diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/map_controller.rb b/app/controllers/map_controller.rb index abc1234..def5678 100644 --- a/app/controllers/map_controller.rb +++ b/app/controllers/map_controller.rb @@ -1,6 +1,6 @@ class MapController < ApplicationController def index - @current_trends = Trend.most_popular + @curren...
Change trend count on page to 30 instead of 10
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,4 +1,10 @@ module ApplicationHelper + class MarkdownHTML < Redcarpet::Render::HTML + def header(text, level) + s...
Add linkable headings to markdown
diff --git a/app/helpers/project_nav_helper.rb b/app/helpers/project_nav_helper.rb index abc1234..def5678 100644 --- a/app/helpers/project_nav_helper.rb +++ b/app/helpers/project_nav_helper.rb @@ -1,6 +1,6 @@ module ProjectNavHelper - def next_project_id project + def next_project_id(project) return if is_last...
Fix code style (parenthesized method arguments)
diff --git a/config/initializers/devise_custom_flash_messages.rb b/config/initializers/devise_custom_flash_messages.rb index abc1234..def5678 100644 --- a/config/initializers/devise_custom_flash_messages.rb +++ b/config/initializers/devise_custom_flash_messages.rb @@ -11,7 +11,7 @@ if kind == :signed_up || (kind ==...
Fix devise custom flash messages
diff --git a/app/mailers/application_mailer.rb b/app/mailers/application_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/application_mailer.rb +++ b/app/mailers/application_mailer.rb @@ -1,4 +1,5 @@ class ApplicationMailer < ActionMailer::Base - default from: ENV["MAILER_FROM"] || "no-reply@queens-awards-ent...
Add a reply_to field for the helpdesk email
diff --git a/app/mailers/application_mailer.rb b/app/mailers/application_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/application_mailer.rb +++ b/app/mailers/application_mailer.rb @@ -1,4 +1,4 @@ class ApplicationMailer < ActionMailer::Base - default from: "support@gadz.org" + default from: "emails@gadz....
Change mailer from address Jira GORGMAIL-227
diff --git a/app/models/survey_response_map.rb b/app/models/survey_response_map.rb index abc1234..def5678 100644 --- a/app/models/survey_response_map.rb +++ b/app/models/survey_response_map.rb @@ -1,7 +1,7 @@ # this class has 2 sub-classes: CourseSurveyResponseMap and AssignmentSurveyResponseMap # The reviewed_object ...
Fix a mistake in the comment.
diff --git a/boot/fancy_ext.rb b/boot/fancy_ext.rb index abc1234..def5678 100644 --- a/boot/fancy_ext.rb +++ b/boot/fancy_ext.rb @@ -16,3 +16,12 @@ require base + "delegator" require base + "symbol" require base + "array" + +unless Rubinius::VERSION =~ /^1\./ + begin + Rubinius::Compiler = Rubinius::ToolSet.curr...
Revert "cleanup: rely on rubinius-compiler gem" This reverts commit 03e3c6294bd59882e925775918bedfbe05fe52ed.
diff --git a/app/lib/exceptions.rb b/app/lib/exceptions.rb index abc1234..def5678 100644 --- a/app/lib/exceptions.rb +++ b/app/lib/exceptions.rb @@ -9,4 +9,6 @@ end class CanvasApiTokenRequired < LMS::Canvas::CanvasException end + class UnAuthorizedGraphQLCanvasRequest < GraphQL::ExecutionError + end end
fix: Add definition for custom exception class In `app/controllers/api/graphql_controller.rb` on line 24, we raise an `Exceptions::UnAuthorizedGraphQLCanvasRequest` error. However, this exception class isn't defined.
diff --git a/lib/codeclimate_ci/get_gpa.rb b/lib/codeclimate_ci/get_gpa.rb index abc1234..def5678 100644 --- a/lib/codeclimate_ci/get_gpa.rb +++ b/lib/codeclimate_ci/get_gpa.rb @@ -1,5 +1,3 @@-require 'timeout' - module CodeclimateCi class GetGpa RETRY_COUNT = ENV['RETRY_COUNT'] || 3
Remove unnecessary timeout requiring from GetGpa
diff --git a/app/models/ability.rb b/app/models/ability.rb index abc1234..def5678 100644 --- a/app/models/ability.rb +++ b/app/models/ability.rb @@ -10,8 +10,9 @@ can :manage, User, id: user.id can :manage, Authentication, user_id: user.id - if user.is_curator? && defined? RailsAdmin - + if user.is_cur...
Create the responsibility for the curation
diff --git a/lib/docker-provider/plugin.rb b/lib/docker-provider/plugin.rb index abc1234..def5678 100644 --- a/lib/docker-provider/plugin.rb +++ b/lib/docker-provider/plugin.rb @@ -1,7 +1,7 @@ # TODO: Switch to Vagrant.require_version before 1.0.0 # see: https://github.com/mitchellh/vagrant/blob/bc55081e9ffaa682...
Copy & paste is evil
diff --git a/bucketkit.gemspec b/bucketkit.gemspec index abc1234..def5678 100644 --- a/bucketkit.gemspec +++ b/bucketkit.gemspec @@ -19,6 +19,6 @@ spec.add_development_dependency 'bundler', '~> 1.5' spec.add_development_dependency 'rake' - spec.add_dependency 'sawyer', '~> 0.5.4' - spec.add_dependency 'faraday...
Modify gemspec to prepare for publishing.
diff --git a/lib/magick/functions/effects.rb b/lib/magick/functions/effects.rb index abc1234..def5678 100644 --- a/lib/magick/functions/effects.rb +++ b/lib/magick/functions/effects.rb @@ -5,16 +5,39 @@ module Effects extend self - # Lowers the intensity of a color, by lowering its alpha by a given - ...
Add 'brightness' effect (borrowed from CamanJS).
diff --git a/gem-search.gemspec b/gem-search.gemspec index abc1234..def5678 100644 --- a/gem-search.gemspec +++ b/gem-search.gemspec @@ -18,7 +18,7 @@ gem.add_dependency 'json', '~>1.8.1' gem.add_development_dependency 'webmock', '~>1.17.4' - gem.add_development_dependency 'rake' + gem.add_development_dependen...
Remove rake version becaouse 0.9.2 is out of date
diff --git a/lib/cc/engine/analyzers/php/main.rb b/lib/cc/engine/analyzers/php/main.rb index abc1234..def5678 100644 --- a/lib/cc/engine/analyzers/php/main.rb +++ b/lib/cc/engine/analyzers/php/main.rb @@ -14,7 +14,7 @@ "**/*.inc", "**/*.module" ] - DEFAULT_MASS_THRESHOLD = 1...
Move PHP default threshold to 28 When analyzing the WordPress project at the current default mass threshold of 10, it was observed that Duplications found only by Platform had masses of 27 or less, while Duplications found by both Platform and Classic had masses of 28 or greater. Note: there were no Duplications found...
diff --git a/example/config.ru b/example/config.ru index abc1234..def5678 100644 --- a/example/config.ru +++ b/example/config.ru @@ -1,5 +1,7 @@ require 'bundler' Bundler.require +$stdout.sync = true + use Rack::HTTPLogger run lambda { [404, {'Content-Type' => 'text/html'}, ['Page Not Found']] }
Set .sync to true, so notifications are logged in development
diff --git a/lib/auto_html/filters/flickr.rb b/lib/auto_html/filters/flickr.rb index abc1234..def5678 100644 --- a/lib/auto_html/filters/flickr.rb +++ b/lib/auto_html/filters/flickr.rb @@ -9,7 +9,7 @@ params = { :url => match, :format => "json" } [:maxwidth, :maxheight].each { |p| params[p] = options[p] unless...
Use https for Flickr oembed API
diff --git a/test/controllers/aliases_controller_test.rb b/test/controllers/aliases_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/aliases_controller_test.rb +++ b/test/controllers/aliases_controller_test.rb @@ -1,3 +1,4 @@+# Encoding: utf-8 require 'test_helper' class AliasesControllerTest...
Clean up alias test script
diff --git a/formulate.gemspec b/formulate.gemspec index abc1234..def5678 100644 --- a/formulate.gemspec +++ b/formulate.gemspec @@ -9,11 +9,11 @@ gem.required_ruby_version = '>= 1.9' - gem.add_dependency 'actionpack', '>= 3.0' - gem.add_dependency 'activesupport', '>= 3.0' + gem.add_dependency 'actionpack', '...
Switch to pessimistic version constraints.
diff --git a/test/integrations/views_integration_test.rb b/test/integrations/views_integration_test.rb index abc1234..def5678 100644 --- a/test/integrations/views_integration_test.rb +++ b/test/integrations/views_integration_test.rb @@ -19,6 +19,11 @@ get @errdo.error_path(Errdo::Error.last) assert_respons...
Add test for error occurrence selecting on error page
diff --git a/features/step_definitions/save_occupations_steps.rb b/features/step_definitions/save_occupations_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/save_occupations_steps.rb +++ b/features/step_definitions/save_occupations_steps.rb @@ -12,7 +12,7 @@ end Then(/^I should see a confirma...
Change what should be changed to protect the innocent
diff --git a/lib/booking_requests/api.rb b/lib/booking_requests/api.rb index abc1234..def5678 100644 --- a/lib/booking_requests/api.rb +++ b/lib/booking_requests/api.rb @@ -24,11 +24,11 @@ end def open_timeout - ENV.fetch('BOOKING_REQUESTS_API_OPEN_TIMEOUT', 10) + ENV.fetch('BOOKING_REQUESTS_API_OP...
Drop timeouts to sane defaults
diff --git a/lib/date-parser/datetime.rb b/lib/date-parser/datetime.rb index abc1234..def5678 100644 --- a/lib/date-parser/datetime.rb +++ b/lib/date-parser/datetime.rb @@ -14,7 +14,7 @@ date = Date.new(date) return if date.nil? - if time =~ /^(0[0-9]|1[0-9]|2[0-4])[\.\:]?([0-5][0-9])([\.\:]?(...
Add support for named timezones
diff --git a/kitchen-tests/cookbooks/end_to_end/recipes/_snap.rb b/kitchen-tests/cookbooks/end_to_end/recipes/_snap.rb index abc1234..def5678 100644 --- a/kitchen-tests/cookbooks/end_to_end/recipes/_snap.rb +++ b/kitchen-tests/cookbooks/end_to_end/recipes/_snap.rb @@ -36,4 +36,4 @@ action :remove end -snap_package...
Fix lint issue in snap test Signed-off-by: Gene Wood <554b3cd6285944658d6dcd5ab0d58c8e35cd6701@cementhorizon.com>
diff --git a/lib/dotter/configuration.rb b/lib/dotter/configuration.rb index abc1234..def5678 100644 --- a/lib/dotter/configuration.rb +++ b/lib/dotter/configuration.rb @@ -35,5 +35,10 @@ package_conf['public'] = false self.save() end + def set_type(package, type) + package_conf = self.package_config(packa...
Add method for setting the type of a package in the config. This will be used for importing repositories as packages.
diff --git a/features/steps/project/builds/summary.rb b/features/steps/project/builds/summary.rb index abc1234..def5678 100644 --- a/features/steps/project/builds/summary.rb +++ b/features/steps/project/builds/summary.rb @@ -13,7 +13,7 @@ end step 'I see button to CI Lint' do - page.within('.controls') do + ...
Update test after changes build page css Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/features/support/app_life_cycle_hooks.rb b/features/support/app_life_cycle_hooks.rb index abc1234..def5678 100644 --- a/features/support/app_life_cycle_hooks.rb +++ b/features/support/app_life_cycle_hooks.rb @@ -7,7 +7,7 @@ After do |scenario| if scenario.failed? - screenshot_embed + #screenshot...
Disable screenshots when calabash tests fail to increase speed of test run
diff --git a/lib/fog/aws/requests/storage/get_bucket_location.rb b/lib/fog/aws/requests/storage/get_bucket_location.rb index abc1234..def5678 100644 --- a/lib/fog/aws/requests/storage/get_bucket_location.rb +++ b/lib/fog/aws/requests/storage/get_bucket_location.rb @@ -12,7 +12,7 @@ # * body [Hash]: #...
Use host for get bucket location operation
diff --git a/lib/patches/ruport_patch.rb b/lib/patches/ruport_patch.rb index abc1234..def5678 100644 --- a/lib/patches/ruport_patch.rb +++ b/lib/patches/ruport_patch.rb @@ -6,36 +6,9 @@ module Ruport::Data class Table def sort_rows_by(col_names = nil, options = {}, &block) - # stabilizer is needed because ...
Use stable_sort_by from more_core_extensions repo in Ruport::Data::Table
diff --git a/adapters/sinatra_adapter.rb b/adapters/sinatra_adapter.rb index abc1234..def5678 100644 --- a/adapters/sinatra_adapter.rb +++ b/adapters/sinatra_adapter.rb @@ -4,6 +4,10 @@ extend Forwardable def initialize(sinatra_app) @sinatra_app = sinatra_app + end + + def params + sinatra_app.request.pa...
Remove junk params added by Sinatra
diff --git a/lib/fotoramajs.rb b/lib/fotoramajs.rb index abc1234..def5678 100644 --- a/lib/fotoramajs.rb +++ b/lib/fotoramajs.rb @@ -2,7 +2,9 @@ module Fotoramajs class Railtie < Rails::Railtie initializer 'fotorama.config' do |app| - app.config.assets.precompile += ['fotorama.png', 'fotorama@2x.png'] + ...
Add pngs to precompile only in Rails 4
diff --git a/lib/stash_merge_executor.rb b/lib/stash_merge_executor.rb index abc1234..def5678 100644 --- a/lib/stash_merge_executor.rb +++ b/lib/stash_merge_executor.rb @@ -30,7 +30,7 @@ begin Rails.logger.info("Trying to delete branch using Stash REST api") remote_server.delete_branch(@build.branch) ...
Remove minor bug in delete branch
diff --git a/lib/accounting/core_ext/rounding.rb b/lib/accounting/core_ext/rounding.rb index abc1234..def5678 100644 --- a/lib/accounting/core_ext/rounding.rb +++ b/lib/accounting/core_ext/rounding.rb @@ -15,6 +15,18 @@ end end end + + module BigDecimal + module Rounding + def cur...
Use CoreExtention Rounding based on BigDecimal.
diff --git a/lib/custodian/samplers/linux/ram.rb b/lib/custodian/samplers/linux/ram.rb index abc1234..def5678 100644 --- a/lib/custodian/samplers/linux/ram.rb +++ b/lib/custodian/samplers/linux/ram.rb @@ -0,0 +1,21 @@+module Custodian + module Samplers + + class RAM < Custodian::Samplers::Sampler + describe "R...
Add RAM sampler for Linux
diff --git a/app/models/post_searcher.rb b/app/models/post_searcher.rb index abc1234..def5678 100644 --- a/app/models/post_searcher.rb +++ b/app/models/post_searcher.rb @@ -0,0 +1,25 @@+class PostSearcher + def initialize + @posts = Groonga['Posts'] + end + + def related_post_ids(post, limit: 5) + related_post...
Implement related posts by Groonga
diff --git a/lib/market_bot.rb b/lib/market_bot.rb index abc1234..def5678 100644 --- a/lib/market_bot.rb +++ b/lib/market_bot.rb @@ -1,4 +1,5 @@ require 'uri' +require 'cgi' require 'typhoeus' require 'nokogiri'
Add missing require for 'cgi'
diff --git a/spec/jobs/submission_job_spec.rb b/spec/jobs/submission_job_spec.rb index abc1234..def5678 100644 --- a/spec/jobs/submission_job_spec.rb +++ b/spec/jobs/submission_job_spec.rb @@ -0,0 +1,18 @@+require "rails_helper" + +RSpec.describe SubmissionJob, type: :job do + include ActiveJob::TestHelper + + let(:a...
Add specs for submission job
diff --git a/lib/gitlab/backend/grack_helpers.rb b/lib/gitlab/backend/grack_helpers.rb index abc1234..def5678 100644 --- a/lib/gitlab/backend/grack_helpers.rb +++ b/lib/gitlab/backend/grack_helpers.rb @@ -1,7 +1,7 @@ module Grack module Helpers def project_by_path(path) - if m = /^\/([\w\.\/-]+)\.git/.matc...
Fix project lookup for git over http + rails4 Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/lib/nehm/commands/select_command.rb b/lib/nehm/commands/select_command.rb index abc1234..def5678 100644 --- a/lib/nehm/commands/select_command.rb +++ b/lib/nehm/commands/select_command.rb @@ -34,6 +34,7 @@ end def usage + "#{program_name} ARGUMENT [OPTIONS]" end protected
Add usage to 'select' command
diff --git a/lib/paper_trail_scrapbook/config.rb b/lib/paper_trail_scrapbook/config.rb index abc1234..def5678 100644 --- a/lib/paper_trail_scrapbook/config.rb +++ b/lib/paper_trail_scrapbook/config.rb @@ -20,6 +20,7 @@ :scrub_columns, :drop_id_suffix, :unknown_who...
Set @invalid_whodunnit and define getter/setter for it
diff --git a/lib/noyes_java.rb b/lib/noyes_java.rb index abc1234..def5678 100644 --- a/lib/noyes_java.rb +++ b/lib/noyes_java.rb @@ -14,3 +14,8 @@ require 'java_impl/bent_cent_marker' require 'java_impl/speech_trimmer' require 'noyes.jar' + +# The NoyesJava module encapsulates the Java implementation of the Noyes +# ...
Add some overview documentation for the NoyesJava module.
diff --git a/lib/travis/sidekiq/build_request.rb b/lib/travis/sidekiq/build_request.rb index abc1234..def5678 100644 --- a/lib/travis/sidekiq/build_request.rb +++ b/lib/travis/sidekiq/build_request.rb @@ -1,5 +1,4 @@ require 'sidekiq/worker' -require 'travis/services/requests/receive' module Travis module Sidekiq...
Remove direct require for now. Have to figure out how to deal with these circular dependencies better. For now, it relies on the file being loaded by gatekeeper.
diff --git a/lib/vcr/util/internet_connection.rb b/lib/vcr/util/internet_connection.rb index abc1234..def5678 100644 --- a/lib/vcr/util/internet_connection.rb +++ b/lib/vcr/util/internet_connection.rb @@ -13,7 +13,7 @@ module Ping def pingecho(host, timeout=5, service="echo") begin - timeou...
Fix Ruby 2.3 deprecation, timeout=>Timeout.timeout
diff --git a/app/helpers/feeds_helper.rb b/app/helpers/feeds_helper.rb index abc1234..def5678 100644 --- a/app/helpers/feeds_helper.rb +++ b/app/helpers/feeds_helper.rb @@ -1,2 +1,5 @@ module FeedsHelper + def prayer_request_path(prayer_request) + group_prayer_request_path(prayer_request.group, prayer_request) + e...
Fix bug showing Prayer Request in activity feed.
diff --git a/app/jobs/get_top_ten_job.rb b/app/jobs/get_top_ten_job.rb index abc1234..def5678 100644 --- a/app/jobs/get_top_ten_job.rb +++ b/app/jobs/get_top_ten_job.rb @@ -1,11 +1,11 @@ class GetTopTenJob < ActiveJob::Base - after_perform do |job| + after_perform do GetTopTenJob.set(wait: 5.minute).perform_late...
Refactor Get Top Ten job
diff --git a/app/models/build/convert.rb b/app/models/build/convert.rb index abc1234..def5678 100644 --- a/app/models/build/convert.rb +++ b/app/models/build/convert.rb @@ -1,63 +1,43 @@ module Build - module Convert - def convert!(opts = {}, &block) - Rails.logger.tagged("build") do - @opts = opts + m...
Remove mutation variables from Convert
diff --git a/lib/rails_config/integration/rails.rb b/lib/rails_config/integration/rails.rb index abc1234..def5678 100644 --- a/lib/rails_config/integration/rails.rb +++ b/lib/rails_config/integration/rails.rb @@ -11,7 +11,7 @@ end # Parse the settings before any of the initializers - Act...
Load files only after requiring initializer
diff --git a/lib/safe_yaml/transform/to_integer.rb b/lib/safe_yaml/transform/to_integer.rb index abc1234..def5678 100644 --- a/lib/safe_yaml/transform/to_integer.rb +++ b/lib/safe_yaml/transform/to_integer.rb @@ -9,7 +9,8 @@ ]) def transform?(value) - MATCHERS.each do |matcher| + MATCHERS.e...
[bugfix] Substitute _ for decimal values
diff --git a/lib/tasks/copy_taxon_title.rake b/lib/tasks/copy_taxon_title.rake index abc1234..def5678 100644 --- a/lib/tasks/copy_taxon_title.rake +++ b/lib/tasks/copy_taxon_title.rake @@ -4,8 +4,12 @@ taxons = RemoteTaxons.new.search(per_page: total).taxons taxons.each do |taxon| - next unless taxon.internal...
Make sure we update existing taxons' internal name The Publishing API returns both a details hash containing the internal name, and an internal name field in the content item. We use the latter throughout the code base. The behaviour on the publishing API is as follows: if there is an internal name in the details ha...
diff --git a/lib/tasks/cpi.rake b/lib/tasks/cpi.rake index abc1234..def5678 100644 --- a/lib/tasks/cpi.rake +++ b/lib/tasks/cpi.rake @@ -0,0 +1,38 @@+# rubocop:disable Metrics/BlockLength + +namespace :cpi do + desc "Import OpenStack Cloud Proivider options" + task :openstack, [:config] => :environment do |_, args| +...
Add rake task to import CPI config
diff --git a/lib/tasks/job.rake b/lib/tasks/job.rake index abc1234..def5678 100644 --- a/lib/tasks/job.rake +++ b/lib/tasks/job.rake @@ -2,7 +2,7 @@ namespace :job do ruby_exec = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['ruby_install_name']) - job_controller = "#{Rails.root}/script/daemons/job_task_...
Use Rails.root.join instead of string concatenation.
diff --git a/lib/arel/algebra/core_extensions/object.rb b/lib/arel/algebra/core_extensions/object.rb index abc1234..def5678 100644 --- a/lib/arel/algebra/core_extensions/object.rb +++ b/lib/arel/algebra/core_extensions/object.rb @@ -12,19 +12,6 @@ yield(self) end - # TODO remove this when ActiveSupport ...
Remove unnecessary code since AS beta1 is out.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -7,7 +7,6 @@ require "action_mailer/railtie" require "action_view/railtie" require "sprockets/railtie" -# require "rails/test_unit/railtie" # Require the gems listed i...
Set configs for heroku to compile assets. According to heroku, Rails 4 dont serve my assets :eyes:
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -21,11 +21,6 @@ config.middleware.use OmniAuth::Builder do provider :github, ENV['GITHUB_APP_ID'], ENV['GITHUB_SECRET'], - client_options: { - ...
Simplify OAuth setup - unlikely that we'll need to handle GitHub Enterprise again.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -31,7 +31,7 @@ provider :developer unless Rails.env.production? provider :github, ENV['GITHUB_CLIENT_ID'], ENV['GITHUB_CLIENT_SECRET'], request_path: ...
Add email permission to github
diff --git a/Library/Homebrew/cmd/--cellar.rb b/Library/Homebrew/cmd/--cellar.rb index abc1234..def5678 100644 --- a/Library/Homebrew/cmd/--cellar.rb +++ b/Library/Homebrew/cmd/--cellar.rb @@ -3,7 +3,7 @@ if ARGV.named.empty? puts HOMEBREW_CELLAR else - puts ARGV.formulae.map{ |f| HOMEBREW_CELLAR+f...
Use rack accessor instead of building pathname manually
diff --git a/core/app/models/spree/return_item/exchange_variant_eligibility/same_product.rb b/core/app/models/spree/return_item/exchange_variant_eligibility/same_product.rb index abc1234..def5678 100644 --- a/core/app/models/spree/return_item/exchange_variant_eligibility/same_product.rb +++ b/core/app/models/spree/retu...
Make same product eligible variants DRY.
diff --git a/lib/goblin/sheet.rb b/lib/goblin/sheet.rb index abc1234..def5678 100644 --- a/lib/goblin/sheet.rb +++ b/lib/goblin/sheet.rb @@ -31,14 +31,14 @@ def each @cells.each do |rows| rows.each do |cell| - yield Goblin::Cell.new(cell) + yield cell end end e...
Change @cells elements from Nokogiri::NodeSet to Goblin::Cell in Goblin::Sheet
diff --git a/lib/lita/handler.rb b/lib/lita/handler.rb index abc1234..def5678 100644 --- a/lib/lita/handler.rb +++ b/lib/lita/handler.rb @@ -23,7 +23,7 @@ @routes.each do |route| if route_applies?(route, instance) instance.public_send( - route[:method_name], + r...
Use method syntax for accessing struct attributes.
diff --git a/lib/munge/system.rb b/lib/munge/system.rb index abc1234..def5678 100644 --- a/lib/munge/system.rb +++ b/lib/munge/system.rb @@ -5,20 +5,22 @@ @config = config end + def item_factory + @item_factory ||= + ItemFactory.new( + text_extensions: @config[:items_text_extensions...
Use only one ItemFactory for both items and layouts
diff --git a/lib/tasks/cron.rake b/lib/tasks/cron.rake index abc1234..def5678 100644 --- a/lib/tasks/cron.rake +++ b/lib/tasks/cron.rake @@ -10,6 +10,6 @@ end task refresh_users: :environment do - User.refresh_shard(Time.now.hour % 6, 6) + User.refresh_shard(Time.now.hour % 24, 24) end end
Refresh user profiles less often
diff --git a/motion/spree.rb b/motion/spree.rb index abc1234..def5678 100644 --- a/motion/spree.rb +++ b/motion/spree.rb @@ -10,18 +10,8 @@ # Spree::API::Zone # module Spree - # - # Getter for the endpoint URL - # - def self.endpoint - @endpoint - end - - # - # Setter for the endpoint URL - # - def self.e...
Use Ruby idioms to create the Spree module accessors for endpoint
diff --git a/app/controllers/active_waiter/jobs_controller.rb b/app/controllers/active_waiter/jobs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/active_waiter/jobs_controller.rb +++ b/app/controllers/active_waiter/jobs_controller.rb @@ -3,6 +3,7 @@ module ActiveWaiter class JobsController < Appli...
Fix instance varialble not initialize warning
diff --git a/app/presenters/assertion_browse_row_presenter.rb b/app/presenters/assertion_browse_row_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/assertion_browse_row_presenter.rb +++ b/app/presenters/assertion_browse_row_presenter.rb @@ -8,7 +8,7 @@ id: @assertion.id, gene_name: @asserti...
Fix disease field in AssertionBrowseRowPresenter
diff --git a/app/services/sms_broker/incoming_message_hook.rb b/app/services/sms_broker/incoming_message_hook.rb index abc1234..def5678 100644 --- a/app/services/sms_broker/incoming_message_hook.rb +++ b/app/services/sms_broker/incoming_message_hook.rb @@ -6,6 +6,7 @@ # This method should be overriden # d...
Raise error if IncomingMessageHook not overridden
diff --git a/spec/views/ops/_rbac_user_details.html.haml_spec.rb b/spec/views/ops/_rbac_user_details.html.haml_spec.rb index abc1234..def5678 100644 --- a/spec/views/ops/_rbac_user_details.html.haml_spec.rb +++ b/spec/views/ops/_rbac_user_details.html.haml_spec.rb @@ -0,0 +1,19 @@+describe 'ops/_rbac_user_details.html....
Add test for user edit form to test Full Name field
diff --git a/spec/features/author_creation_spec.rb b/spec/features/author_creation_spec.rb index abc1234..def5678 100644 --- a/spec/features/author_creation_spec.rb +++ b/spec/features/author_creation_spec.rb @@ -1,5 +1,5 @@-require "spec_helper" -feature "Creating Authors" do +require 'rails_helper' +feature 'Creating...
Swap spec helper for correct one
diff --git a/LUFontIconControls.podspec b/LUFontIconControls.podspec index abc1234..def5678 100644 --- a/LUFontIconControls.podspec +++ b/LUFontIconControls.podspec @@ -6,7 +6,7 @@ s.summary = 'Easy way to use icon fonts to replace images in your iOS app.' s.homepage = 'https://github.com/rjyo/LUFontIconControls'...
Change podspec to specify the version
diff --git a/app/controllers/api/v1/stories_controller.rb b/app/controllers/api/v1/stories_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/stories_controller.rb +++ b/app/controllers/api/v1/stories_controller.rb @@ -2,12 +2,28 @@ module V1 class StoriesController < ApiController d...
Add filtering logic to stories controller
diff --git a/app/controllers/authorizations_controller.rb b/app/controllers/authorizations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/authorizations_controller.rb +++ b/app/controllers/authorizations_controller.rb @@ -8,8 +8,8 @@ u.username = auth_hash["info"]["nickname"] end ...
fix: Access token is in different place
diff --git a/app/models/concerns/find_or_create_locked.rb b/app/models/concerns/find_or_create_locked.rb index abc1234..def5678 100644 --- a/app/models/concerns/find_or_create_locked.rb +++ b/app/models/concerns/find_or_create_locked.rb @@ -16,7 +16,7 @@ # SELECT would succeed. # So if this actually th...
Raise an error if retries are exhausted This code would have accidentally been concealing errors.
diff --git a/google-spreadsheet-ruby.gemspec b/google-spreadsheet-ruby.gemspec index abc1234..def5678 100644 --- a/google-spreadsheet-ruby.gemspec +++ b/google-spreadsheet-ruby.gemspec @@ -18,5 +18,6 @@ s.add_dependency("nokogiri", [">= 1.4.4", "< 1.5.1"]) s.add_dependency("oauth", [">= 0.3.6"]) s.add_dependenc...
Add development dependency rake for bundle exec rake test
diff --git a/install.rb b/install.rb index abc1234..def5678 100644 --- a/install.rb +++ b/install.rb @@ -56,5 +56,11 @@ puts "" puts "===========================================================================" +puts "" +puts " Check that the plugin is installed correctly using:" +puts "" +puts " rake postage:te...
Include mention of rake tasks in welcome message
diff --git a/pakyow-presenter/lib/presenter/bindings.rb b/pakyow-presenter/lib/presenter/bindings.rb index abc1234..def5678 100644 --- a/pakyow-presenter/lib/presenter/bindings.rb +++ b/pakyow-presenter/lib/presenter/bindings.rb @@ -18,7 +18,7 @@ end def value_for_prop(prop) - return unless bindin...
Fix nil value bug when no binding for prop
diff --git a/test/api/teaching_period_test.rb b/test/api/teaching_period_test.rb index abc1234..def5678 100644 --- a/test/api/teaching_period_test.rb +++ b/test/api/teaching_period_test.rb @@ -14,9 +14,42 @@ get '/api/teaching_periods' expected_data = TeachingPeriod.all - puts last_response_body + asse...
TEST: Add checks to get teaching and update breaks
diff --git a/rails/app/models/policy_division.rb b/rails/app/models/policy_division.rb index abc1234..def5678 100644 --- a/rails/app/models/policy_division.rb +++ b/rails/app/models/policy_division.rb @@ -8,10 +8,6 @@ delegate :name, :australian_house, :australian_house_name, to: :division def division - divi...
Use a much simpler way of finding the division
diff --git a/lib/actionmailer_with_request.rb b/lib/actionmailer_with_request.rb index abc1234..def5678 100644 --- a/lib/actionmailer_with_request.rb +++ b/lib/actionmailer_with_request.rb @@ -17,7 +17,7 @@ module MailerDefaultUrlOptions def self.included(base) - base.class_eval do + base.class_eval ...
Use a String for better performance
diff --git a/SwiftDecimalNumber.podspec b/SwiftDecimalNumber.podspec index abc1234..def5678 100644 --- a/SwiftDecimalNumber.podspec +++ b/SwiftDecimalNumber.podspec @@ -25,6 +25,6 @@ s.platform = :ios, '9.2' - s.source_files = ['Package.swift', 'Sources/**/*.swift'] + s.source_files = 'Sources/**/*.swift' en...
Remove SPM Package file from Cocoapod sources
diff --git a/thread_local.gemspec b/thread_local.gemspec index abc1234..def5678 100644 --- a/thread_local.gemspec +++ b/thread_local.gemspec @@ -8,9 +8,9 @@ spec.version = ThreadLocal::VERSION spec.authors = ["Yusuke KUOKA"] spec.email = ["yusuke.kuoka@crowdworks.co.jp"] - spec.summary ...
Update gemspec to allow releasing it ti rubygems.org
diff --git a/lib/blimp/sources/disk_source.rb b/lib/blimp/sources/disk_source.rb index abc1234..def5678 100644 --- a/lib/blimp/sources/disk_source.rb +++ b/lib/blimp/sources/disk_source.rb @@ -8,15 +8,15 @@ end def get_file(path) - raise SourceFile::NotFound if hidden?(path) + raise SourceF...
Raise with path, so we can see whats going wrong
diff --git a/lib/gov_kit/transparency_data.rb b/lib/gov_kit/transparency_data.rb index abc1234..def5678 100644 --- a/lib/gov_kit/transparency_data.rb +++ b/lib/gov_kit/transparency_data.rb @@ -0,0 +1,18 @@+module GovKit + class TransparencyDataResource < Resource + default_params :apikey => GovKit::configuration.su...
Add TransparencyData API Campaign Contributions support
diff --git a/lib/letsencrypt/configuration.rb b/lib/letsencrypt/configuration.rb index abc1234..def5678 100644 --- a/lib/letsencrypt/configuration.rb +++ b/lib/letsencrypt/configuration.rb @@ -16,6 +16,10 @@ config_accessor :save_to_redis config_accessor :redis_url + config_accessor :certificate_model do ...
Add certificate_model for user to customize model
diff --git a/lib/liquid/pagination_filters.rb b/lib/liquid/pagination_filters.rb index abc1234..def5678 100644 --- a/lib/liquid/pagination_filters.rb +++ b/lib/liquid/pagination_filters.rb @@ -5,7 +5,9 @@ def paginate(pagination_info) pagination_html = "" if pagination_info.is_a?(Hash) && (pagination_...
Add pagination div to filter.
diff --git a/lib/nrser/core_ext/enumerable.rb b/lib/nrser/core_ext/enumerable.rb index abc1234..def5678 100644 --- a/lib/nrser/core_ext/enumerable.rb +++ b/lib/nrser/core_ext/enumerable.rb @@ -1,3 +1,4 @@+require 'nrser/functions/enumerable/associate' require_relative './enumerable/find_map'
Add a missing dep req
diff --git a/lib/nikeplusgem/activity_data.rb b/lib/nikeplusgem/activity_data.rb index abc1234..def5678 100644 --- a/lib/nikeplusgem/activity_data.rb +++ b/lib/nikeplusgem/activity_data.rb @@ -1,14 +1,14 @@ module NikePlusGem class Client - ACTIVITY_DATA = [] + ACTIVITY_DATA = ["activityId"] def activ...
Fix issue in Activity Data endpoint. - Must include the required activityId parameter. - Append the activity_id value instead of the required params.
diff --git a/lib/thincloud/postmark/engine.rb b/lib/thincloud/postmark/engine.rb index abc1234..def5678 100644 --- a/lib/thincloud/postmark/engine.rb +++ b/lib/thincloud/postmark/engine.rb @@ -17,15 +17,8 @@ config.thincloud.postmark ||= Thincloud::Postmark.configure end - # Require the config ini...
Use different hook for action_mailer config By using the `after: "finisher_hook"` we are alleviated from the specific load order of the initializers. ActionMailer allows the addition of delivery methods at any point during app execution as long as it's there before you send mail. Now we can lose the specific initial...
diff --git a/lib/plotly/offline/exportable.rb b/lib/plotly/offline/exportable.rb index abc1234..def5678 100644 --- a/lib/plotly/offline/exportable.rb +++ b/lib/plotly/offline/exportable.rb @@ -20,6 +20,11 @@ Launchy.open(File.absolute_path(path)) if open end + def to_html + html = create_ht...
Add feature to generate embeddable html string
diff --git a/lib/rubocop/cop/lint/debugger.rb b/lib/rubocop/cop/lint/debugger.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/lint/debugger.rb +++ b/lib/rubocop/cop/lint/debugger.rb @@ -7,14 +7,15 @@ class Debugger < Cop MSG = 'Remove debugger entry point `%s`.' - def_node_matcher :debugg...
Adjust formatting of NodePattern in Lint/Debugger I find that using multiline strings to keep the node patterns on separate lines from Ruby code makes them read better.
diff --git a/db/migrate/20140626080142_create_contacts.rb b/db/migrate/20140626080142_create_contacts.rb index abc1234..def5678 100644 --- a/db/migrate/20140626080142_create_contacts.rb +++ b/db/migrate/20140626080142_create_contacts.rb @@ -2,8 +2,8 @@ def change create_table :contacts do |t| t.string :em...
Add unique index to contacts email
diff --git a/search-engine/lib/ban_list/pioneer.rb b/search-engine/lib/ban_list/pioneer.rb index abc1234..def5678 100644 --- a/search-engine/lib/ban_list/pioneer.rb +++ b/search-engine/lib/ban_list/pioneer.rb @@ -7,4 +7,12 @@ "Windswept Heath" => "banned", "Wooded Foothills" => "banned", ) + + change( + ...
Add yesterday's Pioneer B&R changes
diff --git a/test/integration/sign_in_flow_test.rb b/test/integration/sign_in_flow_test.rb index abc1234..def5678 100644 --- a/test/integration/sign_in_flow_test.rb +++ b/test/integration/sign_in_flow_test.rb @@ -13,22 +13,28 @@ Warden.test_reset! end + def sign_out + visit '/' + within("div#above-heade...
Add new sign in test if browse direct to admin
diff --git a/test/integration/users_signup_test.rb b/test/integration/users_signup_test.rb index abc1234..def5678 100644 --- a/test/integration/users_signup_test.rb +++ b/test/integration/users_signup_test.rb @@ -7,12 +7,25 @@ assert_no_difference 'User.count' do post signup_path, params: { user: { name: ...
Add valid signup information test
diff --git a/app/models/audit.rb b/app/models/audit.rb index abc1234..def5678 100644 --- a/app/models/audit.rb +++ b/app/models/audit.rb @@ -1,6 +1,6 @@ class Audit < Sequel::Model - many_to_one :auditable, reciprocal: :audits, + many_to_one :auditable, reciprocal: :audits, reciprocal_type: :many_to_one, ...
Fix polymorphic association and set version number
diff --git a/app/models/order.rb b/app/models/order.rb index abc1234..def5678 100644 --- a/app/models/order.rb +++ b/app/models/order.rb @@ -17,10 +17,10 @@ :currency_code => 'EUR' } values.merge!({ - "Cena" => 1, - "Ime artikla" => 'Kontakt', - "Št. artikla" => id, - "Koli...
Change back on Order.rb to english and 10eur price
diff --git a/lib/puppet/parser/functions/ldapquery.rb b/lib/puppet/parser/functions/ldapquery.rb index abc1234..def5678 100644 --- a/lib/puppet/parser/functions/ldapquery.rb +++ b/lib/puppet/parser/functions/ldapquery.rb @@ -1,4 +1,4 @@-require 'puppet_x/ldapquery' +require_relative '../../../puppet_x/ldapquery' beg...
Update require for puppet_x to use relative path This work should allow the code to be loaded in the puppetserver.
diff --git a/lib/sequent/core/base_command_handler.rb b/lib/sequent/core/base_command_handler.rb index abc1234..def5678 100644 --- a/lib/sequent/core/base_command_handler.rb +++ b/lib/sequent/core/base_command_handler.rb @@ -27,7 +27,7 @@ end def handles_message?(command) - self.class.message_mapp...
Fix inconsistency; no CommandHandler inheritance
diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/groups_controller_spec.rb +++ b/spec/controllers/groups_controller_spec.rb @@ -0,0 +1,67 @@+require 'rails_helper' + +describe GroupsController do + let(:user) { Fac...
Add a basic test suite for the Groups Controller. Test coverage is currently at 57%. This needs to be improved.
diff --git a/spec/importers/rows/attendance_row_spec.rb b/spec/importers/rows/attendance_row_spec.rb index abc1234..def5678 100644 --- a/spec/importers/rows/attendance_row_spec.rb +++ b/spec/importers/rows/attendance_row_spec.rb @@ -44,10 +44,5 @@ expect { row.build.save! }.not_to change(Tardy, :count) e...
Remove extra attendance row spec
diff --git a/spec/lib/hipaa-crypt/configuration_spec.rb b/spec/lib/hipaa-crypt/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/lib/hipaa-crypt/configuration_spec.rb +++ b/spec/lib/hipaa-crypt/configuration_spec.rb @@ -4,7 +4,7 @@ describe '#extractable_options' do it 'should be true' do - e...
Fix calling instance instead of class method