diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/utils/fsUtils.js b/utils/fsUtils.js index <HASH>..<HASH> 100644 --- a/utils/fsUtils.js +++ b/utils/fsUtils.js @@ -182,4 +182,7 @@ module.exports = { }); }, -}; \ No newline at end of file + exists(path) { + return fs.exists(path); + } +};
Missing fs.exists method
diff --git a/aiomysql/connection.py b/aiomysql/connection.py index <HASH>..<HASH> 100644 --- a/aiomysql/connection.py +++ b/aiomysql/connection.py @@ -658,7 +658,7 @@ class Connection: if PY_341: # pragma: no branch def __del__(self): - if not self._writer: + if self._writer: ...
fix connection __del__ method
diff --git a/catalog/app/utils/tracking.js b/catalog/app/utils/tracking.js index <HASH>..<HASH> 100644 --- a/catalog/app/utils/tracking.js +++ b/catalog/app/utils/tracking.js @@ -17,8 +17,11 @@ export const mkTracker = (token) => { return { nav: (loc, user) => tracker.then((inst) => + // use same distinct_...
use same distinct_id as registry (#<I>)
diff --git a/lib/UniAlteri/States/Loader/FinderStandard.php b/lib/UniAlteri/States/Loader/FinderStandard.php index <HASH>..<HASH> 100644 --- a/lib/UniAlteri/States/Loader/FinderStandard.php +++ b/lib/UniAlteri/States/Loader/FinderStandard.php @@ -112,7 +112,7 @@ class FinderStandard implements FinderInterface ...
remove Error silenced by the at sign (@)
diff --git a/src/main/java/com/brettonw/bag/Serializer.java b/src/main/java/com/brettonw/bag/Serializer.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/brettonw/bag/Serializer.java +++ b/src/main/java/com/brettonw/bag/Serializer.java @@ -214,8 +214,10 @@ public class Serializer { private static Object des...
Use the local object classloader, rather than the system class loader - most likely to be the right namespace - and a quote from an Animals song.
diff --git a/transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java b/transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java index <HASH>..<HASH> 100644 --- a/transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java +++ b/transport/src/main/java/io/netty/channel/pool/SimpleChanne...
Mention correct order in SimplechannelPool javadocs
diff --git a/cherrypy/_cpwsgiserver.py b/cherrypy/_cpwsgiserver.py index <HASH>..<HASH> 100644 --- a/cherrypy/_cpwsgiserver.py +++ b/cherrypy/_cpwsgiserver.py @@ -286,6 +286,8 @@ class CherryPyWSGIServer(object): self.socket.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) self.so...
Fix for #<I> (CherryPyWSGIServer does not always initalize self.socket) in 2.x and trunk.
diff --git a/docs/_static/js/custom.js b/docs/_static/js/custom.js index <HASH>..<HASH> 100644 --- a/docs/_static/js/custom.js +++ b/docs/_static/js/custom.js @@ -20,6 +20,9 @@ window.onload = function () { if (examples_clicked.length == 1) { $(" nav.bd-links ").children().hide() } + + var selecte...
Add a little arrow to selected item in toctree
diff --git a/demo/service_worker.js b/demo/service_worker.js index <HASH>..<HASH> 100644 --- a/demo/service_worker.js +++ b/demo/service_worker.js @@ -15,7 +15,7 @@ * * @const {string} */ -const CACHE_NAME = 'shaka-player-v2.5+'; +const CACHE_NAME = 'shaka-player-v2.6+'; /**
Update service worker cache name In preparation for <I>, update the service worker cache. Old caches will be dropped, which should clean up any extraneous resources cached by the <I> version. Change-Id: Ief<I>ba<I>d<I>e4b<I>f0a<I>a<I>b<I>
diff --git a/pyout.py b/pyout.py index <HASH>..<HASH> 100644 --- a/pyout.py +++ b/pyout.py @@ -552,10 +552,7 @@ class Tabular(object): return self def __exit__(self, *args): - if self._pool is None: - return - self._pool.close() - self._pool.join() + self.wait() ...
RF: Move Tabular.__exit__ code into wait method This gives the caller the flexibility of using the context manager or calling wait directly.
diff --git a/src/meerkat/logs/models.py b/src/meerkat/logs/models.py index <HASH>..<HASH> 100644 --- a/src/meerkat/logs/models.py +++ b/src/meerkat/logs/models.py @@ -380,7 +380,7 @@ class RequestLog(models.Model): force_verb=False, force_protocol=False, ...
Use strict_url False (maybe not pertinent)
diff --git a/lib/terraforming/resource/efs.rb b/lib/terraforming/resource/efs.rb index <HASH>..<HASH> 100644 --- a/lib/terraforming/resource/efs.rb +++ b/lib/terraforming/resource/efs.rb @@ -29,7 +29,7 @@ module Terraforming "tags.Name" => efs.name, } - resources[format('%s',efs.file_...
add comma in format() for second argument.
diff --git a/plugins/Referrers/functions.php b/plugins/Referrers/functions.php index <HASH>..<HASH> 100644 --- a/plugins/Referrers/functions.php +++ b/plugins/Referrers/functions.php @@ -103,10 +103,13 @@ function getSocialsLogoFromUrl($domain) } $pathWithCode = 'plugins/Referrers/images/socials/' ....
only return social image path if that file exists
diff --git a/insteonplm/plm.py b/insteonplm/plm.py index <HASH>..<HASH> 100644 --- a/insteonplm/plm.py +++ b/insteonplm/plm.py @@ -276,7 +276,7 @@ class PLM(asyncio.Protocol): if device is not None: if isinstance(device, list): for currdev in device: - ...
Fixed adding complex devices from ALDB data
diff --git a/src/Api.php b/src/Api.php index <HASH>..<HASH> 100644 --- a/src/Api.php +++ b/src/Api.php @@ -1067,7 +1067,7 @@ class Api * ]; * </code> * - * @deprecated Use Telegram\Bot\Keyboard\Keyboard::make()->hide(array $params = []) instead. + * @deprecated Use Telegram\Bot\Keyboard\Keyboa...
Update Api to match the keyboard changes.
diff --git a/lib/generators/chili/chili_generator.rb b/lib/generators/chili/chili_generator.rb index <HASH>..<HASH> 100644 --- a/lib/generators/chili/chili_generator.rb +++ b/lib/generators/chili/chili_generator.rb @@ -83,7 +83,7 @@ class ChiliGenerator < Rails::Generators::NamedBase def add_dummy_override exam...
Added "namespaced" option to generated overrides.
diff --git a/tools/run_tests/run_xds_tests.py b/tools/run_tests/run_xds_tests.py index <HASH>..<HASH> 100755 --- a/tools/run_tests/run_xds_tests.py +++ b/tools/run_tests/run_xds_tests.py @@ -2595,7 +2595,12 @@ try: client_env['GRPC_XDS_BOOTSTRAP'] = bootstrap_path client_env['GRPC_XDS_EXPERIMENTAL_CIR...
Disable fault injection env var in xds interop tests (#<I>)
diff --git a/lib/adhearsion/call_controller/dial.rb b/lib/adhearsion/call_controller/dial.rb index <HASH>..<HASH> 100644 --- a/lib/adhearsion/call_controller/dial.rb +++ b/lib/adhearsion/call_controller/dial.rb @@ -130,8 +130,9 @@ module Adhearsion if @confirmation_controller status.unco...
[CS] Use a Celluloid condition rather than signals to avoid a potential race condition
diff --git a/activesupport/lib/active_support/dependencies.rb b/activesupport/lib/active_support/dependencies.rb index <HASH>..<HASH> 100644 --- a/activesupport/lib/active_support/dependencies.rb +++ b/activesupport/lib/active_support/dependencies.rb @@ -54,9 +54,6 @@ module ActiveSupport # :nodoc: Dependencies....
Delete AS::Dependencies.loaded
diff --git a/lib/FieldType/XmlText/Type.php b/lib/FieldType/XmlText/Type.php index <HASH>..<HASH> 100644 --- a/lib/FieldType/XmlText/Type.php +++ b/lib/FieldType/XmlText/Type.php @@ -253,7 +253,7 @@ EOF; if ( !is_integer( $value ) ) { $valid...
Moved validator configuration infrastructure to validators, improved error messages a bit
diff --git a/tests/ImageTests.php b/tests/ImageTests.php index <HASH>..<HASH> 100755 --- a/tests/ImageTests.php +++ b/tests/ImageTests.php @@ -202,6 +202,19 @@ class ImageTests extends \PHPUnit_Framework_TestCase } /** + * Testing Gaussian blur filter. + */ + public function testGaussianBlur() { ...
Add a simple test to check that filter is working.
diff --git a/hazelcast-client/src/test/java/com/hazelcast/client/ClientServiceTest.java b/hazelcast-client/src/test/java/com/hazelcast/client/ClientServiceTest.java index <HASH>..<HASH> 100644 --- a/hazelcast-client/src/test/java/com/hazelcast/client/ClientServiceTest.java +++ b/hazelcast-client/src/test/java/com/hazel...
fix testClientListener_withShuttingDownOwnerMember Delay client endpoint removal so that test will not fail in a slow environment. fixes <URL>
diff --git a/src/main/java/org/culturegraph/mf/stream/pipe/CloseSupressor.java b/src/main/java/org/culturegraph/mf/stream/pipe/CloseSupressor.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/culturegraph/mf/stream/pipe/CloseSupressor.java +++ b/src/main/java/org/culturegraph/mf/stream/pipe/CloseSupressor.java @...
fixed broken build. (missing class)
diff --git a/lib/discordrb/webhooks/embeds.rb b/lib/discordrb/webhooks/embeds.rb index <HASH>..<HASH> 100644 --- a/lib/discordrb/webhooks/embeds.rb +++ b/lib/discordrb/webhooks/embeds.rb @@ -105,7 +105,7 @@ module Discordrb::Webhooks title: @title, description: @description, url: @url, - ...
:anchor: Properly convert embed timestamps
diff --git a/aikif/environments/happiness.py b/aikif/environments/happiness.py index <HASH>..<HASH> 100644 --- a/aikif/environments/happiness.py +++ b/aikif/environments/happiness.py @@ -274,13 +274,27 @@ class Person(object): def __init__(self, nme, prefs): self.prefs = prefs self.nme = nme + ...
added values that can be ranked by people
diff --git a/src/main/java/eu/hansolo/tilesfx/skins/SmoothAreaChartTileSkin.java b/src/main/java/eu/hansolo/tilesfx/skins/SmoothAreaChartTileSkin.java index <HASH>..<HASH> 100644 --- a/src/main/java/eu/hansolo/tilesfx/skins/SmoothAreaChartTileSkin.java +++ b/src/main/java/eu/hansolo/tilesfx/skins/SmoothAreaChartTileSki...
Added a null check to avoid problems (thx to Alessandro Roaro for the hint)
diff --git a/mapchete/log.py b/mapchete/log.py index <HASH>..<HASH> 100644 --- a/mapchete/log.py +++ b/mapchete/log.py @@ -99,6 +99,7 @@ def set_log_level(loglevel): def setup_logfile(logfile): file_handler = logging.FileHandler(logfile) file_handler.setFormatter(formatter) + file_handler.addFilter(KeyVal...
add missing secrets filter to logfile output
diff --git a/lib/Core/Search/Solr/Query/Common/QueryConverter.php b/lib/Core/Search/Solr/Query/Common/QueryConverter.php index <HASH>..<HASH> 100644 --- a/lib/Core/Search/Solr/Query/Common/QueryConverter.php +++ b/lib/Core/Search/Solr/Query/Common/QueryConverter.php @@ -56,20 +56,15 @@ class QueryConverter extends Base...
NGSTACK-<I>: sync with vendor implementation
diff --git a/lib/mangopay.rb b/lib/mangopay.rb index <HASH>..<HASH> 100644 --- a/lib/mangopay.rb +++ b/lib/mangopay.rb @@ -104,7 +104,7 @@ module MangoPay end # decode json data - data = JSON.load(res.body.to_s) rescue {} + data = res.body.to_s.empty? ? {} : JSON.load(res.body.to_s) u...
Never rescue StandardError, it's dangerous! And fix request filtered params
diff --git a/lib/Cake/Test/Case/Cache/Engine/MemcacheEngineTest.php b/lib/Cake/Test/Case/Cache/Engine/MemcacheEngineTest.php index <HASH>..<HASH> 100644 --- a/lib/Cake/Test/Case/Cache/Engine/MemcacheEngineTest.php +++ b/lib/Cake/Test/Case/Cache/Engine/MemcacheEngineTest.php @@ -361,7 +361,7 @@ class MemcacheEngineTest ...
Fix testClear() case After clear of memcache config, all keys should be gone. So a read on a key should return false.
diff --git a/dominoes/players.py b/dominoes/players.py index <HASH>..<HASH> 100644 --- a/dominoes/players.py +++ b/dominoes/players.py @@ -104,12 +104,24 @@ def double(game): game.valid_moves = tuple(sorted(game.valid_moves, key=lambda m: m[0].first != m[0].second)) class omniscient: + ''' + Prefers to pl...
docstring for omniscient player
diff --git a/app/Http/Controllers/Auth/VerifyEmailController.php b/app/Http/Controllers/Auth/VerifyEmailController.php index <HASH>..<HASH> 100644 --- a/app/Http/Controllers/Auth/VerifyEmailController.php +++ b/app/Http/Controllers/Auth/VerifyEmailController.php @@ -76,7 +76,7 @@ class VerifyEmailController extends Abs...
Error when verifying email and no tree exists
diff --git a/src/config/hidev.php b/src/config/hidev.php index <HASH>..<HASH> 100644 --- a/src/config/hidev.php +++ b/src/config/hidev.php @@ -16,5 +16,8 @@ return [ '@hiqdev/assetpackagist/config/goals.yml', ], ], + 'packageStorage' => [ + 'class' => \hiqdev\ass...
+ packageStorage component to hidev config
diff --git a/numina/array/trace/tests/test_trace.py b/numina/array/trace/tests/test_trace.py index <HASH>..<HASH> 100644 --- a/numina/array/trace/tests/test_trace.py +++ b/numina/array/trace/tests/test_trace.py @@ -59,10 +59,9 @@ def test_trace_simple(): assert_allclose(mm, result) -@pytest.mark.xfail(reason='...
Remove xfail mark (bug has been fixed)
diff --git a/activesupport/lib/active_support/dependencies.rb b/activesupport/lib/active_support/dependencies.rb index <HASH>..<HASH> 100644 --- a/activesupport/lib/active_support/dependencies.rb +++ b/activesupport/lib/active_support/dependencies.rb @@ -345,7 +345,7 @@ module ActiveSupport #:nodoc: end def...
Work around Performance/EndWith false positive Rubocop warns about "Use String#end_with? instead of a regex match anchored to the end of the string", it doesn't seem aware of the $` special variable like Performance/RegexpMatch
diff --git a/bessie/base.py b/bessie/base.py index <HASH>..<HASH> 100644 --- a/bessie/base.py +++ b/bessie/base.py @@ -20,7 +20,7 @@ class BaseClient(object): def __init__(self, path='', **kwargs): self.path = path self.kwargs = kwargs - self._define_convenience_methods() + self.__define_convenience_methods()...
Move to private method No one should be overwriting this method.
diff --git a/lib/opal/nodes/literal.rb b/lib/opal/nodes/literal.rb index <HASH>..<HASH> 100644 --- a/lib/opal/nodes/literal.rb +++ b/lib/opal/nodes/literal.rb @@ -52,12 +52,30 @@ module Opal end def compile - sanitized_value = value.inspect.gsub /\\u\{[0-9a-f]+\}/ do |char| - @compiler.w...
Support higher utf8 codepoints in JS' utf<I> Allowing for emoji method names, among other things.
diff --git a/SugarSkull.js b/SugarSkull.js index <HASH>..<HASH> 100644 --- a/SugarSkull.js +++ b/SugarSkull.js @@ -8,7 +8,9 @@ var SugarSkull = (typeof SugarSkull != "undefined") ? SugarSkull : { SugarSkull.App.ExecutiveDelegation = function(params) { var namespace = params.namespace; - window[params.author ||...
change to ExecDelegation
diff --git a/spec/lib/onebox/engine/reddit_image_spec.rb b/spec/lib/onebox/engine/reddit_image_spec.rb index <HASH>..<HASH> 100644 --- a/spec/lib/onebox/engine/reddit_image_spec.rb +++ b/spec/lib/onebox/engine/reddit_image_spec.rb @@ -11,7 +11,6 @@ describe Onebox::Engine::RedditImageOnebox do end it "includes ...
DEV: Remove `puts` from reddit image spec
diff --git a/indra/util/aws.py b/indra/util/aws.py index <HASH>..<HASH> 100644 --- a/indra/util/aws.py +++ b/indra/util/aws.py @@ -36,8 +36,8 @@ def kill_all(job_queue, reason='None given', states=None): def tag_instance(instance_id, **tags): """Tag a single ec2 instance.""" - logger.info("Got request to add...
Change some logging to debug.
diff --git a/src/Provider/CrudGeneratorServiceProvider.php b/src/Provider/CrudGeneratorServiceProvider.php index <HASH>..<HASH> 100644 --- a/src/Provider/CrudGeneratorServiceProvider.php +++ b/src/Provider/CrudGeneratorServiceProvider.php @@ -24,6 +24,11 @@ class CrudGeneratorServiceProvider extends ServiceProvider ...
Resolved breadcrumbs issue #1
diff --git a/providers/dns/simply/simply.go b/providers/dns/simply/simply.go index <HASH>..<HASH> 100644 --- a/providers/dns/simply/simply.go +++ b/providers/dns/simply/simply.go @@ -58,8 +58,8 @@ type DNSProvider struct { recordIDsMu sync.Mutex } -// NewDNSProvider returns a DNSProvider instance configured for Nj...
simply: fix Go doc. (#<I>)
diff --git a/bcbio/ngsalign/novoalign.py b/bcbio/ngsalign/novoalign.py index <HASH>..<HASH> 100644 --- a/bcbio/ngsalign/novoalign.py +++ b/bcbio/ngsalign/novoalign.py @@ -97,7 +97,12 @@ def _novoalign_args_from_config(config, need_quality=True): multi_flag = "None" multi_flags = ["-r"] + multi_flag.split(...
Include default arguments for improved performance with novoalign in variant calling pipelines
diff --git a/salt/modules/timezone.py b/salt/modules/timezone.py index <HASH>..<HASH> 100644 --- a/salt/modules/timezone.py +++ b/salt/modules/timezone.py @@ -160,7 +160,7 @@ def get_hwclock(): elif 'Debian' in __grains__['os_family']: cmd = 'grep "UTC=" /etc/default/rcS | grep -vE "^#"' out = __...
/etc/default/rcS file does not contain UTC boolean value on Debian Wheezy, causes out-of-bounds exception when attempting to lookup given value
diff --git a/Log/sql.php b/Log/sql.php index <HASH>..<HASH> 100644 --- a/Log/sql.php +++ b/Log/sql.php @@ -125,7 +125,7 @@ class Log_sql extends Log $this->_mask = Log::UPTO($level); /* Now that we have a table name, assign our SQL statement. */ - if (!empty($this->_sql)) { + if (!empt...
The sql handler wasn't honoring custom SQL insertion statements. Bug: <I>
diff --git a/music/api.py b/music/api.py index <HASH>..<HASH> 100644 --- a/music/api.py +++ b/music/api.py @@ -11,6 +11,7 @@ class TrackResource(ModelBaseResource): class Meta: queryset = Track.permitted.all() resource_name = 'track' + ordering = ['last_played'] def override_urls(se...
Allow ordering on last_played
diff --git a/spyderlib/config.py b/spyderlib/config.py index <HASH>..<HASH> 100644 --- a/spyderlib/config.py +++ b/spyderlib/config.py @@ -96,7 +96,7 @@ INCLUDE_PATTERNS = [r'|'.join(['\\'+_ext+r'$' for _ext in EDIT_EXT if _ext])+\ r'|README|INSTALL', r'\.pyw?$|\.ipy$|\.txt$|\...
Find in files: fixed default 'exclude pattern' which was accidently excluding all files starting with 'build' instead of simply excluding 'build' folders as intended.
diff --git a/src/cloudant/replicator.py b/src/cloudant/replicator.py index <HASH>..<HASH> 100644 --- a/src/cloudant/replicator.py +++ b/src/cloudant/replicator.py @@ -51,8 +51,7 @@ class Replicator(object): :param str repl_id: Optional replication id. Generated internally if not explicitly set. ...
Always set user_ctx in replication documents
diff --git a/java/src/com/google/template/soy/SoyFileSet.java b/java/src/com/google/template/soy/SoyFileSet.java index <HASH>..<HASH> 100644 --- a/java/src/com/google/template/soy/SoyFileSet.java +++ b/java/src/com/google/template/soy/SoyFileSet.java @@ -93,6 +93,7 @@ import com.google.template.soy.xliffmsgplugin.Xliff...
Soy: Convenience method for adding proto descriptors to SoyFileSet ------------- Created by MOE: <URL>
diff --git a/model.go b/model.go index <HASH>..<HASH> 100644 --- a/model.go +++ b/model.go @@ -2,7 +2,7 @@ package suite import ( "github.com/gobuffalo/envy" - "github.com/markbates/pop" + "github.com/gobuffalo/pop" "github.com/stretchr/testify/require" "github.com/stretchr/testify/suite" )
moved to gobuffalo/pop
diff --git a/Composer.php b/Composer.php index <HASH>..<HASH> 100644 --- a/Composer.php +++ b/Composer.php @@ -65,7 +65,7 @@ class Composer * * @return array */ - protected function findComposer() + public function findComposer() { if ($this->files->exists($this->workingPath.'/comp...
[9.x] Allows to install `doctrine/dbal` from `model:show` command (#<I>) * Allows to install `model:show` command dependencies from the command itself * Apply fixes from StyleCI * Fixes warn message * Install it as regular dependency * formatting * formatting
diff --git a/client/server/api/sign-in-with-apple.js b/client/server/api/sign-in-with-apple.js index <HASH>..<HASH> 100644 --- a/client/server/api/sign-in-with-apple.js +++ b/client/server/api/sign-in-with-apple.js @@ -68,7 +68,7 @@ function redirectToCalypso( request, response, next ) { export default function ( app ...
Two small fixes for the server build (#<I>) * Remove extensions reference from server webpack config * Fix warning about body-parser extended option
diff --git a/lib/utils/file-util.js b/lib/utils/file-util.js index <HASH>..<HASH> 100644 --- a/lib/utils/file-util.js +++ b/lib/utils/file-util.js @@ -6,7 +6,7 @@ var fs = require('fs'); * Check the existence of the file */ function checkFileExistsSync(filepath){ - let flag = true; + var flag = true; try { ...
Use var rather than let for pre-ES6 cross-compatibility
diff --git a/test/spec/adapters/mantis_spec.js b/test/spec/adapters/mantis_spec.js index <HASH>..<HASH> 100644 --- a/test/spec/adapters/mantis_spec.js +++ b/test/spec/adapters/mantis_spec.js @@ -163,7 +163,7 @@ describe('mantis adapter tests', function () { var serverCall = adloader.loadScript.firstCall.args[0]; ...
Mantis - comment out breaking test Mocha redefines `window.context` so the `isAmp` function in the Mantis adapter doesn't work as expected under test. Commenting test out for now.
diff --git a/src/foremast/elb/create_elb.py b/src/foremast/elb/create_elb.py index <HASH>..<HASH> 100644 --- a/src/foremast/elb/create_elb.py +++ b/src/foremast/elb/create_elb.py @@ -204,7 +204,8 @@ class SpinnakerELB: policyname_tmp = "{0}-{1}-{2}-{3}" if sticky_type == 'app': ...
Fixed invalid app cookie stickiness policy names -Some JS libraries ship with dots by default in their cookie name, this at least strips it out.
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100755 --- a/setup.py +++ b/setup.py @@ -4,12 +4,13 @@ from os.path import dirname, join import sys, os # When creating the sdist, make sure the django.mo file also exists: -try: - os.chdir('fluent_comments') - from django.core.management.commands.compilem...
Only generate .po file on setup.py sdist call
diff --git a/core/src/main/java/com/digitalpebble/storm/crawler/persistence/Status.java b/core/src/main/java/com/digitalpebble/storm/crawler/persistence/Status.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/com/digitalpebble/storm/crawler/persistence/Status.java +++ b/core/src/main/java/com/digitalpebble/sto...
Fix incorrect Status returned for HTTP <I>
diff --git a/lib/Graph.php b/lib/Graph.php index <HASH>..<HASH> 100644 --- a/lib/Graph.php +++ b/lib/Graph.php @@ -65,6 +65,40 @@ class Graph implements Countable{ foreach ($originalVertices as $vertex){ $this->createVertexClone($vertex); } + return $this; + } + + /** + * create new clone/copy of this grap...
Add helper methods to clone graph
diff --git a/mvvmfx/src/main/java/de/saxsys/mvvmfx/utils/viewlist/ViewListCell.java b/mvvmfx/src/main/java/de/saxsys/mvvmfx/utils/viewlist/ViewListCell.java index <HASH>..<HASH> 100644 --- a/mvvmfx/src/main/java/de/saxsys/mvvmfx/utils/viewlist/ViewListCell.java +++ b/mvvmfx/src/main/java/de/saxsys/mvvmfx/utils/viewlist...
#<I> ViewListCell is now public to allow customization
diff --git a/lib/feedjira_extension.rb b/lib/feedjira_extension.rb index <HASH>..<HASH> 100644 --- a/lib/feedjira_extension.rb +++ b/lib/feedjira_extension.rb @@ -45,8 +45,8 @@ module FeedjiraExtension rescue self.name = content else - self.name = addr.name - self.email = addr.addre...
Rescue error from Mail::Address#name and #address `Mail::Address.new('')` does not raise any error but calling `name` on the created instance does.
diff --git a/pysat/tests/test_custom.py b/pysat/tests/test_custom.py index <HASH>..<HASH> 100644 --- a/pysat/tests/test_custom.py +++ b/pysat/tests/test_custom.py @@ -251,8 +251,8 @@ class TestBasics(): self.testInst.custom.attach(custom1, 'add') self.testInst.load(2009, 1) - assert self.test...
STY: applied reviewer corrections Removed unnecesary parens from assert statements.
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -63,6 +63,7 @@ setup( include_package_data=True, install_requires=[ 'colorama>=0.3.9', + 'dendrol @ git+https://github.com/cblades-tc/dendrol.git@master', 'future', 'hvac>=0.3.0', ...
update dendrol depenedency to internal fork
diff --git a/owslib/map/wms130.py b/owslib/map/wms130.py index <HASH>..<HASH> 100644 --- a/owslib/map/wms130.py +++ b/owslib/map/wms130.py @@ -665,9 +665,11 @@ class ContentMetadata(AbstractContentMetadata): self.dataUrls = [] for m in elem.findall(nspath('DataURL', WMS_NAMESPACE)): dataU...
Handle empty DataURL element in GetCapabilities As per the specification, the DataURL element may be empty. Using strip() on a empty string raises an exception. This was dealt with in the code for <I> but not for <I>.
diff --git a/concrete/src/Permission/IPService.php b/concrete/src/Permission/IPService.php index <HASH>..<HASH> 100644 --- a/concrete/src/Permission/IPService.php +++ b/concrete/src/Permission/IPService.php @@ -364,7 +364,8 @@ class IPService */ public function getRequestIP() { - return new IPAdd...
Always use IPLib to parse IP Addresses
diff --git a/src/pytest_cov/embed.py b/src/pytest_cov/embed.py index <HASH>..<HASH> 100644 --- a/src/pytest_cov/embed.py +++ b/src/pytest_cov/embed.py @@ -69,15 +69,15 @@ def init(): def _cleanup(cov): - cov.stop() - cov.save() + if cov is not None: + cov.stop() + cov.save() def cleanup...
Properly handle situation where active_cov is None.
diff --git a/lib/3scale/core.rb b/lib/3scale/core.rb index <HASH>..<HASH> 100644 --- a/lib/3scale/core.rb +++ b/lib/3scale/core.rb @@ -26,10 +26,18 @@ module ThreeScale 'Accept' => 'application/json', 'Content-Type' => 'application/json' } - @faraday.basic_auth('xxxxx', 'xxxxx') + @fa...
Get donbot auth info from ENV variables
diff --git a/src/main/index.js b/src/main/index.js index <HASH>..<HASH> 100644 --- a/src/main/index.js +++ b/src/main/index.js @@ -67,8 +67,13 @@ openFile$ // based on if arguments went through argv or through open-file events if (notebooks.length <= 0 && buffer.length <= 0) { log.info('launching an em...
fix(defaultKernel): default to py3, py2, then 1st lexicographically
diff --git a/oauth2/flaskweb.py b/oauth2/flaskweb.py index <HASH>..<HASH> 100644 --- a/oauth2/flaskweb.py +++ b/oauth2/flaskweb.py @@ -98,6 +98,4 @@ class OAuth2(object): response = self.controller.dispatch(Request(), environ={}) - status_code_parts = response.status_code.split(" ") ...
Use status code of a response without splitting
diff --git a/tests/test_cli.py b/tests/test_cli.py index <HASH>..<HASH> 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -75,6 +75,11 @@ class TestMain(object): cli.main(['ls', 'foo']) assert ls_command.call_count == 1 + @mock.patch('s4.cli.daemon_command') + def test_daemon_command(s...
Add basic coverage test for daemon command
diff --git a/src/ajax.js b/src/ajax.js index <HASH>..<HASH> 100644 --- a/src/ajax.js +++ b/src/ajax.js @@ -211,7 +211,7 @@ if (error) ajaxError(error, 'parsererror', xhr, settings) else ajaxSuccess(result, xhr, settings) } else { - ajaxError(null, 'error', xhr, settings) + ...
$.ajax error callback correctly reports "abort" status Before it was just "error". Assumes that an XHR status of "0" means that the request has been aborted. Fixes #<I>
diff --git a/widgets_overview_app.py b/widgets_overview_app.py index <HASH>..<HASH> 100644 --- a/widgets_overview_app.py +++ b/widgets_overview_app.py @@ -29,9 +29,9 @@ class MyApp(App): def main(self): verticalContainer = gui.Widget(640, 620, False, 10) - horizontalContainer = gui.Widget(600, 56...
Simply resizing some widgets in overview app.
diff --git a/tests/test_assess_model_change_watcher.py b/tests/test_assess_model_change_watcher.py index <HASH>..<HASH> 100644 --- a/tests/test_assess_model_change_watcher.py +++ b/tests/test_assess_model_change_watcher.py @@ -1,7 +1,8 @@ """Tests for assess_model_change_watcher module.""" import logging -from io i...
Fix stdout mocking.
diff --git a/lib/plz/command_builder.rb b/lib/plz/command_builder.rb index <HASH>..<HASH> 100644 --- a/lib/plz/command_builder.rb +++ b/lib/plz/command_builder.rb @@ -1,6 +1,6 @@ module Plz class CommandBuilder - SCHEMA_FILE_PATH_PATTERN = "{.,config}/schema.{json,yml}" + SCHEMA_FILE_PATH_PATTERN = "schema.{j...
Find schema file only at ./schema.json or ./schema.yml
diff --git a/lib/Csv/Reader.php b/lib/Csv/Reader.php index <HASH>..<HASH> 100644 --- a/lib/Csv/Reader.php +++ b/lib/Csv/Reader.php @@ -338,7 +338,13 @@ class Reader implements \Iterator { if ($this->header) { if (count($this->header) != count($this->currentData)) { - throw new ...
Fixed line exceeding <I> characters
diff --git a/languagetool-language-modules/uk/src/main/java/org/languagetool/tokenizers/uk/UkrainianWordTokenizer.java b/languagetool-language-modules/uk/src/main/java/org/languagetool/tokenizers/uk/UkrainianWordTokenizer.java index <HASH>..<HASH> 100644 --- a/languagetool-language-modules/uk/src/main/java/org/language...
Ukrainian dictionary and rules update (fix decimal numbers handling pattern)
diff --git a/src/BladeDirective.php b/src/BladeDirective.php index <HASH>..<HASH> 100644 --- a/src/BladeDirective.php +++ b/src/BladeDirective.php @@ -33,7 +33,8 @@ class BladeDirective /** * Handle the @cache setup. * - * @param mixed $model + * @param mixed $model + * @param string|...
Docblock a third time - shut up
diff --git a/src/Helpers/helperTranslations.php b/src/Helpers/helperTranslations.php index <HASH>..<HASH> 100644 --- a/src/Helpers/helperTranslations.php +++ b/src/Helpers/helperTranslations.php @@ -13,8 +13,9 @@ if (!function_exists('is_field_translatable')) { return; } - return $model->...
Check if method exists before running it on models (#<I>)
diff --git a/lib/jellyfish.rb b/lib/jellyfish.rb index <HASH>..<HASH> 100644 --- a/lib/jellyfish.rb +++ b/lib/jellyfish.rb @@ -42,6 +42,7 @@ module Jellyfish def block_call argument, block ret = instance_exec(argument, &block) body ret if body.nil? # prefer explicitly set values + body '' if bo...
jellyfish.rb: at least give an empty string if nothing returned
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -44,13 +44,13 @@ Db.prototype.set = function(key, val, cb) { Db.prototype.get = function(key, cb) { var self = this; key = self._prefix(key); + var item; try { - var item = self.storage.getItem(key); ...
take callback out of try/catch for .get Errors in callback should not result in it appearing like an error for getting a key.
diff --git a/lib/file_templater/file_actions.rb b/lib/file_templater/file_actions.rb index <HASH>..<HASH> 100644 --- a/lib/file_templater/file_actions.rb +++ b/lib/file_templater/file_actions.rb @@ -14,10 +14,10 @@ module FileTemplater def remove(path) # Remove the associated template. - FileUtils.remove_...
Fix remove command Errors were thrown when files did not exist, and the ".rb" suffix was not added to binding files.
diff --git a/src/main/java/water/parser/ParseDataset.java b/src/main/java/water/parser/ParseDataset.java index <HASH>..<HASH> 100644 --- a/src/main/java/water/parser/ParseDataset.java +++ b/src/main/java/water/parser/ParseDataset.java @@ -314,12 +314,10 @@ public final class ParseDataset extends Job { subTasks =...
Udpated the mechanism to reduce the # of parallel files being unzipped at the same time.
diff --git a/lib/highlighter.js b/lib/highlighter.js index <HASH>..<HASH> 100644 --- a/lib/highlighter.js +++ b/lib/highlighter.js @@ -39,7 +39,7 @@ var Highlighter = createReactClass({ caseSensitive: PropTypes.bool, ignoreDiacritics: PropTypes.bool, diacriticsBlacklist: PropTypes.string, - matchEleme...
Allow passing React components as matchElement This fixes a warning related to prop-types in development
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -50,6 +50,7 @@ from distutils.core import Command from distutils.command.build import build as _build from distutils.command.install import install as _install from distutils.util import change_root +from distutils.errors i...
Fix: DistutilsOptionError was undefined
diff --git a/lib/validates_formatting_of/version.rb b/lib/validates_formatting_of/version.rb index <HASH>..<HASH> 100644 --- a/lib/validates_formatting_of/version.rb +++ b/lib/validates_formatting_of/version.rb @@ -1,3 +1,3 @@ module ValidatesFormattingOf - VERSION = "0.3.5" + VERSION = "0.3.5.alpha" end
Testing on <I>.alpha
diff --git a/extensions/struts2/src/com/google/inject/struts2/Struts2Factory.java b/extensions/struts2/src/com/google/inject/struts2/Struts2Factory.java index <HASH>..<HASH> 100644 --- a/extensions/struts2/src/com/google/inject/struts2/Struts2Factory.java +++ b/extensions/struts2/src/com/google/inject/struts2/Struts2Fa...
Re-add a space into the args. Revision created by MOE tool push_codebase. MOE_MIGRATION=<I> git-svn-id: <URL>
diff --git a/snippets/action-search/search-action.js b/snippets/action-search/search-action.js index <HASH>..<HASH> 100644 --- a/snippets/action-search/search-action.js +++ b/snippets/action-search/search-action.js @@ -5,10 +5,12 @@ var page = tabris.create("Page", { var proposals = ["baseball", "batman", "battleshi...
Fix search action snippet layout "Selected '...'" text was behind the button as both were centered horizontally and vertically on the screen. Wrap them in a centered container instead. Change-Id: I<I>ee<I>f5b7ba<I>cdb3cbf<I>c8fd1a<I>ef<I>
diff --git a/mode/coffeescript/coffeescript.js b/mode/coffeescript/coffeescript.js index <HASH>..<HASH> 100644 --- a/mode/coffeescript/coffeescript.js +++ b/mode/coffeescript/coffeescript.js @@ -15,7 +15,7 @@ })(function(CodeMirror) { "use strict"; -CodeMirror.defineMode("coffeescript", function(conf) { +CodeMirror...
[coffeescript mode] Stop strangely fetching options from conf.mode That's what the parser configuration object is for. Also, I am unsure how this was supposed to even work. Issue #<I>
diff --git a/src/nextTick.js b/src/nextTick.js index <HASH>..<HASH> 100644 --- a/src/nextTick.js +++ b/src/nextTick.js @@ -3,14 +3,4 @@ const nextTick = ? requestAnimationFrame : setTimeout -export default function (task) { - if (!task) { - return new Promise(nextTick) - } - return new Promise(resolve...
fix (nextTick): fix nextTick implementation
diff --git a/src/a11y.js b/src/a11y.js index <HASH>..<HASH> 100644 --- a/src/a11y.js +++ b/src/a11y.js @@ -131,7 +131,9 @@ export default class A11y { // if we need to include the rendered node, we need to wait until // the owner has rendered - if ( owner && browser && !this.__sync ) { + // TO...
check for instance on owner before trying to use it
diff --git a/lib/jsdom/browser/htmltodom.js b/lib/jsdom/browser/htmltodom.js index <HASH>..<HASH> 100644 --- a/lib/jsdom/browser/htmltodom.js +++ b/lib/jsdom/browser/htmltodom.js @@ -64,10 +64,6 @@ var HtmlToDom = function(parser){ html +=''; } - // jos3000: not sure why this is here to c...
Fixed the Document.innerHTML setter to parse HTML with double spaces correctly. Previously it flattened double spaces to no whitespace, breaking the parsing if an element name and its attributes were separate by double whitespace.
diff --git a/competency/classes/course_competency.php b/competency/classes/course_competency.php index <HASH>..<HASH> 100644 --- a/competency/classes/course_competency.php +++ b/competency/classes/course_competency.php @@ -245,7 +245,7 @@ class course_competency extends persistent { $results = $DB->get_recor...
MDL-<I> core_competency: Include course category These courses are passed through to the course_summary_exporter which requires a category id in each course record.
diff --git a/hugolib/taxonomy.go b/hugolib/taxonomy.go index <HASH>..<HASH> 100644 --- a/hugolib/taxonomy.go +++ b/hugolib/taxonomy.go @@ -39,7 +39,7 @@ type WeightedPages []WeightedPage // A WeightedPage is a Page with a weight. type WeightedPage struct { Weight int - Page *Page + *Page } func (w WeightedPag...
hubolib: Embed Page in WeightedPage People can still say `.Page`, but by embedding it `WeightedPages` can be used interchangeably with `Pages` in templates. Fixes #<I>
diff --git a/activity/interceptors_test.go b/activity/interceptors_test.go index <HASH>..<HASH> 100644 --- a/activity/interceptors_test.go +++ b/activity/interceptors_test.go @@ -76,6 +76,13 @@ func TestInterceptors(t *testing.T) { t.Fatal("no after fail") } + if calledComplete { + t.Fatal("complete should not ...
Add missing assertions for declared by unused vars
diff --git a/tests/to-json-tests.js b/tests/to-json-tests.js index <HASH>..<HASH> 100644 --- a/tests/to-json-tests.js +++ b/tests/to-json-tests.js @@ -1,6 +1,6 @@ var test = require('ava'); -var JSDOM = require('jsdom').JSDOM; var AdaptiveHtml = require('../dist/adaptive-html.cjs'); +var jsdomHelper = require('./util...
utilize test helper in to-json-tests
diff --git a/twarc/decorators2.py b/twarc/decorators2.py index <HASH>..<HASH> 100644 --- a/twarc/decorators2.py +++ b/twarc/decorators2.py @@ -202,9 +202,10 @@ class FileSizeProgressBar(tqdm): self, result, field="id", error_resource_type=None, error_parameter="ids" ): try: - for item ...
fix FileSizeProgressBar when therte's no data in response
diff --git a/actionview/test/template/atom_feed_helper_test.rb b/actionview/test/template/atom_feed_helper_test.rb index <HASH>..<HASH> 100644 --- a/actionview/test/template/atom_feed_helper_test.rb +++ b/actionview/test/template/atom_feed_helper_test.rb @@ -315,12 +315,11 @@ class AtomFeedTest < ActionController::Test...
Use regexp instead exact match for atom test There are two xml namespaces in the response body and the xhtml namespace is not registered in the root node. This create an invalid XML and nokogiri can't navigate using xpath on that node.
diff --git a/lib/store.js b/lib/store.js index <HASH>..<HASH> 100644 --- a/lib/store.js +++ b/lib/store.js @@ -5,7 +5,12 @@ function Store() { } Store.prototype.connect = function(cb) { - process.nextTick(function() { cb(null, this)}); + var self = this; + process.nextTick(function() { + cb(null, self) + });...
Fixed bug in store.js connect not returning cache object
diff --git a/src/Assetic/AssetWriter.php b/src/Assetic/AssetWriter.php index <HASH>..<HASH> 100644 --- a/src/Assetic/AssetWriter.php +++ b/src/Assetic/AssetWriter.php @@ -80,4 +80,15 @@ class AssetWriter throw new \RuntimeException('Unable to write file '.$path); } } + + /** + * Not us...
added method for better BC with AsseticBundle
diff --git a/app/utils/patient-validation.js b/app/utils/patient-validation.js index <HASH>..<HASH> 100644 --- a/app/utils/patient-validation.js +++ b/app/utils/patient-validation.js @@ -16,8 +16,8 @@ export default { // force validation to fail return true; } else { - let typeAh...
Fixed patient typeahead to avoid false negative Validation was failing when user only typed in part of patient name and selected patient from list.
diff --git a/grunt/config/openui5_connect.js b/grunt/config/openui5_connect.js index <HASH>..<HASH> 100644 --- a/grunt/config/openui5_connect.js +++ b/grunt/config/openui5_connect.js @@ -13,6 +13,9 @@ module.exports = function(grunt, config) { contextpath: config.testsuite.name, proxypath: 'proxy', + proxyO...
[INTERNAL] Grunt: Disable proxy "secure" option for better local testing As the "grunt serve" server is only intended to be used for local testing it is fine to allow insecure connections. Change-Id: I<I>af5d<I>f<I>ce<I>ecc<I>f<I>ee<I>