diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/discovery/gossiper.go b/discovery/gossiper.go index <HASH>..<HASH> 100644 --- a/discovery/gossiper.go +++ b/discovery/gossiper.go @@ -251,6 +251,7 @@ func (d *AuthenticatedGossiper) SynchronizeNode(pub *btcec.PublicKey) error { NodeID: node.PubKey, Alias: alias, Features: node.Features....
discovery: properly set node's color when syncing graph state This commit fixes an existing bug wherein we would blank out a node’s color instead of properly setting the field when syncing graph state with another node This would cause the node to reject the node announcement and we would generate an we would invalida...
diff --git a/models/repo.go b/models/repo.go index <HASH>..<HASH> 100644 --- a/models/repo.go +++ b/models/repo.go @@ -831,11 +831,11 @@ func GetCollaborativeRepos(uname string) ([]*Repository, error) { repos := make([]*Repository, 0, 10) for _, access := range accesses { - if strings.HasPrefix(access.RepoName, ...
Using strings.HasPrefix(...) will misjudgement `strings.HasPrefix(access.RepoName, uname)` can't handle the situation which like following in access table. user_name | repo_name ----------+------------- toby | toby/blog toby | toby/test toby | tobyzxj/blog toby | tobyzxj/test
diff --git a/superset/assets/javascripts/SqlLab/reducers.js b/superset/assets/javascripts/SqlLab/reducers.js index <HASH>..<HASH> 100644 --- a/superset/assets/javascripts/SqlLab/reducers.js +++ b/superset/assets/javascripts/SqlLab/reducers.js @@ -242,10 +242,9 @@ export const sqlLabReducer = function (state, action) { ...
Check if the query is in state first. (#<I>)
diff --git a/src/Pingpong/Admin/AdminServiceProvider.php b/src/Pingpong/Admin/AdminServiceProvider.php index <HASH>..<HASH> 100644 --- a/src/Pingpong/Admin/AdminServiceProvider.php +++ b/src/Pingpong/Admin/AdminServiceProvider.php @@ -97,7 +97,7 @@ class AdminServiceProvider extends ServiceProvider { $this->...
Renamed registerEvents to registerRoutes
diff --git a/Cheque.php b/Cheque.php index <HASH>..<HASH> 100644 --- a/Cheque.php +++ b/Cheque.php @@ -16,10 +16,11 @@ use Propel\Runtime\Connection\ConnectionInterface; use Thelia\Install\Database; use Thelia\Model\MessageQuery; use Thelia\Model\Order; +use Thelia\Module\AbstractPaymentModule; use Thelia\Module\Ba...
Improvement on delivery events (#<I>)
diff --git a/java/server/src/org/openqa/selenium/netty/server/RequestConverter.java b/java/server/src/org/openqa/selenium/netty/server/RequestConverter.java index <HASH>..<HASH> 100644 --- a/java/server/src/org/openqa/selenium/netty/server/RequestConverter.java +++ b/java/server/src/org/openqa/selenium/netty/server/Req...
Update RequestConverter upgrade header handling. (#<I>)
diff --git a/graph/api/src/main/java/org/jboss/windup/graph/service/FileService.java b/graph/api/src/main/java/org/jboss/windup/graph/service/FileService.java index <HASH>..<HASH> 100644 --- a/graph/api/src/main/java/org/jboss/windup/graph/service/FileService.java +++ b/graph/api/src/main/java/org/jboss/windup/graph/se...
Fixed a case where the fileservice doesn't behave well if a filemodel entry was precreated. This really only occurs in odd ege cases. For example, if you were to analyze a source directory which contained a user rules directory. The configuration would create FileModels for the rules directory, which would later be re...
diff --git a/rake-tasks/crazy_fun/mappings/visualstudio.rb b/rake-tasks/crazy_fun/mappings/visualstudio.rb index <HASH>..<HASH> 100644 --- a/rake-tasks/crazy_fun/mappings/visualstudio.rb +++ b/rake-tasks/crazy_fun/mappings/visualstudio.rb @@ -369,7 +369,11 @@ module CrazyFunDotNet if Rake::Task.task_defined? pac...
JimEvans: Change NuGet packages to depend on exact version references, rather than range. This fix will be deployed in the next NuGet package release. Fixes issue #<I> r<I>
diff --git a/lib/node-gyp.js b/lib/node-gyp.js index <HASH>..<HASH> 100644 --- a/lib/node-gyp.js +++ b/lib/node-gyp.js @@ -83,6 +83,7 @@ proto.configDefs = { , proxy: String // 'install' , nodedir: String // 'configure' , loglevel: String // everywhere + , python: String // 'configure' } /**
configure: add "python" to the nopt config definition Makes "node-gyp rebuild --python /usr/bin/python<I>` (with " " instead of "=") work properly. Fixes #<I>.
diff --git a/src/block.js b/src/block.js index <HASH>..<HASH> 100644 --- a/src/block.js +++ b/src/block.js @@ -52,7 +52,7 @@ Object.assign(Block.prototype, SimpleBlock.fn, require('./block-validations'), { icon_name: 'default', validationFailMsg: function() { - return i18n.t('errors:validation_fail', { type:...
Fix error TypeError in validationFailMsg If `this.title` is not function then method `validationFailMsg` throws exception: ``` TypeError: this.title is not a function(…) ``` If this error occurs on `on_post` form's event - browser reloaded and data magically way didn't saved.
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -106,6 +106,10 @@ class RedisMock extends EventEmitter { return mock; } + duplicate() { + return this.createConnectedClient() + } + // eslint-disable-next-line class-methods-use-this discon...
fix: Add duplicate function to support instance duplication for TypeScript mocks (#<I>)
diff --git a/lib/responses/methods/index.js b/lib/responses/methods/index.js index <HASH>..<HASH> 100644 --- a/lib/responses/methods/index.js +++ b/lib/responses/methods/index.js @@ -189,7 +189,15 @@ module.exports = { var res = this.res; var req = this.req; - if (!data) data = {}; + if (typeof data =...
add suport to send messages in forbidden response
diff --git a/spec/models/event_spec.rb b/spec/models/event_spec.rb index <HASH>..<HASH> 100644 --- a/spec/models/event_spec.rb +++ b/spec/models/event_spec.rb @@ -118,6 +118,20 @@ describe Event do Event.cleanup_expired! expect(Event.find_by_id(event.id)).not_to be_nil end + + it "always keeps the...
Add a spec for the change
diff --git a/holoviews/core/element.py b/holoviews/core/element.py index <HASH>..<HASH> 100644 --- a/holoviews/core/element.py +++ b/holoviews/core/element.py @@ -570,7 +570,8 @@ class AxisLayout(UniformNdMapping): # NOTE: If further composite types supporting Overlaying and Layout these # classes may b...
Enabled one-dimensional AxisLayouts
diff --git a/airflow/jobs.py b/airflow/jobs.py index <HASH>..<HASH> 100644 --- a/airflow/jobs.py +++ b/airflow/jobs.py @@ -1162,8 +1162,8 @@ class SchedulerJob(BaseJob): if task_concurrency is not None: num_running = task_concurrency_map[((task_instance.dag_id, task_instance.task_i...
[AIRFLOW-<I>] Fix invalid reference to logger This should be log instead of logger. Somewhere it went wrong with the refactoring of the code. This patch had conflicts when merged, resolved by Committer: Ash Berlin-Taylor <<EMAIL>> Closes #<I> from Fokko/fd-fix-logger
diff --git a/clustering/web/cache/src/main/java/org/wildfly/clustering/web/cache/session/coarse/CoarseSessionAttributes.java b/clustering/web/cache/src/main/java/org/wildfly/clustering/web/cache/session/coarse/CoarseSessionAttributes.java index <HASH>..<HASH> 100644 --- a/clustering/web/cache/src/main/java/org/wildfly/...
WFLY-<I> Mutations following HttpSession.setAttribute(...) lost on failover when using SESSION granularity distributed web session with a non-transactional cache
diff --git a/logentry/logentry.go b/logentry/logentry.go index <HASH>..<HASH> 100644 --- a/logentry/logentry.go +++ b/logentry/logentry.go @@ -43,7 +43,7 @@ type LogEntry struct { } // New constructs a new LogEntry -func New(indexPrefix, typeName, JobType, WorkerName string, Code, ElapsedTime int) *LogEntry { +func...
allow override of status, <I>
diff --git a/pkg/auth/nodeidentifier/default.go b/pkg/auth/nodeidentifier/default.go index <HASH>..<HASH> 100644 --- a/pkg/auth/nodeidentifier/default.go +++ b/pkg/auth/nodeidentifier/default.go @@ -50,8 +50,6 @@ func (defaultNodeIdentifier) NodeIdentity(u user.Info) (string, bool) { return "", false } - nodeNam...
Only do string trim when it's necessary This will enhance performance a little bit.
diff --git a/auditlog_tests/test_settings.py b/auditlog_tests/test_settings.py index <HASH>..<HASH> 100644 --- a/auditlog_tests/test_settings.py +++ b/auditlog_tests/test_settings.py @@ -57,3 +57,5 @@ STATIC_URL = "/static/" ROOT_URLCONF = "auditlog_tests.urls" USE_TZ = True + +DEFAULT_AUTO_FIELD = "django.db.model...
Add DEFAULT_AUTO_FIELD to test settings.
diff --git a/proto/src/templates/primitives.py b/proto/src/templates/primitives.py index <HASH>..<HASH> 100644 --- a/proto/src/templates/primitives.py +++ b/proto/src/templates/primitives.py @@ -21,9 +21,8 @@ class _TemplateField(object): def encode(self, paramdict, parent, name=None, little_endian=False): ...
Refactor setting field_name and field_value in primitives to support Python <I>
diff --git a/src/Response.php b/src/Response.php index <HASH>..<HASH> 100644 --- a/src/Response.php +++ b/src/Response.php @@ -208,6 +208,8 @@ class Response implements ResponseInterface $response->body->useGlobally(); } + $response->isStale = false; + return $res...
The response from `Response::revive()` should not be marked as stale.
diff --git a/treeherder/etl/buildbot.py b/treeherder/etl/buildbot.py index <HASH>..<HASH> 100644 --- a/treeherder/etl/buildbot.py +++ b/treeherder/etl/buildbot.py @@ -15,7 +15,7 @@ RESULT_DICT = { # # PLATFORMS_BUILDERNAME, BUILD_TYPE_BUILDERNAME # -# http://mxr.mozilla.org/build/source/buildapi/buildapi/model/u...
Bug <I> - Switch a link from mxr to dxr in a comment (#<I>) r=emorley
diff --git a/builder/lxc/step_wait_init.go b/builder/lxc/step_wait_init.go index <HASH>..<HASH> 100644 --- a/builder/lxc/step_wait_init.go +++ b/builder/lxc/step_wait_init.go @@ -92,6 +92,9 @@ func (s *StepWaitInit) waitForInit(state multistep.StateBag, cancel <-chan struc if currentRunlevel == targetRunlevel { ...
[lxc] Ubuntu likes runlevel 5
diff --git a/switcheo/test_switcheo_client.py b/switcheo/test_switcheo_client.py index <HASH>..<HASH> 100644 --- a/switcheo/test_switcheo_client.py +++ b/switcheo/test_switcheo_client.py @@ -17,6 +17,8 @@ class TestSwitcheoClient(unittest.TestCase): 'address': 'fea2b883725ef2d194c9060f606cd0a0468a2c59', ...
Adding new keys to the Order History API Return
diff --git a/js/chartbuilder.js b/js/chartbuilder.js index <HASH>..<HASH> 100644 --- a/js/chartbuilder.js +++ b/js/chartbuilder.js @@ -104,7 +104,7 @@ ChartBuilder = { .split("€").join("") .split("%").join(""); - if(value == "null" || value == "" || (/^\s+$/).test(value) || (/^\#[A-Z\\\d\/]+\!$/...
fixed parsing regex to allow for #N/A cells from excel
diff --git a/sexpr/grammar.py b/sexpr/grammar.py index <HASH>..<HASH> 100644 --- a/sexpr/grammar.py +++ b/sexpr/grammar.py @@ -14,16 +14,15 @@ _str_format = ''' class Grammar(Matcher): def __init__(self, source, options = None): - self.yaml = source - rules = source.get('rules', {}) - sel...
Add public attribute for top-level tags (#3)
diff --git a/middleware/appsload.js b/middleware/appsload.js index <HASH>..<HASH> 100644 --- a/middleware/appsload.js +++ b/middleware/appsload.js @@ -59,7 +59,7 @@ function create(options) { var files = [], remoteCounter = 0; for (var i in list) { var m = /^(?:\/(text|raw);)?([\w\/+-]+(?...
Moved last libs to 3rd.party
diff --git a/subprojects/groovy-ginq/src/main/groovy/org/apache/groovy/ginq/dsl/expression/GinqExpression.java b/subprojects/groovy-ginq/src/main/groovy/org/apache/groovy/ginq/dsl/expression/GinqExpression.java index <HASH>..<HASH> 100644 --- a/subprojects/groovy-ginq/src/main/groovy/org/apache/groovy/ginq/dsl/expressi...
Tweak text of GINQ expression further
diff --git a/src/motor-html/base.js b/src/motor-html/base.js index <HASH>..<HASH> 100644 --- a/src/motor-html/base.js +++ b/src/motor-html/base.js @@ -166,8 +166,9 @@ export function initMotorHTMLBase() { // being called from the reciprocal API. See the constructor in // motor/Node.js to get s...
Oops, forgot to commit this with the last commit. Needed for the MotorHTMLScene to wait for the imperativeCounterpart.
diff --git a/src/ploneintranet/workspace/workspacecontainer.py b/src/ploneintranet/workspace/workspacecontainer.py index <HASH>..<HASH> 100644 --- a/src/ploneintranet/workspace/workspacecontainer.py +++ b/src/ploneintranet/workspace/workspacecontainer.py @@ -15,3 +15,12 @@ class WorkspaceContainer(Container): A fo...
also allow temporary attachments on WorkspaceContainer
diff --git a/lib/houston/roadmaps/railtie.rb b/lib/houston/roadmaps/railtie.rb index <HASH>..<HASH> 100644 --- a/lib/houston/roadmaps/railtie.rb +++ b/lib/houston/roadmaps/railtie.rb @@ -1,4 +1,3 @@ -require "houston/tickets" require "houston/roadmaps/milestone_ext" require "houston/roadmaps/project_ext" require "ho...
[skip] Removed require of houston/tickets (1m) It caused errors here
diff --git a/lib/base_controller.js b/lib/base_controller.js index <HASH>..<HASH> 100644 --- a/lib/base_controller.js +++ b/lib/base_controller.js @@ -629,6 +629,14 @@ controller.BaseController.prototype = new (function () { callback(content); }); + // Mix in controller instance-vars -- don't overwrite...
Mix controller instance-vars into view-data
diff --git a/app/search_builders/hyrax/catalog_search_builder.rb b/app/search_builders/hyrax/catalog_search_builder.rb index <HASH>..<HASH> 100644 --- a/app/search_builders/hyrax/catalog_search_builder.rb +++ b/app/search_builders/hyrax/catalog_search_builder.rb @@ -1,3 +1,31 @@ +## +# The default Blacklight catalog `s...
Add class level documentation for `Hyrax::CatalogSearchBuilder` Some folks were thinking about ways to extend this class, but had missed that Blacklight provides an extension mechanism. Adding some class level docs should help folks find the right extension points.
diff --git a/lib/generators/init-generator.js b/lib/generators/init-generator.js index <HASH>..<HASH> 100644 --- a/lib/generators/init-generator.js +++ b/lib/generators/init-generator.js @@ -31,7 +31,11 @@ module.exports = class InitGenerator extends Generator { constructor(args, opts) { super(args, opts); this...
cli(init): add webpack-cli dep (#<I>)
diff --git a/python_modules/dagster/dagster/cli/new_repo.py b/python_modules/dagster/dagster/cli/new_repo.py index <HASH>..<HASH> 100644 --- a/python_modules/dagster/dagster/cli/new_repo.py +++ b/python_modules/dagster/dagster/cli/new_repo.py @@ -2,13 +2,17 @@ import os import click from dagster.generate import gen...
Marks ``dagster new-repo`` as experimental. Summary: In ancitipation of feedback and changes in the near future, `dagster new-repo` is marked as an experimental feature. Test Plan: buildkite Reviewers: catherinewu, schrockn Reviewed By: catherinewu Differential Revision: <URL>
diff --git a/src/utils/get-extension-info.js b/src/utils/get-extension-info.js index <HASH>..<HASH> 100644 --- a/src/utils/get-extension-info.js +++ b/src/utils/get-extension-info.js @@ -19,7 +19,7 @@ function getManifestJSON (src) { try { return require(resolve(src, 'manifest.json')) } catch (error) { - ...
Fix Standard errors Strings must use singlequote
diff --git a/src/Illuminate/Notifications/Channels/MailChannel.php b/src/Illuminate/Notifications/Channels/MailChannel.php index <HASH>..<HASH> 100644 --- a/src/Illuminate/Notifications/Channels/MailChannel.php +++ b/src/Illuminate/Notifications/Channels/MailChannel.php @@ -184,8 +184,12 @@ class MailChannel ...
Allow passing of recipient name in Mail notifications
diff --git a/resources/config/default.php b/resources/config/default.php index <HASH>..<HASH> 100644 --- a/resources/config/default.php +++ b/resources/config/default.php @@ -12,6 +12,7 @@ $config->CM_Render->cdnResource = false; $config->CM_Render->cdnUserContent = false; $config->CM_Mail = new stdClass(); +$confi...
Set `$config->CM_Mail->send` to `true`. It _is_ actually a change, but I think it shouldn't hurt.
diff --git a/src/ecjTransformer/lombok/ast/ecj/EcjTreeConverter.java b/src/ecjTransformer/lombok/ast/ecj/EcjTreeConverter.java index <HASH>..<HASH> 100644 --- a/src/ecjTransformer/lombok/ast/ecj/EcjTreeConverter.java +++ b/src/ecjTransformer/lombok/ast/ecj/EcjTreeConverter.java @@ -27,6 +27,7 @@ public class EcjTreeCon...
Added @SuppressWarnings(unused) where needed so the project is warning free.
diff --git a/Challenge/Dns/LibDnsResolver.php b/Challenge/Dns/LibDnsResolver.php index <HASH>..<HASH> 100644 --- a/Challenge/Dns/LibDnsResolver.php +++ b/Challenge/Dns/LibDnsResolver.php @@ -87,11 +87,15 @@ class LibDnsResolver implements DnsResolverInterface public function getTxtEntries($domain) { ...
Wrap external call in try/catch block
diff --git a/framework/yii/console/controllers/MigrateController.php b/framework/yii/console/controllers/MigrateController.php index <HASH>..<HASH> 100644 --- a/framework/yii/console/controllers/MigrateController.php +++ b/framework/yii/console/controllers/MigrateController.php @@ -584,7 +584,7 @@ class MigrateControll...
Fix Issue #<I> Fixes issue #<I>. Command is created for the selected database, not the default database.
diff --git a/app/assets/javascripts/caboose/placeholder.js b/app/assets/javascripts/caboose/placeholder.js index <HASH>..<HASH> 100644 --- a/app/assets/javascripts/caboose/placeholder.js +++ b/app/assets/javascripts/caboose/placeholder.js @@ -2,7 +2,6 @@ $(document).ready(function() { $('[placeholder]').focus(func...
Remove console.log from placeholder js
diff --git a/client/my-sites/themes/index.node.js b/client/my-sites/themes/index.node.js index <HASH>..<HASH> 100644 --- a/client/my-sites/themes/index.node.js +++ b/client/my-sites/themes/index.node.js @@ -38,7 +38,10 @@ export default function( router ) { '/themes/:site?/filter/:filter', '/themes/:site?/filte...
Use unambiguous routes for support urls. (#<I>)
diff --git a/src/Service/Filler.php b/src/Service/Filler.php index <HASH>..<HASH> 100644 --- a/src/Service/Filler.php +++ b/src/Service/Filler.php @@ -306,7 +306,8 @@ class Filler extends FillerPlugin 'Music' => 'Music video', 'Special' => 'TV-special', ]; - $type = isset($rena...
correct case for type #<I>
diff --git a/src/main/java/org/nanopub/NanopubImpl.java b/src/main/java/org/nanopub/NanopubImpl.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/nanopub/NanopubImpl.java +++ b/src/main/java/org/nanopub/NanopubImpl.java @@ -209,6 +209,9 @@ public class NanopubImpl implements NanopubWithNs, Serializable { } ...
Special error message when set of statements is empty
diff --git a/builder/parser/line_parsers.go b/builder/parser/line_parsers.go index <HASH>..<HASH> 100644 --- a/builder/parser/line_parsers.go +++ b/builder/parser/line_parsers.go @@ -279,7 +279,7 @@ func parseMaybeJSON(rest string) (*Node, map[string]bool, error) { } // parseMaybeJSONToList determines if the argume...
Fix a typo in comment of parseMaybeJSONToList
diff --git a/spyder_kernels/customize/spyderpdb.py b/spyder_kernels/customize/spyderpdb.py index <HASH>..<HASH> 100755 --- a/spyder_kernels/customize/spyderpdb.py +++ b/spyder_kernels/customize/spyderpdb.py @@ -15,8 +15,8 @@ import traceback from collections import namedtuple from IPython.core.autocall import ZMQEx...
Debugger: Don't report skipped frames for IPython <I>+
diff --git a/pkg/nodediscovery/nodediscovery.go b/pkg/nodediscovery/nodediscovery.go index <HASH>..<HASH> 100644 --- a/pkg/nodediscovery/nodediscovery.go +++ b/pkg/nodediscovery/nodediscovery.go @@ -297,7 +297,10 @@ func (n *NodeDiscovery) updateLocalNode() { controller.NewManager().UpdateController("propagating lo...
pkg/nodediscovery: protect variable against concurrent access This variable can be accessed concurrently since controllers run on a separate go routine. Using its mutex and performing a DeepCopy will help protecting it against concurrent access. Fixes: e<I>fe1d<I>d1c ("nodediscovery: Make LocalNode object private")
diff --git a/examples/project_create_script.rb b/examples/project_create_script.rb index <HASH>..<HASH> 100644 --- a/examples/project_create_script.rb +++ b/examples/project_create_script.rb @@ -14,6 +14,10 @@ cname = gets.chomp client_search_results = harvest.clients.all.select { |c| c.name.downcase.include?(cname) }...
Better case statement to not have to use hacky ```(<I>/<I>)``` to get infinity.
diff --git a/discord/ext/commands/errors.py b/discord/ext/commands/errors.py index <HASH>..<HASH> 100644 --- a/discord/ext/commands/errors.py +++ b/discord/ext/commands/errors.py @@ -261,7 +261,7 @@ class MaxConcurrencyReached(CommandError): suffix = 'per %s' % name if per.name != 'default' else 'globally' ...
[commands] Be more clear in the default error for MaxConcurrencyReached
diff --git a/libraries/joomla/session/storage/xcache.php b/libraries/joomla/session/storage/xcache.php index <HASH>..<HASH> 100644 --- a/libraries/joomla/session/storage/xcache.php +++ b/libraries/joomla/session/storage/xcache.php @@ -13,7 +13,7 @@ defined('JPATH_PLATFORM') or die; * XCache session storage handler ...
Fix a docblock in the session package.
diff --git a/spec/support/actor_examples.rb b/spec/support/actor_examples.rb index <HASH>..<HASH> 100644 --- a/spec/support/actor_examples.rb +++ b/spec/support/actor_examples.rb @@ -395,6 +395,19 @@ shared_examples "Celluloid::Actor examples" do |included_module, task_klass| actor.should_not be_alive end ...
Add specs for alive/dead
diff --git a/fscache.go b/fscache.go index <HASH>..<HASH> 100644 --- a/fscache.go +++ b/fscache.go @@ -37,8 +37,12 @@ func New(dir string, expiry int) (*Cache, error) { expiry: time.Duration(expiry) * expiryPeriod, files: make(map[string]*cachedFile), } - time.AfterFunc(reaperPeriod, c.reaper) - return c, c.lo...
reaper runs right after load to remove expired items from the cache
diff --git a/code/GoogleGeocoding.php b/code/GoogleGeocoding.php index <HASH>..<HASH> 100644 --- a/code/GoogleGeocoding.php +++ b/code/GoogleGeocoding.php @@ -26,6 +26,10 @@ class GoogleGeocoding { 'region' => $region, 'key' => $key )); + if (!$service->request()->getBody()) { + // If blank response, ig...
fix(EmptyResponse): If the response is empty, avoid parsing with XML as it will throw an exception.
diff --git a/yamcs-client/yamcs/tmtc/model.py b/yamcs-client/yamcs/tmtc/model.py index <HASH>..<HASH> 100644 --- a/yamcs-client/yamcs/tmtc/model.py +++ b/yamcs-client/yamcs/tmtc/model.py @@ -202,7 +202,7 @@ class IssuedCommand(object): :type: :class:`~datetime.datetime` """ if self._proto.Has...
fixed the datetime conversion broken since the field has been changed to Timestamp
diff --git a/scapy/layers/tls/keyexchange.py b/scapy/layers/tls/keyexchange.py index <HASH>..<HASH> 100644 --- a/scapy/layers/tls/keyexchange.py +++ b/scapy/layers/tls/keyexchange.py @@ -746,7 +746,7 @@ class ClientDiffieHellmanPublic(_GenericTLSSessionInheritance): if s.client_kx_privkey and s.server_kx_pub...
Fix an error in the PMS derivation for DHE key exchange in TLS. The RFC states that the leading zero bytes must be stripped when storing the Pre Master Secret. This is bad practice, since it leads to exploitable timing attacks such as the Raccoon Attack (<URL>). However, this is the standard and the current implementa...
diff --git a/zimsoap/client.py b/zimsoap/client.py index <HASH>..<HASH> 100644 --- a/zimsoap/client.py +++ b/zimsoap/client.py @@ -1397,8 +1397,10 @@ not {0}'.format(type(ids))) def get_folder_grant(self, **kwargs): folder = self.get_folder(**kwargs) - - return folder['folder']['acl'] + if...
Return None when no acl found
diff --git a/control.js b/control.js index <HASH>..<HASH> 100644 --- a/control.js +++ b/control.js @@ -7,4 +7,4 @@ exports.task = task.task; exports.begin = task.begin; exports.perform = task.perform; exports.hosts = host.hosts; -exports.host = host.perform; +exports.host = host.host
Fixes export of host() method.
diff --git a/aiohttp/connector.py b/aiohttp/connector.py index <HASH>..<HASH> 100644 --- a/aiohttp/connector.py +++ b/aiohttp/connector.py @@ -460,19 +460,20 @@ class TCPConnector(BaseConnector): sslcontext = None hosts = yield from self._resolve_host(req.host, req.port) + exc = None - ...
Refactor TCPConnector._create_connection a bit
diff --git a/liquibase-core/src/main/java/liquibase/database/core/HsqlDatabase.java b/liquibase-core/src/main/java/liquibase/database/core/HsqlDatabase.java index <HASH>..<HASH> 100644 --- a/liquibase-core/src/main/java/liquibase/database/core/HsqlDatabase.java +++ b/liquibase-core/src/main/java/liquibase/database/core...
CORE-<I> Sequence is not a reserved object name in HSQLDB
diff --git a/cf/commands/application/start_test.go b/cf/commands/application/start_test.go index <HASH>..<HASH> 100644 --- a/cf/commands/application/start_test.go +++ b/cf/commands/application/start_test.go @@ -83,8 +83,8 @@ var _ = Describe("start command", func() { ui = new(testterm.FakeUI) cmd := NewStart(ui...
Bump timeouts in the start_test
diff --git a/app/controllers/stripe_event/webhook_controller.rb b/app/controllers/stripe_event/webhook_controller.rb index <HASH>..<HASH> 100644 --- a/app/controllers/stripe_event/webhook_controller.rb +++ b/app/controllers/stripe_event/webhook_controller.rb @@ -7,12 +7,20 @@ module StripeEvent end end ...
Add error logging to WebhookController For easier debugging. Fixes #<I>
diff --git a/notification-portlet-webcomponents/notification-component-icon/src/NotificationIcon.js b/notification-portlet-webcomponents/notification-component-icon/src/NotificationIcon.js index <HASH>..<HASH> 100644 --- a/notification-portlet-webcomponents/notification-component-icon/src/NotificationIcon.js +++ b/noti...
fix: ensure notification button shows are red when there are unread
diff --git a/src/locale/tk.js b/src/locale/tk.js index <HASH>..<HASH> 100644 --- a/src/locale/tk.js +++ b/src/locale/tk.js @@ -1,5 +1,5 @@ //! moment.js locale configuration -//! locale : Turkmen [trk] +//! locale : Turkmen [tk] //! author : Atamyrat Abdyrahmanov : https://github.com/atamyratabdy import moment fro...
[locale] tk: fix country code (#<I>)
diff --git a/src/request_handlers/status_request_handler.js b/src/request_handlers/status_request_handler.js index <HASH>..<HASH> 100644 --- a/src/request_handlers/status_request_handler.js +++ b/src/request_handlers/status_request_handler.js @@ -30,17 +30,18 @@ var ghostdriver = ghostdriver || {}; ghostdriver.StatusR...
Completed command "/status"
diff --git a/src/test/java/io/github/bonigarcia/test/docker/DockerHtmlVncJupiterTest.java b/src/test/java/io/github/bonigarcia/test/docker/DockerHtmlVncJupiterTest.java index <HASH>..<HASH> 100644 --- a/src/test/java/io/github/bonigarcia/test/docker/DockerHtmlVncJupiterTest.java +++ b/src/test/java/io/github/bonigarcia...
Use surefire-reports folder in test
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -11,7 +11,8 @@ module.exports = (function (array) { while (length) { value = parseInt(number.charAt(--length), 10) - sum += (bit ^= 1) ? array[value] : value + bit ^= 1 + sum += bit ? array[value] ...
avoid assigning in conidition of ternary
diff --git a/grade/edit/scale/edit.php b/grade/edit/scale/edit.php index <HASH>..<HASH> 100644 --- a/grade/edit/scale/edit.php +++ b/grade/edit/scale/edit.php @@ -107,6 +107,7 @@ if ($mform->is_cancelled()) { if (empty($scale->id)) { $data->description = $data->description_editor['text']; + $data...
gradebook MDL-<I> now saves scale description format when you create a new scale
diff --git a/multiplex.go b/multiplex.go index <HASH>..<HASH> 100644 --- a/multiplex.go +++ b/multiplex.go @@ -170,7 +170,7 @@ func (mp *Multiplex) sendMsg(ctx context.Context, header uint64, data []byte) er if err != nil && written > 0 { // Bail. We've written partial message and can't do anything // about thi...
close the session, not just the connection if we fail to write
diff --git a/src/bezierizer.core.js b/src/bezierizer.core.js index <HASH>..<HASH> 100644 --- a/src/bezierizer.core.js +++ b/src/bezierizer.core.js @@ -104,10 +104,14 @@ Bezierizer.prototype.getHandlePositions = function () { Bezierizer.prototype.setHandlePositions = function (points) { $.extend(this._points, points...
Refactors some calls to .css.
diff --git a/lib/merb-core/bootloader.rb b/lib/merb-core/bootloader.rb index <HASH>..<HASH> 100644 --- a/lib/merb-core/bootloader.rb +++ b/lib/merb-core/bootloader.rb @@ -124,9 +124,8 @@ end class Merb::BootLoader::DropPidFile < Merb::BootLoader class << self - def run - Merb::Server.store_pid(Merb...
Do not drop PID file is not running as daemon or cluster Avoid extra method call in logging
diff --git a/lib/juici/callback.rb b/lib/juici/callback.rb index <HASH>..<HASH> 100644 --- a/lib/juici/callback.rb +++ b/lib/juici/callback.rb @@ -10,7 +10,12 @@ module Juici end def process! - Net::HTTP.post_form(url, build.to_form_hash) + Net::HTTP.start(url.host, url.port) do |http| + re...
Refactor callbacks to use raw POST body
diff --git a/lib/active_record/connection_adapters/sqlserver/database_statements.rb b/lib/active_record/connection_adapters/sqlserver/database_statements.rb index <HASH>..<HASH> 100644 --- a/lib/active_record/connection_adapters/sqlserver/database_statements.rb +++ b/lib/active_record/connection_adapters/sqlserver/data...
Remove un-necessary adapter override
diff --git a/aws/resource_aws_batch_job_queue_test.go b/aws/resource_aws_batch_job_queue_test.go index <HASH>..<HASH> 100644 --- a/aws/resource_aws_batch_job_queue_test.go +++ b/aws/resource_aws_batch_job_queue_test.go @@ -100,11 +100,6 @@ func TestAccAWSBatchJobQueue_disappears(t *testing.T) { ), ExpectNonEm...
tests/resource/aws_batch_job_queue: Remove extraneous import testing from disappears test Output from acceptance testing: ``` --- PASS: TestAccAWSBatchJobQueue_disappears (<I>s) ```
diff --git a/lib/beepboop.js b/lib/beepboop.js index <HASH>..<HASH> 100644 --- a/lib/beepboop.js +++ b/lib/beepboop.js @@ -3,8 +3,8 @@ var Resourcer = require(__dirname + '/resourcer.js') module.exports = { - start: function (config) { - var resourcer = Resourcer(config) + start: function (options) { + var ...
Stub-in means of taking options into the resourcer.
diff --git a/lib/ntlmrequest.js b/lib/ntlmrequest.js index <HASH>..<HASH> 100644 --- a/lib/ntlmrequest.js +++ b/lib/ntlmrequest.js @@ -75,8 +75,8 @@ function ntlmRequest(opts) { if (supportedAuthSchemes.indexOf('ntlm') !== -1) { authHeader = ntlm.createType1Message(); - } else if (supportedAuthSchemes.i...
Fix basic auth check and password variable
diff --git a/widgets/ActionBox.php b/widgets/ActionBox.php index <HASH>..<HASH> 100644 --- a/widgets/ActionBox.php +++ b/widgets/ActionBox.php @@ -78,7 +78,7 @@ JS } public function renderSearchButton() { - return AdvancedSearch::renderButton(); + return AdvancedSearch::renderButton() . "\n"; ...
Add additional gap while render AdvancedSearchButton
diff --git a/lib/virtus/typecast/string.rb b/lib/virtus/typecast/string.rb index <HASH>..<HASH> 100644 --- a/lib/virtus/typecast/string.rb +++ b/lib/virtus/typecast/string.rb @@ -127,6 +127,8 @@ module Virtus end end + private_class_method :to_numeric + # Parse the value or return it as-is...
Update String numeric parser utility method to be private
diff --git a/TYPO3.Flow/Classes/MVC/Controller/F3_FLOW3_MVC_Controller_ActionController.php b/TYPO3.Flow/Classes/MVC/Controller/F3_FLOW3_MVC_Controller_ActionController.php index <HASH>..<HASH> 100644 --- a/TYPO3.Flow/Classes/MVC/Controller/F3_FLOW3_MVC_Controller_ActionController.php +++ b/TYPO3.Flow/Classes/MVC/Contr...
FLOW3: When no indexAction can be found in a controller, the message shown says so now. Original-Commit-Hash: fb<I>c<I>d<I>ac4bee<I>a<I>f<I>a<I>df<I>
diff --git a/aeron-cluster/src/main/java/io/aeron/cluster/SequencerAgent.java b/aeron-cluster/src/main/java/io/aeron/cluster/SequencerAgent.java index <HASH>..<HASH> 100644 --- a/aeron-cluster/src/main/java/io/aeron/cluster/SequencerAgent.java +++ b/aeron-cluster/src/main/java/io/aeron/cluster/SequencerAgent.java @@ -2...
[Java] Reset client activity timestamp after taking a snapshot to avoid session timeout.
diff --git a/test_cipher.py b/test_cipher.py index <HASH>..<HASH> 100644 --- a/test_cipher.py +++ b/test_cipher.py @@ -52,14 +52,14 @@ def test_internal(): def test_speed(): cipher = Cipher('0123456789abcdef', mode='ecb') - start_time = time.clock() + start_time = time.time() txt = '0123456789abcdef' for i in ...
Cherry pick timing from 5c9d<I>e.
diff --git a/source/rafcon/gui/mygaphas/canvas.py b/source/rafcon/gui/mygaphas/canvas.py index <HASH>..<HASH> 100644 --- a/source/rafcon/gui/mygaphas/canvas.py +++ b/source/rafcon/gui/mygaphas/canvas.py @@ -60,8 +60,6 @@ class MyCanvas(gaphas.canvas.Canvas): def remove(self, item): from rafcon.gui.mygapha...
chore(canvas): clean prints of Franz
diff --git a/lib/appsignal/transmitter.rb b/lib/appsignal/transmitter.rb index <HASH>..<HASH> 100644 --- a/lib/appsignal/transmitter.rb +++ b/lib/appsignal/transmitter.rb @@ -78,7 +78,6 @@ module Appsignal client.tap do |http| if uri.scheme == "https" http.use_ssl = true - http.s...
Remove SSL version lock in transmitter (#<I>) By removing the version lock we will no longer be limited to TLSv1, this has known security issues. By not specifying it, it will work with TLS<I> as well. The `ssl_version` option itself is also deprecated. Instead we could use the `min_option` version, but we thi...
diff --git a/periphery/mmio.py b/periphery/mmio.py index <HASH>..<HASH> 100644 --- a/periphery/mmio.py +++ b/periphery/mmio.py @@ -305,7 +305,7 @@ class MMIO(object): :type: ctypes.c_void_p """ - return ctypes.cast(ctypes.pointer(ctypes.c_uint8.from_buffer(self.mapping, 0)), ctypes.c_void_p) ...
mmio: fix memory offset of pointer property the pointer property was returning a unoffset pointer to the beginning of the mapped memory region, which is not at the MMIO object base address when the base address is not page aligned.
diff --git a/spec/main-spec.js b/spec/main-spec.js index <HASH>..<HASH> 100644 --- a/spec/main-spec.js +++ b/spec/main-spec.js @@ -177,7 +177,7 @@ describe('execNode', function() { await promise expect(false).toBe(true) } catch (error) { - expect(error.message).toBe('Process exited with non-zero...
:white_check_mark: Make a spec more cross platform
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100755 --- a/setup.py +++ b/setup.py @@ -24,7 +24,7 @@ setup( author_email='tim@takeflight.com.au', url='https://bitbucket.org/takeflight/wagtailnews', - install_requires=['wagtail>=1.0b2'], + install_requires=['wagtail>=1.0'], zip_safe=False,...
Bump required Wagtail version to <I>
diff --git a/spec/lib/exception_notifier_spec.rb b/spec/lib/exception_notifier_spec.rb index <HASH>..<HASH> 100644 --- a/spec/lib/exception_notifier_spec.rb +++ b/spec/lib/exception_notifier_spec.rb @@ -80,7 +80,7 @@ describe Crashbreak::ExceptionNotifier do end context 'github integration' do - let(:e...
Use string as keys when stubbing server resposne
diff --git a/salt/grains/core.py b/salt/grains/core.py index <HASH>..<HASH> 100644 --- a/salt/grains/core.py +++ b/salt/grains/core.py @@ -1779,12 +1779,14 @@ def ip_fqdn(): ret[key] = [] else: try: + start_time = datetime.datetime.utcnow() info = socke...
require large timediff for ipv6 warning
diff --git a/lib/solargraph/source.rb b/lib/solargraph/source.rb index <HASH>..<HASH> 100644 --- a/lib/solargraph/source.rb +++ b/lib/solargraph/source.rb @@ -340,6 +340,7 @@ module Solargraph def parse node, comments = inner_parse(@fixed, filename) @node = node + @comments = comments pro...
Expose Source#comments for fragments.
diff --git a/biodata-models/src/main/java/org/opencb/biodata/models/variant/annotation/ConsequenceTypeMappings.java b/biodata-models/src/main/java/org/opencb/biodata/models/variant/annotation/ConsequenceTypeMappings.java index <HASH>..<HASH> 100644 --- a/biodata-models/src/main/java/org/opencb/biodata/models/variant/an...
feature-vep-comparison: stop_retained_variant added to ConsequenceTypeMappings
diff --git a/src/Helpers/CrudApi.php b/src/Helpers/CrudApi.php index <HASH>..<HASH> 100644 --- a/src/Helpers/CrudApi.php +++ b/src/Helpers/CrudApi.php @@ -45,7 +45,14 @@ class CrudApi public function getModel() { - $fqModel = $this->getAppNamespace() . $this->model; + $namespace = $this->getAp...
If model is not found in App\ also look in App\Models\
diff --git a/lib/mj-single.js b/lib/mj-single.js index <HASH>..<HASH> 100644 --- a/lib/mj-single.js +++ b/lib/mj-single.js @@ -586,7 +586,7 @@ function GetSVG(result) { // if (data.speakText) { ID++; var id = "MathJax-SVG-"+ID; - svg.setAttribute("role","math"); + svg.setAttribute("role","img"); s...
SVG+SRE: change role from math to img Fixes #<I>
diff --git a/errors.go b/errors.go index <HASH>..<HASH> 100644 --- a/errors.go +++ b/errors.go @@ -50,6 +50,10 @@ var ( // ErrProcNotFound is an error encountered when the the process cannot be found ErrProcNotFound = syscall.Errno(0x7f) + + // ErrVmcomputeOperationAccessIsDenied is an error which can be encounte...
Add 'Access is denied' error
diff --git a/tpl/tplimpl/template.go b/tpl/tplimpl/template.go index <HASH>..<HASH> 100644 --- a/tpl/tplimpl/template.go +++ b/tpl/tplimpl/template.go @@ -598,10 +598,16 @@ func (t *templateHandler) applyBaseTemplate(overlay, base templateInfo) (tpl.Tem } } - templ, err = templ.Parse(overlay.template) + temp...
tpl: Fix race condition in text template baseof Copy most of the htmltemplate cloning to the textemplate implementation in the same function.
diff --git a/test/OfferCommandHandlerTestTrait.php b/test/OfferCommandHandlerTestTrait.php index <HASH>..<HASH> 100644 --- a/test/OfferCommandHandlerTestTrait.php +++ b/test/OfferCommandHandlerTestTrait.php @@ -160,7 +160,6 @@ trait OfferCommandHandlerTestTrait ] ) ->when( - ...
III-<I>: Fix coding standard violation
diff --git a/tests/Fixer/LanguageConstruct/ClassKeywordRemoveFixerTest.php b/tests/Fixer/LanguageConstruct/ClassKeywordRemoveFixerTest.php index <HASH>..<HASH> 100644 --- a/tests/Fixer/LanguageConstruct/ClassKeywordRemoveFixerTest.php +++ b/tests/Fixer/LanguageConstruct/ClassKeywordRemoveFixerTest.php @@ -215,6 +215,16...
add a failed condition for issue #<I>
diff --git a/server/auth_test.go b/server/auth_test.go index <HASH>..<HASH> 100644 --- a/server/auth_test.go +++ b/server/auth_test.go @@ -66,6 +66,19 @@ func TestUserClonePermissionsNoLists(t *testing.T) { } } +func TestUserCloneNoPermissions(t *testing.T) { + user := &User{ + Username: "foo", + Password: "bar"...
Add User clone test for nil Permissions
diff --git a/src/fx/fx.js b/src/fx/fx.js index <HASH>..<HASH> 100644 --- a/src/fx/fx.js +++ b/src/fx/fx.js @@ -415,7 +415,8 @@ jQuery.extend({ // Get the current size z.cur = function(){ - return parseFloat( jQuery.curCSS(z.el, prop) ) || z.max(); + var r = parseFloat( jQuery.curCSS(z.el, prop) ); + retu...
Fixed the giant negative number issue that Opera was having.
diff --git a/client.js b/client.js index <HASH>..<HASH> 100644 --- a/client.js +++ b/client.js @@ -1,4 +1,4 @@ -pipe.on('search::render', function render(pagelet) { +pipe.on('search:render', function render(pagelet) { 'use strict'; var placeholders = $(pagelet.placeholders);
[migrate] Support bigpipe <I>
diff --git a/cassiopeia/dto/matchapi.py b/cassiopeia/dto/matchapi.py index <HASH>..<HASH> 100644 --- a/cassiopeia/dto/matchapi.py +++ b/cassiopeia/dto/matchapi.py @@ -1,7 +1,7 @@ import cassiopeia.dto.requests import cassiopeia.type.dto.match -def get_match(id_): +def get_match(id_, includeTimeline=True): ...
Exposed the option to get the timeline to the api