diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/tensor2tensor/models/research/universal_transformer_util.py b/tensor2tensor/models/research/universal_transformer_util.py index <HASH>..<HASH> 100644 --- a/tensor2tensor/models/research/universal_transformer_util.py +++ b/tensor2tensor/models/research/universal_transformer_util.py @@ -125,8 +125,6 @@ def u...
setting the default for use_memory_as_final_state flag to False (#<I>)
diff --git a/examples/src/main/python/ml/dataframe_example.py b/examples/src/main/python/ml/dataframe_example.py index <HASH>..<HASH> 100644 --- a/examples/src/main/python/ml/dataframe_example.py +++ b/examples/src/main/python/ml/dataframe_example.py @@ -28,6 +28,7 @@ import shutil from pyspark.sql import SparkSessi...
[SPARK-<I>][PYSPARK][ML][EXAMPLES] dataframe_example.py fails to convert ML style vectors ## What changes were proposed in this pull request? Need to convert ML Vectors to the old MLlib style before doing Statistics.colStats operations on the DataFrame ## How was this patch tested? Ran example, local tests
diff --git a/connection.go b/connection.go index <HASH>..<HASH> 100644 --- a/connection.go +++ b/connection.go @@ -16,6 +16,7 @@ const heartbeatDuration = time.Minute type Connection interface { OpenQueue(name string) Queue CollectStats() Stats + GetOpenQueues() []string } // Connection is the entry point. Use...
matching queue name with regexp and return reject for all matches
diff --git a/auth.go b/auth.go index <HASH>..<HASH> 100644 --- a/auth.go +++ b/auth.go @@ -32,12 +32,13 @@ func (auth *PlainAuth) Response() string { return fmt.Sprintf("\000%s\000%s", auth.Username, auth.Password) } -// AMQPLAINAuth is similar to PlainAuth +// AMQPlainAuth is similar to PlainAuth type AMQPlainAu...
Fixes pre-existing golint issues
diff --git a/LiSE/LiSE/proxy.py b/LiSE/LiSE/proxy.py index <HASH>..<HASH> 100644 --- a/LiSE/LiSE/proxy.py +++ b/LiSE/LiSE/proxy.py @@ -2934,9 +2934,10 @@ class EngineProxy(AbstractEngine): for f in self._time_listeners: f(b, t, branch, tick) - def __init__(self, handle_out, handle_in,...
let EngineHandle at the logger, too
diff --git a/conf/lex.go b/conf/lex.go index <HASH>..<HASH> 100644 --- a/conf/lex.go +++ b/conf/lex.go @@ -13,7 +13,7 @@ import ( ) const spaces = " \t" -const whitespace = spaces + "\n\r" +const whitespace = spaces + "\n" const wordRunes = "abcdefghijklmnopqrstuvwxyz1234567890ABCDEFGHIJKLMNOPQRSTUVXYZ_" const qu...
Adjust our CRLF strategy - convert before lexing.
diff --git a/test/api-configuration.test.js b/test/api-configuration.test.js index <HASH>..<HASH> 100644 --- a/test/api-configuration.test.js +++ b/test/api-configuration.test.js @@ -71,10 +71,10 @@ suite('Configuration API', function() { var dump = database.commandSync('dump', { tables: 'compan...
Fix expected dump for DefineIndexField
diff --git a/webapp/WEB-INF/setupdata/vfs/system/workplace/editors/msdhtml/edithtml.js b/webapp/WEB-INF/setupdata/vfs/system/workplace/editors/msdhtml/edithtml.js index <HASH>..<HASH> 100644 --- a/webapp/WEB-INF/setupdata/vfs/system/workplace/editors/msdhtml/edithtml.js +++ b/webapp/WEB-INF/setupdata/vfs/system/workpla...
fixed issue in getSelectedText method throwing JavaScript error
diff --git a/__init__.py b/__init__.py index <HASH>..<HASH> 100644 --- a/__init__.py +++ b/__init__.py @@ -17,3 +17,4 @@ from srl_data import * from causal_data import * from temporal_data import * from factuality_data import * +from markable_data import *
Added markable data to the init
diff --git a/cassandra/cluster.py b/cassandra/cluster.py index <HASH>..<HASH> 100644 --- a/cassandra/cluster.py +++ b/cassandra/cluster.py @@ -1940,7 +1940,7 @@ class Session(object): increasing timestamps across clusters, or set it to to ``lambda: int(time.time() * 1e6)`` if losing records over clock inconsi...
timestamp gen docstrings: sec-->usec
diff --git a/ptpython/layout.py b/ptpython/layout.py index <HASH>..<HASH> 100644 --- a/ptpython/layout.py +++ b/ptpython/layout.py @@ -1,6 +1,6 @@ from __future__ import unicode_literals -from prompt_toolkit.enums import DEFAULT_BUFFER +from prompt_toolkit.enums import DEFAULT_BUFFER, SEARCH_BUFFER from prompt_tool...
Only show search highlighting when the search is the current input buffer.
diff --git a/cmd/jujud/machine.go b/cmd/jujud/machine.go index <HASH>..<HASH> 100644 --- a/cmd/jujud/machine.go +++ b/cmd/jujud/machine.go @@ -84,7 +84,7 @@ func (a *MachineAgent) Run(_ *cmd.Context) error { // that need a state connection Unless we're bootstrapping, we // need to connect to the API server to find ...
cmd/jujud: fix comments
diff --git a/src/sap.m/src/sap/m/upload/UploadSet.js b/src/sap.m/src/sap/m/upload/UploadSet.js index <HASH>..<HASH> 100644 --- a/src/sap.m/src/sap/m/upload/UploadSet.js +++ b/src/sap.m/src/sap/m/upload/UploadSet.js @@ -272,6 +272,7 @@ sap.ui.define([ * <code>maxFileNameLength</code> property.</li> * <li>Whe...
[INTERNAL] API Documentation change for file name and size exceeded BCP: <I> Change-Id: I7eddb9d4fced<I>c<I>bb<I>ef7f5ea<I>c<I>b
diff --git a/object-assign.js b/object-assign.js index <HASH>..<HASH> 100644 --- a/object-assign.js +++ b/object-assign.js @@ -10,7 +10,7 @@ var ToObject = function (val) { if (val == null) { - throw new TypeError('Object.assign can not be called with null or undefined'); + throw new TypeError('Object.assign...
Update object-assign.js
diff --git a/code/thirdparty/Apache/Solr/HttpTransport/Curl.php b/code/thirdparty/Apache/Solr/HttpTransport/Curl.php index <HASH>..<HASH> 100644 --- a/code/thirdparty/Apache/Solr/HttpTransport/Curl.php +++ b/code/thirdparty/Apache/Solr/HttpTransport/Curl.php @@ -119,6 +119,9 @@ class Apache_Solr_HttpTransport_Curl exte...
Remove Content-Type from Curl GET Request Solr <I> does not like Content-Types on GET requests. The Curl HttpTransport reuses the curl instance if you send multiple requests to Solr. This leads to an error if you send a post request, which sets the Content-Type Header and then send a GET request like search.
diff --git a/vapi/library/finder/finder.go b/vapi/library/finder/finder.go index <HASH>..<HASH> 100644 --- a/vapi/library/finder/finder.go +++ b/vapi/library/finder/finder.go @@ -78,6 +78,17 @@ func (f *Finder) find(ctx context.Context, ipath string) ([]FindResult, error) { // Tokenize the path into its distinct part...
lib/finder: Support filenames with "/" This patch fixes the library's finder to support filenames containing the "/" character.
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/models/review.rb b/sonar-server/src/main/webapp/WEB-INF/app/models/review.rb index <HASH>..<HASH> 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/models/review.rb +++ b/sonar-server/src/main/webapp/WEB-INF/app/models/review.rb @@ -24,7 +24,7 @@ class Review < ...
Fix display of source code in review detail The problem occurs when the review relates to a violation tracked over time.
diff --git a/consul/structs/prepared_query_test.go b/consul/structs/prepared_query_test.go index <HASH>..<HASH> 100644 --- a/consul/structs/prepared_query_test.go +++ b/consul/structs/prepared_query_test.go @@ -4,7 +4,7 @@ import ( "testing" ) -func TestStructs_PreparedQuery_GetACLInfo(t *testing.T) { +func TestSt...
Renames a unit test.
diff --git a/lib/compoundify.js b/lib/compoundify.js index <HASH>..<HASH> 100644 --- a/lib/compoundify.js +++ b/lib/compoundify.js @@ -52,10 +52,11 @@ function compoundify(SuperConstructor) { if (arguments.length < 2) { value = {}; } + u = SuperConstructor.prototype.addNode.call(this, u, value); ...
Fix bug where auto-assigned id was not used for parent/children properties
diff --git a/contrib/parseq-batching/src/main/java/com/linkedin/parseq/batching/BatchingSupport.java b/contrib/parseq-batching/src/main/java/com/linkedin/parseq/batching/BatchingSupport.java index <HASH>..<HASH> 100644 --- a/contrib/parseq-batching/src/main/java/com/linkedin/parseq/batching/BatchingSupport.java +++ b/c...
Typos in BathingSupport class.
diff --git a/cordova-lib/src/cordova/plugin.js b/cordova-lib/src/cordova/plugin.js index <HASH>..<HASH> 100644 --- a/cordova-lib/src/cordova/plugin.js +++ b/cordova-lib/src/cordova/plugin.js @@ -391,6 +391,7 @@ function determinePluginTarget(projectRoot, cfg, target, fetchOptions) { } // Require project pkgJs...
CB-<I>: fixed incorrect plugin version fetching issue
diff --git a/salt/grains/core.py b/salt/grains/core.py index <HASH>..<HASH> 100644 --- a/salt/grains/core.py +++ b/salt/grains/core.py @@ -222,7 +222,7 @@ def os_data(): match = regex.match(line) if match: # Adds: lsb_distrib_{id,release,codename,description} - ...
Strip trailing \n off of lsb_* grains
diff --git a/sos/archive.py b/sos/archive.py index <HASH>..<HASH> 100644 --- a/sos/archive.py +++ b/sos/archive.py @@ -118,11 +118,18 @@ class FileCacheArchive(Archive): self._check_path(dest) try: shutil.copy(src, dest) + except IOError: + self.log.info("caught IO error...
Break up exception handling in FileCacheArchive.add_file() An exception can occur at several points in add_file() - Copying the source to the destination - Propagating permissions with shutil.copystat - Setting ownership via os.chown The second of these can occur when copying SELinux xattrs from /proc. Separate out ...
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index <HASH>..<HASH> 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -920,6 +920,7 @@ class SqlaTable(Model, BaseDatasource): # pylint: disable=too-many-public-metho data_["is_s...
fix: properly set `owners` to Sqlatable.owners_data inside payload (#<I>) * properly set owners_data for sqlatabl * fix test
diff --git a/shoebot/__init__.py b/shoebot/__init__.py index <HASH>..<HASH> 100644 --- a/shoebot/__init__.py +++ b/shoebot/__init__.py @@ -993,10 +993,10 @@ class CairoCanvas(Canvas): ctx.save() x,y = item.metrics[0:2] deltax, deltay = item.center + m = ...
transforms are correct for text objects too, finallyhg diff! now the transform system works almost perfectly
diff --git a/psiturk/psiturk_config.py b/psiturk/psiturk_config.py index <HASH>..<HASH> 100644 --- a/psiturk/psiturk_config.py +++ b/psiturk/psiturk_config.py @@ -28,7 +28,7 @@ class PsiturkConfig(SafeConfigParser): local_defaults_file = os.path.join(defaults_folder, "local_config_defaults.txt") globa...
typo (closes #<I>)
diff --git a/git/util.py b/git/util.py index <HASH>..<HASH> 100644 --- a/git/util.py +++ b/git/util.py @@ -20,7 +20,6 @@ import shutil import stat from sys import maxsize import time -from unittest import SkipTest from urllib.parse import urlsplit, urlunsplit import warnings @@ -130,6 +129,7 @@ def rmtree(path: ...
import unittest adds <I>s to script launch time This should not be imported at root level, since it adds a lot of initialization overhead without need.
diff --git a/src/Malenki/Bah/S.php b/src/Malenki/Bah/S.php index <HASH>..<HASH> 100644 --- a/src/Malenki/Bah/S.php +++ b/src/Malenki/Bah/S.php @@ -216,7 +216,6 @@ class S extends O implements \Countable, \IteratorAggregate 'r', 'first', 'last', - ...
Class S: removed deprecated method
diff --git a/environs/ec2/ec2.go b/environs/ec2/ec2.go index <HASH>..<HASH> 100644 --- a/environs/ec2/ec2.go +++ b/environs/ec2/ec2.go @@ -419,7 +419,9 @@ func (e *environ) Destroy(insts []environs.Instance) error { if err != nil { return err } - // take an immutable reference to the current Storage + // to prop...
responding to review comments; some wordsmithing
diff --git a/lib/docker-sync/sync_strategy/unison.rb b/lib/docker-sync/sync_strategy/unison.rb index <HASH>..<HASH> 100644 --- a/lib/docker-sync/sync_strategy/unison.rb +++ b/lib/docker-sync/sync_strategy/unison.rb @@ -158,7 +158,7 @@ module Docker_Sync end def get_host_port(container_name, container_po...
[BUGFIX] Unison reports too many roots - PB: the sed expression to grab the used port in container is not compatible with the default sed binary. - FIX: force the use of the default sed binary /usr/bin/sed and update the regexp accordingly
diff --git a/hgvs/validator.py b/hgvs/validator.py index <HASH>..<HASH> 100644 --- a/hgvs/validator.py +++ b/hgvs/validator.py @@ -96,7 +96,7 @@ class ExtrinsicValidator(): var_ref_seq = None if var.posedit.edit.type == 'dup': # Handle Dup and NADupN objects. - var_ref_seq = ge...
fixed missed seq/ref substitution in validator.py
diff --git a/addon/file.js b/addon/file.js index <HASH>..<HASH> 100644 --- a/addon/file.js +++ b/addon/file.js @@ -139,10 +139,11 @@ export default Ember.Object.extend({ }); let request = new HTTPRequest(); + request.open(options.method, options.url); + Object.keys(options.headers).forEach(function ...
set headers after opening the XMLHttpRequest
diff --git a/ggplot/utils/utils.py b/ggplot/utils/utils.py index <HASH>..<HASH> 100644 --- a/ggplot/utils/utils.py +++ b/ggplot/utils/utils.py @@ -504,7 +504,7 @@ def remove_missing(df, na_rm=False, vars=None, name='', finite=False): if finite: lst = [np.inf, -np.inf] - to_replace = dict((v, lst)...
Accurate file & line no. for missing values
diff --git a/lib/dashboard/public/single_instances.js b/lib/dashboard/public/single_instances.js index <HASH>..<HASH> 100644 --- a/lib/dashboard/public/single_instances.js +++ b/lib/dashboard/public/single_instances.js @@ -19,6 +19,10 @@ document.addEventListener('DOMContentLoaded', () => { continue; } + ...
fix(single_instance): fix "Kill" buttons always being visible, even if no instance was open
diff --git a/src/views/generators/seeder.blade.php b/src/views/generators/seeder.blade.php index <HASH>..<HASH> 100644 --- a/src/views/generators/seeder.blade.php +++ b/src/views/generators/seeder.blade.php @@ -56,7 +56,7 @@ class LaratrustSeeder extends Seeder $this->command->info("Creating '{$key}' user"...
Changes mentioned in #<I>
diff --git a/parse.go b/parse.go index <HASH>..<HASH> 100644 --- a/parse.go +++ b/parse.go @@ -81,7 +81,7 @@ func (p *parser) next() item { } func (p *parser) bug(format string, v ...interface{}) { - log.Fatalf("BUG: %s\n\n", fmt.Sprintf(format, v...)) + log.Panicf("BUG: %s\n\n", fmt.Sprintf(format, v...)) } fu...
Panic instead of os.Exit for illegal state situations in parser Fixes #<I>
diff --git a/test.js b/test.js index <HASH>..<HASH> 100644 --- a/test.js +++ b/test.js @@ -1638,3 +1638,47 @@ test('dyadic ternary but(pref-0i1)', (t) => { t.end(); }); + +test('unary ternary instructions', (t) => { + const cpu = CPU(); + let lines = [ + 'LDA #%i010i', + 'STI A', + 'CMP #%10i01', + ...
Add test for unary ternary instructions: STI, PTI, NTI, FD, and RD
diff --git a/lang/en/langconfig.php b/lang/en/langconfig.php index <HASH>..<HASH> 100644 --- a/lang/en/langconfig.php +++ b/lang/en/langconfig.php @@ -29,7 +29,7 @@ $string['decsep'] = '.'; $string['firstdayofweek'] = '0'; $string['iso6391'] = 'en'; $string['iso6392'] = 'eng'; -$string['labelsep'] = '&nbsp;'; +$stri...
MDL-<I> temporarily disabled support for colonized labels The code must be fixed so that the colon is not displayed when the label is hidden by accessibility CSS.
diff --git a/eventsourcing/application.py b/eventsourcing/application.py index <HASH>..<HASH> 100644 --- a/eventsourcing/application.py +++ b/eventsourcing/application.py @@ -130,7 +130,7 @@ class NotificationLog(ABC): @abstractmethod def select(self, start: int, limit: int) -> List[Notification]: ""...
Fixed class ref in docs.
diff --git a/tests/unit/utils/vt_test.py b/tests/unit/utils/vt_test.py index <HASH>..<HASH> 100644 --- a/tests/unit/utils/vt_test.py +++ b/tests/unit/utils/vt_test.py @@ -16,7 +16,7 @@ import random import subprocess # Import Salt Testing libs -from salttesting import TestCase +from salttesting import TestCase, ski...
Add skipIf import to fix the <I> tests
diff --git a/test/unittests.js b/test/unittests.js index <HASH>..<HASH> 100644 --- a/test/unittests.js +++ b/test/unittests.js @@ -55,8 +55,8 @@ describe('Unit Tests', function () { }); } + require('./worker')(); require('./crypto')(); require('./general')(); - require('./worker')(); require('./sec...
CI: run worker tests first to give enough time to download the required scripts (#<I>) This should fix issues with Safari <I> not managing to load the worker in BrowserStack Automate.
diff --git a/HTML/Auto.py b/HTML/Auto.py index <HASH>..<HASH> 100644 --- a/HTML/Auto.py +++ b/HTML/Auto.py @@ -33,5 +33,5 @@ class Tag: self.hash = hash self.sorted = sorted - def tag( params={} ): + def tag( self, params={} ): return "<html />"
tag() needs self as 1st arg
diff --git a/lib/paymill.rb b/lib/paymill.rb index <HASH>..<HASH> 100644 --- a/lib/paymill.rb +++ b/lib/paymill.rb @@ -51,13 +51,15 @@ module Paymill https_request = case http_method when :post Net::HTTP::Post.new(url) + when :put + Net::HTTP::Put.new...
dangerous mock tests are dangerous. time for webmock, fakeweb or vcr style integration tests.
diff --git a/libraries/joomla/database/database/mysql.php b/libraries/joomla/database/database/mysql.php index <HASH>..<HASH> 100644 --- a/libraries/joomla/database/database/mysql.php +++ b/libraries/joomla/database/database/mysql.php @@ -175,6 +175,44 @@ class JDatabaseMySQL extends JDatabase } /** + * Gets an ...
Add getExporter and getImporter methods to lazy load the respective helpers classes.
diff --git a/client/modules/Weather.py b/client/modules/Weather.py index <HASH>..<HASH> 100644 --- a/client/modules/Weather.py +++ b/client/modules/Weather.py @@ -76,12 +76,18 @@ def handle(text, mic, profile): for entry in forecast: try: date_desc = entry['title'].split()[0].strip().lower() ...
Weather module parses global forecasts correctly The weather module now checks to see if it is a global forecast, as the parsing needs to be slightly different if so
diff --git a/testing/wd_wrapper.py b/testing/wd_wrapper.py index <HASH>..<HASH> 100644 --- a/testing/wd_wrapper.py +++ b/testing/wd_wrapper.py @@ -25,7 +25,7 @@ class WorkDir: return do(cmd, self.cwd) - def write(self, name: str, content: "str | bytes", /, **kw: object) -> Path: + def write(self, nam...
restore python <I> support
diff --git a/lib/chrome/websockets.js b/lib/chrome/websockets.js index <HASH>..<HASH> 100644 --- a/lib/chrome/websockets.js +++ b/lib/chrome/websockets.js @@ -23,11 +23,13 @@ module.exports = function(tab) { ws.on('open', () => { resolve(chrome) - chrome.send('Page.addScriptToEvaluateOnLoad', { - ...
Reenable page and debugger to make scriptParsed fire
diff --git a/test/specs/Routine.spec.js b/test/specs/Routine.spec.js index <HASH>..<HASH> 100644 --- a/test/specs/Routine.spec.js +++ b/test/specs/Routine.spec.js @@ -1,6 +1,6 @@ /* global describe, it, beforeEach */ -import Routine from '../../lib/Routine'; +import Routine from '../../src/Routine'; import {expect,...
use src instead of lib files in tests (#5)
diff --git a/lib/yard/server/commands/library_command.rb b/lib/yard/server/commands/library_command.rb index <HASH>..<HASH> 100644 --- a/lib/yard/server/commands/library_command.rb +++ b/lib/yard/server/commands/library_command.rb @@ -60,9 +60,12 @@ module YARD def initialize_gem @gem = true ...
Fix on-demand building of gems
diff --git a/lib/neo4j/tasks/neo4j_server.rb b/lib/neo4j/tasks/neo4j_server.rb index <HASH>..<HASH> 100644 --- a/lib/neo4j/tasks/neo4j_server.rb +++ b/lib/neo4j/tasks/neo4j_server.rb @@ -62,13 +62,12 @@ namespace :neo4j do end def install_location(args) - "neo4j-#{get_environment(args)}" + FileUtils.mkdir...
Changed rake task so that it installs database in db folder
diff --git a/myanimelist/media_list.py b/myanimelist/media_list.py index <HASH>..<HASH> 100644 --- a/myanimelist/media_list.py +++ b/myanimelist/media_list.py @@ -38,7 +38,7 @@ class MediaList(Base, collections.Mapping): def __init__(self, session, user_name): super(MediaList, self).__init__(session) self....
Actually, one-letter names exist, too.
diff --git a/openquake/engine/calculators/risk/scenario_risk/core.py b/openquake/engine/calculators/risk/scenario_risk/core.py index <HASH>..<HASH> 100644 --- a/openquake/engine/calculators/risk/scenario_risk/core.py +++ b/openquake/engine/calculators/risk/scenario_risk/core.py @@ -45,7 +45,6 @@ def scenario(workflow, ...
Moved the mask for arrays with missing costs in the engine
diff --git a/modules/backend/formwidgets/PermissionEditor.php b/modules/backend/formwidgets/PermissionEditor.php index <HASH>..<HASH> 100644 --- a/modules/backend/formwidgets/PermissionEditor.php +++ b/modules/backend/formwidgets/PermissionEditor.php @@ -55,11 +55,29 @@ class PermissionEditor extends FormWidgetBase ...
Prevent privilege escalation from crafted requests Follow up to <URL>
diff --git a/packages/components/bolt-accordion/accordion.schema.js b/packages/components/bolt-accordion/accordion.schema.js index <HASH>..<HASH> 100644 --- a/packages/components/bolt-accordion/accordion.schema.js +++ b/packages/components/bolt-accordion/accordion.schema.js @@ -22,6 +22,7 @@ module.exports = { t...
DS-<I>: Add bool enum back in, to be addressed in separate PR
diff --git a/endless_pagination/models.py b/endless_pagination/models.py index <HASH>..<HASH> 100644 --- a/endless_pagination/models.py +++ b/endless_pagination/models.py @@ -234,3 +234,7 @@ class PageList(utils.UnicodeMixin): self._page.next_page_number(), label=settings.NEXT_LABEL) ...
Implemented and tested the PageList.paginated method.
diff --git a/asset_allocation/loader.py b/asset_allocation/loader.py index <HASH>..<HASH> 100644 --- a/asset_allocation/loader.py +++ b/asset_allocation/loader.py @@ -34,7 +34,7 @@ class AssetAllocationLoader: cash_root_name = cfg.get(ConfigKeys.cash_root) # Load cash from all accounts under the root....
allow opening gnucash book even if open in gnucash application. <I>
diff --git a/mod/quiz/review.php b/mod/quiz/review.php index <HASH>..<HASH> 100644 --- a/mod/quiz/review.php +++ b/mod/quiz/review.php @@ -38,6 +38,7 @@ require_login($course->id, false, $cm); $isteacher = isteacher($course->id); + $options = quiz_get_reviewoptions($quiz, $attempt, $isteacher); $pop...
mod/quiz/review quiz options loaded once per pageload, not once per qn. Moved loading of quiz review options from loop iterating over each qn to be displayed, to the top of the pageload. Should give efficency gains on quizes with long pages, as well as making the options available earlier in the process. Credit: Peter...
diff --git a/libinput/constant.py b/libinput/constant.py index <HASH>..<HASH> 100755 --- a/libinput/constant.py +++ b/libinput/constant.py @@ -145,7 +145,8 @@ class EventType(Enum): if self in {type(self).GESTURE_SWIPE_BEGIN, type(self).GESTURE_SWIPE_END, type(self).GESTURE_SWIPE_UPDATE, type(self).GESTURE_PIN...
Add the GESTURE_HOLD_START and GESTURE_HOLD_END to the is_gesture method.
diff --git a/src/main/java/org/fxmisc/wellbehaved/event/EventHandlerHelper.java b/src/main/java/org/fxmisc/wellbehaved/event/EventHandlerHelper.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/fxmisc/wellbehaved/event/EventHandlerHelper.java +++ b/src/main/java/org/fxmisc/wellbehaved/event/EventHandlerHelper.ja...
Add EventHandlerHelper.installAfter method to install an event handler with the lowest priority.
diff --git a/tilequeue/queue/file.py b/tilequeue/queue/file.py index <HASH>..<HASH> 100644 --- a/tilequeue/queue/file.py +++ b/tilequeue/queue/file.py @@ -6,10 +6,10 @@ class OutputFileQueue(object): def __init__(self, fp): self.fp = fp - self.lock = threading.RLock() + self._lock = thread...
Rename lock to _lock to imply that it's private. tilequeue/queue/file.py -The `lock` instance variable shouldn't be used outside of the `OutputFileQueue`'s methods.
diff --git a/services/puppetforge/puppetforge-module-pdk-version.tester.js b/services/puppetforge/puppetforge-module-pdk-version.tester.js index <HASH>..<HASH> 100644 --- a/services/puppetforge/puppetforge-module-pdk-version.tester.js +++ b/services/puppetforge/puppetforge-module-pdk-version.tester.js @@ -11,7 +11,7 @@...
tests: fix failing puppet forge service test (#<I>)
diff --git a/Entity/CountryContext.php b/Entity/CountryContext.php index <HASH>..<HASH> 100644 --- a/Entity/CountryContext.php +++ b/Entity/CountryContext.php @@ -45,7 +45,7 @@ class CountryContext /** * @var string - * @ORM\Column(type="simple_array") + * @ORM\Column(type="simple_array", nullable=...
fix nullable state of country context
diff --git a/tika/tika.py b/tika/tika.py index <HASH>..<HASH> 100644 --- a/tika/tika.py +++ b/tika/tika.py @@ -273,6 +273,8 @@ def getRemoteFile(urlOrPath, destPath): urlp = urlparse(urlOrPath) if urlp.scheme == '': return (os.path.abspath(urlOrPath), 'local') + elif urlp.scheme not in ('http', 'h...
Fix for Windows-style paths with C: schemes and so forth. Identified by <EMAIL> this closes #<I>
diff --git a/connection.go b/connection.go index <HASH>..<HASH> 100644 --- a/connection.go +++ b/connection.go @@ -110,7 +110,7 @@ func NewConnection(solrUrl string) (*Connection, error) { } func (c *Connection) Select(selectQuery string) (*SelectResponse, error) { - r, err := HTTPGet(fmt.Sprintf("%s/select?%s", c....
Adding / to select url
diff --git a/py/testdir_multi_jvm/test_GLM_big1_nopoll.py b/py/testdir_multi_jvm/test_GLM_big1_nopoll.py index <HASH>..<HASH> 100644 --- a/py/testdir_multi_jvm/test_GLM_big1_nopoll.py +++ b/py/testdir_multi_jvm/test_GLM_big1_nopoll.py @@ -47,7 +47,8 @@ class Basic(unittest.TestCase): # if we do another poll th...
print some extra info for debug of ec2 fail
diff --git a/src/grid/PartGridView.php b/src/grid/PartGridView.php index <HASH>..<HASH> 100644 --- a/src/grid/PartGridView.php +++ b/src/grid/PartGridView.php @@ -205,7 +205,7 @@ class PartGridView extends BoxedGridView 'filter' => false, 'format' => 'raw', 'value' => ...
Fixed typo for `selling_time` column in PartGridView
diff --git a/test/cmd.js b/test/cmd.js index <HASH>..<HASH> 100644 --- a/test/cmd.js +++ b/test/cmd.js @@ -14,7 +14,7 @@ var validateNpmName = require('validate-npm-package-name') var APP_START_STOP_TIMEOUT = 10000 var PKG_PATH = path.resolve(__dirname, '..', 'package.json') var BIN_PATH = path.resolve(path.dirname(...
tests: increase timeout for npm install
diff --git a/org/postgresql/core/Parser.java b/org/postgresql/core/Parser.java index <HASH>..<HASH> 100644 --- a/org/postgresql/core/Parser.java +++ b/org/postgresql/core/Parser.java @@ -83,6 +83,9 @@ public class Parser { break; case '?': + if (!withParameters) + break; + ...
Replace question marks only in PreparedStatements Question marks in the query text should be replaced with positional parameters ($1, $2, ...) only in java.sql.PreparedStatement. In a java.sql.Statement they should be left alone.
diff --git a/Gruntfile.js b/Gruntfile.js index <HASH>..<HASH> 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -173,6 +173,10 @@ module.exports = function(grunt) { }, }); + // update various components + grunt.registerTask( 'update:iana', ['curl:update-iana'] ); + grunt.registerTask( 'update:html5'...
Grunt: new alias naming pattern for updating components
diff --git a/src/Converter/BaseConverter.php b/src/Converter/BaseConverter.php index <HASH>..<HASH> 100644 --- a/src/Converter/BaseConverter.php +++ b/src/Converter/BaseConverter.php @@ -20,16 +20,10 @@ abstract class BaseConverter implements EventConverterInterface { $q = 'MERGE (user:User {id: {user_id}...
simpler event, user merge io create for event
diff --git a/robovm/src/playn/robovm/RoboAudio.java b/robovm/src/playn/robovm/RoboAudio.java index <HASH>..<HASH> 100644 --- a/robovm/src/playn/robovm/RoboAudio.java +++ b/robovm/src/playn/robovm/RoboAudio.java @@ -163,6 +163,10 @@ public class RoboAudio extends AudioImpl { } } + void delete(RoboSoundOAL sou...
Delete OAL sounds when released.
diff --git a/rpi-gpio.js b/rpi-gpio.js index <HASH>..<HASH> 100755 --- a/rpi-gpio.js +++ b/rpi-gpio.js @@ -414,18 +414,18 @@ function createListener(channel, pin, pollers, onChange) { var fd = fs.openSync(PATH + '/gpio' + pin + '/value', 'r+'); clearInterrupt(fd); poller.add(fd, Epoll.EPOLLPRI); - pol...
Make pollers store a self-removal function
diff --git a/lib/ronin/database/database.rb b/lib/ronin/database/database.rb index <HASH>..<HASH> 100644 --- a/lib/ronin/database/database.rb +++ b/lib/ronin/database/database.rb @@ -262,18 +262,22 @@ module Ronin # The given block will be ran within the context of each Database # repository. # - ...
Renamed Database.each to Database.map. * Choosing `map` since we're applying a block to each DataMapper repository, and returning the accumulated results.
diff --git a/lib/sugarcrm/finders/finder_methods.rb b/lib/sugarcrm/finders/finder_methods.rb index <HASH>..<HASH> 100644 --- a/lib/sugarcrm/finders/finder_methods.rb +++ b/lib/sugarcrm/finders/finder_methods.rb @@ -225,7 +225,7 @@ module SugarCRM; module FinderMethods end VALID_FIND_OPTIONS = [ :con...
remove :query from VALID_OPTIONS snuck in previously by mistake
diff --git a/packer/multi_error.go b/packer/multi_error.go index <HASH>..<HASH> 100644 --- a/packer/multi_error.go +++ b/packer/multi_error.go @@ -37,10 +37,6 @@ func MultiErrorAppend(err error, errs ...error) *MultiError { err = new(MultiError) } - if err.Errors == nil { - err.Errors = make([]error, 0, len...
packer: no need to check if nil since we're appending to slice
diff --git a/anonymoususage/tables/statistic.py b/anonymoususage/tables/statistic.py index <HASH>..<HASH> 100644 --- a/anonymoususage/tables/statistic.py +++ b/anonymoususage/tables/statistic.py @@ -36,15 +36,7 @@ class Statistic(Table): return self def __sub__(self, i): - count = self.count - i ...
In __sub__, rather than trying to delete the row with the specific count (which may not even exist, eg doing +=5 then -= 2), add a new row with the lower count
diff --git a/lib/plugins/thirdparty/index.js b/lib/plugins/thirdparty/index.js index <HASH>..<HASH> 100644 --- a/lib/plugins/thirdparty/index.js +++ b/lib/plugins/thirdparty/index.js @@ -6,7 +6,8 @@ const urlParser = require('url'); const DEFAULT_THIRDPARTY_PAGESUMMARY_METRICS = [ 'category.*.requests.*', - 'cat...
Store total number of 3rd party request (#<I>)
diff --git a/lib/config.js b/lib/config.js index <HASH>..<HASH> 100644 --- a/lib/config.js +++ b/lib/config.js @@ -27,10 +27,6 @@ var path = require("path"), var unclustered = ["memory", "disk", "leveldb"]; -function warnInternalConfig(key, log) { - log.warn("`" + key + "` is an internal config value which will...
Remove dead code from lib/config.js In particular, this brings our line coverage for this module to <I>%. Woot woot!
diff --git a/lib/tri/declarative/__init__.py b/lib/tri/declarative/__init__.py index <HASH>..<HASH> 100644 --- a/lib/tri/declarative/__init__.py +++ b/lib/tri/declarative/__init__.py @@ -373,13 +373,13 @@ def filter_show_recursive(item): if isinstance(item, list): return [filter_show_recursive(v) for v in...
Micro-optimization: dicts are more common than sets
diff --git a/ReText/window.py b/ReText/window.py index <HASH>..<HASH> 100644 --- a/ReText/window.py +++ b/ReText/window.py @@ -458,15 +458,14 @@ class ReTextWindow(QMainWindow): cursor.beginEditBlock() while block != end: cursor.setPosition(block.position()) - if self.tabInsertsSpaces: + if editBox.docume...
editBoxIndentLess: correctly de-dent both tabulated and "spaced" text
diff --git a/keanu-project/src/test/java/io/improbable/keanu/vertices/dbl/nonprobabilistic/operators/multiple/LambdaModelVertexTest.java b/keanu-project/src/test/java/io/improbable/keanu/vertices/dbl/nonprobabilistic/operators/multiple/LambdaModelVertexTest.java index <HASH>..<HASH> 100644 --- a/keanu-project/src/test/...
Reduce number of samples to fix broken build
diff --git a/blocks/myoverview/lang/en/block_myoverview.php b/blocks/myoverview/lang/en/block_myoverview.php index <HASH>..<HASH> 100644 --- a/blocks/myoverview/lang/en/block_myoverview.php +++ b/blocks/myoverview/lang/en/block_myoverview.php @@ -63,7 +63,7 @@ $string['privacy:metadata:overviewgroupingpreference'] = 'T...
MDL-<I> block myoverview: change title string to course change language string for Sort by "Title" to "Course"
diff --git a/termformat/__init__.py b/termformat/__init__.py index <HASH>..<HASH> 100644 --- a/termformat/__init__.py +++ b/termformat/__init__.py @@ -7,7 +7,7 @@ __is_cython__ = False try: # Python 2.7 long = long -except NameError: +except NameError: # pragma: no cover # Python 3.3 unicode = str xrang...
Disable coverage for python3 stuff
diff --git a/container/noxfile.py b/container/noxfile.py index <HASH>..<HASH> 100644 --- a/container/noxfile.py +++ b/container/noxfile.py @@ -75,7 +75,7 @@ def system(session): session.install('-e', '.') # Run py.test against the system tests. - session.run('py.test', '--quiet', 'tests/system/') + se...
Pass posargs to py.test (#<I>)
diff --git a/lib/segment.rb b/lib/segment.rb index <HASH>..<HASH> 100644 --- a/lib/segment.rb +++ b/lib/segment.rb @@ -18,6 +18,10 @@ class Segment response = get "active", options Hashie::Mash.new(response) end + + def clear_rules + response = CreateSend.delete "/segments/#{segment_id}/rules.json", ...
Added ability to clear a segment's rules.
diff --git a/src/Conner/Tagging/TaggingUtil.php b/src/Conner/Tagging/TaggingUtil.php index <HASH>..<HASH> 100644 --- a/src/Conner/Tagging/TaggingUtil.php +++ b/src/Conner/Tagging/TaggingUtil.php @@ -4,14 +4,14 @@ use Conner\Tagging\Tag; /** * Utility functions to help with various tagging functionality. - * + * ...
trying a fix for hhvm
diff --git a/stomp/backward.py b/stomp/backward.py index <HASH>..<HASH> 100755 --- a/stomp/backward.py +++ b/stomp/backward.py @@ -3,15 +3,6 @@ import sys # # Functions for backwards compatibility # - -def get_func_argcount(func): - """ - Return the argument count for a function - """ - if sys.he...
change listener to use consistent number of args - two
diff --git a/lib/Cake/Test/Case/View/ViewTest.php b/lib/Cake/Test/Case/View/ViewTest.php index <HASH>..<HASH> 100644 --- a/lib/Cake/Test/Case/View/ViewTest.php +++ b/lib/Cake/Test/Case/View/ViewTest.php @@ -21,6 +21,7 @@ App::uses('View', 'View'); App::uses('Helper', 'View'); App::uses('Controller', 'Controller'); A...
Add missing import that causes tests to fail in isolation.
diff --git a/addon/serializers/contributor.js b/addon/serializers/contributor.js index <HASH>..<HASH> 100644 --- a/addon/serializers/contributor.js +++ b/addon/serializers/contributor.js @@ -8,11 +8,12 @@ export default OsfSerializer.extend({ serialized.data.relationships = { users: { ...
Use Contrib.id until compound ids are ready
diff --git a/spec/unit/type/exec_spec.rb b/spec/unit/type/exec_spec.rb index <HASH>..<HASH> 100755 --- a/spec/unit/type/exec_spec.rb +++ b/spec/unit/type/exec_spec.rb @@ -755,7 +755,7 @@ describe Puppet::Type.type(:exec) do end describe "when providing a umask" do it "should fail if an invalid umask is used"...
(maint) Fixing build error on windows caused by command with unix path
diff --git a/lib/trace.js b/lib/trace.js index <HASH>..<HASH> 100644 --- a/lib/trace.js +++ b/lib/trace.js @@ -26,7 +26,7 @@ }; getUniqueId = function () { - var random = new Int64(Math.random() * 0x7fffffff, Math.random() * 0x100000000); + var random = new Int64(Math.random() * 0x80000000, Math.random() * 0x1...
0x<I> is the proper upperbound as Math.random has <I> digit precision
diff --git a/openquake/engine/db/models.py b/openquake/engine/db/models.py index <HASH>..<HASH> 100644 --- a/openquake/engine/db/models.py +++ b/openquake/engine/db/models.py @@ -1453,11 +1453,11 @@ class Gmf(djm.Model): """ # a set of GMFs generate by the same SES, one per rupture gmfset = c...
Fixed an ordering issue Former-commit-id: 1cc<I>ae<I>f<I>e<I>f5bb5f2befedebc0
diff --git a/bin/webpack-dev-server.js b/bin/webpack-dev-server.js index <HASH>..<HASH> 100755 --- a/bin/webpack-dev-server.js +++ b/bin/webpack-dev-server.js @@ -217,9 +217,6 @@ function processOptions(wpOpt) { process.stdin.resume(); } - if(!options.watchDelay && !options.watchOptions) // TODO remove in next m...
Remove deprecated `watchDelay` option that was broken anyway
diff --git a/shim.js b/shim.js index <HASH>..<HASH> 100644 --- a/shim.js +++ b/shim.js @@ -1 +1 @@ -require('./src/contra.shim.js'); +require('./contra.shim.js');
fix broken require in shim.js
diff --git a/bundle/Command/GenerateImageVariationsCommand.php b/bundle/Command/GenerateImageVariationsCommand.php index <HASH>..<HASH> 100644 --- a/bundle/Command/GenerateImageVariationsCommand.php +++ b/bundle/Command/GenerateImageVariationsCommand.php @@ -10,14 +10,14 @@ use eZ\Publish\API\Repository\Values\Content\...
Command does not need to be container aware
diff --git a/saunter/po/webdriver/page.py b/saunter/po/webdriver/page.py index <HASH>..<HASH> 100644 --- a/saunter/po/webdriver/page.py +++ b/saunter/po/webdriver/page.py @@ -40,6 +40,23 @@ class Page(object): return False else: return False + + def wait_for_available(self, loc...
adding wait_for_available to the webdriver page class
diff --git a/lib/subprocess.rb b/lib/subprocess.rb index <HASH>..<HASH> 100644 --- a/lib/subprocess.rb +++ b/lib/subprocess.rb @@ -499,7 +499,7 @@ module Subprocess @stdin.close wait_w.delete(@stdin) end - input[0...written] = '' + input = input[written.....
Make Process#communicate do less work on every iteration (#<I>) * Make Process#communicate do less work on every iteration
diff --git a/src/BaseRepository.php b/src/BaseRepository.php index <HASH>..<HASH> 100644 --- a/src/BaseRepository.php +++ b/src/BaseRepository.php @@ -94,6 +94,10 @@ abstract class BaseRepository implements BaseRepositoryInterface $this->onceCriteria = new Collection(); $this->activeCriteria = new C...
Falling back to configuration value if perPage property is falsy or less than 1
diff --git a/coursera/test/test_credentials.py b/coursera/test/test_credentials.py index <HASH>..<HASH> 100644 --- a/coursera/test/test_credentials.py +++ b/coursera/test/test_credentials.py @@ -46,8 +46,8 @@ def test_get_credentials_with_invalid_netrc_raises_exception(): def test_get_credentials_with_username_and...
test: test_credentials: Use more natural/readable wrapping.
diff --git a/packages/neos-ui-contentrepository/src/registry/NodeTypesRegistry.js b/packages/neos-ui-contentrepository/src/registry/NodeTypesRegistry.js index <HASH>..<HASH> 100644 --- a/packages/neos-ui-contentrepository/src/registry/NodeTypesRegistry.js +++ b/packages/neos-ui-contentrepository/src/registry/NodeTypesR...
TASK: Add logic to discover arbitrary inline editors