diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/LastInboundHandler.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/LastInboundHandler.java index <HASH>..<HASH> 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/LastInboundHandler.java +++ b/codec-http2/src/test/java/io...
Change String comparison to equals() from == (#<I>) Motivation: Even if it was stored in the string constant pool, I thought it was safe to compare it through the Equals() method. Modification: So, I changed "==" comparison to equals() comparison Result: It has become safer to compare String values with...
diff --git a/src/Leevel/Protocol/Server.php b/src/Leevel/Protocol/Server.php index <HASH>..<HASH> 100755 --- a/src/Leevel/Protocol/Server.php +++ b/src/Leevel/Protocol/Server.php @@ -580,8 +580,8 @@ abstract class Server throw new InvalidArgumentException($e); } - if (version_compare(phpv...
chore: update swoole version
diff --git a/lib/appsignal/railtie.rb b/lib/appsignal/railtie.rb index <HASH>..<HASH> 100644 --- a/lib/appsignal/railtie.rb +++ b/lib/appsignal/railtie.rb @@ -1,8 +1,5 @@ module Appsignal class Railtie < Rails::Railtie - rake_tasks do - load "tasks/auth_check.rake" - end initializer "appsignal.con...
Remove rake task in favor of CLI
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparablePositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparablePositiveCases.java index <HASH>..<HASH> 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/BadComparablePositive...
BadComparable test case with File. This was a motivating case for BadComparable and so it makes a nice test. RELNOTES: extra BadComparable test. ------------- Created by MOE: <URL>
diff --git a/js/angular/components/notification/notification.js b/js/angular/components/notification/notification.js index <HASH>..<HASH> 100644 --- a/js/angular/components/notification/notification.js +++ b/js/angular/components/notification/notification.js @@ -230,7 +230,9 @@ // close if autoclose ...
Change to autoclose notification to prevent notification from reappearing after swipe.
diff --git a/src/main/java/io/github/lukehutch/fastclasspathscanner/json/JSONMapper.java b/src/main/java/io/github/lukehutch/fastclasspathscanner/json/JSONMapper.java index <HASH>..<HASH> 100644 --- a/src/main/java/io/github/lukehutch/fastclasspathscanner/json/JSONMapper.java +++ b/src/main/java/io/github/lukehutch/fas...
Pass in indentWidth
diff --git a/generators/generator-constants.js b/generators/generator-constants.js index <HASH>..<HASH> 100644 --- a/generators/generator-constants.js +++ b/generators/generator-constants.js @@ -54,7 +54,7 @@ const DOCKER_JAVA_JRE = 'eclipse-temurin:11-jre-focal'; const DOCKER_MYSQL = 'mysql:8.0.27'; const DOCKER_MAR...
Update mongo docker image version to <I>
diff --git a/sunspot/lib/sunspot/query/restriction.rb b/sunspot/lib/sunspot/query/restriction.rb index <HASH>..<HASH> 100644 --- a/sunspot/lib/sunspot/query/restriction.rb +++ b/sunspot/lib/sunspot/query/restriction.rb @@ -353,6 +353,10 @@ module Sunspot @field.to_indexed(value) end + def t...
negative boolean phrase for AbstractRange
diff --git a/lib/app.js b/lib/app.js index <HASH>..<HASH> 100644 --- a/lib/app.js +++ b/lib/app.js @@ -5,7 +5,7 @@ var Performer = require('./performer') function App(opts) { var options = opts || {}; - var ydmHome = process.env.YDM_HOME || path.join(process.env.HOME, '.ydm') + var ydmHome = process.env.YDM_HOM...
don't break when no HOME set
diff --git a/Package/Loader/LazyAssetPackageLoader.php b/Package/Loader/LazyAssetPackageLoader.php index <HASH>..<HASH> 100644 --- a/Package/Loader/LazyAssetPackageLoader.php +++ b/Package/Loader/LazyAssetPackageLoader.php @@ -174,6 +174,10 @@ class LazyAssetPackageLoader implements LazyLoaderInterface if (fal...
Fix output without verbose option when package file is not found
diff --git a/ara/cli/playbook.py b/ara/cli/playbook.py index <HASH>..<HASH> 100644 --- a/ara/cli/playbook.py +++ b/ara/cli/playbook.py @@ -92,8 +92,29 @@ class PlaybookList(Lister): query["limit"] = args.limit playbooks = client.get("/api/v1/playbooks", **query) - columns = ("id", "status", "...
CLI: Add number of items in 'playbook list' This adds columns to display the number of plays, tasks, results, hosts, files and records in each playbook. Change-Id: If<I>e<I>e<I>b<I>d3c<I>e0ec<I>fee<I>f9c<I>
diff --git a/lib/query_report/report_pdf.rb b/lib/query_report/report_pdf.rb index <HASH>..<HASH> 100755 --- a/lib/query_report/report_pdf.rb +++ b/lib/query_report/report_pdf.rb @@ -50,7 +50,7 @@ module QueryReport end def humanized_table_header - report_columns.collect(&:humanize) + report_colum...
Added feature to sanitize the pdf content
diff --git a/nipap/nipap/nipapconfig.py b/nipap/nipap/nipapconfig.py index <HASH>..<HASH> 100644 --- a/nipap/nipap/nipapconfig.py +++ b/nipap/nipap/nipapconfig.py @@ -25,7 +25,7 @@ class NipapConfig(ConfigParser.SafeConfigParser): raise NipapConfigError("missing configuration file") self._...
Python <I> compliance Removed allow_no_value from config object as it's newer than Python <I>.
diff --git a/patroni/postgresql.py b/patroni/postgresql.py index <HASH>..<HASH> 100644 --- a/patroni/postgresql.py +++ b/patroni/postgresql.py @@ -1216,7 +1216,8 @@ class Postgresql(object): if data: data = data.decode('utf-8').splitlines() # pg_controldata out...
check if output lines of controldata are possible to split (#<I>) Otherwise it fails with scary stacktrace
diff --git a/graphsrv/static/js/graphsrv.mtr.js b/graphsrv/static/js/graphsrv.mtr.js index <HASH>..<HASH> 100644 --- a/graphsrv/static/js/graphsrv.mtr.js +++ b/graphsrv/static/js/graphsrv.mtr.js @@ -44,6 +44,9 @@ $gs.components.register( }, + "init_popover": function() { + }, + "default_options" : f...
disable popover in mtr graph for now
diff --git a/app/assets/javascripts/lentil/buttonhandler.js b/app/assets/javascripts/lentil/buttonhandler.js index <HASH>..<HASH> 100644 --- a/app/assets/javascripts/lentil/buttonhandler.js +++ b/app/assets/javascripts/lentil/buttonhandler.js @@ -2,7 +2,7 @@ function buttonhandler() { $(".like-btn, .flag-confirm...
check for image id on standalone image page
diff --git a/salt/utils/sanitisers.py b/salt/utils/sanitisers.py index <HASH>..<HASH> 100644 --- a/salt/utils/sanitisers.py +++ b/salt/utils/sanitisers.py @@ -55,5 +55,7 @@ class InputSanitizer(object): ''' return re.sub(r'[^a-zA-Z0-9.-]', '', InputSanitizer.trim(value)) + id = hostname + clea...
Add a stub for ID sanitiser (at the moment same as hostname)
diff --git a/lib/gearman/multiserver-worker.js b/lib/gearman/multiserver-worker.js index <HASH>..<HASH> 100644 --- a/lib/gearman/multiserver-worker.js +++ b/lib/gearman/multiserver-worker.js @@ -21,11 +21,10 @@ var log = require('../log'); * @return {Object} */ -function MultiserverWorker(servers, func_name, call...
Remove dependecy injection from MultiserverClient
diff --git a/dpark/schedule.py b/dpark/schedule.py index <HASH>..<HASH> 100644 --- a/dpark/schedule.py +++ b/dpark/schedule.py @@ -748,7 +748,7 @@ class DAGScheduler(Scheduler): if self.loghub_dir: self._dump_stats(stats) except Exception as e: - logger.exception("Fail ...
Adjust log level of ""Fail to dump job stats" to warning.
diff --git a/src/main/java/com/parship/roperty/KeyValues.java b/src/main/java/com/parship/roperty/KeyValues.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/parship/roperty/KeyValues.java +++ b/src/main/java/com/parship/roperty/KeyValues.java @@ -58,7 +58,7 @@ public class KeyValues { return addOrChangeDomai...
Removed synchronized modifier, because ConcurrentSkipListSet has an own concurrency mechanism
diff --git a/terraform/resource_test.go b/terraform/resource_test.go index <HASH>..<HASH> 100644 --- a/terraform/resource_test.go +++ b/terraform/resource_test.go @@ -40,6 +40,12 @@ func TestResourceConfigGet(t *testing.T) { Value interface{} }{ { + Config: nil, + Key: "foo", + Value: nil, + }, + + {...
terraform: test to make sure nil in RawConfig is okay
diff --git a/hystrix-core/src/main/java/com/netflix/hystrix/AbstractCommand.java b/hystrix-core/src/main/java/com/netflix/hystrix/AbstractCommand.java index <HASH>..<HASH> 100644 --- a/hystrix-core/src/main/java/com/netflix/hystrix/AbstractCommand.java +++ b/hystrix-core/src/main/java/com/netflix/hystrix/AbstractComman...
Replace explicit iteration with library support for fast list creation
diff --git a/tornadis/__init__.py b/tornadis/__init__.py index <HASH>..<HASH> 100644 --- a/tornadis/__init__.py +++ b/tornadis/__init__.py @@ -4,14 +4,12 @@ # This file is part of tornadis library released under the MIT license. # See the LICENSE file for more information. -version_info = (0, 0, '1') +version_info ...
remove two unused const and preparing <I> release
diff --git a/packages/node-krl-parser/tests/parser.test.js b/packages/node-krl-parser/tests/parser.test.js index <HASH>..<HASH> 100644 --- a/packages/node-krl-parser/tests/parser.test.js +++ b/packages/node-krl-parser/tests/parser.test.js @@ -2059,6 +2059,11 @@ test("Action setting", function(t){ var src = "rulese...
testing action setting support in defaction
diff --git a/fuse.py b/fuse.py index <HASH>..<HASH> 100644 --- a/fuse.py +++ b/fuse.py @@ -382,15 +382,15 @@ class Stat(FuseStruct): def __init__(self, **kw): self.st_mode = None - self.st_ino = None - self.st_dev = None + self.st_ino = 0 + self.st_dev = 0 s...
the FuseStat initializatior sets a default zero value for some of the stat fields
diff --git a/openid/codecutil.py b/openid/codecutil.py index <HASH>..<HASH> 100644 --- a/openid/codecutil.py +++ b/openid/codecutil.py @@ -50,13 +50,7 @@ def _in_escape_range(octet): return False -def _pct_escape_handler(err): - ''' - Encoding error handler that does percent-escaping of Unicode, to be us...
Factor out percent-encoding into separate function in codecutil, for debugging / testing
diff --git a/lib/validation.js b/lib/validation.js index <HASH>..<HASH> 100644 --- a/lib/validation.js +++ b/lib/validation.js @@ -2,6 +2,9 @@ const Joi = require( 'joi' ); +// pre-load +require( 'joi/lib/any' ); + const utils = require( './utils' ); const ignoredProperties = require( './ignored-properties' );...
Added preload and warm-up code for validation testing - reduces time for cold runs
diff --git a/tests/integration/price/testcases/basket/testFrontendOrderStep1DeliverySortedWithCategories(1).php b/tests/integration/price/testcases/basket/testFrontendOrderStep1DeliverySortedWithCategories(1).php index <HASH>..<HASH> 100644 --- a/tests/integration/price/testcases/basket/testFrontendOrderStep1DeliverySo...
marked as skipped (cherry picked from commit <I>b1c5) (cherry picked from commit 7c9cbdd)
diff --git a/lib/schema_monkey/railtie.rb b/lib/schema_monkey/railtie.rb index <HASH>..<HASH> 100644 --- a/lib/schema_monkey/railtie.rb +++ b/lib/schema_monkey/railtie.rb @@ -8,10 +8,14 @@ module SchemaMonkey end rake_tasks do - load 'rails/tasks/database.rake' + namespace :schema_monkey do + ...
bug fix: replace dangling rails/tasks/database.rake with the correct task inline
diff --git a/lib/numina/recipes/__init__.py b/lib/numina/recipes/__init__.py index <HASH>..<HASH> 100644 --- a/lib/numina/recipes/__init__.py +++ b/lib/numina/recipes/__init__.py @@ -62,8 +62,8 @@ class RecipeBase: self.repeat = run.get('repeat', 1) self._current = 0 - def setup(s...
setup method is reserrected
diff --git a/misc/log-analytics/import_logs.py b/misc/log-analytics/import_logs.py index <HASH>..<HASH> 100755 --- a/misc/log-analytics/import_logs.py +++ b/misc/log-analytics/import_logs.py @@ -1353,7 +1353,7 @@ class Parser(object): hit.host = config.options.log_hostname else: ...
import_logs.py: lowercase the host and strip dots at both ends. git-svn-id: <URL>
diff --git a/lib/ronin/config.rb b/lib/ronin/config.rb index <HASH>..<HASH> 100644 --- a/lib/ronin/config.rb +++ b/lib/ronin/config.rb @@ -38,10 +38,14 @@ module Ronin # Temporary file directory TMP_DIR = File.join(PATH,'tmp') + + # Directory for storing recovered remote files + FILES_DIR = File.join(...
Added the ~/.ronin/files/ directory for storing RemoteFiles.
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -271,7 +271,7 @@ def get_version_info(): # If this is a release or another kind of source distribution of PyCBC except: - version = '1.7.5' + version = '1.7.6' release = 'True' date ...
set for <I> release (#<I>)
diff --git a/fermipy/jobs/batch.py b/fermipy/jobs/batch.py index <HASH>..<HASH> 100644 --- a/fermipy/jobs/batch.py +++ b/fermipy/jobs/batch.py @@ -48,7 +48,7 @@ def get_batch_job_interface(job_time=1500): if DEFAULT_JOB_TYPE == 'slac': from fermipy.jobs.slac_impl import SlacInterface - return Sla...
Fix a couple of minor issues left over from code cleanup
diff --git a/lib/conceptql/database.rb b/lib/conceptql/database.rb index <HASH>..<HASH> 100644 --- a/lib/conceptql/database.rb +++ b/lib/conceptql/database.rb @@ -1,4 +1,4 @@ -require 'facets/core/hash/revalue' +require 'facets/hash/revalue' module ConceptQL class Database
Fix incorrect require of hash/revalue
diff --git a/lib/shopify_theme/cli.rb b/lib/shopify_theme/cli.rb index <HASH>..<HASH> 100644 --- a/lib/shopify_theme/cli.rb +++ b/lib/shopify_theme/cli.rb @@ -19,7 +19,7 @@ module ShopifyTheme desc "configure API_KEY PASSWORD STORE", "generate a config file for the store to connect to" def configure(api_key...
default ignore files config, delete should check the ignore files as well
diff --git a/Model/Variant.php b/Model/Variant.php index <HASH>..<HASH> 100644 --- a/Model/Variant.php +++ b/Model/Variant.php @@ -13,7 +13,6 @@ namespace Sylius\Component\Variation\Model; use Doctrine\Common\Collections\ArrayCollection; use Doctrine\Common\Collections\Collection; -use Sylius\Component\Resource\Mod...
Get rid of the SoftDeletable Interface and Trait
diff --git a/lib/ovirt/vm.rb b/lib/ovirt/vm.rb index <HASH>..<HASH> 100644 --- a/lib/ovirt/vm.rb +++ b/lib/ovirt/vm.rb @@ -174,8 +174,9 @@ module OVIRT unless runcmd.nil? runcmd.each do |cmd| cmdlist = \ - "#{cmdlist}\n" \ - "- #{cmd}\n" + "#{cmdlist}\n" \ + "- |\...
Support for multi-line runcmd params In Foreman, we use cloud-init templates like this: ``` runcmd: - | echo 1 echo 2 echo 3 - | echo a echo b echo c ``` Currently, the rbovirt is preparing the cloud-init template, it counts on the fact the runcmd are only single lines, which limits it's ...
diff --git a/urwid_datatable/datatable.py b/urwid_datatable/datatable.py index <HASH>..<HASH> 100644 --- a/urwid_datatable/datatable.py +++ b/urwid_datatable/datatable.py @@ -1255,7 +1255,7 @@ class DataTable(urwid.WidgetWrap, MutableSequence): # raise Exception(columns) # for c in self.columns: ...
Fix another bug with removing columns.
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -250,22 +250,6 @@ function session(options){ : rawCookie; } - // set-cookie - var writeHead = res.writeHead; - res.writeHead = function(){ - if (!req.session) { - debug('no session'); - ...
forgot part of set-cookie to remove
diff --git a/cli/Valet/Valet.php b/cli/Valet/Valet.php index <HASH>..<HASH> 100644 --- a/cli/Valet/Valet.php +++ b/cli/Valet/Valet.php @@ -80,7 +80,7 @@ class Valet $url = 'https://api.github.com/repos/laravel/valet/releases/latest'; $response = Utils::jsonDecode((new Client())->get($url)->getBody());...
Access `tag_name` directly Since `$response` is the response body now the body below is obsolete.
diff --git a/src/android/CameraPreview.java b/src/android/CameraPreview.java index <HASH>..<HASH> 100644 --- a/src/android/CameraPreview.java +++ b/src/android/CameraPreview.java @@ -466,9 +466,6 @@ public class CameraPreview extends CordovaPlugin implements CameraActivity.Camer private boolean setOnPictureTakenHand...
fix: setOnPictureTakenHandler should not be called back immediately after set (#<I>)
diff --git a/wandb/integration/keras/keras.py b/wandb/integration/keras/keras.py index <HASH>..<HASH> 100644 --- a/wandb/integration/keras/keras.py +++ b/wandb/integration/keras/keras.py @@ -1014,7 +1014,8 @@ class WandbCallback(tf.keras.callbacks.Callback): self.model.save(self.filepath[:-3], overwrite=True, ...
sanitize run name (#<I>)
diff --git a/lib/devise/models/timeoutable.rb b/lib/devise/models/timeoutable.rb index <HASH>..<HASH> 100644 --- a/lib/devise/models/timeoutable.rb +++ b/lib/devise/models/timeoutable.rb @@ -12,13 +12,12 @@ module Devise # Checks whether the user session has expired based on configured time. def timeout...
Updating timeoutable with last devise changes.
diff --git a/tests/integration/modules/event.py b/tests/integration/modules/event.py index <HASH>..<HASH> 100644 --- a/tests/integration/modules/event.py +++ b/tests/integration/modules/event.py @@ -81,7 +81,7 @@ class EventModuleTest(integration.ModuleCase): with self.assertRaises(Empty): eventfi...
stub out another event test that needs refinement
diff --git a/cumulusci/core/flows.py b/cumulusci/core/flows.py index <HASH>..<HASH> 100644 --- a/cumulusci/core/flows.py +++ b/cumulusci/core/flows.py @@ -175,7 +175,12 @@ class BaseFlow(object): self._run_task(flow_task_config) def _run_flow(self, flow_task_config): - flow = BaseFlow( + ...
support class override for nested flows
diff --git a/servers/src/main/java/tachyon/UserInfo.java b/servers/src/main/java/tachyon/UserInfo.java index <HASH>..<HASH> 100644 --- a/servers/src/main/java/tachyon/UserInfo.java +++ b/servers/src/main/java/tachyon/UserInfo.java @@ -57,14 +57,14 @@ public class UserInfo { @Override public boolean equals(Obj...
Update UserInfo.java fixed indentation.
diff --git a/test/integration/fixtures/adapter.withHandlers.fixture.js b/test/integration/fixtures/adapter.withHandlers.fixture.js index <HASH>..<HASH> 100644 --- a/test/integration/fixtures/adapter.withHandlers.fixture.js +++ b/test/integration/fixtures/adapter.withHandlers.fixture.js @@ -10,7 +10,7 @@ module.exports ...
Bit more explanation on why we have to look in 'where' in our test fixture for handlers (automatically normalized)
diff --git a/lib/rabbitmq/channel.rb b/lib/rabbitmq/channel.rb index <HASH>..<HASH> 100644 --- a/lib/rabbitmq/channel.rb +++ b/lib/rabbitmq/channel.rb @@ -35,13 +35,13 @@ module RabbitMQ end # @see {Connection#on_event} - def on(event_type, callable=nil, &block) - @connection.on_event(@id, event...
Fix signature of forwarding methods in Channel to be more general.
diff --git a/webpack.config.js b/webpack.config.js index <HASH>..<HASH> 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -1,4 +1,4 @@ require('argv-set-env')(); var webpack = require('./webpack/config')[process.env.NODE_ENV === 'development' ? 'dist' : 'prod']; -module.exports = webpack; \ No newline at en...
style: missing new lines in webpack
diff --git a/lib/hobo/virtual_box.rb b/lib/hobo/virtual_box.rb index <HASH>..<HASH> 100644 --- a/lib/hobo/virtual_box.rb +++ b/lib/hobo/virtual_box.rb @@ -27,6 +27,7 @@ class VirtualBox "cableconnected1" => "on", "nictrace1" => "off", "bridgeadapter1" => "en0: Ethernet", + "maca...
Hard code MAC address for NIC. Must match the base VM.
diff --git a/definitions/npm/react-apollo_v2.x.x/flow_v0.58.x-/react-apollo_v2.x.x.js b/definitions/npm/react-apollo_v2.x.x/flow_v0.58.x-/react-apollo_v2.x.x.js index <HASH>..<HASH> 100644 --- a/definitions/npm/react-apollo_v2.x.x/flow_v0.58.x-/react-apollo_v2.x.x.js +++ b/definitions/npm/react-apollo_v2.x.x/flow_v0.58...
[react-apollo] Fix Query component typing (#<I>) If case of error, result object doesn't contain `data` property, please see the original TypeScript typings: <URL>
diff --git a/lib/cancan/ability.rb b/lib/cancan/ability.rb index <HASH>..<HASH> 100644 --- a/lib/cancan/ability.rb +++ b/lib/cancan/ability.rb @@ -283,9 +283,9 @@ module CanCan protected - def rules - @rules - end + # Must be protected as an ability can merge with other abilities. + # This mea...
Minor ability cleanup. decendants in the alternative_subjects methods will never not be an empty array. We can remove this statement. Make rules an attr_reader and add a bit of documentations as to why it needs to be protected, as this is one of the -few- cases in ruby where it makes sense for it to be so.
diff --git a/kbfsblock/bserver_constants.go b/kbfsblock/bserver_constants.go index <HASH>..<HASH> 100644 --- a/kbfsblock/bserver_constants.go +++ b/kbfsblock/bserver_constants.go @@ -8,5 +8,5 @@ const ( // ServerTokenServer is the expected server type for bserver authentication. ServerTokenServer = "kbfs_block" /...
kbfsmd/kbfsblock: Increase bserver and mdserver token expiry times. Needs to be deployed before any clients start sending such expire times.
diff --git a/define-test.js b/define-test.js index <HASH>..<HASH> 100644 --- a/define-test.js +++ b/define-test.js @@ -1489,3 +1489,18 @@ QUnit.test("async setter is provided", 5, function(){ QUnit.equal(instance.prop2, 9, "used async setter updates after"); }); + +QUnit.test('setter with default value causes an i...
adding test for ininite loop issue
diff --git a/src/structures/Channel.js b/src/structures/Channel.js index <HASH>..<HASH> 100644 --- a/src/structures/Channel.js +++ b/src/structures/Channel.js @@ -100,17 +100,12 @@ class Channel extends Base { const Structures = require('../util/Structures'); let channel; if (!data.guild_id && !guild) { ...
fix(Channel): ensure partial DMChannels get created (#<I>)
diff --git a/src/Illuminate/Database/Query/Builder.php b/src/Illuminate/Database/Query/Builder.php index <HASH>..<HASH> 100755 --- a/src/Illuminate/Database/Query/Builder.php +++ b/src/Illuminate/Database/Query/Builder.php @@ -715,7 +715,7 @@ class Builder * Add a raw or where clause to the query. * *...
Update orWhereRaw docblock following #<I> (#<I>) Thanks @a-komarev for pointing out.
diff --git a/mdc_api/mdc_api.py b/mdc_api/mdc_api.py index <HASH>..<HASH> 100755 --- a/mdc_api/mdc_api.py +++ b/mdc_api/mdc_api.py @@ -448,12 +448,21 @@ class connector: :return: successful ``.status_code`` / ``.is_done``. Check the ``.error`` :rtype: asyncResult ''' + if isinstance(JSONdata,str) and self....
fixed putPreSubscription to handle both list and str json objects, enhanced return code handling
diff --git a/gandi/cli/modules/vhost.py b/gandi/cli/modules/vhost.py index <HASH>..<HASH> 100644 --- a/gandi/cli/modules/vhost.py +++ b/gandi/cli/modules/vhost.py @@ -45,6 +45,7 @@ class Vhost(GandiModule): cls.echo("We're creating a new vhost.") cls.display_progress(result) cls.echo('Your vh...
To know if something was done during the process.
diff --git a/tests/test_extra.py b/tests/test_extra.py index <HASH>..<HASH> 100644 --- a/tests/test_extra.py +++ b/tests/test_extra.py @@ -637,7 +637,8 @@ def test_promises_with_only_then(): promise3 = promise1.then(lambda x: None) context["promise1_reject"](error) - promise1._wait() + promise2._wait(...
Fixed tests in async environments
diff --git a/safe_qgis/widgets/dock.py b/safe_qgis/widgets/dock.py index <HASH>..<HASH> 100644 --- a/safe_qgis/widgets/dock.py +++ b/safe_qgis/widgets/dock.py @@ -1929,11 +1929,13 @@ class Dock(QtGui.QDockWidget, Ui_DockBase): mySettings = QSettings() lastSaveDir = mySettings.value('inasafe/lastSource...
Underscore separate batch file names by default.
diff --git a/src/main/java/com/ibm/stocator/fs/swift/SwiftAPIClient.java b/src/main/java/com/ibm/stocator/fs/swift/SwiftAPIClient.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/ibm/stocator/fs/swift/SwiftAPIClient.java +++ b/src/main/java/com/ibm/stocator/fs/swift/SwiftAPIClient.java @@ -497,7 +497,9 @@ publi...
no need to check isSparkOrigin on objects that unified name equals object name
diff --git a/lib/services/s3.js b/lib/services/s3.js index <HASH>..<HASH> 100644 --- a/lib/services/s3.js +++ b/lib/services/s3.js @@ -495,7 +495,7 @@ AWS.util.update(AWS.S3.prototype, { return done(); } - var regionReq = req.service.listObjects({Bucket: bucket}); + var regionReq = req.service.listO...
For internal SDK requests for bucket region, adds a MaxKeys constraint of 0 so that response will not return any object keys. Although in most cases the request will return an error as well as the region and not be retried, there are some cases in the browser where the request may succeed and return a list of object ke...
diff --git a/bulk_writer.js b/bulk_writer.js index <HASH>..<HASH> 100644 --- a/bulk_writer.js +++ b/bulk_writer.js @@ -1,3 +1,5 @@ +/* eslint no-underscore-dangle: ["error", { "allow": ["_index", "_type"] }] */ + const fs = require('fs'); const path = require('path'); const Promise = require('promise');
allow understcode dangling for _index and _type (expected by ES client)
diff --git a/lib/sendwithus_ruby_action_mailer/version.rb b/lib/sendwithus_ruby_action_mailer/version.rb index <HASH>..<HASH> 100644 --- a/lib/sendwithus_ruby_action_mailer/version.rb +++ b/lib/sendwithus_ruby_action_mailer/version.rb @@ -1,3 +1,3 @@ module SendWithUsMailer - VERSION = "0.4.0" + VERSION = "1.0.0" e...
Update the version number to <I>
diff --git a/src/browser/extension/inject/pageScript.js b/src/browser/extension/inject/pageScript.js index <HASH>..<HASH> 100644 --- a/src/browser/extension/inject/pageScript.js +++ b/src/browser/extension/inject/pageScript.js @@ -185,9 +185,11 @@ const preEnhancer = instanceId => next => const store = next(reduce...
Don't update the store when the page is blacklisted in settings
diff --git a/lib/fog/dreamhost/dns.rb b/lib/fog/dreamhost/dns.rb index <HASH>..<HASH> 100644 --- a/lib/fog/dreamhost/dns.rb +++ b/lib/fog/dreamhost/dns.rb @@ -1,6 +1,5 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', 'dreamhost')) require 'fog/dns' -require 'uuid' module Fog module DNS @@ -70...
[dreamhost|dns] drop uuid gem requirements, not needed Not sure to understand unique_id documentation from Dreamhost, but experimentation shows that a new UUID every request isn't required and Dreamhost says it's optional. <URL>
diff --git a/integration-cli/docker_cli_top_test.go b/integration-cli/docker_cli_top_test.go index <HASH>..<HASH> 100644 --- a/integration-cli/docker_cli_top_test.go +++ b/integration-cli/docker_cli_top_test.go @@ -52,7 +52,7 @@ func TestTopPrivileged(t *testing.T) { topCmd = exec.Command(dockerBinary, "top", clean...
Fixed error check using the wrong error value errorOut was using the err from the previous test. same as #<I> but on TestTopPrivileged, which I missed last time
diff --git a/lib/jazzy/sourcekitten.rb b/lib/jazzy/sourcekitten.rb index <HASH>..<HASH> 100644 --- a/lib/jazzy/sourcekitten.rb +++ b/lib/jazzy/sourcekitten.rb @@ -97,13 +97,11 @@ module Jazzy # Determine the subdirectory in which a doc should be placed def self.subdir_for_doc(doc, parents) - # To group...
Fixed subdirs for nested types e.g. Classes/Request/TaskDelegate.html, not Classes/TaskDelegate.html
diff --git a/dropwizard-core/src/test/java/io/dropwizard/validation/InjectValidatorFeatureTest.java b/dropwizard-core/src/test/java/io/dropwizard/validation/InjectValidatorFeatureTest.java index <HASH>..<HASH> 100644 --- a/dropwizard-core/src/test/java/io/dropwizard/validation/InjectValidatorFeatureTest.java +++ b/drop...
Simplify InjectValidatorFeatureTest
diff --git a/spec/apruve/resources/order_spec.rb b/spec/apruve/resources/order_spec.rb index <HASH>..<HASH> 100644 --- a/spec/apruve/resources/order_spec.rb +++ b/spec/apruve/resources/order_spec.rb @@ -145,7 +145,7 @@ describe Apruve::Order do context 'successful response' do let! (:stubs) do fara...
AP-<I>: changed spec response to contain json array not an object
diff --git a/dragonpy/core/configs.py b/dragonpy/core/configs.py index <HASH>..<HASH> 100644 --- a/dragonpy/core/configs.py +++ b/dragonpy/core/configs.py @@ -130,6 +130,7 @@ class BaseConfig(object): self.mem_info = DummyMemInfo() self.memory_byte_middlewares = {} + self.memory_word_middlewa...
bugfix: 'Cfg' object has no attribute 'memory_word_middlewares'
diff --git a/Datagrid/PropelDatagrid.php b/Datagrid/PropelDatagrid.php index <HASH>..<HASH> 100644 --- a/Datagrid/PropelDatagrid.php +++ b/Datagrid/PropelDatagrid.php @@ -346,10 +346,8 @@ abstract class PropelDatagrid implements PropelDatagridInterface foreach ($sort as $column => $order) { $met...
Fail silently when sorting on unknown column.
diff --git a/tests/PackageManager/ComposerIOBridgeTest.php b/tests/PackageManager/ComposerIOBridgeTest.php index <HASH>..<HASH> 100644 --- a/tests/PackageManager/ComposerIOBridgeTest.php +++ b/tests/PackageManager/ComposerIOBridgeTest.php @@ -13,11 +13,6 @@ namespace Yosymfony\Spress\PackageManager; use Yosymfony\Sp...
Deleted unnecesary docblock
diff --git a/lib/schema.js b/lib/schema.js index <HASH>..<HASH> 100644 --- a/lib/schema.js +++ b/lib/schema.js @@ -285,7 +285,7 @@ var RootTable = { return "CREATE TABLE " + this.name + "(" + atts.join(",") + ")"; }, toJSON: function () { - var o = { name : this.name, attributes: this.attributes }; ...
table.name is not required in the json format (surrounding object holds name alredy)
diff --git a/lib/autokey/scripting/engine.py b/lib/autokey/scripting/engine.py index <HASH>..<HASH> 100644 --- a/lib/autokey/scripting/engine.py +++ b/lib/autokey/scripting/engine.py @@ -91,9 +91,8 @@ class Engine: cannot use absolute paths.") path = parent_folder.expanduser() / ti...
Create_folder: Set path as arg, not after creation
diff --git a/lib/adhearsion/console.rb b/lib/adhearsion/console.rb index <HASH>..<HASH> 100644 --- a/lib/adhearsion/console.rb +++ b/lib/adhearsion/console.rb @@ -33,10 +33,10 @@ module Adhearsion if libedit? logger.error "Cannot start. You are running Adhearsion on Ruby with libedit. You must use readl...
Tweak log messages for readability
diff --git a/openquake/calculators/hazard/disagg/core.py b/openquake/calculators/hazard/disagg/core.py index <HASH>..<HASH> 100644 --- a/openquake/calculators/hazard/disagg/core.py +++ b/openquake/calculators/hazard/disagg/core.py @@ -19,6 +19,7 @@ Disaggregation calculator core functionality """ import nhlib +impo...
calcs/hazard/disagg/core: Added sketch of curve interpolation.
diff --git a/rspec-crispy/spec/rspec/crispy/configure_without_conflict_spec.rb b/rspec-crispy/spec/rspec/crispy/configure_without_conflict_spec.rb index <HASH>..<HASH> 100644 --- a/rspec-crispy/spec/rspec/crispy/configure_without_conflict_spec.rb +++ b/rspec-crispy/spec/rspec/crispy/configure_without_conflict_spec.rb @...
add spec when given argument to have_received
diff --git a/src/Symfony/Bundle/TwigBundle/CacheWarmer/TemplateCacheCacheWarmer.php b/src/Symfony/Bundle/TwigBundle/CacheWarmer/TemplateCacheCacheWarmer.php index <HASH>..<HASH> 100644 --- a/src/Symfony/Bundle/TwigBundle/CacheWarmer/TemplateCacheCacheWarmer.php +++ b/src/Symfony/Bundle/TwigBundle/CacheWarmer/TemplateCa...
Rename misprint property (from warmer to finder)
diff --git a/src/photini/__init__.py b/src/photini/__init__.py index <HASH>..<HASH> 100644 --- a/src/photini/__init__.py +++ b/src/photini/__init__.py @@ -1,4 +1,4 @@ from __future__ import unicode_literals __version__ = '2016.08.0' -build = '683 (8b2ed70)' +build = '684 (d3a9ad5)' diff --git a/src/photini/photinim...
Ensure links from maps are not 'local'.
diff --git a/raven/utils/stacks.py b/raven/utils/stacks.py index <HASH>..<HASH> 100644 --- a/raven/utils/stacks.py +++ b/raven/utils/stacks.py @@ -233,7 +233,7 @@ def get_stack_info(frames, transformer=transform, capture_locals=True, # This changes /foo/site-packages/baz/bar.py into baz/bar.py try: ...
Use lstrip to get rid of leading slashes, because in some cases the paths have already been replaced.
diff --git a/src/Guzzle/Stream/Stream.php b/src/Guzzle/Stream/Stream.php index <HASH>..<HASH> 100644 --- a/src/Guzzle/Stream/Stream.php +++ b/src/Guzzle/Stream/Stream.php @@ -70,9 +70,7 @@ class Stream implements StreamInterface */ public function __destruct() { - if (is_resource($this->stream)) ...
Adding close() method to stream objects
diff --git a/tests/test_protobuf.py b/tests/test_protobuf.py index <HASH>..<HASH> 100644 --- a/tests/test_protobuf.py +++ b/tests/test_protobuf.py @@ -33,7 +33,7 @@ def doc_pb(): def test_parse_protobuf(doc_pb): - assert doc_pb.ByteSize() == 4239 + assert doc_pb.ByteSize() == 4709 def test_write_protobu...
Update the expected size of the protobuf
diff --git a/backend/handler.py b/backend/handler.py index <HASH>..<HASH> 100644 --- a/backend/handler.py +++ b/backend/handler.py @@ -171,7 +171,7 @@ class TensorboardHandler(BaseHTTPServer.BaseHTTPRequestHandler): code: The numeric HTTP status code to use. """ out = BytesIO() - f = gzip.GzipFile(f...
Make GZip faster for TensorBoard It turns out compresslevel=3 is 4x faster and nearly as good. Less time spent compressing is going to be important, because this HTTP server is multithreaded and CPU bound operations scale negatively, i.e. 1 + 1 < 1. Benchmark: <URL>
diff --git a/flattened_serializers.go b/flattened_serializers.go index <HASH>..<HASH> 100644 --- a/flattened_serializers.go +++ b/flattened_serializers.go @@ -1,6 +1,7 @@ package manta import ( + "encoding/json" "os" "github.com/dotabuff/manta/dota" @@ -40,6 +41,23 @@ type flattened_serializers struct { pro...
Added dump_json to flattened_serializers.go
diff --git a/uproot_methods/convert.py b/uproot_methods/convert.py index <HASH>..<HASH> 100644 --- a/uproot_methods/convert.py +++ b/uproot_methods/convert.py @@ -58,6 +58,9 @@ def towriteable(obj): elif any(x == ("uproot_methods.classes.TH1", "Methods") for x in types(obj.__class__, obj)): return...
Write histogram read by uproot
diff --git a/src/_0_scripts/ie8-main.js b/src/_0_scripts/ie8-main.js index <HASH>..<HASH> 100644 --- a/src/_0_scripts/ie8-main.js +++ b/src/_0_scripts/ie8-main.js @@ -1,3 +1,10 @@ +// indexOf polyfill +// Minified version of this: +// https://stackoverflow.com/a/35054662/1611058 +if (!Array.prototype.indexOf) { + Arra...
Fixed IE8 js error I thought indexOf would be safe to use but apparantly it isn't. I'm adding a polyfill to make it safe
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -13,6 +13,7 @@ convert = function(source) { line, objectNames = [], output = {}, + parents, parentObj = {}, i, linesLength,
Added `parents` declaration
diff --git a/studio/lib/archivefile.py b/studio/lib/archivefile.py index <HASH>..<HASH> 100644 --- a/studio/lib/archivefile.py +++ b/studio/lib/archivefile.py @@ -52,5 +52,4 @@ def extractall(archive, filename, dstdir): tar.extractall(path=dstdir) else: # seems to be a single file, save it - ...
shutil.copyfile does take a filename as the destination file to be written instead of a file object
diff --git a/src/Leevel/Event/Observer.php b/src/Leevel/Event/Observer.php index <HASH>..<HASH> 100644 --- a/src/Leevel/Event/Observer.php +++ b/src/Leevel/Event/Observer.php @@ -68,7 +68,8 @@ class Observer implements SplObserver */ public function __invoke(...$args) { - call_user_func($this->ha...
perf(event): improves observer performance
diff --git a/rwa/pandas.py b/rwa/pandas.py index <HASH>..<HASH> 100644 --- a/rwa/pandas.py +++ b/rwa/pandas.py @@ -63,7 +63,11 @@ else: service.poke('name', ix.name, container, visited=visited, _stack=_stack) def peek_index(service, container, _stack=None, force_unicode=None): - data = service.pe...
backward compatibility bugfix for Pandas' Index
diff --git a/tests/test_pandora/test_models.py b/tests/test_pandora/test_models.py index <HASH>..<HASH> 100644 --- a/tests/test_pandora/test_models.py +++ b/tests/test_pandora/test_models.py @@ -253,3 +253,23 @@ class TestAdItem(TestCase): self.result.prepare_playback() assert self.result.regi...
Test cases for handling exceptions in prepare_playback.
diff --git a/python/thunder/utils/ec2.py b/python/thunder/utils/ec2.py index <HASH>..<HASH> 100644 --- a/python/thunder/utils/ec2.py +++ b/python/thunder/utils/ec2.py @@ -177,6 +177,9 @@ def install_anaconda(master, opts): ssh(master, opts, "/root/anaconda/bin/conda install --yes jsonschema pillow seaborn scikit-l...
Add mistune (for notebook HTML conversions)
diff --git a/cronjobs/indexcontent.php b/cronjobs/indexcontent.php index <HASH>..<HASH> 100644 --- a/cronjobs/indexcontent.php +++ b/cronjobs/indexcontent.php @@ -62,6 +62,8 @@ while( true ) if ( !( $node instanceof eZContentObjectTreeNode ) ) { $cli->e...
Fix EZP-<I>: Delayed indexing should fail gracefully on trashed / broken node
diff --git a/karaage/projectreports/views/user.py b/karaage/projectreports/views/user.py index <HASH>..<HASH> 100644 --- a/karaage/projectreports/views/user.py +++ b/karaage/projectreports/views/user.py @@ -69,7 +69,7 @@ def thanks(request, project_id): survey, created = ProjectSurvey.objects.get_or_create(project...
Fixed bug in project reports url redirection
diff --git a/grammar.js b/grammar.js index <HASH>..<HASH> 100644 --- a/grammar.js +++ b/grammar.js @@ -375,7 +375,7 @@ module.exports = grammar({ ) ), - string_expansion: $ => seq('$', $.string), + string_expansion: $ => seq('$', choice($.string, $.raw_string)), expansion: $ => seq( '$...
Allow $'\n' (whatever that is)
diff --git a/controllers/DefaultController.php b/controllers/DefaultController.php index <HASH>..<HASH> 100644 --- a/controllers/DefaultController.php +++ b/controllers/DefaultController.php @@ -51,7 +51,7 @@ class DefaultController extends \cms\base\Controller throw new NotFoundHttpException("The requeste...
fixed but in Cms DefaultController in links lookup
diff --git a/gnupg/test/test_gnupg.py b/gnupg/test/test_gnupg.py index <HASH>..<HASH> 100755 --- a/gnupg/test/test_gnupg.py +++ b/gnupg/test/test_gnupg.py @@ -1152,9 +1152,9 @@ know, maybe you shouldn't be doing it in the first place. self.assertTrue(os.path.isfile(output)) # Check the contents: - ...
Actually check output file contents in to test_encrypt_*() tests. This provides more accurate testing for issues like #<I>.
diff --git a/test/jss_test.py b/test/jss_test.py index <HASH>..<HASH> 100644 --- a/test/jss_test.py +++ b/test/jss_test.py @@ -12,6 +12,7 @@ defaults write org.da.jss_helper jss_url <URL to JSS> import subprocess import base64 +import inspect from xml.etree import ElementTree from nose.tools import * @@ -110,6 ...
Add test for JSS constructor methods.