diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/backbone.js b/backbone.js index <HASH>..<HASH> 100644 --- a/backbone.js +++ b/backbone.js @@ -1369,10 +1369,9 @@ return Backbone.ajax(_.extend(params, options)); }; - // Set the default ajax method if $ is defined. - if ($) Backbone.ajax = function () { - return $.ajax.apply(Backbone, argume...
Fixing Backbone.ajax implementation.
diff --git a/plugins/Referrers/Columns/Keyword.php b/plugins/Referrers/Columns/Keyword.php index <HASH>..<HASH> 100644 --- a/plugins/Referrers/Columns/Keyword.php +++ b/plugins/Referrers/Columns/Keyword.php @@ -44,7 +44,11 @@ class Keyword extends Base $information = $this->getReferrerInformationFromRequest($r...
Internal / external search strings will be reduced more than <I> "bytes" without boundary.
diff --git a/ribbon-archaius/src/main/java/com/netflix/client/config/DefaultClientConfigImpl.java b/ribbon-archaius/src/main/java/com/netflix/client/config/DefaultClientConfigImpl.java index <HASH>..<HASH> 100644 --- a/ribbon-archaius/src/main/java/com/netflix/client/config/DefaultClientConfigImpl.java +++ b/ribbon-arc...
add back API that was accidentally deleted in refactor
diff --git a/actionpack/test/template/test_case_test.rb b/actionpack/test/template/test_case_test.rb index <HASH>..<HASH> 100644 --- a/actionpack/test/template/test_case_test.rb +++ b/actionpack/test/template/test_case_test.rb @@ -24,7 +24,7 @@ module ActionView test_case.class_eval do test "helpers...
Make some assertions in the ActionView::TestCase tests actually do something. [#<I> state:resolved]
diff --git a/ntfy/__init__.py b/ntfy/__init__.py index <HASH>..<HASH> 100644 --- a/ntfy/__init__.py +++ b/ntfy/__init__.py @@ -7,13 +7,6 @@ try: except: __version__ = 'unknown' -try: - from dbus.exceptions import DBusException -except ImportError: - - class DBusException(Exception): - pass - def...
Don't give DBusExceptions special treament, would've avoided #<I>
diff --git a/src/Bugsnag/Error.php b/src/Bugsnag/Error.php index <HASH>..<HASH> 100644 --- a/src/Bugsnag/Error.php +++ b/src/Bugsnag/Error.php @@ -225,7 +225,7 @@ class Bugsnag_Error return $cleanArray; } elseif (is_string($obj)) { // UTF8-encode if not already encoded - if...
Only do encoding magic if mb_detect_encoding is available
diff --git a/flake8_import_order/stdlib_list.py b/flake8_import_order/stdlib_list.py index <HASH>..<HASH> 100644 --- a/flake8_import_order/stdlib_list.py +++ b/flake8_import_order/stdlib_list.py @@ -40,6 +40,7 @@ STDLIB_NAMES = set(( "__main__", "_dummy_thread", "_thread", + "_threading_local", "...
Add _threading_local to the stdlib list
diff --git a/lib/formtools/form.js b/lib/formtools/form.js index <HASH>..<HASH> 100644 --- a/lib/formtools/form.js +++ b/lib/formtools/form.js @@ -106,12 +106,17 @@ var generateFormFromModel = exports.generateFormFromModel = function (m, r, form linz.mongoose.models[m.schema.tree[fieldName].ref].fi...
Ref property values now appear in the select lists.
diff --git a/open/exec_windows.go b/open/exec_windows.go index <HASH>..<HASH> 100644 --- a/open/exec_windows.go +++ b/open/exec_windows.go @@ -20,7 +20,7 @@ func cleaninput(input string) string { } func open(input string) *exec.Cmd { - return exec.Command(runDll32, cmd, cleaninput(input)) + return exec.Command(runD...
Fixing #9 - not replacing ampersand in calls to rundll<I>
diff --git a/src/main/java/technology/tabula/json/TableSerializer.java b/src/main/java/technology/tabula/json/TableSerializer.java index <HASH>..<HASH> 100644 --- a/src/main/java/technology/tabula/json/TableSerializer.java +++ b/src/main/java/technology/tabula/json/TableSerializer.java @@ -30,6 +30,8 @@ public final cl...
Add right and bottom of area to JSON output
diff --git a/charmhelpers/contrib/hahelpers/cluster.py b/charmhelpers/contrib/hahelpers/cluster.py index <HASH>..<HASH> 100644 --- a/charmhelpers/contrib/hahelpers/cluster.py +++ b/charmhelpers/contrib/hahelpers/cluster.py @@ -44,6 +44,7 @@ from charmhelpers.core.hookenv import ( ERROR, WARNING, unit_get...
Try using juju leadership for leadership determination
diff --git a/pkg/kubelet/runtime.go b/pkg/kubelet/runtime.go index <HASH>..<HASH> 100644 --- a/pkg/kubelet/runtime.go +++ b/pkg/kubelet/runtime.go @@ -23,7 +23,7 @@ import ( ) type runtimeState struct { - sync.Mutex + sync.RWMutex lastBaseRuntimeSync time.Time baseRuntimeSyncThreshold time.Duration netwo...
optimize lock of runtimeState stuct
diff --git a/edit_interface.php b/edit_interface.php index <HASH>..<HASH> 100644 --- a/edit_interface.php +++ b/edit_interface.php @@ -317,7 +317,7 @@ case 'editraw': // Notes are special - they may contain data on the first line $gedrec=preg_replace('/^(0 @'.WT_REGEX_XREF.'@ NOTE) (.+)/', "$1\n1 CONC $2", $gedre...
RTL: first line of record has wrong alignment in raw gedcom editing
diff --git a/src/Shader.js b/src/Shader.js index <HASH>..<HASH> 100644 --- a/src/Shader.js +++ b/src/Shader.js @@ -62,10 +62,6 @@ class Shader { const shader = this._shader = gl.createShader(glType); gl.shaderSource(shader, this._code); gl.compileShader(shader); - - if (process.env.NOD...
Remove shader get log methods (#<I>)
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -28,13 +28,15 @@ exports.attach = function (server) { } } }); - var listener = io.listen(server, { log: false }); + var sio = io.listen(server, { log: false }); var args = [].splice.call(a...
Added 'socket' property to options object before passing it to shotgun. This will allow shotgun command modules to access socket.io functionality if needed.
diff --git a/db/agents.go b/db/agents.go index <HASH>..<HASH> 100644 --- a/db/agents.go +++ b/db/agents.go @@ -250,12 +250,20 @@ func (db *DB) UpdateAgent(agent *Agent) error { func (db *DB) DeleteAgent(agent *Agent) error { return db.exclusively(func() error { - n, err := db.count(`SELECT uuid FROM jobs WHERE ag...
Fix Agent Deletion - Agents cannot be deleted if they are referenced by a storage system - Agents cannot be deleted if they are referenced by a target system - Agents can be deleted otherwise Fixes #<I>
diff --git a/Classes/ViewHelpers/ForViewHelper.php b/Classes/ViewHelpers/ForViewHelper.php index <HASH>..<HASH> 100644 --- a/Classes/ViewHelpers/ForViewHelper.php +++ b/Classes/ViewHelpers/ForViewHelper.php @@ -73,7 +73,7 @@ class ForViewHelper extends \F3\Fluid\Core\ViewHelper\AbstractViewHelper { $output = ''; ...
[~BUGFIX] Fluid (ViewHelpers): Fixed a failing test of the For view helper introduced in the last commit. Original-Commit-Hash: <I>c<I>d<I>a6c5c<I>d<I>e0e<I>ae<I>dd<I>
diff --git a/lyric.js b/lyric.js index <HASH>..<HASH> 100755 --- a/lyric.js +++ b/lyric.js @@ -85,7 +85,22 @@ Processor = function() { var processorName = mapped[0].processor , processed = processor[processorName](); - + if (argv.s) { + var script = 'tell application "iTunes" to set lyrics of curr...
Add --set for set lyric for current song.
diff --git a/angr/cfg.py b/angr/cfg.py index <HASH>..<HASH> 100644 --- a/angr/cfg.py +++ b/angr/cfg.py @@ -261,10 +261,14 @@ class CFG(CFGBase): # Start execution! simexit = self._project.exit_to(function_addr, state=symbolic_initial_state) simrun = self._project.sim_run(simexit) - exi...
fixed a bug in CFG that it may use unsatisfiable state to perform symbolic execution.
diff --git a/Controller/Wizard/EditorController.php b/Controller/Wizard/EditorController.php index <HASH>..<HASH> 100644 --- a/Controller/Wizard/EditorController.php +++ b/Controller/Wizard/EditorController.php @@ -89,7 +89,6 @@ class EditorController * name = "innova_path_editor_wizard", * opt...
[PathBundle] do not restrict GET method to allow locale change in Path wizards
diff --git a/tests/Integration/Util/Tax/IntegrationTestTaxServiceLocator.php b/tests/Integration/Util/Tax/IntegrationTestTaxServiceLocator.php index <HASH>..<HASH> 100644 --- a/tests/Integration/Util/Tax/IntegrationTestTaxServiceLocator.php +++ b/tests/Integration/Util/Tax/IntegrationTestTaxServiceLocator.php @@ -2,14 ...
Issue #<I>: Import classes
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100755 --- a/setup.py +++ b/setup.py @@ -19,7 +19,7 @@ try: except ImportError: requirements.append("elementtree") -version = "0.9.5" +version = "0.9.6" f = open("README.rst") try:
BUMP <I> mostly some fixes to the c extension to work around reloading issues that came up in SW production
diff --git a/core/src/main/java/hudson/util/RingBufferLogHandler.java b/core/src/main/java/hudson/util/RingBufferLogHandler.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/hudson/util/RingBufferLogHandler.java +++ b/core/src/main/java/hudson/util/RingBufferLogHandler.java @@ -51,7 +51,7 @@ public class RingBu...
[FIXED JENKINS-<I>] RingBufferLogHandler has int that needs to be reset.
diff --git a/validator/sawtooth_validator/consensus/notifier.py b/validator/sawtooth_validator/consensus/notifier.py index <HASH>..<HASH> 100644 --- a/validator/sawtooth_validator/consensus/notifier.py +++ b/validator/sawtooth_validator/consensus/notifier.py @@ -32,13 +32,13 @@ class _NotifierService: self._co...
Only send updates to active engine in notifier Updates the ConsensusNotifier to only send updates to the active consensus engine. Previously, it sent notifications to all consensus engines.
diff --git a/resources/views/_template/master.blade.php b/resources/views/_template/master.blade.php index <HASH>..<HASH> 100644 --- a/resources/views/_template/master.blade.php +++ b/resources/views/_template/master.blade.php @@ -10,6 +10,7 @@ {{ Html::script('https://oss.maxcdn.com/html5shiv/3.7.3/html5shiv.min....
Adding new sections: head & modals
diff --git a/structr-ui/src/main/resources/structr/js/init.js b/structr-ui/src/main/resources/structr/js/init.js index <HASH>..<HASH> 100644 --- a/structr-ui/src/main/resources/structr/js/init.js +++ b/structr-ui/src/main/resources/structr/js/init.js @@ -827,7 +827,7 @@ var Structr = { var horizontalOffset = 98; ...
Bugfix: While calculating the dialog size, take into account that the content might be scrolled. Otherwise the resulting dialog size might be a lot bigger.
diff --git a/templates/bootstrap/ApiRenderer.php b/templates/bootstrap/ApiRenderer.php index <HASH>..<HASH> 100644 --- a/templates/bootstrap/ApiRenderer.php +++ b/templates/bootstrap/ApiRenderer.php @@ -6,6 +6,7 @@ */ namespace yii\apidoc\templates\bootstrap; + use yii\apidoc\models\Context; use yii\console\Cont...
fixed file PHPdoc issue #<I>
diff --git a/examples/logical_enclosures.py b/examples/logical_enclosures.py index <HASH>..<HASH> 100644 --- a/examples/logical_enclosures.py +++ b/examples/logical_enclosures.py @@ -123,3 +123,27 @@ print("Get all logical enclosures") logical_enclosures = oneview_client.logical_enclosures.get_all() for enc in logica...
Adds an example of how to use patch for Logical Enclosures
diff --git a/Service/Adapter/AmazonS3.php b/Service/Adapter/AmazonS3.php index <HASH>..<HASH> 100644 --- a/Service/Adapter/AmazonS3.php +++ b/Service/Adapter/AmazonS3.php @@ -207,7 +207,11 @@ class AmazonS3 implements AdapterInterface{ $headers = $this->s3->get_object_headers($this->bucketName, $this->getPath(...
modify content-type returned by sendFileToBrowser
diff --git a/helios-system-tests/src/main/java/com/spotify/helios/system/ZooKeeperCuratorFailoverTest.java b/helios-system-tests/src/main/java/com/spotify/helios/system/ZooKeeperCuratorFailoverTest.java index <HASH>..<HASH> 100644 --- a/helios-system-tests/src/main/java/com/spotify/helios/system/ZooKeeperCuratorFailove...
disable curator failover test This test is only in there to build confidence that a three node zookeeper can recover from losing a node. It takes long time to run serially and spawns a lot of subprocesses concurrently when run in parallel, so it likely causes problems on travis.
diff --git a/docs/storage/layerwriter.go b/docs/storage/layerwriter.go index <HASH>..<HASH> 100644 --- a/docs/storage/layerwriter.go +++ b/docs/storage/layerwriter.go @@ -109,6 +109,10 @@ func (lw *layerWriter) ReadFrom(r io.Reader) (n int64, err error) { } func (lw *layerWriter) Close() error { + if lw.err != nil ...
Prevent Close() from being called after Finish()
diff --git a/trailblazer/add/core.py b/trailblazer/add/core.py index <HASH>..<HASH> 100644 --- a/trailblazer/add/core.py +++ b/trailblazer/add/core.py @@ -71,7 +71,7 @@ def parse_sampleinfo(sampleinfo): analysis_type = 'exomes' if analysis_type_raw == 'wes' else 'genomes' analysis_start = sampleinfo['analysis...
parse owner/cust from ped
diff --git a/src/Model/User.php b/src/Model/User.php index <HASH>..<HASH> 100644 --- a/src/Model/User.php +++ b/src/Model/User.php @@ -9,7 +9,6 @@ use Phwoolcon\Model; * @package Phwoolcon\Model * * @property Di $_dependencyInjector - * @property Di $_dependencyInjector * @method UserProfile|false getUserProfil...
docs: remove duplicated ide helper property in user model
diff --git a/src/src/com/tns/AssetExtractor.java b/src/src/com/tns/AssetExtractor.java index <HASH>..<HASH> 100644 --- a/src/src/com/tns/AssetExtractor.java +++ b/src/src/com/tns/AssetExtractor.java @@ -32,7 +32,7 @@ public class AssetExtractor } else if (extractPolicy.shouldExtract(context)) { - String appR...
little change on appRoot path generation
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -46,7 +46,7 @@ var letta = module.exports = function letta (fn, args) { return } utils.relike.promise = letta.promise - utils.relike.promisify(fn).apply(self, args).then(resolve, reject) + utils.relike.p...
.call with context, close #6
diff --git a/server/resource_controller.go b/server/resource_controller.go index <HASH>..<HASH> 100644 --- a/server/resource_controller.go +++ b/server/resource_controller.go @@ -167,7 +167,6 @@ func (rc *ResourceController) ConditionalUpdateHandler(c *gin.Context) { c.Set("Resource", rc.Name) c.Header("Location"...
Removed headers Removed additional Access-Control-Allow-Origin headers that I missed on the first pass.
diff --git a/test/e2e/safari/webview/web-specs.js b/test/e2e/safari/webview/web-specs.js index <HASH>..<HASH> 100644 --- a/test/e2e/safari/webview/web-specs.js +++ b/test/e2e/safari/webview/web-specs.js @@ -22,7 +22,7 @@ describe('Web', function () { const args = [{ [elType]: 5000 }]; - ...
Fix outdated test (#<I>)
diff --git a/lib/redlock/client.rb b/lib/redlock/client.rb index <HASH>..<HASH> 100644 --- a/lib/redlock/client.rb +++ b/lib/redlock/client.rb @@ -118,8 +118,6 @@ module Redlock else @redis = Redis.new(connection) end - - load_scripts end def lock(resource, val, ttl, ...
Don't load scripts on client initialization The `recover_from_script_flush` block will load scripts if they're not loaded yet, so there's no need to load the scripts for every new client instantiation. The loads ought to be redundant more often than not.
diff --git a/bootstrap-unexpected-markdown.js b/bootstrap-unexpected-markdown.js index <HASH>..<HASH> 100644 --- a/bootstrap-unexpected-markdown.js +++ b/bootstrap-unexpected-markdown.js @@ -1,6 +1,7 @@ /*global unexpected:true*/ -unexpected = require('unexpected').clone(); -unexpected.use(require('./lib/unexpected-se...
Tidy up bootstrap-unexpected-markdown.js a bit
diff --git a/spec/javascripts/vec3_spec.js b/spec/javascripts/vec3_spec.js index <HASH>..<HASH> 100644 --- a/spec/javascripts/vec3_spec.js +++ b/spec/javascripts/vec3_spec.js @@ -16,4 +16,15 @@ describe("vec3", function() { expect(vec[1]).toEqual(2); expect(vec[2]).toEqual(3); }); + + describe("set", fu...
added test for vec3.set
diff --git a/src/Controller/Component/FilterComponent.php b/src/Controller/Component/FilterComponent.php index <HASH>..<HASH> 100644 --- a/src/Controller/Component/FilterComponent.php +++ b/src/Controller/Component/FilterComponent.php @@ -656,7 +656,7 @@ class FilterComponent extends Component $sortFie...
enable dynamic sort directions for custom sort options by using ":dir"
diff --git a/install-pngcrush.js b/install-pngcrush.js index <HASH>..<HASH> 100755 --- a/install-pngcrush.js +++ b/install-pngcrush.js @@ -9,7 +9,7 @@ // Credit to Obvious Corp for finding this fix. var originalPath = process.env.PATH; // NPM adds bin directories to the path, which will cause `which` to find t...
This comment was kept because the code was found by somebody else, changing the comment slightly
diff --git a/dtool_create/dataset.py b/dtool_create/dataset.py index <HASH>..<HASH> 100644 --- a/dtool_create/dataset.py +++ b/dtool_create/dataset.py @@ -329,6 +329,12 @@ def show(dataset_uri): @proto_dataset_uri_argument @click.argument('input', type=click.File('r')) def write(proto_dataset_uri, input): + """Us...
Add docstring to 'dtool readme write'
diff --git a/db/migrate/20150331132115_remove_old_permissions.rb b/db/migrate/20150331132115_remove_old_permissions.rb index <HASH>..<HASH> 100644 --- a/db/migrate/20150331132115_remove_old_permissions.rb +++ b/db/migrate/20150331132115_remove_old_permissions.rb @@ -2,12 +2,12 @@ class RemoveOldPermissions < ActiveReco...
Refs #<I> - changing puts to say in permissions migration
diff --git a/lib/websearch_external_collections_getter_tests.py b/lib/websearch_external_collections_getter_tests.py index <HASH>..<HASH> 100644 --- a/lib/websearch_external_collections_getter_tests.py +++ b/lib/websearch_external_collections_getter_tests.py @@ -39,8 +39,9 @@ class AsyncDownloadTest(unittest.TestCase):...
demobibdata with citation stuff. adjusted the tests
diff --git a/crawler.js b/crawler.js index <HASH>..<HASH> 100644 --- a/crawler.js +++ b/crawler.js @@ -174,6 +174,9 @@ Crawler.prototype._crawlUrl = function(url, referer, depth) { if ((depth === 0) || this.knownUrls[url]) { return; } + + this.knownUrls[url] = true; + var self = this; this._startedC...
Sets knownUrls immediately in _crawlUrl to avoid re-crawling failed urls
diff --git a/dataviews/options.py b/dataviews/options.py index <HASH>..<HASH> 100644 --- a/dataviews/options.py +++ b/dataviews/options.py @@ -128,12 +128,14 @@ class Options(object): def __call__(self, obj): - if not hasattr(obj, 'style'): - raise Exception('Supplied object requires style at...
Options can now be generated by string in __call__ methods
diff --git a/brother_ql/raster.py b/brother_ql/raster.py index <HASH>..<HASH> 100644 --- a/brother_ql/raster.py +++ b/brother_ql/raster.py @@ -186,7 +186,7 @@ class BrotherQLRaster(object): def add_raster_data(self, image, second_image=None): """ image: Pillow Image() """ - logger.info("raster_im...
BrotherQLRaster: log raster_image_size as debug, not info
diff --git a/codebase/base_connector.php b/codebase/base_connector.php index <HASH>..<HASH> 100644 --- a/codebase/base_connector.php +++ b/codebase/base_connector.php @@ -230,7 +230,7 @@ class DataItem{ @return escaped string */ - protected function xmlentities($string) { + public function xmlentities($strin...
[fix] set xmlentities to public, must fix some backward compatibility issues
diff --git a/tests/unit/Codeception/Module/BeanstalkdTest.php b/tests/unit/Codeception/Module/BeanstalkdTest.php index <HASH>..<HASH> 100644 --- a/tests/unit/Codeception/Module/BeanstalkdTest.php +++ b/tests/unit/Codeception/Module/BeanstalkdTest.php @@ -19,7 +19,7 @@ class Beanstalkd_Test extends \PHPUnit_Framework_Te...
Pass correct stub to _before hook of Beanstalkd module
diff --git a/lib/Doctrine/DBAL/Migrations/Version.php b/lib/Doctrine/DBAL/Migrations/Version.php index <HASH>..<HASH> 100644 --- a/lib/Doctrine/DBAL/Migrations/Version.php +++ b/lib/Doctrine/DBAL/Migrations/Version.php @@ -148,8 +148,18 @@ class Version public function markMigrated() { + $this->markV...
refactoring the mark version migrated / not migrated code
diff --git a/tests/gui/widget/test_history.py b/tests/gui/widget/test_history.py index <HASH>..<HASH> 100644 --- a/tests/gui/widget/test_history.py +++ b/tests/gui/widget/test_history.py @@ -181,6 +181,7 @@ def create_sm_model(with_gui=False, add_state_machine=False): # TODO introduce test_add_remove_history with_gu...
fix(test_history): Add missing call to dummy_gui in test_add_remove_hist
diff --git a/src/Munee/Asset/Type/Css.php b/src/Munee/Asset/Type/Css.php index <HASH>..<HASH> 100644 --- a/src/Munee/Asset/Type/Css.php +++ b/src/Munee/Asset/Type/Css.php @@ -173,7 +173,8 @@ class Css extends Type $changedContent = preg_replace_callback($regEx, function ($match) use ($originalFile, $webroot) {...
Ignore urls with protocols in CSS.
diff --git a/help_text.php b/help_text.php index <HASH>..<HASH> 100644 --- a/help_text.php +++ b/help_text.php @@ -31,9 +31,7 @@ define('WT_SCRIPT_NAME', 'help_text.php'); require './includes/session.php'; -Zend_Session::writeClose(); - -$controller=new WT_Controller_Simple(); +$controller=new WT_Controller_Ajax();...
help_text.php is now an AJAX response, rather than a popup window, so send the correct headers.
diff --git a/dolo/compiler/compiler_python.py b/dolo/compiler/compiler_python.py index <HASH>..<HASH> 100644 --- a/dolo/compiler/compiler_python.py +++ b/dolo/compiler/compiler_python.py @@ -25,6 +25,7 @@ class GModel(object): calibration = None functions = None symbols = None + infos = dict() ...
Added infos structure to python models.
diff --git a/test_schema.py b/test_schema.py index <HASH>..<HASH> 100644 --- a/test_schema.py +++ b/test_schema.py @@ -445,8 +445,6 @@ def test_optional_key_convert_failed_randomly_while_with_another_optional_object 'created_at': '2015-10-10 00:00:00' } validated_data = s.validate(data) -...
Remove print for py3+
diff --git a/pkg/drivers/kvm/gpu.go b/pkg/drivers/kvm/gpu.go index <HASH>..<HASH> 100644 --- a/pkg/drivers/kvm/gpu.go +++ b/pkg/drivers/kvm/gpu.go @@ -62,7 +62,7 @@ type PCIDevice struct { func getDevicesXML() (string, error) { unboundNVIDIADevices, err := getPassthroughableNVIDIADevices() if err != nil { - retur...
Correct typo in the returned message coundn't->couldn't
diff --git a/lib/extract_jwt.js b/lib/extract_jwt.js index <HASH>..<HASH> 100644 --- a/lib/extract_jwt.js +++ b/lib/extract_jwt.js @@ -40,7 +40,7 @@ extractors.fromUrlQueryParameter = function (param_name) { return function (request) { var token = null, parsed_url = url.parse(request.url, tru...
Switch to using hasOwnProperty from the object prototype since the response from url.parse no longer inherits from it.
diff --git a/src/Ouzo/Goodies/Tests/CatchException.php b/src/Ouzo/Goodies/Tests/CatchException.php index <HASH>..<HASH> 100644 --- a/src/Ouzo/Goodies/Tests/CatchException.php +++ b/src/Ouzo/Goodies/Tests/CatchException.php @@ -8,6 +8,22 @@ namespace Ouzo\Tests; use Throwable; +/** + * Class CatchException can be u...
Few words of docs in CatchException class
diff --git a/lib/manager.js b/lib/manager.js index <HASH>..<HASH> 100644 --- a/lib/manager.js +++ b/lib/manager.js @@ -1,4 +1,3 @@ - /*! * socket.io-node * Copyright(c) 2011 LearnBoost <dev@learnboost.com> @@ -821,9 +820,9 @@ Manager.prototype.handshakeData = function (data) { , connectionAddress; if (co...
Updated Manager.prototype.handshakeData to provide connection.remoteAddress instead of .address() because .address() was returning server IP and .remoteAddress returns client IP.
diff --git a/client/request.php b/client/request.php index <HASH>..<HASH> 100644 --- a/client/request.php +++ b/client/request.php @@ -21,7 +21,9 @@ class Request { // ensure params are utf8 if ($params !== null) { foreach ($params as &$param) { - $param = utf8_encode($para...
Only UTF8 encode strings to preserve other data types
diff --git a/scapy/volatile.py b/scapy/volatile.py index <HASH>..<HASH> 100644 --- a/scapy/volatile.py +++ b/scapy/volatile.py @@ -295,7 +295,7 @@ class RandIP6(RandString): remain = random.randint(0,remain) for j in range(remain): ip.append("%04x" % random.ran...
RandIP6() with default '**' fails, this seems to do the right thing
diff --git a/clam/clamdispatcher.py b/clam/clamdispatcher.py index <HASH>..<HASH> 100755 --- a/clam/clamdispatcher.py +++ b/clam/clamdispatcher.py @@ -261,6 +261,7 @@ def main(): if os.path.exists(projectdir + '.pid'): os.unlink(projectdir + '.pid') #update project index cache + print("[CLAM ...
a bit more verbosity
diff --git a/server/sonar-web/src/main/js/apps/issues/models/issue.js b/server/sonar-web/src/main/js/apps/issues/models/issue.js index <HASH>..<HASH> 100644 --- a/server/sonar-web/src/main/js/apps/issues/models/issue.js +++ b/server/sonar-web/src/main/js/apps/issues/models/issue.js @@ -4,9 +4,7 @@ define([ return ...
SONAR-<I> decrease the list of kept issue fields
diff --git a/lib/Cake/Console/Command/Task/ProjectTask.php b/lib/Cake/Console/Command/Task/ProjectTask.php index <HASH>..<HASH> 100644 --- a/lib/Cake/Console/Command/Task/ProjectTask.php +++ b/lib/Cake/Console/Command/Task/ProjectTask.php @@ -388,7 +388,7 @@ class ProjectTask extends Shell { ))->addOption('empty', ...
removing DS, App::core('Console') already ends with DS
diff --git a/test/ssl_test.js b/test/ssl_test.js index <HASH>..<HASH> 100644 --- a/test/ssl_test.js +++ b/test/ssl_test.js @@ -126,7 +126,7 @@ test('before cert expiration, fallback to newest cert bundle and stick if node d TestHelper.config.instrumental.tlsVariationTimeout = 500; - var timeBetweenSends = 1000;...
Fix intermittent test failures There seems to be occasional failures with these tests related to timing issues. This adds some additional buffer time and seems to resolve the issues.
diff --git a/core/core.js b/core/core.js index <HASH>..<HASH> 100644 --- a/core/core.js +++ b/core/core.js @@ -428,7 +428,8 @@ exports._setup = function() { _globals.core.Item.prototype.addChild = function(child) { _globals.core.Object.prototype.addChild.apply(this, arguments) if ('_tryFocus' in child) - chil...
propagate focus over invisible childs and from addChild
diff --git a/classes/Tools/Storage/StorageTool.php b/classes/Tools/Storage/StorageTool.php index <HASH>..<HASH> 100755 --- a/classes/Tools/Storage/StorageTool.php +++ b/classes/Tools/Storage/StorageTool.php @@ -3011,7 +3011,11 @@ class StorageTool extends Tool public function handleSmushImageOptimizer( $post...
fix: Media Cloud metadata is not saved when Smush is active fixes #<I>
diff --git a/fakeca_test.go b/fakeca_test.go index <HASH>..<HASH> 100644 --- a/fakeca_test.go +++ b/fakeca_test.go @@ -155,7 +155,10 @@ func TestPFX(t *testing.T) { } func assertNoPanic(t *testing.T, cb func()) { - t.Helper() + // Check that t.Helper() is defined for Go<1.9 + if h, ok := interface{}(t).(interface{ ...
*testing.T doesn't have Helper() method before go <I>
diff --git a/lib/comfortable_mexican_sofa/form_builder.rb b/lib/comfortable_mexican_sofa/form_builder.rb index <HASH>..<HASH> 100644 --- a/lib/comfortable_mexican_sofa/form_builder.rb +++ b/lib/comfortable_mexican_sofa/form_builder.rb @@ -43,7 +43,7 @@ class ComfortableMexicanSofa::FormBuilder < ActionView::Helpers::Fo...
Removed annoying capitalize from labels in sofa's form builder.
diff --git a/lib/mongodb/connection/connection.js b/lib/mongodb/connection/connection.js index <HASH>..<HASH> 100644 --- a/lib/mongodb/connection/connection.js +++ b/lib/mongodb/connection/connection.js @@ -12,7 +12,7 @@ var Connection = exports.Connection = function(id, socketOptions) { // Store all socket options ...
disabled keepalive by default for win<I>
diff --git a/shoebot/data/bezier.py b/shoebot/data/bezier.py index <HASH>..<HASH> 100644 --- a/shoebot/data/bezier.py +++ b/shoebot/data/bezier.py @@ -272,7 +272,7 @@ class ClippingPath(BezierPath): class EndClip(Grob): def __init__(self, canvas, **kwargs): - Grob.__init__(canvas = canvas) + Grob....
Wasn't passing self to EndClip
diff --git a/scripts/merge-pr.py b/scripts/merge-pr.py index <HASH>..<HASH> 100755 --- a/scripts/merge-pr.py +++ b/scripts/merge-pr.py @@ -297,11 +297,17 @@ if not bool(pr["mergeable"]): continue_maybe(msg) print("\n=== Pull Request #%s ===" % pr_num) + +# we may have un-printable unicode in our title +try: + ...
ADMIN: edit in merge-pr script to handle unicode titles
diff --git a/src/actions/GlideAction.php b/src/actions/GlideAction.php index <HASH>..<HASH> 100644 --- a/src/actions/GlideAction.php +++ b/src/actions/GlideAction.php @@ -5,6 +5,7 @@ namespace trntv\glide\actions; use Symfony\Component\HttpFoundation\Request; use Yii; use yii\base\Action; +use yii\web\Response; use...
fix image show problem directly browser url like '<URL>
diff --git a/test/timezone_test.rb b/test/timezone_test.rb index <HASH>..<HASH> 100644 --- a/test/timezone_test.rb +++ b/test/timezone_test.rb @@ -33,6 +33,7 @@ class TimezoneTest < Test::Unit::TestCase def test_getting_utc_offset assert_equal 36000, Timezone::Zone.new(:zone => 'Australia/Sydney').utc_offset ...
Added a test for utc_offset in half zones as well.
diff --git a/cassandra/query.py b/cassandra/query.py index <HASH>..<HASH> 100644 --- a/cassandra/query.py +++ b/cassandra/query.py @@ -100,8 +100,8 @@ class Statement(object): def _set_routing_key(self, key): if isinstance(key, (list, tuple)): - self._routing_key = "".join(struct.pack("HsB", ...
Use bytes literals for joining routing key components
diff --git a/entity-store/src/main/java/jetbrains/exodus/entitystore/PersistentEntityStoreImpl.java b/entity-store/src/main/java/jetbrains/exodus/entitystore/PersistentEntityStoreImpl.java index <HASH>..<HASH> 100644 --- a/entity-store/src/main/java/jetbrains/exodus/entitystore/PersistentEntityStoreImpl.java +++ b/enti...
#XD-<I> fixed
diff --git a/tests/test_apps/kafkaimporter/client/kafkaimporter/KafkaImportBenchmark.java b/tests/test_apps/kafkaimporter/client/kafkaimporter/KafkaImportBenchmark.java index <HASH>..<HASH> 100644 --- a/tests/test_apps/kafkaimporter/client/kafkaimporter/KafkaImportBenchmark.java +++ b/tests/test_apps/kafkaimporter/clie...
ENG-<I>, release <I>.x: straightening out some mix ups
diff --git a/sos/plugins/__init__.py b/sos/plugins/__init__.py index <HASH>..<HASH> 100644 --- a/sos/plugins/__init__.py +++ b/sos/plugins/__init__.py @@ -488,7 +488,7 @@ class Plugin(object): self.soslog.warning("command '%s' timed out after %ds" % (prog, timeout)) if status ...
Fix verbose file logging Prior versions of sos enable debug logging to the embedded log file (sos_logs/sos.log) when a single '-v' is given. Restore this behaviour and ensure that command-not-found messages are reported at 'info' rather than 'warning' level.
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -69,7 +69,7 @@ setup(name='django-defender', include_package_data=True, packages=get_packages('defender'), package_data=get_package_data('defender'), - install_requires=['Django>=1.6,<1.9', 'redis==2....
Django <I> is supported in installation requirements.
diff --git a/gpcharts.py b/gpcharts.py index <HASH>..<HASH> 100644 --- a/gpcharts.py +++ b/gpcharts.py @@ -8,7 +8,7 @@ # Python3 compatibility import sys python_version = sys.version_info[0] -if python_version == 3: +if python_version >= 3: try: from past.builtins import xrange except ImportError:
Fixing Python 4 compatibility issue It is presumed that Python4 will be mostly, if not completely, backwards compatible with Python3. At the same time, it will not revert to Python2 compatibility. As such, Python3 patches like this should also be written to be seen by future versions of Python.
diff --git a/examples/example_filter_listbox.py b/examples/example_filter_listbox.py index <HASH>..<HASH> 100644 --- a/examples/example_filter_listbox.py +++ b/examples/example_filter_listbox.py @@ -2,8 +2,9 @@ # This example shows how to change the items of a ListBox widget # when the current selection of a DropDown...
examples/example_filter_listbox: Clean up imports, import defs.
diff --git a/bot/action/standard/logger.py b/bot/action/standard/logger.py index <HASH>..<HASH> 100644 --- a/bot/action/standard/logger.py +++ b/bot/action/standard/logger.py @@ -1,6 +1,7 @@ from bot.action.core.action import IntermediateAction from bot.logger.logger import LoggerFactory from bot.logger.message_send...
Update scheduler callbacks to use LoggerAction logger once it is created
diff --git a/graphistry/plotter.py b/graphistry/plotter.py index <HASH>..<HASH> 100644 --- a/graphistry/plotter.py +++ b/graphistry/plotter.py @@ -71,6 +71,11 @@ class Plotter(object): else: g = graph n = self.nodes if nodes is None else nodes + + if self.source is None or self.des...
NewAPI: Check that at least source/dest are bound before attempting to plot
diff --git a/public/javascripts/wymeditor/jquery.refinery.wymeditor.js b/public/javascripts/wymeditor/jquery.refinery.wymeditor.js index <HASH>..<HASH> 100755 --- a/public/javascripts/wymeditor/jquery.refinery.wymeditor.js +++ b/public/javascripts/wymeditor/jquery.refinery.wymeditor.js @@ -2437,7 +2437,8 @@ WYMeditor.X...
support flashvars in an embed code
diff --git a/spec/features/translations_spec.rb b/spec/features/translations_spec.rb index <HASH>..<HASH> 100644 --- a/spec/features/translations_spec.rb +++ b/spec/features/translations_spec.rb @@ -99,13 +99,11 @@ describe "translations" do expect(page).to have_content("Language") locales.each{|locale| expec...
removing 'wait for ajax' in js testing
diff --git a/lxd/patches.go b/lxd/patches.go index <HASH>..<HASH> 100644 --- a/lxd/patches.go +++ b/lxd/patches.go @@ -3464,7 +3464,7 @@ var legacyPatches = map[int](func(d *Daemon) error){ 30: patchUpdateFromV29, 31: patchUpdateFromV30, } -var legacyPatchesNeedingDB = []int{11, 12, 16} // Legacy patches doing DB ...
Don't use the db in legacy patch <I>
diff --git a/src/layers/cip/objects/Connection.js b/src/layers/cip/objects/Connection.js index <HASH>..<HASH> 100644 --- a/src/layers/cip/objects/Connection.js +++ b/src/layers/cip/objects/Connection.js @@ -609,11 +609,18 @@ const InstanceAttributeDataTypes = { [InstanceAttributeCodes.ConsumedConnectionPath]: DataTy...
Updated CIP Connection binding list instance attribute data type
diff --git a/tests/helpers.py b/tests/helpers.py index <HASH>..<HASH> 100644 --- a/tests/helpers.py +++ b/tests/helpers.py @@ -1,10 +1,4 @@ -from nose import SkipTest -from nose.tools import assert_raises from flask.app import Flask -try: - from flask import __version__ as FLASK_VERSION -except ImportError: - FL...
Don't skip test when Flask <I> Just don't skip test, since Flask-Assets requires at least Flask <I>.
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -866,8 +866,8 @@ function flameGraph (opts) { } chart.getNodeRect = id => { - // returns the node position and size on canvas, or false. - return typeof (id) === 'number' && getNodeRect(id) + // returns the no...
fixing the return value when no node is found
diff --git a/lib/accesslib.php b/lib/accesslib.php index <HASH>..<HASH> 100755 --- a/lib/accesslib.php +++ b/lib/accesslib.php @@ -3023,7 +3023,7 @@ function get_enrolled_sql($context, $withcapability = '', $groupid = 0, $onlyact $ctxids = implode(',', $contextids); $roleids = implode(...
lib MDL-<I> Added missing field in get_enrolled_sql causing errors when capability had prohibited roles
diff --git a/src/Concerns/InteractsWithElements.php b/src/Concerns/InteractsWithElements.php index <HASH>..<HASH> 100644 --- a/src/Concerns/InteractsWithElements.php +++ b/src/Concerns/InteractsWithElements.php @@ -187,6 +187,11 @@ trait InteractsWithElements if (is_null($value)) { $options[array_...
Update InteractsWithElements.php cast boolean value to their appropriate string integer value.
diff --git a/Parsedown.php b/Parsedown.php index <HASH>..<HASH> 100755 --- a/Parsedown.php +++ b/Parsedown.php @@ -90,7 +90,6 @@ class Parsedown '<' => array('Markup'), '=' => array('Setext'), '>' => array('Quote'), - '[' => array('Reference'), '_' => array('Rule'), '...
"reference" is a definition
diff --git a/cfs/main.go b/cfs/main.go index <HASH>..<HASH> 100644 --- a/cfs/main.go +++ b/cfs/main.go @@ -73,6 +73,7 @@ func (NullWriter) Write([]byte) (int, error) { return 0, nil } func main() { + fusermountPath() flag.Usage = printUsage flag.Parse() clargs := getArgs(flag.Args()) @@ -178,6 +179,16 @@ fun...
Running with mount command has no environment PATH The environment PATH variable has to contain the path to /bin/fusermount
diff --git a/discovery-model/src/main/java/com/ticketmaster/discovery/model/Page.java b/discovery-model/src/main/java/com/ticketmaster/discovery/model/Page.java index <HASH>..<HASH> 100644 --- a/discovery-model/src/main/java/com/ticketmaster/discovery/model/Page.java +++ b/discovery-model/src/main/java/com/ticketmaster...
fix NPE in case when none templated links appears in response JSON
diff --git a/fints/client.py b/fints/client.py index <HASH>..<HASH> 100644 --- a/fints/client.py +++ b/fints/client.py @@ -498,12 +498,12 @@ class FinTS3Client: ) logger.info('Fetching done.') - statement = [] - for seg in responses: - # Note: MT940 messages are enco...
Concatenate HIKAZ data before MT<I> parsing. Some banks (especially Sparkasse) send HIKAZ data split over multiple segments, which led to MT<I> parsing errors. The patch changes the way the segments are parsed. Fixes #<I> .
diff --git a/lib/stripe_event.rb b/lib/stripe_event.rb index <HASH>..<HASH> 100644 --- a/lib/stripe_event.rb +++ b/lib/stripe_event.rb @@ -52,7 +52,6 @@ module StripeEvent 'plan.updated', 'plan.deleted', 'coupon.created', - 'coupon.updated', 'coupon.deleted', 'transfer.created', 'transf...
Remove old event type coupon.updated event no longer exists
diff --git a/docs/source/conf.py b/docs/source/conf.py index <HASH>..<HASH> 100644 --- a/docs/source/conf.py +++ b/docs/source/conf.py @@ -267,3 +267,10 @@ texinfo_documents = [ # Example configuration for intersphinx: refer to the Python standard library. intersphinx_mapping = {'http://docs.python.org/': None} + +...
Re-add workaround for rendering of Unicode minus sign in PDF output.
diff --git a/lib/Doctrine/Record.php b/lib/Doctrine/Record.php index <HASH>..<HASH> 100644 --- a/lib/Doctrine/Record.php +++ b/lib/Doctrine/Record.php @@ -1513,15 +1513,14 @@ abstract class Doctrine_Record extends Doctrine_Record_Abstract implements Count { static $methods = array(); if ( isset( ...
remove caching of args. it is just plain wrong
diff --git a/equal/main.go b/equal/main.go index <HASH>..<HASH> 100644 --- a/equal/main.go +++ b/equal/main.go @@ -24,7 +24,7 @@ func main() { if equal { fmt.Println("equal: files match") - os.Exit(0) + return // cleaner than os.Exit(0) } fmt.Println("equal: files differ")
return from main is cleaner than os.Exit(0).