diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/branch_io_cli/configuration/configuration.rb b/lib/branch_io_cli/configuration/configuration.rb index <HASH>..<HASH> 100644 --- a/lib/branch_io_cli/configuration/configuration.rb +++ b/lib/branch_io_cli/configuration/configuration.rb @@ -359,7 +359,7 @@ EOF return @branch_imports if @branch_im...
Better handling of source files that cannot be opened. (Usually from an unresolved setting like PROJECT_DIR/PROJECT_NAME/Bridging-Header.h)
diff --git a/src/components/storage/storage__local.js b/src/components/storage/storage__local.js index <HASH>..<HASH> 100644 --- a/src/components/storage/storage__local.js +++ b/src/components/storage/storage__local.js @@ -7,8 +7,8 @@ var safePromise = function (resolver) { otherwise(function (e) { if (e &&...
RG-<I> Storage: don't expect that everything in localStorage is json: indent Former-commit-id: 0e<I>f<I>d1fec<I>f5d<I>df0bafbb6a4d4
diff --git a/lib/zendesk_apps_support/validations/translations.rb b/lib/zendesk_apps_support/validations/translations.rb index <HASH>..<HASH> 100644 --- a/lib/zendesk_apps_support/validations/translations.rb +++ b/lib/zendesk_apps_support/validations/translations.rb @@ -49,7 +49,7 @@ module ZendeskAppsSupport ...
fix error caused by unsafe hash check
diff --git a/karma.conf.js b/karma.conf.js index <HASH>..<HASH> 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -33,7 +33,7 @@ module.exports = function(config) { // test results reporter to use // possible values: 'dots', 'progress' // available reporters: https://npmjs.org/browse/keyword/karma-reporter - ...
Progress reporter is too noisy on TravisCI. Use dots reporter instead.
diff --git a/dispatch/static/manager/src/js/api/dispatch.js b/dispatch/static/manager/src/js/api/dispatch.js index <HASH>..<HASH> 100644 --- a/dispatch/static/manager/src/js/api/dispatch.js +++ b/dispatch/static/manager/src/js/api/dispatch.js @@ -1,7 +1,7 @@ import fetch from 'isomorphic-fetch' import url from 'url' ...
also revert redux devtools stuff
diff --git a/config/ember-try.js b/config/ember-try.js index <HASH>..<HASH> 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -75,8 +75,9 @@ module.exports = async function () { }, }, }, - embroiderSafe(), - embroiderOptimized(), + // Remove Embroider builds for now...
Remove Embroider compatibility builds from Ember Try config
diff --git a/src/Validators/ConstRangeValidator.php b/src/Validators/ConstRangeValidator.php index <HASH>..<HASH> 100644 --- a/src/Validators/ConstRangeValidator.php +++ b/src/Validators/ConstRangeValidator.php @@ -34,6 +34,11 @@ class ConstRangeValidator extends RangeValidator */ public $targetClass; + ...
Add filter to ConstRangeValidator
diff --git a/lib/node-progress.js b/lib/node-progress.js index <HASH>..<HASH> 100644 --- a/lib/node-progress.js +++ b/lib/node-progress.js @@ -88,6 +88,14 @@ ProgressBar.prototype.tick = function(len, tokens){ this.render(tokens); }; +/** + * Method to render the progress bar with optional `tokens` to + * place i...
Added JSDoc for render method
diff --git a/languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/GermanSpellerRule.java b/languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/GermanSpellerRule.java index <HASH>..<HASH> 100644 --- a/languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/German...
[de] don't suggest ugly form "gefakt" (even though technically correct)
diff --git a/pyowm/parsers/jsonparser.py b/pyowm/parsers/jsonparser.py index <HASH>..<HASH> 100644 --- a/pyowm/parsers/jsonparser.py +++ b/pyowm/parsers/jsonparser.py @@ -100,7 +100,10 @@ def build_weather_from(d): humidity = 0 # -- snow is not a mandatory field if 'snow' in d: - ...
Fixed bug: snow item in JSON daily weather forecasts was treated as a dict while it could have been also a float
diff --git a/assess_autoload_credentials.py b/assess_autoload_credentials.py index <HASH>..<HASH> 100755 --- a/assess_autoload_credentials.py +++ b/assess_autoload_credentials.py @@ -439,9 +439,9 @@ def write_openstack_config_file(tmp_dir, user, credential_details): def ensure_openstack_personal_cloud_exists(clien...
Improve sanity check for writing clouds.yaml.
diff --git a/lib/committee/test/methods.rb b/lib/committee/test/methods.rb index <HASH>..<HASH> 100644 --- a/lib/committee/test/methods.rb +++ b/lib/committee/test/methods.rb @@ -1,9 +1,5 @@ module Committee::Test module Methods - def self.included(klass) - klass.send(:include, Rack::Test::Methods) - end...
Less magic; require an explicit inclusion of `Rack::Test::Methods`
diff --git a/hazelcast/src/main/java/com/hazelcast/cache/impl/AbstractCacheService.java b/hazelcast/src/main/java/com/hazelcast/cache/impl/AbstractCacheService.java index <HASH>..<HASH> 100644 --- a/hazelcast/src/main/java/com/hazelcast/cache/impl/AbstractCacheService.java +++ b/hazelcast/src/main/java/com/hazelcast/ca...
Acquire WanReplicationService from NodeEngine while deleting cache The same cache deletion mechanism is used during node shutdown too, and acquiring `WanReplicationService` can fail in that case.
diff --git a/wallace/db/base/attrs/datatypes.py b/wallace/db/base/attrs/datatypes.py index <HASH>..<HASH> 100644 --- a/wallace/db/base/attrs/datatypes.py +++ b/wallace/db/base/attrs/datatypes.py @@ -81,10 +81,14 @@ class UUID(String): is_uuid, ) - def __set__(self, inst, val): + @classmethod + ...
fix typecasting for UUID types
diff --git a/lib/ProMotion/classes/Screen.rb b/lib/ProMotion/classes/Screen.rb index <HASH>..<HASH> 100644 --- a/lib/ProMotion/classes/Screen.rb +++ b/lib/ProMotion/classes/Screen.rb @@ -195,6 +195,7 @@ module ProMotion end def view_will_appear(animated) + self.will_appear if self.respond_to? :will_app...
Added will_appear method.
diff --git a/src/sortablejs.js b/src/sortablejs.js index <HASH>..<HASH> 100644 --- a/src/sortablejs.js +++ b/src/sortablejs.js @@ -91,7 +91,7 @@ function init(Survey) { }; var getChoicesNotInResults = function () { var res = []; - question.activeChoices.forEach(function (choice) { + ...
Fix #<I> sortableList randomized order not working
diff --git a/src/com/opera/core/systems/scope/services/ums/SystemInputManager.java b/src/com/opera/core/systems/scope/services/ums/SystemInputManager.java index <HASH>..<HASH> 100644 --- a/src/com/opera/core/systems/scope/services/ums/SystemInputManager.java +++ b/src/com/opera/core/systems/scope/services/ums/SystemInp...
Could refactor this a bit, to get rid of a few unnecessary assignments;
diff --git a/src/Connection.php b/src/Connection.php index <HASH>..<HASH> 100644 --- a/src/Connection.php +++ b/src/Connection.php @@ -86,8 +86,7 @@ class Connection implements ConnectionInterface // Set request options $this->addOptions([ CURLOPT_URL => $url, - CURLOPT_POST =>...
Set curl request type to get in get request.
diff --git a/tests/frontend/org/voltdb/iv2/TestScoreboard.java b/tests/frontend/org/voltdb/iv2/TestScoreboard.java index <HASH>..<HASH> 100644 --- a/tests/frontend/org/voltdb/iv2/TestScoreboard.java +++ b/tests/frontend/org/voltdb/iv2/TestScoreboard.java @@ -41,9 +41,12 @@ public class TestScoreboard { } pr...
ENG-<I>: (#<I>) Fix unit test after scoreboard uses completionmessage timestamp.
diff --git a/errors.go b/errors.go index <HASH>..<HASH> 100644 --- a/errors.go +++ b/errors.go @@ -83,7 +83,7 @@ import ( "github.com/getlantern/context" "github.com/getlantern/hidden" "github.com/getlantern/ops" - "github.com/getlantern/stack" + "github.com/go-stack/stack" ) // Error wraps system and applica...
switch back to go-stack/stack
diff --git a/src/request.php b/src/request.php index <HASH>..<HASH> 100644 --- a/src/request.php +++ b/src/request.php @@ -66,6 +66,23 @@ public static function get_method() { } /** + * get the http ($_POST) data + * mainly useful for data from non-POST requests like PUT/PATCH/DELETE + * + * @return array a like $...
allows to fetch $_POST data for PUT/PATCH/DELETE requests
diff --git a/store/tikv/2pc.go b/store/tikv/2pc.go index <HASH>..<HASH> 100644 --- a/store/tikv/2pc.go +++ b/store/tikv/2pc.go @@ -588,8 +588,8 @@ func (c *twoPhaseCommitter) shouldWriteBinlog() bool { } // TiKV recommends each RPC packet should be less than ~1MB. We keep each packet's -// Key+Value size below 4KB....
Push more write flow to tikv (#<I>)
diff --git a/accordion.js b/accordion.js index <HASH>..<HASH> 100644 --- a/accordion.js +++ b/accordion.js @@ -6,12 +6,18 @@ // we're in a CommonJS environment; otherwise we'll just fail out if( vui === undefined ) { if( typeof require === 'function' ) { - module.exports = vui = require('../../vui'); + v...
just checking for require isn't necessarily a CommonJS env. could be AMD based
diff --git a/lib/actv/version.rb b/lib/actv/version.rb index <HASH>..<HASH> 100644 --- a/lib/actv/version.rb +++ b/lib/actv/version.rb @@ -1,3 +1,3 @@ module ACTV - VERSION = "1.4.2" + VERSION = "1.4.3" end
Bumps patch version to <I>
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -131,6 +131,7 @@ var sig = module.exports = function(messenger, opts) { // initialise the data event name var dataEvent = (opts || {}).dataEvent || 'data'; var openEvent = (opts || {}).openEvent || 'open'; + var clos...
Primus close event generates disconnected event, ref #<I>
diff --git a/Swat/SwatString.php b/Swat/SwatString.php index <HASH>..<HASH> 100644 --- a/Swat/SwatString.php +++ b/Swat/SwatString.php @@ -1089,13 +1089,8 @@ class SwatString extends SwatObject */ public static function hash($string) { - $hash = md5($string); - - $string = ''; - for ($i = 0; $i < strlen($hash...
This is over <I> times faster in KCacheGrind profiles and does the same thing. For widgets that use a lot of serialized values (SwatDateEntry for example) this used to add up to about <I>% of the overhead of using Swat. Kudos to Mark PK for noticing this. svn commit r<I>
diff --git a/lib/specinfra/command/openbsd.rb b/lib/specinfra/command/openbsd.rb index <HASH>..<HASH> 100644 --- a/lib/specinfra/command/openbsd.rb +++ b/lib/specinfra/command/openbsd.rb @@ -47,11 +47,25 @@ module SpecInfra "egrep '^#{escape(recipient)}:.*#{escape(target)}' /etc/mail/aliases" end + ...
Add OpenBSD specific commands for checking file status
diff --git a/src/SelectionControls/SelectionControlModel.php b/src/SelectionControls/SelectionControlModel.php index <HASH>..<HASH> 100644 --- a/src/SelectionControls/SelectionControlModel.php +++ b/src/SelectionControls/SelectionControlModel.php @@ -49,6 +49,7 @@ class SelectionControlModel extends ControlModel {...
Selection controls pass their supportsMultipleSelection to the viewbridge
diff --git a/core/node/dns.go b/core/node/dns.go index <HASH>..<HASH> 100644 --- a/core/node/dns.go +++ b/core/node/dns.go @@ -26,7 +26,7 @@ func DNSResolver(cfg *config.Config) (*madns.Resolver, error) { hasEth := false for domain, url := range cfg.DNS.Resolvers { - if !dns.IsFqdn(domain) { + if domain != "." ...
the dot is not really an FQDN
diff --git a/src/angular-materialize.js b/src/angular-materialize.js index <HASH>..<HASH> 100644 --- a/src/angular-materialize.js +++ b/src/angular-materialize.js @@ -767,6 +767,7 @@ // Internal Pagination Click Action function internalAction(scope, page) { + page = page.value...
Fixed that the pagination-action sometimes returned an object, instead of a number. Fixes #<I> (again).
diff --git a/spec/integration/ssh_spec.rb b/spec/integration/ssh_spec.rb index <HASH>..<HASH> 100644 --- a/spec/integration/ssh_spec.rb +++ b/spec/integration/ssh_spec.rb @@ -39,25 +39,20 @@ describe Gas::Ssh do it 'should detect when an id_rsa is already in the .gas directory', :current => true do Gas:...
commented out some junk in a before filter that probably can be removed
diff --git a/src/js/JSONEditor.js b/src/js/JSONEditor.js index <HASH>..<HASH> 100644 --- a/src/js/JSONEditor.js +++ b/src/js/JSONEditor.js @@ -171,7 +171,7 @@ function JSONEditor (container, options, json) { */ JSONEditor.modes = {} -// debounce interval for JSON schema vaidation in milliseconds +// debounce inter...
docs: Fix simple typo, vaidation -> validation (#<I>) There is a small typo in src/js/JSONEditor.js. Should read `validation` rather than `vaidation`.
diff --git a/src/Router.php b/src/Router.php index <HASH>..<HASH> 100644 --- a/src/Router.php +++ b/src/Router.php @@ -240,7 +240,7 @@ class Router { self::$errorCallback = function () { - var_dump(self::$uri); + /* Set errors */ }; ...
Updated to version <I>
diff --git a/user/index.php b/user/index.php index <HASH>..<HASH> 100644 --- a/user/index.php +++ b/user/index.php @@ -410,9 +410,9 @@ list($esql, $params) = get_enrolled_sql($context, null, $currentgroup, true); $joins = array("FROM {user} u"); $wheres = array(); -$mainuserfields = user_picture::fields('u', array(...
MDL-<I> user: Add duplicate field check to avoid oracle db error.
diff --git a/elastic.js b/elastic.js index <HASH>..<HASH> 100644 --- a/elastic.js +++ b/elastic.js @@ -186,6 +186,8 @@ angular.module('monospaced.elastic', []) forceAdjust(); }); + $timeout(adjust); + /* * destroy */
restore inital run of adjust in timeout #<I>
diff --git a/src/pixi/display/MovieClip.js b/src/pixi/display/MovieClip.js index <HASH>..<HASH> 100644 --- a/src/pixi/display/MovieClip.js +++ b/src/pixi/display/MovieClip.js @@ -73,6 +73,23 @@ PIXI.MovieClip.prototype = Object.create( PIXI.Sprite.prototype ); PIXI.MovieClip.prototype.constructor = PIXI.MovieClip; ...
Added totalframes to MovieClip
diff --git a/src/main/java/org/influxdb/dto/Point.java b/src/main/java/org/influxdb/dto/Point.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/influxdb/dto/Point.java +++ b/src/main/java/org/influxdb/dto/Point.java @@ -276,11 +276,11 @@ public class Point { } if (column.tag()) { - i...
Fixing build Adding space after if
diff --git a/src/Embera/Provider/Altru.php b/src/Embera/Provider/Altru.php index <HASH>..<HASH> 100755 --- a/src/Embera/Provider/Altru.php +++ b/src/Embera/Provider/Altru.php @@ -52,6 +52,7 @@ class Altru extends ProviderAdapter implements ProviderInterface /** inline {@inheritdoc} */ public function getFakeR...
Added missing vars on Altru provider
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -4,7 +4,7 @@ import path from 'path'; import MagicString from 'magic-string'; import { createFilter } from 'rollup-pluginutils'; -const componentRegex = /@Component\({([\s\S]*)}\)$/gm; +const componentRegex...
Accept whitespace before braces in @Component (#<I>) * Accept whitespace before braces in @Component Change componentRegex to also accept a single whitespace before { and after } to support further coding styles * Reset package version
diff --git a/demo/demo-scriptinclude.js b/demo/demo-scriptinclude.js index <HASH>..<HASH> 100755 --- a/demo/demo-scriptinclude.js +++ b/demo/demo-scriptinclude.js @@ -10,8 +10,16 @@ function init() { foucTarget && (foucTarget.className = ''); // Add the card container listeners, using the necessary event trigge...
feat(demo): Add event listener for card comments.
diff --git a/src/Silex/Util/Compiler.php b/src/Silex/Util/Compiler.php index <HASH>..<HASH> 100644 --- a/src/Silex/Util/Compiler.php +++ b/src/Silex/Util/Compiler.php @@ -82,7 +82,8 @@ class Compiler $phar->stopBuffering(); - // $phar->compressFiles(\Phar::GZ); + // FIXME: phar compression fe...
Make reason of prenatal code visible. Code is commented since ages, the reason is missing (because there is a reason).
diff --git a/eZ/Publish/Core/Persistence/Legacy/Content/Type/Handler.php b/eZ/Publish/Core/Persistence/Legacy/Content/Type/Handler.php index <HASH>..<HASH> 100644 --- a/eZ/Publish/Core/Persistence/Legacy/Content/Type/Handler.php +++ b/eZ/Publish/Core/Persistence/Legacy/Content/Type/Handler.php @@ -476,6 +476,7 @@ class...
Fixed: missing param in phpdoc
diff --git a/Eloquent/Model.php b/Eloquent/Model.php index <HASH>..<HASH> 100644 --- a/Eloquent/Model.php +++ b/Eloquent/Model.php @@ -8,12 +8,10 @@ use JsonSerializable; use Illuminate\Support\Arr; use Illuminate\Support\Str; use Illuminate\Contracts\Support\Jsonable; -use Illuminate\Contracts\Events\Dispatcher; u...
Remove useless imports. (#<I>)
diff --git a/eZ/Publish/API/REST/Server/View/Visitor.php b/eZ/Publish/API/REST/Server/View/Visitor.php index <HASH>..<HASH> 100644 --- a/eZ/Publish/API/REST/Server/View/Visitor.php +++ b/eZ/Publish/API/REST/Server/View/Visitor.php @@ -44,7 +44,16 @@ class Visitor extends RMF\View */ public function display( ...
Implemented: Correct handling of empty bodies. The visitor now automatically detects if the return value of a controller is null and then sends the correct "<I> No Content" header. This solves the issue of "No Content" for now, let's see if we need additional header handling from the controller side.
diff --git a/core/src/main/java/com/orientechnologies/orient/core/sql/method/misc/OSQLMethodFormat.java b/core/src/main/java/com/orientechnologies/orient/core/sql/method/misc/OSQLMethodFormat.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/com/orientechnologies/orient/core/sql/method/misc/OSQLMethodFormat.jav...
.format(): supported conversion from any Number
diff --git a/androguard/core/bytecodes/apk.py b/androguard/core/bytecodes/apk.py index <HASH>..<HASH> 100644 --- a/androguard/core/bytecodes/apk.py +++ b/androguard/core/bytecodes/apk.py @@ -1024,7 +1024,7 @@ class APK: ] def is_tag_matched(self, tag, **attribute_filter): - """ + r""" ...
fixs docstring in issue #<I> by pyupgrade
diff --git a/java/client/src/org/openqa/selenium/SessionNotCreatedException.java b/java/client/src/org/openqa/selenium/SessionNotCreatedException.java index <HASH>..<HASH> 100644 --- a/java/client/src/org/openqa/selenium/SessionNotCreatedException.java +++ b/java/client/src/org/openqa/selenium/SessionNotCreatedExceptio...
adding ability to pass Throwable to creating SessionNotCreatedException ~ desired by ios-driver
diff --git a/lib/ui/modal/modal.js b/lib/ui/modal/modal.js index <HASH>..<HASH> 100644 --- a/lib/ui/modal/modal.js +++ b/lib/ui/modal/modal.js @@ -237,15 +237,17 @@ proto.hide = function() { + var self = this; + var deferred = $q.defer(); this.templatePromise.then(function() { - t...
changed hide to reference self instead of this.
diff --git a/Framework/DoozR/Di/Factory.php b/Framework/DoozR/Di/Factory.php index <HASH>..<HASH> 100644 --- a/Framework/DoozR/Di/Factory.php +++ b/Framework/DoozR/Di/Factory.php @@ -48,7 +48,7 @@ * @author Benjamin Carl <opensource@clickalicious.de> * @copyright 2012 - 2013 Benjamin Carl * @license http:...
fixed: Wrong hash placeholder
diff --git a/lfs/lfs.go b/lfs/lfs.go index <HASH>..<HASH> 100644 --- a/lfs/lfs.go +++ b/lfs/lfs.go @@ -17,10 +17,6 @@ import ( "github.com/rubyist/tracerx" ) -var ( - LargeSizeThreshold = 5 * 1024 * 1024 -) - // LocalMediaDir returns the root of lfs objects func LocalMediaDir() string { if localstorage.Objects...
lfs: remove unused LargeSizeThreshold constant The constant was introduced in dca7f<I> ("really basic pre-commit hook that rejects commits with files > 5MB", <I>-<I>-<I>) and is not used anymore. Cleanup the code and remove it.
diff --git a/api/register.go b/api/register.go index <HASH>..<HASH> 100644 --- a/api/register.go +++ b/api/register.go @@ -172,7 +172,7 @@ func (this *EngineGroup) getHandlerImp(handler APIHandler) gin.HandlerFunc { session.Save(c.Request, c.Writer) switch context.code { case unresolvedCode: - c.AbortWithSta...
change unresolved statuscode StatusNoContent -> StatusInternalServerError
diff --git a/spyder/plugins/editor/widgets/codeeditor.py b/spyder/plugins/editor/widgets/codeeditor.py index <HASH>..<HASH> 100644 --- a/spyder/plugins/editor/widgets/codeeditor.py +++ b/spyder/plugins/editor/widgets/codeeditor.py @@ -2043,6 +2043,7 @@ class CodeEditor(TextEditBaseWidget): self.highlight_l...
Add docstring for highlight_line_warning
diff --git a/spyderlib/widgets/externalshell/namespacebrowser.py b/spyderlib/widgets/externalshell/namespacebrowser.py index <HASH>..<HASH> 100644 --- a/spyderlib/widgets/externalshell/namespacebrowser.py +++ b/spyderlib/widgets/externalshell/namespacebrowser.py @@ -39,7 +39,8 @@ class NamespaceBrowser(QWidget): ...
Spyder light mode's variable explorer was broken: fixed!
diff --git a/src/Http/ContentDelivery/PageBuilder/SnippetTransformation/PricesJsonSnippetTransformation.php b/src/Http/ContentDelivery/PageBuilder/SnippetTransformation/PricesJsonSnippetTransformation.php index <HASH>..<HASH> 100644 --- a/src/Http/ContentDelivery/PageBuilder/SnippetTransformation/PricesJsonSnippetTrans...
Issue #<I>: Remove unused import
diff --git a/linkedin/linkedin.py b/linkedin/linkedin.py index <HASH>..<HASH> 100644 --- a/linkedin/linkedin.py +++ b/linkedin/linkedin.py @@ -15,6 +15,7 @@ from .utils import enum, to_utf8, raise_for_error, json, StringIO __all__ = ['LinkedInAuthentication', 'LinkedInApplication', 'PERMISSIONS'] PERMISSIONS = enum...
Added rw_company_admin permission This perimission is missing. It's documented here <URL>
diff --git a/jquery.powertip.js b/jquery.powertip.js index <HASH>..<HASH> 100644 --- a/jquery.powertip.js +++ b/jquery.powertip.js @@ -101,8 +101,12 @@ }, mouseleave: function() { if (tipElement.data('mouseOnToPopup')) { - cancelHoverTimer(session.activeHover); - setHoverTimer(session.activeHo...
Added check for activeHover on tip mouseleave. Solves edge case where the mouse cursor enters the tooltip during the fadeOut cycle, causing an undefined error when the fadeOut completes and the mouseout fires.
diff --git a/app.js b/app.js index <HASH>..<HASH> 100644 --- a/app.js +++ b/app.js @@ -91,7 +91,7 @@ mongoose.connection.on('error', function (err) { }); mongoose.connection.on('disconnected', function() { - mongoose.connect(settings.mongoURI); + throw new Error('Could not connect to database'); }); //
Throw exception if mongo cannot be reached
diff --git a/mockserver-core/src/main/java/org/mockserver/mock/action/ExpectationForwardCallback.java b/mockserver-core/src/main/java/org/mockserver/mock/action/ExpectationForwardCallback.java index <HASH>..<HASH> 100644 --- a/mockserver-core/src/main/java/org/mockserver/mock/action/ExpectationForwardCallback.java +++ ...
adding default implementation for all methods so only the required ones need to be implemented
diff --git a/server/Publish.rb b/server/Publish.rb index <HASH>..<HASH> 100644 --- a/server/Publish.rb +++ b/server/Publish.rb @@ -80,7 +80,7 @@ class Dbus_actuator < DBus::Object def define_dbus_methods(methods) methdef = "dbus_interface 'org.openplacos.server.actuator' do \n " - methdef += "dbus_met...
patch for state method and $database error
diff --git a/cpp_coveralls/coverage.py b/cpp_coveralls/coverage.py index <HASH>..<HASH> 100644 --- a/cpp_coveralls/coverage.py +++ b/cpp_coveralls/coverage.py @@ -311,7 +311,7 @@ def collect(args): src_report['coverage'] = parse_gcov_file(fobj) src_files[src_path] = combine_rep...
Fixed issue with python 3 returning a view
diff --git a/Task/Generate.php b/Task/Generate.php index <HASH>..<HASH> 100644 --- a/Task/Generate.php +++ b/Task/Generate.php @@ -207,6 +207,15 @@ class Generate extends Base { * a key $property_name if data has been supplied for this property. */ protected function setComponentDataPropertyDefault($propert...
Fixed defaults set by parent properties into child items getting clobbered by child item setting defaults.
diff --git a/spec/unit/provider/directory_spec.rb b/spec/unit/provider/directory_spec.rb index <HASH>..<HASH> 100644 --- a/spec/unit/provider/directory_spec.rb +++ b/spec/unit/provider/directory_spec.rb @@ -47,6 +47,9 @@ describe Chef::Provider::Directory do end describe "scanning file security metadata on unix...
Stub windows detection in directory spec.
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -7,7 +7,7 @@ with open('requirements.txt') as f: setup( name='pyicloud', - version='0.7.0', + version='0.7.1', url='https://github.com/picklepete/pyicloud', description=( 'PyiCloud is a module ...
Release <I>; Validates Apple's server certificate (to eliminate an emitted warning).
diff --git a/src/services/EmailService.php b/src/services/EmailService.php index <HASH>..<HASH> 100644 --- a/src/services/EmailService.php +++ b/src/services/EmailService.php @@ -2,7 +2,7 @@ namespace app\email\services; -use infuse\Util; +use infuse\Utility as U; use App; @@ -22,8 +22,8 @@ class EmailService...
renamed infuse/Util to Utility
diff --git a/handler/src/main/java/io/netty/handler/stream/ChunkedInput.java b/handler/src/main/java/io/netty/handler/stream/ChunkedInput.java index <HASH>..<HASH> 100644 --- a/handler/src/main/java/io/netty/handler/stream/ChunkedInput.java +++ b/handler/src/main/java/io/netty/handler/stream/ChunkedInput.java @@ -37,7 ...
[#<I>] Correct javadoc of ChunkedInput
diff --git a/ipywidgets/widgets/widget.py b/ipywidgets/widgets/widget.py index <HASH>..<HASH> 100644 --- a/ipywidgets/widgets/widget.py +++ b/ipywidgets/widgets/widget.py @@ -266,6 +266,12 @@ class Widget(LoggingConfigurable): """Return (state_without_buffers, state_with_buffers, buffer_paths, buffers) for bin...
better docstring for _split_state_buffers
diff --git a/admin/cron.php b/admin/cron.php index <HASH>..<HASH> 100644 --- a/admin/cron.php +++ b/admin/cron.php @@ -20,6 +20,7 @@ echo "<pre>\n"; $timenow = time(); + echo "Server Time: ".date('r',$timenow)."\n\n"; /// Run all cron jobs for each module
Output the time in the cron output
diff --git a/lib/HotModuleReplacementPlugin.js b/lib/HotModuleReplacementPlugin.js index <HASH>..<HASH> 100644 --- a/lib/HotModuleReplacementPlugin.js +++ b/lib/HotModuleReplacementPlugin.js @@ -153,7 +153,7 @@ module.exports = class HotModuleReplacementPlugin { const buf = [source]; buf.push(""); buf.pu...
- Fix bug while refactoring HotModuleReplacementPlugin as suggested in PR
diff --git a/p2p/muxer/yamux/transport.go b/p2p/muxer/yamux/transport.go index <HASH>..<HASH> 100644 --- a/p2p/muxer/yamux/transport.go +++ b/p2p/muxer/yamux/transport.go @@ -2,6 +2,7 @@ package sm_yamux import ( "io/ioutil" + "math" "net" "github.com/libp2p/go-libp2p-core/network" @@ -24,7 +25,9 @@ func ini...
disable the incoming streams limit (#<I>) This is now handled by the resource manager.
diff --git a/src/ComposerPlugin.php b/src/ComposerPlugin.php index <HASH>..<HASH> 100644 --- a/src/ComposerPlugin.php +++ b/src/ComposerPlugin.php @@ -20,6 +20,8 @@ use Composer\IO\IOInterface; use Composer\Plugin\PluginInterface; use Composer\Script\Event; use Composer\Script\ScriptEvents; +use Composer\Util\Proces...
Update ComposerPlugin.php (#<I>)
diff --git a/test/test.py b/test/test.py index <HASH>..<HASH> 100644 --- a/test/test.py +++ b/test/test.py @@ -27,7 +27,7 @@ for entry in os.listdir(sys.argv[1]): # Run the test. test_fname = gold_fname[:-len(suffix):] + '.py' command = '%s %s'%(sys.executable, test_fname) - #print(command) + print...
Echo command to stdout.
diff --git a/worker/provisioner/container_initialisation_test.go b/worker/provisioner/container_initialisation_test.go index <HASH>..<HASH> 100644 --- a/worker/provisioner/container_initialisation_test.go +++ b/worker/provisioner/container_initialisation_test.go @@ -177,12 +177,16 @@ func (s *ContainerSetupSuite) TestC...
worker/provisioner: fix test names
diff --git a/salt/client/ssh/state.py b/salt/client/ssh/state.py index <HASH>..<HASH> 100644 --- a/salt/client/ssh/state.py +++ b/salt/client/ssh/state.py @@ -184,10 +184,10 @@ def prep_trans_tar(opts, file_client, chunks, file_refs, pillar=None, id_=None): if id_ is None: id_ = '' try: - cach...
allow file_client to figure out cachedir We do not need to specify the entire path here. _cache_loc in salt.fileclient will do that for us. If we specify cachedir here, it will use the /var/tmp/*/running_data/var/cache path which we do not want to use when on the master. This is intelligent enough to use the /var/t...
diff --git a/src/Configurator/Helpers/RulesHelper.php b/src/Configurator/Helpers/RulesHelper.php index <HASH>..<HASH> 100644 --- a/src/Configurator/Helpers/RulesHelper.php +++ b/src/Configurator/Helpers/RulesHelper.php @@ -44,8 +44,6 @@ abstract class RulesHelper } $k = ''; - - // Look into each matrix whet...
Removed comment [ci skip]
diff --git a/ailment/analyses/simplifier.py b/ailment/analyses/simplifier.py index <HASH>..<HASH> 100644 --- a/ailment/analyses/simplifier.py +++ b/ailment/analyses/simplifier.py @@ -1,6 +1,7 @@ from angr import Analysis, register_analysis from angr.analyses.reaching_definitions import OP_AFTER +from angr.analyses....
Fix a bug where statements are incorrectly removed because we do not differentiate between internal codelocs and external codelocs.
diff --git a/gspread/models.py b/gspread/models.py index <HASH>..<HASH> 100644 --- a/gspread/models.py +++ b/gspread/models.py @@ -1596,7 +1596,7 @@ class Worksheet(object): .. _ValueInputOption: https://developers.google.com/sheets/api/reference/rest/v4/ValueInputOption """ - return self.ins...
Fixed a bug with insert_row Regardless of what the end user put as `value_input_option`, it always resulted in "RAW"
diff --git a/nfc/dev/pn53x.py b/nfc/dev/pn53x.py index <HASH>..<HASH> 100644 --- a/nfc/dev/pn53x.py +++ b/nfc/dev/pn53x.py @@ -476,7 +476,7 @@ class Device(nfc.dev.Device): pollrq = "\x00\xFF\xFF\x00\x03" nfcid3 = "\x01\xfe" + os.urandom(8) - for mode, speed in (("active", "424"), ("passive",...
poll first for NFC-DEP passive, then active mode
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -28,9 +28,15 @@ var HeaderSet = require('./header-set'); var Logger = require('./logger'); var Connection = require('./connection'); +var SerialConnection = require('./serial-connection'); var TcpConnectio...
- Added exports for serial classes and data sources
diff --git a/src/Model/Project.php b/src/Model/Project.php index <HASH>..<HASH> 100644 --- a/src/Model/Project.php +++ b/src/Model/Project.php @@ -104,7 +104,10 @@ class Project extends Resource */ public function addDomain($name, $wildcard = false, array $ssl = []) { - $body = ['name' => $name, ...
Fix - 'body' on create needs to be JSON; the API cannot cope with empty arrays
diff --git a/js/select/js/lumx.select_directive.js b/js/select/js/lumx.select_directive.js index <HASH>..<HASH> 100644 --- a/js/select/js/lumx.select_directive.js +++ b/js/select/js/lumx.select_directive.js @@ -289,7 +289,7 @@ angular.module('lumx.select', []) if ($scope.change) { - ...
fix select: missing model to ngModel rename
diff --git a/charmhelpers/contrib/openstack/utils.py b/charmhelpers/contrib/openstack/utils.py index <HASH>..<HASH> 100644 --- a/charmhelpers/contrib/openstack/utils.py +++ b/charmhelpers/contrib/openstack/utils.py @@ -140,6 +140,7 @@ UBUNTU_OPENSTACK_RELEASE = OrderedDict([ ('yakkety', 'newton'), ('zesty', '...
Add remaining series support for queens (#<I>)
diff --git a/src/public/assets/assets/scripts/admin/custom.js b/src/public/assets/assets/scripts/admin/custom.js index <HASH>..<HASH> 100644 --- a/src/public/assets/assets/scripts/admin/custom.js +++ b/src/public/assets/assets/scripts/admin/custom.js @@ -103,7 +103,20 @@ var app = { var order = u...
Icons I added icons on the column where the user has been sorting the data on.
diff --git a/system/src/Grav/Console/CleanCommand.php b/system/src/Grav/Console/CleanCommand.php index <HASH>..<HASH> 100644 --- a/system/src/Grav/Console/CleanCommand.php +++ b/system/src/Grav/Console/CleanCommand.php @@ -88,7 +88,7 @@ class CleanCommand extends Command { protected function configure() { ...
Minor description update for the CLI Clean command
diff --git a/provision/docker/provisioner.go b/provision/docker/provisioner.go index <HASH>..<HASH> 100644 --- a/provision/docker/provisioner.go +++ b/provision/docker/provisioner.go @@ -224,8 +224,8 @@ func (p *dockerProvisioner) Destroy(app provision.App) error { go func(c container) { defer containersGroup.Do...
provision/docker: fix code and build Using the proper error fixes the build (+race), and the error reporting itself.
diff --git a/tests/integration/cli/sync_test.py b/tests/integration/cli/sync_test.py index <HASH>..<HASH> 100644 --- a/tests/integration/cli/sync_test.py +++ b/tests/integration/cli/sync_test.py @@ -23,3 +23,9 @@ class TestSyncCLI(DustyIntegrationTestCase): self.assertFileContentsInContainer('busyboxa', ...
Add test that sync is now destructive
diff --git a/test/plugin/test_out_elasticsearch.rb b/test/plugin/test_out_elasticsearch.rb index <HASH>..<HASH> 100644 --- a/test/plugin/test_out_elasticsearch.rb +++ b/test/plugin/test_out_elasticsearch.rb @@ -4107,12 +4107,6 @@ class ElasticsearchOutputTest < Test::Unit::TestCase stub_request(:post, url) ...
test: out_elasticsearch: Remove a needless headers from affinity stub
diff --git a/components/Validation/src/Validator/Types.php b/components/Validation/src/Validator/Types.php index <HASH>..<HASH> 100644 --- a/components/Validation/src/Validator/Types.php +++ b/components/Validation/src/Validator/Types.php @@ -17,6 +17,7 @@ */ use DateTime; +use DateTimeInterface; use Limoncello\V...
Check dates with DateTimeInterface rather than specific type DateTime.
diff --git a/grab/spider/base.py b/grab/spider/base.py index <HASH>..<HASH> 100644 --- a/grab/spider/base.py +++ b/grab/spider/base.py @@ -781,14 +781,14 @@ class Spider(object): # even if `proxy` options is set with another proxy server grab.setup(connection_reuse=False) ...
Refactored the selection of active proxy for the spider tasks
diff --git a/docs/conf.py b/docs/conf.py index <HASH>..<HASH> 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -31,9 +31,11 @@ # Add any Sphinx extension module names here, as strings. They can be # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom # ones. -extensions = ['sphinx.ext.autodoc', +exten...
docs: Clean up conf.py a bit
diff --git a/command.go b/command.go index <HASH>..<HASH> 100644 --- a/command.go +++ b/command.go @@ -1269,7 +1269,7 @@ func SetCommandBufferPool(poolSize, initBufSize, maxBufferSize int) { panic("There is no need to optimize the buffer pool anymore. Buffers have moved to Connection object.") } -func (cmd *baseCo...
Get socket timeout once per command execution, do not redefine err var in command execution loop
diff --git a/lib/spec.js b/lib/spec.js index <HASH>..<HASH> 100644 --- a/lib/spec.js +++ b/lib/spec.js @@ -19,6 +19,9 @@ var debug = require('debug')('electrolyte'); * @protected */ function Spec(id, dependencies, mod) { + var keys = Object.keys(mod) + , i, len; + this.id = id; this.dependencies = depe...
Stash all annotations on the spec.
diff --git a/p2p/dial.go b/p2p/dial.go index <HASH>..<HASH> 100644 --- a/p2p/dial.go +++ b/p2p/dial.go @@ -157,7 +157,7 @@ func (s *dialstate) removeStatic(n *discover.Node) { } func (s *dialstate) newTasks(nRunning int, peers map[discover.NodeID]*Peer, now time.Time) []task { - if s.start == (time.Time{}) { + if s...
p2p, swarm/network/kademlia: use IsZero to check for zero time (#<I>)
diff --git a/tests/settings.py b/tests/settings.py index <HASH>..<HASH> 100644 --- a/tests/settings.py +++ b/tests/settings.py @@ -8,5 +8,5 @@ DATABASES = { SECRET_KEY = 'tests' INSTALLED_APPS = ( - 'tests' + 'tests', )
Fix 'INSTALLED_APPS setting must be a list or a tuple' error
diff --git a/src/LdapTools/DomainConfiguration.php b/src/LdapTools/DomainConfiguration.php index <HASH>..<HASH> 100644 --- a/src/LdapTools/DomainConfiguration.php +++ b/src/LdapTools/DomainConfiguration.php @@ -265,7 +265,6 @@ class DomainConfiguration public function setPort($port) { $this->config['...
Fix incorrectly added semi-colon after CS fix script.
diff --git a/moco-core/src/main/java/com/github/dreamhead/moco/internal/WebsocketHandler.java b/moco-core/src/main/java/com/github/dreamhead/moco/internal/WebsocketHandler.java index <HASH>..<HASH> 100644 --- a/moco-core/src/main/java/com/github/dreamhead/moco/internal/WebsocketHandler.java +++ b/moco-core/src/main/jav...
added guard for handle frame in websocket handler
diff --git a/src/transports/remote.js b/src/transports/remote.js index <HASH>..<HASH> 100644 --- a/src/transports/remote.js +++ b/src/transports/remote.js @@ -78,6 +78,10 @@ function jsonDepth(json, depth) { } if (typeof json === 'object') { + if (json instanceof Error) { + return json.stack || json.con...
remote: Serialize Error instances correctly.
diff --git a/spec/compiler_spec.rb b/spec/compiler_spec.rb index <HASH>..<HASH> 100644 --- a/spec/compiler_spec.rb +++ b/spec/compiler_spec.rb @@ -32,8 +32,14 @@ module CorrespondenceMarkup it "compiles with backslash quoting" do parse("a\\[23\\] = b \\\\ c", :text).value.should == "a[23] = b \\ c" + ...
more backslash quoting tests
diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb index <HASH>..<HASH> 100644 --- a/activerecord/lib/active_record/base.rb +++ b/activerecord/lib/active_record/base.rb @@ -13,7 +13,6 @@ require 'active_support/core_ext/kernel/singleton_class' require 'active_support/core_ext/...
Remove duplicated `require 'arel'` It appears first in `lib/active_record.rb`.
diff --git a/bcbio/qc/multiqc.py b/bcbio/qc/multiqc.py index <HASH>..<HASH> 100644 --- a/bcbio/qc/multiqc.py +++ b/bcbio/qc/multiqc.py @@ -198,9 +198,9 @@ def _work_path_to_rel_final_path(path, upload_path_mapping, upload_base_dir): return path upload_path = None for work_path, final_path in upload_p...
MultiQC: avoid os.stat lookups when preparing final paths Attempts to do less filesystem checks to avoid long runtimes on slow filesystems. Fixes #<I>
diff --git a/test/test_generic_http_grabber.rb b/test/test_generic_http_grabber.rb index <HASH>..<HASH> 100644 --- a/test/test_generic_http_grabber.rb +++ b/test/test_generic_http_grabber.rb @@ -1,9 +1,9 @@ -require File.dirname(__FILE__) + '/helper' +#require File.dirname(__FILE__) + '/helper' -class GenericHttpGrab...
Commenting our GenericHttpGrabber test setup until we have tests.