diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/border_patrol/point.rb b/lib/border_patrol/point.rb index abc1234..def5678 100644 --- a/lib/border_patrol/point.rb +++ b/lib/border_patrol/point.rb @@ -11,5 +11,21 @@ alias :lng= :x= alias :lon :x alias :lon= :x= + + # Lots of Map APIs want the coordinates in lat-lng...
Add a friendly inspect output
diff --git a/lib/rubycritic/smell_adapters/flog.rb b/lib/rubycritic/smell_adapters/flog.rb index abc1234..def5678 100644 --- a/lib/rubycritic/smell_adapters/flog.rb +++ b/lib/rubycritic/smell_adapters/flog.rb @@ -23,12 +23,12 @@ private def create_smell(context, score) - location = smell_location(...
Rename `smell_location` method to `smell_locations`
diff --git a/app/models/channels/facebook_page_channel.rb b/app/models/channels/facebook_page_channel.rb index abc1234..def5678 100644 --- a/app/models/channels/facebook_page_channel.rb +++ b/app/models/channels/facebook_page_channel.rb @@ -27,6 +27,7 @@ end log_refresh end + handle_asynchronously :refresh...
Handle facebook channel update asynchronously
diff --git a/lib/docs/scrapers/redis.rb b/lib/docs/scrapers/redis.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/redis.rb +++ b/lib/docs/scrapers/redis.rb @@ -1,7 +1,7 @@ module Docs class Redis < UrlScraper self.type = 'redis' - self.release = 'up to 3.2.2' + self.release = 'up to 3.2.4' s...
Update Redis documentation (up to 3.2.4)
diff --git a/app/models/ability.rb b/app/models/ability.rb index abc1234..def5678 100644 --- a/app/models/ability.rb +++ b/app/models/ability.rb @@ -2,9 +2,11 @@ include CanCan::Ability def initialize(user) + # Stuff everyone can do + can [:read, :open], Document.shared + if user # Document -...
Allow everyone to read shared documents
diff --git a/app/models/ability.rb b/app/models/ability.rb index abc1234..def5678 100644 --- a/app/models/ability.rb +++ b/app/models/ability.rb @@ -11,11 +11,13 @@ can :manage, Authentication, user_id: user.id if user.is_admin? && defined? RailsAdmin + # Allow everything + an :manage, :all + ...
Allow admit to manage everything
diff --git a/app/models/comment.rb b/app/models/comment.rb index abc1234..def5678 100644 --- a/app/models/comment.rb +++ b/app/models/comment.rb @@ -2,4 +2,6 @@ belongs_to :user belongs_to :commentable, polymorphic: true has_many :votes, as: :votable + + validates :content, :user_id, :commentable_id, presence:...
Add validations to Comment class
diff --git a/sql_tagger.gemspec b/sql_tagger.gemspec index abc1234..def5678 100644 --- a/sql_tagger.gemspec +++ b/sql_tagger.gemspec @@ -9,6 +9,7 @@ s.add_development_dependency('rspec', '~> 3.4') + s.add_development_dependency('appraisal', '~> 2.1.0') s.add_development_dependency('mysql') s.add_developmen...
Add appraisal gem as a development dependency
diff --git a/lib/hem/setup.rb b/lib/hem/setup.rb index abc1234..def5678 100644 --- a/lib/hem/setup.rb +++ b/lib/hem/setup.rb @@ -7,6 +7,7 @@ require_relative 'version' require_relative 'plugins' -$:.push File.expand_path(File.join("..", ".."), __FILE__) +gem 'hem', Hem::VERSION unless ENV['HEM_OMNIBUS'] + require '...
Enforce Hem's spec constraints on hem in gem mode This is so that it requiring it's dependencies respects its own constraints on them
diff --git a/app/controllers/admin/users_controller.rb b/app/controllers/admin/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/users_controller.rb +++ b/app/controllers/admin/users_controller.rb @@ -1,23 +1,32 @@ # coding: utf-8 class Admin::UsersController < ApplicationController ssl_...
Implement create and update on organization users controller
diff --git a/lib/publify_core/engine.rb b/lib/publify_core/engine.rb index abc1234..def5678 100644 --- a/lib/publify_core/engine.rb +++ b/lib/publify_core/engine.rb @@ -3,6 +3,10 @@ config.generators do |generators| generators.test_framework :rspec, fixture: false generators.fixture_replacement :facto...
Use correct layout for Devise in publify_core
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -3,9 +3,23 @@ # For APIs, you may want to use :null_session instead. protect_from_forge...
Set website locale from Accept-Language header This is a good option because the header is usually set by the user's browser language preferences. Code from http://guides.rubyonrails.org/i18n.html
diff --git a/lib/remix/stash/cluster.rb b/lib/remix/stash/cluster.rb index abc1234..def5678 100644 --- a/lib/remix/stash/cluster.rb +++ b/lib/remix/stash/cluster.rb @@ -2,6 +2,7 @@ require 'digest/md5' class Stash::Cluster + include Socket::Constants @@connections = {} @@ -39,8 +40,18 @@ private + def c...
Add low level socket timeout for reads and writes.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,4 +2,8 @@ # Prevent CSRF attacks by raising an exception. # For APIs, you may want t...
Enable basic authentication to be configured
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,8 +1,10 @@ class ApplicationController < ActionController::Base + protect_from_forgery...
ApplicationController: Replace negative logic with unless.
diff --git a/app/controllers/github_hook_controller.rb b/app/controllers/github_hook_controller.rb index abc1234..def5678 100644 --- a/app/controllers/github_hook_controller.rb +++ b/app/controllers/github_hook_controller.rb @@ -17,7 +17,7 @@ raise TypeError, "Repository for project '#{identifier}' is not a Git rep...
Use rebase to bring in changes from the remote repository to avoid merge-commit-messages in your Redmine changesets
diff --git a/ts_assets.gemspec b/ts_assets.gemspec index abc1234..def5678 100644 --- a/ts_assets.gemspec +++ b/ts_assets.gemspec @@ -15,7 +15,7 @@ spec.license = "Apache-2.0" spec.files = `git ls-files -z`.split("\x0").reject do |f| - f.match(%r{^(test|spec|features)/}) + f.match(%r{^(test|sp...
Reduce gem package size by ignoring `__tests__` directory
diff --git a/app/helpers/case_workers/travel_helper.rb b/app/helpers/case_workers/travel_helper.rb index abc1234..def5678 100644 --- a/app/helpers/case_workers/travel_helper.rb +++ b/app/helpers/case_workers/travel_helper.rb @@ -6,9 +6,13 @@ origin = options.delete(:origin) destination = options.delete(:destin...
Fix view helper rubocop violations
diff --git a/lib/usesthis/renderable.rb b/lib/usesthis/renderable.rb index abc1234..def5678 100644 --- a/lib/usesthis/renderable.rb +++ b/lib/usesthis/renderable.rb @@ -7,7 +7,7 @@ def render(params = {}, body = '') params['site'] ||= Site.instance - output = Erubis::Eruby.new(@contents).result(pa...
Switch to evaluate(), so we can use instance variables.
diff --git a/Segundo.podspec b/Segundo.podspec index abc1234..def5678 100644 --- a/Segundo.podspec +++ b/Segundo.podspec @@ -18,7 +18,7 @@ s.dependency 'castaway' s.dependency 'KVOController' s.dependency 'ObjectiveMixin' - s.dependency 'PromiseKit/CorePromise', '~> 2.0' + s.dependency 'PromiseKit/CorePromise...
Remove promisekit version dependency while PK is in flux with versioning
diff --git a/app/models/request.rb b/app/models/request.rb index abc1234..def5678 100644 --- a/app/models/request.rb +++ b/app/models/request.rb @@ -25,7 +25,10 @@ end def is_party_to?(user) - [requester.id, responder.id].include?(user.id) + requester_id = requester.id + responder_id = has_neighbor? ? r...
Fix bug in the is_party_to method. This method would have thrown an error if the request had no neighbors. This (mis)behavior has been fixed.
diff --git a/spec/controllers/miq_report_controller/dashboards_spec.rb b/spec/controllers/miq_report_controller/dashboards_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/miq_report_controller/dashboards_spec.rb +++ b/spec/controllers/miq_report_controller/dashboards_spec.rb @@ -1,6 +1,6 @@ describe Report...
Remove :each in dashboard specs as it's default value
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -32,17 +32,3 @@ "includes" => [ "${shared.config.dir}/WicketSampleApp.xml" ] } -default[:wlp][:servers][:Test1] = { - "enabled" => true, - "servername" => "Test1", -...
Remove attribute for Test1 as its nolonger required with the latest application_wlp code
diff --git a/attributes/scripts.rb b/attributes/scripts.rb index abc1234..def5678 100644 --- a/attributes/scripts.rb +++ b/attributes/scripts.rb @@ -1,2 +1,2 @@ default['et_upload']['api_url'] = 'https://api.evertrue.com' -default['et_upload']['support_email'] = 'jenna@evertrue.com' +default['et_upload']['support_email...
Send support emails to onboarding instead of Jenna
diff --git a/ext/tiny_tds/extconsts.rb b/ext/tiny_tds/extconsts.rb index abc1234..def5678 100644 --- a/ext/tiny_tds/extconsts.rb +++ b/ext/tiny_tds/extconsts.rb @@ -9,6 +9,6 @@ FREETDS_VERSION_INFO = Hash.new { |h,k| h[k] = {files: "ftp://ftp.freetds.org/pub/freetds/stable/freetds-#{k}.tar.bz2"} } -FREETDS_VERSION_...
Update FreeTDS v0.99 current version.
diff --git a/lib/validates.rb b/lib/validates.rb index abc1234..def5678 100644 --- a/lib/validates.rb +++ b/lib/validates.rb @@ -1,6 +1,9 @@-[:email, :association_length, :inn, :money, :slug, :url].each do |name| - autoload :"#{name.classify}Validator", "#{name}_validator" -end +autoload :InnValidator, "inn_validator"...
Fix adding AssociationLength to autoload
diff --git a/lunartic.gemspec b/lunartic.gemspec index abc1234..def5678 100644 --- a/lunartic.gemspec +++ b/lunartic.gemspec @@ -19,4 +19,5 @@ gem.require_paths = ['lib'] gem.add_development_dependency 'rspec', '~> 3.0.0' + gem.add_development_dependency 'rake' end
Add rake as a dependency
diff --git a/test/controllers/coronavirus_local_restrictions_controller_test.rb b/test/controllers/coronavirus_local_restrictions_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/coronavirus_local_restrictions_controller_test.rb +++ b/test/controllers/coronavirus_local_restrictions_controller_tes...
Add a controller test for displaying the lookup Co-authored-by: Leena Gupte <95ff60c7d7e33c5bbd817e4643a0ea35251cc1c8@digital.cabinet-office.gov.uk>
diff --git a/matchete.gemspec b/matchete.gemspec index abc1234..def5678 100644 --- a/matchete.gemspec +++ b/matchete.gemspec @@ -3,7 +3,7 @@ Gem::Specification.new do |s| s.name = 'matchete' - s.version = '0.0.1' + s.version = '0.2.0' s.platform = Gem::Platform::RUBY s.authors = ["Ale...
Change gemspec for new version
diff --git a/src/backprints/pageno.rb b/src/backprints/pageno.rb index abc1234..def5678 100644 --- a/src/backprints/pageno.rb +++ b/src/backprints/pageno.rb @@ -15,8 +15,8 @@ raise "sett() was not called" unless not @text.nil? fs_mm = @h_mm / 1.8 w_mm = ( @text.length + 4 ) * FONT_WH_RATIO * fs_mm -...
Make page numbers rounded and awesome.
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -25,5 +25,5 @@ # Deploy-specific configuration activate :gh_pages do |gh_pages| - gh_pages.remote = 'https://github.com/partialconf/partialconf.github.io' + gh_pages.remote = 'https://github.com/partialconf/2017.par...
Deploy with the new origin
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -1 +1,18 @@-run Rack::Directory.new('.')+require 'sprockets' +environment = Sprockets::Environment.new +environment.append_path('javascripts') +environment.append_path('stylesheets') +environment.append_path('images') +m...
Add serving of assets and index
diff --git a/tinkey.rb b/tinkey.rb index abc1234..def5678 100644 --- a/tinkey.rb +++ b/tinkey.rb @@ -6,8 +6,8 @@ class Tinkey < Formula desc "A command line tool to generate and manipulate keysets for the Tink cryptography library" homepage "https://github.com/google/tink/tree/master/tools/tinkey" - url "https:/...
Update Tinkey URL and SHA-256 hash for Tink 1.7.0. PiperOrigin-RevId: 467283778
diff --git a/spec/recipes/centos/default_spec.rb b/spec/recipes/centos/default_spec.rb index abc1234..def5678 100644 --- a/spec/recipes/centos/default_spec.rb +++ b/spec/recipes/centos/default_spec.rb @@ -7,7 +7,7 @@ end let(:expected_packages) do - %w( libtool autoconf unzip rsync make gcc gcc-c++ xz-lzma-co...
Fix to the spec -- no longer expect gcc-c++
diff --git a/plugins/kegbot/kegbot-metrics.rb b/plugins/kegbot/kegbot-metrics.rb index abc1234..def5678 100644 --- a/plugins/kegbot/kegbot-metrics.rb +++ b/plugins/kegbot/kegbot-metrics.rb @@ -0,0 +1,67 @@+#! /usr/bin/env ruby +# +# kegbot-metrics +# +# DESCRIPTION: +# Output kegerator metrics from Kegbot +# +# OUTPU...
Add metrics plugin for kegbot
diff --git a/test/models/user_test.rb b/test/models/user_test.rb index abc1234..def5678 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -1,6 +1,7 @@ # Encoding: utf-8 require 'test_helper' +# Test user model class UserTest < ActiveSupport::TestCase # test "the truth" do # assert true...
Add header to user model test
diff --git a/Casks/firefox-cn.rb b/Casks/firefox-cn.rb index abc1234..def5678 100644 --- a/Casks/firefox-cn.rb +++ b/Casks/firefox-cn.rb @@ -1,6 +1,6 @@ cask :v1 => 'firefox-cn' do - version '41.0.2' - sha256 '0d763d1d7841396a5c3e8d29d7ec8b387e7a8f942b32002d427e236ab8d9e676' + version '42.0' + sha256 'ccd21fd90e1f6...
Update Firefox CN to version 42.0
diff --git a/Casks/opera-beta.rb b/Casks/opera-beta.rb index abc1234..def5678 100644 --- a/Casks/opera-beta.rb +++ b/Casks/opera-beta.rb @@ -1,6 +1,6 @@ cask :v1 => 'opera-beta' do - version '27.0.1689.44' - sha256 'a07580830e9b772ef6644d34c84b260fb17ea592f50b6d4a36fa3ffa6bdc4b0b' + version '28.0.1750.36' + sha256 ...
Upgrade Opera Beta.app to 28.0.1750.36
diff --git a/recipes/package.rb b/recipes/package.rb index abc1234..def5678 100644 --- a/recipes/package.rb +++ b/recipes/package.rb @@ -31,7 +31,7 @@ resolvconf "custom" do nameserver "127.0.0.1" - search node["pdns"]["server"]["searchdomains"] + search node["pdns"]["authoritative"]["searchdomains"] head ...
Use the pdns/authoritative attribute namespace
diff --git a/puppet/lib/puppet/util/puppetdb/blacklist.rb b/puppet/lib/puppet/util/puppetdb/blacklist.rb index abc1234..def5678 100644 --- a/puppet/lib/puppet/util/puppetdb/blacklist.rb +++ b/puppet/lib/puppet/util/puppetdb/blacklist.rb @@ -16,7 +16,7 @@ BlacklistedEvent.new("Schedule", "monthly", "skipped", n...
Change from reduce to inject for ruby 1.8.5 compat
diff --git a/colossus.gemspec b/colossus.gemspec index abc1234..def5678 100644 --- a/colossus.gemspec +++ b/colossus.gemspec @@ -5,6 +5,7 @@ Gem::Specification.new do |s| s.name = "colossus" + s.license = "MIT" s.version = Colossus::VERSION s.authors = ["antoinelyset"] s.email ...
Add a License to gemspec
diff --git a/app/controllers/mail_conversations_controller.rb b/app/controllers/mail_conversations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/mail_conversations_controller.rb +++ b/app/controllers/mail_conversations_controller.rb @@ -2,6 +2,15 @@ def index @mailbox_conversations = curren...
Create inbox,outbox, and trashcan routes.
diff --git a/rugged_adapter.gemspec b/rugged_adapter.gemspec index abc1234..def5678 100644 --- a/rugged_adapter.gemspec +++ b/rugged_adapter.gemspec @@ -13,7 +13,7 @@ s.description = %q{Adapter for Gollum to use Rugged (libgit2) at the backend.} s.license = "MIT" - s.add_runtime_dependency 'rugged', '~> 0.21', ...
Make rugged dependency more strict.
diff --git a/popularity_contest.gemspec b/popularity_contest.gemspec index abc1234..def5678 100644 --- a/popularity_contest.gemspec +++ b/popularity_contest.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |spec| spec.name = "popularity_contest" - spec.version = "0.0.5" + spec.version = "0....
Bump gem version to 0.0.7
diff --git a/bashcov.gemspec b/bashcov.gemspec index abc1234..def5678 100644 --- a/bashcov.gemspec +++ b/bashcov.gemspec @@ -18,7 +18,7 @@ gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] - gem.add_dependency 'simplecov' + gem.add_dependency 'simplecov', '~> 0.7.1' ...
Set required version of SimpleCov
diff --git a/Casks/keepassx0.rb b/Casks/keepassx0.rb index abc1234..def5678 100644 --- a/Casks/keepassx0.rb +++ b/Casks/keepassx0.rb @@ -2,8 +2,9 @@ version '0.4.3' sha256 '15ce2e950ab78ccb6956de985c1fcbf11d27df6a58ab7bf19e106f0a1dc2fedd' - url "http://downloads.sourceforge.net/keepassx/KeePassX-#{version}.dmg"...
KeePassX: Add name and update URL & homepage
diff --git a/test/ignore_test.rb b/test/ignore_test.rb index abc1234..def5678 100644 --- a/test/ignore_test.rb +++ b/test/ignore_test.rb @@ -20,8 +20,8 @@ test "ignore in package" do get '/main.js' - assert body.size > 0 - assert !body.include?("BUMBLEBEE") + assert last_response.body.size > 0 + as...
Fix test for jruby support
diff --git a/Fingertips.podspec b/Fingertips.podspec index abc1234..def5678 100644 --- a/Fingertips.podspec +++ b/Fingertips.podspec @@ -5,7 +5,7 @@ f.summary = 'Touch indicators on external displays for iOS applications.' f.description = 'A UIWindow subclass that gives you automatic presentation mode in you...
Change homepage to https instead of http
diff --git a/Formula/kdelibs.rb b/Formula/kdelibs.rb index abc1234..def5678 100644 --- a/Formula/kdelibs.rb +++ b/Formula/kdelibs.rb @@ -25,4 +25,17 @@ system "cmake .. #{std_cmake_parameters} -DCMAKE_PREFIX_PATH=#{gettext.prefix} -DBUNDLE_INSTALL_DIR=#{bin}" system "make install" end + + def caveats + ...
Add KDELibs caveat so people don't expect it to fully work yet.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -6,8 +6,7 @@ faceting_for :nobelists, :citizens # NB must be BEFORE any resources! match ':controller(/:action(/:id(.:format)))' - - match "/", :to => redirec...
Tweak to make root route work in presence of a prefix path.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,7 +1,13 @@ ActionController::Routing::Routes.draw do |map| - map.connect 'everything/graph',:controller=>'account',:action=>'graph',:account=>'everything' - map.connect 'everything/report...
Add category paths to routing
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -5,7 +5,7 @@ # login (sessions) routes with named helpers get '/login' => 'sessions#new', as: 'login_form' post '/login' => 'sessions#create', as: 'login' - destroy '/logout' => 'sess...
Change incorrect route mapper from 'destroy' to 'delete.'
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,11 +1,11 @@ ENV["RAILS_ENV"] = "test" require File.expand_path("../dummy/config/environment.rb", __FILE__) +require "codeclimate-test-reporter" +CodeClimate::TestReporter.st...
Test reporter must be added before, to correctly send test coverage
diff --git a/paperclip-deflater.gemspec b/paperclip-deflater.gemspec index abc1234..def5678 100644 --- a/paperclip-deflater.gemspec +++ b/paperclip-deflater.gemspec @@ -10,6 +10,7 @@ gem.summary = "Deflate Processor for Paperclip" gem.description = "Deflate Processor for Paperclip" gem.license = "MIT" +...
Add minimum ruby version in gemspec
diff --git a/app/models/situation.rb b/app/models/situation.rb index abc1234..def5678 100644 --- a/app/models/situation.rb +++ b/app/models/situation.rb @@ -1,4 +1,22 @@+# class ChoicesSetUnlessEnding < ActiveModel::Validator +#   def validate(record) +#     unless record.name.starts_with? 'X' +#       record.errors[:n...
Validate presence of choices unless ending.
diff --git a/core/app/models/spree/product_property.rb b/core/app/models/spree/product_property.rb index abc1234..def5678 100644 --- a/core/app/models/spree/product_property.rb +++ b/core/app/models/spree/product_property.rb @@ -19,9 +19,7 @@ def property_name=(name) if name.present? # don't use `fi...
Refactor creation of property by using first_or_create instead of condition based creation
diff --git a/Casks/google-japanese-ime-dev.rb b/Casks/google-japanese-ime-dev.rb index abc1234..def5678 100644 --- a/Casks/google-japanese-ime-dev.rb +++ b/Casks/google-japanese-ime-dev.rb @@ -1,6 +1,6 @@ cask :v1 => 'google-japanese-ime-dev' do - version 'dev' - sha256 'd3f786d3462e0294f29bc1f8998163489f812a1ae65066...
Fix checksum in Google Japanese IME Dev build
diff --git a/pgbundle.gemspec b/pgbundle.gemspec index abc1234..def5678 100644 --- a/pgbundle.gemspec +++ b/pgbundle.gemspec @@ -26,5 +26,5 @@ spec.add_dependency 'pg', '> 0.17' spec.add_development_dependency 'rspec', '~> 2.14.0' spec.add_development_dependency "bundler", ">= 1.5.0" - spec.add_development_dep...
Set rake version to lower than 11.0 This is due to incompatibility of a newer rack with rspec
diff --git a/spec/actions_specs/clean_cocoapods_cache_spec.rb b/spec/actions_specs/clean_cocoapods_cache_spec.rb index abc1234..def5678 100644 --- a/spec/actions_specs/clean_cocoapods_cache_spec.rb +++ b/spec/actions_specs/clean_cocoapods_cache_spec.rb @@ -0,0 +1,33 @@+describe Fastlane do + describe Fastlane::FastFil...
Add unit tests for clean_cocoapods_cache action.
diff --git a/spec/correios_sigep/builders/xml/request_spec.rb b/spec/correios_sigep/builders/xml/request_spec.rb index abc1234..def5678 100644 --- a/spec/correios_sigep/builders/xml/request_spec.rb +++ b/spec/correios_sigep/builders/xml/request_spec.rb @@ -0,0 +1,46 @@+require 'spec_helper' +require 'pry' + +module Cor...
Create the test when receive an override parameter
diff --git a/spec/helpers/specialist_documents_helper_spec.rb b/spec/helpers/specialist_documents_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/specialist_documents_helper_spec.rb +++ b/spec/helpers/specialist_documents_helper_spec.rb @@ -4,7 +4,7 @@ describe '#nice_date_format' do before :al...
Remove variable time in tests
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -17,7 +17,7 @@ database: ":memory:" ) -unless ActiveRecord::Base.connection.tables.include? "dogs" +unless ActiveRecord::Base.connection.data_sources.include? "dogs" Active...
Use data_sources instead of tables Fixes deprecation warning
diff --git a/app/tasks/fetch_feed.rb b/app/tasks/fetch_feed.rb index abc1234..def5678 100644 --- a/app/tasks/fetch_feed.rb +++ b/app/tasks/fetch_feed.rb @@ -23,8 +23,9 @@ end FeedRepository.update_last_fetched(@feed, raw_feed.last_modified) - FeedRepository.set_status(:green, @feed) end...
Set feed status to green when parsing feeds returns 304
diff --git a/lib/troo/api/request.rb b/lib/troo/api/request.rb index abc1234..def5678 100644 --- a/lib/troo/api/request.rb +++ b/lib/troo/api/request.rb @@ -2,16 +2,8 @@ module API class Request class << self - def get(urn, query = {}) - new(:get, urn, query).response - end - - ...
Remove .get, .put, .post methods in favour of .make.
diff --git a/spec/bundler/installer/gem_installer_spec.rb b/spec/bundler/installer/gem_installer_spec.rb index abc1234..def5678 100644 --- a/spec/bundler/installer/gem_installer_spec.rb +++ b/spec/bundler/installer/gem_installer_spec.rb @@ -0,0 +1,27 @@+# frozen_string_literal: true +require "spec_helper" +require "bun...
Add unit test for previous commit
diff --git a/app/decorators/manageiq/providers/ansible_tower/automation_manager/job_decorator.rb b/app/decorators/manageiq/providers/ansible_tower/automation_manager/job_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/manageiq/providers/ansible_tower/automation_manager/job_decorator.rb +++ b/app/decorat...
Add single_quad definition for ansible tower jobs
diff --git a/bin/cab_locator_test.rb b/bin/cab_locator_test.rb index abc1234..def5678 100644 --- a/bin/cab_locator_test.rb +++ b/bin/cab_locator_test.rb @@ -16,7 +16,7 @@ page = mech.get("#{domain}/locations") -if page.body =~ /Find a face-to-face appointment location/ +if page.body =~ /Find an appointment location...
Update tests with new location header
diff --git a/db/migrate/20170413112512_fix_change_note_data_for_the_highway_code.rb b/db/migrate/20170413112512_fix_change_note_data_for_the_highway_code.rb index abc1234..def5678 100644 --- a/db/migrate/20170413112512_fix_change_note_data_for_the_highway_code.rb +++ b/db/migrate/20170413112512_fix_change_note_data_for...
Add migration to fix Highway Code change note data This is the first part of the fix for the problem described in issue #861. There are unexpected updates listed for The Highway Code[1] against 1 March 2017. We expect to see "Annex 5 Penalties" with a single change described as "Updated the penalty table to increas...
diff --git a/spec/balance_tags_c_extn_spec.rb b/spec/balance_tags_c_extn_spec.rb index abc1234..def5678 100644 --- a/spec/balance_tags_c_extn_spec.rb +++ b/spec/balance_tags_c_extn_spec.rb @@ -1,4 +1,5 @@-require "spec_helper" +$:.unshift File.dirname(__FILE__) # required, for some reason. +require 'spec_helper' $:....
Add to so that require'ing spec_helper works
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -21,6 +21,8 @@ # specified here. config.sequel.after_connect = proc do + Sequel::Model.db.extension :connection_validator + Sequel::Model.db.pool.conne...
Use connection validation for pooled connections This will address issues seen in production with RDS closing connections to the database after a time (reasonably) and the local application not correctly restoring them before use.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -19,5 +19,8 @@ # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded. # config.i18n.load_path += Dir[Rails.root.join('my', ...
Enable iframe support on Heroku rails
diff --git a/spec/support/database_cleaner.rb b/spec/support/database_cleaner.rb index abc1234..def5678 100644 --- a/spec/support/database_cleaner.rb +++ b/spec/support/database_cleaner.rb @@ -1,16 +1,6 @@ RSpec.configure do |config| - config.before(:suite) do + config.before(:each) do DatabaseCleaner.clean_with...
Fix the Travis failures in rspec
diff --git a/test/apps/zoo/_init.rb b/test/apps/zoo/_init.rb index abc1234..def5678 100644 --- a/test/apps/zoo/_init.rb +++ b/test/apps/zoo/_init.rb @@ -1,7 +1,6 @@ module Zoo @description = "" @version = 0.1 - @path = File.dirname(__FILE__) include Spider::App def self.test_setup @@ -14,7 ...
Use test storage for Zoo models
diff --git a/lib/cb/utils/validator.rb b/lib/cb/utils/validator.rb index abc1234..def5678 100644 --- a/lib/cb/utils/validator.rb +++ b/lib/cb/utils/validator.rb @@ -1,52 +1,55 @@ require 'json' -require 'xmlsimple' +require 'nori' module Cb module ResponseValidator + + class << self + def validate(res...
Remove Nokogiri usage from validated response
diff --git a/lib/usaidwat/service.rb b/lib/usaidwat/service.rb index abc1234..def5678 100644 --- a/lib/usaidwat/service.rb +++ b/lib/usaidwat/service.rb @@ -4,16 +4,17 @@ module Service class RedditService def user(username) - data = {} - %w{about comments submitted}.each do |page| - ...
Simplify hash-building code using reduce
diff --git a/lib/spot.rb b/lib/spot.rb index abc1234..def5678 100644 --- a/lib/spot.rb +++ b/lib/spot.rb @@ -1,4 +1,4 @@-require 'pry' +# require 'pry' class Spot attr_reader :possible
Comment out pry, for now...
diff --git a/lib/gitlab/ldap/person.rb b/lib/gitlab/ldap/person.rb index abc1234..def5678 100644 --- a/lib/gitlab/ldap/person.rb +++ b/lib/gitlab/ldap/person.rb @@ -1,7 +1,7 @@ module Gitlab module LDAP class Person - AD_USER_DISABLED = Net::LDAP::Filter.ex("userAccountControl:1.2.840.113556.1.4.803", 2) +...
Fix syntax error in AD disabled user filter
diff --git a/lib/hiraoyogi/database.rb b/lib/hiraoyogi/database.rb index abc1234..def5678 100644 --- a/lib/hiraoyogi/database.rb +++ b/lib/hiraoyogi/database.rb @@ -16,7 +16,7 @@ private def body_text(doc) - doc.css("body").text.gsub(/\s/, "") + doc.css("body").text.gsub(/\n|\t/, "") end en...
Remove \n and \t only instead of all whitespace characters
diff --git a/db/migrate/20160610190445_add_search_to_service_version.rb b/db/migrate/20160610190445_add_search_to_service_version.rb index abc1234..def5678 100644 --- a/db/migrate/20160610190445_add_search_to_service_version.rb +++ b/db/migrate/20160610190445_add_search_to_service_version.rb @@ -2,7 +2,7 @@ def up ...
Make migration add_search_to_service_version a bit more resilient On production the extension might have been pre-installed, so we only install it if it doesn't exist
diff --git a/lib/capybara_screenshot_idobata/dsl.rb b/lib/capybara_screenshot_idobata/dsl.rb index abc1234..def5678 100644 --- a/lib/capybara_screenshot_idobata/dsl.rb +++ b/lib/capybara_screenshot_idobata/dsl.rb @@ -8,7 +8,7 @@ options = detect_default_option(Capybara.current_driver).merge(options) - sa...
Fix screenshot path using return value of `save_screenshot` Since this commit (https://github.com/jnicklas/capybara/commit/75084c59), `Capybara::Session#save_screenshot` depends on `Capybara.save_path` when filename is a relative path. Before: `Pathname(Dir.pwd).join(filename)` After: `Pathname(Capybara.save_path).j...
diff --git a/lib/pairwise/test_pair.rb b/lib/pairwise/test_pair.rb index abc1234..def5678 100644 --- a/lib/pairwise/test_pair.rb +++ b/lib/pairwise/test_pair.rb @@ -1,25 +1,23 @@-#TODO: Array gives us too much extract specific behaviour required +require 'forwardable' + module Pairwise - class TestPair < Array - a...
Replace array subclass with forwardable for just the methods we want
diff --git a/lib/prospector/railtie.rb b/lib/prospector/railtie.rb index abc1234..def5678 100644 --- a/lib/prospector/railtie.rb +++ b/lib/prospector/railtie.rb @@ -3,5 +3,9 @@ config.after_initialize do Background.enqueue unless Object.const_defined?('Rake') end + + rake_tasks do + require File...
Include rake tasks automatically in Rails
diff --git a/spec/space2dot_spec.rb b/spec/space2dot_spec.rb index abc1234..def5678 100644 --- a/spec/space2dot_spec.rb +++ b/spec/space2dot_spec.rb @@ -5,4 +5,9 @@ expect(Space2dot.convert(['fuga hoge foo'])).to include('.') # String case expect(Space2dot.convert(%w(fuga hoge foo))).to include('.') # Array ca...
Modify config for use in tmuxinator
diff --git a/lib/guard/notifiers/git_auto_commit.rb b/lib/guard/notifiers/git_auto_commit.rb index abc1234..def5678 100644 --- a/lib/guard/notifiers/git_auto_commit.rb +++ b/lib/guard/notifiers/git_auto_commit.rb @@ -29,8 +29,8 @@ def notify(type, title, message, image, options = { }) commit_message = [t...
Create commit message diff after staging changes
diff --git a/lib/konacha-chai-matchers/collector.rb b/lib/konacha-chai-matchers/collector.rb index abc1234..def5678 100644 --- a/lib/konacha-chai-matchers/collector.rb +++ b/lib/konacha-chai-matchers/collector.rb @@ -30,10 +30,14 @@ @libs ||= urls.each_with_index.map do |url, i| name = paths[i] ...
Add output for versions to use
diff --git a/lib/omniauth/strategies/remote_user.rb b/lib/omniauth/strategies/remote_user.rb index abc1234..def5678 100644 --- a/lib/omniauth/strategies/remote_user.rb +++ b/lib/omniauth/strategies/remote_user.rb @@ -12,6 +12,7 @@ end def request_phase + @user_data = {} @uid = validate_re...
Initialize @user_data like a hash
diff --git a/lib/spree_i18n/railtie.rb b/lib/spree_i18n/railtie.rb index abc1234..def5678 100644 --- a/lib/spree_i18n/railtie.rb +++ b/lib/spree_i18n/railtie.rb @@ -5,7 +5,7 @@ pattern = pattern_from app.config.i18n.available_locales add("config/locales/#{pattern}/*.{rb,yml}") - add("config/lo...
Change to load necessary locale files
diff --git a/lib/tasks/refresh_wysiwyg_content.rake b/lib/tasks/refresh_wysiwyg_content.rake index abc1234..def5678 100644 --- a/lib/tasks/refresh_wysiwyg_content.rake +++ b/lib/tasks/refresh_wysiwyg_content.rake @@ -31,9 +31,13 @@ ) end + template = File.read('lib/assets/privacy_policy_page.json') ...
Fix privacy policy page for new sites
diff --git a/lib/tasks/curriculum.rake b/lib/tasks/curriculum.rake index abc1234..def5678 100644 --- a/lib/tasks/curriculum.rake +++ b/lib/tasks/curriculum.rake @@ -8,14 +8,12 @@ namespace :content do desc 'Import all lessons content from GitHub' task import: :environment do - Rails.logger.info 'Import...
Chore: Add Progress Bar to Curriculum Import Task Because: * It provides a nicer visual representation of the import progress.
diff --git a/lib/tasks/javascript.rake b/lib/tasks/javascript.rake index abc1234..def5678 100644 --- a/lib/tasks/javascript.rake +++ b/lib/tasks/javascript.rake @@ -14,4 +14,16 @@ system "yarn test" end end + + if ENV["REMOVE_JS_BUILD_YARN_INSTALL"] == "true" + Rake::Task["javascript:build"].clear + +...
Add option to remove yarn install from the JavaScript build task. When deploying with a Node.js buildpack, the dependencies will already be installed making this call redundant. The ability to remove it will speed up deployments.
diff --git a/lib/tasks/submodules.rake b/lib/tasks/submodules.rake index abc1234..def5678 100644 --- a/lib/tasks/submodules.rake +++ b/lib/tasks/submodules.rake @@ -7,17 +7,17 @@ sha, repo, branch = commit_info.split(' ') case sha[0,1] when '+' - $stderr.puts "Warning: Currently che...
Call it an error, not a warning.
diff --git a/lib/time_for_a_boolean.rb b/lib/time_for_a_boolean.rb index abc1234..def5678 100644 --- a/lib/time_for_a_boolean.rb +++ b/lib/time_for_a_boolean.rb @@ -5,15 +5,15 @@ require "time_for_a_boolean/railtie" module TimeForABoolean - def time_for_a_boolean(attribute, field="#{attribute}_at") + def time_for_...
Use attribute = true instead of duplicating that
diff --git a/test/rb/core/test_backwards_compatability.rb b/test/rb/core/test_backwards_compatability.rb index abc1234..def5678 100644 --- a/test/rb/core/test_backwards_compatability.rb +++ b/test/rb/core/test_backwards_compatability.rb @@ -5,28 +5,8 @@ class TestTException < Test::Unit::TestCase def test_has_access...
Remove test_remappings because it isn't comprehensive and it's triggering undesired warnings. This should be re-created as a spec. git-svn-id: 8d8e29b1fb681c884914062b88f3633e3a187774@668936 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/windowstate.gemspec b/windowstate.gemspec index abc1234..def5678 100644 --- a/windowstate.gemspec +++ b/windowstate.gemspec @@ -21,5 +21,6 @@ ] s.add_dependency "windows-pr", "~> 1.2" + s.add_dependency "trollop", "~> 1" s.add_development_dependency "ocra", "~> 1.3" end
Fix trollop dependency in gemspec
diff --git a/repo.rb b/repo.rb index abc1234..def5678 100644 --- a/repo.rb +++ b/repo.rb @@ -15,6 +15,15 @@ end end -100_000.times do |i| +str = [] + +1000.times do + str << Array.new(10_000, "a").map { |i| "b" }.join * 10 + str.pop +end + +5000.times do |i| + str << Array.new(10_000, "a").map { |i| "b" }.join ...
Add more work to increase the chance of triggering GC
diff --git a/rack-zip.gemspec b/rack-zip.gemspec index abc1234..def5678 100644 --- a/rack-zip.gemspec +++ b/rack-zip.gemspec @@ -9,4 +9,7 @@ spec.add_runtime_dependency 'rack' spec.add_runtime_dependency 'zipruby' + + spec.add_development_dependency 'test-unit' + spec.add_development_dependency 'test-unit-noti...
Add testing frameworks to dependencies
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -9,8 +9,6 @@ get "/:email/:order_numbers" do content_type "application/json" - response["Access-Control-Allow-Origin"] = "*" - { orders: orders }.to_json end
Remove ACAO; we are accessing from the same server
diff --git a/sample/lib/spree_sample.rb b/sample/lib/spree_sample.rb index abc1234..def5678 100644 --- a/sample/lib/spree_sample.rb +++ b/sample/lib/spree_sample.rb @@ -24,7 +24,6 @@ Spree::Sample.load_sample("assets") Spree::Sample.load_sample("orders") - Spree::Sample.load_sample("line_items") ...
[sample] Remove line items loading, as that's now done with the order creation
diff --git a/Casks/keyspan-usa-19hs.rb b/Casks/keyspan-usa-19hs.rb index abc1234..def5678 100644 --- a/Casks/keyspan-usa-19hs.rb +++ b/Casks/keyspan-usa-19hs.rb @@ -0,0 +1,18 @@+cask 'keyspan-usa-19hs' do + version '4' + sha256 '9a07a07d10c3cee5ea1cf3e67b091c30b26a7e24959602b258ae8060a7bf6ce3' + + url "http://www.tr...
Add Keyspan USA-19HS v4 Drivers
diff --git a/test/extra/checking/checks/test_html.rb b/test/extra/checking/checks/test_html.rb index abc1234..def5678 100644 --- a/test/extra/checking/checks/test_html.rb +++ b/test/extra/checking/checks/test_html.rb @@ -6,7 +6,7 @@ with_site do |site| # Create files FileUtils.mkdir_p('output') - ...
Add necessary charset to HTML check test