diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/active_interaction/integration/model_interaction_spec.rb b/spec/active_interaction/integration/model_interaction_spec.rb index abc1234..def5678 100644 --- a/spec/active_interaction/integration/model_interaction_spec.rb +++ b/spec/active_interaction/integration/model_interaction_spec.rb @@ -3,5 +3,5 @@...
Fix Model filter integration test I'm not sure why it was broken with ActiveModel ~> 3.0. This fixes it, though.
diff --git a/spec/integration/veritas/self_referential/one_to_many_spec.rb b/spec/integration/veritas/self_referential/one_to_many_spec.rb index abc1234..def5678 100644 --- a/spec/integration/veritas/self_referential/one_to_many_spec.rb +++ b/spec/integration/veritas/self_referential/one_to_many_spec.rb @@ -0,0 +1,30 @...
Add self referential 1:N veritas integration specs
diff --git a/gem_template.gemspec b/gem_template.gemspec index abc1234..def5678 100644 --- a/gem_template.gemspec +++ b/gem_template.gemspec @@ -18,4 +18,6 @@ s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } ...
Add rake to the bundle
diff --git a/SwiftCBOR.podspec b/SwiftCBOR.podspec index abc1234..def5678 100644 --- a/SwiftCBOR.podspec +++ b/SwiftCBOR.podspec @@ -11,7 +11,7 @@ s.ios.deployment_target = '8.0' s.osx.deployment_target = '10.9' - s.source_files = 'Sources/SwiftCBOR/*.{swift,h}' + s.source_files = 'Sources/SwiftCBOR/**/*.{swif...
Make sure all source files are included in cocoapod
diff --git a/lib/import_products/user_mailer_ext.rb b/lib/import_products/user_mailer_ext.rb index abc1234..def5678 100644 --- a/lib/import_products/user_mailer_ext.rb +++ b/lib/import_products/user_mailer_ext.rb @@ -5,7 +5,7 @@ def product_import_results(user, error_message = nil) @user = user ...
Update mailer to use attachments[] instead of attachment[]
diff --git a/lib/noosfero/core_ext/action_mailer.rb b/lib/noosfero/core_ext/action_mailer.rb index abc1234..def5678 100644 --- a/lib/noosfero/core_ext/action_mailer.rb +++ b/lib/noosfero/core_ext/action_mailer.rb @@ -8,14 +8,4 @@ super end - def premailer_html html - premailer = Premailer.new html.to_s, :w...
Remove premailer adjust on core
diff --git a/pdfjs.gemspec b/pdfjs.gemspec index abc1234..def5678 100644 --- a/pdfjs.gemspec +++ b/pdfjs.gemspec @@ -9,7 +9,7 @@ s.version = Pdfjs::VERSION s.authors = ["Leigh Caplan"] s.email = ["lcaplan@onehub.com"] - s.homepage = "github.com/onehub/pdfjs" + s.homepage = "https://github....
Make the homepage a real URL.
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -6,6 +6,7 @@ # Publishing paths http_path = "/" http_images_path = "/images" +http_generated_images_path = "/images" http_fonts_path = "/fonts" css_dir = "public/stylesheets"
Fix http generated images path when using Compass sprites Otherwise compass uses '/source/images' for the sprite image URL
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -1,8 +1,6 @@ require "rubygems" require 'rack/contrib' require 'rack-rewrite' -DOMAIN = 'www.ruby-pt.org' - use Rack::Static, :urls => ["/css", "/img"], @@ -10,8 +8,5 @@ use Rack::ETag use Rack::Rewrite do ...
Revert "Added rule to redirect naked domain to www" This reverts commit ae00b3e3d40408cac71e3e0a13dcf717a2ef2345.
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -18,6 +18,4 @@ end end -c = Scrum::Bot.instance.send :client - run Scrum::Web
Remove silly client get line
diff --git a/app/helpers/tabs_helper.rb b/app/helpers/tabs_helper.rb index abc1234..def5678 100644 --- a/app/helpers/tabs_helper.rb +++ b/app/helpers/tabs_helper.rb @@ -1,7 +1,7 @@ module TabsHelper def tab_link_to(model_or_name, link, current=nil) - model_or_name = model_or_name.model_name.human.capitalize.plu...
Use yml for plural model name
diff --git a/app/models/saved_search.rb b/app/models/saved_search.rb index abc1234..def5678 100644 --- a/app/models/saved_search.rb +++ b/app/models/saved_search.rb @@ -20,7 +20,11 @@ query_parameters.delete(:redirect_controller) query_parameters.delete(:redirect_action) query_parameters.delete(:saved_sea...
Make the searches perform a like
diff --git a/tools/build_readme.rb b/tools/build_readme.rb index abc1234..def5678 100644 --- a/tools/build_readme.rb +++ b/tools/build_readme.rb @@ -1,13 +1,13 @@ #!/usr/bin/env ruby template = $stdin.read -examples = template.scan(/include_example (.*)/).flatten +examples = template.scan(/include_example '(.*)'/).f...
Define included examples as strings
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -1,5 +1,9 @@ p4_exe = node[:os] == 'windows' ? 'p4.exe' : 'p4' p4d_exe = node[:os] == 'windows' ? 'p4d.exe' : 'p4d' + +directory node['perforce']['bin_dir'] do + recursive true +end ...
Create the perforce bin_dif if it does not exist
diff --git a/spec/server_spec.rb b/spec/server_spec.rb index abc1234..def5678 100644 --- a/spec/server_spec.rb +++ b/spec/server_spec.rb @@ -4,7 +4,7 @@ describe 'burp::server' do it 'creates a proper client config in clientconfdir/' do - Chef::Recipe.any_instance.stub(:partial_search).with( + allow_any_inst...
Replace deprecated any_instance in server spec http://stackoverflow.com/a/24595457/1058366
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -13,7 +13,10 @@ require "i18n/backend/advanced" require "yaml" -require "pry" rescue LoadError +begin + require "pry" +rescue LoadError +end RSpec.configure do |config| #...
Handle pry no present on CI
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -10,12 +10,12 @@ # in spec/support/ and its subdirectories. Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f } -ActiveSupport::Notifications.subscribe("sql.acti...
Comment out SQL logging magic for now
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,7 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) require 'sports_database' -require 'byebug' require 'simplecov' -SimpleCov.start +SimpleCov.start do + ad...
Add filter to not look at spec and .gems directories for test coverage.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,6 +3,9 @@ # Configure Rails Environment ENV["RAILS_ENV"] = "test" + +# Configure Rails Environment +ENV["DB"] ||= "mysql" require File.expand_path("../../test/dummy/config...
Set $DB mysql as default
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -10,7 +10,7 @@ MongoMapper.database = 'mm-learnup-sluggable-spec' def article_class - Class.new do + @article_class ||= Class.new do include MongoMapper::Document se...
Use ||= in spec class helpers (so that referencing the class again gives back the same class, not a new one)
diff --git a/lib/cheatly/sheet.rb b/lib/cheatly/sheet.rb index abc1234..def5678 100644 --- a/lib/cheatly/sheet.rb +++ b/lib/cheatly/sheet.rb @@ -31,11 +31,11 @@ def self.find(name) body = adapter.find(name) self.new(name, body, persisted: true) - rescue Octokit::NotFound, Octokit::TooManyRequests -...
Fix Error handling on .find method
diff --git a/lib/dm-types/enum.rb b/lib/dm-types/enum.rb index abc1234..def5678 100644 --- a/lib/dm-types/enum.rb +++ b/lib/dm-types/enum.rb @@ -4,6 +4,7 @@ module DataMapper class Property class Enum < Integer + min 0 include Flags @@ -18,6 +19,8 @@ if self.class.accepted_options.includ...
Change Enum type to use tighter database constraints
diff --git a/lib/gherkin/lexer.rb b/lib/gherkin/lexer.rb index abc1234..def5678 100644 --- a/lib/gherkin/lexer.rb +++ b/lib/gherkin/lexer.rb @@ -14,10 +14,8 @@ else begin c[i18n_lang] - rescue NameError => e + rescue NameError, LoadError => e wa...
Raise warning on LoadError, too
diff --git a/lib/poke/controls.rb b/lib/poke/controls.rb index abc1234..def5678 100644 --- a/lib/poke/controls.rb +++ b/lib/poke/controls.rb @@ -2,8 +2,10 @@ # The +Controls+ controller handles keyboard input from the user. class Controls + # Params required at initialization. PARAMS_REQUIRED = [:window]...
Add docs for Controls constants
diff --git a/lib/popular_items.rb b/lib/popular_items.rb index abc1234..def5678 100644 --- a/lib/popular_items.rb +++ b/lib/popular_items.rb @@ -7,6 +7,24 @@ @items = load(filename) @logger = logger || NullLogger.instance end + + def popular?(section, slug) + @items[section] && @items[section].include?(...
Make implicit helper method for PopularItems private
diff --git a/lib/emcee/railtie.rb b/lib/emcee/railtie.rb index abc1234..def5678 100644 --- a/lib/emcee/railtie.rb +++ b/lib/emcee/railtie.rb @@ -7,7 +7,6 @@ module Emcee class Railtie < Rails::Railtie initializer :add_html_processor do |app| - app.assets.register_mime_type "text/html", ".html" app.a...
Remove unnecessary mime type declaration
diff --git a/lib/git-feats/api.rb b/lib/git-feats/api.rb index abc1234..def5678 100644 --- a/lib/git-feats/api.rb +++ b/lib/git-feats/api.rb @@ -6,7 +6,7 @@ extend self - URL = 'http://localhost:3000' + URL = 'http://gitfeats.com' def upload_feats # Post json to git-feats
Update API module to hit production URL
diff --git a/lib/orc/cmdb/yaml.rb b/lib/orc/cmdb/yaml.rb index abc1234..def5678 100644 --- a/lib/orc/cmdb/yaml.rb +++ b/lib/orc/cmdb/yaml.rb @@ -5,9 +5,6 @@ class Orc::CMDB::Yaml def initialize(args) @data_dir = args[:data_dir] - if !Pathname.new(@data_dir).exist? - Dir.mkdir @data_dir - end end ...
Remove surprise mkdir which means you can't later check out
diff --git a/lib/tasks/utils.rake b/lib/tasks/utils.rake index abc1234..def5678 100644 --- a/lib/tasks/utils.rake +++ b/lib/tasks/utils.rake @@ -1,4 +1,9 @@+require 'html-proofer' + task :find_dead_links do - cmd = 'htmlproofer ./_site --only-4xx --url-ignore "/blog/,/#content/"' - system("bundle exec #{cmd}") + op...
Use gem instead of using cli tool.
diff --git a/providers/connection.rb b/providers/connection.rb index abc1234..def5678 100644 --- a/providers/connection.rb +++ b/providers/connection.rb @@ -19,7 +19,9 @@ end action :delete do - new_resource.updated_by_last_action( - node[:stunnel][:services].delete(new_resource.service_name) - ) + serv_data =...
Update attribute interactions in delete action of lwrp
diff --git a/db/migrate/20150218120000_change_unique_index_on_spree_website_payments_standard_transactions.rb b/db/migrate/20150218120000_change_unique_index_on_spree_website_payments_standard_transactions.rb index abc1234..def5678 100644 --- a/db/migrate/20150218120000_change_unique_index_on_spree_website_payments_sta...
Allow multiple notifications per transaction as long as they have different payment statuses We need this because PayPal seems to send another IPN when an authorization expires.
diff --git a/haproxy_log_parser.gemspec b/haproxy_log_parser.gemspec index abc1234..def5678 100644 --- a/haproxy_log_parser.gemspec +++ b/haproxy_log_parser.gemspec @@ -11,11 +11,6 @@ s.add_development_dependency 'rspec', '~> 3.5.0' - s.files = Dir.glob('lib/**/*') + [ - 'LICENSE', - 'README.md', - 'VER...
Use git ls-files for gemspec
diff --git a/spec/features/language_switching_spec.rb b/spec/features/language_switching_spec.rb index abc1234..def5678 100644 --- a/spec/features/language_switching_spec.rb +++ b/spec/features/language_switching_spec.rb @@ -14,14 +14,14 @@ click_on('Cymraeg') - expect(current_path).to eq(booking_requests_pa...
Update spec to pass new rubocop-rspec requirements
diff --git a/sample/fib.rb b/sample/fib.rb index abc1234..def5678 100644 --- a/sample/fib.rb +++ b/sample/fib.rb @@ -1,11 +1,6 @@ require 'jit' -fib = nil -signature = JIT::Type.create_signature( - :CDECL, - :INT, - [ :INT ]) -fib = JIT::Function.build(signature) do |f| +fib = JIT::Function.build([:INT] => :...
Use simplified form for signature.
diff --git a/config/initializers/rack.rb b/config/initializers/rack.rb index abc1234..def5678 100644 --- a/config/initializers/rack.rb +++ b/config/initializers/rack.rb @@ -0,0 +1,7 @@+ +# This is a temporary workaround to fix 'RangeError: exceeded available param key +# space error', pls see https://github.com/rack/ra...
Set higher value for key space limit This should fix the deployment & restart of unicorn workers
diff --git a/spec/commands/add_spec.rb b/spec/commands/add_spec.rb index abc1234..def5678 100644 --- a/spec/commands/add_spec.rb +++ b/spec/commands/add_spec.rb @@ -1,30 +1,44 @@ # frozen_string_literal: true -require "pry-byebug" require "spec_helper" describe "bundle add" do before :each do + build_repo2 + ...
Add specs for `--pre` flag Remove pry
diff --git a/recipes/configure_rundeck.rb b/recipes/configure_rundeck.rb index abc1234..def5678 100644 --- a/recipes/configure_rundeck.rb +++ b/recipes/configure_rundeck.rb @@ -13,12 +13,3 @@ notifies :restart, "service[rundeckd]" end end - -# Set up all the projects. -node['rundeck']['projects'].each do |proje...
Remove configuration of projects as this should happen in a wrapper cookbook.
diff --git a/buffer.gemspec b/buffer.gemspec index abc1234..def5678 100644 --- a/buffer.gemspec +++ b/buffer.gemspec @@ -19,5 +19,7 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.3.5" + spec.add_development_dependency "cucumber", "~> 1.3.8" + spec.add_development_dependency "a...
Add Cucumber and Aruba to project
diff --git a/lib/brivo/collection.rb b/lib/brivo/collection.rb index abc1234..def5678 100644 --- a/lib/brivo/collection.rb +++ b/lib/brivo/collection.rb @@ -15,13 +15,13 @@ def each(&block) - @collection.each(&block) - - while @collection.count < @total_count do + total_count = @total_count + ...
Fix enumberable implementation for Collection Changed the each method to only check the total count of the collection once because if you are deleting the items in the collection the total count will be falling and you won't iterate over the whole collection
diff --git a/lib/assemblotron/objectives/assembly_score.rb b/lib/assemblotron/objectives/assembly_score.rb index abc1234..def5678 100644 --- a/lib/assemblotron/objectives/assembly_score.rb +++ b/lib/assemblotron/objectives/assembly_score.rb @@ -12,7 +12,7 @@ # @return [Float] Assembly score, def run(raw_output, ou...
Fix mis-call of transrate assembly score function
diff --git a/csv_monster.gemspec b/csv_monster.gemspec index abc1234..def5678 100644 --- a/csv_monster.gemspec +++ b/csv_monster.gemspec @@ -1,10 +1,10 @@ require File.expand_path('../lib/csv_monster/version', __FILE__) Gem::Specification.new do |gem| - gem.authors = ["Jeff Iacono"] - gem.email = ["i...
Update gem authors + summary
diff --git a/lib/fog/hp/requests/compute/list_key_pairs.rb b/lib/fog/hp/requests/compute/list_key_pairs.rb index abc1234..def5678 100644 --- a/lib/fog/hp/requests/compute/list_key_pairs.rb +++ b/lib/fog/hp/requests/compute/list_key_pairs.rb @@ -33,8 +33,10 @@ key_pairs = [] key_pairs = self.data[:k...
Fix issue with list in mock mode.
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,28 +1,35 @@ require "git" require "yaml" + +# If repository `name` exists at `path`, pull from it, otherwise clone it there +def clone_or_update(path:, name:, url:) + repo_path = "#{path}/#{name}" + + ap "clone_or_update(path:...
Add a method to simlplify git clone/pull
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -3,13 +3,10 @@ require 'json' SLACK_WEBHOOK = ENV['SLACK_WEBHOOK_URL'] -CHANNEL_NAME = ENV['CHANNEL_NAME'] +CHANNEL_ID = ENV['CHANNEL_ID'] get '/anon' do - print('HOLIS') - print params - print(params[:channel_name]) - ret...
Use channel id instead of name
diff --git a/spec/state_spec.rb b/spec/state_spec.rb index abc1234..def5678 100644 --- a/spec/state_spec.rb +++ b/spec/state_spec.rb @@ -6,6 +6,14 @@ state = State.new + normal = [ + ['k','q','b','n','r'], + ['p','p','p','p','p'], + ['.','.','.','.','.'], + ['.','.','.','.','.'], + ['P',...
Add another gameover spec test
diff --git a/lib/emoji_test_love/rspec/formatters/smiley_faces_formatter.rb b/lib/emoji_test_love/rspec/formatters/smiley_faces_formatter.rb index abc1234..def5678 100644 --- a/lib/emoji_test_love/rspec/formatters/smiley_faces_formatter.rb +++ b/lib/emoji_test_love/rspec/formatters/smiley_faces_formatter.rb @@ -0,0 +1,...
Create smiley faces formatter that really works!
diff --git a/lib/json_key_transformer_middleware/outgoing_json_formatter.rb b/lib/json_key_transformer_middleware/outgoing_json_formatter.rb index abc1234..def5678 100644 --- a/lib/json_key_transformer_middleware/outgoing_json_formatter.rb +++ b/lib/json_key_transformer_middleware/outgoing_json_formatter.rb @@ -11,14 +...
Fix issue introduced by using class methods
diff --git a/features/step_definitions/address_steps.rb b/features/step_definitions/address_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/address_steps.rb +++ b/features/step_definitions/address_steps.rb @@ -15,7 +15,7 @@ expected = JSON.parse(json).to_s actual = JSON.parse(last_response.b...
Make the tests actually test something
diff --git a/railties/lib/rails/rack/logger.rb b/railties/lib/rails/rack/logger.rb index abc1234..def5678 100644 --- a/railties/lib/rails/rack/logger.rb +++ b/railties/lib/rails/rack/logger.rb @@ -1,4 +1,5 @@ require 'rails/log_subscriber' +require 'active_support/core_ext/time/conversions' module Rails module Ra...
Improve performance of the Logger middleware by using simpler versions of methods
diff --git a/lib/generators/active_application/install/install_generator.rb b/lib/generators/active_application/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/active_application/install/install_generator.rb +++ b/lib/generators/active_application/install/install_generator.rb @@ -20,7 +2...
Fix route addition step in install generator
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -8,6 +8,9 @@ set :database, "sqlite3:pizzashop.db" class Product < ActiveRecord::Base +end + +class Order < ActiveRecord::Base end @@ -34,4 +37,10 @@ def parse_order_line orders_input arr = (orders_input.delete "product_")...
Save order & cutomer information
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -2,12 +2,25 @@ require "sinatra/reloader" set :method_override, true +require "pp" require "json" require "./lib/erb_context" # set :bind, '0.0.0.0' # set :port, 4567 + +def puts_e(*args) + args.each{|arg| $stderr.puts a...
Add puts_e, p_e and pp_e
diff --git a/15_timing_discs.rb b/15_timing_discs.rb index abc1234..def5678 100644 --- a/15_timing_discs.rb +++ b/15_timing_discs.rb @@ -0,0 +1,13 @@+base_discs = ARGF.each_line.map { |l| + id, positions, _, initial = l.scan(/\d+/).map(&method(:Integer)) + [id, positions, initial].freeze +} + +[[], [[base_discs.size ...
Add day 15: Timing Discs
diff --git a/distribute_tree.gemspec b/distribute_tree.gemspec index abc1234..def5678 100644 --- a/distribute_tree.gemspec +++ b/distribute_tree.gemspec @@ -9,9 +9,16 @@ s.homepage = 'https://github.com/SunshineLibrary/distribute_tree' s.license = 'MIT' + s.files = `git ls-files`.split("\n") + s...
Add more development gem related
diff --git a/ruby_event_store-rom/spec/rom/adapters/sql/spec_helper_spec.rb b/ruby_event_store-rom/spec/rom/adapters/sql/spec_helper_spec.rb index abc1234..def5678 100644 --- a/ruby_event_store-rom/spec/rom/adapters/sql/spec_helper_spec.rb +++ b/ruby_event_store-rom/spec/rom/adapters/sql/spec_helper_spec.rb @@ -14,8 +1...
Fix SQL tests to test pool size properly
diff --git a/tritium.gemspec b/tritium.gemspec index abc1234..def5678 100644 --- a/tritium.gemspec +++ b/tritium.gemspec @@ -19,7 +19,7 @@ s.email = ["hcatlin@moovweb.com"] s.homepage = "https://github.com/moovweb/tritium" - s.files = Dir['README.md', 'BUILD_VERSION', 'Gemfile', 'Rakefile', 'spe...
Include tests in the gemfile (useful for example generation, etc)
diff --git a/lib/exercism/user_track.rb b/lib/exercism/user_track.rb index abc1234..def5678 100644 --- a/lib/exercism/user_track.rb +++ b/lib/exercism/user_track.rb @@ -17,7 +17,7 @@ def initialize(id, total, viewed) @id = id @total = total - @unread = total-viewed + @unread = total.to_i-viewed.to_i ...
Fix potential nil issue in inbox When querying viewed/total exercises for people one of the values might come back as nil. Or both of them, for that matter. This should ensure that we get a reasonable default rather than a 500 error.
diff --git a/lib/frontend_generators.rb b/lib/frontend_generators.rb index abc1234..def5678 100644 --- a/lib/frontend_generators.rb +++ b/lib/frontend_generators.rb @@ -1,14 +1,25 @@ require "frontend_generators/version" module FrontendGenerators + class Bootstrap def run FileUtils.cp(bootstrap_css,...
Add code to move over the Bootstrap fonts as well
diff --git a/lib/stacks/loadbalancer.rb b/lib/stacks/loadbalancer.rb index abc1234..def5678 100644 --- a/lib/stacks/loadbalancer.rb +++ b/lib/stacks/loadbalancer.rb @@ -4,8 +4,9 @@ attr_accessor :virtual_router_id - def initialize(server_group, index, &block) - super(server_group.name + "-" + index) + def in...
rpearce/jheister: Move virtual_service function to lb cluster, switch to using virtual_services instead of server group
diff --git a/lib/svgeez/optimizer.rb b/lib/svgeez/optimizer.rb index abc1234..def5678 100644 --- a/lib/svgeez/optimizer.rb +++ b/lib/svgeez/optimizer.rb @@ -1,6 +1,6 @@ module Svgeez class Optimizer - SVGO_MINIMUM_VERSION = '1.1.1'.freeze + SVGO_MINIMUM_VERSION = '1.3.0'.freeze SVGO_MINIMUM_VERSION_MESSAG...
Update minimum SVGO version to 1.3.0
diff --git a/lib/web_console/view.rb b/lib/web_console/view.rb index abc1234..def5678 100644 --- a/lib/web_console/view.rb +++ b/lib/web_console/view.rb @@ -5,7 +5,7 @@ # The error pages are special, because they are the only pages that # currently require multiple bindings. We get those from exceptions. ...
Use Thread.current for exception on View class It broke the View#only_on_error_page method.
diff --git a/lib/yomou/downloader.rb b/lib/yomou/downloader.rb index abc1234..def5678 100644 --- a/lib/yomou/downloader.rb +++ b/lib/yomou/downloader.rb @@ -0,0 +1,33 @@+module Yomou + module Narou + + class Downloader + + def initialize + @conf = Yomou::Config.new + + Dir.chdir(@conf.directory) ...
Add thin wrapper of narou command
diff --git a/lib/releaser/capistrano/release_tagging.rb b/lib/releaser/capistrano/release_tagging.rb index abc1234..def5678 100644 --- a/lib/releaser/capistrano/release_tagging.rb +++ b/lib/releaser/capistrano/release_tagging.rb @@ -6,7 +6,7 @@ end task :tag_deploy_commit do - run_locally "bundle exec release...
Use param in capistrano recipe.
diff --git a/spec/generators/double_entry/install/install_generator_spec.rb b/spec/generators/double_entry/install/install_generator_spec.rb index abc1234..def5678 100644 --- a/spec/generators/double_entry/install/install_generator_spec.rb +++ b/spec/generators/double_entry/install/install_generator_spec.rb @@ -7,7 +7,...
Use a local tmp dir
diff --git a/spec/unit/axiom/types/negative_infinity/class_methods/spaceship_operator_spec.rb b/spec/unit/axiom/types/negative_infinity/class_methods/spaceship_operator_spec.rb index abc1234..def5678 100644 --- a/spec/unit/axiom/types/negative_infinity/class_methods/spaceship_operator_spec.rb +++ b/spec/unit/axiom/type...
Remove unnecessary negation from spec
diff --git a/actionmailer/actionmailer.gemspec b/actionmailer/actionmailer.gemspec index abc1234..def5678 100644 --- a/actionmailer/actionmailer.gemspec +++ b/actionmailer/actionmailer.gemspec @@ -20,5 +20,5 @@ s.has_rdoc = true s.add_dependency('actionpack', version) - s.add_dependency('mail', '~> 2.2....
Revert "Bump up mail dependency to take advantage of relaxed i18n version requirement" Locking to ~> 2.2.9.1 means locking to < 2.2.10, not intended behaviour. This reverts commit e7de5dd11e04f03e32865be8bb8c090a96a79ec9.
diff --git a/db/data_migration/20170118092850_remove_deleted_welsh_translation_drafts.rb b/db/data_migration/20170118092850_remove_deleted_welsh_translation_drafts.rb index abc1234..def5678 100644 --- a/db/data_migration/20170118092850_remove_deleted_welsh_translation_drafts.rb +++ b/db/data_migration/20170118092850_re...
Remove deleted Welsh attachment translation drafts This fixes the locale from the migration in #124d654. The Welsh translations had been saved at some point with an `en` locale but the previous commit discarded them as `cy`.
diff --git a/entangler.gemspec b/entangler.gemspec index abc1234..def5678 100644 --- a/entangler.gemspec +++ b/entangler.gemspec @@ -22,6 +22,6 @@ spec.add_development_dependency 'rake', '~> 10.0' spec.add_development_dependency 'rspec', '~> 3.0' spec.add_development_dependency 'rubocop', '~> 0.49.1' - spec.ad...
Remove pessimistic dependency -> listen
diff --git a/spec/models/order_spec.rb b/spec/models/order_spec.rb index abc1234..def5678 100644 --- a/spec/models/order_spec.rb +++ b/spec/models/order_spec.rb @@ -11,4 +11,8 @@ it 'defaults status to waiting for delivery' do expect(order.status).to eq(0) end + + it 'has many products' do + expect(order....
Add spec for orders having many products
diff --git a/spec/title_search_spec.rb b/spec/title_search_spec.rb index abc1234..def5678 100644 --- a/spec/title_search_spec.rb +++ b/spec/title_search_spec.rb @@ -19,3 +19,13 @@ end end + + +describe "Format facet queries" do + + it "Should return a video for a record with multiple 007s" do + resp = solr_res...
Test for format facet query.
diff --git a/spec/unit/errands_spec.rb b/spec/unit/errands_spec.rb index abc1234..def5678 100644 --- a/spec/unit/errands_spec.rb +++ b/spec/unit/errands_spec.rb @@ -0,0 +1,72 @@+require 'yaml' +require 'bosh/template/renderer' +require 'tempfile' +require 'fileutils' + +describe 'errands spec' do + let(:temp_log_dir) ...
Add spec for SSL validation [finishes #114698423] Signed-off-by: Henry Stanley <b0b1d04541cab6bb75fdc9ee8f1c2e7f813af8bc@pivotal.io>
diff --git a/spec/features/ct101s_spec.rb b/spec/features/ct101s_spec.rb index abc1234..def5678 100644 --- a/spec/features/ct101s_spec.rb +++ b/spec/features/ct101s_spec.rb @@ -0,0 +1,9 @@+require 'rails_helper' + +RSpec.feature "Clinical Trials 101", type: :feature, js: true do + scenario "renders CT101 component" do...
Add first test for CT101 rendering
diff --git a/spec/wedding_jukebox_spec.rb b/spec/wedding_jukebox_spec.rb index abc1234..def5678 100644 --- a/spec/wedding_jukebox_spec.rb +++ b/spec/wedding_jukebox_spec.rb @@ -0,0 +1,14 @@+require 'wedding_jukebox' + +describe FakeCatalogue do + let(:catalogue) { FakeCatalogue.new } + + context "searching for songs"...
Add an rspec example for the existing behaviour of FakeCatalogue - Next up - need to ensure only matched songs are returned
diff --git a/LightRoute.podspec b/LightRoute.podspec index abc1234..def5678 100644 --- a/LightRoute.podspec +++ b/LightRoute.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = "LightRoute" - s.version = "2.1.3" + s.version = "2.1.4" s.summary = "LightRoute is easy transition between ...
Update spec to version 2.1.4
diff --git a/Formula/bartycrouch.rb b/Formula/bartycrouch.rb index abc1234..def5678 100644 --- a/Formula/bartycrouch.rb +++ b/Formula/bartycrouch.rb @@ -1,7 +1,7 @@ class Bartycrouch < Formula desc "Incrementally update/translate your Strings files" homepage "https://github.com/Flinesoft/BartyCrouch" - url "http...
Update formula to version 4.3.0
diff --git a/test/test_unescaping_commands.rb b/test/test_unescaping_commands.rb index abc1234..def5678 100644 --- a/test/test_unescaping_commands.rb +++ b/test/test_unescaping_commands.rb @@ -8,19 +8,10 @@ end end - def is_windows - !! (RbConfig::CONFIG['target_os'] =~ /mingw32|mswin/) - end - def ech...
Revert "Make unescape tests work on windows." This reverts commit 775334fc79533e2d75d79b07e2c412f875ebb629.
diff --git a/environment.rb b/environment.rb index abc1234..def5678 100644 --- a/environment.rb +++ b/environment.rb @@ -25,7 +25,7 @@ $LOAD_PATH.unshift("#{File.dirname(__FILE__)}/lib") Dir.glob("#{File.dirname(__FILE__)}/lib/*.rb") { |lib| require File.basename(lib, '.*') } - DataMapper.setup(:default, (ENV["...
Switch to production db name.
diff --git a/BHCDatabase/test/models/enrolment_test.rb b/BHCDatabase/test/models/enrolment_test.rb index abc1234..def5678 100644 --- a/BHCDatabase/test/models/enrolment_test.rb +++ b/BHCDatabase/test/models/enrolment_test.rb @@ -19,4 +19,12 @@ @enrolment.initiative = nil assert_not @enrolment.valid? end + +...
Add test for index on user and initiative for an enrolment.
diff --git a/spec/isolated_environment_spec.rb b/spec/isolated_environment_spec.rb index abc1234..def5678 100644 --- a/spec/isolated_environment_spec.rb +++ b/spec/isolated_environment_spec.rb @@ -0,0 +1,31 @@+require_relative './spec_helper' +require 'tempfile' + +describe Mumukit::IsolatedEnvironment do + class Demo...
Add tests for desired behavior
diff --git a/spec/lib/reg_api2/service_spec.rb b/spec/lib/reg_api2/service_spec.rb index abc1234..def5678 100644 --- a/spec/lib/reg_api2/service_spec.rb +++ b/spec/lib/reg_api2/service_spec.rb @@ -3,23 +3,23 @@ describe :nop do it "should return list of services if requested" do - answer = RegApi2.service...
Rework service spec using new features.
diff --git a/spec/models/users_project_spec.rb b/spec/models/users_project_spec.rb index abc1234..def5678 100644 --- a/spec/models/users_project_spec.rb +++ b/spec/models/users_project_spec.rb @@ -10,7 +10,7 @@ let!(:users_project) { create(:users_project) } it { should validate_presence_of(:user_id) } - ...
Fix spec broken by bde19c0
diff --git a/spec/controllers/user_info_controller_spec.rb b/spec/controllers/user_info_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/user_info_controller_spec.rb +++ b/spec/controllers/user_info_controller_spec.rb @@ -9,7 +9,7 @@ it "renders the dashboard info as json" do get :dash...
Fix user info controller spec.
diff --git a/spec/requests/admin_panel_spec.rb b/spec/requests/admin_panel_spec.rb index abc1234..def5678 100644 --- a/spec/requests/admin_panel_spec.rb +++ b/spec/requests/admin_panel_spec.rb @@ -5,18 +5,14 @@ describe 'an admin user' do let!(:user) { create(:user, :email => 'admin@email.com', :admin => true) }...
Extend specs for the admin panel.
diff --git a/lib/pv.rb b/lib/pv.rb index abc1234..def5678 100644 --- a/lib/pv.rb +++ b/lib/pv.rb @@ -1,6 +1,14 @@+require 'pv/configuration' require 'pv/command' require 'pv/version' +require 'pv/bug_tracker' module Pv - # Your code goes here... + def self.config + @config ||= Pv::Configuration.new + end + +...
Add module-level accessors for PivotalTracker and the config
diff --git a/db/migrate/20170407184247_create_shopify_data_feeds.rb b/db/migrate/20170407184247_create_shopify_data_feeds.rb index abc1234..def5678 100644 --- a/db/migrate/20170407184247_create_shopify_data_feeds.rb +++ b/db/migrate/20170407184247_create_shopify_data_feeds.rb @@ -0,0 +1,15 @@+class CreateShopifyDataFee...
Add migration for create shopify data feed
diff --git a/spec/features/start_new_game_spec.rb b/spec/features/start_new_game_spec.rb index abc1234..def5678 100644 --- a/spec/features/start_new_game_spec.rb +++ b/spec/features/start_new_game_spec.rb @@ -1,36 +1,36 @@-require "spec_helper" +require "rails_helper" -feature "User starts new game" do - let(:userna...
Disable broken capybara feature spec
diff --git a/spec/listen/adapters/polling_spec.rb b/spec/listen/adapters/polling_spec.rb index abc1234..def5678 100644 --- a/spec/listen/adapters/polling_spec.rb +++ b/spec/listen/adapters/polling_spec.rb @@ -7,18 +7,18 @@ it "calls listener.on_change" do adapter = Listen::Adapters::Polling.new(listener) -...
Improve polling adapter spec for JRuby
diff --git a/spec/models/services/twitter_spec.rb b/spec/models/services/twitter_spec.rb index abc1234..def5678 100644 --- a/spec/models/services/twitter_spec.rb +++ b/spec/models/services/twitter_spec.rb @@ -31,5 +31,16 @@ expect(twitter_client).to have_received(:update!).with("#{'q' * 123}… — #{'a' * 124}… ht...
Add test for handling answers that don't need to be shortened for tweets
diff --git a/lib/xp.rb b/lib/xp.rb index abc1234..def5678 100644 --- a/lib/xp.rb +++ b/lib/xp.rb @@ -16,7 +16,7 @@ end def download(location: 'downloads', name: nil) - FileUtils.mkdir_p location + ::FileUtils.mkdir_p location filename = (name || basename).to_s + extension File.open("#{location}...
Update FileUtils to use outside scope
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -11,6 +11,14 @@ # Restart the random number generator prior to each scenario to # ensure we have reproducibility of random output Kernel.srand(3598395826983...
FIX issue with unpredictable dates using faker gem
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -1,6 +1,9 @@ require 'rubygems' require 'bundler/setup' require 'aruba/cucumber' + +$:.unshift(File.dirname(__FILE__) + '/lib') +require 'dnsimple' Before do ...
Fix error uninitialized constant DNSimple::Client (NameError)
diff --git a/app/decorators/issue_decorator.rb b/app/decorators/issue_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/issue_decorator.rb +++ b/app/decorators/issue_decorator.rb @@ -14,6 +14,30 @@ h.image_tag standard_photo_url, class: "issue-photo" end + def small_icon_path(default=true) + ...
Add methods to the Issue decorator to figure out icon paths.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,5 +1,5 @@ module ApplicationHelper - def json_for(collection, serializer, options = {}) + def json_for(collection) ...
Remove unnecessary args from json_for.
diff --git a/lib/smart_answer/predicate/variable_matches.rb b/lib/smart_answer/predicate/variable_matches.rb index abc1234..def5678 100644 --- a/lib/smart_answer/predicate/variable_matches.rb +++ b/lib/smart_answer/predicate/variable_matches.rb @@ -25,16 +25,29 @@ alias_method :|, :or def match_descripti...
Make intention of label generation clearer if there are multiple matches wrap the list of them in braces to make it look more like a mathematical set.
diff --git a/lib/critical_path_css/configuration.rb b/lib/critical_path_css/configuration.rb index abc1234..def5678 100644 --- a/lib/critical_path_css/configuration.rb +++ b/lib/critical_path_css/configuration.rb @@ -1,9 +1,10 @@+require 'erb' module CriticalPathCss class Configuration CONFIGURATION_FILENAME =...
Support Railsy ERB <%= %> interpolations in config file
diff --git a/spec/avro2kafka_spec.rb b/spec/avro2kafka_spec.rb index abc1234..def5678 100644 --- a/spec/avro2kafka_spec.rb +++ b/spec/avro2kafka_spec.rb @@ -14,26 +14,7 @@ before do ARGV.replace ['./spec/support/data.avro'] - - # Get the last 3 messages from the kafka topic - @consumer = Poseidon...
Remove end-to-end test, because it requires a running Kafka
diff --git a/test/centos_spec.rb b/test/centos_spec.rb index abc1234..def5678 100644 --- a/test/centos_spec.rb +++ b/test/centos_spec.rb @@ -12,4 +12,8 @@ it 'should not have a .vbox_version file' do expect(file '/home/vagrant/.vbox_version').to_not be_file end + + it 'should disable SELinux' do + expect(...
Add test for SELinux being disabled
diff --git a/Casks/mjolnir.rb b/Casks/mjolnir.rb index abc1234..def5678 100644 --- a/Casks/mjolnir.rb +++ b/Casks/mjolnir.rb @@ -2,6 +2,7 @@ version '0.4.3' sha256 '7f7a9579427f258a34663abed46845c81c35f676f63b2ae1acef2a7729745572' + # github.com/sdegutis/mjolnir was verified as official when first introduced to...
Fix `url` stanza comment for Mjolnir.
diff --git a/Casks/trailer.rb b/Casks/trailer.rb index abc1234..def5678 100644 --- a/Casks/trailer.rb +++ b/Casks/trailer.rb @@ -1,6 +1,6 @@ cask :v1 => 'trailer' do - version '1.3.4' - sha256 '3daf054656f635a1ec17eb84fac56867da0511b206c7b6a4b4f80562f4fa1f4b' + version '1.3.5' + sha256 '906b13316d243c7791c1258f5b89...
Update Trailer to version 1.3.5 This commit updates the version and sha256 stanzas
diff --git a/spec/models/calagator/event/cloner_spec.rb b/spec/models/calagator/event/cloner_spec.rb index abc1234..def5678 100644 --- a/spec/models/calagator/event/cloner_spec.rb +++ b/spec/models/calagator/event/cloner_spec.rb @@ -22,15 +22,17 @@ describe "#start_time" do it "should equal todays date wit...
Fix Event::Cloner spec for daylight savings transition days Instead of using an offset from midnight, compare the date and wall clock time of the cloned event directly. This better captures the intended cloning behavior and will work when run on DST transition days. Fixes #478