diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -5,6 +5,7 @@ description "Installs and configures Rundeck 2.0" long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) version "2.0.4" +depends "runit" depends ...
Revert "remove the runit dependency" This reverts commit c970574c6323d61ba71ea27e770b5b5188217344 [formerly c970574c6323d61ba71ea27e770b5b5188217344 [formerly 22f0fef602c93cdf7224d09a1d3ffbccd53ae458]]. Former-commit-id: 6213ab53718192e50121eff248f7cb2ad2c59444 Former-commit-id: 8549816b14475fbf69b4974e4f4ff82980c09...
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -2,7 +2,7 @@ maintainer_email "stefan@02strich.de" license "MIT" description "Installs/Configures mpd" -long_description IO.read(File.join(File.dirname(__FILE__), 'README.rdoc')) +long...
Fix name of Readme file
diff --git a/lib/cellular/models/sms.rb b/lib/cellular/models/sms.rb index abc1234..def5678 100644 --- a/lib/cellular/models/sms.rb +++ b/lib/cellular/models/sms.rb @@ -28,11 +28,11 @@ end def save(options) - raise NotImplementerError + raise NotImplementedError end def receive(options)...
Fix typo in SMS class
diff --git a/lib/prelay/lookup_by_id.rb b/lib/prelay/lookup_by_id.rb index abc1234..def5678 100644 --- a/lib/prelay/lookup_by_id.rb +++ b/lib/prelay/lookup_by_id.rb @@ -2,23 +2,28 @@ module Prelay module LookupById + attr_reader :object + def self.included(base) base.argument :id, :id base.pr...
Update LookupById to not even run the mutation if the object isn't found, since that's what we generally want anyway.
diff --git a/lib/rbnacl/serializable.rb b/lib/rbnacl/serializable.rb index abc1234..def5678 100644 --- a/lib/rbnacl/serializable.rb +++ b/lib/rbnacl/serializable.rb @@ -9,7 +9,7 @@ # # @return [String] a string representing this key def inspect - "#<#{self.class}:#{to_s(:hex)[0,8]}>" + "#<#{self...
Fix hex conversion in Serializable
diff --git a/lib/sub_diff/diff_match.rb b/lib/sub_diff/diff_match.rb index abc1234..def5678 100644 --- a/lib/sub_diff/diff_match.rb +++ b/lib/sub_diff/diff_match.rb @@ -2,7 +2,7 @@ module SubDiff class DiffMatch < SimpleDelegator - attr_reader :prefix, :suffix, :replacement + attr_reader :replacement, :prefi...
Reorder attr readers in `DiffMatch`
diff --git a/lib/webdrive/api/client.rb b/lib/webdrive/api/client.rb index abc1234..def5678 100644 --- a/lib/webdrive/api/client.rb +++ b/lib/webdrive/api/client.rb @@ -24,7 +24,7 @@ end def call(*method) - @server.call(@rpc_key, @auth_key, *method) + @server.call(@rpc_key, @auth_key, metho...
Fix issues with the extract options method
diff --git a/twitter-text.gemspec b/twitter-text.gemspec index abc1234..def5678 100644 --- a/twitter-text.gemspec +++ b/twitter-text.gemspec @@ -1,6 +1,6 @@ spec = Gem::Specification.new do |s| s.name = "twitter-text" - s.version = "1.3.0" + s.version = "1.3.1" s.authors = ["Matt Sanford", "Patrick Ewing", "Ben...
Update gem version to v1.3.1
diff --git a/server.rb b/server.rb index abc1234..def5678 100644 --- a/server.rb +++ b/server.rb @@ -29,7 +29,7 @@ 'email' => params[:stripeEmail], 'reason' => params[:reason] }, - :description => "Charge for test@example.com" + :description => "Cashin Charge" ) 'success' ...
Remove example description from Strip charge
diff --git a/builder/test/image_spec.rb b/builder/test/image_spec.rb index abc1234..def5678 100644 --- a/builder/test/image_spec.rb +++ b/builder/test/image_spec.rb @@ -26,7 +26,7 @@ context "Binary dpkg" do let(:stdout) { run_mounted("file-architecture /usr/bin/dpkg").stdout } - it "is compiled for ARM arc...
Fix test if Docker Engine is installed Signed-off-by: Dieter Reuter <554783fc552b5b2a46dd3d7d7b9b2cce9a82c122@me.com>
diff --git a/SBObjectiveCWrapper.podspec b/SBObjectiveCWrapper.podspec index abc1234..def5678 100644 --- a/SBObjectiveCWrapper.podspec +++ b/SBObjectiveCWrapper.podspec @@ -13,7 +13,7 @@ s.ios.deployment_target = "8.0" s.watchos.deployment_target = "2.0" s.tvos.deployment_target = "9.0" - s.osx.deploym...
Update OS X deployment target in pod spec.
diff --git a/plugins/suppliers/models/suppliers_plugin/distributed_product.rb b/plugins/suppliers/models/suppliers_plugin/distributed_product.rb index abc1234..def5678 100644 --- a/plugins/suppliers/models/suppliers_plugin/distributed_product.rb +++ b/plugins/suppliers/models/suppliers_plugin/distributed_product.rb @@ ...
suppliers: Remove validation for own product
diff --git a/lib/tasks/statistics_announcements_intents.rake b/lib/tasks/statistics_announcements_intents.rake index abc1234..def5678 100644 --- a/lib/tasks/statistics_announcements_intents.rake +++ b/lib/tasks/statistics_announcements_intents.rake @@ -0,0 +1,17 @@+namespace :statistics_announcements do + desc "Update...
Add rake task to update `StatisticsAnnouncement` publish intent This rake task is required to send a `publish_intent` to the PublishingAPI for any existing `StatisticsAnnouncement` with a release date in the future. It is a follow up commit to https://github.com/alphagov/whitehall/pull/2538
diff --git a/lib/yard/server/commands/static_file_command.rb b/lib/yard/server/commands/static_file_command.rb index abc1234..def5678 100644 --- a/lib/yard/server/commands/static_file_command.rb +++ b/lib/yard/server/commands/static_file_command.rb @@ -5,6 +5,8 @@ module Commands class StaticFileCommand < Ba...
Add mime type for javascript (WEBrick does not have this defined)
diff --git a/resources/chef-repo/site-cookbooks/nginx_part/recipes/configure.rb b/resources/chef-repo/site-cookbooks/nginx_part/recipes/configure.rb index abc1234..def5678 100644 --- a/resources/chef-repo/site-cookbooks/nginx_part/recipes/configure.rb +++ b/resources/chef-repo/site-cookbooks/nginx_part/recipes/configur...
Add resource to restart nginx
diff --git a/example/environment.rb b/example/environment.rb index abc1234..def5678 100644 --- a/example/environment.rb +++ b/example/environment.rb @@ -4,7 +4,6 @@ require 'oauth2/provider' OAuth2::Provider.realm = 'Notes App' -OAuth2::Provider.mode = 'development' require 'models/connection' require 'models/u...
Remove mode setting from example app.
diff --git a/config/initializers/env.rb b/config/initializers/env.rb index abc1234..def5678 100644 --- a/config/initializers/env.rb +++ b/config/initializers/env.rb @@ -1,5 +1,5 @@ ENV["G5_HUB_ENTRIES_URL"] ||= case Rails.env - when "production" then "https://g5-hub.herokuapp.com" + when "production" then "http://h...
Fix the client uid format So it will match what is in the hub and therefore G5Updatable
diff --git a/Casks/handbrakecli-nightly.rb b/Casks/handbrakecli-nightly.rb index abc1234..def5678 100644 --- a/Casks/handbrakecli-nightly.rb +++ b/Casks/handbrakecli-nightly.rb @@ -1,6 +1,6 @@ cask :v1 => 'handbrakecli-nightly' do - version '6752svn' - sha256 'a9b2d95e47a72b5cd918bd3b2d8f2064cec1b5f8b96b441dabc60af63...
Update HandbrakeCLI Nightly to v6782svn HandBrakeCLI Nightly v6782svn built 2015-01-21.
diff --git a/Casks/handbrakecli-nightly.rb b/Casks/handbrakecli-nightly.rb index abc1234..def5678 100644 --- a/Casks/handbrakecli-nightly.rb +++ b/Casks/handbrakecli-nightly.rb @@ -1,6 +1,6 @@ class HandbrakecliNightly < Cask - version '6452svn' - sha256 'cce4733a704bab3d0314d8950b98c2cdce4ed47e4e838727f8e996a3f5cfa5...
Update HandBrakeCLI Nightly to v6469svn HandBrakeCLI Nightly Build 6469svn released 2014-10-26.
diff --git a/lib/metaforce.rb b/lib/metaforce.rb index abc1234..def5678 100644 --- a/lib/metaforce.rb +++ b/lib/metaforce.rb @@ -23,6 +23,7 @@ # Performs a login and retrurns the session def login(options={}) + options = HashWithIndifferentAccess.new(options) username = options.fetch(:usern...
Use hash with indifferent access.
diff --git a/app/controllers/session.rb b/app/controllers/session.rb index abc1234..def5678 100644 --- a/app/controllers/session.rb +++ b/app/controllers/session.rb @@ -12,16 +12,20 @@ end post '/session/data' do - p params interval_info = params["session"] session = Session.create() + counter = 0 while inte...
Add Feedback Association to Session For Later Use
diff --git a/app/mailers/poll_mailer.rb b/app/mailers/poll_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/poll_mailer.rb +++ b/app/mailers/poll_mailer.rb @@ -36,7 +36,7 @@ locale: locale_for(user), to: user.email, utm_hash: utm_hash, - subject_key: "p...
Fix poll mailer syntax error
diff --git a/app/models/notification.rb b/app/models/notification.rb index abc1234..def5678 100644 --- a/app/models/notification.rb +++ b/app/models/notification.rb @@ -30,10 +30,9 @@ end def text_bindings - h = {} - h[:initiator] = { :text => initiator.name } if initiator - h[:subject] = { :text => sub...
Use loop to avoid code repetition
diff --git a/lib/mongo/rails/instrumentation/railtie.rb b/lib/mongo/rails/instrumentation/railtie.rb index abc1234..def5678 100644 --- a/lib/mongo/rails/instrumentation/railtie.rb +++ b/lib/mongo/rails/instrumentation/railtie.rb @@ -19,12 +19,13 @@ def instrument(clazz, methods) clazz.module_eval do ...
Include stack trace information for instrumented methods. Fixes #2.
diff --git a/lib/proxy_pac_rb/cli/compress_proxy_pac.rb b/lib/proxy_pac_rb/cli/compress_proxy_pac.rb index abc1234..def5678 100644 --- a/lib/proxy_pac_rb/cli/compress_proxy_pac.rb +++ b/lib/proxy_pac_rb/cli/compress_proxy_pac.rb @@ -19,9 +19,12 @@ @linter = ProxyPacLinter.new end + def load_fi...
Load files before linting them. It's more logical
diff --git a/lib/servitude/environment_configuration.rb b/lib/servitude/environment_configuration.rb index abc1234..def5678 100644 --- a/lib/servitude/environment_configuration.rb +++ b/lib/servitude/environment_configuration.rb @@ -6,7 +6,7 @@ class EnvironmentConfiguration < Servitude::Configuration def for_...
Fix issue with environment configuration.
diff --git a/Formula/solr.rb b/Formula/solr.rb index abc1234..def5678 100644 --- a/Formula/solr.rb +++ b/Formula/solr.rb @@ -10,9 +10,9 @@ end_script class Solr <Formula - url 'http://apache.deathculture.net/lucene/solr/1.3.0/apache-solr-1.3.0.tgz' + url 'http://apache.deathculture.net/lucene/solr/1.4.0/apache-sol...
Update Solr Formula to 1.4.0
diff --git a/core/spec/controllers/spree/admin/mail_methods_controller_spec.rb b/core/spec/controllers/spree/admin/mail_methods_controller_spec.rb index abc1234..def5678 100644 --- a/core/spec/controllers/spree/admin/mail_methods_controller_spec.rb +++ b/core/spec/controllers/spree/admin/mail_methods_controller_spec.rb...
Remove order reference from mailMethodsController spec and fix param names Conflicts: core/spec/controllers/spree/admin/mail_methods_controller_spec.rb
diff --git a/app/screens/info_screen.rb b/app/screens/info_screen.rb index abc1234..def5678 100644 --- a/app/screens/info_screen.rb +++ b/app/screens/info_screen.rb @@ -17,7 +17,9 @@ if navigationType == UIWebViewNavigationTypeLinkClicked || navigationType == UIWebViewNavigationTypeOther url = reque...
Fix crash problem in screen for Vimeo video - Adapt to new Vimeo access specifications => it alos needs access to 'vimeocdn.com' now
diff --git a/app/models/tuner.rb b/app/models/tuner.rb index abc1234..def5678 100644 --- a/app/models/tuner.rb +++ b/app/models/tuner.rb @@ -19,6 +19,8 @@ def logs_since(time_interval) query = RecentLog.where(:tuner_id => id) - query.where('created_at > ? ', time_interval.date_range.begin.utc) unles...
Fix Tuner.logs_since returning nil for Log.all_interval
diff --git a/app/workers/repository_check/single_repository_worker.rb b/app/workers/repository_check/single_repository_worker.rb index abc1234..def5678 100644 --- a/app/workers/repository_check/single_repository_worker.rb +++ b/app/workers/repository_check/single_repository_worker.rb @@ -5,13 +5,18 @@ def perform...
Make it easier to override how to save the results
diff --git a/Library/Formula/subversion.rb b/Library/Formula/subversion.rb index abc1234..def5678 100644 --- a/Library/Formula/subversion.rb +++ b/Library/Formula/subversion.rb @@ -1,14 +1,14 @@ require 'brewkit' class SubversionDeps <Formula - @url='http://subversion.tigris.org/downloads/subversion-deps-1.6.3.tar....
Update Subersion to 1.6.5, add SSL support, turn off BDB support.
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -3,6 +3,7 @@ Bundler.require(:default) -require './app' +$LOAD_PATH.unshift(::File.expand_path('lib', ::File.dirname(__FILE__))) +require 'nesta/app' run Nesta::App
Load local code in development.
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -3,7 +3,7 @@ Bundler.require -require "try-redis.rb" +require "./try-redis.rb" use Rack::Static, :urls => %w( /css /images /javascripts ), :root => "public"
Add path to main lib.
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -4,4 +4,8 @@ Bundler.require require './app' + +# So that log output doesn't get buffered +$stdout.sync = true + run Sinatra::Application
Stop log output from being buffered
diff --git a/app/form_objects/create_turn_form_object.rb b/app/form_objects/create_turn_form_object.rb index abc1234..def5678 100644 --- a/app/form_objects/create_turn_form_object.rb +++ b/app/form_objects/create_turn_form_object.rb @@ -4,11 +4,10 @@ def initialize(params) @params = params @coordinates = ex...
Remove player_id param check from CreateTurnFormObject
diff --git a/guard-cucumber.gemspec b/guard-cucumber.gemspec index abc1234..def5678 100644 --- a/guard-cucumber.gemspec +++ b/guard-cucumber.gemspec @@ -16,7 +16,7 @@ s.rubyforge_project = 'guard-cucumber' s.add_dependency 'guard', '>= 0.8.3' - s.add_dependency 'cucumber', '>= 0.10' + s.add_de...
Add Cucumber 1.2.0 as dependency. A change in the Cucumber formatter API must be reflected in the Guard Cucumber notification formatter.
diff --git a/lib/encryptable.rb b/lib/encryptable.rb index abc1234..def5678 100644 --- a/lib/encryptable.rb +++ b/lib/encryptable.rb @@ -2,36 +2,38 @@ # licensed under the Affero General Public License version 3 or later. See # the COPYRIGHT file. - module Encryptable - def signable_string - raise NotImp...
Fix log statements in Encryptable
diff --git a/lib/fraggle-synchrony/fraggle/client.rb b/lib/fraggle-synchrony/fraggle/client.rb index abc1234..def5678 100644 --- a/lib/fraggle-synchrony/fraggle/client.rb +++ b/lib/fraggle-synchrony/fraggle/client.rb @@ -1,14 +1,19 @@ module Fraggle class Client - %w{rev set get del stat}.each do |cmd| + %w{...
Handle blocks passed to functions This means we can implement getdir and walk.
diff --git a/lib/rpush/daemon/interruptible_sleep.rb b/lib/rpush/daemon/interruptible_sleep.rb index abc1234..def5678 100644 --- a/lib/rpush/daemon/interruptible_sleep.rb +++ b/lib/rpush/daemon/interruptible_sleep.rb @@ -1,17 +1,22 @@-require 'monitor' - module Rpush module Daemon class InterruptibleSleep ...
Handle exceptions when joining sleep thread in InterruptibleSleep.
diff --git a/lib/travis/logs/sidekiq/send_timings.rb b/lib/travis/logs/sidekiq/send_timings.rb index abc1234..def5678 100644 --- a/lib/travis/logs/sidekiq/send_timings.rb +++ b/lib/travis/logs/sidekiq/send_timings.rb @@ -14,9 +14,9 @@ sidekiq_options queue: 'send_timing', retry: 3, uniq...
Use more descriptive name for arg
diff --git a/models/season.rb b/models/season.rb index abc1234..def5678 100644 --- a/models/season.rb +++ b/models/season.rb @@ -1,6 +1,10 @@ require 'time' class Season < ActiveRecord::Base + validates :name, presence: true, uniqueness: true + validates :start, presence: true + validates :expiry, presence: true ...
Add validations for Season model.
diff --git a/lib/whitehall/abbreviation_extractor.rb b/lib/whitehall/abbreviation_extractor.rb index abc1234..def5678 100644 --- a/lib/whitehall/abbreviation_extractor.rb +++ b/lib/whitehall/abbreviation_extractor.rb @@ -33,15 +33,8 @@ ) end - # Because the govspeak helpers in whitehall rely on renderin...
Use controller instance helpers proxy
diff --git a/LineKit.podspec b/LineKit.podspec index abc1234..def5678 100644 --- a/LineKit.podspec +++ b/LineKit.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = "LineKit" s.version = "1.4.1" - s.summary = "Share to Naver Line from your apps." + s.summary = "Share to LINE from your a...
Add framework and change description of podspec
diff --git a/jenkins-cli.rb b/jenkins-cli.rb index abc1234..def5678 100644 --- a/jenkins-cli.rb +++ b/jenkins-cli.rb @@ -7,6 +7,15 @@ bottle :unneeded depends_on :java => "1.7+" + + # modified from http://www.rubydoc.info/github/Homebrew/homebrew/Pathname:write_jar_script + def write_jar_script(target_jar, scr...
Allow using a special ssh key that doesn't prompt for a password.
diff --git a/lib/tzinfo/data.rb b/lib/tzinfo/data.rb index abc1234..def5678 100644 --- a/lib/tzinfo/data.rb +++ b/lib/tzinfo/data.rb @@ -20,4 +20,11 @@ # THE SOFTWARE. #++ +# Top level module for TZInfo. +module TZInfo + # Top level module for TZInfo::Data. + module Data + end +end + require 'tzinfo/data/version...
Add documentation comments for TZInfo and TZInfo::Data modules. Avoids blank pages being generated by RDoc and the licence being used as documentation by YARD.
diff --git a/apps/rails_turbo_assets.rb b/apps/rails_turbo_assets.rb index abc1234..def5678 100644 --- a/apps/rails_turbo_assets.rb +++ b/apps/rails_turbo_assets.rb @@ -1,5 +1,13 @@+# +# There are a few requirement for theses tasks to work as intentended : +# +# - You must set :deploy_via, :remote_cache +# - The cached...
Use remote repository for assets precompiling check
diff --git a/ruby_event_store_rom_sql/lib/ruby_event_store/expected_version.rb b/ruby_event_store_rom_sql/lib/ruby_event_store/expected_version.rb index abc1234..def5678 100644 --- a/ruby_event_store_rom_sql/lib/ruby_event_store/expected_version.rb +++ b/ruby_event_store_rom_sql/lib/ruby_event_store/expected_version.rb...
Add helper methods for :any, :none and :auto
diff --git a/lib/cli.rb b/lib/cli.rb index abc1234..def5678 100644 --- a/lib/cli.rb +++ b/lib/cli.rb @@ -24,6 +24,7 @@ stdout.puts("Done!".green) rescue NoMethodError => e stdout.puts("Error: #{e.message}\n".red) + stdout.puts e.backtrace.join("\n\t") end end
Add backtrace to error output
diff --git a/spec/features/tournaments_spec.rb b/spec/features/tournaments_spec.rb index abc1234..def5678 100644 --- a/spec/features/tournaments_spec.rb +++ b/spec/features/tournaments_spec.rb @@ -17,8 +17,13 @@ visit tournaments_path(year: admin.year) expect(page).to have_text 'Order' fill_in "ordinals[#...
Test db is correctly updated
diff --git a/spec/libs/weather_grabber_spec.rb b/spec/libs/weather_grabber_spec.rb index abc1234..def5678 100644 --- a/spec/libs/weather_grabber_spec.rb +++ b/spec/libs/weather_grabber_spec.rb @@ -0,0 +1,26 @@+require 'spec_helper' +require_relative '../../lib/weather_grabber' + +describe WeatherGrabber, :vcr do + + ...
Add test for weather grabber
diff --git a/spec/models/project_total_spec.rb b/spec/models/project_total_spec.rb index abc1234..def5678 100644 --- a/spec/models/project_total_spec.rb +++ b/spec/models/project_total_spec.rb @@ -2,25 +2,25 @@ RSpec.describe ProjectTotal, type: :model do before do - @project_id = create(:contribution, value: 1...
Update ProjectView tests to validate his new behavior
diff --git a/spec/planning_center/base_spec.rb b/spec/planning_center/base_spec.rb index abc1234..def5678 100644 --- a/spec/planning_center/base_spec.rb +++ b/spec/planning_center/base_spec.rb @@ -26,20 +26,20 @@ attrs = { 'id' => 123 } expect( PlanningCenter::Base.new(attrs, client).respond_to?(:...
Fix RSpec 3 deprecation warnings
diff --git a/spec/puppetfiler/metadata_spec.rb b/spec/puppetfiler/metadata_spec.rb index abc1234..def5678 100644 --- a/spec/puppetfiler/metadata_spec.rb +++ b/spec/puppetfiler/metadata_spec.rb @@ -6,7 +6,7 @@ Puppetfiler::Metadata.new('./data/simple_metadata.json') } - describe 'instance variables' do...
Change to more apprioriate description
diff --git a/Casks/phpstorm-eap.rb b/Casks/phpstorm-eap.rb index abc1234..def5678 100644 --- a/Casks/phpstorm-eap.rb +++ b/Casks/phpstorm-eap.rb @@ -1,6 +1,6 @@ cask :v1 => 'phpstorm-eap' do - version '141.176' - sha256 'a5c70789db4aa13c938de761029b15b2348b0a39f7ac549eaa7c82434373caed' + version '141.332' + sha256 ...
Update PhpStorm-EAP.app to version 141.332.
diff --git a/test/tc_terminal.rb b/test/tc_terminal.rb index abc1234..def5678 100644 --- a/test/tc_terminal.rb +++ b/test/tc_terminal.rb @@ -10,6 +10,14 @@ bloom do saw_input <= stdio + end +end + +class StdioEcho + include Bud + + bloom do + stdio <~ stdio {|s| ["Saw: #{s.line}"]} end end @@ -29,4...
Add test case for stdio. Check that reading from / writing to pipe IO objects works. This functionality is being used by the UCLA folks, so it seems prudent to verify that it works.
diff --git a/spec/support/time_travel.rb b/spec/support/time_travel.rb index abc1234..def5678 100644 --- a/spec/support/time_travel.rb +++ b/spec/support/time_travel.rb @@ -17,8 +17,8 @@ raise ArgumentError, "time must be String, Time, or Date: #{time.inspect}" end - Time.stub!(:now).and_return(ti...
Fix deprecated method warnings in specs
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,7 +1,7 @@ require 'simplecov' require 'minitest/rg' -SimpleCov.minimum_coverage_by_file 100 +SimpleCov.minimum_coverage_by_file 90 SimpleCov.start do add_filter '/test/' ...
Reduce minimum test coverage to 90% Zero tolerance really means zero room for common sense. There are some lines that are just stupid to test; doing so would inflate the tests for no benefit. In the future, we will review the coverage reports and ensure that all logic is tested, not necessarily all code.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -23,7 +23,7 @@ class CreateAllTables < ActiveRecord::Migration def self.up - create_table(:users) {|t| t.string :first_name; t.integer :last_name } + create_tabl...
Remove last_name column from User table We are not using it. https://travis-ci.org/yuki24/did_you_mean/jobs/40365201#L76-L78
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,4 +1,5 @@ # coding: UTF-8 +$:.unshift(File.expand_path('../../lib', __FILE__)) Encoding.default_internal = 'UTF-8' if defined? Encoding require 'test/unit'
Add lib to the load path This allows us to run the test suite without `bundle exec` or run a single test without having to push lib to the load path.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -14,6 +14,7 @@ def self.inherited(mod) mod.app = Object.const_get(mod.to_s[/\w+/]) + super end class << self
Make tests run in MiniTest
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -10,3 +10,9 @@ if RUBY_VERSION >= "1.9" MiniTest::Reporters.use!(MiniTest::Reporters::SpecReporter.new) end + +puts "Webhookr #{Webhookr::VERSION}" +puts "Webhookr::Mailchimp #...
Add version information to test output.
diff --git a/big_decimal_helper.gemspec b/big_decimal_helper.gemspec index abc1234..def5678 100644 --- a/big_decimal_helper.gemspec +++ b/big_decimal_helper.gemspec @@ -16,5 +16,5 @@ gem.version = BigDecimalHelper::VERSION gem.add_development_dependency 'rake', '~> 0.9.2.2' - gem.add_development_dependenc...
Update RSpec to ~> 2.14.1
diff --git a/buildr_plus.gemspec b/buildr_plus.gemspec index abc1234..def5678 100644 --- a/buildr_plus.gemspec +++ b/buildr_plus.gemspec @@ -25,6 +25,6 @@ s.rdoc_options = %w(--line-numbers --inline-source --title buildr_plus) s.add_dependency 'reality-core', '>= 1.8.0' - s.add_dependency 'reality-naming'...
Move reality-naming to a later version
diff --git a/tzinfo-data.gemspec b/tzinfo-data.gemspec index abc1234..def5678 100644 --- a/tzinfo-data.gemspec +++ b/tzinfo-data.gemspec @@ -14,5 +14,5 @@ s.add_runtime_dependency 'tzinfo', '>= 1.0.0' s.extra_rdoc_files = ['README.md', 'LICENSE'] s.rdoc_options = %w[--title TZInfo::Data --main README.md --exclu...
Raise minimum Ruby version to 1.8.7. minitest v5 is not compatible with Ruby 1.8.6.
diff --git a/core/db/migrate/20150528125647_delete_inventory_units_without_shipment.rb b/core/db/migrate/20150528125647_delete_inventory_units_without_shipment.rb index abc1234..def5678 100644 --- a/core/db/migrate/20150528125647_delete_inventory_units_without_shipment.rb +++ b/core/db/migrate/20150528125647_delete_inv...
Update conditions under which the orders are updated Do not destroy the shipments/inventory units for cancelled orders or orders that have shipments that have either been cancelled or are ready.
diff --git a/lib/backup/template.rb b/lib/backup/template.rb index abc1234..def5678 100644 --- a/lib/backup/template.rb +++ b/lib/backup/template.rb @@ -26,7 +26,11 @@ ## # Returns a String object containing the contents of the file (in the context of the binding if any) def result(file) - ERB.new(fi...
fix: Handle deprecation in ERB.new arguments
diff --git a/app/models/intervention.rb b/app/models/intervention.rb index abc1234..def5678 100644 --- a/app/models/intervention.rb +++ b/app/models/intervention.rb @@ -2,10 +2,6 @@ belongs_to :student belongs_to :educator belongs_to :intervention_type - belongs_to :school_year - belongs_to :student_school_ye...
Remove before/after events assigning student school years
diff --git a/app/models/organization.rb b/app/models/organization.rb index abc1234..def5678 100644 --- a/app/models/organization.rb +++ b/app/models/organization.rb @@ -26,23 +26,4 @@ ) end - # Search for an Organization - # @param params can be a Hash of attributes to search on Organization - # or a String...
fix(models/orga): Remove useless method on the orga model
diff --git a/lib/que/adapters/pg.rb b/lib/que/adapters/pg.rb index abc1234..def5678 100644 --- a/lib/que/adapters/pg.rb +++ b/lib/que/adapters/pg.rb @@ -1,12 +1,14 @@+require 'monitor' + module Que class PG < Adapter def initialize(pg) - @pg = pg - @mutex = Mutex.new + @pg = pg + @m...
Make sure that locking the bare PG connection is reentrant.
diff --git a/lib/registered_path.rb b/lib/registered_path.rb index abc1234..def5678 100644 --- a/lib/registered_path.rb +++ b/lib/registered_path.rb @@ -18,8 +18,8 @@ { :conditions => {:scope => scope} } } - after_update { |r| PathRegistry.notify :update, self } - after_destroy { |r| PathRegistry.notify :...
Use instance as parameter, not class.
diff --git a/lib/solusvm/general.rb b/lib/solusvm/general.rb index abc1234..def5678 100644 --- a/lib/solusvm/general.rb +++ b/lib/solusvm/general.rb @@ -0,0 +1,22 @@+module Solusvm + class General < Base + def nodes(type) + type.strip! + validate_server_type!(type) + perform_request(:action => 'listn...
Add General. This methods have no real home ATM
diff --git a/lib/swarker/service.rb b/lib/swarker/service.rb index abc1234..def5678 100644 --- a/lib/swarker/service.rb +++ b/lib/swarker/service.rb @@ -2,8 +2,8 @@ class Service DEFAULT_SCHEMA = { swagger: '2.0'.freeze, - consumes: 'application/json'.freeze, - produces: 'application/json'.free...
Fix Service::DEFAULT_SCHEMA: `consumes` and `:produces` are arrays
diff --git a/lib/tasks/migrate.rake b/lib/tasks/migrate.rake index abc1234..def5678 100644 --- a/lib/tasks/migrate.rake +++ b/lib/tasks/migrate.rake @@ -1,7 +1,7 @@ namespace :migrate do task :swap_old_tag_uniqueness_index => :environment do Tag.collection.drop_index('tag_id_1') # this is the generated name for...
Use Mongoid's rake task to create index
diff --git a/lib/zebra/print_job.rb b/lib/zebra/print_job.rb index abc1234..def5678 100644 --- a/lib/zebra/print_job.rb +++ b/lib/zebra/print_job.rb @@ -24,8 +24,8 @@ def check_existent_printers(printer) existent_printers = Cups.show_destinations - logger.info "EXISTENT PRINTERS: \n" - existent_p...
Fix log output statements in print job
diff --git a/config/appconfig.rb b/config/appconfig.rb index abc1234..def5678 100644 --- a/config/appconfig.rb +++ b/config/appconfig.rb @@ -11,4 +11,3 @@ $stderr.puts %[FATAL: Unable to load config] exit 1 end -
Update for changed cloud_controller_ng config path
diff --git a/spec/script/mailin_spec.rb b/spec/script/mailin_spec.rb index abc1234..def5678 100644 --- a/spec/script/mailin_spec.rb +++ b/spec/script/mailin_spec.rb @@ -32,6 +32,8 @@ ir = info_requests(:other_request) incoming_message = ir.incoming_messages[0] incoming_message.fully_destroy + ...
Deal with further side effects of stuff done outside of a transaction in tests
diff --git a/spec/support/vcr_loader.rb b/spec/support/vcr_loader.rb index abc1234..def5678 100644 --- a/spec/support/vcr_loader.rb +++ b/spec/support/vcr_loader.rb @@ -9,5 +9,4 @@ c.filter_sensitive_data('<QT_KEY>') { qt_keys[0] } c.filter_sensitive_data('<QT_KEY_2>') { qt_keys[1] } c.hook_into :webmock - c...
Remove the debug logger for cassettes
diff --git a/app/models/agenda_day.rb b/app/models/agenda_day.rb index abc1234..def5678 100644 --- a/app/models/agenda_day.rb +++ b/app/models/agenda_day.rb @@ -2,7 +2,7 @@ class AgendaDay < ApplicationRecord has_many :times, class_name: 'AgendaTime', inverse_of: :day, - dependent: :destroy + ...
Add missing foreign_key config for agenda day association
diff --git a/app/models/sound_trek.rb b/app/models/sound_trek.rb index abc1234..def5678 100644 --- a/app/models/sound_trek.rb +++ b/app/models/sound_trek.rb @@ -1,5 +1,5 @@ class SoundTrek < ApplicationRecord validates :location_id, :title, presence: true belongs_to :trekker, class_name: "User" - belongs_to :loc...
Add dependent destroy to locations for soundtreks so that pins do not show up on the map when a user deletes soundtrek
diff --git a/realtime.gemspec b/realtime.gemspec index abc1234..def5678 100644 --- a/realtime.gemspec +++ b/realtime.gemspec @@ -7,7 +7,7 @@ Gem::Specification.new do |s| s.name = "realtime" s.version = Realtime::VERSION - s.authors = ["Mike Atlas", "Ahmad Abdel-Yaman (@ayaman)"] + s.authors ...
Update gemspec to include credit for @ayaman & @prokizzle
diff --git a/atspi_app_driver.gemspec b/atspi_app_driver.gemspec index abc1234..def5678 100644 --- a/atspi_app_driver.gemspec +++ b/atspi_app_driver.gemspec @@ -20,9 +20,9 @@ 'Gemfile' ] - s.add_dependency('gir_ffi', ['~> 0.13.0']) + s.add_dependency('gir_ffi', ['~> 0.14.0']) s.add_development_dependency(...
Update gir_ffi and gir_ffi-gtk to 0.14.0
diff --git a/evalso.gemspec b/evalso.gemspec index abc1234..def5678 100644 --- a/evalso.gemspec +++ b/evalso.gemspec @@ -18,6 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.add_runtime_dependency "httparty" spec.add_development_dependency "bundle...
Add httparty as a runtime dependency.
diff --git a/db/migrate/20081211204952_create_attendees.rb b/db/migrate/20081211204952_create_attendees.rb index abc1234..def5678 100644 --- a/db/migrate/20081211204952_create_attendees.rb +++ b/db/migrate/20081211204952_create_attendees.rb @@ -7,10 +7,11 @@ end add_index :attendees, [:member_id, :raid_i...
Add indexes to Attendees for some important performance. That table's gonna be biiiiiig.
diff --git a/ext/extconf.rb b/ext/extconf.rb index abc1234..def5678 100644 --- a/ext/extconf.rb +++ b/ext/extconf.rb @@ -4,6 +4,9 @@ # See COPYING for license details. require 'mkmf' + +# Compile as C99 +$CFLAGS += " -std=c99" if ARGV.include?("--use-float") || ARGV.include?("-F") $CFLAGS += " -DUSE_FLOAT"
Add flag to compile as C99. Because screw C89.
diff --git a/ext/commonmarker/extconf.rb b/ext/commonmarker/extconf.rb index abc1234..def5678 100644 --- a/ext/commonmarker/extconf.rb +++ b/ext/commonmarker/extconf.rb @@ -10,6 +10,12 @@ CMARK_DIR = File.expand_path(File.join(File.dirname(__FILE__), 'cmark')) CMARK_BUILD_DIR = File.join(CMARK_DIR, 'build') + +# TOD...
Remove packaged build directory prior to installation
diff --git a/app/controllers/capacities_controller.rb b/app/controllers/capacities_controller.rb index abc1234..def5678 100644 --- a/app/controllers/capacities_controller.rb +++ b/app/controllers/capacities_controller.rb @@ -1,8 +1,8 @@ class CapacitiesController < ApplicationController - def new - @project = Projec...
Convert to spaces in capacity controller
diff --git a/app/controllers/node_types_controller.rb b/app/controllers/node_types_controller.rb index abc1234..def5678 100644 --- a/app/controllers/node_types_controller.rb +++ b/app/controllers/node_types_controller.rb @@ -1,8 +1,4 @@ class NodeTypesController < ApplicationController - inherit_resources - - actions...
Convert show action to not use inherited_resources
diff --git a/db/dev_seeds/sdg.rb b/db/dev_seeds/sdg.rb index abc1234..def5678 100644 --- a/db/dev_seeds/sdg.rb +++ b/db/dev_seeds/sdg.rb @@ -1,3 +1,21 @@ section "Creating Sustainable Development Goals" do load Rails.root.join("db", "sdg.rb") + + SDG::Target.sample(30).each do |target| + title = "Title for defau...
Add SDG local targets to development seeds
diff --git a/exercises/run-length-encoding/.meta/generator/run_length_encoding_cases.rb b/exercises/run-length-encoding/.meta/generator/run_length_encoding_cases.rb index abc1234..def5678 100644 --- a/exercises/run-length-encoding/.meta/generator/run_length_encoding_cases.rb +++ b/exercises/run-length-encoding/.meta/ge...
Add method name to test name. Adds encode_ or decode_ as a prefix to all tests depending on the method being tested. This fixes a name collision bug between: def test_empty_string for encode and def test_empty_string for decode
diff --git a/mrblib/default_trap.rb b/mrblib/default_trap.rb index abc1234..def5678 100644 --- a/mrblib/default_trap.rb +++ b/mrblib/default_trap.rb @@ -2,5 +2,7 @@ case sig when "INT" Signal.trap(sig) { raise Interrupt, "" } + when "HUP", "TERM", "QUIT", "ALRM", "USR1", "USR2" + Signal.trap(sig) { raise ...
Set default trap functions same as CRuby
diff --git a/fuubar.gemspec b/fuubar.gemspec index abc1234..def5678 100644 --- a/fuubar.gemspec +++ b/fuubar.gemspec @@ -29,5 +29,5 @@ s.require_paths = ['lib'] s.add_dependency 'rspec', '~> 2.0' - s.add_dependency 'ruby-progressbar', '~> 1.0' + s.add_dependency...
Upgrade ruby-progressbar to the latest version
diff --git a/app/helpers/address_helper.rb b/app/helpers/address_helper.rb index abc1234..def5678 100644 --- a/app/helpers/address_helper.rb +++ b/app/helpers/address_helper.rb @@ -1,7 +1,7 @@ module AddressHelper def hidden_tr_if(condition, attributes = {}) - attributes["style"] = "visibility:hidden;" if condi...
Use display:none to to hide secondardy contact, instead of visibility:hidden
diff --git a/app/helpers/sidebar_helper.rb b/app/helpers/sidebar_helper.rb index abc1234..def5678 100644 --- a/app/helpers/sidebar_helper.rb +++ b/app/helpers/sidebar_helper.rb @@ -20,8 +20,14 @@ end def experiment_action_to_link_to(experiment) - # TODO - canvas_experiment_path(experiment) + case action...
Update experiment links on sidebar between actions
diff --git a/test/controllers/optional_modules/blogs/blog_categories_controller_test.rb b/test/controllers/optional_modules/blogs/blog_categories_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/optional_modules/blogs/blog_categories_controller_test.rb +++ b/test/controllers/optional_modules/blog...
Add tests for BlogCategories controller
diff --git a/app/processors/application.rb b/app/processors/application.rb index abc1234..def5678 100644 --- a/app/processors/application.rb +++ b/app/processors/application.rb @@ -1,7 +1,21 @@ class ApplicationProcessor < ActiveMessaging::Processor def ActiveMessaging.logger - @@logger = Logger.new(File.join...
Use the BufferedLogger from ActiveSupport for message process loggin
diff --git a/test/unit/callback_helper_test.rb b/test/unit/callback_helper_test.rb index abc1234..def5678 100644 --- a/test/unit/callback_helper_test.rb +++ b/test/unit/callback_helper_test.rb @@ -2,19 +2,21 @@ require "gir_ffi/callback_helper" describe GirFFI::CallbackHelper do - describe ".map_single_callback_arg...
Test callback helper without setting up GObject.
diff --git a/lib/hosted_graphite/tcp.rb b/lib/hosted_graphite/tcp.rb index abc1234..def5678 100644 --- a/lib/hosted_graphite/tcp.rb +++ b/lib/hosted_graphite/tcp.rb @@ -1,8 +1,13 @@ module HostedGraphite class TCP < Protocol private - def build_message(name, value) - message = [name, value].join(' '...
Configure TCP protocol to accept an optional timestamp
diff --git a/lib/mutant/node_helpers.rb b/lib/mutant/node_helpers.rb index abc1234..def5678 100644 --- a/lib/mutant/node_helpers.rb +++ b/lib/mutant/node_helpers.rb @@ -15,10 +15,14 @@ end module_function :s - NAN = s(:begin, s(:send, s(:float, 0.0), :/, s(:args, s(:float, 0.0)))) - NEGA...
Fix style issues in Mutant::NodeHelpers
diff --git a/roles/tilecache.rb b/roles/tilecache.rb index abc1234..def5678 100644 --- a/roles/tilecache.rb +++ b/roles/tilecache.rb @@ -13,7 +13,7 @@ :sources => ["nginx"] }, :nginx => { - :access_log => nil + :access_log => false }, :sysctl => { :network_conntrack_time_wait => {
Disable nginx logging on tile caches