diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -1,5 +1,5 @@ require 'rubygems' -require './lookup_service.rb' +require "#{File.expand_path(File.dirname(__FILE__))}/lookup_service.rb" CgLookupService::App.set :run, false # disable built-in sinatra web server CgL...
Fix the require path for lookup_service.rb when running from a different directory. git-svn-id: fef28697fff9bc4bae060bf37c18ee74cae4f475@1673 bc291798-7d79-44a5-a816-fbf4f7d05ffa
diff --git a/era_ja.gemspec b/era_ja.gemspec index abc1234..def5678 100644 --- a/era_ja.gemspec +++ b/era_ja.gemspec @@ -4,9 +4,9 @@ Gem::Specification.new do |gem| gem.authors = ["tomi"] gem.email = ["tomiacannondale@gmail.com"] - gem.description = %q{TODO: Write a gem description} - gem.summar...
Fix gem description, gem summary, gem homepage
diff --git a/konjak.gemspec b/konjak.gemspec index abc1234..def5678 100644 --- a/konjak.gemspec +++ b/konjak.gemspec @@ -18,6 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.add_dependency "activesupport" spec.add_dependency "mem" spec.add_depe...
Add activesupport to gem dependency
diff --git a/tiny_http_parser.gemspec b/tiny_http_parser.gemspec index abc1234..def5678 100644 --- a/tiny_http_parser.gemspec +++ b/tiny_http_parser.gemspec @@ -21,5 +21,5 @@ spec.add_development_dependency "bundler", "~> 1.6" spec.add_development_dependency "rake" spec.add_development_dependency "rspec" - spe...
Change http client to faraday
diff --git a/country_select.gemspec b/country_select.gemspec index abc1234..def5678 100644 --- a/country_select.gemspec +++ b/country_select.gemspec @@ -21,5 +21,5 @@ # specify any dependencies here; for example: s.add_development_dependency 'rspec' s.add_development_dependency 'actionpack' - s.add_runtime_dep...
Make appraisal a development dependency rather than runtime
diff --git a/omniauth-oauth2.gemspec b/omniauth-oauth2.gemspec index abc1234..def5678 100644 --- a/omniauth-oauth2.gemspec +++ b/omniauth-oauth2.gemspec @@ -1,5 +1,6 @@-# -*- encoding: utf-8 -*- -require File.expand_path('../lib/omniauth-oauth2/version', __FILE__) +lib = File.expand_path('../lib', __FILE__) +$LOAD_PATH...
Fix loading of version file from gemspec
diff --git a/test/controllers/accounts_controller_test.rb b/test/controllers/accounts_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/accounts_controller_test.rb +++ b/test/controllers/accounts_controller_test.rb @@ -4,6 +4,9 @@ test "should get index" do get :index assert_response :...
Enforce test case for index action in account controller.
diff --git a/faye/config.ru b/faye/config.ru index abc1234..def5678 100644 --- a/faye/config.ru +++ b/faye/config.ru @@ -1,8 +1,28 @@ require 'faye' Faye::WebSocket.load_adapter('thin') - bayeux = Faye::RackAdapter.new(:mount => 'faye', :timeout => 50) +class ServerAuth + def incoming(message, callback) + unle...
Add the extension for faye.
diff --git a/test/lib/gday/version_test.rb b/test/lib/gday/version_test.rb index abc1234..def5678 100644 --- a/test/lib/gday/version_test.rb +++ b/test/lib/gday/version_test.rb @@ -1,6 +1,6 @@ require_relative '../../test_helper' -describe Gday do +describe Gday, 'VERSION' do it "must be defined" do Gday::V...
Add 'VERSION' to describe for VERSION tests
diff --git a/week-6/nested_data_solution.rb b/week-6/nested_data_solution.rb index abc1234..def5678 100644 --- a/week-6/nested_data_solution.rb +++ b/week-6/nested_data_solution.rb @@ -0,0 +1,47 @@+# RELEASE 2: NESTED STRUCTURE GOLF +# Hole 1 +# Target element: "FORE" + +array = [[1,2], ["inner", ["eagle", "par", ["FOR...
Create files for 6.5 Nested Data Structures
diff --git a/examples/multi/basic_top_level.rb b/examples/multi/basic_top_level.rb index abc1234..def5678 100644 --- a/examples/multi/basic_top_level.rb +++ b/examples/multi/basic_top_level.rb @@ -2,13 +2,11 @@ require 'tty-spinner' -spinners = TTY::Spinner::Multi.new "[:spinner] main" +spinners = TTY::Spinner::Mul...
Change to use different formatting and remove auto spin
diff --git a/cloud_conductor_utils.gemspec b/cloud_conductor_utils.gemspec index abc1234..def5678 100644 --- a/cloud_conductor_utils.gemspec +++ b/cloud_conductor_utils.gemspec @@ -24,6 +24,5 @@ spec.add_dependency "rest-client" spec.add_dependency "json" - spec.add_dependency "yaml" end
Fix gemspec to remove unnecessary dependency.
diff --git a/lib/kosmos/packages/enhanced_navball.rb b/lib/kosmos/packages/enhanced_navball.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/enhanced_navball.rb +++ b/lib/kosmos/packages/enhanced_navball.rb @@ -0,0 +1,8 @@+class EnhancedNavball < Kosmos::Package + title 'Enhanced Navball' + url 'http://kerb...
Add a package for Enhanced Navball.
diff --git a/lib/lobster.rb b/lib/lobster.rb index abc1234..def5678 100644 --- a/lib/lobster.rb +++ b/lib/lobster.rb @@ -1,12 +1,12 @@ module Lobster end -require 'lobster/version' +require_relative 'lobster/version' -require 'lobster/error_codes' -require 'lobster/error' -require 'lobster/result' -require 'lobste...
Use require_relative instead of require
diff --git a/lib/tasks/change_organisation_slug.rake b/lib/tasks/change_organisation_slug.rake index abc1234..def5678 100644 --- a/lib/tasks/change_organisation_slug.rake +++ b/lib/tasks/change_organisation_slug.rake @@ -0,0 +1,26 @@+desc "Change an organisation slug (DANGER!).\n + +This rake task changes an organisati...
Add rake task and usage notes.
diff --git a/lib/weather_reporter/console_printer.rb b/lib/weather_reporter/console_printer.rb index abc1234..def5678 100644 --- a/lib/weather_reporter/console_printer.rb +++ b/lib/weather_reporter/console_printer.rb @@ -1,11 +1,30 @@ module WeatherReporter + include OutputFormatter + class ConsolePrinter def ...
Print current weather condition gets weather codtion from weather_obj form the map weather condition to the relevent terminal icon
diff --git a/postgresql-connector.gemspec b/postgresql-connector.gemspec index abc1234..def5678 100644 --- a/postgresql-connector.gemspec +++ b/postgresql-connector.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'postgresql-connector' s.summary = 'PostgreSQL Connector for Sequel' - s.version = '0...
Package version is increased from 0.1.0.1 to 0.1.0.2
diff --git a/depend.rb b/depend.rb index abc1234..def5678 100644 --- a/depend.rb +++ b/depend.rb @@ -31,8 +31,12 @@ @gems = [] - weighted_results.sort {|(k1, v1), (k2, v2)| v2 <=> v1 }.first(50).each_with_index do |(k, v), i| - @gems << { name: k, count: v } + sorted_by_download_count = weighted_results.sort...
Clarify gem sorting logic by download count
diff --git a/tidings.gemspec b/tidings.gemspec index abc1234..def5678 100644 --- a/tidings.gemspec +++ b/tidings.gemspec @@ -13,11 +13,10 @@ spec.email = ['manfred@fngtpspec.com'] spec.extensions << 'ext/extconf.rb' - spec.files = Dir[ + spec.files = Dir.glob('{bin,lib,ext}/**/*') + [ 'README.rdoc', ...
Include ext and bin in the gemspec.
diff --git a/config/initializers/abingo.rb b/config/initializers/abingo.rb index abc1234..def5678 100644 --- a/config/initializers/abingo.rb +++ b/config/initializers/abingo.rb @@ -0,0 +1,8 @@+require 'abingo' +Abingo.cache = ActiveSupport::Cache::MemCacheStore.new('localhost', { :namespace => "wheelmap/#{Rails.env}/",...
Use memcache for Abingo caching.
diff --git a/config/initializers/resque.rb b/config/initializers/resque.rb index abc1234..def5678 100644 --- a/config/initializers/resque.rb +++ b/config/initializers/resque.rb @@ -1,2 +1,7 @@ Resque.redis.namespace = "resque:Cyclescape" Resque.inline = true if Rails.env.test? + +# This seems to be required so that pr...
Fix AR error in Resque workers.
diff --git a/Casks/iterm2-beta.rb b/Casks/iterm2-beta.rb index abc1234..def5678 100644 --- a/Casks/iterm2-beta.rb +++ b/Casks/iterm2-beta.rb @@ -1,12 +1,13 @@ cask :v1 => 'iterm2-beta' do - version '2.9.20150830' - sha256 '3248adc0281c03d5d367e042bcc373ae673bf5eea55fe181169e5824c8379e42' + version '2.9.20151001' + ...
Upgrade iTerm2 Beta to v2.9.20151001
diff --git a/providers/common.rb b/providers/common.rb index abc1234..def5678 100644 --- a/providers/common.rb +++ b/providers/common.rb @@ -24,17 +24,16 @@ # Install the application requirements. # If a requirements file has been specified, use pip. # otherwise use the setup.py - # FIXME: Should we use someth...
Replace bash resource with execute resource
diff --git a/app/views/results_table_view.rb b/app/views/results_table_view.rb index abc1234..def5678 100644 --- a/app/views/results_table_view.rb +++ b/app/views/results_table_view.rb @@ -3,24 +3,22 @@ NSColor.secondarySelectedControlColor end - def acceptsFirstResponder - false - end - def cont...
Make keyboard navigation in the result view work again.
diff --git a/trends.rb b/trends.rb index abc1234..def5678 100644 --- a/trends.rb +++ b/trends.rb @@ -13,10 +13,8 @@ trends << ["year","total paintings","topic paintings"] - -step = 1800 # Enter the year to begin (default to 1800, as this is when SAAM collections begin to get interesting) - ######### Check each yea...
Revert "Start step at 1800" This reverts commit acfecb6380864fc3df2c96409ee9ccd82e4a3765. Conflicts: trends.rb
diff --git a/qa/qa/support/waiter.rb b/qa/qa/support/waiter.rb index abc1234..def5678 100644 --- a/qa/qa/support/waiter.rb +++ b/qa/qa/support/waiter.rb @@ -3,9 +3,11 @@ module QA module Support module Waiter + DEFAULT_MAX_WAIT_TIME = 60 + module_function - def wait(max: 60, interval: 0.1) + ...
Make max wait time a constant So it can be used elsewhere in the code
diff --git a/Casks/colorpicker-skalacolor.rb b/Casks/colorpicker-skalacolor.rb index abc1234..def5678 100644 --- a/Casks/colorpicker-skalacolor.rb +++ b/Casks/colorpicker-skalacolor.rb @@ -1,7 +1,7 @@ class ColorpickerSkalacolor < Cask - url 'http://s3.amazonaws.com/bjango/files/skalacolor/skalacolor1.0.zip' + url 'h...
Update to use the latest version of Skala Color.
diff --git a/ContentfulManagementAPI.podspec b/ContentfulManagementAPI.podspec index abc1234..def5678 100644 --- a/ContentfulManagementAPI.podspec +++ b/ContentfulManagementAPI.podspec @@ -20,5 +20,5 @@ s.source_files = 'Pod/**/*.{h,m}' s.public_header_files = 'Pod/Headers/*.h' - s.dependency 'ContentfulDeliver...
Update required version of the CDA SDK
diff --git a/ruby-gem/crudecumber.gemspec b/ruby-gem/crudecumber.gemspec index abc1234..def5678 100644 --- a/ruby-gem/crudecumber.gemspec +++ b/ruby-gem/crudecumber.gemspec @@ -1,8 +1,8 @@ Gem::Specification.new do |s| s.name = 'crudecumber' - s.version = '0.3.0' + s.version = '0.3.1' s.date ...
Increment gem version to 0.3.1
diff --git a/db/migrate/20180402153329_educator_labels_foreign_key.rb b/db/migrate/20180402153329_educator_labels_foreign_key.rb index abc1234..def5678 100644 --- a/db/migrate/20180402153329_educator_labels_foreign_key.rb +++ b/db/migrate/20180402153329_educator_labels_foreign_key.rb @@ -0,0 +1,5 @@+class EducatorLabel...
Add migration for foreign key constraint
diff --git a/spec/bastet/base_spec.rb b/spec/bastet/base_spec.rb index abc1234..def5678 100644 --- a/spec/bastet/base_spec.rb +++ b/spec/bastet/base_spec.rb @@ -13,6 +13,23 @@ @bastet.activate(:banana, group) @bastet.active?(:banana, user).should be_true end + + describe "complex criteria" do + ...
Add test coverage for complex criteria in groups as well as the default behavior
diff --git a/spec/models/task_spec.rb b/spec/models/task_spec.rb index abc1234..def5678 100644 --- a/spec/models/task_spec.rb +++ b/spec/models/task_spec.rb @@ -3,7 +3,46 @@ RSpec.describe Task do let(:task) { build(:task) } + it { should belong_to(:story) } + it { should belong_to(:owner).class_name("User") } +...
Add more specs for Tasks
diff --git a/spec/centos/grub_spec.rb b/spec/centos/grub_spec.rb index abc1234..def5678 100644 --- a/spec/centos/grub_spec.rb +++ b/spec/centos/grub_spec.rb @@ -4,6 +4,7 @@ it { should be_file } it { should contain "tsc=reliable" } it { should contain "divider=10" } + it { should contain "GRUB_TIMEOUT=5" } end ...
Test to ensure 5 second grub timout. IMAGE-543
diff --git a/spec/models/post_spec.rb b/spec/models/post_spec.rb index abc1234..def5678 100644 --- a/spec/models/post_spec.rb +++ b/spec/models/post_spec.rb @@ -2,9 +2,34 @@ describe Post do + before(:each) do + @post = Post.create!(title: "test", body: "this is a test", author_id: 1) + end -#METHOD TESTS WI...
Add post model rspec tests
diff --git a/Library/Contributions/examples/brew-bottle.rb b/Library/Contributions/examples/brew-bottle.rb index abc1234..def5678 100644 --- a/Library/Contributions/examples/brew-bottle.rb +++ b/Library/Contributions/examples/brew-bottle.rb @@ -13,8 +13,8 @@ filename = formula + '-' + version + '.tar.gz' ohai "Bot...
Improve reasoning in brew bottle for using gzip.
diff --git a/lib/active_interaction/attr.rb b/lib/active_interaction/attr.rb index abc1234..def5678 100644 --- a/lib/active_interaction/attr.rb +++ b/lib/active_interaction/attr.rb @@ -5,7 +5,7 @@ raise NoMethodError unless ActiveInteraction.const_defined?(klass) - "ActiveInteraction::#{klass}".constanti...
Use const_get instead of constantize
diff --git a/lib/batch/helpers/date_time.rb b/lib/batch/helpers/date_time.rb index abc1234..def5678 100644 --- a/lib/batch/helpers/date_time.rb +++ b/lib/batch/helpers/date_time.rb @@ -0,0 +1,52 @@+ +class Batch + + module Helpers + + # Methods for displaying times/durations + module DateTime + + ...
Add helper for displaying timestamps and durations
diff --git a/lib/ionic_notification/status_service.rb b/lib/ionic_notification/status_service.rb index abc1234..def5678 100644 --- a/lib/ionic_notification/status_service.rb +++ b/lib/ionic_notification/status_service.rb @@ -26,7 +26,7 @@ private def headers - { 'Content-Type' => 'application/json', 'Au...
Update status check to use new Ionic header Fixes "Authorization header is malformed; JWT could not be extracted."
diff --git a/lib/action_cable/channel/redis.rb b/lib/action_cable/channel/redis.rb index abc1234..def5678 100644 --- a/lib/action_cable/channel/redis.rb +++ b/lib/action_cable/channel/redis.rb @@ -9,9 +9,10 @@ end def subscribe_to(redis_channel, callback = nil) - @_redis_channels ||= [] + r...
Raise an exception when Server.pubsub class method is not defined
diff --git a/server/config/application.rb b/server/config/application.rb index abc1234..def5678 100644 --- a/server/config/application.rb +++ b/server/config/application.rb @@ -29,8 +29,5 @@ # Do not swallow errors in after_commit/after_rollback callbacks. config.active_record.raise_in_transactional_callback...
Disable session store and reenable api_only now that Omniauth is gone
diff --git a/test/minitest_helper.rb b/test/minitest_helper.rb index abc1234..def5678 100644 --- a/test/minitest_helper.rb +++ b/test/minitest_helper.rb @@ -1,7 +1,7 @@+require 'coveralls' +Coveralls.wear! + $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) require 'rubic' require 'minitest/autorun' -requ...
Fix position of activating coveralls
diff --git a/server.rb b/server.rb index abc1234..def5678 100644 --- a/server.rb +++ b/server.rb @@ -1,5 +1,8 @@ require "sinatra" require "twilio-ruby" + +# Allows this app to be embedded in an iframe. Feel free to remove it. +set :protection, :except => :frame_options get "/" do capability = Twilio::Util::Capa...
Allow to embed this app in an iframe
diff --git a/morandi.gemspec b/morandi.gemspec index abc1234..def5678 100644 --- a/morandi.gemspec +++ b/morandi.gemspec @@ -19,7 +19,7 @@ spec.require_paths = ["lib"] spec.add_dependency "gtk2" - spec.add_dependency "gdk_pixbuf2" + spec.add_dependency "gdk_pixbuf2", "~> 3.4.0" spec.add_dependency "cairo" ...
Add dependency on gdk_pixbuff2 ~> 3.4.0
diff --git a/capitomcat.gemspec b/capitomcat.gemspec index abc1234..def5678 100644 --- a/capitomcat.gemspec +++ b/capitomcat.gemspec @@ -13,7 +13,7 @@ s.authors = ['Sunggun Yu'] s.email = ['sunggun.dev@gmail.com'] s.licenses = ['Apache 2.0'] - s.date = %q{2014-01-11} + s.date = %q{2...
Update Capistrano dependency to v3.1.0
diff --git a/test/angular_rails_csrf_test.rb b/test/angular_rails_csrf_test.rb index abc1234..def5678 100644 --- a/test/angular_rails_csrf_test.rb +++ b/test/angular_rails_csrf_test.rb @@ -3,14 +3,9 @@ class AngularRailsCsrfTest < ActionController::TestCase tests ApplicationController - setup do - @controller....
Fix tests for Rails 4.2
diff --git a/onkcop.gemspec b/onkcop.gemspec index abc1234..def5678 100644 --- a/onkcop.gemspec +++ b/onkcop.gemspec @@ -19,8 +19,8 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_dependency "rubocop", "~> 0.50.0" - spec.add_dependency "ruboco...
Update rubocop v0.51.0 and rubocop-rspec v1.19.0
diff --git a/lib/active_admin/sortable/engine.rb b/lib/active_admin/sortable/engine.rb index abc1234..def5678 100644 --- a/lib/active_admin/sortable/engine.rb +++ b/lib/active_admin/sortable/engine.rb @@ -5,7 +5,7 @@ class Engine < ::Rails::Engine engine_name 'activeadmin_sortable_tree' - initializer ...
Fix assets precompile with config.assets.initialize_on_precompile = true
diff --git a/lib/delayed/serialization/sequel.rb b/lib/delayed/serialization/sequel.rb index abc1234..def5678 100644 --- a/lib/delayed/serialization/sequel.rb +++ b/lib/delayed/serialization/sequel.rb @@ -33,7 +33,7 @@ def init_with(coder) @values = coder["values"] reload - ...
Use fully qualified name when rescuing Sequel::Error
diff --git a/core/range/clone_spec.rb b/core/range/clone_spec.rb index abc1234..def5678 100644 --- a/core/range/clone_spec.rb +++ b/core/range/clone_spec.rb @@ -7,14 +7,14 @@ copy.begin.should == 1 copy.end.should == 3 copy.should_not.exclude_end? - copy.object_id.should_not == original.object_id + ...
Use .should_not.equal? instead of comparing object_id
diff --git a/lib/thinking_sphinx/active_record/sql_source/template.rb b/lib/thinking_sphinx/active_record/sql_source/template.rb index abc1234..def5678 100644 --- a/lib/thinking_sphinx/active_record/sql_source/template.rb +++ b/lib/thinking_sphinx/active_record/sql_source/template.rb @@ -48,6 +48,6 @@ end def pr...
Use more general specification of primary key rather than model's primary key.
diff --git a/lib/georgia.rb b/lib/georgia.rb index abc1234..def5678 100644 --- a/lib/georgia.rb +++ b/lib/georgia.rb @@ -24,6 +24,9 @@ mattr_accessor :permissions @@permissions = Georgia::Permissions::DEFAULT_PERMISSIONS + mattr_accessor :roles + @@roles = %w(admin editor contributor guest) + def self.setup...
Add Georgia.roles with default roles
diff --git a/lib/migrate.rb b/lib/migrate.rb index abc1234..def5678 100644 --- a/lib/migrate.rb +++ b/lib/migrate.rb @@ -12,7 +12,7 @@ t.text :error_backtrace t.string :employee_host - t.string :employee_pid + t.integer :employee_pid t.timestamps end
Store employee_pid as an Integer
diff --git a/lib/api_recipes/settings.rb b/lib/api_recipes/settings.rb index abc1234..def5678 100644 --- a/lib/api_recipes/settings.rb +++ b/lib/api_recipes/settings.rb @@ -15,8 +15,7 @@ } DEFAULT_ROUTE_ATTRIBUTES = { - method: :get, - encode_params_as: :json + method: :get } AVAIL...
Fix stupid bug setting json as default params encoding method
diff --git a/config/initializers/omni_auth.rb b/config/initializers/omni_auth.rb index abc1234..def5678 100644 --- a/config/initializers/omni_auth.rb +++ b/config/initializers/omni_auth.rb @@ -4,4 +4,3 @@ require "openid/fetchers" OpenID.fetcher.ca_file = "/etc/ssl/certs/ca-certificates.crt" -OmniAuth.config.full_ho...
Revert "try forcing omniauth return url" This reverts commit 7590e0481b65ab4acb4a588315627fe272016098.
diff --git a/config/initializers/recaptcha.rb b/config/initializers/recaptcha.rb index abc1234..def5678 100644 --- a/config/initializers/recaptcha.rb +++ b/config/initializers/recaptcha.rb @@ -0,0 +1,6 @@+Recaptcha.configuration.hostname = ->(hostname) do + ( + Rails.application.config.action_mailer.default_url_opt...
Add server-side reCAPTCHA hostname validation based on known convention domains + default host
diff --git a/config/initializers/slack_api.rb b/config/initializers/slack_api.rb index abc1234..def5678 100644 --- a/config/initializers/slack_api.rb +++ b/config/initializers/slack_api.rb @@ -7,11 +7,11 @@ client = Slack.realtime client.on :team_join do |data| - puts 'New User Joined' + puts "New User, #{data['us...
Add descriptive console messages for join events
diff --git a/groonga/init.rb b/groonga/init.rb index abc1234..def5678 100644 --- a/groonga/init.rb +++ b/groonga/init.rb @@ -3,13 +3,12 @@ require "feedcellar" resources = YAML.load_file("resources.yaml") +puts "Resources: #{resources}" command = Feedcellar::Command.new -resources.each do |resource| - puts "Re...
Reduce number of opening database
diff --git a/lib/takosan.rb b/lib/takosan.rb index abc1234..def5678 100644 --- a/lib/takosan.rb +++ b/lib/takosan.rb @@ -36,6 +36,11 @@ end def logger - @@_logger ||= Rails.logger + @@_logger ||= + if defined?(Rails.logger) + Rails.logger + else + Logger.new($stderr) + end e...
Write logs to stderr if used in non-Rails application
diff --git a/lib/pavlov/alpha_compatibility.rb b/lib/pavlov/alpha_compatibility.rb index abc1234..def5678 100644 --- a/lib/pavlov/alpha_compatibility.rb +++ b/lib/pavlov/alpha_compatibility.rb @@ -37,7 +37,7 @@ end # Add attribute for pavlov_options - attribute :pavlov_options, Hash + a...
Set default value for pavlov_options
diff --git a/lib/pipedrive_api/organization.rb b/lib/pipedrive_api/organization.rb index abc1234..def5678 100644 --- a/lib/pipedrive_api/organization.rb +++ b/lib/pipedrive_api/organization.rb @@ -3,7 +3,10 @@ class << self - + def deals(id, **params) + response = get "#{resource_path}/#{id}/deals",...
Add deals method to Organization
diff --git a/lib/special_route_publisher.rb b/lib/special_route_publisher.rb index abc1234..def5678 100644 --- a/lib/special_route_publisher.rb +++ b/lib/special_route_publisher.rb @@ -24,7 +24,7 @@ def self.routes { - prefix: [ + exact: [ { document_type: "answer", con...
Change /eubusiness to an exact route [We're getting errors](https://sentry.io/organizations/govuk/issues/1884114207/?environment=production&project=202213&referrer=slack) because router is sending sub paths of /eubusiness to collections. We only have the /eubusiness page right now, so an exact route is the way to go. ...
diff --git a/robot_name/robot_name.rb b/robot_name/robot_name.rb index abc1234..def5678 100644 --- a/robot_name/robot_name.rb +++ b/robot_name/robot_name.rb @@ -47,6 +47,17 @@ puts "My pet robot's name is #{robot.name}, but we usually call him sparky." # Errors! -# generator = -> { 'AA111' } -# Robot.new(name_genera...
Check both errors at once using begin/end This is a bit smelly because this code really belongs in a test instead of at the bottom of the file. However, I want to focus more on the main class itself right now and not so much creating a test. How dare that be typed from my fingers!!!
diff --git a/app/controllers/api/atomic_docs_controller.rb b/app/controllers/api/atomic_docs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/atomic_docs_controller.rb +++ b/app/controllers/api/atomic_docs_controller.rb @@ -5,11 +5,12 @@ before_action :validate_api_key, only: %i[documents session...
Add AtomicDoc to the controller
diff --git a/spec/adapter/faraday_spec.rb b/spec/adapter/faraday_spec.rb index abc1234..def5678 100644 --- a/spec/adapter/faraday_spec.rb +++ b/spec/adapter/faraday_spec.rb @@ -3,7 +3,7 @@ describe Faraday::Adapter::RackClient do - let(:url) { URI.join(@base_url, '/faraday') } + let(:url) { @base_url } let(:...
Switch the Faraday specs to use the faraday test app directly.
diff --git a/spec/unit/rom/global_spec.rb b/spec/unit/rom/global_spec.rb index abc1234..def5678 100644 --- a/spec/unit/rom/global_spec.rb +++ b/spec/unit/rom/global_spec.rb @@ -2,8 +2,8 @@ describe ROM do describe '.setup' do - it 'allows passing in repository instances' do - klass = Class.new(ROM::Reposit...
Remove Repository reference in spec
diff --git a/lib/ruboty/dmm/actions/messenger.rb b/lib/ruboty/dmm/actions/messenger.rb index abc1234..def5678 100644 --- a/lib/ruboty/dmm/actions/messenger.rb +++ b/lib/ruboty/dmm/actions/messenger.rb @@ -5,7 +5,7 @@ def call attachments = Ruboty::DMM::Ranking.new(submedia: message.match_data[:submed...
Remove 'Today's' in the action
diff --git a/Casks/air-video-server.rb b/Casks/air-video-server.rb index abc1234..def5678 100644 --- a/Casks/air-video-server.rb +++ b/Casks/air-video-server.rb @@ -2,9 +2,11 @@ version '2.4.6-beta3u2' sha256 '479af913987a4cc8414969a8d4a4c164a4bd0a22d156829a983b4c58e9dd3f6e' + # amazonaws.com is the official do...
AirVideoServer: Update license, add name stanza
diff --git a/typeahead-rails.gemspec b/typeahead-rails.gemspec index abc1234..def5678 100644 --- a/typeahead-rails.gemspec +++ b/typeahead-rails.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |spec| spec.name = 'typeahead-rails' spec.version = Typeahead::Rails::VERSION - spec.authors = ['...
Add author and contact for this gem
diff --git a/Casks/thunderbird-beta.rb b/Casks/thunderbird-beta.rb index abc1234..def5678 100644 --- a/Casks/thunderbird-beta.rb +++ b/Casks/thunderbird-beta.rb @@ -1,8 +1,8 @@ class ThunderbirdBeta < Cask - version '32.0b1' - sha256 '0f66e9cb452293e248d92c9a156c0b81c50e81ba1107922ab6f8b555934e83d3' + version '33.0b...
Update Thunderbird Beta to 33.0b1
diff --git a/app/controllers/admin/article_categories_controller.rb b/app/controllers/admin/article_categories_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/article_categories_controller.rb +++ b/app/controllers/admin/article_categories_controller.rb @@ -35,7 +35,7 @@ if @article_categor...
Fix article category edit redirect.
diff --git a/app/controllers/second_level_browse_page_controller.rb b/app/controllers/second_level_browse_page_controller.rb index abc1234..def5678 100644 --- a/app/controllers/second_level_browse_page_controller.rb +++ b/app/controllers/second_level_browse_page_controller.rb @@ -33,7 +33,7 @@ end def page - ...
Reduce content store requests for 2nd level browse This reduces the number of content store requests made to render an HTML page in second level browse from 3 to 1, and for a json response from 4 to 1. Example URL: https://www.gov.uk/browse/births-deaths-marriages/death
diff --git a/app/services/organisational_manual_service_registry.rb b/app/services/organisational_manual_service_registry.rb index abc1234..def5678 100644 --- a/app/services/organisational_manual_service_registry.rb +++ b/app/services/organisational_manual_service_registry.rb @@ -1,6 +1,6 @@ class OrganisationalManualS...
Use Ruby keyword args in OrganisationalManualServiceRegistry I think that using language features instead of custom code makes this easier to understand.
diff --git a/lib/pwwka/error_handlers.rb b/lib/pwwka/error_handlers.rb index abc1234..def5678 100644 --- a/lib/pwwka/error_handlers.rb +++ b/lib/pwwka/error_handlers.rb @@ -1,3 +1,8 @@+module Pwwka + module ErrorHandlers + end +end + require_relative "error_handlers/chain" require_relative "error_handlers/base_erro...
Define Pwwka::ErrorHandlers module to make it requirable
diff --git a/app/helpers/georgia/internationalization_helper.rb b/app/helpers/georgia/internationalization_helper.rb index abc1234..def5678 100644 --- a/app/helpers/georgia/internationalization_helper.rb +++ b/app/helpers/georgia/internationalization_helper.rb @@ -1,7 +1,7 @@ # encoding: UTF-8 module Georgia module...
Add option sanitize to link_to_locale
diff --git a/lib/quick_travel/payment.rb b/lib/quick_travel/payment.rb index abc1234..def5678 100644 --- a/lib/quick_travel/payment.rb +++ b/lib/quick_travel/payment.rb @@ -5,10 +5,6 @@ class Payment < Adapter def payment_type QuickTravel::PaymentType.find(@payment_type_id) - end - - def self.create...
Remove unused method (URL doesnt exist in QT) Was used by CC-CMS a while ago
diff --git a/web.rb b/web.rb index abc1234..def5678 100644 --- a/web.rb +++ b/web.rb @@ -5,5 +5,9 @@ end post '/' do - puts request.body + request.body.rewind + request_payload = JSON.parse request.body.read + + #do something with request_payload + puts "Text from groupme: "request_payload['text'] end
Add in puts for groupme text
diff --git a/lib/signal_api/short_url.rb b/lib/signal_api/short_url.rb index abc1234..def5678 100644 --- a/lib/signal_api/short_url.rb +++ b/lib/signal_api/short_url.rb @@ -19,7 +19,8 @@ response = post('/api/short_urls.xml', :body => body, - :headers => {'api_token' ...
Use the :format option to specify the format
diff --git a/lib/smart_api/controller.rb b/lib/smart_api/controller.rb index abc1234..def5678 100644 --- a/lib/smart_api/controller.rb +++ b/lib/smart_api/controller.rb @@ -2,17 +2,21 @@ module Controller extend ActiveSupport::Concern + include AbstractController::Callbacks include ActionController::Co...
Add common modules and allow view rendering
diff --git a/hideable.gemspec b/hideable.gemspec index abc1234..def5678 100644 --- a/hideable.gemspec +++ b/hideable.gemspec @@ -7,7 +7,7 @@ s.platform = Gem::Platform::RUBY s.authors = ['Joe Corcoran'] s.email = ['joecorcoran@gmail.com'] - s.homepage = 'http://github.com/joecorcoran/judge' + ...
Remove bad homepage ref in gemspec
diff --git a/lib/hairballs.rb b/lib/hairballs.rb index abc1234..def5678 100644 --- a/lib/hairballs.rb +++ b/lib/hairballs.rb @@ -1,8 +1,10 @@ require_relative 'hairballs/version' +require_relative 'hairballs/helpers' require_relative 'hairballs/theme' +class Hairballs + extend Helpers -class Hairballs def self...
Use helpers in base class
diff --git a/lib/intrinsic.rb b/lib/intrinsic.rb index abc1234..def5678 100644 --- a/lib/intrinsic.rb +++ b/lib/intrinsic.rb @@ -12,6 +12,7 @@ def initialize(values = {}) @properties = {}.merge self.class.defaults check_properties_of values + values.each { |property, value| send property.to_sym, value } ...
Set each key value as property and value
diff --git a/lib/pig_latin.rb b/lib/pig_latin.rb index abc1234..def5678 100644 --- a/lib/pig_latin.rb +++ b/lib/pig_latin.rb @@ -3,9 +3,10 @@ module PigLatin def PigLatin.translate(text) + if text.nil? then return "Translation will appear here." end pig_arr = text.split(" ") pig_trans_arr = [] - ...
Fix nil logic to exit method
diff --git a/lib/transproc.rb b/lib/transproc.rb index abc1234..def5678 100644 --- a/lib/transproc.rb +++ b/lib/transproc.rb @@ -3,23 +3,25 @@ require 'transproc/composer' module Transproc - def self.register(*args, &block) + module_function + + def register(*args, &block) name, fn = *args functions[nam...
Use module_function in Transproc module
diff --git a/lib/tasks/load_legacy_mappings.rake b/lib/tasks/load_legacy_mappings.rake index abc1234..def5678 100644 --- a/lib/tasks/load_legacy_mappings.rake +++ b/lib/tasks/load_legacy_mappings.rake @@ -13,18 +13,15 @@ begin topic_taxon_id = api.lookup_content_id(base_path: topic_taxon) raise "Looku...
Replace optimistic locking or legacy taxon with specific patch. The patch API for links allows you to specify the specific link set to patch. As the legacy_taxon links are new, there's no possibility of overwriting previous versions.
diff --git a/lib/travis/sidekiq/build_request.rb b/lib/travis/sidekiq/build_request.rb index abc1234..def5678 100644 --- a/lib/travis/sidekiq/build_request.rb +++ b/lib/travis/sidekiq/build_request.rb @@ -21,7 +21,7 @@ def service raise(ProcessingError, "the #{type} payload was empty and could not be p...
Use the service force, Luke!
diff --git a/rspec-image.gemspec b/rspec-image.gemspec index abc1234..def5678 100644 --- a/rspec-image.gemspec +++ b/rspec-image.gemspec @@ -18,9 +18,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_dependency "rmagick" - spec.add_dependency "rspec" ...
Use add_runtime_dependency instead of add_dependency
diff --git a/lib/dimples.rb b/lib/dimples.rb index abc1234..def5678 100644 --- a/lib/dimples.rb +++ b/lib/dimples.rb @@ -12,7 +12,6 @@ require 'dimples/logger' require 'dimples/frontable' -require 'dimples/writeable' require 'dimples/renderable' require 'dimples/category'
Remove the writeable require statement.
diff --git a/config/initializers/simple_form_foundation.rb b/config/initializers/simple_form_foundation.rb index abc1234..def5678 100644 --- a/config/initializers/simple_form_foundation.rb +++ b/config/initializers/simple_form_foundation.rb @@ -8,7 +8,7 @@ b.optional :min_max b.optional :readonly b.use :l...
Configure simple_form to use error class for inputs with error
diff --git a/lib/handler.rb b/lib/handler.rb index abc1234..def5678 100644 --- a/lib/handler.rb +++ b/lib/handler.rb @@ -6,7 +6,6 @@ def self.included(base) base.extend ClassMethods end - module ClassMethods @@ -25,15 +24,16 @@ # Generate a URL-friendly name. # define_method :ge...
Clean up generate_handle implementation and attempt to transliterate.
diff --git a/rummageable.gemspec b/rummageable.gemspec index abc1234..def5678 100644 --- a/rummageable.gemspec +++ b/rummageable.gemspec @@ -13,11 +13,11 @@ s.require_paths = ["lib"] s.summary = "Mediator for apps that want their content to be in the search index" s.test_files = Dir["test/**/*_test.rb"] - s.ad...
Make yajl-ruby just a development_dependency
diff --git a/db/migrate/20190522180629_add_raw_contents.rb b/db/migrate/20190522180629_add_raw_contents.rb index abc1234..def5678 100644 --- a/db/migrate/20190522180629_add_raw_contents.rb +++ b/db/migrate/20190522180629_add_raw_contents.rb @@ -14,15 +14,8 @@ # Apply HTML cleansing / munging to existing content...
Use most recent HTMLUtils for all contents in migration The older HTMLUtils versions were proving to be problematic in the way they handled HTML, which is why we iterated on and replaced them, but utilizing them here in order to preserve quirks on which annotations might be dependent is bring with it bigger problems.
diff --git a/config/initializers/sidekiq.rb b/config/initializers/sidekiq.rb index abc1234..def5678 100644 --- a/config/initializers/sidekiq.rb +++ b/config/initializers/sidekiq.rb @@ -1,13 +1,11 @@ Sidekiq.configure_server do |config| config.redis = { - url: ENV['REDIS_PROVIDER'], namespace: "tahi_#{Rails.e...
Remove `url` key from Sidekiq configuration This way, Sidekiq uses its own conventions to work it out.
diff --git a/plugins/ssh/check-ssh.rb b/plugins/ssh/check-ssh.rb index abc1234..def5678 100644 --- a/plugins/ssh/check-ssh.rb +++ b/plugins/ssh/check-ssh.rb @@ -0,0 +1,56 @@+#! /usr/bin/env ruby +# +# check-ssh +# +# DESCRIPTION: +# Check the status and version of SSH +# +# OUTPUT: +# plain-text +# +# PLATFORMS: +#...
Add new check for ssh
diff --git a/app/controllers/api/timeslots_controller.rb b/app/controllers/api/timeslots_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/timeslots_controller.rb +++ b/app/controllers/api/timeslots_controller.rb @@ -13,9 +13,11 @@ end def update - @timeslot = Timeslot.find_by(id: safe_par...
Add Damian's scheduling_email back into api timeslots controller
diff --git a/app/controllers/registrations_controller.rb b/app/controllers/registrations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/registrations_controller.rb +++ b/app/controllers/registrations_controller.rb @@ -21,4 +21,8 @@ def after_inactive_sign_up_path_for(resource) registration_not...
Update Devise Registrations Update Redirect Update the Devise Registrations controller 'update' action to redirect to the User registration edit path on successful update so that the User is not redirected away from the current page they are viewing.
diff --git a/app/controllers/registrations_controller.rb b/app/controllers/registrations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/registrations_controller.rb +++ b/app/controllers/registrations_controller.rb @@ -3,14 +3,14 @@ def new # Building the resource with information that MAY B...
Fix bug with sign_up on registration controller
diff --git a/app/controllers/user_sessions_controller.rb b/app/controllers/user_sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/user_sessions_controller.rb +++ b/app/controllers/user_sessions_controller.rb @@ -5,7 +5,7 @@ end def create - @user_session = UserSession.new(params[:user...
Use strong parameters. Required for Authlogic.
diff --git a/app/decorators/billing/account_decorator.rb b/app/decorators/billing/account_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/billing/account_decorator.rb +++ b/app/decorators/billing/account_decorator.rb @@ -15,7 +15,7 @@ def credit_limit_or_none if credit_limit? num = h...
Fix bug with account page
diff --git a/lib/riemann.rb b/lib/riemann.rb index abc1234..def5678 100644 --- a/lib/riemann.rb +++ b/lib/riemann.rb @@ -1,8 +1,6 @@ # frozen_string_literal: true module Riemann - $LOAD_PATH.unshift __dir__ - require 'rubygems' require 'beefcake' require 'timeout' @@ -12,5 +10,4 @@ require 'riemann/event...
Fix warning: circular require considered harmful Running the riemann-tools test suite emit this warning: lib/riemann.rb:15: warning: lib/riemann.rb:15: warning: loading in progress, circular require considered harmful - lib/riemann/client.rb The README.md says one should require 'riemann/client', so let 'riemann/clie...
diff --git a/lib/ui.rb b/lib/ui.rb index abc1234..def5678 100644 --- a/lib/ui.rb +++ b/lib/ui.rb @@ -23,8 +23,8 @@ io.get_user_input end - def display_winner_message(game_being_played) - io.display_winner_message(game_being_played) + def display_winner_message(rules, game_being_played) + io.display_win...
Add correct paramters so test will pass