diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/config/initializers/rubydora_monkey_patch.rb b/config/initializers/rubydora_monkey_patch.rb index abc1234..def5678 100644 --- a/config/initializers/rubydora_monkey_patch.rb +++ b/config/initializers/rubydora_monkey_patch.rb @@ -0,0 +1,11 @@+module Rubydora + class Datastream + def entity_size(response)...
Patch Rubydora to deal with external datastream content.
diff --git a/spec/controllers/api/users/verification_spec.rb b/spec/controllers/api/users/verification_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/api/users/verification_spec.rb +++ b/spec/controllers/api/users/verification_spec.rb @@ -9,8 +9,8 @@ expect(user.verified_at).to eq(nil) put :v...
Update tests to reflect changes to user verification
diff --git a/Dip.podspec b/Dip.podspec index abc1234..def5678 100644 --- a/Dip.podspec +++ b/Dip.podspec @@ -19,7 +19,7 @@ s.homepage = "https://github.com/AliSoftware/Dip" s.license = 'MIT' - s.author = { "Olivier Halligon" => "olivier@halligon.net" } + s.authors = { "Olivi...
Add @ilyapuchka as author in the Podspec
diff --git a/lib/yard.rb b/lib/yard.rb index abc1234..def5678 100644 --- a/lib/yard.rb +++ b/lib/yard.rb @@ -1,4 +1,7 @@-$LOAD_PATH.unshift File.join(File.dirname(__FILE__), 'yard') +YARD_ROOT = File.join(File.dirname(__FILE__), 'yard') +YARD_TEMPLATE_ROOT = File.join(File.dirname(__FILE__), '..', 'templates') + +$LOAD...
Add YARD_ROOT and YARD_TEMPLATE_ROOT constants for later
diff --git a/lib/scss_lint/linter/placeholder_in_extend.rb b/lib/scss_lint/linter/placeholder_in_extend.rb index abc1234..def5678 100644 --- a/lib/scss_lint/linter/placeholder_in_extend.rb +++ b/lib/scss_lint/linter/placeholder_in_extend.rb @@ -8,11 +8,10 @@ # every word boundary (so %placeholder becomes ['%', 'p...
Remove description method from PlaceholderInExtend The `description` method is being deprecated. Change-Id: I755e28a599f1cccdd38dafec1bf549e3f6b7e664 Reviewed-on: http://gerrit.causes.com/36723 Tested-by: jenkins <d95b56ce41a2e1ac4cecdd398defd7414407cc08@causes.com> Reviewed-by: Shane da Silva <6f6e68d1df92f30cb4b3ce...
diff --git a/lib/cardgate/gateway.rb b/lib/cardgate/gateway.rb index abc1234..def5678 100644 --- a/lib/cardgate/gateway.rb +++ b/lib/cardgate/gateway.rb @@ -13,7 +13,7 @@ end def self.is_test_environment? - environment.to_sym == :test + self.environment == :test end def self.request_url...
Use attribute accessor for checking for test environment
diff --git a/lib/cloudkit/command.rb b/lib/cloudkit/command.rb index abc1234..def5678 100644 --- a/lib/cloudkit/command.rb +++ b/lib/cloudkit/command.rb @@ -23,6 +23,12 @@ end def run_app + unless File.exist?('.bundle') + Formatador.display_line("[yellow][bold]No gem bundle found.[/]") + F...
Add naive bundler support to app runner
diff --git a/lib/dry/types/result.rb b/lib/dry/types/result.rb index abc1234..def5678 100644 --- a/lib/dry/types/result.rb +++ b/lib/dry/types/result.rb @@ -1,7 +1,17 @@+require 'dry/equalizer' + module Dry module Types - module Result - class Success < ::Struct.new(:input) + class Result + include ...
Refactor Result to use a custom base class (stdlib Struct is SLOW)
diff --git a/lib/haml_lint/logger.rb b/lib/haml_lint/logger.rb index abc1234..def5678 100644 --- a/lib/haml_lint/logger.rb +++ b/lib/haml_lint/logger.rb @@ -0,0 +1,99 @@+module HamlLint + # Encapsulates all communication to an output source. + class Logger + # Whether colored output via ANSI escape sequences is en...
Remove unnecessary documentation for void return values These aren't necessary when the return value isn't intended to be used.
diff --git a/spec/unit/aequitas/class_methods/inherited_spec.rb b/spec/unit/aequitas/class_methods/inherited_spec.rb index abc1234..def5678 100644 --- a/spec/unit/aequitas/class_methods/inherited_spec.rb +++ b/spec/unit/aequitas/class_methods/inherited_spec.rb @@ -0,0 +1,28 @@+require_relative '../../../spec_helper' +r...
Add spec coverage for class inheritance propagating rules. This occurs at inheritance time, so descendants do not automatically receive rules declared in ancestors after inheritance occurs. Related to #2 and #3.
diff --git a/lib/kanaveral/output.rb b/lib/kanaveral/output.rb index abc1234..def5678 100644 --- a/lib/kanaveral/output.rb +++ b/lib/kanaveral/output.rb @@ -11,7 +11,6 @@ def self.cmd_output text text ||= '' cr - text = ' '.freeze + text print Rainbow(text).cyan cr end
Remove leading space of command stdout
diff --git a/app/models/notification.rb b/app/models/notification.rb index abc1234..def5678 100644 --- a/app/models/notification.rb +++ b/app/models/notification.rb @@ -2,7 +2,6 @@ def generate - latestNotification = Notification.last(1).first require 'open-uri' require 'twilio-ruby' ...
Fix the issue with reordeing RSS items
diff --git a/app/models/professional.rb b/app/models/professional.rb index abc1234..def5678 100644 --- a/app/models/professional.rb +++ b/app/models/professional.rb @@ -5,5 +5,9 @@ has_many :students, :through => :mentorships has_many :mentorships - attr_accessible :email, :name, :phone_number + attr_accessibl...
Add validations and nested attributes writer
diff --git a/ci_environment/haskell/attributes/multi.rb b/ci_environment/haskell/attributes/multi.rb index abc1234..def5678 100644 --- a/ci_environment/haskell/attributes/multi.rb +++ b/ci_environment/haskell/attributes/multi.rb @@ -1,4 +1,4 @@ default[:haskell][:multi] = { - :ghcs => ["7.8.3","7.6.3","7.4.2","7.0.4"]...
Move from 7.8.3 to 7.8.4 version of ghc
diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/application_controller_spec.rb +++ b/spec/controllers/application_controller_spec.rb @@ -0,0 +1,35 @@+require 'rails_helper' + +describe ApplicationControll...
Create application controller spec, add tests for new authentication methods
diff --git a/rspec-pdf_diff.gemspec b/rspec-pdf_diff.gemspec index abc1234..def5678 100644 --- a/rspec-pdf_diff.gemspec +++ b/rspec-pdf_diff.gemspec @@ -20,7 +20,6 @@ spec.add_dependency "cocaine", "~> 0.5" - spec.add_development_dependency "bundler", "~> 1.7" spec.add_development_dependency "prawn", "~> 1.3....
Stop depending on bundler for development Not sure that's a common practice? It was way outdated anyway.
diff --git a/spec/versioneye/crawlers/github_crawler_spec.rb b/spec/versioneye/crawlers/github_crawler_spec.rb index abc1234..def5678 100644 --- a/spec/versioneye/crawlers/github_crawler_spec.rb +++ b/spec/versioneye/crawlers/github_crawler_spec.rb @@ -0,0 +1,23 @@+require 'spec_helper' + +describe GithubCrawler do + +...
Add test for github crawler.
diff --git a/app/services/activation.rb b/app/services/activation.rb index abc1234..def5678 100644 --- a/app/services/activation.rb +++ b/app/services/activation.rb @@ -12,12 +12,12 @@ end def self.user_activates_device( user, activation_token ) - raise 'Invalid user specified' if user.blank? + raise 'Inva...
Allow devices to be reactivated on the same account.
diff --git a/podspec/1.0.2/OBShapedButton.podspec b/podspec/1.0.2/OBShapedButton.podspec index abc1234..def5678 100644 --- a/podspec/1.0.2/OBShapedButton.podspec +++ b/podspec/1.0.2/OBShapedButton.podspec @@ -0,0 +1,13 @@+Pod::Spec.new do |s| + s.name = 'OBShapedButton' + s.version = '1.0.2' + s.license = 'MIT...
Add CocoaPods podspec for v1.0.2
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -8,10 +8,10 @@ supports "ubuntu" -depends "python" -depends "apache2" +depends "python" +depends "apache2" +depends "runit" -suggests "runit" suggests "systemd" suggests "s6" suggests "graphiti"
Make runit a dependency since out of the box it's needed
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -1,3 +1,4 @@+name "minitest-handler" maintainer "Bryan Berry" maintainer_email "bryan.berry@gmail.com" license "Apache 2.0"
Add explicit name to cookbook Better than relying on cookbook directory and plays better with Berkshelf.
diff --git a/spec/models/vote_spec.rb b/spec/models/vote_spec.rb index abc1234..def5678 100644 --- a/spec/models/vote_spec.rb +++ b/spec/models/vote_spec.rb @@ -13,7 +13,16 @@ end end + describe "validations" do + describe "requireds" do + it { should validate_presence_of(:direction) } + end + + ...
Add validations spec to Vote
diff --git a/spec/unit/mutant_spec.rb b/spec/unit/mutant_spec.rb index abc1234..def5678 100644 --- a/spec/unit/mutant_spec.rb +++ b/spec/unit/mutant_spec.rb @@ -1,9 +1,18 @@ require 'spec_helper' describe Mutant do + let(:object) { described_class } + + describe '.zombify' do + subject { object.zombify } + + ...
Add minimal specs for Mutant.zombify
diff --git a/spec/custom_matchers.rb b/spec/custom_matchers.rb index abc1234..def5678 100644 --- a/spec/custom_matchers.rb +++ b/spec/custom_matchers.rb @@ -5,3 +5,9 @@ actual == expected end end + +RSpec::Matchers.define :have_format do |expected| + match do |actual| + actual.format == expected + end +end...
Add custom rspec matcher have_format
diff --git a/script/cruise_build.rb b/script/cruise_build.rb index abc1234..def5678 100644 --- a/script/cruise_build.rb +++ b/script/cruise_build.rb @@ -1,3 +1,14 @@ #!/usr/bin/env ruby -p "My project name is: #{ARGV.inspect}" +project_name = ARGV.first + +case project_name +when "racing_on_rails" + # Nothing else t...
Add ATRA in as a test git-svn-id: 96bd6241e080dd4199045f7177cf3384e2eaed71@1422 2d86388d-c40f-0410-ad6a-a69da6a65d20
diff --git a/nested_sortable-rails.gemspec b/nested_sortable-rails.gemspec index abc1234..def5678 100644 --- a/nested_sortable-rails.gemspec +++ b/nested_sortable-rails.gemspec @@ -7,11 +7,11 @@ Gem::Specification.new do |s| s.name = "nested_sortable-rails" s.version = NestedSortableRails::VERSION - s...
Add gem description and author details to gemspec
diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb index abc1234..def5678 100644 --- a/spec/support/helpers.rb +++ b/spec/support/helpers.rb @@ -16,6 +16,7 @@ require "kitchen/terraform/error" +# This module comprises miscellaneous helper methods to be used by examples. module Helpers def fail_after...
Add a description to the spec Helper module
diff --git a/lib/sass/script/bool.rb b/lib/sass/script/bool.rb index abc1234..def5678 100644 --- a/lib/sass/script/bool.rb +++ b/lib/sass/script/bool.rb @@ -1,13 +1,17 @@ require 'sass/script/literal' module Sass::Script - class Bool < Literal # :nodoc: + # A SassScript object representing a boolean (true or false...
[Sass] Convert Sass::Script::Bool docs to YARD.
diff --git a/app/controllers/doorkeeper/application_controller.rb b/app/controllers/doorkeeper/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/doorkeeper/application_controller.rb +++ b/app/controllers/doorkeeper/application_controller.rb @@ -15,5 +15,13 @@ instance_eval(&block) ...
Add method missing to application controller It notifies users that they should use main_app object if they want to access their named routes.
diff --git a/db/migrate/20151107105747_create_trends.rb b/db/migrate/20151107105747_create_trends.rb index abc1234..def5678 100644 --- a/db/migrate/20151107105747_create_trends.rb +++ b/db/migrate/20151107105747_create_trends.rb @@ -4,6 +4,7 @@ t.string :description t.string :links # link of the feed itsel...
Add new column "categories" in db
diff --git a/db/migrate/20140412005454_load_shapefile.rb b/db/migrate/20140412005454_load_shapefile.rb index abc1234..def5678 100644 --- a/db/migrate/20140412005454_load_shapefile.rb +++ b/db/migrate/20140412005454_load_shapefile.rb @@ -0,0 +1,43 @@+class LoadShapefile < ActiveRecord::Migration + + SHAPEFILE = Rails.r...
Add migration to load shapefile into bikeway_segments table
diff --git a/lib/opscode/models/opc_customer.rb b/lib/opscode/models/opc_customer.rb index abc1234..def5678 100644 --- a/lib/opscode/models/opc_customer.rb +++ b/lib/opscode/models/opc_customer.rb @@ -15,6 +15,10 @@ rw_attribute :display_name rw_attribute :contact + rw_attribute :osc_customer + ...
Add the 4 new fields to the increasingly misnamed OpcCustomer.
diff --git a/lib/puppet/type/xtreemfs_volume.rb b/lib/puppet/type/xtreemfs_volume.rb index abc1234..def5678 100644 --- a/lib/puppet/type/xtreemfs_volume.rb +++ b/lib/puppet/type/xtreemfs_volume.rb @@ -27,6 +27,7 @@ newparam(:host) do desc 'A host of volume, pass an directory service host here' fqdn = Facter...
Fix for Travis box without hostname
diff --git a/lib/tasks/editions.rake b/lib/tasks/editions.rake index abc1234..def5678 100644 --- a/lib/tasks/editions.rake +++ b/lib/tasks/editions.rake @@ -31,4 +31,22 @@ end end end + + desc "cache latest version number against editions" + task :cache_version_numbers => :environment do + WholeEdit...
Add rake task to cache version numbers in the right places
diff --git a/lib/stagehand/schema/statements.rb b/lib/stagehand/schema/statements.rb index abc1234..def5678 100644 --- a/lib/stagehand/schema/statements.rb +++ b/lib/stagehand/schema/statements.rb @@ -7,7 +7,7 @@ return if options.symbolize_keys[:stagehand] == false return if UNTRACKED_TABLES.include...
Fix rake not creating triggers If the test environment used only a single connection, and the rake task was run in that environment, the extended version of create_table would not create triggers because it found that it was migrating the production database (which was also the staging database). Now if there is a sin...
diff --git a/lib/tic_tac_toe/game.rb b/lib/tic_tac_toe/game.rb index abc1234..def5678 100644 --- a/lib/tic_tac_toe/game.rb +++ b/lib/tic_tac_toe/game.rb @@ -1,14 +1,19 @@ module TicTacToe class Game + attr_reader :to_play def initialize display @display = display + @to_play = "X" end ...
Write a very basic do_turn method
diff --git a/lib/tod/mongoization.rb b/lib/tod/mongoization.rb index abc1234..def5678 100644 --- a/lib/tod/mongoization.rb +++ b/lib/tod/mongoization.rb @@ -11,7 +11,7 @@ # Get the object as it was stored in the database, and instantiate # this custom class from it. def demongoize(object) - T...
Fix error on mongoid load when object is nil
diff --git a/app/models/renalware/clinics/visit_query.rb b/app/models/renalware/clinics/visit_query.rb index abc1234..def5678 100644 --- a/app/models/renalware/clinics/visit_query.rb +++ b/app/models/renalware/clinics/visit_query.rb @@ -7,7 +7,7 @@ def initialize(q = {}) @q = q - @q[:s] = "date ...
Sort visits in reverse date order
diff --git a/lib/ws_light/set/strawberry_set.rb b/lib/ws_light/set/strawberry_set.rb index abc1234..def5678 100644 --- a/lib/ws_light/set/strawberry_set.rb +++ b/lib/ws_light/set/strawberry_set.rb @@ -26,7 +26,7 @@ set = sprinkle_nuts(set) - set + type == :double ? set + set.reverse : set ...
[BUGFIX] Extend strawberry to second strip
diff --git a/app/controllers/concerns/workouts_checker.rb b/app/controllers/concerns/workouts_checker.rb index abc1234..def5678 100644 --- a/app/controllers/concerns/workouts_checker.rb +++ b/app/controllers/concerns/workouts_checker.rb @@ -0,0 +1,15 @@+module WorkoutsChecker + extend ActiveSupport::Concern + + inclu...
Check if wotkout is being async updated before changes.
diff --git a/app/controllers/embedded_tools_controller.rb b/app/controllers/embedded_tools_controller.rb index abc1234..def5678 100644 --- a/app/controllers/embedded_tools_controller.rb +++ b/app/controllers/embedded_tools_controller.rb @@ -1,4 +1,9 @@ class EmbeddedToolsController < ApplicationController + + # Preven...
Apply fix for locale param being repeated in engines.
diff --git a/app/controllers/errata_reports_controller.rb b/app/controllers/errata_reports_controller.rb index abc1234..def5678 100644 --- a/app/controllers/errata_reports_controller.rb +++ b/app/controllers/errata_reports_controller.rb @@ -11,7 +11,7 @@ if display_flag_version?(bz, params["flag_version"]) ...
Change method name to all_acks? to pass rubocop coding style evaluation.
diff --git a/example/config/initializers/shopify_app.rb b/example/config/initializers/shopify_app.rb index abc1234..def5678 100644 --- a/example/config/initializers/shopify_app.rb +++ b/example/config/initializers/shopify_app.rb @@ -5,4 +5,5 @@ config.scope = 'read_customers, write_products' config.embedded_app = ...
Add version to example app.
diff --git a/lib/haml/template.rb b/lib/haml/template.rb index abc1234..def5678 100644 --- a/lib/haml/template.rb +++ b/lib/haml/template.rb @@ -25,8 +25,8 @@ end -Haml::Template.options[:ugly] ||= Rails.env.development? +Haml::Template.options[:ugly] = !Rails.env.development? Haml::Template.options[:escape...
Fix ugly option being set being set incorrectly
diff --git a/ci_environment/leiningen/attributes/default.rb b/ci_environment/leiningen/attributes/default.rb index abc1234..def5678 100644 --- a/ci_environment/leiningen/attributes/default.rb +++ b/ci_environment/leiningen/attributes/default.rb @@ -2,4 +2,4 @@ default[:leiningen][:lein1][:install_script] = "https://git...
Make sure we download lein2 w.r.t. the version we want
diff --git a/spec/mr_version_spec.rb b/spec/mr_version_spec.rb index abc1234..def5678 100644 --- a/spec/mr_version_spec.rb +++ b/spec/mr_version_spec.rb @@ -4,25 +4,25 @@ describe MrVersion do - it 'should have a version number' do + it 'has a library version' do MrVersion::VERSION.should.match /[0-9]+\.[0-9...
Modify spec descriptions to read better
diff --git a/spec/xml/parser_spec.rb b/spec/xml/parser_spec.rb index abc1234..def5678 100644 --- a/spec/xml/parser_spec.rb +++ b/spec/xml/parser_spec.rb @@ -1,12 +1,6 @@ require_relative './../spec_helper.rb' describe ROXML::XML do - it "should raise on malformed xml" do - if ROXML::XML_PARSER == 'libxml' # noko...
Remove the malformed xml spec, which after all tests the parser rather than roxml
diff --git a/chart-js-rails.gemspec b/chart-js-rails.gemspec index abc1234..def5678 100644 --- a/chart-js-rails.gemspec +++ b/chart-js-rails.gemspec @@ -15,5 +15,5 @@ gem.require_paths = ["lib"] gem.version = Chart::Js::Rails::VERSION - gem.add_dependency "railties", "~> 3.1" + gem.add_dependency "railti...
Update railties dependency to > 3.1 Depending on ~> 3.1 prevents this gem from being used with Rails 4 for no good reason.
diff --git a/files/default/ohai_plugins/local_passwd.rb b/files/default/ohai_plugins/local_passwd.rb index abc1234..def5678 100644 --- a/files/default/ohai_plugins/local_passwd.rb +++ b/files/default/ohai_plugins/local_passwd.rb @@ -0,0 +1,27 @@+provides 'etc', 'current_user' + +require 'etc' + +unless etc + etc Mash....
Add ohai plugin for local passwords
diff --git a/wowfoot-webrick/tdb.rb b/wowfoot-webrick/tdb.rb index abc1234..def5678 100644 --- a/wowfoot-webrick/tdb.rb +++ b/wowfoot-webrick/tdb.rb @@ -0,0 +1,45 @@+#!/usr/bin/ruby +# open mysql connection to TDB +require 'rubygems' # 1.8 bug workaround + +require 'dbi' +require '../wowfoot-ex/output/WorldMapArea.rb' ...
Test code for accessing the Trinity DB.
diff --git a/test/integration/search_with_trait_sets_test.rb b/test/integration/search_with_trait_sets_test.rb index abc1234..def5678 100644 --- a/test/integration/search_with_trait_sets_test.rb +++ b/test/integration/search_with_trait_sets_test.rb @@ -4,6 +4,7 @@ fixtures :projects, :taxa, :trait_sets, :categorical_...
Set capybara default wait time to 5
diff --git a/language/module_spec.rb b/language/module_spec.rb index abc1234..def5678 100644 --- a/language/module_spec.rb +++ b/language/module_spec.rb @@ -16,6 +16,24 @@ LangModuleSpec::Anon = Module.new LangModuleSpec::Anon.name.should == "LangModuleSpec::Anon" end + + it "raises a TypeError if the cons...
Add spec for module trying to reopen a class
diff --git a/deathbycaptcha.gemspec b/deathbycaptcha.gemspec index abc1234..def5678 100644 --- a/deathbycaptcha.gemspec +++ b/deathbycaptcha.gemspec @@ -6,7 +6,7 @@ Gem::Specification.new do |spec| spec.name = "deathbycaptcha" spec.version = DeathByCaptcha::VERSION - spec.authors = ["Débora ...
Add Marcelo Mita in the list of authors in gemspec
diff --git a/math24cli.rb b/math24cli.rb index abc1234..def5678 100644 --- a/math24cli.rb +++ b/math24cli.rb @@ -4,4 +4,4 @@ operators = ["+", "-", "*", "/"] solver = Math24.new(operators) solver.numbers = numbers -solver.solve()+puts solver.solve()
Make CLI responsible for printing the result
diff --git a/spec/attr_deprected_active_record_spec.rb b/spec/attr_deprected_active_record_spec.rb index abc1234..def5678 100644 --- a/spec/attr_deprected_active_record_spec.rb +++ b/spec/attr_deprected_active_record_spec.rb @@ -0,0 +1,22 @@+require 'spec_helper' + +class User < ActiveRecord::Base + include AttrDeprec...
Add spec for ActiveRecord integration
diff --git a/spec/controllers/clubs_controller_spec.rb b/spec/controllers/clubs_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/clubs_controller_spec.rb +++ b/spec/controllers/clubs_controller_spec.rb @@ -0,0 +1,58 @@+require 'spec_helper' + +describe ClubsController do + let(:user) { FactoryGi...
Add Clubs Controller Spec for Edit Action Add a spec to test the Clubs controller edit action.
diff --git a/spec/controllers/pages_controller_spec.rb b/spec/controllers/pages_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/pages_controller_spec.rb +++ b/spec/controllers/pages_controller_spec.rb @@ -0,0 +1,18 @@+require 'spec_helper' + +describe HighVoltage::PagesController, '#show' do + ...
Add spec to ensure about_us and faq pages render properly
diff --git a/lib/fb_graph/connections/userpermissions.rb b/lib/fb_graph/connections/userpermissions.rb index abc1234..def5678 100644 --- a/lib/fb_graph/connections/userpermissions.rb +++ b/lib/fb_graph/connections/userpermissions.rb @@ -2,7 +2,7 @@ module Connections module UserPermissions def userpermiss...
Return all permissions for ad accounts from Business Manager
diff --git a/mixlib-shellout.gemspec b/mixlib-shellout.gemspec index abc1234..def5678 100644 --- a/mixlib-shellout.gemspec +++ b/mixlib-shellout.gemspec @@ -19,5 +19,6 @@ s.bindir = "bin" s.executables = [] s.require_path = 'lib' - s.files = %w(Gemfile Rakefile LICENSE README.md) + Dir.glob("lib/**/*") ...
Add gemspec files to allow bundler to run from the gem
diff --git a/spec/dummy/db/seeds.rb b/spec/dummy/db/seeds.rb index abc1234..def5678 100644 --- a/spec/dummy/db/seeds.rb +++ b/spec/dummy/db/seeds.rb @@ -0,0 +1,25 @@+# setup a simple, one-page activity +act = Lightweight::LightweightActivity.create!(:name => "Test activity") +page = act.pages.create!(:name => "Page 1",...
Add a basic activity as seed data
diff --git a/spec/postfix-filter.rb b/spec/postfix-filter.rb index abc1234..def5678 100644 --- a/spec/postfix-filter.rb +++ b/spec/postfix-filter.rb @@ -0,0 +1,32 @@+#!/usr/bin/ruby +# encoding: UTF-8 + +$:.unshift File.join(File.dirname(__FILE__), '..', 'lib') +$:.unshift File.join(File.dirname(__FILE__), '..', 'proce...
Add basic tests for Postfix filter processor. Signed-off-by: brian m. carlson <738bdd359be778fee9f0fc4e2934ad72f436ceda@crustytoothpaste.net>
diff --git a/app/controllers/community/forums_controller.rb b/app/controllers/community/forums_controller.rb index abc1234..def5678 100644 --- a/app/controllers/community/forums_controller.rb +++ b/app/controllers/community/forums_controller.rb @@ -8,6 +8,7 @@ def show @forum = Community::Forum.where(slug:...
Fix undefined method `topics' for nil:NilClass.
diff --git a/app/controllers/related_contents_controller.rb b/app/controllers/related_contents_controller.rb index abc1234..def5678 100644 --- a/app/controllers/related_contents_controller.rb +++ b/app/controllers/related_contents_controller.rb @@ -7,7 +7,7 @@ def create if relationable_object && related_objec...
Fix relatedcontent creation and scoring on related content controller
diff --git a/lib/versioneye/mailers/newsletter_mailer.rb b/lib/versioneye/mailers/newsletter_mailer.rb index abc1234..def5678 100644 --- a/lib/versioneye/mailers/newsletter_mailer.rb +++ b/lib/versioneye/mailers/newsletter_mailer.rb @@ -8,7 +8,7 @@ def newsletter_new_features_email( user ) @user = user @new...
Update subject of newsletter email
diff --git a/app/controllers/newsletter_subscriptions_controller.rb b/app/controllers/newsletter_subscriptions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/newsletter_subscriptions_controller.rb +++ b/app/controllers/newsletter_subscriptions_controller.rb @@ -8,7 +8,7 @@ end respond_to d...
Discard the flash at the end of the current action when rendering js. This prevents success / error messages from appearing on the next request. @amansinghb small and subtle. thanks
diff --git a/app/models/time_span.rb b/app/models/time_span.rb index abc1234..def5678 100644 --- a/app/models/time_span.rb +++ b/app/models/time_span.rb @@ -23,6 +23,9 @@ attr_accessible :date, :duration, :duration_bonus, :duration_days + validates_presence_of :date, :duration, :duration_in_work_days, + ...
Validate that all the needed fields are present for a TimeSpan
diff --git a/lib/cancan_namespace/rule.rb b/lib/cancan_namespace/rule.rb index abc1234..def5678 100644 --- a/lib/cancan_namespace/rule.rb +++ b/lib/cancan_namespace/rule.rb @@ -9,7 +9,7 @@ # of conditions and the last one is the block passed to the "can" call. def initialize(base_behavior, action, subject, con...
Fix extract contexts from options
diff --git a/lib/capistrano/rightscale.rb b/lib/capistrano/rightscale.rb index abc1234..def5678 100644 --- a/lib/capistrano/rightscale.rb +++ b/lib/capistrano/rightscale.rb @@ -9,23 +9,29 @@ # tag "x99:role=app", :app, :deployment => 45678 def tag(which, *args) @rightscale ||= RightScale::Client.new(fetch...
Check all servers for tags now, tag search seems limited.
diff --git a/app/services/create_salesforce_media_record.rb b/app/services/create_salesforce_media_record.rb index abc1234..def5678 100644 --- a/app/services/create_salesforce_media_record.rb +++ b/app/services/create_salesforce_media_record.rb @@ -28,7 +28,7 @@ def salesforce_media_fields { Title__c: @ar...
Fix engagement type for Salesforce record creation
diff --git a/test/form/simple_form.rb b/test/form/simple_form.rb index abc1234..def5678 100644 --- a/test/form/simple_form.rb +++ b/test/form/simple_form.rb @@ -17,13 +17,15 @@ form.handle_input - + { first_name: first_name.value, last_name: last_name.value, form_submitted: form.submitted?} end + screen ...
Access form information after curses screen.
diff --git a/spec/fake_app/mongo_mapper/config.rb b/spec/fake_app/mongo_mapper/config.rb index abc1234..def5678 100644 --- a/spec/fake_app/mongo_mapper/config.rb +++ b/spec/fake_app/mongo_mapper/config.rb @@ -1,2 +1,2 @@-MongoMapper.connection = Mongo::Connection.new 'localhost', 27017 +MongoMapper.connection = Mongo::...
Fix mongo mapper test suite https://travis-ci.org/amatsuda/kaminari/jobs/41827391#L98
diff --git a/spec/libraries/borrow_direct_spec.rb b/spec/libraries/borrow_direct_spec.rb index abc1234..def5678 100644 --- a/spec/libraries/borrow_direct_spec.rb +++ b/spec/libraries/borrow_direct_spec.rb @@ -0,0 +1,12 @@+require 'spec_helper' +require 'blacklight_cornell_requests/borrow_direct' + +describe BlacklightC...
Add tests for borrow direct library.
diff --git a/news.gemspec b/news.gemspec index abc1234..def5678 100644 --- a/news.gemspec +++ b/news.gemspec @@ -17,7 +17,7 @@ s.test_files = Dir["test/**/*"] s.add_dependency "rails", "~> 3.2.11" - s.add_dependency "paperclip", "~> 3.5.2" + s.add_dependency "paperclip", "~> 3.0" s.add_dependency "stringex"...
Reduce paperclip version dependancy to fix identify issue with ImageMagick
diff --git a/lib/cocoapods/search/command.rb b/lib/cocoapods/search/command.rb index abc1234..def5678 100644 --- a/lib/cocoapods/search/command.rb +++ b/lib/cocoapods/search/command.rb @@ -28,6 +28,9 @@ abort rescue PodError => e say e.message + if e.message =~ /rbenv: pod: command not found/ + ...
Add displaying message if cocoapods is not installed
diff --git a/spec/lib/knowledge_base/configuration_spec.rb b/spec/lib/knowledge_base/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/lib/knowledge_base/configuration_spec.rb +++ b/spec/lib/knowledge_base/configuration_spec.rb @@ -27,4 +27,28 @@ expect(subject.section_styles).to eq({ }) end ...
Add spec for default uploaders
diff --git a/lib/woocommerce_api/resources/coupon_line.rb b/lib/woocommerce_api/resources/coupon_line.rb index abc1234..def5678 100644 --- a/lib/woocommerce_api/resources/coupon_line.rb +++ b/lib/woocommerce_api/resources/coupon_line.rb @@ -3,5 +3,9 @@ attribute :id, Integer attribute :code attribute :amo...
Add instance method for coupon
diff --git a/lib/smart_answer/calculators/paternity_adoption_pay_calculator.rb b/lib/smart_answer/calculators/paternity_adoption_pay_calculator.rb index abc1234..def5678 100644 --- a/lib/smart_answer/calculators/paternity_adoption_pay_calculator.rb +++ b/lib/smart_answer/calculators/paternity_adoption_pay_calculator.rb...
Add paternity adoption pay calculator Almost the same logic as paternity pay but delegates to adoption pay calculator for certain operations.
diff --git a/lib/hey/pubsub/event.rb b/lib/hey/pubsub/event.rb index abc1234..def5678 100644 --- a/lib/hey/pubsub/event.rb +++ b/lib/hey/pubsub/event.rb @@ -28,6 +28,8 @@ def metadata merged_data = Hey::ThreadCargo.to_hash.merge(@metadata) + merged_data.delete(:uuid) + merged_data.delete(Hey::ThreadCargo...
Remove values from returned hash.
diff --git a/lib/rspec/rake/example_group.rb b/lib/rspec/rake/example_group.rb index abc1234..def5678 100644 --- a/lib/rspec/rake/example_group.rb +++ b/lib/rspec/rake/example_group.rb @@ -13,7 +13,7 @@ subject(:task) { Rake.application[self.class.top_level_description] } - before(:all) do + ...
Use before `each` hook instead of `all`.
diff --git a/lib/shutterstock-ruby/videos.rb b/lib/shutterstock-ruby/videos.rb index abc1234..def5678 100644 --- a/lib/shutterstock-ruby/videos.rb +++ b/lib/shutterstock-ruby/videos.rb @@ -23,6 +23,10 @@ JSON.parse(get("/videos/licenses", params.merge(options))) end + def download(licence) + JSON.p...
Allow purchased content to be downloaded again
diff --git a/lib/multiplay/was_changed.rb b/lib/multiplay/was_changed.rb index abc1234..def5678 100644 --- a/lib/multiplay/was_changed.rb +++ b/lib/multiplay/was_changed.rb @@ -7,7 +7,7 @@ end def store_changes - @was_changed_attributes = @changed_attributes.clone + @was_changed_attributes = @chang...
Fix being able to saved cloned Objects
diff --git a/lib/tasks/octopress_import.rake b/lib/tasks/octopress_import.rake index abc1234..def5678 100644 --- a/lib/tasks/octopress_import.rake +++ b/lib/tasks/octopress_import.rake @@ -26,7 +26,7 @@ album_data = YAML.load_file(File.join(root_path, name, index_filename)) photo = Photo.where(path: name, ...
Fix album import title casing
diff --git a/grack.gemspec b/grack.gemspec index abc1234..def5678 100644 --- a/grack.gemspec +++ b/grack.gemspec @@ -16,8 +16,8 @@ lib/grack/app.rb lib/grack/file_streamer.rb lib/grack/git_adapter.rb + lib/grack/git_adapter_factory.rb lib/grack/io_streamer.rb - lib/grack/request_handler.rb }...
Update the list of files in the gemspec
diff --git a/lib/s3_multipart/uploader.rb b/lib/s3_multipart/uploader.rb index abc1234..def5678 100644 --- a/lib/s3_multipart/uploader.rb +++ b/lib/s3_multipart/uploader.rb @@ -34,11 +34,11 @@ end def attach(model, options = {}) - self.mount_point = options[:using] if options.key?(:using) + ...
Allow association options for uploads
diff --git a/lib/sass/script/operation.rb b/lib/sass/script/operation.rb index abc1234..def5678 100644 --- a/lib/sass/script/operation.rb +++ b/lib/sass/script/operation.rb @@ -1,3 +1,4 @@+require 'set' require 'sass/script/string' require 'sass/script/number' require 'sass/script/color' @@ -5,17 +6,29 @@ require 's...
[Sass] Convert Sass::Script::Operation docs to YARD.
diff --git a/lib/songkick/oauth2/model.rb b/lib/songkick/oauth2/model.rb index abc1234..def5678 100644 --- a/lib/songkick/oauth2/model.rb +++ b/lib/songkick/oauth2/model.rb @@ -12,7 +12,8 @@ Schema = Songkick::OAuth2::Schema DUPLICATE_RECORD_ERRORS = [ - /^Mysql::Error: Duplicate entry\b/, +...
Add error string for duplicate key records on Postgres.
diff --git a/lib/tasks/message_queue.rake b/lib/tasks/message_queue.rake index abc1234..def5678 100644 --- a/lib/tasks/message_queue.rake +++ b/lib/tasks/message_queue.rake @@ -7,6 +7,10 @@ # Note: this output is used in the test helpers to detect when this has started. puts "Starting message consumer" $s...
Handle signals in consumer rake task. When upstart stops the worker, it sends a SIGTERM to the process. This is manifested in ruby as a SignalException. Unless handled, this exception bubbles all the way up, and it intercepted by the airbrake handler, resulting in noise in Errbit. Handling this exception in the rak...
diff --git a/lib/ubuntu_unused_kernels.rb b/lib/ubuntu_unused_kernels.rb index abc1234..def5678 100644 --- a/lib/ubuntu_unused_kernels.rb +++ b/lib/ubuntu_unused_kernels.rb @@ -23,8 +23,11 @@ end def get_current - uname = Open3.capture2('uname', '-r').first.chomp - match = uname.match(/^(#{KERNEL_V...
Implement error handling in get_current.
diff --git a/cookbooks/elasticsearch/recipes/az_aware.rb b/cookbooks/elasticsearch/recipes/az_aware.rb index abc1234..def5678 100644 --- a/cookbooks/elasticsearch/recipes/az_aware.rb +++ b/cookbooks/elasticsearch/recipes/az_aware.rb @@ -1,2 +1,8 @@ # Add this recipe to the run list to make this node AZ aware -node.defa...
Expand AZ awareness to explicitly set the rack_id as an awareness attribute
diff --git a/lib/link_expansion/edition_diff.rb b/lib/link_expansion/edition_diff.rb index abc1234..def5678 100644 --- a/lib/link_expansion/edition_diff.rb +++ b/lib/link_expansion/edition_diff.rb @@ -28,7 +28,7 @@ ) end - def hash_diff(a, b) # rubocop:disable Naming/UncommunicativeMethodParamName + def hash...
Fix name of cop in disable directive
diff --git a/motion/joybox-osx/configuration/gl_view.rb b/motion/joybox-osx/configuration/gl_view.rb index abc1234..def5678 100644 --- a/motion/joybox-osx/configuration/gl_view.rb +++ b/motion/joybox-osx/configuration/gl_view.rb @@ -14,11 +14,8 @@ def self.new(options) - - bounds_provided = options.inc...
Fix => Exception on window close
diff --git a/lib/core_ext/time.rb b/lib/core_ext/time.rb index abc1234..def5678 100644 --- a/lib/core_ext/time.rb +++ b/lib/core_ext/time.rb @@ -11,7 +11,7 @@ def self.json_create string return nil if string.nil? - d = DateTime.parse(string).new_offset + d = DateTime.parse(string.to_s).new_offset ...
Make sure we pass a string to DateTime.parse. This unbreaks type casting with time zone objects.
diff --git a/lib/danger/runner.rb b/lib/danger/runner.rb index abc1234..def5678 100644 --- a/lib/danger/runner.rb +++ b/lib/danger/runner.rb @@ -5,6 +5,8 @@ def initialize(argv) @dangerfile_path = "Dangerfile" if File.exist? "Dangerfile" + @base = argv.option('base') + @head = argv.option('head')...
Support options on danger run for specifying the head / base commit
diff --git a/lib/flakey/buffer.rb b/lib/flakey/buffer.rb index abc1234..def5678 100644 --- a/lib/flakey/buffer.rb +++ b/lib/flakey/buffer.rb @@ -4,7 +4,7 @@ SHARE_URL = "https://bufferapp.com/add" - def buffer_button(options = {}) + def buffer_button(options = {}, &block) defaults = { url:...
Facilitate passing blocks into Buffer
diff --git a/lib/spree_paypal_express/engine.rb b/lib/spree_paypal_express/engine.rb index abc1234..def5678 100644 --- a/lib/spree_paypal_express/engine.rb +++ b/lib/spree_paypal_express/engine.rb @@ -10,7 +10,7 @@ end def self.activate - Dir.glob(File.join(File.dirname(__FILE__), "../app/**/*_decorator...
Make sure decorators are being loaded
diff --git a/lib/job/db_backup.rb b/lib/job/db_backup.rb index abc1234..def5678 100644 --- a/lib/job/db_backup.rb +++ b/lib/job/db_backup.rb @@ -8,38 +8,44 @@ MESSAGE = ENV['NVST_DB_BACKUP_MSG'] def self.perform - db = Nvst::Application.config.database_configuration['default'] + db_dump!(Nvst::Appl...
Split DbBackup to smaller chunks
diff --git a/lib/ghtorrent/migrations/020_add_deleted_to_users.rb b/lib/ghtorrent/migrations/020_add_deleted_to_users.rb index abc1234..def5678 100644 --- a/lib/ghtorrent/migrations/020_add_deleted_to_users.rb +++ b/lib/ghtorrent/migrations/020_add_deleted_to_users.rb @@ -6,28 +6,14 @@ Sequel.migration do up do - ...
Fix migration to actually add the deleted field
diff --git a/lib/raml/resource.rb b/lib/raml/resource.rb index abc1234..def5678 100644 --- a/lib/raml/resource.rb +++ b/lib/raml/resource.rb @@ -1,5 +1,3 @@-require 'uri' - module Raml class Resource ATTRIBUTES = [] @@ -13,7 +11,7 @@ end def url - URI.join(parent.uri, uri_partial) + File.j...
Use File.join, URI.join does validation and {} is not valid
diff --git a/lib/relax/helpers.rb b/lib/relax/helpers.rb index abc1234..def5678 100644 --- a/lib/relax/helpers.rb +++ b/lib/relax/helpers.rb @@ -8,7 +8,8 @@ def relax_snippet if defined?(@relax) && @relax - "Relax.replace(#{@relax});".html_safe + snippet = @relax.gsub(/\;$/, '') + "Rel...
Fix ie11 can't have semicolons inside parenthesis
diff --git a/lib/pier.rb b/lib/pier.rb index abc1234..def5678 100644 --- a/lib/pier.rb +++ b/lib/pier.rb @@ -4,16 +4,7 @@ module Pier def runShellProc(command) - begin - IO.popen(command, :err=>[:child, :out]) do |io| - while (output = io.getc) do - print output - $stdout.flush - ...
Switch to using `system` for running commands Using `IO.popen()` does not forward the TTY, which prevents commands like `psql` from using readline (e.g. ctrl+r). Using `system` allows for readline to work without causing any other known issues.