diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/scanny/checks/session/session_secure_check_spec.rb b/spec/scanny/checks/session/session_secure_check_spec.rb index abc1234..def5678 100644 --- a/spec/scanny/checks/session/session_secure_check_spec.rb +++ b/spec/scanny/checks/session/session_secure_check_spec.rb @@ -6,14 +6,6 @@ @runner = Scanny...
Remove spec with simple symbols
diff --git a/lib/rails_admin/adapters/mongoid/extension.rb b/lib/rails_admin/adapters/mongoid/extension.rb index abc1234..def5678 100644 --- a/lib/rails_admin/adapters/mongoid/extension.rb +++ b/lib/rails_admin/adapters/mongoid/extension.rb @@ -39,7 +39,8 @@ args.each do |arg| @nested_attributes_...
Fix syntax error in Ruby1.8
diff --git a/lib/tasks/data_migrations/add_pic_school.rake b/lib/tasks/data_migrations/add_pic_school.rake index abc1234..def5678 100644 --- a/lib/tasks/data_migrations/add_pic_school.rake +++ b/lib/tasks/data_migrations/add_pic_school.rake @@ -1,5 +1,5 @@ namespace :data_migration do - desc "Add Capuano school" + de...
Fix description for Parent Information Center school
diff --git a/scripts/npm_bundles.rb b/scripts/npm_bundles.rb index abc1234..def5678 100644 --- a/scripts/npm_bundles.rb +++ b/scripts/npm_bundles.rb @@ -7,6 +7,7 @@ "coffee-script" => "coffee", "grunt-cli" => "grunt", "dalek-cli" => "dalek", + "gulp" => "", "gh" => "", "bower" => "", "yo" => "",
Add gulp to npm packages
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -21,12 +21,12 @@ client.instance_variable_set('@instance_host', 'na9.salesforce.com') end - def fixture_path - File.expand_path("../fixtures", __FILE__) + def fixtu...
Update fixture_path helper to take a file name that way we can use it separately if necessary. We'll need it for our YAML config implementation test.
diff --git a/app/models/auth_token.rb b/app/models/auth_token.rb index abc1234..def5678 100644 --- a/app/models/auth_token.rb +++ b/app/models/auth_token.rb @@ -1,9 +1,55 @@ class AuthToken < ActiveRecord::Base + + belongs_to :user # Auth token encryption settings attr_encrypted :auth_token, key: Doubtfir...
QUALITY: Move generation of auth token to auth token class
diff --git a/oc-chef-pedant/spec/running_configs/analytics_spec.rb b/oc-chef-pedant/spec/running_configs/analytics_spec.rb index abc1234..def5678 100644 --- a/oc-chef-pedant/spec/running_configs/analytics_spec.rb +++ b/oc-chef-pedant/spec/running_configs/analytics_spec.rb @@ -0,0 +1,48 @@+require 'json' +require 'pedan...
[pedant] Add specs for analytics-required config exports Signed-off-by: Steven Danna <9ce5770b3bb4b2a1d59be2d97e34379cd192299f@chef.io>
diff --git a/test/test_as_json.rb b/test/test_as_json.rb index abc1234..def5678 100644 --- a/test/test_as_json.rb +++ b/test/test_as_json.rb @@ -28,7 +28,6 @@ end def test_as_json_options - Oj.mimic_JSON() raccoon = Raccoon.new('Rocket') obj = Oj.dump(raccoon.to_json) assert_equal(obj, '"{\"nam...
Remove mimic call as we're now explicitly invoking the applicable methods,
diff --git a/lib/moonshine/no_www.rb b/lib/moonshine/no_www.rb index abc1234..def5678 100644 --- a/lib/moonshine/no_www.rb +++ b/lib/moonshine/no_www.rb @@ -26,7 +26,6 @@ if configuration[:ssl] rewrite_section = <<-MOD_REWRITE_SSL # SSL WWW Redirect - RewriteCond %{HTTP_HOST} !^#{dom...
Apply change to ssl section too.
diff --git a/lib/mws-rb/api/feeds.rb b/lib/mws-rb/api/feeds.rb index abc1234..def5678 100644 --- a/lib/mws-rb/api/feeds.rb +++ b/lib/mws-rb/api/feeds.rb @@ -18,7 +18,7 @@ params = params.except(:merchant_id, :message_type, :message, :messages, :skip_schema_validation) call(:submit_feed, params.merge!( ...
Fix format option used in the submit_feed method
diff --git a/examples/06_treeview.rb b/examples/06_treeview.rb index abc1234..def5678 100644 --- a/examples/06_treeview.rb +++ b/examples/06_treeview.rb @@ -0,0 +1,49 @@+$LOAD_PATH.unshift File.join(File.dirname(__FILE__), '..', 'lib') +require 'gir_ffi-gtk3' + +Gtk.init + + +#Add window. +win = Gtk::Window.new(:toplev...
Add tree view example [merges 'kaspernj/master']
diff --git a/commands/development_playground_command.rb b/commands/development_playground_command.rb index abc1234..def5678 100644 --- a/commands/development_playground_command.rb +++ b/commands/development_playground_command.rb @@ -0,0 +1,40 @@+module ChatBotCommand + class DevPlaygroundCommand + TITLE = "DevPlayg...
Add development playground command for testing purposes
diff --git a/app/controllers/credit_scores_controller.rb b/app/controllers/credit_scores_controller.rb index abc1234..def5678 100644 --- a/app/controllers/credit_scores_controller.rb +++ b/app/controllers/credit_scores_controller.rb @@ -15,4 +15,8 @@ def obj_params params.require(:credit_score).permit(:score...
Set default new credit score date
diff --git a/lib/tasks/database.rake b/lib/tasks/database.rake index abc1234..def5678 100644 --- a/lib/tasks/database.rake +++ b/lib/tasks/database.rake @@ -0,0 +1,24 @@+namespace :db do + desc "Create a lot of data in the database to test syncing performance" + task muchdata: :environment do + 10.times do |i_n| +...
Add rake task for inserting a lot of data to db
diff --git a/lib/xbox_leaders/api.rb b/lib/xbox_leaders/api.rb index abc1234..def5678 100644 --- a/lib/xbox_leaders/api.rb +++ b/lib/xbox_leaders/api.rb @@ -12,7 +12,7 @@ end def fetch_achievements(gamertag, game_id) - get('/achievements', gamertag: gamertag, titleid: game_id) + get('/achievements', gamert...
Fix achievements endpoint for new gameid param.
diff --git a/config/initializers/omniauth_shibboleth.rb b/config/initializers/omniauth_shibboleth.rb index abc1234..def5678 100644 --- a/config/initializers/omniauth_shibboleth.rb +++ b/config/initializers/omniauth_shibboleth.rb @@ -1,5 +1,5 @@ Rails.application.config.middleware.use OmniAuth::Builder do - if Rails.en...
Fix up for testing - had wrong dns name.
diff --git a/config/initializers/metal_archives.rb b/config/initializers/metal_archives.rb index abc1234..def5678 100644 --- a/config/initializers/metal_archives.rb +++ b/config/initializers/metal_archives.rb @@ -1,4 +1,7 @@ # frozen_string_literal: true + +require Rails.root.join("lib/headbanger/app.rb") +require Rail...
Load Headbanger version to avoid autoload errors
diff --git a/core/spec/entities/menu/menu_entry_spec.rb b/core/spec/entities/menu/menu_entry_spec.rb index abc1234..def5678 100644 --- a/core/spec/entities/menu/menu_entry_spec.rb +++ b/core/spec/entities/menu/menu_entry_spec.rb @@ -5,7 +5,7 @@ describe MenuEntry do it "wraps passed children" do e = MenuE...
Use be_kind_of in class comparison.
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -1,2 +1,8 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), *%w[.. .. lib])) +Before do + if test_proxy = ENV["MIMIC_TEST_PROXY"] + puts "(Using proxy #...
Support use of an HTTP proxy when running Cucumber features to assist debugging.
diff --git a/week-4/simple-string.rb b/week-4/simple-string.rb index abc1234..def5678 100644 --- a/week-4/simple-string.rb +++ b/week-4/simple-string.rb @@ -0,0 +1,31 @@+# Solution Below + + + + + +# RSpec Tests. They are included in this file because the local variables you are creating are not accessible across files...
Add file for simple string
diff --git a/benchmarks/acceptable.rb b/benchmarks/acceptable.rb index abc1234..def5678 100644 --- a/benchmarks/acceptable.rb +++ b/benchmarks/acceptable.rb @@ -0,0 +1,28 @@+require 'rubygems' +require 'rbench' +require File.expand_path('../../lib/rack/acceptable', __FILE__) + +TIMES = 10_000 + +SIMPLE = "text/html" +S...
Add a benchmark at yehuda's request
diff --git a/rake_tasks/jeweler.rake b/rake_tasks/jeweler.rake index abc1234..def5678 100644 --- a/rake_tasks/jeweler.rake +++ b/rake_tasks/jeweler.rake @@ -6,7 +6,7 @@ def extract_description_from_readme readme = File.open(README_PATH, 'r', &:read) - s = readme[/^# FTPD\n+((?:.*\n)+?)\n*##/i, 1] + s = readme[/^...
Fix rake tasks, busted by b9e5a88 (Add code climate tag to README)
diff --git a/test/integration/openstackrc/serverspec/default_spec.rb b/test/integration/openstackrc/serverspec/default_spec.rb index abc1234..def5678 100644 --- a/test/integration/openstackrc/serverspec/default_spec.rb +++ b/test/integration/openstackrc/serverspec/default_spec.rb @@ -1,12 +1,7 @@ require 'serverspec' ...
Fix PATH in tests for new serverspec
diff --git a/core/main/private_spec.rb b/core/main/private_spec.rb index abc1234..def5678 100644 --- a/core/main/private_spec.rb +++ b/core/main/private_spec.rb @@ -14,4 +14,12 @@ it "returns Object" do eval("private :main_public_method", TOPLEVEL_BINDING).should equal(Object) end + + it "raises a NameError ...
Add a spec for main.private when given an undefined name
diff --git a/app/lib/finder_schema.rb b/app/lib/finder_schema.rb index abc1234..def5678 100644 --- a/app/lib/finder_schema.rb +++ b/app/lib/finder_schema.rb @@ -13,6 +13,20 @@ def options_for(facet_name) allowed_values_as_option_tuples(allowed_values_for(facet_name)) + end + + def humanized_facet_name(key, &...
Allow FinderSchema to humanize values
diff --git a/app/workers/dependency_resolution_worker.rb b/app/workers/dependency_resolution_worker.rb index abc1234..def5678 100644 --- a/app/workers/dependency_resolution_worker.rb +++ b/app/workers/dependency_resolution_worker.rb @@ -28,7 +28,7 @@ end def present_content_store(dependent_content_id) - lates...
Remove unnecessary or equals operator
diff --git a/Casks/android-studio-bundle.rb b/Casks/android-studio-bundle.rb index abc1234..def5678 100644 --- a/Casks/android-studio-bundle.rb +++ b/Casks/android-studio-bundle.rb @@ -1,7 +1,7 @@ class AndroidStudioBundle < Cask - url 'https://dl.google.com/android/studio/install/0.4.2/android-studio-bundle-133.97093...
Upgrade Android Studio Bundle to v0.5.2
diff --git a/client/ruby/solrb/test/unit/solr_mock_base.rb b/client/ruby/solrb/test/unit/solr_mock_base.rb index abc1234..def5678 100644 --- a/client/ruby/solrb/test/unit/solr_mock_base.rb +++ b/client/ruby/solrb/test/unit/solr_mock_base.rb @@ -13,6 +13,7 @@ require 'test/unit' require 'solr' +# TODO: Maybe replace ...
Add TODO note about perhaps replacing our mock with the use of flexmock. Not worth adding this dependency just yet, only when we feel pain in mocking later git-svn-id: 3b1ff1236863b4d63a22e4dae568675c2e247730@500588 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/db/migrate/20170405123353_add_a_dummy_user.rb b/db/migrate/20170405123353_add_a_dummy_user.rb index abc1234..def5678 100644 --- a/db/migrate/20170405123353_add_a_dummy_user.rb +++ b/db/migrate/20170405123353_add_a_dummy_user.rb @@ -0,0 +1,16 @@+class AddADummyUser < ActiveRecord::Migration[5.0] + USER_INF...
Add dummy user to test CircleCI/Heroku continuous deployment
diff --git a/files/default/tests/minitest/hbase_test.rb b/files/default/tests/minitest/hbase_test.rb index abc1234..def5678 100644 --- a/files/default/tests/minitest/hbase_test.rb +++ b/files/default/tests/minitest/hbase_test.rb @@ -5,5 +5,35 @@ include Helpers::Hadoop # Example spec tests can be found at http:/...
Add tests for hbase recipe
diff --git a/lib/rom/plugins/relation/sql/auto_combine.rb b/lib/rom/plugins/relation/sql/auto_combine.rb index abc1234..def5678 100644 --- a/lib/rom/plugins/relation/sql/auto_combine.rb +++ b/lib/rom/plugins/relation/sql/auto_combine.rb @@ -42,8 +42,7 @@ # @api private def preload(source_key,...
Use .to_sym interface for keys
diff --git a/lib/sinatra-websocket/ext/sinatra/request.rb b/lib/sinatra-websocket/ext/sinatra/request.rb index abc1234..def5678 100644 --- a/lib/sinatra-websocket/ext/sinatra/request.rb +++ b/lib/sinatra-websocket/ext/sinatra/request.rb @@ -5,7 +5,8 @@ # Taken from skinny https://github.com/sj26/skinny and up...
Check if headers exist instead of crashing This should solve problems with Rack::Test, which does not pass the Connection header.
diff --git a/spec/decorators/category_navigation_decorator_spec.rb b/spec/decorators/category_navigation_decorator_spec.rb index abc1234..def5678 100644 --- a/spec/decorators/category_navigation_decorator_spec.rb +++ b/spec/decorators/category_navigation_decorator_spec.rb @@ -15,7 +15,7 @@ describe '#path' do le...
Fix typo / strange presence of `double`.
diff --git a/app/models/email_processor.rb b/app/models/email_processor.rb index abc1234..def5678 100644 --- a/app/models/email_processor.rb +++ b/app/models/email_processor.rb @@ -4,8 +4,12 @@ end def process + to = @email.to[0][:email] + if @email.headers && !@email.headers["X-Forwarded-To"].nil? + ...
Save the way to run the goodies
diff --git a/lib/sync_checker/formats/detailed_guide_check.rb b/lib/sync_checker/formats/detailed_guide_check.rb index abc1234..def5678 100644 --- a/lib/sync_checker/formats/detailed_guide_check.rb +++ b/lib/sync_checker/formats/detailed_guide_check.rb @@ -42,6 +42,10 @@ def related_mainstream_content_ids(edition...
Update Detailed Guide sync check rendering app Now checks that it is 'government-frontend'
diff --git a/lib/buildr_plus/features/source_code_analysis.rb b/lib/buildr_plus/features/source_code_analysis.rb index abc1234..def5678 100644 --- a/lib/buildr_plus/features/source_code_analysis.rb +++ b/lib/buildr_plus/features/source_code_analysis.rb @@ -13,6 +13,28 @@ # module BuildrPlus + class SourceCodeAnalys...
Make it possible to disable various source code analysis phases
diff --git a/auto_book.rb b/auto_book.rb index abc1234..def5678 100644 --- a/auto_book.rb +++ b/auto_book.rb @@ -13,5 +13,5 @@ latest_date: DateTime.parse(ENV.fetch('TEST_LATEST_DATE')) } -puts '[*] Running' +puts "[*] Run started at #{DateTime.now}" driver.run options
Print run time at start of run
diff --git a/spec/factories/drawings.rb b/spec/factories/drawings.rb index abc1234..def5678 100644 --- a/spec/factories/drawings.rb +++ b/spec/factories/drawings.rb @@ -4,7 +4,7 @@ description "Description of the content of this drawing" gender "other" age 10 - mood_rating 7 + mood_rating 4 sub...
Update drawing factory to make sure the mood_rating is between 1-5;
diff --git a/spec/models/author_spec.rb b/spec/models/author_spec.rb index abc1234..def5678 100644 --- a/spec/models/author_spec.rb +++ b/spec/models/author_spec.rb @@ -5,7 +5,6 @@ should_allow_values_for :name, "John Doe", :allow_nil => true should_validate_length_of :name, :minimum => 2, :maximum => 255 shoul...
Update spec to reflect changes in Author model
diff --git a/spec/subtime/timer_spec.rb b/spec/subtime/timer_spec.rb index abc1234..def5678 100644 --- a/spec/subtime/timer_spec.rb +++ b/spec/subtime/timer_spec.rb @@ -22,9 +22,10 @@ end end - context "for 10 minutes with messages" do + context "for 10 minutes with code blocks" do let(:minute...
Test for calling a code block
diff --git a/spec/support/dummy_view.rb b/spec/support/dummy_view.rb index abc1234..def5678 100644 --- a/spec/support/dummy_view.rb +++ b/spec/support/dummy_view.rb @@ -1,4 +1,4 @@-require 'action_view' +require "action_view" class DummyView < ActionView::Base module FakeRequest @@ -20,9 +20,11 @@ include Actio...
Update DummyView to pass in required arguments as required by Rails 6.1
diff --git a/app/models/report.rb b/app/models/report.rb index abc1234..def5678 100644 --- a/app/models/report.rb +++ b/app/models/report.rb @@ -21,7 +21,8 @@ validates :summary, length: { maximum: 40 } - validates :reuniter_name, :reuniter_email, - presence: true, if: proc {|r| r.reunited? } - + validates :...
Allow editing reunion_confirmation fields when reuniter info is missing
diff --git a/scripts/lint-groups.rb b/scripts/lint-groups.rb index abc1234..def5678 100644 --- a/scripts/lint-groups.rb +++ b/scripts/lint-groups.rb @@ -12,7 +12,22 @@ data.each_value do |group| group.each do |category| category['files'].each do |file| - files_in_groups << File.basename(file['path'...
Check duplicated entry in public/groups.json
diff --git a/scripts/list-routes.rb b/scripts/list-routes.rb index abc1234..def5678 100644 --- a/scripts/list-routes.rb +++ b/scripts/list-routes.rb @@ -5,9 +5,7 @@ routes_by_domain_url = {} -page = JSON.parse `cf curl '/v2/routes?results-per-page=100'` -next_url = page["next_url"] - +next_url = '/v2/routes?results...
Fix bug where the first page of results is skipped `page` was set to the next_url page before we looked at any of the resources on the first page.
diff --git a/scripts/npm_bundles.rb b/scripts/npm_bundles.rb index abc1234..def5678 100644 --- a/scripts/npm_bundles.rb +++ b/scripts/npm_bundles.rb @@ -4,22 +4,24 @@ npms = { # module name => module command # leave command blank if they are the same + "bower" => "", + "casperjs" => "", "coffee-script" => "c...
Refactor NPM modules install script
diff --git a/lib/rbNFA.rb b/lib/rbNFA.rb index abc1234..def5678 100644 --- a/lib/rbNFA.rb +++ b/lib/rbNFA.rb @@ -6,4 +6,10 @@ end end + + class Lexer + def lex(regexp) + return [] + end + end end
Add basic implementation for first test in regexp.
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -17,13 +17,6 @@ # limitations under the License. # -case node["platform"] -when "debian", "ubuntu" - package 'ruby1.9.1-dev' -when "redhat", "centos", "fedora" - -end - mysql_chef...
Revert "Added dependacy for mysql-chef-gem" This reverts commit 84f2f2fad79a882bcf6d97d69caf0f78099f52ed.
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -5,8 +5,9 @@ # Copyright (C) 2015 Sunggun Yu <sunggun.dev@gmail.com> # Copyright (C) 2015 Bloomberg Finance L.P. # + node.default['rabbitmq']['cluster'] = true -include_recipe 'rabb...
Use the plugin management cookbook to install any plugins.
diff --git a/test/spec/libraries/consul_installation_webui_spec.rb b/test/spec/libraries/consul_installation_webui_spec.rb index abc1234..def5678 100644 --- a/test/spec/libraries/consul_installation_webui_spec.rb +++ b/test/spec/libraries/consul_installation_webui_spec.rb @@ -15,7 +15,6 @@ end it do - p...
Move spec tests to use poise-archive matchers
diff --git a/test/unit/govuk_index/elasticsearch_processor_test.rb b/test/unit/govuk_index/elasticsearch_processor_test.rb index abc1234..def5678 100644 --- a/test/unit/govuk_index/elasticsearch_processor_test.rb +++ b/test/unit/govuk_index/elasticsearch_processor_test.rb @@ -4,7 +4,7 @@ def test_should_save_valid_do...
Add unit test for deletion of valid document This was previous part of https://github.com/alphagov/rummager/pull/864 which is closed. However it is still a useful test.
diff --git a/lib/active_exchanger.rb b/lib/active_exchanger.rb index abc1234..def5678 100644 --- a/lib/active_exchanger.rb +++ b/lib/active_exchanger.rb @@ -19,5 +19,5 @@ require 'active_exchanger/supervisor' Dir.glob(Rails.root.join('app', 'exchangers', '**', '*.rb')).each do |path| - require path + require_depen...
Use require_dependency instead of require in ActiveExchanger so we don't re-require all exchangers again.
diff --git a/app/controllers/georgia/concerns/revisioning.rb b/app/controllers/georgia/concerns/revisioning.rb index abc1234..def5678 100644 --- a/app/controllers/georgia/concerns/revisioning.rb +++ b/app/controllers/georgia/concerns/revisioning.rb @@ -18,7 +18,7 @@ @revision.approve message = "#{c...
Fix :show urls and notify url
diff --git a/app/controllers/spree/admin/zones_controller.rb b/app/controllers/spree/admin/zones_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/admin/zones_controller.rb +++ b/app/controllers/spree/admin/zones_controller.rb @@ -24,8 +24,13 @@ def permitted_resource_params param...
Add missing permitted attributes to zones
diff --git a/app/helpers/mongoid_forums/formatting_helper.rb b/app/helpers/mongoid_forums/formatting_helper.rb index abc1234..def5678 100644 --- a/app/helpers/mongoid_forums/formatting_helper.rb +++ b/app/helpers/mongoid_forums/formatting_helper.rb @@ -10,7 +10,7 @@ end def as_quoted_text(text) - if Mon...
Remove accidental reminant of Forem
diff --git a/buffered-logger.gemspec b/buffered-logger.gemspec index abc1234..def5678 100644 --- a/buffered-logger.gemspec +++ b/buffered-logger.gemspec @@ -15,7 +15,6 @@ gem.required_ruby_version = ">= 1.9.2" - gem.add_development_dependency "bundler", "~> 1.1" gem.add_development_dependency "mocha", "~> 0.1...
Remove bundler as a development dependency
diff --git a/app/serializers/councillor_detail_serializer.rb b/app/serializers/councillor_detail_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/councillor_detail_serializer.rb +++ b/app/serializers/councillor_detail_serializer.rb @@ -4,5 +4,6 @@ has_one :ward has_many :motions + has_many :counci...
Add a Councillor's Vote In Their Details Page
diff --git a/lib/ember-dev/config.rb b/lib/ember-dev/config.rb index abc1234..def5678 100644 --- a/lib/ember-dev/config.rb +++ b/lib/ember-dev/config.rb @@ -15,6 +15,7 @@ attr_accessor :testing_additional_requires attr_accessor :testing_needs_ember_data attr_accessor :testing_ember + attr_accessor :das...
Allow dasherized_name to be specified.
diff --git a/spec/lib/gitlab/serializer/pagination_spec.rb b/spec/lib/gitlab/serializer/pagination_spec.rb index abc1234..def5678 100644 --- a/spec/lib/gitlab/serializer/pagination_spec.rb +++ b/spec/lib/gitlab/serializer/pagination_spec.rb @@ -3,11 +3,14 @@ describe Gitlab::Serializer::Pagination do let(:request) {...
Make headers asserts explicit in pagination specs
diff --git a/lib/optioneer/option.rb b/lib/optioneer/option.rb index abc1234..def5678 100644 --- a/lib/optioneer/option.rb +++ b/lib/optioneer/option.rb @@ -1,22 +1,22 @@ module Optioneer - # This class will be instantiated for each individual option registered. + # an instance will be created for each individual opt...
Rename the short, long etc methods Signed-off-by: Grant Ramsay <4ab1b2fdb7784a8f9b55e81e3261617f44fd0585@gmail.com>
diff --git a/app/models/concerns/gobierto_common/acts_as_api_token.rb b/app/models/concerns/gobierto_common/acts_as_api_token.rb index abc1234..def5678 100644 --- a/app/models/concerns/gobierto_common/acts_as_api_token.rb +++ b/app/models/concerns/gobierto_common/acts_as_api_token.rb @@ -11,8 +11,7 @@ belongs_t...
Allow blank names in not primary api tokens
diff --git a/lib/taxjar/line_item.rb b/lib/taxjar/line_item.rb index abc1234..def5678 100644 --- a/lib/taxjar/line_item.rb +++ b/lib/taxjar/line_item.rb @@ -4,6 +4,7 @@ class LineItem < Taxjar::Base extend ModelAttribute + attribute :id, :integer attribute :quantity, :inte...
Add `id` attribute to LineItem
diff --git a/lib/teamcity/request.rb b/lib/teamcity/request.rb index abc1234..def5678 100644 --- a/lib/teamcity/request.rb +++ b/lib/teamcity/request.rb @@ -2,32 +2,38 @@ # Defines HTTP request methods module Request # Perform an HTTP GET request - def get(path, &block) - request(:get, path, &block) +...
Add the options params back since I'll be using those instead of the build locator in another branch
diff --git a/TheSpot/spec/controllers/users_controller_spec.rb b/TheSpot/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/TheSpot/spec/controllers/users_controller_spec.rb +++ b/TheSpot/spec/controllers/users_controller_spec.rb @@ -0,0 +1,22 @@+require 'spec_helper' +require 'rails_helper' ...
Add outline of users_controller tests
diff --git a/bean_counter.gemspec b/bean_counter.gemspec index abc1234..def5678 100644 --- a/bean_counter.gemspec +++ b/bean_counter.gemspec @@ -19,7 +19,7 @@ spec.require_paths = ['lib'] spec.add_dependency 'beaneater' - spec.add_dependency 'stalk_climber', '>= 0.0.6' + spec.add_dependency 'stalk_climber', '>...
Update minimum required version of StalkClimber
diff --git a/app/constraints/feature_toggle_constraint.rb b/app/constraints/feature_toggle_constraint.rb index abc1234..def5678 100644 --- a/app/constraints/feature_toggle_constraint.rb +++ b/app/constraints/feature_toggle_constraint.rb @@ -1,4 +1,6 @@ # frozen_string_literal: true + +require "open_food_network/feature...
Allow devs to lazy-load app with right dependency
diff --git a/app/controllers/projects/hooks_controller.rb b/app/controllers/projects/hooks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/projects/hooks_controller.rb +++ b/app/controllers/projects/hooks_controller.rb @@ -18,7 +18,7 @@ if @hook.valid? redirect_to project_hooks_path(@projec...
Fix url generation error on hook invalid create
diff --git a/Casks/vagrant-bar.rb b/Casks/vagrant-bar.rb index abc1234..def5678 100644 --- a/Casks/vagrant-bar.rb +++ b/Casks/vagrant-bar.rb @@ -1,8 +1,8 @@ cask :v1 => 'vagrant-bar' do - version '1.15' - sha256 'dc4f77ad00e2751e7375eab0172323d9bd9110ced170dc4033036b530ed7fdeb' + version '1.16' + sha256 'f5c5869096...
Update Vagrant Bar to v1.16
diff --git a/engine/wikimedia_image.rb b/engine/wikimedia_image.rb index abc1234..def5678 100644 --- a/engine/wikimedia_image.rb +++ b/engine/wikimedia_image.rb @@ -15,7 +15,7 @@ name = wikimedia_image_name(url) return nil if name.nil? api_url = wikimedia_image_api_url(name) - r...
Replace another instance of open with URI.open
diff --git a/config/deploy/staging.rb b/config/deploy/staging.rb index abc1234..def5678 100644 --- a/config/deploy/staging.rb +++ b/config/deploy/staging.rb @@ -21,6 +21,8 @@ on_rollback { run "rm #{release_path}/config/database.yml" } run "rm #{release_path}/config/database.yml" run "ln -s #{db_config} #{relea...
Change to deployment recipe to support nginx deploy
diff --git a/IBMWatsonRestKit.podspec b/IBMWatsonRestKit.podspec index abc1234..def5678 100644 --- a/IBMWatsonRestKit.podspec +++ b/IBMWatsonRestKit.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = 'IBMWatsonRestKit' - s.version = '0.32.0' + s.version = '0.33.0' ...
Prepare RestKit for its first Cocoapods release
diff --git a/lib/knife-solo/node_config_command.rb b/lib/knife-solo/node_config_command.rb index abc1234..def5678 100644 --- a/lib/knife-solo/node_config_command.rb +++ b/lib/knife-solo/node_config_command.rb @@ -25,7 +25,7 @@ def generate_node_config if node_config.exist? - ui.msg "Node config '#{n...
Use debug message when node config already exists
diff --git a/lib/paperclip/dropbox/tasks/authorize.rake b/lib/paperclip/dropbox/tasks/authorize.rake index abc1234..def5678 100644 --- a/lib/paperclip/dropbox/tasks/authorize.rake +++ b/lib/paperclip/dropbox/tasks/authorize.rake @@ -4,6 +4,9 @@ namespace :dropbox do desc "Obtains your Dropbox credentials" task :a...
Raise error in the rake task if the credentials were not given
diff --git a/jot.podspec b/jot.podspec index abc1234..def5678 100644 --- a/jot.podspec +++ b/jot.podspec @@ -10,7 +10,7 @@ "Devin Foley" => "devin@ifttt.com" } #s.source = { :git => "https://github.com/IFTTT/jot.git", :tag => s.version.to_s } - s.source = { ...
Update pod spec to link to this repo.
diff --git a/lib/sinatra/asset_snack/precompile.rb b/lib/sinatra/asset_snack/precompile.rb index abc1234..def5678 100644 --- a/lib/sinatra/asset_snack/precompile.rb +++ b/lib/sinatra/asset_snack/precompile.rb @@ -2,14 +2,16 @@ module Sinatra module AssetSnack - extend InstanceMethods - def self.precompile!...
Extend anonymous module instead of AssetSnack itself; also be more explicit about it to appease Travis
diff --git a/config/initializers/new_framework_defaults.rb b/config/initializers/new_framework_defaults.rb index abc1234..def5678 100644 --- a/config/initializers/new_framework_defaults.rb +++ b/config/initializers/new_framework_defaults.rb @@ -20,6 +20,3 @@ # Require `belongs_to` associations by default. Previous ve...
Remove non-existent initializer config option - By the looks of things, `halt_callback_chains_on_return_false` arrived in a Rails version prior to 5.1 (there's a separate initializer config for 5.1) and is now gone, [having been deprecated in 2017](https://github.com/rails/rails/pull/27940).
diff --git a/lib/awsraw.rb b/lib/awsraw.rb index abc1234..def5678 100644 --- a/lib/awsraw.rb +++ b/lib/awsraw.rb @@ -1,6 +1,8 @@+require "awsraw/error" require "awsraw/version" require "awsraw/s3/canonicalized_resource" require "awsraw/s3/client" +require "awsraw/s3/content_md5_header" require "awsraw/s3/faraday_mi...
Add missing requires to top level.
diff --git a/lib/barcelona/network/auto_scaling_group.rb b/lib/barcelona/network/auto_scaling_group.rb index abc1234..def5678 100644 --- a/lib/barcelona/network/auto_scaling_group.rb +++ b/lib/barcelona/network/auto_scaling_group.rb @@ -30,7 +30,7 @@ j.MaxBatchSize 1 j.MinInstancesInService des...
Set CF timeout to 15 minutes
diff --git a/db/schema.rb b/db/schema.rb index abc1234..def5678 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -0,0 +1,71 @@+# encoding: UTF-8 +# This file is auto-generated from the current state of the database. Instead +# of editing this file, please use the migrations feature of Active Record to +# incrementally m...
Add Schema File to Run Server With Seed File
diff --git a/db/schema.rb b/db/schema.rb index abc1234..def5678 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -11,7 +11,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 20141017041439) do +ActiveRecord::Schema.define(version: 201410...
Add migration which adds event_photo field to events table
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -8,7 +8,7 @@ end def update - if current_user.update_attributes(user_params) + if current_user.update(u...
Fix Rails 6.1 deprecation warning
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -9,4 +9,8 @@ @test = @user.questions #@question = Question.order("comments_count, created_at DESC")#n...
Create User controller edit method
diff --git a/lib/omniauth/strategies/wordpress_hosted.rb b/lib/omniauth/strategies/wordpress_hosted.rb index abc1234..def5678 100644 --- a/lib/omniauth/strategies/wordpress_hosted.rb +++ b/lib/omniauth/strategies/wordpress_hosted.rb @@ -8,7 +8,7 @@ # This is where you pass the options you would pass when ...
Update endpoints used by WP OAuth Server 3.1.3
diff --git a/app/models/clone_ticket_settings.rb b/app/models/clone_ticket_settings.rb index abc1234..def5678 100644 --- a/app/models/clone_ticket_settings.rb +++ b/app/models/clone_ticket_settings.rb @@ -8,7 +8,7 @@ #safe_attributes 'dst_project_id', 'dst_tracker_id', 'copy_attachment', 'copy_children', 'copy_relate...
Change inst method to class method
diff --git a/app/presenters/details_presenter.rb b/app/presenters/details_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/details_presenter.rb +++ b/app/presenters/details_presenter.rb @@ -2,12 +2,11 @@ module Presenters class DetailsPresenter - attr_reader :content_item_details, :body + attr...
Refactor to consolidate logic about body format Replace the few bits of code related to whether the body is a string, hash or array-of-hashes with a single decision (in the form of a factory method). A bit more code but hopefully (perhaps?) easier to understand.
diff --git a/lib/alchemy/solidus/alchemy_user_extension.rb b/lib/alchemy/solidus/alchemy_user_extension.rb index abc1234..def5678 100644 --- a/lib/alchemy/solidus/alchemy_user_extension.rb +++ b/lib/alchemy/solidus/alchemy_user_extension.rb @@ -1,6 +1,10 @@ module Alchemy module Solidus module AlchemyUserExtens...
Include Spree::UserMethods in Alchemy::User extension Without that the Alchemy::User is no proper Spree.user_class
diff --git a/app/view_models/effort_show_view.rb b/app/view_models/effort_show_view.rb index abc1234..def5678 100644 --- a/app/view_models/effort_show_view.rb +++ b/app/view_models/effort_show_view.rb @@ -22,7 +22,7 @@ splits.each do |split| split_row = SplitRow.new(split, related_split_times(split), prior_t...
Fix bug that prevented certain split_rows from showing a segment time.
diff --git a/app/controllers/api_controller/error_handler.rb b/app/controllers/api_controller/error_handler.rb index abc1234..def5678 100644 --- a/app/controllers/api_controller/error_handler.rb +++ b/app/controllers/api_controller/error_handler.rb @@ -31,6 +31,8 @@ :message => message, :klass => kla...
Include backtrace in error response in tests I always add the backtrace to the error response when developing a new feature or debugging to enhance feedback in request specs, which can be a bit opaque. I'm proposing that we make this a default in the test environment.
diff --git a/lib/fog/aliyun/requests/storage/get_object.rb b/lib/fog/aliyun/requests/storage/get_object.rb index abc1234..def5678 100644 --- a/lib/fog/aliyun/requests/storage/get_object.rb +++ b/lib/fog/aliyun/requests/storage/get_object.rb @@ -30,7 +30,7 @@ end if block_given? - http_...
Fix "ArgumentError: tried to create Proc object without a block"
diff --git a/api/app/controllers/spree/api/line_items_controller.rb b/api/app/controllers/spree/api/line_items_controller.rb index abc1234..def5678 100644 --- a/api/app/controllers/spree/api/line_items_controller.rb +++ b/api/app/controllers/spree/api/line_items_controller.rb @@ -5,7 +5,7 @@ def create ...
[api] Allow especially overriden attribute setters for line items Fixes #2916
diff --git a/lib/patronus_fati/data_models/common_state.rb b/lib/patronus_fati/data_models/common_state.rb index abc1234..def5678 100644 --- a/lib/patronus_fati/data_models/common_state.rb +++ b/lib/patronus_fati/data_models/common_state.rb @@ -13,13 +13,13 @@ new? || data_dirty? || status_dirty? end -...
Change logic on new? checks to make use of the other helpers
diff --git a/lib/sprockets/source_map_comment_processor.rb b/lib/sprockets/source_map_comment_processor.rb index abc1234..def5678 100644 --- a/lib/sprockets/source_map_comment_processor.rb +++ b/lib/sprockets/source_map_comment_processor.rb @@ -1,4 +1,7 @@ # frozen_string_literal: true +require 'sprockets/uri_utils' +r...
Fix index alias source maps
diff --git a/cookbooks/chef-server-deploy/libraries/helpers.rb b/cookbooks/chef-server-deploy/libraries/helpers.rb index abc1234..def5678 100644 --- a/cookbooks/chef-server-deploy/libraries/helpers.rb +++ b/cookbooks/chef-server-deploy/libraries/helpers.rb @@ -14,6 +14,6 @@ end end -Chef::Node.send(:include, ChefO...
Fix new chefstyle finding in chef-server-deploy cookbooks As a follow up we should look at removing these cookbooks as I don't think they are required anymore. Signed-off-by: Steven Danna <9ce5770b3bb4b2a1d59be2d97e34379cd192299f@chef.io>
diff --git a/NSExtensions.podspec b/NSExtensions.podspec index abc1234..def5678 100644 --- a/NSExtensions.podspec +++ b/NSExtensions.podspec @@ -1,12 +1,12 @@ Pod::Spec.new do |s| s.name = "NSExtensions" - s.version = "0.0.2" + s.version = "0.0.3" s.summary = "A collection of useful exten...
Update podspec to version 0.0.3
diff --git a/app/controllers/users/omniauth_callbacks_controller.rb b/app/controllers/users/omniauth_callbacks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users/omniauth_callbacks_controller.rb +++ b/app/controllers/users/omniauth_callbacks_controller.rb @@ -1,4 +1,8 @@ class Users::OmniauthCallba...
Fix login failure redirect path
diff --git a/app/controllers/users/omniauth_callbacks_controller.rb b/app/controllers/users/omniauth_callbacks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users/omniauth_callbacks_controller.rb +++ b/app/controllers/users/omniauth_callbacks_controller.rb @@ -2,8 +2,13 @@ def github @user...
Change after sign-in behaviour depending on sign in count
diff --git a/app/helpers/budgets_helper.rb b/app/helpers/budgets_helper.rb index abc1234..def5678 100644 --- a/app/helpers/budgets_helper.rb +++ b/app/helpers/budgets_helper.rb @@ -42,4 +42,9 @@ def investment_tags_select_options Budget::Investment.tags_on(:valuation).order(:name).select(:name).distinct end +...
Add budget_published? helper method to BudgetHelper We need to check if the budget is in drafting phase to avoid showing it to the users, unless the current user is an administrator.
diff --git a/db/migrate/20100811222824_allow_null_in_posts_columns.rb b/db/migrate/20100811222824_allow_null_in_posts_columns.rb index abc1234..def5678 100644 --- a/db/migrate/20100811222824_allow_null_in_posts_columns.rb +++ b/db/migrate/20100811222824_allow_null_in_posts_columns.rb @@ -0,0 +1,17 @@+class AllowNullInP...
Allow null in posts columns
diff --git a/db/migrate/20161014194032_add_tags_to_articles.rb b/db/migrate/20161014194032_add_tags_to_articles.rb index abc1234..def5678 100644 --- a/db/migrate/20161014194032_add_tags_to_articles.rb +++ b/db/migrate/20161014194032_add_tags_to_articles.rb @@ -1,5 +1,5 @@ class AddTagsToArticles < ActiveRecord::Migrati...
Remove default to make it work with both sqlite and postgres Postgres doesn't accept array: true and default: string("[]"). So, simply remove the default. Anyway, the next migration changes it to a simple string column.
diff --git a/test/sepa/banks/nordea/nordea_renew_cert_request_soap_builder_test.rb b/test/sepa/banks/nordea/nordea_renew_cert_request_soap_builder_test.rb index abc1234..def5678 100644 --- a/test/sepa/banks/nordea/nordea_renew_cert_request_soap_builder_test.rb +++ b/test/sepa/banks/nordea/nordea_renew_cert_request_soap...
Add test suite for Nordea renew certificate soap
diff --git a/test/redimap/version.rb b/test/redimap/version.rb index abc1234..def5678 100644 --- a/test/redimap/version.rb +++ b/test/redimap/version.rb @@ -3,7 +3,7 @@ require_relative '../../lib/redimap/version' -describe Redimap::VERSION do +describe "Redimap::VERSION" do subject { Redimap::VERSION }
Fix string description of Redimap::VERSION test.