diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/lumberjack/device.rb b/lib/lumberjack/device.rb index abc1234..def5678 100644 --- a/lib/lumberjack/device.rb +++ b/lib/lumberjack/device.rb @@ -11,7 +11,7 @@ # Subclasses must implement this method to write a LogEntry. def write(entry) - raise NotImpelementedError + raise NotImplem...
Fix error class name typo
diff --git a/lib/biblio_commons/title.rb b/lib/biblio_commons/title.rb index abc1234..def5678 100644 --- a/lib/biblio_commons/title.rb +++ b/lib/biblio_commons/title.rb @@ -29,9 +29,13 @@ titles["title"] end - # Returns the first UPC (if present) or ISBN. + # Returns the first UPC or ISBN. def u...
Fix bug where if neither UPC/ISBN present, exception was raised.
diff --git a/lib/ramesh/image_util.rb b/lib/ramesh/image_util.rb index abc1234..def5678 100644 --- a/lib/ramesh/image_util.rb +++ b/lib/ramesh/image_util.rb @@ -14,8 +14,8 @@ begin image_list = [ Image.from_blob(open(BACKGROUND_IMAGE_URL).read).shift, - Image.from_blob...
Change the order of layers
diff --git a/spec/controllers/friendships_controller_spec.rb b/spec/controllers/friendships_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/friendships_controller_spec.rb +++ b/spec/controllers/friendships_controller_spec.rb @@ -24,5 +24,27 @@ end describe "DELETE #destroy" do + let(:u...
Create tests for friendship deletion
diff --git a/spec/controllers/retirements_controller_spec.rb b/spec/controllers/retirements_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/retirements_controller_spec.rb +++ b/spec/controllers/retirements_controller_spec.rb @@ -1,4 +1,4 @@-RSpec.describe RetirementsController, type: :controller...
Fix wrong feature flag in RetirementsController spec.
diff --git a/lib/sales_tax/receipt.rb b/lib/sales_tax/receipt.rb index abc1234..def5678 100644 --- a/lib/sales_tax/receipt.rb +++ b/lib/sales_tax/receipt.rb @@ -1,9 +1,59 @@ module SalesTax class Receipt + def initialize(args = {}) + @items = args[:items] || [] + end + def add_item(item) + items...
Implement Receipt class, green specs
diff --git a/spec/features/signing_a_user_in_feature_spec.rb b/spec/features/signing_a_user_in_feature_spec.rb index abc1234..def5678 100644 --- a/spec/features/signing_a_user_in_feature_spec.rb +++ b/spec/features/signing_a_user_in_feature_spec.rb @@ -0,0 +1,13 @@+require 'rails_helper' +describe "the sign in process"...
Add basic feature tests for user login; all tests pass
diff --git a/lib/embiggen/http_client.rb b/lib/embiggen/http_client.rb index abc1234..def5678 100644 --- a/lib/embiggen/http_client.rb +++ b/lib/embiggen/http_client.rb @@ -2,7 +2,7 @@ require 'net/http' module Embiggen - class GetWithoutResponse < ::Net::HTTPRequest + class GetWithoutBody < ::Net::HTTPRequest ...
Use clearer class name in HTTP client We create our own special HTTP request subclass in order to send a GET request without reading the body but the class name misleadingly says it is without response (which isn't true). Rename the class to GetWithoutBody which hopefully makes this a little clearer.
diff --git a/app/jobs/sendgrid_notification/sendmail_job.rb b/app/jobs/sendgrid_notification/sendmail_job.rb index abc1234..def5678 100644 --- a/app/jobs/sendgrid_notification/sendmail_job.rb +++ b/app/jobs/sendgrid_notification/sendmail_job.rb @@ -9,7 +9,7 @@ def perform(to, notification_mail, params, hash_attachm...
Fix attachment hash keys to symbolize
diff --git a/lib/terrestrial/error.rb b/lib/terrestrial/error.rb index abc1234..def5678 100644 --- a/lib/terrestrial/error.rb +++ b/lib/terrestrial/error.rb @@ -1,3 +1,26 @@ module Terrestrial Error = Module.new + + class LoadError < RuntimeError + include Error + + def initialize(relation_name, factory, reco...
Introduce LoadError, mixing in Terrestrial::Error
diff --git a/lib/global_phone/context.rb b/lib/global_phone/context.rb index abc1234..def5678 100644 --- a/lib/global_phone/context.rb +++ b/lib/global_phone/context.rb @@ -30,7 +30,7 @@ def validate(string, territory_name = default_territory_name) number = parse(string, territory_name) - number && nu...
Return false if the number passed to GlobalPhone.validate is invalid. Currently the code returns either true or nil
diff --git a/api-docs/uceem_api.rb b/api-docs/uceem_api.rb index abc1234..def5678 100644 --- a/api-docs/uceem_api.rb +++ b/api-docs/uceem_api.rb @@ -48,4 +48,9 @@ get '/activities' do markdown(:activities) -end+end + +get '/all.css' do + content_type 'text/css', charset: 'utf-8' + scss(:'../public/scss/all') +en...
Create route for scss assets.
diff --git a/sidekiq/3-signal-handling/worker.rb b/sidekiq/3-signal-handling/worker.rb index abc1234..def5678 100644 --- a/sidekiq/3-signal-handling/worker.rb +++ b/sidekiq/3-signal-handling/worker.rb @@ -13,6 +13,10 @@ sleep 10 puts "Bear with me" else + while true do + sleep 1 + p...
Add infinite loop to test Signals
diff --git a/lib/avalon/sanitizer.rb b/lib/avalon/sanitizer.rb index abc1234..def5678 100644 --- a/lib/avalon/sanitizer.rb +++ b/lib/avalon/sanitizer.rb @@ -14,7 +14,7 @@ module Avalon module Sanitizer - def self.sanitize(name, translations=['\\/ &:.','______']) + def self.sanitize(name, translations=['\\/ &...
Convert ?s in collection dropbox name
diff --git a/lib/active_node/validations/uniqueness_validator.rb b/lib/active_node/validations/uniqueness_validator.rb index abc1234..def5678 100644 --- a/lib/active_node/validations/uniqueness_validator.rb +++ b/lib/active_node/validations/uniqueness_validator.rb @@ -10,10 +10,11 @@ private def other_ma...
Update uniqieness lookup by id to use neo4j's id(n)
diff --git a/lib/openlogi/base_object.rb b/lib/openlogi/base_object.rb index abc1234..def5678 100644 --- a/lib/openlogi/base_object.rb +++ b/lib/openlogi/base_object.rb @@ -1,6 +1,9 @@+require "openlogi/errors" + module Openlogi class BaseObject < Hashie::Dash include Hashie::Extensions::Dash::Coercion + in...
Include Hashie::Extensions::MergeInitializer in base object
diff --git a/adash.gemspec b/adash.gemspec index abc1234..def5678 100644 --- a/adash.gemspec +++ b/adash.gemspec @@ -9,8 +9,8 @@ spec.authors = ["Code Ass"] spec.email = ["aycabta@gmail.com"] - spec.summary = %q{Adash} - spec.description = %q{Adash} + spec.summary = %q{Adash is a D...
Fix .spec summary and description
diff --git a/lib/rspec/rails/example/controller_example_group.rb b/lib/rspec/rails/example/controller_example_group.rb index abc1234..def5678 100644 --- a/lib/rspec/rails/example/controller_example_group.rb +++ b/lib/rspec/rails/example/controller_example_group.rb @@ -20,6 +20,10 @@ def params_from(method, path) ...
Add helper for setting a raw post body
diff --git a/lib/scss_lint/linter/id_with_extraneous_selector.rb b/lib/scss_lint/linter/id_with_extraneous_selector.rb index abc1234..def5678 100644 --- a/lib/scss_lint/linter/id_with_extraneous_selector.rb +++ b/lib/scss_lint/linter/id_with_extraneous_selector.rb @@ -7,7 +7,12 @@ id_sel = seq.members.find { |sim...
Fix Rubocop lints in IdWithExtraneousSelector Change-Id: Ib06958a78c715c01349fa38db793565fdfa771d9 Reviewed-on: http://gerrit.causes.com/36710 Tested-by: jenkins <d95b56ce41a2e1ac4cecdd398defd7414407cc08@causes.com> Reviewed-by: Shane da Silva <6f6e68d1df92f30cb4b3ce35260ddf94a402f33d@causes.com>
diff --git a/app/controllers/rglossa/corpora_controller.rb b/app/controllers/rglossa/corpora_controller.rb index abc1234..def5678 100644 --- a/app/controllers/rglossa/corpora_controller.rb +++ b/app/controllers/rglossa/corpora_controller.rb @@ -28,11 +28,8 @@ render json: { corpus: @corpus.as_j...
Return metadata embedded when loading a particular corpus
diff --git a/test/standard_api/controller/create_test.rb b/test/standard_api/controller/create_test.rb index abc1234..def5678 100644 --- a/test/standard_api/controller/create_test.rb +++ b/test/standard_api/controller/create_test.rb @@ -0,0 +1,27 @@+require 'standard_api/test_helper' + +class PropertiesControllerTest <...
Add test for creating/updating with an invalid includes
diff --git a/spec/features/show_bounties_spec.rb b/spec/features/show_bounties_spec.rb index abc1234..def5678 100644 --- a/spec/features/show_bounties_spec.rb +++ b/spec/features/show_bounties_spec.rb @@ -0,0 +1,29 @@+require 'spec_helper' + +describe 'showing all bounties' do + let!(:user) { User.make! } + let!(:pro...
Check to make sure bounties are filtered correctly
diff --git a/refinerycms-multisites.gemspec b/refinerycms-multisites.gemspec index abc1234..def5678 100644 --- a/refinerycms-multisites.gemspec +++ b/refinerycms-multisites.gemspec @@ -4,9 +4,9 @@ s.platform = Gem::Platform::RUBY s.name = 'refinerycms-multisites' s.version = '1.0...
Fix gemspec desc and sum
diff --git a/spec/lita/handlers/hal_9000_spec.rb b/spec/lita/handlers/hal_9000_spec.rb index abc1234..def5678 100644 --- a/spec/lita/handlers/hal_9000_spec.rb +++ b/spec/lita/handlers/hal_9000_spec.rb @@ -2,4 +2,10 @@ describe Lita::Handlers::Hal9000, lita_handler: true do it { is_expected.to route_event(:unhandle...
Add test for sending unknown command
diff --git a/spec/models/email_processor_spec.rb b/spec/models/email_processor_spec.rb index abc1234..def5678 100644 --- a/spec/models/email_processor_spec.rb +++ b/spec/models/email_processor_spec.rb @@ -12,7 +12,7 @@ it "creates an entry even if the email address is uppercase" do user = create(:user) ...
Use double quotes for @houndci
diff --git a/spec/models/lab_description_spec.rb b/spec/models/lab_description_spec.rb index abc1234..def5678 100644 --- a/spec/models/lab_description_spec.rb +++ b/spec/models/lab_description_spec.rb @@ -1,9 +1,29 @@ describe LabDescription do - it "defaults to true" do - create(:lab_description).should be_valid +...
Create basic specs for LabDescription, all validations passes
diff --git a/rack-allocation_stats.gemspec b/rack-allocation_stats.gemspec index abc1234..def5678 100644 --- a/rack-allocation_stats.gemspec +++ b/rack-allocation_stats.gemspec @@ -10,8 +10,7 @@ spec.summary = "Rack middleware for tracing object allocations in Ruby 2.1" spec.description = "Rack middleware ...
Include non-Ruby files in gem package The interactive mode was not working because the gem package did not contain the non-Ruby files needed to run it. This commit opens up the file inclusion to anything under lib and spec.
diff --git a/lita-github-commits.gemspec b/lita-github-commits.gemspec index abc1234..def5678 100644 --- a/lita-github-commits.gemspec +++ b/lita-github-commits.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |spec| spec.name = "lita-github-commits" - spec.version = "0.0.1" + spec.version = ...
Update gemspec for Lita 3.0 compatibility.
diff --git a/lib/bootstrap-sass.rb b/lib/bootstrap-sass.rb index abc1234..def5678 100644 --- a/lib/bootstrap-sass.rb +++ b/lib/bootstrap-sass.rb @@ -7,8 +7,7 @@ require 'sass-rails' # See: https://github.com/thomas-mcdonald/bootstrap-sass/pull/4 require 'bootstrap-sass/engine' require 'bootstrap-sas...
Revert "support for rails w/compass" This reverts commit 0cea6384c87fc88ba3503999ed808f3f833c7b43. I had not considered the side effect of loading all the compass setup, since this will mean that Rails' asset-url is overridden, or some side effect will come about as a result.
diff --git a/.delivery/build_cookbook/recipes/_install_docker.rb b/.delivery/build_cookbook/recipes/_install_docker.rb index abc1234..def5678 100644 --- a/.delivery/build_cookbook/recipes/_install_docker.rb +++ b/.delivery/build_cookbook/recipes/_install_docker.rb @@ -5,14 +5,14 @@ package "docker-engine" -execute ...
Use remote_file instead of execute-n-curl Check that the docker-compose we download is the one we expect with a checksum. Also don't need to uname things because we only use 64-bit Linux builders for this pipeline. Signed-off-by: Robb Kidd <11cd4f9ba93acb67080ee4dad8d03929f9e64bf2@chef.io>
diff --git a/app/views/api/v1/divisions/show.json.jbuilder b/app/views/api/v1/divisions/show.json.jbuilder index abc1234..def5678 100644 --- a/app/views/api/v1/divisions/show.json.jbuilder +++ b/app/views/api/v1/divisions/show.json.jbuilder @@ -7,7 +7,7 @@ json.possible_turnout @division.division_info.possible_turnout ...
Use summary rather than motion text in api
diff --git a/backend/lib/tasks/rubocop_brakeman_rspec.rake b/backend/lib/tasks/rubocop_brakeman_rspec.rake index abc1234..def5678 100644 --- a/backend/lib/tasks/rubocop_brakeman_rspec.rake +++ b/backend/lib/tasks/rubocop_brakeman_rspec.rake @@ -0,0 +1,55 @@+require 'rubocop/rake_task' +require 'rspec/core/rake_task' + ...
Write rubocop rspec and test rakefile
diff --git a/cookbooks/chef/attributes/default.rb b/cookbooks/chef/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/chef/attributes/default.rb +++ b/cookbooks/chef/attributes/default.rb @@ -2,7 +2,7 @@ default[:apt][:sources] = node[:apt][:sources] | [ "opscode" ] # Set the default client version ...
Upgrade chef client to 11.8.0
diff --git a/lib/resqued/daemon.rb b/lib/resqued/daemon.rb index abc1234..def5678 100644 --- a/lib/resqued/daemon.rb +++ b/lib/resqued/daemon.rb @@ -23,6 +23,7 @@ exit else # master + rd.close @master.run(wr) end end
Clean up a leaky pipe.
diff --git a/lib/right_on/rails.rb b/lib/right_on/rails.rb index abc1234..def5678 100644 --- a/lib/right_on/rails.rb +++ b/lib/right_on/rails.rb @@ -1,7 +1,12 @@ require 'right_on/role_model' +require 'right_on/ability' +require 'right_on/rule' +require 'right_on/error' require 'right_on/right' require 'right_on/role...
Fix requires to get everything working
diff --git a/app/presenters/finders/finder_rummager_presenter.rb b/app/presenters/finders/finder_rummager_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/finders/finder_rummager_presenter.rb +++ b/app/presenters/finders/finder_rummager_presenter.rb @@ -9,12 +9,12 @@ def to_json { - title: ...
Sort keys in rummager payload
diff --git a/lib/MrMurano/version.rb b/lib/MrMurano/version.rb index abc1234..def5678 100644 --- a/lib/MrMurano/version.rb +++ b/lib/MrMurano/version.rb @@ -1,4 +1,13 @@+# Last Modified: 2017.07.01 /coding: utf-8 +# frozen_string_literal: true + +# Copyright © 2016-2017 Exosite LLC. +# License: MIT. See LICENSE.txt. +#...
Add EXE_NAME and SIGN_UP_URL to MrMurano module. - Also add copyright and license header. - Rubocop: Add `# frozen_string_literal: true` header comment. - Rubocop: Do not `.freeze` immutable object.
diff --git a/lib/caching/response.rb b/lib/caching/response.rb index abc1234..def5678 100644 --- a/lib/caching/response.rb +++ b/lib/caching/response.rb @@ -16,10 +16,14 @@ end def ttl - cache_control[/max-age=([0-9]+)/, 1] || 0 if cache_control == 'no-cache' + max_age.to_i end private ...
Refactor and correct ttl for when max-age is defined
diff --git a/lib/cassandra/pooled.rb b/lib/cassandra/pooled.rb index abc1234..def5678 100644 --- a/lib/cassandra/pooled.rb +++ b/lib/cassandra/pooled.rb @@ -18,8 +18,7 @@ client.disconnect! if client end - # Method not supported (yet?): - # :login!, :keyspace=, + preparation_methods :login!, :disa...
Add preparation methods to Cassandra
diff --git a/test/unit/observers/update_router_observer_test.rb b/test/unit/observers/update_router_observer_test.rb index abc1234..def5678 100644 --- a/test/unit/observers/update_router_observer_test.rb +++ b/test/unit/observers/update_router_observer_test.rb @@ -0,0 +1,35 @@+require_relative '../../test_helper' + +cl...
Add test coverage for existing observer behaviour The existing UpdateRouterObserver didn't have any unit tests. I've written some retrospectively so that it will be easier to change its behaviour.
diff --git a/wateringServer/spec/routing/plants_routing_spec.rb b/wateringServer/spec/routing/plants_routing_spec.rb index abc1234..def5678 100644 --- a/wateringServer/spec/routing/plants_routing_spec.rb +++ b/wateringServer/spec/routing/plants_routing_spec.rb @@ -1,15 +1,35 @@ require 'rails_helper' describe Plants...
Add unroutable tests for plants
diff --git a/spec/controllers/miq_report_controller/dashboards_spec.rb b/spec/controllers/miq_report_controller/dashboards_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/miq_report_controller/dashboards_spec.rb +++ b/spec/controllers/miq_report_controller/dashboards_spec.rb @@ -1,25 +1,23 @@ describe Repo...
Use let and adapt name in dashboard spec
diff --git a/spec/controllers/workers/index_filters_controller_spec.rb b/spec/controllers/workers/index_filters_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/workers/index_filters_controller_spec.rb +++ b/spec/controllers/workers/index_filters_controller_spec.rb @@ -0,0 +1,59 @@+require 'rails...
Add workers index filters controller test.
diff --git a/lib/dm-mongo-adapter.rb b/lib/dm-mongo-adapter.rb index abc1234..def5678 100644 --- a/lib/dm-mongo-adapter.rb +++ b/lib/dm-mongo-adapter.rb @@ -3,27 +3,25 @@ require 'dm-core' require 'dm-aggregates' -dir = Pathname(__FILE__).dirname.expand_path + 'dm-mongo-adapter' +require 'dm-mongo-adapter/query' +re...
Change requires from absolute to relative paths
diff --git a/dmarc_inspector.gemspec b/dmarc_inspector.gemspec index abc1234..def5678 100644 --- a/dmarc_inspector.gemspec +++ b/dmarc_inspector.gemspec @@ -19,5 +19,8 @@ spec.add_dependency 'parslet', '~> 1.6' spec.add_development_dependency "bundler", "~> 1.7" + spec.add_development_dependency 'rspec-core', '...
Add rspec-core, rspec-expectations, rspec-mock as dev dependencies
diff --git a/lib/interactor/hooks.rb b/lib/interactor/hooks.rb index abc1234..def5678 100644 --- a/lib/interactor/hooks.rb +++ b/lib/interactor/hooks.rb @@ -47,7 +47,7 @@ end def call_hook(hook) - hook.is_a?(Symbol) ? method(hook).call : instance_eval(&hook) + hook.is_a?(Symbol) ? send(hook) : inst...
Refactor hook execution for symbols
diff --git a/app/models/request.rb b/app/models/request.rb index abc1234..def5678 100644 --- a/app/models/request.rb +++ b/app/models/request.rb @@ -16,14 +16,6 @@ true end - def other_party - if current_user == requester - responder - elsif current_user == responder - requester - end - en...
Remove other_party getter from model"
diff --git a/spec/command_spec.rb b/spec/command_spec.rb index abc1234..def5678 100644 --- a/spec/command_spec.rb +++ b/spec/command_spec.rb @@ -6,6 +6,8 @@ let(:container){LintTrap::Container::Docker.new('lintci/rubocop', fixture_path)} describe '#run' do + let(:container){LintTrap::Container::Docker.new('li...
Fix remaining failure for circle when trying to remove containers.
diff --git a/spec/message_spec.rb b/spec/message_spec.rb index abc1234..def5678 100644 --- a/spec/message_spec.rb +++ b/spec/message_spec.rb @@ -0,0 +1,63 @@+require 'spec_helper' + +describe DripDrop::Message do + describe "basic message" do + def create_basic + attrs = { + :name => 'test', + :h...
Add in message spec for reals
diff --git a/app/helpers/tags_helper.rb b/app/helpers/tags_helper.rb index abc1234..def5678 100644 --- a/app/helpers/tags_helper.rb +++ b/app/helpers/tags_helper.rb @@ -8,7 +8,7 @@ end def tag_classes(tag) - classes = ["tag-toggle", tag] + classes = ["tag-toggle", tag.downcase] if active_tag?(tag) ...
Tag classnames should always be lowercase The development seeds have tags that are title case: "Ember", "Rails", etc. As such, the tags had the classnames `Ember`, `Rails`. This change forces tags to use the downcase for classnames.
diff --git a/app/mailers/user_mailer.rb b/app/mailers/user_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/user_mailer.rb +++ b/app/mailers/user_mailer.rb @@ -5,7 +5,7 @@ @user = user @url = "http://prepared.ly/users/sign_in" @referral_url = "http://www.prepared.ly/?ref=<%= @referral_code ...
Fix welcome email logo url
diff --git a/lib/opal/path_reader.rb b/lib/opal/path_reader.rb index abc1234..def5678 100644 --- a/lib/opal/path_reader.rb +++ b/lib/opal/path_reader.rb @@ -1,7 +1,10 @@+require 'opal/regexp_anchors' require 'opal/hike_path_finder' module Opal class PathReader + RELATIVE_PATH_REGEXP = %r{#{Opal::REGEXP_START}...
Use Opal::REGEXP_START in path reader At least until we'll be able to compile `\A` and `\z`. Also moved it to a constant. Ref: https://github.com/opal/opal/issues/1630
diff --git a/server/app/controllers/api/v1/results_controller.rb b/server/app/controllers/api/v1/results_controller.rb index abc1234..def5678 100644 --- a/server/app/controllers/api/v1/results_controller.rb +++ b/server/app/controllers/api/v1/results_controller.rb @@ -1,3 +1,4 @@+# -*- coding: undecided -*- class Api:...
ADD bfs in (POST /api/vi/results)
diff --git a/api/app/views/spree/api/line_items/show.v1.rabl b/api/app/views/spree/api/line_items/show.v1.rabl index abc1234..def5678 100644 --- a/api/app/views/spree/api/line_items/show.v1.rabl +++ b/api/app/views/spree/api/line_items/show.v1.rabl @@ -1,5 +1,7 @@ object @line_item attributes *line_item_attributes +no...
[api] Return display_single_amount and display_total_amount in LineItems responses This is useful if the API client wants to display a well-formatted version of the price
diff --git a/streamio-magick.gemspec b/streamio-magick.gemspec index abc1234..def5678 100644 --- a/streamio-magick.gemspec +++ b/streamio-magick.gemspec @@ -19,6 +19,6 @@ s.add_development_dependency("rake", "~> 0.9.2") s.add_development_dependency("rspec", "~> 2.9") - s.files = Dir.glob("lib/**/*") + %w...
Fix README file in gemspec.
diff --git a/lib/color_divider/api.rb b/lib/color_divider/api.rb index abc1234..def5678 100644 --- a/lib/color_divider/api.rb +++ b/lib/color_divider/api.rb @@ -3,6 +3,13 @@ class ColorDivider class API < Sinatra::Base + use Rack::Cors do + allow do + origins '*' + resource '*', :headers => :...
Add CORS support to API class
diff --git a/test/template_handler_test.rb b/test/template_handler_test.rb index abc1234..def5678 100644 --- a/test/template_handler_test.rb +++ b/test/template_handler_test.rb @@ -26,17 +26,17 @@ get "/site/index.js" s = last_response.body - assert_match "var x = 5;", last_response.body + assert_match...
Update tests to use a more flexible match to get around multi-system line endings
diff --git a/spec/ruby/core/exception/system_stack_error_spec.rb b/spec/ruby/core/exception/system_stack_error_spec.rb index abc1234..def5678 100644 --- a/spec/ruby/core/exception/system_stack_error_spec.rb +++ b/spec/ruby/core/exception/system_stack_error_spec.rb @@ -0,0 +1,16 @@+require File.expand_path('../../../spe...
Add some basic specs for the ancestry of SystemStackError
diff --git a/spec/unit/facter/util/fact_rabbitmq_version_spec.rb b/spec/unit/facter/util/fact_rabbitmq_version_spec.rb index abc1234..def5678 100644 --- a/spec/unit/facter/util/fact_rabbitmq_version_spec.rb +++ b/spec/unit/facter/util/fact_rabbitmq_version_spec.rb @@ -19,6 +19,15 @@ expect(Facter.fact(:rabbitmq...
Add test for invalid version value
diff --git a/lib/dotenv/deployment.rb b/lib/dotenv/deployment.rb index abc1234..def5678 100644 --- a/lib/dotenv/deployment.rb +++ b/lib/dotenv/deployment.rb @@ -0,0 +1,9 @@+require "dotenv" +require "dotenv/deployment/version" + +# Load defaults +Dotenv.load '.env' + +# Override any existing variables if an environment...
Add support for multiple environments
diff --git a/lib/hello_sign/client.rb b/lib/hello_sign/client.rb index abc1234..def5678 100644 --- a/lib/hello_sign/client.rb +++ b/lib/hello_sign/client.rb @@ -36,10 +36,11 @@ def unauth_connection(&auth) Faraday.new(:url => API_ENDPOINT) do |faraday| + auth.call(faraday) if block_given? + f...
Add multipart middleware to Faraday stack
diff --git a/lib/infrataster/rspec.rb b/lib/infrataster/rspec.rb index abc1234..def5678 100644 --- a/lib/infrataster/rspec.rb +++ b/lib/infrataster/rspec.rb @@ -10,7 +10,7 @@ @infrataster_context = Infrataster::Contexts.from_example(self.class) end config.before(:each) do - @infrataster_context = Infratast...
Use `RSpec.current_example` in place of `example` In order to remove deprecation warning #34
diff --git a/lib/pacto/test_helper.rb b/lib/pacto/test_helper.rb index abc1234..def5678 100644 --- a/lib/pacto/test_helper.rb +++ b/lib/pacto/test_helper.rb @@ -1,4 +1,5 @@ begin + require 'pacto' require 'goliath/test_helper' require 'pacto/server' rescue LoadError
Save an extra require, expect this will fix the issue loading webmock on travis-ci
diff --git a/lib/sfn/config/update.rb b/lib/sfn/config/update.rb index abc1234..def5678 100644 --- a/lib/sfn/config/update.rb +++ b/lib/sfn/config/update.rb @@ -10,11 +10,6 @@ :description => 'Print the resulting stack template' ) attribute( - :apply_nesting, [TrueClass, FalseClass], - ...
Remove duplicated configuration attribute (is already inherited)
diff --git a/lib/trufflepig/search.rb b/lib/trufflepig/search.rb index abc1234..def5678 100644 --- a/lib/trufflepig/search.rb +++ b/lib/trufflepig/search.rb @@ -25,12 +25,17 @@ def scan(file_path) content = File.read file_path - features = FeatureList.load features.each do |key, feature| ...
Load feature list only once when scanning multiple files
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -18,6 +18,7 @@ # Install module and dependencies hosts.each do |host| copy_module_to(host, source: proj_root, module_nam...
Add missing dependency for Beaker tests
diff --git a/spec/togls/rules/group_spec.rb b/spec/togls/rules/group_spec.rb index abc1234..def5678 100644 --- a/spec/togls/rules/group_spec.rb +++ b/spec/togls/rules/group_spec.rb @@ -22,7 +22,7 @@ describe "#run" do context "when the target is included in the list" do it "returns true" do - group...
Modify Group rule spec to include type_id Why you made the change: I did this because Rule construction now requires the first parameter to be the abstract type_id of that rule.
diff --git a/db/migrate/20160128222817_change_grants_description_type.rb b/db/migrate/20160128222817_change_grants_description_type.rb index abc1234..def5678 100644 --- a/db/migrate/20160128222817_change_grants_description_type.rb +++ b/db/migrate/20160128222817_change_grants_description_type.rb @@ -0,0 +1,9 @@+class C...
Change grants description type to text
diff --git a/Casks/intellij-idea-eap.rb b/Casks/intellij-idea-eap.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-eap.rb +++ b/Casks/intellij-idea-eap.rb @@ -1,6 +1,6 @@ cask :v1 => 'intellij-idea-eap' do - version '140.2110.5' - sha256 '971cea43259cf517c209dd646c6c48220c97f22e35c0773b644b8c7578aea1c3' + ...
Upgrade Intellij Idea EAP to v140.2285.5
diff --git a/core/app/models/spree/line_item/pricers/abstract.rb b/core/app/models/spree/line_item/pricers/abstract.rb index abc1234..def5678 100644 --- a/core/app/models/spree/line_item/pricers/abstract.rb +++ b/core/app/models/spree/line_item/pricers/abstract.rb @@ -1,6 +1,16 @@ module Spree class LineItem + # ...
Add YARD documentation for Abstract Pricer
diff --git a/spec/controllers/vm_controller_spec.rb b/spec/controllers/vm_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/vm_controller_spec.rb +++ b/spec/controllers/vm_controller_spec.rb @@ -0,0 +1,23 @@+describe VmController do + before do + stub_user(:features => :all) + EvmSpecHelper...
Add spec for live_migrate called outside explorers.
diff --git a/spec/factory_bot_rails/railtie_spec.rb b/spec/factory_bot_rails/railtie_spec.rb index abc1234..def5678 100644 --- a/spec/factory_bot_rails/railtie_spec.rb +++ b/spec/factory_bot_rails/railtie_spec.rb @@ -39,14 +39,7 @@ end def reload_rails! - if defined? ActiveSupport::Reloader - Rai...
Remove branch for rails 4.2 reloader We are no longer testing against Rails 4.2, so we no longer need to branch for the Rails 4.2 style reloader
diff --git a/apnd.gemspec b/apnd.gemspec index abc1234..def5678 100644 --- a/apnd.gemspec +++ b/apnd.gemspec @@ -22,6 +22,8 @@ s.add_dependency('json', '= 1.4.6') s.add_dependency('daemons', '= 1.1.0') + s.add_development_dependency('shoulda') + s.extra_rdoc_files = ['README.markdown'] s.rdoc...
Add shoulda to gemspec development dependencies
diff --git a/verified_double.gemspec b/verified_double.gemspec index abc1234..def5678 100644 --- a/verified_double.gemspec +++ b/verified_double.gemspec @@ -8,9 +8,9 @@ gem.version = VerifiedDouble::VERSION gem.authors = ["George Mendoza"] gem.email = ["gsmendoza@gmail.com"] - gem.descripti...
Update gem description, summary, and homepage for release.
diff --git a/app/models/page.rb b/app/models/page.rb index abc1234..def5678 100644 --- a/app/models/page.rb +++ b/app/models/page.rb @@ -1,6 +1,4 @@ class Page < DataMapper::Base - class VersionNotFound < Exception; end - property :name, :string property :slug, :string property :versions_count, :integer, :d...
Raise standard 404 not found instead of custom exception when a non-existent version is selected
diff --git a/app/models/post.rb b/app/models/post.rb index abc1234..def5678 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -1,6 +1,6 @@ class Post < ActiveRecord::Base include DateFormat - + before_save :prevent_blank_content after_save :calculate_word_count @@ -30,7 +30,7 @@ private de...
Return nil so that callback won't leave false on the stack.
diff --git a/test_declarative.gemspec b/test_declarative.gemspec index abc1234..def5678 100644 --- a/test_declarative.gemspec +++ b/test_declarative.gemspec @@ -8,6 +8,7 @@ s.authors = ['Sven Fuchs'] s.email = 'svenfuchs@artweb-design.de' s.homepage = 'http://github.com/svenfuchs/test_declarativ...
Add license to gemspec file.
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -5,6 +5,7 @@ LIB_DIR = File.join(File.expand_path(File.dirname(__FILE__)),'..','..','lib') Before do + @aruba_timeout_seconds = 3600 # Using "announce" c...
Extend aruba timeout in order to have plenty of time to debug.
diff --git a/tools/split-mysql-dump.rb b/tools/split-mysql-dump.rb index abc1234..def5678 100644 --- a/tools/split-mysql-dump.rb +++ b/tools/split-mysql-dump.rb @@ -0,0 +1,67 @@+#!/usr/bin/env ruby + +require "optparse" +require "ostruct" + +options = OpenStruct.new +options.base_name = "dump" +option_parser = OptionPa...
Add a tool to split table dump from all tables dump
diff --git a/lib/flex_commerce_api/error/internal_server.rb b/lib/flex_commerce_api/error/internal_server.rb index abc1234..def5678 100644 --- a/lib/flex_commerce_api/error/internal_server.rb +++ b/lib/flex_commerce_api/error/internal_server.rb @@ -3,14 +3,15 @@ class InternalServer < Base def message ...
Fix for when fastly errors are returned
diff --git a/lib/rugged/diff/delta.rb b/lib/rugged/diff/delta.rb index abc1234..def5678 100644 --- a/lib/rugged/diff/delta.rb +++ b/lib/rugged/diff/delta.rb @@ -1,25 +1,13 @@ module Rugged class Diff class Delta - def new_blob - blob(new_file) - end - - def old_blob - blob(old_file)...
Add new_file_full_path method on Rugged::Diff::Delta
diff --git a/test/anticuado/ios/carthage_test.rb b/test/anticuado/ios/carthage_test.rb index abc1234..def5678 100644 --- a/test/anticuado/ios/carthage_test.rb +++ b/test/anticuado/ios/carthage_test.rb @@ -9,6 +9,13 @@ *** Fetching Himotoki The following dependencies are outdated: Result "2.0.0" -> "2.1.3" + OUTD...
Add test case for recent Carthage
diff --git a/client/ruby/solrb/lib/solr/response/standard.rb b/client/ruby/solrb/lib/solr/response/standard.rb index abc1234..def5678 100644 --- a/client/ruby/solrb/lib/solr/response/standard.rb +++ b/client/ruby/solrb/lib/solr/response/standard.rb @@ -36,6 +36,11 @@ def max_score return @response['maxSc...
Add helper method to retrieve and sort facets git-svn-id: 3b1ff1236863b4d63a22e4dae568675c2e247730@499438 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/test/operators/revenue_code_test.rb b/test/operators/revenue_code_test.rb index abc1234..def5678 100644 --- a/test/operators/revenue_code_test.rb +++ b/test/operators/revenue_code_test.rb @@ -7,7 +7,7 @@ ).must_equal({}) end - it "should have the best procedure_domain" do + it "should have the c...
Fix typo in Revenue Code tests
diff --git a/milkfarm-onix.gemspec b/milkfarm-onix.gemspec index abc1234..def5678 100644 --- a/milkfarm-onix.gemspec +++ b/milkfarm-onix.gemspec @@ -15,7 +15,7 @@ s.test_files = Dir.glob("spec/**/*.rb") s.files = Dir.glob("{lib,support,dtd}/**/**/*") + ["README.markdown", "TODO", "CHANGELOG"] ...
Change roxml version requirement to ~>3.1.6
diff --git a/example/example2.rb b/example/example2.rb index abc1234..def5678 100644 --- a/example/example2.rb +++ b/example/example2.rb @@ -9,6 +9,9 @@ sensor :interface => 'en1', :name => 'Unified2 Example', :id => 3 + # Load signatures, generate events will be sent over the web socket + # quickly so we sl...
Add io position to Event class
diff --git a/lib/dimples.rb b/lib/dimples.rb index abc1234..def5678 100644 --- a/lib/dimples.rb +++ b/lib/dimples.rb @@ -7,7 +7,6 @@ require 'yaml' require 'dimples/frontable' -require 'dimples/renderable' require 'dimples/category' require 'dimples/configuration' @@ -16,5 +15,6 @@ require 'dimples/pager' requi...
Swap the renderable module for the renderer class
diff --git a/fancyengine.gemspec b/fancyengine.gemspec index abc1234..def5678 100644 --- a/fancyengine.gemspec +++ b/fancyengine.gemspec @@ -9,9 +9,9 @@ s.version = Fancyengine::VERSION s.authors = ["Sean Devine"] s.email = ["barelyknown@icloud.com"] - s.homepage = "TODO" - s.summary = "T...
Add summary and description to gemspec.
diff --git a/fc-reminder.gemspec b/fc-reminder.gemspec index abc1234..def5678 100644 --- a/fc-reminder.gemspec +++ b/fc-reminder.gemspec @@ -24,5 +24,5 @@ spec.add_dependency 'daemons', '~> 1.1.9' spec.add_dependency 'clockwork', '~> 0.7.5' - spec.add_development_dependency 'bundler', '~> 1.3' + spec.add_devel...
Set dev dependency of bundler; to ~> 1.6
diff --git a/docs/analytics_scripts/submitted_courses.csv.rb b/docs/analytics_scripts/submitted_courses.csv.rb index abc1234..def5678 100644 --- a/docs/analytics_scripts/submitted_courses.csv.rb +++ b/docs/analytics_scripts/submitted_courses.csv.rb @@ -4,7 +4,7 @@ require 'csv' -CSV.open("/home/sage/unsubmitted-#{D...
Fix filename in script for CSV of submitted courses
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -11,9 +11,7 @@ config.generators do |g| g.factory_girl dir: 'spec/factories' end - # Settings in config/environments/* take precedence over those specifi...
Set timezone for displaying (and remove comments)
diff --git a/glimpse-mongo.gemspec b/glimpse-mongo.gemspec index abc1234..def5678 100644 --- a/glimpse-mongo.gemspec +++ b/glimpse-mongo.gemspec @@ -18,5 +18,5 @@ gem.require_paths = ['lib'] gem.add_dependency 'glimpse' - gem.add_dependency 'mongo' + gem.add_dependency 'mongo', '>= 1.8' end
Update the mongo dependency to >= 1.8
diff --git a/stripe_event.gemspec b/stripe_event.gemspec index abc1234..def5678 100644 --- a/stripe_event.gemspec +++ b/stripe_event.gemspec @@ -14,7 +14,8 @@ s.summary = "Stripe webhook integration for Rails applications." s.description = "Stripe webhook integration for Rails applications." - s.files = Dir...
Update gemspec config for files and test_files
diff --git a/sync_repositories.rb b/sync_repositories.rb index abc1234..def5678 100644 --- a/sync_repositories.rb +++ b/sync_repositories.rb @@ -5,7 +5,7 @@ page = 1 catch(:done) do - while (repositories = Octokit.repositories('railscasts', page: page, per_page: 100, sorted: 'created', direction: 'desc')).length > ...
Use right github API parameter for defining the sort field.
diff --git a/freckle-api.gemspec b/freckle-api.gemspec index abc1234..def5678 100644 --- a/freckle-api.gemspec +++ b/freckle-api.gemspec @@ -13,11 +13,11 @@ s.files = Dir['LICENSE', 'README.md', 'lib/**/*.rb'] s.test_files = Dir['spec/**/*.rb'] - s.add_development_dependency('rake') - s.add_development_depende...
Add versions to dependencies, tag 0.1.0
diff --git a/lib/instana/frameworks/instrumentation/action_controller.rb b/lib/instana/frameworks/instrumentation/action_controller.rb index abc1234..def5678 100644 --- a/lib/instana/frameworks/instrumentation/action_controller.rb +++ b/lib/instana/frameworks/instrumentation/action_controller.rb @@ -7,15 +7,38 @@ ...
Add ActionPack 5 instrumentation support via prepend
diff --git a/cssminify.rb b/cssminify.rb index abc1234..def5678 100644 --- a/cssminify.rb +++ b/cssminify.rb @@ -1,19 +1,16 @@ class CSS - - def initialize(file_name) - @file_name = file_name + def initialize(file) + @file_name = file + @file_name_min = file.clone.gsub(/(.css)/, "") + clean_file end - def open...
Fix file issue, thanks johncausey
diff --git a/config/initializers/new_framework_defaults.rb b/config/initializers/new_framework_defaults.rb index abc1234..def5678 100644 --- a/config/initializers/new_framework_defaults.rb +++ b/config/initializers/new_framework_defaults.rb @@ -18,6 +18,3 @@ # Require `belongs_to` associations by default. Previous ve...
Change to default halt_callback_chains_on_return_false option This will make it easier to migrate to Rails 5.2 since this option has no affect now and it gets fully removed then.
diff --git a/lib/active_set/processor_sort/enumerable_adapter.rb b/lib/active_set/processor_sort/enumerable_adapter.rb index abc1234..def5678 100644 --- a/lib/active_set/processor_sort/enumerable_adapter.rb +++ b/lib/active_set/processor_sort/enumerable_adapter.rb @@ -35,12 +35,16 @@ def sortable_attribute_for(it...
Handle booleans and nils in the sort enumerable adapter
diff --git a/delete_at.rb b/delete_at.rb index abc1234..def5678 100644 --- a/delete_at.rb +++ b/delete_at.rb @@ -18,7 +18,7 @@ index = arguments[1] - if not index.match(/^\d+$/) + if index.is_a?(String) and not index.match(/^\d+$/) raise(Puppet::ParseError, 'delete_at(): You must provide ' + ...
Make sure that we have string-encoded integer value. Signed-off-by: Krzysztof Wilczynski <9bf091559fc98493329f7d619638c79e91ccf029@linux.com>