diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/wechatpay/service.rb b/lib/wechatpay/service.rb index abc1234..def5678 100644 --- a/lib/wechatpay/service.rb +++ b/lib/wechatpay/service.rb @@ -3,6 +3,9 @@ module Wechatpay module Service + + class InvalidResponseError < StandardError; end + class << self def unified_order(options) ...
Raise proper error when response is not expected
diff --git a/app/controllers/thredded/application_controller.rb b/app/controllers/thredded/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/thredded/application_controller.rb +++ b/app/controllers/thredded/application_controller.rb @@ -22,7 +22,7 @@ def messageboard if params.k...
[JRO] Use friendly_id for finding messageboard obj
diff --git a/chef-repo/site-cookbooks/cbench-chef-server/attributes/default.rb b/chef-repo/site-cookbooks/cbench-chef-server/attributes/default.rb index abc1234..def5678 100644 --- a/chef-repo/site-cookbooks/cbench-chef-server/attributes/default.rb +++ b/chef-repo/site-cookbooks/cbench-chef-server/attributes/default.rb...
Fix chef api_fqdn config causing bookshelf reachability issues (ipv4 shortcut does not work)
diff --git a/definitions/disk-monitor.rb b/definitions/disk-monitor.rb index abc1234..def5678 100644 --- a/definitions/disk-monitor.rb +++ b/definitions/disk-monitor.rb @@ -11,6 +11,7 @@ a[:template] = params[:template] a[:cookbook] = params[:cookbook] || "disk-monitor" a[:check_frequency] = params[:check...
Allow check frequency to be every minute
diff --git a/omnibus_overrides.rb b/omnibus_overrides.rb index abc1234..def5678 100644 --- a/omnibus_overrides.rb +++ b/omnibus_overrides.rb @@ -10,7 +10,7 @@ # variable. override :bundler, version: "1.15.4" override :rubygems, version: "2.7.6" -override :ruby, version: "2.4.4" +override :ruby,...
Update Ruby from 2.4.4 to 2.4.5 This resolves a CVE and fixes a few bugs Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/test/acceptance/version_test.rb b/test/acceptance/version_test.rb index abc1234..def5678 100644 --- a/test/acceptance/version_test.rb +++ b/test/acceptance/version_test.rb @@ -5,4 +5,14 @@ result = execute("vagrant", "version") assert_equal("Vagrant version #{config.vagrant_version}\n", result.std...
Add more acceptance tests for printing the Vagrant version
diff --git a/Banana.podspec b/Banana.podspec index abc1234..def5678 100644 --- a/Banana.podspec +++ b/Banana.podspec @@ -2,15 +2,6 @@ s.name = "Banana" s.version = "0.0.1" s.summary = "A customizable dropdown menu" - s.description = <<-DESC - A longer description of Banana ...
Remove description from pod spec
diff --git a/lib/generators/spree_shipping_matrix/install/install_generator.rb b/lib/generators/spree_shipping_matrix/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/spree_shipping_matrix/install/install_generator.rb +++ b/lib/generators/spree_shipping_matrix/install/install_generator.rb...
Update generator to include backend JS
diff --git a/jquery-qtip2-rails.gemspec b/jquery-qtip2-rails.gemspec index abc1234..def5678 100644 --- a/jquery-qtip2-rails.gemspec +++ b/jquery-qtip2-rails.gemspec @@ -16,4 +16,6 @@ gem.version = Jquery::Qtip2::Rails::VERSION gem.add_dependency "railties", ">= 3.1.0" + + gem.add_development_dependency 'r...
Add rails as a development dependency due to the dummy app
diff --git a/test/lib/test_initialization.rb b/test/lib/test_initialization.rb index abc1234..def5678 100644 --- a/test/lib/test_initialization.rb +++ b/test/lib/test_initialization.rb @@ -11,13 +11,15 @@ assert_equal client.host, 'login.salesforce.com' assert_equal client.version, '23.0' + assert_equ...
Update test to check debugging option default and override.
diff --git a/pgoapi.podspec b/pgoapi.podspec index abc1234..def5678 100644 --- a/pgoapi.podspec +++ b/pgoapi.podspec @@ -13,7 +13,7 @@ s.author = "Rayman Rosevear" - s.ios.deployment_target = '8.0' + s.ios.deployment_target = '9.0' s.osx.deployment_target = '10.10' s.source = { :git => "https://gi...
Update the minimum deployment target in the podspec
diff --git a/resources/port_options.rb b/resources/port_options.rb index abc1234..def5678 100644 --- a/resources/port_options.rb +++ b/resources/port_options.rb @@ -23,14 +23,8 @@ attribute :name, kind_of: String, name_attribute: true attribute :source, kind_of: String attribute :options, kind_of: Hash -attribute :di...
Use lazy for the default values instead of the initializer Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/sensu-plugins-kue.gemspec b/sensu-plugins-kue.gemspec index abc1234..def5678 100644 --- a/sensu-plugins-kue.gemspec +++ b/sensu-plugins-kue.gemspec @@ -14,9 +14,9 @@ spec.homepage = "https://github.com/xgin/sensu-plugins-kue" spec.license = "MIT" - spec.files = `git ls-files -z`....
Switch from using 'git ls-files' to Ruby Dir globbing
diff --git a/lib/open_project/revisions/subversion/version.rb b/lib/open_project/revisions/subversion/version.rb index abc1234..def5678 100644 --- a/lib/open_project/revisions/subversion/version.rb +++ b/lib/open_project/revisions/subversion/version.rb @@ -1,3 +1,7 @@-module OpenProject::Revisions::Subversion - VERSIO...
Fix NameError when installing plugin
diff --git a/main.rb b/main.rb index abc1234..def5678 100644 --- a/main.rb +++ b/main.rb @@ -15,7 +15,7 @@ else set :domain, "https://127.0.0.1:3000" end - set :secret_key, File.read('secret-key').strip + #set :secret_key, File.read('secret-key').strip end Dir["./app/models/*.rb"].each { |file| require ...
Remove secret key reference for prod
diff --git a/social_stream.gemspec b/social_stream.gemspec index abc1234..def5678 100644 --- a/social_stream.gemspec +++ b/social_stream.gemspec @@ -13,5 +13,5 @@ s.add_dependency('inherited_resources', '~> 1.1.2') s.add_dependency('stringex', '~> 1.2.0') s.add_dependency('paperclip', '~> 2.3.4') - s.add_depen...
Fix github jquery-rails redirect issue
diff --git a/Library/Homebrew/requirements/glibc_requirement.rb b/Library/Homebrew/requirements/glibc_requirement.rb index abc1234..def5678 100644 --- a/Library/Homebrew/requirements/glibc_requirement.rb +++ b/Library/Homebrew/requirements/glibc_requirement.rb @@ -30,6 +30,6 @@ # Fix for brew tests, which uses Nu...
GlibcRequirement: Fix system_version for old Ruby
diff --git a/dartsduino-games-countup.gemspec b/dartsduino-games-countup.gemspec index abc1234..def5678 100644 --- a/dartsduino-games-countup.gemspec +++ b/dartsduino-games-countup.gemspec @@ -8,8 +8,8 @@ spec.version = Dartsduino::Games::Countup::VERSION spec.authors = ["Ikuo Terado"] spec.email ...
Update gem's summary and description
diff --git a/db/migrate/20140927005000_add_dummy_for_missing_emails.rb b/db/migrate/20140927005000_add_dummy_for_missing_emails.rb index abc1234..def5678 100644 --- a/db/migrate/20140927005000_add_dummy_for_missing_emails.rb +++ b/db/migrate/20140927005000_add_dummy_for_missing_emails.rb @@ -1,7 +1,7 @@ class AddDummyF...
Correct syntax for update column
diff --git a/config/initializers/omniauth.rb b/config/initializers/omniauth.rb index abc1234..def5678 100644 --- a/config/initializers/omniauth.rb +++ b/config/initializers/omniauth.rb @@ -2,5 +2,5 @@ Rails.application.config.middleware.use OmniAuth::Builder do provider :trello, ENV['TRELLO_KEY'], ENV['TRELLO_SECR...
Add account OAuth scope in order to get the user's email
diff --git a/spec/integration/admin_collections_controller_spec.rb b/spec/integration/admin_collections_controller_spec.rb index abc1234..def5678 100644 --- a/spec/integration/admin_collections_controller_spec.rb +++ b/spec/integration/admin_collections_controller_spec.rb @@ -0,0 +1,34 @@+# Copyright 2011-2019, The Tru...
Add integration test for mini_magick
diff --git a/cortex-field-types-core.rb b/cortex-field-types-core.rb index abc1234..def5678 100644 --- a/cortex-field-types-core.rb +++ b/cortex-field-types-core.rb @@ -1,10 +1,17 @@+require 'cortex/field_types/core/boolean/boolean_field_type' +require 'cortex/field_types/core/boolean/boolean_cell' -require 'cortex/f...
Remove Tree concern, explicitly require Core FieldTypes due to eager-loading issues
diff --git a/app/controllers/ruby_wedding/invitations_controller.rb b/app/controllers/ruby_wedding/invitations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/ruby_wedding/invitations_controller.rb +++ b/app/controllers/ruby_wedding/invitations_controller.rb @@ -34,7 +34,7 @@ @menu = Menu.all.fi...
Correct detection of whether a guest already has choices for this course.
diff --git a/kuromi.gemspec b/kuromi.gemspec index abc1234..def5678 100644 --- a/kuromi.gemspec +++ b/kuromi.gemspec @@ -10,7 +10,7 @@ spec.email = ["matt@eightbitraptor.com"] spec.description = %q{Kuromi is an application runner} spec.summary = %q{Kuromi provides a DSL for running command lines...
Add homepage to the gemspec
diff --git a/lancat.gemspec b/lancat.gemspec index abc1234..def5678 100644 --- a/lancat.gemspec +++ b/lancat.gemspec @@ -2,6 +2,12 @@ s.name = 'lancat' s.version = '0.0.1' s.summary = 'Zero-configuration LAN file transfer' + s.description = 'lancat is a program which allows files and other data ...
Add license and description to gemspec.
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -10,7 +10,12 @@ def api_release_notes; end - def servicedown; end + def servicedown + respond_to do |form...
Add ability for servicedown to respond to json API queries should also respond in kind and indicate that service is unavailable.
diff --git a/seed_migration.gemspec b/seed_migration.gemspec index abc1234..def5678 100644 --- a/seed_migration.gemspec +++ b/seed_migration.gemspec @@ -8,8 +8,8 @@ Gem::Specification.new do |s| s.name = "seed_migration" s.version = SeedMigration::VERSION - s.authors = ["Andy O'Neill", "Dani...
Add @irubnich and me as gem authors
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -33,7 +33,7 @@ protected def user_params - params.fetch(:user, {}).permit(:email, :password, :password_con...
Revert "add {} in user params.fetch" This reverts commit b5f12c39c4b962cb28787d45ffd08fb601c19c32.
diff --git a/ruby/utils.rb b/ruby/utils.rb index abc1234..def5678 100644 --- a/ruby/utils.rb +++ b/ruby/utils.rb @@ -1,19 +1,11 @@-def benchmark_once - start = Time.now - yield - stop = Time.now - stop - start -end +require 'benchmark' def benchmark(&b) runs = 100 - total = 0.0 - runs.times do |i| - resu...
Use 'benchmark' for benchmarking (duh).
diff --git a/activerecord-uuid.gemspec b/activerecord-uuid.gemspec index abc1234..def5678 100644 --- a/activerecord-uuid.gemspec +++ b/activerecord-uuid.gemspec @@ -18,7 +18,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] - s.add_runtime_dependenc...
Change gemspec activerecord dependency to 3.2.8
diff --git a/app/jobs/sweep_subscriptions_job.rb b/app/jobs/sweep_subscriptions_job.rb index abc1234..def5678 100644 --- a/app/jobs/sweep_subscriptions_job.rb +++ b/app/jobs/sweep_subscriptions_job.rb @@ -6,7 +6,7 @@ def perform start_time = Time.current report = '' - report += "Started job at #{start_ti...
Improve reporting for subscription sweeper
diff --git a/app/models/schedule_rehabilitation_update_event.rb b/app/models/schedule_rehabilitation_update_event.rb index abc1234..def5678 100644 --- a/app/models/schedule_rehabilitation_update_event.rb +++ b/app/models/schedule_rehabilitation_update_event.rb @@ -7,7 +7,7 @@ # Callbacks after_initialize :set_defa...
Fix validation. rehab year must be entered
diff --git a/config/puma/development.rb b/config/puma/development.rb index abc1234..def5678 100644 --- a/config/puma/development.rb +++ b/config/puma/development.rb @@ -1,3 +1,7 @@-# config/puma.rb +# config/puma/development.rb +# Number of threads to start (min / max) threads 2,8 + +# Log files +stdout_redirect 'lo...
Add stdout/stderr redirection of puma in log/puma.out and log/puma.err
diff --git a/spec/higher_level_api/integration/connection_stop_spec.rb b/spec/higher_level_api/integration/connection_stop_spec.rb index abc1234..def5678 100644 --- a/spec/higher_level_api/integration/connection_stop_spec.rb +++ b/spec/higher_level_api/integration/connection_stop_spec.rb @@ -1,21 +1,13 @@ require "spec...
Make this a "regular" functional test
diff --git a/lib/validated_fields/validators/numericality_validator.rb b/lib/validated_fields/validators/numericality_validator.rb index abc1234..def5678 100644 --- a/lib/validated_fields/validators/numericality_validator.rb +++ b/lib/validated_fields/validators/numericality_validator.rb @@ -12,6 +12,9 @@ optio...
Add greater_than_or_equal_to and greater_than_or_equal_to support to NumericalityValidator
diff --git a/app/view_models/effort_show_view.rb b/app/view_models/effort_show_view.rb index abc1234..def5678 100644 --- a/app/view_models/effort_show_view.rb +++ b/app/view_models/effort_show_view.rb @@ -22,7 +22,7 @@ splits.each do |split| split_row = SplitRow.new(split, related_split_times(split), prior_t...
Fix minor bug that prevented certain segment times from displaying in effort show view.
diff --git a/lib/capistrano/twingly/tasks/servers_from_srv_record.rake b/lib/capistrano/twingly/tasks/servers_from_srv_record.rake index abc1234..def5678 100644 --- a/lib/capistrano/twingly/tasks/servers_from_srv_record.rake +++ b/lib/capistrano/twingly/tasks/servers_from_srv_record.rake @@ -1,7 +1,6 @@ require 'resolv...
Remove SRV record for LKP datacenter
diff --git a/spec/support/vcr_setup.rb b/spec/support/vcr_setup.rb index abc1234..def5678 100644 --- a/spec/support/vcr_setup.rb +++ b/spec/support/vcr_setup.rb @@ -1,7 +1,9 @@ VCR.configure do |c| - c.cassette_library_dir = 'spec/fixtures/vcr_cassettes' + c.cassette_library_dir = "spec/fixtures/vcr_cassettes" c.h...
Configure VCR to filter sensitive data in it's cassettes Why: * Someone can see sensitive data in fixtures/cassettes/* This change addresses the need by: * Security
diff --git a/test/functional_test_case.rb b/test/functional_test_case.rb index abc1234..def5678 100644 --- a/test/functional_test_case.rb +++ b/test/functional_test_case.rb @@ -38,7 +38,6 @@ end def delete(*args, &block) - args = check_for_params(args) super(*args, &block) check_for_unsafe_html! ...
Remove Rails 5.2 `delete` monkey-patch
diff --git a/domgen/domgen/iris_model_ext.rb b/domgen/domgen/iris_model_ext.rb index abc1234..def5678 100644 --- a/domgen/domgen/iris_model_ext.rb +++ b/domgen/domgen/iris_model_ext.rb @@ -11,9 +11,18 @@ class IrisAttribute < IrisElement attr_accessor :inverse_sorter + + attr_writer :traversable ...
Update model extension to support some extra irisi specific cruft
diff --git a/application.rb b/application.rb index abc1234..def5678 100644 --- a/application.rb +++ b/application.rb @@ -1,4 +1,5 @@ require 'bundler' +ENV['RACK_ENV'] = 'development' unless ENV['RACK_ENV'] Bundler.require(:default, ENV['RACK_ENV']) class App < Sinatra::Base
Set RACK_ENV if not set so a Rakefile can pick up the environment.
diff --git a/lib/inherited_attribute.rb b/lib/inherited_attribute.rb index abc1234..def5678 100644 --- a/lib/inherited_attribute.rb +++ b/lib/inherited_attribute.rb @@ -19,7 +19,8 @@ class_eval \ " def share_#{attribute}_with(person) - visible? and ( + read_attribute(...
Fix bug that hides attributes for hidden people (even when viewer can see the person).
diff --git a/spec/dummy/db/seeds.rb b/spec/dummy/db/seeds.rb index abc1234..def5678 100644 --- a/spec/dummy/db/seeds.rb +++ b/spec/dummy/db/seeds.rb @@ -0,0 +1,20 @@+# create users +User.create(email: 'partner@example.com') +partner = User.first +4.times do |n| + User.create(email: "m#{n}@example.com") + User.last.ta...
Add seed for dummy app
diff --git a/lib/my_mongoid/document.rb b/lib/my_mongoid/document.rb index abc1234..def5678 100644 --- a/lib/my_mongoid/document.rb +++ b/lib/my_mongoid/document.rb @@ -4,7 +4,7 @@ end module Document - + attr_reader :attributes module ClassMethods def is_mongoid_model? true @@ -16,5 +16,...
Implement attributes for a model
diff --git a/lib/resync/client/resync_extensions.rb b/lib/resync/client/resync_extensions.rb index abc1234..def5678 100644 --- a/lib/resync/client/resync_extensions.rb +++ b/lib/resync/client/resync_extensions.rb @@ -12,10 +12,11 @@ alias_method :base_links=, :links= def links=(value) self.base_links = ...
Use closures & define_singleton_method to avoid creating extra instance variables
diff --git a/lib/rubocop/cop/rspec/scattered_let.rb b/lib/rubocop/cop/rspec/scattered_let.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/rspec/scattered_let.rb +++ b/lib/rubocop/cop/rspec/scattered_let.rb @@ -34,22 +34,18 @@ def on_block(node) return unless example_group_with_body?(node) - ...
Simplify code and make helper methods private
diff --git a/lib/riddle/query/insert.rb b/lib/riddle/query/insert.rb index abc1234..def5678 100644 --- a/lib/riddle/query/insert.rb +++ b/lib/riddle/query/insert.rb @@ -50,6 +50,8 @@ value.to_time.to_i when Array "(#{value.join(',')})" + when Hash + "'#{value.to_json.gsub("'", "\\\\'").gsub('\u0026...
Fix for json attributes in sphinx
diff --git a/lib/zombie_scout/method_call_finder.rb b/lib/zombie_scout/method_call_finder.rb index abc1234..def5678 100644 --- a/lib/zombie_scout/method_call_finder.rb +++ b/lib/zombie_scout/method_call_finder.rb @@ -23,7 +23,7 @@ end def files_to_search - glob = @ruby_project.folders.join(' ') + @...
Kill unneeded assignment to local var
diff --git a/lib/gir_ffi.rb b/lib/gir_ffi.rb index abc1234..def5678 100644 --- a/lib/gir_ffi.rb +++ b/lib/gir_ffi.rb @@ -13,6 +13,7 @@ require 'gir_ffi/sized_array' require 'gir_ffi/zero_terminated' require 'gir_ffi/arg_helper' +require 'gir_ffi/user_defined_type_info' require 'gir_ffi/builder' module GirFFI
Make sure UserDefinedTypeInfo is available
diff --git a/github-auth.gemspec b/github-auth.gemspec index abc1234..def5678 100644 --- a/github-auth.gemspec +++ b/github-auth.gemspec @@ -21,6 +21,7 @@ spec.add_development_dependency 'bundler', '~> 1.3' spec.add_development_dependency 'rake' spec.add_development_dependency 'rspec' + spec.add_development_de...
Add cane as development dependency
diff --git a/lib/csv2api.rb b/lib/csv2api.rb index abc1234..def5678 100644 --- a/lib/csv2api.rb +++ b/lib/csv2api.rb @@ -1,6 +1,7 @@ require 'csv2api/version' require 'csv2api/utils' require 'csv2api/parser' +require 'active_support' require 'active_support/core_ext' # @author Jonah Ruiz <jonah@pixelhipsters.com>...
Add active_support before using core_ext to prevent weird travis err
diff --git a/lib/sisimai.rb b/lib/sisimai.rb index abc1234..def5678 100644 --- a/lib/sisimai.rb +++ b/lib/sisimai.rb @@ -6,6 +6,19 @@ def version(); return Sisimai::VERSION; end def sysname(); return 'bouncehammer'; end def libname(); return 'Sisimai'; end + + # Wrapper method for parsing mail...
Implement make() and dump() methods as a skelton
diff --git a/lib/sublime_video_layout.rb b/lib/sublime_video_layout.rb index abc1234..def5678 100644 --- a/lib/sublime_video_layout.rb +++ b/lib/sublime_video_layout.rb @@ -5,6 +5,7 @@ module SublimeVideoLayout class Engine < ::Rails::Engine initializer 'assets' do |app| + # Should be duplicated to applica...
Add not about assets.precompile & initialize_on_precompile
diff --git a/lib/tasks/team_members.rake b/lib/tasks/team_members.rake index abc1234..def5678 100644 --- a/lib/tasks/team_members.rake +++ b/lib/tasks/team_members.rake @@ -0,0 +1,10 @@+namespace :migrate do + desc "Make all current team members confirmed" + task :team_members do + require 'bundler' + Bundler.r...
Add data migration for team memberships
diff --git a/lib/travis/config/heroku.rb b/lib/travis/config/heroku.rb index abc1234..def5678 100644 --- a/lib/travis/config/heroku.rb +++ b/lib/travis/config/heroku.rb @@ -11,6 +11,7 @@ compact( database: database, logs_database: logs_database, + logs_readonly_database: logs_read...
Add support for parsing LOGS_READONLY_DATABASE_URL
diff --git a/lib/winnow/fingerprinter.rb b/lib/winnow/fingerprinter.rb index abc1234..def5678 100644 --- a/lib/winnow/fingerprinter.rb +++ b/lib/winnow/fingerprinter.rb @@ -29,10 +29,12 @@ def k_grams(str) current_line = 0 - # this starts at -1 to make the #map logic simpler - current_col = -1 + ...
Refactor / fix window positioning logic. This implementation works with newlines properly.
diff --git a/.delivery/build_cookbook/recipes/smoke.rb b/.delivery/build_cookbook/recipes/smoke.rb index abc1234..def5678 100644 --- a/.delivery/build_cookbook/recipes/smoke.rb +++ b/.delivery/build_cookbook/recipes/smoke.rb @@ -3,22 +3,41 @@ # Recipe:: smoke # # Copyright:: 2017, Jp Robinson, All Rights Reserved. +w...
Test fetching the published package and starting it
diff --git a/spec/github_pulls_spec.rb b/spec/github_pulls_spec.rb index abc1234..def5678 100644 --- a/spec/github_pulls_spec.rb +++ b/spec/github_pulls_spec.rb @@ -1,4 +1,6 @@ require 'spec_helper' + +# TODO: using webmock? describe GithubPulls::API do let(:api) { GithubPulls::API.new('holysugar/github_pulls') }...
Add a spec using pull request data
diff --git a/spec/lib/basecamp_spec.rb b/spec/lib/basecamp_spec.rb index abc1234..def5678 100644 --- a/spec/lib/basecamp_spec.rb +++ b/spec/lib/basecamp_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe TaskMapper::Basecamp do +describe TaskMapper::Provider::Basecamp do let(:tm) { create_instance } desc...
Remove ref to top-level constant
diff --git a/spec/models/phone_spec.rb b/spec/models/phone_spec.rb index abc1234..def5678 100644 --- a/spec/models/phone_spec.rb +++ b/spec/models/phone_spec.rb @@ -0,0 +1,38 @@+require "spec_helper" + +describe Phone do + it "does not allow duplicate phone numbers per contact" do + contact = Contact.create( + ...
Write specs of Phone model
diff --git a/rack-pretty_json.gemspec b/rack-pretty_json.gemspec index abc1234..def5678 100644 --- a/rack-pretty_json.gemspec +++ b/rack-pretty_json.gemspec @@ -6,7 +6,7 @@ gem.email = ["damien@mindglob.com"] gem.description = %q{Pretty JSON for pretty people} gem.summary = %q{Rack::PrettyJSON r...
Fix a type in the gem home URL.
diff --git a/react-native-pdf.podspec b/react-native-pdf.podspec index abc1234..def5678 100644 --- a/react-native-pdf.podspec +++ b/react-native-pdf.podspec @@ -12,4 +12,5 @@ s.source = { :git => 'https://github.com/wonday/react-native-pdf.git' } s.platform = :ios, '8.0' s.source_files = "ios/**/*....
Fix compile issues with cocoapods 1.5+ Add React as explicit dependency
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -2,7 +2,7 @@ def new @trail = Trail.find(params[:trail_id]) - @comments = @trail.comments + ...
Create new comment to avoid nil form object
diff --git a/app/controllers/products_controller.rb b/app/controllers/products_controller.rb index abc1234..def5678 100644 --- a/app/controllers/products_controller.rb +++ b/app/controllers/products_controller.rb @@ -1,6 +1,6 @@ class ProductsController < ApplicationController def index - @productsbytitle = Pr...
Allow sort queries on All Products page
diff --git a/mellon.gemspec b/mellon.gemspec index abc1234..def5678 100644 --- a/mellon.gemspec +++ b/mellon.gemspec @@ -17,6 +17,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.add_dependency "plist" + spec.add_development_dependency "bundler", "~> 1...
Add plist for parsing secure notes from keychain
diff --git a/lib/rfm.rb b/lib/rfm.rb index abc1234..def5678 100644 --- a/lib/rfm.rb +++ b/lib/rfm.rb @@ -1,8 +1,11 @@-path = File.expand_path(File.dirname(__FILE__)) -$:.unshift(path) unless $:.include?(path) - -require path + '/rfm/utilities/case_insensitive_hash' -require path + '/rfm/utilities/factory' +# encoding: ...
Remove autoload in favor of require
diff --git a/app/models/manageiq/providers/amazon/network_manager/refresher.rb b/app/models/manageiq/providers/amazon/network_manager/refresher.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/amazon/network_manager/refresher.rb +++ b/app/models/manageiq/providers/amazon/network_manager/refresher.rb...
Change AWS Network Refresher to the new format Change AWS Network Refresher to the new format separating collection from parsing. We use Inventory abstraction for the inventory collection and parsing.
diff --git a/spec/exporter/test_dot.rb b/spec/exporter/test_dot.rb index abc1234..def5678 100644 --- a/spec/exporter/test_dot.rb +++ b/spec/exporter/test_dot.rb @@ -2,10 +2,26 @@ module Agora describe "Graphviz dot export" do + subject{ model.to_dot } + context 'on the minepump' do let(:model){ mine...
Add a dot test on a single goal.
diff --git a/spec/lib/hubstats_spec.rb b/spec/lib/hubstats_spec.rb index abc1234..def5678 100644 --- a/spec/lib/hubstats_spec.rb +++ b/spec/lib/hubstats_spec.rb @@ -2,15 +2,19 @@ describe Hubstats context ".config" do + subject { Hubstats } + after do + Hubstats.class_variable_set(:@@config, nil) + e...
Fix race condition in the config test
diff --git a/db/migrate/20131123172825_create_asset_attachments.rb b/db/migrate/20131123172825_create_asset_attachments.rb index abc1234..def5678 100644 --- a/db/migrate/20131123172825_create_asset_attachments.rb +++ b/db/migrate/20131123172825_create_asset_attachments.rb @@ -1,8 +1,8 @@ class CreateAssetAttachments < ...
Fix migration for rails 5
diff --git a/test/daimon_skycrawlers/commands/enqueue_test.rb b/test/daimon_skycrawlers/commands/enqueue_test.rb index abc1234..def5678 100644 --- a/test/daimon_skycrawlers/commands/enqueue_test.rb +++ b/test/daimon_skycrawlers/commands/enqueue_test.rb @@ -0,0 +1,77 @@+require "test_helper" +require "daimon_skycrawlers...
Add test for daimon_skycrawlers enqueue sub command
diff --git a/lib/domgen.rb b/lib/domgen.rb index abc1234..def5678 100644 --- a/lib/domgen.rb +++ b/lib/domgen.rb @@ -16,6 +16,7 @@ # Ruby require 'domgen/ruby/model' +require 'domgen/ruby/helper' # SQL require 'domgen/sql/model'
Make sure the ruby helper is required
diff --git a/test/integration/default/serverspec/ruby_spec.rb b/test/integration/default/serverspec/ruby_spec.rb index abc1234..def5678 100644 --- a/test/integration/default/serverspec/ruby_spec.rb +++ b/test/integration/default/serverspec/ruby_spec.rb @@ -0,0 +1,22 @@+require "spec_helper" + +describe "practicingruby:...
Add integration test for Ruby
diff --git a/contrib/ruby_event_store-protobuf/lib/ruby_event_store/protobuf.rb b/contrib/ruby_event_store-protobuf/lib/ruby_event_store/protobuf.rb index abc1234..def5678 100644 --- a/contrib/ruby_event_store-protobuf/lib/ruby_event_store/protobuf.rb +++ b/contrib/ruby_event_store-protobuf/lib/ruby_event_store/protobu...
Define aliases for backward compatibility
diff --git a/lib/swftly.rb b/lib/swftly.rb index abc1234..def5678 100644 --- a/lib/swftly.rb +++ b/lib/swftly.rb @@ -1,37 +1,49 @@ class Swftly - attr_reader :swf - - #init w/ a swf - def initialize( swf, options = {} ) + require 'curb' + attr_reader :auto_process, :swf, :runtime, :markup, :raw, + :...
Add some basic functionality, plus the tie-in to the Runtime class.
diff --git a/roadie.gemspec b/roadie.gemspec index abc1234..def5678 100644 --- a/roadie.gemspec +++ b/roadie.gemspec @@ -21,13 +21,6 @@ s.add_development_dependency 'rspec' - # TODO: Remove these dependencies - s.add_dependency 'actionmailer', '> 3.0.0', '< 5.0.0' - s.add_dependency 'sprockets' - s.add_develo...
Remove Rails, Sprockets and ActionMailer dependencies
diff --git a/app/services/generate_envelope_dump.rb b/app/services/generate_envelope_dump.rb index abc1234..def5678 100644 --- a/app/services/generate_envelope_dump.rb +++ b/app/services/generate_envelope_dump.rb @@ -33,15 +33,9 @@ end def write_dump_to_file - File.write(dump_file, dump_contents) - end - - ...
Optimize dump file generation code An intermediary string that contained all the dumped envelopes is discarded in favor of writing directly to the final file on disk.
diff --git a/wordpress_deploy.gemspec b/wordpress_deploy.gemspec index abc1234..def5678 100644 --- a/wordpress_deploy.gemspec +++ b/wordpress_deploy.gemspec @@ -5,8 +5,8 @@ gem.authors = ["Ryan Lovelett"] gem.email = ["ryan@lovelett.me"] gem.description = %q{Used to deploy a Wordpress site.} - ...
Update Gemspec summary and homepage.
diff --git a/features/step_definitions/moderate_proposed_organisation_steps.rb b/features/step_definitions/moderate_proposed_organisation_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/moderate_proposed_organisation_steps.rb +++ b/features/step_definitions/moderate_proposed_organisation_steps.rb...
Fix step for accept/reject button
diff --git a/lib/commutator/simple_client.rb b/lib/commutator/simple_client.rb index abc1234..def5678 100644 --- a/lib/commutator/simple_client.rb +++ b/lib/commutator/simple_client.rb @@ -17,10 +17,10 @@ super Aws::DynamoDB::Client.new(options) end - # `**kwargs` automatically calls `to_hash` on Option...
Make SimpleClient compatible with ruby 2.3 Somehow `super kwargs` worked pre-2.3 but resulted in `NoMethodError: super called outside of method` in 2.3 I still don't understand why, but this is a better implementation anyway
diff --git a/app/views/courses/course.json.jbuilder b/app/views/courses/course.json.jbuilder index abc1234..def5678 100644 --- a/app/views/courses/course.json.jbuilder +++ b/app/views/courses/course.json.jbuilder @@ -9,9 +9,7 @@ json.published CohortsCourses.exists?(course_id: @course.id) json.enroll_url "#{reques...
Update one more instance where new article count logic is duplicated. We want to use course.new_article_count as the canonical definition of how many new articles were created by a class.
diff --git a/lib/capistrano/tasks/nodejs.rake b/lib/capistrano/tasks/nodejs.rake index abc1234..def5678 100644 --- a/lib/capistrano/tasks/nodejs.rake +++ b/lib/capistrano/tasks/nodejs.rake @@ -2,8 +2,8 @@ desc 'Install node packages in shared directory' task :install_packages do - run "ln -s #{shared_path}/no...
Use execute rather than run
diff --git a/app/models/shipit/deploy_spec/rubygems_discovery.rb b/app/models/shipit/deploy_spec/rubygems_discovery.rb index abc1234..def5678 100644 --- a/app/models/shipit/deploy_spec/rubygems_discovery.rb +++ b/app/models/shipit/deploy_spec/rubygems_discovery.rb @@ -15,7 +15,7 @@ def discover_gem_checklist ...
Fix rubygems checklist git tag command Shipit don't support annotated tags unfortunately :/
diff --git a/lib/danger/ci_source/bitrise.rb b/lib/danger/ci_source/bitrise.rb index abc1234..def5678 100644 --- a/lib/danger/ci_source/bitrise.rb +++ b/lib/danger/ci_source/bitrise.rb @@ -40,7 +40,7 @@ self.pull_request_id = env["BITRISE_PULL_REQUEST"] self.repo_url = env["GIT_REPOSITORY_URL"] - re...
Add lazy match to Bitrise repo URL regex Lazy match allows for periods in the repo name.
diff --git a/core/spec/support/rspec-activemodel-mocks-patch.rb b/core/spec/support/rspec-activemodel-mocks-patch.rb index abc1234..def5678 100644 --- a/core/spec/support/rspec-activemodel-mocks-patch.rb +++ b/core/spec/support/rspec-activemodel-mocks-patch.rb @@ -0,0 +1,8 @@+# Manually applied the patch from https://g...
Add rspec-activemodel-mocks patch until fixed upstream.
diff --git a/0_code_wars/6_is_prime.rb b/0_code_wars/6_is_prime.rb index abc1234..def5678 100644 --- a/0_code_wars/6_is_prime.rb +++ b/0_code_wars/6_is_prime.rb @@ -0,0 +1,16 @@+# http://www.codewars.com/kata/5262119038c0985a5b00029f/ +# --- iteration 1 --- +def isPrime(num) + return false if num < 2 + (2..(Math.sq...
Add code wars (6) is prime
diff --git a/app/controllers/spree/checkout_controller_decorator.rb b/app/controllers/spree/checkout_controller_decorator.rb index abc1234..def5678 100644 --- a/app/controllers/spree/checkout_controller_decorator.rb +++ b/app/controllers/spree/checkout_controller_decorator.rb @@ -12,7 +12,7 @@ def update_registrati...
Address state is required (and shouldn't be) Email validation in checkout controller decorator assumes the `address` state will be the present. Changed to use the first checkout step via `current_order.checkout_steps.first`. Fixes #59
diff --git a/nixos-i686.rb b/nixos-i686.rb index abc1234..def5678 100644 --- a/nixos-i686.rb +++ b/nixos-i686.rb @@ -3,7 +3,7 @@ gen_template( arch: "i686", - iso_url: "https://nixos.org/releases/nixos/15.09/nixos-15.09.1076.9220f03/nixos-minimal-15.09.1076.9220f03-i686-linux.iso", - iso_sha256: "4ffa1cbaa006bd6...
Update i686 template to nixos-16.03
diff --git a/lib/honeybadger-read-api/api.rb b/lib/honeybadger-read-api/api.rb index abc1234..def5678 100644 --- a/lib/honeybadger-read-api/api.rb +++ b/lib/honeybadger-read-api/api.rb @@ -20,7 +20,7 @@ private def request(path, options = {}) - uri = URI.join(Api.site, path, "?auth_token=#{access_...
Rework building the uri to enable pagination to properly implemented
diff --git a/lib/google-maps/location.rb b/lib/google-maps/location.rb index abc1234..def5678 100644 --- a/lib/google-maps/location.rb +++ b/lib/google-maps/location.rb @@ -17,9 +17,18 @@ end def self.find(address, language=:en) - API.query(:geocode_service, :language => language, :address => addr...
Add api key to Geocode API Google requires an API key for this API and you'll get over query limit errors early without it.
diff --git a/lib/pgbackups-archive/storage.rb b/lib/pgbackups-archive/storage.rb index abc1234..def5678 100644 --- a/lib/pgbackups-archive/storage.rb +++ b/lib/pgbackups-archive/storage.rb @@ -23,7 +23,7 @@ end def store - bucket.files.create :key => @key, :body => @file, :public => false + bucket.files.cr...
Use multipart uploads per Jonathan Baxter's fork
diff --git a/lib/kaminari-views-bootstrap.rb b/lib/kaminari-views-bootstrap.rb index abc1234..def5678 100644 --- a/lib/kaminari-views-bootstrap.rb +++ b/lib/kaminari-views-bootstrap.rb @@ -1,5 +1,6 @@ require "kaminari-views-bootstrap/version" module KaminariViewsBootstrap - + class Engine < Rails::Engine + end e...
Make Kaminari actually see this
diff --git a/Casks/dockermachine010.rb b/Casks/dockermachine010.rb index abc1234..def5678 100644 --- a/Casks/dockermachine010.rb +++ b/Casks/dockermachine010.rb @@ -0,0 +1,19 @@+cask :v1 => 'dockermachine010' do + version 'v0.1.0' + sha256 '9915d88f779915aa7f1d7ba2537433b15665030574d61b9e348dd1f7397606c4' + + # gith...
Add docker-machine with no boot2docker dependency
diff --git a/Casks/intellij-idea-ce.rb b/Casks/intellij-idea-ce.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-ce.rb +++ b/Casks/intellij-idea-ce.rb @@ -1,8 +1,8 @@ class IntellijIdeaCe < Cask - version '13.1.3' - sha256 '4b0e3cb665aa2e3523d3c90b0075292f5ba3eaaff2bfc4872e4438193e561067' + version '13.1.4...
Update IntelliJ IDEA to 13.1.4 Additionally, reuse `version` stanza to facilitate future updates
diff --git a/app/presenters/renalware/dashboard/dashboard_presenter.rb b/app/presenters/renalware/dashboard/dashboard_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/renalware/dashboard/dashboard_presenter.rb +++ b/app/presenters/renalware/dashboard/dashboard_presenter.rb @@ -1,4 +1,5 @@ require_depende...
Add explicit require to ensure presenter works in isolation
diff --git a/AGEmojiKeyboard.podspec b/AGEmojiKeyboard.podspec index abc1234..def5678 100644 --- a/AGEmojiKeyboard.podspec +++ b/AGEmojiKeyboard.podspec @@ -0,0 +1,23 @@+Pod::Spec.new do |s| + s.name = "AGEmojiKeyboard" + s.version = "0.1.0" + s.summary = "An emoji keyboard view that ca...
Create podspec file and edit required details
diff --git a/lib/ticket_evolution/offices.rb b/lib/ticket_evolution/offices.rb index abc1234..def5678 100644 --- a/lib/ticket_evolution/offices.rb +++ b/lib/ticket_evolution/offices.rb @@ -3,5 +3,6 @@ include TicketEvolution::Modules::List include TicketEvolution::Modules::Search include TicketEvolution::...
Allow office create (Sabre related).
diff --git a/lib/probes/active_record.rb b/lib/probes/active_record.rb index abc1234..def5678 100644 --- a/lib/probes/active_record.rb +++ b/lib/probes/active_record.rb @@ -4,7 +4,7 @@ module Base module ClassMethods def find_by_sql_with_probes(sql) - Dtrace::Probe::ActionController.find_by...
Correct call to ActiveRecord.find_by_sql probe, prompting exception on bad call to probes in ruby-dtrace. git-svn-id: ee21a9573714ad23dc07274cc891719afe0bb9d1@358 0a37a38d-5523-0410-8951-9484fa28833c
diff --git a/lib/webpay_rails/transaction.rb b/lib/webpay_rails/transaction.rb index abc1234..def5678 100644 --- a/lib/webpay_rails/transaction.rb +++ b/lib/webpay_rails/transaction.rb @@ -5,11 +5,10 @@ def initialize(params) @token = params[:token] @url = params[:url] - @valid_cert = params[:val...
Remove unused variable and fix success? method on Transaction
diff --git a/lib/worth_saving/form/record.rb b/lib/worth_saving/form/record.rb index abc1234..def5678 100644 --- a/lib/worth_saving/form/record.rb +++ b/lib/worth_saving/form/record.rb @@ -37,7 +37,7 @@ def rescued_record if record.is_a? Array rescued_record = record.dup - res...
Correct assignment to array's last element