diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/default_search_spec.rb b/spec/default_search_spec.rb index abc1234..def5678 100644 --- a/spec/default_search_spec.rb +++ b/spec/default_search_spec.rb @@ -20,7 +20,7 @@ end it "Should match partial title and TOC text" do - default_search('b3176352', 'Effects of globalization in india', 5) + ...
Make partial title and TOC match less strict.
diff --git a/spec/hosts/test_api_spec.rb b/spec/hosts/test_api_spec.rb index abc1234..def5678 100644 --- a/spec/hosts/test_api_spec.rb +++ b/spec/hosts/test_api_spec.rb @@ -9,5 +9,10 @@ it 'subject should return a catalogue' do expect(subject.call).to be_a(Puppet::Resource::Catalog) end + + it 'shoul...
Add to ensure that we generate coverage info for hosts
diff --git a/spec/lib/wiki_edits_spec.rb b/spec/lib/wiki_edits_spec.rb index abc1234..def5678 100644 --- a/spec/lib/wiki_edits_spec.rb +++ b/spec/lib/wiki_edits_spec.rb @@ -7,7 +7,15 @@ end describe '.tokens' do - pending 'should fetch edit tokens for an OAuthed user' + it 'should get edit tokens using OAu...
Add the start of a stub-based spec of WikiEdits
diff --git a/spec/support/html_helper.rb b/spec/support/html_helper.rb index abc1234..def5678 100644 --- a/spec/support/html_helper.rb +++ b/spec/support/html_helper.rb @@ -1,6 +1,6 @@ module OpenFoodNetwork module HtmlHelper - def save_and_open(html) + def html_save_and_open(html) require "launchy" ...
Rename spec support method for faster tab completion on save_and_open_page
diff --git a/climate_control.gemspec b/climate_control.gemspec index abc1234..def5678 100644 --- a/climate_control.gemspec +++ b/climate_control.gemspec @@ -5,8 +5,8 @@ Gem::Specification.new do |gem| gem.name = "climate_control" gem.version = ClimateControl::VERSION - gem.authors = ["Joshua Clayton"] - gem.ema...
Add myself as gem author
diff --git a/spec/controllers/spree/admin/sale_prices_controller_spec.rb b/spec/controllers/spree/admin/sale_prices_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/spree/admin/sale_prices_controller_spec.rb +++ b/spec/controllers/spree/admin/sale_prices_controller_spec.rb @@ -0,0 +1,27 @@+requir...
Introduce tests for the admin-controller: spec the destroy action.
diff --git a/mustache-js-rails.gemspec b/mustache-js-rails.gemspec index abc1234..def5678 100644 --- a/mustache-js-rails.gemspec +++ b/mustache-js-rails.gemspec @@ -19,5 +19,5 @@ s.files = Dir["{vendor,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "Gemfile", "README.md"] s.require_paths = ["lib"] - s.add_dependency...
Allow any Rails 5.x version
diff --git a/spec/formatters/key_value_deep_spec.rb b/spec/formatters/key_value_deep_spec.rb index abc1234..def5678 100644 --- a/spec/formatters/key_value_deep_spec.rb +++ b/spec/formatters/key_value_deep_spec.rb @@ -36,8 +36,7 @@ expect(subject).to include('params_object_key_array_1=2') end - it 'return the ...
Remove extraneous `puts` from spec This was probably mistakenly forgotten in #282. Also fixes a typo in the spec description.
diff --git a/app/controllers/api/v1/expense_reports_controller.rb b/app/controllers/api/v1/expense_reports_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/expense_reports_controller.rb +++ b/app/controllers/api/v1/expense_reports_controller.rb @@ -21,6 +21,14 @@ end def update + expen...
Implement expense report update action
diff --git a/spec/integration/integration_helper.rb b/spec/integration/integration_helper.rb index abc1234..def5678 100644 --- a/spec/integration/integration_helper.rb +++ b/spec/integration/integration_helper.rb @@ -21,11 +21,10 @@ end def use_cucumber_config(file) - if File.file?("#{@project_path}/con...
Fix style according to Mr. Rubocop
diff --git a/app/controllers/subscribem/application_controller.rb b/app/controllers/subscribem/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/subscribem/application_controller.rb +++ b/app/controllers/subscribem/application_controller.rb @@ -13,7 +13,7 @@ def current_user if us...
Fix warden error fetching current_user
diff --git a/app/jobs/enqueue_publishers_for_paypal_payout_job.rb b/app/jobs/enqueue_publishers_for_paypal_payout_job.rb index abc1234..def5678 100644 --- a/app/jobs/enqueue_publishers_for_paypal_payout_job.rb +++ b/app/jobs/enqueue_publishers_for_paypal_payout_job.rb @@ -3,7 +3,7 @@ def perform(should_send_notific...
Use the right country designation for country
diff --git a/db/migrate/20130911191210_add_data_dump_delayed_jobs.rb b/db/migrate/20130911191210_add_data_dump_delayed_jobs.rb index abc1234..def5678 100644 --- a/db/migrate/20130911191210_add_data_dump_delayed_jobs.rb +++ b/db/migrate/20130911191210_add_data_dump_delayed_jobs.rb @@ -0,0 +1,14 @@+class AddDataDumpDelay...
Add migration to set up delayed job
diff --git a/db/migrate/20140401181046_remove_simple_captcha_data.rb b/db/migrate/20140401181046_remove_simple_captcha_data.rb index abc1234..def5678 100644 --- a/db/migrate/20140401181046_remove_simple_captcha_data.rb +++ b/db/migrate/20140401181046_remove_simple_captcha_data.rb @@ -0,0 +1,15 @@+class RemoveSimpleCapt...
Add migration to remove simple_captcha_data table
diff --git a/db/migrate/20170227125753_change_column_type_to_text.rb b/db/migrate/20170227125753_change_column_type_to_text.rb index abc1234..def5678 100644 --- a/db/migrate/20170227125753_change_column_type_to_text.rb +++ b/db/migrate/20170227125753_change_column_type_to_text.rb @@ -0,0 +1,47 @@+class ChangeColumnType...
Create index against column type varchar for PostgreSQL
diff --git a/db/migrate/20191115150137_remove_heat_network_mekkos.rb b/db/migrate/20191115150137_remove_heat_network_mekkos.rb index abc1234..def5678 100644 --- a/db/migrate/20191115150137_remove_heat_network_mekkos.rb +++ b/db/migrate/20191115150137_remove_heat_network_mekkos.rb @@ -0,0 +1,11 @@+class RemoveHeatNetwor...
Add migration for removing old heat network mekkos
diff --git a/app/services/metrics/content_distribution_metrics.rb b/app/services/metrics/content_distribution_metrics.rb index abc1234..def5678 100644 --- a/app/services/metrics/content_distribution_metrics.rb +++ b/app/services/metrics/content_distribution_metrics.rb @@ -2,7 +2,7 @@ class ContentDistributionMetrics ...
Use the taxonomy metrics namespace for distribution metrics
diff --git a/cookbooks/zookeeper_cluster/metadata.rb b/cookbooks/zookeeper_cluster/metadata.rb index abc1234..def5678 100644 --- a/cookbooks/zookeeper_cluster/metadata.rb +++ b/cookbooks/zookeeper_cluster/metadata.rb @@ -8,8 +8,6 @@ depends "java" depends "apt" -depends "mountable_volumes"...
Remove 2 dependencies on provides_service and mountable_volumes from zookeeper. These just don't exist anywhere and they break bulk cookbook uploads
diff --git a/spec/features/users_spec.rb b/spec/features/users_spec.rb index abc1234..def5678 100644 --- a/spec/features/users_spec.rb +++ b/spec/features/users_spec.rb @@ -9,7 +9,7 @@ fill_in 'user_email', with: attributes_for(:user)[:email] fill_in 'user_password', with: attributes_for(:user)[:password] - ...
Change name of click button feature test
diff --git a/spec/message_filter_spec.rb b/spec/message_filter_spec.rb index abc1234..def5678 100644 --- a/spec/message_filter_spec.rb +++ b/spec/message_filter_spec.rb @@ -11,6 +11,9 @@ context 'with argument "foo"' do subject { MessageFilter.new('foo') } it_behaves_like 'MessageFilter with argument "foo"'...
Add example for ng_words size
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -3,19 +3,58 @@ require 'minitest/autorun' require 'mocha/mini_test' -def command_instance(klass, config={}, args=[]) - Miasma.test_api = connection - instance = klass.new(config.merge(:ui => ui, ...
Update mocking strategy for remote intecepts
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -20,12 +20,17 @@ Coveralls::SimpleCov::Formatter ] + add_group "Grammars" do |source_file| + source_file.filename =~ %r{\.y$} + end + + # Exclude the testsuite itself. ...
Add a separate coverage category for .y files.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -10,6 +10,7 @@ require 'rr' unless defined?(Test::Unit::AssertionFailedError) + require 'activesupport' class Test::Unit::AssertionFailedError < ActiveSupport::TestCase::Assertion end end
Bring in the big guns.
diff --git a/lib/browser.rb b/lib/browser.rb index abc1234..def5678 100644 --- a/lib/browser.rb +++ b/lib/browser.rb @@ -1,5 +1,5 @@ module Browser - ALLOWED_BROWSERS = %w[firefox ie11 ie10 ie9 ie8 ie7 chrome safari] + ALLOWED_BROWSERS = %w[firefox ie11 ie10 ie9 chrome safari] def user_agent case request.en...
Remove support for IE7 and IE8 Ref #1978
diff --git a/lib/chamber.rb b/lib/chamber.rb index abc1234..def5678 100644 --- a/lib/chamber.rb +++ b/lib/chamber.rb @@ -38,7 +38,10 @@ end def load_file(file_path) - settings.merge! YAML.load(File.read(file_path.to_s)) + file_contents = File.read(file_path.to_s) + yaml_contents = YAML.load(file_content...
Decompress a few lines for better readability
diff --git a/test/unit/services/link_checker_api_service_test.rb b/test/unit/services/link_checker_api_service_test.rb index abc1234..def5678 100644 --- a/test/unit/services/link_checker_api_service_test.rb +++ b/test/unit/services/link_checker_api_service_test.rb @@ -0,0 +1,38 @@+require 'test_helper' + +class LinkChe...
Add unit tests for link checker service In preparation for adding public URL lookups to the service.
diff --git a/test/tests/test_json_compare.rb b/test/tests/test_json_compare.rb index abc1234..def5678 100644 --- a/test/tests/test_json_compare.rb +++ b/test/tests/test_json_compare.rb @@ -7,6 +7,10 @@ File.delete @json_path if File.exist? @json_path Brakeman.run :app_path => @path, :output_files => [@json_pat...
Clean up JSON file from tests
diff --git a/test/unit/resque_worker_test.rb b/test/unit/resque_worker_test.rb index abc1234..def5678 100644 --- a/test/unit/resque_worker_test.rb +++ b/test/unit/resque_worker_test.rb @@ -25,14 +25,10 @@ resque_job_file = File.expand_path('./test_resque_job.rb', File.dirname(__FILE__)) require resque_job_file...
Remove extra report call in resque test
diff --git a/spec/features/projects/labels/update_prioritization_spec.rb b/spec/features/projects/labels/update_prioritization_spec.rb index abc1234..def5678 100644 --- a/spec/features/projects/labels/update_prioritization_spec.rb +++ b/spec/features/projects/labels/update_prioritization_spec.rb @@ -0,0 +1,78 @@+requir...
Add tests for label prioritization
diff --git a/test/iruby/jupyter_test.rb b/test/iruby/jupyter_test.rb index abc1234..def5678 100644 --- a/test/iruby/jupyter_test.rb +++ b/test/iruby/jupyter_test.rb @@ -3,24 +3,24 @@ module IRubyTest class JupyterDefaultKernelSpecDirectoryTest < TestBase def setup - @kernel_spec = IRuby::Jupyter.kernelspec...
Rename instance variable in a test
diff --git a/test_code/json_php_test_code.rb b/test_code/json_php_test_code.rb index abc1234..def5678 100644 --- a/test_code/json_php_test_code.rb +++ b/test_code/json_php_test_code.rb @@ -0,0 +1,52 @@+require 'json' +require 'faraday' + +url = "http://cal.syoboi.jp" +json_path = "/json.php" + +program_title = "冴えない彼女の...
Add test program of json.php
diff --git a/test/test_faker_bitcoin.rb b/test/test_faker_bitcoin.rb index abc1234..def5678 100644 --- a/test/test_faker_bitcoin.rb +++ b/test/test_faker_bitcoin.rb @@ -7,8 +7,8 @@ end def test_testnet_address - assert_match /\A[mn][1-9A-Za-z]{32,34}\Z/, Faker::Bitcoin.testnet_address - assert_not_match /[...
Remove `warning: ambiguous first argument; put parentheses or a space even after `/' operator`
diff --git a/lib/context.rb b/lib/context.rb index abc1234..def5678 100644 --- a/lib/context.rb +++ b/lib/context.rb @@ -1,32 +1,43 @@ require 'application_insights' -module AIAgent +module ApplicationInsightsInstaller class Context class << self - def self.configure(config) - @context = Applicati...
Update Context class to read the settings from a toml file
diff --git a/loquor.gemspec b/loquor.gemspec index abc1234..def5678 100644 --- a/loquor.gemspec +++ b/loquor.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_dependency 'filum', '0.0.1' + spec.add_dependency 'filum', '0.0.2' s...
Upgrade filum to fix tests.
diff --git a/db/migrate/20161128102235_change_art_museum_to_museum_art.rb b/db/migrate/20161128102235_change_art_museum_to_museum_art.rb index abc1234..def5678 100644 --- a/db/migrate/20161128102235_change_art_museum_to_museum_art.rb +++ b/db/migrate/20161128102235_change_art_museum_to_museum_art.rb @@ -0,0 +1,27 @@+cl...
Rename and migrate art_museum.png to museum_art.png in node_types table Fixes 404 - icon not found error for "Art Museum" Related Github issue: #484
diff --git a/db/migrate/20161128102235_change_art_museum_to_museum_art.rb b/db/migrate/20161128102235_change_art_museum_to_museum_art.rb index abc1234..def5678 100644 --- a/db/migrate/20161128102235_change_art_museum_to_museum_art.rb +++ b/db/migrate/20161128102235_change_art_museum_to_museum_art.rb @@ -6,7 +6,7 @@ ...
Rename NodeType class back to LocalNodeType to use own model for migration
diff --git a/core/kernel/printf_spec.rb b/core/kernel/printf_spec.rb index abc1234..def5678 100644 --- a/core/kernel/printf_spec.rb +++ b/core/kernel/printf_spec.rb @@ -8,5 +8,27 @@ end describe "Kernel.printf" do - it "needs to be reviewed for spec completeness" + + before :each do + @stdout = $stdout + @na...
Add basic specs for Kernel.printf
diff --git a/backend/spec/controllers/api/v1/sessions_controller_spec.rb b/backend/spec/controllers/api/v1/sessions_controller_spec.rb index abc1234..def5678 100644 --- a/backend/spec/controllers/api/v1/sessions_controller_spec.rb +++ b/backend/spec/controllers/api/v1/sessions_controller_spec.rb @@ -28,25 +28,4 @@ ...
Drop test cases for session destroy.
diff --git a/actionsystemtest/lib/action_system_test/driver_adapters/web_server.rb b/actionsystemtest/lib/action_system_test/driver_adapters/web_server.rb index abc1234..def5678 100644 --- a/actionsystemtest/lib/action_system_test/driver_adapters/web_server.rb +++ b/actionsystemtest/lib/action_system_test/driver_adapte...
Use 1 thread instead of 4 with Puma server for system tests
diff --git a/app/controllers/admin/alert_types/find_out_more_preview_controller.rb b/app/controllers/admin/alert_types/find_out_more_preview_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/alert_types/find_out_more_preview_controller.rb +++ b/app/controllers/admin/alert_types/find_out_more_previ...
Use same ordering in FOM preview as dashboard
diff --git a/lib/ohai/plugins/erlang.rb b/lib/ohai/plugins/erlang.rb index abc1234..def5678 100644 --- a/lib/ohai/plugins/erlang.rb +++ b/lib/ohai/plugins/erlang.rb @@ -23,10 +23,10 @@ output = nil erlang = Mash.new -status, stdout, error = run_command(:no_status_check => true, :command => "erl +V") +status, stdout,...
Fix typo in Erlang plugin
diff --git a/lib/redmine/redmine-api.rb b/lib/redmine/redmine-api.rb index abc1234..def5678 100644 --- a/lib/redmine/redmine-api.rb +++ b/lib/redmine/redmine-api.rb @@ -31,6 +31,19 @@ end class Issue < Base + def self.find(*arguments) + scope = arguments.slice!(0) + options = arguments.slice!(0) |...
Refactor RedmineAPI::Issue.find to include journals which allows access to notes/comments
diff --git a/lib/stacks/proxy_server.rb b/lib/stacks/proxy_server.rb index abc1234..def5678 100644 --- a/lib/stacks/proxy_server.rb +++ b/lib/stacks/proxy_server.rb @@ -6,9 +6,6 @@ def initialize(virtual_service, index) super(virtual_service.name + "-" + index) @virtual_service = virtual_service - @downs...
Remove code which doesn't appear to be needed that was throwing me off
diff --git a/lib/tasks/data_points.rake b/lib/tasks/data_points.rake index abc1234..def5678 100644 --- a/lib/tasks/data_points.rake +++ b/lib/tasks/data_points.rake @@ -5,6 +5,7 @@ desc "Load data points and related records." task load: :environment do SpreadsheetConverter.new('db/fixtures/data_points.c...
Check if column even exists
diff --git a/core/app/controllers/spree/admin/tax_settings_controller.rb b/core/app/controllers/spree/admin/tax_settings_controller.rb index abc1234..def5678 100644 --- a/core/app/controllers/spree/admin/tax_settings_controller.rb +++ b/core/app/controllers/spree/admin/tax_settings_controller.rb @@ -7,7 +7,7 @@ ...
Fix - Shipment includes vat is allways false after save Fixes #2368
diff --git a/features/step_definitions/bold_steps.rb b/features/step_definitions/bold_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/bold_steps.rb +++ b/features/step_definitions/bold_steps.rb @@ -1,5 +1,5 @@ When /^I get the bold text for the "([^\"]*)" element$/ do |el| - @b = @page.send "#{e...
Add support of <b> tag
diff --git a/spec/integration/start_page_spec.rb b/spec/integration/start_page_spec.rb index abc1234..def5678 100644 --- a/spec/integration/start_page_spec.rb +++ b/spec/integration/start_page_spec.rb @@ -19,6 +19,7 @@ end page.should have_selector(".article-container #test-report_a_problem") + page...
Add test for related items on start page.
diff --git a/spec/lib/locales_validation_spec.rb b/spec/lib/locales_validation_spec.rb index abc1234..def5678 100644 --- a/spec/lib/locales_validation_spec.rb +++ b/spec/lib/locales_validation_spec.rb @@ -1,6 +1,12 @@ RSpec.describe "locales files" do it "should meet all locale validation requirements" do - check...
Update the list of keys that should be skipped This spec is running the same rake tasks. It needs it's own list of excluded keys. See: https://github.com/alphagov/rails_translation_manager/blob/e6d46f03cf1d9a75f852784aaab385ed48de1147/lib/rails_translation_manager/locale_checker.rb#L15
diff --git a/spec/lita/handlers/hal_9000_spec.rb b/spec/lita/handlers/hal_9000_spec.rb index abc1234..def5678 100644 --- a/spec/lita/handlers/hal_9000_spec.rb +++ b/spec/lita/handlers/hal_9000_spec.rb @@ -1,4 +1,5 @@ require "spec_helper" describe Lita::Handlers::Hal9000, lita_handler: true do + it { is_expected.to...
Add initial test to ensure routes event
diff --git a/spec/unit/relation/join_dsl_spec.rb b/spec/unit/relation/join_dsl_spec.rb index abc1234..def5678 100644 --- a/spec/unit/relation/join_dsl_spec.rb +++ b/spec/unit/relation/join_dsl_spec.rb @@ -21,5 +21,29 @@ expect(result.to_a). to eql([name: 'Jane', title: "Jane's task" ]) end + + it...
Add specs for left and right joins
diff --git a/spec/unit/trello/basic_data_spec.rb b/spec/unit/trello/basic_data_spec.rb index abc1234..def5678 100644 --- a/spec/unit/trello/basic_data_spec.rb +++ b/spec/unit/trello/basic_data_spec.rb @@ -0,0 +1,18 @@+require 'spec_helper' + +RSpec.describe Trello::BasicData do + + describe '.many' do + let(:associ...
Add unit test for Trello::BasicData.many
diff --git a/db/migrate/20150406222613_add_attachment_avatar_to_users.rb b/db/migrate/20150406222613_add_attachment_avatar_to_users.rb index abc1234..def5678 100644 --- a/db/migrate/20150406222613_add_attachment_avatar_to_users.rb +++ b/db/migrate/20150406222613_add_attachment_avatar_to_users.rb @@ -1,6 +1,7 @@ class A...
Fix migration adding avatar attachment
diff --git a/zencoder.gemspec b/zencoder.gemspec index abc1234..def5678 100644 --- a/zencoder.gemspec +++ b/zencoder.gemspec @@ -14,8 +14,7 @@ s.summary = "Zencoder <http://zencoder.com> integration library." s.description = "Zencoder <http://zencoder.com> integration library." s.rubyforge_project = "zencod...
Change gemspec dependency from json libs to active support
diff --git a/spec/config_spec.rb b/spec/config_spec.rb index abc1234..def5678 100644 --- a/spec/config_spec.rb +++ b/spec/config_spec.rb @@ -0,0 +1,54 @@+require 'client_helper' + +describe Cyclid::Client::Config do + it 'loads a valid configuration' do + config = nil + expect{ config = Cyclid::Client::Config.ne...
Add tests specific to configuration files
diff --git a/lib/b2b_center_api/web_service/types/array_of_ids.rb b/lib/b2b_center_api/web_service/types/array_of_ids.rb index abc1234..def5678 100644 --- a/lib/b2b_center_api/web_service/types/array_of_ids.rb +++ b/lib/b2b_center_api/web_service/types/array_of_ids.rb @@ -12,7 +12,7 @@ def self.from_response(re...
Fix bug returning Array of Ids
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -19,5 +19,10 @@ Capybara.default_selector = :xpath end end + +# Until this library is merge with capybara there needs to be local app and you need to add +# 127.0.0.1 capyb...
Add simple instructions to get the tests running
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,9 +1,9 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) -require "codeclimate-test-reporter" -CodeClimate::TestReporter.start +require 'simplecov' +SimpleCov.star...
[Test] Replace deprecated CodeClimate::TestReporter by SimpleCov
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -23,3 +23,24 @@ PuppetlabsSpec::Files.cleanup end end + +require 'pathname' +dir = Pathname.new(__FILE__).parent +Puppet[:modulepath] = File.join(dir, 'fixtures', 'modules'...
Use modulesync to manage meta files
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,4 +11,7 @@ config.before :all do CreateAllTables.up unless ActiveRecord::Base.connection.table_exists? 'foos' end + config.after :each do + [Foo, Bar, Baz].each{|...
Delete all records after each examples
diff --git a/lib/generators/stripe_webhooks/callback_generator.rb b/lib/generators/stripe_webhooks/callback_generator.rb index abc1234..def5678 100644 --- a/lib/generators/stripe_webhooks/callback_generator.rb +++ b/lib/generators/stripe_webhooks/callback_generator.rb @@ -15,9 +15,9 @@ end template 'ca...
Fix issue in generator where RSpec.configuration is nil
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,6 +11,7 @@ conf.include Webrat::Methods conf.include Webrat::Matchers conf.before(:each) { WebMock.reset! } + conf.after(:each) { Timecop.return } end WebMock.disa...
Reset Timecop after each spec
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -8,8 +8,8 @@ require_relative 'unit/connection/test_client' # INSERT YOUR API KEYS HERE -APIKEY = "key" -PUB_APIKEY = "pubkey" +APIKEY = ENV['MAILGUN_API_KEY'] +PUB_APIKEY = ENV...
Use environment variables for API keys Since we have to use our own keys to run the tests on this gem, support using environment variables so we don’t have to edit this file and remember to revert it back before committing. This way we can run tests like: `MAILGUN_API_KEY=abcd MAILGUN_PUBLIC_KEY=1234 bundle exec rspe...
diff --git a/db/fixtures/development/25_api_personal_access_token.rb b/db/fixtures/development/25_api_personal_access_token.rb index abc1234..def5678 100644 --- a/db/fixtures/development/25_api_personal_access_token.rb +++ b/db/fixtures/development/25_api_personal_access_token.rb @@ -0,0 +1,15 @@+# frozen_string_litera...
Add seed for personal access token
diff --git a/db/migrate/20120419093427_add_kind_to_physical_roads.rb b/db/migrate/20120419093427_add_kind_to_physical_roads.rb index abc1234..def5678 100644 --- a/db/migrate/20120419093427_add_kind_to_physical_roads.rb +++ b/db/migrate/20120419093427_add_kind_to_physical_roads.rb @@ -2,8 +2,8 @@ def change add_c...
Delete lines which fails on Centos postgresql
diff --git a/db/migrate/20151208181322_add_released_at_to_episode.rb b/db/migrate/20151208181322_add_released_at_to_episode.rb index abc1234..def5678 100644 --- a/db/migrate/20151208181322_add_released_at_to_episode.rb +++ b/db/migrate/20151208181322_add_released_at_to_episode.rb @@ -1,5 +1,5 @@ class AddReleasedAtToEp...
Use the same type as the last_build_date
diff --git a/db/migrate/20190212153345_change_export_id_to_bigint.rb b/db/migrate/20190212153345_change_export_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190212153345_change_export_id_to_bigint.rb +++ b/db/migrate/20190212153345_change_export_id_to_bigint.rb @@ -0,0 +1,9 @@+class ChangeExportIdToB...
Update export_id foreign key to bigint
diff --git a/rake/lib/rake/filelist.rb b/rake/lib/rake/filelist.rb index abc1234..def5678 100644 --- a/rake/lib/rake/filelist.rb +++ b/rake/lib/rake/filelist.rb @@ -10,7 +10,9 @@ filenames.each do |fn| case fn when Array - fn.each { |f| self << f } + fn.each { |f| self.add(f) } + when %r{[*?]} + add_mat...
Add now handles patterns as a special case. Add_matching is now private. git-svn-id: 6a2c20c72ceedae27ecedb68e90cd4f115192a7a@59 5af023f1-ac1a-0410-98d6-829a145c37ef
diff --git a/activerecord/lib/active_record/relation/predicate_builder.rb b/activerecord/lib/active_record/relation/predicate_builder.rb index abc1234..def5678 100644 --- a/activerecord/lib/active_record/relation/predicate_builder.rb +++ b/activerecord/lib/active_record/relation/predicate_builder.rb @@ -23,8 +23,15 @@ ...
Handle Range with excluded end
diff --git a/lib/generators/shopify_app/templates/app/controllers/home_controller.rb b/lib/generators/shopify_app/templates/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/lib/generators/shopify_app/templates/app/controllers/home_controller.rb +++ b/lib/generators/shopify_app/templates/app/contro...
Comment shows right number of products
diff --git a/modules/openconnect/spec/classes/openconnect_spec.rb b/modules/openconnect/spec/classes/openconnect_spec.rb index abc1234..def5678 100644 --- a/modules/openconnect/spec/classes/openconnect_spec.rb +++ b/modules/openconnect/spec/classes/openconnect_spec.rb @@ -0,0 +1,29 @@+require_relative '../../../../spec...
Add spec tests for OpenConnect We have logic in a template. So I'd be a lot happier if we had positive/negative tests for the desired behaviour.
diff --git a/lib/rails_core_extensions/active_record_liquid_extensions.rb b/lib/rails_core_extensions/active_record_liquid_extensions.rb index abc1234..def5678 100644 --- a/lib/rails_core_extensions/active_record_liquid_extensions.rb +++ b/lib/rails_core_extensions/active_record_liquid_extensions.rb @@ -10,7 +10,7 @@ ...
Fix passing of symbol to liquid template
diff --git a/Library/Homebrew/cmd/sh.rb b/Library/Homebrew/cmd/sh.rb index abc1234..def5678 100644 --- a/Library/Homebrew/cmd/sh.rb +++ b/Library/Homebrew/cmd/sh.rb @@ -16,7 +16,6 @@ end ENV['PS1'] = 'brew \[\033[1;32m\]\w\[\033[0m\]$ ' ENV['VERBOSE'] = '1' - ENV['HOMEBREW_LOG'] = '1' puts <<-EOS....
Remove ENV variable that is no longer used
diff --git a/features/step_definitions/git_files_step_definitions.rb b/features/step_definitions/git_files_step_definitions.rb index abc1234..def5678 100644 --- a/features/step_definitions/git_files_step_definitions.rb +++ b/features/step_definitions/git_files_step_definitions.rb @@ -0,0 +1,8 @@+World(Aruba::Api) + +Gi...
Add step definition to add files to Git
diff --git a/features/support/page_models/page_actions/footer_actions.rb b/features/support/page_models/page_actions/footer_actions.rb index abc1234..def5678 100644 --- a/features/support/page_models/page_actions/footer_actions.rb +++ b/features/support/page_models/page_actions/footer_actions.rb @@ -1,13 +1,21 @@-def c...
Correct format in footer actions
diff --git a/nanoc/lib/nanoc/base/services/compiler/stages/build_reps.rb b/nanoc/lib/nanoc/base/services/compiler/stages/build_reps.rb index abc1234..def5678 100644 --- a/nanoc/lib/nanoc/base/services/compiler/stages/build_reps.rb +++ b/nanoc/lib/nanoc/base/services/compiler/stages/build_reps.rb @@ -5,6 +5,9 @@ cla...
Refactor: Add contracts to BuildReps stage
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -2,6 +2,7 @@ backend_resources :download_categories backend_resources :downloads do member { get :download } + member { post :toggle_published } end root to: 'home#index'
Add route to toggle published status.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -24,7 +24,7 @@ # get "/auth/github/callback", to: "sessions#create" # get "/sign_out", to: "sessions#destroy" - get "/pages/*id" => "pages#show", as: :page, format: false + get "/page...
Use the plural for path helpers
diff --git a/test/specialization_breadcrumb_test.rb b/test/specialization_breadcrumb_test.rb index abc1234..def5678 100644 --- a/test/specialization_breadcrumb_test.rb +++ b/test/specialization_breadcrumb_test.rb @@ -1,6 +1,12 @@ require 'test_helper' describe 'Redis::Breadcrumb' do + class SpecializedBreadcrumb < ...
Add test 'can specialize owned key names'
diff --git a/spec/controllers/hanuman/api/v1/questions_controller_spec.rb b/spec/controllers/hanuman/api/v1/questions_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/hanuman/api/v1/questions_controller_spec.rb +++ b/spec/controllers/hanuman/api/v1/questions_controller_spec.rb @@ -18,4 +18,31 @@ ...
Add missing tests for questions controller under v1 api
diff --git a/spec/higher_level_api/integration/publisher_confirms_spec.rb b/spec/higher_level_api/integration/publisher_confirms_spec.rb index abc1234..def5678 100644 --- a/spec/higher_level_api/integration/publisher_confirms_spec.rb +++ b/spec/higher_level_api/integration/publisher_confirms_spec.rb @@ -29,7 +29,8 @@ ...
Insert a brief sleep to allow all messages to be confirmed before message_count is called
diff --git a/trove.gemspec b/trove.gemspec index abc1234..def5678 100644 --- a/trove.gemspec +++ b/trove.gemspec @@ -9,7 +9,7 @@ spec.authors = ["query-string"] spec.email = ["atimofeev@reactant.ru"] spec.summary = %q{Simple wrapper for interacting with Trove (http://trove.nla.gov.au/) API} ...
Change API link to full technical guide
diff --git a/app/controllers/uramon_article_viewer/articles_controller.rb b/app/controllers/uramon_article_viewer/articles_controller.rb index abc1234..def5678 100644 --- a/app/controllers/uramon_article_viewer/articles_controller.rb +++ b/app/controllers/uramon_article_viewer/articles_controller.rb @@ -8,12 +8,13 @@ ...
Add "/admin" prefix to path for article_manager
diff --git a/lib/i18n/workflow/translation_helper.rb b/lib/i18n/workflow/translation_helper.rb index abc1234..def5678 100644 --- a/lib/i18n/workflow/translation_helper.rb +++ b/lib/i18n/workflow/translation_helper.rb @@ -4,11 +4,11 @@ module TranslationHelper def translate_with_rescue_format(key, optio...
Fix issues with missing translation handling Updates to I18n and ActionView seem to have changed the behaviour. We always need to provide the `raise: false` option to activate the custom exception handler.
diff --git a/lib/kosmos/packages/tac_life_support.rb b/lib/kosmos/packages/tac_life_support.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/tac_life_support.rb +++ b/lib/kosmos/packages/tac_life_support.rb @@ -2,6 +2,7 @@ title 'TAC Life Support (WIP)' aliases 'tac life support' url 'https://github.c...
Add ModuleManager dependence to TAC Life.
diff --git a/lib/swagger/docs/generator/generator.rb b/lib/swagger/docs/generator/generator.rb index abc1234..def5678 100644 --- a/lib/swagger/docs/generator/generator.rb +++ b/lib/swagger/docs/generator/generator.rb @@ -41,7 +41,7 @@ end def agregate_metadata - case Rails.env + cas...
Fix test Rails class exists
diff --git a/lib/tritium/parser/instructions/base.rb b/lib/tritium/parser/instructions/base.rb index abc1234..def5678 100644 --- a/lib/tritium/parser/instructions/base.rb +++ b/lib/tritium/parser/instructions/base.rb @@ -49,7 +49,7 @@ end def returns - spec.returns + spec.re...
Set a default return type to "Text"
diff --git a/lib/device_recipes/automated_architecture/siren_of_shame.rb b/lib/device_recipes/automated_architecture/siren_of_shame.rb index abc1234..def5678 100644 --- a/lib/device_recipes/automated_architecture/siren_of_shame.rb +++ b/lib/device_recipes/automated_architecture/siren_of_shame.rb @@ -3,14 +3,12 @@ m...
Remove sound and audio for success and reduce audio time to 5 seconds
diff --git a/lib/puppet/provider/netscaler_lbvserver_service_bind/rest.rb b/lib/puppet/provider/netscaler_lbvserver_service_bind/rest.rb index abc1234..def5678 100644 --- a/lib/puppet/provider/netscaler_lbvserver_service_bind/rest.rb +++ b/lib/puppet/provider/netscaler_lbvserver_service_bind/rest.rb @@ -36,4 +36,12 @@ ...
Fix for lbvserver_service_bind destroy issues
diff --git a/app/api/pushificator/v1.rb b/app/api/pushificator/v1.rb index abc1234..def5678 100644 --- a/app/api/pushificator/v1.rb +++ b/app/api/pushificator/v1.rb @@ -11,6 +11,7 @@ before do header['Access-Control-Allow-Origin'] = '*' header['Access-Control-Request-Method'] = '*' + header['Acce...
Add CORS header to api
diff --git a/app/models/feedback_sms.rb b/app/models/feedback_sms.rb index abc1234..def5678 100644 --- a/app/models/feedback_sms.rb +++ b/app/models/feedback_sms.rb @@ -9,7 +9,7 @@ end def address - "1234 Lincoln Way West" + "#{property_number} Lincoln Way West" end def property_number
Make address a simple function of input property code (always same street for testing)
diff --git a/lib/consistency_fail/enforcer.rb b/lib/consistency_fail/enforcer.rb index abc1234..def5678 100644 --- a/lib/consistency_fail/enforcer.rb +++ b/lib/consistency_fail/enforcer.rb @@ -15,7 +15,8 @@ models.preload_all introspectors = [ConsistencyFail::Introspectors::ValidatesUniquenessOf.new, - ...
Add polymorphic has_one to the Enforcer
diff --git a/app/controllers/email_configurations_controller.rb b/app/controllers/email_configurations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/email_configurations_controller.rb +++ b/app/controllers/email_configurations_controller.rb @@ -25,8 +25,8 @@ end def try_email - output = Ja...
Fix email test output formating
diff --git a/railties/test/generators/integration_test_generator_test.rb b/railties/test/generators/integration_test_generator_test.rb index abc1234..def5678 100644 --- a/railties/test/generators/integration_test_generator_test.rb +++ b/railties/test/generators/integration_test_generator_test.rb @@ -3,10 +3,14 @@ cla...
Add test for generate namespaced integration test
diff --git a/vagrant.rb b/vagrant.rb index abc1234..def5678 100644 --- a/vagrant.rb +++ b/vagrant.rb @@ -5,6 +5,7 @@ sudo apt-get -qq update sudo DEBIAN_FRONTEND=noninteractive apt-get -qq -y install chef sudo DEBIAN_FRONTEND=noninteractive apt-get -qq -y install exim4-base + sudo DEBIAN_FRONTEND=n...
Install mailutils, required for tests of sys::mail
diff --git a/spec/acceptance_tests/suite_2/application_tours_spec.rb b/spec/acceptance_tests/suite_2/application_tours_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance_tests/suite_2/application_tours_spec.rb +++ b/spec/acceptance_tests/suite_2/application_tours_spec.rb @@ -33,8 +33,7 @@ it 'does not ...
Use helper function instead of manually accessing the DOM to close tour.
diff --git a/lib/flightaware/client/client.rb b/lib/flightaware/client/client.rb index abc1234..def5678 100644 --- a/lib/flightaware/client/client.rb +++ b/lib/flightaware/client/client.rb @@ -18,10 +18,10 @@ attr_reader :bytes attr_reader :pkts - def initialize(config, out = nil) + def initialize(conf...
Use the new interface for callback def.
diff --git a/Casks/printer-pro-desktop.rb b/Casks/printer-pro-desktop.rb index abc1234..def5678 100644 --- a/Casks/printer-pro-desktop.rb +++ b/Casks/printer-pro-desktop.rb @@ -0,0 +1,11 @@+cask :v1 => 'printer-pro-desktop' do + version '1.3.7' + sha256 '6baa80352c3756824972a6aac8ebdabebcc082f693018d04a7a95f062565e70...
Add Printer Pro Desktop v1.3.7
diff --git a/lib/mongoid_auto_increment_id.rb b/lib/mongoid_auto_increment_id.rb index abc1234..def5678 100644 --- a/lib/mongoid_auto_increment_id.rb +++ b/lib/mongoid_auto_increment_id.rb @@ -3,16 +3,15 @@ include Components end - class Identity - protected - def generate_id - table_name...
Fix relation Model id convert bug.
diff --git a/test/daliagraphite_test.rb b/test/daliagraphite_test.rb index abc1234..def5678 100644 --- a/test/daliagraphite_test.rb +++ b/test/daliagraphite_test.rb @@ -0,0 +1,29 @@+require "minitest/unit" +require "minitest/autorun" +require "mocha/setup" +require_relative "../lib/daliagraphite" + +class DaliaGraphite...
Implement basic tests for datapoint and counter methods
diff --git a/lib/rails_sequel/rails_sequel.rb b/lib/rails_sequel/rails_sequel.rb index abc1234..def5678 100644 --- a/lib/rails_sequel/rails_sequel.rb +++ b/lib/rails_sequel/rails_sequel.rb @@ -33,6 +33,8 @@ # MSSQL support options[:db_type] = config[:db_type] if config[:db_type] options[:socket] = c...
Add :charset and :encoding options Signed-off-by: Piotr Usewicz <2c0eb4a25a7cde333ff2d0860cb06051925fd74f@layer22.com>