diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/api_cache.gemspec b/api_cache.gemspec index abc1234..def5678 100644 --- a/api_cache.gemspec +++ b/api_cache.gemspec @@ -16,7 +16,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] - s.add_development_dependency('rspec', "~> 2.8") + s.ad...
Add rspec ~> 2.7 to gemspec development dependencies
diff --git a/lib/structured_logger.rb b/lib/structured_logger.rb index abc1234..def5678 100644 --- a/lib/structured_logger.rb +++ b/lib/structured_logger.rb @@ -6,10 +6,11 @@ class StructuredLogger - def initialize(name, log_device=STDOUT) + def initialize(name, level=Logger::DEBUG, log_device=STDOUT) @logge...
Allow setting the level for the logger
diff --git a/lib/tasks/pathology.rake b/lib/tasks/pathology.rake index abc1234..def5678 100644 --- a/lib/tasks/pathology.rake +++ b/lib/tasks/pathology.rake @@ -0,0 +1,29 @@+require "benchmark" + +namespace :pathology do + namespace :test do + desc "In development only, import a test HL7 message. Useful for testing...
Add rake task to help debugging HL7 messages rake pathology:test:import_one
diff --git a/arbre.gemspec b/arbre.gemspec index abc1234..def5678 100644 --- a/arbre.gemspec +++ b/arbre.gemspec @@ -11,6 +11,7 @@ s.homepage = "" s.summary = %q{An Object Oriented DOM Tree in Ruby} s.description = %q{An Object Oriented DOM Tree in Ruby} + s.license = "MIT" s.files = `g...
Add missing license info to gemspec
diff --git a/radius-rails.gemspec b/radius-rails.gemspec index abc1234..def5678 100644 --- a/radius-rails.gemspec +++ b/radius-rails.gemspec @@ -19,7 +19,7 @@ spec.require_paths = ["lib"] #spec.add_dependency "font-awesome-rails" - spec.add_dependency "railties", ">= 3.2", "~> 6.0" + spec.add_dependency "railt...
Use <= contraint on railties instead of pessimistic version lock This was causing us some issues when attempting to upgrade some gems in iris. Using <= over ~> resolves this issue
diff --git a/logglier.gemspec b/logglier.gemspec index abc1234..def5678 100644 --- a/logglier.gemspec +++ b/logglier.gemspec @@ -7,6 +7,8 @@ s.date = Time.now s.summary = 'Loggly "plugin" for Logger' s.description = 'Logger => Loggly' + + s.license = "http://opensource.org/licenses...
Resolve gem build warnings, add a license.
diff --git a/redis_cache_mailer_delivery.gemspec b/redis_cache_mailer_delivery.gemspec index abc1234..def5678 100644 --- a/redis_cache_mailer_delivery.gemspec +++ b/redis_cache_mailer_delivery.gemspec @@ -21,4 +21,5 @@ gem.add_development_dependency(%q<guard-rspectacle>) gem.add_development_dependency(%q<growl>) ...
Add rake into bundler env
diff --git a/spec/authentication_spec.rb b/spec/authentication_spec.rb index abc1234..def5678 100644 --- a/spec/authentication_spec.rb +++ b/spec/authentication_spec.rb @@ -3,7 +3,7 @@ class DummyClient - def secret + def api_secret_key "uA96CFtJa138E2T5GhKfngml" end
Fix secret key call method.
diff --git a/spec/mixin_writable_spec.rb b/spec/mixin_writable_spec.rb index abc1234..def5678 100644 --- a/spec/mixin_writable_spec.rb +++ b/spec/mixin_writable_spec.rb @@ -2,21 +2,20 @@ require 'rdf/spec/writable' describe RDF::Writable do - before :each do + subject {RDF::Repository.new} + + # @see lib/rdf/spec...
Use RDF::Writable behavior, instead of RDF_Writable include.
diff --git a/app/helpers/owners_helper.rb b/app/helpers/owners_helper.rb index abc1234..def5678 100644 --- a/app/helpers/owners_helper.rb +++ b/app/helpers/owners_helper.rb @@ -8,10 +8,23 @@ options[:class] += " has-tooltip" # Trying container: 'body' as a workaround for a bug where gravatars move when ...
Make tooltip for owners show the full name as well if it's available
diff --git a/app/jobs/slack_pinger_job.rb b/app/jobs/slack_pinger_job.rb index abc1234..def5678 100644 --- a/app/jobs/slack_pinger_job.rb +++ b/app/jobs/slack_pinger_job.rb @@ -8,7 +8,7 @@ actual_location = booking_location.name_for(booking_request.location_id) hook = WebHook.new(hook_uri) - hook.call(pa...
Include number of chosen slots for slack ping Pings slack with the location and number of slots the customer chose.
diff --git a/app/models/procedure_path.rb b/app/models/procedure_path.rb index abc1234..def5678 100644 --- a/app/models/procedure_path.rb +++ b/app/models/procedure_path.rb @@ -23,7 +23,7 @@ end def publish!(new_procedure) - if procedure&.publiee? + if procedure&.publiee? && procedure != new_procedure ...
Archive only when path changes owner
diff --git a/app/models/event.rb b/app/models/event.rb index abc1234..def5678 100644 --- a/app/models/event.rb +++ b/app/models/event.rb @@ -1,4 +1,6 @@ class Event < ActiveRecord::Base has_many :participations, class_name: EventParticipation.name, dependent: :destroy has_many :users, through: :participations + +...
Add validate presence to Event model
diff --git a/spec/models/renalware/feeds/files/practices/import_job_spec.rb b/spec/models/renalware/feeds/files/practices/import_job_spec.rb index abc1234..def5678 100644 --- a/spec/models/renalware/feeds/files/practices/import_job_spec.rb +++ b/spec/models/renalware/feeds/files/practices/import_job_spec.rb @@ -8,7 +8,...
Fix practice import spec now we import more types of practice
diff --git a/spec/lib/gitlab/ci/status/build/common_spec.rb b/spec/lib/gitlab/ci/status/build/common_spec.rb index abc1234..def5678 100644 --- a/spec/lib/gitlab/ci/status/build/common_spec.rb +++ b/spec/lib/gitlab/ci/status/build/common_spec.rb @@ -0,0 +1,37 @@+require 'spec_helper' + +describe Gitlab::Ci::Status::Buil...
Add tests for common build detailed status helpers
diff --git a/lib/bumper/version.rb b/lib/bumper/version.rb index abc1234..def5678 100644 --- a/lib/bumper/version.rb +++ b/lib/bumper/version.rb @@ -1,7 +1,7 @@ module Bumper class Version - ['major', 'minor', 'revision', 'build'].each do |part| + [:major, :minor, :revision, :build].each do |part| ...
Use symbol keys instead of string keys
diff --git a/lib/cap-git-deploy.rb b/lib/cap-git-deploy.rb index abc1234..def5678 100644 --- a/lib/cap-git-deploy.rb +++ b/lib/cap-git-deploy.rb @@ -16,9 +16,9 @@ # The name of the current logged user def self.current_user login = Etc.getlogin - user = Etc.getpwnam(login) + user = ...
Fix full username (used to inspect a struct instead)
diff --git a/lib/deployml/shell.rb b/lib/deployml/shell.rb index abc1234..def5678 100644 --- a/lib/deployml/shell.rb +++ b/lib/deployml/shell.rb @@ -4,8 +4,8 @@ # module Shell - def initialize(&block) - block.call(self) if block + def initialize + yield self if block_given? end #
Use yield instead of block.call.
diff --git a/black_list.rb b/black_list.rb index abc1234..def5678 100644 --- a/black_list.rb +++ b/black_list.rb @@ -5,12 +5,16 @@ BlackList = [ ["coq-bdds.8.5.0", "Error: Could not find the .cmi file for interface parser.mli."], ["coq-bdds.8.7.0", "Error: Could not find the .cmi file for interface parser.mli."],...
Add new packages to the black-list
diff --git a/lib/em-dir-watcher.rb b/lib/em-dir-watcher.rb index abc1234..def5678 100644 --- a/lib/em-dir-watcher.rb +++ b/lib/em-dir-watcher.rb @@ -10,7 +10,7 @@ end end -require "em-dir-watcher/platform/#{EMDirWatcher::PLATFORM.upcase}" +require "em-dir-watcher/platform/#{EMDirWatcher::PLATFORM.downcase}" ...
Fix a bug when running on case-insensitive file systems
diff --git a/lib/gds_api/maslow.rb b/lib/gds_api/maslow.rb index abc1234..def5678 100644 --- a/lib/gds_api/maslow.rb +++ b/lib/gds_api/maslow.rb @@ -1,5 +1,5 @@ class GdsApi::Maslow < GdsApi::Base - def need_page_url(need_id) - "#{endpoint}/needs/#{need_id}" + def need_page_url(content_id) + "#{endpoint}/needs/...
Change need_id to content_id in need_page_url This is to match changes in Maslow. Using need ids will continue to work, and this isn't required for using content ids, but may be less confusing going forward.
diff --git a/lib/juici/callback.rb b/lib/juici/callback.rb index abc1234..def5678 100644 --- a/lib/juici/callback.rb +++ b/lib/juici/callback.rb @@ -5,8 +5,9 @@ attr_reader :url attr_accessor :payload - def initialize(url) + def initialize(url, pl=nil) @url = url + @payload = pl if pl ...
Allow payload to be specified at init time
diff --git a/lib/kaminari/hooks.rb b/lib/kaminari/hooks.rb index abc1234..def5678 100644 --- a/lib/kaminari/hooks.rb +++ b/lib/kaminari/hooks.rb @@ -27,14 +27,6 @@ ::MongoMapper::Document.send :include, Kaminari::MongoMapperExtension::Document ::Plucky::Query.send :include, Kaminari::PluckyCriteriaMeth...
Revert "Rails 3.0.x fails to load helpers in Engines (?)" This reverts commit 00c912d12bc49c0e7b3d748854e0bdce94ff3470. reason: reverting back from app/helpers to ActionView::Base freedom-patch. Because mounted engines on the app doesn't search the main_app's helpers, then throws "undefined method `paginate'" in the ...
diff --git a/lib/orchid/routing.rb b/lib/orchid/routing.rb index abc1234..def5678 100644 --- a/lib/orchid/routing.rb +++ b/lib/orchid/routing.rb @@ -2,10 +2,35 @@ module Routing module_function - def draw(reserved_names: []) + def draw(reserved_names: [], parent_scope: "") # Retrieve list of main ...
Add ability to scope routes from main app
diff --git a/lib/redmine_charts.rb b/lib/redmine_charts.rb index abc1234..def5678 100644 --- a/lib/redmine_charts.rb +++ b/lib/redmine_charts.rb @@ -11,7 +11,7 @@ module RedmineCharts def self.has_sub_issues_functionality_active - ((Redmine::VERSION.to_a <=> [0,9,5]) >= 0) or (Redmine::VERSION.to_a == [0,9,4,'d...
Fix subtasks problem in Redmine 0.9.x
diff --git a/lib/whenever/setup.rb b/lib/whenever/setup.rb index abc1234..def5678 100644 --- a/lib/whenever/setup.rb +++ b/lib/whenever/setup.rb @@ -14,6 +14,8 @@ "bin/rails runner" when Whenever.script_rails? "script/rails runner" + when Whenever.bundler? + "bundle exec rails runner" else "scri...
Add condition path to use bundle exec as runner command
diff --git a/pronto-rubocop.gemspec b/pronto-rubocop.gemspec index abc1234..def5678 100644 --- a/pronto-rubocop.gemspec +++ b/pronto-rubocop.gemspec @@ -1,7 +1,8 @@ # -*- encoding: utf-8 -*- + $LOAD_PATH.push File.expand_path('../lib', __FILE__) - require 'pronto/rubocop/version' +require 'English' Gem::Specificat...
Reduce size of the gem by only including the necessary files via gemspec
diff --git a/slack-mathbot/commands/calculate.rb b/slack-mathbot/commands/calculate.rb index abc1234..def5678 100644 --- a/slack-mathbot/commands/calculate.rb +++ b/slack-mathbot/commands/calculate.rb @@ -10,10 +10,10 @@ if result && result.length > 0 send_message client, data.channel, result ...
Revert "Remove giphy query from end of error strings" This reverts commit 0f3bde20c569e4c7bfd0030b20d875592c817dd0.
diff --git a/recipes/registrator.rb b/recipes/registrator.rb index abc1234..def5678 100644 --- a/recipes/registrator.rb +++ b/recipes/registrator.rb @@ -5,11 +5,11 @@ command = node['docker-simple']['registrator']['command'] compose = { - 'registrator': { - 'image': "gliderlabs/registrator:#{tag}", - 'command...
Change quotes to prevent symbolizing
diff --git a/Casks/meld.rb b/Casks/meld.rb index abc1234..def5678 100644 --- a/Casks/meld.rb +++ b/Casks/meld.rb @@ -0,0 +1,12 @@+cask 'meld' do + version '3.16.0 (r1)' + sha256 '324e096e0253e8ad4237f64a90cdda200fe427db8cf7ebc78143fc98e2d33ebc' + + # github.com/yousseb/meld was verified as official when first introd...
Add Meld for OSX v3.16.0 (r1)
diff --git a/Casks/xact.rb b/Casks/xact.rb index abc1234..def5678 100644 --- a/Casks/xact.rb +++ b/Casks/xact.rb @@ -1,7 +1,7 @@ class Xact < Cask - url 'http://xact.scottcbrown.org/xACT2.25.zip' + url 'http://xact.scottcbrown.org/xACT2.27.zip' homepage 'http://xact.scottcbrown.org' - version '2.25' - sha256 '16...
Update xACT 2.25 to 2.27
diff --git a/test/test_helper_methods.rb b/test/test_helper_methods.rb index abc1234..def5678 100644 --- a/test/test_helper_methods.rb +++ b/test/test_helper_methods.rb @@ -19,7 +19,7 @@ def test_filelist rim = Rim.instance - fl = rim.filelist(/rakefile/i, 'lib') + fl = rim.filelist(/^rakefile/i, 'lib') ...
Bugfix: Make tests work in unclean directory tree.
diff --git a/spec/lib/text_filter_plugin_spec.rb b/spec/lib/text_filter_plugin_spec.rb index abc1234..def5678 100644 --- a/spec/lib/text_filter_plugin_spec.rb +++ b/spec/lib/text_filter_plugin_spec.rb @@ -1,6 +1,32 @@ # frozen_string_literal: true require "rails_helper" + +RSpec.describe TextFilterPlugin do + descr...
Improve specs for list of available filters
diff --git a/spec/ruby/library/etc/group_spec.rb b/spec/ruby/library/etc/group_spec.rb index abc1234..def5678 100644 --- a/spec/ruby/library/etc/group_spec.rb +++ b/spec/ruby/library/etc/group_spec.rb @@ -4,4 +4,14 @@ describe "Etc.group" do it_behaves_like(:etc_on_windows, :group) + + it "raises a RuntimeError f...
Add spec for parallel group iteration Spec is shamelessly taken from #1149 by @cwgem. This way it's ensured it is run and don't have to wait for a Rubyspec pull request.
diff --git a/bin/production_cache_test.rb b/bin/production_cache_test.rb index abc1234..def5678 100644 --- a/bin/production_cache_test.rb +++ b/bin/production_cache_test.rb @@ -36,6 +36,10 @@ puts page response = conn.get(page) + unless response.status == 200 + raise "Status code was #{response.status}" + e...
Check production pages are 200 OK
diff --git a/test/integration_helper.rb b/test/integration_helper.rb index abc1234..def5678 100644 --- a/test/integration_helper.rb +++ b/test/integration_helper.rb @@ -40,10 +40,10 @@ end def setup - VCR.insert_cassette(api_name) + ENV['LIVE'] ? VCR.turn_off! : VCR.insert_cassette(api_name) end de...
Add switch to run integration against live data
diff --git a/spec/search_builder/sufia/single_admin_set_search_builder_spec.rb b/spec/search_builder/sufia/single_admin_set_search_builder_spec.rb index abc1234..def5678 100644 --- a/spec/search_builder/sufia/single_admin_set_search_builder_spec.rb +++ b/spec/search_builder/sufia/single_admin_set_search_builder_spec.rb...
Adjust test for changes in curation_concerns
diff --git a/spec/rails/unit/collection_spec.rb b/spec/rails/unit/collection_spec.rb index abc1234..def5678 100644 --- a/spec/rails/unit/collection_spec.rb +++ b/spec/rails/unit/collection_spec.rb @@ -9,9 +9,3 @@ c.db.name.should == 'mingo_rails_test' end end - -describe "Mingo.collection=" do - it "should rai...
Remove rails test that's already covered in main suite.
diff --git a/test_site/sequel_setup.rb b/test_site/sequel_setup.rb index abc1234..def5678 100644 --- a/test_site/sequel_setup.rb +++ b/test_site/sequel_setup.rb @@ -2,8 +2,10 @@ require 'sequel' Sequel.single_threaded = true SequelDB = Sequel.sqlite("db/#{SE_TEST_FRAMEWORK}.sequel.sqlite3", :single_threaded=>true, :f...
Use the Sequel prepared statement plugins in the test site
diff --git a/rom-yaml.gemspec b/rom-yaml.gemspec index abc1234..def5678 100644 --- a/rom-yaml.gemspec +++ b/rom-yaml.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ['lib'] - spec.add_runtime_dependency 'rom-core', '~> 4.0.0.beta' + spec.add_runti...
Update rom version to rom-4
diff --git a/config/initializers/rollbar.rb b/config/initializers/rollbar.rb index abc1234..def5678 100644 --- a/config/initializers/rollbar.rb +++ b/config/initializers/rollbar.rb @@ -6,7 +6,7 @@ config.access_token = ENV['ROLLBAR_ACCESS_TOKEN'] # Here we'll disable in 'test': - if Rails.env.test? + if ['deve...
Disable Rollbar for dev envs
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,2 +1,9 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) +require 'rspec' +require 'fakefs/safe' +require 'fakefs/spec_helpers' require 'failspell' + +RSpec.configu...
Create a flag to include fakefs for specs
diff --git a/cookbooks/duckduckhack-vm/recipes/default.rb b/cookbooks/duckduckhack-vm/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/duckduckhack-vm/recipes/default.rb +++ b/cookbooks/duckduckhack-vm/recipes/default.rb @@ -2,6 +2,10 @@ # Cookbook Name:: duckduckhack-vm # Recipe:: default # + +# Enab...
Enable multiverse because many users will want to install packages from it
diff --git a/db/migrate/20180712141700_fix_gss_codes_for_some_councils_in_existing_support_schemes.rb b/db/migrate/20180712141700_fix_gss_codes_for_some_councils_in_existing_support_schemes.rb index abc1234..def5678 100644 --- a/db/migrate/20180712141700_fix_gss_codes_for_some_councils_in_existing_support_schemes.rb ++...
Fix GSS codes for two councils in Scotland with recent border changes
diff --git a/delocalize.gemspec b/delocalize.gemspec index abc1234..def5678 100644 --- a/delocalize.gemspec +++ b/delocalize.gemspec @@ -13,7 +13,7 @@ s.require_paths = ['lib'] s.test_files = Dir['test/**/*'] - s.add_dependency 'rails', '>= 3.0' + s.add_dependency 'rails', '>= 2' s.add_development_dependenc...
Allow Rails 2 in gemspec
diff --git a/lib/convection/model/template/resource_property/aws_cloudfront_defaultcachebehavior.rb b/lib/convection/model/template/resource_property/aws_cloudfront_defaultcachebehavior.rb index abc1234..def5678 100644 --- a/lib/convection/model/template/resource_property/aws_cloudfront_defaultcachebehavior.rb +++ b/li...
Add max ttl option for cloudfront
diff --git a/Watt.podspec b/Watt.podspec index abc1234..def5678 100644 --- a/Watt.podspec +++ b/Watt.podspec @@ -7,9 +7,9 @@ s.source = { :git => 'https://github.com/benoit-pereira-da-silva/Watt.git'} s.license = { :type => "LGPL", :file => "LICENSE" } - s.platform = :ios, '5.0' + s.ios.deployment_tar...
Support of Mac OS X 10.7
diff --git a/common_spree_dependencies.rb b/common_spree_dependencies.rb index abc1234..def5678 100644 --- a/common_spree_dependencies.rb +++ b/common_spree_dependencies.rb @@ -27,6 +27,7 @@ gem 'launchy' gem 'pry' gem 'webmock', '1.8.11' + gem 'email_spec', '1.4.0' end gemspec
Make frontend tests happy again by adding email_spec as a dependency
diff --git a/ducksauce.gemspec b/ducksauce.gemspec index abc1234..def5678 100644 --- a/ducksauce.gemspec +++ b/ducksauce.gemspec @@ -1,4 +1,5 @@ # -*- encoding: utf-8 -*- + lib = File.expand_path('../lib', __FILE__) $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) require 'ducksauce/version' @@ -9,7 +10,7 @@ ...
Add Ruby 2.1.0 requirement to Gemspec
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -23,5 +23,5 @@ spec.add_development_dependency "gc_ruboconfig", "~> 2.23.0" spec.add_development_dependency "rspec", "~> 3.1" spec.add_development_dependency "rspec_junit_formatter", "...
Update rubocop requirement from ~> 1.5.2 to ~> 1.6.0 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](htt...
diff --git a/editorium.gemspec b/editorium.gemspec index abc1234..def5678 100644 --- a/editorium.gemspec +++ b/editorium.gemspec @@ -8,8 +8,8 @@ spec.version = Editorium::VERSION spec.authors = ["Gabor Babicz"] spec.email = ["gabor.babicz@gmail.com"] - spec.summary = %q{TODO: Write a ...
Remove TODOs so that rake will work correctly
diff --git a/lib/shell_commands/shell_command.rb b/lib/shell_commands/shell_command.rb index abc1234..def5678 100644 --- a/lib/shell_commands/shell_command.rb +++ b/lib/shell_commands/shell_command.rb @@ -20,9 +20,9 @@ end @@last_result = { - :command => command, - :result => result, - :success => $?.suc...
Use strings as keys in the results hash
diff --git a/lib/tasks/auto_annotate_models.rake b/lib/tasks/auto_annotate_models.rake index abc1234..def5678 100644 --- a/lib/tasks/auto_annotate_models.rake +++ b/lib/tasks/auto_annotate_models.rake @@ -1,6 +1,4 @@-# NOTE: only doing this in development as some production environments (Heroku) -# NOTE: are sensitive ...
Exclude controllers and helpers to be annoted by the annotation gem
diff --git a/spree_s3.gemspec b/spree_s3.gemspec index abc1234..def5678 100644 --- a/spree_s3.gemspec +++ b/spree_s3.gemspec @@ -16,7 +16,7 @@ s.require_path = 'lib' s.requirements << 'none' - s.add_dependency 'spree_core', '~> 1.0.0' + s.add_dependency 'spree_core', '~> 1.0' s.add_dependency 'aws-sdk', '~>...
Change to support Spree 1.x series
diff --git a/clash.gemspec b/clash.gemspec index abc1234..def5678 100644 --- a/clash.gemspec +++ b/clash.gemspec @@ -13,9 +13,8 @@ spec.homepage = "https://github.com/imathis/clash" spec.license = "MIT" - spec.files = `git ls-files -z`.split("\x0") + spec.files = `git ls-files -z`.sp...
Remove test files from gem distribution.
diff --git a/roles/web-db.rb b/roles/web-db.rb index abc1234..def5678 100644 --- a/roles/web-db.rb +++ b/roles/web-db.rb @@ -4,6 +4,6 @@ default_attributes( :web => { :database_host => "katla.bm.openstreetmap.org", - :readonly_database_host => "katla.bm.openstreetmap.org" + :readonly_database_host => "ram...
Move readonly database load to ramoth
diff --git a/rollbar.gemspec b/rollbar.gemspec index abc1234..def5678 100644 --- a/rollbar.gemspec +++ b/rollbar.gemspec @@ -19,18 +19,5 @@ gem.require_paths = ["lib"] gem.version = Rollbar::VERSION - gem.add_development_dependency 'oj', '~> 2.12.14' unless is_jruby - - gem.add_development_dependency 'si...
Remove dev dependencies from gemspec We use the gemfiles in gemfiles/ for the tests.
diff --git a/skymorph.gemspec b/skymorph.gemspec index abc1234..def5678 100644 --- a/skymorph.gemspec +++ b/skymorph.gemspec @@ -18,8 +18,9 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spec.add_dependency "nokogiri" + spec.add_development_dependency "bund...
Move nokogiri to runtime dependencies
diff --git a/chef-api.gemspec b/chef-api.gemspec index abc1234..def5678 100644 --- a/chef-api.gemspec +++ b/chef-api.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |spec| spec.name = 'chef-api' spec.version = ChefAPI::VERSION - spec.authors = ['Seth Vargo'] - spec.email = ['sethv...
Add myself to the author list now Thanks for the handoff Seth Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/enumerable-statistics.gemspec b/enumerable-statistics.gemspec index abc1234..def5678 100644 --- a/enumerable-statistics.gemspec +++ b/enumerable-statistics.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |spec| spec.name = "enumerable-statistics" - spec.version = '1.1.0' + spec.vers...
Add .dev suffix in version number
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -1,6 +1,6 @@ # Include hook code here -require "lib/emailthing" +require File.dirname(__FILE__) + "lib/emailthing" require "net/http" require "action_mailer"
Make plugin use full path
diff --git a/spec/automation/unit/method_validation/vm_migrate_task_complete_spec.rb b/spec/automation/unit/method_validation/vm_migrate_task_complete_spec.rb index abc1234..def5678 100644 --- a/spec/automation/unit/method_validation/vm_migrate_task_complete_spec.rb +++ b/spec/automation/unit/method_validation/vm_migra...
Add test case for automate method vmmigratetask_complete. https://bugzilla.redhat.com/show_bug.cgi?id=1284110
diff --git a/griddler-mandrill.gemspec b/griddler-mandrill.gemspec index abc1234..def5678 100644 --- a/griddler-mandrill.gemspec +++ b/griddler-mandrill.gemspec @@ -9,7 +9,7 @@ spec.authors = ['Stafford Brunk'] spec.email = ['stafford.brunk@gmail.com'] spec.summary = %q{Mandrill adapter for ...
Fix typo in gem description
diff --git a/spec/commands/deploy_spec.rb b/spec/commands/deploy_spec.rb index abc1234..def5678 100644 --- a/spec/commands/deploy_spec.rb +++ b/spec/commands/deploy_spec.rb @@ -15,7 +15,7 @@ end it "should honor releases_path" do - stdout.should include "#{Dir.pwd}/deploy/releases" + stdout.should ...
Update the deploy spec which got outta sync.
diff --git a/spec/lhm_integration_spec.rb b/spec/lhm_integration_spec.rb index abc1234..def5678 100644 --- a/spec/lhm_integration_spec.rb +++ b/spec/lhm_integration_spec.rb @@ -16,7 +16,7 @@ context 'creating column', index: true do let(:direction) { :up } - it 'adds the column in the DB table' do + ...
Mark lhm integration test as pending. We'll be done in another branch
diff --git a/Casks/duplicate-annihilator.rb b/Casks/duplicate-annihilator.rb index abc1234..def5678 100644 --- a/Casks/duplicate-annihilator.rb +++ b/Casks/duplicate-annihilator.rb @@ -1,8 +1,8 @@ class DuplicateAnnihilator < Cask url 'http://brattoo.com/propaganda/downloadDa.php' homepage 'http://brattoo.com/pro...
Switch to latest version, no_checksum
diff --git a/Casks/soundcloud-downloader.rb b/Casks/soundcloud-downloader.rb index abc1234..def5678 100644 --- a/Casks/soundcloud-downloader.rb +++ b/Casks/soundcloud-downloader.rb @@ -1,8 +1,8 @@ cask :v1 => 'soundcloud-downloader' do - version '2.6.2' - sha256 'a68b69c3c1e523a1f93f8f9d774f8fa071e33cd0bbebdaaf797210...
Update SoundCloud Downloader to 2.6.4
diff --git a/examples/eventmachine_adapter/tls/tls_without_peer_verification.rb b/examples/eventmachine_adapter/tls/tls_without_peer_verification.rb index abc1234..def5678 100644 --- a/examples/eventmachine_adapter/tls/tls_without_peer_verification.rb +++ b/examples/eventmachine_adapter/tls/tls_without_peer_verificatio...
Correct vhost to not use leading slash
diff --git a/vendor/plugins/model_stubbing/lib/model_stubbing/extensions.rb b/vendor/plugins/model_stubbing/lib/model_stubbing/extensions.rb index abc1234..def5678 100644 --- a/vendor/plugins/model_stubbing/lib/model_stubbing/extensions.rb +++ b/vendor/plugins/model_stubbing/lib/model_stubbing/extensions.rb @@ -48,6 +4...
Update to history's fork of model_stubbing to make compat with Edge Rails.
diff --git a/config/common_application.rb b/config/common_application.rb index abc1234..def5678 100644 --- a/config/common_application.rb +++ b/config/common_application.rb @@ -8,6 +8,7 @@ set :server, [:thin, :mongrel, :webrick] set :host, '0.0.0.0' set :port, 3000 +set :development, false # Default controllers ...
Make `development' context entry exist in all common application configurations
diff --git a/lib/cc/engine/source_file.rb b/lib/cc/engine/source_file.rb index abc1234..def5678 100644 --- a/lib/cc/engine/source_file.rb +++ b/lib/cc/engine/source_file.rb @@ -32,7 +32,7 @@ end def rubocop_team - RuboCop::Cop::Team.new(RuboCop::Cop::Cop.all, config_store) + RuboCop::Cop::T...
Replace Cop.all with Cop.registry to follow rubocop refactoring
diff --git a/lib/cellular/backends/log.rb b/lib/cellular/backends/log.rb index abc1234..def5678 100644 --- a/lib/cellular/backends/log.rb +++ b/lib/cellular/backends/log.rb @@ -2,7 +2,7 @@ module Backends class Log def self.deliver(options = {}, savon_options = {}) - STDOUT.puts options[:message] +...
Use $stdout instead of STDOUT Fixes #8
diff --git a/lib/email_center_api/base.rb b/lib/email_center_api/base.rb index abc1234..def5678 100644 --- a/lib/email_center_api/base.rb +++ b/lib/email_center_api/base.rb @@ -2,6 +2,10 @@ class Base include HTTParty default_timeout 10 + + def to_i + id + end def self.get(*args, &block) ...
Make the objects respond to_i
diff --git a/lib/ffi-glib/list_methods.rb b/lib/ffi-glib/list_methods.rb index abc1234..def5678 100644 --- a/lib/ffi-glib/list_methods.rb +++ b/lib/ffi-glib/list_methods.rb @@ -11,7 +11,7 @@ replace_method base, :next, :tail replace_method base, :data, :head - base.singleton_class.send :remove_metho...
Use 1.8.7-compatible way of getting the singleton class
diff --git a/lib/kafka/pending_message.rb b/lib/kafka/pending_message.rb index abc1234..def5678 100644 --- a/lib/kafka/pending_message.rb +++ b/lib/kafka/pending_message.rb @@ -11,5 +11,15 @@ @create_time = create_time @bytesize = key.to_s.bytesize + value.to_s.bytesize end + + def ==(other) + ...
Support equality checks for Kafka::PendingMessage
diff --git a/test/features/support/pages/catalinker/catalinker_client.rb b/test/features/support/pages/catalinker/catalinker_client.rb index abc1234..def5678 100644 --- a/test/features/support/pages/catalinker/catalinker_client.rb +++ b/test/features/support/pages/catalinker/catalinker_client.rb @@ -3,6 +3,10 @@ requir...
Make test pass on non-material-design ui
diff --git a/lib/tasks/elasticsearch.rake b/lib/tasks/elasticsearch.rake index abc1234..def5678 100644 --- a/lib/tasks/elasticsearch.rake +++ b/lib/tasks/elasticsearch.rake @@ -8,4 +8,22 @@ Rubygem.__elasticsearch__.create_index! force: true Rubygem.__elasticsearch__.refresh_index! end + + task :import_ali...
Add rake task to import and create alias
diff --git a/lib/tasks/rglossa_tasks.rake b/lib/tasks/rglossa_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/rglossa_tasks.rake +++ b/lib/tasks/rglossa_tasks.rake @@ -1,4 +1,19 @@-# desc "Explaining what the task does" -# task :rglossa do -# # Task goes here -# end +namespace "rglossa" do + namespace "inst...
Add rake task for copying thor scripts to host app
diff --git a/lib/watch_tower/appscript.rb b/lib/watch_tower/appscript.rb index abc1234..def5678 100644 --- a/lib/watch_tower/appscript.rb +++ b/lib/watch_tower/appscript.rb @@ -1,8 +1,15 @@ # -*- encoding: utf-8 -*- begin + require 'rubygems' require 'appscript' rescue LoadError + require 'rbconfig' + if RbCo...
Revert "Appscript: Remove the useless message it is now included in the Gemspec." This reverts commit 5c6b9c92247a02183404c23a5a79da5638fbd518.
diff --git a/omnibus/files/private-chef-cookbooks/private-chef/recipes/plugin_chef_run.rb b/omnibus/files/private-chef-cookbooks/private-chef/recipes/plugin_chef_run.rb index abc1234..def5678 100644 --- a/omnibus/files/private-chef-cookbooks/private-chef/recipes/plugin_chef_run.rb +++ b/omnibus/files/private-chef-cookb...
Allow plugins to leave cookbook_path unset Some plugins (such as the new chef-aws plugin) do not require additional configuration. Previously, we required such plugins to define empty enable and disable recipes. This commit allow such plugins to leave cookbook_path unset if they don't have cookbooks to run.
diff --git a/Library/Formula/sublercli.rb b/Library/Formula/sublercli.rb index abc1234..def5678 100644 --- a/Library/Formula/sublercli.rb +++ b/Library/Formula/sublercli.rb @@ -0,0 +1,14 @@+require 'formula' + +class Sublercli <Formula + head 'http://subler.googlecode.com/svn/trunk/' + homepage 'http://code.google.co...
Add formula to build SublerCLI from SVN Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/Casks/wimoweh-beta.rb b/Casks/wimoweh-beta.rb index abc1234..def5678 100644 --- a/Casks/wimoweh-beta.rb +++ b/Casks/wimoweh-beta.rb @@ -1,5 +1,5 @@ class WimowehBeta < Cask - url 'http://www.serialangels.co.uk/sa-content/uploads/2013/12/Wimoweh.0.66.BETA.zip' + url 'http://www.serialangels.co.uk/sa-conte...
Fix Wimoweh Beta URL Missed a rogue _ before the file extension, not sure why the dev has it there.
diff --git a/Library/Homebrew/extend/ENV.rb b/Library/Homebrew/extend/ENV.rb index abc1234..def5678 100644 --- a/Library/Homebrew/extend/ENV.rb +++ b/Library/Homebrew/extend/ENV.rb @@ -4,10 +4,7 @@ require 'extend/ENV/super' def superenv? - return false if MacOS::Xcode.without_clt? && MacOS.sdk_path.nil? - return ...
Simplify conditions for superenv activation `MacOS::Xcode.without_clt? && MacOS.sdk_path.nil?` should never be true. In its earliest form, this would raise a bare RuntimeError in an effort to have the bug reported. Later, it was changed to silently disable superenv. But we don't want to do that. If there's a bug, or ...
diff --git a/app/services/testing_ground/tree_sampler.rb b/app/services/testing_ground/tree_sampler.rb index abc1234..def5678 100644 --- a/app/services/testing_ground/tree_sampler.rb +++ b/app/services/testing_ground/tree_sampler.rb @@ -1,8 +1,10 @@ class TestingGround - class TreeSampler + module TreeSampler RE...
Change TreeSampler to be a module
diff --git a/Casks/identify.rb b/Casks/identify.rb index abc1234..def5678 100644 --- a/Casks/identify.rb +++ b/Casks/identify.rb @@ -1,7 +1,7 @@ class Identify < Cask - url 'https://www.macupdate.com/download/33814/iDentifyLite532.zip' + url 'https://www.macupdate.com/download/33814/iDentifyLite545.zip' homepage '...
Update Identify to version 545
diff --git a/lib/patches/translations_for_associations.rb b/lib/patches/translations_for_associations.rb index abc1234..def5678 100644 --- a/lib/patches/translations_for_associations.rb +++ b/lib/patches/translations_for_associations.rb @@ -13,6 +13,7 @@ translation_class = association_class.translation_class ...
Disable deprecated implicit join references
diff --git a/lib/sitemap_generator/adapters/s3_adapter.rb b/lib/sitemap_generator/adapters/s3_adapter.rb index abc1234..def5678 100644 --- a/lib/sitemap_generator/adapters/s3_adapter.rb +++ b/lib/sitemap_generator/adapters/s3_adapter.rb @@ -15,7 +15,11 @@ storage = Fog::Storage.new(credentials) d...
Add :public => true option when creating sitemap.
diff --git a/authy.gemspec b/authy.gemspec index abc1234..def5678 100644 --- a/authy.gemspec +++ b/authy.gemspec @@ -20,7 +20,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] - s.add_dependency('httpclient', '>= 2.3.4') + s.add_dependency('httpcli...
Update the dependency of HttpClient to version 2.5.3.3
diff --git a/examples/association_loader.rb b/examples/association_loader.rb index abc1234..def5678 100644 --- a/examples/association_loader.rb +++ b/examples/association_loader.rb @@ -36,7 +36,7 @@ end def preload_association(records) - ::ActiveRecord::Associations::Preloader.new.preload(records, @associatio...
Fix AssociationLoader Rails 7 Deprecation Warning Currently running this example code with rails 7 yields the following warning: ``` DEPRECATION WARNING: `preload` is deprecated and will be removed in Rails 7.0. Call `Preloader.new(kwargs).call` instead. ``` Updating the preloader code to use kwargs and call s...
diff --git a/BHCDatabase/app/controllers/users_controller.rb b/BHCDatabase/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/BHCDatabase/app/controllers/users_controller.rb +++ b/BHCDatabase/app/controllers/users_controller.rb @@ -42,11 +42,19 @@ User.where(:privilege => false) end - col...
Add links to each volunteer in volunteer table.
diff --git a/db/migrate/20200616162646_move_all_calculators_outside_the_spree_namespace.rb b/db/migrate/20200616162646_move_all_calculators_outside_the_spree_namespace.rb index abc1234..def5678 100644 --- a/db/migrate/20200616162646_move_all_calculators_outside_the_spree_namespace.rb +++ b/db/migrate/20200616162646_mov...
Make migration a bit easier to read
diff --git a/redis-rack-cache.gemspec b/redis-rack-cache.gemspec index abc1234..def5678 100644 --- a/redis-rack-cache.gemspec +++ b/redis-rack-cache.gemspec @@ -20,7 +20,7 @@ s.add_dependency 'rack-cache', '>= 1.6', '< 2' s.add_development_dependency 'rake', '~> 10' - s.add_development_dependency 'bundler'...
Update bundler dependency to be more permissive
diff --git a/fastlane-plugin-trainer/lib/fastlane/plugin/trainer/actions/trainer_action.rb b/fastlane-plugin-trainer/lib/fastlane/plugin/trainer/actions/trainer_action.rb index abc1234..def5678 100644 --- a/fastlane-plugin-trainer/lib/fastlane/plugin/trainer/actions/trainer_action.rb +++ b/fastlane-plugin-trainer/lib/f...
Switch from user_error! to test_failure!
diff --git a/lib/godmin/application.rb b/lib/godmin/application.rb index abc1234..def5678 100644 --- a/lib/godmin/application.rb +++ b/lib/godmin/application.rb @@ -16,7 +16,7 @@ helper_method :authentication_enabled? helper_method :authorization_enabled? - before_action :append_view_paths + be...
Prepend view paths to make our override the Rails default
diff --git a/test/unit/counter_cache_test.rb b/test/unit/counter_cache_test.rb index abc1234..def5678 100644 --- a/test/unit/counter_cache_test.rb +++ b/test/unit/counter_cache_test.rb @@ -11,9 +11,13 @@ cc.increment :foo, :by => 5 assert_equal 6, cc[:foo] + # legacy style + cc.increment :foo, 2 + ...
Add test to cover legacy style of >1 incrementation
diff --git a/lib/niles/helpers/html.rb b/lib/niles/helpers/html.rb index abc1234..def5678 100644 --- a/lib/niles/helpers/html.rb +++ b/lib/niles/helpers/html.rb @@ -25,12 +25,16 @@ html_tag(:a, options.merge(href: url_for(target))) { name } end - def url_for(what) - case what - whe...
Make url_for helper object aware
diff --git a/lib/pah/partials/_gems.rb b/lib/pah/partials/_gems.rb index abc1234..def5678 100644 --- a/lib/pah/partials/_gems.rb +++ b/lib/pah/partials/_gems.rb @@ -3,13 +3,17 @@ in_root do gsub_file 'Gemfile', /RAILS_VERSION/, ::Pah::RAILS_VERSION - # Since the gemset is likely empty, manually install bundler so...
Install bundler only when needed in order to speed up the build
diff --git a/lib/phonenumber-client.rb b/lib/phonenumber-client.rb index abc1234..def5678 100644 --- a/lib/phonenumber-client.rb +++ b/lib/phonenumber-client.rb @@ -0,0 +1,11 @@+require 'httparty' + +module PhoneNumberClient + include HTTParty + + base_uri 'http://phonenumber.herokuapp.com' + + def self.phone_number...
Create PhoneNumberClient class with phone_number method.
diff --git a/lib/rubiks/nodes/level.rb b/lib/rubiks/nodes/level.rb index abc1234..def5678 100644 --- a/lib/rubiks/nodes/level.rb +++ b/lib/rubiks/nodes/level.rb @@ -1,5 +1,4 @@ require 'rubiks/nodes/annotated_node' -require 'rubiks/nodes/hierarchy' module ::Rubiks
Remove unnecessary require in Level
diff --git a/lib/schnitzelpress/app.rb b/lib/schnitzelpress/app.rb index abc1234..def5678 100644 --- a/lib/schnitzelpress/app.rb +++ b/lib/schnitzelpress/app.rb @@ -2,8 +2,7 @@ class App < Sinatra::Base set :views, Schnitzelpress.root.join('lib').join('views') - use Rack::Session::Cookie - set :session_s...
Set session cookie secret (for real this time)