diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/aoede/attributes/base.rb b/lib/aoede/attributes/base.rb index abc1234..def5678 100644 --- a/lib/aoede/attributes/base.rb +++ b/lib/aoede/attributes/base.rb @@ -5,7 +5,7 @@ module Base extend ActiveSupport::Concern - ATTRIBUTES = [:album, :artist, :comment, :genre, :title, :track, :yea...
Define default attribute methods on Attributes::Base
diff --git a/lib/gir_ffi/in_out_pointer.rb b/lib/gir_ffi/in_out_pointer.rb index abc1234..def5678 100644 --- a/lib/gir_ffi/in_out_pointer.rb +++ b/lib/gir_ffi/in_out_pointer.rb @@ -37,10 +37,6 @@ end end - def clear - put_bytes 0, "\x00" * value_type_size, 0, value_type_size - end - def sel...
Remove unused methods from InOutPointer
diff --git a/lib/mspec/runner/exception.rb b/lib/mspec/runner/exception.rb index abc1234..def5678 100644 --- a/lib/mspec/runner/exception.rb +++ b/lib/mspec/runner/exception.rb @@ -1,3 +1,6 @@+# Initialize $MSPEC_DEBUG +$MSPEC_DEBUG = false unless defined?($MSPEC_DEBUG) + class ExceptionState attr_reader :descripti...
Make sure $MSPEC_DEBUG is initialized
diff --git a/lib/perpetuity/validations.rb b/lib/perpetuity/validations.rb index abc1234..def5678 100644 --- a/lib/perpetuity/validations.rb +++ b/lib/perpetuity/validations.rb @@ -36,21 +36,31 @@ class Length def initialize attribute, options @attribute = attribute - @options = options - - ...
Use dynamic method dispatch for length validation
diff --git a/lib/sequelizer/yaml_config.rb b/lib/sequelizer/yaml_config.rb index abc1234..def5678 100644 --- a/lib/sequelizer/yaml_config.rb +++ b/lib/sequelizer/yaml_config.rb @@ -23,7 +23,7 @@ # or +nil+ if config/database.yml doesn't exist def options return {} unless config_file_path.exist? - c...
Check for symbols in YamlConfig as well
diff --git a/mailchimp.gemspec b/mailchimp.gemspec index abc1234..def5678 100644 --- a/mailchimp.gemspec +++ b/mailchimp.gemspec @@ -26,4 +26,5 @@ s.add_development_dependency('mocha') s.add_development_dependency('cover_me') s.add_development_dependency('fakeweb') + s.add_development_dependency('geminabox') ...
Add geminabox as a dev dependency
diff --git a/lib/gitlab/satellite/files/file_action.rb b/lib/gitlab/satellite/files/file_action.rb index abc1234..def5678 100644 --- a/lib/gitlab/satellite/files/file_action.rb +++ b/lib/gitlab/satellite/files/file_action.rb @@ -4,7 +4,7 @@ attr_accessor :file_path, :ref def initialize(user, project, ref...
Use same 30 seconds satellite timeout for all actions Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/lib/riddle/0.9.9/configuration/searchd.rb b/lib/riddle/0.9.9/configuration/searchd.rb index abc1234..def5678 100644 --- a/lib/riddle/0.9.9/configuration/searchd.rb +++ b/lib/riddle/0.9.9/configuration/searchd.rb @@ -1,6 +1,8 @@ module Riddle class Configuration class Searchd + NUMBER = 1.class...
Check for numbers in a MRI 2.4 friendly manner.
diff --git a/buildr-ipojo.gemspec b/buildr-ipojo.gemspec index abc1234..def5678 100644 --- a/buildr-ipojo.gemspec +++ b/buildr-ipojo.gemspec @@ -0,0 +1,25 @@+require File.expand_path(File.dirname(__FILE__) + '/lib/buildr/ipojo/version') + +Gem::Specification.new do |spec| + spec.name = 'buildr-ipojo' + spec...
Add in the initial gemspec for the project
diff --git a/lib/dimples/configuration.rb b/lib/dimples/configuration.rb index abc1234..def5678 100644 --- a/lib/dimples/configuration.rb +++ b/lib/dimples/configuration.rb @@ -20,6 +20,7 @@ { output: './public', archives: 'archives', + paginated_posts: 'posts', posts: 'archives/...
Add default paginated post settings
diff --git a/capistrano-fast_deploy.gemspec b/capistrano-fast_deploy.gemspec index abc1234..def5678 100644 --- a/capistrano-fast_deploy.gemspec +++ b/capistrano-fast_deploy.gemspec @@ -8,12 +8,15 @@ gem.version = Capistrano::FastDeploy::VERSION gem.authors = ["Aaron Jensen"] gem.email = ["aa...
Add summary and description and dependency
diff --git a/app/lib/services.rb b/app/lib/services.rb index abc1234..def5678 100644 --- a/app/lib/services.rb +++ b/app/lib/services.rb @@ -19,7 +19,8 @@ def self.email_alert_api @email_alert_api ||= GdsApi::EmailAlertApi.new( - Plek.find("email-alert-api") + Plek.find("email-alert-api"), + bea...
Configure email-alert-api with bearer token Also moves the creation of the client into the `Services` module.
diff --git a/test/run_test.rb b/test/run_test.rb index abc1234..def5678 100644 --- a/test/run_test.rb +++ b/test/run_test.rb @@ -5,7 +5,7 @@ test_dir = File.join(base_dir, 'test') require 'test-unit' -require 'test/unit/notify' +require 'test/unit/notify' unless ENV['DISABLE_TEST_NOTIFY'] require 'idcf/cli/validate...
Add test option to disable notifications
diff --git a/SwiftyUserDefaults.podspec b/SwiftyUserDefaults.podspec index abc1234..def5678 100644 --- a/SwiftyUserDefaults.podspec +++ b/SwiftyUserDefaults.podspec @@ -11,6 +11,7 @@ s.ios.deployment_target = '8.0' s.osx.deployment_target = '10.9' s.tvos.deployment_target = '9.0' + s.watchos.deployment_target ...
Add watchOS support to the podspec
diff --git a/lib/necromancer/converter.rb b/lib/necromancer/converter.rb index abc1234..def5678 100644 --- a/lib/necromancer/converter.rb +++ b/lib/necromancer/converter.rb @@ -28,6 +28,17 @@ end.new end + # Fail with conversion type error + # + # @param [Object] value + # the value that cann...
Add common type conversion error method.
diff --git a/lib/puppet/util/cli_parser.rb b/lib/puppet/util/cli_parser.rb index abc1234..def5678 100644 --- a/lib/puppet/util/cli_parser.rb +++ b/lib/puppet/util/cli_parser.rb @@ -23,7 +23,11 @@ end def parse(parser, input) - result = parser.parse input + begin + result = parser.parse input + resc...
Add better contect for parsing errors
diff --git a/lib/tasks/publishing_api.rake b/lib/tasks/publishing_api.rake index abc1234..def5678 100644 --- a/lib/tasks/publishing_api.rake +++ b/lib/tasks/publishing_api.rake @@ -2,9 +2,6 @@ desc "Send all tags to the publishing-api, skipping any marked as dirty" task :republish_all_tags => :environment do - -...
Send root browse page after other tags. To prevent a race condition when initially deploying this where the /browse page is set to an exact route before the *.josn browse routes are registered.
diff --git a/Transition.podspec b/Transition.podspec index abc1234..def5678 100644 --- a/Transition.podspec +++ b/Transition.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'Transition' - s.version = '1.0.0' + s.version = '1.0.1' s.summary = 'Easy interactive interru...
Bump pod spec version to 1.0.1
diff --git a/Casks/julia.rb b/Casks/julia.rb index abc1234..def5678 100644 --- a/Casks/julia.rb +++ b/Casks/julia.rb @@ -7,6 +7,7 @@ license :mit app "Julia-#{version}.app" + binary "Julia-#{version}.app/Contents/Resources/julia/bin/julia" zap :delete => '~/.julia' end
Add binary stanza to Julia cask
diff --git a/test/good_migrations_test.rb b/test/good_migrations_test.rb index abc1234..def5678 100644 --- a/test/good_migrations_test.rb +++ b/test/good_migrations_test.rb @@ -15,13 +15,13 @@ def test_good_migration_does_not_blow_up stdout, stderr, status = shell("bundle exec rake db:drop db:create db:migrate V...
Use clean Bundle env, status.exitstatus (fix travis) * Process status objects are weird. They'll be integers on success (ie: 0) ,but objects on a failure. Using status.exitstatus means we always get an integer for comparison * Use Bundler.with_clean_env to shell out. Apparently environment variables become a complete...
diff --git a/Stripe.podspec b/Stripe.podspec index abc1234..def5678 100644 --- a/Stripe.podspec +++ b/Stripe.podspec @@ -13,6 +13,6 @@ s.requires_arc = true s.ios.deployment_target = '5.0' - s.dependency 'PaymentKit' , '~> 1.0.4' + s.dependency 'PaymentKit', :git => 'https://gi...
Add Zip Code - UI
diff --git a/lib/shard_handler/handler.rb b/lib/shard_handler/handler.rb index abc1234..def5678 100644 --- a/lib/shard_handler/handler.rb +++ b/lib/shard_handler/handler.rb @@ -4,6 +4,7 @@ # {Handler}. # # @see Model + # @api private class Handler # @param klass [ActiveRecord::Base] model class # ...
Add more documentation for Handler
diff --git a/app/helpers/content_manager/application_helper.rb b/app/helpers/content_manager/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/content_manager/application_helper.rb +++ b/app/helpers/content_manager/application_helper.rb @@ -2,7 +2,6 @@ module ApplicationHelper # a helper to a...
Fix error in Heroku fix Passing ill formatted constant names to Object.const_defined?
diff --git a/app/models/manageiq/providers/ansible_tower/inventory/persister/automation_manager.rb b/app/models/manageiq/providers/ansible_tower/inventory/persister/automation_manager.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/ansible_tower/inventory/persister/automation_manager.rb +++ b/app/m...
Add an InventoryCollection for VMs crosslinks Add an InventoryCollection for VMs crosslinks
diff --git a/app/queries/raw_time_query.rb b/app/queries/raw_time_query.rb index abc1234..def5678 100644 --- a/app/queries/raw_time_query.rb +++ b/app/queries/raw_time_query.rb @@ -11,7 +11,7 @@ INNER JOIN existing_scope ON existing_scope.id = raw_times.id) SELECT - r.id, r.event_group_id, r.para...
Fix RawTimeQuery.with_relations to return all RawTime attributes.
diff --git a/spec/js_bundle_spec.lint.rb b/spec/js_bundle_spec.lint.rb index abc1234..def5678 100644 --- a/spec/js_bundle_spec.lint.rb +++ b/spec/js_bundle_spec.lint.rb @@ -0,0 +1,16 @@+require "open3" + +RSpec.describe "JS bundle sanity" do + it "is up to date" do + current_bundle = File.read("app/assets/javascrip...
Add javascript bundle checking to specs
diff --git a/lib/sprinkle/deployment.rb b/lib/sprinkle/deployment.rb index abc1234..def5678 100644 --- a/lib/sprinkle/deployment.rb +++ b/lib/sprinkle/deployment.rb @@ -17,9 +17,11 @@ @style = Actors.const_get(type.to_s.titleize).new &block end - def source(&block) - @defaults[:source] = bl...
Support any installer type defaults via method missing
diff --git a/config/initializers/gds-sso.rb b/config/initializers/gds-sso.rb index abc1234..def5678 100644 --- a/config/initializers/gds-sso.rb +++ b/config/initializers/gds-sso.rb @@ -1,7 +1,7 @@ GDS::SSO.config do |config| - config.user_model = "User" - config.oauth_id = ENV['PANOPTICON_OAUTH_ID'] || "abcdefg...
Use correct oauth environment variables These are now set in hieradata. Trello: https://trello.com/c/LZBdyczv
diff --git a/lib/zipline/output_stream.rb b/lib/zipline/output_stream.rb index abc1234..def5678 100644 --- a/lib/zipline/output_stream.rb +++ b/lib/zipline/output_stream.rb @@ -17,12 +17,16 @@ def put_next_entry(entry_name, size) new_entry = Zip::Entry.new(@file_name, entry_name) - new_entry.size = si...
Set uncompressed size in local file header to 0 The ZIP spec [1] describes in section 4.4.9 that the uncompressed size field is set to zero in the local file header if bit 3 of the general purpose flags is set, which zipline does. Some applications actually care about this, e.g. Powerpoint regards a file as corrupt w...
diff --git a/lib/shoulda/matchers/active_record/association_matchers/model_reflector.rb b/lib/shoulda/matchers/active_record/association_matchers/model_reflector.rb index abc1234..def5678 100644 --- a/lib/shoulda/matchers/active_record/association_matchers/model_reflector.rb +++ b/lib/shoulda/matchers/active_record/ass...
Make `order` option Rails 4.0.1-compatible The way that we figure out whether the value which is passed to `order` is the same as the `order` that the association was defined with is by creating an ActiveRecord::Relation object from the given `order` and comparing it with the Relation stored under the association. Spe...
diff --git a/lib/vagrant-free-memory.rb b/lib/vagrant-free-memory.rb index abc1234..def5678 100644 --- a/lib/vagrant-free-memory.rb +++ b/lib/vagrant-free-memory.rb @@ -1,9 +1,13 @@-require "vagrant/free/memory/version" +require 'vagrant-free-memory/version' -module Vagrant - module Free - module Memory - # ...
Create the module for the plugin
diff --git a/lib/whereabouts_methods.rb b/lib/whereabouts_methods.rb index abc1234..def5678 100644 --- a/lib/whereabouts_methods.rb +++ b/lib/whereabouts_methods.rb @@ -13,6 +13,7 @@ module ClassMethods def has_whereabouts has_one :address, :as => :addressable, :dependent => :destroy + ...
Add accepts_nested_attributes_for address on has_whereabouts class methods
diff --git a/app/views/renalware/api/ukrdc/patients/_hd_session_observations.xml.builder b/app/views/renalware/api/ukrdc/patients/_hd_session_observations.xml.builder index abc1234..def5678 100644 --- a/app/views/renalware/api/ukrdc/patients/_hd_session_observations.xml.builder +++ b/app/views/renalware/api/ukrdc/patie...
Remove temperature and respiratory_rate HD observations
diff --git a/lib/berufsorientierungstag.rb b/lib/berufsorientierungstag.rb index abc1234..def5678 100644 --- a/lib/berufsorientierungstag.rb +++ b/lib/berufsorientierungstag.rb @@ -16,13 +16,16 @@ @repo = SpielElementRepository.new @repo.import_map('maps/test.json') @repo.game_objects << @spieler = ...
Add Cursor to Edit Mode + Minor Tweaks -remove debug output
diff --git a/config/initializers/geocoder.rb b/config/initializers/geocoder.rb index abc1234..def5678 100644 --- a/config/initializers/geocoder.rb +++ b/config/initializers/geocoder.rb @@ -10,8 +10,9 @@ Geocoder.configure( lookup: :google, + api_key: ENV['GOOGLE_GEOCODING_API_KEY'], + use_https: true, cache: ...
Use API key for Google geocoding **Why**: To prevent going over the quota.
diff --git a/lib/metacrunch/ubpb/transformations/primo_to_elasticsearch/add_record_date_facet.rb b/lib/metacrunch/ubpb/transformations/primo_to_elasticsearch/add_record_date_facet.rb index abc1234..def5678 100644 --- a/lib/metacrunch/ubpb/transformations/primo_to_elasticsearch/add_record_date_facet.rb +++ b/lib/metacru...
Fix error handling for cataloging_date
diff --git a/merb-haml/lib/merb-haml.rb b/merb-haml/lib/merb-haml.rb index abc1234..def5678 100644 --- a/merb-haml/lib/merb-haml.rb +++ b/merb-haml/lib/merb-haml.rb @@ -7,4 +7,11 @@ Merb::BootLoader.after_app_loads do require "sass/plugin" if File.directory?(Merb.dir_for(:stylesheet) / "sass") end + + # ...
Make symbolize_keys! a noop temporarily.
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb index abc1234..def5678 100644 --- a/config/initializers/assets.rb +++ b/config/initializers/assets.rb @@ -10,4 +10,3 @@ # application.js, application.css, and all non-JS/CSS in app/assets folder are already added. Rails.application.config.asset...
Remove ckeditor from initialize file. :fries:
diff --git a/data-aggregation-index.gemspec b/data-aggregation-index.gemspec index abc1234..def5678 100644 --- a/data-aggregation-index.gemspec +++ b/data-aggregation-index.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'data_aggregation-index' - s.version = '0.1.0.0' + s...
Package version is increased from 0.1.0.0 to 0.2.0.0
diff --git a/db/migrate/20161023011514_add_pickup_date_and_pickup_time_to_orders.rb b/db/migrate/20161023011514_add_pickup_date_and_pickup_time_to_orders.rb index abc1234..def5678 100644 --- a/db/migrate/20161023011514_add_pickup_date_and_pickup_time_to_orders.rb +++ b/db/migrate/20161023011514_add_pickup_date_and_pick...
Add pickup date and pickup time columns to orders
diff --git a/Casks/a-better-finder-rename-beta.rb b/Casks/a-better-finder-rename-beta.rb index abc1234..def5678 100644 --- a/Casks/a-better-finder-rename-beta.rb +++ b/Casks/a-better-finder-rename-beta.rb @@ -1,6 +1,6 @@ cask :v1 => 'a-better-finder-rename-beta' do version '10' - sha256 'df4208eb01c25434b5c93c65ae8...
Update SHA256 for A Better Finder Rename 10
diff --git a/week-5/calculate-mode/my_solution.rb b/week-5/calculate-mode/my_solution.rb index abc1234..def5678 100644 --- a/week-5/calculate-mode/my_solution.rb +++ b/week-5/calculate-mode/my_solution.rb @@ -1,7 +1,7 @@ =begin # Calculate the mode Pairing Challenge -# I worked on this challenge [by myself, with: ] ...
Add my initial pseudocode for 5.3
diff --git a/lib/gemstash/configuration.rb b/lib/gemstash/configuration.rb index abc1234..def5678 100644 --- a/lib/gemstash/configuration.rb +++ b/lib/gemstash/configuration.rb @@ -1,4 +1,5 @@ require "yaml" +require "erb" module Gemstash #:nodoc: @@ -31,7 +32,7 @@ file ||= DEFAULT_FILE if File.exi...
Support ERB parsing in YAML config
diff --git a/lib/intercom-rails/railtie.rb b/lib/intercom-rails/railtie.rb index abc1234..def5678 100644 --- a/lib/intercom-rails/railtie.rb +++ b/lib/intercom-rails/railtie.rb @@ -1,13 +1,18 @@ module IntercomRails class Railtie < Rails::Railtie initializer "intercom-rails" do |app| - ActionView::Base.sen...
Make use of ActiveSupport lazy loading this to prevent load order issues. More on lazy loading here: https://simonecarletti.com/blog/2011/04/understanding-ruby-and-rails-lazy-load-hooks/
diff --git a/promo/app/models/spree/order_decorator.rb b/promo/app/models/spree/order_decorator.rb index abc1234..def5678 100644 --- a/promo/app/models/spree/order_decorator.rb +++ b/promo/app/models/spree/order_decorator.rb @@ -20,7 +20,8 @@ most_valuable_adjustment = adjustments.promotion.eligible.max{|a,b| a.a...
[promo] Check for calculator on adjustment.originator in update_adjustments_with_promotion_listing before checking its type Related up to #1526
diff --git a/lib/orchestrate.io/request.rb b/lib/orchestrate.io/request.rb index abc1234..def5678 100644 --- a/lib/orchestrate.io/request.rb +++ b/lib/orchestrate.io/request.rb @@ -36,6 +36,7 @@ end end } + options.delete_if {|k,v| v.empty? if v.is_a? Hash } end def method_mis...
Delete the key if its value is an empty hash
diff --git a/brew/cask/awsaml.rb b/brew/cask/awsaml.rb index abc1234..def5678 100644 --- a/brew/cask/awsaml.rb +++ b/brew/cask/awsaml.rb @@ -7,7 +7,6 @@ checkpoint: '3d2a662d80c619406bac6682158d8b89320b9d5359863cfbeddd574b00019e9a' name 'awsaml' homepage 'https://github.com/rapid7/awsaml' - license :mi...
Remove the "license" stanza as it's no longer supported. See the complete list of stanzas that are valid in homebrew-cask. https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/all_stanzas.md
diff --git a/app/mailers/user_mailer.rb b/app/mailers/user_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/user_mailer.rb +++ b/app/mailers/user_mailer.rb @@ -1,5 +1,5 @@ class UserMailer < ActionMailer::Base - default from: "emmaleth2003@devbootcamp.com" + default from: "wine-tasting@devbootcamp.com" ...
Change 'from' email for mailers
diff --git a/lib/geocaching.rb b/lib/geocaching.rb index abc1234..def5678 100644 --- a/lib/geocaching.rb +++ b/lib/geocaching.rb @@ -1,4 +1,7 @@ require "geocaching/version" +require "core_ext/array" +require "core_ext/integer" +require "core_ext/string" module Geocaching # Your code goes here...
Add requires for core extensions
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -23,25 +23,5 @@ photos << in_db.select {|x| !in_queue.include?(x.id)} end - - # existing_photos = Photo.where(unsplash_id: unsplash_ids) - # existing_queues = PhotoQ...
Remove unused code in User model
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -5,9 +5,10 @@ # :rememberable, :trackable, :validatable and :omniauthable devise :registerable, :trackable + field :name field :contact, :type => Boolean - validates_pres...
Add name to User model.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -6,7 +6,7 @@ named_scope :active, :conditions => {:active => true} def can_second?(star) - return false if [star.from, star.to.flatten].include?(self) + return false if [s...
Fix for seconding bug for multi-recipient starz
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -19,16 +19,4 @@ def gds_editor? permissions.include?('gds_editor') end - - def organisation_content_id - organisation_content_id = super - - if organisation_content_id...
Revert "Hotfix: Fix RAIB permissions" The organisation_content_id field now gets set by SPv1 as per this commit: https://github.com/alphagov/specialist-publisher/pull/732/commits/75dc26807c0662a9a8c0fe76f8bb682db04dd1e2 The next time a user logs in through signon, that field is set and this application's permissions ...
diff --git a/lib/plugins/wa.rb b/lib/plugins/wa.rb index abc1234..def5678 100644 --- a/lib/plugins/wa.rb +++ b/lib/plugins/wa.rb @@ -11,12 +11,12 @@ input_array = text.split(/[[:space:]]/) input = input_array.join(' ').downcase response = Nokogiri::XML(open("http://api.wolframalpha.com/v2/query?input=#{UR...
Check for and delete nbsp characters
diff --git a/app/uploaders/basic_uploader.rb b/app/uploaders/basic_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/basic_uploader.rb +++ b/app/uploaders/basic_uploader.rb @@ -13,7 +13,8 @@ # Override the directory where uploaded files will be stored. # This is a sensible default for uploaders that ar...
Store files in tmp in specs
diff --git a/spec/integration/run_sim_spec.rb b/spec/integration/run_sim_spec.rb index abc1234..def5678 100644 --- a/spec/integration/run_sim_spec.rb +++ b/spec/integration/run_sim_spec.rb @@ -16,11 +16,9 @@ :sim_control => sim_control } - hash = nil - Retriable.retriable({:tr...
Use launch-sim interface in run sim specs
diff --git a/spec/lib/import_finisher_spec.rb b/spec/lib/import_finisher_spec.rb index abc1234..def5678 100644 --- a/spec/lib/import_finisher_spec.rb +++ b/spec/lib/import_finisher_spec.rb @@ -15,5 +15,30 @@ require 'spec_helper' describe ImportFinisher do + describe "#on_success" do + before :each do + @pr...
Add specs for import finisher
diff --git a/spec/support/factories/topics.rb b/spec/support/factories/topics.rb index abc1234..def5678 100644 --- a/spec/support/factories/topics.rb +++ b/spec/support/factories/topics.rb @@ -3,7 +3,7 @@ t.subject "FIRST TOPIC" t.forum {|f| f.association(:forum) } t.user {|u| u.association(:user) } - ...
Send through post attributes using posts_attributes when creating a topic This ensures that when we use factories that the topics+posts are created identically to how they're created inside the application
diff --git a/spec/unit/oss_compliance_spec.rb b/spec/unit/oss_compliance_spec.rb index abc1234..def5678 100644 --- a/spec/unit/oss_compliance_spec.rb +++ b/spec/unit/oss_compliance_spec.rb @@ -0,0 +1,52 @@+require 'spec_helper' +require 'rubygems/package' +require 'zlib' +require 'yaml' +require 'httparty' + +describe ...
Add spec to check OSS compliance of erlang blob [#115611161] Signed-off-by: Houssem El Fekih <79fadb0a34afe753d9a3e9572acabeee9978c197@pivotal.io>
diff --git a/lib/radbeacon.rb b/lib/radbeacon.rb index abc1234..def5678 100644 --- a/lib/radbeacon.rb +++ b/lib/radbeacon.rb @@ -1,10 +1,9 @@ require "radbeacon/version" require "radbeacon/le_scanner" require "radbeacon/bluetooth_le_device" +require "radbeacon/utils" require "radbeacon/scanner" require "radbeacon/u...
Reorder require statements so Utils is before Usb
diff --git a/libraries/nsd3.rb b/libraries/nsd3.rb index abc1234..def5678 100644 --- a/libraries/nsd3.rb +++ b/libraries/nsd3.rb @@ -22,12 +22,15 @@ def generate_nsd3_conf_section(lines, data, prefix="\t") data.each do |tag, value_or_values| + # Does not work as intended because deep merge ignores nil v...
Allow reset of predefined value
diff --git a/assignments/ruby/bob/example.rb b/assignments/ruby/bob/example.rb index abc1234..def5678 100644 --- a/assignments/ruby/bob/example.rb +++ b/assignments/ruby/bob/example.rb @@ -13,7 +13,7 @@ class AnswerQuestion def self.handles?(input) - input.include?('?') + input.end_with?('?') end def...
Fix implementation of question in ruby:bob
diff --git a/lingohub.gemspec b/lingohub.gemspec index abc1234..def5678 100644 --- a/lingohub.gemspec +++ b/lingohub.gemspec @@ -3,17 +3,15 @@ Gem::Specification.new do |gem| gem.name = 'lingohub' gem.version = Lingohub::VERSION - gem.author = 'lingohub GmbH' - gem.email = 'team@li...
Rearrange gem specification declarations slightly
diff --git a/linguist.gemspec b/linguist.gemspec index abc1234..def5678 100644 --- a/linguist.gemspec +++ b/linguist.gemspec @@ -11,6 +11,6 @@ s.add_dependency 'charlock_holmes', '~> 0.6.6' s.add_dependency 'escape_utils', '~> 0.2.3' s.add_dependency 'mime-types', '~> 1.18' - s.add_dependency 'pygments...
Use an even newer Pygments
diff --git a/lita-irc.gemspec b/lita-irc.gemspec index abc1234..def5678 100644 --- a/lita-irc.gemspec +++ b/lita-irc.gemspec @@ -1,12 +1,13 @@ Gem::Specification.new do |spec| spec.name = "lita-irc" - spec.version = "1.2.1" + spec.version = "1.2.2" spec.authors = ["Jimmy Cuadra"] s...
Add plugin type metadata and bump version to 1.2.2.
diff --git a/test/factories.rb b/test/factories.rb index abc1234..def5678 100644 --- a/test/factories.rb +++ b/test/factories.rb @@ -23,7 +23,8 @@ Factory.define :user do |u| u.username { Factory.next(:usernames) } - u.author {|a| Factory(:author, :username => a.username, :created_at => a.created_at) } + u.email...
Change where email is set on a factoried user Since a local user controls its author's email, mirror that in the factory
diff --git a/lunokhod.gemspec b/lunokhod.gemspec index abc1234..def5678 100644 --- a/lunokhod.gemspec +++ b/lunokhod.gemspec @@ -23,6 +23,7 @@ spec.add_development_dependency "bundler", "~> 1.2" spec.add_development_dependency "rake" + spec.add_development_dependency 'benchmark_suite' spec.add_development_de...
Use benchmark_suite to benchmark the parser and other bits.
diff --git a/test/integration/config/client_rb_spec.rb b/test/integration/config/client_rb_spec.rb index abc1234..def5678 100644 --- a/test/integration/config/client_rb_spec.rb +++ b/test/integration/config/client_rb_spec.rb @@ -1,8 +1,14 @@-describe command('ohai virtualization -c /etc/chef/client.rb') do +if os.windo...
Fix a few failing tests on Windows Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/test/integration/universe_stories_test.rb b/test/integration/universe_stories_test.rb index abc1234..def5678 100644 --- a/test/integration/universe_stories_test.rb +++ b/test/integration/universe_stories_test.rb @@ -0,0 +1,43 @@+require 'test_helper' + +# Tests scenarios related to interacting with Univers...
Write a universes integration test
diff --git a/terraform/aws/scenarios/omnibus-external-elasticsearch/files/chef-server.rb b/terraform/aws/scenarios/omnibus-external-elasticsearch/files/chef-server.rb index abc1234..def5678 100644 --- a/terraform/aws/scenarios/omnibus-external-elasticsearch/files/chef-server.rb +++ b/terraform/aws/scenarios/omnibus-ext...
Fix elasticsearch test scenario configuration The elasticsearch provider is only supported by the batch or inline queue modes. Signed-off-by: Christopher A. Snapp <dffaa860ed97a8fe2bd7fd9817f16f80af273fae@chef.io>
diff --git a/mit-ldap.gemspec b/mit-ldap.gemspec index abc1234..def5678 100644 --- a/mit-ldap.gemspec +++ b/mit-ldap.gemspec @@ -7,9 +7,9 @@ s.version = MIT::LDAP::VERSION s.authors = ["Eduardo Gutierrez"] s.email = ["edd_d@mit.edu"] - s.homepage = "" - s.summary = %q{Wrapper for MIT LDAP...
Add homepage and update descriptions
diff --git a/broach.gemspec b/broach.gemspec index abc1234..def5678 100644 --- a/broach.gemspec +++ b/broach.gemspec @@ -1,9 +1,7 @@-require 'rake' - Gem::Specification.new do |spec| spec.name = 'broach' spec.version = '0.1.4' - + spec.author = "Manfred Stienstra" spec.email = "manfred@fngtps.com" @@ -...
Remove the Rake dependency from the gemspec.
diff --git a/hashie.gemspec b/hashie.gemspec index abc1234..def5678 100644 --- a/hashie.gemspec +++ b/hashie.gemspec @@ -1,18 +1,18 @@ require File.expand_path('../lib/hashie/version', __FILE__) Gem::Specification.new do |gem| + gem.name = 'hashie' + gem.version = Hashie::VERSION gem.authors ...
Reorganize gemspec according to common convention
diff --git a/lib/gitolite/gitolite_admin.rb b/lib/gitolite/gitolite_admin.rb index abc1234..def5678 100644 --- a/lib/gitolite/gitolite_admin.rb +++ b/lib/gitolite/gitolite_admin.rb @@ -17,10 +17,22 @@ @config = Config.new(File.join(path, conf)) end - def add_key(key) + #Writes all aspects out to the ...
Add initial methods for saving back to disk
diff --git a/homebrew/chruby-fish.rb b/homebrew/chruby-fish.rb index abc1234..def5678 100644 --- a/homebrew/chruby-fish.rb +++ b/homebrew/chruby-fish.rb @@ -2,8 +2,8 @@ class ChrubyFish < Formula homepage 'https://github.com/JeanMertz/chruby-fish#readme' - url 'https://github.com/JeanMertz/chruby-fish/archive/v0....
Update Homebrew formula for v0.6.0
diff --git a/PlanetExpress/spec/routing/planet_express/zoidbergs_routing_spec.rb b/PlanetExpress/spec/routing/planet_express/zoidbergs_routing_spec.rb index abc1234..def5678 100644 --- a/PlanetExpress/spec/routing/planet_express/zoidbergs_routing_spec.rb +++ b/PlanetExpress/spec/routing/planet_express/zoidbergs_routing...
Add PATCH update spec for Zoidbergs
diff --git a/examples/queues_default_name.rb b/examples/queues_default_name.rb index abc1234..def5678 100644 --- a/examples/queues_default_name.rb +++ b/examples/queues_default_name.rb @@ -0,0 +1,18 @@+# Example of how Qu works with graceful shutdown turned on. +require_relative './example_setup' + +Qu.configure do |co...
Add example of default queue.
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb index abc1234..def5678 100644 --- a/config/initializers/assets.rb +++ b/config/initializers/assets.rb @@ -21,3 +21,5 @@ %w[images fonts javascripts].each do |asset| assets_path.insert(0, Rails.root.join("app", "assets", asset, "custom").to_s)...
Fix ckeditor link, another try
diff --git a/Library/Homebrew/test/cmd/cat_spec.rb b/Library/Homebrew/test/cmd/cat_spec.rb index abc1234..def5678 100644 --- a/Library/Homebrew/test/cmd/cat_spec.rb +++ b/Library/Homebrew/test/cmd/cat_spec.rb @@ -8,4 +8,13 @@ .and not_to_output.to_stderr .and be_a_success end + + it "fails when given m...
Add multiple arguments test for brew cat
diff --git a/install-program-list.rb b/install-program-list.rb index abc1234..def5678 100644 --- a/install-program-list.rb +++ b/install-program-list.rb @@ -0,0 +1,21 @@+#!/usr/bin/env ruby + +# Install brew and gems as listed in `brew` and `gems` folder. + +require 'rake' + +def installFrom(filePath) + File.foreach...
Add script to install programs from lists
diff --git a/db/migrate/076_add_indices.rb b/db/migrate/076_add_indices.rb index abc1234..def5678 100644 --- a/db/migrate/076_add_indices.rb +++ b/db/migrate/076_add_indices.rb @@ -0,0 +1,9 @@+class AddIndices < ActiveRecord::Migration + def self.up + add_index :track_things_sent_emails, :track_thing_id + end + + ...
Add an index Alex found was missing.
diff --git a/cfndsl.gemspec b/cfndsl.gemspec index abc1234..def5678 100644 --- a/cfndsl.gemspec +++ b/cfndsl.gemspec @@ -21,6 +21,6 @@ s.executables << 'cfndsl' - s.add_development_dependency 'bundler', '~> 1.17' + s.add_development_dependency 'bundler', '~> 2.0' s.add_runtime_dependency 'hana', '~> 1.3' en...
Upgrade dev dependency to bundler 2
diff --git a/app/controllers/remote_database_cleaner_home_rails/home_controller.rb b/app/controllers/remote_database_cleaner_home_rails/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/remote_database_cleaner_home_rails/home_controller.rb +++ b/app/controllers/remote_database_cleaner_home_rails/ho...
Make status code a variable
diff --git a/lib/ansible/transmit.rb b/lib/ansible/transmit.rb index abc1234..def5678 100644 --- a/lib/ansible/transmit.rb +++ b/lib/ansible/transmit.rb @@ -24,8 +24,7 @@ beacon = __method__ headers['Content-Type'] = 'text/event-stream' sse = SSE.new(response.stream) - loop do -...
Use "until" instead of "loop do"
diff --git a/kumade.gemspec b/kumade.gemspec index abc1234..def5678 100644 --- a/kumade.gemspec +++ b/kumade.gemspec @@ -18,6 +18,7 @@ s.add_dependency('heroku', '~> 2.0') s.add_dependency('thor', '~> 0.14') + s.add_dependency('rake', '~> 0.8.7') s.add_development_dependency('rake', '~> 0.8.7') s.add_de...
Fix to work with 1.8.7 again.
diff --git a/lib/travis/github/services/find_or_create_repo.rb b/lib/travis/github/services/find_or_create_repo.rb index abc1234..def5678 100644 --- a/lib/travis/github/services/find_or_create_repo.rb +++ b/lib/travis/github/services/find_or_create_repo.rb @@ -13,7 +13,7 @@ private def find - ...
Use only relevant params when searching for repo
diff --git a/test/helpers/helper_test.rb b/test/helpers/helper_test.rb index abc1234..def5678 100644 --- a/test/helpers/helper_test.rb +++ b/test/helpers/helper_test.rb @@ -0,0 +1,33 @@+require File.expand_path('../../test_helper', __FILE__) + +class HelperTestController < ActionController::Base + def test + render...
Add action view test case
diff --git a/lib/omc/cli.rb b/lib/omc/cli.rb index abc1234..def5678 100644 --- a/lib/omc/cli.rb +++ b/lib/omc/cli.rb @@ -14,7 +14,7 @@ instances = ops.describe_instances(stack_id: ops_stack[:stack_id])[:instances] instances.reject!{|i| i[:status] != "online" } instance = instances.first || abort("No...
Use exec instead of leaving a waiting ruby process Change-Id: Ia9c190b96803a6950d895e99a2546879329e1f35
diff --git a/api/app/models/hackbot/interactions/greeter.rb b/api/app/models/hackbot/interactions/greeter.rb index abc1234..def5678 100644 --- a/api/app/models/hackbot/interactions/greeter.rb +++ b/api/app/models/hackbot/interactions/greeter.rb @@ -12,6 +12,10 @@ def start im = SlackClient::Chat.open_im(...
Fix Orpheus sending multiple messages to new users
diff --git a/app/models/concerns/prev_nextable.rb b/app/models/concerns/prev_nextable.rb index abc1234..def5678 100644 --- a/app/models/concerns/prev_nextable.rb +++ b/app/models/concerns/prev_nextable.rb @@ -7,12 +7,12 @@ # For Event object, start_date is used to determine the previous record included do def...
Fix broken tests with Sqlite3 adapter
diff --git a/app/services/notes/create_service.rb b/app/services/notes/create_service.rb index abc1234..def5678 100644 --- a/app/services/notes/create_service.rb +++ b/app/services/notes/create_service.rb @@ -3,6 +3,7 @@ def execute note = project.notes.new(params[:note]) note.author = current_user + ...
Make sure note.system is false if created by user Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/app/workers/thread_resolve_worker.rb b/app/workers/thread_resolve_worker.rb index abc1234..def5678 100644 --- a/app/workers/thread_resolve_worker.rb +++ b/app/workers/thread_resolve_worker.rb @@ -3,7 +3,7 @@ class ThreadResolveWorker include Sidekiq::Worker - sidekiq_options queue: 'pull', retry: fal...
Change ThreadResolveWorker retry value to 5
diff --git a/app/controllers/buckets_controller.rb b/app/controllers/buckets_controller.rb index abc1234..def5678 100644 --- a/app/controllers/buckets_controller.rb +++ b/app/controllers/buckets_controller.rb @@ -23,6 +23,7 @@ # POST /buckets def create @bucket = Bucket.new(bucket_params) + @bucket.team_id...
Set bucket team_id on create
diff --git a/app/controllers/reviews_controller.rb b/app/controllers/reviews_controller.rb index abc1234..def5678 100644 --- a/app/controllers/reviews_controller.rb +++ b/app/controllers/reviews_controller.rb @@ -9,7 +9,6 @@ def create review = Review.new(review_params) - review.update_attributes(reviewer_i...
Add merge to review params in controller to assign reviewer id to current user id
diff --git a/webadmin/start.rb b/webadmin/start.rb index abc1234..def5678 100644 --- a/webadmin/start.rb +++ b/webadmin/start.rb @@ -20,8 +20,9 @@ revision = params[:revision].ergo.to_s[/(\w+)/, 1] @command = nil - common_restart = %{bundle exec rake RAILS_ENV=production clear && (bundle check || bundle --local...
Fix webadmin to run bundle before migrations.
diff --git a/dashboard/test/integration/twilio_sms_test.rb b/dashboard/test/integration/twilio_sms_test.rb index abc1234..def5678 100644 --- a/dashboard/test/integration/twilio_sms_test.rb +++ b/dashboard/test/integration/twilio_sms_test.rb @@ -0,0 +1,51 @@+require 'test_helper' +require 'twilio-ruby' + +class TwilioSm...
Add integration test for receiving Twilio SMS on carrier network
diff --git a/app/services/groups/update_service.rb b/app/services/groups/update_service.rb index abc1234..def5678 100644 --- a/app/services/groups/update_service.rb +++ b/app/services/groups/update_service.rb @@ -30,7 +30,7 @@ return true unless changing_share_with_group_lock? return true if can?(current_u...
Make UpdateService error message translatable
diff --git a/lib/rlm_ruby/license.rb b/lib/rlm_ruby/license.rb index abc1234..def5678 100644 --- a/lib/rlm_ruby/license.rb +++ b/lib/rlm_ruby/license.rb @@ -5,7 +5,8 @@ class License def self.generate_keys(contact = {}, products = []) - req = Net::HTTP::Post.new(RlmRuby.configuration.uri, initheader = {'C...
Send the products SKU inside note for reference later
diff --git a/lib/shamrock/service.rb b/lib/shamrock/service.rb index abc1234..def5678 100644 --- a/lib/shamrock/service.rb +++ b/lib/shamrock/service.rb @@ -5,13 +5,13 @@ def initialize(rack_app, handler = Rack::Handler::WEBrick, - monitor = Shamrock::Monitor) + ...
Remove full namespacing when not needed
diff --git a/lib/tasks/guidance.rake b/lib/tasks/guidance.rake index abc1234..def5678 100644 --- a/lib/tasks/guidance.rake +++ b/lib/tasks/guidance.rake @@ -1,10 +1,32 @@ require 'logger' namespace :guidance do - task :import_csv, [:file] => [:environment] do |t, args| + task :import_csv, [:file, :topic, :organisa...
Update importer to count rows and use passed in data Invoke with: rake guidance:import_csv[file,topic_name,org_name,author_email]