diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/protopuffs/parser/parser.rb b/lib/protopuffs/parser/parser.rb index abc1234..def5678 100644 --- a/lib/protopuffs/parser/parser.rb +++ b/lib/protopuffs/parser/parser.rb @@ -7,7 +7,7 @@ class ProtocolBufferDescriptor def initialize - Treetop.load "lib/protopuffs/parser/protocol_buffer...
Fix that loading the message descriptor grammar file only worked from certain working directories
diff --git a/lib/sass/tree/mixin_def_node.rb b/lib/sass/tree/mixin_def_node.rb index abc1234..def5678 100644 --- a/lib/sass/tree/mixin_def_node.rb +++ b/lib/sass/tree/mixin_def_node.rb @@ -1,14 +1,25 @@ module Sass module Tree + # A dynamic node representing a mixin definition. + # + # @see Sass::Tree ...
[Sass] Convert Sass::Tree::MixinDefNode docs to YARD.
diff --git a/DMHeatmap.podspec b/DMHeatmap.podspec index abc1234..def5678 100644 --- a/DMHeatmap.podspec +++ b/DMHeatmap.podspec @@ -8,6 +8,6 @@ s.social_media_url = "http://twitter.com/moltman" s.platform = :ios s.source = { :git => "https://github.com/dataminr/DMHeatmap.git", :tag => '1' } - s.sour...
Add color providers to podspec
diff --git a/lib/lftruncator.rb b/lib/lftruncator.rb index abc1234..def5678 100644 --- a/lib/lftruncator.rb +++ b/lib/lftruncator.rb @@ -8,6 +8,7 @@ opts = DEFAULT_OPTIONS.merge(opts) doc = Nokogiri::HTML::DocumentFragment.parse(text) doc.search("img").remove + doc.css(".sommaire,.toc").remove doc...
Remove the table of contents from listing pages
diff --git a/spec/unit/recipes/git_spec.rb b/spec/unit/recipes/git_spec.rb index abc1234..def5678 100644 --- a/spec/unit/recipes/git_spec.rb +++ b/spec/unit/recipes/git_spec.rb @@ -10,9 +10,9 @@ expect(windows_chef_run).to install_chocolatey_package('git-credential-manager-for-windows') end - it 'instal...
Remove poshgit from unit tests
diff --git a/create_project.rb b/create_project.rb index abc1234..def5678 100644 --- a/create_project.rb +++ b/create_project.rb @@ -0,0 +1,21 @@+require 'xcodeproj' +require 'trollop' + +opts = Trollop::options do + opt :name, "The name of the project", type: String +end + +name = opts[:name] + +Trollop::die :name,...
Create an XCode Project from the commandline.
diff --git a/puppet-parse.gemspec b/puppet-parse.gemspec index abc1234..def5678 100644 --- a/puppet-parse.gemspec +++ b/puppet-parse.gemspec @@ -15,7 +15,7 @@ gem.require_paths = ["lib"] gem.version = PuppetParse::VERSION - gem.add_development_dependency "rspec" + gem.add_development_dependency "rspec", ...
Define rspec version - tests don't work with rspec 3+
diff --git a/CascadingTableDelegate.podspec b/CascadingTableDelegate.podspec index abc1234..def5678 100644 --- a/CascadingTableDelegate.podspec +++ b/CascadingTableDelegate.podspec @@ -4,7 +4,7 @@ s.summary = 'A no-nonsense way to write cleaner `UITableViewDelegate` and `UITableViewDataSource`.' s.descr...
Change NSIndexPath to IndexPath in podspec
diff --git a/Casks/pinegrow-web-designer.rb b/Casks/pinegrow-web-designer.rb index abc1234..def5678 100644 --- a/Casks/pinegrow-web-designer.rb +++ b/Casks/pinegrow-web-designer.rb @@ -1,14 +1,14 @@ cask :v1 => 'pinegrow-web-designer' do - version :latest - sha256 :no_check + version '2.00' + sha256 '9cfaf6538e52d0...
Update Pinegrow Web Designer.app to verion 2.0
diff --git a/spec/class_file_finder_spec.rb b/spec/class_file_finder_spec.rb index abc1234..def5678 100644 --- a/spec/class_file_finder_spec.rb +++ b/spec/class_file_finder_spec.rb @@ -6,7 +6,9 @@ Dir.mkdir 'dummy' ['foo', 'bar'].each do |name| - File.write("dummy/#{ name }.rb", '') + out_file = Fi...
Revert "Clean up file finder spec since it no longer scans for class keyword match" This reverts commit 57d28a47210f561daf6c0fe4184bb012cef92063.
diff --git a/spec/runtime/gem_tasks_spec.rb b/spec/runtime/gem_tasks_spec.rb index abc1234..def5678 100644 --- a/spec/runtime/gem_tasks_spec.rb +++ b/spec/runtime/gem_tasks_spec.rb @@ -0,0 +1,32 @@+require "spec_helper" + +describe "require 'bundler/gem_tasks'" do + before :each do + bundled_app("foo.gemspec").open...
[GemTasks] Add a basic spec that the relevant tasks are installed
diff --git a/spec/unit/command/repo_spec.rb b/spec/unit/command/repo_spec.rb index abc1234..def5678 100644 --- a/spec/unit/command/repo_spec.rb +++ b/spec/unit/command/repo_spec.rb @@ -19,11 +19,11 @@ end it "supports a repo with a compatible maximum version" do - versions = { 'max' => '0.7' } + versions =...
Fix repo max version spec work for the foreseeable future.
diff --git a/lib/impasta/missing_method.rb b/lib/impasta/missing_method.rb index abc1234..def5678 100644 --- a/lib/impasta/missing_method.rb +++ b/lib/impasta/missing_method.rb @@ -28,7 +28,7 @@ end def message - "invalid message `#{method_info}' for #{target_info}" + "invalid message #{method_info...
Remove excess quotes, they are in the method now
diff --git a/Raccoon.podspec b/Raccoon.podspec index abc1234..def5678 100644 --- a/Raccoon.podspec +++ b/Raccoon.podspec @@ -13,7 +13,7 @@ spec.author = "Manuel García-Estañ" spec.social_media_url = "http://twitter.com/ManueGE" - spec.platform = :ios, "8.0" + spec.platform = :ios, "9.0" spec.s...
Change minimum version to iOS 9
diff --git a/lib/slg-meta/traced_method.rb b/lib/slg-meta/traced_method.rb index abc1234..def5678 100644 --- a/lib/slg-meta/traced_method.rb +++ b/lib/slg-meta/traced_method.rb @@ -3,24 +3,26 @@ module SLG module Meta class TracedMethod - attr_reader :base, :method, :type, :call_count + attr_reader :b...
Refactor TracedMethod to defer const_lookup somewhat
diff --git a/opal-jquery.gemspec b/opal-jquery.gemspec index abc1234..def5678 100644 --- a/opal-jquery.gemspec +++ b/opal-jquery.gemspec @@ -6,7 +6,7 @@ s.version = Opal::JQuery::VERSION s.authors = ['Adam Beynon', 'Elia Schito'] s.email = 'elia@schito.me' - s.homepage = 'http://opalrb.org...
Update the homepage url in the gemspec
diff --git a/lib/torckapi/response/base.rb b/lib/torckapi/response/base.rb index abc1234..def5678 100644 --- a/lib/torckapi/response/base.rb +++ b/lib/torckapi/response/base.rb @@ -7,7 +7,7 @@ def self.bdecode_and_check(data, key) begin - bdecoded_data = BEncode.load(data) + bdecoded_...
Allow proper loading of failed Bencoded data When returned with a failure of a response, originally this will raise a MalformedResponseError well, erroneously. The response is proper, and should carry on to raise the next error later, for proper debugging purposes.
diff --git a/lib/word_search/plane/base.rb b/lib/word_search/plane/base.rb index abc1234..def5678 100644 --- a/lib/word_search/plane/base.rb +++ b/lib/word_search/plane/base.rb @@ -8,9 +8,7 @@ validates :x, :y, numericality: { greater_than_or_equal_to: 2 } def print(file_name = nil) - file = File....
Make writing word search to file actually work
diff --git a/lib/tasks/iso.rake b/lib/tasks/iso.rake index abc1234..def5678 100644 --- a/lib/tasks/iso.rake +++ b/lib/tasks/iso.rake @@ -2,14 +2,7 @@ namespace :maintenance do task :repair_image_permissions => :environment do bucket = $s3_client.buckets.find(ENV['S3_BUCKET']) - to_fix = [] Pho...
Revert to being more generalised
diff --git a/Casks/cyberduck.rb b/Casks/cyberduck.rb index abc1234..def5678 100644 --- a/Casks/cyberduck.rb +++ b/Casks/cyberduck.rb @@ -1,6 +1,6 @@ class Cyberduck < Cask version '4.5.2' - sha256 '94afaf396b4fddfb1bacbe9a8f648492949dde437579be273c0a752470d577c1' + sha256 'cff337f880b6ebbcc7f2e246b677fa5346fd225ae...
Fix SHA2 mismatch for Cyberduck 4.5.2. Error: SHA2 mismatch Expected: 94afaf396b4fddfb1bacbe9a8f648492949dde437579be273c0a752470d577c1 Actual: cff337f880b6ebbcc7f2e246b677fa5346fd225ae83289dca71ab35cf4b6eb8f Archive: /Library/Caches/Homebrew/cyberduck-4.5.2.zip
diff --git a/Casks/textadept.rb b/Casks/textadept.rb index abc1234..def5678 100644 --- a/Casks/textadept.rb +++ b/Casks/textadept.rb @@ -1,5 +1,5 @@ class Textadept < Cask - url 'http://foicica.com/textadept/download/textadept_5.4.osx.zip' + url 'http://foicica.com/textadept/download/textadept_6.0_beta_3.osx.zip' ...
Update Cask: Textadept 6.0 beta 3.
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -5,3 +5,14 @@ # # movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }]) # Character.create(name: 'Luke', movie: movies.first) + +## Create a default Admin User +admin = User.where(em...
Add a default admin user to db:seed
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -9,6 +9,7 @@ name = page.css('td.cafename a substring')[item_num].text link = page.css('td.cafename')[item_num].css('a').first['href'] members = page.css('td.member')[item_num].text.gsub(/,/, '').to...
Update seed for negative members bug
diff --git a/app/helpers/admin_helper.rb b/app/helpers/admin_helper.rb index abc1234..def5678 100644 --- a/app/helpers/admin_helper.rb +++ b/app/helpers/admin_helper.rb @@ -11,13 +11,23 @@ def i18n_reply + # Builds the nested selector for common replies + select = "<label class='control-label' for='post_r...
Update select common reply helper with hack to handle missing translations for chinese char sets Signed-off-by: Scott Miller <ee4be419d3f845eb9ce4e4ef3aeee8bd8acd07cf@gmail.com>
diff --git a/engines/order_management/spec/services/order_management/stock/packer_spec.rb b/engines/order_management/spec/services/order_management/stock/packer_spec.rb index abc1234..def5678 100644 --- a/engines/order_management/spec/services/order_management/stock/packer_spec.rb +++ b/engines/order_management/spec/se...
Update test setup in Packer spec. This is the correct way to set a variant's weight.
diff --git a/TEQuickPageViewController.podspec b/TEQuickPageViewController.podspec index abc1234..def5678 100644 --- a/TEQuickPageViewController.podspec +++ b/TEQuickPageViewController.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "TEQuickPageViewController" - s.version = "2.0.0" + s.version ...
Update podspec for version 2.1.0.
diff --git a/fakefs.gemspec b/fakefs.gemspec index abc1234..def5678 100644 --- a/fakefs.gemspec +++ b/fakefs.gemspec @@ -6,7 +6,7 @@ Gem::Specification.new do |spec| spec.name = "fakefs" spec.version = FakeFS::Version.to_s - spec.authors = ["Chris Wanstrath", "Scott Taylor", "Jeff Hodges", "...
Add myself as an author.
diff --git a/feeder.gemspec b/feeder.gemspec index abc1234..def5678 100644 --- a/feeder.gemspec +++ b/feeder.gemspec @@ -31,5 +31,5 @@ s.add_development_dependency "capybara" s.add_development_dependency "factory_girl_rails" s.add_development_dependency "timecop" - s.add_development_dependency "cancan" + s.ad...
Use cancancan instead of cancan
diff --git a/app/policies/user_policy.rb b/app/policies/user_policy.rb index abc1234..def5678 100644 --- a/app/policies/user_policy.rb +++ b/app/policies/user_policy.rb @@ -33,4 +33,8 @@ def destroy? show? end + + def view_admin? + index? + end end
Add view_admin? method to user policy
diff --git a/spec/scanner_spec.rb b/spec/scanner_spec.rb index abc1234..def5678 100644 --- a/spec/scanner_spec.rb +++ b/spec/scanner_spec.rb @@ -6,7 +6,7 @@ let(:name) { 'nmap' } let(:version) { '6.01' } let(:args) { 'nmap -v -sS -sU -A -O -oX spec/scan.xml scanme.nmap.org' } - let(:start_time) {...
Use Time.parse instead of Time.new for ruby-3.1.0-preview1.
diff --git a/spec/support/jazz.rb b/spec/support/jazz.rb index abc1234..def5678 100644 --- a/spec/support/jazz.rb +++ b/spec/support/jazz.rb @@ -1,29 +1,33 @@ # frozen_string_literal: true + +# Here's the "application" module Jazz + # Here are some classes that the application deals with module Models Ensembl...
Annotate the example a bit
diff --git a/recipes/grml-zsh.rb b/recipes/grml-zsh.rb index abc1234..def5678 100644 --- a/recipes/grml-zsh.rb +++ b/recipes/grml-zsh.rb @@ -1,4 +1,4 @@-include_recipe "chef-apt-repo::grml" +include_recipe "apt-repo::grml" directory "/etc/apt/preferences.d" cookbook_file "grml-pin" do
Use apt-repo as cookbook name instead of chef-apt-repo
diff --git a/ruboty.gemspec b/ruboty.gemspec index abc1234..def5678 100644 --- a/ruboty.gemspec +++ b/ruboty.gemspec @@ -20,7 +20,7 @@ spec.add_dependency "bundler" spec.add_dependency "dotenv" spec.add_dependency "mem" - spec.add_dependency "slop" + spec.add_dependency "slop", ">= 4.0.0" spec.add_developm...
Use slop v4 or higher because some options couldn't work
diff --git a/Casks/syncthing.rb b/Casks/syncthing.rb index abc1234..def5678 100644 --- a/Casks/syncthing.rb +++ b/Casks/syncthing.rb @@ -2,6 +2,7 @@ version '0.13.7' sha256 '58c0063cecef9d2969b96223e4cacfabb91f2df0f7a7bf43860a50a344b487f7' + # github.com/syncthing/syncthing was verified as official when first i...
Fix `url` stanza comment for Syncthing.
diff --git a/temperature_conversion.gemspec b/temperature_conversion.gemspec index abc1234..def5678 100644 --- a/temperature_conversion.gemspec +++ b/temperature_conversion.gemspec @@ -13,14 +13,6 @@ spec.homepage = "https://github.com/eternal44/temperature_conversion" spec.license = "MIT" - # Preven...
Remove metadata option on gemspec Allows for easier releasing / deployment to any server
diff --git a/acts_as_shopping_cart.gemspec b/acts_as_shopping_cart.gemspec index abc1234..def5678 100644 --- a/acts_as_shopping_cart.gemspec +++ b/acts_as_shopping_cart.gemspec @@ -18,7 +18,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] - s.add_d...
Change the activerecord dependency lock to work both with 4.0 and 4.1
diff --git a/lib/mongo_mapper/plugins/inspect.rb b/lib/mongo_mapper/plugins/inspect.rb index abc1234..def5678 100644 --- a/lib/mongo_mapper/plugins/inspect.rb +++ b/lib/mongo_mapper/plugins/inspect.rb @@ -5,9 +5,9 @@ extend ActiveSupport::Concern module InstanceMethods - def inspect(include_super=...
Update variable name to reflect intention
diff --git a/app/helpers/access_lint_helper.rb b/app/helpers/access_lint_helper.rb index abc1234..def5678 100644 --- a/app/helpers/access_lint_helper.rb +++ b/app/helpers/access_lint_helper.rb @@ -1,17 +1,5 @@ module AccessLintHelper def include_access_lint - javascript_include_tag("accesslint") + - javascript...
Simplify javascript loading and execution - accesslint.js now handled the loading and execution.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -13,15 +13,23 @@ nil end - def thumbnail_image_tag(model, size = "50x50") + def thumbnail_path(model) if mod...
Improve thumbnail helpers by three methods: thumbnail_path, thumbnail_image_tag, thumbnail_image_link
diff --git a/app/helpers/investments_helper.rb b/app/helpers/investments_helper.rb index abc1234..def5678 100644 --- a/app/helpers/investments_helper.rb +++ b/app/helpers/investments_helper.rb @@ -26,7 +26,7 @@ end def errors_on_image(investment) - @investment.errors[:image].join(', ') if @investment.errors.h...
Use helper argument intead of instance variable.
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -4,7 +4,7 @@ license 'MIT' description 'Installs and configures the Frog Media Server' long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) -version '1.0.1' +version '1.0.2' depends 'data...
Update development version to 1.0.2
diff --git a/test/unit/asset_bundle_test.rb b/test/unit/asset_bundle_test.rb index abc1234..def5678 100644 --- a/test/unit/asset_bundle_test.rb +++ b/test/unit/asset_bundle_test.rb @@ -5,8 +5,8 @@ class AssetBundleTest < TestCase def test_raise_exception_if_bundle_command_fails capture_io do - err ...
Fix occasionally failing test: wait for stdin
diff --git a/salestation.gemspec b/salestation.gemspec index abc1234..def5678 100644 --- a/salestation.gemspec +++ b/salestation.gemspec @@ -20,7 +20,7 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.13" - spec.add_development_dependency "rake", "~> 10.0" + spec.add_development...
Update rake development dependency to fix CVE
diff --git a/spec/factories/game_factory.rb b/spec/factories/game_factory.rb index abc1234..def5678 100644 --- a/spec/factories/game_factory.rb +++ b/spec/factories/game_factory.rb @@ -1,5 +1,6 @@ Factory.define :game do |g| g.regulation_type :unregulated + g.after_create { |game| attach_region game } end Facto...
Attach a region to every new factory'd game
diff --git a/spec/integration/login_spec.rb b/spec/integration/login_spec.rb index abc1234..def5678 100644 --- a/spec/integration/login_spec.rb +++ b/spec/integration/login_spec.rb @@ -4,7 +4,7 @@ describe 'Login' do include_context 'in site' - before { FactoyrGirl.create(:user, name: 'test') } + before { Factor...
Fix admin login integration spec
diff --git a/app/models/concerns/has_a_feed.rb b/app/models/concerns/has_a_feed.rb index abc1234..def5678 100644 --- a/app/models/concerns/has_a_feed.rb +++ b/app/models/concerns/has_a_feed.rb @@ -0,0 +1,15 @@+module HasAFeed + extend ActiveSupport::Concern + + included do + + has_many :entities_imported_from_feed...
Move feeds association to HasAFeed concern and check if assoc. exists
diff --git a/net-socket.gemspec b/net-socket.gemspec index abc1234..def5678 100644 --- a/net-socket.gemspec +++ b/net-socket.gemspec @@ -11,7 +11,7 @@ spec.summary = %q{A better socket API.} spec.description = spec.summary - spec.homepage = "https://github.com/heresy/net-socket" + spec.homepage ...
Fix homepage URL in gemspec.
diff --git a/app/models/key/fingerprint.rb b/app/models/key/fingerprint.rb index abc1234..def5678 100644 --- a/app/models/key/fingerprint.rb +++ b/app/models/key/fingerprint.rb @@ -30,7 +30,7 @@ self.fingerprint = match.gsub(":","") end rescue Subprocess::Error => e - errors[:key] << e.output.split("\n...
Delete whitespace to fix test.
diff --git a/Casks/a-better-finder-rename-beta.rb b/Casks/a-better-finder-rename-beta.rb index abc1234..def5678 100644 --- a/Casks/a-better-finder-rename-beta.rb +++ b/Casks/a-better-finder-rename-beta.rb @@ -0,0 +1,15 @@+cask :v1 => 'a-better-finder-rename-beta' do + version '10' + sha256 'df4208eb01c25434b5c93c65ae...
Add A Better Finder Rename 10.app beta
diff --git a/noodall-ui.gemspec b/noodall-ui.gemspec index abc1234..def5678 100644 --- a/noodall-ui.gemspec +++ b/noodall-ui.gemspec @@ -15,7 +15,7 @@ s.required_rubygems_version = ">= 1.3.6" s.add_dependency 'noodall-core', ">= 0.7.2" - s.add_dependency 'thoughtbot-sortable_table', "0.0.6" + s.add_dependency ...
Fix up gemspec again grrr
diff --git a/WhiteLabel.podspec b/WhiteLabel.podspec index abc1234..def5678 100644 --- a/WhiteLabel.podspec +++ b/WhiteLabel.podspec @@ -12,8 +12,8 @@ s.source = { :git => 'https://github.com/White-Label/Swift-SDK.git', :tag => s.version.to_s } s.ios.deployment_target = '10.0' - s.osx.deployment_targe...
Remove support for macOS and tvOS.
diff --git a/MockInject.podspec b/MockInject.podspec index abc1234..def5678 100644 --- a/MockInject.podspec +++ b/MockInject.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "MockInject" - s.version = "1.0.0" + s.version = "1.0.1" s.summary = "A library that allows developers to glob...
Update Podspec for new minor version
diff --git a/snapme.gemspec b/snapme.gemspec index abc1234..def5678 100644 --- a/snapme.gemspec +++ b/snapme.gemspec @@ -7,8 +7,8 @@ gem.version = Snapme::Version gem.authors = ['Jay Hayes'] gem.email = ['ur@iamvery.com'] - gem.description = %q{} - gem.summary = %q{} + gem.descrip...
Add description and summary to gemspec
diff --git a/vagrant-bindfs.gemspec b/vagrant-bindfs.gemspec index abc1234..def5678 100644 --- a/vagrant-bindfs.gemspec +++ b/vagrant-bindfs.gemspec @@ -11,7 +11,7 @@ s.summary = "A Vagrant plugin to automate bindfs mount in the VM" s.description = "A Vagrant plugin to automate bindfs mount in the VM. This all...
Update gemspec to require Vagrant 0.9.4+
diff --git a/lib/georgia.rb b/lib/georgia.rb index abc1234..def5678 100644 --- a/lib/georgia.rb +++ b/lib/georgia.rb @@ -27,12 +27,19 @@ mattr_accessor :roles @@roles = %w(admin editor contributor guest) - def self.setup - yield self - end - class << self alias :header :navigation + + def setup +...
Verify that Georgia roles have been created
diff --git a/conjure.gemspec b/conjure.gemspec index abc1234..def5678 100644 --- a/conjure.gemspec +++ b/conjure.gemspec @@ -17,7 +17,7 @@ s.add_dependency "thor" s.add_dependency "unf" s.add_development_dependency "guard-rspec" - s.add_development_dependency "rspec", ">= 3.0.0.beta2" + s.add_development_depe...
Update RSpec version for development
diff --git a/weather_hacker.gemspec b/weather_hacker.gemspec index abc1234..def5678 100644 --- a/weather_hacker.gemspec +++ b/weather_hacker.gemspec @@ -4,9 +4,9 @@ Gem::Specification.new do |gem| gem.authors = ["Ryo NAKAMURA"] gem.email = ["r7kamura@gmail.com"] - gem.description = %q{TODO: Write...
Write simple description in gemspec
diff --git a/spec/support/db.rb b/spec/support/db.rb index abc1234..def5678 100644 --- a/spec/support/db.rb +++ b/spec/support/db.rb @@ -1,4 +1,4 @@-require 'lib/generators/social_stream/templates/migration' +require File.join(Rails.root, '../../lib/generators/social_stream/templates/migration') CreateSocialStream.up ...
Fix tests for Ruby 1.9
diff --git a/spec/summary_generation_spec.rb b/spec/summary_generation_spec.rb index abc1234..def5678 100644 --- a/spec/summary_generation_spec.rb +++ b/spec/summary_generation_spec.rb @@ -1,25 +1,30 @@-require 'spec_helper' +require "spec_helper" +require_relative "../lib/active_record_record/summary_generation" -de...
Add spec for clearing the ar counts
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -14,6 +14,11 @@ config.expect_with :rspec do |c| c.syntax = :expect end + + unless ENV["CI"] + config.filter_run focus: true + config.run_all_when_everything_filte...
Allow focus for specs when not on CI
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,2 +1,4 @@ require "lita-ascii-art" require "lita/rspec" + +Lita.version_3_compatibility_mode = false
spec: Disable Lita 3 compatibility mode
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -17,6 +17,12 @@ require 'support/stub_fog_interface.rb' require 'support/integration_helper' +RSpec.configure do |config| + config.expect_with :rspec do |c| + c.syntax = :ex...
Disable `should` syntax in Rspec `should` syntax is deprecated as of Rspec version 3.0 and the previous commit converts all of our tests to use `expect` for consistency. To prevent regressions, this change disables `should` syntax for this gem.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,6 +3,9 @@ require 'failsafe' +class MockFailureBackend < Failsafe::Backends::Base +end + RSpec.configure do |config| config.mock_with :mocha config.after { Failsafe.e...
Add MockFailureBackend for test mode
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,5 @@ RSpec.configure do |config| - config.around(:each) { |example| Timeout.timeout(1, &example) } + config.around(:each) { |example| Timeout.timeout(0.5, &example) } en...
Reduce test timeout to 0.5 seconds Have tests time out after half the time, especially now that rspec-eventually is out of the picture and we don't have polling going on.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,5 +3,13 @@ require 'rubygems' require 'yajl' -require 'active_support/core_ext/kernel/reporting' require 'date' + +module Kernel + def silence_warnings + old_verbose, $V...
Reimplement the single function used by activesupport. Instead of adding a test dependency over activesupport, rewrite the same function here. The dependency over activesupport would be way exaggerated for just this.
diff --git a/config/initializers/01_env.rb b/config/initializers/01_env.rb index abc1234..def5678 100644 --- a/config/initializers/01_env.rb +++ b/config/initializers/01_env.rb @@ -1,4 +1,4 @@-Confy::Config.env(ENV['CONFY_URL']) if ENV['CONFY_URL'] +# Confy::Config.env(ENV['CONFY_URL']) if ENV['CONFY_URL'] module He...
Remove confy until we sync env vars
diff --git a/lib/travis/log_subscriber/active_record_metrics.rb b/lib/travis/log_subscriber/active_record_metrics.rb index abc1234..def5678 100644 --- a/lib/travis/log_subscriber/active_record_metrics.rb +++ b/lib/travis/log_subscriber/active_record_metrics.rb @@ -2,8 +2,8 @@ module LogSubscriber class ActiveRec...
Use the event's payload to get the proper values.
diff --git a/oauth2.gemspec b/oauth2.gemspec index abc1234..def5678 100644 --- a/oauth2.gemspec +++ b/oauth2.gemspec @@ -0,0 +1,40 @@+# coding: utf-8 + +lib = File.expand_path('../lib', __FILE__) +$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) +require 'oauth2/version' + +Gem::Specification.new do |spec| + sp...
Upgrade rake to version 12.3.1
diff --git a/Formula/php54-pspell.rb b/Formula/php54-pspell.rb index abc1234..def5678 100644 --- a/Formula/php54-pspell.rb +++ b/Formula/php54-pspell.rb @@ -10,7 +10,7 @@ depends_on 'aspell' def install - Dir.chdir "ext/pcntl" + Dir.chdir "ext/pspell" # See https://github.com/mxcl/homebrew/pull/5947...
Fix pspell module for PHP 5.4 (wrong build path)
diff --git a/lib/base.rb b/lib/base.rb index abc1234..def5678 100644 --- a/lib/base.rb +++ b/lib/base.rb @@ -13,8 +13,13 @@ raise PageObjectMissingPath, "You need to override this" end + def prefix + '' + end + def visit - source.visit path + source.visit prefix + path + self...
Allow a prefix for paths
diff --git a/Library/Formula/solr.rb b/Library/Formula/solr.rb index abc1234..def5678 100644 --- a/Library/Formula/solr.rb +++ b/Library/Formula/solr.rb @@ -1,9 +1,9 @@ require 'formula' class Solr < Formula - url 'ftp://ftp.fu-berlin.de/unix/www/apache/lucene/solr/1.4.1/apache-solr-1.4.1.tgz' + url 'ftp://ftp.fu-...
Update Solr Formula to 3.1.0 Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/app/controllers/sources_controller.rb b/app/controllers/sources_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sources_controller.rb +++ b/app/controllers/sources_controller.rb @@ -32,7 +32,7 @@ client = DropboxClient.new(@user.dropbox_token) make_dropbox_folder("/this-week", clien...
Update on user folder creation.
diff --git a/app/graphql/scalar_types/date_time.rb b/app/graphql/scalar_types/date_time.rb index abc1234..def5678 100644 --- a/app/graphql/scalar_types/date_time.rb +++ b/app/graphql/scalar_types/date_time.rb @@ -3,6 +3,6 @@ ScalarTypes::DateTime = GraphQL::ScalarType.define do name "DateTime" - coerce_input ->(v...
Fix deprecation warning in coerce_input/coerce_result
diff --git a/app/groonga/post_search_result_set.rb b/app/groonga/post_search_result_set.rb index abc1234..def5678 100644 --- a/app/groonga/post_search_result_set.rb +++ b/app/groonga/post_search_result_set.rb @@ -16,7 +16,7 @@ end def posts - @posts ||= @site.posts.includes(credits: [:participant]).published....
Include category to fix N+1 problem for search result set The following queries are run: Category Load (0.1ms) SELECT "categories".* FROM "categories" WHERE "categories"."id" = $1 LIMIT 1 [ ["id", 2]] Rendered posts/_summary.html.haml (11.7ms) Category Load (0.1ms) SELECT "categories".* FROM ...
diff --git a/app/mailers/spree/gift_card_mailer.rb b/app/mailers/spree/gift_card_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/spree/gift_card_mailer.rb +++ b/app/mailers/spree/gift_card_mailer.rb @@ -2,8 +2,11 @@ def gift_card_email(gift_card) @gift_card = gift_card.respond_to?(:id) ? gift_card : Sp...
Remove usage of Spree::Store.current from GiftCardMailer
diff --git a/app/serializers/service_serializer.rb b/app/serializers/service_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/service_serializer.rb +++ b/app/serializers/service_serializer.rb @@ -1,5 +1,5 @@ class ServiceSerializer < ActiveModel::Serializer - attributes :name, :command, :cpu, :memory,...
Add port_mappings to service serializer
diff --git a/app/services/credentials_validator.rb b/app/services/credentials_validator.rb index abc1234..def5678 100644 --- a/app/services/credentials_validator.rb +++ b/app/services/credentials_validator.rb @@ -27,11 +27,21 @@ if user return user else - errors.add(:username_or_password, "...
Use translations for error messages, which requires hacking into ActiveModel::Validations a bit. See http://yehudakatz.com/2010/01/10/activemodel-make-any-ruby-object-feel-like-activerecord/ for an explanation of read_attribute_for_validation [#28089551]
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,4 +1,17 @@ class User < ActiveRecord::Base + VALID_INSTITUTION_CODES = Institutions.institutions.keys.map(&:to_s) + devise :omniauthable, omniauth_providers: [:nyulibraries] +...
Add validation for institution codes and make institution code
diff --git a/app/workers/inbound_mail_processor.rb b/app/workers/inbound_mail_processor.rb index abc1234..def5678 100644 --- a/app/workers/inbound_mail_processor.rb +++ b/app/workers/inbound_mail_processor.rb @@ -6,9 +6,10 @@ def self.perform(mail_id) mail = InboundMail.find(mail_id) to_address = mail.messa...
Stop logging emails without valid tokens This is filling the resque logs
diff --git a/dill.gemspec b/dill.gemspec index abc1234..def5678 100644 --- a/dill.gemspec +++ b/dill.gemspec @@ -25,4 +25,5 @@ s.add_development_dependency 'sinatra' s.add_development_dependency 'capybara-webkit', '~> 1.0.0' s.add_development_dependency 'poltergeist', '~> 1.3.0' + s.add_development_dependency ...
Add cucumber as a development dependency.
diff --git a/spec/models/ability/user_group_ability_spec.rb b/spec/models/ability/user_group_ability_spec.rb index abc1234..def5678 100644 --- a/spec/models/ability/user_group_ability_spec.rb +++ b/spec/models/ability/user_group_ability_spec.rb @@ -0,0 +1,26 @@+# frozen_string_literal: true + +# Tests for abilities rel...
10173: Add basic test for existing UserGroup abilities
diff --git a/spec/unit/puppet/type/zabbix_hostgroup_spec.rb b/spec/unit/puppet/type/zabbix_hostgroup_spec.rb index abc1234..def5678 100644 --- a/spec/unit/puppet/type/zabbix_hostgroup_spec.rb +++ b/spec/unit/puppet/type/zabbix_hostgroup_spec.rb @@ -0,0 +1,11 @@+require 'spec_helper' + +describe Puppet::Type.type(:zabbi...
Add unit test for zabbix_hostgroup type Really basic test to make sure type has expected parameters.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -19,6 +19,18 @@ require "phone" require "minitest/autorun" +class Minitest::Test + def setup + Phoner::Phone.default_country_code = nil + Phoner::Phone.default_area_code = nil + end + + de...
Update Minitest::Test class with setup and teardown Protect our test runs from tests that manipulate the class methods and don't reset them.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -18,5 +18,7 @@ require 'sklik-api' require './test/fake_web' +SklikApi.logger = Logger.new('log/sklik_api_test.log') + class Test::Unit::TestCase end
[FIX] Send test logger output to log/sklik_api_test.log
diff --git a/db/migrate/20161107191141_remove_is_done_from_report_uploads_and_update_submitted_timestamps.rb b/db/migrate/20161107191141_remove_is_done_from_report_uploads_and_update_submitted_timestamps.rb index abc1234..def5678 100644 --- a/db/migrate/20161107191141_remove_is_done_from_report_uploads_and_update_submi...
Add migration to update submitted timestampss
diff --git a/actionpack/test/ts_isolated.rb b/actionpack/test/ts_isolated.rb index abc1234..def5678 100644 --- a/actionpack/test/ts_isolated.rb +++ b/actionpack/test/ts_isolated.rb @@ -1,3 +1,4 @@+$:.unshift(File.dirname(__FILE__)) $:.unshift(File.dirname(__FILE__) + '/../../activesupport/lib') require 'test/unit'
Add test path to LOAD_PATH to fix load error
diff --git a/app/helpers/ezborrow_helper.rb b/app/helpers/ezborrow_helper.rb index abc1234..def5678 100644 --- a/app/helpers/ezborrow_helper.rb +++ b/app/helpers/ezborrow_helper.rb @@ -5,7 +5,7 @@ def ezborrow_url(holding) @ezborrow_url ||= - "#{HoldingRequestsController::EZBORROW_BASE_URL}/ezborrow?query...
Change ezborrow search to known title search
diff --git a/app/lib/adhesion/exceptions.rb b/app/lib/adhesion/exceptions.rb index abc1234..def5678 100644 --- a/app/lib/adhesion/exceptions.rb +++ b/app/lib/adhesion/exceptions.rb @@ -17,5 +17,11 @@ super(msg) end end + + class ConcludeEnrollment < StandardError + def initialize(msg = "Unab...
Add error for being unable to conclude enrollment for Course Completion tool
diff --git a/recipes/cleanup.rb b/recipes/cleanup.rb index abc1234..def5678 100644 --- a/recipes/cleanup.rb +++ b/recipes/cleanup.rb @@ -3,7 +3,7 @@ remove_file "public/index.html" remove_file "public/images/rails.png" remove_file "config/database.yml" -append_file '.gitignore', "config/database.yml\nvendor/ruby" +ap...
Add proper newline after gitignore-ing vendored gems
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -12,6 +12,7 @@ application app_path do javascript "4" environment.update("PORT" => "80") + environment.update(app["environment"]) git app_path do repository app["app_s...
Support OpsWorks app environment variables Pass environment variables from OpsWorks to the upstart job, so the application may pick it up. Restart is necessary to make upstart re-read the config, so changes take effect.
diff --git a/db/migrate/20181026095008_unique_constraints_on_platforms_sections_and_datasets.data_uploader.rb b/db/migrate/20181026095008_unique_constraints_on_platforms_sections_and_datasets.data_uploader.rb index abc1234..def5678 100644 --- a/db/migrate/20181026095008_unique_constraints_on_platforms_sections_and_data...
Update migrations to avoid crashing if constants already exist
diff --git a/app/admin/optional_module.rb b/app/admin/optional_module.rb index abc1234..def5678 100644 --- a/app/admin/optional_module.rb +++ b/app/admin/optional_module.rb @@ -36,4 +36,17 @@ f.actions end + + # + # == Controller + # + controller do + def update + if params[:optional_module][:name]...
Remove adult_validated cookie when Adult OptionalModule is disabled
diff --git a/app/models/page.rb b/app/models/page.rb index abc1234..def5678 100644 --- a/app/models/page.rb +++ b/app/models/page.rb @@ -23,7 +23,7 @@ end def self.update_visuals - Page.where(visual_url: nil).find_each do |page| + Page.where(visual_url: nil).order('created_at DESC').each do |page| b...
Update Page::update_visuals: update in recent order
diff --git a/app/models/post.rb b/app/models/post.rb index abc1234..def5678 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -38,6 +38,7 @@ end def create_tags_from_description + tags.clear @tags_list.each do |tag_title| if not tags.exists?({title: tag_title}) tags.create!({tit...
Clear tags before updating them
diff --git a/app/models/site.rb b/app/models/site.rb index abc1234..def5678 100644 --- a/app/models/site.rb +++ b/app/models/site.rb @@ -1,3 +1,5 @@ class Site < ApplicationRecord - has_many :bookmarks + has_many :bookmarks, dependent: :destroy + + after_touch :destroy, if: -> { bookmarks.empty? } end
Destroy Site when has no bookmarks
diff --git a/spec/rover_spec.rb b/spec/rover_spec.rb index abc1234..def5678 100644 --- a/spec/rover_spec.rb +++ b/spec/rover_spec.rb @@ -6,4 +6,9 @@ it "creates a curiosity rover" do expect(rover.name).to eq("curiosity") end + + it "retrieves the photos for a rover when give sol" do + sol = 1000 + expect(rover....
Add rspec to check the get method for Rover class
diff --git a/horsefield.gemspec b/horsefield.gemspec index abc1234..def5678 100644 --- a/horsefield.gemspec +++ b/horsefield.gemspec @@ -15,7 +15,7 @@ spec.files = `git ls-files -z`.split("\x0") spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } - spec.test_files = spec.files.gr...
Add lib to list of spec files
diff --git a/OpenWebRTC.podspec b/OpenWebRTC.podspec index abc1234..def5678 100644 --- a/OpenWebRTC.podspec +++ b/OpenWebRTC.podspec @@ -4,8 +4,8 @@ s.summary = "SDK for adding WebRTC to your app through OpenWebRTC" s.homepage = "http://www.openwebrtc.io" s.license = { :type => "BSD-2", :file => "...
Change author and platform req
diff --git a/HTAutocompleteTextField.podspec b/HTAutocompleteTextField.podspec index abc1234..def5678 100644 --- a/HTAutocompleteTextField.podspec +++ b/HTAutocompleteTextField.podspec @@ -1,12 +1,13 @@ Pod::Spec.new do |s| s.name = "HTAutocompleteTextField" - s.version = "1.0.0" + s.version = "1...
Bump podspec version to 1.0.1 Increment version and add iOS deployment target version.
diff --git a/Library/Homebrew/extend/os/linux/formula.rb b/Library/Homebrew/extend/os/linux/formula.rb index abc1234..def5678 100644 --- a/Library/Homebrew/extend/os/linux/formula.rb +++ b/Library/Homebrew/extend/os/linux/formula.rb @@ -15,9 +15,10 @@ # Ex. 1: "libONE.so.1" # Ex. 2: %r{(libONE|li...
Fix style (Convert if-elsif to case-when)