diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -5,6 +5,11 @@ before_filter :find_page before_filter :set_host + def index + @page.selected_c...
Hide unapproved comments from url guessers and/or spiders.
diff --git a/app/controllers/services_controller.rb b/app/controllers/services_controller.rb index abc1234..def5678 100644 --- a/app/controllers/services_controller.rb +++ b/app/controllers/services_controller.rb @@ -1,6 +1,7 @@ class ServicesController < ApplicationController include ApplicationHelper + before...
Add "Vary: *" header to request_country to prevent it being cached for all users by varnish.
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -7,14 +7,7 @@ if user session[:user_id] = user.id - - if session[:return_to] - ...
Use hash delete to shorten login return to logic.
diff --git a/lib/tasks/export_trade_db.rake b/lib/tasks/export_trade_db.rake index abc1234..def5678 100644 --- a/lib/tasks/export_trade_db.rake +++ b/lib/tasks/export_trade_db.rake @@ -0,0 +1,49 @@+require 'zip' +require 'fileutils' +namespace :export do + task :trade_db => :environment do + RECORDS_PER_FILE = 5000...
Add rake task to export the entire trade db in csv files and then zipped
diff --git a/lib/three_dee_cart/core_ext.rb b/lib/three_dee_cart/core_ext.rb index abc1234..def5678 100644 --- a/lib/three_dee_cart/core_ext.rb +++ b/lib/three_dee_cart/core_ext.rb @@ -1,13 +1,4 @@ class Hash - - def reverse_merge(other_hash = {}) - other_hash.each_pair do |k, v| - unless self.has_key?(k) - ...
Remove monkey patched method from Hash
diff --git a/lib/weak_headers/controller.rb b/lib/weak_headers/controller.rb index abc1234..def5678 100644 --- a/lib/weak_headers/controller.rb +++ b/lib/weak_headers/controller.rb @@ -4,7 +4,7 @@ filter_options = {} filter_options.merge!(only: args.flatten) unless args.empty? - before_filter filter...
Use before_action instead of before_filter DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1
diff --git a/lib/workflowmgr/cycleformat.rb b/lib/workflowmgr/cycleformat.rb index abc1234..def5678 100644 --- a/lib/workflowmgr/cycleformat.rb +++ b/lib/workflowmgr/cycleformat.rb @@ -0,0 +1,40 @@+########################################## +# +# Module WorkflowMgr +# +########################################## +module...
Add new class to represent dynamic strings whose values are evaluated based on the provided cycle time.
diff --git a/app/admin/report.rb b/app/admin/report.rb index abc1234..def5678 100644 --- a/app/admin/report.rb +++ b/app/admin/report.rb @@ -15,7 +15,8 @@ index do selectable_column id_column - column 'Picture', sortable: :image_file_name do |report| link_to report.picture.name, report.image.url end + ...
Replace all apparitions of image with picture.
diff --git a/app/app_delegate.rb b/app/app_delegate.rb index abc1234..def5678 100644 --- a/app/app_delegate.rb +++ b/app/app_delegate.rb @@ -1,5 +1,5 @@ class AppDelegate - attr_accessor :van_hoorden_sounds, :miller_and_heise_sounds, :window + attr_accessor :van_hoorden_sounds, :miller_and_heise_sounds, :window, :sub...
Add subject field to app delegate
diff --git a/half-pipe.gemspec b/half-pipe.gemspec index abc1234..def5678 100644 --- a/half-pipe.gemspec +++ b/half-pipe.gemspec @@ -16,4 +16,6 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] ...
Add asset compiler as gem dependency
diff --git a/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_http_spec.rb b/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_http_spec.rb index abc1234..def5678 100644 --- a/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_http_spec.rb +++ b/qa/qa/specs/featu...
Add e2e test of push via HTTP via Git protocol v2 Adds a new end-to-end test to check that Git protocol v2 can be used to push over HTTP
diff --git a/lib/pod/command/package.rb b/lib/pod/command/package.rb index abc1234..def5678 100644 --- a/lib/pod/command/package.rb +++ b/lib/pod/command/package.rb @@ -6,6 +6,8 @@ def initialize(argv) @name = argv.shift_argument + @spec = spec_with_path(@name) + @spec = spec_with_name(@n...
Make it actually run without errors. Now the magic can be implemented :)
diff --git a/AHKNavigationController.podspec b/AHKNavigationController.podspec index abc1234..def5678 100644 --- a/AHKNavigationController.podspec +++ b/AHKNavigationController.podspec @@ -3,7 +3,7 @@ s.version = "0.1.1" s.summary = "A UINavigationController replacement allowing interactive pop gesture w...
Change the homepage in the Podfile to github
diff --git a/lib/opskit/vhost.rb b/lib/opskit/vhost.rb index abc1234..def5678 100644 --- a/lib/opskit/vhost.rb +++ b/lib/opskit/vhost.rb @@ -1,6 +1,8 @@ module OpsKit class VHost PROVIDERS = [:apache, :nginx] + + attr_reader :provider, :conf def initialize( provider = nil, conf = {} ) @provider...
Add getters for VHost instance variables
diff --git a/lib/speedcounter.rb b/lib/speedcounter.rb index abc1234..def5678 100644 --- a/lib/speedcounter.rb +++ b/lib/speedcounter.rb @@ -2,7 +2,7 @@ def initialize(window, player) @window, @player = window, player - @speed_text = Gosu::Font.new(@window, 'media/poke.ttf', 16) + @speed_text = Gosu::Font.new(@...
Update position text to 18px high
diff --git a/config/initializers/active_record_data_types.rb b/config/initializers/active_record_data_types.rb index abc1234..def5678 100644 --- a/config/initializers/active_record_data_types.rb +++ b/config/initializers/active_record_data_types.rb @@ -4,12 +4,43 @@ if Gitlab::Database.postgresql? require 'active_re...
Fix PostgreSQL schema dump for `timestamptz`
diff --git a/lib/tasks/application.rake b/lib/tasks/application.rake index abc1234..def5678 100644 --- a/lib/tasks/application.rake +++ b/lib/tasks/application.rake @@ -10,3 +10,32 @@ CampaignFinisherWorker.perform_async(project.id) end end + +desc 'Import data from YAML file for new users/projects/rewards' +ta...
Create rake task to import users/projects/rewards
diff --git a/lib/wptemplates/regexes.rb b/lib/wptemplates/regexes.rb index abc1234..def5678 100644 --- a/lib/wptemplates/regexes.rb +++ b/lib/wptemplates/regexes.rb @@ -35,9 +35,9 @@ \[\[ (?<link> # ([% title-legal-chars])+ - [%!"$&'()*,\-.\/0-9:;=?@A-Z\\^_`a-z~\u0080-\uFFFF+]...
Fix a_link regex would not accept spaces in links
diff --git a/app/models/email.rb b/app/models/email.rb index abc1234..def5678 100644 --- a/app/models/email.rb +++ b/app/models/email.rb @@ -1,11 +1,6 @@ class Email include HTTParty - - APIKEY = Setting.get(:email, :mailgunapikey) - - base_uri 'https://api.mailgun.net/v2' - basic_auth 'api', APIKEY def se...
Move Mailgun apikey out of class def. Fixes bug running tests some times.
diff --git a/app/helpers/versions_helper.rb b/app/helpers/versions_helper.rb index abc1234..def5678 100644 --- a/app/helpers/versions_helper.rb +++ b/app/helpers/versions_helper.rb @@ -11,6 +11,8 @@ 'Switched mapping to a Redirect' when 'archive' 'Switched mapping to an Archive' + when 'unresolved'...
Add a specific message for changing a mapping type to unresolved
diff --git a/app/helpers/writable_helper.rb b/app/helpers/writable_helper.rb index abc1234..def5678 100644 --- a/app/helpers/writable_helper.rb +++ b/app/helpers/writable_helper.rb @@ -9,6 +9,6 @@ @post end return (@unread_warning = false) unless unread_reply - @unread_warning = content_tag :a, 'Post...
Make the 'unread replies' link of the reply editor have target=_blank
diff --git a/libraries/helper.rb b/libraries/helper.rb index abc1234..def5678 100644 --- a/libraries/helper.rb +++ b/libraries/helper.rb @@ -19,7 +19,9 @@ # limitations under the License. # -require 'chef/win32/version' +if RUBY_PLATFORM =~ /mswin|mingw32|windows/ + require 'chef/win32/version' +end module Opsco...
[COOK-4138] Check for RUBY_VERSION of Windows before attempting to require chef/win32/version.
diff --git a/db/migrate/20090316132151_disable_file_types.rb b/db/migrate/20090316132151_disable_file_types.rb index abc1234..def5678 100644 --- a/db/migrate/20090316132151_disable_file_types.rb +++ b/db/migrate/20090316132151_disable_file_types.rb @@ -3,7 +3,7 @@ Radiant::Config['assets.skip_filetype_validation'] ...
Fix migration by prefixing the Config module with Radiant Signed-off-by: Keith BIngman <keith@keithbingman.com> Signed-off-by: Aissac SRL <ef29f82a68bbcac28aaf4f4f019e2bfc7b150e76@aissac.ro>
diff --git a/db/migrate/20130621223337_create_flash_sales.rb b/db/migrate/20130621223337_create_flash_sales.rb index abc1234..def5678 100644 --- a/db/migrate/20130621223337_create_flash_sales.rb +++ b/db/migrate/20130621223337_create_flash_sales.rb @@ -4,7 +4,7 @@ t.string :name t.datetime :start_date ...
Revert "make default value false" This reverts commit 366a8ba9c3a527e67a26b7d7068a9cc844297d16.
diff --git a/loudspeaker.podspec b/loudspeaker.podspec index abc1234..def5678 100644 --- a/loudspeaker.podspec +++ b/loudspeaker.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "loudspeaker" - s.version = "0.1.11" + s.version = "0.2.0" s.summary = "An AVQueuePlayer-b...
Bump podspec to 0.2.0 after dropping iOS 7
diff --git a/spec/i18n/locale_name_spec.rb b/spec/i18n/locale_name_spec.rb index abc1234..def5678 100644 --- a/spec/i18n/locale_name_spec.rb +++ b/spec/i18n/locale_name_spec.rb @@ -10,9 +10,21 @@ end it "all entries in human_locale_names.yml are valid" do - YAML.load_file(Rails.root.join('config/human_locale_...
Test that all locales have properly set human locale name
diff --git a/db/migrate/20171024074942_convert_autograded_text_response_answers_to_plaintext.rb b/db/migrate/20171024074942_convert_autograded_text_response_answers_to_plaintext.rb index abc1234..def5678 100644 --- a/db/migrate/20171024074942_convert_autograded_text_response_answers_to_plaintext.rb +++ b/db/migrate/201...
Convert answers for autograded text response questions to plaintext. Raise error on rollback as the formatting can't be restored. Previously stored as HTML due to richtext input.
diff --git a/spec/integration/renalware/api/ukrdc/patients_spec.rb b/spec/integration/renalware/api/ukrdc/patients_spec.rb index abc1234..def5678 100644 --- a/spec/integration/renalware/api/ukrdc/patients_spec.rb +++ b/spec/integration/renalware/api/ukrdc/patients_spec.rb @@ -10,6 +10,7 @@ describe "GET #show" do ...
Mark ukrdc spec as pending for now
diff --git a/AFMobilePayRequestHandler.podspec b/AFMobilePayRequestHandler.podspec index abc1234..def5678 100644 --- a/AFMobilePayRequestHandler.podspec +++ b/AFMobilePayRequestHandler.podspec @@ -6,7 +6,7 @@ s.license = 'MIT' s.author = { 'Anders Fogh Eriksen' => 'andfogh@gmail.com' } s.source ...
Update platform version to 7.0
diff --git a/Library/Homebrew/tap_migrations.rb b/Library/Homebrew/tap_migrations.rb index abc1234..def5678 100644 --- a/Library/Homebrew/tap_migrations.rb +++ b/Library/Homebrew/tap_migrations.rb @@ -19,4 +19,5 @@ 'nlopt' => 'homebrew/science', 'comparepdf' => 'homebrew/boneyard', 'colormake' => 'homebrew/head...
Move wkhtmltopdf to the boneyard Closes Homebrew/homebrew#26813.
diff --git a/resources/ingredient_config.rb b/resources/ingredient_config.rb index abc1234..def5678 100644 --- a/resources/ingredient_config.rb +++ b/resources/ingredient_config.rb @@ -21,7 +21,6 @@ provides :ingredient_config property :product_name, String, name_property: true -property :sensitive, [TrueClass, Fals...
Remove sensitive property for Chef 13 compatibility This is provided by chef-client on all resources now. Including it here breaks runs on Chef 13 Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/test/schema_test.rb b/test/schema_test.rb index abc1234..def5678 100644 --- a/test/schema_test.rb +++ b/test/schema_test.rb @@ -0,0 +1,69 @@+ +require 'test/helper' +require 'ostruct' + +class MockSchema + include Paperclip::Schema + + def initialize(table_name = nil) + @table_name = table_name + @...
Add a proper test suite of the schema helper
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -3,13 +3,14 @@ require "minitest/autorun" require "minitest/reporters" -require "mocha" +require "mocha/setup" require "support/fake_environment" require "support/captain_ho...
Fix mocha warning and change to default report
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,9 +1,6 @@ require 'rubygems' require 'bundler/setup' require 'mock_redis' -require 'mock_redis/version' require 'minitest/autorun' require 'redis-breadcrumbs' - -puts "moc...
Remove dumping of mock redis version
diff --git a/app/helpers/relations_helper.rb b/app/helpers/relations_helper.rb index abc1234..def5678 100644 --- a/app/helpers/relations_helper.rb +++ b/app/helpers/relations_helper.rb @@ -1,14 +1,7 @@ module RelationsHelper def format_date_for(relation) - if relation.from == relation.to - return "#{relati...
Simplify formatter helper for relation dates
diff --git a/admin/test/integration/api_test.rb b/admin/test/integration/api_test.rb index abc1234..def5678 100644 --- a/admin/test/integration/api_test.rb +++ b/admin/test/integration/api_test.rb @@ -2,20 +2,6 @@ class ApiTest < ActionDispatch::IntegrationTest setup do - @coupons = "{\"coupons\":" + - ...
Fix api test in admin
diff --git a/vtd-xml.gemspec b/vtd-xml.gemspec index abc1234..def5678 100644 --- a/vtd-xml.gemspec +++ b/vtd-xml.gemspec @@ -21,4 +21,5 @@ gem.require_paths = ['lib'] gem.add_development_dependency 'rake' + gem.add_development_dependency 'rspec' end
Add Rspec as a development dependency
diff --git a/les_04/station.rb b/les_04/station.rb index abc1234..def5678 100644 --- a/les_04/station.rb +++ b/les_04/station.rb @@ -33,6 +33,6 @@ end def trains_by_type(type) - self.trains.select.count { |train| train.type if train.type == type} + self.trains.select { |train| train.type if train.type == t...
Fix 'trains by type' counter
diff --git a/omnibus-ctl.gemspec b/omnibus-ctl.gemspec index abc1234..def5678 100644 --- a/omnibus-ctl.gemspec +++ b/omnibus-ctl.gemspec @@ -13,7 +13,7 @@ s.required_ruby_version = ">= 2.6" - s.add_development_dependency "chefstyle", "2.1.0" + s.add_development_dependency "chefstyle", "2.1.1" s.add_developme...
Update chefstyle requirement from = 2.1.0 to = 2.1.1 Updates the requirements on [chefstyle](https://github.com/chef/chefstyle) to permit the latest version. - [Release notes](https://github.com/chef/chefstyle/releases) - [Changelog](https://github.com/chef/chefstyle/blob/main/CHANGELOG.md) - [Commits](https://github....
diff --git a/createDB.rb b/createDB.rb index abc1234..def5678 100644 --- a/createDB.rb +++ b/createDB.rb @@ -1,5 +1,26 @@ #!/usr/bin/env ruby -w require "sqlite3" + +# Open a database +db = SQLite3::Database.new "sqlite3.db" + +# Drop old tables +rows = db.execute <<-SQL + DROP TABLE IF EXISTS user; +SQL + +rows = db...
Drop old tables for multiple executions Drop old data, each run makes a new DB.
diff --git a/test/all_basic.rb b/test/all_basic.rb index abc1234..def5678 100644 --- a/test/all_basic.rb +++ b/test/all_basic.rb @@ -31,6 +31,7 @@ require 'Image_attributes.rb' require 'Import_Export.rb' require 'Pixel.rb' +require 'Preview.rb' require 'Info.rb' require 'Magick.rb' require 'Draw.rb'
Add Preview_UT.rb to the standard list of tests
diff --git a/lib/convection/model/template/resource_group.rb b/lib/convection/model/template/resource_group.rb index abc1234..def5678 100644 --- a/lib/convection/model/template/resource_group.rb +++ b/lib/convection/model/template/resource_group.rb @@ -12,8 +12,6 @@ include DSL::Template::Resource incl...
Remove the :attributes from ResourceGroup Users can define attributes inside of resource groups using the attribute helper method.
diff --git a/lib/gir_ffi/builders/registered_type_builder.rb b/lib/gir_ffi/builders/registered_type_builder.rb index abc1234..def5678 100644 --- a/lib/gir_ffi/builders/registered_type_builder.rb +++ b/lib/gir_ffi/builders/registered_type_builder.rb @@ -14,15 +14,19 @@ end # TODO: Rename the created metho...
Store gtype of generated classes in a constant
diff --git a/teamocil.gemspec b/teamocil.gemspec index abc1234..def5678 100644 --- a/teamocil.gemspec +++ b/teamocil.gemspec @@ -7,7 +7,7 @@ s.homepage = "http://github.com/remiprev/teamocil" s.summary = "Easy window and split layouts for tmux" s.description = "Teamocil helps you set up window and spl...
Fix typo in gemspec file
diff --git a/lib/vagrant_syllabus_provisioner/provisioner.rb b/lib/vagrant_syllabus_provisioner/provisioner.rb index abc1234..def5678 100644 --- a/lib/vagrant_syllabus_provisioner/provisioner.rb +++ b/lib/vagrant_syllabus_provisioner/provisioner.rb @@ -7,10 +7,6 @@ def error_message "Execution failed. Ab...
Remove unnecessary method from Provisioner.
diff --git a/app/controllers/logs_controller.rb b/app/controllers/logs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/logs_controller.rb +++ b/app/controllers/logs_controller.rb @@ -1,13 +1,10 @@ class LogsController < ApplicationController + before_action :setup_variables, only: [:new, :create] + ...
Reduce complexity of the create method
diff --git a/app/controllers/main_controller.rb b/app/controllers/main_controller.rb index abc1234..def5678 100644 --- a/app/controllers/main_controller.rb +++ b/app/controllers/main_controller.rb @@ -1,7 +1,7 @@ class MainController < ApplicationController def index @components = Component.all.is_approved.by_ag...
Add a default Prompt in order to not break the database if there aren't any prompts
diff --git a/app/jobs/extract_github_profile.rb b/app/jobs/extract_github_profile.rb index abc1234..def5678 100644 --- a/app/jobs/extract_github_profile.rb +++ b/app/jobs/extract_github_profile.rb @@ -5,7 +5,7 @@ def perform(id) client = Octokit::Client.new - if ENV['TRAVIS'].blank? || client.ratelimit[:re...
[Fix] Fix profile job for travis
diff --git a/app/models/concerns/redcarpeted.rb b/app/models/concerns/redcarpeted.rb index abc1234..def5678 100644 --- a/app/models/concerns/redcarpeted.rb +++ b/app/models/concerns/redcarpeted.rb @@ -1,21 +1,48 @@ module Redcarpeted extend ActiveSupport::Concern - - class HTMLRenderer < Redcarpet::Render::HTML - ...
Refactor Redcarpeted concern, adds support for custom Markdown for <figure> element.
diff --git a/pdf_ravager.gemspec b/pdf_ravager.gemspec index abc1234..def5678 100644 --- a/pdf_ravager.gemspec +++ b/pdf_ravager.gemspec @@ -10,7 +10,6 @@ s.summary = %q{DSL to aid filling out AcroForms PDF and XFA documents} s.description = %q{DSL to aid filling out AcroForms PDF and XFA documents} s.licen...
Remove platform=java from .gemspec so RubyGems updates properly
diff --git a/app/models/query.rb b/app/models/query.rb index abc1234..def5678 100644 --- a/app/models/query.rb +++ b/app/models/query.rb @@ -6,21 +6,33 @@ FORMATS = ['article', 'book', 'other'] PUBLICATION_YEARS = [-1, 0, 1] + ACCESS = ['dtu'] - def self.common_filter_query + # Params: ...
Add options to adjust the common filter queries
diff --git a/test/st_errors.rb b/test/st_errors.rb index abc1234..def5678 100644 --- a/test/st_errors.rb +++ b/test/st_errors.rb @@ -50,7 +50,7 @@ assert_not_nil @response.body.index( '<errors count="1">') assert_not_nil @response.body.index( - '<message>pexp : no participant named "tonto"</message...
Test adapted to new quoting style for errors
diff --git a/app/models/round.rb b/app/models/round.rb index abc1234..def5678 100644 --- a/app/models/round.rb +++ b/app/models/round.rb @@ -4,8 +4,12 @@ has_many :donations after_initialize do |round| - self.url = SecureRandom.hex(3) - self.expire_time = Time.now + 1.hours + if self.url.nil? + sel...
Update Round attributes in after_initialize only if nil
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -0,0 +1,20 @@+namespace :db do + dump_file = 'tmp/latest.dump' + + def verify_exec(command) + system(command) + fail 'Command failed' unless $CHILD_STATUS.exitstatus.zero? + end +...
Add restore production dump rake task
diff --git a/lib/twitterise.rb b/lib/twitterise.rb index abc1234..def5678 100644 --- a/lib/twitterise.rb +++ b/lib/twitterise.rb @@ -36,7 +36,7 @@ end def save_number_of_followers - repository.save_number_followers(twitter_client.followers.size) + repository.save_number_followers(twitter_client.user.follow...
Save number of followers from user information
diff --git a/test/test_calc.rb b/test/test_calc.rb index abc1234..def5678 100644 --- a/test/test_calc.rb +++ b/test/test_calc.rb @@ -13,4 +13,9 @@ def test_complex_expression assert_equal 10, calc("2 PLUS 5 MINUS 1 PLUS 4") end + + def test_more_complex_expression + skip "not yet" + assert_equal 10, ca...
Add division test. Not implemented.
diff --git a/lib/desktop/osx.rb b/lib/desktop/osx.rb index abc1234..def5678 100644 --- a/lib/desktop/osx.rb +++ b/lib/desktop/osx.rb @@ -0,0 +1,55 @@+require 'sqlite3' + +module Desktop + class OSX + class DesktopImagePermissionsError < StandardError; end + + def self.desktop_image=(image) + self.new.deskto...
Add Desktop::OSX for updating desktops on OSX
diff --git a/ci_environment/couchdb/recipes/ubuntu_ppa.rb b/ci_environment/couchdb/recipes/ubuntu_ppa.rb index abc1234..def5678 100644 --- a/ci_environment/couchdb/recipes/ubuntu_ppa.rb +++ b/ci_environment/couchdb/recipes/ubuntu_ppa.rb @@ -13,13 +13,13 @@ # limitations under the License. # -# https://launchpad.net/...
Use latest stable CouchDB ppa Use CouchDB 1.5
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -16,6 +16,10 @@ on(host, puppet('module', 'install', 'puppetlabs-stdlib')) on(host, puppet('module', 'install', 'stahnma-ep...
Install net-tools for netstat command
diff --git a/app/helpers/markdown_helper.rb b/app/helpers/markdown_helper.rb index abc1234..def5678 100644 --- a/app/helpers/markdown_helper.rb +++ b/app/helpers/markdown_helper.rb @@ -8,7 +8,11 @@ # Render markdown def render_markdown(text) - Redcarpet::Markdown.new(TargetBlankRenderer, autolink: true).rende...
Enable redcarpet fenced code blocks Markdown should format fenced code blocks, so enable this feature in redcarpet.
diff --git a/app/inputs/date_field_input.rb b/app/inputs/date_field_input.rb index abc1234..def5678 100644 --- a/app/inputs/date_field_input.rb +++ b/app/inputs/date_field_input.rb @@ -1,6 +1,7 @@ class DateFieldInput < SimpleForm::Inputs::StringInput def input input_html_options['date-picker'] = true + inpu...
Use input type text instead of default date_field.
diff --git a/db/data_migration/20181002120423_create_publishing_api_drafts_for_scheduled_content.rb b/db/data_migration/20181002120423_create_publishing_api_drafts_for_scheduled_content.rb index abc1234..def5678 100644 --- a/db/data_migration/20181002120423_create_publishing_api_drafts_for_scheduled_content.rb +++ b/db...
Create Publishing API drafts for scheduled content This avoids issues with this content being publishing on schedule, resulting from changing what Whitehall sends to the Publishing API when publishing content. Previously, Whitehall created or updated the draft edition, and then published that, now Whitehall just publi...
diff --git a/app/policies/sponsor_policy.rb b/app/policies/sponsor_policy.rb index abc1234..def5678 100644 --- a/app/policies/sponsor_policy.rb +++ b/app/policies/sponsor_policy.rb @@ -1,4 +1,12 @@ class SponsorPolicy < ApplicationPolicy + + def index? + create? + end + + def show? + create? + end def cr...
Hide sponsors page from !sponsor_admins
diff --git a/spec/defines/interface_spec.rb b/spec/defines/interface_spec.rb index abc1234..def5678 100644 --- a/spec/defines/interface_spec.rb +++ b/spec/defines/interface_spec.rb @@ -1,6 +1,10 @@ require 'spec_helper' describe 'networkmanager::interface' do + let :facts do + { :concat_basedir => '/dne' } + e...
Check if this suggestion solves the error of not defined
diff --git a/spec/identity/identity_spec.rb b/spec/identity/identity_spec.rb index abc1234..def5678 100644 --- a/spec/identity/identity_spec.rb +++ b/spec/identity/identity_spec.rb @@ -15,6 +15,10 @@ it { should be_listening.with('tcp') } end +describe port(35357) do + it { should be_listening.with('tcp') } +end ...
Check admin port is listening
diff --git a/spec/libs/query_parser_spec.rb b/spec/libs/query_parser_spec.rb index abc1234..def5678 100644 --- a/spec/libs/query_parser_spec.rb +++ b/spec/libs/query_parser_spec.rb @@ -0,0 +1,49 @@+require 'spec_helper' +require 'query_parser' + +describe QueryParser do + + include QueryParser + + { + + '10kg of b...
Add spec test for query parser
diff --git a/spec/license_spec.rb b/spec/license_spec.rb index abc1234..def5678 100644 --- a/spec/license_spec.rb +++ b/spec/license_spec.rb @@ -2,7 +2,7 @@ describe DataKitten::License do - describe 'with known licenses' do + describe 'with known license URIs' do known_licenses = { "http://www....
Add new test for license abbreviations
diff --git a/spec/proteus_spec.rb b/spec/proteus_spec.rb index abc1234..def5678 100644 --- a/spec/proteus_spec.rb +++ b/spec/proteus_spec.rb @@ -11,6 +11,6 @@ end it "returns a friendly message if the repo doesn't exist" do - expect(@proteus.new('invalid')).to eq("A thoughtbot repo doesn't exist with that nam...
Use RSpec output matcher to test kit's output
diff --git a/spec/models/spree/page_spec.rb b/spec/models/spree/page_spec.rb index abc1234..def5678 100644 --- a/spec/models/spree/page_spec.rb +++ b/spec/models/spree/page_spec.rb @@ -3,5 +3,9 @@ describe Spree::Page do let(:page) { build :page } subject { page } + it { should be_valid } + it "should be deco...
Add test for decorating functionality
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -25,6 +25,7 @@ puppet_module_install(:source => proj_root, :module_name => 'tdd_puppet_module') hosts.each do |host| on ...
Install dependency for acceptance test
diff --git a/tests/vcr_test.rb b/tests/vcr_test.rb index abc1234..def5678 100644 --- a/tests/vcr_test.rb +++ b/tests/vcr_test.rb @@ -2,41 +2,49 @@ require 'test/unit' require 'vcr' require 'xmlsimple' +require 'uri' require './libraries_west' VCR.configure do |config| + # where do we store fixtures? config.ca...
Refactor cassette name creation into config method
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -1,5 +1,5 @@ require 'rails_helper' -RSpec.describe User, :type => :model do +describe User do pending "add some examples to (or delete) #{__FILE__}" end
Change rspec model syntax for User model spec.
diff --git a/spec/suite_frame_spec.rb b/spec/suite_frame_spec.rb index abc1234..def5678 100644 --- a/spec/suite_frame_spec.rb +++ b/spec/suite_frame_spec.rb @@ -13,7 +13,6 @@ end specify "#{t.property('@id')}: #{t.name} ordered#{' (negative test)' unless t.positiveTest?}" do - pending "Order...
Mark frame/in03 not pending (ordered)
diff --git a/spec/unit/helper_spec.rb b/spec/unit/helper_spec.rb index abc1234..def5678 100644 --- a/spec/unit/helper_spec.rb +++ b/spec/unit/helper_spec.rb @@ -1,6 +1,10 @@ require 'spec_helper' describe Que, 'helpers' do + it "should be able to run arbitrary SQL" do + Que.execute("SELECT 1 AS one").to_a.should...
Add a spec to ensure that Que.execute remains publically available.
diff --git a/integration-tests/apps/alacarte/runtime_jobs/app/jobs/some_module/another_simple_job.rb b/integration-tests/apps/alacarte/runtime_jobs/app/jobs/some_module/another_simple_job.rb index abc1234..def5678 100644 --- a/integration-tests/apps/alacarte/runtime_jobs/app/jobs/some_module/another_simple_job.rb +++ b...
Revert "Proper injection usage in AnotherSimpleJob class" This reverts commit ef91514c3f0e2bab94c8f05fbf6fb7a235e5df67.
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -23,7 +23,6 @@ #config.assets.digest = true config.assets.debug = true - # comment line below in if you want to ...
Allow slimmer asset host to be overriden.
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -5,6 +5,9 @@ # every request. This slows down response time but is perfect for development # since you don't have ...
Make the lib/ directory autoreload
diff --git a/config/initializers/rails_admin.rb b/config/initializers/rails_admin.rb index abc1234..def5678 100644 --- a/config/initializers/rails_admin.rb +++ b/config/initializers/rails_admin.rb @@ -27,7 +27,9 @@ config.actions do dashboard # mandatory index # m...
Hide new action in admin for unapproved projects
diff --git a/usaidwat.gemspec b/usaidwat.gemspec index abc1234..def5678 100644 --- a/usaidwat.gemspec +++ b/usaidwat.gemspec @@ -8,7 +8,7 @@ s.authors = ["Michael Dippery"] s.email = ["michael@monkey-robot.com"] s.homepage = "" - s.summary = %q{View a user's last 100 Reddit comments} + s.summ...
Update gemspec with better summary
diff --git a/config/initializers/scrivito.rb b/config/initializers/scrivito.rb index abc1234..def5678 100644 --- a/config/initializers/scrivito.rb +++ b/config/initializers/scrivito.rb @@ -10,4 +10,14 @@ # Disable the default routes to allow route configuration config.inject_preset_routes = false + + # Basic Au...
Add simple auth with session
diff --git a/app/models/info.rb b/app/models/info.rb index abc1234..def5678 100644 --- a/app/models/info.rb +++ b/app/models/info.rb @@ -4,9 +4,15 @@ validates :user_id, presence: true - default_scope -> { order(created_at: :desc) } - scope :not_archived, -> { where(archived: false).order(created_at: :desc) } -...
Improve DB calls in scopes
diff --git a/app/models/tone.rb b/app/models/tone.rb index abc1234..def5678 100644 --- a/app/models/tone.rb +++ b/app/models/tone.rb @@ -11,6 +11,14 @@ def play @sound.play + end + + def is_playing? + @sound.isPlaying + end + + def stop + @sound.stop end def type
Add methods to check if playing and stop
diff --git a/mongoid-active_merchant.gemspec b/mongoid-active_merchant.gemspec index abc1234..def5678 100644 --- a/mongoid-active_merchant.gemspec +++ b/mongoid-active_merchant.gemspec @@ -22,7 +22,7 @@ spec.add_dependency 'activemerchant', '>= 1.52' spec.add_development_dependency "bundler", ">= 1.10" - spec.a...
Update rake to fix security vulnerability
diff --git a/app/controllers/user/confirmations_controller.rb b/app/controllers/user/confirmations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/user/confirmations_controller.rb +++ b/app/controllers/user/confirmations_controller.rb @@ -52,6 +52,6 @@ end def get_user_years_of_birth - (18.y...
Adjust year of birth range
diff --git a/singleton/everyday_singleton.rb b/singleton/everyday_singleton.rb index abc1234..def5678 100644 --- a/singleton/everyday_singleton.rb +++ b/singleton/everyday_singleton.rb @@ -9,6 +9,18 @@ class << self def two () 2 end + + <<-DOC + Inside the Foo's body self is Foo. So the above is the sa...
[singleton] Add another way to extend singleton classes
diff --git a/lib/green-button-data.rb b/lib/green-button-data.rb index abc1234..def5678 100644 --- a/lib/green-button-data.rb +++ b/lib/green-button-data.rb @@ -11,7 +11,8 @@ require 'green-button-data/parser/authorization' require 'green-button-data/parser/application_information' require 'green-button-data/parser/s...
Add ReadingType class to requires
diff --git a/cassandra/recipes/ec2snitch.rb b/cassandra/recipes/ec2snitch.rb index abc1234..def5678 100644 --- a/cassandra/recipes/ec2snitch.rb +++ b/cassandra/recipes/ec2snitch.rb @@ -1,13 +1,13 @@ @topo_map = search(:node, "cassandra_cluster_name:#{node[:cassandra][:cluster_name]} AND ec2:placement_availability_zone"...
Split datacenter and area field for EC2 snitch
diff --git a/core/io/pid_spec.rb b/core/io/pid_spec.rb index abc1234..def5678 100644 --- a/core/io/pid_spec.rb +++ b/core/io/pid_spec.rb @@ -17,13 +17,13 @@ end it "returns the ID of a process associated with stream" do - IO.popen(RUBY_NAME, "r+") { |io| + IO.popen(RUBY_EXE, "r+") { |io| io.pid.shou...
Use RUBY_EXE not RUBY_NAME if ruby_exe helper is not suitable.
diff --git a/gds_zendesk.gemspec b/gds_zendesk.gemspec index abc1234..def5678 100644 --- a/gds_zendesk.gemspec +++ b/gds_zendesk.gemspec @@ -21,6 +21,6 @@ gem.add_development_dependency "rake" gem.add_development_dependency "rspec", "~> 3" - gem.add_development_dependency "rubocop-govuk", "~> 3" + gem.add_deve...
Set a specific version for rubocop-govuk It's not helpful to have this gem as a relative version as you don't want different environments to be using different versions and thus reporting different linting violations.
diff --git a/lib/rack/handler/puma.rb b/lib/rack/handler/puma.rb index abc1234..def5678 100644 --- a/lib/rack/handler/puma.rb +++ b/lib/rack/handler/puma.rb @@ -30,7 +30,14 @@ server.max_threads = Integer(max) yield server if block_given? - server.run.join + begin + server.run....
Add interruption support to Rack Handler
diff --git a/lib/sparkpost_rails/delivery_method.rb b/lib/sparkpost_rails/delivery_method.rb index abc1234..def5678 100644 --- a/lib/sparkpost_rails/delivery_method.rb +++ b/lib/sparkpost_rails/delivery_method.rb @@ -19,15 +19,15 @@ :recipients => [ { :address => { - :name ...
Remove display name for now
diff --git a/lib/retina_tag/engine.rb b/lib/retina_tag/engine.rb index abc1234..def5678 100644 --- a/lib/retina_tag/engine.rb +++ b/lib/retina_tag/engine.rb @@ -27,13 +27,12 @@ end options_default.merge!(options) - image_tag_without_retina(source,options_default) if options_default[:"data-l...
Return chained image_tag to fix "size" attribute handling. A call was originally being made to image_tag_without_retina, but the value was discarded and then it returned tag("img") which does not have the same effect. This changes the return to be the actual call to image_tag_without_retina.
diff --git a/girl_friday.gemspec b/girl_friday.gemspec index abc1234..def5678 100644 --- a/girl_friday.gemspec +++ b/girl_friday.gemspec @@ -17,4 +17,5 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] s.add_development_dependency 'sinatra', '~> 1.0' ...
Add rake dep, fixes GH-10
diff --git a/csv2strings.gemspec b/csv2strings.gemspec index abc1234..def5678 100644 --- a/csv2strings.gemspec +++ b/csv2strings.gemspec @@ -1,3 +1,4 @@+puts RUBY_VERSION Gem::Specification.new do |s| s.name = 'csv2strings' s.version = '0.2.1' @@ -12,7 +13,7 @@ s.add_dependency "thor" - if RUBY...
Update gemspec for 1.8 failing dependencies
diff --git a/spec/classes/toolkit_spec.rb b/spec/classes/toolkit_spec.rb index abc1234..def5678 100644 --- a/spec/classes/toolkit_spec.rb +++ b/spec/classes/toolkit_spec.rb @@ -0,0 +1,19 @@+require 'spec_helper' +describe 'percona::toolkit' do + + context 'with default values for all parameters' do + it { should co...
Add unit tests for toolkit
diff --git a/lib/time_entry_mailer.rb b/lib/time_entry_mailer.rb index abc1234..def5678 100644 --- a/lib/time_entry_mailer.rb +++ b/lib/time_entry_mailer.rb @@ -21,9 +21,8 @@ @project = time_entry.project @hours = time_entry.hours - to = @issue.notified_users.map(&:mail) - [ @actor.mail ] - cc = @iss...
Send timelog notice to all project members @fpietrosanti
diff --git a/spec/shoes/edit_line_spec.rb b/spec/shoes/edit_line_spec.rb index abc1234..def5678 100644 --- a/spec/shoes/edit_line_spec.rb +++ b/spec/shoes/edit_line_spec.rb @@ -4,7 +4,8 @@ let(:input_block) { Proc.new {} } let(:input_opts) { {} } - let(:parent) { double("parent").as_null_object } + let(:app) {...
Update EditLine specs to work with Swt backend
diff --git a/spec/tennis/launcher_spec.rb b/spec/tennis/launcher_spec.rb index abc1234..def5678 100644 --- a/spec/tennis/launcher_spec.rb +++ b/spec/tennis/launcher_spec.rb @@ -0,0 +1,75 @@+require "tennis/launcher" + +require "support/my_job" + +RSpec.describe Tennis::Launcher do + before do + allow(Tennis::Fetche...
Add a laucher spec, as always very implementation-based
diff --git a/x/docs/launch.rb b/x/docs/launch.rb index abc1234..def5678 100644 --- a/x/docs/launch.rb +++ b/x/docs/launch.rb @@ -15,7 +15,7 @@ attr_reader :repository, :checklist_issue def read - File.read("./x/docs/md/track/LAUNCH.md").gsub('REPO', repository).gsub('CHECKLIST_ISSUE', checklist_is...
Handle checklist number as integer in track documentation
diff --git a/class_annotation.rb b/class_annotation.rb index abc1234..def5678 100644 --- a/class_annotation.rb +++ b/class_annotation.rb @@ -0,0 +1,51 @@+# +# Let's assume we have a BookSearch class. The initialize method takes a Hash of +# parameters. +class BookSearch + def initialize(hash) + @author_name = hash[...
Initialize objects with a hash_initializer