diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/concerns/interval_validatable.rb b/app/concerns/interval_validatable.rb index abc1234..def5678 100644 --- a/app/concerns/interval_validatable.rb +++ b/app/concerns/interval_validatable.rb @@ -1,7 +1,7 @@ module IntervalValidatable extend ActiveSupport::Concern - INTERVALS = %w{Once Weekly Monthly...
Remove completion recurrence from bills
diff --git a/lib/middleman-s3_sync/commands.rb b/lib/middleman-s3_sync/commands.rb index abc1234..def5678 100644 --- a/lib/middleman-s3_sync/commands.rb +++ b/lib/middleman-s3_sync/commands.rb @@ -11,10 +11,14 @@ true end - desc "s3_sync", "Builds and push the minimum set of files needed to S3" + ...
Add a --bucket command line to allow configuring an alternate destination bucket. fixes #2.
diff --git a/app/controllers/forums_controller.rb b/app/controllers/forums_controller.rb index abc1234..def5678 100644 --- a/app/controllers/forums_controller.rb +++ b/app/controllers/forums_controller.rb @@ -12,8 +12,4 @@ end end - def home_redirect - redirect_to path('/') - end - end
Delete useless home_redirect method from ForumsController.
diff --git a/app/controllers/issues_controller.rb b/app/controllers/issues_controller.rb index abc1234..def5678 100644 --- a/app/controllers/issues_controller.rb +++ b/app/controllers/issues_controller.rb @@ -5,17 +5,26 @@ def show if @issue = Issue.find_by(id: params[:id]) - @category_name = @issue.categ...
Add updates to current user and categories from team check-in morning meeting
diff --git a/app/controllers/listen_controller.rb b/app/controllers/listen_controller.rb index abc1234..def5678 100644 --- a/app/controllers/listen_controller.rb +++ b/app/controllers/listen_controller.rb @@ -2,21 +2,21 @@ layout false def redirect - @icy_metadata = request.env['HTTP_ICY_METADATA'] - strea...
Revert "Use cdnstream.phate.io for https listener" This reverts commit 66c1a823dde4b96af0d9e57f20af0202fd1c96c4.
diff --git a/app/controllers/orders_controller.rb b/app/controllers/orders_controller.rb index abc1234..def5678 100644 --- a/app/controllers/orders_controller.rb +++ b/app/controllers/orders_controller.rb @@ -6,15 +6,21 @@ end def closed - @orders = current_user.closed_orders_with_access + Organization.uns...
Allow loading orders with deleted organizations
diff --git a/lib/roxml/xml/parsers/nokogiri.rb b/lib/roxml/xml/parsers/nokogiri.rb index abc1234..def5678 100644 --- a/lib/roxml/xml/parsers/nokogiri.rb +++ b/lib/roxml/xml/parsers/nokogiri.rb @@ -32,6 +32,10 @@ def search(xpath) super("./#{xpath}") end + + def attributes + self ...
Fix attributes access for Nokogiri
diff --git a/lib/tasks/update_draw_status.rake b/lib/tasks/update_draw_status.rake index abc1234..def5678 100644 --- a/lib/tasks/update_draw_status.rake +++ b/lib/tasks/update_draw_status.rake @@ -0,0 +1,10 @@+task :update_status=> :environment do + pics = Pick.where(result: nil) + puts "results set" + pics.each do ...
Add rake task to update pick status
diff --git a/environment.rb b/environment.rb index abc1234..def5678 100644 --- a/environment.rb +++ b/environment.rb @@ -14,4 +14,4 @@ require 'bridges/bridge.rb' -I18n.load_path += Dir[File.join(File.dirname(__FILE__), 'lib', 'active_scaffold', 'locale', '*.{rb,yml}')] +I18n.load_path.unshift *Dir[File.join(File.d...
Allow override locale from app
diff --git a/lib/graphql/unauthorized_error.rb b/lib/graphql/unauthorized_error.rb index abc1234..def5678 100644 --- a/lib/graphql/unauthorized_error.rb +++ b/lib/graphql/unauthorized_error.rb @@ -22,7 +22,7 @@ @object = object @type = type @context = context - message ||= "An instance of #{obj...
Use graphql_name rather than name when constructing the default error message
diff --git a/lib/lightspeed_restaurant/base.rb b/lib/lightspeed_restaurant/base.rb index abc1234..def5678 100644 --- a/lib/lightspeed_restaurant/base.rb +++ b/lib/lightspeed_restaurant/base.rb @@ -1,10 +1,21 @@ module LightspeedRestaurant class Base def initialize(data = {}) - data.each do |k, v| - ...
Improve hash and json generator method
diff --git a/app/controllers/projects/clusters/applications_controller.rb b/app/controllers/projects/clusters/applications_controller.rb index abc1234..def5678 100644 --- a/app/controllers/projects/clusters/applications_controller.rb +++ b/app/controllers/projects/clusters/applications_controller.rb @@ -5,16 +5,17 @@ ...
Refactor cluster app creation code in controller Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/lib/human_date/parser.rb b/lib/human_date/parser.rb index abc1234..def5678 100644 --- a/lib/human_date/parser.rb +++ b/lib/human_date/parser.rb @@ -1,7 +1,7 @@ module HumanDate class Parser def initialize - Chronic.time_class = Time.zone + # Chronic.time_class = Time.zone end ...
Remove broken Chronic.time_class = Time.zone
diff --git a/lib/service_desk/configuration.rb b/lib/service_desk/configuration.rb index abc1234..def5678 100644 --- a/lib/service_desk/configuration.rb +++ b/lib/service_desk/configuration.rb @@ -1,5 +1,10 @@ class ServiceDesk::Configuration OPTIONS = [:client_id, :client_secret, :redirect_uri, :api_host, :authenti...
Add some defaults to Configuration
diff --git a/lib/swift/playground/generator.rb b/lib/swift/playground/generator.rb index abc1234..def5678 100644 --- a/lib/swift/playground/generator.rb +++ b/lib/swift/playground/generator.rb @@ -19,7 +19,7 @@ html = section.inner_html playground.sections << DocumentationSection.new(html) ...
Fix bug where swift code was being transformed into HTML entities.
diff --git a/lib/travis/build/job/configure.rb b/lib/travis/build/job/configure.rb index abc1234..def5678 100644 --- a/lib/travis/build/job/configure.rb +++ b/lib/travis/build/job/configure.rb @@ -30,7 +30,7 @@ parse(response.body) else # TODO log error - {} + ...
Include ".parsing_failed" and ".fetching_failed" keys during configuration so that Hub can use this info
diff --git a/lib/lockfile/lockfile.rb b/lib/lockfile/lockfile.rb index abc1234..def5678 100644 --- a/lib/lockfile/lockfile.rb +++ b/lib/lockfile/lockfile.rb @@ -6,7 +6,7 @@ end def qualified_path - "#{@path}/#{@filename}" + File.join(@path, @filename) end def process_id
Use File.join over string interpolation.
diff --git a/app/models/genotype.rb b/app/models/genotype.rb index abc1234..def5678 100644 --- a/app/models/genotype.rb +++ b/app/models/genotype.rb @@ -10,7 +10,7 @@ before_post_process :is_image? validates_attachment :genotype, presence: true, - size: { in: 0..100.megabytes } + size: { in: 0..400.mega...
Increase file limit to 400mb
diff --git a/chef-provisioning-docker.gemspec b/chef-provisioning-docker.gemspec index abc1234..def5678 100644 --- a/chef-provisioning-docker.gemspec +++ b/chef-provisioning-docker.gemspec @@ -15,6 +15,7 @@ s.add_dependency 'chef' s.add_dependency 'chef-provisioning', '~> 1.0' s.add_dependency 'docker-api' + s...
Add minitar as missing dependency.
diff --git a/lib/twterm/subscriber.rb b/lib/twterm/subscriber.rb index abc1234..def5678 100644 --- a/lib/twterm/subscriber.rb +++ b/lib/twterm/subscriber.rb @@ -6,7 +6,7 @@ cb = if callback.is_a?(Proc) callback elsif callback.is_a?(Symbol) - if self.respond_to?(callback) + ...
Enable to subscribe events with private methods Specify true in the second argument of `respond_to?` method in order to check if the receiver has the method including private ones
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,5 +1,6 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) + +require 'coveralls' +Coveralls.wear! require 'crazipsum' require 'minitest/autorun' -require 'coveralls...
Fix coverall by moving Coveralls.wear on top Laboris verilog sunt powerscript dolore vhdl magna anim. Lustre ipsum dolore self voluptate incididunt mathematica. Occaecat cillum autolisp anim excepteur sed deserunt enim anim. Avenue lorem hypertalk id nulla ceylon dolor ad fantom simulink duis fugiat consectetur. Incid...
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -11,11 +11,12 @@ RubygemFs.mock! Aws.config[:stub_responses] = true -I18n.locale = :en class ActiveSupport::TestCase include FactoryGirl::Syntax::Methods include GemHel...
Move locale intialization to setup Setting it in test_helper as config didn't seem to work.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -11,10 +11,10 @@ require 'camping-unabridged' end -require 'test/unit' +require 'minitest/autorun' require 'rack/test' -class TestCase < Test::Unit::TestCase +class TestCas...
Make sure we're using MiniTest
diff --git a/filehandles/file_handle_monitor.rb b/filehandles/file_handle_monitor.rb index abc1234..def5678 100644 --- a/filehandles/file_handle_monitor.rb +++ b/filehandles/file_handle_monitor.rb @@ -0,0 +1,20 @@+class FileHandleMonitor < Scout::Plugin + OPTIONS=<<-EOS + EOS + + def build_report + report_hash={}...
Add a simple plugin to monitor open file handles
diff --git a/config/initializers/clearance.rb b/config/initializers/clearance.rb index abc1234..def5678 100644 --- a/config/initializers/clearance.rb +++ b/config/initializers/clearance.rb @@ -2,6 +2,6 @@ Clearance.configure do |config| config.mailer_sender = "donotreply@rubygems.org" config.secure_cookie =...
Switch password strategy to BCryptMigrationFromSHA1.
diff --git a/lib/dry/view/part.rb b/lib/dry/view/part.rb index abc1234..def5678 100644 --- a/lib/dry/view/part.rb +++ b/lib/dry/view/part.rb @@ -18,14 +18,14 @@ @_renderer = renderer end - def __render(partial_name, as: _name, **locals, &block) + def _render(partial_name, as: _name, **locals,...
Use single underscores for Part’s local methods This makes them consistent with the accessor naming
diff --git a/spec/integration/project_spec.rb b/spec/integration/project_spec.rb index abc1234..def5678 100644 --- a/spec/integration/project_spec.rb +++ b/spec/integration/project_spec.rb @@ -33,6 +33,7 @@ Dir.chdir('spec/fixtures/LibraryConsumerDemo') do `pod install 2>&1` `xcodebuild -w...
Test simulator build as well.
diff --git a/spec/lib/dbd/performance_spec.rb b/spec/lib/dbd/performance_spec.rb index abc1234..def5678 100644 --- a/spec/lib/dbd/performance_spec.rb +++ b/spec/lib/dbd/performance_spec.rb @@ -0,0 +1,38 @@+require 'spec_helper' + +module Dbd + describe "performance" do + + def new_subject + Fact.new_subject + ...
Add a first performance benchmark * On MRI 2.0.0 typically 30 ms for 1000 * "graph << (Fact.new(...))" * On JRuby 1.7.3 typically 400 ms for 1000 * "graph << (Fact.new(..))" Not immediately found the cause of the large discrepency. In Jruby, just creating the data_fact objects from the Factories seems to consume 330 ...
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -5,7 +5,6 @@ # Be sure to restart your server when you modify this file. -# Secure cookies only when not in ...
Remove comment about secure cookies (no longer true)
diff --git a/lib/kanagata/base.rb b/lib/kanagata/base.rb index abc1234..def5678 100644 --- a/lib/kanagata/base.rb +++ b/lib/kanagata/base.rb @@ -10,7 +10,7 @@ @pwd = File.expand_path('.') @templates = config['templates'] @attributes = config['attributes'] || {} - @templates_dir...
Remove an undefined local variable
diff --git a/joiner.gemspec b/joiner.gemspec index abc1234..def5678 100644 --- a/joiner.gemspec +++ b/joiner.gemspec @@ -16,7 +16,7 @@ spec.add_runtime_dependency 'activerecord', '>= 5.2.beta1' spec.add_development_dependency 'combustion', '~> 0.8' - spec.add_development_dependency 'rails', '>= 5.2.0.rc2...
Update Rails dependency to >= 5.2.0.
diff --git a/lib/tasks/blank.rake b/lib/tasks/blank.rake index abc1234..def5678 100644 --- a/lib/tasks/blank.rake +++ b/lib/tasks/blank.rake @@ -9,7 +9,7 @@ end task :switch_to_app_gitignore do - `cp .new_app.gitignore .gitignore` + cp ".new_app.gitignore", ".gitignore" end task :session_config...
Use Rake's copy command instead of shelling out
diff --git a/lib/webpack/rails.rb b/lib/webpack/rails.rb index abc1234..def5678 100644 --- a/lib/webpack/rails.rb +++ b/lib/webpack/rails.rb @@ -3,7 +3,7 @@ module Webpack module Assets class Railtie < Rails::Railtie - config.after_initialize do + config.before_initialize do Webpack.config.us...
Set default configuration in before_initialize
diff --git a/url_extractor.gemspec b/url_extractor.gemspec index abc1234..def5678 100644 --- a/url_extractor.gemspec +++ b/url_extractor.gemspec @@ -4,8 +4,8 @@ Gem::Specification.new do |gem| gem.authors = ["Michael Guterl"] gem.email = ["michael@diminishing.org"] - gem.description = %q{TODO: Wr...
Remove TODO from gemspec to silence warnings
diff --git a/promisepay.gemspec b/promisepay.gemspec index abc1234..def5678 100644 --- a/promisepay.gemspec +++ b/promisepay.gemspec @@ -21,7 +21,7 @@ spec.required_ruby_version = '>= 1.9.3' spec.add_dependency 'faraday' - spec.add_dependency 'json' + spec.add_dependency 'json', '~> 1.8.3' spec.add_developm...
Fix json gem version in Gemspec in order to keep project compliant with ruby 1.9.3
diff --git a/qa/qa/page/base.rb b/qa/qa/page/base.rb index abc1234..def5678 100644 --- a/qa/qa/page/base.rb +++ b/qa/qa/page/base.rb @@ -5,7 +5,7 @@ include Scenario::Actable def refresh - visit current_path + visit current_url end end end
Fix QA page refresh address by using absolute URLs This makes QA page refresh address to be absolute URL since we dropped `Capybara.app_host`, thus there is no support for relative URLs with `visit` now.
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -12,7 +12,7 @@ template 'drone.conf' do source 'drone.conf.erb' - path "#{node['drone']['config_file']}" + path node['drone']['config_file'] mode 0644 owner 'root' grou...
Remove unecessary string interpolation, make Foodcritic happy.
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -20,7 +20,7 @@ chef_gem 'acme-client' do action :install - version '0.4.0' + version '0.6.2' compile_time true if respond_to?(:compile_time) end
Upgrade acme-client gem to v0.6.2
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -35,7 +35,14 @@ else service_name "ssh" end - supports :restart => true + supports value_for_platform( + "debian" => { "default" => [ :restart, :reload ] }, + "ubuntu...
COOK-202: Use status on supported platforms.
diff --git a/labels_spec.rb b/labels_spec.rb index abc1234..def5678 100644 --- a/labels_spec.rb +++ b/labels_spec.rb @@ -14,7 +14,7 @@ end describe "#[]" do - it "returns the pre at the given index" do + it "returns the label at the given index" do browser.labels[0].id.should == "first_label" e...
Correct element name in spec description
diff --git a/ruby-poker.gemspec b/ruby-poker.gemspec index abc1234..def5678 100644 --- a/ruby-poker.gemspec +++ b/ruby-poker.gemspec @@ -1,32 +1,32 @@-Gem::Specification.new do |s| +spec = Gem::Specification.new do |s| s.name = "ruby-poker" - s.version = "0.3.1" - s.date = "2009-01-24" + s.version = RUB...
Update gemspec for 0.3.2 release
diff --git a/Casks/mapbox-studio.rb b/Casks/mapbox-studio.rb index abc1234..def5678 100644 --- a/Casks/mapbox-studio.rb +++ b/Casks/mapbox-studio.rb @@ -1,6 +1,6 @@ cask :v1 => 'mapbox-studio' do - version '0.3.1' - sha256 'ed5cb9ca0db8135caf2b82c30e3b58c4ad1689f7a3b6d05d7ecf82642c95e812' + version '0.3.2' + sha256...
Update Mapbox Studio version to 3.2
diff --git a/lionel.gemspec b/lionel.gemspec index abc1234..def5678 100644 --- a/lionel.gemspec +++ b/lionel.gemspec @@ -12,8 +12,8 @@ Engine gems are convenient for versioning and packaging static assets. Lionel lets you use assets packaged as Engines without depending on Rails. EOF gem.summary = %q{U...
Add homepage and license info
diff --git a/lib/spectrum/config/formatted_page_range_field.rb b/lib/spectrum/config/formatted_page_range_field.rb index abc1234..def5678 100644 --- a/lib/spectrum/config/formatted_page_range_field.rb +++ b/lib/spectrum/config/formatted_page_range_field.rb @@ -35,6 +35,7 @@ if end_page end_page ...
Fix a missing end tag
diff --git a/config/database_cleaner.rb b/config/database_cleaner.rb index abc1234..def5678 100644 --- a/config/database_cleaner.rb +++ b/config/database_cleaner.rb @@ -23,9 +23,11 @@ config.after(:each) do DatabaseCleaner.clean - # Remove repositories - dir = Rails.root.join("tmp","repos...
Delete repositories and other data after a spec
diff --git a/mdl_ruleset.rb b/mdl_ruleset.rb index abc1234..def5678 100644 --- a/mdl_ruleset.rb +++ b/mdl_ruleset.rb @@ -5,3 +5,6 @@ # Set Ordered list item prefix to "ordered" (use 1. 2. 3. not 1. 1. 1.) rule 'MD029', :style => "ordered" + +# Exclude code block style +exclude_rule 'MD046'
Exclude code block style from Markdownlint The Python-Markdown parser includes support for fenced code blocks, but only at the root level of the document. Therefore, a code block nested in a list item must be an indented block. At the same time, MkDocs' code highlighting relies on the language identifier in fenced cod...
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,5 +1,7 @@ class ApplicationController < ActionController::Base # Prevent CSRF attacks ...
Comment out include Authentication line - awaiting user auth helpers
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,7 +2,7 @@ # # Check ActiveAdmin and DeviseAuthToken incompatibilities. # unless co...
Change nil check to defined?
diff --git a/app/serializers/shipit/task_serializer.rb b/app/serializers/shipit/task_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/shipit/task_serializer.rb +++ b/app/serializers/shipit/task_serializer.rb @@ -5,7 +5,7 @@ has_one :author has_one :revision, serializer: ShortCommitSerializer ...
Include action and description is Task payloads
diff --git a/event_store-client-http.gemspec b/event_store-client-http.gemspec index abc1234..def5678 100644 --- a/event_store-client-http.gemspec +++ b/event_store-client-http.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'event_store-client-http' - s.version = '0.4.0.1'...
Package version is increased from 0.4.0.1 to 0.4.0.2
diff --git a/lib/quotes/entities/publication.rb b/lib/quotes/entities/publication.rb index abc1234..def5678 100644 --- a/lib/quotes/entities/publication.rb +++ b/lib/quotes/entities/publication.rb @@ -5,7 +5,7 @@ attr_reader :added_by, :uid def initialize(added_by, author, title, publisher, year, uid = n...
Add '!' to validate method in pub entity
diff --git a/spec/email_spec.rb b/spec/email_spec.rb index abc1234..def5678 100644 --- a/spec/email_spec.rb +++ b/spec/email_spec.rb @@ -2,20 +2,23 @@ describe Reparty::Email do describe "provides variables" do - let(:from) { "test@test.com" } - let(:subject) { "Test Subject" } - let(:title) { "Test ...
Fix spec test (and cover reports) :+1:
diff --git a/IOSLinkedInAPI.podspec b/IOSLinkedInAPI.podspec index abc1234..def5678 100644 --- a/IOSLinkedInAPI.podspec +++ b/IOSLinkedInAPI.podspec @@ -5,7 +5,7 @@ s.summary = 'IOS LinkedIn API capable of accessing LinkedIn using oauth2. Using a UIWebView to fetch the authorization code.' s.homepage = 'https://g...
Change for our custom repo
diff --git a/core/kernel/format_spec.rb b/core/kernel/format_spec.rb index abc1234..def5678 100644 --- a/core/kernel/format_spec.rb +++ b/core/kernel/format_spec.rb @@ -11,4 +11,20 @@ it "is accessible as a module function" do Kernel.format("%s", "hello").should == "hello" end + + it "formats string with pre...
Support precision when formatting string
diff --git a/config/initializers/mini_magick.rb b/config/initializers/mini_magick.rb index abc1234..def5678 100644 --- a/config/initializers/mini_magick.rb +++ b/config/initializers/mini_magick.rb @@ -2,4 +2,6 @@ MiniMagick.configure do |config| config.shell_api = "posix-spawn" + config.timeout = 300 + config.va...
Enable a 300 second timeout for image magix conversion and disable initial validation pass
diff --git a/config/initializers/rack_attack.rb b/config/initializers/rack_attack.rb index abc1234..def5678 100644 --- a/config/initializers/rack_attack.rb +++ b/config/initializers/rack_attack.rb @@ -4,8 +4,8 @@ req.ip if req.path == '/admin/sign_in' && req.post? end -ActiveSupport::Notifications.subscribe('rack....
Fix invalid variable for rack-attacker notifier
diff --git a/config/initializers/rails_admin.rb b/config/initializers/rails_admin.rb index abc1234..def5678 100644 --- a/config/initializers/rails_admin.rb +++ b/config/initializers/rails_admin.rb @@ -15,9 +15,6 @@ ### More at https://github.com/sferik/rails_admin/wiki/Base-configuration - config.included_models...
Whitelist user fields in admin.
diff --git a/spec/chartroom/container_spec.rb b/spec/chartroom/container_spec.rb index abc1234..def5678 100644 --- a/spec/chartroom/container_spec.rb +++ b/spec/chartroom/container_spec.rb @@ -0,0 +1,95 @@+require "spec_helper" + +module Chartroom + describe Container do + let(:container) { described_class.new(doub...
Add tests for instance methods of Chartroom::Container
diff --git a/spec/concepts/game_state_spec.rb b/spec/concepts/game_state_spec.rb index abc1234..def5678 100644 --- a/spec/concepts/game_state_spec.rb +++ b/spec/concepts/game_state_spec.rb @@ -25,5 +25,11 @@ expect(game_state.dealer).to be nil end end + + describe "hands" do + it "are all em...
Test that all hands are initially empty
diff --git a/spec/integration/decoder_spec.rb b/spec/integration/decoder_spec.rb index abc1234..def5678 100644 --- a/spec/integration/decoder_spec.rb +++ b/spec/integration/decoder_spec.rb @@ -29,7 +29,7 @@ expect(subject.words.map(&:word)).to eq(["<s>", "go", "forward", "ten", "meters", "</s>"]) expect(...
Fix integration tests after decoding change in Sphinxbase: https://github.com/cmusphinx/sphinxbase/commit/b99073ee0febd102c517b1e6e3046cc0781bf8f7
diff --git a/spec/rspec/mocks/methods_spec.rb b/spec/rspec/mocks/methods_spec.rb index abc1234..def5678 100644 --- a/spec/rspec/mocks/methods_spec.rb +++ b/spec/rspec/mocks/methods_spec.rb @@ -0,0 +1,27 @@+require 'spec_helper' + +module RSpec + module Mocks + describe Methods, :if => (Method.method_defined?(:owner...
Add a spec that helps us limit the number of methods added to all objects.
diff --git a/store_hours.gemspec b/store_hours.gemspec index abc1234..def5678 100644 --- a/store_hours.gemspec +++ b/store_hours.gemspec @@ -10,7 +10,7 @@ gem.email = ["yanhaozhu@gmail.com"] gem.description = 'A small parser for store normal business hours' gem.summary = 'A small parser for stor...
Update homepage for gem settings
diff --git a/spec/support/database_cleaner.rb b/spec/support/database_cleaner.rb index abc1234..def5678 100644 --- a/spec/support/database_cleaner.rb +++ b/spec/support/database_cleaner.rb @@ -0,0 +1,24 @@+require 'database_cleaner' + +RSpec.configure do |config| + + config.before(:suite) do + DatabaseCleaner.clean...
Configure database cleaner for feature specs
diff --git a/scripts/seo/update_static_html.rb b/scripts/seo/update_static_html.rb index abc1234..def5678 100644 --- a/scripts/seo/update_static_html.rb +++ b/scripts/seo/update_static_html.rb @@ -0,0 +1,15 @@+require "open-uri" + +# Useful script for updating all of the static html on the site (in normal circumstances...
Add script which updates static html of all pages.
diff --git a/spec/unit/generator/copy_resources_script_spec.rb b/spec/unit/generator/copy_resources_script_spec.rb index abc1234..def5678 100644 --- a/spec/unit/generator/copy_resources_script_spec.rb +++ b/spec/unit/generator/copy_resources_script_spec.rb @@ -17,5 +17,16 @@ generator_1.send(:script).should.not.i...
[Spec] Add a more specifc unit test for configuration dependent resources
diff --git a/spec/controller_spec.rb b/spec/controller_spec.rb index abc1234..def5678 100644 --- a/spec/controller_spec.rb +++ b/spec/controller_spec.rb @@ -16,8 +16,10 @@ end class Record + attr_reader :saved + def save - + @saved = true end end @@ -30,7 +32,7 @@ include TestWizard def model...
Add test of update model
diff --git a/spec/active_record_spec_helper.rb b/spec/active_record_spec_helper.rb index abc1234..def5678 100644 --- a/spec/active_record_spec_helper.rb +++ b/spec/active_record_spec_helper.rb @@ -0,0 +1,14 @@+require 'active_record' +require 'yaml' + +connection_info = YAML.load_file('config/database.yml')['test'] +Ac...
Add active record spec helper
diff --git a/spec/features/validations_spec.rb b/spec/features/validations_spec.rb index abc1234..def5678 100644 --- a/spec/features/validations_spec.rb +++ b/spec/features/validations_spec.rb @@ -1,38 +1,34 @@ require 'rails_helper.rb' -feature 'Saving posts with invalid title' do - it "Doesn't save posts with more...
Simplify and improve the post validations spec- passing
diff --git a/spec/hadoop_hdfs_namenode_spec.rb b/spec/hadoop_hdfs_namenode_spec.rb index abc1234..def5678 100644 --- a/spec/hadoop_hdfs_namenode_spec.rb +++ b/spec/hadoop_hdfs_namenode_spec.rb @@ -25,7 +25,12 @@ end it 'creates hadoop-hdfs-namenode service resource, but does not run it' do + expect(chef...
Add more negative checks to hadoop_hdfs_namenode unit tests
diff --git a/spec/lib/frecon/base/bson_spec.rb b/spec/lib/frecon/base/bson_spec.rb index abc1234..def5678 100644 --- a/spec/lib/frecon/base/bson_spec.rb +++ b/spec/lib/frecon/base/bson_spec.rb @@ -2,6 +2,8 @@ describe BSON::ObjectId do describe "#as_json" do - it "takes no arguments and returns the string represen...
Change spec from pending to failing to test Travis' response.
diff --git a/spec/requests/healthcheck_spec.rb b/spec/requests/healthcheck_spec.rb index abc1234..def5678 100644 --- a/spec/requests/healthcheck_spec.rb +++ b/spec/requests/healthcheck_spec.rb @@ -0,0 +1,8 @@+RSpec.describe "/healthcheck" do + it "returns database connection status" do + get "/healthcheck" + jso...
Add healthcheck database connection test
diff --git a/lib/bourbon.rb b/lib/bourbon.rb index abc1234..def5678 100644 --- a/lib/bourbon.rb +++ b/lib/bourbon.rb @@ -23,10 +23,6 @@ end else bourbon_path = File.expand_path("../../app/assets/stylesheets", __FILE__) - if ENV.has_key?("SASS_PATH") - ENV["SASS_PATH"] = ENV["SASS_PATH"] + File::PATH...
Use clean one-liner to set `SASS_PATH` environment variable.
diff --git a/lib/hatchet.rb b/lib/hatchet.rb index abc1234..def5678 100644 --- a/lib/hatchet.rb +++ b/lib/hatchet.rb @@ -31,4 +31,13 @@ raise "Attempting to find current branch name. Error: Cannot describe git: #{out}" unless $?.success? out end -end+ + if ENV["HATCHET_DEBUG_DEADLOCK"] + Thread.new do +...
Allow users to debug deadlock When set, an env var will spawn a background thread that sleeps for the given amount of time. At the end of that timeout period it will print the backtrace for all threads that are alive, this should point to the location where the code is frozen.
diff --git a/lib/migrate.rb b/lib/migrate.rb index abc1234..def5678 100644 --- a/lib/migrate.rb +++ b/lib/migrate.rb @@ -21,6 +21,12 @@ add_index :jobs, :path add_index :jobs, :status + + postgres = (ActiveRecord::Base.connection.adapter_name == 'PostgreSQL') + + ['started_at', 'cancelled_at', 'complet...
Add indexes for date fields
diff --git a/lib/moltres.rb b/lib/moltres.rb index abc1234..def5678 100644 --- a/lib/moltres.rb +++ b/lib/moltres.rb @@ -3,6 +3,7 @@ module Moltres class Application def call(env) + `echo debug > debug.txt`; [ 200, { 'Content-Type' => 'text/html'}, ['Hello from Ruby on Moltres!']] end end
Add debug file on Application
diff --git a/lib/poi2csv.rb b/lib/poi2csv.rb index abc1234..def5678 100644 --- a/lib/poi2csv.rb +++ b/lib/poi2csv.rb @@ -4,6 +4,7 @@ module Poi2csv Poi2csvException = Class.new(StandardError) + SUPPORTED_EXTENSIONS = [:xls, :xlsx] def self.to_csv(input_file_path, output_folder_path, separator=nil, formating_...
Add a list of supported extensions
diff --git a/jekyll-theme-slate.gemspec b/jekyll-theme-slate.gemspec index abc1234..def5678 100644 --- a/jekyll-theme-slate.gemspec +++ b/jekyll-theme-slate.gemspec @@ -4,7 +4,7 @@ s.name = "jekyll-theme-slate" s.version = "0.0.1" s.authors = ["Please come forward"] - s.email = ["s...
Update contact email in Gemspec
diff --git a/libsyn.gemspec b/libsyn.gemspec index abc1234..def5678 100644 --- a/libsyn.gemspec +++ b/libsyn.gemspec @@ -7,10 +7,10 @@ spec.name = "libsyn" spec.version = Libsyn::VERSION spec.authors = ["Chris Hunt"] - spec.email = ["chrishunt@github.com"] + spec.email = [...
Add email and homepage to gemspec
diff --git a/core/config/initializers/konacha.rb b/core/config/initializers/konacha.rb index abc1234..def5678 100644 --- a/core/config/initializers/konacha.rb +++ b/core/config/initializers/konacha.rb @@ -1,4 +1,4 @@-puts "DEBUG line for CircleCI testing" +puts "DEBUG line for CircleCI: #{Rails.env}" if defined?(Konac...
Include rails env in debug output
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -13,6 +13,7 @@ def munge_filename(opts) return if opts[:filename] test_name = Haml::Util.caller_info(caller[1])[2] + test_name.sub!(/^block in /, '') opts[:file...
[Sass] Fix a few Ruby 1.9 test failures.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -13,4 +13,8 @@ @dtp.close unless @dtp.nil? end + def test_nothing + assert(1) + end + end
Add dummy test to keep Ruby 1.8's test-unit happy.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,3 +1,4 @@ require 'rubygems' require 'active_support' -require 'active_support/test_case'+require 'minitest/autorun' +require 'active_support/test_case'
Add autorunner to make tests runnable with rake.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -17,7 +17,7 @@ ENV["SKYCRAWLERS_ENV"] = "test" ActiveRecord::Migration.verbose = false -ActiveRecord::Base.configurations = YAML.load_file("config/database.yml") +ActiveRecord::...
test: Use proper path for database.yml
diff --git a/test/test_models.rb b/test/test_models.rb index abc1234..def5678 100644 --- a/test/test_models.rb +++ b/test/test_models.rb @@ -9,8 +9,7 @@ class Setting < ActiveRecord::Base def_druthers :quest, :favourite_colour, :things, :hashish, :change - serialize :value, CustomSerialize - + def self.defau...
Move serialize method so class id defined
diff --git a/test/govuk_component/analytics_meta_tags_test.rb b/test/govuk_component/analytics_meta_tags_test.rb index abc1234..def5678 100644 --- a/test/govuk_component/analytics_meta_tags_test.rb +++ b/test/govuk_component/analytics_meta_tags_test.rb @@ -0,0 +1,41 @@+require 'govuk_component_test_helper' + +class Ana...
Add tests for analytics component
diff --git a/GameOfLife/oop/spec/cell_spec.rb b/GameOfLife/oop/spec/cell_spec.rb index abc1234..def5678 100644 --- a/GameOfLife/oop/spec/cell_spec.rb +++ b/GameOfLife/oop/spec/cell_spec.rb @@ -12,6 +12,18 @@ expect(Cell.new(State::Dead, []).state).to eq(State::Dead) end end + describe 'On...
Add rule 1 Cell's tests
diff --git a/lib/event_provider/base.rb b/lib/event_provider/base.rb index abc1234..def5678 100644 --- a/lib/event_provider/base.rb +++ b/lib/event_provider/base.rb @@ -37,7 +37,7 @@ alias_method :eql?, :== def hash - "#{@id}-#{provider}-#{@link}".hash + "#{id}-#{provider}-#{link}".hash end ...
Use attr readers instead of instance variable directly.
diff --git a/lib/ext/sawyer/relation.rb b/lib/ext/sawyer/relation.rb index abc1234..def5678 100644 --- a/lib/ext/sawyer/relation.rb +++ b/lib/ext/sawyer/relation.rb @@ -2,7 +2,7 @@ module Patch def href(options=nil) - # see: octokit/octokit.rb#727 + # Temporary workaround for: https://github.com/octokit/octo...
Add proper link to issue
diff --git a/lib/hive/device/android.rb b/lib/hive/device/android.rb index abc1234..def5678 100644 --- a/lib/hive/device/android.rb +++ b/lib/hive/device/android.rb @@ -11,50 +11,8 @@ @model = config['model'].downcase.gsub(/\s/, '_') @brand = config['brand'].downcase.gsub(/\s/, '_') @os_versio...
Remove queue generation in device class
diff --git a/lib/nyaplot/charts/base.rb b/lib/nyaplot/charts/base.rb index abc1234..def5678 100644 --- a/lib/nyaplot/charts/base.rb +++ b/lib/nyaplot/charts/base.rb @@ -12,7 +12,7 @@ end end - attr_reader :glyphs, :deps + attr_reader :glyphs, :deps, :xdomain, :ydomain def initialize(**...
Add reader for xdomain and ydomain of Charts
diff --git a/lib/pansophy/connection.rb b/lib/pansophy/connection.rb index abc1234..def5678 100644 --- a/lib/pansophy/connection.rb +++ b/lib/pansophy/connection.rb @@ -1,6 +1,7 @@ module Pansophy module Connection def self.aws + Excon.defaults[:ciphers] = 'DEFAULT' Fog::Storage.new( provid...
Use the ruby default Cipher list for Excon
diff --git a/lib/stache/asset_helper.rb b/lib/stache/asset_helper.rb index abc1234..def5678 100644 --- a/lib/stache/asset_helper.rb +++ b/lib/stache/asset_helper.rb @@ -8,7 +8,11 @@ lookup_context.view_paths = [Stache.template_base_path] template_finder = lambda do |partial| - lookup_context...
Support Rails 3.2 and < 3.2 in the lookup_context call.
diff --git a/lib/tasks/run_mailman.rake b/lib/tasks/run_mailman.rake index abc1234..def5678 100644 --- a/lib/tasks/run_mailman.rake +++ b/lib/tasks/run_mailman.rake @@ -9,9 +9,8 @@ puts 'pop3 config found' Mailman.config.pop3 = { server: AppSettings['email.pop3_server'], - #ssl: true, - ...
Use settings in rake task
diff --git a/lib/tasks/task_runner.rake b/lib/tasks/task_runner.rake index abc1234..def5678 100644 --- a/lib/tasks/task_runner.rake +++ b/lib/tasks/task_runner.rake @@ -3,9 +3,15 @@ # Require the :client group from the Gemfile Bundler.require :client + # Point to local host in development mode, + # or heroku o...
Switch service URL based on Rails environment.
diff --git a/lib/tire/model/indexing.rb b/lib/tire/model/indexing.rb index abc1234..def5678 100644 --- a/lib/tire/model/indexing.rb +++ b/lib/tire/model/indexing.rb @@ -17,6 +17,8 @@ end def indexes(name, options = {}, &block) + options[:type] ||= 'string' + if block_given? ...
[ACTIVEMODEL] Make mapping type optional and default to "string"
diff --git a/lib/traject/json_writer.rb b/lib/traject/json_writer.rb index abc1234..def5678 100644 --- a/lib/traject/json_writer.rb +++ b/lib/traject/json_writer.rb @@ -34,7 +34,7 @@ unless defined? @output_file @output_file = if settings["output_file"] - File.open(settings["output_file"])...
Make JsonWriter actually open file for output in write mode
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,3 +1,10 @@ class ApplicationController < ActionController::Base protect_from_forgery +...
Set the current user if available
diff --git a/test/export/test_mux.rb b/test/export/test_mux.rb index abc1234..def5678 100644 --- a/test/export/test_mux.rb +++ b/test/export/test_mux.rb @@ -0,0 +1,23 @@+require File.dirname(__FILE__) + '/../helper' + +class MuxTest < Test::Unit::TestCase + + def test_mux_replays + outs = (0..25).map do + o ...
Add a test for the Mux exporter
diff --git a/test/pdf_helper_test.rb b/test/pdf_helper_test.rb index abc1234..def5678 100644 --- a/test/pdf_helper_test.rb +++ b/test/pdf_helper_test.rb @@ -21,6 +21,6 @@ options = @ac.send( :prerender_header_and_footer, :header => {:html => { :template => 'hf.html.erb'}}); assert !opt...
Fix test checking for tempfile name
diff --git a/lib/authorize_if.rb b/lib/authorize_if.rb index abc1234..def5678 100644 --- a/lib/authorize_if.rb +++ b/lib/authorize_if.rb @@ -13,26 +13,20 @@ end def authorize(*args, &block) + rule_method_name = "authorize_#{action_name}?" + unless self.respond_to?(rule_method_name, true) - raise(Mis...
Refactor `authorize` not to use any private methods. This is an included module. There shouldn't be any private methods included along with public ones. The names can easily clash with some other included modules.