diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/gir_ffi/zero_terminated.rb b/lib/gir_ffi/zero_terminated.rb index abc1234..def5678 100644 --- a/lib/gir_ffi/zero_terminated.rb +++ b/lib/gir_ffi/zero_terminated.rb @@ -7,7 +7,6 @@ def initialize elm_t, ptr @element_type = elm_t - @ffi_type = TypeMap.map_basic_type_or_string elm_t ...
Make ZeroTerminated work for arrays of pointers to objects
diff --git a/examples/custom_coercion_spec.rb b/examples/custom_coercion_spec.rb index abc1234..def5678 100644 --- a/examples/custom_coercion_spec.rb +++ b/examples/custom_coercion_spec.rb @@ -0,0 +1,50 @@+require './spec/spec_helper' + +class MD5 < Virtus::Attribute::Object + primitive String + coercion_method...
Add specs for examples in README
diff --git a/breezy_rails/lib/breezy/render.rb b/breezy_rails/lib/breezy/render.rb index abc1234..def5678 100644 --- a/breezy_rails/lib/breezy/render.rb +++ b/breezy_rails/lib/breezy/render.rb @@ -1,5 +1,11 @@ module Breezy module Render + DEFAULT_ACTIONS_FOR_VERBS = { + :post => 'new', + :patch => 'edi...
Add default screen names for post patch and put
diff --git a/lib/octokit/client/licenses.rb b/lib/octokit/client/licenses.rb index abc1234..def5678 100644 --- a/lib/octokit/client/licenses.rb +++ b/lib/octokit/client/licenses.rb @@ -12,7 +12,7 @@ # @example # Octokit.licenses def licenses(options = {}) - options = ensure_license_api_medi...
Change one last reference to ensure_license_api_media_type
diff --git a/lib/palletjack/tool-support.rb b/lib/palletjack/tool-support.rb index abc1234..def5678 100644 --- a/lib/palletjack/tool-support.rb +++ b/lib/palletjack/tool-support.rb @@ -0,0 +1,35 @@+# Support functions used by the Pallet Jack tools + +require 'rugged' + +# Return a string stating the Git provenance of a...
Move function for writing Git provenance header into a support module All tools will want to use this function, so move it out of the tool itself to a common file.
diff --git a/lib/travis/api/app/endpoint.rb b/lib/travis/api/app/endpoint.rb index abc1234..def5678 100644 --- a/lib/travis/api/app/endpoint.rb +++ b/lib/travis/api/app/endpoint.rb @@ -14,7 +14,7 @@ # TODO hmmm? before { flash.clear } - before { content_type :json } + after { content_type :json unless ...
Set json content type only when content type is not set
diff --git a/lib/tumblargh/resource/blog.rb b/lib/tumblargh/resource/blog.rb index abc1234..def5678 100644 --- a/lib/tumblargh/resource/blog.rb +++ b/lib/tumblargh/resource/blog.rb @@ -31,7 +31,7 @@ end def fetch! - attributes = fetch + self.attributes = fetch end def posts
Make the linter happy :)
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -3,7 +3,7 @@ # In the development environment your application's code is reloaded on # every request. This slows down ...
Secure fix for gravatar images
diff --git a/capistrano-resque-pool.gemspec b/capistrano-resque-pool.gemspec index abc1234..def5678 100644 --- a/capistrano-resque-pool.gemspec +++ b/capistrano-resque-pool.gemspec @@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) # Maintain your gem's version: -require 'capistrano/resque/pool/...
Change path to gem version
diff --git a/app/s3_uploader.rb b/app/s3_uploader.rb index abc1234..def5678 100644 --- a/app/s3_uploader.rb +++ b/app/s3_uploader.rb @@ -6,18 +6,26 @@ # http://docs.aws.amazon.com/sdkforruby/api/index.html class S3Uploader + DEFAULT_PUT_OPTIONS = { + acl: 'public-read', + server_side_encryption: 'AES256', + ...
Use AES256 server-side encryption and reduced_redundancy storage class
diff --git a/test/serializer_support_test.rb b/test/serializer_support_test.rb index abc1234..def5678 100644 --- a/test/serializer_support_test.rb +++ b/test/serializer_support_test.rb @@ -2,6 +2,13 @@ class RandomModel include ActiveModel::SerializerSupport +end + +class OtherRandomModel + include ActiveModel::S...
Test : use a deducted serializer on non-ActiveRecord models
diff --git a/color_schema_validator.gemspec b/color_schema_validator.gemspec index abc1234..def5678 100644 --- a/color_schema_validator.gemspec +++ b/color_schema_validator.gemspec @@ -9,9 +9,9 @@ spec.authors = ["ka"] spec.email = ["ka.kaosf@gmail.com"] - spec.summary = %q{TODO: Write a sho...
Fix placeholders in gemspec file
diff --git a/test/tc_historical_date.rb b/test/tc_historical_date.rb index abc1234..def5678 100644 --- a/test/tc_historical_date.rb +++ b/test/tc_historical_date.rb @@ -0,0 +1,27 @@+#!/usr/bin/env ruby -w + +$:.unshift File.join( File.dirname( __FILE__ ), '..', 'lib' ) + +require 'test/unit' +require 'historical_date' ...
Add test dir, tc_date.rb file, and first test.
diff --git a/app/controllers/api/v1/helpers.rb b/app/controllers/api/v1/helpers.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/helpers.rb +++ b/app/controllers/api/v1/helpers.rb @@ -46,7 +46,7 @@ end def declared_params - declared(params, include_missing: false).to_hash + dec...
Allow access to declared_params with key as symbol
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -29,11 +29,11 @@ def thumbnail_url(obj) thumbnail = (obj.has_attribute?(:thumbnail) ? obj.thumbnai...
Fix opengraph image urls again
diff --git a/app/helpers/surveys_url_helper.rb b/app/helpers/surveys_url_helper.rb index abc1234..def5678 100644 --- a/app/helpers/surveys_url_helper.rb +++ b/app/helpers/surveys_url_helper.rb @@ -2,6 +2,6 @@ module SurveysUrlHelper def course_survey_url(notification) - "#{survey_url(notification.survey)}?cours...
Replace ampersand in course slug for survey links We disallow "&" in a course title on the frontend, but that validation wasn't preventing submission for several months. We now have 11 courses, most of them recent (and a few much older) that have this character. It's fine except in cases where the slug is passed as a ...
diff --git a/test/unit/donation_test.rb b/test/unit/donation_test.rb index abc1234..def5678 100644 --- a/test/unit/donation_test.rb +++ b/test/unit/donation_test.rb @@ -19,4 +19,18 @@ assert_equal Rails.application.config.gravatar_url % "aa99b351245441b8ca95d54a52d2998c", @d.gravatar_url end + + test "donatio...
Test Donation has random secret
diff --git a/lib/rfd.rb b/lib/rfd.rb index abc1234..def5678 100644 --- a/lib/rfd.rb +++ b/lib/rfd.rb @@ -3,6 +3,7 @@ class Window def draw(contents) + @win.setpos 0, 0 @win.addstr contents @win.refresh end
Set position before each draw
diff --git a/lib/tty.rb b/lib/tty.rb index abc1234..def5678 100644 --- a/lib/tty.rb +++ b/lib/tty.rb @@ -41,6 +41,9 @@ # Raised when the argument validation fails class ArgumentValidation < ArgumentError; end + # Raised when the argument is not expected + class InvalidArgument < ArgumentError; end + # Raise...
Add invalid argument error type.
diff --git a/postman.rb b/postman.rb index abc1234..def5678 100644 --- a/postman.rb +++ b/postman.rb @@ -28,18 +28,18 @@ @@normal_sleep += 1 @@low_sleep += 1 - if(@@normal_sleep == 12) + if(@@normal_sleep == Postman.settings['normal_sleep']) mails.concat Postman.find_mails(MailNormal, ...
Move sleep variables into settings file
diff --git a/config/subscribers/customer.rb b/config/subscribers/customer.rb index abc1234..def5678 100644 --- a/config/subscribers/customer.rb +++ b/config/subscribers/customer.rb @@ -8,7 +8,7 @@ :deleted_at, :bill_to_location_id, :ship_to_location_id, - :is...
Remove incorrect c from is_tax_exempt
diff --git a/app/models/hyrax/uploaded_file.rb b/app/models/hyrax/uploaded_file.rb index abc1234..def5678 100644 --- a/app/models/hyrax/uploaded_file.rb +++ b/app/models/hyrax/uploaded_file.rb @@ -10,7 +10,5 @@ class_name: 'JobIoWrapper', dependent: :destroy belongs_to :user, class_name:...
Remove unnecessary callback Carrierwave installs an after_commit callback to run delete_file!
diff --git a/EnumeratorKit.podspec b/EnumeratorKit.podspec index abc1234..def5678 100644 --- a/EnumeratorKit.podspec +++ b/EnumeratorKit.podspec @@ -16,7 +16,6 @@ collection classes. EOS - s.ios.deployment_target = '5.1.1' s.requires_arc = true s.homepage = 'https://github.com/sharplet/EnumeratorK...
Remove explicit iOS deployment target from podspec
diff --git a/GDPerformanceView.podspec b/GDPerformanceView.podspec index abc1234..def5678 100644 --- a/GDPerformanceView.podspec +++ b/GDPerformanceView.podspec @@ -7,8 +7,8 @@ s.author = { "Gavrilov Daniil" => "daniilmbox@gmail.com" } s.platform = :ios, "8.0" s.ios.deployment_target = "8.0" - s.sour...
Fix pod spec frameworks list Remove ‘mach’ from list, because it is not a framework
diff --git a/yaks-html/lib/yaks-html.rb b/yaks-html/lib/yaks-html.rb index abc1234..def5678 100644 --- a/yaks-html/lib/yaks-html.rb +++ b/yaks-html/lib/yaks-html.rb @@ -3,6 +3,6 @@ require 'yaks/format/html' -> do - unparser = Hexp::Unparser.new({}) + unparser = Hexp::Unparser.new({no_escape: [:script, :style]}) ...
Stop Hexp from escaping `<style>` stuff This will be fixed in Hexp as well, but this way people aren't forced to upgrade.
diff --git a/.delivery/build/metadata.rb b/.delivery/build/metadata.rb index abc1234..def5678 100644 --- a/.delivery/build/metadata.rb +++ b/.delivery/build/metadata.rb @@ -10,3 +10,4 @@ depends 's3_file' depends 'delivery-red-pill' depends 'delivery-sugar-extras' +depends 'fancy_execute'
Use fancy_execute in the pipeline We would like to be able to see what the commands that ran successsfully displays to the STDOUT. By depending in `fancy_execute` that overrides the `execute` resource in chef we will be able to do it.
diff --git a/test/unit/resources/global_spec.rb b/test/unit/resources/global_spec.rb index abc1234..def5678 100644 --- a/test/unit/resources/global_spec.rb +++ b/test/unit/resources/global_spec.rb @@ -0,0 +1,49 @@+require "chef/resource/lwrp_base" + +unless Chef::Resource.const_defined?("RbenvGlobal") + Chef::Resource...
Add spec coverage for rbenv_global resource.
diff --git a/app/models/answer.rb b/app/models/answer.rb index abc1234..def5678 100644 --- a/app/models/answer.rb +++ b/app/models/answer.rb @@ -1,6 +1,4 @@ class Answer < ActiveRecord::Base belongs_to :question belongs_to :user - - attr_accessible :body, :question_id, :user_id end
Remove attr_accessible calls for Rails4
diff --git a/lib/hightops.rb b/lib/hightops.rb index abc1234..def5678 100644 --- a/lib/hightops.rb +++ b/lib/hightops.rb @@ -20,12 +20,19 @@ if block_given? yield config + serverengine_config = { + supervisor: true, + daemon_process_name: "hightops-supervisor-#{config.project_n...
Add customization options for serverengine
diff --git a/lib/hubstats.rb b/lib/hubstats.rb index abc1234..def5678 100644 --- a/lib/hubstats.rb +++ b/lib/hubstats.rb @@ -6,4 +6,7 @@ require "hubstats/config" module Hubstats + def self.config + @@config ||= Hubstats::Config.parse + end end
Add back in the config method on Hubstats
diff --git a/lib/jukeberx.rb b/lib/jukeberx.rb index abc1234..def5678 100644 --- a/lib/jukeberx.rb +++ b/lib/jukeberx.rb @@ -1,5 +1,56 @@ require "jukeberx/version" +require "jukeberx/song" +require "jukeberx/searcher" + +require "sinatra/base" +require "json" +require "pry" + +MUSIC_DIR = "/Users/brit/Music/downloads"...
Add a basic API for song playback.
diff --git a/lib/sem_info.rb b/lib/sem_info.rb index abc1234..def5678 100644 --- a/lib/sem_info.rb +++ b/lib/sem_info.rb @@ -3,7 +3,11 @@ def SemInfo.tag(args) subcommand = args.shift if subcommand == "latest" - ::SemInfo::Tag.latest.to_version_string + if latest = ::SemInfo::Tag.latest + l...
Fix NPE when there are no git tags
diff --git a/tasks.rb b/tasks.rb index abc1234..def5678 100644 --- a/tasks.rb +++ b/tasks.rb @@ -12,6 +12,7 @@ end end sh "./codegen.py spec #{spec} lib/amqp/protocol.rb" + sh "ruby -c lib/amqp/protocol.rb" end end
Check syntax of the generated Ruby file.
diff --git a/pco_api.gemspec b/pco_api.gemspec index abc1234..def5678 100644 --- a/pco_api.gemspec +++ b/pco_api.gemspec @@ -6,7 +6,7 @@ s.homepage = "https://github.com/planningcenter/pco_api_ruby" s.summary = "Ruby wrapper for api.planningcenteronline.com" s.description = "Ruby wrapper for api.planning...
Fix author setting in gemspec
diff --git a/lib/condition/condition_format.rb b/lib/condition/condition_format.rb index abc1234..def5678 100644 --- a/lib/condition/condition_format.rb +++ b/lib/condition/condition_format.rb @@ -8,7 +8,18 @@ def search(db) @format = Format[@format_name].new(db.resolve_time(@time)) - db.cards.values.select...
Speed up ConditionFormat for small formats
diff --git a/lib/middleman-s3_sync/commands.rb b/lib/middleman-s3_sync/commands.rb index abc1234..def5678 100644 --- a/lib/middleman-s3_sync/commands.rb +++ b/lib/middleman-s3_sync/commands.rb @@ -24,9 +24,9 @@ def s3_sync shared_inst = ::Middleman::Application.server.inst - bucket = shared_inst...
Return nil if the extension isn't loaded, update the error message.
diff --git a/lib/diaclone/result.rb b/lib/diaclone/result.rb index abc1234..def5678 100644 --- a/lib/diaclone/result.rb +++ b/lib/diaclone/result.rb @@ -0,0 +1,78 @@+# Parse result that's passed around in the stack and eventually returned +# at the end of parsing. Includes a `lines` array for holding each line +# of th...
Add Diaclone::Result, the object that transformers pass around
diff --git a/lib/dimples/archive.rb b/lib/dimples/archive.rb index abc1234..def5678 100644 --- a/lib/dimples/archive.rb +++ b/lib/dimples/archive.rb @@ -0,0 +1,64 @@+# frozen_string_literal: true + +module Dimples + # A collection of posts, organised by date. + class Archive + def initialize + @years = {} + ...
Add the new Archive class
diff --git a/plugin.rb b/plugin.rb index abc1234..def5678 100644 --- a/plugin.rb +++ b/plugin.rb @@ -13,11 +13,11 @@ enabled_site_setting :rocketchatsso_enabled +load Rails.root.join( 'plugins', 'rocketchat-sso', 'lib', 'engine.rb' ).to_s + def rocketchatsso_require( path ) require Rails.root.join( 'plugins',...
Fix loading of controllers, jobs
diff --git a/lib/la_maquina/dependency_map/yaml_map.rb b/lib/la_maquina/dependency_map/yaml_map.rb index abc1234..def5678 100644 --- a/lib/la_maquina/dependency_map/yaml_map.rb +++ b/lib/la_maquina/dependency_map/yaml_map.rb @@ -5,6 +5,7 @@ submap = map args.each do |key| submap = submap[key...
Allow for anything in the yaml find chain to be not found
diff --git a/lib/rails_autoscale_agent/registration.rb b/lib/rails_autoscale_agent/registration.rb index abc1234..def5678 100644 --- a/lib/rails_autoscale_agent/registration.rb +++ b/lib/rails_autoscale_agent/registration.rb @@ -10,7 +10,7 @@ dyno: config.dyno, pid: config.pid, ruby_version: R...
Check for the presence of Rails before using it
diff --git a/lib/biased/client.rb b/lib/biased/client.rb index abc1234..def5678 100644 --- a/lib/biased/client.rb +++ b/lib/biased/client.rb @@ -2,10 +2,12 @@ require "wikipedia" module Biased + # The main class that a end user will use to interact with the application. # @author Justin Harrison # @since 0.0....
Include more documentation for Biased::Client
diff --git a/lib/emcee/railtie.rb b/lib/emcee/railtie.rb index abc1234..def5678 100644 --- a/lib/emcee/railtie.rb +++ b/lib/emcee/railtie.rb @@ -7,6 +7,7 @@ module Emcee class Railtie < Rails::Railtie initializer :add_preprocessors do |app| + app.assets.register_mime_type "text/html", ".html" app.as...
Add back in mime type declaration For html
diff --git a/lib/gitlab/ci/status/core.rb b/lib/gitlab/ci/status/core.rb index abc1234..def5678 100644 --- a/lib/gitlab/ci/status/core.rb +++ b/lib/gitlab/ci/status/core.rb @@ -23,7 +23,7 @@ end def group - self.class.name.demodulize.downcase.underscore + self.class.name.demodulize....
Improve how we calculate detailed status group name
diff --git a/lib/openlogi/api/endpoint.rb b/lib/openlogi/api/endpoint.rb index abc1234..def5678 100644 --- a/lib/openlogi/api/endpoint.rb +++ b/lib/openlogi/api/endpoint.rb @@ -5,26 +5,6 @@ def initialize(client) @client = client - end - - def find(id) - raise NotImplementedError - ...
Remove placeholder actions in Openlogi::Api::Endpoint We don't really need these.
diff --git a/lib/roda/plugins/dry_view.rb b/lib/roda/plugins/dry_view.rb index abc1234..def5678 100644 --- a/lib/roda/plugins/dry_view.rb +++ b/lib/roda/plugins/dry_view.rb @@ -13,12 +13,16 @@ def view_context_options {} end + + def view_key(name) + "views.#{name}" + e...
Add ability to define a custom view key resolver
diff --git a/lib/ruote/postgres/worker.rb b/lib/ruote/postgres/worker.rb index abc1234..def5678 100644 --- a/lib/ruote/postgres/worker.rb +++ b/lib/ruote/postgres/worker.rb @@ -2,7 +2,7 @@ Ruote::Worker.class_eval do def run - @storage.wait_for_notify(6) do + @storage.wait_for_notify(60) do step ...
Update timeout to 60 seconds
diff --git a/library/fiber/resume_spec.rb b/library/fiber/resume_spec.rb index abc1234..def5678 100644 --- a/library/fiber/resume_spec.rb +++ b/library/fiber/resume_spec.rb @@ -10,6 +10,12 @@ fiber2.resume -> { fiber2.resume }.should raise_error(FiberError) end + + it "raises a FiberError if the Fi...
Add spec to cover resume a resuming fiber error
diff --git a/app/mailers/application_mailer.rb b/app/mailers/application_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/application_mailer.rb +++ b/app/mailers/application_mailer.rb @@ -1,4 +1,4 @@ class ApplicationMailer < ActionMailer::Base - default from: Woodlock.site_name + default from: Woodlock.site...
Fix default mailer <from> reference.
diff --git a/app/models/campus_activity_set.rb b/app/models/campus_activity_set.rb index abc1234..def5678 100644 --- a/app/models/campus_activity_set.rb +++ b/app/models/campus_activity_set.rb @@ -1,2 +1,7 @@ class CampusActivitySet < ActiveRecord::Base + belongs_to :campus + belongs_to :unit_activity_set + + valida...
ENHANCE: Validate the presence of campus and unit activity set
diff --git a/app/workers/music_graph_worker.rb b/app/workers/music_graph_worker.rb index abc1234..def5678 100644 --- a/app/workers/music_graph_worker.rb +++ b/app/workers/music_graph_worker.rb @@ -1,18 +1,18 @@- -class MusicGraphWorker - include Sidekiq::Worker - - def perform - # @word = "coffee" - # url = "ht...
Comment out ununsed Sidekiq worker code
diff --git a/config/environments/production.rb b/config/environments/production.rb index abc1234..def5678 100644 --- a/config/environments/production.rb +++ b/config/environments/production.rb @@ -1,4 +1,3 @@-require Rails.root.join("config/smtp") Rails.application.configure do config.cache_classes = true config...
Remove reference to old smtp (MailGun) config
diff --git a/config/initializers/extensions.rb b/config/initializers/extensions.rb index abc1234..def5678 100644 --- a/config/initializers/extensions.rb +++ b/config/initializers/extensions.rb @@ -1,4 +1,4 @@-Rails.application.config.after_initialize do +Rails.application.config.before_initialize do extensions_path ...
Load Extensions before rails initialize
diff --git a/core/spec/models/taxonomy_spec.rb b/core/spec/models/taxonomy_spec.rb index abc1234..def5678 100644 --- a/core/spec/models/taxonomy_spec.rb +++ b/core/spec/models/taxonomy_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Taxonomy do +describe Spree::Taxonomy do context "validation" do it...
Correct reference in Taxonomy spec
diff --git a/lib/generators/rain/install/install_generator.rb b/lib/generators/rain/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/rain/install/install_generator.rb +++ b/lib/generators/rain/install/install_generator.rb @@ -3,7 +3,7 @@ source_root File.expand_path('../templates', __...
Fix source path in generator
diff --git a/lib/tasks/publishing_api/publish_api_prefix.rake b/lib/tasks/publishing_api/publish_api_prefix.rake index abc1234..def5678 100644 --- a/lib/tasks/publishing_api/publish_api_prefix.rake +++ b/lib/tasks/publishing_api/publish_api_prefix.rake @@ -0,0 +1,33 @@+require 'logger' +require 'gds_api/publishing_api'...
Bring back /api prefix by publishing it to publishing-api This commit makes content-tagger the publishing-app of `/api` prefix, this is because content-api has been retired. This commit also aims to fix the unpublishing of the /api prefix which was done [here](https://github.com/alphagov/content-tagger/pull/369/commi...
diff --git a/lib/aws/plugins/content_length.rb b/lib/aws/plugins/content_length.rb index abc1234..def5678 100644 --- a/lib/aws/plugins/content_length.rb +++ b/lib/aws/plugins/content_length.rb @@ -16,7 +16,7 @@ module Aws module Plugins class ContentLength < Seahorse::Client::Plugin - handle_request :Handl...
Set the content-length plugin to lowest priority.
diff --git a/lib/capistrano-info/capistrano.rb b/lib/capistrano-info/capistrano.rb index abc1234..def5678 100644 --- a/lib/capistrano-info/capistrano.rb +++ b/lib/capistrano-info/capistrano.rb @@ -23,7 +23,11 @@ rel_date = Time.local(*rel.unpack("a4a2a2a2a2a2")) version_file = "#{current_path}/VERSION" -...
Handle "failed" reading of VERSION-file silently
diff --git a/lib/geocoder/results/nominatim.rb b/lib/geocoder/results/nominatim.rb index abc1234..def5678 100644 --- a/lib/geocoder/results/nominatim.rb +++ b/lib/geocoder/results/nominatim.rb @@ -20,7 +20,7 @@ end def village - @data['address']['villiage'] + @data['address']['village'] end ...
Fix a typo 'villiage' with village
diff --git a/MagicalRecord.podspec b/MagicalRecord.podspec index abc1234..def5678 100644 --- a/MagicalRecord.podspec +++ b/MagicalRecord.podspec @@ -1,6 +1,5 @@ Pod::Spec.new do |s| s.name = 'MagicalRecord' - s.version = '1.8' s.license = 'MIT' s.summary = 'Effortless fetching, saving, and importing fo...
Prepare Pod Spec for ad-hoc usage. Signed-off-by: Zachary Waldowski <f6cb034ae1bf314d2c0261a7a22e4684d1f74b57@gmail.com>
diff --git a/db/data_migration/20180802133114_update_html_attachment_slug.rb b/db/data_migration/20180802133114_update_html_attachment_slug.rb index abc1234..def5678 100644 --- a/db/data_migration/20180802133114_update_html_attachment_slug.rb +++ b/db/data_migration/20180802133114_update_html_attachment_slug.rb @@ -0,0...
Update html attachment slug for Brexit document
diff --git a/db/migrate/20170714092132_add_engagement_to_entry_enclosures.rb b/db/migrate/20170714092132_add_engagement_to_entry_enclosures.rb index abc1234..def5678 100644 --- a/db/migrate/20170714092132_add_engagement_to_entry_enclosures.rb +++ b/db/migrate/20170714092132_add_engagement_to_entry_enclosures.rb @@ -0,0...
Add migration: add engagment to entry_enclosures
diff --git a/app/controllers/games_controller.rb b/app/controllers/games_controller.rb index abc1234..def5678 100644 --- a/app/controllers/games_controller.rb +++ b/app/controllers/games_controller.rb @@ -3,7 +3,7 @@ @title = '301' @scores = [] - 10.times do + 12.times do @scores.push(0) en...
Change row number to 12
diff --git a/app/controllers/rooms_controller.rb b/app/controllers/rooms_controller.rb index abc1234..def5678 100644 --- a/app/controllers/rooms_controller.rb +++ b/app/controllers/rooms_controller.rb @@ -2,7 +2,7 @@ before_action :authenticate, except: [:github] def index - @rooms = current_user.rooms + @...
Add order in room list
diff --git a/app/lib/activitypub/activity/add.rb b/app/lib/activitypub/activity/add.rb index abc1234..def5678 100644 --- a/app/lib/activitypub/activity/add.rb +++ b/app/lib/activitypub/activity/add.rb @@ -7,7 +7,7 @@ status = status_from_uri(object_uri) status ||= fetch_remote_original_status - return u...
Fix spurious errors when receiving an Add activity for a private post
diff --git a/lib/inline_svg/transform_pipeline/transformations/no_comment.rb b/lib/inline_svg/transform_pipeline/transformations/no_comment.rb index abc1234..def5678 100644 --- a/lib/inline_svg/transform_pipeline/transformations/no_comment.rb +++ b/lib/inline_svg/transform_pipeline/transformations/no_comment.rb @@ -2,1...
Handle documents without SVG root elements
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -8,4 +8,4 @@ puts 'Equivalent of ActiveModel::Errors#messages' puts password.errors.to_h puts password.errors.to_a.inspect -exit 1 unless password.errors.any? +exit 1 if password.errors.any?
Fix exit signal of executed script
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -11,6 +11,7 @@ require 'rails_xss_helper' require 'av_patch' -rescue LoadError +rescue LoadError => e puts "Could not load all modules required by rails_xss. Please make sure erubis is installed an try again." + raise...
Abort loading if there's a LoadError
diff --git a/lib/vSphere/action/vim_helpers.rb b/lib/vSphere/action/vim_helpers.rb index abc1234..def5678 100644 --- a/lib/vSphere/action/vim_helpers.rb +++ b/lib/vSphere/action/vim_helpers.rb @@ -13,8 +13,8 @@ end def get_resource_pool(connection, machine) - cr = get_datacenter(connection, ...
Correct typo 'erorrs' -> 'errors'
diff --git a/app/mailers/spree/email_delivery_mailer.rb b/app/mailers/spree/email_delivery_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/spree/email_delivery_mailer.rb +++ b/app/mailers/spree/email_delivery_mailer.rb @@ -3,6 +3,4 @@ @inventory_units = shipment.inventory_units mail :to => shipment.o...
Revert "Send license key email asynchronously." This reverts commit 5c27d5745aa9df94bcf9071df197076599e144db. We added this after we had issues with sendgrid that caused delayed jobs to fail and re-send license keys, but the commit does not actually work: it makes email_delivery_email asynchronous so it returns `nil`...
diff --git a/lib/websocket/server_handshake.rb b/lib/websocket/server_handshake.rb index abc1234..def5678 100644 --- a/lib/websocket/server_handshake.rb +++ b/lib/websocket/server_handshake.rb @@ -7,17 +7,20 @@ end def render(out) - response_header = "#{@version} #{@status} #{@reason}#{CRLF}" + out...
Split data generation and rendering in server handshake
diff --git a/delayed_job_active_record.gemspec b/delayed_job_active_record.gemspec index abc1234..def5678 100644 --- a/delayed_job_active_record.gemspec +++ b/delayed_job_active_record.gemspec @@ -16,7 +16,7 @@ s.test_files = Dir.glob('spec/**/*') s.add_runtime_dependency 'activerecord', '> 2.1.0' -...
Use pessimistic version constraint to allow latest pre-release delayed_job http://docs.rubygems.org/read/chapter/16#page74
diff --git a/gir_ffi.gemspec b/gir_ffi.gemspec index abc1234..def5678 100644 --- a/gir_ffi.gemspec +++ b/gir_ffi.gemspec @@ -4,7 +4,6 @@ Gem::Specification.new do |s| s.name = "gir_ffi" s.version = GirFFI::VERSION - s.date = Date.today.to_s s.summary = "FFI-based GObject binding using the GObject Introspect...
Remove superfluous date setting in gemspec.
diff --git a/IKEventSource.podspec b/IKEventSource.podspec index abc1234..def5678 100644 --- a/IKEventSource.podspec +++ b/IKEventSource.podspec @@ -12,5 +12,5 @@ s.tvos.deployment_target = '9.0' s.osx.deployment_target = '10.10' s.source = { :git => "https://github.com/inaka/EventSource.git" } - s.sourc...
Update podspec source files path
diff --git a/cookbooks/rbenv/recipes/default.rb b/cookbooks/rbenv/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/rbenv/recipes/default.rb +++ b/cookbooks/rbenv/recipes/default.rb @@ -42,14 +42,3 @@ group "mzp" mode 0644 end - -%w(2.1.0-rc1).each do|version| - bash "install #{version}" do - u...
Revert "update recipe: install ruby 2.1.0-rc1" This reverts commit 7eee16d7a76c806ada686605f9dd986dba97b2d9.
diff --git a/debug-extras.gemspec b/debug-extras.gemspec index abc1234..def5678 100644 --- a/debug-extras.gemspec +++ b/debug-extras.gemspec @@ -1,7 +1,7 @@ # coding: utf-8 -lib = File.expand_path('../lib', __FILE__) +lib = File.expand_path("../lib", __FILE__) $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) -r...
Move gemspec to double quotes.
diff --git a/test/dummy/config/application.rb b/test/dummy/config/application.rb index abc1234..def5678 100644 --- a/test/dummy/config/application.rb +++ b/test/dummy/config/application.rb @@ -26,6 +26,19 @@ # For long-polling 45 seconds timeout seems reasonable. config.web_console.timeout = 45.seconds ...
Add color switching ENV vars to the dummy app
diff --git a/plugins/httpwatch.rb b/plugins/httpwatch.rb index abc1234..def5678 100644 --- a/plugins/httpwatch.rb +++ b/plugins/httpwatch.rb @@ -0,0 +1,64 @@+require 'digest' +require 'zmb/timer' + +class HttpWatch + attr_accessor :settings + + def initialize(sender, s) + @delegate = sender + @settings = s + ...
Add a plugin to watch a url for changes
diff --git a/plugins/ohai_solo.rb b/plugins/ohai_solo.rb index abc1234..def5678 100644 --- a/plugins/ohai_solo.rb +++ b/plugins/ohai_solo.rb @@ -0,0 +1,10 @@+provides "ohai_solo" + +def parse_version(versionfile) + data = File.open(versionfile) {|f| f.readline}.strip + version = data.split(" ")[1] + return version +...
Add plugin to report ohai-solo version
diff --git a/lib/mutant/mutator/node/named_value/variable_assignment.rb b/lib/mutant/mutator/node/named_value/variable_assignment.rb index abc1234..def5678 100644 --- a/lib/mutant/mutator/node/named_value/variable_assignment.rb +++ b/lib/mutant/mutator/node/named_value/variable_assignment.rb @@ -39,7 +39,7 @@ ...
Change variable interpolation into simpler to read statement
diff --git a/did_you_mean.gemspec b/did_you_mean.gemspec index abc1234..def5678 100644 --- a/did_you_mean.gemspec +++ b/did_you_mean.gemspec @@ -13,7 +13,7 @@ spec.homepage = "https://github.com/yuki24/did_you_mean" spec.license = "MIT" - spec.files = `git ls-files`.split($/) + spec.files ...
Exclude non-production code that has a non-commercial license closes #105
diff --git a/app/models/authorization.rb b/app/models/authorization.rb index abc1234..def5678 100644 --- a/app/models/authorization.rb +++ b/app/models/authorization.rb @@ -36,7 +36,7 @@ def token_auth_podcasts if token.globally_authorized?('read-private') - Podcast.all + Podcast.with_deleted.all ...
Include deleted only on wildcard requests
diff --git a/week-4/basic-math.rb b/week-4/basic-math.rb index abc1234..def5678 100644 --- a/week-4/basic-math.rb +++ b/week-4/basic-math.rb @@ -0,0 +1,86 @@+# Solution Below + +num1 = 7 +num2 = 13 +sum = num1 + num2 +difference = num1 - num2 +quotient = num1.to_f/num2.to_f +product = num1 * num2 +modulus = num1 % num2...
Create basic math tests for basic integers
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,5 +1,7 @@ class UsersController < ApplicationController include Orderable + + respond_to :html, :json, :js, :...
Use responders in users controller
diff --git a/app/helpers/claim_reviews_helper.rb b/app/helpers/claim_reviews_helper.rb index abc1234..def5678 100644 --- a/app/helpers/claim_reviews_helper.rb +++ b/app/helpers/claim_reviews_helper.rb @@ -6,10 +6,6 @@ message: t('.incomplete_claim_message') } end - end - - def review_header - I...
Remove unused helper method in the claims reviews helper
diff --git a/app/models/concerns/api_resource.rb b/app/models/concerns/api_resource.rb index abc1234..def5678 100644 --- a/app/models/concerns/api_resource.rb +++ b/app/models/concerns/api_resource.rb @@ -2,9 +2,8 @@ extend ActiveSupport::Concern included do - cattr_accessor(:panoptes_attributes) do - ...
Use class_attribute instead of cattr_accessor
diff --git a/queue/lib/flow/queue/transport.rb b/queue/lib/flow/queue/transport.rb index abc1234..def5678 100644 --- a/queue/lib/flow/queue/transport.rb +++ b/queue/lib/flow/queue/transport.rb @@ -15,9 +15,13 @@ def transform(type, data) queue = @router ? @router.call(data) : @queue - queue = flow.queue_pro...
Support skipping queue (local mode)
diff --git a/omnibus/config/software/pushy-server-cookbooks.rb b/omnibus/config/software/pushy-server-cookbooks.rb index abc1234..def5678 100644 --- a/omnibus/config/software/pushy-server-cookbooks.rb +++ b/omnibus/config/software/pushy-server-cookbooks.rb @@ -6,33 +6,30 @@ name "pushy-server-cookbooks" +source pat...
Make cookbooks software definition consistent with other projects.
diff --git a/spec/gc.rb b/spec/gc.rb index abc1234..def5678 100644 --- a/spec/gc.rb +++ b/spec/gc.rb @@ -0,0 +1,103 @@+#!/usr/bin/env ruby + +require 'rubygems' +require 'bacon' +require "#{File.expand_path(File.dirname(__FILE__))}/../lib/bitcask" + +unless ARGV.first + puts "I need a bitcask directory." + exit 1 +en...
Add spec to verify filehandle closing on GC.
diff --git a/spec/lib/initializers/zz_patch_reconnect_spec.rb b/spec/lib/initializers/zz_patch_reconnect_spec.rb index abc1234..def5678 100644 --- a/spec/lib/initializers/zz_patch_reconnect_spec.rb +++ b/spec/lib/initializers/zz_patch_reconnect_spec.rb @@ -0,0 +1,19 @@+# encoding: utf-8 + +require_relative '../../spec_...
Add spec for AR reconnection monkeypatching
diff --git a/lib/capistrano/tasks/shared.rake b/lib/capistrano/tasks/shared.rake index abc1234..def5678 100644 --- a/lib/capistrano/tasks/shared.rake +++ b/lib/capistrano/tasks/shared.rake @@ -1,3 +1,11 @@+# +# Manage shared files +# +# Configuration: +# +# - `shared_rsync_options`: Allow to specify which options to be...
Add some documentation, update default filter
diff --git a/lib/github_cli/commands/users.rb b/lib/github_cli/commands/users.rb index abc1234..def5678 100644 --- a/lib/github_cli/commands/users.rb +++ b/lib/github_cli/commands/users.rb @@ -5,17 +5,41 @@ namespace :user + desc 'list', 'List all users' + option :since, :type => :string, :banner => "<use...
Add user listing command and add options support.
diff --git a/lib/jmespath/nodes/projection.rb b/lib/jmespath/nodes/projection.rb index abc1234..def5678 100644 --- a/lib/jmespath/nodes/projection.rb +++ b/lib/jmespath/nodes/projection.rb @@ -11,7 +11,8 @@ if (targets = extract_targets(@target.visit(value))) list = [] targets.each do |v| ...
Fix a bug in Projection It shouldn't skip false values, just nil values
diff --git a/lib/net/ptth/incoming_request.rb b/lib/net/ptth/incoming_request.rb index abc1234..def5678 100644 --- a/lib/net/ptth/incoming_request.rb +++ b/lib/net/ptth/incoming_request.rb @@ -11,6 +11,8 @@ env["CONTENT_LENGTH"] = body.length unless body.nil? env.merge!(headers) if headers + + env ...
Make sure env is always returned If headers is nil here, the method previously returned nil.
diff --git a/lib/traitdb_import/downloader.rb b/lib/traitdb_import/downloader.rb index abc1234..def5678 100644 --- a/lib/traitdb_import/downloader.rb +++ b/lib/traitdb_import/downloader.rb @@ -0,0 +1,27 @@+require 'net/http' +require 'uri' + +# initialize with url +# return path to downloaded file on local file system ...
Add skeleton class for downloading files, not functional
diff --git a/app/models/application_record.rb b/app/models/application_record.rb index abc1234..def5678 100644 --- a/app/models/application_record.rb +++ b/app/models/application_record.rb @@ -4,7 +4,7 @@ self.abstract_class = true def self.raise_not_implemented_error - raise NotImplementedError, "Subclass sh...
Update method to get name of called method for Ruby 2.0+
diff --git a/app/models/quota_order_number.rb b/app/models/quota_order_number.rb index abc1234..def5678 100644 --- a/app/models/quota_order_number.rb +++ b/app/models/quota_order_number.rb @@ -1,6 +1,6 @@ class QuotaOrderNumber < Sequel::Model plugin :time_machine - plugin :oplog, primary_key: :quota_definition_sid...
Fix QuotaOrderNumber pk for oplog plugin
diff --git a/test/centos_spec.rb b/test/centos_spec.rb index abc1234..def5678 100644 --- a/test/centos_spec.rb +++ b/test/centos_spec.rb @@ -16,4 +16,12 @@ it 'should disable SELinux' do expect(selinux).to be_disabled end + + vbox_string = command("dmesg | grep VirtualBox").stdout + has_vbox = vbox_string.i...
Add test for slow DNS fix
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,4 +1,13 @@ require 'rubygems' + +if ENV['CODECLIMATE_REPO_TOKEN'] + require 'codeclimate-test-reporter' + CodeClimate::TestReporter.start +else + require 'simplecov' + Simpl...
Integrate code climate test coverage
diff --git a/test/test_octets.rb b/test/test_octets.rb index abc1234..def5678 100644 --- a/test/test_octets.rb +++ b/test/test_octets.rb @@ -20,6 +20,15 @@ assert_equal(0x01020304, o.to_i) end + def test_octets_single_octet + o = Octets.new + o.read("ABCD") + assert_equal(o.o1, 0x41) + assert_equal(o.o2, 0x42...
Add some single octet tests.