diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/chefspec/matchers/file_spec.rb b/spec/chefspec/matchers/file_spec.rb index abc1234..def5678 100644 --- a/spec/chefspec/matchers/file_spec.rb +++ b/spec/chefspec/matchers/file_spec.rb @@ -22,5 +22,18 @@ end end end + + describe :create_remote_file do + describe "#match" do +...
Add specs for matcher create_remote_file.
diff --git a/spec/factories/published_entries.rb b/spec/factories/published_entries.rb index abc1234..def5678 100644 --- a/spec/factories/published_entries.rb +++ b/spec/factories/published_entries.rb @@ -2,7 +2,7 @@ FactoryBot.define do factory :published_entry, class: PublishedEntry do transient do - ...
Fix scrolled entry json seed spec Set `type_name` of `published_entry` factory to `paged`. Previous `nil` value caused error when trying to construct entry type specic config. REDMINE-17257
diff --git a/spec/features/post_creation_spec.rb b/spec/features/post_creation_spec.rb index abc1234..def5678 100644 --- a/spec/features/post_creation_spec.rb +++ b/spec/features/post_creation_spec.rb @@ -0,0 +1,28 @@+require 'rails_helper' + +describe "Post creation" do + before do + # Sign in + @user = User.cr...
Add test for creating new posts
diff --git a/spec/controllers/medicaid/sign_and_submit_controller_spec.rb b/spec/controllers/medicaid/sign_and_submit_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/medicaid/sign_and_submit_controller_spec.rb +++ b/spec/controllers/medicaid/sign_and_submit_controller_spec.rb @@ -14,6 +14,7 @@ ...
Add explicit nil in test setup when checking attribute change
diff --git a/lib/docs/scrapers/react_native.rb b/lib/docs/scrapers/react_native.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/react_native.rb +++ b/lib/docs/scrapers/react_native.rb @@ -3,7 +3,7 @@ self.name = 'React Native' self.slug = 'react_native' self.type = 'react' - self.release = '0....
Update React Native documentation (0.40)
diff --git a/spec/unit/puppet/functions/validate_ip_address_array_spec.rb b/spec/unit/puppet/functions/validate_ip_address_array_spec.rb index abc1234..def5678 100644 --- a/spec/unit/puppet/functions/validate_ip_address_array_spec.rb +++ b/spec/unit/puppet/functions/validate_ip_address_array_spec.rb @@ -0,0 +1,43 @@+# ...
Add unit tests for validate_ip_address_array
diff --git a/puppet-lint-no_symbolic_file_modes-check.gemspec b/puppet-lint-no_symbolic_file_modes-check.gemspec index abc1234..def5678 100644 --- a/puppet-lint-no_symbolic_file_modes-check.gemspec +++ b/puppet-lint-no_symbolic_file_modes-check.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |spec| spec.name ...
Allow puppet-lint 2.0 as a dependency and bump check version
diff --git a/test/test_samples.rb b/test/test_samples.rb index abc1234..def5678 100644 --- a/test/test_samples.rb +++ b/test/test_samples.rb @@ -1,4 +1,6 @@ require 'linguist/samples' +require 'tempfile' +require 'yajl' require 'test/unit' @@ -12,6 +14,19 @@ # Just warn, it shouldn't scare people off by breaki...
Print out samples db diffs
diff --git a/lib/metacrunch/redis/queue_writer.rb b/lib/metacrunch/redis/queue_writer.rb index abc1234..def5678 100644 --- a/lib/metacrunch/redis/queue_writer.rb +++ b/lib/metacrunch/redis/queue_writer.rb @@ -6,6 +6,8 @@ def initialize(redis_connection_or_url, queue_name, options = {}) @queue_name = queue_na...
Save redis before the writer closes the connection. Can be disabled with save_on_close: false.
diff --git a/lib/refinery/elasticsearch/result.rb b/lib/refinery/elasticsearch/result.rb index abc1234..def5678 100644 --- a/lib/refinery/elasticsearch/result.rb +++ b/lib/refinery/elasticsearch/result.rb @@ -16,7 +16,7 @@ end def record - @record ||= klass.where(id:@result['_id']).first + ...
Use find instead of where
diff --git a/lib/utracker/logger/stdout_logger.rb b/lib/utracker/logger/stdout_logger.rb index abc1234..def5678 100644 --- a/lib/utracker/logger/stdout_logger.rb +++ b/lib/utracker/logger/stdout_logger.rb @@ -5,21 +5,14 @@ protected def write(event) - puts [ - event.datetime.to_s, - event.service, -...
Make the StdoutLogger output JSON.
diff --git a/lib/bugsnag/delivery/thread_queue.rb b/lib/bugsnag/delivery/thread_queue.rb index abc1234..def5678 100644 --- a/lib/bugsnag/delivery/thread_queue.rb +++ b/lib/bugsnag/delivery/thread_queue.rb @@ -5,10 +5,12 @@ class ThreadQueue < Synchronous MAX_OUTSTANDING_REQUESTS = 100 STOP = Object.ne...
Fix thread-queue delivery method under puma --preload
diff --git a/examples/enum_select.rb b/examples/enum_select.rb index abc1234..def5678 100644 --- a/examples/enum_select.rb +++ b/examples/enum_select.rb @@ -0,0 +1,7 @@+# encoding: utf-8 + +require 'tty-prompt' + +prompt = TTY::Prompt.new +choices = %w(/bin/nano /usr/bin/vim.basic /usr/bin/vim.tiny) +prompt.enum_select...
Add example of enumerated selection.
diff --git a/spec/dummy/app/controllers/welcome_controller.rb b/spec/dummy/app/controllers/welcome_controller.rb index abc1234..def5678 100644 --- a/spec/dummy/app/controllers/welcome_controller.rb +++ b/spec/dummy/app/controllers/welcome_controller.rb @@ -1,5 +1,5 @@ class WelcomeController < ApplicationController - ...
Fix Rails 5 deprecation warning for skip_before_action DEPRECATION WARNING: `skip_before_filter` is deprecated and will be removed in Rails 5.1. Use `skip_before_action` instead.
diff --git a/spec/st_scenario_spec.rb b/spec/st_scenario_spec.rb index abc1234..def5678 100644 --- a/spec/st_scenario_spec.rb +++ b/spec/st_scenario_spec.rb @@ -19,7 +19,7 @@ describe "#end_scenario" do it "returns true" do - @st.begin_scenario.should be_true + @st.end_scenario.should be_true en...
Use end_scenario in the end_scenario spec
diff --git a/lib/git_day_one/day_one_formatter.rb b/lib/git_day_one/day_one_formatter.rb index abc1234..def5678 100644 --- a/lib/git_day_one/day_one_formatter.rb +++ b/lib/git_day_one/day_one_formatter.rb @@ -0,0 +1,30 @@+module GitDayOne + class DayOneFormatter + attr_accessor :commits, :project + + def initial...
Add day one message formatter
diff --git a/lib/linkedcare/connection/handler.rb b/lib/linkedcare/connection/handler.rb index abc1234..def5678 100644 --- a/lib/linkedcare/connection/handler.rb +++ b/lib/linkedcare/connection/handler.rb @@ -47,7 +47,7 @@ begin subscriber.handler.call(meta, data) rescue Exception => e...
Add Exception to log when fail
diff --git a/lib/letter_opener/delivery_method.rb b/lib/letter_opener/delivery_method.rb index abc1234..def5678 100644 --- a/lib/letter_opener/delivery_method.rb +++ b/lib/letter_opener/delivery_method.rb @@ -22,7 +22,7 @@ location = File.join(settings[:location], "#{Time.now.to_f.to_s.tr('.', '_')}_#{Digest::SHA...
Make sure that global Launchy constant is used.
diff --git a/lib/puppet/provider/oratab/parsed.rb b/lib/puppet/provider/oratab/parsed.rb index abc1234..def5678 100644 --- a/lib/puppet/provider/oratab/parsed.rb +++ b/lib/puppet/provider/oratab/parsed.rb @@ -27,7 +27,7 @@ }, :to_line => proc { |h| str = "#{h[:name]}:#{h[:home]}:#{h[:atboot]}" - ...
Remove comment if description is empty If the description property is an empty string puppet should remove the comment sign (#) alltogether
diff --git a/lib/simple-api-auth/authenticator.rb b/lib/simple-api-auth/authenticator.rb index abc1234..def5678 100644 --- a/lib/simple-api-auth/authenticator.rb +++ b/lib/simple-api-auth/authenticator.rb @@ -1,6 +1,6 @@ module SimpleApiAuth class Authenticator - include RequestHelpers + include ::SimpleApiAut...
Fix incompatibility between Ruby versions.
diff --git a/lib/cached_resource.rb b/lib/cached_resource.rb index abc1234..def5678 100644 --- a/lib/cached_resource.rb +++ b/lib/cached_resource.rb @@ -9,12 +9,12 @@ module CachedResource - # Switch caching off + # Switch cache usage off def self.off! self.config.cache_enabled = false end - # Switc...
Clarify comments for on! and off! methods
diff --git a/lib/thunder_punch/recipes/bundler.rb b/lib/thunder_punch/recipes/bundler.rb index abc1234..def5678 100644 --- a/lib/thunder_punch/recipes/bundler.rb +++ b/lib/thunder_punch/recipes/bundler.rb @@ -5,7 +5,7 @@ desc "Install and lock bundle" task :bundle, :roles => bundler_roles do _cset(:excl...
Fix bug caused by use of wrong variable
diff --git a/db/migrate/20180417101940_add_index_to_ci_stage.rb b/db/migrate/20180417101940_add_index_to_ci_stage.rb index abc1234..def5678 100644 --- a/db/migrate/20180417101940_add_index_to_ci_stage.rb +++ b/db/migrate/20180417101940_add_index_to_ci_stage.rb @@ -4,6 +4,6 @@ DOWNTIME = false def change - add...
Use smallint for stage index column
diff --git a/lib/history_tracker.rb b/lib/history_tracker.rb index abc1234..def5678 100644 --- a/lib/history_tracker.rb +++ b/lib/history_tracker.rb @@ -37,6 +37,7 @@ end def current_modifier=(value) + return unless value config_store[:current_modifier] = value.attributes.slice(*current_user_fiel...
Fix when there is no current_user
diff --git a/lib/lj_media/author.rb b/lib/lj_media/author.rb index abc1234..def5678 100644 --- a/lib/lj_media/author.rb +++ b/lib/lj_media/author.rb @@ -39,7 +39,7 @@ # @param userid LiveJournal user id # @param username LiveJournal username # - # **TODO**: parse detailed user info from his profile p...
Use @todo in Author doc instead of **TODO** text [skip ci]
diff --git a/lib/localdoc/engine.rb b/lib/localdoc/engine.rb index abc1234..def5678 100644 --- a/lib/localdoc/engine.rb +++ b/lib/localdoc/engine.rb @@ -2,8 +2,6 @@ require "rails" require "action_view" require "haml" -require "bourbon" -require "neat" module Localdoc class Engine < ::Rails::Engine @@ -16,7 +14...
Complete the migration to webpack
diff --git a/lib/maildrop/client.rb b/lib/maildrop/client.rb index abc1234..def5678 100644 --- a/lib/maildrop/client.rb +++ b/lib/maildrop/client.rb @@ -26,7 +26,7 @@ end def share(path) - @client.share(path) + @client.shares(path) end private
Reword to shares not share
diff --git a/test/test_cmd_ls.rb b/test/test_cmd_ls.rb index abc1234..def5678 100644 --- a/test/test_cmd_ls.rb +++ b/test/test_cmd_ls.rb @@ -20,13 +20,13 @@ { 'Name' => 'foo.txt', 'Hash' => 'QmTz3oc4gdpRMKP2sdGUPZTAGRngqjsi99BPoztyP53JMM', - 'Size' => 12, +...
Adjust the expectation of a unit test to the changed behavior Since version 0.4.19 "ipfs ls" is reporting files size rather than DAG size, see https://github.com/ipfs/go-ipfs/blob/master/CHANGELOG.md#-file-listing
diff --git a/lib/soulmate/server.rb b/lib/soulmate/server.rb index abc1234..def5678 100644 --- a/lib/soulmate/server.rb +++ b/lib/soulmate/server.rb @@ -23,11 +23,12 @@ limit = (params[:limit] || 5).to_i types = params[:types].map { |t| normalize(t) } term = params[:term] - + cache = par...
Allow cache-busting via query params
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -5,7 +5,7 @@ add_filter 'bundle|vendor' end -require File.expand_path('../../config/environment', __FILE__) +require File.expand_path('../config/environment', __dir__) requir...
Modify to pass rubocop 0.53.0
diff --git a/Library/Homebrew/os/linux/hardware.rb b/Library/Homebrew/os/linux/hardware.rb index abc1234..def5678 100644 --- a/Library/Homebrew/os/linux/hardware.rb +++ b/Library/Homebrew/os/linux/hardware.rb @@ -11,30 +11,37 @@ def arch_64_bit; :x86_64; end def universal_archs; [].extend ArchitectureListExtension...
Linuxbrew: Read CPU flags from /proc/cpuinfo Closes #29895. Signed-off-by: Mike McQuaid <a17fed27eaa842282862ff7c1b9c8395a26ac320@mikemcquaid.com>
diff --git a/flexpaper-rails.gemspec b/flexpaper-rails.gemspec index abc1234..def5678 100644 --- a/flexpaper-rails.gemspec +++ b/flexpaper-rails.gemspec @@ -16,5 +16,5 @@ s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.rdoc"] s.add_dependency "rails", "~> 3.2.0" - # s.add_depende...
Add query as a dep
diff --git a/lib/tasks/sidekiq.rake b/lib/tasks/sidekiq.rake index abc1234..def5678 100644 --- a/lib/tasks/sidekiq.rake +++ b/lib/tasks/sidekiq.rake @@ -6,7 +6,7 @@ # sidekiq is already running, don't need to run if Sidekiq::ProcessSet.new.size == 0 ss = Sidekiq::ScheduledSet.new - if ss.first.at <...
Handle case when ScheduledSet is empty
diff --git a/db/migrate/20090316132151_disable_file_types.rb b/db/migrate/20090316132151_disable_file_types.rb index abc1234..def5678 100644 --- a/db/migrate/20090316132151_disable_file_types.rb +++ b/db/migrate/20090316132151_disable_file_types.rb @@ -3,7 +3,7 @@ Radiant::Config['assets.skip_filetype_validation'] ...
Fix migration by prefixing the Config module with Radiant Signed-off-by: Keith BIngman <0ccc0848a69a0c9f60128cfc9721e973b7acd43f@keithbingman.com>
diff --git a/db/migrate/20100322160212_delete_in_progress.rb b/db/migrate/20100322160212_delete_in_progress.rb index abc1234..def5678 100644 --- a/db/migrate/20100322160212_delete_in_progress.rb +++ b/db/migrate/20100322160212_delete_in_progress.rb @@ -8,6 +8,16 @@ end end Status.find_all_by_name("in pr...
Change migration from "In Progress" to "Open". Change task filter qualifiers for status from "In Progress" to "Open"
diff --git a/db/migrate/20170428031949_add_admin_to_users.rb b/db/migrate/20170428031949_add_admin_to_users.rb index abc1234..def5678 100644 --- a/db/migrate/20170428031949_add_admin_to_users.rb +++ b/db/migrate/20170428031949_add_admin_to_users.rb @@ -1,5 +1,5 @@ class AddAdminToUsers < ActiveRecord::Migration[5.0] ...
Add admin status to false by default when creating a user
diff --git a/spec/lita/adapters/shell_spec.rb b/spec/lita/adapters/shell_spec.rb index abc1234..def5678 100644 --- a/spec/lita/adapters/shell_spec.rb +++ b/spec/lita/adapters/shell_spec.rb @@ -1,7 +1,20 @@ describe Lita::Adapters::Shell do - let(:robot) { double("Robot") } + let(:robot) do + robot = double("Robot"...
Add coverage for Shell adapter's run method.
diff --git a/spec/mailers/game_mailer_spec.rb b/spec/mailers/game_mailer_spec.rb index abc1234..def5678 100644 --- a/spec/mailers/game_mailer_spec.rb +++ b/spec/mailers/game_mailer_spec.rb @@ -9,10 +9,6 @@ it "sends email to member" do expect(mailer).to deliver_to(member.email) - end - - it "sends email from...
Remove email check in game mailer spec
diff --git a/spec/mailers/user_mailer_spec.rb b/spec/mailers/user_mailer_spec.rb index abc1234..def5678 100644 --- a/spec/mailers/user_mailer_spec.rb +++ b/spec/mailers/user_mailer_spec.rb @@ -5,14 +5,14 @@ before do user = create(:user) - Spree::UserMailer.reset_password_instructions(user, 'token goes here...
Use deliver_later to fix deprecation.
diff --git a/lib/picturelife/base.rb b/lib/picturelife/base.rb index abc1234..def5678 100644 --- a/lib/picturelife/base.rb +++ b/lib/picturelife/base.rb @@ -16,7 +16,7 @@ end def authenticated? - @access_token + !! @access_token end def reset_configuration!
Fix authenticated? to return boolean
diff --git a/app/admin/dashboards.rb b/app/admin/dashboards.rb index abc1234..def5678 100644 --- a/app/admin/dashboards.rb +++ b/app/admin/dashboards.rb @@ -1,38 +1,33 @@-ActiveAdmin::Dashboards.build do +ActiveAdmin.register_page "Dashboard" do - # Define your dashboard sections here. Each block will be - # render...
Remove old style ActiveAdmin::Dashboard, use ActiveAdmin.register_page "Dashboard"
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -13,4 +13,9 @@ hard_music = FactoryGirl.create :hard_music FactoryGirl.create(:music_user, music: hard_music, user: user) end + + 10.times do + f = FactoryGirl.create(:friend) + FactoryGirl.cre...
Add seed data(user has many friends)
diff --git a/_rake/start_jekyll.rake b/_rake/start_jekyll.rake index abc1234..def5678 100644 --- a/_rake/start_jekyll.rake +++ b/_rake/start_jekyll.rake @@ -4,5 +4,17 @@ port = ENV['port'] || '4000' trace = ENV['trace'] == 'true' ? '--trace' : '' detach = ENV['detach'] == 'true' ? '--detach' : '' + + # Set active ...
Set active code page on Windows to avoid encoding issues
diff --git a/test/integration/ap_setup/rspec/ap_setup_spec.rb b/test/integration/ap_setup/rspec/ap_setup_spec.rb index abc1234..def5678 100644 --- a/test/integration/ap_setup/rspec/ap_setup_spec.rb +++ b/test/integration/ap_setup/rspec/ap_setup_spec.rb @@ -0,0 +1,58 @@+require 'spec_helper' +require 'json' + +describe ...
Add ap_setup spec of integration test of test-kicthen
diff --git a/event_store-client-http.gemspec b/event_store-client-http.gemspec index abc1234..def5678 100644 --- a/event_store-client-http.gemspec +++ b/event_store-client-http.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'event_store-client-http' - s.version = '0.3.0.0'...
Package version is increased from 0.3.0.0 to 0.4.0.0
diff --git a/spec/acceptance/documentation_spec.rb b/spec/acceptance/documentation_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/documentation_spec.rb +++ b/spec/acceptance/documentation_spec.rb @@ -0,0 +1,27 @@+require "json" +require "net/http" +require "uri" + +RSpec.describe "neovim-ruby documentation...
Add acceptance test around stale generated docs
diff --git a/active_importer.gemspec b/active_importer.gemspec index abc1234..def5678 100644 --- a/active_importer.gemspec +++ b/active_importer.gemspec @@ -10,7 +10,7 @@ spec.email = ["gnapse@gmail.com"] spec.description = %q{Import tabular data from spreadsheets or similar sources into data models} ...
Add homepage url to gemspec
diff --git a/spec/features/events_features_spec.rb b/spec/features/events_features_spec.rb index abc1234..def5678 100644 --- a/spec/features/events_features_spec.rb +++ b/spec/features/events_features_spec.rb @@ -31,11 +31,11 @@ page.should have_content "standalone" end - pending "should show the output...
Fix pending specs in events features
diff --git a/spec/session/remote_mechanize_spec.rb b/spec/session/remote_mechanize_spec.rb index abc1234..def5678 100644 --- a/spec/session/remote_mechanize_spec.rb +++ b/spec/session/remote_mechanize_spec.rb @@ -35,7 +35,7 @@ end end - # Pending: Still 90 (and before the update of capybara to 0.4.0 16)...
Update comment about failing specs, also need to find out why there are less failures now
diff --git a/spec/sub_diff/diff_collection_spec.rb b/spec/sub_diff/diff_collection_spec.rb index abc1234..def5678 100644 --- a/spec/sub_diff/diff_collection_spec.rb +++ b/spec/sub_diff/diff_collection_spec.rb @@ -12,7 +12,10 @@ end def diff(value) - double('diff', changed?: false, empty?: value.empty?, to_s: ...
Add `to_str` double mock for `Diff` objects Fixes `Double "diff" received unexpected message :to_str with (no args)` from `DiffCollection` specs.
diff --git a/app/models/blog_post.rb b/app/models/blog_post.rb index abc1234..def5678 100644 --- a/app/models/blog_post.rb +++ b/app/models/blog_post.rb @@ -10,13 +10,9 @@ title = self.title slug = title.gsub(/[^a-zA-Z\d\s]/, '').gsub(' ', '-').downcase - # TODO: revisit the following logic once the redir...
Change mind about redirect functionality, do not let people edit slugs
diff --git a/app/models/tent/site.rb b/app/models/tent/site.rb index abc1234..def5678 100644 --- a/app/models/tent/site.rb +++ b/app/models/tent/site.rb @@ -5,6 +5,7 @@ validates :title, :path, presence: true validates :path, length: { maximum: 50 } validates :path, format: { with: /\A(?:\p{Hiragana}|\p{K...
Use Tent::Site::RESERVED_PATHS when validate path
diff --git a/ar-audit-tracer.gemspec b/ar-audit-tracer.gemspec index abc1234..def5678 100644 --- a/ar-audit-tracer.gemspec +++ b/ar-audit-tracer.gemspec @@ -13,9 +13,7 @@ s.summary = %q{Track creator/modifiers of you AR Models similar to timestamps.} s.description = %q{Handles ActiveRecord authors in the same ...
Remove duplicate dependency on activerecord
diff --git a/time_guarded_run.rb b/time_guarded_run.rb index abc1234..def5678 100644 --- a/time_guarded_run.rb +++ b/time_guarded_run.rb @@ -22,5 +22,9 @@ exit end +if time.hour == start_hour + max_tweets = max_tweets_first_hour +end + puts "Running Konstabot with #{max_tweets} max tweets" system "ruby konstabo...
Allow for a larger number of tweets in the first hour
diff --git a/test/fixtures/schema.rb b/test/fixtures/schema.rb index abc1234..def5678 100644 --- a/test/fixtures/schema.rb +++ b/test/fixtures/schema.rb @@ -38,7 +38,7 @@ t.timestamps end - create_table :listings_locations, :force => true do |t| + create_table :listings_locations, :force => true, :id => fals...
Fix failing test under ActiveRecord 2.3.5.
diff --git a/app/models/task_definition_config.rb b/app/models/task_definition_config.rb index abc1234..def5678 100644 --- a/app/models/task_definition_config.rb +++ b/app/models/task_definition_config.rb @@ -0,0 +1,32 @@+class TaskDefinitionConfig + include ActiveModel::Model + + CONFIG_FILE = 'task_definition.yml'....
Add TaskDefinitionConfig that to load config from task_definition.yml
diff --git a/app/models/competitions/monday_pir.rb b/app/models/competitions/monday_pir.rb index abc1234..def5678 100644 --- a/app/models/competitions/monday_pir.rb +++ b/app/models/competitions/monday_pir.rb @@ -0,0 +1,87 @@+# frozen_string_literal: true + +module Competitions + class MondayPir < Competition + def...
Add Monday Night PIR monthly standings
diff --git a/recipes/rack-mini-profiler.rb b/recipes/rack-mini-profiler.rb index abc1234..def5678 100644 --- a/recipes/rack-mini-profiler.rb +++ b/recipes/rack-mini-profiler.rb @@ -14,7 +14,7 @@ gem 'rack-mini-profiler', group: :development text_to_add = <<-RUBY - before_filter :miniprofiler + before_action :minip...
Replace before_filter with before_action to use Rails 4 syntax
diff --git a/lib/faraday/adapter/patron.rb b/lib/faraday/adapter/patron.rb index abc1234..def5678 100644 --- a/lib/faraday/adapter/patron.rb +++ b/lib/faraday/adapter/patron.rb @@ -2,6 +2,11 @@ class Adapter class Patron < Faraday::Adapter dependency 'patron' + + def initialize(app, &block) + ...
Add ability to set options on Patron Session object. Example: Faraday.new(:url => url) do |conn| conn.adapter :patron do |session| session.handle_cookies end end
diff --git a/app/uploaders/hero_image_uploader.rb b/app/uploaders/hero_image_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/hero_image_uploader.rb +++ b/app/uploaders/hero_image_uploader.rb @@ -15,7 +15,7 @@ def apply_blur manipulate! do |img| - img = img.blur_image(0, 3) + img = img.b...
Add more blur to hero images
diff --git a/lib/metacrunch/job/context.rb b/lib/metacrunch/job/context.rb index abc1234..def5678 100644 --- a/lib/metacrunch/job/context.rb +++ b/lib/metacrunch/job/context.rb @@ -19,8 +19,8 @@ @job.destinations << destination if destination end - def pre_process(&block) - @job.pre_processes << bl...
Allow pre_process to handle callables.
diff --git a/lib/one_click_orgs/version.rb b/lib/one_click_orgs/version.rb index abc1234..def5678 100644 --- a/lib/one_click_orgs/version.rb +++ b/lib/one_click_orgs/version.rb @@ -1,5 +1,5 @@ module OneClickOrgs - VERSION = "1.0.0rc2" unless defined?(VERSION) + VERSION = "1.0.0rc2" unless defined?(::OneClickOrgs::VE...
Fix that OneClickOrgs::VERSION would not be defined due to presence of Ruby VERSION constant.
diff --git a/lib/tasks/import_racquet.rake b/lib/tasks/import_racquet.rake index abc1234..def5678 100644 --- a/lib/tasks/import_racquet.rake +++ b/lib/tasks/import_racquet.rake @@ -5,6 +5,6 @@ match_data = JSON.parse(HTTParty.get('http://racquet.io/pivotal-denver/matches.json?limit=500').body)['results'] match_d...
Add rake task for importing racquet data
diff --git a/tty-spinner.gemspec b/tty-spinner.gemspec index abc1234..def5678 100644 --- a/tty-spinner.gemspec +++ b/tty-spinner.gemspec @@ -19,9 +19,9 @@ spec.required_ruby_version = '>= 2.0.0' - spec.add_runtime_dependency 'tty-cursor', '~> 0.6.0' + spec.add_runtime_dependency 'tty-cursor', '~> 0.7' - spec...
Change to update dependency and relax bundler version
diff --git a/db/data_migration/20170818102913_send_missing_people_to_rummager.rb b/db/data_migration/20170818102913_send_missing_people_to_rummager.rb index abc1234..def5678 100644 --- a/db/data_migration/20170818102913_send_missing_people_to_rummager.rb +++ b/db/data_migration/20170818102913_send_missing_people_to_rum...
Add migration to send missing people to rummager Some people listed in Whitehall have not been indexed in rummager. This manifests in some finder screens as rows in the people drop down that have no description which displays as blank or empty. It also means that searching for one of the missing people at `/government...
diff --git a/lib/calligraphy/resource.rb b/lib/calligraphy/resource.rb index abc1234..def5678 100644 --- a/lib/calligraphy/resource.rb +++ b/lib/calligraphy/resource.rb @@ -1,6 +1,6 @@ module Calligraphy class Resource - attr_accessor :contents + attr_accessor :contents, :updated_at attr_reader :full_requ...
Add :updated_at attr_accessor to Resource
diff --git a/lib/raphl/true_random.rb b/lib/raphl/true_random.rb index abc1234..def5678 100644 --- a/lib/raphl/true_random.rb +++ b/lib/raphl/true_random.rb @@ -1,30 +1,30 @@ module Raphl module TrueRandom - class << self - # Pick a random element from collection using Random.org true random number generator...
Use "module_function" instead of "class << self"
diff --git a/lib/smart_answer/calculators/arrested_abroad.rb b/lib/smart_answer/calculators/arrested_abroad.rb index abc1234..def5678 100644 --- a/lib/smart_answer/calculators/arrested_abroad.rb +++ b/lib/smart_answer/calculators/arrested_abroad.rb @@ -3,12 +3,10 @@ # created for the help-if-you-are-arrested-abroad...
Refactor prisioner packs to be class constant This removes the overhead of re-loading the prisioner packs YAML file for every request and simplifies the class intialisation structure.
diff --git a/week-4/smallest-integer/my_solution.rb b/week-4/smallest-integer/my_solution.rb index abc1234..def5678 100644 --- a/week-4/smallest-integer/my_solution.rb +++ b/week-4/smallest-integer/my_solution.rb @@ -13,5 +13,10 @@ # Your Solution Below def smallest_integer(list_of_nums) + list_of_nums.sort! + sma...
Complete challenge 1, smallest interger
diff --git a/jekyll-archives.gemspec b/jekyll-archives.gemspec index abc1234..def5678 100644 --- a/jekyll-archives.gemspec +++ b/jekyll-archives.gemspec @@ -13,7 +13,7 @@ s.licenses = ["MIT"] s.files = ["lib/jekyll-archives.rb", "lib/jekyll-archives/archive.rb"] - s.add_dependency "jekyll", '~> 2.0' + ...
Change jekyll dependency to be ~> 2.4 * 8bbfaf60831369698b141da72fb8d71a0a7b0c43 used `Utils.slugify` which has been added in 2.4
diff --git a/messagebird-rest.gemspec b/messagebird-rest.gemspec index abc1234..def5678 100644 --- a/messagebird-rest.gemspec +++ b/messagebird-rest.gemspec @@ -18,4 +18,6 @@ s.files = Dir.glob("lib/**/*") + %w(LICENSE README.md) s.require_path = 'lib' + + s.add_development_dependency 'rspec', '~> 3.8' ...
Add rspec as a development dependency
diff --git a/lib/dry/system/constants.rb b/lib/dry/system/constants.rb index abc1234..def5678 100644 --- a/lib/dry/system/constants.rb +++ b/lib/dry/system/constants.rb @@ -16,11 +16,11 @@ InvalidSettingsError = Class.new(ArgumentError) do # @api private def initialize(attributes) - message = <...
Use STR in multi-line string
diff --git a/app/models/developer.rb b/app/models/developer.rb index abc1234..def5678 100644 --- a/app/models/developer.rb +++ b/app/models/developer.rb @@ -1,23 +1,51 @@ class Developer < ActiveRecord::Base devise :database_authenticatable, :trackable, :validatable, :omniauthable store_accessor :data, :bio, :htm...
Remove scope code as we are using Graphql
diff --git a/lib/facter/boxen_facts_d.rb b/lib/facter/boxen_facts_d.rb index abc1234..def5678 100644 --- a/lib/facter/boxen_facts_d.rb +++ b/lib/facter/boxen_facts_d.rb @@ -9,6 +9,24 @@ class BoxenFactsDirectoryLoader < Facter::Util::DirectoryLoader EXTERNAL_FACT_WEIGHT = Facter::Util::DirectoryLoader::EXTERNAL_FA...
Fix custom external fact loader's weights Because facter doesn't expose the weight as a customizable value, we need to override the constant. You can't do that in a subclass: ```ruby class A FOO="A" def foo; FOO; end end class B < A FOO="B" end A.new.foo # => "A" B.new.foo # => "A" class A def foo; self.cl...
diff --git a/lib/acclimate/cli_helper.rb b/lib/acclimate/cli_helper.rb index abc1234..def5678 100644 --- a/lib/acclimate/cli_helper.rb +++ b/lib/acclimate/cli_helper.rb @@ -3,6 +3,8 @@ def self.included( base ) base.class_eval do + include Acclimate::Output + no_commands do def...
Add output helper to CLIHelper.
diff --git a/Casks/sweet-home-3d.rb b/Casks/sweet-home-3d.rb index abc1234..def5678 100644 --- a/Casks/sweet-home-3d.rb +++ b/Casks/sweet-home-3d.rb @@ -0,0 +1,7 @@+class SweetHome3d < Cask + url 'http://downloads.sourceforge.net/project/sweethome3d/SweetHome3D/SweetHome3D-4.0/SweetHome3D-4.0-macosx.dmg' + homepage '...
Add Sweet Home 3D (Version 4.0) Cask
diff --git a/app_generators/merb/merb_generator.rb b/app_generators/merb/merb_generator.rb index abc1234..def5678 100644 --- a/app_generators/merb/merb_generator.rb +++ b/app_generators/merb/merb_generator.rb @@ -2,21 +2,21 @@ require "merb-gen/base" class MerbGenerator < Merb::GeneratorBase - + def initialize(...
Create gems directory in new applications.
diff --git a/app/models/spree/payment_decorator.rb b/app/models/spree/payment_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/payment_decorator.rb +++ b/app/models/spree/payment_decorator.rb @@ -1,7 +1,7 @@ module Spree Payment.class_eval do - state_machine :initial => 'checkout' do - after...
Use symbols for payment decorator states By re-defining the state machine like this, the state_machine gem will complain because 'checkout' != :checkout and 'completed' != :completed
diff --git a/app/models/spree/product_decorator.rb b/app/models/spree/product_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/product_decorator.rb +++ b/app/models/spree/product_decorator.rb @@ -1,6 +1,6 @@ Spree::Product.class_eval do has_many :digitals, :through => :variants_including_master - s...
Sort digital by updated_at desc
diff --git a/app/models/spree/variant_decorator.rb b/app/models/spree/variant_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/variant_decorator.rb +++ b/app/models/spree/variant_decorator.rb @@ -10,7 +10,7 @@ { :id => self.id, :count => self.count_on_hand, - :price => numb...
Use display price for variant hash data
diff --git a/app/resources/api/v1/crop_resource.rb b/app/resources/api/v1/crop_resource.rb index abc1234..def5678 100644 --- a/app/resources/api/v1/crop_resource.rb +++ b/app/resources/api/v1/crop_resource.rb @@ -8,6 +8,9 @@ has_many :plantings has_many :seeds has_many :harvests + + has_many :p...
Add photos back into crop resources
diff --git a/lib/kosmos/packages/void.rb b/lib/kosmos/packages/void.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/void.rb +++ b/lib/kosmos/packages/void.rb @@ -0,0 +1,9 @@+class VesselOrbitalInformationalDisplay < Kosmos::Package + title 'VOID - Vessel Orbital Informational Display' + aliases 'void' + u...
Add a package for VOID.
diff --git a/lib/minder/task_recorder.rb b/lib/minder/task_recorder.rb index abc1234..def5678 100644 --- a/lib/minder/task_recorder.rb +++ b/lib/minder/task_recorder.rb @@ -45,12 +45,13 @@ end def delete_task - lines = File.read(DOING_FILE).split("\n") - lines.delete_at(selected_task_index) + li...
Fix issues w/ tasks after deleting - Adding a task would append to last task - Cursor would end up on line without task
diff --git a/db/migrate/20130712163509_add_missing_id_columns.rb b/db/migrate/20130712163509_add_missing_id_columns.rb index abc1234..def5678 100644 --- a/db/migrate/20130712163509_add_missing_id_columns.rb +++ b/db/migrate/20130712163509_add_missing_id_columns.rb @@ -0,0 +1,11 @@+class AddMissingIdColumns < ActiveReco...
Add primary key `id` to `category_featured_topics` and `topic_users`
diff --git a/db/migrate/20170523095536_add_last_name_to_users.rb b/db/migrate/20170523095536_add_last_name_to_users.rb index abc1234..def5678 100644 --- a/db/migrate/20170523095536_add_last_name_to_users.rb +++ b/db/migrate/20170523095536_add_last_name_to_users.rb @@ -0,0 +1,12 @@+require 'carto/db/migration_helper' + ...
Migration: Add last name to users
diff --git a/lib/scais/topology/files.rb b/lib/scais/topology/files.rb index abc1234..def5678 100644 --- a/lib/scais/topology/files.rb +++ b/lib/scais/topology/files.rb @@ -25,7 +25,7 @@ end #add constant - self.constants<< Constant.new(output, "#{options[:time]},#{options[:value]}") +...
Fix constant type error on setting_for
diff --git a/lib/schneiderlein/engine.rb b/lib/schneiderlein/engine.rb index abc1234..def5678 100644 --- a/lib/schneiderlein/engine.rb +++ b/lib/schneiderlein/engine.rb @@ -3,8 +3,15 @@ isolate_namespace Schneiderlein initializer 'schneiderlein.middleware' do |app| - app.config.middleware.insert_before ...
Use a different fixpoint to insert Schneiderlein ActionDispatch::Request is gone in Rails 5. By default, ActionDispatch::Request was inserted after ActionDispatch::Callbacks so this is where we put ourselves.
diff --git a/bulk_api_transferrer.rb b/bulk_api_transferrer.rb index abc1234..def5678 100644 --- a/bulk_api_transferrer.rb +++ b/bulk_api_transferrer.rb @@ -3,6 +3,7 @@ require "active_support" require "active_support/core_ext/array" require "active_support/core_ext/hash" +require "active_support/core_ext/date" cl...
Replace our methods with activesupport's
diff --git a/lib/devise_invitable.rb b/lib/devise_invitable.rb index abc1234..def5678 100644 --- a/lib/devise_invitable.rb +++ b/lib/devise_invitable.rb @@ -4,7 +4,7 @@ @@invite_for = 0 end Devise::ALL << :invitable -Devise::CONTROLLERS = Devise::CONTROLLERS.merge(:invitations => [:invitable]) +Devise::CONTROLLERS[...
Update for devise 0.7.1, controllers is not frozen yet
diff --git a/lib/git_service/repo.rb b/lib/git_service/repo.rb index abc1234..def5678 100644 --- a/lib/git_service/repo.rb +++ b/lib/git_service/repo.rb @@ -12,9 +12,11 @@ require 'rugged' rugged_repo.remotes.each do |remote| fetch_options = {} + username = uri_for_remote(remote.url).u...
[GitService::Repo] Update .git_fetch to 'find' creds Uses GitService::Credentials.find_for_user_and_host when looking up credentials, and uses .uri_for_remote to also find hostname for a given remote url.
diff --git a/lib/ice_nine/version.rb b/lib/ice_nine/version.rb index abc1234..def5678 100644 --- a/lib/ice_nine/version.rb +++ b/lib/ice_nine/version.rb @@ -3,6 +3,6 @@ module IceNine # Unreleased gem version - VERSION = '0.8.0' + VERSION = '0.8.0'.freeze end # module IceNine
Change the IceNine::VERSION to be frozen
diff --git a/lib/options/registry.rb b/lib/options/registry.rb index abc1234..def5678 100644 --- a/lib/options/registry.rb +++ b/lib/options/registry.rb @@ -9,7 +9,7 @@ def register(item_name, item) if registered?(item_name) - raise ArgumentError, "#{name} already registered: #{item_name}" + ...
Use `fail` instead of `raise` for new errors Though `fail` and `raise` do exactly the same thing, the style guide[1] suggests that `raise` be used only to re-raise existing errors in a `rescue` block and to use `fail` to raise new errors. [1] https://github.com/bbatsov/ruby-style-guide
diff --git a/lib/tasks/database.rake b/lib/tasks/database.rake index abc1234..def5678 100644 --- a/lib/tasks/database.rake +++ b/lib/tasks/database.rake @@ -1,4 +1,5 @@ require 'active_record' +require 'cloud_cost_tracker' namespace :db do namespace :migrate do
Fix missing requirement in exported tasks
diff --git a/app/controllers/tokite/repositories_controller.rb b/app/controllers/tokite/repositories_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tokite/repositories_controller.rb +++ b/app/controllers/tokite/repositories_controller.rb @@ -7,9 +7,10 @@ end def new - github_repos = o...
Fix codes to follow the cookpad coding rule
diff --git a/lib/fog/brightbox/requests/compute/update_server.rb b/lib/fog/brightbox/requests/compute/update_server.rb index abc1234..def5678 100644 --- a/lib/fog/brightbox/requests/compute/update_server.rb +++ b/lib/fog/brightbox/requests/compute/update_server.rb @@ -9,7 +9,7 @@ # @option options [String] :nam...
[Brightbox] Fix typo in yard tag
diff --git a/spec/acceptance/admin_spec.rb b/spec/acceptance/admin_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/admin_spec.rb +++ b/spec/acceptance/admin_spec.rb @@ -7,6 +7,7 @@ } do background do + drop_data_stores @user = FactoryGirl.create(:user) end
Drop all datastores, in the hope to pass the build on travis
diff --git a/spec/factories/collections.rb b/spec/factories/collections.rb index abc1234..def5678 100644 --- a/spec/factories/collections.rb +++ b/spec/factories/collections.rb @@ -6,5 +6,10 @@ managers {[FactoryGirl.create(:manager).username]} editors {[FactoryGirl.create(:user).username]} depositors {[F...
Add item(s) creation to collection factory
diff --git a/spec/i18n/locale_name_spec.rb b/spec/i18n/locale_name_spec.rb index abc1234..def5678 100644 --- a/spec/i18n/locale_name_spec.rb +++ b/spec/i18n/locale_name_spec.rb @@ -8,4 +8,11 @@ FastGettext.locale = 'en' # set the locale for runnin specs back to English end + + it "all entries in human_locale_...
Test that all human locale names are valid
diff --git a/spec/motion/encodable_spec.rb b/spec/motion/encodable_spec.rb index abc1234..def5678 100644 --- a/spec/motion/encodable_spec.rb +++ b/spec/motion/encodable_spec.rb @@ -13,17 +13,17 @@ } end - describe 'NSCoderプロトコル準拠' do + describe 'NSCoder protocol' do before do @entry = Entry.new(@...
Use English in specs description
diff --git a/spec/support/admin_helpers.rb b/spec/support/admin_helpers.rb index abc1234..def5678 100644 --- a/spec/support/admin_helpers.rb +++ b/spec/support/admin_helpers.rb @@ -0,0 +1,10 @@+module AdminHelpers + def follow_invite_request_link(admin_user) + open_email admin_user.email, with_subject: /would like...
Add helper to simulate admin following the link in an invitation request email