diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/namespaces_controller.rb b/app/controllers/namespaces_controller.rb index abc1234..def5678 100644 --- a/app/controllers/namespaces_controller.rb +++ b/app/controllers/namespaces_controller.rb @@ -14,7 +14,7 @@ if user redirect_to user_path(user) - elsif group && can?(current...
Allow access to group from root url
diff --git a/spec/support/discovery_link_behaviour.rb b/spec/support/discovery_link_behaviour.rb index abc1234..def5678 100644 --- a/spec/support/discovery_link_behaviour.rb +++ b/spec/support/discovery_link_behaviour.rb @@ -5,7 +5,7 @@ :headers => { 'Content-Type' => 'application/json' }, - ...
Fix spec (wrap meta post response)
diff --git a/lib/ice_nine/support/recursion_guard.rb b/lib/ice_nine/support/recursion_guard.rb index abc1234..def5678 100644 --- a/lib/ice_nine/support/recursion_guard.rb +++ b/lib/ice_nine/support/recursion_guard.rb @@ -17,10 +17,10 @@ # Guard against recursively calling a block with the same object # # ...
Fix formatting in YARD docs
diff --git a/app/models/shoppe/customization_value.rb b/app/models/shoppe/customization_value.rb index abc1234..def5678 100644 --- a/app/models/shoppe/customization_value.rb +++ b/app/models/shoppe/customization_value.rb @@ -2,7 +2,8 @@ class CustomizationValue < ActiveRecord::Base self.table_name = 'shoppe_cust...
Add new stlye for content type validation
diff --git a/test/test_binds.rb b/test/test_binds.rb index abc1234..def5678 100644 --- a/test/test_binds.rb +++ b/test/test_binds.rb @@ -0,0 +1,71 @@+require 'helper' + +class TestQuery < Test::Unit::TestCase + attr_accessor :dbh + + def setup + self.dbh = new_database + end + + def teardown + @dbh.disconnect...
Test parameter binds: named, unnamed, good and bad
diff --git a/test/test_query.rb b/test/test_query.rb index abc1234..def5678 100644 --- a/test/test_query.rb +++ b/test/test_query.rb @@ -2,6 +2,11 @@ # Test query DSL class QueryTest < Minitest::Test + + def setup + Bicho.client = nil + end + def test_active_record_style # No client set yet assert_...
Reset Bicho.client as it makes it test order dependent
diff --git a/gtm-oauth2-thekey.podspec b/gtm-oauth2-thekey.podspec index abc1234..def5678 100644 --- a/gtm-oauth2-thekey.podspec +++ b/gtm-oauth2-thekey.podspec @@ -1,11 +1,11 @@ Pod::Spec.new do |s| s.name = "gtm-oauth2-thekey" - s.version = "1.0.120" + s.version = "1.0.123" s.summary = ...
Increment version to 1.0.123, based on SVN r123
diff --git a/Casks/firefoxdeveloperedition-ja.rb b/Casks/firefoxdeveloperedition-ja.rb index abc1234..def5678 100644 --- a/Casks/firefoxdeveloperedition-ja.rb +++ b/Casks/firefoxdeveloperedition-ja.rb @@ -5,6 +5,7 @@ url "https://download.mozilla.org/?product=firefox-aurora-latest-l10n&os=osx&lang=ja-JP-mac" homep...
Add tag stanza to Firefox Developer Edition JA
diff --git a/db/migrate/2_add_name_to_subscriptions.rb b/db/migrate/2_add_name_to_subscriptions.rb index abc1234..def5678 100644 --- a/db/migrate/2_add_name_to_subscriptions.rb +++ b/db/migrate/2_add_name_to_subscriptions.rb @@ -0,0 +1,8 @@+class AddNameToSubscriptions < ActiveRecord::Migration + + def change + add...
Add migration for first and last name
diff --git a/Casks/freesmug-chromium.rb b/Casks/freesmug-chromium.rb index abc1234..def5678 100644 --- a/Casks/freesmug-chromium.rb +++ b/Casks/freesmug-chromium.rb @@ -1,6 +1,6 @@ cask :v1 => 'freesmug-chromium' do - version '40.0.2214.94' - sha256 '404d93a048f86d500320c7d2a11b58bf8391aca190278036688c095fd8d183b2' +...
Update FreeSMUG Chromium to v40.0.2214.115
diff --git a/config/software/ganeti-common-haskell.rb b/config/software/ganeti-common-haskell.rb index abc1234..def5678 100644 --- a/config/software/ganeti-common-haskell.rb +++ b/config/software/ganeti-common-haskell.rb @@ -1,15 +1,17 @@ name "ganeti-common-haskell" -dependency 'ghc-crypto' -dependency 'ghc-base64-b...
Switch to installing all the haskell deps in one shot instead individually
diff --git a/app/controllers/browse_controller.rb b/app/controllers/browse_controller.rb index abc1234..def5678 100644 --- a/app/controllers/browse_controller.rb +++ b/app/controllers/browse_controller.rb @@ -1,7 +1,7 @@ class BrowseController < ApplicationController def index - setup_page_title("Browse") + ...
Change 'browse' to 'All categories' as it is more meaningful to users even if they for some reason end up on /browse where they shouldn't really be
diff --git a/spec/connectors/swiftiply_client_spec.rb b/spec/connectors/swiftiply_client_spec.rb index abc1234..def5678 100644 --- a/spec/connectors/swiftiply_client_spec.rb +++ b/spec/connectors/swiftiply_client_spec.rb @@ -0,0 +1,66 @@+require File.dirname(__FILE__) + '/../spec_helper' + +describe Connectors::Swiftip...
Add spec for swiftiply connector.
diff --git a/potatochop.gemspec b/potatochop.gemspec index abc1234..def5678 100644 --- a/potatochop.gemspec +++ b/potatochop.gemspec @@ -18,6 +18,7 @@ gem.require_paths = ["lib"] gem.add_runtime_dependency 'sinatra' gem.add_runtime_dependency 'haml' + gem.add_runtime_dependency 'sass' gem.add_development_de...
Add sass as a dependency
diff --git a/app/controllers/errors_controller.rb b/app/controllers/errors_controller.rb index abc1234..def5678 100644 --- a/app/controllers/errors_controller.rb +++ b/app/controllers/errors_controller.rb @@ -1,9 +1,9 @@ class ErrorsController < ApplicationController def not_found - render :json => { status: "Err...
Return appropriate status code on error
diff --git a/spec/features/user_edits_article_spec.rb b/spec/features/user_edits_article_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_edits_article_spec.rb +++ b/spec/features/user_edits_article_spec.rb @@ -0,0 +1,14 @@+require 'spec_helper' + +feature "Article Editing" do + before(:each) do + sig...
Add spec for editing article
diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index abc1234..def5678 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -13,7 +13,7 @@ @total_results = @google_request["queries"]["request"][0]["totalResults"].to_i ...
Change config data for google custom search for production.
diff --git a/app/controllers/explore_controller.rb b/app/controllers/explore_controller.rb index abc1234..def5678 100644 --- a/app/controllers/explore_controller.rb +++ b/app/controllers/explore_controller.rb @@ -4,9 +4,9 @@ layout 'explore' def index - render_404 and return if current_user.nil? || !current_u...
Use viewed user instead of current user to disable explore access
diff --git a/app/controllers/uploads_controller.rb b/app/controllers/uploads_controller.rb index abc1234..def5678 100644 --- a/app/controllers/uploads_controller.rb +++ b/app/controllers/uploads_controller.rb @@ -1,7 +1,7 @@ class UploadsController < ApplicationController def remove puts params - upload = co...
Create single controller for all uploads.
diff --git a/app/models/spree/payment_decorator.rb b/app/models/spree/payment_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/payment_decorator.rb +++ b/app/models/spree/payment_decorator.rb @@ -1,7 +1,9 @@ module Spree module PaymentDecorator def handle_response(response, success_state, failu...
Verify the response from the payment provider responds to params
diff --git a/tincan-api.gemspec b/tincan-api.gemspec index abc1234..def5678 100644 --- a/tincan-api.gemspec +++ b/tincan-api.gemspec @@ -1,7 +1,7 @@ Gem::Specification.new do |s| s.name = "tincan-api" - s.version = "1.2.1" - s.date = "2014-05-08" + s.version = "1.2.2" + ...
Update Gem version to be 1.2.2
diff --git a/lib/phil_columns/command/generate/seed.rb b/lib/phil_columns/command/generate/seed.rb index abc1234..def5678 100644 --- a/lib/phil_columns/command/generate/seed.rb +++ b/lib/phil_columns/command/generate/seed.rb @@ -16,7 +16,7 @@ protected def template_filepath - 'templates/seed_c...
Fix issue with template path in generator.
diff --git a/lib/rspec/matchers/built_in/be_between.rb b/lib/rspec/matchers/built_in/be_between.rb index abc1234..def5678 100644 --- a/lib/rspec/matchers/built_in/be_between.rb +++ b/lib/rspec/matchers/built_in/be_between.rb @@ -19,7 +19,7 @@ def matches?(actual) @actual = actual - compara...
Use && instead of and
diff --git a/spec/models/food_spec.rb b/spec/models/food_spec.rb index abc1234..def5678 100644 --- a/spec/models/food_spec.rb +++ b/spec/models/food_spec.rb @@ -12,6 +12,19 @@ end describe "#display" do + it "creates a concatenated title for food" do + food = create(:food) + + expect(food.display).t...
Add missing tests for food model
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -2,35 +2,58 @@ describe User do - let(:user) { FactoryGirl.create(:user) } + describe '#valid?' do + subject { FactoryGirl.build(:user, params) } - ...
Refactor User specs for readability
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -10,15 +10,16 @@ User.update_or_create(auth) new_user = User.first - expect(new_user.provider).to eq("google") expect(new_user.uid).t...
Add associations tests for models to have many comments and pins
diff --git a/spec/github_cli/commands/statuses_spec.rb b/spec/github_cli/commands/statuses_spec.rb index abc1234..def5678 100644 --- a/spec/github_cli/commands/statuses_spec.rb +++ b/spec/github_cli/commands/statuses_spec.rb @@ -0,0 +1,28 @@+# encoding: utf-8 + +require 'spec_helper' + +describe GithubCLI::Commands::St...
Add test specs for statuses commands.
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -6,8 +6,9 @@ describe "#valid?" do describe "password" do it "password != password_confirmation is invalid" do - user.password = "a" - ...
Fix the broken model spec Before, validated user is invalid, but other validations cause (length, and wrong current_password)
diff --git a/spec/semmy/tasks_spec.rb b/spec/semmy/tasks_spec.rb index abc1234..def5678 100644 --- a/spec/semmy/tasks_spec.rb +++ b/spec/semmy/tasks_spec.rb @@ -0,0 +1,76 @@+require 'spec_helper' + +module Semmy + describe Tasks, fixture_files: true do + describe 'release:prepare task' do + it 'passes on maste...
Add smoke test for main rake tasks
diff --git a/config/initializers/constants.rb b/config/initializers/constants.rb index abc1234..def5678 100644 --- a/config/initializers/constants.rb +++ b/config/initializers/constants.rb @@ -1,4 +1,4 @@-DOC_URL = "https://demarches-simplifiees.gitbook.io/demarches-simplifiees/" +DOC_URL = "https://demarches-simplifie...
Remove trailing slash from DOC_URL
diff --git a/test/emails/send_daily_triage_email_test.rb b/test/emails/send_daily_triage_email_test.rb index abc1234..def5678 100644 --- a/test/emails/send_daily_triage_email_test.rb +++ b/test/emails/send_daily_triage_email_test.rb @@ -2,14 +2,22 @@ class UserMailerTest < ActionMailer::TestCase include ActiveJob:...
Make email test not time dependent
diff --git a/test/fixtures/rails_app/app/models/asset.rb b/test/fixtures/rails_app/app/models/asset.rb index abc1234..def5678 100644 --- a/test/fixtures/rails_app/app/models/asset.rb +++ b/test/fixtures/rails_app/app/models/asset.rb @@ -13,19 +13,27 @@ # Dragonfly Stuff # - image_accessor :dragonfly + if defin...
Use methods only if modules are defined.
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -0,0 +1,8 @@+#http://www.cocktails.eu/alphabetical/index.php?letter=a + +#find sibling of .list_head elements + +#https://blog.hartleybrody.com/web-scraping/ + +#iterate over letter=a&i=2 +#a=17, b=37, c=35, d=13...
Add research for scraping cocktail recipes
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -0,0 +1,188 @@+require 'spec_helper' + +describe User do + before(:each) do + @user = Fabricate(:user) + end + + describe "module/plugin inclusions (optio...
Add file for user specs Signed-off-by: Jorge H. Cuadrado <f24d0cb14d293fb1f3cb2016ae41425d3291832c@gmail.com>
diff --git a/spec/unit/config_spec.rb b/spec/unit/config_spec.rb index abc1234..def5678 100644 --- a/spec/unit/config_spec.rb +++ b/spec/unit/config_spec.rb @@ -16,11 +16,14 @@ describe '#hash' do it { should respond_to( :hash ) } - it 'should add a new hash' do - Eastwood.hash :foo, '#/bar' + descr...
Use more specific matcher for hashes
diff --git a/spec/unit/spec_helper.rb b/spec/unit/spec_helper.rb index abc1234..def5678 100644 --- a/spec/unit/spec_helper.rb +++ b/spec/unit/spec_helper.rb @@ -7,7 +7,7 @@ config.version = '10.11.1' # via https://github.com/customink/fauxhai/tree/master/lib/fauxhai/platforms/mac_os_x config.before do stub_co...
Add comment to command stub
diff --git a/db/migrate/20160615191922_set_missing_stage_on_ci_builds.rb b/db/migrate/20160615191922_set_missing_stage_on_ci_builds.rb index abc1234..def5678 100644 --- a/db/migrate/20160615191922_set_missing_stage_on_ci_builds.rb +++ b/db/migrate/20160615191922_set_missing_stage_on_ci_builds.rb @@ -0,0 +1,9 @@+class S...
Set missing stages on ci builds to 'test' to avoid regressions in the pipelines view
diff --git a/gtk3/sample/misc/cairo-cursor.rb b/gtk3/sample/misc/cairo-cursor.rb index abc1234..def5678 100644 --- a/gtk3/sample/misc/cairo-cursor.rb +++ b/gtk3/sample/misc/cairo-cursor.rb @@ -0,0 +1,37 @@+=begin + cairo_cursor.rb Ruby/GTK3 script + Adapted from https://developer.gnome.org/gtk3/stable/ch25s02.html#id...
Add example of a Gdk::Cursor based on Cairo
diff --git a/spec/prime_spec.rb b/spec/prime_spec.rb index abc1234..def5678 100644 --- a/spec/prime_spec.rb +++ b/spec/prime_spec.rb @@ -1,6 +1,20 @@ require_relative '../lib/prime.rb' describe Prime do - it 'checks if a number is prime' - it 'generates any number of primes' + it 'checks if a number is prime' do ...
Write tests for validating Prime behavior
diff --git a/Casks/pharo.rb b/Casks/pharo.rb index abc1234..def5678 100644 --- a/Casks/pharo.rb +++ b/Casks/pharo.rb @@ -1,6 +1,6 @@ class Pharo < Cask version '3.0' - sha256 'f811c7ab77240c680ac74f0d50390101cd61007f027045a9c68322f7dadc6c38' + sha256 '2aae5efd2d6e93df29ca5e04f2ad95c22494ff3d0e27c50276c25c298c0a58b...
Fix checksum in Pharo.app Cask
diff --git a/lib/conceptql/database.rb b/lib/conceptql/database.rb index abc1234..def5678 100644 --- a/lib/conceptql/database.rb +++ b/lib/conceptql/database.rb @@ -10,7 +10,6 @@ if db db.extension :date_arithmetic db.extension :error_sql - db.quote_identifiers = true db_type = d...
Remove hack now that sequel-impala is fixed
diff --git a/faraday_middleware-oauth2_refresh.gemspec b/faraday_middleware-oauth2_refresh.gemspec index abc1234..def5678 100644 --- a/faraday_middleware-oauth2_refresh.gemspec +++ b/faraday_middleware-oauth2_refresh.gemspec @@ -6,7 +6,7 @@ s.description = 'This Faraday middleware gem adds OAuth2 token handling with ...
Update homepage for RubyGems GitHub link
diff --git a/lib/akamai_api/cp_code.rb b/lib/akamai_api/cp_code.rb index abc1234..def5678 100644 --- a/lib/akamai_api/cp_code.rb +++ b/lib/akamai_api/cp_code.rb @@ -13,22 +13,16 @@ end def self.all - response, result = [], [] - basic_auth *AkamaiApi.config[:auth] response = client.request(...
Use Array.wrap instead of use alternative variables
diff --git a/vim-flavor.gemspec b/vim-flavor.gemspec index abc1234..def5678 100644 --- a/vim-flavor.gemspec +++ b/vim-flavor.gemspec @@ -4,8 +4,8 @@ Gem::Specification.new do |gem| gem.authors = ['Kana Natsuno'] gem.email = ['dev@whileimautomaton.net'] - gem.description = %q{See the README file.}...
Fix the useless description in the gemspec
diff --git a/lib/guessr.rb b/lib/guessr.rb index abc1234..def5678 100644 --- a/lib/guessr.rb +++ b/lib/guessr.rb @@ -13,8 +13,17 @@ class Hangman < Base validates :answer, presence: true, - format: { with: /^[a-z]+$/, message: "only lowercase words allowed"}, + format: { with: /^[a-z]+$/, mes...
Add finished? and guess_letter methods on Hangman.
diff --git a/pwwka.gemspec b/pwwka.gemspec index abc1234..def5678 100644 --- a/pwwka.gemspec +++ b/pwwka.gemspec @@ -8,7 +8,7 @@ s.platform = Gem::Platform::RUBY s.authors = ['Stitch Fix Engineering'] s.email = ['opensource@stitchfix.com'] - s.homepage = "http://www.stitchfix.com" + s.homepage...
Make homepage GitHub repo, so gem information is easily accessible
diff --git a/aggregate_root/spec/no_warnings_spec.rb b/aggregate_root/spec/no_warnings_spec.rb index abc1234..def5678 100644 --- a/aggregate_root/spec/no_warnings_spec.rb +++ b/aggregate_root/spec/no_warnings_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -module RubyEventStore +module AggregateRoot RSpec.describe ...
Rename enclosing module to match gem.
diff --git a/lib/erudite/executable.rb b/lib/erudite/executable.rb index abc1234..def5678 100644 --- a/lib/erudite/executable.rb +++ b/lib/erudite/executable.rb @@ -24,7 +24,7 @@ end def self.format_failing_example(example) - <<-"TXT" + <<-"TEXT" - FAIL Source: #{example.source} Expected: @@...
Use the same heredoc delimiters everywhere
diff --git a/govuk-content-schema-test-helpers.gemspec b/govuk-content-schema-test-helpers.gemspec index abc1234..def5678 100644 --- a/govuk-content-schema-test-helpers.gemspec +++ b/govuk-content-schema-test-helpers.gemspec @@ -21,4 +21,5 @@ s.add_development_dependency 'gem_publisher', '1.5.0' s.add_development_...
Add pry-byebug as development dependency Use it for debugging.
diff --git a/lib/chefspec/berkshelf.rb b/lib/chefspec/berkshelf.rb index abc1234..def5678 100644 --- a/lib/chefspec/berkshelf.rb +++ b/lib/chefspec/berkshelf.rb @@ -7,38 +7,48 @@ " to your Gemfile:\n\n gem 'berkshelf'\n\n" end -require 'fileutils' - module ChefSpec class Berkshelf class << self ...
Use RSpec's `before(:suite)` and `after(:suite)` for Berkshelf
diff --git a/lib/time_for_a_boolean.rb b/lib/time_for_a_boolean.rb index abc1234..def5678 100644 --- a/lib/time_for_a_boolean.rb +++ b/lib/time_for_a_boolean.rb @@ -1,5 +1,6 @@ require "active_support/core_ext/module/delegation" -require "active_record/connection_adapters/column" +require "active_support/core_ext/time/...
Switch to using Rails 5 false values instead of true First, rails removed TRUE_VALUES, leaving FALSE_VALUES: https://github.com/rails/rails/commit/a502703c3d2151d4d3b421b29fefdac5ad05df61 Then, the file containing FALSE_VALUES was moved to ActiveModel: https://github.com/rails/rails/commit/9cc8c6f3730df3d94c81a55be9e...
diff --git a/lib/kontrast/page_test.rb b/lib/kontrast/page_test.rb index abc1234..def5678 100644 --- a/lib/kontrast/page_test.rb +++ b/lib/kontrast/page_test.rb @@ -18,6 +18,12 @@ original_query = Rack::Utils.parse_query(uri.query) new_query = url_params.merge(original_query) uri.q...
Remove trailing "?" from path
diff --git a/publify_core/spec/models/resource_spec.rb b/publify_core/spec/models/resource_spec.rb index abc1234..def5678 100644 --- a/publify_core/spec/models/resource_spec.rb +++ b/publify_core/spec/models/resource_spec.rb @@ -1,4 +1,31 @@ require 'rails_helper' describe Resource, type: :model do + describe '#upl...
Add tests for Resource upload behavior
diff --git a/app/controllers/dashboard_controller.rb b/app/controllers/dashboard_controller.rb index abc1234..def5678 100644 --- a/app/controllers/dashboard_controller.rb +++ b/app/controllers/dashboard_controller.rb @@ -2,6 +2,6 @@ before_filter :authenticate_user! def show - + session[:CTF_FLAG] = "21...
Add a flag in triage.
diff --git a/app/controllers/questions_controller.rb b/app/controllers/questions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/questions_controller.rb +++ b/app/controllers/questions_controller.rb @@ -41,6 +41,19 @@ end end + def upvote + @question = Question.find(params[:id]) + @use...
Add upvote action to questions controller
diff --git a/app/controllers/summoners_controller.rb b/app/controllers/summoners_controller.rb index abc1234..def5678 100644 --- a/app/controllers/summoners_controller.rb +++ b/app/controllers/summoners_controller.rb @@ -8,8 +8,7 @@ def show #matches = @summoner.matches.paginate(page: params[:page], per_page: 10...
Add more filter params (still hidden)
diff --git a/lib/pdfshaver/page_set.rb b/lib/pdfshaver/page_set.rb index abc1234..def5678 100644 --- a/lib/pdfshaver/page_set.rb +++ b/lib/pdfshaver/page_set.rb @@ -16,6 +16,14 @@ Page.new(@document, page_index+1) end + def first + Page.new(@document, 1) + end + + def last + Page...
Add and first and last to page sets
diff --git a/lib/plaintweet/web_app.rb b/lib/plaintweet/web_app.rb index abc1234..def5678 100644 --- a/lib/plaintweet/web_app.rb +++ b/lib/plaintweet/web_app.rb @@ -5,7 +5,7 @@ require 'uri' require 'active_support' require 'plaintweet/repository' -require 'english' +require 'English' module Plaintweet class We...
Fix case for English lib
diff --git a/lib/rails_admin/engine.rb b/lib/rails_admin/engine.rb index abc1234..def5678 100644 --- a/lib/rails_admin/engine.rb +++ b/lib/rails_admin/engine.rb @@ -5,7 +5,7 @@ class Engine < Rails::Engine initializer "static assets" do |app| if app.config.serve_static_assets - app.middleware.inser...
Make rails admin static assets override everything apart from static assets in the main application.
diff --git a/lib/file_data/formats/mpeg4/box_stream.rb b/lib/file_data/formats/mpeg4/box_stream.rb index abc1234..def5678 100644 --- a/lib/file_data/formats/mpeg4/box_stream.rb +++ b/lib/file_data/formats/mpeg4/box_stream.rb @@ -4,12 +4,17 @@ class BoxStream def initialize(stream) @stream = stream + ...
Remove some of the duplication in BoxStream and BoxSubStream by using inheritance
diff --git a/lib/rom/sql/repository.rb b/lib/rom/sql/repository.rb index abc1234..def5678 100644 --- a/lib/rom/sql/repository.rb +++ b/lib/rom/sql/repository.rb @@ -6,7 +6,7 @@ module ROM module SQL class Repository < ROM::Repository - attr_reader :logger + attr_reader :logger, :schema def se...
Store schema in an ivar
diff --git a/lib/leaflet-draw-rails.rb b/lib/leaflet-draw-rails.rb index abc1234..def5678 100644 --- a/lib/leaflet-draw-rails.rb +++ b/lib/leaflet-draw-rails.rb @@ -5,6 +5,10 @@ RSpec.configure do |spec| spec.include Leaflet::Draw::Rails::Testing end +end + +if respond_to? :World + World Leaflet::Draw::Rails...
Make the testing helpers visible in cucumber step definitions.
diff --git a/lib/ssbe_authenticator.rb b/lib/ssbe_authenticator.rb index abc1234..def5678 100644 --- a/lib/ssbe_authenticator.rb +++ b/lib/ssbe_authenticator.rb @@ -15,7 +15,7 @@ def update_credentials(challenge_response) @domain = Addressable::URI.parse(challenge_response.uri).host - @challenge = HTT...
Update for new resourceful header style
diff --git a/Nimble.podspec b/Nimble.podspec index abc1234..def5678 100644 --- a/Nimble.podspec +++ b/Nimble.podspec @@ -15,4 +15,5 @@ s.source_files = "Nimble", "Nimble/**/*.{swift,h,m}" s.framework = "XCTest" s.requires_arc = true + s.pod_target_xcconfig = { 'ENABLE_BITCODE' => 'NO' } end
Add ENABLE_BITCODE = NO in podspec. This was added to the Nimble.xcodeproj, but was forgotten in the xcodeproj. Fixes #170.
diff --git a/core/enumerator/lazy/fixtures/classes.rb b/core/enumerator/lazy/fixtures/classes.rb index abc1234..def5678 100644 --- a/core/enumerator/lazy/fixtures/classes.rb +++ b/core/enumerator/lazy/fixtures/classes.rb @@ -0,0 +1,50 @@+# -*- encoding: us-ascii -*- + +module EnumeratorLazySpecs + class SpecificError ...
Write spec fixtures for Enumerator::Lazy
diff --git a/app/models/email_signup_pages_finder.rb b/app/models/email_signup_pages_finder.rb index abc1234..def5678 100644 --- a/app/models/email_signup_pages_finder.rb +++ b/app/models/email_signup_pages_finder.rb @@ -9,19 +9,16 @@ def self.mhra_email_signup_pages [ OpenStruct.new( - text: "Safe...
Update copy for MHRA email alerts Make the copy for this page match the prototype.
diff --git a/lib/usesthis/interview.rb b/lib/usesthis/interview.rb index abc1234..def5678 100644 --- a/lib/usesthis/interview.rb +++ b/lib/usesthis/interview.rb @@ -14,10 +14,10 @@ begin contents = File.read(path) - parts = contents.match(/---\n(.*)\n---\n(.*)/m) + parts = contents.match(/^(-{3}\...
Use this frontmatter method totally borrowed from the Internets.
diff --git a/lib/wkhtmltopdf-heroku.rb b/lib/wkhtmltopdf-heroku.rb index abc1234..def5678 100644 --- a/lib/wkhtmltopdf-heroku.rb +++ b/lib/wkhtmltopdf-heroku.rb @@ -15,3 +15,12 @@ WickedPdf.config[:exe_path] = WKHTMLTOPDF_PATH rescue LoadError end + +begin + require 'wisepdf' + + Wisepdf::Configuration.configure ...
Add hook in for Wisepdf.
diff --git a/app/services/location_lookup_service.rb b/app/services/location_lookup_service.rb index abc1234..def5678 100644 --- a/app/services/location_lookup_service.rb +++ b/app/services/location_lookup_service.rb @@ -49,7 +49,7 @@ def response @response ||= begin - JSON.parse(GdsApi.mapi...
Use My Society's Mapit when running locally GOV.UK hosts it's own version of Mapit. Unfortunately, that is only accessibly via the production and test environments, not locally. Until we can access Mapit locally, add a work around to make it possibly to manually test changes.
diff --git a/lib/rbbt/util/tsv/misc.rb b/lib/rbbt/util/tsv/misc.rb index abc1234..def5678 100644 --- a/lib/rbbt/util/tsv/misc.rb +++ b/lib/rbbt/util/tsv/misc.rb @@ -29,3 +29,13 @@ counts end end + +module Open + def self.tsv(file, *args) + TSV.new file, *args + end + + def self.index(file, *args) + TSV...
Add 2 more methods to Open: tsv and index
diff --git a/lib/rdbi/driver/rubyfb.rb b/lib/rdbi/driver/rubyfb.rb index abc1234..def5678 100644 --- a/lib/rdbi/driver/rubyfb.rb +++ b/lib/rdbi/driver/rubyfb.rb @@ -1,6 +1,12 @@ require 'rdbi' require 'rubyfb' +## +# +# RDBI database driver for the robust and SQL-compliant Firebird RDBMS, an +# open-source member of...
Add preamble doc to RDBI::Driver::Rubyfb
diff --git a/rubio.gemspec b/rubio.gemspec index abc1234..def5678 100644 --- a/rubio.gemspec +++ b/rubio.gemspec @@ -18,6 +18,7 @@ gem.add_runtime_dependency('hashie') # Hash method access gem.add_runtime_dependency('httparty') # Used to tell Rdio to let us in gem.add_runtime_dependency('activesupport', '~> 3.2...
Update gemspec to reinclude OAuth, sweet jesus.
diff --git a/data-aggregation-accumulator.gemspec b/data-aggregation-accumulator.gemspec index abc1234..def5678 100644 --- a/data-aggregation-accumulator.gemspec +++ b/data-aggregation-accumulator.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'data_aggregation-accumulator'...
Package version is increased from 0.0.1.1 to 0.1.0.0
diff --git a/lib/render_menu_helper.rb b/lib/render_menu_helper.rb index abc1234..def5678 100644 --- a/lib/render_menu_helper.rb +++ b/lib/render_menu_helper.rb @@ -1,13 +1,15 @@ module ActionView class Base - def render_menu(dynamic_menu) + def render_menu(dynamic_menu, *args) raise 'No DynamicMenu o...
Add model instruction for render_menu method
diff --git a/slack-danbot/commands/info.rb b/slack-danbot/commands/info.rb index abc1234..def5678 100644 --- a/slack-danbot/commands/info.rb +++ b/slack-danbot/commands/info.rb @@ -3,7 +3,7 @@ class Info < SlackRubyBot::Commands::Base command 'get_basic_info' do |client, data, _match| - client.say(c...
Make test commit for BeepBoop
diff --git a/app/controllers/spree/admin/postage_labels_controller.rb b/app/controllers/spree/admin/postage_labels_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/admin/postage_labels_controller.rb +++ b/app/controllers/spree/admin/postage_labels_controller.rb @@ -13,7 +13,7 @@ return ...
Fix redirect when Rails' `raise_on_open_redirect` is true That is the new default on Rails 7. We need to be explicit to allow redirecting to an external host. See https://api.rubyonrails.org/classes/ActionController/Redirecting.html#method-i-redirect_to-label-Open+Redirect+protection
diff --git a/lib/samuel.rb b/lib/samuel.rb index abc1234..def5678 100644 --- a/lib/samuel.rb +++ b/lib/samuel.rb @@ -21,10 +21,13 @@ @logger = nil if !defined?(@logger) return @logger if !@logger.nil? - if defined?(RAILS_DEFAULT_LOGGER) - @logger = RAILS_DEFAULT_LOGGER - else - @logger = Logg...
Use Rails.logger when available (fix deprecation warning in Rails 3.x)
diff --git a/lib/ci_in_a_can/bash_result.rb b/lib/ci_in_a_can/bash_result.rb index abc1234..def5678 100644 --- a/lib/ci_in_a_can/bash_result.rb +++ b/lib/ci_in_a_can/bash_result.rb @@ -1,5 +1,13 @@ module CiInACan + class BashResult + attr_accessor :exit_code, :output + + def success + exit_code == 0 + ...
Add a method to be able to determine if the call was successful or not.
diff --git a/spec/reel/unix_server_spec.rb b/spec/reel/unix_server_spec.rb index abc1234..def5678 100644 --- a/spec/reel/unix_server_spec.rb +++ b/spec/reel/unix_server_spec.rb @@ -17,22 +17,16 @@ end end -=begin Dir::Tmpname.create('reel-sock') do |path| begin - - sock = Net::Buffe...
Fix broken UNIX server test
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -22,7 +22,7 @@ # Rails' instrumentation code, and is run after each request. def append...
Fix output of custom log attributes
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,11 +2,13 @@ protect_from_forgery with: :exception force_ssl if: :ssl_configured? -...
Add `is_admin` instance var for permission fun
diff --git a/app/controllers/admin_controller.rb b/app/controllers/admin_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin_controller.rb +++ b/app/controllers/admin_controller.rb @@ -6,11 +6,13 @@ private def require_user - redirect_to '/auth/google_oauth2' unless session[:user_id] + ...
Check the current user instead of just the session id
diff --git a/gems/pending/util/extensions/miq-yaml.rb b/gems/pending/util/extensions/miq-yaml.rb index abc1234..def5678 100644 --- a/gems/pending/util/extensions/miq-yaml.rb +++ b/gems/pending/util/extensions/miq-yaml.rb @@ -6,11 +6,13 @@ module Psych module Visitors class ToRuby + SHOVEL = '<<' + ...
Use constants for these strings instead of freezing them. Reworked #4371 based on: https://github.com/tenderlove/psych/pull/249
diff --git a/app/graphql/types/connection_data_type.rb b/app/graphql/types/connection_data_type.rb index abc1234..def5678 100644 --- a/app/graphql/types/connection_data_type.rb +++ b/app/graphql/types/connection_data_type.rb @@ -2,11 +2,7 @@ name 'ConnectionData' description 'Common type to fetch fields for variou...
Use regular id field as answers response is fixed
diff --git a/lib/foundation_rails_helper/flash_helper.rb b/lib/foundation_rails_helper/flash_helper.rb index abc1234..def5678 100644 --- a/lib/foundation_rails_helper/flash_helper.rb +++ b/lib/foundation_rails_helper/flash_helper.rb @@ -16,7 +16,7 @@ key_matching = DEFAULT_KEY_MATCHING.merge(key_matching) ...
Add data-alert attribute to content_tag
diff --git a/test/support/effective_test_bot_login_helper.rb b/test/support/effective_test_bot_login_helper.rb index abc1234..def5678 100644 --- a/test/support/effective_test_bot_login_helper.rb +++ b/test/support/effective_test_bot_login_helper.rb @@ -7,6 +7,10 @@ def sign_in(user) # Warden::Test::Helpers use...
Add sign_out as an alias for logout
diff --git a/lib/low_voltage/post_finder.rb b/lib/low_voltage/post_finder.rb index abc1234..def5678 100644 --- a/lib/low_voltage/post_finder.rb +++ b/lib/low_voltage/post_finder.rb @@ -1,5 +1,10 @@ module LowVoltage - class PostFinder < HighVoltage::PageFinder + class PostFinder + VALID_CHARACTERS = "a-zA-Z0-9~!@$...
Rewrite post finder to not extend HighVoltage::PageFinder.
diff --git a/lib/reports/published_attachments_report.rb b/lib/reports/published_attachments_report.rb index abc1234..def5678 100644 --- a/lib/reports/published_attachments_report.rb +++ b/lib/reports/published_attachments_report.rb @@ -1,7 +1,7 @@ module Reports class PublishedAttachmentsReport def report - ...
Fix path for attachment report directory A slash was missed from the start of the path, so the output file for the published attachment report was being written to the application deployment directory, rather than the machine's /tmp directory.
diff --git a/lib/smart_answer/question/country_select.rb b/lib/smart_answer/question/country_select.rb index abc1234..def5678 100644 --- a/lib/smart_answer/question/country_select.rb +++ b/lib/smart_answer/question/country_select.rb @@ -1,10 +1,9 @@ module SmartAnswer module Question - class CountrySelect < Multi...
Fix the CountrySelect initialize to not load options This was unnecessary and seemed to be incorrect, maybe a hangover from inheriting from MultipleChoice. This change means it doesn't need to load the countries from the API on initialise, which means it doesn't need to load them when registering with Panopticon... w...
diff --git a/app/services/pages_core/invite_service.rb b/app/services/pages_core/invite_service.rb index abc1234..def5678 100644 --- a/app/services/pages_core/invite_service.rb +++ b/app/services/pages_core/invite_service.rb @@ -14,8 +14,8 @@ end class << self - def call(*attrs) - new(*attrs).cal...
Use explicit attributes in InviteService.call
diff --git a/lib/renalware/configuration.rb b/lib/renalware/configuration.rb index abc1234..def5678 100644 --- a/lib/renalware/configuration.rb +++ b/lib/renalware/configuration.rb @@ -22,7 +22,7 @@ config_accessor(:salutation_prefix) { "Dear" } config_accessor(:page_title_spearator) { " : " } config_acce...
Change session expired polling freq to 1 min To reduce noise in logs
diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/application_helper_spec.rb +++ b/spec/helpers/application_helper_spec.rb @@ -0,0 +1,22 @@+require 'spec_helper' + +# Specs in this file have access to a helper object that incl...
Add stub for ApplicationHelper spec.
diff --git a/spec/lib/tasks/after_precompile_spec.rb b/spec/lib/tasks/after_precompile_spec.rb index abc1234..def5678 100644 --- a/spec/lib/tasks/after_precompile_spec.rb +++ b/spec/lib/tasks/after_precompile_spec.rb @@ -34,7 +34,6 @@ end after do - Rake::Task["assets:clobber"].execute FileUtils.rm_r(Dir...
Remove a redundant execution of rake task
diff --git a/lib/stripe/bitcoin_receiver.rb b/lib/stripe/bitcoin_receiver.rb index abc1234..def5678 100644 --- a/lib/stripe/bitcoin_receiver.rb +++ b/lib/stripe/bitcoin_receiver.rb @@ -10,7 +10,7 @@ end def url - if respond_to?(:customer) + if respond_to?(:customer) && !self.customer.nil? ...
Check for nil customer value when determining bitcoin receiver URL Stripe API responses include `customer: nil`, which causes `refresh` to throw an exception
diff --git a/spec/lib/use_case/question/create_followers_spec.rb b/spec/lib/use_case/question/create_followers_spec.rb index abc1234..def5678 100644 --- a/spec/lib/use_case/question/create_followers_spec.rb +++ b/spec/lib/use_case/question/create_followers_spec.rb @@ -0,0 +1,29 @@+# frozen_string_literal: true + +requi...
Add tests for question create followers use case
diff --git a/BartyCrouch.podspec b/BartyCrouch.podspec index abc1234..def5678 100644 --- a/BartyCrouch.podspec +++ b/BartyCrouch.podspec @@ -2,12 +2,12 @@ s.name = "BartyCrouch" s.version = "4.0.1" - s.summary = "Localization/I18n: Incrementally update your Strings files from .swift, .h, .m(m)...
Update description & summary in podspec
diff --git a/app/controllers/admin/posts_controller.rb b/app/controllers/admin/posts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/posts_controller.rb +++ b/app/controllers/admin/posts_controller.rb @@ -33,7 +33,7 @@ private def post_params - params.permit(:id, post: [:author, :publi...
Add title to allowed parameters
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,5 +1,5 @@ class ApplicationController < ActionController::Base # Prevent CSRF attacks ...
Save us, null_session, you're our only hope
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -11,10 +11,10 @@ end def authorize_user - redirect_to :back, error: "You can...
Fix Bug in authorize methods
diff --git a/lib/spree_paypal_express.rb b/lib/spree_paypal_express.rb index abc1234..def5678 100644 --- a/lib/spree_paypal_express.rb +++ b/lib/spree_paypal_express.rb @@ -7,7 +7,6 @@ config.autoload_paths += %W(#{config.root}/lib) def self.activate - debugger Dir.glob(File.join(File.dirname(__F...
Remove debugger statement accidentally left in ff443b2