diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/helpers/page_helper.rb b/app/helpers/page_helper.rb index abc1234..def5678 100644 --- a/app/helpers/page_helper.rb +++ b/app/helpers/page_helper.rb @@ -1,6 +1,7 @@ module PageHelper def project_versions(project) versions = Services::Projects::ConvertTagsToVersions.call(project.tags) + versio...
Fix showing versions for a project
diff --git a/db/migrate/20180423091042_create_intervention_proposal_parameters.planning_engine.rb b/db/migrate/20180423091042_create_intervention_proposal_parameters.planning_engine.rb index abc1234..def5678 100644 --- a/db/migrate/20180423091042_create_intervention_proposal_parameters.planning_engine.rb +++ b/db/migra...
Remove quantity and unit columns for migration after
diff --git a/spec/classes/java_spec.rb b/spec/classes/java_spec.rb index abc1234..def5678 100644 --- a/spec/classes/java_spec.rb +++ b/spec/classes/java_spec.rb @@ -4,8 +4,8 @@ let(:facts) { default_test_facts } let(:params) { { - update_version: '42', - base_download_url: 'https://downloads.test/ja...
Drop Ruby 1.9 hash syntax
diff --git a/config/puma.rb b/config/puma.rb index abc1234..def5678 100644 --- a/config/puma.rb +++ b/config/puma.rb @@ -5,7 +5,7 @@ end port ENV['PORT'] -environment ENV['RACK_ENV'] +environment ENV['RAILS_ENV'] preload_app!
Use RAILS_ENV instead of RACK_ENV
diff --git a/spec/requests/api_spec.rb b/spec/requests/api_spec.rb index abc1234..def5678 100644 --- a/spec/requests/api_spec.rb +++ b/spec/requests/api_spec.rb @@ -11,96 +11,4 @@ expect(response.status).to eq(400) end end - - describe 'POST /api/v1/login/call_back/' do - before do - post '/api/v...
Delete to not use specs
diff --git a/spec/sub_diff/sub_spec.rb b/spec/sub_diff/sub_spec.rb index abc1234..def5678 100644 --- a/spec/sub_diff/sub_spec.rb +++ b/spec/sub_diff/sub_spec.rb @@ -0,0 +1,53 @@+require_relative '../../lib/sub_diff/sub' + +RSpec.describe SubDiff::Sub do + subject { described_class.new diffable } + + let(:diffable) { ...
Add spec for `Sub` class
diff --git a/htty.gemspec b/htty.gemspec index abc1234..def5678 100644 --- a/htty.gemspec +++ b/htty.gemspec @@ -2,9 +2,9 @@ s.name = 'htty' s.version = File.read('VERSION').chomp s.summary = 'The HTTP TTY' - s.description = 'htty is a console application for interacting with HTTP ' + - ...
Tweak the RubyGems project description
diff --git a/bosh_openstack_cpi.gemspec b/bosh_openstack_cpi.gemspec index abc1234..def5678 100644 --- a/bosh_openstack_cpi.gemspec +++ b/bosh_openstack_cpi.gemspec @@ -20,7 +20,7 @@ s.bindir = "bin" s.executables = %w(bosh_openstack_console) - s.add_dependency "fog", "~>1.10.1" + s.add_dependency "fog"...
Upgrade fog gem to v1.11.1
diff --git a/spec/features/users/form_answers/letters_of_support_spec.rb b/spec/features/users/form_answers/letters_of_support_spec.rb index abc1234..def5678 100644 --- a/spec/features/users/form_answers/letters_of_support_spec.rb +++ b/spec/features/users/form_answers/letters_of_support_spec.rb @@ -23,19 +23,19 @@ e...
Update spec, stub virus scanner
diff --git a/cutcut.gemspec b/cutcut.gemspec index abc1234..def5678 100644 --- a/cutcut.gemspec +++ b/cutcut.gemspec @@ -5,7 +5,7 @@ s.homepage = 'http://github.com/stjhimy/cutcut' s.license = 'MIT' s.summary = 'Trim/Cut/Screenshot videos' - s.description = 'CLI for Trim/Cut/Screenshot videos' + s....
Update description and release to rubygems
diff --git a/infopen-docker.gemspec b/infopen-docker.gemspec index abc1234..def5678 100644 --- a/infopen-docker.gemspec +++ b/infopen-docker.gemspec @@ -2,8 +2,8 @@ # Common informations spec.name = 'infopen-docker' - spec.version = '0.0.0' - spec.date = '2015-12-05' + spec.version...
Set first version of gem
diff --git a/reru.gemspec b/reru.gemspec index abc1234..def5678 100644 --- a/reru.gemspec +++ b/reru.gemspec @@ -20,6 +20,7 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_development_dependency "travis-lint" spec.add_runtime_dependency "activesuppor...
Add travis-lint to development dependencies
diff --git a/lib/schema_plus/pg_types/active_record/connection_adapters/postgresql/oid/interval.rb b/lib/schema_plus/pg_types/active_record/connection_adapters/postgresql/oid/interval.rb index abc1234..def5678 100644 --- a/lib/schema_plus/pg_types/active_record/connection_adapters/postgresql/oid/interval.rb +++ b/lib/s...
Fix typo in method name (_to_i)
diff --git a/taskhandler.rb b/taskhandler.rb index abc1234..def5678 100644 --- a/taskhandler.rb +++ b/taskhandler.rb @@ -22,7 +22,8 @@ "tasks" => [ { "task" => arg_task, - "due_date" => Date.parse(arg_duedate) + "due_date" => Date.parse(arg_duedate), + "status" => "open" ...
Add status when the task is added
diff --git a/config/initializers/01_app_config.rb b/config/initializers/01_app_config.rb index abc1234..def5678 100644 --- a/config/initializers/01_app_config.rb +++ b/config/initializers/01_app_config.rb @@ -13,7 +13,9 @@ raise "Can't find App configuration for #{Rails.env} environment on config/app_config.yml" ...
Check if mandatory_key key is present on app_config
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -NoMoreIdeas::Application.config.sess...
Update configuration for new Rails update
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,8 +1,13 @@ # Be sure to restart your server when you modify this file. # Rails.application.config.session_...
Change session store from redis to cookie
diff --git a/cookbooks/windows/recipes/default.rb b/cookbooks/windows/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/windows/recipes/default.rb +++ b/cookbooks/windows/recipes/default.rb @@ -33,27 +33,4 @@ end end -# Webtrends System Setup -#Install SNMP feature -windows_feature "SNMP-Service" ...
Remove Webtrends server config out of the Windows cookbook Former-commit-id: 1415fd5f056aaf5e0d08a2754495602e135135df
diff --git a/lib/myaso.rb b/lib/myaso.rb index abc1234..def5678 100644 --- a/lib/myaso.rb +++ b/lib/myaso.rb @@ -11,13 +11,13 @@ class << self # Return the root path of the <tt>Myaso</tt> gem. def root - @myaso_root ||= File.expand_path('../../', __FILE__) + @@myaso_root ||= File.expand_path('../....
Use cvar instead of ivar in Myaso class
diff --git a/config/initializers/exlibris_aleph.rb b/config/initializers/exlibris_aleph.rb index abc1234..def5678 100644 --- a/config/initializers/exlibris_aleph.rb +++ b/config/initializers/exlibris_aleph.rb @@ -4,5 +4,7 @@ # Load all the item circulation policies when the application starts Exlibris::Aleph::Tabl...
Print the exlibris-aleph initializer error message to standard output
diff --git a/db/migrate/20170204203531_create_pin_tag_votes.rb b/db/migrate/20170204203531_create_pin_tag_votes.rb index abc1234..def5678 100644 --- a/db/migrate/20170204203531_create_pin_tag_votes.rb +++ b/db/migrate/20170204203531_create_pin_tag_votes.rb @@ -0,0 +1,9 @@+class CreatePinTagVotes < ActiveRecord::Migrati...
Create migrate for pintagvotes table with pintagid and userid
diff --git a/image_data_processor/parser/xml_to_hash.rb b/image_data_processor/parser/xml_to_hash.rb index abc1234..def5678 100644 --- a/image_data_processor/parser/xml_to_hash.rb +++ b/image_data_processor/parser/xml_to_hash.rb @@ -6,6 +6,8 @@ module Parser::XmlToHash class << self + # TODO: Load the pat...
Add TODO comment for loading paths from a config file or something.
diff --git a/lib/casa/receiver/strategy/adj_in_filter.rb b/lib/casa/receiver/strategy/adj_in_filter.rb index abc1234..def5678 100644 --- a/lib/casa/receiver/strategy/adj_in_filter.rb +++ b/lib/casa/receiver/strategy/adj_in_filter.rb @@ -17,7 +17,7 @@ allows = true @attributes.each do |attribute_n...
Fix respond_to? check for in_filter
diff --git a/capybara_wysihtml5.gemspec b/capybara_wysihtml5.gemspec index abc1234..def5678 100644 --- a/capybara_wysihtml5.gemspec +++ b/capybara_wysihtml5.gemspec @@ -8,8 +8,8 @@ spec.version = CapybaraWysihtml5::VERSION spec.authors = ["Miles Z. Sterrett"] spec.email = ["miles@mileszs.com...
Add description and summary to gemspec
diff --git a/lib/duby/jvm/source_generator/precompile.rb b/lib/duby/jvm/source_generator/precompile.rb index abc1234..def5678 100644 --- a/lib/duby/jvm/source_generator/precompile.rb +++ b/lib/duby/jvm/source_generator/precompile.rb @@ -0,0 +1,124 @@+require 'duby/ast' + +module Duby::AST + class TempValue + def in...
Add file missing from .java cleanup.
diff --git a/utility/android_studio.rb b/utility/android_studio.rb index abc1234..def5678 100644 --- a/utility/android_studio.rb +++ b/utility/android_studio.rb @@ -11,9 +11,9 @@ end if manifest.length > 0 - dir = File.dirname(__FILE__) + dir = `pwd` puts "open -a Android\ Studio #{dir}" - `open -a Android\\ Studi...
Fix Android Studio Open ShortCut Bug
diff --git a/handlebars_assets.gemspec b/handlebars_assets.gemspec index abc1234..def5678 100644 --- a/handlebars_assets.gemspec +++ b/handlebars_assets.gemspec @@ -6,8 +6,9 @@ s.name = "handlebars_assets" s.version = HandlebarsAssets::VERSION s.authors = ["Les Hill"] + s.licenses = ["MIT"] ...
Add Licenses and Homepage to gemspec.
diff --git a/lib/omniauth/strategies/wordpress_hosted.rb b/lib/omniauth/strategies/wordpress_hosted.rb index abc1234..def5678 100644 --- a/lib/omniauth/strategies/wordpress_hosted.rb +++ b/lib/omniauth/strategies/wordpress_hosted.rb @@ -8,7 +8,7 @@ # This is where you pass the options you would pass when ...
Update endpoints used by WP OAuth Server 3.1.3
diff --git a/lib/reports/published_attachments_report.rb b/lib/reports/published_attachments_report.rb index abc1234..def5678 100644 --- a/lib/reports/published_attachments_report.rb +++ b/lib/reports/published_attachments_report.rb @@ -28,7 +28,7 @@ attachment.attachable.organisations.map(&:name).join("; "...
Switch published attachment report to use attachment date The Data Standards Authority have asked us to change the date included in the published attachments report (introduced in https://github.com/alphagov/whitehall/pull/6148) to be the attachment update date, rather than the date the edition was first published.
diff --git a/lib/childprocess/abstract_io.rb b/lib/childprocess/abstract_io.rb index abc1234..def5678 100644 --- a/lib/childprocess/abstract_io.rb +++ b/lib/childprocess/abstract_io.rb @@ -1,6 +1,11 @@ module ChildProcess class AbstractIO attr_reader :stderr, :stdout + + def inherit! + @stdout = STDOUT ...
Add a simple way to inherit the parent's output streams.
diff --git a/lib/danger/ci_source/bitrise.rb b/lib/danger/ci_source/bitrise.rb index abc1234..def5678 100644 --- a/lib/danger/ci_source/bitrise.rb +++ b/lib/danger/ci_source/bitrise.rb @@ -29,7 +29,11 @@ end def supported_request_sources - @supported_request_sources ||= [Danger::RequestSources::GitHub, ...
Enable Bitbucket Server support for Bitrise CI
diff --git a/lib/gutenberg/book/paragraph.rb b/lib/gutenberg/book/paragraph.rb index abc1234..def5678 100644 --- a/lib/gutenberg/book/paragraph.rb +++ b/lib/gutenberg/book/paragraph.rb @@ -1,5 +1,6 @@-class Paragraph +class Paragraph < String def initialize string + super string @paragraph = string end
Make Paragraph to be a subclass of String
diff --git a/lib/apns-s3.rb b/lib/apns-s3.rb index abc1234..def5678 100644 --- a/lib/apns-s3.rb +++ b/lib/apns-s3.rb @@ -5,28 +5,30 @@ module ApnsS3 # Set PEM file to APNS module # + # @param [String] region + # One of ap-northeast-1, ap-southeast-1, ap-southeast-2, eu-central-1, + # eu-west-1, sa-east-1, ...
Fix for AWS SDK 2
diff --git a/lib/active_storage/service/gcs_service.rb b/lib/active_storage/service/gcs_service.rb index abc1234..def5678 100644 --- a/lib/active_storage/service/gcs_service.rb +++ b/lib/active_storage/service/gcs_service.rb @@ -36,14 +36,20 @@ def exist?(key) instrument :exist, key do |payload| - payload...
Revert back to the original implementaion with varaibles Revert `exist? and url` to the original implementation. Since the new one doesn't provide any benefits and makes implementation harder to follow.
diff --git a/lib/bebox/server.rb b/lib/bebox/server.rb index abc1234..def5678 100644 --- a/lib/bebox/server.rb +++ b/lib/bebox/server.rb @@ -10,27 +10,14 @@ I18n.enforce_available_locales = false def ip_free? - pattern = Regexp.new("Destination Host Unreachable") - ip_is_available =false - `pi...
Change ip_free? method to work in multiple OS
diff --git a/lib/cognizant/util/symbolize_hash_keys.rb b/lib/cognizant/util/symbolize_hash_keys.rb index abc1234..def5678 100644 --- a/lib/cognizant/util/symbolize_hash_keys.rb +++ b/lib/cognizant/util/symbolize_hash_keys.rb @@ -0,0 +1,19 @@+class Hash + # Destructively convert all keys by using the block operation. +...
Add deep symbolizing util for Hash.
diff --git a/lib/csvable.rb b/lib/csvable.rb index abc1234..def5678 100644 --- a/lib/csvable.rb +++ b/lib/csvable.rb @@ -1,7 +1,12 @@+# frozen_string_literal: true + module Csvable + + require "csv" + class << self def from_array_of_hashes(data = []) - return '' unless data.first&.keys + return "" u...
Fix missing CSV requirement from Csvable module
diff --git a/lib/paypal_adaptive/response.rb b/lib/paypal_adaptive/response.rb index abc1234..def5678 100644 --- a/lib/paypal_adaptive/response.rb +++ b/lib/paypal_adaptive/response.rb @@ -1,7 +1,7 @@ module PaypalAdaptive class Response < Hash def initialize(response, env=nil) - config = PaypalAdaptiv...
Fix to use Rails config file for Responses as well as Requests
diff --git a/lib/vagrant-rekey-ssh/actions/ssh_info.rb b/lib/vagrant-rekey-ssh/actions/ssh_info.rb index abc1234..def5678 100644 --- a/lib/vagrant-rekey-ssh/actions/ssh_info.rb +++ b/lib/vagrant-rekey-ssh/actions/ssh_info.rb @@ -31,7 +31,7 @@ if Vagrant::VERSION < "1.4.0" @machine.config....
Fix problems transitioning from insecure_private_key to less_insecure_private_key (Vagrant >= 1.4.0) This doesn't fix Vagrant < 1.4.0. Without this, `vagrant reload` after installing the plugin just hangs forever waiting for the VM to boot, with output similar to the following: ==> default: Less insecure SSH key...
diff --git a/rails/app/controllers/auth_controller.rb b/rails/app/controllers/auth_controller.rb index abc1234..def5678 100644 --- a/rails/app/controllers/auth_controller.rb +++ b/rails/app/controllers/auth_controller.rb @@ -20,24 +20,26 @@ end def callback - code = params[:code] + token = Octokit.exchange...
Tidy up the auth controller a bit
diff --git a/lib/selectivizr/rails/engine.rb b/lib/selectivizr/rails/engine.rb index abc1234..def5678 100644 --- a/lib/selectivizr/rails/engine.rb +++ b/lib/selectivizr/rails/engine.rb @@ -2,7 +2,7 @@ module Rails class Engine < ::Rails::Engine initializer 'Selectivizr precompile hook', :group => :all do ...
Fix a huge, glaring error thanks to @graff
diff --git a/lib/haml/railtie.rb b/lib/haml/railtie.rb index abc1234..def5678 100644 --- a/lib/haml/railtie.rb +++ b/lib/haml/railtie.rb @@ -26,7 +26,7 @@ require "haml/sass_rails_filter" end - if defined?(::Erubi) && const_defined?('ActionView::Template::Handlers::ERB::Erubi') + if c...
Remove extraneous condition for Erubi
diff --git a/lib/sub_diff/diff_collection.rb b/lib/sub_diff/diff_collection.rb index abc1234..def5678 100644 --- a/lib/sub_diff/diff_collection.rb +++ b/lib/sub_diff/diff_collection.rb @@ -14,6 +14,7 @@ def initialize(diffable) @diffable = diffable @diffs = [] + super(diffable) end de...
Use __setobj__ instead of overwriting __getobj__
diff --git a/lib/zlown/cli/cmd/script_cmd.rb b/lib/zlown/cli/cmd/script_cmd.rb index abc1234..def5678 100644 --- a/lib/zlown/cli/cmd/script_cmd.rb +++ b/lib/zlown/cli/cmd/script_cmd.rb @@ -15,7 +15,7 @@ end cmd.desc 'Stop httpry' - cmd.command 'start' do |script_cmd| + cmd.command 'stop' do |sc...
Fix typo 'start' -> 'stop'
diff --git a/lib/mytime/setup.rb b/lib/mytime/setup.rb index abc1234..def5678 100644 --- a/lib/mytime/setup.rb +++ b/lib/mytime/setup.rb @@ -0,0 +1,36 @@+module Mytime + extend self + + # Create .mytime file in the profile directory + # and insert the user account and Freshbooks token + # + def init + puts "...
Add methods responsible for initializing mytime
diff --git a/lib/patches/tire.rb b/lib/patches/tire.rb index abc1234..def5678 100644 --- a/lib/patches/tire.rb +++ b/lib/patches/tire.rb @@ -2,6 +2,8 @@ module Results class Item + + attr_reader :attributes def class defined?(::Padrino) && @attributes[:_type] ? @attributes[:_type].cameli...
Fix more methods in Tire
diff --git a/lib/onionjs.rb b/lib/onionjs.rb index abc1234..def5678 100644 --- a/lib/onionjs.rb +++ b/lib/onionjs.rb @@ -0,0 +1,15 @@+module Onionjs + class Engine < Rails::Engine + + initializer "onionjs" do |app| + app.assets.paths << app.root.join('app/assets/modules') + + # If requirejs-rails is prese...
Make it a (requirejs-rails - friendly) Rails Engine
diff --git a/lib/tasks/sync.rake b/lib/tasks/sync.rake index abc1234..def5678 100644 --- a/lib/tasks/sync.rake +++ b/lib/tasks/sync.rake @@ -1,11 +1,9 @@ namespace :sync do desc "Broadcast all current publications states" task :broadcast => :environment do - Publication.all.each do |pub| - if pub.has_publ...
Use the Publication.published scope to more efficiently pull out published stuff
diff --git a/lib/xhive/engine.rb b/lib/xhive/engine.rb index abc1234..def5678 100644 --- a/lib/xhive/engine.rb +++ b/lib/xhive/engine.rb @@ -1,5 +1,18 @@+require "cells" + module Xhive class Engine < ::Rails::Engine isolate_namespace Xhive + ::Cell::Base.prepend_view_path('app/cells') + initializer "xhiv...
Load all controllers on initialization
diff --git a/SwiftyUserDefaults.podspec b/SwiftyUserDefaults.podspec index abc1234..def5678 100644 --- a/SwiftyUserDefaults.podspec +++ b/SwiftyUserDefaults.podspec @@ -1,10 +1,10 @@ Pod::Spec.new do |s| s.name = 'SwiftyUserDefaults' - s.version = '3.0.1' + s.version = '4.0.0-alpha.1' s.license = 'MIT' s.sum...
Prepare podspec for version 4.0.0-alpha.1
diff --git a/lib/arrthorizer/rails/controller_action.rb b/lib/arrthorizer/rails/controller_action.rb index abc1234..def5678 100644 --- a/lib/arrthorizer/rails/controller_action.rb +++ b/lib/arrthorizer/rails/controller_action.rb @@ -26,8 +26,8 @@ private attr_writer :controller_path, :action_name - de...
Improve variable naming in the key_for method This eliminates doubt about whether this is a controller instance or a controller class - it is just the current controller, executing the current action.
diff --git a/lib/flying_sphinx/configuration_options.rb b/lib/flying_sphinx/configuration_options.rb index abc1234..def5678 100644 --- a/lib/flying_sphinx/configuration_options.rb +++ b/lib/flying_sphinx/configuration_options.rb @@ -3,7 +3,7 @@ def initialize(raw = nil, version = nil) @raw = raw || configu...
Use Sphinx 2.2.11 by default.
diff --git a/lib/generators/npush/toheroku_generator.rb b/lib/generators/npush/toheroku_generator.rb index abc1234..def5678 100644 --- a/lib/generators/npush/toheroku_generator.rb +++ b/lib/generators/npush/toheroku_generator.rb @@ -35,7 +35,7 @@ end end - append_file 'app/assets/jav...
Prepend requires instead of appending them + add semicolon at the end of client js initializer
diff --git a/lib/specinfra/command/smartos/base/file.rb b/lib/specinfra/command/smartos/base/file.rb index abc1234..def5678 100644 --- a/lib/specinfra/command/smartos/base/file.rb +++ b/lib/specinfra/command/smartos/base/file.rb @@ -1,11 +1,11 @@ class Specinfra::Command::Smartos::Base::File < Specinfra::Command::Solar...
Use full path to digest This way we don't accidentally use the pkgsrc version
diff --git a/activesupport/lib/active_support/configuration_file.rb b/activesupport/lib/active_support/configuration_file.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/configuration_file.rb +++ b/activesupport/lib/active_support/configuration_file.rb @@ -33,7 +33,7 @@ File.read(conte...
Include file path in invisible space warning While the warning is useful in itself, it doesn't tell you what file is specifically causing the issue which can make resolving it harder than it should be. As we've got the path already, we can simply include the location of the problematic file in the warning message.
diff --git a/lib/qbwc_requests/item_service/v07/mod.rb b/lib/qbwc_requests/item_service/v07/mod.rb index abc1234..def5678 100644 --- a/lib/qbwc_requests/item_service/v07/mod.rb +++ b/lib/qbwc_requests/item_service/v07/mod.rb @@ -0,0 +1,19 @@+module QbwcRequests + module ItemService + module V07 + class Mod < Q...
Allow service items to be updated
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -0,0 +1,27 @@+# +# Author:: Joshua Timberman (<joshua@opscode.com>) +# Cookbook Name:: apparmor +# Recipe:: default +# +# Copyright 2009, Opscode, Inc. +# +# Licensed under the Apache ...
Add apparmor recipe (ubuntu only)
diff --git a/config/initializers/unlimited_strength_cryptography.rb b/config/initializers/unlimited_strength_cryptography.rb index abc1234..def5678 100644 --- a/config/initializers/unlimited_strength_cryptography.rb +++ b/config/initializers/unlimited_strength_cryptography.rb @@ -2,4 +2,15 @@ begin java.lang.Class.f...
Add some logging for the cursed crytography issue with rails and jruby
diff --git a/lib/possibly.rb b/lib/possibly.rb index abc1234..def5678 100644 --- a/lib/possibly.rb +++ b/lib/possibly.rb @@ -3,7 +3,7 @@ ([:each] + Enumerable.instance_methods).each do |enumerable_method| define_method(enumerable_method) { |*args, &block| res = __enumerable_value.send(enumerable_met...
Use first instead of accessing by id
diff --git a/lib/conceptql/nodes/drug_type_concept.rb b/lib/conceptql/nodes/drug_type_concept.rb index abc1234..def5678 100644 --- a/lib/conceptql/nodes/drug_type_concept.rb +++ b/lib/conceptql/nodes/drug_type_concept.rb @@ -0,0 +1,18 @@+require_relative 'node' + +module ConceptQL + module Nodes + class DrugTypeCon...
DrugConceptType: Add a prototype for this criterion node
diff --git a/lib/miq_pglogical/connection_handling.rb b/lib/miq_pglogical/connection_handling.rb index abc1234..def5678 100644 --- a/lib/miq_pglogical/connection_handling.rb +++ b/lib/miq_pglogical/connection_handling.rb @@ -15,8 +15,15 @@ end def pglogical(refresh = false) - @pglogical = nil if r...
Remove class cache called in threads to avoid timing issues Fixes #20979 The first two calls of the class method pg_logical can and are often called in threads, leading to race conditions with two threads sharing the same PG::LogicalReplication::Client object, ultimately ending in various fatal errors including segme...
diff --git a/lib/rock_doc/interrogation/controller.rb b/lib/rock_doc/interrogation/controller.rb index abc1234..def5678 100644 --- a/lib/rock_doc/interrogation/controller.rb +++ b/lib/rock_doc/interrogation/controller.rb @@ -17,13 +17,30 @@ if configuration.controller_class.respond_to?(:permitted_params) &&...
Fix a bug with permitted param hashes
diff --git a/lib/rubocop/cop/style/space_after_not.rb b/lib/rubocop/cop/style/space_after_not.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/style/space_after_not.rb +++ b/lib/rubocop/cop/style/space_after_not.rb @@ -16,9 +16,9 @@ MSG = 'Do not leave space between `!` and its argument.'.freeze ...
Reorder some code to make it a bit more efficient
diff --git a/lib/parallelios/cli.rb b/lib/parallelios/cli.rb index abc1234..def5678 100644 --- a/lib/parallelios/cli.rb +++ b/lib/parallelios/cli.rb @@ -5,6 +5,51 @@ module Parallelios # Command-Line Interfaces of project class CLI < Thor + # Command-Line Interface help. + # + # shell - String command na...
Create help and start test methods for CLI
diff --git a/lib/rubygems_plugin.rb b/lib/rubygems_plugin.rb index abc1234..def5678 100644 --- a/lib/rubygems_plugin.rb +++ b/lib/rubygems_plugin.rb @@ -2,5 +2,5 @@ Gem::CommandManager.instance.register_command :sign Gem::CommandManager.instance.register_command :verify -Gem::CommandManager.instance.register_command...
Disable vinstall and sbuild totally
diff --git a/linked_list_reverse.rb b/linked_list_reverse.rb index abc1234..def5678 100644 --- a/linked_list_reverse.rb +++ b/linked_list_reverse.rb @@ -0,0 +1,36 @@+class Node + attr_accessor :value, :next + + def initialize(value) + @value = value + @next = nil + end + +end + +def reverseList(head_of_list) ...
Create linked list reverse function
diff --git a/metadater.rb b/metadater.rb index abc1234..def5678 100644 --- a/metadater.rb +++ b/metadater.rb @@ -15,7 +15,7 @@ # These are the filetypes we consider to be videos # All others are not videos and we care nothing for them # Note that we will also scan files with no extensions. -@@filetypes = [ '.mov', '....
Add MKV to the extension whitelist
diff --git a/lib/rtasklib.rb b/lib/rtasklib.rb index abc1234..def5678 100644 --- a/lib/rtasklib.rb +++ b/lib/rtasklib.rb @@ -10,7 +10,7 @@ module Rtasklib class TaskWarrior - attr_reader :version, :data_location, :taskrc, :create_new, + attr_reader :version, :data_location, :taskrc, :overrid...
Use less confusing naming convention for the taskrc model
diff --git a/lib/bidu/house/error_report.rb b/lib/bidu/house/error_report.rb index abc1234..def5678 100644 --- a/lib/bidu/house/error_report.rb +++ b/lib/bidu/house/error_report.rb @@ -36,7 +36,7 @@ def as_json { - ids: scoped.map(&external_key), + ids: scoped.pluck(external_key), ...
Use pluck for better performance
diff --git a/examples/marketplace/classical-moip-account-flow-with-company.rb b/examples/marketplace/classical-moip-account-flow-with-company.rb index abc1234..def5678 100644 --- a/examples/marketplace/classical-moip-account-flow-with-company.rb +++ b/examples/marketplace/classical-moip-account-flow-with-company.rb @@ ...
Add example of creating moip account with company
diff --git a/lib/express_templates/components/forms/basic_fields.rb b/lib/express_templates/components/forms/basic_fields.rb index abc1234..def5678 100644 --- a/lib/express_templates/components/forms/basic_fields.rb +++ b/lib/express_templates/components/forms/basic_fields.rb @@ -3,7 +3,7 @@ module Forms mod...
Add `file` type for basic field form component - this introduce input field with file type mainly use for image uploading
diff --git a/week-6/validate-credit-card/my_solution.rb b/week-6/validate-credit-card/my_solution.rb index abc1234..def5678 100644 --- a/week-6/validate-credit-card/my_solution.rb +++ b/week-6/validate-credit-card/my_solution.rb @@ -18,8 +18,41 @@ class CreditCard + def initialize(number) + if number.to_s.lengt...
Complete pair challenge credit card
diff --git a/Casks/iterm2.rb b/Casks/iterm2.rb index abc1234..def5678 100644 --- a/Casks/iterm2.rb +++ b/Casks/iterm2.rb @@ -11,6 +11,8 @@ license :gpl auto_updates true + depends_on macos: '>= :lion' + depends_on arch: :intel app 'iTerm.app'
Update iTerm2: depends_on macos and arch
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -5,4 +5,15 @@ has_many :events_attended, through: :attendances, source: :event has_many :sent_nudges, class_name: "Nudge", foreign_key: :nudger_id has_many :recieved_nudges, cl...
Add ActiveRecord validations to model
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -12,7 +12,7 @@ # Setup accessible (or protected) attributes for your model attr_accessible :email, :first_name, :last_name, :password, :password_confirmation, :remember_me - sc...
Fix SQL query syntax so we get agents and admins
diff --git a/deployment_scripts/puppet/modules/contrail/lib/puppet/parser/functions/get_physdev_mtu.rb b/deployment_scripts/puppet/modules/contrail/lib/puppet/parser/functions/get_physdev_mtu.rb index abc1234..def5678 100644 --- a/deployment_scripts/puppet/modules/contrail/lib/puppet/parser/functions/get_physdev_mtu.rb...
Fix function that get mtu for vhost0 On dpdk computes function get_physdev_mtu dont get right mtu because we override action for bond0 to noop. [DE271493] Change-Id: I12d317df777cf503408aa28152634206d11c1e5a
diff --git a/app/controllers/api/v1/needs_controller.rb b/app/controllers/api/v1/needs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/needs_controller.rb +++ b/app/controllers/api/v1/needs_controller.rb @@ -5,15 +5,11 @@ before_filter :authenticate_user! def create - spar...
Clean up needs create action
diff --git a/app/controllers/api/version1_controller.rb b/app/controllers/api/version1_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/version1_controller.rb +++ b/app/controllers/api/version1_controller.rb @@ -3,13 +3,14 @@ before_filter :set_site def get_proxy - result = @sit...
Fix NameError and parameter handling
diff --git a/app/controllers/leaderboards_controller.rb b/app/controllers/leaderboards_controller.rb index abc1234..def5678 100644 --- a/app/controllers/leaderboards_controller.rb +++ b/app/controllers/leaderboards_controller.rb @@ -1,23 +1,14 @@ class LeaderboardsController < ApplicationController def data - pla...
Use a hash default in calculating the leaderboard.
diff --git a/lib/communicator/tasks.rb b/lib/communicator/tasks.rb index abc1234..def5678 100644 --- a/lib/communicator/tasks.rb +++ b/lib/communicator/tasks.rb @@ -21,12 +21,20 @@ Communicator::Client.push rescue => err report_exception err, "Status" => "Sync failed while trying to PUSH messages" + ...
Make sure captured exceptions on communication are re-raised. Added communicator:purge rake-Task to clear message tables.
diff --git a/lib/cucumber/jira/soap.rb b/lib/cucumber/jira/soap.rb index abc1234..def5678 100644 --- a/lib/cucumber/jira/soap.rb +++ b/lib/cucumber/jira/soap.rb @@ -16,10 +16,10 @@ Cucumber::Jira.client.login(username, password) rescue Handsoap::Fault => e if prompt - puts 'Enter your u...
Update the username/password prompt in Cucumber::Jira.login
diff --git a/lib/daemons/gpx_import.rb b/lib/daemons/gpx_import.rb index abc1234..def5678 100644 --- a/lib/daemons/gpx_import.rb +++ b/lib/daemons/gpx_import.rb @@ -27,7 +27,7 @@ Notifier::deliver_gpx_failure(trace, '0 points parsed ok. Do they all have lat,lng,alt,timestamp?') end rescue Exception ...
Fix exception handling in GPX importer.
diff --git a/app/models/cfp/proposal.rb b/app/models/cfp/proposal.rb index abc1234..def5678 100644 --- a/app/models/cfp/proposal.rb +++ b/app/models/cfp/proposal.rb @@ -2,7 +2,7 @@ module Cfp class Proposal < ActiveRecord::Base - RANK_SCALE = (0..2).to_a + RANK_SCALE = (0..5).to_a TALK_LEVEL = %w(beginn...
Change evaluation range to 0..5
diff --git a/app/models/group_member.rb b/app/models/group_member.rb index abc1234..def5678 100644 --- a/app/models/group_member.rb +++ b/app/models/group_member.rb @@ -23,7 +23,7 @@ has_many :meetings, through: :group has_many :meeting_memberships, - lambda(group_member) { + lambda { |group_...
Use correct multiline lambda syntax
diff --git a/app/models/hound_config.rb b/app/models/hound_config.rb index abc1234..def5678 100644 --- a/app/models/hound_config.rb +++ b/app/models/hound_config.rb @@ -3,6 +3,7 @@ BETA_LANGUAGES = %w( eslint jscs + jshint mdast python swift
Mark `JsHint` as a beta language
diff --git a/spec/classes/trove_db_postgresql_spec.rb b/spec/classes/trove_db_postgresql_spec.rb index abc1234..def5678 100644 --- a/spec/classes/trove_db_postgresql_spec.rb +++ b/spec/classes/trove_db_postgresql_spec.rb @@ -34,13 +34,14 @@ }).each do |os,facts| context "on #{os}" do let (:facts) do - ...
Revert "CentOS 9: Disable unit tests dependent on puppet-postgresql" This reverts commit d07a47d2cbc51456a89936c3751013297fac96e9. Reason for revert: puppet-postgresql 8.1.0 was released and now the module supports RHEL 9 (and CentOS 9 effectively). Note: This change adds the service_provider fact in test fact data ...
diff --git a/spec/classes/trove_db_postgresql_spec.rb b/spec/classes/trove_db_postgresql_spec.rb index abc1234..def5678 100644 --- a/spec/classes/trove_db_postgresql_spec.rb +++ b/spec/classes/trove_db_postgresql_spec.rb @@ -2,21 +2,13 @@ describe 'trove::db::postgresql' do - let :req_params do - { :password =>...
Test multiple operating systems for trove::db::postgresql Change-Id: I93a9877415f0d7f8d48500f08ae2376c91ee3d06
diff --git a/spec/functional/topic_management_spec.rb b/spec/functional/topic_management_spec.rb index abc1234..def5678 100644 --- a/spec/functional/topic_management_spec.rb +++ b/spec/functional/topic_management_spec.rb @@ -21,6 +21,9 @@ end example "create partitions" do + unless kafka.support_api?(Kafka::P...
Check for the API support before running tests
diff --git a/app/controllers/admin/users_controller.rb b/app/controllers/admin/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/users_controller.rb +++ b/app/controllers/admin/users_controller.rb @@ -2,7 +2,7 @@ before_filter :load_user, only: [:show, :edit, :update] def index - @...
Fix Ruby 1.8 hash syntax
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,16 +1,26 @@ class ApplicationController < ActionController::Base # Prevent CSRF attack...
Add authenticate helper method to application controller
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -15,5 +15,4 @@ devise_parameter_sanitizer.for(:sign_up) << :last_name devise_parame...
Fix for rubocop in application controller
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -11,7 +11,7 @@ def adjust_format_for_iphone user_agent = request.env['HTTP_USER_AGENT...
Check for iPhone instead of AppleWebKit Mobile.
diff --git a/app/controllers/newsletters_controller.rb b/app/controllers/newsletters_controller.rb index abc1234..def5678 100644 --- a/app/controllers/newsletters_controller.rb +++ b/app/controllers/newsletters_controller.rb @@ -44,7 +44,7 @@ end def validate_permission - unless current_user.permissions.inclu...
Fix permission check in newsletters controller
diff --git a/app/controllers/posts/homes_controller.rb b/app/controllers/posts/homes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/posts/homes_controller.rb +++ b/app/controllers/posts/homes_controller.rb @@ -7,7 +7,7 @@ # GET /homes # GET /homes.json def index - @homes = Home.online + ...
Improve SQL request on homepage
diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api_controller.rb +++ b/app/controllers/api_controller.rb @@ -14,13 +14,19 @@ @control_blocks = ControlBlock.find( :all, :conditions => [ "base_station_id = ? AND dea...
Return 404 on api if base station doesn't exist
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -4,7 +4,7 @@ IPAddr::RE_IPV6ADDRLIKE_COMPRESSED) def apps_hosts - hosts = %w(oregon us eu tokyo).map{|region| "p...
Add host for Sydney region
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -22,7 +22,7 @@ reverse: true, description: meta_description, og: { - image: @article.try(:eye_cat...
Fix og:iamge is always empty
diff --git a/app/models/content_item_expanded_links.rb b/app/models/content_item_expanded_links.rb index abc1234..def5678 100644 --- a/app/models/content_item_expanded_links.rb +++ b/app/models/content_item_expanded_links.rb @@ -2,22 +2,7 @@ include ActiveModel::Model attr_accessor :content_id, :previous_version ...
Remove feature flag for related links tagging We're finishing this feature now. Because of the deploy freeze this is safe to merge now.
diff --git a/lib/hubs3d/model.rb b/lib/hubs3d/model.rb index abc1234..def5678 100644 --- a/lib/hubs3d/model.rb +++ b/lib/hubs3d/model.rb @@ -16,7 +16,11 @@ end def id - @id ||= post["modelId"].to_i + @id ||= begin + result = post + fail "Expected #{result.inspect} to have modelId" if ...
Add error messages to post response
diff --git a/lib/trash.rb b/lib/trash.rb index abc1234..def5678 100644 --- a/lib/trash.rb +++ b/lib/trash.rb @@ -20,7 +20,8 @@ module ClassMethodsMixin def deleted - unscoped.where("#{self.table_name}.deleted_at IS NOT NULL") + deleted_at = Arel::Table.new(self.table_name)[:deleted_at] + ...
Use ARel to generate the SQL