diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/apipie/params/dsl.rb b/lib/apipie/params/dsl.rb index abc1234..def5678 100644 --- a/lib/apipie/params/dsl.rb +++ b/lib/apipie/params/dsl.rb @@ -14,7 +14,7 @@ # Example: # param :greeting, String, :desc => "arbitrary text", :required => true # - def param(param_name, descripto...
Make the validator argument for param optional
diff --git a/lib/tentd/models/entity.rb b/lib/tentd/models/entity.rb index abc1234..def5678 100644 --- a/lib/tentd/models/entity.rb +++ b/lib/tentd/models/entity.rb @@ -5,6 +5,8 @@ def self.first_or_create(entity_uri) first(:entity => entity_uri) || create(:entity => entity_uri) + rescue Sequel::U...
Fix race condition for Entity.first_or_create
diff --git a/app/controllers/carto/api/received_notifications_controller.rb b/app/controllers/carto/api/received_notifications_controller.rb index abc1234..def5678 100644 --- a/app/controllers/carto/api/received_notifications_controller.rb +++ b/app/controllers/carto/api/received_notifications_controller.rb @@ -8,7 +8,...
Revert "Avoid loading user model" This reverts commit 0990bf5b67d84cb5559145a80c811442233a5676.
diff --git a/examples/test_ffi_struct.rb b/examples/test_ffi_struct.rb index abc1234..def5678 100644 --- a/examples/test_ffi_struct.rb +++ b/examples/test_ffi_struct.rb @@ -0,0 +1,40 @@+require 'ffi' +require 'forwardable' + +class Foo < FFI::Struct + layout :a, :int, :b, :int +end + +class Bar < Foo + layout :p, Foo...
Add test for inheritance with FFI::Struct (2 options).
diff --git a/spec/nc_spec.rb b/spec/nc_spec.rb index abc1234..def5678 100644 --- a/spec/nc_spec.rb +++ b/spec/nc_spec.rb @@ -1,10 +1,4 @@ require 'nc' - -RSpec.configure do |config| - config.color_enabled = true - config.formatter = 'doc' - config.formatter = 'Nc' -end describe Nc do let(:formatter) { Nc.new...
Remove RSpec configuration from the spec file.
diff --git a/lib/blossom.rb b/lib/blossom.rb index abc1234..def5678 100644 --- a/lib/blossom.rb +++ b/lib/blossom.rb @@ -13,14 +13,12 @@ set :views, root set :index, index - Compass.configuration do |config| - config.project_path = root - config.sass_dir = "" - config.images_d...
Use inline Compass configuration instead of passing block.
diff --git a/lib/database_cleaner/spec/shared_examples.rb b/lib/database_cleaner/spec/shared_examples.rb index abc1234..def5678 100644 --- a/lib/database_cleaner/spec/shared_examples.rb +++ b/lib/database_cleaner/spec/shared_examples.rb @@ -13,3 +13,12 @@ it { is_expected.to respond_to(:clean) } it { is_expected.t...
Add shared example for database_cleaner adapter
diff --git a/haxby.rb b/haxby.rb index abc1234..def5678 100644 --- a/haxby.rb +++ b/haxby.rb @@ -3,7 +3,7 @@ class Haxby < Formula homepage 'https://github.com/tabletcorry/haxby' url "https://github.com/tabletcorry/haxby/tarball/haxby-0.4" - head "git://github.com/tabletcorry/haxby.git" + head "https://...
Switch HEAD url to https, per brew best practices
diff --git a/lib/brewery.rb b/lib/brewery.rb index abc1234..def5678 100644 --- a/lib/brewery.rb +++ b/lib/brewery.rb @@ -2,7 +2,6 @@ require "brewery/auth_core" require "jquery-rails" -require "sass-rails" require "coffee-rails" require "bootstrap-sass"
Remove sass-rails as a dependency
diff --git a/lib/rspec_api_documentation/api_formatter.rb b/lib/rspec_api_documentation/api_formatter.rb index abc1234..def5678 100644 --- a/lib/rspec_api_documentation/api_formatter.rb +++ b/lib/rspec_api_documentation/api_formatter.rb @@ -1,7 +1,7 @@-require 'rspec/core/formatters/base_formatter' +require 'rspec/core...
Change ApiFormatter to subclass BaseTextFormatter
diff --git a/lib/rubycritic/source_control_systems/git.rb b/lib/rubycritic/source_control_systems/git.rb index abc1234..def5678 100644 --- a/lib/rubycritic/source_control_systems/git.rb +++ b/lib/rubycritic/source_control_systems/git.rb @@ -17,7 +17,7 @@ end def head_reference - `git rev-parse --v...
Modify string in place with bang method
diff --git a/lib/money-rails/money.rb b/lib/money-rails/money.rb index abc1234..def5678 100644 --- a/lib/money-rails/money.rb +++ b/lib/money-rails/money.rb @@ -2,8 +2,9 @@ require "active_support/core_ext/hash/reverse_merge.rb" class Money + alias_method :orig_format, :format - def format_with_settings(*rules) ...
Use alias_method instead of alias_method_chain
diff --git a/lib/nehm/path_manager.rb b/lib/nehm/path_manager.rb index abc1234..def5678 100644 --- a/lib/nehm/path_manager.rb +++ b/lib/nehm/path_manager.rb @@ -13,8 +13,19 @@ # Checks path for validation and returns it if valid def self.get_path(path) - # Check path for existence - UI.term 'Invali...
Add creation a directory entered in `to` option
diff --git a/lib/phil_columns/seed.rb b/lib/phil_columns/seed.rb index abc1234..def5678 100644 --- a/lib/phil_columns/seed.rb +++ b/lib/phil_columns/seed.rb @@ -2,11 +2,12 @@ class Seed def self.envs( *envs ) - @_envs = envs.sort.map( &:to_s ) + _envs += envs.sort.map( &:to_s ) + end end ...
Make 'envs' and 'tags' statements callable more than once
diff --git a/lib/optical.rb b/lib/optical.rb index abc1234..def5678 100644 --- a/lib/optical.rb +++ b/lib/optical.rb @@ -35,7 +35,7 @@ end if exits.any?{|e| !e} - on_error.call("A thread failed") + on_error.call("A thread failed near: #{caller_locations(2,1)[0].to_s}") return false end ...
Add a little more debug/loc info on thread failures
diff --git a/lib/promise.rb b/lib/promise.rb index abc1234..def5678 100644 --- a/lib/promise.rb +++ b/lib/promise.rb @@ -58,10 +58,10 @@ end end - def reject(reason = Error, backtrace = nil) + def reject(reason = nil, backtrace = nil) dispatch(backtrace) do @state = :rejected - @reason = rea...
Revert "Set default reason in arglist, previously counted as ControlParameter" This reverts commit cbfe6f20ec693c7e6d1cbf58f750b6639bb42a46.
diff --git a/slack-gamebot/api/presenters/status_presenter.rb b/slack-gamebot/api/presenters/status_presenter.rb index abc1234..def5678 100644 --- a/slack-gamebot/api/presenters/status_presenter.rb +++ b/slack-gamebot/api/presenters/status_presenter.rb @@ -11,14 +11,8 @@ property :games_count property :g...
Remove aggressive GC, a better solution is to split processes.
diff --git a/black_list.rb b/black_list.rb index abc1234..def5678 100644 --- a/black_list.rb +++ b/black_list.rb @@ -12,5 +12,6 @@ ["coq-compcert.3.5", "Error: Corrupted compiled interface"], # flaky Makefile ["coq-metacoq-erasure.1.0~alpha+8.8", "make inconsistent assumptions over interface Quoter"], ["coq-sta...
Add coq-stalmarck.8.12.0 to the black-list
diff --git a/lib/quality/process_runner.rb b/lib/quality/process_runner.rb index abc1234..def5678 100644 --- a/lib/quality/process_runner.rb +++ b/lib/quality/process_runner.rb @@ -4,9 +4,9 @@ # Wrapper around IO.popen that allows exit status to be mocked in tests. class ProcessRunner def initialize(full_cmd,...
Fix compatibility with Ruby 1.9.3
diff --git a/core/app/classes/open_graph/objects/og_fact.rb b/core/app/classes/open_graph/objects/og_fact.rb index abc1234..def5678 100644 --- a/core/app/classes/open_graph/objects/og_fact.rb +++ b/core/app/classes/open_graph/objects/og_fact.rb @@ -1,9 +1,13 @@ module OpenGraph::Objects class OgFact < OpenGraph::Obj...
Use correct Facebook app namespace in meta tag for each environment
diff --git a/lib/specinfra/ec2_metadata.rb b/lib/specinfra/ec2_metadata.rb index abc1234..def5678 100644 --- a/lib/specinfra/ec2_metadata.rb +++ b/lib/specinfra/ec2_metadata.rb @@ -3,20 +3,73 @@ class Ec2Metadata def initialize @base_uri = 'http://169.254.169.254/latest/meta-data/' + @metadata = {} ...
Fix to extend Ec2Metadata easily by external gem
diff --git a/spec/requests/tool_integration/annuities_spec.rb b/spec/requests/tool_integration/annuities_spec.rb index abc1234..def5678 100644 --- a/spec/requests/tool_integration/annuities_spec.rb +++ b/spec/requests/tool_integration/annuities_spec.rb @@ -3,12 +3,8 @@ context 'when the feature flag is enabled' do ...
Change the matcher verification for annuites spec * The spec was renamed to requests so the route to does not exist here. Changing the matcher will fix the spec. * This only spec can be runned with anuites feature flag turn on
diff --git a/lib/grape_devise_token_auth/token_authorizer.rb b/lib/grape_devise_token_auth/token_authorizer.rb index abc1234..def5678 100644 --- a/lib/grape_devise_token_auth/token_authorizer.rb +++ b/lib/grape_devise_token_auth/token_authorizer.rb @@ -11,8 +11,12 @@ @resource_class = devise_interface.mapping_to...
Add check for client id on warden user A user signed into warden (through devise for example), GTDA wasn't checking to see if that user already has a client_id. This commmit changes it so that it does.
diff --git a/lib/facter/virtualenv_version.rb b/lib/facter/virtualenv_version.rb index abc1234..def5678 100644 --- a/lib/facter/virtualenv_version.rb +++ b/lib/facter/virtualenv_version.rb @@ -6,7 +6,7 @@ has_weight 100 setcode do begin - Facter::Util::Resolution.exec('virtualenv --version') + Facte...
Return 'absent' instead of nil
diff --git a/lib/rom/support/class_builder.rb b/lib/rom/support/class_builder.rb index abc1234..def5678 100644 --- a/lib/rom/support/class_builder.rb +++ b/lib/rom/support/class_builder.rb @@ -1,10 +1,24 @@ module ROM + # Internal support class for generating classes + # + # @private class ClassBuilder inclu...
Add YARD docs to ClassBuilder support class
diff --git a/spec/volunteermatch/api/hello_world_spec.rb b/spec/volunteermatch/api/hello_world_spec.rb index abc1234..def5678 100644 --- a/spec/volunteermatch/api/hello_world_spec.rb +++ b/spec/volunteermatch/api/hello_world_spec.rb @@ -4,6 +4,11 @@ subject { Volunteermatch::Client.new('VolunteerMatch','test_key') } ...
Add additional test to helloWorld api call
diff --git a/ab.gemspec b/ab.gemspec index abc1234..def5678 100644 --- a/ab.gemspec +++ b/ab.gemspec @@ -23,4 +23,5 @@ spec.add_development_dependency 'bundler', '~> 1.3' spec.add_development_dependency 'rake', '~> 10.1', '>= 10.1.0' spec.add_development_dependency 'rspec', '~> 2.14', '>= 2.14.0' + spec.add_de...
Add json-schema as development dependency
diff --git a/spec/adapter_spec.rb b/spec/adapter_spec.rb index abc1234..def5678 100644 --- a/spec/adapter_spec.rb +++ b/spec/adapter_spec.rb @@ -38,7 +38,7 @@ end it 'should not have duplicate ids' do - file = @adapter.send(:yaml_file, Example) + file = adapter.send(:yaml_file, Example) resu...
Fix specs to use method defined by let() rather than an ivar
diff --git a/test/everypolitician_index_test.rb b/test/everypolitician_index_test.rb index abc1234..def5678 100644 --- a/test/everypolitician_index_test.rb +++ b/test/everypolitician_index_test.rb @@ -4,10 +4,8 @@ def test_country VCR.use_cassette('countries_json') do index = Everypolitician::Index.new - ...
Make it clear we're expecting different data for different SHAs This makes the tests in everypolitician_index_test.rb similar to each other, so it's clearer that we're testing for the same thing against different version of the data.
diff --git a/tests/serverspec/spec/spec_init.rb b/tests/serverspec/spec/spec_init.rb index abc1234..def5678 100644 --- a/tests/serverspec/spec/spec_init.rb +++ b/tests/serverspec/spec/spec_init.rb @@ -10,6 +10,12 @@ print "------------------------\n" print " DOCKERIMAGE_ID: " + ENV['DOCKERIMAGE_ID'] + "\n" print " DO...
Print internal configuration hash in serverspec
diff --git a/db/migrate/20160524170457_create_sub_splits.rb b/db/migrate/20160524170457_create_sub_splits.rb index abc1234..def5678 100644 --- a/db/migrate/20160524170457_create_sub_splits.rb +++ b/db/migrate/20160524170457_create_sub_splits.rb @@ -9,10 +9,6 @@ add_index :sub_splits, :bitkey, unique: true add_...
Remove SubSplit object creation from create_sub_splits migration (allows heroku to migrate up despite code having been updated to remove SubSplit as an ActiveRecord model).
diff --git a/plugins/providers/hyperv/action/delete_vm.rb b/plugins/providers/hyperv/action/delete_vm.rb index abc1234..def5678 100644 --- a/plugins/providers/hyperv/action/delete_vm.rb +++ b/plugins/providers/hyperv/action/delete_vm.rb @@ -9,6 +9,14 @@ def call(env) env[:ui].info("Deleting the machi...
Delete and re-create data directory when destroying guest
diff --git a/services/importer/lib/importer/result.rb b/services/importer/lib/importer/result.rb index abc1234..def5678 100644 --- a/services/importer/lib/importer/result.rb +++ b/services/importer/lib/importer/result.rb @@ -33,6 +33,16 @@ def update_support_tables(new_list) @support_tables = new_list ...
Remove log_trace from Result inspection Fixes #9615
diff --git a/spec/libs/bearer_token/bearer_token_spec.rb b/spec/libs/bearer_token/bearer_token_spec.rb index abc1234..def5678 100644 --- a/spec/libs/bearer_token/bearer_token_spec.rb +++ b/spec/libs/bearer_token/bearer_token_spec.rb @@ -0,0 +1,72 @@+require 'spec_helper' +require 'delorean' +def addToken(user, client, ...
Verify bearer token devise strategy accounts for token expiration [#111242640] https://www.pivotaltracker.com/story/show/111242640
diff --git a/spec/policies/task_templates_policy_spec.rb b/spec/policies/task_templates_policy_spec.rb index abc1234..def5678 100644 --- a/spec/policies/task_templates_policy_spec.rb +++ b/spec/policies/task_templates_policy_spec.rb @@ -4,7 +4,7 @@ let(:journal) { FactoryGirl.create(:journal) } let(:manuscript_man...
Build task_template instead of create
diff --git a/objective-c/auth_sample/AuthTestService.podspec b/objective-c/auth_sample/AuthTestService.podspec index abc1234..def5678 100644 --- a/objective-c/auth_sample/AuthTestService.podspec +++ b/objective-c/auth_sample/AuthTestService.podspec @@ -0,0 +1,35 @@+Pod::Spec.new do |s| + s.name = "AuthTestService"...
Add podspec for auth proto library
diff --git a/spec/classes/hitch_spec.rb b/spec/classes/hitch_spec.rb index abc1234..def5678 100644 --- a/spec/classes/hitch_spec.rb +++ b/spec/classes/hitch_spec.rb @@ -5,7 +5,24 @@ context "on #{os}" do let(:facts) { os_facts } - it { is_expected.to compile } + context 'defaults' do + it ...
Add test for missing dhparams content This should fail until #6 is fixed.
diff --git a/spec/lib/resources_spec.rb b/spec/lib/resources_spec.rb index abc1234..def5678 100644 --- a/spec/lib/resources_spec.rb +++ b/spec/lib/resources_spec.rb @@ -3,7 +3,7 @@ describe Cathode::Resource do describe '.new' do context 'with a nonexistent resource' do - subject { Class.new(Cathode::Base)...
Test against the actual resource instantiation method
diff --git a/spec/rules_checker_spec.rb b/spec/rules_checker_spec.rb index abc1234..def5678 100644 --- a/spec/rules_checker_spec.rb +++ b/spec/rules_checker_spec.rb @@ -10,21 +10,21 @@ fourth_rule: { proper_controllers_amount: 2, total_controllers_amount: 2 } } end - + let(:succeed_conditions) do ...
Test case for RulesChecker with 0 controllers
diff --git a/spec/abstract_class_spec.rb b/spec/abstract_class_spec.rb index abc1234..def5678 100644 --- a/spec/abstract_class_spec.rb +++ b/spec/abstract_class_spec.rb @@ -1,4 +1,4 @@-require_relative '../lib/abstract_class' +require File.expand_path('../../lib/abstract_class', __FILE__) RSpec.describe AbstractClas...
Use require with expand_path instead of require_relative
diff --git a/spec/models/payload_spec.rb b/spec/models/payload_spec.rb index abc1234..def5678 100644 --- a/spec/models/payload_spec.rb +++ b/spec/models/payload_spec.rb @@ -6,11 +6,25 @@ describe 'attributes' do it { expect(@payload).to respond_to :header } it { expect(@payload).to respond_to :data } + it...
Add new tests for Payload attributes
diff --git a/spec/raptor/version_spec.rb b/spec/raptor/version_spec.rb index abc1234..def5678 100644 --- a/spec/raptor/version_spec.rb +++ b/spec/raptor/version_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Raptor::VERSION do +describe "Raptor::VERSION" do it 'holds the version number of the library' do ...
Use a string to avoid expansion
diff --git a/spec/support/auth_helper.rb b/spec/support/auth_helper.rb index abc1234..def5678 100644 --- a/spec/support/auth_helper.rb +++ b/spec/support/auth_helper.rb @@ -1,13 +1,8 @@ module AuthHelper def visit_protected(path) - password = gen_secure_pass - user = create(:user, password: password) + user...
Refactor visit_protected* methods in AuthHelper
diff --git a/app/controllers/spree/checkout_controller_decorator.rb b/app/controllers/spree/checkout_controller_decorator.rb index abc1234..def5678 100644 --- a/app/controllers/spree/checkout_controller_decorator.rb +++ b/app/controllers/spree/checkout_controller_decorator.rb @@ -2,13 +2,13 @@ Spree::PermittedAttri...
Update checkout decorator for Spree 2.4 The checkout controller has changed between spree 2.2 -> 2.4, in that the address parameters now appear to be part of the order details rather than having to persist it separately. The commit that changed it in spree is: https://github.com/spree/spree/commit/7c16987c822b1ca97e2...
diff --git a/spree_bank_transfer.gemspec b/spree_bank_transfer.gemspec index abc1234..def5678 100644 --- a/spree_bank_transfer.gemspec +++ b/spree_bank_transfer.gemspec @@ -1,7 +1,7 @@ # encoding: UTF-8 Gem::Specification.new do |s| s.platform = Gem::Platform::RUBY - s.name = 'spree_bank_transfer' + s.n...
Update gem name in gemspec
diff --git a/schema_to_scaffold.gemspec b/schema_to_scaffold.gemspec index abc1234..def5678 100644 --- a/schema_to_scaffold.gemspec +++ b/schema_to_scaffold.gemspec @@ -9,7 +9,7 @@ gem.authors = ["Humberto Pinto", "João Soares"] gem.email = ["h.lsp999@gmail.com", "jsoaresgeral@gmail.com"] gem.desc...
Remove OS references in description Since this is now a gem it should work for all platforms with ruby and rubygems-bundler installed Signed-off-by: João Soares <aa8bbb841c16da95f4aa0fde9f93d16ce9f21700@gmail.com>
diff --git a/app/controllers/import/gitorious_controller.rb b/app/controllers/import/gitorious_controller.rb index abc1234..def5678 100644 --- a/app/controllers/import/gitorious_controller.rb +++ b/app/controllers/import/gitorious_controller.rb @@ -15,7 +15,7 @@ @already_added_projects = current_user.created_projec...
Fix Gitorious import status page hiding of already added projects.
diff --git a/app/models/france_connect_entreprise_client.rb b/app/models/france_connect_entreprise_client.rb index abc1234..def5678 100644 --- a/app/models/france_connect_entreprise_client.rb +++ b/app/models/france_connect_entreprise_client.rb @@ -2,8 +2,8 @@ def initialize params={} super( - identifie...
Change identifier and secret name for FranceConnect::Entreprise connection
diff --git a/black_list.rb b/black_list.rb index abc1234..def5678 100644 --- a/black_list.rb +++ b/black_list.rb @@ -8,5 +8,6 @@ ["coq-compcert.3.3.0", "Error: Corrupted compiled interface"], # flaky Makefile ["coq-compcert.3.6", "Error: Corrupted compiled interface"], # flaky Makefile ["coq-metacoq-erasure.1.0...
Add VST to the black-list for the CompCert dependency
diff --git a/app/controllers/api/users_controller.rb b/app/controllers/api/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/users_controller.rb +++ b/app/controllers/api/users_controller.rb @@ -21,6 +21,7 @@ params.require(:user).permit(:firstname, :lastname, :program, :start_year, ...
Fix bug where notification setting could not be updated via the API
diff --git a/app/controllers/documents_controller.rb b/app/controllers/documents_controller.rb index abc1234..def5678 100644 --- a/app/controllers/documents_controller.rb +++ b/app/controllers/documents_controller.rb @@ -13,11 +13,11 @@ end def show - send_file @document.document.path, type: @document.documen...
Fix broken download links on heroku The path call works with filesystems, but not where S3 buckets are concerned. This is a quick-fix for that for now.
diff --git a/app/controllers/languages_controller.rb b/app/controllers/languages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/languages_controller.rb +++ b/app/controllers/languages_controller.rb @@ -6,11 +6,11 @@ def show find_language - @created = Project.language(@language).few_versi...
Disable the language pages for a minute
diff --git a/app/controllers/effective/pages_controller.rb b/app/controllers/effective/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/effective/pages_controller.rb +++ b/app/controllers/effective/pages_controller.rb @@ -5,7 +5,9 @@ @pages = @pages.published if params[:edit].to_s != 'true'...
Raise the proper 404 even if find() has been overridden not to.
diff --git a/lib/dbcode.rb b/lib/dbcode.rb index abc1234..def5678 100644 --- a/lib/dbcode.rb +++ b/lib/dbcode.rb @@ -3,10 +3,11 @@ autoload :Schema, 'dbcode/schema' autoload :Graph, 'dbcode/graph' extend self - attr_accessor :sql_file_path + attr_accessor :sql_file_path, :code_schema_name + self.code_schema_...
Allow configuration of code schema name
diff --git a/acceptance/fips/test/integration/fips-integration/serverspec/fips-integration_spec.rb b/acceptance/fips/test/integration/fips-integration/serverspec/fips-integration_spec.rb index abc1234..def5678 100644 --- a/acceptance/fips/test/integration/fips-integration/serverspec/fips-integration_spec.rb +++ b/accep...
Disable FIPS integration tests for now.
diff --git a/lib/quotes.rb b/lib/quotes.rb index abc1234..def5678 100644 --- a/lib/quotes.rb +++ b/lib/quotes.rb @@ -1,12 +1,12 @@ require 'quotes/version' -require './lib/quotes/helpers/validation_helpers' +require 'quotes/support/validation_helpers' -require './lib/quotes/entities' -require './lib/quotes/services...
Change how files are required in manifest file
diff --git a/lib/banzai/reference_parser/project_parser.rb b/lib/banzai/reference_parser/project_parser.rb index abc1234..def5678 100644 --- a/lib/banzai/reference_parser/project_parser.rb +++ b/lib/banzai/reference_parser/project_parser.rb @@ -13,16 +13,15 @@ # Returns an Array of Project ids that can be read ...
Use a hash to memoize readable_project_ids with user objects as keys
diff --git a/core/db/migrate/20150121022521_remove_environment_from_payment_method.rb b/core/db/migrate/20150121022521_remove_environment_from_payment_method.rb index abc1234..def5678 100644 --- a/core/db/migrate/20150121022521_remove_environment_from_payment_method.rb +++ b/core/db/migrate/20150121022521_remove_enviro...
Remove the environment column from payment_method Sets any payment method not in the current environment to be inactive. Can't be reversed as we have set the active = false (cherry picked from commit 42cf3f0155b218d506afc3a8e653db73b6a442fa in freerunningtech/spree)
diff --git a/config/initializers/00_deprecate_prototype.rb b/config/initializers/00_deprecate_prototype.rb index abc1234..def5678 100644 --- a/config/initializers/00_deprecate_prototype.rb +++ b/config/initializers/00_deprecate_prototype.rb @@ -0,0 +1,33 @@+# Mostly copied from: +# https://github.com/rails/rails/blob/3...
Add initializer to deprecate prototype
diff --git a/cookbooks/get-repositories/recipes/default.rb b/cookbooks/get-repositories/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/get-repositories/recipes/default.rb +++ b/cookbooks/get-repositories/recipes/default.rb @@ -46,6 +46,6 @@ end execute "#{destination} -> git clone #{url}" d...
Change to su from sudo
diff --git a/core/app/controllers/spree/base_controller.rb b/core/app/controllers/spree/base_controller.rb index abc1234..def5678 100644 --- a/core/app/controllers/spree/base_controller.rb +++ b/core/app/controllers/spree/base_controller.rb @@ -1,4 +1,4 @@ class Spree::BaseController < ApplicationController - include ...
Fix require to Spree::Core::ControllerHelpers in BaseController
diff --git a/lib/facebooker/rails/facebook_request_fix.rb b/lib/facebooker/rails/facebook_request_fix.rb index abc1234..def5678 100644 --- a/lib/facebooker/rails/facebook_request_fix.rb +++ b/lib/facebooker/rails/facebook_request_fix.rb @@ -7,7 +7,7 @@ request_method_without_facebooker end - if meth...
Fix for rails 1.2 exclusion git-svn-id: abd3364c23bece18756deaf5558fcfa62d3b1b71@118 06148572-b36b-44fe-9aa8-f68b04d8b080
diff --git a/lib/generators/templates/create_addresses.rb b/lib/generators/templates/create_addresses.rb index abc1234..def5678 100644 --- a/lib/generators/templates/create_addresses.rb +++ b/lib/generators/templates/create_addresses.rb @@ -7,16 +7,10 @@ t.string :buildingable_type t.string :postal_code ...
Remove translate from main table
diff --git a/lib/vagrant/action/builtin/write_box_info.rb b/lib/vagrant/action/builtin/write_box_info.rb index abc1234..def5678 100644 --- a/lib/vagrant/action/builtin/write_box_info.rb +++ b/lib/vagrant/action/builtin/write_box_info.rb @@ -11,10 +11,13 @@ end def call(env) - box_url = env...
core: Write box information after download
diff --git a/templates/mongoid/features/support/hooks.rb b/templates/mongoid/features/support/hooks.rb index abc1234..def5678 100644 --- a/templates/mongoid/features/support/hooks.rb +++ b/templates/mongoid/features/support/hooks.rb @@ -1,3 +1,3 @@ Before do |scenario| - Mongoid.master.collections.reject { |c| c.name ...
Update mongoid collection drop statement to match rspec version
diff --git a/rspec-puppet-facts.gemspec b/rspec-puppet-facts.gemspec index abc1234..def5678 100644 --- a/rspec-puppet-facts.gemspec +++ b/rspec-puppet-facts.gemspec @@ -24,4 +24,5 @@ s.add_runtime_dependency 'json' s.add_runtime_dependency 'facter' s.add_runtime_dependency 'facterdb', '>= 0.3.0' + s.add_runtim...
Add mcollective-client as runtime dependency
diff --git a/anchored.gemspec b/anchored.gemspec index abc1234..def5678 100644 --- a/anchored.gemspec +++ b/anchored.gemspec @@ -15,6 +15,8 @@ spec.files = Dir["LICENSE.txt", "README.md", "lib/**/*"] spec.require_paths = ["lib"] + spec.required_ruby_version = ">= 2.3.0" + spec.add_development_depende...
Add required ruby version to gemspec (2.3+)
diff --git a/dayrb.gemspec b/dayrb.gemspec index abc1234..def5678 100644 --- a/dayrb.gemspec +++ b/dayrb.gemspec @@ -1,7 +1,6 @@ Gem::Specification.new do |s| s.name = 'dayrb' s.version = '2.0.2' - s.date = '08-17-2014' s.summary = "To-do & Time-Tracking CLI App" s.description = "Crea...
Remove date field from gemspec
diff --git a/lib/active_job/retriable.rb b/lib/active_job/retriable.rb index abc1234..def5678 100644 --- a/lib/active_job/retriable.rb +++ b/lib/active_job/retriable.rb @@ -12,10 +12,10 @@ rescue_from Exception do |ex| tag_logger self.class.name, job_id do if retries_exhausted? - lo...
Add a more detailed retry log messages
diff --git a/lib/bedi/parsing_helpers.rb b/lib/bedi/parsing_helpers.rb index abc1234..def5678 100644 --- a/lib/bedi/parsing_helpers.rb +++ b/lib/bedi/parsing_helpers.rb @@ -13,7 +13,7 @@ def remove_artifacts(match) match.captures.each_with_object({}) do |(key, val), result| next if (Numeric === key)...
Convert match values to string
diff --git a/lib/booking_requests/api.rb b/lib/booking_requests/api.rb index abc1234..def5678 100644 --- a/lib/booking_requests/api.rb +++ b/lib/booking_requests/api.rb @@ -9,10 +9,30 @@ private def connection - HTTPConnectionFactory.build(api_uri).tap do |c| + HTTPConnectionFactory.build(api_uri, ...
Configure HTTP connections for bookings API Bumps the default timeout to 10 seconds for both connect and read. Also, since the endpoint is not considered idempotent I have disabled retries.
diff --git a/design/api.rb b/design/api.rb index abc1234..def5678 100644 --- a/design/api.rb +++ b/design/api.rb @@ -1,19 +1,19 @@ Praxis::ApiDefinition.define do |api| - + # Applies to all API versions - api.info do + api.info do name "bloggy" title "A Blog API example application" description "...
Add XML consumes and produces (more as an example than anything else since we’re not using/requesting XML docs) Signed-off-by: Josep M. Blanquer <843d9a062ab1c6792ebebca5589f22ce86ac85ce@rightscale.com>
diff --git a/svg_tag.gemspec b/svg_tag.gemspec index abc1234..def5678 100644 --- a/svg_tag.gemspec +++ b/svg_tag.gemspec @@ -19,7 +19,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_dependency "actionview" + spec.add_runtime_dependency "rails", '~> ...
Fix gemspec for older Rails (should test for newer Rails).
diff --git a/lib/google/places/client.rb b/lib/google/places/client.rb index abc1234..def5678 100644 --- a/lib/google/places/client.rb +++ b/lib/google/places/client.rb @@ -30,6 +30,14 @@ ) end + def place_photos(photo_reference, options = {}) + options = options.with_indifferent_access + ...
Add Place Photos API support
diff --git a/lib/bricks.rb b/lib/bricks.rb index abc1234..def5678 100644 --- a/lib/bricks.rb +++ b/lib/bricks.rb @@ -3,7 +3,11 @@ module Bricks class << self - attr_accessor :builders + attr_writer :builders + + def builders + @builders ||= BuilderHashSet.new + end end class BuilderHashSet...
Initialize global `builders' var if it's nil.
diff --git a/config/environments/test.rb b/config/environments/test.rb index abc1234..def5678 100644 --- a/config/environments/test.rb +++ b/config/environments/test.rb @@ -9,8 +9,4 @@ config.action_controller.allow_forgery_protection = false config.action_mailer.delivery_method = :test config.active_support.de...
Remove stray 'Mail' reference which was erroring
diff --git a/test/controllers/static_pages_controller_test.rb b/test/controllers/static_pages_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/static_pages_controller_test.rb +++ b/test/controllers/static_pages_controller_test.rb @@ -1,4 +1,20 @@ require 'test_helper' class StaticPagesControll...
Add basic tests for the static pages controller The get tests that have been added are for the sake of completeness.
diff --git a/test/unit/models/link_checker_api_report_test.rb b/test/unit/models/link_checker_api_report_test.rb index abc1234..def5678 100644 --- a/test/unit/models/link_checker_api_report_test.rb +++ b/test/unit/models/link_checker_api_report_test.rb @@ -0,0 +1,30 @@+require "test_helper" +require "gds_api/test_helpe...
Add a test for replacing link checker api reports
diff --git a/lib/joiner.rb b/lib/joiner.rb index abc1234..def5678 100644 --- a/lib/joiner.rb +++ b/lib/joiner.rb @@ -1,4 +1,5 @@ require 'set' +require 'active_record' module Joiner class AssociationNotFound < StandardError
Make sure ActiveRecord is loaded.
diff --git a/app/controllers/admin/user_needs_controller.rb b/app/controllers/admin/user_needs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/user_needs_controller.rb +++ b/app/controllers/admin/user_needs_controller.rb @@ -1,6 +1,6 @@ class Admin::UserNeedsController < Admin::BaseController ...
Add strong params for user needs
diff --git a/app/controllers/concerns/admin/acts_as_list.rb b/app/controllers/concerns/admin/acts_as_list.rb index abc1234..def5678 100644 --- a/app/controllers/concerns/admin/acts_as_list.rb +++ b/app/controllers/concerns/admin/acts_as_list.rb @@ -8,8 +8,8 @@ extend ActiveSupport::Concern included do - ...
Fix ActsAsList concern so it doesn't prevent before_filters from running on other actions when included
diff --git a/app/factories/shopify/product_image_factory.rb b/app/factories/shopify/product_image_factory.rb index abc1234..def5678 100644 --- a/app/factories/shopify/product_image_factory.rb +++ b/app/factories/shopify/product_image_factory.rb @@ -20,9 +20,9 @@ # else if it's hosted online we must get the `url` ...
Use open instead of File.open That way we can open the online URLs instead of just local files.
diff --git a/paperclip-storage-ftp.gemspec b/paperclip-storage-ftp.gemspec index abc1234..def5678 100644 --- a/paperclip-storage-ftp.gemspec +++ b/paperclip-storage-ftp.gemspec @@ -7,7 +7,7 @@ gem.homepage = "https://github.com/xing/paperclip-storage-ftp" gem.executables = `git ls-files -- bin/*`.split("\...
Put vendor directory back in gem, to allow all tests to run
diff --git a/ci_environment/phantomjs/recipes/2.0.rb b/ci_environment/phantomjs/recipes/2.0.rb index abc1234..def5678 100644 --- a/ci_environment/phantomjs/recipes/2.0.rb +++ b/ci_environment/phantomjs/recipes/2.0.rb @@ -1,8 +1,18 @@ # Install PhantomJS 2.0.0 from custom-built archive package 'libjpeg-dev' -package ...
Adjust dependency packages for phantomjs on trusty & precise
diff --git a/lib/haml/template/plugin.rb b/lib/haml/template/plugin.rb index abc1234..def5678 100644 --- a/lib/haml/template/plugin.rb +++ b/lib/haml/template/plugin.rb @@ -1,3 +1,4 @@+# :stopdoc: # This file makes Haml work with Rails # using the > 2.0.1 template handler API. @@ -19,3 +20,4 @@ end ActionView::B...
Make sure that the proper Haml module docs show up in the RDoc. git-svn-id: 4f3887ee22fa92c7515d4a1b1e550bc0e860970c@723 7063305b-7217-0410-af8c-cdc13e5119b9
diff --git a/lib/nessus/client/policy.rb b/lib/nessus/client/policy.rb index abc1234..def5678 100644 --- a/lib/nessus/client/policy.rb +++ b/lib/nessus/client/policy.rb @@ -21,11 +21,15 @@ # @return [String] looks up policy ID by policy name def policy_id_by_name(name) policy_list.find{|policy| po...
Add rescue to return nil
diff --git a/lib/sections/header_data.rb b/lib/sections/header_data.rb index abc1234..def5678 100644 --- a/lib/sections/header_data.rb +++ b/lib/sections/header_data.rb @@ -18,6 +18,13 @@ new_header[5] = team.warning new_header[6] = team.patreon > 0 ? "patreon" : "no patreon" + # Add raid bosses to ...
Add raid bosses to header in new implementation
diff --git a/lib/tasks/data_hygiene.rake b/lib/tasks/data_hygiene.rake index abc1234..def5678 100644 --- a/lib/tasks/data_hygiene.rake +++ b/lib/tasks/data_hygiene.rake @@ -1,4 +1,5 @@ namespace :data_hygiene do + desc "Verify that artefacts have the correct `owning_app`" task :verify_formats => [:environment] do ...
Add rake task to list artefacts without content_id In the future all artefacts should have a content_id. This rake task lists artefacts per app and displays how many of them do/don't have a content_id.
diff --git a/lib/tasks/email_topics.rake b/lib/tasks/email_topics.rake index abc1234..def5678 100644 --- a/lib/tasks/email_topics.rake +++ b/lib/tasks/email_topics.rake @@ -7,9 +7,17 @@ desc "check the email topics for all documents" task check_all_documents: :environment do - Document.published.find_in_batch...
Make check_all_documents more robust and continue from offset The script errored during the EmailTopicChecker initializer. This handles errors in this case. we’ve also added the ability to continue from an offset so we don’t need to run the script from the beginning.
diff --git a/app/controllers/admin/feedback_controller.rb b/app/controllers/admin/feedback_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/feedback_controller.rb +++ b/app/controllers/admin/feedback_controller.rb @@ -1,6 +1,6 @@ class Admin::FeedbackController < Admin::ApplicationController ...
Fix N+1 query issue wrt feedback index page for admins
diff --git a/spec/configuration_spec.rb b/spec/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/configuration_spec.rb +++ b/spec/configuration_spec.rb @@ -8,7 +8,7 @@ it { should eq Specinfra.configuration.path } end -SpecInfra.configuration.os = 'foo' -describe SpecInfra.configuration.os do +Specinf...
Change SpecInfra to Specinfa after merging master
diff --git a/lib/generators/forest/block/templates/model.rb b/lib/generators/forest/block/templates/model.rb index abc1234..def5678 100644 --- a/lib/generators/forest/block/templates/model.rb +++ b/lib/generators/forest/block/templates/model.rb @@ -18,27 +18,27 @@ <% if class_name.match(/image/i) -%> def self.disp...
Update block template with bootstrap 4 icon names
diff --git a/lib/project_tango_foxtrot/proof_of_concept1.rb b/lib/project_tango_foxtrot/proof_of_concept1.rb index abc1234..def5678 100644 --- a/lib/project_tango_foxtrot/proof_of_concept1.rb +++ b/lib/project_tango_foxtrot/proof_of_concept1.rb @@ -1,3 +1,9 @@+# Proof of Concept: guaranteed time-to-render +# ------ +# ...
Add explanation to first PoC
diff --git a/jquery_mobile_rails.gemspec b/jquery_mobile_rails.gemspec index abc1234..def5678 100644 --- a/jquery_mobile_rails.gemspec +++ b/jquery_mobile_rails.gemspec @@ -7,11 +7,12 @@ Gem::Specification.new do |s| s.name = "jquery_mobile_rails" s.version = JqueryMobileRails::VERSION - s.authors ...
Update gemspec authors and license. Closes #24.
diff --git a/lib/stagehand/connection_adapter_extensions.rb b/lib/stagehand/connection_adapter_extensions.rb index abc1234..def5678 100644 --- a/lib/stagehand/connection_adapter_extensions.rb +++ b/lib/stagehand/connection_adapter_extensions.rb @@ -1,15 +1,22 @@ module Stagehand module Connection def self.with_...
Make unsynced production write blocks more robust When we create a block that allows unsynced production writes, we expect that any connection opened within that block would be allowed to write to the production database. Unfortunately, only the current `ActiveRecord::Base.connection` instance is marked as being read/...
diff --git a/yomou.gemspec b/yomou.gemspec index abc1234..def5678 100644 --- a/yomou.gemspec +++ b/yomou.gemspec @@ -19,6 +19,8 @@ spec.require_paths = ["lib"] spec.add_runtime_dependency "thor", "~> 0.19" + spec.add_runtime_dependency "grn_mini", "~> 0.5" + spec.add_runtime_dependency "rroonga", "~> 4.0.4" ...
Add runtime dependency to Rroonga
diff --git a/api/lib/tasks/heroku_scheduler.rake b/api/lib/tasks/heroku_scheduler.rake index abc1234..def5678 100644 --- a/api/lib/tasks/heroku_scheduler.rake +++ b/api/lib/tasks/heroku_scheduler.rake @@ -38,4 +38,14 @@ task queue_collect_projects_shipped_job: :environment do CollectProjectsShippedJob.perform_la...
Add rake tasks for closing and scheduling check-ins Fix #172
diff --git a/app/controllers/items_controller.rb b/app/controllers/items_controller.rb index abc1234..def5678 100644 --- a/app/controllers/items_controller.rb +++ b/app/controllers/items_controller.rb @@ -19,7 +19,7 @@ def show today = Time.zone.today @item = Item.find(params[:id]) - redirect_to root_path if to...
Fix conditions to properly redirect to the top page.
diff --git a/app/controllers/likes_controller.rb b/app/controllers/likes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/likes_controller.rb +++ b/app/controllers/likes_controller.rb @@ -3,12 +3,37 @@ before_action :find_likeable def create + current_user.like(@item) + render text: @ite...
Add the find_likable before_action to find something able to the liked based on the params.
diff --git a/app/classes/meme_captain_web/gend_image_script.rb b/app/classes/meme_captain_web/gend_image_script.rb index abc1234..def5678 100644 --- a/app/classes/meme_captain_web/gend_image_script.rb +++ b/app/classes/meme_captain_web/gend_image_script.rb @@ -32,23 +32,7 @@ private def json - JSON.pret...
Remove redundant gend image api request json generation