html_url
stringlengths
51
51
comments
stringlengths
67
24.7k
title
stringlengths
6
280
body
stringlengths
51
36.2k
comment_length
int64
16
1.45k
text
stringlengths
190
38.3k
embeddings
list
https://github.com/huggingface/datasets/issues/5137
- Some people do not agree about current "hierarchy": - symbolic-regression: [yoshitomo-matsubara/srsd-feynman_hard](https://huggingface.co/datasets/yoshitomo-matsubara/srsd-feynman_hard/discussions/2#63614194c12a09b8a31457cc), [yoshitomo-matsubara/srsd-feynman_medium](https://huggingface.co/datasets/yoshitomo-matsu...
Align task tags in dataset metadata
## Describe Once we have agreed on a common naming for task tags for all open source projects, we should align on them. ## Steps - [x] Align task tags in canonical datasets - [x] task_categories: 4 datasets - [x] task_ids (by @lhoestq) - [x] Open PRs in community datasets - [x] task_categories: 451 datas...
21
Align task tags in dataset metadata ## Describe Once we have agreed on a common naming for task tags for all open source projects, we should align on them. ## Steps - [x] Align task tags in canonical datasets - [x] task_categories: 4 datasets - [x] task_ids (by @lhoestq) - [x] Open PRs in community datase...
[ -0.4428844451904297, -0.005620554089546204, -0.1913151741027832, 0.03644547984004021, 0.07210001349449158, -0.19481387734413147, 0.325492799282074, 0.21850556135177612, 0.11320289969444275, 0.2021964192390442, -0.002584785223007202, 0.3101687431335449, -0.024333855137228966, 0.460830688476...
https://github.com/huggingface/datasets/issues/5137
@albertvillanova Thank you for sharing our voice here! Yes, we want `symbolic-regression` to be listed as a task. This task has been attracting attention from the machine learning/deep learning community, and unfortunately existing symbolic regression datasets are de-centralized in the community (hosted at individ...
Align task tags in dataset metadata
## Describe Once we have agreed on a common naming for task tags for all open source projects, we should align on them. ## Steps - [x] Align task tags in canonical datasets - [x] task_categories: 4 datasets - [x] task_ids (by @lhoestq) - [x] Open PRs in community datasets - [x] task_categories: 451 datas...
64
Align task tags in dataset metadata ## Describe Once we have agreed on a common naming for task tags for all open source projects, we should align on them. ## Steps - [x] Align task tags in canonical datasets - [x] task_categories: 4 datasets - [x] task_ids (by @lhoestq) - [x] Open PRs in community datase...
[ -0.2714502811431885, -0.0036717504262924194, -0.18218612670898438, -0.14358827471733093, 0.11106596142053604, -0.01041208952665329, 0.3569684326648712, 0.09038521349430084, 0.20404142141342163, 0.06712507456541061, 0.06111719459295273, 0.36005088686943054, -0.1698015183210373, 0.5808397531...
https://github.com/huggingface/datasets/issues/5134
hey @mariosasko , i made a pr for this issue. Could you please review it. Also i found multiple `OSError` in `extract.py` file which i thought could be replaced too but wasn't sure about them. Please do tell if that also needs to be done.
Raise ImportError instead of OSError if required extraction library is not installed
According to the official Python docs, `OSError` should be thrown in the following situations: > This exception is raised when a system function returns a system-related error, including I/O failures such as “file not found” or “disk full” (not for illegal argument types or other incidental errors). Hence, it makes...
45
Raise ImportError instead of OSError if required extraction library is not installed According to the official Python docs, `OSError` should be thrown in the following situations: > This exception is raised when a system function returns a system-related error, including I/O failures such as “file not found” or “dis...
[ 0.13113826513290405, -0.10024959594011307, -0.04780905321240425, -0.041649144142866135, -0.044207390397787094, -0.15195390582084656, 0.048548225313425064, 0.06684938818216324, 0.1849394142627716, 0.42027994990348816, 0.11480405181646347, 0.2957746684551239, -0.1283906102180481, 0.010311268...
https://github.com/huggingface/datasets/issues/5133
Hi! The Torch ops in your snippet are not equivalent to the NumPy ones, hence the difference. You can get the same behavior by replacing the line `feature = torch.mean(feature, dim=1)` with `feature = feature.squeeze().mean(1)` .
Tensor operation not functioning in dataset mapping
## Describe the bug I'm doing a torch.mean() operation in data preprocessing, and it's not working. ## Steps to reproduce the bug ``` from transformers import pipeline import torch import numpy as np from datasets import load_dataset device = 'cuda:0' raw_dataset = load_dataset("glue", "sst2") feature_extra...
36
Tensor operation not functioning in dataset mapping ## Describe the bug I'm doing a torch.mean() operation in data preprocessing, and it's not working. ## Steps to reproduce the bug ``` from transformers import pipeline import torch import numpy as np from datasets import load_dataset device = 'cuda:0' raw...
[ -0.31599903106689453, -0.4850853681564331, 0.0010897107422351837, 0.29548829793930054, 0.22902560234069824, -0.08756116777658463, 0.5998209118843079, 0.16039946675300598, -0.09626518934965134, 0.30303168296813965, -0.00175568088889122, 0.3639739751815796, 0.14919815957546234, -0.3700709342...
https://github.com/huggingface/datasets/issues/5133
> Hi! The Torch ops in your snippet are not equivalent to the NumPy ones, hence the difference. You can get the same behavior by replacing the line `feature = torch.mean(feature, dim=1)` with `feature = feature.squeeze().mean(1)` . Thank you.
Tensor operation not functioning in dataset mapping
## Describe the bug I'm doing a torch.mean() operation in data preprocessing, and it's not working. ## Steps to reproduce the bug ``` from transformers import pipeline import torch import numpy as np from datasets import load_dataset device = 'cuda:0' raw_dataset = load_dataset("glue", "sst2") feature_extra...
39
Tensor operation not functioning in dataset mapping ## Describe the bug I'm doing a torch.mean() operation in data preprocessing, and it's not working. ## Steps to reproduce the bug ``` from transformers import pipeline import torch import numpy as np from datasets import load_dataset device = 'cuda:0' raw...
[ -0.30328452587127686, -0.5189118385314941, -0.0023396573960781097, 0.3160865902900696, 0.20632261037826538, -0.08732123672962189, 0.5950581431388855, 0.15039925277233124, -0.09797541797161102, 0.28440386056900024, -0.009616311639547348, 0.35724934935569763, 0.14310038089752197, -0.36868506...
https://github.com/huggingface/datasets/issues/5131
any updates on this? It happens to me on [OpenWikiText-20%](https://huggingface.co/datasets/Bingsu/openwebtext_20p) dataset, but not on [OpenWebText-10k](https://huggingface.co/datasets/stas/openwebtext-10k). This is really strange because I don't change anything else in my running script. transformers version 4.18....
WikiText 103 tokenizer hangs
See issue here: https://github.com/huggingface/transformers/issues/19702
35
WikiText 103 tokenizer hangs See issue here: https://github.com/huggingface/transformers/issues/19702 any updates on this? It happens to me on [OpenWikiText-20%](https://huggingface.co/datasets/Bingsu/openwebtext_20p) dataset, but not on [OpenWebText-10k](https://huggingface.co/datasets/stas/openwebtext-10k). This...
[ 0.03930792957544327, -0.5219093561172485, 0.05311062932014465, -0.0770573541522026, 0.3084466755390167, -0.17780789732933044, 0.44314226508140564, -0.07915514707565308, -0.07170741260051727, 0.10493902862071991, -0.11941306293010712, 0.2056071013212204, 0.1295611709356308, -0.0826607272028...
https://github.com/huggingface/datasets/issues/5129
Hi! Unfortunately, I can't reproduce this issue locally (in Python 3.7/3.10) or in Colab. I would assume this is due to a bug we fixed in the latest release, but your version is up-to-date, so I'm not sure if there is something we can do to help...
unexpected `cast` or `class_encode_column` result after `rename_column`
## Describe the bug When invoke `cast` or `class_encode_column` to a colunm renamed by `rename_column` , it will convert all the variables in this column into one variable. I also run this script in version 2.5.2, this bug does not appear. So I switched to the older version. ## Steps to reproduce the bug ```python...
47
unexpected `cast` or `class_encode_column` result after `rename_column` ## Describe the bug When invoke `cast` or `class_encode_column` to a colunm renamed by `rename_column` , it will convert all the variables in this column into one variable. I also run this script in version 2.5.2, this bug does not appear. So I ...
[ 0.24168159067630768, 0.03820718824863434, -0.003612775355577469, 0.14938563108444214, 0.9369387626647949, 0.14646272361278534, 0.3778993785381317, 0.3624087870121002, -0.34284311532974243, 0.1879625916481018, -0.04112619906663895, 0.3603786826133728, -0.08040334284305573, -0.05424092337489...
https://github.com/huggingface/datasets/issues/5129
Hi, 方子东. I tried running the code with exact the same configuration (both datasets 2.5.2 and 2.6.1, python, pyarrow, pandas), but on Linux. The results seem to be the expected `{<pyarrow.Int64Scalar: 4>, <pyarrow.Int64Scalar: 2>, <pyarrow.Int64Scalar: 3>, <pyarrow.Int64Scalar: 0>, <pyarrow.Int64Scalar: 1>}`. I don't h...
unexpected `cast` or `class_encode_column` result after `rename_column`
## Describe the bug When invoke `cast` or `class_encode_column` to a colunm renamed by `rename_column` , it will convert all the variables in this column into one variable. I also run this script in version 2.5.2, this bug does not appear. So I switched to the older version. ## Steps to reproduce the bug ```python...
56
unexpected `cast` or `class_encode_column` result after `rename_column` ## Describe the bug When invoke `cast` or `class_encode_column` to a colunm renamed by `rename_column` , it will convert all the variables in this column into one variable. I also run this script in version 2.5.2, this bug does not appear. So I ...
[ 0.24168159067630768, 0.03820718824863434, -0.003612775355577469, 0.14938563108444214, 0.9369387626647949, 0.14646272361278534, 0.3778993785381317, 0.3624087870121002, -0.34284311532974243, 0.1879625916481018, -0.04112619906663895, 0.3603786826133728, -0.08040334284305573, -0.05424092337489...
https://github.com/huggingface/datasets/issues/5129
> Hi! Unfortunately, I can't reproduce this issue locally (in Python 3.7/3.10) or in Colab. I would assume this is due to a bug we fixed in the latest release, but your version is up-to-date, so I'm not sure if there is something we can do to help... Thank you for your attention and feel sorry to take your time. Sin...
unexpected `cast` or `class_encode_column` result after `rename_column`
## Describe the bug When invoke `cast` or `class_encode_column` to a colunm renamed by `rename_column` , it will convert all the variables in this column into one variable. I also run this script in version 2.5.2, this bug does not appear. So I switched to the older version. ## Steps to reproduce the bug ```python...
99
unexpected `cast` or `class_encode_column` result after `rename_column` ## Describe the bug When invoke `cast` or `class_encode_column` to a colunm renamed by `rename_column` , it will convert all the variables in this column into one variable. I also run this script in version 2.5.2, this bug does not appear. So I ...
[ 0.24168159067630768, 0.03820718824863434, -0.003612775355577469, 0.14938563108444214, 0.9369387626647949, 0.14646272361278534, 0.3778993785381317, 0.3624087870121002, -0.34284311532974243, 0.1879625916481018, -0.04112619906663895, 0.3603786826133728, -0.08040334284305573, -0.05424092337489...
https://github.com/huggingface/datasets/issues/5123
@lhoestq I tested the script without accelerator, and I confirm this is due to datasets part as this gets similar results without accelerator.
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
23
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
Hi ! You said it works on 1 GPU but doesn't wortk without accelerator - what's the difference between running on 1 GPU and running without accelerator in your case ?
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
31
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
Hi @lhoestq thanks for coming back to me. Sorry for the confusion I made. I meant this works fine on 1 GPU, but on multi-gpu it is freezing. "accelerator" is not an issue as if you adapt the code without accelerator this still gets the same issue. In order to test it. Please run "accelerate config", then use the set...
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
79
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
Hi @lhoestq could you have the chance to reproduce the error by running the minimal example shared? thanks
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
18
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
I think you need to do `train_dataset = train_dataset.with_format("torch")` to work with the DataLoader in a multiprocessing setup :) The hang is probably caused by our streamign lib `fsspec` which doesn't work in multiprocessing out of the box - but we made it work with the PyTorch DataLoader when the dataset forma...
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
56
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
Hi @lhoestq thanks for the response. I added the line suggested right before calling `with accelerator.main_process_first():` in the code above and I confirm this also freezes. to reproduce it please run "accelerate launch code.py". I was wondering if you could have more suggestions for me? I do not have an idea how...
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
61
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
Maybe the `fsspec` stuff need to be clearer even before - can you try to run this function at the very beginning of your script ? ```python import fsspec def _set_fsspec_for_multiprocess() -> None: """ Clear reference to the loop and thread. This is necessary otherwise HTTPFileSystem hangs in the ML...
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
69
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
Hi @lhoestq thank you. I tried it, I am getting `AttributeError: module 'fsspec' has no attribute 'asyn'`. which version of fsspect do you use? I am using ```fsspec 2022.8.2 pypi_0 pypi``` thank you.
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
33
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
Hi @lhoestq I solved `fsspec` error with this hack for now https://discuss.huggingface.co/t/attributeerror-module-fsspec-has-no-attribute-asyn/19255 but this is still freezing, I greatly appreciate if you could run this script on your side. Many thanks. ``` import fsspec def _set_fsspec_for_multiprocess() -> N...
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
472
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
Are you using `Pytorch 1.11`? Otherwise the script freezes because of the shuffling in this line: ``` return ShufflerIterDataPipe(self, buffer_size=buffer_size) ``` `ShufflerIterDataPipe` behavior must have changed for newer Pytorch versions. But this doesn't change whether you're using streaming or not in...
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
52
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5123
> Are you using `Pytorch 1.11`? Otherwise the script freezes because of the shuffling in this line: > > ``` > return ShufflerIterDataPipe(self, buffer_size=buffer_size) > ``` > > `ShufflerIterDataPipe` behavior must have changed for newer Pytorch versions. But this doesn't change whether you're using st...
datasets freezes with streaming mode in multiple-gpu
## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe978afc/examples/research_projects/codeparrot/scripts/cod...
83
datasets freezes with streaming mode in multiple-gpu ## Describe the bug Hi. I am using this dataloader, which is for processing large datasets in streaming mode mentioned in one of examples of huggingface. I am using it to read c4: https://github.com/huggingface/transformers/blob/b48ac1a094e572d6076b46a9e4ed3e0ebe9...
[ -0.32017046213150024, -0.31651628017425537, -0.03900309279561043, 0.4769470989704132, 0.32108497619628906, -0.05959739908576012, 0.3707592189311981, -0.002803770825266838, 0.2912582755088806, 0.2773028016090393, -0.1412859857082367, 0.06606163829565048, -0.1297408640384674, 0.3895158171653...
https://github.com/huggingface/datasets/issues/5117
Hi @echatzikyriakidis, thanks for submitting the issue. Which shell are you using exactly? I tried to run the command you sent, but I don't see colors at all 🧐 I tried from bash and zsh as well.
Progress bars have color red and never completed to 100%
## Describe the bug Progress bars after transformative operations turn in red and never be completed to 100% ## Steps to reproduce the bug ```python from datasets import load_dataset load_dataset('rotten_tomatoes', split='test').filter(lambda o: True) ``` ## Expected results Progress bar should be 100% an...
37
Progress bars have color red and never completed to 100% ## Describe the bug Progress bars after transformative operations turn in red and never be completed to 100% ## Steps to reproduce the bug ```python from datasets import load_dataset load_dataset('rotten_tomatoes', split='test').filter(lambda o: True) ...
[ -0.39734870195388794, 0.04320937395095825, -0.10254934430122375, -0.029496122151613235, 0.3089587986469269, -0.11117624491453171, 0.13297158479690552, 0.3897700309753418, -0.28815364837646484, 0.09463734924793243, 0.04255252331495285, 0.5570790767669678, 0.16084706783294678, 0.197009280323...
https://github.com/huggingface/datasets/issues/5117
Got it. I [created a PR](https://github.com/huggingface/datasets/pull/5120) that fixes this issue. Turns out that the wrapping logic for the inner loop was slightly incorrect.
Progress bars have color red and never completed to 100%
## Describe the bug Progress bars after transformative operations turn in red and never be completed to 100% ## Steps to reproduce the bug ```python from datasets import load_dataset load_dataset('rotten_tomatoes', split='test').filter(lambda o: True) ``` ## Expected results Progress bar should be 100% an...
23
Progress bars have color red and never completed to 100% ## Describe the bug Progress bars after transformative operations turn in red and never be completed to 100% ## Steps to reproduce the bug ```python from datasets import load_dataset load_dataset('rotten_tomatoes', split='test').filter(lambda o: True) ...
[ -0.3259928822517395, 0.16977046430110931, -0.084647037088871, -0.16093911230564117, 0.32357433438301086, -0.19417737424373627, 0.12783366441726685, 0.3235277533531189, -0.17735105752944946, 0.050864338874816895, -0.047706037759780884, 0.6858981251716614, 0.3134887218475342, 0.3177023530006...
https://github.com/huggingface/datasets/issues/5114
Hi Hubert! Could you please probably create a publicly available `gs://` dataset link? I think this would be easier for others to directly start to debug.
load_from_disk with remote filesystem fails due to a wrong temporary local folder path
## Describe the bug The function load_from_disk fails when using a remote filesystem because of a wrong temporary path generation in the load_from_disk method of arrow_dataset.py: ```python if is_remote_filesystem(fs): src_dataset_path = extract_path_from_uri(dataset_path) dataset_path = Dataset._build...
26
load_from_disk with remote filesystem fails due to a wrong temporary local folder path ## Describe the bug The function load_from_disk fails when using a remote filesystem because of a wrong temporary path generation in the load_from_disk method of arrow_dataset.py: ```python if is_remote_filesystem(fs): ...
[ -0.1440090835094452, -0.26802539825439453, 0.03857969492673874, 0.34252315759658813, 0.25744152069091797, -0.22356398403644562, 0.2704879939556122, 0.08593171834945679, 0.25620418787002563, 0.10422706604003906, 0.25353825092315674, 0.4123653471469879, -0.276187926530838, -0.387976199388504...
https://github.com/huggingface/datasets/issues/5112
Thanks a lot for the swift response! For a brief moment yesterday I thought I had gone insane 🤣On 14 Oct 2022, at 15:44, Albert Villanova del Moral ***@***.***> wrote: @PartiallyTyped, @Muennighoff: the issue is fixed. We are planning to make a patch release today. —Reply to this email directly, view it on GitHub, o...
Bug with filtered indices
## Describe the bug As reported by @PartiallyTyped (and by @Muennighoff): - https://github.com/huggingface/datasets/issues/5111#issuecomment-1278652524 There is an issue with the indices of a filtered dataset. ## Steps to reproduce the bug ```python ds = Dataset.from_dict({"num": [0, 1, 2, 3]}) ds = ds.filte...
65
Bug with filtered indices ## Describe the bug As reported by @PartiallyTyped (and by @Muennighoff): - https://github.com/huggingface/datasets/issues/5111#issuecomment-1278652524 There is an issue with the indices of a filtered dataset. ## Steps to reproduce the bug ```python ds = Dataset.from_dict({"num": [...
[ 0.036104410886764526, -0.20418187975883484, -0.15221640467643738, 0.2889063060283661, 0.2275732308626175, -0.04369246959686279, 0.42200157046318054, 0.2353927493095398, 0.1657329797744751, 0.4011457860469818, 0.012838099151849747, 0.29628220200538635, 0.020446334034204483, 0.33652895689010...
https://github.com/huggingface/datasets/issues/5111
Thanks for reporting, @loubnabnl and for the additional information, @PartiallyTyped. However, I'm not able to reproduce this issue, neither locally nor on Colab: ``` Dataset({ features: ['repo_name', 'path', 'copies', 'size', 'content', 'license', 'hash', 'line_mean', 'line_max', 'alpha_frac', 'autogenerated...
map and filter not working properly in multiprocessing with the new release 2.6.0
## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc` in filter for it to work properly. This doesn't happen with `datasets` version 2.5...
63
map and filter not working properly in multiprocessing with the new release 2.6.0 ## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc...
[ -0.29329997301101685, -0.09082436561584473, -0.12948665022850037, 0.18801121413707733, -0.0888834297657013, -0.4970914125442505, 0.20947514474391937, 0.24282601475715637, 0.20070993900299072, 0.06659453362226486, 0.03769483417272568, 0.4152701199054718, -0.10309334844350815, 0.175760433077...
https://github.com/huggingface/datasets/issues/5111
This is the minimum reproducible example. I ran this on the premium instances of colab. ``` # !pip install datasets import datasets from datasets import load_dataset ds = load_dataset("copenlu/answerable_tydiqa").filter("english".__eq__, input_columns="language") assert all(map("english".__eq__, ds["train"]["la...
map and filter not working properly in multiprocessing with the new release 2.6.0
## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc` in filter for it to work properly. This doesn't happen with `datasets` version 2.5...
96
map and filter not working properly in multiprocessing with the new release 2.6.0 ## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc...
[ -0.29329997301101685, -0.09082436561584473, -0.12948665022850037, 0.18801121413707733, -0.0888834297657013, -0.4970914125442505, 0.20947514474391937, 0.24282601475715637, 0.20070993900299072, 0.06659453362226486, 0.03769483417272568, 0.4152701199054718, -0.10309334844350815, 0.175760433077...
https://github.com/huggingface/datasets/issues/5111
I can reproduce the issue on my mac too ``` - `datasets` version: 2.6.0 - Platform: macOS-12.2.1-arm64-arm-64bit - Python version: 3.9.13 - PyArrow version: 9.0.0 - Pandas version: 1.4.3 ``` But not on Colab with python 3.7, maybe related to python version? (didn't manage to install python 3.9) ``` - `datase...
map and filter not working properly in multiprocessing with the new release 2.6.0
## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc` in filter for it to work properly. This doesn't happen with `datasets` version 2.5...
69
map and filter not working properly in multiprocessing with the new release 2.6.0 ## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc...
[ -0.29329997301101685, -0.09082436561584473, -0.12948665022850037, 0.18801121413707733, -0.0888834297657013, -0.4970914125442505, 0.20947514474391937, 0.24282601475715637, 0.20070993900299072, 0.06659453362226486, 0.03769483417272568, 0.4152701199054718, -0.10309334844350815, 0.175760433077...
https://github.com/huggingface/datasets/issues/5111
I think there are 2 different issues here: - the one reported by @loubnabnl is related to multiprocessing in map and then filter; we should reproduce it first: I have tried with Python version 3.9.7 and I can't reproduce it either; maybe it is related to the version of PyArrow? To be checked. - the issue reported by ...
map and filter not working properly in multiprocessing with the new release 2.6.0
## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc` in filter for it to work properly. This doesn't happen with `datasets` version 2.5...
71
map and filter not working properly in multiprocessing with the new release 2.6.0 ## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc...
[ -0.29329997301101685, -0.09082436561584473, -0.12948665022850037, 0.18801121413707733, -0.0888834297657013, -0.4970914125442505, 0.20947514474391937, 0.24282601475715637, 0.20070993900299072, 0.06659453362226486, 0.03769483417272568, 0.4152701199054718, -0.10309334844350815, 0.175760433077...
https://github.com/huggingface/datasets/issues/5111
Could you create another issue for the @PartiallyTyped one please ? Regarding the OP issue, I also tried on colab or locally on py3.7 or py3.10 but didn't reproduce
map and filter not working properly in multiprocessing with the new release 2.6.0
## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc` in filter for it to work properly. This doesn't happen with `datasets` version 2.5...
29
map and filter not working properly in multiprocessing with the new release 2.6.0 ## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc...
[ -0.29329997301101685, -0.09082436561584473, -0.12948665022850037, 0.18801121413707733, -0.0888834297657013, -0.4970914125442505, 0.20947514474391937, 0.24282601475715637, 0.20070993900299072, 0.06659453362226486, 0.03769483417272568, 0.4152701199054718, -0.10309334844350815, 0.175760433077...
https://github.com/huggingface/datasets/issues/5111
I managed to reproduce your issue @loubnabnl on colab by upgrading pyarrow to 9.0.0 instead of 6.0.1
map and filter not working properly in multiprocessing with the new release 2.6.0
## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc` in filter for it to work properly. This doesn't happen with `datasets` version 2.5...
17
map and filter not working properly in multiprocessing with the new release 2.6.0 ## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc...
[ -0.29329997301101685, -0.09082436561584473, -0.12948665022850037, 0.18801121413707733, -0.0888834297657013, -0.4970914125442505, 0.20947514474391937, 0.24282601475715637, 0.20070993900299072, 0.06659453362226486, 0.03769483417272568, 0.4152701199054718, -0.10309334844350815, 0.175760433077...
https://github.com/huggingface/datasets/issues/5111
I managed to have a _super_ minimal reproducible example: ```python from datasets import Dataset, concatenate_datasets ds = concatenate_datasets([Dataset.from_dict({"a": [i]}) for i in range(10)]) ds2 = ds.map(lambda _: {}, batched=True) assert list(ds2) == list(ds) ``` (filter uses a batched `map` under the...
map and filter not working properly in multiprocessing with the new release 2.6.0
## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc` in filter for it to work properly. This doesn't happen with `datasets` version 2.5...
42
map and filter not working properly in multiprocessing with the new release 2.6.0 ## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc...
[ -0.29329997301101685, -0.09082436561584473, -0.12948665022850037, 0.18801121413707733, -0.0888834297657013, -0.4970914125442505, 0.20947514474391937, 0.24282601475715637, 0.20070993900299072, 0.06659453362226486, 0.03769483417272568, 0.4152701199054718, -0.10309334844350815, 0.175760433077...
https://github.com/huggingface/datasets/issues/5111
> the one reported by @loubnabnl is related to multiprocessing in map and then filter; we should reproduce it first: I have tried with Python version 3.9.7 and I can't reproduce it either; maybe it is related to the version of PyArrow? To be checked. So finally it was related to PyArrow version! :+1:
map and filter not working properly in multiprocessing with the new release 2.6.0
## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc` in filter for it to work properly. This doesn't happen with `datasets` version 2.5...
54
map and filter not working properly in multiprocessing with the new release 2.6.0 ## Describe the bug When mapping is used on a dataset with more than one process, there is a weird behavior when trying to use `filter` , it's like only the samples from one worker are retrieved, one needs to specify the same `num_proc...
[ -0.29329997301101685, -0.09082436561584473, -0.12948665022850037, 0.18801121413707733, -0.0888834297657013, -0.4970914125442505, 0.20947514474391937, 0.24282601475715637, 0.20070993900299072, 0.06659453362226486, 0.03769483417272568, 0.4152701199054718, -0.10309334844350815, 0.175760433077...
https://github.com/huggingface/datasets/issues/5109
The hash used for caching is computed by pickling recursively the function passed to `map`. Maybe some objects don't have the same hash across sessions. In particular you can check the hash of your model using ```python from datasets.fingerprint import Hasher obj = AutoModel.from_config(config=config, add_pooling_l...
Map caching not working for some class methods
## Describe the bug The cache loading is not working as expected for some class methods with a model stored in an attribute. The new fingerprint for `_map_single` is not the same at each run. The hasher generate a different hash for the class method. This comes from `dumps` function in `datasets.utils.py_utils` whic...
71
Map caching not working for some class methods ## Describe the bug The cache loading is not working as expected for some class methods with a model stored in an attribute. The new fingerprint for `_map_single` is not the same at each run. The hasher generate a different hash for the class method. This comes from `...
[ 0.06155872344970703, -0.034300848841667175, 0.12326925992965698, 0.33168426156044006, 0.18914653360843658, 0.00266052782535553, 0.5595552921295166, 0.2945951521396637, 0.23397710919380188, -0.1649484932422638, -0.13468119502067566, 0.5997432470321655, -0.010526822879910469, -0.443996489048...
https://github.com/huggingface/datasets/issues/5109
Indeed, the hash is changing. The `dumps` function serialize the model object in different ways because the model object is not deterministic ```python from datasets.utils.py_utils import dumps obj1 = AutoModel.from_config(config=config, add_pooling_layer=False) obj2 = AutoModel.from_config(config=config, add_pooli...
Map caching not working for some class methods
## Describe the bug The cache loading is not working as expected for some class methods with a model stored in an attribute. The new fingerprint for `_map_single` is not the same at each run. The hasher generate a different hash for the class method. This comes from `dumps` function in `datasets.utils.py_utils` whic...
89
Map caching not working for some class methods ## Describe the bug The cache loading is not working as expected for some class methods with a model stored in an attribute. The new fingerprint for `_map_single` is not the same at each run. The hasher generate a different hash for the class method. This comes from `...
[ 0.06064450740814209, -0.0009959936141967773, 0.13304975628852844, 0.3238905370235443, 0.20141944289207458, -0.009757868945598602, 0.6343295574188232, 0.29405227303504944, 0.2097470462322235, -0.16269373893737793, -0.15033181011676788, 0.6095578074455261, -0.004029382020235062, -0.416094690...
https://github.com/huggingface/datasets/issues/5105
Thanks for reporting, @cakiki. I would say the deletion of the dir is an expected behavior though...
Specifying an exisiting folder in download_and_prepare deletes everything in it
## Describe the bug The builder correctly creates the `output_dir` folder if it doesn't exist, but if the folder exists everything within it is deleted. Specifying `"."` as the `output_dir` deletes everything in your current dir but also leads to **another bug** whose traceback is the following: ``` ...
17
Specifying an exisiting folder in download_and_prepare deletes everything in it ## Describe the bug The builder correctly creates the `output_dir` folder if it doesn't exist, but if the folder exists everything within it is deleted. Specifying `"."` as the `output_dir` deletes everything in your current dir but also...
[ -0.2782193720340729, 0.4378104507923126, -0.09798122942447662, 0.33214250206947327, 0.3933848738670349, -0.18041014671325684, -0.07301950454711914, 0.3537350296974182, -0.07171323895454407, 0.3245939016342163, -0.22473810613155365, 0.25985386967658997, -0.14223022758960724, -0.006780289113...
https://github.com/huggingface/datasets/issues/5105
Thank you both for your feedback! @albertvillanova I think I might have have the wrong mental model of what the function was meant to do. I thought it would be an API similar to the pandas `to_XX` write methods (Like the one @lhoestq mentions) so I just assumed it would download the dataframe to whichever folder I s...
Specifying an exisiting folder in download_and_prepare deletes everything in it
## Describe the bug The builder correctly creates the `output_dir` folder if it doesn't exist, but if the folder exists everything within it is deleted. Specifying `"."` as the `output_dir` deletes everything in your current dir but also leads to **another bug** whose traceback is the following: ``` ...
103
Specifying an exisiting folder in download_and_prepare deletes everything in it ## Describe the bug The builder correctly creates the `output_dir` folder if it doesn't exist, but if the folder exists everything within it is deleted. Specifying `"."` as the `output_dir` deletes everything in your current dir but also...
[ -0.2782193720340729, 0.4378104507923126, -0.09798122942447662, 0.33214250206947327, 0.3933848738670349, -0.18041014671325684, -0.07301950454711914, 0.3537350296974182, -0.07171323895454407, 0.3245939016342163, -0.22473810613155365, 0.25985386967658997, -0.14223022758960724, -0.006780289113...
https://github.com/huggingface/datasets/issues/5105
actually there's already a `download_mode` parameter that defaults to `REUSE_DATASET_IF_EXISTS` - so I guess it's just a matter of not deleting files unrelated to the dataset, and to overwrite existing dataset files if the download mode is `REUSE_CACHE_IF_EXISTS` or `FORCE_REDOWNLOAD`
Specifying an exisiting folder in download_and_prepare deletes everything in it
## Describe the bug The builder correctly creates the `output_dir` folder if it doesn't exist, but if the folder exists everything within it is deleted. Specifying `"."` as the `output_dir` deletes everything in your current dir but also leads to **another bug** whose traceback is the following: ``` ...
40
Specifying an exisiting folder in download_and_prepare deletes everything in it ## Describe the bug The builder correctly creates the `output_dir` folder if it doesn't exist, but if the folder exists everything within it is deleted. Specifying `"."` as the `output_dir` deletes everything in your current dir but also...
[ -0.2782193720340729, 0.4378104507923126, -0.09798122942447662, 0.33214250206947327, 0.3933848738670349, -0.18041014671325684, -0.07301950454711914, 0.3537350296974182, -0.07171323895454407, 0.3245939016342163, -0.22473810613155365, 0.25985386967658997, -0.14223022758960724, -0.006780289113...
https://github.com/huggingface/datasets/issues/5099
`datasets` doesn't seem to urlencode the directory names here https://github.com/huggingface/datasets/blob/7feeb5648a63b6135a8259dedc3b1e19185ee4c7/src/datasets/utils/file_utils.py#L109-L111 for example we should have ```python from datasets.utils.file_utils import hf_hub_url url = hf_hub_url("loubnabnl/bigc...
datasets doesn't support # in data paths
## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same data is loaded properly ```python ds = lo...
38
datasets doesn't support # in data paths ## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same ...
[ -0.20917704701423645, 0.135900616645813, -0.08399749547243118, 0.41576308012008667, 0.38240277767181396, 0.019603505730628967, -0.07633669674396515, 0.41128993034362793, -0.030178077518939972, 0.22143185138702393, 0.024373799562454224, 0.4805355668067932, -0.3922275900840759, 0.28832444548...
https://github.com/huggingface/datasets/issues/5099
@loubnabnl The dataset you linked in the description of the bug does not work and returns a 404. Where can I find the dataset to reproduce the bug?
datasets doesn't support # in data paths
## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same data is loaded properly ```python ds = lo...
28
datasets doesn't support # in data paths ## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same ...
[ -0.18062302470207214, 0.1916036307811737, -0.08600074797868729, 0.4722375273704529, 0.23272094130516052, 0.13766761124134064, 0.02379724755883217, 0.35274696350097656, -0.0653897374868393, 0.15885403752326965, 0.29410889744758606, 0.5142217874526978, -0.4371049702167511, 0.2932418286800384...
https://github.com/huggingface/datasets/issues/5099
I think you can create a dataset repository on the Hub with a dummy file containing a `#`
datasets doesn't support # in data paths
## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same data is loaded properly ```python ds = lo...
18
datasets doesn't support # in data paths ## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same ...
[ -0.30818724632263184, 0.11641325056552887, -0.09123967587947845, 0.35130101442337036, 0.34503206610679626, 0.09891665726900101, 0.02098218724131584, 0.45544716715812683, -0.03980487585067749, 0.22690454125404358, 0.11732076853513718, 0.6159343123435974, -0.361494779586792, 0.38039487600326...
https://github.com/huggingface/datasets/issues/5099
Ah sorry it was private I just made it public, I can also help with this if needed
datasets doesn't support # in data paths
## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same data is loaded properly ```python ds = lo...
18
datasets doesn't support # in data paths ## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same ...
[ -0.26596423983573914, 0.15241317451000214, -0.11883436888456345, 0.4522741436958313, 0.3733290135860443, 0.04726604372262955, -0.03504325449466705, 0.4054626226425171, -0.025888592004776, 0.15918132662773132, 0.16953334212303162, 0.5867080688476562, -0.415131151676178, 0.38535523414611816,...
https://github.com/huggingface/datasets/issues/5099
@lhoestq Should I url encode also repo_id and revision parameters? I'm not sure what are the valid characters there. Personally, I would be cautious and only url encode the path parameter.
datasets doesn't support # in data paths
## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same data is loaded properly ```python ds = lo...
31
datasets doesn't support # in data paths ## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same ...
[ -0.23935467004776, 0.34229058027267456, -0.09241920709609985, 0.41411009430885315, 0.3124765157699585, -0.07263592630624771, -0.06012554466724396, 0.3487836420536041, -0.1738092452287674, 0.12757396697998047, 0.21336376667022705, 0.48026469349861145, -0.3821045458316803, 0.2710798680782318...
https://github.com/huggingface/datasets/issues/5099
These are possible solutions (assuming `from urllib.parse import quote`): 1) url encode only the path parameter: ``` # src/datasets/utils/file_utils.py def hf_hub_url(repo_id: str, path: str, revision: Optional[str] = None) -> str: revision = revision or config.HUB_DEFAULT_VERSION return config.HUB_DATA...
datasets doesn't support # in data paths
## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same data is loaded properly ```python ds = lo...
113
datasets doesn't support # in data paths ## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same ...
[ -0.2604638338088989, 0.17757558822631836, -0.06597213447093964, 0.3687848150730133, 0.3751511871814728, 0.022102251648902893, -0.024053294211626053, 0.459063321352005, -0.059669867157936096, 0.1981833130121231, 0.05648915469646454, 0.6017806529998779, -0.36706823110580444, 0.35972750186920...
https://github.com/huggingface/datasets/issues/5099
repo_id can only contain alphanumeric characters and _- so it doesn't need to be encoded. However I agree it's a good idea to also apply `quote` to the revision as well as in 2. !
datasets doesn't support # in data paths
## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same data is loaded properly ```python ds = lo...
35
datasets doesn't support # in data paths ## Describe the bug dataset files with `#` symbol their paths aren't read correctly. ## Steps to reproduce the bug The data in folder `c#`of this [dataset](https://huggingface.co/datasets/loubnabnl/bigcode_csharp) can't be loaded. While the folder `c_sharp` with the same ...
[ -0.2246045172214508, 0.32174623012542725, -0.11245297640562057, 0.3619314730167389, 0.3766544461250305, 0.013073816895484924, -0.051430732011795044, 0.43473711609840393, -0.16425886750221252, 0.16487082839012146, 0.17711126804351807, 0.5607147812843323, -0.30946698784828186, 0.338590681552...
https://github.com/huggingface/datasets/issues/5098
Hi, thanks for reporting and suggesting a fix! We still need to account for `.`/`..` in the file path, so a more robust fix would be `Path(os.path.abspath(filepath))`.
Classes label error when loading symbolic links using imagefolder
**Is your feature request related to a problem? Please describe.** Like this: #4015 When there are **symbolic links** to pictures in the data folder, the parent folder name of the **real file** will be used as the class name instead of the parent folder of the symbolic link itself. Can you give an option to decide wh...
27
Classes label error when loading symbolic links using imagefolder **Is your feature request related to a problem? Please describe.** Like this: #4015 When there are **symbolic links** to pictures in the data folder, the parent folder name of the **real file** will be used as the class name instead of the parent fol...
[ -0.2692006826400757, 0.04193270206451416, 0.03758130222558975, 0.7047106027603149, 0.2662847340106964, 0.05047333240509033, 0.4039701819419861, 0.0237501822412014, 0.3618275821208954, 0.0737377256155014, -0.06793917715549469, 0.34430450201034546, -0.4016427993774414, -0.3618546426296234, ...
https://github.com/huggingface/datasets/issues/5098
> Hi, thanks for reporting and suggesting a fix! We still need to account for `.`/`..` in the file path, so a more robust fix would be `Path(os.path.abspath(filepath))`. Thanks for your reply!
Classes label error when loading symbolic links using imagefolder
**Is your feature request related to a problem? Please describe.** Like this: #4015 When there are **symbolic links** to pictures in the data folder, the parent folder name of the **real file** will be used as the class name instead of the parent folder of the symbolic link itself. Can you give an option to decide wh...
32
Classes label error when loading symbolic links using imagefolder **Is your feature request related to a problem? Please describe.** Like this: #4015 When there are **symbolic links** to pictures in the data folder, the parent folder name of the **real file** will be used as the class name instead of the parent fol...
[ -0.2615424692630768, 0.03905509412288666, 0.04089824855327606, 0.7104777693748474, 0.2595891058444977, 0.045819446444511414, 0.41204971075057983, 0.01836317405104637, 0.37061673402786255, 0.07174444198608398, -0.06196688488125801, 0.34097540378570557, -0.40204107761383057, -0.3577244877815...
https://github.com/huggingface/datasets/issues/5097
Thanks for reporting, @catalys1. This seems a duplicate of: - #3310 The source of the problem is in PyArrow: - [ARROW-15141: [C++] Fatal error condition occurred in aws_thread_launch](https://issues.apache.org/jira/browse/ARROW-15141) - [ARROW-17501: [C++] Fatal error condition occurred in aws_thread_launch](...
Fatal error with pyarrow/libarrow.so
## Describe the bug When using datasets, at the very end of my jobs the program crashes (see trace below). It doesn't seem to affect anything, as it appears to happen as the program is closing down. Just importing `datasets` is enough to cause the error. ## Steps to reproduce the bug This is sufficient to reprodu...
91
Fatal error with pyarrow/libarrow.so ## Describe the bug When using datasets, at the very end of my jobs the program crashes (see trace below). It doesn't seem to affect anything, as it appears to happen as the program is closing down. Just importing `datasets` is enough to cause the error. ## Steps to reproduce...
[ -0.6741321086883545, 0.3884136974811554, 0.05871608108282089, 0.14144942164421082, 0.3065972626209259, -0.06482528895139694, 0.2413044571876526, 0.09869422763586044, -0.22348648309707642, 0.11210647970438004, 0.09991703182458878, 0.6103008389472961, -0.010139338672161102, 0.095856532454490...
https://github.com/huggingface/datasets/issues/5096
The transfer of the dummy dataset to the dummy org works as expected: ```python In [1]: from datasets import load_dataset; ds = load_dataset("dummy_canonical_dataset", download_mode="force_redownload"); ds Downloading builder script: 100%|██████████████████████████████████████████████████████████████████████████████...
Transfer some canonical datasets under an organization namespace
As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organization namespace, we are deprecating the canonical one (and eventua...
140
Transfer some canonical datasets under an organization namespace As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organi...
[ 0.042021170258522034, 0.31293785572052, -0.013558253645896912, 0.025106238201260567, 0.17084795236587524, 0.023028627038002014, 0.24620990455150604, 0.39081692695617676, 0.057508379220962524, 0.02178104966878891, -0.31573739647865295, -0.07118796557188034, -0.26906123757362366, 0.031928755...
https://github.com/huggingface/datasets/issues/5096
Maybe we should be a bit more proactive with these transfers. There are only ≈70 canonical models, so reaching that number with datasets would be great, too. It's not easy considering the current number of ≈750 canonical datasets, but doable. For instance, it shouldn't be too hard to transfer these datasets (partial...
Transfer some canonical datasets under an organization namespace
As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organization namespace, we are deprecating the canonical one (and eventua...
470
Transfer some canonical datasets under an organization namespace As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organi...
[ 0.042021170258522034, 0.31293785572052, -0.013558253645896912, 0.025106238201260567, 0.17084795236587524, 0.023028627038002014, 0.24620990455150604, 0.39081692695617676, 0.057508379220962524, 0.02178104966878891, -0.31573739647865295, -0.07118796557188034, -0.26906123757362366, 0.031928755...
https://github.com/huggingface/datasets/issues/5096
Next week I can take care of some of them :) In most cases we just need to send an email to ask them if they're ok with it. Let's coordinate on slack ?
Transfer some canonical datasets under an organization namespace
As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organization namespace, we are deprecating the canonical one (and eventua...
34
Transfer some canonical datasets under an organization namespace As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organi...
[ 0.042021170258522034, 0.31293785572052, -0.013558253645896912, 0.025106238201260567, 0.17084795236587524, 0.023028627038002014, 0.24620990455150604, 0.39081692695617676, 0.057508379220962524, 0.02178104966878891, -0.31573739647865295, -0.07118796557188034, -0.26906123757362366, 0.031928755...
https://github.com/huggingface/datasets/issues/5096
I can also continuing working on this if we agree this has become a priority now.
Transfer some canonical datasets under an organization namespace
As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organization namespace, we are deprecating the canonical one (and eventua...
16
Transfer some canonical datasets under an organization namespace As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organi...
[ 0.042021170258522034, 0.31293785572052, -0.013558253645896912, 0.025106238201260567, 0.17084795236587524, 0.023028627038002014, 0.24620990455150604, 0.39081692695617676, 0.057508379220962524, 0.02178104966878891, -0.31573739647865295, -0.07118796557188034, -0.26906123757362366, 0.031928755...
https://github.com/huggingface/datasets/issues/5096
cool stuff! this morning on my side i moved huggingface.co/ctrl (a not very used model) to its rightful entity
Transfer some canonical datasets under an organization namespace
As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organization namespace, we are deprecating the canonical one (and eventua...
19
Transfer some canonical datasets under an organization namespace As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organi...
[ 0.042021170258522034, 0.31293785572052, -0.013558253645896912, 0.025106238201260567, 0.17084795236587524, 0.023028627038002014, 0.24620990455150604, 0.39081692695617676, 0.057508379220962524, 0.02178104966878891, -0.31573739647865295, -0.07118796557188034, -0.26906123757362366, 0.031928755...
https://github.com/huggingface/datasets/issues/5096
As a previous step before transferring the datasets, we decided we should convert them to Parquet, so that the viewer does not stop working (the viewer does not support datasets with scripts). Datasets converted to Parquet: - [x] adversarial_qa - [x] ai2_arc - [x] americas_nli - [x] anli - [x] asset - [x] bea...
Transfer some canonical datasets under an organization namespace
As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organization namespace, we are deprecating the canonical one (and eventua...
361
Transfer some canonical datasets under an organization namespace As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organi...
[ 0.042021170258522034, 0.31293785572052, -0.013558253645896912, 0.025106238201260567, 0.17084795236587524, 0.023028627038002014, 0.24620990455150604, 0.39081692695617676, 0.057508379220962524, 0.02178104966878891, -0.31573739647865295, -0.07118796557188034, -0.26906123757362366, 0.031928755...
https://github.com/huggingface/datasets/issues/5096
For `c4` and `mc4` I was thinking of adding the corresponding configs to `allenai/c4` and redirect `c4` and `mc4` to `allenai/c4`. I'll open a PR on `allenai/c4` if it's good for you
Transfer some canonical datasets under an organization namespace
As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organization namespace, we are deprecating the canonical one (and eventua...
32
Transfer some canonical datasets under an organization namespace As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organi...
[ 0.042021170258522034, 0.31293785572052, -0.013558253645896912, 0.025106238201260567, 0.17084795236587524, 0.023028627038002014, 0.24620990455150604, 0.39081692695617676, 0.057508379220962524, 0.02178104966878891, -0.31573739647865295, -0.07118796557188034, -0.26906123757362366, 0.031928755...
https://github.com/huggingface/datasets/issues/5096
@davanstrien and @lhoestq, I have shared with you this spreadsheet: https://docs.google.com/spreadsheets/d/1GvNTd1UxmtTvEFOK-Eq6E3Str4FUWQuWZsEN0WVFirs/edit?usp=sharing This way we can take datasets by batches to contact the authors and transfer to the organizations.
Transfer some canonical datasets under an organization namespace
As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organization namespace, we are deprecating the canonical one (and eventua...
28
Transfer some canonical datasets under an organization namespace As discussed during our @huggingface/datasets meeting, we are planning to move some "canonical" dataset scripts under their corresponding organization namespace (if this does not exist). On the contrary, if the dataset already exists under the organi...
[ 0.042021170258522034, 0.31293785572052, -0.013558253645896912, 0.025106238201260567, 0.17084795236587524, 0.023028627038002014, 0.24620990455150604, 0.39081692695617676, 0.057508379220962524, 0.02178104966878891, -0.31573739647865295, -0.07118796557188034, -0.26906123757362366, 0.031928755...
https://github.com/huggingface/datasets/issues/5094
Hi ! Could it be an Out of Memory issue that could have killed one of the processes ? can you check your memory ?
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
25
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5094
Hi! I don't think it is a memory issue. I'm monitoring the main and spawn python processes and threads with `htop` and the memory does not peak. Besides, the example I've posted above should not be that demanding in terms of memory, right? (I have 32GB of RAM).
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
48
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5094
Indeed it should be fine. I couldn't reproduce the error though - I ran your script on my side and it works fine. What version of pytorch are you using ?
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
31
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5094
I also tried on colab and it works fine 🤔 Maybe something is wrong with your installation of pytorch ?
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
20
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5094
Oh actually I just saw that you're using python 3.9 This could be related to https://github.com/huggingface/datasets/issues/4113 We'll fix that as soon as we can, in the meantime you can try to use use single process, or use an older version of python maybe ?
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
44
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5094
I tried with python 3.7 and the issue persists. In collab, which also uses 3.7 I don't get the issue, so yes I guess is something on mu side... will post it here if I manage to fix it
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
39
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5094
Hi! Which version of transformers are you using? I test the code on Colab (so python 3.7) with transformers 4.23.1, torch 1.12.1 and pyarrow 9.0.0 (also 6.x), it worked without stuck.
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
31
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5094
Hi, I have the same problem in use **datasets.IterableDatasetDict.map()** my pytorch is 2.0.0a0+gitc263bd4 my python is 3.8.16(default, Jun 12 2023, 17:37:21) work on aarch64 in 16 node, each node with 4*nVidia-A100-40G every node have 4 process execute code as ↓ ``` from datasets import load_dataset, interleav...
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
447
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5094
@bio-punk `IterableDatasetDict.map` does not support multiprocessing (only `DatasetDict.map` and `Dataset.map` do), so please open a new issue as this doesn't seem to be related to the original issue.
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock
## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `datasets.Dataset.map` spawns [a this step](https://github.com/huggingface/datase...
28
Multiprocessing with `Dataset.map` and `PyTorch` results in deadlock ## Describe the bug There seems to be an issue with using multiprocessing with `datasets.Dataset.map` (i.e. setting `num_proc` to a value greater than one) combined with a function that uses `torch` under the hood. The subprocesses that `dataset...
[ -0.1972830593585968, -0.5258709788322449, -0.05985720828175545, 0.191212996840477, -0.03308046981692314, -0.03727483004331589, 0.3879682123661041, 0.10255981236696243, 0.19705405831336975, 0.15648040175437927, 0.15930667519569397, 0.5224059224128723, -0.1971757411956787, -0.348668277263641...
https://github.com/huggingface/datasets/issues/5093
Hi, thanks for reporting! This line should be replaced with ```python dataset = dataset.map(lambda examples: tokenizer(examples["text"], return_tensors="np"), batched=True) ``` for it to work (the `return_tensors` part inside the `tokenizer` call).
Mismatch between tutoriel and doc
## Describe the bug In the "Process text data" tutorial, [`map` has `return_tensors` as kwarg](https://huggingface.co/docs/datasets/main/en/nlp_process#map). It does not seem to appear in the [function documentation](https://huggingface.co/docs/datasets/main/en/package_reference/main_classes#datasets.Dataset.map), nor...
30
Mismatch between tutoriel and doc ## Describe the bug In the "Process text data" tutorial, [`map` has `return_tensors` as kwarg](https://huggingface.co/docs/datasets/main/en/nlp_process#map). It does not seem to appear in the [function documentation](https://huggingface.co/docs/datasets/main/en/package_reference/mai...
[ 0.10698112845420837, -0.38053208589553833, 0.052491411566734314, 0.12463709712028503, 0.06381562352180481, -0.14597515761852264, 0.31472453474998474, 0.05504579097032547, 0.07469645887613297, 0.09037390351295471, 0.1336309313774109, 0.7944684028625488, -0.037477102130651474, -0.06233176961...
https://github.com/huggingface/datasets/issues/5088
Hi @junwang-wish, thanks for reporting. Unfortunately, I'm not able to reproduce the bug. Which version of `datasets` are you using? Does the problem persist if you update `datasets`? ```shell pip install -U datasets ```
load_datasets("json", ...) don't read local .json.gz properly
## Describe the bug I have a local file `*.json.gz` and it can be read by `pandas.read_json(lines=True)`, but cannot be read by `load_datasets("json")` (resulting in 0 lines) ## Steps to reproduce the bug ```python fpath = '/data/junwang/.cache/general/57b6f2314cbe0bc45dda5b78f0871df2/test.json.gz' ds_panda = Da...
34
load_datasets("json", ...) don't read local .json.gz properly ## Describe the bug I have a local file `*.json.gz` and it can be read by `pandas.read_json(lines=True)`, but cannot be read by `load_datasets("json")` (resulting in 0 lines) ## Steps to reproduce the bug ```python fpath = '/data/junwang/.cache/gener...
[ -0.003829382359981537, -0.04745712876319885, -0.0509805753827095, 0.4958299994468689, 0.28055697679519653, 0.060935430228710175, 0.36184051632881165, 0.34863871335983276, 0.5576654672622681, 0.0336512066423893, -0.11394594609737396, 0.4106939435005188, 0.14960315823554993, -0.0385022200644...
https://github.com/huggingface/datasets/issues/5088
Thanks @albertvillanova I updated `datasets` from `2.5.1` to `2.5.2` and tested copying the `json.gz` to a different directory and my mind was blown: ```python fpath = '/data/junwang/.cache/general/57b6f2314cbe0bc45dda5b78f0871df2/test.json.gz' ds_panda = DatasetDict( test=Dataset.from_pandas( pd.rea...
load_datasets("json", ...) don't read local .json.gz properly
## Describe the bug I have a local file `*.json.gz` and it can be read by `pandas.read_json(lines=True)`, but cannot be read by `load_datasets("json")` (resulting in 0 lines) ## Steps to reproduce the bug ```python fpath = '/data/junwang/.cache/general/57b6f2314cbe0bc45dda5b78f0871df2/test.json.gz' ds_panda = Da...
189
load_datasets("json", ...) don't read local .json.gz properly ## Describe the bug I have a local file `*.json.gz` and it can be read by `pandas.read_json(lines=True)`, but cannot be read by `load_datasets("json")` (resulting in 0 lines) ## Steps to reproduce the bug ```python fpath = '/data/junwang/.cache/gener...
[ -0.003829382359981537, -0.04745712876319885, -0.0509805753827095, 0.4958299994468689, 0.28055697679519653, 0.060935430228710175, 0.36184051632881165, 0.34863871335983276, 0.5576654672622681, 0.0336512066423893, -0.11394594609737396, 0.4106939435005188, 0.14960315823554993, -0.0385022200644...
https://github.com/huggingface/datasets/issues/5086
Hi @km5ar, thanks for reporting. This should be fixed in the notebook: - the filename `datasets-issues-with-hf-doc-builder.jsonl` no longer exists on the repo; instead, current filename is `datasets-issues-with-comments.jsonl` - see: https://huggingface.co/datasets/lewtun/github-issues/tree/main Anyway, dependi...
HTTPError: 404 Client Error: Not Found for url
## Describe the bug I was following chap 5 from huggingface course: https://huggingface.co/course/chapter5/6?fw=tf However, I'm not able to download the datasets, with a 404 erros <img width="1160" alt="iShot2022-10-06_15 54 50" src="https://user-images.githubusercontent.com/54015474/194406327-ae62c2f3-1da5-...
178
HTTPError: 404 Client Error: Not Found for url ## Describe the bug I was following chap 5 from huggingface course: https://huggingface.co/course/chapter5/6?fw=tf However, I'm not able to download the datasets, with a 404 erros <img width="1160" alt="iShot2022-10-06_15 54 50" src="https://user-images.github...
[ 0.04106111824512482, -0.10149192810058594, 0.0027760714292526245, 0.39377036690711975, 0.12849527597427368, 0.21601125597953796, 0.03236091509461403, 0.26079005002975464, 0.058052629232406616, 0.15013878047466278, -0.2736705541610718, 0.06521652638912201, -0.042442236095666885, -0.14198353...
https://github.com/huggingface/datasets/issues/5086
Thanks for reporting @km5ar and thank you @albertvillanova for the quick solution! I'll post a fix on the source too
HTTPError: 404 Client Error: Not Found for url
## Describe the bug I was following chap 5 from huggingface course: https://huggingface.co/course/chapter5/6?fw=tf However, I'm not able to download the datasets, with a 404 erros <img width="1160" alt="iShot2022-10-06_15 54 50" src="https://user-images.githubusercontent.com/54015474/194406327-ae62c2f3-1da5-...
20
HTTPError: 404 Client Error: Not Found for url ## Describe the bug I was following chap 5 from huggingface course: https://huggingface.co/course/chapter5/6?fw=tf However, I'm not able to download the datasets, with a 404 erros <img width="1160" alt="iShot2022-10-06_15 54 50" src="https://user-images.github...
[ 0.04595053195953369, -0.2297397255897522, -0.006929539144039154, 0.4549531042575836, 0.15103325247764587, 0.24672569334506989, 0.008113919757306576, 0.22636815905570984, 0.12358377873897552, 0.180573970079422, -0.3037809133529663, 0.021852433681488037, -0.06190662086009979, -0.082032181322...
https://github.com/huggingface/datasets/issues/5085
~~It seems like #5043 fix (merged recently) is the root cause of such behaviour. When we empty indices mapping (because the dataset length equals to zero), we can no longer get column item like: `ds_filter_2['sentence']` which uses `ds_filter_1._indices.column(0)`~~ **UPDATE:** Empty datasets are returned without ...
Filtering on an empty dataset returns a corrupted dataset.
## Describe the bug When filtering a dataset twice, where the first result is an empty dataset, the second dataset seems corrupted. ## Steps to reproduce the bug ```python datasets = load_dataset("glue", "sst2") dataset_split = datasets['validation'] ds_filter_1 = dataset_split.filter(lambda x: False) # ...
103
Filtering on an empty dataset returns a corrupted dataset. ## Describe the bug When filtering a dataset twice, where the first result is an empty dataset, the second dataset seems corrupted. ## Steps to reproduce the bug ```python datasets = load_dataset("glue", "sst2") dataset_split = datasets['validation...
[ -0.10343414545059204, -0.032650724053382874, -0.04013124108314514, 0.2233489453792572, 0.0536968819797039, 0.0005479976534843445, 0.4005722999572754, 0.42343083024024963, 0.11768108606338501, 0.0069408118724823, -0.11518234014511108, 0.22237616777420044, 0.08214183151721954, 0.079101510345...
https://github.com/huggingface/datasets/issues/5083
hii @lhoestq, can you assign this issue to me? Though i am new to open source still I would love to put my best foot forward. I can see there isn't anyone right now assigned to this issue.
Support numpy/torch/tf/jax formatting for IterableDataset
Right now `IterableDataset` doesn't do any formatting. In particular this code should return a numpy array: ```python from datasets import load_dataset ds = load_dataset("imagenet-1k", split="train", streaming=True).with_format("np") print(next(iter(ds))["image"]) ``` Right now it returns a PIL.Image. S...
38
Support numpy/torch/tf/jax formatting for IterableDataset Right now `IterableDataset` doesn't do any formatting. In particular this code should return a numpy array: ```python from datasets import load_dataset ds = load_dataset("imagenet-1k", split="train", streaming=True).with_format("np") print(next(iter(d...
[ -0.1601518988609314, -0.29652372002601624, -0.02709023840725422, -0.044058531522750854, 0.2904995083808899, -0.014094822108745575, 0.5831496119499207, 0.4664074778556824, -0.2450704574584961, -0.09684009104967117, -0.08783741295337677, 0.4100489914417267, -0.12891221046447754, 0.0897972285...
https://github.com/huggingface/datasets/issues/5083
Hi @zutarich ! This issue was fixed by #5852 - sorry I forgot to close it Feel free to look for other issues and ping me or @mariosasko if you have questions :) Also let us know if we can help find an issue that can correspond to what you're looking for
Support numpy/torch/tf/jax formatting for IterableDataset
Right now `IterableDataset` doesn't do any formatting. In particular this code should return a numpy array: ```python from datasets import load_dataset ds = load_dataset("imagenet-1k", split="train", streaming=True).with_format("np") print(next(iter(ds))["image"]) ``` Right now it returns a PIL.Image. S...
52
Support numpy/torch/tf/jax formatting for IterableDataset Right now `IterableDataset` doesn't do any formatting. In particular this code should return a numpy array: ```python from datasets import load_dataset ds = load_dataset("imagenet-1k", split="train", streaming=True).with_format("np") print(next(iter(d...
[ -0.2871100604534149, -0.2844577729701996, -0.08146311342716217, 0.03790128231048584, 0.32992592453956604, 0.054992035031318665, 0.5919590592384338, 0.42329853773117065, -0.13432016968727112, -0.030175834894180298, -0.1399732530117035, 0.3614839017391205, -0.17100802063941956, 0.07982943952...
https://github.com/huggingface/datasets/issues/5081
The dataset is sadly not really compatible to be loaded with `load_dataset`. So far it is better to git clone it and to use the files directly. A data loading script would be needed to be added to this dataset. But this was too much overhead / not really intuitive how to create it.
Bug loading `sentence-transformers/parallel-sentences`
## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/download/streaming_download_manager.py:697: FutureWarning: the '...
54
Bug loading `sentence-transformers/parallel-sentences` ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/downloa...
[ -0.006445273756980896, -0.3018946349620819, -0.07506994158029556, 0.1588546186685562, 0.19041438400745392, 0.014945924282073975, 0.5312551856040955, 0.17734773457050323, -0.1279134750366211, 0.1705007702112198, -0.0851421132683754, 0.37924695014953613, 0.0759560614824295, -0.50062328577041...
https://github.com/huggingface/datasets/issues/5081
Since the dataset is a bunch of TSVs we should not need a dataset script I think. By default it tries to load all the TSVs at once, which fails here because they don't all have the same columns (pd.read_csv uses the first line as header by default). But those files have no header ! So, to properly load any TSV file ...
Bug loading `sentence-transformers/parallel-sentences`
## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/download/streaming_download_manager.py:697: FutureWarning: the '...
118
Bug loading `sentence-transformers/parallel-sentences` ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/downloa...
[ -0.006445273756980896, -0.3018946349620819, -0.07506994158029556, 0.1588546186685562, 0.19041438400745392, 0.014945924282073975, 0.5312551856040955, 0.17734773457050323, -0.1279134750366211, 0.1705007702112198, -0.0851421132683754, 0.37924695014953613, 0.0759560614824295, -0.50062328577041...
https://github.com/huggingface/datasets/issues/5081
There are more issues in the dataset. To load OpenSubtitles I have to provide this (see `skiprows`): ```python df_os = pd.read_csv( "./parallel-sentences/OpenSubtitles/OpenSubtitles-en-de-train.tsv.gz", sep="\t", quoting=csv.QUOTE_NONE, header=None, names=["en", "de"], skiprows=[540...
Bug loading `sentence-transformers/parallel-sentences`
## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/download/streaming_download_manager.py:697: FutureWarning: the '...
39
Bug loading `sentence-transformers/parallel-sentences` ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/downloa...
[ -0.006445273756980896, -0.3018946349620819, -0.07506994158029556, 0.1588546186685562, 0.19041438400745392, 0.014945924282073975, 0.5312551856040955, 0.17734773457050323, -0.1279134750366211, 0.1705007702112198, -0.0851421132683754, 0.37924695014953613, 0.0759560614824295, -0.50062328577041...
https://github.com/huggingface/datasets/issues/5081
What's wrong with those lines exactly ? Maybe passing `error_bad_lines=False` (and maybe `warn_bad_lines=True`) can be helpful
Bug loading `sentence-transformers/parallel-sentences`
## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/download/streaming_download_manager.py:697: FutureWarning: the '...
16
Bug loading `sentence-transformers/parallel-sentences` ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/downloa...
[ -0.006445273756980896, -0.3018946349620819, -0.07506994158029556, 0.1588546186685562, 0.19041438400745392, 0.014945924282073975, 0.5312551856040955, 0.17734773457050323, -0.1279134750366211, 0.1705007702112198, -0.0851421132683754, 0.37924695014953613, 0.0759560614824295, -0.50062328577041...
https://github.com/huggingface/datasets/issues/5081
> What's wrong with those lines exactly ? Stuff like this: `ParserError: Error tokenizing data. C error: Expected 2 fields in line 540345, saw 3`
Bug loading `sentence-transformers/parallel-sentences`
## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/download/streaming_download_manager.py:697: FutureWarning: the '...
25
Bug loading `sentence-transformers/parallel-sentences` ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/downloa...
[ -0.006445273756980896, -0.3018946349620819, -0.07506994158029556, 0.1588546186685562, 0.19041438400745392, 0.014945924282073975, 0.5312551856040955, 0.17734773457050323, -0.1279134750366211, 0.1705007702112198, -0.0851421132683754, 0.37924695014953613, 0.0759560614824295, -0.50062328577041...
https://github.com/huggingface/datasets/issues/5081
> Maybe passing error_bad_lines=False (and maybe warn_bad_lines=True) can be helpful Yes. That would hide the issue but not solve it.
Bug loading `sentence-transformers/parallel-sentences`
## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/download/streaming_download_manager.py:697: FutureWarning: the '...
20
Bug loading `sentence-transformers/parallel-sentences` ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("sentence-transformers/parallel-sentences") ``` raises this: ``` /home/phmay/miniconda3/envs/paraphrase-mining/lib/python3.9/site-packages/datasets/downloa...
[ -0.006445273756980896, -0.3018946349620819, -0.07506994158029556, 0.1588546186685562, 0.19041438400745392, 0.014945924282073975, 0.5312551856040955, 0.17734773457050323, -0.1279134750366211, 0.1705007702112198, -0.0851421132683754, 0.37924695014953613, 0.0759560614824295, -0.50062328577041...
https://github.com/huggingface/datasets/issues/5074
Looks like the top-level `datasource` directory was removed when https://github.com/huggingface/datasets/pull/4974 was merged, so there are 3 source files to fix.
Replace AssertionErrors with more meaningful errors
Replace the AssertionErrors with more meaningful errors such as ValueError, TypeError, etc. The files with AssertionErrors that need to be replaced: ``` src/datasets/arrow_reader.py src/datasets/builder.py src/datasets/utils/version.py ```
20
Replace AssertionErrors with more meaningful errors Replace the AssertionErrors with more meaningful errors such as ValueError, TypeError, etc. The files with AssertionErrors that need to be replaced: ``` src/datasets/arrow_reader.py src/datasets/builder.py src/datasets/utils/version.py ``` Looks like the t...
[ -0.20892229676246643, -0.05266205966472626, -0.11660854518413544, 0.20085133612155914, 0.2864801585674286, 0.05914204567670822, 0.11856654286384583, 0.3406088650226593, -0.029903508722782135, 0.2285209447145462, -0.024910196661949158, 0.23046915233135223, -0.028467362746596336, 0.055955104...
https://github.com/huggingface/datasets/issues/5070
Thank you for creating this feature request, Albert. For context this is the datatest where Albert has been helping me to switch to on-the-fly split config https://huggingface.co/datasets/HuggingFaceM4/cm4-synthetic-testing and the attempt to switch on-the-fly splits was here: https://huggingface.co/datasets/Hugg...
Support default config name when no builder configs
**Is your feature request related to a problem? Please describe.** As discussed with @stas00, we could support defining a default config name, even if no predefined allowed config names are set. That is, support `DEFAULT_CONFIG_NAME`, even when `BUILDER_CONFIGS` is not defined. **Additional context** In order to ...
51
Support default config name when no builder configs **Is your feature request related to a problem? Please describe.** As discussed with @stas00, we could support defining a default config name, even if no predefined allowed config names are set. That is, support `DEFAULT_CONFIG_NAME`, even when `BUILDER_CONFIGS` is...
[ -0.3808918595314026, -0.5076113939285278, 0.10775356739759445, -0.2350175827741623, 0.14683575928211212, -0.03946521878242493, 0.29537054896354675, 0.22066807746887207, -0.009172577410936356, 0.674118161201477, 0.3586376905441284, 0.09719197452068329, -0.25373077392578125, 0.54542332887649...
https://github.com/huggingface/datasets/issues/5061
This is maybe related to python 3.10, do you think you could try on 3.8 ? In the meantime we'll keep improving the support for 3.10. Let me add a dedicated CI
`_pickle.PicklingError: logger cannot be pickled` in multiprocessing `map`
## Describe the bug When I `map` with multiple processes, this error occurs. The `.name` of the `logger` that fails to pickle in the final line is `datasets.fingerprint`. ``` File "~/project/dataset.py", line 204, in <dictcomp> split: dataset.map( File ".../site-packages/datasets/arrow_dataset.py", line 24...
32
`_pickle.PicklingError: logger cannot be pickled` in multiprocessing `map` ## Describe the bug When I `map` with multiple processes, this error occurs. The `.name` of the `logger` that fails to pickle in the final line is `datasets.fingerprint`. ``` File "~/project/dataset.py", line 204, in <dictcomp> split...
[ -0.17047849297523499, -0.24004444479942322, -0.04107757657766342, 0.1450410783290863, -0.08370199799537659, 0.0011461526155471802, 0.33660614490509033, 0.16821666061878204, 0.649385929107666, 0.16566845774650574, -0.035232678055763245, 0.612138569355011, -0.26885199546813965, 0.08796787261...
https://github.com/huggingface/datasets/issues/5061
I did some binary search and seems like the root cause is either `multiprocess` or `dill`. python 3.10 is fine. Specifically: - `multiprocess==0.70.12.2, dill==0.3.4`: works - `multiprocess==0.70.12.2, dill==0.3.5.1`: doesn't work - `multiprocess==0.70.13, dill==0.3.5.1`: doesn't work - `multiprocess==0.70.13, dill...
`_pickle.PicklingError: logger cannot be pickled` in multiprocessing `map`
## Describe the bug When I `map` with multiple processes, this error occurs. The `.name` of the `logger` that fails to pickle in the final line is `datasets.fingerprint`. ``` File "~/project/dataset.py", line 204, in <dictcomp> split: dataset.map( File ".../site-packages/datasets/arrow_dataset.py", line 24...
100
`_pickle.PicklingError: logger cannot be pickled` in multiprocessing `map` ## Describe the bug When I `map` with multiple processes, this error occurs. The `.name` of the `logger` that fails to pickle in the final line is `datasets.fingerprint`. ``` File "~/project/dataset.py", line 204, in <dictcomp> split...
[ -0.17047849297523499, -0.24004444479942322, -0.04107757657766342, 0.1450410783290863, -0.08370199799537659, 0.0011461526155471802, 0.33660614490509033, 0.16821666061878204, 0.649385929107666, 0.16566845774650574, -0.035232678055763245, 0.612138569355011, -0.26885199546813965, 0.08796787261...
https://github.com/huggingface/datasets/issues/5061
I'm not 100% sure how to figure it out -- the stack trace above doesn't clearly give me a place where I can print out who owns the logger, etc. I only found out its `.name` is `datasets.fingerprint` by printing right before ``` File ".../logging/__init__.py", line 1774, in __reduce__ raise pickle.PicklingError...
`_pickle.PicklingError: logger cannot be pickled` in multiprocessing `map`
## Describe the bug When I `map` with multiple processes, this error occurs. The `.name` of the `logger` that fails to pickle in the final line is `datasets.fingerprint`. ``` File "~/project/dataset.py", line 204, in <dictcomp> split: dataset.map( File ".../site-packages/datasets/arrow_dataset.py", line 24...
70
`_pickle.PicklingError: logger cannot be pickled` in multiprocessing `map` ## Describe the bug When I `map` with multiple processes, this error occurs. The `.name` of the `logger` that fails to pickle in the final line is `datasets.fingerprint`. ``` File "~/project/dataset.py", line 204, in <dictcomp> split...
[ -0.17047849297523499, -0.24004444479942322, -0.04107757657766342, 0.1450410783290863, -0.08370199799537659, 0.0011461526155471802, 0.33660614490509033, 0.16821666061878204, 0.649385929107666, 0.16566845774650574, -0.035232678055763245, 0.612138569355011, -0.26885199546813965, 0.08796787261...
https://github.com/huggingface/datasets/issues/5061
Ok I see, not sure why it triggers this error though, in `logging.py` the code is https://github.com/python/cpython/blob/c9da063e32725a66495e4047b8a5ed13e72d9e8e/Lib/logging/__init__.py#L1769-L1775 and on my side it works on 3.10 with dill 0.3.5.1 and multiprocess 0.70.13 ```python >>> datasets.fingerprint.logg...
`_pickle.PicklingError: logger cannot be pickled` in multiprocessing `map`
## Describe the bug When I `map` with multiple processes, this error occurs. The `.name` of the `logger` that fails to pickle in the final line is `datasets.fingerprint`. ``` File "~/project/dataset.py", line 204, in <dictcomp> split: dataset.map( File ".../site-packages/datasets/arrow_dataset.py", line 24...
71
`_pickle.PicklingError: logger cannot be pickled` in multiprocessing `map` ## Describe the bug When I `map` with multiple processes, this error occurs. The `.name` of the `logger` that fails to pickle in the final line is `datasets.fingerprint`. ``` File "~/project/dataset.py", line 204, in <dictcomp> split...
[ -0.17047849297523499, -0.24004444479942322, -0.04107757657766342, 0.1450410783290863, -0.08370199799537659, 0.0011461526155471802, 0.33660614490509033, 0.16821666061878204, 0.649385929107666, 0.16566845774650574, -0.035232678055763245, 0.612138569355011, -0.26885199546813965, 0.08796787261...
https://github.com/huggingface/datasets/issues/5060
Hi ! I opened a PR in your repo to fix this :) https://huggingface.co/datasets/zpn/pubchem_selfies/discussions/7 basically you need to use `open` for streaming to work properly
Unable to Use Custom Dataset Locally
## Describe the bug I have uploaded a [dataset](https://huggingface.co/datasets/zpn/pubchem_selfies) and followed the instructions from the [dataset_loader](https://huggingface.co/docs/datasets/dataset_script#download-data-files-and-organize-splits) tutorial. In that tutorial, it says ``` If the data files live in ...
25
Unable to Use Custom Dataset Locally ## Describe the bug I have uploaded a [dataset](https://huggingface.co/datasets/zpn/pubchem_selfies) and followed the instructions from the [dataset_loader](https://huggingface.co/docs/datasets/dataset_script#download-data-files-and-organize-splits) tutorial. In that tutorial, it...
[ -0.14774182438850403, 0.22815251350402832, 0.11311464756727219, 0.2891528606414795, 0.18403849005699158, 0.0391501784324646, 0.3222103714942932, 0.10394845902919769, 0.1223008781671524, 0.010489962995052338, -0.20797930657863617, 0.343542218208313, -0.08664320409297943, 0.03940447419881821...
https://github.com/huggingface/datasets/issues/5060
Thank you so much for this! Naive question, is this a feature of `open` or have you all overloaded it to be able to read from a URL? Any links to code/documentation would be greatly appreciated, I'd love to learn more
Unable to Use Custom Dataset Locally
## Describe the bug I have uploaded a [dataset](https://huggingface.co/datasets/zpn/pubchem_selfies) and followed the instructions from the [dataset_loader](https://huggingface.co/docs/datasets/dataset_script#download-data-files-and-organize-splits) tutorial. In that tutorial, it says ``` If the data files live in ...
41
Unable to Use Custom Dataset Locally ## Describe the bug I have uploaded a [dataset](https://huggingface.co/datasets/zpn/pubchem_selfies) and followed the instructions from the [dataset_loader](https://huggingface.co/docs/datasets/dataset_script#download-data-files-and-organize-splits) tutorial. In that tutorial, it...
[ -0.14774182438850403, 0.22815251350402832, 0.11311464756727219, 0.2891528606414795, 0.18403849005699158, 0.0391501784324646, 0.3222103714942932, 0.10394845902919769, 0.1223008781671524, 0.010489962995052338, -0.20797930657863617, 0.343542218208313, -0.08664320409297943, 0.03940447419881821...
https://github.com/huggingface/datasets/issues/5060
`datasets` extends `open` in dataset scripts to work with URLs. The builtin `open` from python only works with local files. You can find the extension here: https://github.com/huggingface/datasets/blob/6ad430ba0cdeeb601170f732d4bd977f5c04594d/src/datasets/download/streaming_download_manager.py#L435-L451 I think w...
Unable to Use Custom Dataset Locally
## Describe the bug I have uploaded a [dataset](https://huggingface.co/datasets/zpn/pubchem_selfies) and followed the instructions from the [dataset_loader](https://huggingface.co/docs/datasets/dataset_script#download-data-files-and-organize-splits) tutorial. In that tutorial, it says ``` If the data files live in ...
43
Unable to Use Custom Dataset Locally ## Describe the bug I have uploaded a [dataset](https://huggingface.co/datasets/zpn/pubchem_selfies) and followed the instructions from the [dataset_loader](https://huggingface.co/docs/datasets/dataset_script#download-data-files-and-organize-splits) tutorial. In that tutorial, it...
[ -0.14774182438850403, 0.22815251350402832, 0.11311464756727219, 0.2891528606414795, 0.18403849005699158, 0.0391501784324646, 0.3222103714942932, 0.10394845902919769, 0.1223008781671524, 0.010489962995052338, -0.20797930657863617, 0.343542218208313, -0.08664320409297943, 0.03940447419881821...
https://github.com/huggingface/datasets/issues/5053
Maybe #2838 can help. In this PR we allow to skip bad chunks of JSON data to not crash the training Did you have warning messages before the error ? something like this maybe ? ``` 03/24/2022 02:19:46 - WARNING - datasets.utils.streaming_download_manager - Got disconnected from remote data host. Retrying in 5se...
Intermittent JSON parse error when streaming the Pile
## Describe the bug I have an intermittent error when streaming the Pile, where I get a JSON parse error which causes my program to crash. This is intermittent - when I rerun the program with the same random seed it does not crash in the same way. The exact point this happens also varied - it happened to me 11B tok...
95
Intermittent JSON parse error when streaming the Pile ## Describe the bug I have an intermittent error when streaming the Pile, where I get a JSON parse error which causes my program to crash. This is intermittent - when I rerun the program with the same random seed it does not crash in the same way. The exact po...
[ -0.25615596771240234, 0.08614325523376465, 0.10274148732423782, 0.35110101103782654, 0.23096983134746552, -0.037778764963150024, 0.19184662401676178, 0.4205733835697174, -0.28757524490356445, 0.12985315918922424, 0.32849055528640747, 0.3421487510204315, 0.023091237992048264, -0.18281874060...
https://github.com/huggingface/datasets/issues/5053
Ah, thanks! I did get errors like that. Sad that PR wasn't merged in! I'm currently just downloading 200GB of the Pile locally to avoid streaming (I have space and it's faster anyway), but that's really useful! I can probably apply the dumb patch of just commenting out the bits that raise the JSON Parse Error lol, ...
Intermittent JSON parse error when streaming the Pile
## Describe the bug I have an intermittent error when streaming the Pile, where I get a JSON parse error which causes my program to crash. This is intermittent - when I rerun the program with the same random seed it does not crash in the same way. The exact point this happens also varied - it happened to me 11B tok...
71
Intermittent JSON parse error when streaming the Pile ## Describe the bug I have an intermittent error when streaming the Pile, where I get a JSON parse error which causes my program to crash. This is intermittent - when I rerun the program with the same random seed it does not crash in the same way. The exact po...
[ -0.25615596771240234, 0.08614325523376465, 0.10274148732423782, 0.35110101103782654, 0.23096983134746552, -0.037778764963150024, 0.19184662401676178, 0.4205733835697174, -0.28757524490356445, 0.12985315918922424, 0.32849055528640747, 0.3421487510204315, 0.023091237992048264, -0.18281874060...
https://github.com/huggingface/datasets/issues/5053
Yup you can get some inspiration from this PR. It simply ignores the bad chunks (a chunk is ~a few MBs of data). We'll try to merge this PR soon
Intermittent JSON parse error when streaming the Pile
## Describe the bug I have an intermittent error when streaming the Pile, where I get a JSON parse error which causes my program to crash. This is intermittent - when I rerun the program with the same random seed it does not crash in the same way. The exact point this happens also varied - it happened to me 11B tok...
30
Intermittent JSON parse error when streaming the Pile ## Describe the bug I have an intermittent error when streaming the Pile, where I get a JSON parse error which causes my program to crash. This is intermittent - when I rerun the program with the same random seed it does not crash in the same way. The exact po...
[ -0.25615596771240234, 0.08614325523376465, 0.10274148732423782, 0.35110101103782654, 0.23096983134746552, -0.037778764963150024, 0.19184662401676178, 0.4205733835697174, -0.28757524490356445, 0.12985315918922424, 0.32849055528640747, 0.3421487510204315, 0.023091237992048264, -0.18281874060...
https://github.com/huggingface/datasets/issues/5046
Hi! Unfortunately, I can't reproduce this behavior. Instead, I get `ValueError: audio at 2063_fe9936e7-62b2-4e62-a276-acbd344480ce_1.wav doesn't have metadata in /audio-data/metadata.csv`, which can be fixed by removing the `./` from the file name. (Link to a Colab that tries to reproduce this behavior: https://cola...
Audiofolder creates empty Dataset if files same level as metadata
## Describe the bug When audio files are at the same level as the metadata (`metadata.csv` or `metadata.jsonl` ), the `load_dataset` returns a `DatasetDict` with no rows but the correct columns. https://github.com/huggingface/datasets/blob/1ea4d091b7a4b83a85b2eeb8df65115d39af3766/docs/source/audio_dataset.mdx?plain...
42
Audiofolder creates empty Dataset if files same level as metadata ## Describe the bug When audio files are at the same level as the metadata (`metadata.csv` or `metadata.jsonl` ), the `load_dataset` returns a `DatasetDict` with no rows but the correct columns. https://github.com/huggingface/datasets/blob/1ea4d091...
[ -0.04184475913643837, 0.18840759992599487, -0.012081895023584366, 0.5899378061294556, 0.19426459074020386, 0.05188995599746704, 0.3689002990722656, 0.27233168482780457, 0.009523093700408936, 0.28956669569015503, -0.08250947296619415, 0.33010637760162354, -0.4205986261367798, 0.118906296789...
https://github.com/huggingface/datasets/issues/5046
I think we can make the file name matching part more robust by replacing `file_name` with `os.path.normpath(file_name)`, to ignore "./" among other things, in these two places: * https://github.com/huggingface/datasets/blob/85cd129bde605cd9acacdff0d065fc02e39e09b1/src/datasets/packaged_modules/folder_based_builder/fol...
Audiofolder creates empty Dataset if files same level as metadata
## Describe the bug When audio files are at the same level as the metadata (`metadata.csv` or `metadata.jsonl` ), the `load_dataset` returns a `DatasetDict` with no rows but the correct columns. https://github.com/huggingface/datasets/blob/1ea4d091b7a4b83a85b2eeb8df65115d39af3766/docs/source/audio_dataset.mdx?plain...
31
Audiofolder creates empty Dataset if files same level as metadata ## Describe the bug When audio files are at the same level as the metadata (`metadata.csv` or `metadata.jsonl` ), the `load_dataset` returns a `DatasetDict` with no rows but the correct columns. https://github.com/huggingface/datasets/blob/1ea4d091...
[ -0.04184475913643837, 0.18840759992599487, -0.012081895023584366, 0.5899378061294556, 0.19426459074020386, 0.05188995599746704, 0.3689002990722656, 0.27233168482780457, 0.009523093700408936, 0.28956669569015503, -0.08250947296619415, 0.33010637760162354, -0.4205986261367798, 0.118906296789...
https://github.com/huggingface/datasets/issues/5046
I realized what I was doing wrong. The documentation puts the files in a subfolder. Once I have done that, it worked. But l agree that this should be handled better if possible.
Audiofolder creates empty Dataset if files same level as metadata
## Describe the bug When audio files are at the same level as the metadata (`metadata.csv` or `metadata.jsonl` ), the `load_dataset` returns a `DatasetDict` with no rows but the correct columns. https://github.com/huggingface/datasets/blob/1ea4d091b7a4b83a85b2eeb8df65115d39af3766/docs/source/audio_dataset.mdx?plain...
33
Audiofolder creates empty Dataset if files same level as metadata ## Describe the bug When audio files are at the same level as the metadata (`metadata.csv` or `metadata.jsonl` ), the `load_dataset` returns a `DatasetDict` with no rows but the correct columns. https://github.com/huggingface/datasets/blob/1ea4d091...
[ -0.04184475913643837, 0.18840759992599487, -0.012081895023584366, 0.5899378061294556, 0.19426459074020386, 0.05188995599746704, 0.3689002990722656, 0.27233168482780457, 0.009523093700408936, 0.28956669569015503, -0.08250947296619415, 0.33010637760162354, -0.4205986261367798, 0.118906296789...
https://github.com/huggingface/datasets/issues/5045
Could you share the error you got please ? Maybe the full stack trace if you have it ? Maybe `push_to_hub` be implemented as a single commit @Wauplin ? This way if it fails, the repo is still at the previous (valid) state instead of ending-up in an invalid/incimplete state.
Automatically revert to last successful commit to hub when a push_to_hub is interrupted
**Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the dataset to raise an error on load_dataset() (ValueError couldn’t cast … because column names do...
50
Automatically revert to last successful commit to hub when a push_to_hub is interrupted **Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the datas...
[ -0.5574368834495544, -0.14015501737594604, -0.025222811847925186, -0.3282569348812103, 0.12634921073913574, -0.21481458842754364, -0.02843863144516945, 0.3787877857685089, 0.024059921503067017, 0.3719666600227356, 0.359006404876709, 0.22657270729541779, -0.01069505326449871, 0.234880059957...
https://github.com/huggingface/datasets/issues/5045
> Maybe push_to_hub be implemented as a single commit ? I think that would definitely be the way to go. Do you know the reasons why not implementing it like this in the first place ? I guess it is because of not been able to upload all at once with `huggingface_hub` but if there was another reason, please let me kn...
Automatically revert to last successful commit to hub when a push_to_hub is interrupted
**Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the dataset to raise an error on load_dataset() (ValueError couldn’t cast … because column names do...
125
Automatically revert to last successful commit to hub when a push_to_hub is interrupted **Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the datas...
[ -0.3658260107040405, -0.4249005615711212, -0.0063219256699085236, -0.21672150492668152, 0.08757197856903076, -0.3276034891605377, 0.049897920340299606, 0.30589601397514343, 0.10879592597484589, 0.41265782713890076, 0.29710260033607483, 0.06020911782979965, -0.16505074501037598, 0.414782702...
https://github.com/huggingface/datasets/issues/5045
> I think that would definitely be the way to go. Do you know the reasons why not implementing it like this in the first place ? I guess it is because of not been able to upload all at once with huggingface_hub but if there was another reason, please let me know. Ideally we would want to upload the files iteratively...
Automatically revert to last successful commit to hub when a push_to_hub is interrupted
**Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the dataset to raise an error on load_dataset() (ValueError couldn’t cast … because column names do...
147
Automatically revert to last successful commit to hub when a push_to_hub is interrupted **Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the datas...
[ -0.5348614454269409, -0.31370633840560913, 0.03873644024133682, -0.25577041506767273, 0.015381453558802605, -0.3755168616771698, 0.0838247686624527, 0.31598687171936035, -0.018812429159879684, 0.42596086859703064, 0.34442999958992004, 0.11366379261016846, -0.08638134598731995, 0.3823524713...
https://github.com/huggingface/datasets/issues/5045
> Ideally we would want to upload the files iteratively - and then once everything is uploaded we proceed to commit. Oh I see. So maybe this has to be done in an implementation specific to `datasets/` as it is not a very common case (upload a bunch of files on the fly). You can maybe have a look at how `huggingf...
Automatically revert to last successful commit to hub when a push_to_hub is interrupted
**Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the dataset to raise an error on load_dataset() (ValueError couldn’t cast … because column names do...
162
Automatically revert to last successful commit to hub when a push_to_hub is interrupted **Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the datas...
[ -0.5546009540557861, -0.16547518968582153, 0.006455734372138977, -0.14277000725269318, 0.022968586534261703, -0.2583605647087097, 0.0675445944070816, 0.32462069392204285, 0.07754328846931458, 0.29907190799713135, 0.24885307252407074, 0.17172124981880188, -0.17607903480529785, 0.24146264791...
https://github.com/huggingface/datasets/issues/5045
> Could you share the error you got please ? Maybe the full stack trace if you have it ? Here’s part of the stack trace, that I can reproduce at the moment from a photo I took (potential typos from OCR): ``` ValueError Traceback (most recent call last) <ipython-input-4-274613b7d3f5> in <module> from datasets im...
Automatically revert to last successful commit to hub when a push_to_hub is interrupted
**Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the dataset to raise an error on load_dataset() (ValueError couldn’t cast … because column names do...
155
Automatically revert to last successful commit to hub when a push_to_hub is interrupted **Is your feature request related to a problem? Please describe.** I pushed a modification of a large dataset (remove a column) to the hub. The push was interrupted after some files were committed to the repo. This left the datas...
[ -0.48917582631111145, -0.2021462619304657, 0.027005955576896667, -0.23982323706150055, 0.19127070903778076, -0.202187180519104, 0.07046365737915039, 0.403494268655777, 0.09972301125526428, 0.3640478849411011, 0.24140533804893494, 0.25706803798675537, -0.06661667674779892, 0.127149239182472...
https://github.com/huggingface/datasets/issues/5044
I agree the situation is not ideal and it would be awesome to use `load_dataset` to reload a dataset saved locally ! For context: - `load_dataset` works in three steps: download the dataset, then prepare it as an arrow dataset, and finally return a memory mapped arrow dataset. In particular it creates a cache dir...
integrate `load_from_disk` into `load_dataset`
**Is your feature request related to a problem? Please describe.** Is it possible to make `load_dataset` more universal similar to `from_pretrained` in `transformers` so that it can handle the hub, and the local path datasets of all supported types? Currently one has to choose a different loader depending on how ...
154
integrate `load_from_disk` into `load_dataset` **Is your feature request related to a problem? Please describe.** Is it possible to make `load_dataset` more universal similar to `from_pretrained` in `transformers` so that it can handle the hub, and the local path datasets of all supported types? Currently one ...
[ -0.44635629653930664, -0.25477927923202515, 0.010255582630634308, 0.2019413411617279, 0.2771255671977997, -0.0641511082649231, 0.34563830494880676, 0.05371476709842682, 0.18767520785331726, 0.003259710967540741, -0.12002961337566376, 0.4315915107727051, -0.21891234815120697, 0.365950495004...
https://github.com/huggingface/datasets/issues/5044
Thank you for the detailed breakdown, @lhoestq > I'm curious, what would you expect to happen in this situation ? 1. the simplest solution is to add a flag to the dataset saved by `save_to_disk` and have `load_dataset` check that flag - if it's set simply switch control to `load_from_disk` behind the scenes. So ...
integrate `load_from_disk` into `load_dataset`
**Is your feature request related to a problem? Please describe.** Is it possible to make `load_dataset` more universal similar to `from_pretrained` in `transformers` so that it can handle the hub, and the local path datasets of all supported types? Currently one has to choose a different loader depending on how ...
257
integrate `load_from_disk` into `load_dataset` **Is your feature request related to a problem? Please describe.** Is it possible to make `load_dataset` more universal similar to `from_pretrained` in `transformers` so that it can handle the hub, and the local path datasets of all supported types? Currently one ...
[ -0.44635629653930664, -0.25477927923202515, 0.010255582630634308, 0.2019413411617279, 0.2771255671977997, -0.0641511082649231, 0.34563830494880676, 0.05371476709842682, 0.18767520785331726, 0.003259710967540741, -0.12002961337566376, 0.4315915107727051, -0.21891234815120697, 0.365950495004...