language
string
code-snippit
string
instruction
string
flaws
list
flaw_count
int64
python
} thumbnail2x3 { ...ImageDetails } thumbnail16x9WithTitle { ...ImageDetails } thumbnail2x3WithTitle { ...ImageDetails } } fragment ImageDetails on AssetImage { id ...
Review this code and list any quality issues.
[ { "issue": "use `_search_json()`\r\n```suggestion\r\n settings = self._search_json(r'var\\s+SETTINGS\\s*=', login_page, 'settings', None)\r\n```", "severity": "minor", "line": 26 } ]
1
python
# Basic check if len(diagonals) != len(offsets): raise ValueError("Different number of diagonals and offsets.") # Determine shape, if omitted if shape is None: m = len(diagonals[0]) + abs(int(offsets[0])) shape = (m, m) # Determine data type, if omitted if dtype is None: ...
Review this code and list any quality issues.
[ { "issue": "Ah, this is a nice cleanup indeed.", "severity": "minor", "line": 26 } ]
1
python
import asyncio # % if cookiecutter.http_client == 'curl-impersonate' and 'playwright' not in cookiecutter.crawler_type import platform # % endif {{ '' }} from .main import main if __name__ == '__main__': # % if cookiecutter.http_client == 'curl-impersonate' and 'playwright' not in cookiecutter.crawler_type if ...
Review this code and list any quality issues.
[ { "issue": "[nitpick] The original guidance explaining how to remove this policy if not using curl-impersonate was removed—consider re-adding a brief note for users who may not need this workaround.", "severity": "major", "line": 14 } ]
1
python
"id": [1, 2, 3], "name": ["Alice", "Bob", "Charlie"], "age": [30, 25, 35], }) await self.table_provider.write_dataframe("users", df) result = await self.table_provider.read_dataframe("users") pd.testing.assert_frame_equal(result, df) async def test_read_non...
Review this code and list any quality issues.
[]
0
python
}] _NOA_STATION_IDS = {'r1': 'n1', 'r2': 'n2', 'fm': 'n3'} # lookup table is easier than working it out def _real_extract(self, url): station = self._match_id(url) area = traverse_obj(self._configuration_arg('area'), 0) or "tokyo" config = self._download_xml('https://www.nhk.or.jp/ra...
Review this code and list any quality issues.
[ { "issue": "we can simplify `title` extraction with a single traversal instead, and eliminate the need for the `service` var\r\n```suggestion\r\n\r\n return {\r\n 'title': ' '.join(traverse_obj(present_info, (('service', 'area',), 'name', {str}))),\r\n 'id': join_nonempty(station, a...
1
python
video_id = urllib.parse.unquote(self._match_id(url)) webpage = self._download_webpage(url, video_id) json = self._search_json(r'window\.ltvEmbedPayload\s*=', webpage, 'embed json', video_id) embed_type = traverse_obj(json, ('source', 'name')) embed_data = {} if embed_type == '...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n **traverse_obj(json, {\r\n 'title': ('parentInfo', 'title'),\r\n 'duration': ('parentInfo', 'duration', {int_or_none}),\r\n 'thumbnail': ('source', 'poster', {url_or_none}),\r\n }),\r\n```", "severity": "minor",...
1
python
comment=None, comment_url=None, rest={}) jar.set_cookie(cookie) logger.info(f'Extracted {len(jar)} cookies from firefox') return jar finally: if cursor is not None: cursor.connection.close() def _firefox_browser_dir(): if sys.platform...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n if sys.platform in ('win32', 'cygwin'):\r\n```", "severity": "minor", "line": 26 } ]
1
python
should think of all other mobjects on the screen as moving Returns ------- list """ return [self.frame] def auto_zoom(self, mobjects, margin=0, only_mobjects_in_frame=False): """Zooms on to a given array of mobjects (or a singular mobject) and automatically resizes ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n Returns an animation that zooms the camera view to a given\r\n list of mobjects.\r\n```", "severity": "minor", "line": 26 } ]
1
python
logger.warning("Attention backends are an experimental feature and the API may be subject to change.") attention_classes = (Attention, MochiAttention, AttentionModuleMixin) parallel_config_set = False for module in self.modules(): if not isinstance(module, attention_classes): ...
Review this code and list any quality issues.
[ { "issue": "Since this change allows `set_attention_backend` and `enable_paralleism` to be invoked in any order, I think we can adjust the error message slightly. \n\n```suggestion\n f\"Context parallelism is enabled but current attention backend '{backend.value}' \"\n f\"does not...
1
python
def get_cpu_codename(default="Unknown"): """Return the CPU codename.""" cpu_model = get_cpu_model_name() vendor = get_cpu_vendor() if vendor == CpuVendor.INTEL: result = re.match(r"^(.*) @.*$", cpu_model) if result: return CPU_DICT[CpuVendor.INTEL].get(result.group(1), defaul...
Review this code and list any quality issues.
[]
0
python
yt1 -= d xt2, yt2 = xt1 + w, yt1 + h projected_xs.extend([xt1, xt2]) projected_ys.extend([yt1, yt2]) xt_box, yt_box = min(projected_xs), min(projected_ys) w_box, h_box = max(projected_xs) - xt_box, max(projected_ys) - yt_box x_box, y_box = Affine2D().rotate(theta).transform((xt_bo...
Review this code and list any quality issues.
[ { "issue": "Do you actually need to explicitly create a weakref here? Doesn't using a WeakKeyDictionary basically do this for you for free already (i.e. aren't you having two layers of weakref'ing here?)? (not sure...)", "severity": "minor", "line": 26 } ]
1
python
X = check_array( X, accept_sparse="csc", dtype=[np.float64, np.float32], order="F", copy=copy_X, ) y = check_array( y, accept_sparse="csc", dtype=X.dtype.type, order="F", copy=False, ...
Review this code and list any quality issues.
[ { "issue": "Can't we call _pre_fit or some other function here instead of replicating its logic?", "severity": "minor", "line": 26 } ]
1
python
Currently, LocalFileSystem and MockFileSystem support only single file copying but S3Client copies either a file or a directory as required. """ raise NotImplementedError("copy() not implemented on {0}". format(self.__class__.__name__)) class FileSystemTarget(...
Review this code and list any quality issues.
[ { "issue": "This kind of docs will try to execute (and verify that you get `False`). Hence why Travis turns red. Please change the doc style to the non executing or make it side effect free.\r\n\r\nThen we can merge this. :)", "severity": "minor", "line": 26 } ]
1
python
# Copyright 2021-2024 Avaiga Private Limited # # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with # the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agree...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\ndef key_pressed(state, id, payload):\r\n```", "severity": "minor", "line": 24 } ]
1
python
test_case = [ { "hidden_size": hidden_size, "num_heads": num_heads, "dropout_rate": dropout_rate, "rel_pos_embedding": rel_pos_embedding, "input_size": inpu...
Review this code and list any quality issues.
[ { "issue": "The alternative to this duplicate code is to add a `use_flash_attention` value to the `input_param` dictionary constructed above in the nested for-loop.", "severity": "major", "line": 26 } ]
1
python
---------- vertices : (N, 2) array-like The path vertices, as an array, masked array or sequence of pairs. Masked values, if any, will be converted to NaNs, which are then handled correctly by the Agg PathIterator and other consumers of path data, such as :meth:`i...
Review this code and list any quality issues.
[ { "issue": "I would rather try to improve the performace of check_shape globally, rather than going back to inlined checks. e.g. currently, I find that check_shape is ~10x slower than the fully inlined code, but the following\n```python\nimport functools, itertools, operator\n\n@functools.cache\ndef check_shap...
1
python
# Copyright (c) ONNX Project Contributors # # SPDX-License-Identifier: Apache-2.0 from __future__ import annotations import numpy as np import onnx from onnx.backend.test.case.base import Base from onnx.backend.test.case.node import expect class LpNormalization(Base): @staticmethod def export_l2normalizatio...
Review this code and list any quality issues.
[ { "issue": "Would it be a good idea to also test 1d input?", "severity": "minor", "line": 19 } ]
1
python
key = "qkv_weight" qkv_w = state_dict[prefix + "W_pack.weight"] in_features = qkv_w.size(1) out_features = qkv_w.size(0) // 3 qkv_w.data = qkv_w.view((3, out_features, -1)).transpose(0, 1).reshape(out_features, in_features * 3) device_mesh = self.helper_layout.device_mesh ...
Review this code and list any quality issues.
[]
0
python
crop_vision_frame = numpy.expand_dims(crop_vision_frame.transpose(2, 0, 1), axis = 0).astype(numpy.float32) if model_type == 'wav2lip': crop_vision_frame = numpy.expand_dims(crop_vision_frame, axis = 0) prepare_vision_frame = crop_vision_frame.copy() prepare_vision_frame[:, model_size[0] // 2:] = 0 crop_visio...
Review this code and list any quality issues.
[ { "issue": "Should we rename this to VisionMask?", "severity": "minor", "line": 26 } ]
1
python
_item_transformed = self._pre_transform(deepcopy(item_transformed)) # keep the original hashed if hashfile is None: return _item_transformed if isinstance(_item_transformed, dict): for k in _item_transformed: data_hashfile = f"{hashfile}-{k}" meta...
Review this code and list any quality issues.
[ { "issue": "this meta dictionary doesn't take much space, how about storing it with `self._meta_cache[\"meta_hash_file_name\"] = copy(data.meta)`?", "severity": "major", "line": 26 } ]
1
python
@property def properties(self): self._properties = _Reloader()._reload(self._MANAGER_NAME, self)._properties return self._properties @property def creation_date(self): return self._creation_date def get_label(self) -> str: """Returns the submission simple label prefixed...
Review this code and list any quality issues.
[]
0
python
s = sc.scale_[:, np.newaxis] * s * sc.scale_[np.newaxis, :] self.covariance_ = s rng = np.random.RandomState(global_random_seed) X = rng.rand(100, 10) y = rng.randint(3, size=(100,)) c1 = QuadraticDiscriminantAnalysis( store_covariance=True, shrinkage="auto", solver="eigen" ) ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n centers=n_classes,\r\n cluster_std=[1.0, 3.0],\r\n```\r\n\r\nto make the test more interesting for a QDA model.", "severity": "minor", "line": 26 } ]
1
python
'info_dict': { 'id': 'eyBd9aj', 'ext': 'mp4', 'title': '1. Farlig kryssning', 'timestamp': 1491019200, 'upload_date': '20170401', 'duration': 2566, 'thumbnail': r're:^https?://(?:.*[\.-]jpg|www.svtstatic.se/image/.*)$', 'age...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n 'skip_download': 'm3u8',\r\n```\r\n\r\nThis is a known issue affecting many IEs. Extra comment isnt needed", "severity": "minor", "line": 26 } ]
1
python
assert result == filters def test_dict_filters_roundtrip_json(): """AgentResponse with dict filters must survive Pydantic JSON serialization.""" resp = _make_response({"user_id": "jordan_mitchell"}) dumped = json.loads(resp.model_dump_json()) assert dumped["knowledge"]["knowledge_filters"] == {"user_i...
Review this code and list any quality issues.
[]
0
python
with open(archive, 'wb') as output: writer = WARCWriter(output, gzip=True) # Create a WARC info record to store metadata about the archive. warcinfo_payload = { 'software': 'Crawlee', 'format': 'WARC/1.1', 'description': 'Example archive created with Playwrig...
Review this code and list any quality issues.
[ { "issue": "Maybe specify explicitly that we want to enqueue links only from the same domain?", "severity": "minor", "line": 26 } ]
1
python
'tags': ['Atomenergie', 'Endlager', 'hoch-radioaktiver Abfall', 'Endlagersuche', 'Atommüll', 'Atomendlager', 'Gorleben', 'Deutschland'], 'thumbnail': 'https://www.bpb.de/cache/images/3/315813_teaser_16x9_1240.png?92A94', 'title': 'Folge 1: Eine Einführung', 'uploader': 'Bundeszentral...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n _TITLE_RE = re.compile('(?P<title>[^<]*)<[^>]+>(?P<series>[^<]*)')\r\n```", "severity": "minor", "line": 26 } ]
1
python
# See the License for the specific language governing permissions and # limitations under the License. import copy import inspect import time from dataclasses import fields from datetime import datetime from typing import Any, Callable, Optional, Union from oumi.builders.inference_engines import build_inference_engin...
Review this code and list any quality issues.
[ { "issue": "should we make this constant private by pre-pending `_` ? (reduces API surface)", "severity": "minor", "line": 26 } ]
1
python
def __init__(self, func: Callable[[DataFrame], Any], repr_str: str) -> None: self._func = func self._repr_str = repr_str def __call__(self, df: DataFrame) -> Any: return self._func(df) def _with_binary_op(self, op: str, other: Any) -> Expression: op_symbol = _OP_SYMBOLS.get(op,...
Review this code and list any quality issues.
[ { "issue": "Would it make sense for `Expression._with_op` to accept an `other_repr: str` argument so we don't need to do more repr manipulation here?", "severity": "minor", "line": 26 } ]
1
python
def __init__( self, path: Union[str, PathLike], code: Union[str, PathLike], entry: str, data: dict, **kwargs, ): # flow.dag.yaml file path or entry.py file path path = Path(path) # flow.dag.yaml file's folder or entry.py's folder code =...
Review this code and list any quality issues.
[ { "issue": "Please avoid adding public properties for public entities unless necessary cc @wangchao1230", "severity": "minor", "line": 26 } ]
1
python
thumbnail16x9 { ...ImageDetails } thumbnail2x3 { ...ImageDetails } thumbnail16x9WithTitle { ...ImageDetails } thumbnail2x3WithTitle { ...ImageDetails } } fr...
Review this code and list any quality issues.
[ { "issue": "- line too long\r\n- use the `query` param of `_download_webpage()`\r\n- single quotes", "severity": "major", "line": 26 } ]
1
python
#!/usr/bin/env python3 import subprocess import sys def run_tests_with_threshold(self_test_exe, threshold): cmd = [self_test_exe, '--min-duration', str(threshold), '[min_duration_test]'] process = subprocess.Popen( cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE) stdout, stderr...
Review this code and list any quality issues.
[]
0
python
import re from .common import InfoExtractor from ..utils import ( encode_base_n, ExtractorError, int_or_none, merge_dicts, parse_duration, str_to_int, url_or_none, get_elements_by_class, join_nonempty ) class EpornerIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?eporner\....
Review this code and list any quality issues.
[ { "issue": "add a trailing comma and isort this", "severity": "minor", "line": 12 } ]
1
python
[ 1. , 49. ], [ 1. , 72.25]]) We want to find the least-squares solution to ``M.dot(p) = y``, where ``p`` is a vector with length 2 that holds the parameters ``a`` and ``b``. >>> p, res, rnk, s = lstsq(M, y) >>> p array([ 0.20925829, 0.12013861]) Plot the data and the f...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n models: a quadratic model above, and one with an additional linear term,\r\n```", "severity": "minor", "line": 26 } ]
1
python
bf.write(b[b2_start:b3_start]) # The reindexing code should detect and accommodate out of order blocks. with self.nodes[0].assert_debug_log([ 'LoadExternalBlockFile: Out of order block', 'LoadExternalBlockFile: Processing out of order child', ]): extra_args =...
Review this code and list any quality issues.
[ { "issue": "nit: Should use named args for integral literal arguments", "severity": "minor", "line": 26 } ]
1
python
'url': 'https://zoom.iprima.cz/10-nejvetsich-tajemstvi-zahad/posvatna-mista-a-stavby', 'only_matching': True, }, { 'url': 'https://krimi.iprima.cz/mraz-0/sebevrazdy', 'only_matching': True, }, { 'url': 'https://cool.iprima.cz/derava-silnice-nevadi', 'only_matching': True,...
Review this code and list any quality issues.
[ { "issue": "inline this too\r\n```suggestion\r\n token_data = self._download_json(\r\n```", "severity": "minor", "line": 26 } ]
1
python
'code': urllib.parse.parse_qs(handle.geturl()).get('code')[-1], 'grant_type': 'authorization_code', 'client_id': 'tennis-tv-web', 'redirect_uri': 'https://www.tennistv.com/resources/v1.1.10/html/silent-check-sso.html' }) def _cookie_login(self): ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n self.ACCESS_TOKEN = res['access_token']\r\n self.REFRESH_TOKEN = res['refresh_token']\r\n```\r\nOR\r\n```suggestion\r\n self.ACCESS_TOKEN = res.get('access_token') or self.ACCESS_TOKEN\r\n self.REFRESH_TOKEN = res.get('refresh_token') or self.REFRESH_TOK...
1
python
:toctree: ../reference core Predefined colors ----------------- There are several predefined colors available in Manim: - The colors listed in :mod:`.color.manim_colors` are loaded into Manim's global name space. - The colors in :mod:`.color.AS2700`, :mod:`.color.BS381`, :mod:`.color.DVIPSNAMES`, :mod:`.col...
Review this code and list any quality issues.
[]
0
python
self._initialize_pref() self._initialize_consent() self._check_login_required() def _perform_login(self, username, password): auth_type, sep, user = (username or '').partition('+') if auth_type != 'oauth': raise ExtractorError( 'Login using username and ...
Review this code and list any quality issues.
[ { "issue": "do we wanna do this instead of huge comment block?\r\n```suggestion\r\n '''\r\n OAuth 2.0 Device Authorization Grant flow, used by the YouTube TV client (youtube.com/tv).\r\n\r\n For more information regarding OAuth 2.0 and the Device Authorization Grant flow in general, see:\r\n - https...
1
python
NewgroundsPlaylistIE, NewgroundsUserIE, ) from .newspicks import NewsPicksIE from .newstube import NewstubeIE from .newsy import NewsyIE from .nextmedia import ( NextMediaIE, NextMediaActionNewsIE, AppleDailyIE, NextTVIE, ) from .nexx import ( NexxIE, NexxEmbedIE, ) from .nfb import NFBIE fr...
Review this code and list any quality issues.
[]
0
python
error_params = ["Reduction failed at followed parameters:"] for param in self.param2name: if not is_ddp_ignored(param) and not getattr(param, "_gemini_reduced"): error_params.append(self.param2name[param]) error_str = "\n\t".join(error_params) rais...
Review this code and list any quality issues.
[ { "issue": "`backward_by_grad()` shoud not be called, since Gemini is not compatible with pipeline. Raise a runtime error here.", "severity": "critical", "line": 26 } ]
1
python
# Copyright (c) Microsoft Corporation. # SPDX-License-Identifier: Apache-2.0 # DeepSpeed Team import torch from deepspeed import comm as dist from torch import nn from torch.nn import functional as F from torch.nn.parameter import Parameter from deepspeed.accelerator import get_accelerator from deepspeed.module_inje...
Review this code and list any quality issues.
[ { "issue": "Should have some comments to explain the sharding scheme here. Better with a simple example to help understanding.", "severity": "minor", "line": 26 } ]
1
python
torch.nn.Conv1d, torch.nn.Conv2d, torch.nn.Conv3d, torch.nn.ConvTranspose1d, torch.nn.ConvTranspose2d, torch.nn.ConvTranspose3d, torch.nn.Linear, # TODO(aryan): look into torch.nn.LayerNorm, torch.nn.GroupNorm later, seems to be causing some issues with CogVideoX # because of double invocation of the sa...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n group_id: Optional[int] = None,\r\n```", "severity": "minor", "line": 26 } ]
1
python
np.testing.assert_allclose(p_jac[:, -1], np.where(n >= 1, -pow(x, n) * np.inf, 0)) for m in range(3, m_max + 1): np.testing.assert_allclose(p_jac[:, m], 0) np.testing.assert_allclose(p_jac[:, -m], 0) def test_assoc_legendre_p_norm_m0(self): # gh 24099 m ...
Review this code and list any quality issues.
[ { "issue": "You could parametrize both tests over `n` to get better testing feedback if only a subset of cases start failing at some point, but not sure that is even worth flushing the CI again over.", "severity": "critical", "line": 26 } ]
1
python
from metagpt.actions.action import Action from metagpt.config2 import Config from metagpt.const import TEST_DATA_PATH from metagpt.context import Context from metagpt.provider.llm_provider_registry import create_llm_instance from metagpt.roles.role import Role def test_set_llm(): config1 = Config.default() co...
Review this code and list any quality issues.
[]
0
python
#!/usr/bin/env python3 # # Copyright (c) 2024 Raspberry Pi (Trading) Ltd. # # SPDX-License-Identifier: BSD-3-Clause import sys with open(sys.argv[1], "r") as f: data = f.read() lines = data.split(";") for line in lines[1].split("\n"): if "#define CYW43_WIFI_FW_LEN" in line: cyw43_wifi_...
Review this code and list any quality issues.
[ { "issue": "I guess you could `break` from this `for` loop once both `cyw43_wifi_fw_len` and cyw43_clm_len` have been read?", "severity": "minor", "line": 12 } ]
1
python
metadata = self._download_json( 'https://app.veo.co/api/app/matches/%s' % video_id, video_id) video_data = self._download_json( 'https://app.veo.co/api/app/matches/%s/videos' % video_id, video_id, 'Downloading video data') formats = [] for fmt in video_data: ...
Review this code and list any quality issues.
[ { "issue": "Is this really needed? It is generally preferable to use `--check-formats`", "severity": "minor", "line": 26 } ]
1
python
else self.config.trainer.n_gpus_per_node * self.config.trainer.nnodes ) num_replicas = world_size // rollout_world_size rollout_config = self.config.actor_rollout_ref.rollout model_config = self.config.actor_rollout_ref.model self.rollout_replicas = [ self.rollout_re...
Review this code and list any quality issues.
[ { "issue": "Please add config in `verl/trainer/config/rollout/rollout.yaml` instead of environment variable.", "severity": "minor", "line": 26 } ]
1
python
self.gguf_writer.add_value_length(rope_dim) def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iterable[tuple[str, Tensor]]: if name == "lm_head.weight": if self.hparams.get("tie_word_embeddings", False): logger.info("Skipping tied output layer 'lm_head....
Review this code and list any quality issues.
[ { "issue": "This `noaux_tc` is probably not handled now", "severity": "minor", "line": 26 } ]
1
python
if __name__ == "__main__": parser = argparse.ArgumentParser( description="Preprocesses audio files from datasets, encodes them as mel spectrograms " "and writes them to the disk. Audio files are also saved, to be used by the " "vocoder for training.", formatt...
Review this code and list any quality issues.
[]
0
python
@classmethod def configure_csv_data_node( cls, id: str, default_path: Optional[str] = None, encoding: Optional[str] = None, has_header: Optional[bool] = None, exposed_type: Optional[str] = None, scope: Optional[Scope] = None, validity_period: Optional[...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n relevant tasks will run even if they are skippable (see the\r\n [Task configs page](../../userman/scenario_features/task-orchestration/scenario-config.md#from-task-configurations)\r\n for more details).\r\n```", "severity": "minor", ...
1
python
if value == "charging": return True if value == "idle": return False return None def _device_status_is_on(value: str | None) -> bool | None: """Map device status value to binary sensor state.""" if value == "on": return True if value == "off": return False retur...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n is_on_fn={\"charging\": True, \"idle\": False}.get,\r\n```", "severity": "minor", "line": 26 } ]
1
python
@pytest.mark.parametrize("empty", []) def test(): pass """ ) result = pytester.runpytest(str(p1)) result.stdout.fnmatch_lines( [ "collected 0 items / 1 error", "* ERROR collecting test_parameterset_for_fail_at_collect.py *", "Empty para...
Review this code and list any quality issues.
[ { "issue": "IIUC `idfunc` is no longer being called when parametrize receives an empty list, is that it?", "severity": "minor", "line": 26 } ]
1
python
) return load_data_series( Path("test_results/test-report.json"), binary_dir, reemit=True ) def analyze_data( processed_emf_a, processed_emf_b, p_thresh, strength_abs_thresh, noise_threshold, *, n_resamples: int = 9999, ): """ Analyzes the A/B-test data produced by ...
Review this code and list any quality issues.
[]
0
python
... model=model_params, ... training=training_params, ... ) >>> # Use the training_config in your training pipeline Note: All configuration classes inherit from :class:`~oumi.core.configs.base_config.BaseConfig`, which provides common functionality such as serialization and vali...
Review this code and list any quality issues.
[]
0
python
lambda: logits, lambda: _top_k(), ) def sample_sequence(*, hparams, length, start_token=None, batch_size=None, context=None, temperature=1, top_k=0): if start_token is None: assert context is not None, 'Specify exactly one of start_token and context!' else: assert context is None, '...
Review this code and list any quality issues.
[ { "issue": "how about we just always make it just `prev`, and don't do the later squeeze?", "severity": "minor", "line": 26 } ]
1
python
def setup_platform( hass: HomeAssistant, config: ConfigType, add_entities: AddEntitiesCallback, discovery_info: DiscoveryInfoType | None = None, ) -> None: """Connect to Sony projector using network.""" host = config[CONF_HOST] name = config[CONF_NAME] sdcp_connection = pysdcp.Projector...
Review this code and list any quality issues.
[ { "issue": "`SonyProjector.__init__` is missing type annotations for `sdcp_connection` and `name`, while the rest of the module is typed. Adding annotations (and a `-> None` return type) will keep the file consistent and helps with static analysis as pylint/mypy settings tighten.\n```suggestion\n def __init_...
1
python
import functools import warnings from typing import Callable def deprecated_parameter( old_parameter: str, new_parameter: str, map_function: Callable = lambda x: x, warn_message: str = "Warning: '{old_parameter}' in '{function_name}' " "is deprecated: use '{new_parameter}' instead.", **message...
Review this code and list any quality issues.
[ { "issue": "Please do change `warn_message` to `warning_message`. I try to avoid using abbreviated names.", "severity": "minor", "line": 10 } ]
1
python
if self._default_persp_cam is None: self._default_persp_cam = PerspectiveCamera(yfov=np.pi / 3.0, znear=znear, zfar=zfar) if self._default_orth_cam is None: xmag = ymag = self.scene.scale if self.scene.scale == 0: xmag = ymag = 1.0 self._default_or...
Review this code and list any quality issues.
[ { "issue": "Just use relative import and move them back on top (after all non-relative imports). It should work:\r\n```python\r\nfrom .interaction.viewer_interaction import ViewerInteraction\r\nfrom .interaction.viewer_interaction_base import ViewerInteractionBase\r\n```", "severity": "minor", "line": 2...
1
python
# Mock firmware update API async def get_firmware_details( device: OmadaListDevice, ) -> OmadaFirmwareUpdate | None: """Mock getting firmware details for a device.""" if device.need_upgrade: firmware_data = await async_load_json_object_fixture( hass, f"firmwar...
Review this code and list any quality issues.
[]
0
python
'content_providers/channels', item_id=f'channels/{channel_name}', note='Fetching channel list', errnote='Unable to fetch channel list', )['data']['content_providers'] for fanclub in fanclub_list_json: if fanclub.get('domain') == f'{self._WEBPAGE_BASE_URL}/{channel_name}': ...
Review this code and list any quality issues.
[ { "issue": "why Channel**Plus**? Imo, `NiconicoChannelIE` is sufficient. Also, everything should be moved into `niconico.py`", "severity": "minor", "line": 26 } ]
1
python
import os import json import requests BASE_URL = os.environ.get('OLLAMA_HOST', 'http://localhost:11434') # Generate a response for a given prompt with a provided model. This is a streaming endpoint, so will be a series of responses. # The final response object will include statistics and additional data from the requ...
Review this code and list any quality issues.
[ { "issue": "`prompt` should probably also be required rather than defaulting to `None`", "severity": "minor", "line": 10 } ]
1
python
textwrap.dedent( """\ simple==2.0 # and something else to test out: simple2<=3.0 """ ) ) script.pip_install_local( "-r", script.scratch_path / "initools-req.txt", ) result = script.pip("freeze", expect_stderr=True) expected = textwr...
Review this code and list any quality issues.
[ { "issue": "This also doesn't seem directly related to this PR. It's a sensible addition, but why is it included here?", "severity": "minor", "line": 26 } ]
1
python
return gguf.GGMLQuantizationType.F32 return False def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iterable[tuple[str, Tensor]]: del bid # unused if name.startswith("vision_model") or name.startswith("mlp"): # process visual tensors # corr...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n super().set_vocab()\r\n```", "severity": "minor", "line": 26 } ]
1
python
if not success: raise ExternalProgramRunError( 'Program failed with return code={}:'.format(proc.returncode), args, env=env, stdout=stdout, stderr=stderr) finally: if self.capture_output: tmp_stderr.close() tmp_s...
Review this code and list any quality issues.
[ { "issue": "Is it possible to use contextlib? This reminds me of #2652. :)", "severity": "minor", "line": 26 } ]
1
python
def _stop_again(*_) -> None: """Signal handler that will put the application back to sleep.""" os.kill(os.getpid(), signal.SIGSTOP) # Set up handlers to ensure that, if there's a SIGTTOU or a SIGTTIN, # we go back to sleep. signal.signal(signal.SIGTTOU, _stop_again) ...
Review this code and list any quality issues.
[]
0
python
test_doc = Document( root_path=str(tests_file_repo.root_path), filename="test_" + code_doc.filename, content="" ) logger.info(f"Writing {test_doc.filename}..") context = TestingContext(filename=test_doc.filename, test_doc=test_doc, code_doc=code_doc) ...
Review this code and list any quality issues.
[]
0
python
class JioSaavnSongIE(JioSaavnBaseIE): _VALID_URL = r'https?://(?:www\.)?(?:jiosaavn\.com/song/[^/?#]+/|saavn\.com/s/song/(?:[^/?#]+/){3})(?P<id>[^/?#]+)' _TESTS = [{ 'url': 'https://www.jiosaavn.com/song/leja-re/OQsEfQFVUXk', 'md5': '3b84396d15ed9e083c3106f1fa589c04', 'info_dict': { ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n extract_bitrates = self._configuration_arg('bitrate', ['128', '320'], ie_key='JioSaavn')\r\n if invalid_bitrates := [br for br in extract_bitrates if br not in self._VALID_BITRATES]:\r\n raise ValueError(\r\n f'Invalid bitrate(s): {\", \".joi...
1
python
) mocker.patch( "importlib.metadata.distributions", return_value=[fake_distribution], ) return fake_distribution class TestKedroCLIHooks: @pytest.mark.parametrize( "command, exit_code", [("-V", 0), ("info", 0), ("pipeline list", 2), ("starter", 0)], ) def test_k...
Review this code and list any quality issues.
[ { "issue": "Same here re: comments and the mocker part below.", "severity": "minor", "line": 26 } ]
1
python
def __post_init__(self): """Initialize additional_info if None.""" if self.additional_info is None: self.additional_info = {} class BaseQuantization(ABC): """Abstract base class for all quantization methods. This class defines the common interface that all quantization implementat...
Review this code and list any quality issues.
[ { "issue": "nit: update the comment, since now we return the `QuantizationResult` object", "severity": "minor", "line": 26 } ]
1
python
coin = blocks[-1].get_included_reward_coins()[0] spend_bundle = wallet.generate_signed_transaction(uint64(42), wallet_ph, coin) sb_name = spend_bundle.name() await node_to_add_tx_to.add_transaction(spend_bundle, sb_name, ws_con) mempool_item = node_to_add_tx_to.mempool_manager.get_mempoo...
Review this code and list any quality issues.
[ { "issue": "you need an else block here, to make sure the peer is *not* banned. e.g. if the peer is *always* banned, this test would still pass right now", "severity": "minor", "line": 26 } ]
1
python
Iterable, Iterator, List, Optional, Pattern, Sequence, Tuple, Union, TYPE_CHECKING, ) from mypy_extensions import mypyc_attr from pathspec import PathSpec from pathspec.patterns.gitwildmatch import GitWildMatchPatternError import tomli from black.output import err from black.report imp...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\ndef find_project_root(srcs: Sequence[str]) -> Tuple[Path, str]:\r\n```", "severity": "minor", "line": 26 } ]
1
python
layer_names=[self.attn.layer_name], vllm_config=self.vllm_config, device=self.device, ) def build_attn_metadata(self, batch_size: int) -> AttentionMetadata: """Initialize attention metadata.""" # Create common attn metadata batch_spec = BatchSpec(seq_lens=[1...
Review this code and list any quality issues.
[ { "issue": "Can you make an issue to properly fix this in the base class?", "severity": "minor", "line": 26 } ]
1
python
def visit_async_stmt(self, node: Node) -> Iterator[Line]: """Visit `async def`, `async for`, `async with`.""" yield from self.line() children = iter(node.children) for child in children: yield from self.visit(child) if child.type == token.ASYNC: ...
Review this code and list any quality issues.
[ { "issue": "AFAIK `trailer` also includes the subscript and the call, e.g `1(duh)` or `1[duh]` would be also parenthesized (even though there is no such use case). I wonder whether we should make a more stricter check and ensure we are in an attribute trailer 🤔", "severity": "minor", "line": 26 } ]
1
python
import pytest for node in item.listchain(): if isinstance(node, pytest.Session): continue if isinstance(node, pytest.Directory) and isinstance( node.parent, pytest.Session ): continue mapped_names.add(node.name) ...
Review this code and list any quality issues.
[ { "issue": "`kwargs` is always a mapping, I don't think that using `object` for typing such things is customary, is it?", "severity": "minor", "line": 26 } ]
1
python
streams_data = self._download_json(token_url, video_id) formats = [] for key in ['content', 'content2', 'content3']: stream_url = try_get(streams_data, lambda x: x['response']['data'][key]) if stream_url == '': continue formats.extend(self._extract_m3...
Review this code and list any quality issues.
[ { "issue": "md5 of fragmented downloads keep changing. This should have never had md5 in the test definition\r\n```suggestion\r\n```", "severity": "minor", "line": 26 } ]
1
python
webpage, 'title', default=None) director = self._html_search_regex( r'<[^>]+\bitemprop=["\']name["\'][^>]*>([^<]+)', webpage, 'director', default=None) year = self._html_search_regex( r'<[^>]+\bitemprop=["\']datePublished["\'][^>]*>([^<]+)', webpage, 'year...
Review this code and list any quality issues.
[ { "issue": "Use self._extract_m3u8_formats_and_subtitles", "severity": "major", "line": 26 } ]
1
python
def load_state_dict(self, state_dict: Dict[str, torch.Tensor]) -> None: raise NotImplementedError def loop(self) -> None: num_update_per_episode = len(self.train_dataloader) // self.num_microbatches num_valid_microbatches = num_update_per_episode * self.num_microbatches print( ...
Review this code and list any quality issues.
[ { "issue": "It is better to indicate that here we use `consumer_global_step` as we have different steps.", "severity": "minor", "line": 26 } ]
1
python
self.assertEqual(schema["function"], expected_schema) def test_tuple(self): def fn(x: tuple[int, str]): """ Test function Args: x: The input Returns: The output """ return x schema = get_json...
Review this code and list any quality issues.
[]
0
python
"""Mobjects used to mark and annotate other mobjects.""" __all__ = ["SurroundingRectangle", "BackgroundRectangle", "Cross", "Underline"] from ..constants import * from ..mobject.geometry import Line, Rectangle from ..mobject.types.vectorized_mobject import VGroup, VMobject from ..utils.color import BLACK, RED, YELLO...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n \"\"\"A rectangle surrounding a :class:`~.Mobject`\r\n```", "severity": "minor", "line": 13 } ]
1
python
np.unique_all(arr), np.unique( arr, return_index=True, return_inverse=True, return_counts=True, equal_nan=False ) ) ]: assert len(res_unique_array_api) == l...
Review this code and list any quality issues.
[ { "issue": "Can we make sure we have tests for both NaNs and `-0.0` vs `0.0`. For NaN, test with `np.nan` and `-np.nan` (I hope `-np.nan` is enough, but it stays in python world).", "severity": "minor", "line": 26 } ]
1
python
@staticmethod def _extract_session_index(*data): """ Index of current account in account list. See: https://github.com/yt-dlp/yt-dlp/pull/519 """ for ytcfg in data: session_index = int_or_none(try_get(ytcfg, lambda x: x['SESSION_INDEX'])) if session_in...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n if second:\r\n return first, second\r\n return None, first\r\n```\r\nThis is easier to read imo", "severity": "minor", "line": 26 } ]
1
python
if f.is_file() ] if session.get('custom_model_dir'): voice_options.extend( (f.stem, str(f)) for f in Path(session['custom_model_dir']).rglob('*.wav') ...
Review this code and list any quality issues.
[ { "issue": "The code attempts to access parts[idx + 1] without verifying that idx + 1 is within bounds. If \"voices\" is the last directory component in the path, this will raise an IndexError. Add a bounds check to ensure idx + 1 is less than len(parts) before accessing it.\n```suggestion\n ...
1
python
raise AttributeError(field_name) def has_input(self, field_name): if field_name in self.dynamic_input_fields: return True return field_name in self.inputs and self.inputs[field_name] not in ('', None) def has_inputs(self, field_names=()): for name in field_names: ...
Review this code and list any quality issues.
[ { "issue": "`actor.organizations` wasn't correct, and it was my fault. https://github.com/ansible/awx/pull/15298", "severity": "minor", "line": 26 } ]
1
python
if namespace.__name__ == "array_api_strict" and hasattr( namespace, "set_array_api_strict_flags" ): namespace.set_array_api_strict_flags(api_version="2024.12") return namespace, is_array_api_compliant def get_namespace_and_device( *array_list, remove_none=True, remove_types=(str,), xp=Non...
Review this code and list any quality issues.
[ { "issue": "If that can help make this helper easier to use in different contexts, it would be fine to introduce optional kwargs to allow for either convention to specify the target namespace and device\r\n\r\n```python\r\ndef move_to(*arrays, xp=None, device=None, same_xp_and_device_as=None):\r\n ...\r\n\r\n...
1
python
def html_to_text(source: str | BeautifulSoup) -> str: """Converts markup string or BeautifulSoup object to newline separated plain text without tags.""" if isinstance(source, str): soup = BeautifulSoup(source) elif isinstance(source, BeautifulSoup): soup = source else: raise Type...
Review this code and list any quality issues.
[ { "issue": "JS version has only compr.startswith(' '), but I can't understand how it passed the test. In Python to pass exactly same test I had to do: compr.startswith((' ', '\\n')", "severity": "minor", "line": 26 } ]
1
python
exclude = set() meta = meta or self._meta field_map = {} generated_fields = [] for field in meta.local_fields: if field.name in exclude: continue if field.generated: if any( ref[0] in exclude ...
Review this code and list any quality issues.
[ { "issue": "Should we continue if the field is not concrete?\r\n\r\n```suggestion\r\n elif field.concrete:\r\n value = getattr(self, field.attname)\r\n else:\r\n continue\r\n```", "severity": "minor", "line": 26 } ]
1
python
_PROGRAMCARD_BASE = 'https://www.dr.dk/mu-online/api/1.4/programcard' query = {'expanded': 'true'} if video_id: programcard_url = '%s/%s' % (_PROGRAMCARD_BASE, video_id) else: programcard_url = _PROGRAMCARD_BASE is_radio_url = 'dr.dk/lyd' in url i...
Review this code and list any quality issues.
[ { "issue": "I know this is just old code / not yours, but it could be modernized/simplified with `_search_json` and `traverse_obj`\r\n```suggestion\r\n else:\r\n json_data = self._search_json(\r\n r'window\\.__data\\s*=', webpage, 'data', raw_video_id)\r\n ...
1
python
def test_height_ratios(): """ Addresses issue #5835. See at https://github.com/matplotlib/matplotlib/issues/5835. """ with pytest.raises(ValueError): gridspec.GridSpec(1, 1, height_ratios=[2, 1, 3]) def test_SubplotParams(): s = gridspec.SubplotParams(.1, .1, .9, .9) assert s.left ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n with pytest.raises(ValueError, match='left cannot be >= right'):\r\n gridspec.SubplotParams(.1, .1, .09, .9)\r\n```\r\nlet's be more specific here as well.", "severity": "minor", "line": 26 } ]
1
python
self.func = func x_range = np.arange(*self.x_range) y_range = np.arange(*self.y_range) z_range = np.arange(*self.z_range) self.add( *[self.get_vector(pos) for pos in it.product(x_range, y_range, z_range)] ) self.set_opacity(self.opacity) def get_vector(s...
Review this code and list any quality issues.
[ { "issue": "if i leave this out the docs compilation fails but i don't know why it suddenly passes in a list instead of an ndarray", "severity": "critical", "line": 26 } ]
1
python
def get_pipeline(self, components_manager=None, torch_dtype=torch.float32): pipeline = self.pipeline_blocks_class().init_pipeline(self.repo, components_manager=components_manager) pipeline.load_components(torch_dtype=torch_dtype) return pipeline def get_dummy_inputs(self, device, seed=0): ...
Review this code and list any quality issues.
[]
0
python
items.append(ThinkingPart(content=item.thinking, signature=item.signature, provider_name=self.system)) elif isinstance(item, BetaMCPToolUseBlock): call_part = _map_mcp_server_use_block(item, self.system) builtin_tool_calls[call_part.tool_call_id] = call_part i...
Review this code and list any quality issues.
[ { "issue": "if the `message` is the same/similar for all, more of a reason to set it in the model itself to not repeat it everywhere", "severity": "minor", "line": 26 } ]
1
python
activities=["CPU", "CUDA"], ) logger.debug( "Starting torch profiler with trace name: %s", trace_name ) elif self.profiler_config.profiler == "cuda": self.profiler = CudaProfilerWrapper(self.profiler_...
Review this code and list any quality issues.
[ { "issue": "shall we throw the exception here?\n\nLazy create, then lazy throw?", "severity": "minor", "line": 26 } ]
1
python
self._SVTPLAY_RE, webpage, 'embedded data', default='{}', group='json'), video_id, fatal=False) thumbnail = self._og_search_thumbnail(webpage) if data: video_info = try_get( data, lambda x: x['context']['dispatcher']['stores']['VideoTitlePageStor...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n r'<[^>]+\\bdata-rt=[\"\\']top-area-play-button[\"\\'][^>]+\\bhref=[\"\\'][^\"\\']*video/[\\w-]+/[^\"\\']*\\b(?:modalId|id)=([\\w-]+)',\r\n```", "severity": "minor", "line": 26 } ]
1
python
'description': 'md5:e87beab3bf9f392d6b9e541a63286343', }, 'playlist_count': 30, }, { 'url': 'https://wetv.vip/en/play/u37kgfnfzs73kiu-You-Are-My-Glory', 'info_dict': { 'id': 'u37kgfnfzs73kiu', 'title': 'You Are My Glory', 'description': 'md5:831363...
Review this code and list any quality issues.
[ { "issue": "This looks like it should use playlist_from_matches", "severity": "minor", "line": 26 } ]
1
python
def _configure_cmake(self): cmake = CMake(self) if tools.get_env("CONAN_RUN_TESTS"): cmake.definitions["BENCHMARK_ENABLE_TESTING"] = "ON" cmake.definitions["BENCHMARK_ENABLE_GTEST_TESTS"] = "ON" if self.options.enable_gtest_tests else "OFF" else: cmake.defini...
Review this code and list any quality issues.
[ { "issue": "This line looks kind of weird to me but having a look at `BENCHMARK_ENABLE_TESTING` and `BENCHMARK_ENABLE_GTEST_TESTS` it could make sense to have it separated. Anyway both the option and env var for tests are well managed", "severity": "minor", "line": 26 } ]
1
python
if subcategory not in rid_map[category]: raise ExtractorError("The supplied subcategory, %s, is not supported" % subcategory) rid_value = rid_map[category][subcategory] api_url = "https://api.bilibili.com/x/web-interface/newlist?rid=%d&type=1&ps=20&jsonp=jsonp" % rid_value json_str...
Review this code and list any quality issues.
[ { "issue": "Why sort by published date? Unless there is a specific reason for this, it should return in same order as is fetched", "severity": "minor", "line": 26 } ]
1
python
'series_id': '14694', 'episode': '次世代リアクション王発掘トーナメント', 'episode_number': 335, 'episode_id': '14694_2090934_1000117476', 'timestamp': 1749547434, 'upload_date': '20250610', 'release_timestamp': 1749646802, 'release_date': '20250611', ...
Review this code and list any quality issues.
[ { "issue": "line too long\r\n```suggestion\r\n 'cast': (\r\n 'credit', ..., 'name', ..., 'value', {clean_html}, any,\r\n {lambda x: x.split(',')}, ..., {str.strip}, filter, all, filter),\r\n```", "severity": "major", "line": 26 } ]
1
python
import logging import os import warnings from functools import wraps from typing import Any, Dict, List, Optional, Union import httpx from mem0.memory.setup import get_user_id, setup_config from mem0.memory.telemetry import capture_client_event logger = logging.getLogger(__name__) # Setup user config setup_config()...
Review this code and list any quality issues.
[ { "issue": "@Dev-Khant curious why did we remove this?", "severity": "major", "line": 15 } ]
1
python
output_ids.append(token) if token == tokenizer.eos_token_id: stopped = True else: stopped = False if i % stream_interval == 0 or i == max_new_tokens - 1 or stopped: output = tokenizer.decode(output_ids, skip_special_tokens=True) pos = output.rfin...
Review this code and list any quality issues.
[]
0
python
# ========================== Sensor Lifecycle ========================== def build(self): """Initialize the rasterizer and register this camera.""" super().build() scene = self._manager._sim.scene if self._shared_metadata.sensors is None: self._shared_metadata.sensors ...
Review this code and list any quality issues.
[ { "issue": "We should support multiple OpenGL context in parallel. Here you are hiding a bug while complexifying the implementation.", "severity": "critical", "line": 26 } ]
1