language string | code-snippit string | instruction string | flaws list | flaw_count int64 |
|---|---|---|---|---|
python | self.app.config_from_object(Config(), force=True)
assert exc.args[0].startswith('CELERY_DEFAULT_DELIVERY_MODE')
assert 'task_default_delivery_mode' in exc.args[0]
def test_config_from_object__mixing_old_and_new(self):
class Config:
CELERY_ALWAYS_EAGER = 46
C... | Review this code and list any quality issues. | [
{
"issue": "Shouldn't this and the next assertion be outside the `with` scope?",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'email': username,
'password': password
}).encode('utf-8'),
headers={
'Content-Type': 'application/json'
})['token']
self.cache.store(self._NETRC_MACHINE, username, IwaraBaseIE._USERTOKEN)
return self._USERTOKE... | Review this code and list any quality issues. | [
{
"issue": "make sure to `import urllib.error`\r\n```suggestion\r\n except ExtractorError as e:\r\n if not isinstance(e.cause, urllib.error.HTTPError) and e.cause.code == 403:\r\n raise\r\n self.to_screen('User token has expired')\r\n```",
"severity": "major",
... | 1 |
python | use of any covariance estimator.
Parameters
----------
X : array-like of shape (n_samples, n_features)
Training data.
y : array-like of shape (n_samples,) or (n_samples, n_targets)
Target values.
shrinkage : 'auto', float or None
Shrinkage p... | Review this code and list any quality issues. | [
{
"issue": "Nitpick: could you please rewrap docstring paragraphs (respectively multi-line exception messages) to use more of the available 80 (respectively 88) columns allowed by our formatting conventions?",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'id': 'todayinfocus',
'title': 'Today in Focus | Page 2 of 66 | News | The Guardian',
'description': 'md5:0f097764fc0d359e0b6eb537be0387e2'
},
'playlist_mincount': 1261
}, {
'url': 'https://www.theguardian.com/news/series/the-audio-long-read',
'info_dict': {
... | Review this code and list any quality issues. | [
{
"issue": "`suitable` check likely isn't necessary unless this site also has the problem that radiocomercial did where it embeds its own playlist URL in place of unavailable episodes' URLs",
"severity": "minor",
"line": 26
}
] | 1 |
python | print("[FullyAsyncTrainer] async_rollout_manager sleep")
await self.async_rollout_manager.sleep()
else:
print("[FullyAsyncTrainer] Skip async rollout manager (use_trainer_do_validate=False)")
async def fit(self):
"""
The training loop of PPO.
The driver proce... | Review this code and list any quality issues. | [] | 0 |
python | skip_identifiers (`List[str]`, *optional*, defaults to `None`):
Regex patterns (fullmatch) for module names to be placed in "skip" mode, where the module is evaluated
during warmup / refresh, but then replaced by a cheap dummy tensor during prediction steps.
cache_identifiers (`List[str... | Review this code and list any quality issues. | [
{
"issue": "If `lite` mode is not functional across all model types (based on comment [here](https://github.com/huggingface/diffusers/pull/12648#issuecomment-3555982032)) I would recommend removing the option. \n\nIf we want to reduce memory use we have other routes (use lower taylor_factors_dtype, model_cpu_of... | 1 |
python | ) -> None:
debug_data = {
"todo_nodes": todo_nodes,
"done_nodes": done_nodes,
"ready_nodes": ready,
"done_futures": done,
}
debug_data_str = "\n".join(f"{k} = {v}" for k, v in debug_data.items())
raise RuntimeError(
f"Unable to ... | Review this code and list any quality issues. | [] | 0 |
python | # you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES... | Review this code and list any quality issues. | [
{
"issue": "we already have `is_transformers_version_greater_than` https://github.com/hiyouga/LLaMA-Factory/blob/e43a972b25fcf9caf5fa4018649ac9f06d1c89df/src/llamafactory/extras/packages.py#L110",
"severity": "minor",
"line": 26
}
] | 1 |
python | # or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You ma... | Review this code and list any quality issues. | [
{
"issue": "@sadpandajoe feel free to simplify this, if it's just re-testing Hive",
"severity": "major",
"line": 26
}
] | 1 |
python | webpage = self._download_webpage(url, video_id)
iframe_src = self._html_search_regex(r'<iframe src="([^"]+)"', webpage, 'iframe', fatal=True)
title = self._html_search_meta(['name', 'twitter:title', 'og:title'], webpage, 'title', default=None) or self._search_regex(r'<h1>(.*?)</h1>', webpage, 'title')
... | Review this code and list any quality issues. | [
{
"issue": "You can use `_parse_html5_media_entries` instead. (even without it you have to request for finding more formats using `_extract_m3u8_formats` or set `protocol` key)\r\n\r\n<!--Note that this returns list of root info-dict (which you return at `_real_extract`), so expect minor rewrite-->",
"sever... | 1 |
python | import re
from .common import InfoExtractor
class RbgTumIE(InfoExtractor):
_VALID_URL = r'https://(live\.rbg\.tum\.de|tum\.live)/w/(?P<id>.+)'
_TESTS = [{
# Combined view
'url': 'https://live.rbg.tum.de/w/cpp/22128',
'md5': '53a5e7b3e07128e33bbf36687fe1c08f',
'info_dict': {
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n _VALID_URL = r'https://(?:live\\.rbg\\.tum\\.de|tum\\.live)/w/(?P<id>[^?#]+)'\r\n```\r\nWe don't want to match query. Same issue for other IE",
"severity": "minor",
"line": 7
}
] | 1 |
python | )['data']['content_providers']
fanclub_id = traverse_obj(fanclub_list_json, (
lambda _, v: v.get('domain') == f'{self._WEBPAGE_BASE_URL}/{channel_name}', 'id'),
get_all=False)
if not fanclub_id:
raise ExtractorError(f'Channel {channel_name} does not exist', expected=T... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n _VALID_URL = r'https?://nicochannel\\.jp/(?P<channel>[\\w.-]+)/(?:video|live)/(?P<code>sm\\w+)'\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | return self._into_message_param()
def _into_message_param(self) -> chat.ChatCompletionAssistantMessageParam:
"""Converts the collected texts and tool calls into a single OpenAI `ChatCompletionAssistantMessageParam`.
This method serves as a hook that can be overridden by subclasses
... | Review this code and list any quality issues. | [
{
"issue": "Could we use `assert ... is not None`?",
"severity": "minor",
"line": 26
}
] | 1 |
python | assert "suggestion_2" in result.output
def test_not_found_closet_match_singular(self, mocker):
"""Check that calling a nonexistent command with a close match has the proper wording"""
patched_difflib = mocker.patch(
"kedro.framework.cli.utils.difflib.get_close_matches",
retu... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n assert result.exit_code == 2\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | msg = "Current model does not support the image input. If you are using openai connection, then please use " \
"gpt-4-vision-preview. You can refer to https://platform.openai.com/docs/guides/vision." \
"If you are using azure openai connection, then please first go to your Azure OpenAI resou... | Review this code and list any quality issues. | [
{
"issue": "Instead of manual copy raw message, why not reference `error_message` in your refined one?",
"severity": "minor",
"line": 26
}
] | 1 |
python | ----------
basis_points : int, optional
basis points to apply
"""
def __init__(self, basis_points=5, volume_limit=0.1):
super(FixedBasisPointsSlippage, self).__init__()
self.basis_points = basis_points
self.percentage = self.basis_points / 10000.0
self.volume_limit = ... | Review this code and list any quality issues. | [
{
"issue": "Does this need to be truncated to an integer?",
"severity": "minor",
"line": 26
}
] | 1 |
python | *,
stable: Literal[False] | None = False,
) -> _ArrayT: ...
@overload
def sort(
a: ArrayLike,
axis: SupportsIndex = -1,
kind: _SortKind | None = None,
order: str | Sequence[str] | None = None,
endwith: bool | None = True,
fill_value: _ScalarLike_co | None = None,
*,
stable: Literal[F... | Review this code and list any quality issues. | [
{
"issue": "I realize that there are some existing `'` quotes here and there, but `\"` is used way more often. I'm kinda surprised that ruff accepts this though 🤔\r\n\r\n```suggestion\r\ndef reshape(a, new_shape, order=\"C\"): ...\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | "tree": lambda gui, control_type, attrs: _Builder(
gui=gui,
control_type=control_type,
element_name="TreeView",
attributes=attrs,
)
.set_value_and_default(with_default=False, var_type=PropertyType.lov_value)
.set_attributes(
[
... | Review this code and list any quality issues. | [
{
"issue": "you also need to declare the component and it's default property at the top of the file\r\nI propose `value`\r\nand then add a call to `.set_value_and_default(var_type=PropertyType.dynamic_number)`",
"severity": "minor",
"line": 26
}
] | 1 |
python | self.dev = hid.Device(path=self.device['path'])
# Nonce is all zeros, because we don't care.
init_packet = [0] + list(_DEFAULT_CID) + [0x86, 0x00, 0x08] + [0x00] * 57
if len(init_packet) != _SEND_DATA_SIZE:
raise Exception(
f'Expected packet to be {_SEND_DATA_SIZE} but was {len(init_packet)}... | Review this code and list any quality issues. | [
{
"issue": "Type hinting is not used consistently across the file?",
"severity": "minor",
"line": 26
}
] | 1 |
python | - the start of all multiply objects is always 0 (in each window all
adjustments are overlapping)
- the end of the multiply object is the location before the calendar
location of the adjustment action, making all days before the event
adjusted.
Parameters
----------... | Review this code and list any quality issues. | [
{
"issue": "is there a way to pass multiple fields or assets now, instead of doing them one at a time?",
"severity": "minor",
"line": 26
}
] | 1 |
python | )._log_to_envelope
def log_event(log_data):
nonlocal envelope
envelope = log_to_envelope(log_data)
def check_evelope():
assert envelope.data.base_data.name.startswith("pf.runs.create_or_update")
custom_dimensions = pydash.get(envelope, "data.base_data.pr... | Review this code and list any quality issues. | [] | 0 |
python | await conversation_store.delete_metadata(conversation_id)
return True
@app.get('/conversations/{conversation_id}/remember-prompt')
async def get_prompt(
event_id: int,
conversation_id: str = Depends(validate_conversation_id),
user_settings: SettingsStore = Depends(get_user_settings_store),
metadat... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\n```\n\nWe don't use global envs for settings (except for the resolver); `settings.llm_base_url` should be enough!",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'google': google_model_profile,
'openai': openai_model_profile,
'anthropic': anthropic_model_profile,
'mistralai': mistral_model_profile,
'qwen': qwen_model_profile,
'x-ai': grok_model_profile,
'cohere': cohere_model_profile,
'amazon': ... | Review this code and list any quality issues. | [] | 0 |
python | "\nYou are probably using the old Vicuna-v0 model, "
"which will generate unexpected results with the "
"current fastchat.\nYou can try one of the following methods:\n"
"1. Upgrade your weights to the new Vicuna-v1.1: https://github.com/lm-sys/FastChat#vicuna-weights.\n"
... | Review this code and list any quality issues. | [] | 0 |
python | def get_array_attrs(self):
return Mobject.get_array_attrs(self) + ["rgbas"]
def add_points(self, points, rgbas=None, color=None, alpha=1):
"""
Points must be a Nx3 numpy array, as must rgbas if it is not None
"""
if not isinstance(points, np.ndarray):
points = np... | Review this code and list any quality issues. | [
{
"issue": "Wouldn't this mean that opacity is being passed a boolean? Seems like it needs a way to define opacity, unless I'm missing something 🤔",
"severity": "minor",
"line": 26
}
] | 1 |
python | from .common import InfoExtractor
import re
class MaarivIE(InfoExtractor):
IE_NAME = 'maariv.co.il'
_VALID_URL = r'(https?://)?(www\.)?(m\.)?maariv\.co\.il(?:/[^/]+)*/Article-(?P<id>\d{7})'
_TESTS = [
{
'url': 'https://www.maariv.co.il/news/law/Article-1044008',
'info_dict'... | Review this code and list any quality issues. | [
{
"issue": "This can be removed, since we can instead use the `parse_resolution` function from `..utils`\r\n```suggestion\r\n```",
"severity": "minor",
"line": 22
}
] | 1 |
python | 'responsive_web_graphql_exclude_directive_enabled': True,
'verified_phone_label_enabled': False,
'responsive_web_media_download_video_enabled': False,
'responsive_web_graphql_skip_user_profile_image_extensions_enabled': False,
'responsive_web_graphql_timel... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n self.report_warning(f'{e.orig_msg}. Falling back to syndication endpoint; some metadata may be missing', video_id=twid)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | formatter = AttributeFormatter(params)
sample = {"name": "John"}
format_string = "Hello {name}, your age is {age}"
result = formatter.format(sample, format_string, missing_values_allowed=True)
expected = "Hello John, your age is {age}"
assert result == expected
with pytest.raises(ValueError,... | Review this code and list any quality issues. | [] | 0 |
python | import sentry_sdk
from pydantic import SecretStr
from sentry_sdk.integrations.anthropic import AnthropicIntegration
from sentry_sdk.integrations.asyncio import AsyncioIntegration
from sentry_sdk.integrations.logging import LoggingIntegration
from backend.util.settings import Settings
settings = Settings()
class Dis... | Review this code and list any quality issues. | [
{
"issue": "How does this help us?\r\n\r\nI have no idea what they do, and we need to have a common understanding so we dont replicate effort",
"severity": "minor",
"line": 26
}
] | 1 |
python | current_line.append(word)
check_line = delimiter.join(current_line)
# Check if line exceeds max width
if rl.measure_text_ex(font, check_line, font_size * font_scale, 0).x > max_width:
current_line.pop() # Line is too long, move word to next line
if current_line:
lines.append(delimiter.j... | Review this code and list any quality issues. | [
{
"issue": "The max_width calculation for metadata text wrapping uses an approximation (time_size * 6) to leave space for the time overlay. However, this doesn't account for the padding added by draw_text_box (16px total width) and could lead to overlap between metadata and time overlay. Consider measuring the ... | 1 |
python | class BgeM3SparseEmbeddingsProcessor(
IOProcessor[SparseEmbeddingCompletionRequestMixin, SparseEmbeddingResponse]
):
def __init__(self, vllm_config: VllmConfig, renderer: BaseRenderer):
super().__init__(vllm_config, renderer)
self.offline_requests: list[SparseEmbeddingCompletionRequestMixin] = [... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\n def parse_request(self, request_data: object) -> SparseEmbeddingCompletionRequestMixin:\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | def _is_parameter(name: str) -> bool:
return _is_single_parameter(name) or _is_all_parameters(name)
def _validate_inputs_outputs(
inputs: AbstractSet[str], outputs: AbstractSet[str], pipe: Pipeline
) -> None:
"""Safeguards to ensure that:
- parameters are not specified under inputs
- inputs are on... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n raise ModularPipelineError(\"Inputs must not be outputs from another node in the same pipeline\")\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | mobject: Mobject,
run_time: float = DEFAULT_POINTWISE_FUNCTION_RUN_TIME,
**kwargs,
) -> None:
super().__init__(mobject.apply_function, function, run_time=run_time, **kwargs)
class ApplyPointwiseFunctionToCenter(ApplyPointwiseFunction):
def __init__(self, function: types.MethodType, mob... | Review this code and list any quality issues. | [
{
"issue": "Do we really want an explicit example for Restore? There already is [this](https://docs.manim.community/en/stable/examples.html#followinggraphcamera) which demonstrates its use",
"severity": "minor",
"line": 26
}
] | 1 |
python | # See: https://github.com/yt-dlp/yt-dlp/pull/7094#discussion_r1199746041
self.http_server_thread.daemon = True
self.http_server_thread.start()
# HTTPS server
certfn = os.path.join(TEST_DIR, 'testcert.pem')
self.https_httpd = http.server.ThreadingHTTPServer(
('127.0.0... | Review this code and list any quality issues. | [] | 0 |
python | if match_exception(err):
return
raise
else:
break
if is_playlist:
self.assertTrue(res_dict['_type'] in ['playlist', 'multi_video'])
self.assertTrue('entries' in res_dict)
expect_i... | Review this code and list any quality issues. | [
{
"issue": "these messages are incorrect because if there is `playlist_count` or `playlist_maxcount` in the `test_case`, then we are never extracting all of the entries (we are only extracting 1 more than the expected count)",
"severity": "critical",
"line": 26
}
] | 1 |
python | q = df.lazy().select(
pl.col("a").list.eval(
(op(pl.element(), pl.element().cast(inner_dtype))).cast(target_dtype)
)
)
assert q.collect_schema() == q.collect().schema
def test_lit_cast_arithmetic_23677() -> None:
df = pl.DataFrame({"a": [1]}, schema={"a": pl.Float32})
q = d... | Review this code and list any quality issues. | [
{
"issue": "Minor note - I was unable to find a way to cast directly to the right underlying Unknown variant from pytest, hence the branhing workaround. In the end state, we need both the default path and the explicit schema/cast path, and it would be nice to do so from the type system parametrization.",
"s... | 1 |
python | "write_to": "_black_version.py",
"write_to_template": 'version = "{version}"\n',
},
description="The uncompromising code formatter.",
long_description=get_long_description(),
long_description_content_type="text/markdown",
keywords="automation formatter yapf autopep8 pyfmt gofmt rustfmt",
... | Review this code and list any quality issues. | [
{
"issue": "Prefer to do it like in https://github.com/python/typing/commit/f254d69c56920819b4211f47fdaba6472097dc5c",
"severity": "minor",
"line": 26
}
] | 1 |
python | # coding: utf-8
from __future__ import unicode_literals
from .common import InfoExtractor
from ..utils import (
int_or_none,
parse_duration,
parse_iso8601,
unescapeHTML,
)
class MoviepilotIE(InfoExtractor):
_IE_NAME = "moviepilot"
_IE_DESC = "Moviepilot trailer"
_VALID_URL = r'https?://(?... | Review this code and list any quality issues. | [
{
"issue": "use single quotes everywhere. Make sure you have read the contributing guidelines",
"severity": "minor",
"line": 14
}
] | 1 |
python | 'params': {'skip_download': 'm3u8'},
}, {
'url': 'https://player.glomex.com/integration/1/iframe-player.html?origin=fullpage&integrationId=19syy24xjn1oqlpc&playlistId=rl-vcb49w1fb592p&playlistIndex=0',
'info_dict': {
'id': 'rl-vcb49w1fb592p',
},
'playlist_count': 100,
... | Review this code and list any quality issues. | [
{
"issue": "I simplified the regex a bit. Not entirely sure nothing is broken due to lack of tests. Please confirm",
"severity": "critical",
"line": 26
}
] | 1 |
python | # lot of duplication of memory.
# There is no need copy X if the model is fit without an intercept.
copy_X = self.copy_X and self.fit_intercept # TODO: Sample_weights?
check_y_params = dict(
copy=False, dtype=[np.float64, np.float32], ensure_2d=False
)
if isinstance... | Review this code and list any quality issues. | [] | 0 |
python | pd.col("a") | False,
[True, False, True, False],
"(col('a') | False)",
),
(
pd.col("a") ^ pd.col("b"),
[True, True, False, True],
"(col('a') ^ col('b'))",
),
(
pd.col("a") ^ True,
[False, True, False, Tru... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\n) -> None:\n # https://github.com/pandas-dev/pandas/issues/63322\n df = pd.DataFrame({\"a\": [True, False, True, False], \"b\": [False, True, True, True]})\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | capture_event("mem0.delete_all", self, {"filters": len(filters)})
memories = self.vector_store.list(name=self.collection_name, filters=filters)[0]
for memory in memories:
self._delete_memory_tool(memory.id)
return {'message': 'Memories deleted successfully!'}
def history(self, m... | Review this code and list any quality issues. | [
{
"issue": "can you please change this to md5 checksum of the data supplied in?",
"severity": "minor",
"line": 26
}
] | 1 |
python | write_back=black.WriteBack.YES,
mode=DEFAULT_MODE,
)
except io.UnsupportedOperation:
pass # StringIO does not support detach
assert output.getvalue() == ""
def test_invalid_cli_regex(self) -> None:
for option in ["--include", "--e... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n def test_required_version_does_not_match_on_minor_version(self) -> None:\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | Determines whether a tip is added to the end of the line.
tip_width : :class:`float`
The width of the tip.
tip_height : :class:`float`
The height of the tip.
include_numbers : :class:`bool`
Determines whether numbers are added to tick marks. The number of decimal places is determined... | Review this code and list any quality issues. | [
{
"issue": "This should make the docs render. \r\n```suggestion\r\n :save_last_frame:\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | "--arg", default=((1, 2), (3, 4)), nargs=2, multiple=True, type=click.INT
)
def cli(arg):
for a, b in arg:
click.echo(f"<{a:d}|{b:d}>")
result = runner.invoke(cli, [])
assert not result.exception
assert result.output.splitlines() == ["<1|2>", "<3|4>"]
def test_multiple_flag_de... | Review this code and list any quality issues. | [] | 0 |
python | "ci": "CI/CD configuration",
"revert": "Reverting a previous commit",
}
def validate_commit_message(message: str) -> dict:
"""Validate a commit message against conventional commit format.
Args:
message: The commit message to validate.
Returns:
A dictionary with validation results.
... | Review this code and list any quality issues. | [
{
"issue": "The split operation on line 42 will fail if the subject contains multiple colons. For example, \"feat: add API: version 2\" would split incorrectly. Use maxsplit=1 to ensure only the first colon is used as the separator: `subject.split(\":\", 1)`",
"severity": "critical",
"line": 26
}
] | 1 |
python | assert NumberPlane().dimension == 2
assert PolarPlane().dimension == 2
assert ComplexPlane().dimension == 2
assert ThreeDAxes().dimension == 3
def test_abstract_base_class():
"""Check that CoordinateSystem has some abstract methods."""
with pytest.raises(Exception):
CS().get_axes()
def t... | Review this code and list any quality issues. | [] | 0 |
python | rgba = gc.get_rgb()
if len(rgba) == 3 or gc.get_forced_alpha():
rgba = rgba[:3] + (gc.get_alpha(),)
gc1 = self.new_gc()
gc1.set_linewidth(0)
for dx, dy, w, h in parse.rects: # dy is upwards & the rect top side.
path = Path._create_closed(
... | Review this code and list any quality issues. | [
{
"issue": "If this were trimmed to integers (`int(x), int(self.height - y)`) then for `boxarrow_test_image`, all but the first letter in each string remain the same as the old images. I guess keeping the fractional part (i.e., as its written now) gives us the proper sub-pixel positioning?",
"severity": "mi... | 1 |
python | 'referer': '',
'region': 'US',
'screen_height': '1080',
'screen_width': '1920',
'secUid': sec_uid,
'type': '1', # pagination type: 0 == oldest-to-newest, 1 == newest-to-oldest
'tz_name': 'UTC',
'verifyFp': 'verify_%s' % ''.join(random.... | Review this code and list any quality issues. | [
{
"issue": "As I said on discord, this isn't necessary to get `tiktokuser:` working, but I leave it to your discretion",
"severity": "minor",
"line": 26
}
] | 1 |
python | r'SAMLRequest\s*=\s*"(?P<saml_request>.+?)";',
saml_login_page, 'SAMLRequest', group='saml_request')
login_json = {
mso_info['username_field']: username,
mso_info['password_field']: password,
'RelayState'... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n # SlingTV has a meta-refresh based authentication, but also\r\n```",
"severity": "critical",
"line": 26
}
] | 1 |
python | def run(self):
"""
The method that will be executed in the process.
"""
pass
def cleanup(self):
"""
Implement this method on a subclass to do post-execution cleanup,
e.g. disconnecting from a database or terminating child processes.
"""
pass
... | Review this code and list any quality issues. | [] | 0 |
python | path_pdf = path_output.joinpath("_build", "pdf")
assert path_html.joinpath("index.html").exists()
assert path_pdf.joinpath("book.pdf").exists()
# test for page
path_page = path_tests.parent.joinpath("jupyter_book", "book_template").joinpath(
"markdown.md"
)
cmd = f"{path_page} --path-ou... | Review this code and list any quality issues. | [] | 0 |
python | [
(
{},
{'weight': 0.2, 'circuit': {'state': CBState.CLOSED}},
{'weight': 0.7, 'circuit': {'state': CBState.CLOSED}},
{'weight': 0.5, 'circuit': {'state': CBState.CLOSED}},
),
],
indirect=True,
)
... | Review this code and list any quality issues. | [] | 0 |
python | else:
resolved_root_hash = root_hash
merkle_blob = await self.get_merkle_blob(store_id=store_id, root_hash=resolved_root_hash)
kid, vid = merkle_blob.get_node_by_hash(node_hash)
return await self.get_terminal_node(kid, vid, store_id)
async def get_first_generation(self, node_ha... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n kv_ids_unpacked = (\r\n KeyOrValueId(id.raw)\r\n for node_hash in node_hashes\r\n for id in merkle_blob.get_node_by_hash(node_hash)\r\n )\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | label: use the label data to get the indices of every class.
spatial_size: spatial size of the ROIs to be sampled.
num_samples: total sample centers to be generated.
label_spatial_shape: spatial shape of the original label data to unravel selected centers.
indices: sequence of pre-comput... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n indices = map_classes_to_indices(label, num_classes, image, image_threshold, max_samples_per_class)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | import inspect
from . import _api
def kwarg_doc(text):
"""
Decorator for defining the documentation used when artist properties are
passed through as keyword arguments.
See e.g. the ``**kwargs`` section in `.Axes.text`.
The given text is stored in a privat variable ``_kwarg_doc`` on the method.... | Review this code and list any quality issues. | [
{
"issue": "Having a little bit of trouble following this - is there a more direct way of saying what this decorator does? \r\nMy reading is that the decorator stores documentation for the Artist property and the documentation stored on the decorator is what populates interpolated fields for that Artist?",
... | 1 |
python | from __future__ import unicode_literals
from .common import InfoExtractor
from ..utils import (
traverse_obj,
ExtractorError,
unified_timestamp,
)
class PixivSketchBaseIE(InfoExtractor):
def _call_api(self, video_id, path, referer):
response = self._download_json(f'https://sketch.pixiv.net/ap... | Review this code and list any quality issues. | [
{
"issue": "these tests doesnt seem to have ever been actually run!?",
"severity": "minor",
"line": 26
}
] | 1 |
python | return False
elif res == "sat":
model = z3_model_to_sympy_model(s.model(), expr)
has_theory_preds = any(is_supported_predicate(pred) for pred in expr.encoding.keys())
if has_theory_preds:
return True
if model:
return model
return True
def z3_model_... | Review this code and list any quality issues. | [
{
"issue": "I'm pretty sure there will never be any UndefinedFunctions -- there should only every be AppliedUndef",
"severity": "minor",
"line": 26
}
] | 1 |
python | import operator as op
import random
import sys
import types
import warnings
from functools import reduce
from math import ceil
from pathlib import Path
from typing import (
TYPE_CHECKING,
Callable,
Dict,
Iterable,
List,
Optional,
Sequence,
Tuple,
Type,
TypeVar,
Union,
)
impo... | Review this code and list any quality issues. | [
{
"issue": "relative imports\r\n```suggestion\r\nfrom ..animation.animation import override_animation\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | # iframe api.play-backend.iprima.cz
'url': 'https://prima.iprima.cz/my-little-pony/mapa-znameni-2-2',
'only_matching': True,
}, {
# iframe prima.iprima.cz
'url': 'https://prima.iprima.cz/porady/jak-se-stavi-sen/rodina-rathousova-praha',
'only_matching': True,
}, {
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n self.raise_login_required('Login is required to access any iPrima content', method='password')\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | recursive_check(optimizer.state_dict(), new_optimizer.state_dict())
ckpt_io.load_lr_scheduler(new_scheduler, lr_scheduler_ckpt_tempfile.name)
recursive_check(scheduler.state_dict(), new_scheduler.state_dict())
def run_dist(rank, world_size, port):
colossalai.launch(config=(dict()), rank=rank, wor... | Review this code and list any quality issues. | [
{
"issue": "This can be simplified as `assert torch.equal(v[i], d2[k][i])`",
"severity": "minor",
"line": 26
}
] | 1 |
python | Given a `page` list of objects, a nested dictionary of user_capabilities
are returned by id, ex.
{
4: {'edit': True, 'start': True},
6: {'edit': False, 'start': False}
}
Each capability is produced for all items in the page in a single query
Examples of prefetch language:
prefet... | Review this code and list any quality issues. | [] | 0 |
python | with importlib.resources.open_text("pip._vendor", "vendor.txt") as f:
# Purge non version specifying lines.
# Also, remove any space prefix or suffixes (including comments).
lines = [
line.strip().split(" ", 1)[0] for line in f.readlines() if "==" in line
]
# Transform i... | Review this code and list any quality issues. | [
{
"issue": "Should we also check the Python version?",
"severity": "minor",
"line": 26
}
] | 1 |
python | # Debugging
You can override the destination of the metrics to stdout with:
AWS_EMF_NAMESPACE=$USER-test
AWS_EMF_ENVIRONMENT=local ./tools/devtest test
# References:
- https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Embedded_Metric_Format_Specification.html
- https://github.com/aws... | Review this code and list any quality issues. | [] | 0 |
python | filename_real_ext = os.path.splitext(filename)[1][1:]
filename_wo_ext = (
os.path.splitext(filename)[0]
if filename_real_ext in (old_ext, new_ext)
else filename)
return f'{filename_wo_ext}... | Review this code and list any quality issues. | [
{
"issue": "This should be handled in FFmpegFD imo since the two formats could need different headers in theory",
"severity": "minor",
"line": 26
}
] | 1 |
python | def set_test_params(self):
self.num_nodes = 1
self.extra_args = [[
'-txindex','-permitbaremultisig=0',
]] * self.num_nodes
self.supports_cli = False
def check_mempool_result(self, result_expected, *args, **kwargs):
"""Wrapper to check result of testmempoolaccept ... | Review this code and list any quality issues. | [
{
"issue": "Could have a test with the `True` case?",
"severity": "minor",
"line": 26
}
] | 1 |
python | self._unflatten_partitioned_parameters(sub_group_id)
else:
self._partitioned_params_swap_out(sub_group_id)
def override_loss_scale(self, loss_scale):
if loss_scale != self.external_loss_scale:
logger.info(f'[deepspeed] setting loss scale from {self.external_loss_scale} -> {l... | Review this code and list any quality issues. | [
{
"issue": "I just noticed that `torch.norm` is deprecated. Is there any reason not to use the recommended replacements? \r\n",
"severity": "minor",
"line": 26
}
] | 1 |
python | def _get_process_by_port(port):
if platform.system() == "Windows":
command = f"netstat -ano | findstr :{port}"
result = subprocess.run(command, shell=True, capture_output=True, text=True)
if result.returncode == 0:
output = result.stdout.strip()
lines = output.split("... | Review this code and list any quality issues. | [] | 0 |
python | # MOV dword ptr [EBP + local_*], 0x65
if insn.getMnemonicString().startswith("MOV"):
found = all(insn.getOperandType(i) == mov_its_ops[i] for i in range(2))
return found
def bb_contains_stackstring(bb: ghidra.program.model.block.CodeBlock) -> bool:
"""check basic block for stackstring indicators
... | Review this code and list any quality issues. | [
{
"issue": "I found that `getCodeUnits` worked in a similar manner. I just got the Iterator in reverse order, then pulled the first instruction. This also eliminated the possibility of having NoneTypes returned as well.",
"severity": "minor",
"line": 26
}
] | 1 |
python | new_name = self.map_tensor_name(merged_name)
tensors.append((new_name, data_torch))
return tensors
else:
return []
return [(self.map_tensor_name(name), data_torch)]
def prepare_tensors(self):
super().prepare_tensors()
if sel... | Review this code and list any quality issues. | [] | 0 |
python | ----------
args
Animations to be played.
subcaption
The content of the external subcaption that should
be added during the animation.
subcaption_duration
The duration for which the specified subcaption is
added. If ``None`` (the defaul... | Review this code and list any quality issues. | [
{
"issue": "I think it would be better to use the conventional update method for dicts, the `|` syntax was only introduced with like Python 3.9 and up, no? Without a corresponding `__future__` import, this will break Manim on Python 3.7 + 3.8.",
"severity": "critical",
"line": 26
}
] | 1 |
python | _CellValue: TypeAlias = int | float | str | bool | time | date | datetime | timedelta
class CalamineReader(BaseExcelReader["CalamineWorkbook"]):
def __init__(
self,
filepath_or_buffer: FilePath | ReadBuffer[bytes],
storage_options: StorageOptions | None = None,
engine_kwargs: dict ... | Review this code and list any quality issues. | [
{
"issue": "Can you indent this entire description?",
"severity": "minor",
"line": 26
}
] | 1 |
python | elif limit > 100:
limit = 100
query.limit = Constant(limit)
df = db_handler.dispatch_select(query, conditions)
df = self.addapt_result_columns(df)
logger.debug(f"Query returned {len(df)} rows")
logger.debug(f"Columns in response: {df.columns.tolist()}")
... | Review this code and list any quality issues. | [
{
"issue": "`dispatch_keyword_select` accepts only 2 params",
"severity": "minor",
"line": 26
}
] | 1 |
python | # In the following, we will use ``type(xyz) is xyz_type`` instead of
# isinstance checks to make sure no subclasses of the type pass the
# check
# ruff: noqa: E721
def parse_module_attributes() -> tuple[AliasDocsDict, DataDict, TypeVarDict]:
"""Read all files, generate Abstract Syntax Trees from them, and
ext... | Review this code and list any quality issues. | [
{
"issue": "Don't forget to add a description to the new returned variable (btw I noticed that I missed the `:class:` prefixes for the return values and other stuff, I intend to fix it in another PR):\r\n```suggestion\r\n \r\n TYPEVAR_DICT : `TypeVarDict`\r\n A dictionary containing the definitions... | 1 |
python | if TORCHXLA_AVAILABLE:
import torch_xla.core.xla_model as xm
else:
xm = None
def inner_f(queue, func, *args, **kwargs): # pragma: no cover
try:
queue.put(func(*args, **kwargs))
except Exception:
traceback.print_exc()
queue.put(None)
def pl_multi_process(func):
@functools... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n return\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | model.config.max_sequence_length = 8192
tokenizer = AutoTokenizer.from_pretrained(
model_path, trust_remote_code=True, revision=revision
)
return model, tokenizer
def get_default_conv_template(self, model_path: str) -> Conversation:
return get_conv_template("internlm-cha... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n return \"mistral\" in model_path.lower()\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | '--dockerfile',
],
'hub push': [
'--help',
'--no-usage',
'--verbose',
'--dockerfile',
'--tag',
'--protected-tag',
'--force-update',
'--force',
'--build-env',
'--secret',
'-... | Review this code and list any quality issues. | [
{
"issue": "Is this related to these other changes?",
"severity": "minor",
"line": 26
}
] | 1 |
python | """
# 1. Apply migrations up to the point *before* the 0202_squashed_deletions migration.
# This simulates the state where the problematic CredentialType might exist.
# We use 0201_create_managed_creds as the direct predecessor.
old_state = migrator.apply_tested_migration(('main', '0201_... | Review this code and list any quality issues. | [
{
"issue": "IMO, the error on superuser creation was extremely secondary to the original issue. And the credential plugin loading is likely mocked in tests anyway, I don't trust that you would have reproduced the bug here without the fix.\r\n\r\nI would say, just focus on detecting that the credential had its `... | 1 |
python | uds: str = None,
local_address: str = None,
retries: int = 0,
backend: str = "sync",
) -> None:
ssl_context = create_ssl_context(verify=verify, cert=cert, trust_env=trust_env)
self._pool = core.ConnectionPool(
ssl_context=ssl_context,
max_connections=... | Review this code and list any quality issues. | [] | 0 |
python | }]
@staticmethod
def _sanitize_urls(urls):
# add protocol if missing and clean iframes urls
for url in urls:
url = sanitize_url(url, scheme='https')
url = urljoin(base_url(url), url_basename(url))
return urls
@classmethod
def _extract_embed_urls(cls, url... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n /(?!video-embed/)[^?#]+?/(?P<id>[^/\\?]+)(?=\\?|/$|$)'''\r\n```\r\nURLs can technically have space. `.+?` is fine when matching against URL. The problem is when matching against large data (i.e, webpage)",
"severity": "minor",
"line": 26
}
] | 1 |
python | model_a_b, changed, unchanged = copy_model_state(
model_a, model_b, exclude_vars="conv_0.conv_0", inplace=False)
# dst model updated: 76 of 82 variables.
model_a.load_state_dict(model_a_b)
# <All keys matched successfully>
Returns: an OrderedDict of the updated `... | Review this code and list any quality issues. | [
{
"issue": "this `zip` assumes 1 to 1 mapping for the first N keys, I can see in practice there could be missing keys in the middle of `dst_keys` or `src_keys` and will cause mismatches... in my opinion defining this kind of search pattern is complicated, but if there's a use case I'm fine with this new feature... | 1 |
python | }
)
async def test_openai_auto_mode_multiple_thinking_parts_same_field(allow_model_requests: None):
"""Test that auto mode correctly groups multiple thinking parts from the same field."""
# Test that multiple thinking parts with the same field id get grouped correctly
c1 = completion_message(
... | Review this code and list any quality issues. | [
{
"issue": "please use a snapshot here and below",
"severity": "minor",
"line": 26
}
] | 1 |
python | evaluation_fn = self._get_custom_evaluation_fn(evaluation_fn_name)
custom_kwargs = self._merge_kwargs(kwargs, task_params.eval_kwargs)
self._validate_custom_kwargs(
custom_kwargs=custom_kwargs,
evaluation_fn=evaluation_fn,
evaluation_fn_name=evalua... | Review this code and list any quality issues. | [
{
"issue": "I know you don't want to advertise the EvaluationResult option, but without mentioning it, this error isn't correct. Could you still mention it here? You could highlight that the dict is preferred though.",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'url': 'https://steviasphere.bandcamp.com/music',
'playlist_mincount': 47,
'info_dict': {
'id': 'steviasphere',
'title': 'Discography of steviasphere',
},
}, {
'url': 'https://coldworldofficial.bandcamp.com/music',
'playlist_mincount': 10,
'inf... | Review this code and list any quality issues. | [
{
"issue": "I would instead use a generator method to yield all the url paths\r\n```suggestion\r\n def _yield_items(self, webpage):\r\n yield from (\r\n re.findall(r'<li data-item-id=[\"\\'][^>]+>\\s*<a href=[\"\\'](?![^\"\\'/]*?/merch)([^\"\\']+)', webpage)\r\n or re.findall(r'<... | 1 |
python | """Test that two overlapping tensors sharing the same underlying storage produce a
single NIXL registration. When each tensor's ref goes out of scope via
garbage_collect, the metadata_count decrements. After both are freed,
the registration is removed."""
from unittest.mock import MagicMock, patch
... | Review this code and list any quality issues. | [
{
"issue": "why do you need to mock out the worker in the tests?",
"severity": "minor",
"line": 26
}
] | 1 |
python | if video_url is None or video_id is None:
return info_dict
base_name = 'clip' if '/clips/' in video_url else 'montage'
info_dict['webpage_url'] = f'https://allstar.gg/{base_name}?{base_name}={video_id}'
info_dict['webpage_url_basename'] = base_name
return info_dict
def... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n profile_data = self._download_json(\r\n urljoin('https://api.allstar.gg/v1/users/profile/', display_id), display_id)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | __module_test__ = "tex_mobject"
@frames_comparison
def test_color_inheritance(scene):
"""Test that Text and MarkupText correctly inherit colour from
their parent class.
"""
VMobject.set_default(color=RED)
tex = Tex("test color inheritance")
mathtex = MathTex("test color inheritance")
vgr =... | Review this code and list any quality issues. | [] | 0 |
python | name: str = ...,
permissions: Permissions = ...,
color: Union[Colour, int] = ...,
hoist: bool = ...,
display_icon: Union[bytes, str] = MISSING,
mentionable: bool = ...,
secondary_color: Union[Colour, int, None] = ...,
tertiary_color: Union[Colour, int, None] = ...... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n secondary_color: Optional[Union[Colour, int]] = MISSING,\r\n tertiary_color: Optional[Union[Colour, int]] = MISSING,\r\n secondary_colour: Optional[Union[Colour, int]] = MISSING,\r\n tertiary_colour: Optional[Union[Colour, int]] = MISSING,\r\n```",
"... | 1 |
python | self._channel.send(command)
_logger.info('Reconnected.')
return
except Exception as e:
_logger.exception(e)
_logger.error('Failed to reconnect.')
raise RuntimeError('Connection lost')
def _receive(self) -> tuple[CommandType, str] | tuple[N... | Review this code and list any quality issues. | [
{
"issue": "Suggest adding logs at every retrying.",
"severity": "minor",
"line": 26
}
] | 1 |
python | try:
assert self.address
device = bluetooth.async_ble_device_from_address(
self.hass, self.address, connectable=True
) or await get_device(self.address)
mower = Mower(
reauth_entry.data[CONF_CLIENT_ID], self.address... | Review this code and list any quality issues. | [
{
"issue": "This syntax is invalid in Python 3. Multiple exceptions must be enclosed in parentheses. The correct syntax is `except (TimeoutError, BleakError):` not `except TimeoutError, BleakError:`. This change will cause a SyntaxError at runtime.",
"severity": "major",
"line": 26
}
] | 1 |
python | )
# Associations of these types are ordered and have special consideration in the modified associations function
ordered_associations = ['instance_groups', 'galaxy_credentials']
short_params = {
'host': 'controller_host',
'username': 'controller_username',
'password': 'controller_pas... | Review this code and list any quality issues. | [
{
"issue": "Why have `controller` in here? If you are using `/api/controller/` you are using Gateway.",
"severity": "minor",
"line": 26
}
] | 1 |
python | .. versionadded:: 0.10.0
Examples
--------
>>> from scipy.linalg import invhilbert
>>> invhilbert(4)
array([[ 16., -120., 240., -140.],
[ -120., 1200., -2700., 1680.],
[ 240., -2700., 6480., -4200.],
[ -140., 1680., -4200., 2800.]])
>>> invhilbert(4,... | Review this code and list any quality issues. | [] | 0 |
python | if mlflow_run.info.end_time is not None
else None
)
def __repr__(self):
name = self.__class__.__name__
space_length = len(name) + 1
return "{name}(info={info},\n{space}uri={uri},\n{space}artifact_uri={artifact_uri},\n{space}client={client})".format(
... | Review this code and list any quality issues. | [
{
"issue": "If the funtion aims to get the path in a filesystem, it should raise error(e.g. NotImplementError) when the uri is not file system.\r\n\r\nBesides, the `root_uri` is not a good name for user.",
"severity": "minor",
"line": 26
}
] | 1 |
python | kwargs['param_visibilities'] = task._get_param_visibilities()
self._scheduler.add_task(*args, **kwargs)
logger.info('Informed scheduler that task %s has status %s', task_id, status)
def __enter__(self):
"""
Start the KeepAliveThread.
"""
self._keep_alive_thre... | Review this code and list any quality issues. | [] | 0 |
python | def _real_extract(self, url):
video_id = self._match_id(url)
webpage = self._download_webpage(url, video_id)
entry_id = self._html_search_meta('entryId', webpage, 'entryId', fatal=True)
video_info = self._download_json(
f'https://learn.microsoft.com/api/video/public/v1/entri... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n _VALID_URL = r'https?://learn\\.microsoft\\.com/(?:[\\w-]+/)?events/[\\w-]+/(?P<id>[^?#/]+)'\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | """
if TYPE_CHECKING:
_protocol_check: ClassVar[BlocksProtocol] = cast("AugmentedBlockchain", None)
_underlying: BlocksProtocol
_extra_blocks: dict[bytes32, tuple[FullBlock, BlockRecord]]
_height_to_hash: dict[uint32, bytes32]
def __init__(self, underlying: BlocksProtocol) -> None:
... | Review this code and list any quality issues. | [
{
"issue": "my model of errors is that an `assert` failing indicates a bug, but any other exception being raised is not necessarily a bug. Which makes me ask this question: I would expect this violation of precondition to be a bug, is it still?",
"severity": "critical",
"line": 26
}
] | 1 |
python | ret = '\n'.join(''.join(row).rstrip() for row in table)
return ret
def _match_one(filter_part, dct, incomplete):
# TODO: Generalize code with YoutubeDL._build_format_filter
STRING_OPERATORS = {
'*=': operator.contains,
'^=': lambda attr, value: attr.startswith(value),
'$=': lambda ... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n fcntl.flock(f,\r\n fcntl.LOCK_SH if not exclusive\r\n else fcntl.LOCK_EX if block\r\n else fcntl.LOCK_EX | fcntl.LOCK_NB)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | # Copyright (c) MONAI Consortium
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# http://www.apache.org/licenses/LICENSE-2.0
# Unless required by applicable law or agreed to in writing, so... | Review this code and list any quality issues. | [
{
"issue": "Looks like this docstring is no longer true:\r\n```\r\nworker: number of workers to use for parallel processing. If device is cuda/GPU, worker has\r\n to be 0.\r\n```",
"severity": "minor",
"line": 1
}
] | 1 |
python | if indptr_diff.dtype.itemsize > np.dtype(np.intp).itemsize:
# Check for potential overflow
indptr_diff_limited = indptr_diff.astype(np.intp)
if np.any(indptr_diff_limited != indptr_diff):
raise ValueError("Matrix too big to convert")
indptr_diff = indptr_d... | Review this code and list any quality issues. | [] | 0 |
python | import json
import re
from .common import InfoExtractor
from ..utils import (
ExtractorError,
get_element_by_id,
)
class MaveIE(InfoExtractor):
_VALID_URL = r'https?://(?P<channel_id>[a-z]+)\.mave\.digital/ep-(?P<short_id>[0-9]+)'
_TESTS = [
{
'url': 'https://ochenlichnoe.mave.dig... | Review this code and list any quality issues. | [
{
"issue": "IMO we should relax the subdomain character class and capture the whole slug\r\n```suggestion\r\n _VALID_URL = r'https?://(?P<channel>[\\w-]+)\\.mave\\.digital/(?P<id>ep-\\d+)'\r\n```",
"severity": "minor",
"line": 12
}
] | 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.