language string | code-snippit string | instruction string | flaws list | flaw_count int64 |
|---|---|---|---|---|
python | Deadline.dagrun_id == dagrun.id,
Deadline.missed == false(),
)
).all()
if not deadlines:
return
for deadline in deadlines:
if deadline.deadline_alert_id:
if deadline_alert := session.get(DeadlineAlertModel, deadline.deadline_alert_id):
refere... | Review this code and list any quality issues. | [
{
"issue": "Should not we commit the new deadline time?",
"severity": "minor",
"line": 26
}
] | 1 |
python | class CurvesAsSubmobjects(VGroup):
"""Convert a curve's elements to submobjects.
Examples
--------
.. manim:: LineGradientExample
:save_last_frame:
class LineGradientExample(Scene):
def construct(self):
curve = ParametricFunction(lambda t: [t, np.sin(t), 0],... | Review this code and list any quality issues. | [
{
"issue": "I have not investigated closely, but it seems like this change includes a certain redundancy when it comes to the points of `self`: not only are the points added to the mobject itself, but they are also added as part of `self`'s submobjects. This is not good (as the mobject would, in this case, also... | 1 |
python | """Async I/O backend support utilities."""
import socket
import threading
import time
from collections import deque
from queue import Empty
from time import sleep
from weakref import WeakKeyDictionary
from kombu.utils.compat import detect_environment
from celery import states
from celery.exceptions import TimeoutErro... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\nclass EventletAdaptedEvent:\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | @given(dtype=dtypes(allowed_dtypes=[pl.List(pl.List), pl.Int64]))
def test_dtypes_allowed_uninstantiated_nested(dtype: pl.DataType) -> None:
assert dtype in (pl.List, pl.Int64)
@pytest.mark.parametrize(
"expr",
[
# TODO: Add more (bitwise) operators once their types are resolved correctly
... | Review this code and list any quality issues. | [
{
"issue": "I don't believe that this exhaustively covers each allowed datatype. I think I would prefer an exhaustive combination of data types, which you can initialize by just giving a `null` value.",
"severity": "minor",
"line": 26
}
] | 1 |
python | }
}
]
def _real_extract(self, url):
video_id = self._match_valid_url(url)
# TODO: This part could be smarter (Set and store age cookie?)
video_page = self._download_webpage(
'https://murrtube.net', None, note='Getting session token')
data = self._hidden_input... | Review this code and list any quality issues. | [
{
"issue": "Inline in the return. No need for variable",
"severity": "minor",
"line": 26
}
] | 1 |
python | max_seq_len = self.config.max_position_embeddings * rope_scaling_factor
else:
max_seq_len = 2048 * rope_scaling_factor
base = float(base)
# NTK ref: https://www.reddit.com/r/LocalLLaMA/comments/14lz7j5/ntkaware_scaled_rope_allows_llama_models_to_have/
try:
ntk_alpha = float(os.environ.... | Review this code and list any quality issues. | [
{
"issue": "you don't need to write `return` if you do not return anything.",
"severity": "minor",
"line": 26
}
] | 1 |
python | from __future__ import annotations
import logging
import pytest
from manim.utils.deprecation import deprecated, deprecated_params
def _get_caplog_record_msg(warn_caplog_manim):
logger_name, level, message = warn_caplog_manim.record_tuples[0]
return message
@pytest.fixture()
def warn_caplog_manim(caplog):... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n caplog.set_level(logging.WARNING, logger=\"manim\")\r\n```\r\n?\r\nAlso, I'm not a fan of the repetition of the `logger` stuff, what do you think about making a `logger` fixture?",
"severity": "minor",
"line": 19
}
] | 1 |
python | self._log_params(attrs)
if self.dataset_logger:
self.dataset_logger(self.dataset_dict)
else:
self._default_dataset_log(self.dataset_dict)
def _set_experiment(self):
experiment = self.experiment
if not experiment:
for _ in range(3):
... | Review this code and list any quality issues. | [
{
"issue": "Do we need a warning here?\r\n```\r\nlogger.warning(\"Experiment already exists; delaying before retrying.\")\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | self.log.debug("Wait for another, but time out, since the fee threshold is set now")
template7 = await wait_next_template(template6, stack, ctx, waitoptions)
assert template7 is None
self.log.debug("interruptWait should abort the current wait")
async def ... | Review this code and list any quality issues. | [
{
"issue": "In commit \"mining: enforce minimum reserved weight for IPC\" (d3db5285989f7b3fef7436a37ce928065be2804e)\n\nMight be nice to make exception more specific to expected error like:\n\n```diff\n--- a/test/functional/interface_ipc.py\n+++ b/test/functional/interface_ipc.py\n@@ -278,8 +278,9 @@ class IPCI... | 1 |
python | for mobj in re.finditer(r'(?s)<(p|div)\s+class="(?P<class>[^" ]+?)">(?P<value>.+?)</\1>', webpage)}
# since videos do not have title, give the name of song instead
data_dict['user_name'] = re.sub(r'\s*さん\s*$', '', data_dict['user_name'])
title = data_dict.get('song_title')
stream_tree ... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n 'upload_date': unified_strdate(self._search_regex(r'(\\d{4}/\\d{2}/\\d{2})', data_dict.get('date'), 'upload_date', default=None)),\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | def get_server(path_server: str, path_log: Optional[str]) -> dict:
if os.environ.get("LLAMA_ARG_HOST") is None:
logger.info("LLAMA_ARG_HOST not explicitly set, using 127.0.0.1")
os.environ["LLAMA_ARG_HOST"] = "127.0.0.1"
if os.environ.get("LLAMA_ARG_PORT") is None:
logger.info("LLAMA_ARG... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n raise RuntimeError(f\"llama.cpp server exited unexpectedly with exit code {exit_code}{path_log and f', see {path_log.format(port=port)}' or ''}\")\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | def _create_module_forward_pre_hook(self):
def _module_forward_pre_hook(module, inputs, kwargs):
return self._forward_prologue(inputs, kwargs)
return self.module.register_forward_pre_hook(_module_forward_pre_hook, prepend=False, with_kwargs=True)
def _create_module_forward_post_hook(s... | Review this code and list any quality issues. | [] | 0 |
python | else:
if not item_index.values[0].subscriptable() and not self.is_sequence:
# we're modifying a single sample, convert it to a list as chunk engine expects multiple samples
value = [value]
self.chunk_engine.update(
self.index[item_index],
... | Review this code and list any quality issues. | [
{
"issue": "not sure why we need separate logic for links?",
"severity": "minor",
"line": 26
}
] | 1 |
python | def compute_Ap(self):
damping_alpha_dt = self._damping_alpha * self._substep_dt
damping_alpha_factor = damping_alpha_dt + 1.0
damping_beta_over_dt = self._damping_beta / self._substep_dt
damping_beta_factor = damping_beta_over_dt + 1.0
for i_b, i_v in ti.ndrange(self._B, self.n_v... | Review this code and list any quality issues. | [
{
"issue": "You have multiple duplication of this pattern. Could this be factored in some private ti.func?",
"severity": "minor",
"line": 26
}
] | 1 |
python | self.iterative_pruner.task_generator._log_dir = Path(self._log_dir_root, 'SA')
self.iterative_pruner.reset(model, config_list=config_list, masks=masks)
def allocate_sparsity(self, new_config_list: List[Dict], model: Module, masks: Dict[str, Dict[str, Tensor]]):
self._iterative_pruner_reset(model, n... | Review this code and list any quality issues. | [
{
"issue": "why not simply provide a link to ADMMPruner?",
"severity": "minor",
"line": 26
}
] | 1 |
python | stop_temperature
Stop temperature of the simulated annealing process.
cool_down_rate
Cool down rate of the temperature.
perturbation_magnitude
Initial perturbation magnitude to the sparsities. The magnitude decreases with current temperature.
log_dir
... | Review this code and list any quality issues. | [
{
"issue": "There is a grammar problem, please fix it.",
"severity": "minor",
"line": 26
}
] | 1 |
python | from monai.networks.blocks import CrossAttentionBlock, MLPBlock, SABlock
class TransformerBlock(nn.Module):
"""
A transformer block, based on: "Dosovitskiy et al.,
An Image is Worth 16x16 Words: Transformers for Image Recognition at Scale <https://arxiv.org/abs/2010.11929>"
"""
def __init__(
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n hidden_size (int): dimension of hidden layer.\r\n mlp_dim (int): dimension of feedforward layer.\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | total_frames = int(video.get(cv2.CAP_PROP_FRAME_COUNT))
if end is not None and end > total_frames:
raise Exception("Requested frames are outbound")
start = max(start, 0)
end = min(end, total_frames) if end is not None else total_frames
video.set(cv2.CAP_PROP_POS_FRAMES, start)
return video, ... | Review this code and list any quality issues. | [
{
"issue": "I'd probably call it `iterative_seek`.",
"severity": "minor",
"line": 26
}
] | 1 |
python | _TESTS = [{
'url': 'https://www.qingting.fm/channels/378005/programs/22257411/',
'md5': '47e6a94f4e621ed832c316fd1888fb3c',
'info_dict': {
'id': '22257411',
'title': '用了十年才修改，谁在乎教科书？',
'channel_id': '378005',
'channel_name': '睡前消息',
'po... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n channel_id, pid = self._match_valid_url(url).group('channel', 'id')\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | if img.mode != "RGBA" or img.getextrema()[3][0] == 255:
img = img.convert("RGB")
return np.asarray(img)
def compare_images(expected, actual, tol, in_decorator=False):
"""
Compare two "image" files checking differences within a tolerance.
The two given filenames may point to files which are co... | Review this code and list any quality issues. | [
{
"issue": "I think what's important here is how these methods differ? (what's the takeaway supposed to be here?)",
"severity": "minor",
"line": 26
}
] | 1 |
python | from dask.dataframe.io import read_parquet, to_parquet
except ImportError:
pass
try:
from dask.dataframe.io import read_orc, to_orc
except ImportError:
pass
try:
from dask.dataframe.core import isna
except ImportError:
p... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\nThe new implementation is already available and you can opt-in with\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | response = self._download_json(
'https://www.freetv.com/wordpress/wp-admin/admin-ajax.php',
contentId,
'Downloading %s video JSON' % contentId,
data=urlencode_postdata(request_body),
fatal=False
)
if response is False:
return False... | Review this code and list any quality issues. | [
{
"issue": "1. Get rid of variables that are only used once\r\n2. Lack of video id/URL should throw error. So make their extraction fatal",
"severity": "major",
"line": 26
}
] | 1 |
python | for NumPy array and PyTorch Tensor, log the data shape and value range,
for other metadata, log the values directly. Default to `False`.
min_samples: minimum number of transforms to sample. Defaults to `0`.
max_samples: maximum number of transforms to sample. Defaults to `3`.
fixed: ... | Review this code and list any quality issues. | [
{
"issue": "I would initialise `self.active` here so that it always exists rather than popping in when `__call__` is called for the first time. It's initial value can just be `np.arange(self.n_transforms)`.",
"severity": "minor",
"line": 26
}
] | 1 |
python | )
if np.isclose(_convert_to_numpy(denominator, xp), 0):
warnings.warn(msg_zero_division, UndefinedMetricWarning, stacklevel=2)
return replace_undefined_by
expected = numerator / denominator
if weights is None:
w_mat = xp.ones([n_classes, n_classes], dtype=max_float_dtype, device=de... | Review this code and list any quality issues. | [
{
"issue": "following https://github.com/scikit-learn/scikit-learn/pull/31172#discussion_r2681625535\r\n```suggestion\r\n if denominator == 0:\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | def create_validator_instance(algo_type, builtin_name):
"""Create instance of validator class
Parameters
----------
algo_type: str
can be one of 'tuners', 'assessors'
builtin_name: str
builtin name.
Returns: object | None
-------
Returns validator class instance.
... | Review this code and list any quality issues. | [] | 0 |
python | # Copyright (c) Microsoft. All rights reserved.
import asyncio
from urllib.request import urlopen
try:
from PIL import Image
pil_available = True
except ImportError:
pil_available = False
from semantic_kernel import Kernel
from semantic_kernel.connectors.ai import PromptExecutionSettings
from semantic_k... | Review this code and list any quality issues. | [] | 0 |
python | self.assertEqual(
encrypted,
b'\x03\xc7\xdd\xd4\x8e\xb3\xbc\x1a*O\xdc1\x12+8Aio\xd1z\xb5#\xaf\x08')
def test_gcm_decrypt(self):
data = b'\x159Y\xcf5eud\x90\x9c\x85&]\x14\x1d\x0f.\x08\xb4T\xe4/\x17\xbd'
authentication_tag = b'\xe8&I\x80rI\x07\x9d}YWuU@:e'
decrypted =... | Review this code and list any quality issues. | [
{
"issue": "I don't like using `intlist_to_bytes` and `bytes_to_intlist` in new code:\r\n```suggestion\r\n decrypted = intlist_to_bytes(aes_gcm_decrypt_and_verify(\r\n list(data), self.key, list(authentication_tag), self.iv[:12]))\r\n self.assertEqual(decrypted.rstrip(b'\\x08'), self.se... | 1 |
python | # vk serves two same remixlhk cookies in Set-Cookie header and expects
# first one to be actually set
self._apply_first_set_cookie_header(url_handle, 'remixlhk')
login_page = self._download_webpage(
'https://vk.com/login', None,
note='Logging in',
data=urlenc... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n data['al'] = 1\r\n code, payload = self._download_json(\r\n f'https://vk.com/{path}.php', video_id,\r\n data=urlencode_postdata(data), fatal=fatal,\r\n headers={\r\n 'Referer': url,\r\n 'X-Requested-With':... | 1 |
python | from .common import InfoExtractor
from ..utils import ExtractorError
class NetAppBaseIE(InfoExtractor):
_ACCOUNT_ID = '6255154784001'
_VIDEO_METADATA_URL = 'https://api.media.netapp.com/client/detail/%s'
_COLLECTION_METADATA_URL = 'https://api.media.netapp.com/client/collection/%s'
_BC_URL = f'https:/... | Review this code and list any quality issues. | [
{
"issue": "Use regex to not match the whole URL",
"severity": "minor",
"line": 24
}
] | 1 |
python | ----------
axis : Index
groupings : Sequence[Grouping]
all the grouping instances to handle in this grouper
for example for grouper list to groupby, need to pass the list
sort : bool, default True
whether this grouper will give sorted result or not
"""
axis: Index
def ... | Review this code and list any quality issues. | [
{
"issue": "Curious why we need a carve-out for resample?",
"severity": "minor",
"line": 26
}
] | 1 |
python | SchemaOptional('op_types'): [str],
SchemaOptional('op_names'): [str],
SchemaOptional('op_partial_names'): [str]
}
GLOBAL_SCHEMA = {
'total_sparsity': And(float, lambda n: 0 <= n < 1),
SchemaOptional('max_sparsity_per_layer'): And(float, lambda n: 0 < n <= 1),
SchemaOptional('op_types'): [str],
... | Review this code and list any quality issues. | [
{
"issue": "`op_partial_names` should not in `INTERNAL_SCHEMA`",
"severity": "minor",
"line": 26
}
] | 1 |
python | https?://
(?:
(?:(?:live|afbbs|www)\.)?sooplive\.co\.kr(?::\d+)?
(?:
/app/(?:index|read_ucc_bbs)\.cgi|
/player/[Pp]layer\.(?:swf|html)
)\?.*?\bnTitl... | Review this code and list any quality issues. | [
{
"issue": "same as above\r\n```suggestion\r\n 'url': 'http://afbbs.afreecatv.com:8080/app/read_ucc_bbs.cgi?nStationNo=16711924&nTitleNo=36153164&szBjId=dailyapril&nBbsNo=18605867',\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | ) -> None:
self.sampling_states.apply_staged_writes()
self.penalties_state.apply_staged_writes(
prefill_token_ids, prefill_lens, prompt_lens
)
self.logit_bias_state.apply_staged_writes()
def __call__(
self,
logits: torch.Tensor,
idx_mapping: torch... | Review this code and list any quality issues. | [] | 0 |
python | import random
import itertools
import urllib.parse
from .common import InfoExtractor
from ..utils import (
int_or_none,
make_archive_id,
mimetype2ext,
parse_resolution,
str_or_none,
strip_jsonp,
traverse_obj,
url_or_none,
urlencode_postdata,
urljoin,
)
class WeiboBaseIE(InfoEx... | Review this code and list any quality issues. | [
{
"issue": "the `User-Agent` key will always exist in `params['http_headers']`\r\n```suggestion\r\n r'Chrome/(\\d+)', self.get_param('http_headers')['User-Agent'], 'user agent version', default='90')\r\n```",
"severity": "minor",
"line": 24
}
] | 1 |
python | def test_snapshot_rename_interface(uvm_nano, microvm_factory):
"""
Test that we can restore a snapshot and point its interface to a
different host interface.
"""
vm = uvm_nano
base_iface = vm.add_net_iface()
vm.start()
snapshot = vm.snapshot_full()
# We don't reuse the network names... | Review this code and list any quality issues. | [
{
"issue": "nit: not needed, as `restore_from_snapshot` already does this iirc",
"severity": "minor",
"line": 26
}
] | 1 |
python | self.execution_engine = execution_engine
def _canonicalize(self, _parents):
msg = '{} is not supposed to be set in Retiarii experiment by users, your config is {}.'
if self.search_space != '':
raise ValueError(msg.format('search_space', self.search_space))
# TODO: maybe we shoul... | Review this code and list any quality issues. | [
{
"issue": "according to line 73, this line does not take any effect. so why add it?",
"severity": "minor",
"line": 26
}
] | 1 |
python | entities_info=entities_info,
rigid_global_info=rigid_global_info,
constraint_state=constraint_state,
static_rigid_sim_config=static_rigid_sim_config,
)
func_terminate_or_update_descent_batch(
i_b,
constraint_state=constraint_state,
... | Review this code and list any quality issues. | [
{
"issue": "`_monolith` is not clear to me. What are you referring to with this keyword?",
"severity": "minor",
"line": 26
}
] | 1 |
python | Reconstruct the input array from the unique values and inverse:
>>> a = np.array([1, 2, 6, 4, 2, 3, 2])
>>> u, indices = np.unique(a, return_inverse=True)
>>> u
array([1, 2, 3, 4, 6])
>>> indices
array([0, 1, 4, 3, 1, 2, 1])
>>> u[indices]
array([1, 2, 6, 4, 2, 3, 2])
Reconstruct t... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n if ar.ndim == 1 or axis is None\r\n```\r\n\r\nA teeny bit more concisely and I think works out to the same thing in practice?",
"severity": "minor",
"line": 26
}
] | 1 |
python | new_name = self.map_tensor_name(merged_name)
tensors.append((new_name, data_torch))
return tensors
else:
return []
return [(self.map_tensor_name(name), data_torch)]
def prepare_tensors(self):
super().prepare_tensors()
if sel... | Review this code and list any quality issues. | [
{
"issue": "I thought they weren't permuted?",
"severity": "minor",
"line": 26
}
] | 1 |
python | head_size: int,
cos_sin_cache: torch.Tensor,
is_neox_style: bool,
offsets: torch.Tensor | None = None,
) -> None:
return
# Global flag to ensure ops are registered only once
_OPS_REGISTERED = False
class rocm_aiter_ops:
"""ROCm AITER operations wrapper for AMD GPU acceleration in vLLM.
This... | Review this code and list any quality issues. | [] | 0 |
python | def get_dotnet_managed_imports(pe: dnfile.dnPE) -> Iterator[DnType]:
"""get managed imports from MemberRef table
see https://www.ntcore.com/files/dotnetformat.htm
10 - MemberRef Table
Each row represents an imported method
Class (index into the TypeRef, ModuleRef, MethodDef, TypeSpec o... | Review this code and list any quality issues. | [
{
"issue": "should we do conversions like this once (where repeated)?",
"severity": "minor",
"line": 26
}
] | 1 |
python | def shuffle_submobjects(self, *args, **kwargs):
"""Shuffles the order of :attr:`submobjects`
Examples
--------
.. manim:: ShuffleSubmobjectsExample
class ShuffleSubmobjectsExample(Scene):
def construct(self):
s= VGroup(*[Dot().shift(i*0.... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n :meth:`.null_point_align`). If `skip_point_alignment` is false,\r\n they will also have the same number of points (see :meth:`.align_points`).\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | metadata_keys_to_exclude_from_context = [
"token_count",
"metadata_token_count",
]
metadata_for_context = {}
for k in chunk_metadata_keys_to_include_from_context:
metadata_for_context[k] = getattr(chunk.chunk_metadata, k)
fo... | Review this code and list any quality issues. | [
{
"issue": "I'm not sure why document_id would be in chunk_metadata vs metadata, or even what distinguishes the two metadatas :( , but can we move this to a @property method of `Chunk`?",
"severity": "major",
"line": 26
}
] | 1 |
python | def test_entire_notebook_without_changes() -> None:
with open(DATA_DIR / "notebook_without_changes.ipynb", "rb") as fd:
content_bytes = fd.read()
content = content_bytes.decode()
with pytest.raises(NothingChanged):
format_file_contents(content, fast=True, mode=JUPYTER_MODE)
def test_non_py... | Review this code and list any quality issues. | [
{
"issue": "this didn't pass when I tried running the CI checks in a fork, I had to use\r\n```\r\n'{re.escape(str(path))}'\r\n```\r\ninstead of\r\n```\r\n'{path}'\r\n```\r\n\r\nhttps://github.com/MarcoGorelli/black/pull/1",
"severity": "critical",
"line": 26
}
] | 1 |
python | b = np.arange(-6, 0).reshape((3, 2))
assert_raises(ValueError, signal.correlate2d, *(a, b), **{'mode': 'valid'})
assert_raises(ValueError, signal.correlate2d, *(b, a), **{'mode': 'valid'})
@make_xp_test_case(signal.correlate2d)
def test_complex_input(self, xp):
xp_assert_equal(signal.c... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n lfilter_zi(b=1, a=xp.asarray([0, 0, 0]))\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | return {
'url': url,
**extracted,
}
def _real_extract(self, url):
creator = self._match_id(url)
creator_id = self._get_creator_id(creator)
playback_data = self._get_live_playback_data(creator_id)
if not playback_data['is_live']:
raise Use... | Review this code and list any quality issues. | [
{
"issue": "I would again simplify this in to a single function.\r\nOne change of note for discord URLs we need to replace the `/` as `%23` (url encoded #)\r\nYou can also directly pass the timestamp in the info dict. The core code will then populate the `upload_date`\r\n```suggestion\r\n\r\n def _real_extra... | 1 |
python | x = torch.randn(1, 2, 3, 1, requires_grad=False).int()
self.checkExportImport(SimpleOp(), (x, ))
def test_basic_instancenorm_2d(self):
class SimpleOp(nn.Module):
def __init__(self):
super().__init__()
def forward(self, x):
out... | Review this code and list any quality issues. | [
{
"issue": "the unittest should be put in `test_model_speedup.py` and test whether speedup works for these two ops.",
"severity": "minor",
"line": 26
}
] | 1 |
python | )
from .netverse import (
NetverseIE,
NetversePlaylistIE,
NetverseSearchIE,
)
from .netzkino import NetzkinoIE
from .newgrounds import (
NewgroundsIE,
NewgroundsPlaylistIE,
NewgroundsUserIE,
)
from .newspicks import NewsPicksIE
from .newsy import NewsyIE
from .nextmedia import (
AppleDailyIE... | Review this code and list any quality issues. | [] | 0 |
python | import itertools
import json
import random
import string
from .common import InfoExtractor
from ..utils import (
ExtractorError,
format_field,
int_or_none,
str_or_none,
)
class TrovoBaseIE(InfoExtractor):
_VALID_URL_BASE = r'https?://(?:www\.)?trovo\.live/'
_HEADERS = {'Origin': 'https://trov... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n try_get,\r\n```",
"severity": "minor",
"line": 10
}
] | 1 |
python | from .common import InfoExtractor
from ..utils import int_or_none, urljoin
class PornezIE(InfoExtractor):
_VALID_URL = r'https?://(?:www\.)?pornez\.net/(?:video(?P<id>[0-9]+)|watch)/'
_TEST = {
'url': 'https://pornez.net/video344819/mistresst-funny_penis_names-wmv/',
'md5': '2e19a0a1cff3a5dbea... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n video_id = self._search_regex(\r\n r'<link[^>]+\\bhref=[\"\\']https?://pornez.net/\\?p=(\\w+)[\"\\']', webpage, 'id')\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | # axis = [0, 0, z] case is common enough it's worth
# having a shortcut
sgn = 1 if axis[2] > 0 else -1
cos_a = math.cos(angle)
sin_a = math.sin(angle) * sgn
return [
[cos_a, sin_a, 0],
[-sin_a, cos_a, 0],
[0, 0, 1],
]
quat = quatern... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n \"\"\"Returns a rotation matrix for a given angle.\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | [-1000, -1000, -1000, -1000, -1000, -1000])
class TestDividendPerformanceHolidayStyle(TestDividendPerformance):
# The holiday tests begins the simulation on the day
# before Thanksgiving, so that the next trading day is
# two days ahead. Any tests that hard code events
# to be start + oneday will fai... | Review this code and list any quality issues. | [] | 0 |
python | """Various geometric Mobjects.
Modules
=======
.. autosummary::
:toctree: ../reference
~arc
~boolean_ops
~labeled_shapes
~line
~polygram
~shape_matchers
~tips
""" | Review this code and list any quality issues. | [
{
"issue": "could maybe just called this `labeled`",
"severity": "minor",
"line": 11
}
] | 1 |
python | )
with pytest.raises(capa.rules.InvalidRule):
_ = capa.rules.Rule.from_yaml(
textwrap.dedent(
"""
rule:
meta:
name: test rule
scopes:
static: process
... | Review this code and list any quality issues. | [] | 0 |
python | autolink_classes_and_methods(lines)
except Exception as e:
print(
style(
"Failed to check for class name mentions that can be "
f"converted to reStructuredText links in docstring of {name}. "
f"Error is: \n{str(e)}",
fg="red",
... | Review this code and list any quality issues. | [
{
"issue": "Thinking that maybe these functions should stay here, instead of being in the theme itself",
"severity": "minor",
"line": 26
}
] | 1 |
python | return ModelResponse(
parts=[
ToolCallPart(
tool_name='final_result',
args={'greeting': 'Hola, David! Espero que tengas un gran día!', 'language_code': 'es-MX'},
tool_call_id='pyd_ai_tool_call_id',
)
]
... | Review this code and list any quality issues. | [
{
"issue": "This is not needed anymore is it?",
"severity": "minor",
"line": 26
}
] | 1 |
python | return self.playlist_from_matches(
videopress_urls, video_id, video_title, ie=VideoPressIE.ie_key())
# Look for Rutube embeds
rutube_urls = RutubeIE._extract_urls(webpage)
if rutube_urls:
return self.playlist_from_matches(
rutube_urls, video_id, video... | Review this code and list any quality issues. | [
{
"issue": "Can you add tests? Preferably one for each type of embed we try to detect",
"severity": "minor",
"line": 26
}
] | 1 |
python | import sys
from distutils.core import setup
class FakeError(Exception):
pass
if sys.argv[1] in ("install", "bdist_wheel"):
if hasattr(sys.stdout, "buffer"):
sys.stdout.buffer.write(b"\nThis package prints out UTF-8 stuff like:\n")
sys.stdout.buffer.write("* return type of ‘main’ is not ‘int’... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n sys.stdout.buffer.write(\"\\nThis package prints out UTF-8 stuff like:\\n\".encode())\r\n```\r\n\r\nI prefer this for consistency, so if someone wants to click \"apply\" that's fine. But I don't care that much, so ignore it if you prefer.",
"severity": "minor",
"line... | 1 |
python | yield chunk
@staticmethod
async def tts_node(
agent: Agent, text: AsyncIterable[str], model_settings: ModelSettings
) -> AsyncGenerator[rtc.AudioFrame, None]:
"""Default implementation for `Agent.tts_node`"""
activity = agent._get_activity_or_raise()
... | Review this code and list any quality issues. | [] | 0 |
python | lhs_, rhs_ = parse_version_strs(lhs, rhs)
for l, r in zip(lhs_, rhs_):
if l != r:
if isinstance(l, int) and isinstance(r, int):
return l < r
return f"{l}" < f"{r}"
return True
def version_geq(lhs: str, rhs: str) -> bool:
"""
Returns True if version `lhs... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n except pkging.version.InvalidVersion:\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | if os.environ.get('UNSLOTH_ENABLE_LOGGING', '0') != '1':
try:
from vllm.worker.worker import logger as vllm_worker_logger
print(f'Patching vLLM worker, executor and prefix logs')
vllm_worker_logger.addFilter(HideLoggingMessage("Sleep mode freed"))
del vllm_worker_logger
from... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\nif os.environ.get('UNSLOTH_ENABLE_LOGGING', '0') != '1':\n try:\n from vllm.worker.worker import logger as vllm_worker_logger\n vllm_worker_logger.addFilter(HideLoggingMessage(\"Sleep mode freed\"))\n del vllm_worker_logger\n except:\n pass\n try:\... | 1 |
python | 'require_colons',
'animated',
'managed',
'id',
'name',
'_roles',
'_state',
'user',
'available',
)
def __init__(self, *, application_id: int, state: ConnectionState, data: EmojiPayload) -> None:
self.application_id: int = application_id
... | Review this code and list any quality issues. | [
{
"issue": "Not needed because app emojis cannot have roles requirement, that field for guilds",
"severity": "minor",
"line": 26
}
] | 1 |
python | [8, 9, 5],
[3, 2, 9],
[9, 4, 2],
[8, 4, 9],
[0, 4, 8],
[6, 4, 0],
[6, 2, 4],
[11, 2, 6],
[3, 11, 2],
[0, 6, 10],
[10, 1, 0],
[10, 7, 1],
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n edge_length\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | if self._disable_nullable and _schema is not None:
_schema = pa.schema(pa.field(field.name, field.type, nullable=False) for field in _schema)
return _schema if _schema is not None else []
@staticmethod
def _build_metadata(info: DatasetInfo, fingerprint: Optional[str] = None) -> Dict[str, st... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n if self.schema:\r\n schema_cols = set(self.schema.names)\r\n examples_cols = self.current_examples[0][0].keys() # .keys() preserves the order (unlike set)\r\n common_cols = [col for col in self.schema.names if col in examples_cols]\r\n ... | 1 |
python | if len(entries) == 1:
return entries[0]
return self.playlist_result(entries, video_id)
@staticmethod
def _build_profile_url(path):
return format_field(path, None, 'https://bsky.app/profile/%s', default=None)
def _extract_videos(self, root, video_id, embed_path='embed', record_p... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n endpoint = self._get_service_endpoint(did, video_id)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | are not loaded to not run User code in Scheduler.
:param collect_dags: when True, collects dags during class initialization.
:param known_pools: If not none, then generate warnings if a Task attempts to use an unknown pool.
"""
def __init__(
self,
dag_folder: str | Path | None = None, ... | Review this code and list any quality issues. | [
{
"issue": "It is extremely counter-intuitive that creating a DagBag object has a system-wide side effect. I would argue this is worse than the previous approach.",
"severity": "minor",
"line": 26
}
] | 1 |
python | from .common import InfoExtractor
from ..utils import (
js_to_json,
urlencode_postdata,
urljoin,
)
from ..utils.traversal import traverse_obj
class JioSaavnBaseIE(InfoExtractor):
def _extract_initial_data(self, url, audio_id):
webpage = self._download_webpage(url, audio_id)
return self... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n js_to_json,\r\n url_or_none,\r\n urlencode_postdata,\r\n```",
"severity": "minor",
"line": 4
}
] | 1 |
python | ```
:param
arn: The AWS role arn
role_tags: A dictionary of role tags
:return: boolean specifying whether ConsoleMe is allowed to sync / access the role
"""
allowed_tags = config.get("roles.allowed_tags", {})
allowed_arns = config.get("roles.allowed_arns", [])
allowed_tag_keys ... | Review this code and list any quality issues. | [
{
"issue": "We can eliminate the list comprehension above by changing this to:\r\n\r\n```python\r\nif allowed_tag_keys and any(x in role_tags for x in allowed_tag_keys):\r\n```\r\n\r\nThat way, each iteration through `allowed_tag_keys` is a hash lookup in the `role_tags` dict.",
"severity": "minor",
"li... | 1 |
python | from olmo.torch_util import barrier, get_fs_local_rank
from olmo.util import load_dataset_from_disk, save_dataset_to_disk
from ..tokenizer import Tokenizer
log = logging.getLogger(__name__)
def load_dataset(path, name, split, datasets_cache_dir: Optional[str] = None):
# Try get dataset from disk.
if dataset... | Review this code and list any quality issues. | [
{
"issue": "This seems a little sketch, but I guess it's fine as long as all ranks either have or do not have the dataset on disk, which is probably a reasonable assumption?",
"severity": "minor",
"line": 26
}
] | 1 |
python | elif "state" in data:
LOGGER.debug("Streaming received state from %s", vin)
coordinator.data["state"] = data["state"]
coordinator.async_set_updated_data(coordinator.data)
return handle_vehicle_stream
def async_setup_energy_device(
hass: HomeAssistant,
entry: Teslemetry... | Review this code and list any quality issues. | [
{
"issue": "I think you can group this loop and remove a bit redundant code. Something in line such as:\n\n```py\nfor component in [\n *components.get(\"components_gateways\", []),\n *components.get(\"components_batteries\", []),\n]:\n if part_name := component.get(\"part_name\"):\n models.add(p... | 1 |
python | """
warnings.warn(
"`run_node()` has been deprecated and will be removed in Kedro 0.20.0",
KedroDeprecationWarning,
)
if is_async and inspect.isgeneratorfunction(node.func):
raise ValueError(
f"Async data loading and saving does not work with "
f"nodes wrappi... | Review this code and list any quality issues. | [
{
"issue": "Is there a reason why `_validate_catalog` and `_validate_nodes` are private methods and this one is public?",
"severity": "minor",
"line": 26
}
] | 1 |
python | from json import JSONDecodeError
from urllib.error import HTTPError
from .common import InfoExtractor
from ..utils import (
ExtractorError,
float_or_none,
parse_iso8601,
strip_or_none,
traverse_obj,
try_call,
try_get,
urljoin)
class CinetecaMilanoIE(InfoExtractor):
_VALID_URL = r'h... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n _VALID_URL = r'https?://(?:www\\.)?cinetecamilano\\.it/film/(?P<id>\\d+)'\r\n```\r\nit does nothing",
"severity": "minor",
"line": 16
}
] | 1 |
python | ssl_context_factory = insecure_ssl_context_factory
else:
ssl_context_factory = gevent.ssl.create_default_context
self.client = LocustUserAgent(
cookiejar=self.cookiejar,
ssl_context_factory=ssl_context_factory,
insecure=insecure,
client_pool=cl... | Review this code and list any quality issues. | [
{
"issue": "Not sure this deserves its own method :)",
"severity": "minor",
"line": 26
}
] | 1 |
python | self.sv2.processes[process.ref_parent_process.path[1]].os_pid if process.ref_parent_process else 0
)
self.monitor_processes[process.monitor_id] = VMRayMonitorProcess(
process.os_pid, ppid, process.monitor_id, process.image_name
)
# not all processes are recor... | Review this code and list any quality issues. | [
{
"issue": "this comment confuses me (only 1 thread per process?) and the following 2 lines appear unrelated?",
"severity": "minor",
"line": 26
}
] | 1 |
python | @pytest.fixture
def cfupdate() -> Generator[MagicMock]:
"""Mock the CloudflareUpdater for easier testing."""
mock_cfupdate = get_mock_client()
with patch(
"homeassistant.components.cloudflare.coordinator.pycfdns.Client",
return_value=mock_cfupdate,
) as mock_api:
yield mock_api
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\ndef location_info() -> Generator[None]:\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | CONF_SSL,
CONF_VERIFY_SSL,
)
from homeassistant.core import HomeAssistant
from tests.common import MockConfigEntry
MOCK_DEVICE = DeviceInfo(
manufacturer="SMA",
name="SMA Device Name",
type="Sunny Boy 3.6",
serial=123456789,
sw_version="1.0.0",
)
MOCK_USER_INPUT = {
CONF_HOST: "1.1.1.1",... | Review this code and list any quality issues. | [] | 0 |
python | images: list["ImageInput"],
videos: list["VideoInput"],
audios: list["AudioInput"],
processor: Optional["MMProcessor"],
) -> list[dict[str, str]]:
self._validate_input(processor, images, videos, audios)
num_image_tokens, num_video_tokens, num_audio_tokens = 0, 0, 0
me... | Review this code and list any quality issues. | [
{
"issue": "do we need to check audios here? we already checked the feature attention mask in L1626",
"severity": "minor",
"line": 26
}
] | 1 |
python | if len(lines) == 1 and not trailing_newline:
# No new lines, buffer the input and continue.
self.buffer.append(lines[0])
return []
if self.buffer:
# Include any existing buffer in the first portion of the
# splitlines result.
lines = ["".j... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n if not self.buffer and not self.trailing_cr:\r\n return []\r\n \r\n lines = [\"\".join(self.buffer)]\r\n self.buffer = []\r\n self.trailing_cr = False\r\n return lines\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | from .const import DOMAIN
class OpenEVSEConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
"""OpenEVSE config flow."""
VERSION = 1
MINOR_VERSION = 1
async def check_status(self, host: str) -> bool:
"""Check if we can connect to the OpenEVSE charger."""
try:
charger = ... | Review this code and list any quality issues. | [
{
"issue": "Host isn't a valid unique id, the unique id should be unique for the device, like a mac address or serial number. If we don't have such identifier we need to use `self._async_abort_entries_match(` https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/unique-config-entry",
... | 1 |
python | )
async def test_flow_as_a_func_asynckw(self, async_call_folder):
f = load_flow(async_call_folder, is_async_call=True)
result = await f(key="PATH")
assert result["output"] is not None
@pytest.mark.asyncio
async def test_flow_as_a_func_real_async(self):
from promptflow._sdk.e... | Review this code and list any quality issues. | [
{
"issue": "maybe we could have several tasks to ensure they are running in parallel",
"severity": "minor",
"line": 26
}
] | 1 |
python | if err is None:
passed_models.append(name)
else:
failed_info[name] = err
if early_stop:
break
if dist.get_rank() == 0:
print(f"Init method: {init_method}")
print(f"Passed models({len(passed_models)}): {passed_models}\n\n")
print(f"... | Review this code and list any quality issues. | [
{
"issue": "only 1 micro batch is not suitable",
"severity": "major",
"line": 26
}
] | 1 |
python | sphere = scene.add_entity(
morph=gs.morphs.Sphere(
pos=(0.0, 0.0, SPHERE_RADIUS),
radius=SPHERE_RADIUS,
),
material=gs.materials.FEM.Elastic(
friction_mu=1.0,
model="linear_corotated",
),
)
asset_path = get_hf_dataset(pattern="meshe... | Review this code and list any quality issues. | [] | 0 |
python | self.on_state_change(self._decode_result(meta), None)
self._pubsub = self.backend.client.pubsub(
ignore_subscribe_messages=True,
)
# subscribed_to maybe empty after on_state_change
if self.subscribed_to:
self._pubsub.subscribe(*self.subscribed_to)
else:
... | Review this code and list any quality issues. | [
{
"issue": "@Nusnus would you be able to help me understand if a `RuntimeError` is what we'd want to raise here, or if there's a more specific exception available to us in Python (in general), or in this repository (perhaps there's an error class that we'd want to subclass) that we can raise here that clients w... | 1 |
python | def get_rules_path():
return os.path.join(CD, "..", "rules")
def get_rule_path():
return os.path.join(get_rules_path(), "lib", "allocate-memory.yml")
@pytest.mark.parametrize(
# test detect_duplicate_features.py script for 3 cases
# - New rule isn't a valid rule
# - New rule file name doesn't en... | Review this code and list any quality issues. | [
{
"issue": "I'm afraid this could change when we update rules, so I'd say we better create a test rule set and rule like we do in the test_rules and test that here. We don't have to parametrize it and can just add it verbatim inline.",
"severity": "minor",
"line": 26
}
] | 1 |
python | "qwen-max-0428": {"prompt": 0.0055, "completion": 0.0166},
"qwen-max-0403": {"prompt": 0.0055, "completion": 0.0166},
"qwen-max-0107": {"prompt": 0.0055, "completion": 0.0166},
"qwen-max-1201": {"prompt": 0.0166, "completion": 0.0166},
"qwen-max-longcontext": {"prompt": 0.0055, "completion": 0.0166},
... | Review this code and list any quality issues. | [
{
"issue": "It seems that the token cost of these models should be updated together with the length supported by the model.",
"severity": "minor",
"line": 26
}
] | 1 |
python | self,
*,
turn_detection: NotGivenOr[TurnDetectionMode] = NOT_GIVEN,
stt: NotGivenOr[stt.STT | STTModels | str] = NOT_GIVEN,
vad: NotGivenOr[vad.VAD] = NOT_GIVEN,
llm: NotGivenOr[llm.LLM | llm.RealtimeModel | LLMModels | str] = NOT_GIVEN,
tts: NotGivenOr[tts.TTS | TTSModel... | Review this code and list any quality issues. | [
{
"issue": "I think we should do it by default.\nMaybe we shouldn't even have an option for it, it seems like an issue everybody has",
"severity": "minor",
"line": 26
}
] | 1 |
python | def sentinel(name, doc=None):
try:
value = sentinel._cache[name] # memoized
except KeyError:
pass
else:
if doc == value.__doc__:
return value
raise ValueError(dedent(
"""\
New sentinel value %r conflicts with an existing sentinel of the
... | Review this code and list any quality issues. | [
{
"issue": "Should we add a comment here explaining why we did this?",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'id': 'F261_01_3855109',
'ext': 'm4a',
'channel': 'NHKラジオ第1',
'uploader': 'NHKラジオ第1',
'timestamp': 1681635900,
'release_date': '20230416',
'series': 'NHKラジオニュース',
'title': '午後６時のNHKニュース',
'thumbnail': 'https://www.nhk.or.jp/... | Review this code and list any quality issues. | [
{
"issue": "make non-fatal. feel free to try and find better formatting for the `detail_url` lines\r\n```suggestion\r\n detail_url = try_call(\r\n lambda: f'https:{self._api_config.find(\".//url_program_detail\").text}'.format(\r\n service=service, area=area, dateid=aa_vinfo3))\... | 1 |
python | )
from .messages import NODE_P2P_V2
from .p2p import P2P_SERVICES, P2P_SUBVERSION
from .util import (
MAX_NODES,
assert_equal,
assert_not_equal,
append_config,
delete_cookie_file,
get_auth_cookie,
get_rpc_proxy,
rpc_url,
wait_until_helper_internal,
p2p_port,
tor_port,
)
BITC... | Review this code and list any quality issues. | [
{
"issue": "fa18c82 — Does this test use the system `ARG_MAX` at runtime or intentionally use a conservative value? Could we add a short comment that `1024` is a test-only, conservative value to ensure the stdin fallback is exercised, and that production behavior still relies on the system `ARG_MAX`",
"seve... | 1 |
python | Tests
-----
Check that creating a :class:`~.MathTex` works::
>>> MathTex('a^2 + b^2 = c^2') # doctest: +SKIP
MathTex('a^2 + b^2 = c^2')
Check that double brace group splitting works correctly::
>>> t1 = MathTex('{{ a }} + {{ b }} = {{ c }}') # doctest: +SKIP
>>> len(t1.sub... | Review this code and list any quality issues. | [] | 0 |
python | order_rel_fields = {
"slices": ("slice_name", "asc"),
"owners": ("first_name", "asc"),
}
base_related_field_filters = {
"owners": [["id", BaseFilterRelatedUsers, lambda: []]],
"created_by": [["id", BaseFilterRelatedUsers, lambda: []]],
"changed_by": [["id", BaseFilterRela... | Review this code and list any quality issues. | [
{
"issue": "haven't dug in, but isn't there an existing method that we can modify to now support uuid while preserving the API, essentially doing a non-breaking change that supports uuid as an input, and adds new uuid fields in the output?",
"severity": "minor",
"line": 26
}
] | 1 |
python | # MLA-specific
kv_lora_rank: int | None = None
qk_nope_head_dim: int | None = None
qk_rope_head_dim: int | None = None
v_head_dim: int | None = None
# Backend-specific tuning
num_kv_splits: int | None = None # CUTLASS MLA
reorder_batch_threshold: int | None = None # FlashAttn MLA, FlashML... | Review this code and list any quality issues. | [] | 0 |
python | 'age_limit': 12,
'alt_title': 'Snow Beast',
'cast': 'count:3',
'categories': 'count:7',
'creators': 'count:2',
'description': 'md5:e604a954a7f827a80e96a3a97d48b269',
'location': 'US',
'release_year': 2011,
'thumbnail': r're:... | Review this code and list any quality issues. | [
{
"issue": "Wouldn't it be better to have the traversal return a list?\r\n\r\ne.g. `properties` appears to be a list like `[\"DRM\",\"AVOD\"]`, but if `DRM` is not the first element then the current code will result in a false negative\r\n\r\n```suggestion\r\n if 'DRM' in traverse_obj(query, ('licenses',... | 1 |
python | continue
lang = (str_or_none(text_track.get('srclang'))
or str_or_none(text_track.get('label')) or 'en').lower()
subtitles.setdefault(lang, []).append({
'url': text_track_url,
})
is_live = False
duration = float_or_none(json_data.g... | Review this code and list any quality issues. | [
{
"issue": "~~enumerate the for loop and use that index here~~ Preference isn't needed since we know all resolutions\r\n\r\nYou can also get rid of append all-together. Like this:\r\n```py\r\nbase_url = dict_get(json_data, ('poster', 'thumbnail')\r\nthumbnails = [{\r\n 'url': re.sub(re.sub(r'\\d+x\\d+', f'{w... | 1 |
python | course = course_api['course']
episode_api = self._get_episode_api_json(webpage, episode_id)
episode = episode_api['episode']
for i in range(len(course.get('topics'))):
if traverse_obj(course, ('topics', i, 'id'), expected_type=str) == episode.get('topic'):
chapter_n... | Review this code and list any quality issues. | [
{
"issue": "playlist tests MUST define atleast one of `playlist`, `playlist_count`, `playlist_mincount` or `playlist_maxcount`. This is why these tests are failing",
"severity": "critical",
"line": 26
}
] | 1 |
python | logging.debug("trying to get from current working directory...")
collection = _get_collection_from_cwd()
else:
logging.debug("collection is protected, will directly use that...")
tracer_provider: TracerProvider = trace.get_tracer_provider()
collection = tracer... | Review this code and list any quality issues. | [] | 0 |
python | # SPDX-License-Identifier: Apache-2.0
# Standard
from dataclasses import dataclass
from enum import IntEnum, auto
from typing import Optional
import struct
# Third Party
import torch
# First Party
from lmcache.utils import CacheEngineKey
from lmcache.v1.memory_management import MemoryFormat
MAX_KEY_LENGTH = 150
cl... | Review this code and list any quality issues. | [
{
"issue": "Sorry but I didn't mean to add `s` at end; do you mind changing to `ClientCommand`?",
"severity": "minor",
"line": 18
}
] | 1 |
python | Role: SelectDefaultValueType.role,
GuildChannel: SelectDefaultValueType.channel,
AppCommandChannel: SelectDefaultValueType.channel,
AppCommandThread: SelectDefaultValueType.channel,
Thread: SelectDefaultValueType.channel,
}
values: List[SelectDefaultValue... | Review this code and list any quality issues. | [
{
"issue": "Please give this its own variable, it reads terribly.\r\n\r\nOn that note, as mentioned, it's buggy to coerce the value into the given `value_type`.",
"severity": "critical",
"line": 26
}
] | 1 |
python | def _real_extract(self, url):
program_id = self._match_id(url)
webpage = self._download_webpage(f'https://www.nhk.or.jp/school/{program_id}/', program_id)
title = (self._generic_title('', webpage)
or self._html_search_regex(r'<h3>([^<]+?)とは？\s*</h3>', webpage, 'title', fatal=F... | Review this code and list any quality issues. | [
{
"issue": "- accept `http` URLs\r\n- `id` group is not useful since its value is only used for playlists and we are constructing our own equivalent `programme_id` below\r\n```suggestion\r\n _VALID_URL = r'https?://www\\.nhk\\.or\\.jp/radio/(?:player/ondemand|ondemand/detail)\\.html\\?p=(?P<site>[\\da-zA-Z]+... | 1 |
python | 'id': 'ed063cd5-72c8-46b5-a60a-569243edcea8',
'ext': 'mp4',
'title': '11 - Kryptographie - 24.11.2015',
'thumbnail': r're:^https?://.*\.jpg$',
'timestamp': 1606208400,
'upload_date': '20201124',
},
}
]
def _real... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n _VALID_URL = rf'''(?x)\r\n https?://(?P<host>{OpencastBaseIE._INSTANCES_RE})(\r\n /engage/ui/index.html\\?(?:[^#]+&)?epFrom=|\r\n /lttools/index.html\\?(?:[^#]+&)?series=\r\n )(?P<id>{OpencastBaseIE._UUID_RE})'''\r\n```",
"severity": "mino... | 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.