language
string
code-snippit
string
instruction
string
flaws
list
flaw_count
int64
python
shrinkage : 'auto', float or None Shrinkage parameter, possible values: - None: no shrinkage. - 'auto': automatic shrinkage using the Ledoit-Wolf lemma. - float between 0 and 1: fixed shrinkage constant. Shrinkage parameter is ignored if `covariance_es...
Review this code and list any quality issues.
[ { "issue": "`ind` could be renamed to `class_idx` to improve clarity.", "severity": "minor", "line": 26 } ]
1
python
if f.get('vcodec') != 'none' and not f.get('dynamic_range'): f['dynamic_range'] = tag_dict.get('dynamic_range') if f.get('acodec') != 'none' and not f.get('audio_channels'): f['audio_channels'] = { 'stereo': 2, 'dolb...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n 'release_year': int_or_none(video_data.get('year')),\r\n```", "severity": "minor", "line": 26 } ]
1
python
http2_no_verify = client_context_no_verify( SSLCipherList.PYTHON_DEFAULT, SSL_ALPN_HTTP11_HTTP2 ) no_alpn_no_verify = client_context_no_verify( SSLCipherList.PYTHON_DEFAULT, SSL_ALPN_NONE ) assert http1_no_verify is not http2_no_verify assert http1_no_verify is not no_alpn_no_verify ...
Review this code and list any quality issues.
[ { "issue": "Maybe also check that the no verify http2 context is the same when created with those parameters?", "severity": "minor", "line": 26 } ]
1
python
lambda x: x['data']['content']['model']['blocks'],), list) or []): if block.get('type') not in ['media', 'video']: continue parse_media(block.get('model')) return self.playlist_result( ...
Review this code and list any quality issues.
[ { "issue": "use `traverse_obj` to filter here, and only bother to extract the timestamp if there is actually `video_data`, e.g.\r\n```suggestion\r\n video_data = traverse_obj(next_data, (\r\n ..., 'contents', lambda _, v: v['type'] == 'video'), get_all=False)\r\n if video_data:\r\n ...
1
python
"""Example from https://click.palletsprojects.com/en/8.1.x/advanced/#command-aliases""" from __future__ import annotations from typing_extensions import assert_type import click class AliasedGroup(click.Group): def get_command(self, ctx: click.Context, cmd_name: str) -> click.Command | None: rv = click....
Review this code and list any quality issues.
[]
0
python
# escape like \uDC80. # As we want the overall message to be kept atomic and therefore smaller than 512, # we encode encode the raw name bytes with URL-safe Base64 - so a 255 long name # will not exceed 340 bytes. b = name.encode('utf-8', 'surrogateescape') if len(b) > 255: ...
Review this code and list any quality issues.
[ { "issue": "`_decode_message` so no-one thinks its public.", "severity": "minor", "line": 26 } ]
1
python
actives : list of bool, optional The initial check states of the buttons. The list must have the same length as *labels*. If not given, all buttons are unchecked. layout : None or "vertical" or "horizontal" or (int, int), default: None The layout of the check buttons. Options...
Review this code and list any quality issues.
[ { "issue": "```suggestion\n The new layout options are provisional, meaning that their algorithmic behavior may change\nwithout prior warning. This behavior includes if and when a figure redraw happens and the computation of the exact positions of buttons and labels \n```\nThe nesting on the sent...
1
python
comment_list = [] for page in itertools.count(1): comments_json = self._call_api(vid, data={ 'operationName': 'getCommentList', 'variables': { 'params': { 'appInfo': { 'postID': vid, ...
Review this code and list any quality issues.
[ { "issue": "Since comment extraction needs extra requests, move it into `_get_comments` and return `'__post_extractor': self.extract_comments(...)`", "severity": "major", "line": 26 } ]
1
python
log.debug(log_data) log_data = { "function": function, "message": "Completed : looking for IAM Role limits", } log.debug(log_data) stats.count(f"{function}.success") return True schedule_30_minute = timedelta(seconds=1800) schedule_45_minute = timedelta(seconds=2700) schedule_6_ho...
Review this code and list any quality issues.
[ { "issue": "Adding total number of accounts and total number of roles might be useful metrics to have in our final log_data", "severity": "minor", "line": 26 } ]
1
python
def test_StateSpace_functions(): # https://in.mathworks.com/help/control/ref/statespacemodel.obsv.html A_mat = Matrix([[-1.5, -2], [1, 0]]) B_mat = Matrix([0.5, 0]) C_mat = Matrix([[0, 1]]) D_mat = Matrix([1]) SS1 = StateSpace(A_mat, B_mat, C_mat, D_mat) SS2 = StateSpace(Matrix([[1, 1], [4,...
Review this code and list any quality issues.
[ { "issue": "I'm not seeing a test for `to_observable_form()`", "severity": "minor", "line": 26 } ]
1
python
r'[^.]+\.vidflex\.tv', r'(?:www\.)?acactv\.ca', r'(?:www\.)?albertalacrossetv\.com', r'(?:www\.)?cjfltv\.com', r'(?:www\.)?figureitoutbaseball\.com', r'(?:www\.)?ocaalive\.com', r'(?:www\.)?pegasussports\.tv', r'(?:www\.)?praxisseries\.ca', r'(?:www\.)?sil...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n _VALID_URL = rf'https?://(?:{\"|\".join(_DOMAINS_RE)})/[a-z]{{2}}(?:-[a-z]{{2}})?/c/[\\w-]+\\.(?P<id>\\d+)'\r\n```", "severity": "minor", "line": 26 } ]
1
python
return xor_f.read(NUM_XOR_BYTES) @property def wallets_path(self) -> Path: return self.chain_path / "wallets" def debug_log_size(self, **kwargs) -> int: with open(self.debug_log_path, **kwargs) as dl: dl.seek(0, 2) return dl.tell() @contextlib.contextmanager ...
Review this code and list any quality issues.
[]
0
python
return self def __set_function_attribute( self, name: str, default_value: t.Optional[str] = None, optional: t.Optional[bool] = True ): value = self.__prop_values.get(name, default_value) if value is None: if not optional: _warn(f"Property {name} is required f...
Review this code and list any quality issues.
[ { "issue": "[nitpick] The parameter names `is_var` and `client_var_name` are ambiguous. Consider renaming to `track_as_frontend_var` and `use_client_var_name` to clearly indicate their purpose.", "severity": "minor", "line": 26 } ]
1
python
Raises: ValueError: When ``batchdata`` is None. """ if batchdata is None: raise ValueError("Must provide batch data for current iteration.") batch = engine.prepare_batch(batchdata, engine.state.device, engine.non_blocking, **engine.to_kwargs) if len(batch) == 2: ...
Review this code and list any quality issues.
[]
0
python
self.assertIs(result.wasSuccessful(), False) event = events[1] self.assertEqual(event[0], "addSubTest") self.assertEqual( str(event[2]), "dummy_test (test_runner.test_parallel.SampleFailingSubtest.dummy_test) " "(index=0)", ) self.assertEqual(...
Review this code and list any quality issues.
[ { "issue": "The `_init_worker` function was not unit tested.", "severity": "minor", "line": 26 } ]
1
python
# Copyright (c) MONAI Consortium # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # http://www.apache.org/licenses/LICENSE-2.0 # Unless required by applicable law or agreed to in writing, so...
Review this code and list any quality issues.
[ { "issue": "In MONAI we use `unittest` and `parameterized` packages for tests and not `pytest`, specifically we use test classes and methods for unit tests rather than functions. Please reformulate these tests to use these packages according the style of other tests that are present here. It might make sense to...
1
python
def collect_metrics(self): return self.config.collect_metrics @collect_metrics.setter def collect_metrics(self, value): if not isinstance(value, bool): raise ValueError(f"Boolean value expected but got {type(value)}.") self.config.collect_metrics = value @property d...
Review this code and list any quality issues.
[ { "issue": "Is it possible to move this check inside the loader class? If we keep adding these if conditions here, then this file will blow up quickly.", "severity": "major", "line": 26 } ]
1
python
"""A helper script to "clean up" all of your generated markdown, zip, and HTML files.""" import shutil as sh import os.path as op path_root = op.join(op.dirname(op.abspath(__file__)), '..') paths = [op.join(path_root, '_site'), op.join(path_root, '_build')] for path in paths: print('Removing {}...'.forma...
Review this code and list any quality issues.
[ { "issue": "I had updated this comment, since at the time I was 'cleaning' out created zip files, but as is, the reference to zip files is outdated.", "severity": "minor", "line": 1 } ]
1
python
integer PKs and can be deserialized without error. """ user1 = SubclassNaturalKeyOptOutUser.objects.create(email="user1@example.com") user2 = SubclassNaturalKeyOptOutUser.objects.create(email="user2@example.com") post = PostToOptOutSubclassUser.objects.create( author=user1, title="Post 2 (Subcl...
Review this code and list any quality issues.
[ { "issue": "You can remove these comments to blend in with the surrounding style.", "severity": "minor", "line": 26 } ]
1
python
) def get_points_without_null_curves(self, atol=1e-9): nppc = self.n_points_per_curve points = self.get_points() distinct_curves = reduce( op.or_, [ (abs(points[i::nppc] - points[0::nppc]) > atol).any(1) for i in range(1, nppc) ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n The length of the :class:`OpenGLVMobject`.\r\n```", "severity": "minor", "line": 26 } ]
1
python
def _setup_server(self): # Apply _force_eager_loading overrides from modules eager_loading = self.config.eager_loading for module_name in ComponentRegistry.registry: module = sys.modules[module_name] eager = getattr(module, "_force_eager_loading", False) eager...
Review this code and list any quality issues.
[ { "issue": "Hmm, maybe we could just call `get_asset_url` here?", "severity": "minor", "line": 26 } ]
1
python
height = uint32(max(last_coin_state.created_height or 0, last_coin_state.spent_height or 0)) if height != next_height: break coin_states.pop() return coin_states, next_height async def rollback_to_block(self, block_index: int) -> dict[bytes32, CoinRecord]: ...
Review this code and list any quality issues.
[ { "issue": "this is not obvious to me. why do you need to \"launder\" the same-puzzle and same amount bit here?", "severity": "minor", "line": 26 } ]
1
python
'ext': 'mp4', 'title': '【検証】専門家は、KADOKAWAをどう見るか', 'cast': 'count:3', 'description': 'md5:2c2d4bf77484a4333ec995d676f9a91d', 'release_date': '20240622', 'release_timestamp': 1719088080, 'series': 'NPレポート', 'series_id': '158', ...
Review this code and list any quality issues.
[ { "issue": "`cookies` is the default `method` if `_NETRC_MACHINE` is unset\r\n```suggestion\r\n f'only the preview is downloaded. {self._login_hint()}', video_id)\r\n```", "severity": "minor", "line": 26 } ]
1
python
instrumentation_names.tool_result_attr, output if isinstance(output, str) else json.dumps(InstrumentedModel.serialize_any(output)), ) return output @dataclass class OutputValidator(Generic[AgentDepsT, OutputDataT_inv]): function: OutputValidatorFunc[AgentDepsT, OutputDataT_inv...
Review this code and list any quality issues.
[ { "issue": "This should just be `partial`, right? As it indicates that the output _is_ partial, not that partial parsing is allowed", "severity": "minor", "line": 26 } ]
1
python
idx = 0 ids = result['id'] days = result['day'] for asset_id in self.assets: for date in self.dates_for_asset(asset_id): self.assertEqual(ids[idx], asset_id) self.assertEqual(date, seconds_to_timestamp(days[idx])) idx += 1 def test...
Review this code and list any quality issues.
[ { "issue": "Should this say \"asset 11\" now?", "severity": "minor", "line": 26 } ]
1
python
from importlib import import_module from typing import TYPE_CHECKING, Any from polars._dependencies import _PYARROW_AVAILABLE, import_optional from polars._utils.various import parse_version from polars.convert import from_arrow from polars.exceptions import ModuleUpgradeRequiredError if TYPE_CHECKING: from colle...
Review this code and list any quality issues.
[ { "issue": "> for now\n\nIs this a cliffhanger I see? 😄", "severity": "minor", "line": 26 } ]
1
python
MYPY_FILES_ARGS = ['git', 'ls-files', 'test/functional/*.py', 'contrib/devtools/*.py'] ENABLED = ( 'E101,' # indentation contains mixed spaces and tabs 'E112,' # expected an indented block 'E113,' # unexpected indentation 'E115,' # expected an indented block (comment) 'E116,' # unexpected inde...
Review this code and list any quality issues.
[ { "issue": "In commit: lint: Remove python whitespace and shadowing lint rules \r\nThis seems reasonable to me, but not available without the `--preview` argument", "severity": "minor", "line": 26 } ]
1
python
@overload def __add__(self: _MaskedArrayUInt_co, other: _ArrayLikeUInt_co, /) -> _MaskedArray[unsignedinteger]: ... # type: ignore[overload-overlap] @overload def __add__(self: _MaskedArrayInt_co, other: _ArrayLikeInt_co, /) -> _MaskedArray[signedinteger]: ... # type: ignore[overload-overlap] @overloa...
Review this code and list any quality issues.
[ { "issue": "It's a slight deviation from `ndarray` (https://github.com/numpy/numpy/blob/main/numpy/__init__.pyi#L2853). But it's exactly equivalent, so I'd still consider it to be \"in sync\" like this 🤷🏻.\r\n\r\n```suggestion\r\n ) -> MaskedArray[_AnyShape, dtypes.StringDType]: ...\r\n```", "severity"...
1
python
return report_unable('remove corrupt download') try: os.rename(exe, exe + '.old') except (IOError, OSError): return report_unable('move current version') try: os.rename(exe + '.new', exe) except (IOError, OSError): report_unable('overwrite...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n elif variant in ('zip', 'mac_bin'):\r\n pack_type = ('mac', '64') if variant == 'mac_bin' else ('zip', '3')\r\n```", "severity": "minor", "line": 26 } ]
1
python
prompt: str | Sequence[_messages.UserContent] | None = None """The original user prompt passed to the run.""" messages: list[_messages.ModelMessage] = field(default_factory=list) """Messages exchanged in the conversation so far.""" tracer: Tracer = field(default_factory=NoOpTracer) """The tracer to ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n \"\"\"Whether the output passed to an output validator is partial.\"\"\"\r\n```", "severity": "minor", "line": 26 } ]
1
python
if finished: break print("Getting benchmark result") result = driver.execute_script("return globalThis.benchmarkClient._formattedJSONResult({modern: true})") speedometer_json = json.loads(result) print("Writing to file") try: ...
Review this code and list any quality issues.
[ { "issue": "I think the location might be important. I think it needs to be after we start the app, since that unlocks the screen (which this command doesn't do yet).", "severity": "minor", "line": 26 } ]
1
python
Raises ------ :exc:`ValueError` If ``point`` does not lie on the curve. :exc:`Exception` If the :class:`VMobject` has no points. """ self.throw_error_if_no_points() nc = self.get_num_curves() vmob_length = sum(self.get_nth_curve_length(i) ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n\r\n alpha = total_length / vmob_length\r\n return alpha\r\n```", "severity": "minor", "line": 26 } ]
1
python
import ujson as json from mock import patch from tornado.testing import AsyncHTTPTestCase from consoleme.config import config class TestRequestsHandler(AsyncHTTPTestCase): def get_app(self): from consoleme.routes import make_app return make_app(jwt_validator=lambda x: {}) def test_get(sel...
Review this code and list any quality issues.
[ { "issue": "These endpoints should be returning a `501 Not Implemented` status until they're implemented. It looks like this changed because `write_error()` is implemented differently for `BaseAPIHandler` than it is for `BaseJSONHandler`. We don't have to keep the same logic, but it would be nice to have an eas...
1
python
}, 'contentCheckOk': True, 'racyCheckOk': True } @staticmethod def _is_agegated(player_response): if traverse_obj(player_response, ('playabilityStatus', 'desktopLegacyAgeGateReason')): return True reasons = traverse_obj(player_response, ('playability...
Review this code and list any quality issues.
[ { "issue": "Is there really a need for `require_js_player`? Can't we just check if `player_url is None`? I also noticed `fatal=true` is never used for `_extract_signature_timestamp`", "severity": "major", "line": 26 } ]
1
python
# check existence inst: t.Optional[_DataAccessor] = None for cl in classes: inst = self.__access_4_type.get(cl) if inst: break if inst is None: try: inst = cls(self.__gui) except Exception as e: raise...
Review this code and list any quality issues.
[ { "issue": "no need for this line, the user will get the warning", "severity": "minor", "line": 26 } ]
1
python
response = [{"role": Role.ASSISTANT.value, "content": example[self.dataset_attr.response]}] else: # unsupervised response = [] output = { "_prompt": prompt, "_response": response, "_system": example[self.dataset_attr.system] if self.dataset_attr.system e...
Review this code and list any quality issues.
[]
0
python
offs_cm = pid_m * BLOCK_SIZE_M + tl.arange(0, BLOCK_SIZE_M) offs_cn = pid_n * BLOCK_SIZE_N + tl.arange(0, BLOCK_SIZE_N) out_data = out_ptr + stride_cm * offs_cm[:, None] + stride_cn * offs_cn[None, :] tl.store(out_data, out, mask=(offs_cm[:, None] < M) & (offs_cn[None, :] < N)) @triton.jit def matmul_kern...
Review this code and list any quality issues.
[]
0
python
memory_fragment = CogneeGraph() logger.debug("Initialized empty CogneeGraph memory fragment") import time start_time = time.time() await memory_fragment.project_graph_from_db( graph_engine, node_properties_to_project=properties_to_project, edge_prop...
Review this code and list any quality issues.
[ { "issue": "Same as in cognee graph, this is not necessarily true, we can have 10 nodes and 1 edge then 8 nodes are gonna be isolated.", "severity": "minor", "line": 26 } ]
1
python
* 'two-sided': the correlation is nonzero * 'less': the correlation is negative (less than zero) * 'greater': the correlation is positive (greater than zero) method : ResamplingMethod, optional Defines the method used to compute the p-value. If `method` is an instance of `Permutati...
Review this code and list any quality issues.
[ { "issue": "The \"2-D square\" is a bit confusing here, because in one of the examples there's a `res.statistic` that's a vector of size 2. And this also supports >2-D results, no?", "severity": "minor", "line": 26 } ]
1
python
} }, { # video can't be watched anonymously due to view count limit reached, # but can be downloaded (see https://github.com/ytdl-org/youtube-dl/issues/14046) 'url': 'https://drive.google.com/file/d/0B-vUyvmDLdWDcEt4WjBqcmI2XzQ/view', 'only_matching': True, }, { # video i...
Review this code and list any quality issues.
[ { "issue": "please actually run the test and add in the required fields", "severity": "minor", "line": 26 } ]
1
python
txt = self.recurse_node(node_to_parse) if not txt: continue txt = txt.replace(" ", "-") createLabel(a, txt, name_space, True, SourceType.USER_DEFINED) # type: ignore [name-defined] # noqa: F821 continue # handle first ad...
Review this code and list any quality issues.
[ { "issue": "Let's instead return an empty `str` object here to avoid the caller having to handle both `int` and `str` return value types.", "severity": "minor", "line": 26 } ]
1
python
import numpy as np import torch import torch.distributed as dist from monai.handlers import AveragePrecision from monai.transforms import Activations, AsDiscrete from tests.test_utils import DistCall, DistTestCase class TestHandlerAveragePrecision(unittest.TestCase): def test_compute(self): ap_metric = ...
Review this code and list any quality issues.
[]
0
python
def test_cast_temporals_overflow_16039( s: pl.Series, to: pl.DataType, should_fail: bool ) -> None: if should_fail: with pytest.raises( pl.exceptions.InvalidOperationError, match="conversion from" ): s.cast(to) else: s.cast(to) @pytest.mark.parametrize("dtyp...
Review this code and list any quality issues.
[ { "issue": "I think there are some mypy errors here. Can you rebase and see?", "severity": "minor", "line": 26 } ]
1
python
assert isinstance(skeleton.value, tuple) assert all( isinstance(edge, tuple) and len(edge) == 2 for edge in skeleton.value ) def test_skeletons_by_vertex_count(self): """Test SKELETONS_BY_VERTEX_COUNT dictionary population.""" # Test that the dictionary is po...
Review this code and list any quality issues.
[ { "issue": "This test has a similar issue to the vertex count test. It assumes that all skeletons have unique edge counts by asserting that `SKELETONS_BY_EDGE_COUNT[edge_count] == skeleton.value`. However, if two skeletons have the same number of edges, only the last one will be stored in the dictionary (as per...
1
python
description="List of source identifiers for multiple sources", ), "chunks": fields.Integer(required=True, description="Chunks count"), "retriever": fields.String(required=True, description="Retriever ID"), "prompt_id": fields.String(required=True, description="Prompt ID")...
Review this code and list any quality issues.
[ { "issue": "Typo, should be required instead of require", "severity": "minor", "line": 26 } ]
1
python
def values(self) -> List[AbstractDataset]: # noqa: UP006 """List all datasets registered in the catalog.""" return [self._datasets[key] for key in self] def items(self) -> List[tuple[str, AbstractDataset]]: # noqa: UP006 """List all dataset names and datasets registered in the catalog."""...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n is not in the collection and does not match patterns.\r\n```", "severity": "minor", "line": 26 } ]
1
python
rect.left * dpr, rect.top * dpr, rect.right * dpr, rect.bottom * dpr ]; """, element, ) return physical_rect def element_screenshot(element: WebElement, filename: str): if not (filename.lower().endswith(".jpg") or filename.lower().endswith(".jpe...
Review this code and list any quality issues.
[ { "issue": "this will be `<name>.jpg.png`, right? maybe we could do `name_cropped.png`?\r\nI think hdc screenshot might support png too.", "severity": "minor", "line": 26 } ]
1
python
"""Create a ``KedroDataCatalog`` instance from configuration. This is a factory method used to provide developers with a way to instantiate ``KedroDataCatalog`` with configuration parsed from configuration files. Args: catalog: A dictionary whose keys are the dataset names and ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n An instantiated ``KedroDataCatalog`` containing all specified\r\n```", "severity": "minor", "line": 26 } ]
1
python
}] def _real_extract(self, url): broadcast_type, display_id = self._match_valid_url(url).groups() if broadcast_type == 'events': timeline = self._call_api( f'live_event/1/{display_id}/timeline.json', display_id) broadcast_id = traverse_obj(timeline, ( ...
Review this code and list any quality issues.
[ { "issue": "Kinda unrelated, can we do this too? I forgot to add this a while ago and it's been bothering me\r\n```suggestion\r\n if info['live_status'] == 'is_upcoming':\r\n self.raise_no_formats('This live broadcast has not yet started', expected=True)\r\n return info\r\n```", ...
1
python
@staticmethod def instantiate_template(template, params): def get_parameter(match): key = match.group(1) return params.get(key, match.group(0)) return re.sub(r"\{\{(\w+)\}\}", get_parameter, template) @staticmethod def execute(command): if is_windows(): ...
Review this code and list any quality issues.
[ { "issue": "these two lines can go in a single one (no need for the `timeout` variable when `TEST262_CASE_TIMEOUT` is already there)", "severity": "minor", "line": 26 } ]
1
python
metadata = { 'thumbnail': traverse_obj( hydration, ('content', 'currentContent', 'channel', 'image', 'logo', 'path'), ('content', 'currentContent', 'resource', 'image', 'cover_desktop', 'path')), **traverse_obj(hydration, ('content', 'currentContent', { ...
Review this code and list any quality issues.
[ { "issue": "I was getting some html tags during testing and warnings about non-numeric season number fields\r\n```suggestion\r\n 'description': ('description', {clean_html}),\r\n 'episode_number': ('chapter_number', {int_or_none}),\r\n 'season_number': ('...
1
python
for src in traverse_obj(source_meta, ('sources', ..., 'src')): fmts, subs = self._extract_m3u8_formats_and_subtitles(src, video_id, fatal=False) formats.extend(fmts) self._merge_subtitles(subs, target=subtitles) return { 'title': try_call(lambda: clean_html(get_e...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n _VALID_URL = r'https?://cu\\.tbs\\.co\\.jp/program/(?P<id>\\d+)'\r\n```", "severity": "minor", "line": 26 } ]
1
python
'id': key, 'url': thumbnail_info['url'], 'width': int_or_none(thumbnail_info.get('width')), 'height': int_or_none(thumbnail_info.get('height')), } for key, thumbnail_info in thumbnails.items() if url_or_none(thumbnail_info.get('url'))] def _teaser_to_url_result(self, tea...
Review this code and list any quality issues.
[ { "issue": "What should I do in case the ID can't be found? Continue (i.e. return no results) or raise an error?", "severity": "minor", "line": 26 } ]
1
python
.. manim:: SequencePlot :save_last_frame: class SequencePlot(GraphScene): def __init__(self, **kwargs): GraphScene.__init__( self, y_axis_label=r"Concentration [\%]", x_axis_label="Time [...
Review this code and list any quality issues.
[ { "issue": "Please use a similar one-line description as above.", "severity": "minor", "line": 26 } ]
1
python
"""Return reauth entry id.""" if self.source != SOURCE_REAUTH: raise ValueError(f"Source is {self.source}, expected {SOURCE_REAUTH}") return self.context["entry_id"] @callback def _get_reauth_entry(self) -> ConfigEntry: """Return the reauth config entry linked to the current...
Review this code and list any quality issues.
[ { "issue": "The method `async_set_dismiss_protected` lacks a docstring. Following the codebase documentation standards where every method and function requires a docstring (as seen throughout the codebase), this method should include documentation explaining its purpose, parameters, and usage. A docstring would...
1
python
from op_builder import __deepspeed__ # noqa: F401 # type: ignore from op_builder.cpu import CCLCommBuilder, ShareMemCommBuilder, FusedAdamBuilder, CPUAdamBuilder, NotImplementedBuilder except ImportError: from deepspeed.ops.op_builder.cpu import CCLCommBuilder, ShareMemCommBuilder, Fuse...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n # TODO: cpu's visible envs is confirmed, keep as CUDA_VISIBLE_DEVICES\r\n def visible_devices_envs(self):\r\n```", "severity": "minor", "line": 26 } ]
1
python
Usage: - Set your Google API key as environment variable: `export GOOGLE_API_KEY="your_api_key"` - Run `pip install agno google-genai Pillow` to install dependencies """ from pathlib import Path from agno.agent import Agent from agno.tools.nano_banana import NanoBananaTools # Example 1: Basic NanoBanana agent with d...
Review this code and list any quality issues.
[]
0
python
self._carrays = { field: LRUCache(maxsize=sid_cache_size) for field in self.FIELDS } self._last_get_value_dt_position = None self._last_get_value_dt_value = None def _get_metadata(self): return BcolzMinuteBarMetadata.read(self._rootdir) @lazyval def...
Review this code and list any quality issues.
[ { "issue": "Same as with `ohclv_ratio_for_sid`, should the `_default_ohlc_inverse` be returned here?", "severity": "minor", "line": 26 } ]
1
python
return f'{version}.{revision}' if revision else version def get_git_head(): with contextlib.suppress(Exception): sp = subprocess.Popen(['git', 'rev-parse', '--short', 'HEAD'], stdout=subprocess.PIPE) return sp.communicate()[0].decode().strip() or None VERSION = get_new_version((sys.argv + [''])[...
Review this code and list any quality issues.
[ { "issue": "if the env var doesnt exist (running locally), this should be skipped", "severity": "minor", "line": 26 } ]
1
python
) async def test_bedrock_anthropic_tool_with_thinking(allow_model_requests: None, bedrock_provider: BedrockProvider): """When using thinking with tool calls in Anthropic, we need to send the thinking part back to the provider. This tests the issue raised in https://github.com/pydantic/pydantic-ai/issues/2453...
Review this code and list any quality issues.
[ { "issue": "These change are a bit weird and I'm surprised our linter isn't complaining about them. Can you please revert them and keep the `\"\"\"` on the same line as the `(` or `)`?\r\n\r\nAfter that I'll merge :)", "severity": "minor", "line": 26 } ]
1
python
ImpersonateTarget('chrome', '99', 'windows', '10'): curl_cffi.requests.BrowserType.chrome99, ImpersonateTarget('edge', '101', 'windows', '10'): curl_cffi.requests.BrowserType.edge101, ImpersonateTarget('edge', '99', 'windows', '10'): curl_cffi.requests.BrowserType.edge99, **({ Impers...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n```\r\n\r\ncurl cffi does not support keeping header casing sometimes (e..g http/2 from memory)", "severity": "major", "line": 26 } ]
1
python
ExtractorError, clean_html, determine_ext, make_archive_id, merge_dicts, mimetype2ext, parse_duration, traverse_obj, unified_timestamp, urljoin, url_or_none, ) class TeamcocoBaseIE(TurnerBaseIE): _QUALITIES = { 'low': (480, 272), 'sd': (640, 360), 'h...
Review this code and list any quality issues.
[ { "issue": "FYI:\r\n```suggestion\r\n for src in traverse_obj(info, ('src', ..., {dict})):\r\n```\r\nis the recommended way now", "severity": "minor", "line": 26 } ]
1
python
def extract_spectrogram(spectrogram : numpy.ndarray[Any, Any], filter_total : int, steps : int, fps : float) -> List[numpy.ndarray[Any, Any]]: audio_frames = [] index = 0 while True: start_index = int(index * filter_total / fps) if start_index + steps > spectrogram.shape[1]: audio_frames.append(spectrogram[:,...
Review this code and list any quality issues.
[ { "issue": "Move the method to the very top of the file\r\n\r\nIs audio frame a real word?\r\n\r\n`Optional[numpy.ndarray[Any, Any]]:` ... hard to understand what this actual returns", "severity": "minor", "line": 26 } ]
1
python
# Copyright 2021-2024 Avaiga Private Limited # # Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with # the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agree...
Review this code and list any quality issues.
[ { "issue": "I would have called this '_is_function' to be honest.\r\n... and... can a class be callabled? Seriously??", "severity": "minor", "line": 17 } ]
1
python
:keyword max_sample_files: The maximum number of sample files. :paramtype max_sample_files: Optional[int] :keyword chunk_prepend_summary: Whether to prepend summary to each chunk. :paramtype chunk_prepend_summary: Optional[bool] :keyword document_path_replacement_regex: The regex for document path repla...
Review this code and list any quality issues.
[ { "issue": "Is the plan ultimately to have a \"supported_models\" list that we can easily add new models to?", "severity": "minor", "line": 26 } ]
1
python
login_submit_page, 'error', default=None) if error: raise ExtractorError(error, expected=True) class LinkedInLearningIE(LinkedInLearningBaseIE): IE_NAME = 'linkedin:learning' _VALID_URL = r'https?://(?:www\.)?linkedin\.com/learning/(?P<course_slug>[^/]+)/(?P<id>[^/?#]+)' _TEST = { ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n start_time, caption = line_dict['transcriptStartAt'] / 1000, line_dict['caption']\r\n end_time = next_dict['transcriptStartAt'] / 1000 if next_dict else duration or start_time + 1\r\n srt_data += '%d\\n%s --> %s\\n%s\\n' % (line + 1, srt_subtitles_t...
1
python
def get_device_name() -> str: r"""Get the name of available devices.""" if is_torch_xpu_available(): device = "xpu" elif is_torch_npu_available(): device = "npu" elif is_torch_mps_available(): device = "mps" elif is_torch_cuda_available(): device = "gpu" else: ...
Review this code and list any quality issues.
[]
0
python
val_dataloaders=valid_dataloader, export_onnx=False, max_epochs=1, limit_train_batches=2, limit_val_batches=3, ) evaluator.fit(model) # cleanup to avoid affecting later test cases _reset() def test_nasbench101(): ss = searchspace.NasBench101() _test_searchspace...
Review this code and list any quality issues.
[]
0
python
self.hass, SIGNAL_BINARY_EVENT_UPDATE.format( tag_id, event.type, mac ), tag, ) except Exception as ex: # noqa: BLE001 _LOG...
Review this code and list any quality issues.
[ { "issue": "The schema marks them as compulsory - so dropped `.get` access.", "severity": "minor", "line": 26 } ]
1
python
Brace.__init__(self, Line(point_1, point_2), direction=direction, **kwargs) class ArcBrace(Brace): """Creates a :class:`~Brace` that wraps around an :class:`~Arc`. The direction parameter allows the brace to be applied from outside or inside the Arc. .. warning:: The :class:`ArcBrace` is sma...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n The :class:`~.Arc` that wraps around the :class:`Brace` mobject.\r\n direction\r\n The direction from which the brace faces the arc.\r\n ``LEFT`` for inside the arc, and ``RIGHT`` for the outside.\r\n```", "severity": "minor", "line": 26 } ]
1
python
'ext': 'mp4', 'subtitles': subtitle_list, # it seems AcFun do not have subtitles **parse_codecs(video.get('codecs', '')) } for fmt in format_list] subtitles += subtitle_list self._sort_formats(formats) return { 'formats': formats, ...
Review this code and list any quality issues.
[ { "issue": "Does this URL not change? If it can, use regex\r\n```suggestion\r\n 'thumbnail': r're:https?://tx-free-imgs\\.acfun\\.cn/newUpload/\\w+.jpeg',\r\n```", "severity": "minor", "line": 26 } ]
1
python
ChatFunctionCall, ChatToolCall, CompletionRequest, CompletionResponse, CompletionResponseChoice, ListResponse, LogProbs, LogProbsContent, ModelResponse, UsageInfo, ) from ..server import ServerContext from . import entrypoint_utils app = fastapi.APIRouter() ################ v1/mode...
Review this code and list any quality issues.
[ { "issue": "Use `ServerContext.current()` for these places. And we do not need to introduce the `request` parameter.", "severity": "minor", "line": 26 } ]
1
python
if self.use_grad_accum_for_reduction: param.grad = None # Clear the tensor the reduction gradient attribute is pointing to def clear_grad_reduc(self, param): param.grad_reduc = None if self.use_grad_accum_for_reduction: param.grad_accum = None else: ...
Review this code and list any quality issues.
[ { "issue": "Hooks can incur runtime overheads that could be non-trivial for zero stage 1, so I would like to avoid them. Couldn't we call `set_grad_accum` for all params in the optimizer constructor?", "severity": "major", "line": 26 } ]
1
python
"as of date %s." % as_of_date) if fuzzy: return self._lookup_symbol_fuzzy(symbol, as_of_date) return self._lookup_symbol_strict(symbol, as_of_date) def lookup_symbols(self, symbols, as_of_date, fuzzy=False): """ Lookup a list of equities by symbol. Parameters ...
Review this code and list any quality issues.
[ { "issue": "Maybe add a note saying that it is the same as the list comprehension but better for performance.", "severity": "major", "line": 26 } ]
1
python
("mytest.db", "mytest_2.db"), ("mytest", "mytest_2"), ] for test_db_name, expected_source_db_name in tests: with self.subTest(test_db_name=test_db_name): # When calling setup_worker_connection(), the test database has been # created already and its...
Review this code and list any quality issues.
[ { "issue": "Not sure if all these mocks are warranted, but I assume we don't want the test to actually connect to the databases. All these connections are written in `setup_worker_connection` (not broken up into different methods), so we have to mock all of them.\n\nI added comments to clarify what each mock me...
1
python
}, { 'url': 'https://www.thisoldhouse.com/tv-episode/ask-toh-shelf-rough-electric', 'only_matching': True, }, { 'url': 'https://www.thisoldhouse.com/furniture/21017078/how-to-build-a-storage-bench', 'only_matching': True, }, { 'url': 'https://www.thisoldhouse.com/21113884...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n return self.url_result(self._request_webpage(HEADRequest(video_url), display_id).geturl(), 'Zype', display_id)\r\n```\r\n\r\nor \r\n```suggestion\r\n return self.url_result(video_url, 'Generic', display_id)\r\n```\r\nshould work too", "severity": "minor", ...
1
python
crops { name renditions { name width height url } } } } renditions { type width height url bitrate } summary } } }''' def _build_playli...
Review this code and list any quality issues.
[ { "issue": "I'd make this a generator instead of an append loop", "severity": "minor", "line": 26 } ]
1
python
available plus source control management and constructed. :returns: Dictionary of plugin cloud names plus source control. :rtype: dict[str, str] """ plugins = discover_available_cloud_provider_plugin_names() return dict(zip(plugins, plugins), scm='scm', constructed='constructed') @cache def loa...
Review this code and list any quality issues.
[ { "issue": "The description lives in `awx-plugins`. For example here is the azure description https://github.com/ansible/awx-plugins/blob/devel/src/awx_plugins/inventory/plugins.py#L154\r\n\r\nWe don't want the descriptions to be hard-coded here in awx because we don't know the entire set of plugins.\r\n\r\nSay...
1
python
## Llama4 ## @pytest.mark.skip( reason=( "RuntimeError: run_moe() Expected a value of type " "'Optional[List[Tensor]]' for argument '_9' but instead found type " "'list'." ) ) def test_llama4_fp8_tensor_moe_flashinfer_cutlass(monkeypatch: pytest.MonkeyPatch): can_initialize( ...
Review this code and list any quality issues.
[]
0
python
def do_delayed_imports(): global webdriver import webdriver global ServoCommandExtensions class ServoCommandExtensions: def __init__(self, session): self.session = session def get_prefs(self, *prefs): body = {"prefs": list(prefs)} return self.sessio...
Review this code and list any quality issues.
[ { "issue": "```\n./wptrunner/wptrunner/executors/executorservodriver.py:34:1: W293 blank line contains whitespace\n./wptrunner/wptrunner/executors/executorservodriver.py:38:1: W293 blank line contains whitespace\n```\nPer the CI failures in https://community-tc.services.mozilla.com/tasks/FisJG5vlTpqDDj8LB1U-Iw/...
1
python
""" Computes the integral of a 1D pdf between two bounds. Parameters ---------- low : scalar Lower bound of integration. high : scalar Upper bound of integration. Returns ------- value : scalar The result of the integr...
Review this code and list any quality issues.
[]
0
python
class Meta: ordering = ('-created',) # Remove view permission, as a temporary solution, defer to organization read permission default_permissions = ('add', 'change', 'delete') PULL_CHOICES = [ ('always', _("Always pull container before running.")), ('missing', _("Only pull t...
Review this code and list any quality issues.
[]
0
python
Returns ------- :class:`Mobject` ``self`` See also -------- :meth:`move_to` """ if config["use_opengl_renderer"]: self.apply_points_function( lambda points: scale_factor * points, works_on_bounding_box=True...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n \"\"\"Rotates the :class:`~.Mobject` about the ORIGIN, which is at [0,0,0].\"\"\"\r\n```", "severity": "minor", "line": 26 } ]
1
python
return None @metadata.request(peer_required=True) async def new_transaction( self, transaction: full_node_protocol.NewTransaction, peer: WSChiaConnection ) -> Optional[Message]: """ A peer notifies us of a new transaction. Requests a full transaction if we haven't seen it pr...
Review this code and list any quality issues.
[ { "issue": "you should check the fee here too", "severity": "minor", "line": 26 } ]
1
python
# Copyright 2025 - Oumi # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, softw...
Review this code and list any quality issues.
[ { "issue": "Our test structure is flat, no test suites.\r\n\r\nCursor does this by default generally unless you tell it not to...", "severity": "minor", "line": 20 } ]
1
python
# Typically implemented by subclass pass def get_sub_alpha(self, alpha: float, index: int, num_submobjects: int) -> float: """Get the animation progress of any submobjects subanimation. Parameters ---------- alpha The overall animation progress index ...
Review this code and list any quality issues.
[]
0
python
"""Utilities for with-statement contexts. See PEP 343.""" import abc from inspect import getattr_static, _descriptor_get import os import sys import _collections_abc from collections import deque from functools import wraps from types import GenericAlias __all__ = ["asynccontextmanager", "contextmanager", "closing", ...
Review this code and list any quality issues.
[ { "issue": "Eek, that's a heavy dependency to bring into contextlib by default. Maybe we could move the private helper to types and have both modules import it from there?", "severity": "major", "line": 3 } ]
1
python
def _map_provider_details( choice: chat_completion_chunk.Choice | chat_completion.Choice, ) -> dict[str, Any]: provider_details: dict[str, Any] = {} # Add logprobs to vendor_details if available if choice.logprobs is not None and choice.logprobs.content: provider_details['logprobs'] = _map_logp...
Review this code and list any quality issues.
[ { "issue": "Would it make sense to also put the logprobs on `ModelResponse.provider_details` when using `OpenAIResponsesModel`, since that's where people may currently be looking for it?", "severity": "minor", "line": 26 } ]
1
python
TODO: {evaluator_docstring} input_layers Mark the first layer of the model where the input needs to be quantified. Examples -------- >>> from nni.contrib.compression.quantization import DoReFaQuantizer >>> from nni.contrib.compression.utils import TorchEvaluator >>> model = ...
Review this code and list any quality issues.
[ { "issue": "please don't use a obj as function default value", "severity": "minor", "line": 26 } ]
1
python
try: from openai import AsyncOpenAI except ImportError as _import_error: # pragma: no cover raise ImportError( 'Please install the `openai` package to use OVHcloud AI Endpoints provider.' 'You can use the `openai` optional group — `pip install "pydantic-ai-slim[openai]"`' ) from _import_err...
Review this code and list any quality issues.
[ { "issue": "Could we check the prefix like we do in the other providers, or could something else come before this keyword?", "severity": "minor", "line": 26 } ]
1
python
} # https://stackoverflow.com/questions/61770698/sphinx-nit-picky-mode-but-only-for-links-i-explicitly-wrote nitpick_ignore = [(key, value) for key in type_targets for value in type_targets[key]] # The name of the Pygments (syntax highlighting) style to use. pygments_style = "sphinx" # -- Options for HTML output ----...
Review this code and list any quality issues.
[ { "issue": "Please refer to https://github.com/readthedocs/readthedocs.org/issues/6841 too", "severity": "minor", "line": 26 } ]
1
python
from .newsy import NewsyIE from .nextmedia import ( NextMediaIE, NextMediaActionNewsIE, AppleDailyIE, NextTVIE, ) from .nexx import ( NexxIE, NexxEmbedIE, ) from .nfb import ( NFBIE, NFBSeriesIE, ) from .nfhsnetwork import NFHSNetworkIE from .nfl import ( NFLIE, NFLArticleIE, ...
Review this code and list any quality issues.
[]
0
python
requestor_id, title, video_id, rating) query['auth'] = self._extract_mvpd_auth( url, video_id, requestor_id, resource) media_url = update_url_query(media_url, query) formats, subtitles = self._extract_theplatform_smil( media_url, video_id) self._sort_forma...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n thumbnails = []\r\n thumbnail_urls = [properties.get('imageDesktop')]\r\n if 'thumbnail' in info:\r\n thumbnail_urls.append(info.pop('thumbnail'))\r\n for thumbnail_url in thumbnail_urls:\r\n if not thumbnail_url:\r\n ...
1
python
# H5 and H6 should be part of H4 chunk assert len(chunks) == 4 assert "##### H5" in chunks[3].content assert "###### H6" in chunks[3].content # --- Tests for fallback behavior --- def test_fallback_splits_at_paragraphs(): """When markdown parsing fails, should fall back to paragraph splitting.""" ...
Review this code and list any quality issues.
[]
0
python
TEXT_DATASETS = { "gutenberg_english": "sedthh/gutenberg_english", # Gutenberg eBooks in English "gutenberg_multilang": "sedthh/gutenberg_multilang", # Gutenberg eBooks in foreign languages "tv_dialogue": "sedthh/tv_dialogue", # TV and Movie dialogues and transcripts "fd_dialogue": "sedthh/fd_dialogu...
Review this code and list any quality issues.
[]
0
python
def get_git_head_timestamp() -> str: return subprocess.run( [ "git", "log", "-1", "--pretty=format:%ct", ], text=True, stdout=subprocess.PIPE, ).stdout.strip() def main() -> None: with tempfile.TemporaryDirectory() as build_en...
Review this code and list any quality issues.
[ { "issue": "This won't work on Windows. I know this is primarily meant for GHA, but it'd be good for our release flow to work on everyone's machine when needed.", "severity": "minor", "line": 26 } ]
1
python
duration = int_or_none( current_programme.get('duration', {}).get('value')) thumbnail = None image_url = current_programme.get('image_url') if image_url: thumbnail = image_url.replace('{recipe}', 'raw') tracklist = [...
Review this code and list any quality issues.
[ { "issue": "You could inline and make it completely non-fatal by doing this:\r\n```suggestion\r\n 'chapters': traverse_obj(preload_state, (\r\n 'tracklist', 'tracks', lambda _, v: float_or_none(v['offset']['start']), {\r\n 'title': ('titles', ...
1
python
asset_name = bundle_name_pattern.split(asset)[0] if asset_name not in bundles_info: bundles_info[asset_name] = {} asset_version = asset.split(f"{asset_name}_v")[-1] bundles_info[asset_name][asset_version] = { "name": asset, "browser_dow...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n bundles_info[asset_name][asset_version] = dict(asset)\r\n```\r\nNo harm in copying the whole thing?", "severity": "minor", "line": 26 } ]
1
python
) self._move_into_position(width, height) def _ensure_valid_file(self): """Reads self.file_name and determines whether the given input file_name is valid. """ if self.file_name is None: raise Exception("Must specify file for SVGMobject") if self.file_nam...
Review this code and list any quality issues.
[ { "issue": "1) The operator `+` is not supported between a Path and a Literal.\r\n2) `self.file_path / \".svg\"` will give you `filepath/.svg` which is probably not what you want.", "severity": "minor", "line": 26 } ]
1
python
DEALINGS IN THE SOFTWARE. """ from typing import List, Literal, TypedDict from typing_extensions import NotRequired, Required class EmbedFooter(TypedDict): text: str icon_url: NotRequired[str] proxy_icon_url: NotRequired[str] class EmbedField(TypedDict): name: str value: str inline: NotRequ...
Review this code and list any quality issues.
[]
0