language
string
code-snippit
string
instruction
string
flaws
list
flaw_count
int64
python
parse_iso8601, traverse_obj, ) class TuneInBaseIE(InfoExtractor): _VALID_URL_BASE = r'https?://(?:www\.)?tunein\.com' def _extract_metadata(self, webpage, content_id): return self._search_json(r'window.INITIAL_STATE=', webpage, 'hydration', content_id, fatal=False) def _extract_formats_and_s...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n 'url': self._search_regex(r'File1=(.*)', playlist_content, 'url'),\r\n```", "severity": "minor", "line": 26 } ]
1
python
"null", "number", "object", "string", ] # Generate all combinations of 2 or more types TYPE_COMBINATIONS = [ list(combo) for size in range(2, len(TYPE_VALUES) + 1) for combo in itertools.combinations(TYPE_VALUES, size) ] @pytest.mark.parametrize("type_val", TYPE_VALUES) def test_schema_type_s...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\ndef test_schema_type_multiple_type_value() -> None:\r\n \"\"\"Test all possible values of TypeValue for Schema type field.\"\"\"\r\n schema = Schema(type=TYPE_VALUES)\r\n assert schema.type == TYPE_VALUES\r\n```\r\n\r\nI think now it's too much tests for such small feature....
1
python
from manim import ORIGIN, UR, Arrow, DashedVMobject, VGroup from manim.mobject.geometry.tips import ArrowTip, StealthTip def _collect_tips(mobject): return [mob for mob in mobject.get_family() if isinstance(mob, ArrowTip)] def test_dashed_arrow_has_single_tip(): dashed = DashedVMobject(Arrow(ORIGIN, 2 * UR)...
Review this code and list any quality issues.
[]
0
python
def _set_array(self, idx, x): idx_set = idx.ravel() x_set = x.ravel() if len(idx_set) != len(x_set): if len(x_set) == 1: x_set = np.full(len(idx_set), x_set[0], dtype=self.dtype) else: raise ValueError("Need len(index)==len(data) or len(data)...
Review this code and list any quality issues.
[]
0
python
response = self._download_json( f'https://chaturbate.{tld}/get_edge_hls_url_ajax/', video_id, data=urlencode_postdata({'room_slug': video_id}), headers={ **self.geo_verification_headers(), 'X-Requested-With': 'XMLHttpRequest', 'Accept':...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n 'is_live': True,\r\n 'age_limit': 18,\r\n 'formats': self._extract_m3u8_formats(m3u8_url, video_id, ext='mp4', live=True),\r\n```", "severity": "major", "line": 26 } ]
1
python
def __init__(self, batch_size_limit=16): self.batch_size_limit = batch_size_limit def on_step_end(self, args, state, control, **kwargs): # simulate OOM on the first step if state.train_batch_size >= self.batch_size_limit: raise RuntimeError("CUDA out of memory.") def ForCausal...
Review this code and list any quality issues.
[ { "issue": "Although this is a test, it's probably better to not divide by `.numel()` or the number of items, but do the pure mean, since there might be padding tokens.\r\n\r\n```suggestion\r\n if num_items_in_batch is None or disable_num_items_in_batch:\r\n loss = nn.functional.cross_entropy(shift_lo...
1
python
'view_count': self._get_count(playlist_stats, 1), 'availability': self._extract_availability(data), 'modified_date': strftime_or_none(last_updated_unix, '%Y%m%d'), 'playlist_count': self._get_count(playlist_stats, 0), 'channel_follower_count': self._get_count(data, ('head...
Review this code and list any quality issues.
[ { "issue": "This is needed to properly terminate mixes", "severity": "minor", "line": 26 } ]
1
python
m.argmin(fill_value=lambda x: 27) # E: No overload variant np.ma.argmin(m, axis=1.0) # E: No overload variant np.ma.argmin(m, axis=(1,)) # E: No overload variant np.ma.argmin(m, keepdims=1.0) # E: No overload variant np.ma.argmin(m, out=1.0) # E: No overload variant np.ma.argmin(m, fill_value=lambda x: 27) # E: ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\nm.sort(stable='cabbage') # E: No overload variant\r\nm.sort(stable=True) # E: No overload variant\r\n```", "severity": "minor", "line": 26 } ]
1
python
'withSuperFollowsTweetFields': True, 'withSuperFollowsUserFields': True, 'withV2Timeline': True, 'withVoice': True, }, 'features': { 'graphql_is_translatable_rweb_tweet_is_translatable_enabled': False, 'interactive_t...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n self.write_debug(f'Using GraphQL API (Auth = {self.is_logged_in})')\r\n```", "severity": "critical", "line": 26 } ]
1
python
return series def get_longest_back_rolling(self): if self.N == 0: return np.inf return self.feature.get_longest_back_rolling() + self.N def get_extended_window_size(self): if self.N == 0: get_module_logger(self.__class__.__name__).warning("The Ref(ATTR, 0) will ...
Review this code and list any quality issues.
[]
0
python
(?P<series>browse\.html\?series=)| (?P<episode>watch.html\?id=) )(?P<id>[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}) $""" _TEST = { "url": "https://tube.tugraz.at/paella/ui/watch.html?id=f2634392-e40e-4ac7-9ddc-47764aa23d40", "md5": "a23a3d5c9aaca2b84932fdba66e17145"...
Review this code and list any quality issues.
[ { "issue": "inline the URLs that are only used once", "severity": "minor", "line": 26 } ]
1
python
latest_block.deficit if latest_block.deficit > 0 else constants.MIN_BLOCKS_PER_CHALLENGE_BLOCK ) icc_eos_vdf, icc_ip_proof = get_icc( constants, uint128(sub_slot_start_total_iters + sub_slot_iters), finished_sub_slots_at_ip, latest_...
Review this code and list any quality issues.
[]
0
python
) ] ) ) def test_sources_list_with_event_handler_but_no_display_url(self): self.run_servoshell(url='data:text/html,<a onclick="1"></a>') self.assert_sources_list(Counter([frozen_multiset([])])) @unittest.expectedFailure def test_sources_list_with_dom_tim...
Review this code and list any quality issues.
[]
0
python
wheel_cache=wheel_cache, use_user_site=use_user_site, force_reinstall=force_reinstall, ignore_installed=ignore_installed, ignore_requires_python=ignore_requires_python, py_version_info=py_version_info, ) self.ignore_dependencies = ignore_depend...
Review this code and list any quality issues.
[ { "issue": "Rather than accessing a private attribute add a property to `PipProvider` and then use `provider.constraints`:\r\n\r\n```python\r\n @property\r\n def constraints(self) -> dict[str, Constraint]:\r\n return self._constraints\r\n```", "severity": "minor", "line": 26 } ]
1
python
sine = ax.plot(np.sin, color=RED) alpha = ValueTracker(0) point = always_redraw( lambda: Dot( sine.point_from_proportion(alpha.get_value()), color=BLUE) ) tangent = always_...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n \"\"\"A mobject which is continuously shifted along some direction\r\n at a certain rate.\r\n```", "severity": "minor", "line": 26 } ]
1
python
value__contains={"baz": {"a": "b", "c": "d"}}, ).get() @skipUnlessDBFeature( "supports_primitives_in_json_field", "supports_json_field_contains", ) def test_contains_primitives(self): for value in self.primitives: with self.subTest(value=value): ...
Review this code and list any quality issues.
[]
0
python
# This module is automatically generated by autogen.sh. DO NOT EDIT. from . import _OnPrem class _Client(_OnPrem): _type = "client" _icon_dir = "resources/onprem/client" class Client(_Client): _icon = "client.png" class User(_Client): _icon = "user.png" class Users(_Client): _icon = "users....
Review this code and list any quality issues.
[]
0
python
elif isinstance(insn.opers[0], envi.archs.i386.disasm.i386PcRelOper): imports = get_imports(f.vw) target = capa.features.extractors.viv.helpers.get_coderef_from(f.vw, insn.va) if not target: return if f.vw.metadata["Format"] == "elf": if "symtab" not in fh.ctx["c...
Review this code and list any quality issues.
[ { "issue": "what if there is no symtab? or if parsing fails? lets:\r\n\r\n 1. wrap the parsing in a try/except\r\n 2. if theres no symtab (or corrupt), skip the logic", "severity": "critical", "line": 26 } ]
1
python
self.logger.info(f"Set {len(recorder)} models to '{tag}'.") def get_online_tag(self, recorder: Recorder) -> str: """ Given a model recorder and return its online tag. Args: recorder (Recorder): an instance of recorder Returns: str: the online tag ""...
Review this code and list any quality issues.
[ { "issue": "This piece of code appears too many times.\r\nPlease create a new function like `def _get_exp_name(exp_name) -> str` (error may be raised in this method)", "severity": "minor", "line": 26 } ]
1
python
'id': '20831', 'ext': 'mp4', 'description': 'Gefühle pur: Schaut euch die ungeschnittene Version von Stefans Liebesbeweis an die Moderationsgrazie von Welt, Verona Feldbusch, an.', 'title': 'Raabigramm Verona Feldbusch', 'thumbnail': r're:.*\.jpg', 'episode_nu...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n for group in self._search_regex(r'/myspass2009/\\d+/(\\d+)/(\\d+)/(\\d+)/', video_url, 'myspass', group=(1,2,3), default=[]):\r\n```", "severity": "minor", "line": 26 } ]
1
python
"""Unified callable function API of Inferers. Args: inputs: model input data for inference. network: target model to execute inference. supports callables such as ``lambda x: my_torch_model(x, additional_config)`` args: other optional args to be passed to the...
Review this code and list any quality issues.
[ { "issue": "I was not sure about the `while True` loop, so changed it to be sure at most 10 iterations", "severity": "minor", "line": 26 } ]
1
python
Raises ------ ValueError If the provided parameters do not allow to choose a vali window function with valid parameters. Notes ----- Note that by default this function returns a periodic window, whereas the wrapped window functions return a symmetric window by default. This is c...
Review this code and list any quality issues.
[ { "issue": "Is this supposed to be the same as the Blackman window above?", "severity": "minor", "line": 26 } ]
1
python
) if enable_1min: GetData().qlib_data( name="qlib_data", region=REG_CN, interval="1min", target_dir=cls.provider_uri_1min, delete_old=False, exists_skip=True, ) provider_uri_map = {"...
Review this code and list any quality issues.
[ { "issue": "Why do you import them in the method instead of at the head of this file?", "severity": "minor", "line": 26 } ]
1
python
+ generated_file_labels # We also need the Bazel C++ runfiles that aren't "generated", but not # linked into place until built. + ["@bazel_tools//tools/cpp/runfiles:runfiles"] ) def _get_config_for_entry(entry: Dict[str, Any]) -> str: """Returns the configuration for a compile command ...
Review this code and list any quality issues.
[ { "issue": "style: please use either a one-line docstring, or a multiline docstring with a one-line summary. More info at https://peps.python.org/pep-0257/#multi-line-docstrings (particularly \"The summary line may be used by automatic indexing tools; it is important that it fits on one line and is separated fr...
1
python
def mix_tmp(count): nonlocal tmp for i in range(count): mix_once(tmp) def mix_twist(nonce): nonlocal tmp mix_once(base64.urlsafe_b64encode(tmp).rstrip(b'=') + nonce) mix_once(cls._SECRETKEY) mix_tmp(time_struct.tm_mon) mix...
Review this code and list any quality issues.
[ { "issue": "note to maintainers: Update the version before merge", "severity": "minor", "line": 26 } ]
1
python
'url': 'https://volej.tv/match/487520', 'info_dict': { 'id': '487520', 'ext': 'mp4', 'thumbnail': r're:https://.+\.(png|jpeg)', 'title': 'CZE-FRA (2024-09-06)', 'categories': ['mládež'], 'series': 'Mistrovství Evropy do 20 let', ...
Review this code and list any quality issues.
[ { "issue": "format metadata should not be fatal", "severity": "minor", "line": 26 } ]
1
python
message = f'status_code: {status_code}, model_name: {model_name}, body: {body}' super().__init__(model_name=model_name, message=message) class ContentFilterError(ModelHTTPError): """Raised when content filtering is triggered by the model provider.""" def __init__(self, message: str, status_code: int,...
Review this code and list any quality issues.
[ { "issue": "this might seem a bit picky but `Prompt content filtered by the model` doesn't seem right\r\n\r\n**Prompt**\r\nplease change to `Model '{model_name}' content filter was triggered by the user's prompt`\r\n\r\n**Response**\r\nplease change to `Model '{model_name}' triggered its content filter while ge...
1
python
Set True to have the animation start erasing from the last submobject first. Examples -------- .. manim:: UnwriteReverseFalse class UnwriteReverseFalse(Scene): def construct(self): text = Tex("Alice and Bob").scale(3) self.add(text) self...
Review this code and list any quality issues.
[ { "issue": "I haven't tried this locally yet, but I don't see how the behavior of `Unwrite` is preserved if the logic is flipped and moved to `Write`. Doesn't `Unwrite` now do the same as `Write`?\r\n\r\n(I'm on mobile, so it's likely that I've missed something.)", "severity": "minor", "line": 26 } ]
1
python
tasks = [tasks] if len(tasks) == 0: return [] if train_func is None: train_func = self.train_func if experiment_name is None: experiment_name = self.experiment_name task_pool = self.task_pool if task_pool is None: task_pool = experi...
Review this code and list any quality issues.
[ { "issue": "Please use the constant variable instead of string", "severity": "minor", "line": 26 } ]
1
python
) rq_2 = await RequestQueue.open( alias='test_alias_2', storage_client=storage_client, ) # Verify they have different IDs but no names (unnamed) assert rq_1.id != rq_2.id assert rq_1.name is None assert rq_2.name is None # Add different requests to each await rq_1.add_r...
Review this code and list any quality issues.
[]
0
python
def __delitem__(self, name: str) -> None: return self.delete(name) def __len__(self) -> int: return len(self.jar) def __iter__(self) -> typing.Iterator[str]: return (cookie.name for cookie in self.jar) def __bool__(self) -> bool: for _ in self.jar: return True ...
Review this code and list any quality issues.
[ { "issue": "(Nit) Possible simplification using f-strings:\r\n\r\n```suggestion\r\n cookies_repr = \", \".join(\r\n f\"<Cookie {cookie.name}={cookie.value} for {cookie.domain} />\"\r\n for cookie in self.jar\r\n )\r\n```", "severity": "minor", "line": 26 } ]
1
python
def set_vocab(self): # deal with intern-s1 if self.origin_hf_arch == 'InternS1ForConditionalGeneration': self._set_vocab_interns1() return super().set_vocab() @ModelBase.register("RND1") class RND1Model(Qwen3MoeModel): model_arch = gguf.MODEL_ARCH.RND1 def __in...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n if (mask_token_id := self.hparams.get(\"mask_token_id\")) is not None:\r\n```", "severity": "minor", "line": 26 } ]
1
python
vm = uvm_with_rng check_entropy(vm.ssh) def test_rng_snapshot(uvm_with_rng, microvm_factory): """ Test that a virtio-rng device is functional after resuming from a snapshot """ vm = uvm_with_rng check_entropy(vm.ssh) snapshot = vm.snapshot_full() new_vm = microvm_factory.build() ...
Review this code and list any quality issues.
[ { "issue": "why do we need the 10% margin actually? Should the measured value not be less or equal to the desired?", "severity": "minor", "line": 26 } ]
1
python
If the delta table doesn't exist and MERGE action is triggered Notes ----- The Polars data types :class:`Null` and :class:`Time` are not supported by the delta protocol specification and will raise a TypeError. Columns using The :class:`Categorical` data type will be converted t...
Review this code and list any quality issues.
[ { "issue": "All of these `df.sink_delta()` need to be `df.lazy().sink_delta()`.\n\nIf possible it would help to add an example that highlights the lazy functionality (e.g. `pl.scan_parquet().sink_delta()`", "severity": "minor", "line": 26 } ]
1
python
}, "track_data": True, "generate_report": True, "indicator_config": { "show_indicator": True, }, }, }, "backtest": { "start_time": "2020-01-01", "end_time": "2020-12-31", "...
Review this code and list any quality issues.
[ { "issue": "Please don't commit these code", "severity": "minor", "line": 26 } ]
1
python
chapter_list = [{ 'start_time': chapter_time(chapter), 'title': chapter_title(chapter), } for chapter in chapter_list or []] if not strict: chapter_list.sort(key=lambda c: c['start_time'] or 0) chapters = [{'start_time': 0}] for idx, chapter in enumer...
Review this code and list any quality issues.
[ { "issue": "There is no way for us to extract a more accurate timestamp, correct? Then let's leave it enabled by default", "severity": "major", "line": 26 } ]
1
python
old_codename = perm.codename new_codename = f"{action}{new_suffix}" new_name_str = f"Can {action} {camel_case_to_spaces(new_name)}" if perm.codename == new_codename and perm.name == new_name_str: continue perm.codename = new_codename ...
Review this code and list any quality issues.
[ { "issue": "These are just attribute accesses, so it's simple enough to just use an f-string.", "severity": "minor", "line": 26 } ]
1
python
log.debug("Received 401 from Keycloak: %s", resp.text) return set() if resp.status_code == 403: return set() if resp.status_code == 400: error = json.loads(resp.text) raise AirflowException( f"Request not recognized by Keycloak. {error.get(...
Review this code and list any quality issues.
[ { "issue": "Link is currently not completely correct:\r\n\r\n```suggestion\r\n # See: https://www.keycloak.org/docs/latest/authorization_services/index.html#_service_pushing_claims\r\n```", "severity": "critical", "line": 26 } ]
1
python
# # Copyright 2016 Quantopian, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in wr...
Review this code and list any quality issues.
[ { "issue": "(Though see note below re: storing contracts as a list vs tuple.)", "severity": "minor", "line": null } ]
1
python
is_meeting = form.get('useWhichPasswd') == 'meeting' validation = self._download_json( base_url + 'rec/validate%s_passwd' % ('_meet' if is_meeting else ''), play_id, 'Validating passcode', 'Wrong passcode', data=urlencode_postdata({ 'id': form[('meet' if i...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n formats = []\r\n```", "severity": "minor", "line": 26 } ]
1
python
with open(gui_pyi_file, "w") as write_file: write_file.write(replaced_content) # ################################################################################################## # Generate Page Builder pyi file (gui/builder/__init__.pyi) # #########################################################################...
Review this code and list any quality issues.
[ { "issue": "should this import be first to please the linter ?", "severity": "minor", "line": 26 } ]
1
python
'height': try_get(hls_fmts, lambda x: x[0]['height'], int), }) self._sort_formats(formats) uploader_url = try_get(metadata, lambda x: x['live']['user']['user_path'], compat_str) if uploader_url: uploader_url = 'https://whowatch.tv/profile/%s' % uploader_url ...
Review this code and list any quality issues.
[ { "issue": "`upload_date` will be automatically calculated from `timestamp`\r\n\r\n```suggestion\r\n 'timestamp': timestamp,\r\n```", "severity": "minor", "line": 26 } ]
1
python
default=None, description=""" Configuration for the persistence store used by the inference API. Can be either a InferenceStoreConfig (with queue tuning parameters) or a SqlStoreConfig (deprecated). If not specified, a default SQLite store will be used.""", ) conversations_store: SqlStoreConfig | None ...
Review this code and list any quality issues.
[ { "issue": "just have a default?\n```suggestion\n telemetry: TelemetryConfig = Field(default_factory=TelemetryConfig, description=\"Configuration for telemetry\")\n```", "severity": "minor", "line": 26 } ]
1
python
orig_func = getattr(service_type, name, None) if orig_func is None: raise AttributeError(f"Method {name} not found in {service_type}") sig = inspect.signature(orig_func) ret_ann = sig.return_annotation if ret_ann != inspect.Signature.empty: ...
Review this code and list any quality issues.
[ { "issue": "I guess this works, but `\"OK\"` is a magic value that can't be differentiated by type from an unhealthy response. I'd suggest letting `health_check` raise an error on failure and treating an error-less call to `health_check` as healthy.", "severity": "critical", "line": 26 } ]
1
python
model_type_instance = model_config.provider_model_bundle.model_type_instance model_type_instance = cast(LargeLanguageModel, model_type_instance) self._task_state.llm_result.usage = model_type_instance.calc_response_usage( model, credentials, prompt_tokens, completion_tokens ) de...
Review this code and list any quality issues.
[ { "issue": "I suggest using the early return trick to simplify this code.", "severity": "major", "line": 26 } ]
1
python
def _og_search_title(self, webpage, fatal=False): title = super()._og_search_title(webpage, fatal=fatal) return re.split(r'\s+[-|]\s+ZDF(?:mediathek)?$', title or '')[0] or None def _real_extract(self, url): channel_id = self._match_id(url) webpage = self._download_webpage(url, cha...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n rf'''(<a\\b[^>]*?\\shref\\s*=[^>]+?\\sdata-target-id\\s*=\\s*([\"']){m.group(\"p_id\")}\\2[^>]*>)''',\r\n```", "severity": "minor", "line": 26 } ]
1
python
'format_id': ext, **traverse_obj(media, { 'width': ('frameWidth', {int_or_none}), 'height': ('frameHeight', {int_or_none}), # NB: filesize is 0 if unknown, bitrate is -1 if unknown 'filesize': ('fileSize'...
Review this code and list any quality issues.
[ { "issue": "Use the md5 or a partial regex", "severity": "minor", "line": 26 } ]
1
python
from sympy.assumptions.ask import Q from sympy.assumptions.refine import refine from sympy.core.expr import Expr from sympy.core.numbers import (I, Rational, nan, pi) from sympy.core.singleton import S from sympy.core.symbol import Symbol from sympy.functions.elementary.complexes import (Abs, arg, im, re, sign) from sy...
Review this code and list any quality issues.
[ { "issue": "Oh - one last thing. I almost missed this. You should import floor and ceiling like you did inside the function: \"from sympy.functions.elementary.integers import floor, ceiling\"", "severity": "minor", "line": 15 } ]
1
python
(operator.ge,), (operator.lt,), (operator.le,), ]) def test_comparison_errors(self, op): for column in TDS.columns: with self.assertRaises(TypeError): op(column, 1000) with self.assertRaises(TypeError): op(1000, column) ...
Review this code and list any quality issues.
[ { "issue": "This needs to happen outside the `with` block, otherwise it won't get hit.", "severity": "minor", "line": 26 } ]
1
python
@pytest.mark.required @pytest.mark.parametrize("backend", [gs.cpu]) def test_gravity(show_viewer): base_rpm = 14468.429183500699 scene = gs.Scene( show_viewer=show_viewer, sim_options=gs.options.SimOptions( dt=0.01, substeps=1, gravity=[(0.0, 0.0, -9.8), (0.0,...
Review this code and list any quality issues.
[ { "issue": "For the dropping sphere, you should be able to check analytically that the positions match the theory.", "severity": "minor", "line": 26 } ]
1
python
def construct(self): c = Circle() c.to_corner(UR) t = Tex("To the corner!") t2 = MathTex("x^3").shift(DOWN) self.add(c,t,t2) t.to_corner(DL, buff=0) t2.to_corner(UL, buff=1.5) ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n .. manim:: ToEdgeExample\r\n :save_last_frame:\r\n class ToEdgeExample(Scene):\r\n```", "severity": "minor", "line": 26 } ]
1
python
'title': '#138 Nepilnīgā kompensējamo zāļu sistēma pat mēnešiem dzenā pacientus pa aptiekām', 'thumbnail': 'https://pic.latvijasradio.lv/public/assets/media/9/d/large_fd4675ac.jpg', 'upload_date': '20231102', 'timestamp': 1698913860, 'description': 'md5:7bac3b2dd41e443250...
Review this code and list any quality issues.
[ { "issue": "same here\r\n```suggestion\r\n 'formats': self._extract_m3u8_formats(data['playback']['service']['hls_url'], video_id),\r\n```\r\n\r\nand do we want to try extracting subs from the m3u8 too?", "severity": "major", "line": 26 } ]
1
python
aws_region: Optional[str] = None, profile_name: Optional[str] = None, token: Optional[str] = None, **kwargs, ): """Initializes the S3Provider Example: >>> s3_provider = S3Provider("snark-test/benchmarks") Args: root (str): The root of the pr...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n **kwargs: Additional arguments to pass to the S3 client. Includes: ``expiration``.\r\n```", "severity": "minor", "line": 26 } ]
1
python
"input": params.input, "encoding_format": params.encoding_format if params.encoding_format is not None else NOT_GIVEN, "dimensions": params.dimensions if params.dimensions is not None else NOT_GIVEN, "user": params.user if params.user is not None else NOT_GIVEN, } # ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\n if hasattr(response, \"usage\"):\n```", "severity": "minor", "line": 26 } ]
1
python
api\.arte\.tv/api/player/v\d+/config/(?P<lang_2>%(langs)s) ) /(?P<id>\d{6}-\d{3}-[AF]) ''' % {'langs': ArteTVBaseIE._ARTE_LANGUAGES} _TESTS = [{ 'url': 'https://www.arte.tv/en/videos/088501-000-A/mexico-stealing-petrol-to-survive/', ...
Review this code and list any quality issues.
[ { "issue": "Using `__` doesn't really make sense here, but 🤷", "severity": "minor", "line": 26 } ]
1
python
async def _generate_inline_policy_statement_from_mapping( generator: ChangeGeneratorModel, ) -> Dict: """ Generates an inline policy statement given a ChangeGeneratorModel from a action mapping stored in configuration. :param generator: ChangeGeneratorModel :return: policy_statement: A dictionary r...
Review this code and list any quality issues.
[]
0
python
:class:`get_x_axis_label` :class:`get_y_axis_label` """ self.axis_labels = VGroup( self.get_x_axis_label(x_label), self.get_y_axis_label(y_label), ) return self.axis_labels def add_coordinates( self, *axes_numbers: Optional[Iterable[float]], ...
Review this code and list any quality issues.
[ { "issue": "Since the default x,y,z ranges of `ThreeDAxes` are (-6, 6, 1), (-5, 5, 1) and (-4, 4, 1) respectively, I think it would be better to have these ranges within the axes's ranges. \r\n```suggestion\r\n x_labels = range(-4, 5)\r\n z_labels = range(-4, 4, 2)\r\n```", "severity":...
1
python
from controllers.console.auth.error import ( AuthenticationFailedError, EmailCodeError, EmailPasswordResetLimitError, InvalidEmailError, InvalidTokenError, PasswordMismatchError, ) from controllers.console.error import EmailSendIpLimitError from controllers.console.wraps import email_password_lo...
Review this code and list any quality issues.
[ { "issue": "The code field is defined as `code: str` without using `Field(...)`, which is inconsistent with the console version. The console version of ForgotPasswordCheckPayload (api/controllers/console/auth/forgot_password.py:38) uses `code: str = Field(...)` to explicitly mark it as required. For consistency...
1
python
self.cache.store( self._NETRC_MACHINE, 'token_data', ( self._get_vrt_cookie(self._ACCESS_TOKEN_COOKIE_NAME), self._get_vrt_cookie(self._VIDEO_TOKEN_COOKIE_NAME))) self.cache.store(self._NETRC_MACHINE, 'refresh_token', self._get_vrt_cookie(self._REFRESH_TOKEN_COOKIE_NA...
Review this code and list any quality issues.
[ { "issue": "to go with the above suggestion\r\n```suggestion\r\n }))['data']['page']\r\n```", "severity": "minor", "line": 26 } ]
1
python
for mob in self.get_all_mobjects_to_update(): mob.update(dt) def get_all_mobjects_to_update(self) -> List[Mobject]: """Get all mobjects to be updated during the animation. Returns ------- List[Mobject] The list of mobjects to be updated during the animation....
Review this code and list any quality issues.
[]
0
python
site_id = "123456" device = device_registry.async_get_device(identifiers={(DOMAIN, site_id)}) assert device is not None assert device.sw_version == "23.44.0 eb113390" # Update mock to return new version on next poll updated_site_info = deepcopy(SITE_INFO) updated_site_info["response"]["version"...
Review this code and list any quality issues.
[ { "issue": "I think you can use [parameterized tests](https://docs.pytest.org/en/stable/example/parametrize.html) here to remove redundant test setup?", "severity": "minor", "line": 26 } ]
1
python
import sys import pytest from ..utils.commands import capture @pytest.mark.slow def test_unicode_partial_movie(tmpdir, simple_scenes_path): # Characters that failed for a user on Windows # due to its weird default encoding. unicode_str = "三角函数" scene_name = "SquareToCircle" command = [ ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\nfrom manim.utils.commands import capture\r\n```", "severity": "minor", "line": 5 } ]
1
python
) if data: sys.exit(1) @cli_utils.action_cli @suppress_logs_and_warning @providers_configuration_loaded def dag_report(args) -> None: """Display dagbag stats at the command line.""" manager = DagBundlesManager() all_bundles = list(manager.get_all_dag_bundles()) if args.bundle_name: ...
Review this code and list any quality issues.
[ { "issue": "`include_examples` should always be False when loading from a bundle (because example dags are not in the bundle… obviously), so this should be handled in BundleDagBag’s `__init__` instead of repeated in every instantiation.", "severity": "minor", "line": 26 } ]
1
python
# Check migration was successful assert config_entry.state is ConfigEntryState.LOADED assert config_entry.data == { CONF_BASE_URL: "https://mastodon.social", CONF_CLIENT_ID: "client_id", CONF_CLIENT_SECRET: "client_secret", CONF_ACCESS_TOKEN: "access_token", } assert conf...
Review this code and list any quality issues.
[ { "issue": "In this parametrized test, `exc` is an exception *type* (used as a mock `side_effect`), not an exception instance. Adjust the type hint to `type[Exception]` (or a more specific exception base) to match how the parameter is used and avoid confusing type checkers/readers.", "severity": "minor", ...
1
python
with self.assertRaisesMessage(ValidationError, expected_message): field.clean(100, None) def test_max_decimal_places_validation(self): field = models.DecimalField(decimal_places=1) expected_message = validators.DecimalValidator.messages[ "max_decimal_places" ] % {"ma...
Review this code and list any quality issues.
[ { "issue": "Please remove \"sqlite\" from the test name.", "severity": "minor", "line": 26 } ]
1
python
if name is None or '{' in name: return (name, [], []) elif self._settings["disable_split_super_sub"]: name, supers, subs = (name.replace('_', '\\_').replace('^', '\\^'), [], []) else: name, supers, subs = split_super_sub(name) name = translate(name) su...
Review this code and list any quality issues.
[]
0
python
self.num_nodes = 2 # Don't test trickling logic self.noban_tx_relay = True def add_output_to_create_multi_result(self, result, output_value=0): """ Add output without changing absolute tx fee """ assert len(result["tx"].vout) > 0 assert result["tx"].vout[0].nValue >...
Review this code and list any quality issues.
[ { "issue": "micro-nit, no need to invalidate acks\r\n```suggestion\r\n \"\"\"Creates a 1P1C package containing ephemeral dust by default. By default, the parent transaction\r\n```", "severity": "minor", "line": 26 } ]
1
python
setattr(opts, opt1, default) # Conflicting options report_conflict('--playlist-reverse', 'playlist_reverse', '--playlist-random', 'playlist_random') report_conflict('--playlist-reverse', 'playlist_reverse', '--lazy-playlist', 'lazy_playlist') report_conflict('--playlist-random', 'playlist_random', '--l...
Review this code and list any quality issues.
[]
0
python
model = Net(4, 2) x = torch.rand((16, 16), dtype=torch.float) self.run_test(model, (x, )) def test_append_input_tensor(self): from typing import List class Net(nn.Module): def __init__(self, num_nodes): super().__init__() self.ops = nn.Mo...
Review this code and list any quality issues.
[ { "issue": "Suggest to change this function name to \"test_channel_shuffle\" for a clearer instruction. My fault.", "severity": "minor", "line": 26 } ]
1
python
def _extract_notification(self, notification): # notificationRenderer video_id = traverse_obj( notification, ('navigationEndpoint', 'watchEndpoint', 'videoId'), expected_type=str) if not video_id: return None thumbnails = traverse_obj(notification, ('videoThumbnai...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n @classmethod\r\n def _extract_next_notification_continuation_data(cls, renderer):\r\n```", "severity": "major", "line": 26 } ]
1
python
) id_node = onnx.helper.make_node( "Identity", inputs=["sum_out"], outputs=["scan_out"] ) scan_body = onnx.helper.make_graph( [add_node, id_node], "scan_body", [sum_in, next_], [sum_out, scan_out] ) # create scan op node no_sequence_lens = "" # op...
Review this code and list any quality issues.
[]
0
python
vlarr = self._handle.create_vlarray(self.group, key, _tables().ObjectAtom()) vlarr.append(value.to_numpy()) node = getattr(self.group, key) node._v_attrs.value_type = str(value.dtype) elif empty_array: self.write_array_empty(key, value) else: s...
Review this code and list any quality issues.
[ { "issue": "This was added back in #54431. I do not believe it is no longer necessary - we will infer string in the Series constructor.", "severity": "minor", "line": 26 } ]
1
python
self.decoder_hidden_size = decoder_hidden_size if masking_ratio <= 0 or masking_ratio >= 1: raise ValueError(f"masking_ratio should be in the range (0, 1), got {masking_ratio}.") self.masking_ratio = masking_ratio self.cls_token = nn.Parameter(torch.zeros(1, 1, hidden_size)) ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n blocks = [\r\n TransformerBlock(hidden_size, mlp_dim, num_heads, dropout_rate, qkv_bias, save_attn)\r\n for _ in range(num_layers)\r\n ]\r\n self.blocks = nn.Sequential(*blocks, nn.LayerNorm(hidden_size))\r\n```\r\nThis is a suggested simp...
1
python
# Set max_concurrency to 1 to ensure testing max_requests_per_crawl accurately crawler = BasicCrawler( concurrency_settings=ConcurrencySettings(desired_concurrency=1, max_concurrency=1), max_crawl_depth=2, ) @crawler.router.handler('start') async def start_handler(context: BasicCrawling...
Review this code and list any quality issues.
[]
0
python
def construct_model_from_line(model: Type[BaseModel], line: List[str]) -> BaseModel: origin = get_origin(model) # If the model is of type Optional[X], unwrap it to get X if origin is Union: # If the model is of type Optional[X], unwrap ...
Review this code and list any quality issues.
[ { "issue": "use thr fastapi status codes and not plain numbers", "severity": "minor", "line": 26 } ]
1
python
from flask_restx import Resource from pydantic import BaseModel from werkzeug.exceptions import Forbidden from controllers.console import console_ns from controllers.console.wraps import account_initialization_required, setup_required from core.model_runtime.entities.model_entities import ModelType from core.model_run...
Review this code and list any quality issues.
[ { "issue": "Consider using the register_schema_model helper from controllers.common.schema instead of calling console_ns.schema_model directly. This would make the code more consistent with newer refactored files and reduce boilerplate code.", "severity": "major", "line": 25 } ]
1
python
if not isinstance(text, list): text = [text] for item in cast(list, text): if isinstance(item, str): input_.append(Document(text=item, id_=str(uuid.uuid4()))) elif isinstance(item, Document): input_.append(item) else: ...
Review this code and list any quality issues.
[ { "issue": "Now Python has a more advanced `pathlib` module, I think we should avoid using `os.path.xxx` and using the pathlib's equivalent methods when possible.", "severity": "minor", "line": 26 } ]
1
python
# number of fragment that would subsequently requested with (`&sq=N`) if fmt_stream.get('type') == 'FORMAT_STREAM_TYPE_OTF' and not bool(fmt_stream.get('drmFamilies')): continue stream_id = get_stream_id(fmt_stream) if not all_formats:...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n # We still need to register original/default language information\r\n # See: https://github.com/yt-dlp/yt-dlp/issues/14883\r\n```", "severity": "minor", "line": 26 } ]
1
python
except ImportError: return "deepspeed.ops.op_builder" # create an instance of op builder, specified by class_name def create_op_builder(self, op_name): builder_class = self.get_op_builder(op_name) if builder_class is not None: return builder_class() return None ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n # TODO: mpu's visible envs is confirmed, keep as CUDA_VISIBLE_DEVICES\r\n def visible_devices_envs(self):\r\n```", "severity": "minor", "line": 26 } ]
1
python
# Pre-migration verification check_comments() # Migrate _, wallet = self.migrate_and_get_rpc("persist_comments") # Post-migration verification check_comments() wallet.unloadwallet() def test_migrate_simple_watch_only(self): self.log.info("Test migrating a wa...
Review this code and list any quality issues.
[ { "issue": "In e7fec273593d825e0e7dbec46a026aacc58c479f \"test: Migration fail recovery w/ `../` in path\"\r\n\r\nI think `failed_watchonly` is the wrong wallet name. Probably best to do `f\"{wallet_name}_watchonly\"`", "severity": "critical", "line": 26 } ]
1
python
import numpy as np import pandas as pd from typing import Text, Union import copy from ...utils import get_or_create_path from ...log import get_module_logger import torch import torch.nn as nn import torch.optim as optim from .pytorch_utils import count_parameters from ...model.base import Model from ...data.dataset...
Review this code and list any quality issues.
[ { "issue": "evaluation metric.\r\nThs comment applies to other modifications", "severity": "minor", "line": 26 } ]
1
python
mds.MDS( metric="cosine", dissimilarity="euclidean", init="random", n_init=1 ).fit(X) # TODO(1.9): remove warning filter @pytest.mark.filterwarnings("ignore::FutureWarning") def test_classical_mds_init_to_mds(): X, _ = load_iris(return_X_y=True) cmds = ClassicalMDS() Z_classical = cmd...
Review this code and list any quality issues.
[ { "issue": "Maybe rename `mds1` into `mds` and `Z1` into `Z`.", "severity": "minor", "line": 26 } ]
1
python
from crawlee._utils.docs import docs_group from crawlee.abstract_http_crawler._http_crawling_context import ParsedHttpCrawlingContext from crawlee.parsel_crawler._utils import html_to_text @dataclass(frozen=True) @docs_group('Data structures') class ParselCrawlingContext(ParsedHttpCrawlingContext[Selector]): """T...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n \"\"\"Convert the parsed HTML content to newline-separated plain text without tags.\"\"\"\r\n```", "severity": "minor", "line": 26 } ]
1
python
_TESTS = [{ 'url': 'https://player.fm/series/chapo-trap-house/movie-mindset-33-casino-feat-felix', 'info_dict': { 'id': 'movie-mindset-33-casino-feat-felix', 'thumbnail': r're:^https://.*\.(jpg|png)', 'title': 'Movie Mindset 33 - Casino feat. Felix', 'crea...
Review this code and list any quality issues.
[ { "issue": "This URL is dead? And can we use anything else for the `id`? This id is way too long", "severity": "major", "line": 26 } ]
1
python
@pytest.mark.parametrize("mock_bridge", [[DUMMY_HEATER_DEVICE]], indirect=True) async def test_set_auto_off_service_token_needed( hass: HomeAssistant, mock_bridge, mock_api ) -> None: """Test the set auto off service.""" await init_integration(hass, USERNAME, TOKEN) assert mock_bridge device = DUMM...
Review this code and list any quality issues.
[ { "issue": "This does not need to be in the patched context (reduce 1 ident)", "severity": "minor", "line": 26 } ]
1
python
Checksums ========= MD5 --- :: """)) f.writelines([f' {c}\n' for c in compute_hash(wheel_dir, md5)]) f.writelines(textwrap.dedent( """ SHA256 ------ :: """)) f.writeline...
Review this code and list any quality issues.
[ { "issue": "This could be simplified a bit with `subprocess.run` (available since Python 3.5), e.g. like\r\n\r\n```suggestion\r\n subprocess.run(\r\n [\"pandoc\", \"-s\", \"-o\", str(target_md), str(target_rst), \"--wrap=preserve\"],\r\n check=True,\r\n )\r\n```\r\n\r\nOr if you only want to...
1
python
expected_services = NODE_WITNESS | NODE_NETWORK_LIMITED if self.options.v2transport: expected_services |= NODE_P2P_V2 self.log.info("Check that node has signalled expected services.") assert_equal(node.nServices, expected_services) self.log.info("Check that the localservice...
Review this code and list any quality issues.
[ { "issue": "Here `sync_blocks()` is used and above `self.wait_until(lambda: node.getbestblockhash() == ...` is used to achieve the same purpose. For consistency maybe use only one of the methods.", "severity": "minor", "line": 26 } ]
1
python
sessions, data_portal, emission_rate="daily", benchmark_returns=None): self.benchmark_asset = benchmark_asset self.sessions = sessions self.emission_rate = emission_rate self.data_portal = data_portal if len(sessions) == 0: ...
Review this code and list any quality issues.
[ { "issue": "the comment just above this line needs updating now", "severity": "minor", "line": 26 } ]
1
python
live_status = 'is_live' else: live_status = None self.report_warning(f'unknown status: {data.get("status")}') start_time = rfc3339_to_atende(params['start']) # current streams have a stop time of *expected* end of session, but actual times # can change during the...
Review this code and list any quality issues.
[ { "issue": "You must have missed this when applying the suggestion\r\n```suggestion\r\n file = update_url_query(file, {'startTime': start_time})\r\n if stop_time is not None:\r\n file = update_url_query(file, {'stopTime': stop_time})\r\n```", "severity": "min...
1
python
'id': 'c64916eb-10fb-46a9-9a19-8c4b7ed064e7', 'ext': 'mp4', 'title': 'PAULINHO LOKO NA LOCO!', 'description': 'live on na loco', 'uploader_id': '2MDO7Z1DPM', 'channel': 'paulinholokobr', 'channel_follower_count': int, 'comment_count': i...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n stream = traverse_obj(self._search_nextjs_data(webpage, video_id), (\r\n 'props', 'pageProps', ('liveStreamData', 'stream'), {dict}, any, {require('stream info')}))\r\n```", "severity": "minor", "line": 26 } ]
1
python
else: assert offsets is not None assert hashes is not None lookup_request_id = self.stats_monitor.on_lookup_request(sum(offsets)) try: end = 0 prev_end = 0 if pin: assert lookup_id is not None, "lookup_id is required when ...
Review this code and list any quality issues.
[]
0
python
pipeline_specialized = Pipeline({ 'open': EquityPricing.open.latest, 'high': EquityPricing.high.latest, 'low': EquityPricing.low.latest, 'close': EquityPricing.close.latest, 'volume': EquityPricing.volume.latest, }, domain=US_EQUITIES) dataset_...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n EquityPricing.volume.fx('EUR')\r\n```\r\n\r\nWe don't need to construct a Pipeline around this for the error to trigger, so no reason to include that in the code under test.", "severity": "minor", "line": 26 } ]
1
python
hidden_data['history'] = 3 mvpd_confirm_page_res = self._download_webpage_handle( urlh.geturl(), video_id, 'Sending final bookend', query=hidden_data) post_form(mvpd_confirm_page_res, 'Confirming Login') elif mso_i...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n provider_login_redirect_page = self._download_webpage(\r\n urlh.geturl(), video_id, 'Sending First Bookend',\r\n query=hidden_data)\r\n\r\n provider_tryauth_url = self._html_search_regex(\r\n ...
1
python
window = self.data_portal.get_history_window( [cf], Timestamp('2016-04-06 18:01', tz='US/Eastern').tz_convert('UTC'), 30, '1d', 'sid') self.assertEqual(window.loc['2016-02-25', cf], 1, "Should be FOG16 at beginning of window....
Review this code and list any quality issues.
[]
0
python
#!/usr/bin/env python3 # Copyright (c) 2022 The Bitcoin Core developers # Distributed under the MIT software license, see the accompanying # file COPYING or http://www.opensource.org/licenses/mit-license.php. """Test initial headers download Test that we only try to initially sync headers from one peer (until our chai...
Review this code and list any quality issues.
[ { "issue": "Would be better to do 2022-Present", "severity": "minor", "line": 2 } ]
1
python
}, 'params': {'skip_download': 'm3u8'}, 'expected_warnings': ['Unable to download XML'] }] def _real_extract(self, url): lang, internal_id, display_id = self._match_valid_url(url).group('lang', 'internal_id', 'id') webpage = self._download_webpage(url, display_id) initia...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n f'{api_domain}/auth/v1/token', display_id,\r\n```\r\netc", "severity": "critical", "line": 26 } ]
1
python
class BuiltinFunctionPropertiesTest(unittest.TestCase): # XXX Not sure where this should really go since I can't find a # test module specifically for builtin_function_or_method. def test_builtin__module__(self): import decimal import math # builtin function: self.assertEqu...
Review this code and list any quality issues.
[ { "issue": "Note that for classmethods the ``__module__`` attribute is also empty. We could extend proposed solution to cover this case as well. But this looks as a less severe issue for me: the module value is available in this case via the ``__self__`` attribute.", "severity": "minor", "line": 26 ...
1
python
parser.write(chunk) parser.finalize() parser.close() if file_object is not None: if not file_object.closed: try: file_object.flush() except (AttributeError, ValueError, OSError): ...
Review this code and list any quality issues.
[ { "issue": "why should it be case independent?", "severity": "minor", "line": 26 } ]
1
python
MODEL_TENSOR.OUTPUT, MODEL_TENSOR.ROPE_FREQS, MODEL_TENSOR.ATTN_NORM, MODEL_TENSOR.ATTN_Q, MODEL_TENSOR.ATTN_K, MODEL_TENSOR.ATTN_V, MODEL_TENSOR.ATTN_OUT, MODEL_TENSOR.ATTN_ROT_EMBD, MODEL_TENSOR.FFN_NORM, MODEL_TENSOR.FFN_GATE, MODEL_TENS...
Review this code and list any quality issues.
[ { "issue": "You need to add it to deepseek too.", "severity": "minor", "line": 26 } ]
1
python
import sys import pytest from anyscale.job.models import JobState from ray_release.anyscale_util import Anyscale from ray_release.cluster_manager.cluster_manager import ClusterManager from ray_release.job_manager.anyscale_job_manager import AnyscaleJobManager from ray_release.test import Test class FakeJobStatus: ...
Review this code and list any quality issues.
[]
0