id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
b47acf2a161b2f3001bf50dfa740477db6d32327 | Analyze and fix the following issue in the Linux kernel code: [media] staging: Fix comments and some typos in staging/media/* | Problem Details:
linux-next:
I like to spend some time reading code, in doing so I have found some
typos in some of the comments.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig
index 7e5caa39ed3f..4f4b7d6281a7 100644
--- a/drivers/staging/media/Kconfig
+++ b/drivers/staging/media/Kconfig
@@ -6,7 +6,7 @@ menuconfig STAGING_MEDIA
don't have the "normal" Linux kernel quality level.
Most of them don't follo... |
abf9d005375d6c6160cc9c17e5dcac32e412c8dc | Analyze and fix the following issue in the Linux kernel code: [media] as102: add __packed attribute to structs defined inside packed structs | Problem Details:
This patch fixes a regression in kernel 3.3 due to this patch:
http://patchwork.linuxtv.org/patch/8332/
That patch changes "#pragma pack(1)" with "__packed" attributes, but it is not
complete. In fact, in the as102 driver there are a lot of structs/unions
defined inside other structs/unions.
When the... | ```diff
diff --git a/drivers/staging/media/as102/as102_fw.h b/drivers/staging/media/as102/as102_fw.h
index bd21f0554392..4bfc6849d95a 100644
--- a/drivers/staging/media/as102/as102_fw.h
+++ b/drivers/staging/media/as102/as102_fw.h
@@ -29,7 +29,7 @@ struct as10x_fw_pkt_t {
union {
unsigned char request[2];
unsig... |
266e8ae37daa04fb3d89759305659f4e0acbc126 | Analyze and fix the following issue in the Linux kernel code: [media] media, cx231xx: Fix double free on close | Problem Details:
In cx231xx_v4l2_close() there are two calls to
cx231xx_release_resources(dev) followed by kfree(dev). That is a
problem since cx231xx_release_resources() already kfree()'s its
argument, so we end up doing a double free.
Easily resolved by just removing the redundant kfree() calls after the
calls to cx... | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c b/drivers/media/video/cx231xx/cx231xx-cards.c
index 875a7ce94736..8ed460d692e0 100644
--- a/drivers/media/video/cx231xx/cx231xx-cards.c
+++ b/drivers/media/video/cx231xx/cx231xx-cards.c
@@ -861,7 +861,6 @@ void cx231xx_release_resources(struct cx231xx *de... |
f769c26085ee0945fba3ba0ea48781770a8c81e2 | Analyze and fix the following issue in the Linux kernel code: [media] Two small string fixes in v4l2-ctrls.c | Problem Details:
Fix one typo and use 'Microseconds' instead of 'useconds' in the pre-emphasis
descriptions.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c
index 88cb2c6e5d23..18015c0a8d31 100644
--- a/drivers/media/video/v4l2-ctrls.c
+++ b/drivers/media/video/v4l2-ctrls.c
@@ -245,8 +245,8 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
};
static const char * const tune_preempha... |
f074ff92b5b26f3a559fab1203c36e140ea8d067 | Analyze and fix the following issue in the Linux kernel code: [media] radio-sf16fmr2: fix session mismatches | Problem Details:
WARNING: drivers/media/radio/built-in.o(.data+0x284): Section mismatch in reference from the variable fmr2_driver to the function .init.text:fmr2_probe()
The variable fmr2_driver references
the function __init fmr2_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (... | ```diff
diff --git a/drivers/media/radio/radio-sf16fmr2.c b/drivers/media/radio/radio-sf16fmr2.c
index b18be64b2556..7c69214334bf 100644
--- a/drivers/media/radio/radio-sf16fmr2.c
+++ b/drivers/media/radio/radio-sf16fmr2.c
@@ -186,7 +186,7 @@ static int fmr2_tea_ext_init(struct snd_tea575x *tea)
return 0;
}
-stati... |
ce85852b90a214cf577fc1b4f49d99fd7e98784a | Analyze and fix the following issue in the Linux kernel code: CIFS: Fix a spurious error in cifs_push_posix_locks | Problem Details:
Signed-off-by: Pavel Shilovsky <piastry@etersoft.ru>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Steve French <stevef@smf-gateway.(none)> | ```diff
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 5e64748a2917..8e02dbd88ae1 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -960,9 +960,9 @@ cifs_push_posix_locks(struct cifsFileInfo *cfile)
INIT_LIST_HEAD(&locks_to_send);
/*
- * Allocating count locks is enough because no locks can be added to
- ... |
bc2b395c031430639e5ad5dcb2669cfcf1fa5fd2 | Analyze and fix the following issue in the Linux kernel code: [media] tea575x: fix HW seek | Problem Details:
Fix HW seek in TEA575x to work properly:
- a delay must be present after search start and before first register read
or the seek does weird things
- when the search stops, the new frequency is not available immediately, we
must wait until it appears in the register (fortunately, we can clear the
... | ```diff
diff --git a/sound/i2c/other/tea575x-tuner.c b/sound/i2c/other/tea575x-tuner.c
index b291bd86c4ca..a63faec5e7fd 100644
--- a/sound/i2c/other/tea575x-tuner.c
+++ b/sound/i2c/other/tea575x-tuner.c
@@ -89,7 +89,7 @@ static void snd_tea575x_write(struct snd_tea575x *tea, unsigned int val)
tea->ops->set_pins(tea,... |
d4ecc83b79cc290eadf1ffb33a589c3c72bbc295 | Analyze and fix the following issue in the Linux kernel code: [media] tea575x-tuner: update to latest V4L2 framework requirements | Problem Details:
The tea575x-tuner module has been updated to use the latest V4L2 framework
functionality. This also required changes in the drivers that rely on it.
The tea575x changes are:
- The drivers must provide a v4l2_device struct to the tea module.
- The radio_nr module parameter must be part of the actual r... | ```diff
diff --git a/drivers/media/radio/radio-sf16fmr2.c b/drivers/media/radio/radio-sf16fmr2.c
index 7ab9afadf29b..b18be64b2556 100644
--- a/drivers/media/radio/radio-sf16fmr2.c
+++ b/drivers/media/radio/radio-sf16fmr2.c
@@ -9,16 +9,23 @@
#include <linux/delay.h>
#include <linux/module.h> /* Modules */
#include... |
9f1dfccf6607822f556698f0940ead57e6e42d5f | Analyze and fix the following issue in the Linux kernel code: [media] Add missing slab.h to fix linux-next compile errors | Problem Details:
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/radio/radio-aimslab.c b/drivers/media/radio/radio-aimslab.c
index 862dfce1f2fd..98e0c8c20312 100644
--- a/drivers/media/radio/radio-aimslab.c
+++ b/drivers/media/radio/radio-aimslab.c
@@ -32,6 +32,7 @@
#include <linux/delay.h> /* msleep */
#include <linux/videodev2.h> /* kernel ra... |
91caad3195e3b622f2a878869aab40d094106d33 | Analyze and fix the following issue in the Linux kernel code: [media] stb0899: set FE_HAS_SIGNAL flag in read_status | Problem Details:
In stb0899_read_status the FE_HAS_SIGNAL flag was not set in case of a
successful carrier lock. This change fixes that.
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Acked-by: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de>
Cc: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Mauro Carvalho Ch... | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 38565beafe23..d38f555a1f15 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -1071,7 +1071,7 @@ static int stb0899_read_status(struct dvb_frontend *fe,... |
2b49fad59513b07f976c9711b99f93ae74d081c5 | Analyze and fix the following issue in the Linux kernel code: [media] tda10071: fix the delivery system | Problem Details:
Commit b2a29b578d9c21b2e5c88020f830d3c42115c51d sets accidentally
supported delivery systems as DVB-T/T2 whilst it should be
DVB-S/S2. Due to that frontend cannot be used at all.
Reported-by: Jiří Zelenka <klacek@bubakov.net>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Cc: stable@kernel.org
Signed-o... | ```diff
diff --git a/drivers/media/dvb/frontends/tda10071.c b/drivers/media/dvb/frontends/tda10071.c
index a99205026751..c21bc92d2811 100644
--- a/drivers/media/dvb/frontends/tda10071.c
+++ b/drivers/media/dvb/frontends/tda10071.c
@@ -1215,7 +1215,7 @@ error:
EXPORT_SYMBOL(tda10071_attach);
static struct dvb_fronte... |
273b72c8ce6b28df6b49423d775c3e59072c73c5 | Analyze and fix the following issue in the Linux kernel code: ASoC: pxa-ssp: atomically set stream active masks | Problem Details:
PXA's SSP engine fails to take its current channel phase into account
when enabling a stream while the engine is already running. This
results in randomly swapped left/right channels on either the record
or the playback side, depending on which one was enabled first.
The following patch fixes this by ... | ```diff
diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
index a16df0fa6eff..fd04ce139031 100644
--- a/sound/soc/pxa/pxa-ssp.c
+++ b/sound/soc/pxa/pxa-ssp.c
@@ -668,6 +668,38 @@ static int pxa_ssp_hw_params(struct snd_pcm_substream *substream,
return 0;
}
+static void pxa_ssp_set_running_bit(struct s... |
6c1173a61e63c32bd40cb1e6dd16343240a328eb | Analyze and fix the following issue in the Linux kernel code: MCE, AMD: Correct ucode patch buffer description | Problem Details:
This MC1 error signature is called differently now, fix it.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Reviewed-by: Andreas Herrmann <andreas.herrmann3@amd.com> | ```diff
diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index 0ee1c0a115a2..5626e17a6b91 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -88,7 +88,7 @@ static const char * const f15h_ic_mce_desc[] = {
"Parity error for IC probe tag valid bit",
"PFB non-cacheable bit parity error",
... |
11b0a31473edf74b70ab6f8fe857b61bff82d7cc | Analyze and fix the following issue in the Linux kernel code: amd64_edac: Fix K8 revD and later chip select sizes | Problem Details:
Fix DRAM chip select sizes calculation for K8, revisions D and E.
Reported-by: Niklas Söderlund <niklas.soderlund@ericsson.com
Link: http://lkml.kernel.org/r/1320849178-23340-1-git-send-email-niklas.soderlund@ericsson.com
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com> | ```diff
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index b9424dcde906..03807283aca4 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -1132,12 +1132,36 @@ static int k8_dbam_to_chip_select(struct amd64_pvt *pvt, u8 dct,
return ddr2_cs_size(cs_mode, dclr & WIDTH_128);
... |
943bc7e110f269f88dc92bbf249adbd384d35f1c | Analyze and fix the following issue in the Linux kernel code: x86: Fix section warnings | Problem Details:
Fix the following section warnings :
WARNING: vmlinux.o(.text+0x49dbc): Section mismatch in reference
from the function acpi_map_cpu2node() to the variable
.cpuinit.data:__apicid_to_node The function acpi_map_cpu2node()
references the variable __cpuinitdata __apicid_to_node. This is
often because acpi... | ```diff
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index ce664f33ea8e..406ed77216d0 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -593,7 +593,7 @@ void __init acpi_set_irq_model_ioapic(void)
#ifdef CONFIG_ACPI_HOTPLUG_CPU
#include <acpi/processor.h>
-stati... |
f92cae45263b25cdb4c4d24e297e07945d3bc01b | Analyze and fix the following issue in the Linux kernel code: amd64_edac: Fix missing csrows sysfs nodes | Problem Details:
While initializing the array of csrow attribute instances, a few csrows
were uninitialized. This happened because the module only performed a
check for DRAM base ctl register0's and not DRAM base ctl register1's
chip select enable bit. There could be systems with DIMMs populated
on only single memory c... | ```diff
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index c9eee6d33e9a..b9424dcde906 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2133,6 +2133,7 @@ static void read_mc_regs(struct amd64_pvt *pvt)
static u32 amd64_csrow_nr_pages(struct amd64_pvt *pvt, u8 dct, int csr... |
18dd2ece3cde14cfd42e95a89eb14016699a5f15 | Analyze and fix the following issue in the Linux kernel code: PM / Domains: Check domain status during hibernation restore of devices | Problem Details:
Power domains that were off before hibernation shouldn't be turned on
during device restore, so prevent that from happening.
This change fixes up commit 65533bbf63b4f37723fdfedc73d0653958973323
PM / Domains: Fix hibernation restore of devices, v2
that didn't include it by mistake.
Signed-off-by... | ```diff
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index b6ff6ecf519d..73ce9fbe9839 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1127,6 +1127,9 @@ static int pm_genpd_restore_noirq(struct device *dev)
}
}
+ if (genpd->suspend_power_off)
+ return 0;
+... |
581330ba7b219fec0587452bd72fe5635c30c4ae | Analyze and fix the following issue in the Linux kernel code: ixgbe: Whitespace cleanups | Problem Details:
This patch contains several fixes for formatting in regards to whitespace.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> | ```diff
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index eb58f13773ad..1d22c9f0e9fe 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -6233,7 +6233,7 @@ static void ixgbe_watchdog_link_is_up(s... |
6ca435078822d9728318dee49ba4f2ff8a2ead24 | Analyze and fix the following issue in the Linux kernel code: ixgbe: Two minor fixes for RSS and FDIR set queues functions | Problem Details:
This change fixes two minor issues. The first was the fact that we were
setting the return value to false twice in the set_rss_queues function.
The second is the fact that we should have been using "min_t(int," instead
of "min((int)" in set_fdir_queues.
Signed-off-by: Alexander Duyck <alexander.h.duyc... | ```diff
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 6259619ec7e7..eb58f13773ad 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -4332,8 +4332,6 @@ static inline bool ixgbe_set_rss_queues... |
f7f4786c7546534ca969cfa5eb753fa97e30c728 | Analyze and fix the following issue in the Linux kernel code: microblaze: trivial: Fix typo fault in timer.c | Problem Details:
Signed-off-by: Michal Simek <monstr@monstr.eu> | ```diff
diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
index 3cb0bf640135..78b82f30bdd5 100644
--- a/arch/microblaze/kernel/timer.c
+++ b/arch/microblaze/kernel/timer.c
@@ -79,7 +79,7 @@ static inline void microblaze_timer0_start_periodic(unsigned long load_val)
* !PWMA - disable pwm
... |
00708d421a22a0f82de2dbb91ca6213b3dcc5267 | Analyze and fix the following issue in the Linux kernel code: microblaze: Fix makefile to work with latest toolchain | Problem Details:
When building with latest binutils, vmlinux includes
some sections which need to be stripped out when building
the binary image.
Signed-off-by: Michal Simek <monstr@monstr.eu> | ```diff
diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile
index 0c796cf81586..34940c828def 100644
--- a/arch/microblaze/boot/Makefile
+++ b/arch/microblaze/boot/Makefile
@@ -8,7 +8,7 @@ obj-y += linked_dtb.o
targets := linux.bin linux.bin.gz simpleImage.%
-OBJCOPYFLAGS := -O binary
+OBJCOP... |
9bc974b927ad7f07206b8db9b36a29a146c1cfd1 | Analyze and fix the following issue in the Linux kernel code: microblaze: Fix typo in early_printk.c | Problem Details:
Correct spelling "remaping" to "remapping" in
arch/microblaze/kernel/early_printk.c
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Michal Simek <monstr@monstr.eu> | ```diff
diff --git a/arch/microblaze/kernel/early_printk.c b/arch/microblaze/kernel/early_printk.c
index 8356e47631c4..742c247792ce 100644
--- a/arch/microblaze/kernel/early_printk.c
+++ b/arch/microblaze/kernel/early_printk.c
@@ -171,7 +171,7 @@ void __init remap_early_printk(void)
{
if (!early_console_initialized ... |
d0962936bff659d20522555b517582a2715fd23f | Analyze and fix the following issue in the Linux kernel code: md: fix clearing of the 'changed' flags for the bad blocks list. | Problem Details:
In super_1_sync (the first hunk) we need to clear 'changed' before
checking read_seqretry(), otherwise we might race with other code
adding a bad block and so won't retry later.
In md_update_sb (the second hunk), in the case where there is no
metadata (neither persistent nor external), we treat any ba... | ```diff
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 26591cc8ee87..21a90efb13b7 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -1805,13 +1805,13 @@ retry:
| BB_LEN(internal_bb));
*bbp++ = cpu_to_le64(store_bb);
}
+ bb->changed = 0;
if (read_seqretry(&bb->lock, seq))
goto retry;... |
d6b42dcb995e6acd7cc276774e751ffc9f0ef4bf | Analyze and fix the following issue in the Linux kernel code: md/raid1,raid10: avoid deadlock during resync/recovery. | Problem Details:
If RAID1 or RAID10 is used under LVM or some other stacking
block device, it is possible to enter a deadlock during
resync or recovery.
This can happen if the upper level block device creates
two requests to the RAID1 or RAID10. The first request gets
processed, blocks recovery and queue requests for ... | ```diff
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index a0b225eb4ac4..118e0f69f224 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -737,9 +737,22 @@ static void wait_barrier(struct r1conf *conf)
spin_lock_irq(&conf->resync_lock);
if (conf->barrier) {
conf->nr_waiting++;
- wait_event_lock_... |
c744a65c1e2d59acc54333ce80a5b0702a98010b | Analyze and fix the following issue in the Linux kernel code: md: don't set md arrays to readonly on shutdown. | Problem Details:
It seems that with recent kernel, writeback can still be happening
while shutdown is happening, and consequently data can be written
after the md reboot notifier switches all arrays to read-only.
This causes a BUG.
So don't switch them to read-only - just mark them clean and
set 'safemode' to '2' whic... | ```diff
diff --git a/drivers/md/md.c b/drivers/md/md.c
index ce88755baf4a..115a6dd85837 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8157,30 +8157,23 @@ static int md_notify_reboot(struct notifier_block *this,
struct mddev *mddev;
int need_delay = 0;
- if ((code == SYS_DOWN) || (code == SYS_HALT) || (co... |
f15df57ded710bd018794a264b900975ce3599a0 | Analyze and fix the following issue in the Linux kernel code: hwmon: (jc42) Convert to use devm_kzalloc | Problem Details:
Marginally less code and eliminate the possibility of memory leaks.
Also replace new_client variable with client and introduce dev variable to make
the code a bit easier to read.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
index 877e1593655b..a002bdac470a 100644
--- a/drivers/hwmon/jc42.c
+++ b/drivers/hwmon/jc42.c
@@ -469,20 +469,19 @@ static const struct attribute_group jc42_group = {
};
/* Return 0 if detection is successful, -ENODEV otherwise */
-static int jc42_det... |
918ddef35f518407d6ed6e72faf6df75e49cee24 | Analyze and fix the following issue in the Linux kernel code: hwmon: (max16065) Convert to use devm_kzalloc | Problem Details:
Marginally less code and eliminate the possibility of memory leaks.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/max16065.c b/drivers/hwmon/max16065.c
index 51edae93baa2..822261be84dd 100644
--- a/drivers/hwmon/max16065.c
+++ b/drivers/hwmon/max16065.c
@@ -554,7 +554,7 @@ static int max16065_probe(struct i2c_client *client,
| I2C_FUNC_SMBUS_READ_WORD_DATA))
return -ENODEV;
- data ... |
b8a5a7cebded23eb311b8db73a11ed23b4135170 | Analyze and fix the following issue in the Linux kernel code: hwmon: (smm665) Convert to use devm_kzalloc | Problem Details:
Marginally less code and eliminate the possibility of memory leaks.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/smm665.c b/drivers/hwmon/smm665.c
index 5877078aaca5..cbc51fb30dba 100644
--- a/drivers/hwmon/smm665.c
+++ b/drivers/hwmon/smm665.c
@@ -584,10 +584,9 @@ static int smm665_probe(struct i2c_client *client,
if (i2c_smbus_read_byte_data(client, SMM665_ADOC_ENABLE) < 0)
return -ENODEV... |
36839287204f1c419907d3873f1e45062000e8a2 | Analyze and fix the following issue in the Linux kernel code: hwmon: (ltc4261) Convert to use devm_kzalloc | Problem Details:
Marginally less code and eliminate the possibility of memory leaks.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/ltc4261.c b/drivers/hwmon/ltc4261.c
index ab1bfbf2a3f0..069b7d34d8f9 100644
--- a/drivers/hwmon/ltc4261.c
+++ b/drivers/hwmon/ltc4261.c
@@ -235,11 +235,9 @@ static int ltc4261_probe(struct i2c_client *client,
return -ENODEV;
}
- data = kzalloc(sizeof(*data), GFP_KERNEL);
- if (... |
8b313ca7f1b98263ce22519b25a9c2a362eeb898 | Analyze and fix the following issue in the Linux kernel code: hwmon: (pmbus) Convert pmbus drivers to use devm_kzalloc | Problem Details:
Marginally less code and eliminate the possibility of memory leaks.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
index fe52c3cf87ba..f81cb4adaeba 100644
--- a/drivers/hwmon/pmbus/adm1275.c
+++ b/drivers/hwmon/pmbus/adm1275.c
@@ -229,7 +229,8 @@ static int adm1275_probe(struct i2c_client *client,
if (device_config < 0)
return device_config;
-... |
07404aab52f5106ec436692474cf8f40978f5dac | Analyze and fix the following issue in the Linux kernel code: hwmon: (lineage-pem) Convert to use devm_kzalloc | Problem Details:
Marginally less code and eliminate the possibility of memory leaks.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c
index 5b8c9aeed3d6..d264937c7f5e 100644
--- a/drivers/hwmon/lineage-pem.c
+++ b/drivers/hwmon/lineage-pem.c
@@ -448,7 +448,7 @@ static int pem_probe(struct i2c_client *client,
| I2C_FUNC_SMBUS_WRITE_BYTE))
return -ENODEV;
- da... |
f352df652ff37c434ed32bc5b7eb7ce430b73abc | Analyze and fix the following issue in the Linux kernel code: hwmon: (hwmon-vid) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: space required before the open parenthesis '('
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Not fixed (url):
WARNING: line over 80 characters
Not fixed (false positive):
ERROR: Macros with complex values s... | ```diff
diff --git a/drivers/hwmon/hwmon-vid.c b/drivers/hwmon/hwmon-vid.c
index 55f86c4deb44..9f26400713f0 100644
--- a/drivers/hwmon/hwmon-vid.c
+++ b/drivers/hwmon/hwmon-vid.c
@@ -83,18 +83,18 @@ int vid_from_reg(int val, u8 vrm)
{
int vid;
- switch(vrm) {
+ switch (vrm) {
- case 100: /* VRD 10.... |
7599d32b1332546a3c0af17ce925ce7a8e89bfa1 | Analyze and fix the following issue in the Linux kernel code: hwmon: (lm70) Fix: do not use assignment in if condition | Problem Details:
Fix checkpatch issue:
ERROR: do not use assignment in if condition
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
index 61c2ffbb9dd0..472f79521a96 100644
--- a/drivers/hwmon/lm70.c
+++ b/drivers/hwmon/lm70.c
@@ -158,11 +158,12 @@ static int __devinit lm70_probe(struct spi_device *spi)
spi_set_drvdata(spi, p_lm70);
- if ((status = device_create_file(&spi->dev, &... |
01d9def5bae959de5d420a2fc09fcc58106513fa | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83l786ng) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/w83l786ng.c b/drivers/hwmon/w83l786ng.c
index a6310b89dedc..5850b7706088 100644
--- a/drivers/hwmon/w83l786ng.c
+++ b/drivers/hwmon/w83l786ng.c
@@ -1,28 +1,28 @@
/*
- w83l786ng.c - Linux kernel driver for hardware monitoring
- Copyright (c) 2007 Kevin Lo <kevlo@kevlo.org>
-
- ... |
130067d7c62dea33f82fbba96ebb042f6fac9474 | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83l785ts) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/w83l785ts.c b/drivers/hwmon/w83l785ts.c
index bc071441a3fe..5f14e3897058 100644
--- a/drivers/hwmon/w83l785ts.c
+++ b/drivers/hwmon/w83l785ts.c
@@ -116,8 +116,7 @@ struct w83l785ts_data {
unsigned long last_updated; /* in jiffies */
/* registers values */
- s8 temp[2]; /* 0: inp... |
795013333b613ba79b7df57515c9afacac6f167d | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83781d) Fix: do not use assignment in if condition | Problem Details:
Fix checkpatch issue:
ERROR: do not use assignment in if condition
Replace repeated calls to device_create_file() with calls to sysfs_create_group.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/w83781d.c b/drivers/hwmon/w83781d.c
index cbed525a425f..b03d54a799e3 100644
--- a/drivers/hwmon/w83781d.c
+++ b/drivers/hwmon/w83781d.c
@@ -975,23 +975,58 @@ static const struct attribute_group w83781d_group = {
.attrs = w83781d_attributes,
};
-static struct attribute *w83781d_at... |
aff6e00ee142d04ffeb8d8dcd3b2c0b8f789c354 | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83781d) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/w83781d.c b/drivers/hwmon/w83781d.c
index e8a19005b7d2..cbed525a425f 100644
--- a/drivers/hwmon/w83781d.c
+++ b/drivers/hwmon/w83781d.c
@@ -1,37 +1,37 @@
/*
- w83781d.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (c) 1998 - 2001 Frodo Looi... |
2a52dd667d74a074ebb54d2eec84ca55a73834b9 | Analyze and fix the following issue in the Linux kernel code: hwmon: (smsc47b397) Fix multi-line comments | Problem Details:
Cc: Mark M Hoffman <mhoffman@lightlink.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/smsc47b397.c b/drivers/hwmon/smsc47b397.c
index 65c88ff5645a..d3b778da3f86 100644
--- a/drivers/hwmon/smsc47b397.c
+++ b/drivers/hwmon/smsc47b397.c
@@ -1,30 +1,30 @@
/*
- smsc47b397.c - Part of lm_sensors, Linux kernel modules
- for hardware monitoring
-
- Supports the SMSC L... |
36564efaddb7c1ace20f531860985a9848714c79 | Analyze and fix the following issue in the Linux kernel code: hwmon: (pc87427) Fix multi-line comments | Problem Details:
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org> | ```diff
diff --git a/drivers/hwmon/pc87427.c b/drivers/hwmon/pc87427.c
index cb35461d52d9..37059a3755e9 100644
--- a/drivers/hwmon/pc87427.c
+++ b/drivers/hwmon/pc87427.c
@@ -46,9 +46,11 @@ static struct platform_device *pdev;
#define DRVNAME "pc87427"
-/* The lock mutex protects both the I/O accesses (needed beca... |
b6707b78ff3172f03ee197b7e638cf6bc81d4407 | Analyze and fix the following issue in the Linux kernel code: hwmon: (max1668) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/max1668.c b/drivers/hwmon/max1668.c
index 12249f7bccf4..335b183d7c02 100644
--- a/drivers/hwmon/max1668.c
+++ b/drivers/hwmon/max1668.c
@@ -1,23 +1,23 @@
/*
- Copyright (c) 2011 David George <david.george@ska.ac.za>
-
- based on adm1021.c
- some credit to Christoph Scheurer,... |
1160631b10e48bd71500f947960efeea334e3247 | Analyze and fix the following issue in the Linux kernel code: hwmon: (lm80) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org> | ```diff
diff --git a/drivers/hwmon/lm80.c b/drivers/hwmon/lm80.c
index 6a2a777fe9cb..a996f2795db0 100644
--- a/drivers/hwmon/lm80.c
+++ b/drivers/hwmon/lm80.c
@@ -1,8 +1,8 @@
/*
* lm80.c - From lm_sensors, Linux kernel modules for hardware
- * monitoring
+ * monitoring
* Copyright (C) 1998, 1999 Frodo Looijaa... |
bf0f3a0430b7cc33fd65d21acfd41840cba76d48 | Analyze and fix the following issue in the Linux kernel code: hwmon: (emc2103) Fix multi-line comments | Problem Details:
Cc: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/emc2103.c b/drivers/hwmon/emc2103.c
index 0f51382df80a..9691f664c76e 100644
--- a/drivers/hwmon/emc2103.c
+++ b/drivers/hwmon/emc2103.c
@@ -1,21 +1,21 @@
/*
- emc2103.c - Support for SMSC EMC2103
- Copyright (c) 2010 SMSC
-
- This program is free software; you can redistribu... |
fbb6670d941fa018af2bebc729091a577899f1fb | Analyze and fix the following issue in the Linux kernel code: hwmon: (adm1031) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
index 71b5ec31fdc3..ff37363ea5bc 100644
--- a/drivers/hwmon/adm1031.c
+++ b/drivers/hwmon/adm1031.c
@@ -1,25 +1,25 @@
/*
- adm1031.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Based on lm75.c and lm85.c
- Supports ad... |
94b991d4c780b98bcf36451ab4839f35c19d5e32 | Analyze and fix the following issue in the Linux kernel code: hwmon: (adm1029) Fix multi-line comments | Problem Details:
Cc: Corentin Labbe <corentin.labbe@geomatys.fr>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
index c6531a8cf258..80cc465d8ac7 100644
--- a/drivers/hwmon/adm1029.c
+++ b/drivers/hwmon/adm1029.c
@@ -240,9 +240,9 @@ static ssize_t set_fan_div(struct device *dev,
}
/*
-Access rights on sysfs, S_IRUGO stand for Is Readable by User, Group and... |
27b9de3c4ae302c51d99187047e6ebebb21fd29b | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83627hf) Fix checkpatch issues | Problem Details:
Fixed:
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
ERROR: do not use assignment in if condition
Modify multi-line comments to follow Documentation/CodingStyle.
Other checkpatch issues not fixed to reduce number of conflicts with pe... | ```diff
diff --git a/drivers/hwmon/w83627hf.c b/drivers/hwmon/w83627hf.c
index ca4d378c7623..5ce54a297249 100644
--- a/drivers/hwmon/w83627hf.c
+++ b/drivers/hwmon/w83627hf.c
@@ -1,43 +1,43 @@
/*
- w83627hf.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (c) 1998... |
ca3ccad827175fa47f4b20ea4c7072e1ddc33128 | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83l786ng) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
WARNING: braces {} are not necessary for single statement blocks
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
W... | ```diff
diff --git a/drivers/hwmon/w83l786ng.c b/drivers/hwmon/w83l786ng.c
index deac4b625305..a6310b89dedc 100644
--- a/drivers/hwmon/w83l786ng.c
+++ b/drivers/hwmon/w83l786ng.c
@@ -52,7 +52,7 @@ MODULE_PARM_DESC(reset, "Set to 1 to reset chip, not recommended");
#define W83L786NG_REG_CONFIG 0x40
#define W83L786N... |
47efe8772f241c4be540355d90e38b79cc1092a4 | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83793) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
WARNING: braces {} are not necessary for any arm of this statement
WARNING: braces {} are not necessary for single statement blocks
WARNING: simple_strtol... | ```diff
diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
index 742bf1355f3d..834e49d1827b 100644
--- a/drivers/hwmon/w83793.c
+++ b/drivers/hwmon/w83793.c
@@ -1,34 +1,34 @@
/*
- w83793.c - Linux kernel driver for hardware monitoring
- Copyright (C) 2006 Winbond Electronics Corp.
- Yu... |
d17436813a07b217027eccfa9561e59f9d3f479a | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83792d) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space prohibited after that open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:WxV)
ERROR: spaces required around that ':' (ctx:VxE)
ER... | ```diff
diff --git a/drivers/hwmon/w83792d.c b/drivers/hwmon/w83792d.c
index a87c4bd2eccf..ffb5fdfecf0d 100644
--- a/drivers/hwmon/w83792d.c
+++ b/drivers/hwmon/w83792d.c
@@ -1,39 +1,39 @@
/*
- w83792d.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (C) 2004, 200... |
2185696d7d8a852146f6a901b35e9b94be43329a | Analyze and fix the following issue in the Linux kernel code: hwmon: (vt1211) Fix: do not use assignment in if condition | Problem Details:
Fix checkpatch issue:
ERROR: do not use assignment in if condition
Replace repeated calls to device_create_file() with calls to sysfs_create_group.
Cc: Juerg Haefliger <juergh@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/vt1211.c b/drivers/hwmon/vt1211.c
index 5de5f72a8202..c2c5c72fb8f0 100644
--- a/drivers/hwmon/vt1211.c
+++ b/drivers/hwmon/vt1211.c
@@ -909,112 +909,99 @@ static ssize_t show_alarms(struct device *dev,
* Device attribute structs
* --------------------------------------------------... |
b162c033480a7ba0433d329f56c142a0ab59049d | Analyze and fix the following issue in the Linux kernel code: hwmon: (vt1211) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
ERROR: switch and case should be at the same indent
ERROR: trailing statements should be on next line
WARNING: braces {} are not necessary for single statement blocks
WARNING: simple_strtol is obsolete, use kstrtol instead
Modify multi-line comments ... | ```diff
diff --git a/drivers/hwmon/vt1211.c b/drivers/hwmon/vt1211.c
index 49163d48e966..5de5f72a8202 100644
--- a/drivers/hwmon/vt1211.c
+++ b/drivers/hwmon/vt1211.c
@@ -151,8 +151,10 @@ struct vt1211_data {
#define ISTEMP(ix, uch_config) ((ix) < 2 ? 1 : \
((uch_config) >> (ix)) & 1)
-/* in5 (ix = 5) is speci... |
9004ac8134de260b2eb9a6d8fb2dd4a37321e49b | Analyze and fix the following issue in the Linux kernel code: hwmon: (via686a) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
ERROR: open brace '{' following function declarations go on the next line
ERROR: space prohibited before that close parenthesis ')'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required... | ```diff
diff --git a/drivers/hwmon/via686a.c b/drivers/hwmon/via686a.c
index 1424f0a1e498..288135d85e11 100644
--- a/drivers/hwmon/via686a.c
+++ b/drivers/hwmon/via686a.c
@@ -1,34 +1,35 @@
/*
- via686a.c - Part of lm_sensors, Linux kernel modules
- for hardware monitoring
-
- Copyright (c) 1998 - 2002 Frodo Lo... |
bce2778df9ea32146d59344c027001e270911f4b | Analyze and fix the following issue in the Linux kernel code: hwmon: (pc87360) Fix: do not use assignment in if condition | Problem Details:
Fix checkpatch issue:
ERROR: do not use assignment in if condition
Replace repeated calls to device_create_file() with calls to sysfs_create_group.
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
index 000499ea5973..79ba48c8c116 100644
--- a/drivers/hwmon/pc87360.c
+++ b/drivers/hwmon/pc87360.c
@@ -346,11 +346,13 @@ static struct sensor_device_attribute fan_min[] = {
SENSOR_ATTR(fan3_min, S_IWUSR | S_IRUGO, show_fan_min, set_fan_min, 2),
... |
8958dfb74a8b8673824d21efabaf565777c549fe | Analyze and fix the following issue in the Linux kernel code: hwmon: (max1619): Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
ERROR: trailing whitespace
WARNING: line over 80 characters
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/max1619.c b/drivers/hwmon/max1619.c
index 135822e05c4d..ecac04a7b7d6 100644
--- a/drivers/hwmon/max1619.c
+++ b/drivers/hwmon/max1619.c
@@ -125,7 +125,7 @@ struct max1619_data {
u8 temp_input2, temp_low2, temp_high2; /* remote */
u8 temp_crit2;
u8 temp_hyst2;
- u8 alarms;
+ u8 ... |
09770b261914166f326dcff5e43794a5f53e0f6a | Analyze and fix the following issue in the Linux kernel code: hwmon: (lm85) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Modify multi-line comments to follow Documentation/CodingStyle.
Also: s/#define^I/#de... | ```diff
diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c
index fd269831788f..864c7d999e0c 100644
--- a/drivers/hwmon/lm85.c
+++ b/drivers/hwmon/lm85.c
@@ -1,28 +1,28 @@
/*
- lm85.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (c) 1998, 1999 Frodo Looijaard... |
9b03079fca96a5815f197f02e09b9ac20d67b71e | Analyze and fix the following issue in the Linux kernel code: hwmon: (lm78) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space prohibited before that close parenthesis ')'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:Vx... | ```diff
diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
index 6df0b4681710..f6bc414e1e91 100644
--- a/drivers/hwmon/lm78.c
+++ b/drivers/hwmon/lm78.c
@@ -1,23 +1,23 @@
/*
- lm78.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (c) 1998, 1999 Frodo Looijaard... |
02fe2fd949daf7906dba4d7a795c5eed79bfc24f | Analyze and fix the following issue in the Linux kernel code: hwmon: (lm77) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: trailing whitespace
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrto... | ```diff
diff --git a/drivers/hwmon/lm77.c b/drivers/hwmon/lm77.c
index 7cd516f888cc..0fca8613e7d8 100644
--- a/drivers/hwmon/lm77.c
+++ b/drivers/hwmon/lm77.c
@@ -1,29 +1,29 @@
/*
- lm77.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
-
- Copyright (c) 2004 Andras BALI <drewie... |
f445a9af939a6989e356a25ca97ea691d98bc336 | Analyze and fix the following issue in the Linux kernel code: hwmon: (gl520sm) Fix: do not use assignment in if condition | Problem Details:
Fix checkpatch issue:
ERROR: do not use assignment in if condition
Replace repeated calls to device_create_file() with calls to sysfs_create_group.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/gl520sm.c b/drivers/hwmon/gl520sm.c
index 01a494935198..5ff452b6a4d0 100644
--- a/drivers/hwmon/gl520sm.c
+++ b/drivers/hwmon/gl520sm.c
@@ -720,13 +720,16 @@ static const struct attribute_group gl520_group = {
.attrs = gl520_attributes,
};
-static struct attribute *gl520_attribut... |
43da3d123a6ec556a2e1b69a3b9c7d33af965fa0 | Analyze and fix the following issue in the Linux kernel code: hwmon: (gl520sm) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR... | ```diff
diff --git a/drivers/hwmon/gl520sm.c b/drivers/hwmon/gl520sm.c
index e6dcf660e6ae..01a494935198 100644
--- a/drivers/hwmon/gl520sm.c
+++ b/drivers/hwmon/gl520sm.c
@@ -1,25 +1,25 @@
/*
- gl520sm.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (c) 1998, 199... |
228f8e0c60e96f16ae7739b62187622d566022a9 | Analyze and fix the following issue in the Linux kernel code: hwmon: (gl518sm) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxE)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxV)
ERROR: ... | ```diff
diff --git a/drivers/hwmon/gl518sm.c b/drivers/hwmon/gl518sm.c
index 89b8c0a4aca4..764a083ac7a7 100644
--- a/drivers/hwmon/gl518sm.c
+++ b/drivers/hwmon/gl518sm.c
@@ -83,11 +83,12 @@ enum chips { gl518sm_r00, gl518sm_r80 };
#define RAW_FROM_REG(val) val
-#define BOOL_FROM_REG(val) ((val)?0:1)
-#define BOOL... |
8c103696fa59e1b810bf24a63304acd5ab585c12 | Analyze and fix the following issue in the Linux kernel code: hwmon: (asb100): Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space prohibited after that open parenthesis '('
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
WARNING: please, no spaces at the start of a l... | ```diff
diff --git a/drivers/hwmon/asb100.c b/drivers/hwmon/asb100.c
index 0f300c6b7f98..4b8814deabb1 100644
--- a/drivers/hwmon/asb100.c
+++ b/drivers/hwmon/asb100.c
@@ -1,40 +1,40 @@
/*
- asb100.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
-
- Copyright (C) 2004 Mark M. Hoffma... |
c387e4eb245bf55695f96817d15fe90c3bc99e6b | Analyze and fix the following issue in the Linux kernel code: hwmon: (adm9240) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
ERROR: that open brace { should be on the previous line
WARNING: please, no space before tabs
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Modify multi-line comments to follow Docum... | ```diff
diff --git a/drivers/hwmon/adm9240.c b/drivers/hwmon/adm9240.c
index 64e7ef885411..c3c2865a8967 100644
--- a/drivers/hwmon/adm9240.c
+++ b/drivers/hwmon/adm9240.c
@@ -1,12 +1,12 @@
/*
* adm9240.c Part of lm_sensors, Linux kernel modules for hardware
- * monitoring
+ * monitoring
*
* Copyright (C) 1999... |
21d2a8f17b7533d84acf659d4a3757115fad0356 | Analyze and fix the following issue in the Linux kernel code: hwmon: (adm1021) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: space prohibited between function name and open parenthesis '('
Modify multi-line comments to follow Documentation/CodingStyle.
Cc: Michael Abbott <michael.abbott@diamond.ac.uk>
Signed... | ```diff
diff --git a/drivers/hwmon/adm1021.c b/drivers/hwmon/adm1021.c
index bce543907222..4394e7e99c46 100644
--- a/drivers/hwmon/adm1021.c
+++ b/drivers/hwmon/adm1021.c
@@ -1,23 +1,23 @@
/*
- adm1021.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (c) 1998, 1999 Frodo Looij... |
8969e84d954af3f7142cb5e6fd870466aaf59932 | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83627ehf) Fix multi-line comments | Problem Details:
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index a658d62c5e10..ec595c606ed4 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -1,50 +1,49 @@
/*
- w83627ehf - Driver for the hardware monitoring functionality of
- the Winbond W83627EHF Super-I/O chip
- Copyr... |
51683ee83e5a737da218bcfa064993b6cd05b946 | Analyze and fix the following issue in the Linux kernel code: hwmon: (max1111) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/max1111.c b/drivers/hwmon/max1111.c
index e5206ae00d76..362a40eb6129 100644
--- a/drivers/hwmon/max1111.c
+++ b/drivers/hwmon/max1111.c
@@ -106,7 +106,8 @@ static ssize_t show_adc(struct device *dev,
if (ret < 0)
return ret;
- /* assume the reference voltage to be 2.048V, with ... |
1b05d22f2c8de166dd4ac14fe05c5c740db825e8 | Analyze and fix the following issue in the Linux kernel code: hwmon: (ltc4151) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Cc: Per Dalen <per.dalen@appeartv.com> | ```diff
diff --git a/drivers/hwmon/ltc4151.c b/drivers/hwmon/ltc4151.c
index f646b4570c93..4d005b219de2 100644
--- a/drivers/hwmon/ltc4151.c
+++ b/drivers/hwmon/ltc4151.c
@@ -154,7 +154,8 @@ static SENSOR_DEVICE_ATTR(in2_input, S_IRUGO, \
static SENSOR_DEVICE_ATTR(curr1_input, S_IRUGO, \
ltc4151_show_value, NULL, LT... |
1b9c491df8ac0e3b0ba01d9e9e786a1def79878d | Analyze and fix the following issue in the Linux kernel code: hwmon: (g760a) Fix multi-line comments | Problem Details:
Cc: Herbert Valerio Riedel <hvr@gnu.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/g760a.c b/drivers/hwmon/g760a.c
index 052e30484505..ebcd2698e4dc 100644
--- a/drivers/hwmon/g760a.c
+++ b/drivers/hwmon/g760a.c
@@ -1,17 +1,17 @@
/*
- g760a - Driver for the Global Mixed-mode Technology Inc. G760A
- fan speed PWM controller chip
-
- Copyright (C) 2007 Herb... |
20eaf7247ed9ea15c0e117cf58206f3b64219382 | Analyze and fix the following issue in the Linux kernel code: hwmon: (f71882fg) Fix multi-line comments | Problem Details:
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
index f8a9c9a86a44..6d1226365e30 100644
--- a/drivers/hwmon/f71882fg.c
+++ b/drivers/hwmon/f71882fg.c
@@ -252,9 +252,11 @@ struct f71882fg_data {
u16 fan_full_speed[4];
u8 fan_status;
u8 fan_beep;
- /* Note: all models have max 3 temperature... |
4bebced84fb66e8f4c061c5579264b112c39fdec | Analyze and fix the following issue in the Linux kernel code: hwmon: (emc1403) Fix multi-line comments | Problem Details:
Cc: Kalhan Trisal <kalhan.trisal@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
index 99ac141bf3d7..149dcb0e148f 100644
--- a/drivers/hwmon/emc1403.c
+++ b/drivers/hwmon/emc1403.c
@@ -41,8 +41,10 @@
struct thermal_data {
struct device *hwmon_dev;
struct mutex mutex;
- /* Cache the hyst value so we don't keep re-reading it.... |
ca3c7b63423c7f723258797bcb5b11652d32500b | Analyze and fix the following issue in the Linux kernel code: hwmon: (amc6821) Fix multi-line comments | Problem Details:
Cc: T. Mertelj <tomaz.mertelj@guest.arnes.si>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
index 5298855d4c43..f600fa1f92e3 100644
--- a/drivers/hwmon/amc6821.c
+++ b/drivers/hwmon/amc6821.c
@@ -1,25 +1,25 @@
/*
- amc6821.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (C) 2009 T. Mertelj <tomaz.mertelj... |
10775d18995f50def96c7affea5eb3ca293485d6 | Analyze and fix the following issue in the Linux kernel code: hwmon: (ads7871) Fix multi-line comments | Problem Details:
Cc: Paul Thomas <pthomas8589@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
index 11a5f5f69071..e65c6e45d36b 100644
--- a/drivers/hwmon/ads7871.c
+++ b/drivers/hwmon/ads7871.c
@@ -34,9 +34,11 @@
#define REG_SER_CONTROL 24 /*Serial Interface Control Register*/
#define REG_ID 31 /*ID Register*/
-/*From figure 17 in the d... |
d13d6232de932f11554119bb0c756798f5039ecd | Analyze and fix the following issue in the Linux kernel code: hwmon: (ads7828) Fix multi-line comments | Problem Details:
Cc: Steve Hardy <shardy@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/ads7828.c b/drivers/hwmon/ads7828.c
index ed60242d6a0a..bf3fdf495595 100644
--- a/drivers/hwmon/ads7828.c
+++ b/drivers/hwmon/ads7828.c
@@ -1,27 +1,27 @@
/*
- ads7828.c - lm_sensors driver for ads7828 12-bit 8-channel ADC
- (C) 2007 EADS Astrium
-
- This driver is based on the lm75 a... |
562fca2f7a6e682455de3f51accfc15f6091cc14 | Analyze and fix the following issue in the Linux kernel code: hwmon: (abituguru3) Fix multi-line comments | Problem Details:
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Alistair John Strachan <alistair@devzero.co.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/abituguru3.c b/drivers/hwmon/abituguru3.c
index 93ab1a5001c7..a5bc4287daa6 100644
--- a/drivers/hwmon/abituguru3.c
+++ b/drivers/hwmon/abituguru3.c
@@ -1,28 +1,28 @@
/*
- abituguru3.c
-
- Copyright (c) 2006-2008 Hans de Goede <hdegoede@redhat.com>
- Copyright (c) 2008 Alista... |
ec1c3194179579df41be78551a0ca642f49e52ff | Analyze and fix the following issue in the Linux kernel code: hwmon: (w83791d) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space prohibited after that open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)
WARNING: braces {} are not necessary for single statement blocks
WARNING: simple_strtol is obsolet... | ```diff
diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
index 1ff97b0e867a..2f446f92acf2 100644
--- a/drivers/hwmon/w83791d.c
+++ b/drivers/hwmon/w83791d.c
@@ -1,36 +1,36 @@
/*
- w83791d.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
-
- Copyright (C) 2006-20... |
a80b10ccac53087a6ad47f45e29a3800e84448fa | Analyze and fix the following issue in the Linux kernel code: hwmon: (ultra45_env) Fix checkpatch issues | Problem Details:
Fixed:
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
Modify multi-line comments to follow Documentation/CodingStyle.
Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop
Cc: David S. Miller <davem@daveml... | ```diff
diff --git a/drivers/hwmon/ultra45_env.c b/drivers/hwmon/ultra45_env.c
index b9a87e89bab4..c315c59f61fe 100644
--- a/drivers/hwmon/ultra45_env.c
+++ b/drivers/hwmon/ultra45_env.c
@@ -1,4 +1,5 @@
-/* ultra45_env.c: Driver for Ultra45 PIC16F747 environmental monitor.
+/*
+ * ultra45_env.c: Driver for Ultra45 PIC1... |
4d387df74e175659ad9c8a16ae8e5b364b7d3f56 | Analyze and fix the following issue in the Linux kernel code: hwmon: (thmc50) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Modify multi-line comments to follow Documentation/CodingStyle.
Not fixed (false posi... | ```diff
diff --git a/drivers/hwmon/thmc50.c b/drivers/hwmon/thmc50.c
index bd83bc0cd8cd..add9f019b24f 100644
--- a/drivers/hwmon/thmc50.c
+++ b/drivers/hwmon/thmc50.c
@@ -1,24 +1,24 @@
/*
- thmc50.c - Part of lm_sensors, Linux kernel modules for hardware
- monitoring
- Copyright (C) 2007 Krzysztof He... |
85a0c0d1a17cd83f4c2cec09c3ae69ed210f23b2 | Analyze and fix the following issue in the Linux kernel code: hwmon: (smsc47m1) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<=' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '>=' (ctx:VxV)
ERRO... | ```diff
diff --git a/drivers/hwmon/smsc47m1.c b/drivers/hwmon/smsc47m1.c
index aba11e56e8e7..c590c1469793 100644
--- a/drivers/hwmon/smsc47m1.c
+++ b/drivers/hwmon/smsc47m1.c
@@ -1,30 +1,30 @@
/*
- smsc47m1.c - Part of lm_sensors, Linux kernel modules
- for hardware monitoring
-
- Supports the SM... |
7e612685a3a3f0c1159f4562421e91a6c55d024e | Analyze and fix the following issue in the Linux kernel code: hwmon: (smsc47m1) Fix: do not use assignment in if condition | Problem Details:
Fix checkpatch issue:
ERROR: do not use assignment in if condition
Replace repeated calls to device_create_file() with calls to sysfs_create_group.
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/smsc47m1.c b/drivers/hwmon/smsc47m1.c
index f44a89aac381..aba11e56e8e7 100644
--- a/drivers/hwmon/smsc47m1.c
+++ b/drivers/hwmon/smsc47m1.c
@@ -380,30 +380,73 @@ static ssize_t show_name(struct device *dev, struct device_attribute
}
static DEVICE_ATTR(name, S_IRUGO, show_name, NULL)... |
7cc3cb6662a21a59a2e0e752a8ebd95137c71d3a | Analyze and fix the following issue in the Linux kernel code: hwmon: (smsc47m192) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '>' (ctx:VxV)
NOTE... | ```diff
diff --git a/drivers/hwmon/smsc47m192.c b/drivers/hwmon/smsc47m192.c
index 8f88908cf78a..4705a8bf11c2 100644
--- a/drivers/hwmon/smsc47m192.c
+++ b/drivers/hwmon/smsc47m192.c
@@ -1,25 +1,25 @@
/*
- smsc47m192.c - Support for hardware monitoring block of
- SMSC LPC47M192 and compatible Supe... |
8fda79ec8654afa98fb9bad04d1e08df853fe05e | Analyze and fix the following issue in the Linux kernel code: hwmon: (sis5595) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (... | ```diff
diff --git a/drivers/hwmon/sis5595.c b/drivers/hwmon/sis5595.c
index 33242456e2d2..6c4d8eb9b7ca 100644
--- a/drivers/hwmon/sis5595.c
+++ b/drivers/hwmon/sis5595.c
@@ -1,54 +1,54 @@
/*
- sis5595.c - Part of lm_sensors, Linux kernel modules
- for hardware monitoring
-
- Copyright (C) 1998 - 2001 Frodo Loo... |
57256088e1e0f26bb8abf677c9622de4841a89ac | Analyze and fix the following issue in the Linux kernel code: hwmon: (pcf8591) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
ERROR: spaces required around that ':' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxV)
WARNING: line over 80 characters
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Modify multi-line comments to follow Documentation/CodingStyl... | ```diff
diff --git a/drivers/hwmon/pcf8591.c b/drivers/hwmon/pcf8591.c
index 2041155a9fa3..4174c7463d70 100644
--- a/drivers/hwmon/pcf8591.c
+++ b/drivers/hwmon/pcf8591.c
@@ -1,22 +1,22 @@
/*
- Copyright (C) 2001-2004 Aurelien Jarno <aurelien@aurel32.net>
- Ported to Linux 2.6 by Aurelien Jarno <aurelien@aurel32... |
a318afd890ea4cf1e35543ad100704173edb4406 | Analyze and fix the following issue in the Linux kernel code: hwmon: (lm92) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '*=' (ctx:VxV)
ERROR: trailing whitespace
WARNING: line over 80 char... | ```diff
diff --git a/drivers/hwmon/lm92.c b/drivers/hwmon/lm92.c
index 92f2d4684a3c..fdc691a4028f 100644
--- a/drivers/hwmon/lm92.c
+++ b/drivers/hwmon/lm92.c
@@ -49,8 +49,10 @@
#include <linux/err.h>
#include <linux/mutex.h>
-/* The LM92 and MAX6635 have 2 two-state pins for address selection,
- resulting in 4 p... |
073f1e6c895f256b1d7b535a97fe0ced98ac1615 | Analyze and fix the following issue in the Linux kernel code: hwmon: (lm87) Fix: do not use assignment in if condition | Problem Details:
Fix checkpatch issue:
ERROR: do not use assignment in if condition
Replace repeated calls to device_create_file() with calls to sysfs_create_group.
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org> | ```diff
diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c
index 0216592a794b..e35f9af03b6a 100644
--- a/drivers/hwmon/lm87.c
+++ b/drivers/hwmon/lm87.c
@@ -700,34 +700,69 @@ static const struct attribute_group lm87_group = {
.attrs = lm87_attributes,
};
-static struct attribute *lm87_attributes_opt[] = {
+s... |
c6370dbe45278db0ebebc377c0a6143b7c488379 | Analyze and fix the following issue in the Linux kernel code: hwmon: (lm87) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: do not use assignment in if condition
ERROR: space required after that close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: trailing statements should be on next line
WARNING: line over 80 characters
WARNING: simple_strtol ... | ```diff
diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c
index 126d0cc42090..0216592a794b 100644
--- a/drivers/hwmon/lm87.c
+++ b/drivers/hwmon/lm87.c
@@ -119,20 +119,21 @@ static u8 LM87_REG_TEMP_LOW[3] = { 0x3A, 0x38, 0x2C };
* The LM87 uses signed 8-bit values for temperatures.
*/
-#define IN_FROM_REG(... |
525ad3731949fd9049254eabde57012d7cc06dbc | Analyze and fix the following issue in the Linux kernel code: hwmon: (fschmd) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: that open brace { should be on the previous line
ERROR: trailing statements should be on next line
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Modify multi-line comments to follow Docum... | ```diff
diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c
index 73ba942609c2..8305d29459bd 100644
--- a/drivers/hwmon/fschmd.c
+++ b/drivers/hwmon/fschmd.c
@@ -1,4 +1,5 @@
-/* fschmd.c
+/*
+ * fschmd.c
*
* Copyright (C) 2007 - 2009 Hans de Goede <hdegoede@redhat.com>
*
@@ -76,12 +77,12 @@ enum chips { ... |
f24d548bf2c4da3fd2cc4d0ffec108216b705850 | Analyze and fix the following issue in the Linux kernel code: hwmon: (atxp1) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: else should follow close brace '}'
ERROR: "foo * bar" should be "foo *bar"
WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
WARNING: please, no s... | ```diff
diff --git a/drivers/hwmon/atxp1.c b/drivers/hwmon/atxp1.c
index e69036a51253..58af6aa93530 100644
--- a/drivers/hwmon/atxp1.c
+++ b/drivers/hwmon/atxp1.c
@@ -1,22 +1,22 @@
/*
- atxp1.c - kernel module for setting CPU VID and general purpose
- I/Os using the Attansic ATXP1 chip.
-
- T... |
724cc3316e6e1060f727958b4c327001c0bbd62c | Analyze and fix the following issue in the Linux kernel code: hwmon: (adt7462) Fix checkpatch issues | Problem Details:
Fixed:
ERROR: that open brace { should be on the previous line
WARNING: please, no space before tabs
Cc: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c
index fede95f65e90..339269f76e57 100644
--- a/drivers/hwmon/adt7462.c
+++ b/drivers/hwmon/adt7462.c
@@ -65,8 +65,8 @@ static const unsigned short normal_i2c[] = { 0x58, 0x5C, I2C_CLIENT_END };
#define ADT7462_REG_PWM_TEMP_MIN_MAX_ADDR 0x5F
#define... |
790fa38c125a39f4b31dc83aa4a74e68ec7704e4 | Analyze and fix the following issue in the Linux kernel code: hwmon: (ltc4215) Fix multi-line comments | Problem Details:
Cc: Ira W. Snyder <iws@ovro.caltech.edu>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Ira W. Snyder <iws@ovro.caltech.edu> | ```diff
diff --git a/drivers/hwmon/ltc4215.c b/drivers/hwmon/ltc4215.c
index 0789b635ba86..429c5b2b66fd 100644
--- a/drivers/hwmon/ltc4215.c
+++ b/drivers/hwmon/ltc4215.c
@@ -91,8 +91,10 @@ static int ltc4215_get_voltage(struct device *dev, u8 reg)
voltage = regval * 605 / 10;
break;
case LTC4215_ADIN:
- /* Th... |
430b4fcd82eb3e71254c1ea13998524301489f2f | Analyze and fix the following issue in the Linux kernel code: hwmon: (ltc4245) Fix multi-line comments | Problem Details:
Cc: Ira W. Snyder <iws@ovro.caltech.edu>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Ira W. Snyder <iws@ovro.caltech.edu> | ```diff
diff --git a/drivers/hwmon/ltc4245.c b/drivers/hwmon/ltc4245.c
index 693a6bd4e5de..b99b45bafdad 100644
--- a/drivers/hwmon/ltc4245.c
+++ b/drivers/hwmon/ltc4245.c
@@ -214,7 +214,8 @@ static unsigned int ltc4245_get_current(struct device *dev, u8 reg)
unsigned int voltage;
unsigned int curr;
- /* The stran... |
85ebfd3ef9a52abe6426cc5e96604f2dd0e9b375 | Analyze and fix the following issue in the Linux kernel code: hwmon: (applesmc) Fix multi-line comments | Problem Details:
Cc: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Henrik Rydberg <rydberg@euromail.se> | ```diff
diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
index b9895531240d..1b130852e3e1 100644
--- a/drivers/hwmon/applesmc.c
+++ b/drivers/hwmon/applesmc.c
@@ -1189,8 +1189,10 @@ static int applesmc_dmi_match(const struct dmi_system_id *id)
return 1;
}
-/* Note that DMI_MATCH(...,"MacBook") will... |
75bdc936ea4c228fe248d47120d67f7a22a1adc5 | Analyze and fix the following issue in the Linux kernel code: hwmon: (asus_atk0110) Fix multi-line comments | Problem Details:
Cc: Luca Tettamanti <kronos.it@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Luca Tettamanti <kronos.it@gmail.com> | ```diff
diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
index 4000fee9d989..351d1f4593e7 100644
--- a/drivers/hwmon/asus_atk0110.c
+++ b/drivers/hwmon/asus_atk0110.c
@@ -38,7 +38,8 @@ static const struct dmi_system_id __initconst atk_force_new_if[] = {
{ }
};
-/* Minimum time between readi... |
8deeac82b3f3e73f50ca7109ea0029764b33874f | Analyze and fix the following issue in the Linux kernel code: hwmon: (ad7414) Fix multi-line comments | Problem Details:
Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Stefan Roese <sr@denx.de> | ```diff
diff --git a/drivers/hwmon/ad7414.c b/drivers/hwmon/ad7414.c
index 36465006c4fb..06d2d60d1fd0 100644
--- a/drivers/hwmon/ad7414.c
+++ b/drivers/hwmon/ad7414.c
@@ -50,7 +50,8 @@ struct ad7414_data {
/* REG: (0.25C/bit, two's complement) << 6 */
static inline int ad7414_temp_from_reg(s16 reg)
{
- /* use intege... |
5d577dba0443634f11fec0547b6cbca5ac0b0e57 | Analyze and fix the following issue in the Linux kernel code: hwmon: (jc42) Fix multi-line comments | Problem Details:
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
index 102e3ae397cc..877e1593655b 100644
--- a/drivers/hwmon/jc42.c
+++ b/drivers/hwmon/jc42.c
@@ -350,8 +350,10 @@ set(temp_min, JC42_REG_TEMP_LOWER);
set(temp_max, JC42_REG_TEMP_UPPER);
set(temp_crit, JC42_REG_TEMP_CRITICAL);
-/* JC42.4 compliant chi... |
780affe0e9162bd6aec8acdb6255d61e4b04abba | Analyze and fix the following issue in the Linux kernel code: hwmon: (coretemp) Fix checkpatch error | Problem Details:
Fix:
ERROR: Macros with complex values should be enclosed in parenthesis
Cc: Fenghua Yu <fenghua.yu@intel.com>
Acked-By: Durgadoss R <durgadoss.r@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index a6c6ec36615e..30e30e8e7e73 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -57,8 +57,8 @@ MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
#define TOTAL_ATTRS (MAX_CORE_ATTRS + 1)
#define MAX_CORE_DATA (... |
3af2861e8b80676d32c5498f9ac1b2de70d3e19b | Analyze and fix the following issue in the Linux kernel code: hwmon: (pc87360) Fix multi-line comments | Problem Details:
Cc: Jim Cromie <jim.cromie@gmail.com>
Acked-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
index 3d99b8854d7c..b54637efc879 100644
--- a/drivers/hwmon/pc87360.c
+++ b/drivers/hwmon/pc87360.c
@@ -498,9 +498,11 @@ static struct sensor_device_attribute in_max[] = {
#define CHAN_ALM_MAX 0x04 /* max limit exceeded */
#define TEMP_ALM_CRIT 0x... |
07de3dfb15793c3e406bfb04da7c4b64ecdf3022 | Analyze and fix the following issue in the Linux kernel code: hwmon: (wm831x-hwmon) Fix multi-line comments | Problem Details:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/wm831x-hwmon.c b/drivers/hwmon/wm831x-hwmon.c
index 23b44de76740..07cb25ae69be 100644
--- a/drivers/hwmon/wm831x-hwmon.c
+++ b/drivers/hwmon/wm831x-hwmon.c
@@ -117,8 +117,10 @@ static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_chip_temp, NULL,
WM831X_AUX_CHIP_TEMP);
static S... |
3c22e2326015e79822837aaa44eaf15249f8af7b | Analyze and fix the following issue in the Linux kernel code: hwmon: (smm665) Fix checkpatch error | Problem Details:
Fix:
ERROR: Macros with complex values should be enclosed in parenthesis
Also updated multi-line comments to follow Documentation/CodingStyle.
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/smm665.c b/drivers/hwmon/smm665.c
index 24382c735e56..5877078aaca5 100644
--- a/drivers/hwmon/smm665.c
+++ b/drivers/hwmon/smm665.c
@@ -124,9 +124,9 @@ enum chips { smm465, smm665, smm665c, smm764, smm766 };
#define SMM665_AIN_ADC_TO_VOLTS(adc) ((adc) * vref / 512)
/* Temp Senso... |
3c56b066fb62e4aee95e4b3acff35296765a25d1 | Analyze and fix the following issue in the Linux kernel code: hwmon: (asc7621) Fix multi-line comments | Problem Details:
Cc: George Joseph <george.joseph@fairview5.com>
Acked-by: George Joseph <george.joseph@fairview5.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/asc7621.c b/drivers/hwmon/asc7621.c
index 3efd32449982..7caa242915a6 100644
--- a/drivers/hwmon/asc7621.c
+++ b/drivers/hwmon/asc7621.c
@@ -268,9 +268,11 @@ static ssize_t store_fan16(struct device *dev,
if (kstrtol(buf, 10, &reqval))
return -EINVAL;
- /* If a minimum RPM of ze... |
4a0d71cfdc30b645714ee5672f39c35c67e8e2a2 | Analyze and fix the following issue in the Linux kernel code: hwmon: (it87) Fix multi-line comments | Problem Details:
Fix multi-line comments, and clean up some of the affected comments.
Cc: Jean Delvare <khali@linux-fr.org>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 0054d6f9cec9..93a197bd315a 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -176,12 +176,16 @@ static bool fix_pwm_polarity;
#define IT87_REG_ALARM2 0x02
#define IT87_REG_ALARM3 0x03
-/* The IT8718F and IT8720F have ... |
86d566e58edc578f12fe070e1671944889e4d391 | Analyze and fix the following issue in the Linux kernel code: hwmon: (hwmon-vid) Fix multi-line comments | Problem Details:
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/hwmon-vid.c b/drivers/hwmon/hwmon-vid.c
index 4fcb867122ec..4029ac618d71 100644
--- a/drivers/hwmon/hwmon-vid.c
+++ b/drivers/hwmon/hwmon-vid.c
@@ -40,7 +40,7 @@
* available at http://developer.intel.com/.
*
* AMD Athlon 64 and AMD Opteron Processors, AMD Publication 26094,
- * ... |
5ed04880a3399a0bb0bb5eb886316b8a722b1a7b | Analyze and fix the following issue in the Linux kernel code: hwmon: (hwmon) Fix multi-line comments | Problem Details:
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ```diff
diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
index b58a0ffbd3bd..c3c471ca202f 100644
--- a/drivers/hwmon/hwmon.c
+++ b/drivers/hwmon/hwmon.c
@@ -1,14 +1,14 @@
/*
- hwmon.c - part of lm_sensors, Linux kernel modules for hardware monitoring
-
- This file defines the sysfs class "hwmon", for u... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.