id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
462a185c5cea7063348003c1644b70a6f6780f01 | Analyze and fix the following issue in the Linux kernel code: regmap: Do not call regcache_exit from regcache_rbtree_init error path | Problem Details:
Calling regcache_exit from regcache_rbtree_init is first of all a layering
violation and secondly will cause double frees. regcache_exit will free buffers
allocated by the core, but the core will also free the same buffers when the
cacheops init callback returns an error. Thus we end up with a double f... | ```diff
diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c
index e31498499b0f..e71320f61d18 100644
--- a/drivers/base/regmap/regcache-rbtree.c
+++ b/drivers/base/regmap/regcache-rbtree.c
@@ -17,6 +17,7 @@
static int regcache_rbtree_write(struct regmap *map, unsigned int reg,
... |
7b08fae8fbf0c14f003be8e039ed37bcbae4415a | Analyze and fix the following issue in the Linux kernel code: device.h: Fix struct member documentation | Problem Details:
Fix warning of make xmldocs of documention of the struct member iommu_ops from struct bus_type.
Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/include/linux/device.h b/include/linux/device.h
index ffbcf95cd97d..2b8832060893 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -69,7 +69,7 @@ extern void bus_remove_file(struct bus_type *, struct bus_attribute *);
* @resume: Called to bring a device on this bus out of sleep ... |
2a9887919457c6e1bd482e8448223be59d19010a | Analyze and fix the following issue in the Linux kernel code: pch_phub: Fix MAC address writing issue for LAPIS ML7831 | Problem Details:
ISSUE:
Using ML7831, MAC address writing doesn't work well.
CAUSE:
ML7831 and EG20T have the same register map for MAC address access.
However, this driver processes the writing the same as ML7223.
This is not true.
This driver must process the writing the same as EG20T.
This patch fixes the issue.
S... | ```diff
diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c
index 0e2c1819a944..10fc4785dba7 100644
--- a/drivers/misc/pch_phub.c
+++ b/drivers/misc/pch_phub.c
@@ -476,7 +476,7 @@ static int pch_phub_write_gbe_mac_addr(struct pch_phub_reg *chip, u8 *data)
int retval;
int i;
- if (chip->ioh_type == 1) /... |
3e1f49011973ff3e67014d03cac50593004cee3c | Analyze and fix the following issue in the Linux kernel code: USB: serial: fix whitespace issues | Problem Details:
Minor whitespace clean ups.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index a2a0574b662a..5c4fcf8d5f98 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -50,7 +50,7 @@ static struct usb_driver usb_serial_driver = {
.disconnect = usb_serial_disconnect,
.suspend = ... |
9ada19342b2441f290f0043ed7c562682c8c4ede | Analyze and fix the following issue in the Linux kernel code: slub: move discard_slab out of node lock | Problem Details:
Lockdep reports there is potential deadlock for slub node list_lock.
discard_slab() is called with the lock hold in unfreeze_partials(),
which could trigger a slab allocation, which could hold the lock again.
discard_slab() doesn't need hold the lock actually, if the slab is
already removed from parti... | ```diff
diff --git a/mm/slub.c b/mm/slub.c
index 60e16c43f88c..00efbb56a268 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1862,7 +1862,7 @@ static void unfreeze_partials(struct kmem_cache *s)
{
struct kmem_cache_node *n = NULL;
struct kmem_cache_cpu *c = this_cpu_ptr(s->cpu_slab);
- struct page *page;
+ struct page *... |
ac3695fb74f27ae36632bcc2d83c0f2c8c4a7ca2 | Analyze and fix the following issue in the Linux kernel code: USB: usb_debug: use process_read_urb | Problem Details:
Use process_read_urb rather than read_bulk_callback for break
processing.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/serial/usb_debug.c b/drivers/usb/serial/usb_debug.c
index 51bb509219e0..9b632e753210 100644
--- a/drivers/usb/serial/usb_debug.c
+++ b/drivers/usb/serial/usb_debug.c
@@ -54,7 +54,7 @@ static void usb_debug_break_ctl(struct tty_struct *tty, int break_state)
usb_serial_generic_write(tty... |
e63aa508f20283b49cfdc47018455778690800cd | Analyze and fix the following issue in the Linux kernel code: USB: usb_debug: fix indentation | Problem Details:
Use tabs for indentation.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/serial/usb_debug.c b/drivers/usb/serial/usb_debug.c
index 95a82148ee81..51bb509219e0 100644
--- a/drivers/usb/serial/usb_debug.c
+++ b/drivers/usb/serial/usb_debug.c
@@ -40,7 +40,7 @@ static struct usb_driver debug_driver = {
.probe = usb_serial_probe,
.disconnect = usb_serial_disco... |
f64ae042d94d376b54e7a343d93c48561e9d2e16 | Analyze and fix the following issue in the Linux kernel code: slub: use correct parameter to add a page to partial list tail | Problem Details:
unfreeze_partials() needs add the page to partial list tail, since such page
hasn't too many free objects. We now explictly use DEACTIVATE_TO_TAIL for this,
while DEACTIVATE_TO_TAIL != 1. This will cause performance regression (eg, more
lock contention in node->list_lock) without below fix.
Signed-off... | ```diff
diff --git a/mm/slub.c b/mm/slub.c
index 7d2a996c307e..60e16c43f88c 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1904,7 +1904,8 @@ static void unfreeze_partials(struct kmem_cache *s)
if (l == M_PARTIAL)
remove_partial(n, page);
else
- add_partial(n, page, 1);
+ add_partial(n, page,
+ ... |
694c6301e515bad574af74b6552134c4d9dcb334 | Analyze and fix the following issue in the Linux kernel code: USB: omninet: fix write_room | Problem Details:
Fix regression introduced by commit 507ca9bc047666 ([PATCH] USB: add
ability for usb-serial drivers to determine if their write urb is
currently being used.) which inverted the logic in write_room so that it
returns zero when the write urb is actually free.
Signed-off-by: Johan Hovold <jhovold@gmail.c... | ```diff
diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index 6d7c56d0cb61..6e976649fcae 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -290,7 +290,7 @@ static int omninet_write_room(struct tty_struct *tty)
int room = 0; /* Default: no room */
/* FIXME: no... |
ce3af89e761b413bef72b49f650fa0ae55f3b6d5 | Analyze and fix the following issue in the Linux kernel code: usb: storage: shuttle_usbat: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/shuttle_usbat.c:173:22: warning:
| symbol 'usbat_usb_ids' was not declared. Should
| it be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/shuttle_usbat.c b/drivers/usb/storage/shuttle_usbat.c
index 0b00091d2ae9..7d642c8efed3 100644
--- a/drivers/usb/storage/shuttle_usbat.c
+++ b/drivers/usb/storage/shuttle_usbat.c
@@ -170,7 +170,7 @@ static int init_usbat_flash(struct us_data *us);
{ USB_DEVICE_VER(id_vendor, id_... |
566b8bbf8c01cd32586087aa267f9358c8857078 | Analyze and fix the following issue in the Linux kernel code: usb: storage: sddr55: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/sddr55.c:51:22: warning: symbol
| 'sddr55_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c
index 44dfed7754ed..f2930441a2fa 100644
--- a/drivers/usb/storage/sddr55.c
+++ b/drivers/usb/storage/sddr55.c
@@ -48,7 +48,7 @@ MODULE_LICENSE("GPL");
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
.driver_info ... |
6f871f9e30504a86f37d074e45a2aa722d7aed53 | Analyze and fix the following issue in the Linux kernel code: usb: storage: sddr09: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/sddr09.c:74:22: warning: symbol
| 'sddr09_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/sddr09.c b/drivers/usb/storage/sddr09.c
index bcb9a709d349..6ecbf44c7ecb 100644
--- a/drivers/usb/storage/sddr09.c
+++ b/drivers/usb/storage/sddr09.c
@@ -71,7 +71,7 @@ static int usb_stor_sddr09_init(struct us_data *us);
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcd... |
d762ad4792fcdec4d58c5385097083116e47337d | Analyze and fix the following issue in the Linux kernel code: usb: storagE: realtek_cr: fix sparse warnings | Problem Details:
Fix the following sparse warnings:
| drivers/usb/storage/realtek_cr.c:821:6: warning: symbol
| 'rts51x_invoke_transport' was not declared. Should
| it be static?
|
| drivers/usb/storage/realtek_cr.c:980:5: warning: symbol
| 'realtek_cr_suspend' was not declared. Should it
| be static?
|
| drivers/usb/... | ```diff
diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
index 0ce5f79197e7..30f64bfe101e 100644
--- a/drivers/usb/storage/realtek_cr.c
+++ b/drivers/usb/storage/realtek_cr.c
@@ -507,15 +507,14 @@ static int enable_oscillator(struct us_data *us)
static int __do_config_autodelink(struct ... |
e2c83f019a2abe48f5faf2fe631e8502adcc70ea | Analyze and fix the following issue in the Linux kernel code: usb: storage: onetouch: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/onetouch.c:72:22: warning: symbol
| 'onetouch_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/onetouch.c b/drivers/usb/storage/onetouch.c
index 1943be5a2914..d29be3e81134 100644
--- a/drivers/usb/storage/onetouch.c
+++ b/drivers/usb/storage/onetouch.c
@@ -69,7 +69,7 @@ struct usb_onetouch {
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
.drive... |
f35e0d5614b9dbf76ec7b5cbd464914a77c01c88 | Analyze and fix the following issue in the Linux kernel code: usb: storage: karma: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/karma.c:62:22: warning: symbol
| 'karma_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/karma.c b/drivers/usb/storage/karma.c
index ba1b78906880..fb5bfb00d797 100644
--- a/drivers/usb/storage/karma.c
+++ b/drivers/usb/storage/karma.c
@@ -59,7 +59,7 @@ static int rio_karma_init(struct us_data *us);
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax)... |
9d35214b415812372a7b1ba1091097b043837604 | Analyze and fix the following issue in the Linux kernel code: usb: storage: jumpshot: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/jumpshot.c:74:22: warning: symbol
| 'jumpshot_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
index 6168596c5ac6..5ef55c7d73e1 100644
--- a/drivers/usb/storage/jumpshot.c
+++ b/drivers/usb/storage/jumpshot.c
@@ -71,7 +71,7 @@ MODULE_LICENSE("GPL");
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
.driv... |
e7724baf78685759a31216362660b70d7786fc77 | Analyze and fix the following issue in the Linux kernel code: usb: storage: isd200: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/freecom.c:122:22: warning: symbol
| 'freecom_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
index ffc4193e9505..7b813036b485 100644
--- a/drivers/usb/storage/isd200.c
+++ b/drivers/usb/storage/isd200.c
@@ -76,7 +76,7 @@ static int isd200_Initialization(struct us_data *us);
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bc... |
2053f075ffc379ddfbca403d95b79effdb41685e | Analyze and fix the following issue in the Linux kernel code: usb: storage: freecom: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/freecom.c:122:22: warning: symbol
| 'freecom_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/freecom.c b/drivers/usb/storage/freecom.c
index 6542ca40d505..8cf16f89c96c 100644
--- a/drivers/usb/storage/freecom.c
+++ b/drivers/usb/storage/freecom.c
@@ -119,7 +119,7 @@ static int init_freecom(struct us_data *us);
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDe... |
36f3a14ded234757f101c866452a8a26d1e83844 | Analyze and fix the following issue in the Linux kernel code: usb: storage: ene_ub6250: fix sparse warnings | Problem Details:
Fix the following sparse warnings:
| drivers/usb/storage/ene_ub6250.c:45:22: warning: symbol
| 'ene_ub6250_usb_ids' was not declared. Should it
| be static?
|
| drivers/usb/storage/ene_ub6250.c:780:5: warning: symbol
| 'ms_lib_alloc_logicalmap' was not declared. Should it
| be static?
|
| drivers/usb/... | ```diff
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 4dca3ef0668c..9665f15f52a7 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -42,7 +42,7 @@ MODULE_LICENSE("GPL");
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
... |
b03379f7e0168791e29534044a9172fa97e498d6 | Analyze and fix the following issue in the Linux kernel code: usb: storage: datafab: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/datafab.c:91:22: warning: symbol
| 'datafab_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c
index ded836b02d7b..0d8d97c94f09 100644
--- a/drivers/usb/storage/datafab.c
+++ b/drivers/usb/storage/datafab.c
@@ -88,7 +88,7 @@ static int datafab_determine_lun(struct us_data *us,
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin,... |
60e3cfbdea3e9696554ac805848ab3049c77b2fd | Analyze and fix the following issue in the Linux kernel code: usb: storage: cypress: fix sparse warning | Problem Details:
Fix the following sparse warning:
| drivers/usb/storage/cypress_atacb.c:46:22: warning:
| symbol 'cypress_usb_ids' was not declared. Should
| it be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/cypress_atacb.c b/drivers/usb/storage/cypress_atacb.c
index c84471821183..740bfe6b2d23 100644
--- a/drivers/usb/storage/cypress_atacb.c
+++ b/drivers/usb/storage/cypress_atacb.c
@@ -43,7 +43,7 @@ MODULE_LICENSE("GPL");
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDe... |
3358be9adf368b54b3f95a3e2556f7aa1ae106d9 | Analyze and fix the following issue in the Linux kernel code: usb: storage: alauda: fix sparse warnings | Problem Details:
Fix the following warning:
| drivers/usb/storage/alauda.c:142:22: warning: symbol
| 'alauda_usb_ids' was not declared. Should it
| be static?
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
index 42d0eaed4a01..9ce3bbab6d20 100644
--- a/drivers/usb/storage/alauda.c
+++ b/drivers/usb/storage/alauda.c
@@ -139,7 +139,7 @@ static int init_alauda(struct us_data *us);
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceM... |
bc985c10f388c0e5fb2cff95ff2220721627fbd8 | Analyze and fix the following issue in the Linux kernel code: USB: storage: ene_ub6250: fix compile warnings | Problem Details:
Fix the following compile warning:
| drivers/usb/storage/ene_ub6250.c: In function ‘ms_scsi_write’:
| drivers/usb/storage/ene_ub6250.c:1728:6: warning: ‘result’ may \
| be used uninitialized in this function [-Wuninitialized]
| drivers/usb/storage/ene_ub6250.c:1795:77: warning: ‘offset’ may \
| be use... | ```diff
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 4dca3ef0668c..9fbe742343c6 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -1762,10 +1762,9 @@ static int ms_scsi_write(struct us_data *us, struct scsi_cmnd *srb)
result = ene_send_s... |
83551c0159e9101b39b2d727ca1be0fd76daaf73 | Analyze and fix the following issue in the Linux kernel code: Input: synaptics - update OLPC XO exclusion | Problem Details:
We have determined that the jumpiness previously seen when using
the synaptics kernel mouse driver on OLPC XO was due to not using
the synaptics X11 userspace driver - the xf86-input-evdev driver was
interpreting 'finger near pad' signals as movements. Newer versions
of xf86-input-evdev fix this issue.... | ```diff
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index a3bb49cb691c..06c9ee57951e 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1389,15 +1389,12 @@ static int __synaptics_init(struct psmouse *psmouse, bool absolute_mode)
int err = -1;
... |
bc5b8a9003132ae44559edd63a1623b7b99dfb68 | Analyze and fix the following issue in the Linux kernel code: hfs: add sanity check for file name length | Problem Details:
On a corrupted file system the ->len field could be wrong leading to
a buffer overflow.
Reported-and-acked-by: Clement LECIGNE <clement.lecigne@netasq.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/fs/hfs/trans.c b/fs/hfs/trans.c
index e673a88b8ae7..b1ce4c7ad3fb 100644
--- a/fs/hfs/trans.c
+++ b/fs/hfs/trans.c
@@ -40,6 +40,8 @@ int hfs_mac2asc(struct super_block *sb, char *out, const struct hfs_name *in)
src = in->name;
srclen = in->len;
+ if (srclen > HFS_NAMELEN)
+ srclen = HFS_NAMEL... |
fe09b32a4361bea44169b2063e8c867cabb6a8ba | Analyze and fix the following issue in the Linux kernel code: Net, libertas: Resolve memory leak in if_spi_host_to_card() | Problem Details:
If we hit the default case in the switch in if_spi_host_to_card() we'll leak
the memory we allocated for 'packet'. This patch resolves the leak by freeing
the allocated memory in that case.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Dan Williams <dcbw@redhat.com>
Cc: stable@vger.kernel.or... | ```diff
diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wireless/libertas/if_spi.c
index 622ae6de0d8b..7059d9645dab 100644
--- a/drivers/net/wireless/libertas/if_spi.c
+++ b/drivers/net/wireless/libertas/if_spi.c
@@ -995,6 +995,7 @@ static int if_spi_host_to_card(struct lbs_private *priv,
spin_unlo... |
ed66ba472a742cd8df37d7072804b2111cdb1014 | Analyze and fix the following issue in the Linux kernel code: rt2x00: Fix sleep-while-atomic bug in powersaving code. | Problem Details:
The generic powersaving code that determines after reception of a frame
whether the device should go back to sleep or whether is could stay
awake was calling rt2x00lib_config directly from RX tasklet context.
On a number of the devices this call can actually sleep, due to having
to confirm that the sle... | ```diff
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
index 2ec5c00235e6..99ff12d0c29d 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h
@@ -943,6 +943,7 @@ struct rt2x00_dev {
* Powersaving work
*/
struct delayed_work autowak... |
f1ebcc74d5b2159f44c96b479b6eb8afc7829095 | Analyze and fix the following issue in the Linux kernel code: Btrfs: fix tree corruption after multi-thread snapshots and inode_cache flush | Problem Details:
The btrfs snapshotting code requires that once a root has been
snapshotted, we don't change it during a commit.
But there are two cases to lead to tree corruptions:
1) multi-thread snapshots can commit serveral snapshots in a transaction,
and this may change the src root when processing the follow... | ```diff
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 0fe615e4ea38..dede441bdeee 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -514,10 +514,25 @@ static inline int should_cow_block(struct btrfs_trans_handle *trans,
struct btrfs_root *root,
struct extent_buffer *buf)
{
+ /* ensure we ... |
dd44eb9e13131f7b1fda65518b24fd3dfcf3a114 | Analyze and fix the following issue in the Linux kernel code: iwlegacy: change IL_ERR to D_HT in iwl4965_rs_tl_turn_on_agg_for_tid | Problem Details:
This message should be a debug message and not an error.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> | ```diff
diff --git a/drivers/net/wireless/iwlegacy/4965-rs.c b/drivers/net/wireless/iwlegacy/4965-rs.c
index 4bc5a1845821..93c3a4d9b9b5 100644
--- a/drivers/net/wireless/iwlegacy/4965-rs.c
+++ b/drivers/net/wireless/iwlegacy/4965-rs.c
@@ -371,10 +371,10 @@ il4965_rs_tl_turn_on_agg_for_tid(struct il_priv *il, struct il_... |
53611e05263ca2101a29736920fdf86ccad0e93b | Analyze and fix the following issue in the Linux kernel code: iwlegacy: change IL_WARN to D_HT in il4965_tx_agg_start | Problem Details:
This message should be a debug message and not a warning.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> | ```diff
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 21a1381c9748..8d2f6162d6e8 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -2252,7 +2252,7 @@ il4965_tx_agg_start(struct il_priv *il, struct ieee80211_vi... |
f02579e3a81954c8f0944c7d2a95159ee48f052d | Analyze and fix the following issue in the Linux kernel code: iwlegacy: merge iwl-debug.h into common.h | Problem Details:
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> | ```diff
diff --git a/drivers/net/wireless/iwlegacy/3945.h b/drivers/net/wireless/iwlegacy/3945.h
index ed367bb7878f..1a2430bb1889 100644
--- a/drivers/net/wireless/iwlegacy/3945.h
+++ b/drivers/net/wireless/iwlegacy/3945.h
@@ -35,7 +35,6 @@
extern const struct pci_device_id il3945_hw_card_ids[];
#include "common.h"... |
f19ab370a7ba40570dcdb2c0c3cdaa8c20efde97 | Analyze and fix the following issue in the Linux kernel code: iwlegacy: rename iwl-debug.c to debug.c | Problem Details:
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> | ```diff
diff --git a/drivers/net/wireless/iwlegacy/Makefile b/drivers/net/wireless/iwlegacy/Makefile
index 74218419f8ef..c985a01a0731 100644
--- a/drivers/net/wireless/iwlegacy/Makefile
+++ b/drivers/net/wireless/iwlegacy/Makefile
@@ -1,6 +1,6 @@
obj-$(CONFIG_IWLEGACY) += iwlegacy.o
iwlegacy-objs := common.o
-iwleg... |
9a95b37015de03aa82bf340b3ee8e97af11be910 | Analyze and fix the following issue in the Linux kernel code: iwlegacy: use FH49_ prefix in 4965 code | Problem Details:
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> | ```diff
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 82b6a7b8624a..9e3f74c8e9a7 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -138,22 +138,22 @@ int il4965_rx_init(struct il_priv *il, struct il_rx_queue *... |
53143a1809db521ff34371f066bfd8f1619ec2c9 | Analyze and fix the following issue in the Linux kernel code: iwlegacy: use FH39_ prefix in 3945 code | Problem Details:
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> | ```diff
diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c
index 3c8999960011..ffd6ddf89ec1 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
@@ -1528,7 +1528,7 @@ static void il3945_irq_tasklet(struct il_priv *il)
if (in... |
ccf5533ec4cdf792ec17c375b1186cfed4086f2a | Analyze and fix the following issue in the Linux kernel code: iwlegacy: rename iwl-3945-{rs,debugfs}.c to 3945-{rs,debug}.c | Problem Details:
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> | ```diff
diff --git a/drivers/net/wireless/iwlegacy/iwl-3945-debugfs.c b/drivers/net/wireless/iwlegacy/3945-debug.c
similarity index 100%
rename from drivers/net/wireless/iwlegacy/iwl-3945-debugfs.c
rename to drivers/net/wireless/iwlegacy/3945-debug.c
diff --git a/drivers/net/wireless/iwlegacy/iwl-3945-rs.c b/drivers/ne... |
f3a1b49d669472159e05327fff64ec55315a0f54 | Analyze and fix the following issue in the Linux kernel code: iwlegacy: rename iwl-4965-{rs,calib,debugfs}.c to 4965-{rs,calib,debug}.c | Problem Details:
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> | ```diff
diff --git a/drivers/net/wireless/iwlegacy/iwl-4965-calib.c b/drivers/net/wireless/iwlegacy/4965-calib.c
similarity index 100%
rename from drivers/net/wireless/iwlegacy/iwl-4965-calib.c
rename to drivers/net/wireless/iwlegacy/4965-calib.c
diff --git a/drivers/net/wireless/iwlegacy/iwl-4965-debugfs.c b/drivers/n... |
95bdaf71ccf2cb4bba0c9a3d2baea0e7916f466b | Analyze and fix the following issue in the Linux kernel code: iommu: Fix compile error with !IOMMU_API | Problem Details:
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> | ```diff
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 93617e7779a1..0f318fd549be 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -181,7 +181,7 @@ static inline void iommu_set_fault_handler(struct iommu_domain *domain,
{
}
-static inline int iommu_device_group(struct device *dev,... |
e13b91c1c47e7be178d2d7914452040ee82c0bd2 | Analyze and fix the following issue in the Linux kernel code: unicore32: fix build error for find bitops | Problem Details:
Remove the __uc32_ prefix in find bitops functions.
Move find_* macros behind asm-generic/bitops.h inclusion.
see commit <19de85ef574c3a2182e3ccad9581805052f14946>
bitops: add #ifndef for each of find bitops
also see commit <63e424c84429903c92a0f1e9654c31ccaf6694d0>
arch: remove CONFIG_GENERIC_FIND... | ```diff
diff --git a/arch/unicore32/include/asm/bitops.h b/arch/unicore32/include/asm/bitops.h
index 1628a6328994..401f597bc38c 100644
--- a/arch/unicore32/include/asm/bitops.h
+++ b/arch/unicore32/include/asm/bitops.h
@@ -13,12 +13,6 @@
#ifndef __UNICORE_BITOPS_H__
#define __UNICORE_BITOPS_H__
-#define find_next_b... |
483b88f86e1682241bfa0848e348aa175257c6e7 | Analyze and fix the following issue in the Linux kernel code: drm/exynos: fix vblank bug. | Problem Details:
In case that vblank_disable_allowed is 1, the problem that manager->pipe
could be -1 at vsync interrupt handler could be induced so this patch fixes
that.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> | ```diff
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index f5c8b072e497..272c3b53c062 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -447,7 +447,9 @@ static void fimd_win_commit(struct device *dev)
static void ... |
b0e0f85631f9d905095d2896a952430f5eb0aba1 | Analyze and fix the following issue in the Linux kernel code: drm/exynos: checked for null pointer | Problem Details:
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> | ```diff
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
index f15da9581a1e..866f419f485b 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
@@ -283,7 +283,8 @@ void exynos_drm_encoder_crtc_mode_set(struct drm_... |
1d299bc7732c34d85bd43ac1a8745f5a2fed2078 | Analyze and fix the following issue in the Linux kernel code: sparc: Fix handling of orig_i0 wrt. debugging when restarting syscalls. | Problem Details:
Although we provide a proper way for a debugger to control whether
syscall restart occurs, we run into problems because orig_i0 is not
saved and restored properly.
Luckily we can solve this problem without having to make debuggers
aware of the issue. Across system calls, several registers are
conside... | ```diff
diff --git a/arch/sparc/kernel/signal32.c b/arch/sparc/kernel/signal32.c
index 2caa556db86d..2e86fd1ddc7b 100644
--- a/arch/sparc/kernel/signal32.c
+++ b/arch/sparc/kernel/signal32.c
@@ -822,21 +822,23 @@ static inline void syscall_restart32(unsigned long orig_i0, struct pt_regs *regs
* want to handle. Thus y... |
332960bd7eb48ef21923b4876e7fe3487d6bf11c | Analyze and fix the following issue in the Linux kernel code: USB: ehci: report Data Buffer Error in debug mode | Problem Details:
Data Buffer Error as per spec section 4.15.1.1.2
results when there is Underrun or Overrun condition.
This error is considered non-fatal and never gets reported.
Its a very good indication on things going wrong at system level,
like running memory at much slower speed.
This is a good error to flag al... | ```diff
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
index 4e4066c35a09..f136f7f1c4f4 100644
--- a/drivers/usb/host/ehci-q.c
+++ b/drivers/usb/host/ehci-q.c
@@ -373,6 +373,17 @@ qh_completions (struct ehci_hcd *ehci, struct ehci_qh *qh)
retry_xacterr:
if ((token & QTD_STS_ACTIVE) == 0) {
+ ... |
161f14191dc166c4e3f37f68af1bc199c6868b7d | Analyze and fix the following issue in the Linux kernel code: pcie-gadget-spear: Add "platform:" prefix for platform modalias | Problem Details:
Since 43cc71eed1250755986da4c0f9898f9a635cb3bf (platform: prefix MODALIAS
with "platform:"), the platform modalias is prefixed with "platform:".
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Pratyush Anand <pratyush.anand@st.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-H... | ```diff
diff --git a/drivers/misc/spear13xx_pcie_gadget.c b/drivers/misc/spear13xx_pcie_gadget.c
index cfbddbef11de..43d073bc1d9c 100644
--- a/drivers/misc/spear13xx_pcie_gadget.c
+++ b/drivers/misc/spear13xx_pcie_gadget.c
@@ -903,6 +903,6 @@ static void __exit spear_pcie_gadget_exit(void)
}
module_exit(spear_pcie_ga... |
8981d76a2cf4c46333d9a18176a6eee337a71146 | Analyze and fix the following issue in the Linux kernel code: powerpc/usb: fix type cast for address of ioremap to compatible with 64-bit | Problem Details:
Below are codes for accessing usb sysif_regs in driver:
usb_sys_regs = (struct usb_sys_interface *)
((u32)dr_regs + USB_DR_SYS_OFFSET);
these codes work in 32-bit, but in 64-bit, use u32 to type cast the address
of ioremap is not right, and accessing members of 'usb_sys_regs' will cause
call trace, ... | ```diff
diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
index d786ba31fc07..b3b3d83b7c33 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2480,8 +2480,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
#ifndef CONFIG_ARCH_MX... |
770f0baaee0c511d0d466082e72815ed861e301f | Analyze and fix the following issue in the Linux kernel code: USB: at91: at91-ohci: fix set/get power | Problem Details:
in commit aa6e52a35 we introduce the support of overcurrent notification
but the set and get of the power without checking if the gpio is valid or not
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Nico... | ```diff
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index ba3a46b78b75..95a9fec38e89 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -223,6 +223,9 @@ static void ohci_at91_usb_set_power(struct at91_usbh_data *pdata, int port, int
if (port < 0 || port >= 2)
... |
9f3bdd4f937a75c4589a867dc1f8fefe09c1a618 | Analyze and fix the following issue in the Linux kernel code: PM / devfreq: fix use after free in devfreq_remove_device | Problem Details:
In devfreq_remove_device, calling _remove_devfreq will also free devfreq.
Don't dereference devfreq->governor->no_central_polling after _remove_devfreq.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> | ```diff
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index d0659253387a..59d24e9cb8c5 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -418,10 +418,14 @@ out:
*/
int devfreq_remove_device(struct devfreq *devfreq)
{
+ bool central_polling;
+
if (!devfreq)
return -E... |
5dc2470c602da8851907ec18942cd876c3b4ecc1 | Analyze and fix the following issue in the Linux kernel code: USB: cdc-acm: Fix disconnect() vs close() race | Problem Details:
There's a race between the USB disconnect handler and the TTY close
handler which may cause the acm object to be freed while it's still
being used. This may lead to things like
http://article.gmane.org/gmane.linux.usb.general/54250
and
https://lkml.org/lkml/2011/5/29/64
This is the simplest fix I c... | ```diff
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 6960715c5063..e8c564a53346 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -539,7 +539,6 @@ static void acm_port_down(struct acm *acm)
{
int i;
- mutex_lock(&open_mutex);
if (acm->dev) {
usb_auto... |
811c926c538f7e8d3c08b630dd5844efd7e000f6 | Analyze and fix the following issue in the Linux kernel code: USB: EHCI: fix HUB TT scheduling issue with iso transfer | Problem Details:
The current TT scheduling doesn't allow to play and then record on a
full-speed device connected to a high speed hub.
The IN iso stream can only start on the first uframe (0-2 for a 165 us)
because of CSPLIT transactions.
For the OUT iso stream there no such restriction. uframe 0-5 are possible.
The ... | ```diff
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index 2e829fae6482..56a32033adb3 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -1479,10 +1479,15 @@ iso_stream_schedule (
/* NOTE: assumes URB_ISO_ASAP, to limit complexity/bugs */
- /* find a... |
f69e3120df82391a0ee8118e0a156239a06b2afb | Analyze and fix the following issue in the Linux kernel code: USB: XHCI: resume root hubs when the controller resumes | Problem Details:
This patch (as1494) fixes a problem in xhci-hcd's resume routine.
When the controller is runtime-resumed, this can only mean that one of
the two root hubs has made a wakeup request and therefore needs to be
resumed as well. Rather than try to determine which root hub requires
attention (which might be... | ```diff
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 747c5ead922b..aa94c0195791 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -799,7 +799,7 @@ int xhci_resume(struct xhci_hcd *xhci, bool hibernated)
u32 command, temp = 0;
struct usb_hcd *hcd = xhci_to_hcd(xhci);
... |
97ff22ee3b4cb3a334f7385e269773141aed702f | Analyze and fix the following issue in the Linux kernel code: USB: workaround for bug in old version of GCC | Problem Details:
This patch (as1491) works around a bug in GCC-3.4.6, which is still
supposed to be supported. The number of microseconds in the udelay()
call in quirk_usb_disable_ehci() is fixed at 100, but the compiler
doesn't understand this and generates a link-time error. So we
replace the otherwise unused varia... | ```diff
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index 27a3dec32fa2..c7fd6ce11904 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -627,7 +627,7 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
void __iomem *base, *op_reg_base;
... |
583182ba5f02c8c9be82ea550f2051eaec15b975 | Analyze and fix the following issue in the Linux kernel code: USB: ark3116 initialisation fix | Problem Details:
This patch for the usb serial ark3116 driver fixes an initialisation
ordering bug that gets triggered on hotplug when using at least recent
debian/ubuntu userspace. Without it, ark3116 serial cables don't work.
Signed-off-by: Bart Hartgers <bart.hartgers@gmail.com>
Tested-by: law_ence.dev@ntlworld.com... | ```diff
diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c
index 5cdb9d912275..18e875b92e00 100644
--- a/drivers/usb/serial/ark3116.c
+++ b/drivers/usb/serial/ark3116.c
@@ -42,7 +42,7 @@ static int debug;
* Version information
*/
-#define DRIVER_VERSION "v0.6"
+#define DRIVER_VERSION "v0.7"
... |
bd061c78cabc28bb64ed79f784d24918b6bdb791 | Analyze and fix the following issue in the Linux kernel code: regmap: Fix memory leak in regcache_init error path | Problem Details:
Make sure all allocated memory gets freed again in case initializing the cache
failed.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> | ```diff
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 79446262812c..27fae58ff4cb 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -144,9 +144,18 @@ int regcache_init(struct regmap *map)
if (map->cache_ops->init) {
dev_dbg(map->dev, "Initializi... |
021cd616decb4e8a4b31f1f8c466a847e8c04e67 | Analyze and fix the following issue in the Linux kernel code: regmap: Fix memory leak in regcache_hw_init error path | Problem Details:
Make sure reg_defaults_raw gets freed in case of an error.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> | ```diff
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 6ab9f0384d82..79446262812c 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -61,8 +61,10 @@ static int regcache_hw_init(struct regmap *map)
map->reg_defaults = kmalloc(count * sizeof(struct ... |
abbb18fb4ad7472ee2e1351f0ca12bce64cac143 | Analyze and fix the following issue in the Linux kernel code: regmap: return ERR_PTR instead of NULL in regmap_init | Problem Details:
The regmap_init documentation states that it will either return a pointer to a
valid regmap structure or a ERR_PTR in case of an error. Currently it returns a
NULL pointer in case no bus or no config was given. Since NULL is not a
ERR_PTR a caller might assume that it is a pointer to a valid regmap str... | ```diff
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index b08df85cedff..b84ebf9eecf0 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -139,7 +139,7 @@ struct regmap *regmap_init(struct device *dev,
int ret = -EINVAL;
if (!bus || !config)
- return NULL;
... |
ab570da26eec4e840dc1d18f45ab9d64bae49a5d | Analyze and fix the following issue in the Linux kernel code: usb: musb: fix compilation breakage introduced by de47725 | Problem Details:
commit de47725 (include: replace linux/module.h
with "struct module" wherever possible) introduced
a compilation breaked when it removed <linux/module.h>
from <linux/device.h> which musb glue layers were
(mistakenly) relying on.
Include that header to fix the compile error.
Signed-off-by: Felipe Balb... | ```diff
diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c
index 08f1d0b662a3..e233d2b7d335 100644
--- a/drivers/usb/musb/am35x.c
+++ b/drivers/usb/musb/am35x.c
@@ -27,6 +27,7 @@
*/
#include <linux/init.h>
+#include <linux/module.h>
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/plat... |
d7a00ec1a8debf74317c5110ded9918bad8de772 | Analyze and fix the following issue in the Linux kernel code: usb: gadget: renesas_usbhs: bugfix: set DATA0 when usbhsh_endpoint_alloc() | Problem Details:
new endpoint should start from DATA0,
but mod_host didn't care it.
This patch fix it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c
index 228f7b844c1d..bade761a1e52 100644
--- a/drivers/usb/renesas_usbhs/mod_host.c
+++ b/drivers/usb/renesas_usbhs/mod_host.c
@@ -435,6 +435,7 @@ usbhsh_endpoint_alloc_find_pipe:
* see
* DCPMAXP/PIPEMAXP
*/
+ usbh... |
146ee50ae51c78fc93d025cb9528883df26ab705 | Analyze and fix the following issue in the Linux kernel code: usb: gadget: renesas_usbhs: bugfix: disable irq when device stop | Problem Details:
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c
index f8f612c46ea4..228f7b844c1d 100644
--- a/drivers/usb/renesas_usbhs/mod_host.c
+++ b/drivers/usb/renesas_usbhs/mod_host.c
@@ -1226,8 +1226,18 @@ static int usbhsh_stop(struct usbhs_priv *priv)
{
struct usbhsh_hpriv *... |
73ef635a07c0e6a0a159d8beabffb83399429188 | Analyze and fix the following issue in the Linux kernel code: usb: gadget: renesas_usbhs: bugfix: care pipe direction | Problem Details:
renesas_usbhs is caring pipe type and its direction.
but current usbhs_endpoint_alloc() didn't check direction.
this patch modify it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c
index b964f25ebdb7..f8f612c46ea4 100644
--- a/drivers/usb/renesas_usbhs/mod_host.c
+++ b/drivers/usb/renesas_usbhs/mod_host.c
@@ -355,6 +355,7 @@ static void usbhsh_device_free(struct usbhsh_hpriv *hpriv,
struct usbhsh_ep ... |
194fa47ef629df07d87064ca4aa973939fa6fb4d | Analyze and fix the following issue in the Linux kernel code: USB: ci13xxx_udc: fix debug trace code | Problem Details:
This patch fixes the following compile errors that show up if switching
on the debug trace code:
drivers/usb/gadget/ci13xxx_udc.c: In function 'ci13xxx_wakeup':
drivers/usb/gadget/ci13xxx_udc.c:2517:3: error: 'dev' undeclared (first use in this function)
drivers/usb/gadget/ci13xxx_udc.c:2517:3: note: ... | ```diff
diff --git a/drivers/usb/gadget/ci13xxx_udc.c b/drivers/usb/gadget/ci13xxx_udc.c
index 4241241128c6..9a0c3979ff43 100644
--- a/drivers/usb/gadget/ci13xxx_udc.c
+++ b/drivers/usb/gadget/ci13xxx_udc.c
@@ -2503,12 +2503,12 @@ static int ci13xxx_wakeup(struct usb_gadget *_gadget)
spin_lock_irqsave(udc->lock, flag... |
fd537c041b7f2cbceb5a21c37946e017006edd1c | Analyze and fix the following issue in the Linux kernel code: USB: ci13xxx_udc: fix deadlock during rmmod | Problem Details:
The inline documentation of _gadget_stop_activity() states that the
function should be called holding the udc->lock. This however will
result in a deadlock, because _gadget_stop_activity() takes the udc->lock.
During normal operation _gadget_stop_activity() is always called unlocked,
but in ci13xxx_st... | ```diff
diff --git a/drivers/usb/gadget/ci13xxx_udc.c b/drivers/usb/gadget/ci13xxx_udc.c
index ae6c0010f5e7..4241241128c6 100644
--- a/drivers/usb/gadget/ci13xxx_udc.c
+++ b/drivers/usb/gadget/ci13xxx_udc.c
@@ -1613,7 +1613,6 @@ __acquires(mEp->lock)
* @gadget: gadget
*
* This function returns an error code
- * C... |
954aad8cd18c928e2db5229f6fa71c80d1c3d8b5 | Analyze and fix the following issue in the Linux kernel code: USB: ci13xxx_udc: fix logic to mark request dma addresses as invalid | Problem Details:
The current driver sets the request's dma addr (mReq->req.dma) to 0 to
mark the DMA address as not valid. However some gadget drivers
(e.g. gadgetfs) set the request's dma addr to DMA_ADDR_INVALID to mark
the address as invalid. This leads to bogus data send because the
ci13xxx_udc driver assumes the r... | ```diff
diff --git a/drivers/usb/gadget/ci13xxx_udc.c b/drivers/usb/gadget/ci13xxx_udc.c
index 83428f56253b..ae6c0010f5e7 100644
--- a/drivers/usb/gadget/ci13xxx_udc.c
+++ b/drivers/usb/gadget/ci13xxx_udc.c
@@ -71,6 +71,9 @@
/******************************************************************************
* DEFINE
*... |
001428e4871d6c62f5e16c62df681624d8b480c1 | Analyze and fix the following issue in the Linux kernel code: USB: gadgetfs: gadgetfs_disconnect: fix inconsistent lock state | Problem Details:
Under certain circumstances lockdep finds an inconsistent lock state in
gadgetfs. The problem can be reproduced with a hardware using the
ci13xxx_udc driver and the gadgetfs test program (needs a patch to support
the ci13xxx_udc, though):
http://www.linux-usb.org/gadget/usb.c
Start the test program, w... | ```diff
diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c
index a392ec0d2d51..6ccae2707e59 100644
--- a/drivers/usb/gadget/inode.c
+++ b/drivers/usb/gadget/inode.c
@@ -1730,8 +1730,9 @@ static void
gadgetfs_disconnect (struct usb_gadget *gadget)
{
struct dev_data *dev = get_gadget_data (gadget);... |
74203de067ae5c71526168b597088022836e31d3 | Analyze and fix the following issue in the Linux kernel code: usb: gadget: fix MIDI gadget jack allocation | Problem Details:
The dynamic jack allocation of the MIDI gadget currently links all
external jacks to one single instance of an embedded jack. According to
the spec, this is only valid if these streams always carry the same data
stream, as described in the USB MIDI 1.0 spec, chapter 3.3.1.
Also, genius Windows 7(tm) t... | ```diff
diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c
index 67b222908cf9..3797b3d6c622 100644
--- a/drivers/usb/gadget/f_midi.c
+++ b/drivers/usb/gadget/f_midi.c
@@ -95,7 +95,6 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req);
DECLARE_UAC_AC_HEADER_DESCRIPTOR(1);
... |
ce7b6121851c72d661134d113a78161095e0ae73 | Analyze and fix the following issue in the Linux kernel code: usb: gadget: storage: check for valid USB_BULK_RESET_REQUEST wLength | Problem Details:
The USB-IF CV compliance tester is getting stricter, and it would
be valid for it to fail a mass-storage device that accepts an
invalid USB_BULK_RESET_REQUEST request. Although it doesn't do
that yet, let's be proactive and fix that now.
Suggested by Alan Stern.
Signed-off-by: Paul Zimmerman <paulz@s... | ```diff
diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
index dfd0044cc15a..c39d58860fa0 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -624,7 +624,8 @@ static int fsg_setup(struct usb_function *f,
if (ctrl->bRequestType !=
... |
b7a8d17db9a86db1040862600cf3a02848f83844 | Analyze and fix the following issue in the Linux kernel code: usb: gadget: renesas_usbhs: fixup section mismatch warning | Problem Details:
Fix up the following section mismatch warnings:
WARNING: drivers/usb/renesas_usbhs/renesas_usbhs.o(.text+0xf5d): Section
mismatch in reference from the function usbhs_mod_probe() to the function
.devinit.text:usbhs_mod_host_probe() The function usbhs_mod_probe() references
the function __devinit usbhs... | ```diff
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index d2e2efaba658..08c679c0dde5 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -405,7 +405,7 @@ int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
/*
* platform f... |
c9ae0c91b920a7ba91725d170aa023be8c12db7b | Analyze and fix the following issue in the Linux kernel code: usb: gadget: renesas_usbhs: fixup bogus conversion | Problem Details:
this patch fixup bogus conversion of
8a9775ab71218690ac34bed9e237e2b968857d3a
(usb: gadget: renesas_usbhs: fix compile warning)
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
index 8da685e796d1..ffdf5d15085e 100644
--- a/drivers/usb/renesas_usbhs/fifo.c
+++ b/drivers/usb/renesas_usbhs/fifo.c
@@ -820,7 +820,7 @@ static int usbhsf_dma_prepare_push(struct usbhs_pkt *pkt, int *is_done)
if (len % 4) /* 32b... |
0e042be348b864a57a8a452aaa7ec49be5fb9e59 | Analyze and fix the following issue in the Linux kernel code: usb: gadget: fsl_udc_core: fix compile error. | Problem Details:
Fix compile error in file drivers/usb/gadget/fsl_udc_core.c.
drivers/usb/gadget/fsl_udc_core.c: In function 'portscx_device_speed':
drivers/usb/gadget/fsl_udc_core.c:1720: error: 'speed' undeclared (first
use in this function)
Introduced in commit e538dfdae85244fd2c4231725d82cc1f1bc4942c
(usb: Provid... | ```diff
diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
index b2c44e1d5813..d786ba31fc07 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -1717,7 +1717,7 @@ static void dtd_complete_irq(struct fsl_udc *udc)
static inline enum usb_device_spee... |
05bb7013038a2b609aef14ad4e07afe031daec49 | Analyze and fix the following issue in the Linux kernel code: usb: gadget: r8a66597-udc: fix flush fifo handling | Problem Details:
The "BCLR" in CFIFOCTR/DnFIFOCTR can flush the fifo of "CPU side" only.
To flush the fifo of "SIE side", we have to use the "ACLRM" in PIPEnCTR.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse... | ```diff
diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c
index 38f99887b935..24f84b210ce1 100644
--- a/drivers/usb/gadget/r8a66597-udc.c
+++ b/drivers/usb/gadget/r8a66597-udc.c
@@ -1718,6 +1718,8 @@ static void r8a66597_fifo_flush(struct usb_ep *_ep)
if (list_empty(&ep->queue) && !ep... |
b8cbbf803d5ad0971665dd502d784148464c6d1a | Analyze and fix the following issue in the Linux kernel code: usb: gadget: r8a66597-udc: fix for udc-newstyle | Problem Details:
The udc-newstyle needs device_register in probe() of platform_device.
If it doesn't call, kernel panic happens in the sysfs_create_dir() when
we run modprobe a gadget driver.
[ balbi@ti.com : fix compile warning introduced by this patch ]
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas... | ```diff
diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c
index 68a826a1b866..38f99887b935 100644
--- a/drivers/usb/gadget/r8a66597-udc.c
+++ b/drivers/usb/gadget/r8a66597-udc.c
@@ -1742,7 +1742,6 @@ static int r8a66597_start(struct usb_gadget *gadget,
struct usb_gadget_driver *drive... |
0de174b56ba70e5c0a26de9b5d2889260164d666 | Analyze and fix the following issue in the Linux kernel code: usb: musb: hdrc: fix dependency on USB_GADGET_DUALSPEED in Kconfig | Problem Details:
USB_MUSB_HDRC depends on USB_GADGET_DUALSPEED. If HDRC is selected
but DUALSPEED is not, the kernel oopses:
[ 3.132781] Unable to handle kernel NULL pointer dereference at virtual address 00000000
[ 3.141296] pgd = c0004000
[ 3.144134] [00000000] *pgd=00000000
[ 3.147918] Internal error: ... | ```diff
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index e1187242a34e..07a03460a598 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -11,6 +11,7 @@ config USB_MUSB_HDRC
select TWL4030_USB if MACH_OMAP_3430SDP
select TWL6030_USB if MACH_OMAP_4430SDP || MACH_OMAP4_PANDA
... |
6f39504de55ef69bb8d9d0a645949c5d0407faab | Analyze and fix the following issue in the Linux kernel code: usb: gadget: core: fix bug when removing gadget drivers | Problem Details:
usb_gadget_disconnect() is responsible of removing
data pullups. Before doing that we must, first, tell
gadget driver we're disconnecting (by calling disconnect
method on gadget driver structure), unbind the gadget
driver and stop the controller.
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-b... | ```diff
diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
index 31e410bbe55a..4c5ff14a7c61 100644
--- a/drivers/usb/gadget/udc-core.c
+++ b/drivers/usb/gadget/udc-core.c
@@ -210,10 +210,10 @@ static void usb_gadget_remove_driver(struct usb_udc *udc)
kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE)... |
1d91a96268a0b2d7301c3ee67a784b712f34010f | Analyze and fix the following issue in the Linux kernel code: usb: gadget: udc-core: fix bug on soft_connect and srp interfaces | Problem Details:
We should not be using dev_get_drvdata() because we
never call dev_set_drvdata(). Let's use container_of()
as all other sysfs attributes.
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
index 022baeca7c94..31e410bbe55a 100644
--- a/drivers/usb/gadget/udc-core.c
+++ b/drivers/usb/gadget/udc-core.c
@@ -344,7 +344,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_unregister_driver);
static ssize_t usb_udc_srp_store(struct device *dev,
... |
ad79eefc42d56cb851a2b28a86e481cf1161005e | Analyze and fix the following issue in the Linux kernel code: ipv4: fix a memory leak in ic_bootp_send_if | Problem Details:
when dev_hard_header() failed, the newly allocated skb should be freed.
Signed-off-by: RongQing.Li <roy.qing.li@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 0da2afc97f32..7f17ba8b0318 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -822,8 +822,13 @@ static void __init ic_bootp_send_if(struct ic_device *d, unsigned long jiffies_d
skb->dev = dev;
skb->protocol = htons(ETH_P_IP);
if (dev_... |
a32fd63dbf15f70cafd30b306c31f117129c57f2 | Analyze and fix the following issue in the Linux kernel code: NET: MIPS: lantiq: fix etop compile error | Problem Details:
The Lantiq ETOP ethernet driver fails to build in 3.2-rc1 due to 2 missing
header files.
Signed-off-by: John Crispin <blogic@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 6bb2b9506cad..0b3567ab8121 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -34,6 +34,8 @@
#include <linux/init.h>
#include <linux/delay.h>
#include <linux/io.h>
+#include <li... |
abbd00b82a2771b0460ba2cffdb1343aa827ccde | Analyze and fix the following issue in the Linux kernel code: net/can/mscan: Fix buggy listen only mode setting | Problem Details:
This patch fixes an issue introduced recently with commit
452448f9283e1939408b397e87974a418825b0a8.
CC: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
index 74f3b1829e02..1c82dd8b896e 100644
--- a/drivers/net/can/mscan/mscan.c
+++ b/drivers/net/can/mscan/mscan.c
@@ -581,7 +581,7 @@ static int mscan_open(struct net_device *dev)
priv->open_time = jiffies;
- if (ctrlmode.flags & CAN... |
e0ce42e19ce1978a5aee33b2954d7e1a730e88c4 | Analyze and fix the following issue in the Linux kernel code: fsl-rio: fix compile error | Problem Details:
The "#include <linux/module.h>" was replaced by "#include <linux/export.h>"
in the patch "powerpc: various straight conversions from module.h --> export.h".
This will cause the following compile problem:
arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception':
arch/powerpc/sysdev/fsl_rio.... | ```diff
diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
index de170fd5ba4e..22ffccd8bef5 100644
--- a/arch/powerpc/sysdev/fsl_rio.c
+++ b/arch/powerpc/sysdev/fsl_rio.c
@@ -23,7 +23,7 @@
*/
#include <linux/init.h>
-#include <linux/export.h>
+#include <linux/module.h>
#include <linux/type... |
4cac2eb158c6da0c761689345c6cc5df788a6292 | Analyze and fix the following issue in the Linux kernel code: PCI hotplug: shpchp: don't blindly claim non-AMD 0x7450 device IDs | Problem Details:
Previously we claimed device ID 0x7450, regardless of the vendor, which is
clearly wrong. Now we'll claim that device ID only for AMD.
I suspect this was just a typo in the original code, but it's possible this
change will break shpchp on non-7450 AMD bridges. If so, we'll have to fix
them as we fin... | ```diff
diff --git a/drivers/pci/hotplug/shpchp_core.c b/drivers/pci/hotplug/shpchp_core.c
index aca972bbfb4c..dd7e0c51a33e 100644
--- a/drivers/pci/hotplug/shpchp_core.c
+++ b/drivers/pci/hotplug/shpchp_core.c
@@ -278,8 +278,8 @@ static int get_adapter_status (struct hotplug_slot *hotplug_slot, u8 *value)
static in... |
1a9a8aefa8f0530c97f4606ab7a2fc01fe31e9c1 | Analyze and fix the following issue in the Linux kernel code: printk, lockdep: Switch to tracked irq ops | Problem Details:
Switch to local_irq_ ops so that the irq state is properly tracked
(raw_local_irq_* isn't tracked by lockdep, causing confusion).
Possible now that commit dd4e5d3ac4a ("lockdep: Fix
trace_[soft,hard]irqs_[on,off]() recursion") cured the reason we
needed the raw_ ops.
Signed-off-by: Peter Zijlstra <a.... | ```diff
diff --git a/kernel/printk.c b/kernel/printk.c
index ba5ee0435821..dfd8f73dcb76 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -842,7 +842,7 @@ asmlinkage int vprintk(const char *fmt, va_list args)
printk_delay();
/* This stops the holder of console_sem just where we want him */
- raw_local_irq_sav... |
94d24fc47219219b5aa23b45956cc37ee5aa5b01 | Analyze and fix the following issue in the Linux kernel code: printk, lockdep: Disable lock debugging on zap_locks() | Problem Details:
zap_locks() is used by printk() in a last ditch effort to get data
out, clearly we cannot trust lock state after this so make it disable
lock debugging.
Also don't treat printk recursion through lockdep as a normal
recursion bug but try hard to get the lockdep splat out.
Signed-off-by: Peter Zijlstra... | ```diff
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index b6a56e37284c..d36619ead3ba 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -343,6 +343,8 @@ extern void lockdep_trace_alloc(gfp_t mask);
#define lockdep_assert_held(l) WARN_ON(debug_locks && !lockdep_is_held(l))
+#de... |
5d81e5cfb37a174e8ddc0413e2e70cdf05807ace | Analyze and fix the following issue in the Linux kernel code: events: Don't divide events if it has field period | Problem Details:
This patch solves the following problem:
Now some samples may be lost due to throttling. The number of samples is
restricted by sysctl_perf_event_sample_rate/HZ. A trace event is
divided on some samples according to event's period. I don't sure, that
we should generate more than one sample on each t... | ```diff
diff --git a/kernel/events/core.c b/kernel/events/core.c
index eadac69265fc..8d9dea56c262 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -4528,7 +4528,6 @@ static void perf_swevent_overflow(struct perf_event *event, u64 overflow,
struct hw_perf_event *hwc = &event->hw;
int throttle = 0;
-... |
78345d2edc25e001558f3b7c85906f645d38d23c | Analyze and fix the following issue in the Linux kernel code: x86: Call stop_machine_text_poke() on all CPUs | Problem Details:
It appears that stop_machine_text_poke() wants to be called on all CPUs,
like it's done from text_poke_smp(). Fix text_poke_smp_batch() to do
this.
Signed-off-by: Rabin Vincent <rabin@rab.in>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chel... | ```diff
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index c63822816249..1f84794f0759 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -738,5 +738,5 @@ void __kprobes text_poke_smp_batch(struct text_poke_param *params, int n)
atomic_set(&stop_machine_fi... |
57d1c0c03c6b48b2b96870d831b9ce6b917f53ac | Analyze and fix the following issue in the Linux kernel code: perf/x86: Fix PEBS instruction unwind | Problem Details:
Masami spotted that we always try to decode the instruction stream as
64bit instructions when running a 64bit kernel, this doesn't work for
ia32-compat proglets.
Use TIF_IA32 to detect if we need to use the 32bit instruction
decoder.
Reported-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc:... | ```diff
diff --git a/arch/x86/kernel/cpu/perf_event_intel_ds.c b/arch/x86/kernel/cpu/perf_event_intel_ds.c
index c0d238f49db8..73da6b64f5b7 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_ds.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c
@@ -493,6 +493,7 @@ static int intel_pmu_pebs_fixup_ip(struct pt_regs *regs)
... |
f1c6f1a7eed963ed233ba4c8b6fa8addb86c6ddc | Analyze and fix the following issue in the Linux kernel code: sched: Set the command name of the idle tasks in SMP kernels | Problem Details:
In UP systems, the idle task is initialized using the init_task
structure from which the command name is taken (currently "swapper").
In SMP systems, one idle task per CPU is forked by the worker thread
from which the task structure is copied. The command name is, therefore,
"kworker/0:0" or "kworker/... | ```diff
diff --git a/include/linux/init_task.h b/include/linux/init_task.h
index 08ffab01e76c..b6e5b8b000e0 100644
--- a/include/linux/init_task.h
+++ b/include/linux/init_task.h
@@ -126,6 +126,8 @@ extern struct cred init_cred;
# define INIT_PERF_EVENTS(tsk)
#endif
+#define INIT_TASK_COMM "swapper"
+
/*
* INIT... |
4a6184ce7a48c478dee0d8a9ed74c1fa35161858 | Analyze and fix the following issue in the Linux kernel code: sched, rt: Provide means of disabling cross-cpu bandwidth sharing | Problem Details:
Normally the RT bandwidth scheme will share bandwidth across the
entire root_domain. However sometimes its convenient to disable this
sharing for debug purposes. Provide a simple feature switch to this
end.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.h... | ```diff
diff --git a/kernel/sched_features.h b/kernel/sched_features.h
index efa0a7b75dde..84802245abd2 100644
--- a/kernel/sched_features.h
+++ b/kernel/sched_features.h
@@ -67,3 +67,4 @@ SCHED_FEAT(NONTASK_POWER, 1)
SCHED_FEAT(TTWU_QUEUE, 1)
SCHED_FEAT(FORCE_SD_OVERLAP, 0)
+SCHED_FEAT(RT_RUNTIME_SHARE, 1)
diff --... |
461819ac8ee950ce027c72a066156a3df9e60c7e | Analyze and fix the following issue in the Linux kernel code: sched_fair: Fix a typo in the comment describing update_sd_lb_stats | Problem Details:
Signed-off-by: Hui Kang <hkang.sunysb@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1318388459-4427-1-git-send-email-hkang.sunysb@gmail.com
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index aba20f495188..7e51b5bb27cc 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -3588,7 +3588,7 @@ static bool update_sd_pick_busiest(struct sched_domain *sd,
}
/**
- * update_sd_lb_stats - Update sched_group's statistics for load balanci... |
f6bf1a8acd2cb3a92a7b7c9ab03e56a32ac5ece5 | Analyze and fix the following issue in the Linux kernel code: [S390] topology: fix topology on z10 machines | Problem Details:
Make sure that all cpus in a book on a z10 appear as book siblings
and not as core siblings. This fixes some performance regressions that
appeared after the book scheduling domain got introduced.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@d... | ```diff
diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c
index 77b8942b9a15..fdb5b8cb260f 100644
--- a/arch/s390/kernel/topology.c
+++ b/arch/s390/kernel/topology.c
@@ -68,8 +68,10 @@ static cpumask_t cpu_group_map(struct mask_info *info, unsigned int cpu)
return mask;
}
-static void add_cpus... |
09b538833b85521d937a06faf61e6a3273253cc0 | Analyze and fix the following issue in the Linux kernel code: [S390] fix pgste update logic | Problem Details:
The pgste_update_all / pgste_update_young and pgste_set_pte need to
check if the pte entry contains a valid page address before the storage
key can be accessed. In addition pgste_set_pte needs to set the access
key and fetch protection bit of the new pte entry, not the old entry.
Signed-off-by: Martin... | ```diff
diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
index 34ede0ea85a9..524d23b8610c 100644
--- a/arch/s390/include/asm/pgtable.h
+++ b/arch/s390/include/asm/pgtable.h
@@ -593,6 +593,8 @@ static inline pgste_t pgste_update_all(pte_t *ptep, pgste_t pgste)
unsigned long address, bits;... |
f6252114cbb7edabc1c92bf794153922ee0ea46d | Analyze and fix the following issue in the Linux kernel code: vgaarb: a NULL bridge is acceptable for root devices. | Problem Details:
I assumed all PCI buses had a bridge, but playing with qemu recently, I
discovered vgaarb bug where it wasn't detecting both devices shared a bridge
at the root level.
Don't check for NULL, if two buses have a NULL bridge, assume they share the
root bus.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.o... | ```diff
diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
index c72f1c0b5e63..bdde899af72e 100644
--- a/drivers/gpu/vga/vgaarb.c
+++ b/drivers/gpu/vga/vgaarb.c
@@ -465,31 +465,29 @@ static void vga_arbiter_check_bridge_sharing(struct vga_device *vgadev)
while (new_bus) {
new_bridge = new_bus->self;
... |
905905432868fa513f0f783fb9e5724536f4ee1f | Analyze and fix the following issue in the Linux kernel code: blackfin: Fixup export.h includes | Problem Details:
Commit 8dc7a9c84 ("blackfin: Add export.h to files using
EXPORT_SYMBOL/THIS_MODULE") inserted some of the include statements into
sections protected by an unrelated #if CONFIG_... statement. This can cause,
depending on the configuration used, warnings like this one:
arch/blackfin/mach-bf537/boards/s... | ```diff
diff --git a/arch/blackfin/mach-bf527/boards/cm_bf527.c b/arch/blackfin/mach-bf527/boards/cm_bf527.c
index c13065b895f2..cd289698b4dd 100644
--- a/arch/blackfin/mach-bf527/boards/cm_bf527.c
+++ b/arch/blackfin/mach-bf527/boards/cm_bf527.c
@@ -8,6 +8,7 @@
*/
#include <linux/device.h>
+#include <linux/export... |
c3e072f8a6c5625028531c40ec65f7e301531be2 | Analyze and fix the following issue in the Linux kernel code: net: fsl_pq_mdio: fix non tbi phy access | Problem Details:
Since 952c5ca1 (fsl_pq_mdio: Clean up tbi address configuration) .probe returns
-EBUSY when the "tbi-phy" node is missing. Fix this.
Cc: Andy Fleming <afleming@freescale.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index 4d9f84b8ab97..8dee1aed47e4 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -356,16 +356,16 @@ static int fsl_pq_mdio_probe(struct platfor... |
6d74eb9442fb113c97edc88a1c658462db711337 | Analyze and fix the following issue in the Linux kernel code: net/usb: Misc. fixes for the LG-VL600 LTE USB modem | Problem Details:
Add checking for valid magic values (needed for stability in the event
corrupted packets are received) and remove some other unneeded checks.
Also, fix flagging device as WWAN (Bugzilla bug #39952).
Signed-off-by: Mark Kamichoff <prox@prolixium.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index c924ea2bce07..99ed6eb4dfaf 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -567,7 +567,7 @@ static const struct usb_device_id products [] = {
{
USB_DEVICE_AND_INTERFACE_INFO(0x1004, 0x61aa, USB_CLASS_CO... |
ef5e0d8237287db3a12d84f08fb2483d7a30a943 | Analyze and fix the following issue in the Linux kernel code: bridge: Fix potential deadlock on br->multicast_lock | Problem Details:
multicast_lock is taken in softirq context, so we should use
spin_lock_bh() in userspace.
call-chain in softirq context:
run_timer_softirq()
br_multicast_query_expired()
call-chain in userspace:
sysfs_write_file()
store_multicast_snooping()
br_multicast_toggle()
Signed-off-by: Andrew Vagin <avag... | ```diff
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 995cbe0ac0b2..2eefe275b338 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1770,7 +1770,7 @@ int br_multicast_toggle(struct net_bridge *br, unsigned long val)
int err = 0;
struct net_bridge_mdb_htable *mdb;
... |
22f4cb4bd06db14912f69039917422fe0c5b11fb | Analyze and fix the following issue in the Linux kernel code: ARM: mmp: fix build error on gpio | Problem Details:
Parameters of GPIO_REG() should be assigned as volatile.
arch/arm/plat-pxa/include/plat/gpio.h: In function ‘gpio_get_value’:
arch/arm/plat-pxa/include/plat/gpio.h:12:21: error: invalid operands to
binary & (have ‘void *’ and ‘int’)
arch/arm/plat-pxa/include/plat/gpio.h: In function ‘gpio_set_value’:
... | ```diff
diff --git a/arch/arm/mach-mmp/include/mach/gpio-pxa.h b/arch/arm/mach-mmp/include/mach/gpio-pxa.h
index d14eeaf16322..99b4ce1b6562 100644
--- a/arch/arm/mach-mmp/include/mach/gpio-pxa.h
+++ b/arch/arm/mach-mmp/include/mach/gpio-pxa.h
@@ -7,7 +7,7 @@
#define GPIO_REGS_VIRT (APB_VIRT_BASE + 0x19000)
#define ... |
731abb9cb27aef6013ce60808a04e04a545f3f4e | Analyze and fix the following issue in the Linux kernel code: ip6_tunnel: copy parms.name after register_netdevice | Problem Details:
Commit 1c5cae815d removed an explicit call to dev_alloc_name in ip6_tnl_create
because register_netdevice will now create a valid name. This works for the
net_device itself.
However the tunnel keeps a copy of the name in the parms structure for the
ip6_tnl associated with the tunnel. parms.name is s... | ```diff
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index bdc15c9003d7..4e2e9ff67ef2 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -289,6 +289,8 @@ static struct ip6_tnl *ip6_tnl_create(struct net *net, struct ip6_tnl_parm *p)
if ((err = register_netdevice(dev)) < 0)
goto failed_... |
4d039f684314b707fdae3c7262faf4a80c548194 | Analyze and fix the following issue in the Linux kernel code: 6LoWPAN: set proper netdev flags | Problem Details:
This patch fixes settings for device initialization which makes possible to
use NDISC and TCP.
Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index af5553eb1283..39ec6e018227 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -973,13 +973,12 @@ static void lowpan_setup(struct net_device *dev)
dev->addr_len = IEEE802154_ADDR_LEN;
memset(dev->broadcast, 0xff, IEE... |
e86586ba8c570591372bc6cd0435a9bc1364c6d5 | Analyze and fix the following issue in the Linux kernel code: 6LoWPAN: disable debugging by default | Problem Details:
This patch disables debug output enabled by default.
Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index 7d4cb58bbddc..af5553eb1283 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -50,8 +50,6 @@
* SUCH DAMAGE.
*/
-#define DEBUG
-
#include <linux/bitops.h>
#include <linux/if_arp.h>
#include <linux/module.h>
``` |
898bdf2cb43eb0a962c397eb4dd1aec2c7211be2 | Analyze and fix the following issue in the Linux kernel code: forcedeth: fix stats on hardware without extended stats support | Problem Details:
This change makes sure that tx_packets/rx_bytes ifconfig counters are
updated even on NICs that don't provide hardware support for these
stats: they are now updated in software. For the sake of consistency,
we also now have tx_bytes updated in software (hardware counters
include ethernet CRC, and softw... | ```diff
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 1dca57013cb2..1c61d36e6570 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -609,7 +609,7 @@ struct nv_ethtool_str {
};
static const struct nv_ethtool_str... |
3ed90f766dab55fc9d49638a02704becaec379ae | Analyze and fix the following issue in the Linux kernel code: net/packet: remove dead code and unneeded variable from prb_setup_retire_blk_timer() | Problem Details:
We test for 'tx_ring' being != zero and BUG() if that's the case. So after
that check there is no way that 'tx_ring' could be anything _but_ zero, so
testing it again is just dead code. Once that dead code is removed, the
'pkc' local variable becomes entirely redundant, so remove that as well.
Signed-... | ```diff
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 82a6f34d39d0..ab10e84eda3a 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -516,13 +516,11 @@ static void prb_init_blk_timer(struct packet_sock *po,
static void prb_setup_retire_blk_timer(struct packet_sock *po, int tx_rin... |
72103bd1285211440621f2c46f4fce377584de54 | Analyze and fix the following issue in the Linux kernel code: virtio-pci: fix use after free | Problem Details:
Commit 31a3ddda166cda86d2b5111e09ba4bda5239fae6 introduced
a use after free in virtio-pci. The main issue is
that the release method signals removal of the virtio device,
while remove signals removal of the pci device.
For example, on driver removal or hot-unplug,
virtio_pci_release_dev is called befo... | ```diff
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 79a31e5b4b68..3d1bf41e8892 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -594,11 +594,11 @@ static struct virtio_config_ops virtio_pci_config_ops = {
static void virtio_pci_release_dev(struct device *... |
92094aa0946a0e64ef5dd810ccc829fb6aae93c6 | Analyze and fix the following issue in the Linux kernel code: MAINTAINERS: update ipwireless entry | Problem Details:
Drop the git tree from MAINTAINERS for ipwireless_cs, as there
is no active development on this driver happening. Also change
the driver from Maintained to Odd Fixes for the same reason.
Cc: David Sterba <dsterba@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz> | ```diff
diff --git a/MAINTAINERS b/MAINTAINERS
index 071a99674347..14b8688e7842 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3582,8 +3582,7 @@ F: net/netfilter/ipvs/
IPWIRELESS DRIVER
M: Jiri Kosina <jkosina@suse.cz>
M: David Sterba <dsterba@suse.cz>
-S: Maintained
-T: git git://git.kernel.org/pub/scm/linux/kernel... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.