id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
7ccc83b0fc69d5b18602aa250c10be0d3ae920c6 | Analyze and fix the following issue in the Linux kernel code: carl9170: fix timekeeping for HW_COUNTER firmwares | Problem Details:
AR9170_PWR_REG_PLL_ADDAC is used to set the main clock
divisor which affects the AHB/CPU speed. Because this
would interfere with the firmware internal timekeeping,
the function has to be moved into the firmware.
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linvi... | ```diff
diff --git a/drivers/net/wireless/ath/carl9170/carl9170.h b/drivers/net/wireless/ath/carl9170/carl9170.h
index c5427a72a1e2..f7dbdaa74c63 100644
--- a/drivers/net/wireless/ath/carl9170/carl9170.h
+++ b/drivers/net/wireless/ath/carl9170/carl9170.h
@@ -282,6 +282,7 @@ struct ar9170 {
bool rx_stream;
bool tx... |
0cc9772a6bd8002aaf7583194098e92481d9c7f1 | Analyze and fix the following issue in the Linux kernel code: b43: fix DMA on some bugged hardware | Problem Details:
Some hardware with 64-bit DMA uses lower address word for setting
routing (translation) bit. Add workaround for such boards.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/b43/b43.h b/drivers/net/wireless/b43/b43.h
index f4e9d8b7d9f8..9e5974bf2655 100644
--- a/drivers/net/wireless/b43/b43.h
+++ b/drivers/net/wireless/b43/b43.h
@@ -594,6 +594,7 @@ struct b43_dma {
struct b43_dmaring *rx_ring;
u32 translation; /* Routing bits */
+ bool transl... |
04023afcce2eaff4f66d19ca21b106512fffabe7 | Analyze and fix the following issue in the Linux kernel code: ssb: fix DMA translation for some specific boards | Problem Details:
Signed-off-by: Michael Buesch <m@bues.ch>
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 29c7d4f9d1ae..d0cbdb0cf9d5 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1260,16 +1260,34 @@ void ssb_device_disable(struct ssb_device *dev, u32 core_specific_flags)
}
EXPORT_SYMBOL(ssb_device_disable);
+/* Some chipsets need routing ... |
e338a85e21d89574a0160fef7a89f42960cc5d7f | Analyze and fix the following issue in the Linux kernel code: ath9k: Fix invalid noisefloor reading due to channel update | Problem Details:
While switching b/w HT20/40, the current channel's nf values
are updated into history buffer. Since the current channel's
channel type, channel flag got updated before reading
nf value from hw. This channel type mismatch is causing invalid
readings when hw is on ht20 but getnf tries to read on extn cha... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 2af4a1c2e2d6..113c1df26b36 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1672,6 +1672,7 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
if (c... |
6b3d348681a153b8e4a16ba1a6f792711e389a9e | Analyze and fix the following issue in the Linux kernel code: ath9k: Fix noisefloor history update for extn chains | Problem Details:
Before doing hw reset the current channel's noisefloor readings
are updated into history buffer. The extension chain's readings
are considered only if the current channel was configured in HT40.
While moving from HT40 to HT20, the extn chain's readings are
skipped though the current channel is in ht40.... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c
index ac2da3cce788..ebaf304f464b 100644
--- a/drivers/net/wireless/ath/ath9k/calib.c
+++ b/drivers/net/wireless/ath/ath9k/calib.c
@@ -82,7 +82,6 @@ static void ath9k_hw_update_nfcal_hist_buffer(struct ath_hw *ah,
... |
0682c9b52bf51fbc67c4e79fcbdadcf70bd600f8 | Analyze and fix the following issue in the Linux kernel code: ath9k: Fix rx overrun interrupt storm | Problem Details:
Whenever RXEOL is received, both RXORN and RXEOL got cleared
to avoid rx overrun interrupt storm. This was handled only for
edma chips. The same scenario was also observered with AR9280,
doing frequent channel type switch b/w HT20/40 with bidi traffic
that is causing failure to stop rx dma. This patch ... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 781af25f440d..3c5db3063877 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -826,11 +826,9 @@ irqreturn_t ath_isr(int irq, void *dev)
if (status & ATH9K_INT_TXURN)
... |
7a12dfdbf508fed2cbd1a9142c6e19341a55527b | Analyze and fix the following issue in the Linux kernel code: ath9k_hw: Fix exceed transmission burst-time of 5GHz | Problem Details:
The WAR which adds extra delimiters when using RTS/CTS
with aggregation and non-enterprise AR9003 chips.
This extra padding is done after doing all the 4ms limit
checks and hence the total aggregate sizes are exceeding
the allowed duration. This patch limits the aggregate
sizes appropriately after incl... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mac.c b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
index 1aadc4757e67..81ccce1faff5 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_mac.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
@@ -415,36 +415,12 @@ static void ar9003_hw_set11n_ratescenario(struc... |
699403dbd41998a56d1d92d612ac261e5085a99f | Analyze and fix the following issue in the Linux kernel code: {nl,mac}80211: add missing root mode meshconf entries | Problem Details:
This fix allows userspace to mark a meshif as a root node.
Signed-off-by: Javier Cardona <javier@cozybit.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c
index 9ea7c0d0103f..75ece3d3b6dd 100644
--- a/net/mac80211/debugfs_netdev.c
+++ b/net/mac80211/debugfs_netdev.c
@@ -485,7 +485,7 @@ static void add_mesh_config(struct ieee80211_sub_if_data *sdata)
MESHPARAMS_ADD(dot11MeshHWMPmaxPREQret... |
5ee68e5b39de5cefecf147c58711f8ab01c21231 | Analyze and fix the following issue in the Linux kernel code: mac80211: mesh gate implementation | Problem Details:
In this implementation, a mesh gate is a root node with a certain bit
set in its RANN flags. The mpath to this root node is marked as a path
to a gate, and added to our list of known gates for this if_mesh. Once a
path discovery process fails, we forward the unresolved frames to a
known gate. Thanks to... | ```diff
diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index 03cfbf393a63..37f95f2e10f9 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -633,6 +633,10 @@ struct ieee80211_rann_ie {
u32 rann_metric;
} __attribute__ ((packed));
+enum ieee80211_rann_flags {
+ RANN_FLAG_IS... |
00e3f25c8556384bfec2a168c41e885fa6a7748c | Analyze and fix the following issue in the Linux kernel code: mac80211: fix mesh path flushing | Problem Details:
Previously, mpaths were never flushed since the mpath is not active once
we call this function.
Signed-off-by: Javier Cardona <javier@cozybit.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c
index 385f9fc526db..bcf7fee53b2c 100644
--- a/net/mac80211/mesh_pathtbl.c
+++ b/net/mac80211/mesh_pathtbl.c
@@ -735,8 +735,7 @@ void mesh_path_flush_pending(struct mesh_path *mpath)
{
struct sk_buff *skb;
- while ((skb = skb_dequeue(&mp... |
a6965c44e981214c7483e020106a30a869411231 | Analyze and fix the following issue in the Linux kernel code: mac80211: mesh locking fixes | Problem Details:
mesh_queue_preq is invoked invoked from both user (work queue) and
softirq (timer) context, so the _bh version of spinlock needs to be
used. Also, the mpath->state_lock should be softirq safe as well.
Signed-off-by: Javier Cardona <javier@cozybit.com>
Signed-off-by: John W. Linville <linville@tuxdrive... | ```diff
diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c
index bfd7638e235f..385f9fc526db 100644
--- a/net/mac80211/mesh_pathtbl.c
+++ b/net/mac80211/mesh_pathtbl.c
@@ -654,12 +654,12 @@ int mesh_path_del(u8 *addr, struct ieee80211_sub_if_data *sdata)
mpath = node->mpath;
if (mpath->sdata ==... |
86d7f9f35dcc686d57465798201e678040916979 | Analyze and fix the following issue in the Linux kernel code: mac80211: fix mpath timer NULL function | Problem Details:
If we have an mpath whose timer has not been initialized, don't try to
delete it.
Signed-off-by: Javier Cardona <javier@cozybit.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c
index bd6b8b3e873a..bfd7638e235f 100644
--- a/net/mac80211/mesh_pathtbl.c
+++ b/net/mac80211/mesh_pathtbl.c
@@ -619,7 +619,8 @@ static void mesh_path_node_reclaim(struct rcu_head *rp)
struct mpath_node *node = container_of(rp, struct mpath... |
8b2a3827bb12430d932cd479b22d906baf08c212 | Analyze and fix the following issue in the Linux kernel code: ath9k: Fix PS wrappers in ath9k_set_coverage_class | Problem Details:
this callback is called during suspend/resume and also via iw command.
it configures parameters like sifs, slottime, acktimeout in
ath9k_hw_init_global_settings where few REG_READ, REG_RMW are also done
and hence the need for PS wrappers
Cc: stable@kernel.org
Signed-off-by: Mohammed Shafi Shajakhan <m... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 9098aaad97a9..6530694a59ae 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -2283,7 +2283,11 @@ static void ath9k_set_coverage_class(struct ieee80211_hw *hw, u8 cover... |
66cb54bd24086b2d871a03035de9b0e79b2b725e | Analyze and fix the following issue in the Linux kernel code: carl9170: Fix mismatch in carl9170_op_set_key mutex lock-unlock | Problem Details:
If is_main_vif(ar, vif) reports that we have to fall back
to software encryption, we goto err_softw; before locking ar->mutex.
As a result, we have unprotected call to carl9170_set_operating_mode
and unmatched mutex_unlock.
The patch fix the issue by adding mutex_lock before goto.
Found by Linux Driv... | ```diff
diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
index 0122930b14c7..0474e6638d21 100644
--- a/drivers/net/wireless/ath/carl9170/main.c
+++ b/drivers/net/wireless/ath/carl9170/main.c
@@ -1066,8 +1066,10 @@ static int carl9170_op_set_key(struct ieee80211_hw *hw, en... |
f1c39625d63c9f8eba8f036429c10a9cb9e32920 | Analyze and fix the following issue in the Linux kernel code: xen: use non-tracing preempt in xen_clocksource_read() | Problem Details:
The tracing code used sched_clock() to get tracing timestamps, which
ends up calling xen_clocksource_read(). xen_clocksource_read() must
disable preemption, but if preemption tracing is enabled, this results
in infinite recursion.
I've only noticed this when boot-time tracing tests are enabled, but i... | ```diff
diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index 5158c505bef9..163b4679556e 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -168,9 +168,10 @@ cycle_t xen_clocksource_read(void)
struct pvclock_vcpu_time_info *src;
cycle_t ret;
- src = &get_cpu_var(xen_vcpu)->time;
+ preempt... |
a9b36153a4f75c2977271578df8a82715e803c17 | Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Remove ALC662 ASUS eeepc-ep20 model quirk | Problem Details:
Since the recent fixes, this device works with the auto-parser well.
Let's kill it.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/Documentation/sound/alsa/HD-Audio-Models.txt b/Documentation/sound/alsa/HD-Audio-Models.txt
index 708543699f7e..8bd5034c9a48 100644
--- a/Documentation/sound/alsa/HD-Audio-Models.txt
+++ b/Documentation/sound/alsa/HD-Audio-Models.txt
@@ -71,7 +71,6 @@ ALC662/663/272
3stack-6ch 3-stack (6-channe... |
9c4e84d3b8cbcde88947ceff265e11d38ab127b9 | Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Fix Center/LFE mixer element creations for Realtek | Problem Details:
The commit 23c09b00900c3fa6672148738cad29d6fc6ded7c
ALSA: hda - Support multiple speakers by Realtek auto-parser
changes the return value from alc_get_line_out_pfx(), and it breaks
the center/LFE mixer split check. The caller must test with a string
"CLFE" now.
Signed-off-by: Takashi Iwai <tiwai@... | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 50fd55097488..de63619decdb 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -3014,7 +3014,7 @@ static int alc_auto_create_multi_out_ctls(struct hda_codec *codec,
sw = alc_look_for_out_mute_nid(co... |
81d66c70b546e7be5d7e1f1ca9676fd17c5973af | Analyze and fix the following issue in the Linux kernel code: mm/vmscan.c: fix a typo in a comment "relaimed" to "reclaimed" | Problem Details:
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz> | ```diff
diff --git a/mm/vmscan.c b/mm/vmscan.c
index febbc044e792..8e32698fab66 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1417,7 +1417,7 @@ static inline bool should_reclaim_stall(unsigned long nr_taken,
if (sc->reclaim_mode & RECLAIM_MODE_SINGLE)
return false;
- /* If we have relaimed everything on the iso... |
e92d4b08d756e11f89a5d7e7d45a3ab9387bd25a | Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Rewrite Lenovo X200 quirk with pincfg-fix using auto-parser | Problem Details:
Introduce the pincfg table to patch_conexant.c for fixing up the extra
pin-configuration for auto-parser. As an example, Lenovo X200 model is
replaced with this new mechanism. (This also fixes the wrong mixer
elements for docking-station I/O in the previous model quirk
automagically.)
Signed-off-by:... | ```diff
diff --git a/Documentation/sound/alsa/HD-Audio-Models.txt b/Documentation/sound/alsa/HD-Audio-Models.txt
index 57e80eb78d72..708543699f7e 100644
--- a/Documentation/sound/alsa/HD-Audio-Models.txt
+++ b/Documentation/sound/alsa/HD-Audio-Models.txt
@@ -237,7 +237,6 @@ Conexant 5051
hp-dv6736 HP dv6736
hp-f7... |
a63271627521b825b0dd0a564e9a9c62b4c1ca89 | Analyze and fix the following issue in the Linux kernel code: block: change force plug flush call order | Problem Details:
Do blk_flush_plug_list() first and then add new request aDo blk_flush_plug_list() first and then add new request aDo blk_flush_plug_list() first and then add new request at the tail. New
request can't be merged to existing requests, but later new requests might
be merged with this new one. If blk_flush... | ```diff
diff --git a/block/blk-core.c b/block/blk-core.c
index 90e1ffdeb415..67dba6941194 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1302,11 +1302,11 @@ get_rq:
if (__rq->q != q)
plug->should_sort = 1;
}
- list_add_tail(&req->queuelist, &plug->list);
- plug->count++;
- drive_stat_acct(req, ... |
c0764b2a4cdc41779460eb8796bc76e4fbddf339 | Analyze and fix the following issue in the Linux kernel code: at91: at91sam9261.c: fix typo in t2_clk alias for atmel_tcb.0 | Problem Details:
This was a typo in clockdev declaration for at91sam9261 SoC.
Fix the kernel hanging when switching clocksource to TC (tcb_clksrc).
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Acked-by: Remy Bohmer <linux@bohmer.net>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> | ```diff
diff --git a/arch/arm/mach-at91/at91sam9261.c b/arch/arm/mach-at91/at91sam9261.c
index d522b47e30b5..6c8e3b5f669f 100644
--- a/arch/arm/mach-at91/at91sam9261.c
+++ b/arch/arm/mach-at91/at91sam9261.c
@@ -157,7 +157,7 @@ static struct clk_lookup periph_clocks_lookups[] = {
CLKDEV_CON_DEV_ID("spi_clk", "atmel_sp... |
def76608681983c1fe70c0fa780d8fe777442ef5 | Analyze and fix the following issue in the Linux kernel code: udlfb: fix issues found with Sparse static analysis | Problem Details:
Add __user casting, a missing copy_from_user, and proper boolean
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> | ```diff
diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
index 0b77af7bdf1b..37498abcd917 100644
--- a/drivers/video/udlfb.c
+++ b/drivers/video/udlfb.c
@@ -776,14 +776,13 @@ static int dlfb_ops_ioctl(struct fb_info *info, unsigned int cmd,
{
struct dlfb_data *dev = info->par;
- struct dloarea *area = NU... |
58e7c3b00114c48e0879e9fbafd37e0e0c2402cb | Analyze and fix the following issue in the Linux kernel code: udlfb: add more comprehensive support for DPMS FB_BLANK_* modes | Problem Details:
Fixes earlier problems where monitor would not return from blank
Test with any DisplayLink-based USB 2.0 graphics adapter
sudo nano /sys/class/graphics/fb?/blank
and write out single digit FB_BLANK_* code from include/linux/fb.h
Supports on (0), blank (1), suspend (2,3), powerdown (4)
Signed-off-by:... | ```diff
diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
index 087fc9960bb9..fecd2d3543bd 100644
--- a/drivers/video/udlfb.c
+++ b/drivers/video/udlfb.c
@@ -94,17 +94,39 @@ static char *dlfb_vidreg_unlock(char *buf)
}
/*
- * On/Off for driving the DisplayLink framebuffer to the display
- * 0x00 H and V s... |
983929cafc4225d61f50b3e35cf892606a15bc69 | Analyze and fix the following issue in the Linux kernel code: ALSA: core: trivial code style fix | Problem Details:
remove trailing tab on the line.
Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/core/control.c b/sound/core/control.c
index f8c5be464510..7f2b3a7eabb2 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1072,7 +1072,7 @@ static int snd_ctl_elem_add(struct snd_ctl_file *file,
long private_size;
struct user_element *ue;
int idx, err;
-
+
if (card->use... |
c2183d1e9b3f313dd8ba2b1b0197c8d9fb86a7ae | Analyze and fix the following issue in the Linux kernel code: fuse: check size of FUSE_NOTIFY_INVAL_ENTRY message | Problem Details:
FUSE_NOTIFY_INVAL_ENTRY didn't check the length of the write so the
message processing could overrun and result in a "kernel BUG at
fs/fuse/dev.c:629!"
Reported-by: Han-Wen Nienhuys <hanwenn@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@kernel.org | ```diff
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 640fc229df10..168a80f7f12b 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -1358,6 +1358,10 @@ static int fuse_notify_inval_entry(struct fuse_conn *fc, unsigned int size,
if (outarg.namelen > FUSE_NAME_MAX)
goto err;
+ err = -EINVAL;
+ if (size != sizeof... |
058b96d445a05eac71be5e6b5b5db34412b4b175 | Analyze and fix the following issue in the Linux kernel code: ARM: 7063/1: Orion: gpio: add missing include of linux/types.h | Problem Details:
This patch adds missing include of linux/types.h to fix below build error.
CC arch/arm/mach-mv78xx0/mpp.o
In file included from arch/arm/mach-mv78xx0/include/mach/gpio.h:9,
from /home/axel/repos/git/linux-2.6/arch/arm/include/asm/gpio.h:5,
from include/linux/gp... | ```diff
diff --git a/arch/arm/plat-orion/include/plat/gpio.h b/arch/arm/plat-orion/include/plat/gpio.h
index f7d76308603f..3abf30428bee 100644
--- a/arch/arm/plat-orion/include/plat/gpio.h
+++ b/arch/arm/plat-orion/include/plat/gpio.h
@@ -12,6 +12,7 @@
#define __PLAT_GPIO_H
#include <linux/init.h>
+#include <linux/... |
5f9d4f67beb603b0efcb0360897f99cf775e7a74 | Analyze and fix the following issue in the Linux kernel code: ARM: 7055/1: arm/tegra: mach/gpio.h: include linux/types.h to fix build | Problem Details:
Tegra's <mach/gpio.h> uses type bool; we need to include <linux/types.h>
to get the definition.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
index 284a19e12d74..7910d26e7133 100644
--- a/arch/arm/mach-tegra/include/mach/gpio.h
+++ b/arch/arm/mach-tegra/include/mach/gpio.h
@@ -20,7 +20,7 @@
#ifndef __MACH_TEGRA_GPIO_H
#define __MACH_TEGRA_GPIO_H
-#inclu... |
ece88dc08b87501025927bf52e460655f89e2c02 | Analyze and fix the following issue in the Linux kernel code: ARM: 7054/1: arm/tegra: Delete custom gpio_to_irq, and irq_to_gpio | Problem Details:
By not definining a custom gpio_to_irq, the default gpiolib version is
used, allowing platform consolidation.
irq_to_gpio is deprecated and in the process of being removed. Make that
happen now for ARM Tegra.
This also partially fixes the Tegra build; it was broken because gpio.h
referred to EINVAL, ... | ```diff
diff --git a/arch/arm/mach-tegra/include/mach/gpio.h b/arch/arm/mach-tegra/include/mach/gpio.h
index e3538055f409..284a19e12d74 100644
--- a/arch/arm/mach-tegra/include/mach/gpio.h
+++ b/arch/arm/mach-tegra/include/mach/gpio.h
@@ -26,22 +26,6 @@
#define TEGRA_NR_GPIOS INT_GPIO_NR
#define TEGRA_GPIO_TO_IRQ(... |
e8037d49835482c9534a9a07bed0d0ea831135ae | Analyze and fix the following issue in the Linux kernel code: block: Fix queue_flag update when rq_affinity goes from 2 to 1 | Problem Details:
Commit 5757a6d76cdf added the QUEUE_FLAG_SAME_FORCE flag, but fails to
clear that flag when the current state is '2' (SAME_COMP + SAME_FORCE)
and the new state is '1' (SAME_COMP).
Acked-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Eric ... | ```diff
diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 0ee17b5e7fb6..e681805cdb47 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -258,11 +258,13 @@ queue_rq_affinity_store(struct request_queue *q, const char *page, size_t count)
ret = queue_var_store(&val, page, count);
spin_lock_irq(q->queue... |
2278a29d7a05a3fad9b07f3b84b14da8dd588031 | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Convert typedef rtl_fs_debug to struct rtl_fs_debug | Problem Details:
Remove typedef from struct.
Rename struct.
Rename uses.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> | ```diff
diff --git a/drivers/staging/rtl8192e/rtl_debug.h b/drivers/staging/rtl8192e/rtl_debug.h
index db8be0e3435a..1d4177ef1317 100644
--- a/drivers/staging/rtl8192e/rtl_debug.h
+++ b/drivers/staging/rtl8192e/rtl_debug.h
@@ -257,15 +257,14 @@ do { if (rt_global_debug_component & component) \
} ... |
ebbef649f97c1d92321bdd2dc91b9babc21b2b26 | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Convert typedef rtl_reg_debug to struct rtl_reg_debug | Problem Details:
Remove typedef from struct.
Rename struct.
Rename uses.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> | ```diff
diff --git a/drivers/staging/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl_core.h
index 720d1afffbb6..d6e2975e65f9 100644
--- a/drivers/staging/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl_core.h
@@ -352,7 +352,7 @@ typedef struct buffer
} buffer;
-typedef struct rtl_reg_debug{
+struct rtl_r... |
77cd72a53f6426f81b7f56a862402849ee903bda | Analyze and fix the following issue in the Linux kernel code: [SCSI] isci: fix event-get pointer increment | Problem Details:
Hardware only increments the put pointer on event types >= 4. Do not
increment the get pointer for event type 3.
Reported-by: Kapil Karkra <kapil.karkra@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com> | ```diff
diff --git a/drivers/scsi/isci/host.c b/drivers/scsi/isci/host.c
index 2328f98c7f1e..6981b773a88d 100644
--- a/drivers/scsi/isci/host.c
+++ b/drivers/scsi/isci/host.c
@@ -531,6 +531,9 @@ static void sci_controller_process_completions(struct isci_host *ihost)
break;
case SCU_COMPLETION_TYPE_EVENT:
+ s... |
bca54c0184b3b3913ee9660f01e42ccb40abdac4 | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Fix compilation warnings | Problem Details:
When the driver is compiled, the following messages result:
CC [M] drivers/staging/rtl8192e/r8192E_phy.o
drivers/staging/rtl8192e/r8192E_phy.c: In function ‘rtl8192_phy_ConfigRFWithHeaderFile’:
drivers/staging/rtl8192e/r8192E_phy.c:791:25: warning: array subscript is above array bounds
drivers/stag... | ```diff
diff --git a/drivers/staging/rtl8192e/r8192E_hwimg.h b/drivers/staging/rtl8192e/r8192E_hwimg.h
index 061a9c34ac89..019836bb36c2 100644
--- a/drivers/staging/rtl8192e/r8192E_hwimg.h
+++ b/drivers/staging/rtl8192e/r8192E_hwimg.h
@@ -37,9 +37,9 @@ extern u32 Rtl8192PciEPHY_REG_1T2RArray[PHY_REG_1T2RArrayLengthPciE... |
ee33e2b771f9e9e4aaba2bb2ace7b727fe451a8b | Analyze and fix the following issue in the Linux kernel code: [SCSI] isci: fix 32-bit operation when CONFIG_HIGHMEM64G=n | Problem Details:
The unsolicited frame control infrastructure requires a table of dma
addresses for the hardware to lookup the frame buffer location by an
index. The hardware expects the elements of this table to be 64-bit
quantities, so we cannot reference these elements as dma_addr_t. All
unsolicited frame protocol... | ```diff
diff --git a/drivers/scsi/isci/unsolicited_frame_control.c b/drivers/scsi/isci/unsolicited_frame_control.c
index e9e1e2abacb9..16f88ab939c8 100644
--- a/drivers/scsi/isci/unsolicited_frame_control.c
+++ b/drivers/scsi/isci/unsolicited_frame_control.c
@@ -72,7 +72,7 @@ int sci_unsolicited_frame_control_construct... |
66898177e7e5486dc77a4ba742efa4e2e9e900a4 | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Fix unload/reload problem | Problem Details:
The driver is not releasing the memory region that was mapped. As a result,
the driver cannot be unloaded and reloaded.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> | ```diff
diff --git a/drivers/staging/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl_core.c
index f8040acb91d1..f8a13d95985b 100644
--- a/drivers/staging/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl_core.c
@@ -3122,6 +3122,11 @@ static void __devexit rtl8192_pci_disconnect(struct pci_dev *pdev)
if (priv... |
1a878284473284f9577d44babf16d87152a05c33 | Analyze and fix the following issue in the Linux kernel code: [SCSI] isci: fix sata response handling | Problem Details:
A bug (likely copy/paste) that has been carried from the original
implementation. The unsolicited frame handling structure returns the
d2h fis in the isci_request.stp.rsp buffer.
Cc: <stable@kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@... | ```diff
diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
index a46e07ac789f..b4cf998385b3 100644
--- a/drivers/scsi/isci/request.c
+++ b/drivers/scsi/isci/request.c
@@ -2399,22 +2399,19 @@ static void isci_task_save_for_upper_layer_completion(
}
}
-static void isci_request_process_stp_respons... |
8cc638e95bcef31d5f8896bbe5ca06fd52fa7947 | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Remove ifdefs for CONFIG_RTLLIB_DEBUG | Problem Details:
This symbol is unconditionally defined in a header file, thus tests for it can be removed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> | ```diff
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 352ee474bbfa..d1c35503879f 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -670,8 +670,6 @@ typedef enum _NETWORK_TYPE{
#define OUI_SUBTYPE_QOS_CAPABI 5
/* debug macros */
-#def... |
9ab2da30490c095834332aeb3c0a01d1f1ed0fb9 | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Remove dead code associated with RTL819x_DEBUG | Problem Details:
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> | ```diff
diff --git a/drivers/staging/rtl8192e/rtl_debug.h b/drivers/staging/rtl8192e/rtl_debug.h
index 511d96c9141b..2e23bf65a8d7 100644
--- a/drivers/staging/rtl8192e/rtl_debug.h
+++ b/drivers/staging/rtl8192e/rtl_debug.h
@@ -237,8 +237,6 @@ do { if (rt_global_debug_component & component) \
##args);\
}while(... |
438af18e9278157a94b4f1ecb50cf9aa9437ebc2 | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Remove dead code associated with ENABLE_NULL_PT_DEBUG | Problem Details:
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> | ```diff
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 4ecfe5f0e083..352ee474bbfa 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -454,27 +454,8 @@ typedef enum _RT_OP_MODE{
#define IEEE_CRYPT_ALG_NAME_LEN 16
#define MAX_IE_LEN 0... |
82a7fc6d4cde3584c8c637d2482994853b44243d | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Fix kernel panics due to RX skb allocation failures | Problem Details:
This driver uses RX skb's of O(2), thus it is possible for memory fragmentation
to prevent the allocation of a new one to replace a newly-received buffer.
When such a failure occurs, the kernel panics.
The fix is to drop an incoming packet whenever such an allocation fails. This
fix matches the one do... | ```diff
diff --git a/drivers/staging/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl_core.c
index d8504e4d941b..49f787e05503 100644
--- a/drivers/staging/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl_core.c
@@ -2550,12 +2550,18 @@ void rtl8192_rx_normal(struct net_device *dev)
rx_desc *pdesc = &priv->rx_... |
b1d5ee7004c85558f3e8330235db2d7b4f7a6a3e | Analyze and fix the following issue in the Linux kernel code: staging: rtl8192e: Fix edit error in removal of dead code associated with RTL8190P | Problem Details:
One too many lines were removed in an earlier patch. Rather than resubmit
as a V2, this line is added back here.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> | ```diff
diff --git a/drivers/staging/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/r8192E_dev.c
index 0e66d261bc74..9d13705ad4b4 100644
--- a/drivers/staging/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/r8192E_dev.c
@@ -1535,6 +1535,8 @@ void rtl8192_query_rxphystatus(
{
u8 report;
+
+ priv->stats.nu... |
2246698303be8ffb36fc19f4daff1052521e7ea1 | Analyze and fix the following issue in the Linux kernel code: rtl8192e: Remove unused debug code | Problem Details:
Signed-off-by: Mike McCormack <mikem@ring3k.org> | ```diff
diff --git a/drivers/staging/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl_core.c
index 240b59b2d543..38481a235182 100644
--- a/drivers/staging/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl_core.c
@@ -3188,17 +3188,7 @@ int rtl8192_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
}
... |
c8b7de7fce9cffe97e9d10dbda7b5476e2339d6f | Analyze and fix the following issue in the Linux kernel code: staging: et131x: Fix free IRQ from IRQ context warning after tx_timeout | Problem Details:
When a tx timeout occured, et131x_tx_timeout closed and re-opened the device to fix.
As et131x_close called free_irq(), bad things ensued (see warning trace below), namely a
storm of errors and warnings.
Fixed by replacing the close() and open() calls with just the relevant functions previously
called ... | ```diff
diff --git a/drivers/staging/et131x/et1310_phy.c b/drivers/staging/et131x/et1310_phy.c
index 2c6898f707be..c845c27f23db 100644
--- a/drivers/staging/et131x/et1310_phy.c
+++ b/drivers/staging/et131x/et1310_phy.c
@@ -732,7 +732,6 @@ void et131x_mii_check(struct et131x_adapter *adapter,
u32 mdi_mdix;
u32 maste... |
c922d1241ff37ab2db0f1a29e4b043fe1d8a8e8c | Analyze and fix the following issue in the Linux kernel code: staging: et131x: Fix link detection signalling | Problem Details:
Remove redundant code around netif_carrier_XXX calls, and associated adapter->media_state, which prevented the link from being reported as off.
Tested on an ET-1310 device.
Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/et131x/et1310_phy.c b/drivers/staging/et131x/et1310_phy.c
index 6eb9d5cb6432..2c6898f707be 100644
--- a/drivers/staging/et131x/et1310_phy.c
+++ b/drivers/staging/et131x/et1310_phy.c
@@ -737,16 +737,6 @@ void et131x_mii_check(struct et131x_adapter *adapter,
if (bmsr_ints & MI_BMSR_... |
dbbb24947e1bea5e6034ae2edfbf1be5b8f2b062 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: Fix macros, tab errors and warning in drivers/staging/hv/hv_mouse.c | Problem Details:
This is a patch to the hv_mouse.c file that fixed up macros, tab
errors and warning found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
index d957fc228019..9f3fbeeed8df 100644
--- a/drivers/staging/hv/hv_mouse.c
+++ b/drivers/staging/hv/hv_mouse.c
@@ -54,7 +54,7 @@ struct hv_input_dev_info {
(SYNTHHID_INPUT_VERSION_MAJOR << 16))
-#pragma pack(push,1)
+#pragma ... |
e54bbc6471d7f788d829e5f3b5922960048fbff7 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: util: kvp: Fix the reported OSVersion string | Problem Details:
The current win7 host does not like it when we return the
complete kernel release information. Conform to what the host
expects.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/tools/hv_kvp_daemon.c b/drivers/staging/hv/tools/hv_kvp_daemon.c
index 8fd0f2ba57b4..c4cf988ad5cb 100644
--- a/drivers/staging/hv/tools/hv_kvp_daemon.c
+++ b/drivers/staging/hv/tools/hv_kvp_daemon.c
@@ -118,6 +118,15 @@ void kvp_get_os_info(void)
os_build = uts_buf.release;
p... |
dec317fd6accfdba4daff13aa4d9f5abde02b347 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: vmbus: Fix checkpatch warnings | Problem Details:
Fix checkpatch warnings in hv.c
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/hv.c b/drivers/staging/hv/hv.c
index 824f81679ae8..2192d7885d48 100644
--- a/drivers/staging/hv/hv.c
+++ b/drivers/staging/hv/hv.c
@@ -111,7 +111,7 @@ static u64 do_hypercall(u64 control, void *input, void *output)
u64 hv_status = 0;
u64 input_address = (input) ? virt_to_phys... |
064931d0bb088c56e80d427e91a812ee7dd8c7dc | Analyze and fix the following issue in the Linux kernel code: Staging: hv: tools: Fix a checkpatch warning in hv_kvp_daemon.c | Problem Details:
Fix a checkpatch warning in hv_kvp_daemon.c.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/tools/hv_kvp_daemon.c b/drivers/staging/hv/tools/hv_kvp_daemon.c
index a4a407f7052a..8fd0f2ba57b4 100644
--- a/drivers/staging/hv/tools/hv_kvp_daemon.c
+++ b/drivers/staging/hv/tools/hv_kvp_daemon.c
@@ -116,7 +116,7 @@ void kvp_get_os_info(void)
uname(&uts_buf);
os_build = ... |
2dda95f80b2afa4bf85c6419f40e11b545cda422 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: vmbus: Don't wait indefinitely for IRQ resouces | Problem Details:
If an attempt is made to load the vmbus driver on a non-Hyper-V platform,
the load operation will hang since we currently wait indefinitely to
retrieve the IRQ information. This is done in the context of an acpi callback
context (which will obviously not happen when this driver is
loaded on a non-Hyper... | ```diff
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
index 1c949f5fb716..67a4f336df9c 100644
--- a/drivers/staging/hv/vmbus_drv.c
+++ b/drivers/staging/hv/vmbus_drv.c
@@ -768,7 +768,7 @@ MODULE_DEVICE_TABLE(pci, microsoft_hv_pci_table);
static int __init hv_acpi_init(void)
{
- int re... |
048316be72893455f69ad728fa94c26e2e582ba2 | Analyze and fix the following issue in the Linux kernel code: staging: octeon-ethernet: Add missing #includes. | Problem Details:
I looks like something used to implicitly include linux/interrupt.h,
and no longer does. Fix the resulting build error by explicitly
including it.
Signed-off-by: David Daney <david.daney@cavium.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/octeon/ethernet-rgmii.c b/drivers/staging/octeon/ethernet-rgmii.c
index 9c0d2936e486..c3d73f8431ae 100644
--- a/drivers/staging/octeon/ethernet-rgmii.c
+++ b/drivers/staging/octeon/ethernet-rgmii.c
@@ -26,6 +26,7 @@
******************************************************************... |
ab8ac090142daa3371217de98f8a00419f8c2670 | Analyze and fix the following issue in the Linux kernel code: Staging: go7007: fix braces coding style issue in wis-tw2804.c | Problem Details:
This is a patch to the wis-tw2804.c to fix the braces coding style issue as pointed by checkpatch.pl tool
Signed-off-by: Pradheep Shrinivasan <pradheep.sh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/go7007/wis-tw2804.c b/drivers/staging/go7007/wis-tw2804.c
index 5b218c55842a..9134f03e3cf0 100644
--- a/drivers/staging/go7007/wis-tw2804.c
+++ b/drivers/staging/go7007/wis-tw2804.c
@@ -33,8 +33,7 @@ struct wis_tw2804 {
int hue;
};
-static u8 global_registers[] =
-{
+static u8 ... |
af69c2943f60e4163bf3b3edbccead388b5ab3c5 | Analyze and fix the following issue in the Linux kernel code: Staging : winbond : fix coding style issue in phy_calibration.c | Problem Details:
Thus us a patch to the phy_calibration.c file that fixes up coding style warning found by the checkpatch.pl tool
Signed-off-by: Vincent Abel-Grimalt <kolymine@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/phy_calibration.c b/drivers/staging/winbond/phy_calibration.c
index c5a07fbe10ae..77a3fff708c6 100644
--- a/drivers/staging/winbond/phy_calibration.c
+++ b/drivers/staging/winbond/phy_calibration.c
@@ -24,7 +24,7 @@
#define AG_CONST 0.6072529350
#define FIXED(X) ... |
fa2d8bbb6360ec4bf831802e925d9db06d3c9649 | Analyze and fix the following issue in the Linux kernel code: Staging: serqt_usb2: fix sleeping with spinlock held | Problem Details:
The patch replaces spinlock with mutex.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
index 12f5eba0355c..2ea82c104d57 100644
--- a/drivers/staging/serqt_usb2/serqt_usb2.c
+++ b/drivers/staging/serqt_usb2/serqt_usb2.c
@@ -190,7 +190,7 @@ struct quatech_port {
struct usb_serial_port *port; /* owner ... |
eb93ca4e83ecf06a94a36571be730a98177c8e14 | Analyze and fix the following issue in the Linux kernel code: staging: fix ft1000 sparse warnings | Problem Details:
Fix sparse warnings in staging/ft1000/:
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:69:7: warning: obsolete struct initializer, use C99 syntax
and make many functions & data static. Examples:
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:65:23: warning: symbol 'fw_entry' was not declared. Sh... | ```diff
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
index 3b0130fe6083..adb436ed2511 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
@@ -68,6 +68,16 @@ struct ft1000_info {
char netdevname[IFN... |
1dc634772b0daead0e841b9034e88b6c76a05709 | Analyze and fix the following issue in the Linux kernel code: Staging: bcm: Fix memory leak reported during compile. | Problem Details:
This patch fixes a potential memory leak were temp_buff buffer
is not being freed when a certain condition is true.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index d3f3856e2dcc..6f8a75dc1ef0 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++ b/drivers/staging/bcm/Bcmchar.c
@@ -304,6 +304,8 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg)
BCM_DEBUG_PRINT(Adapter, DBG_TYP... |
fbfcdf254d7be71b25bfc053e9d22ef8ff061750 | Analyze and fix the following issue in the Linux kernel code: Staging: bcm: Fix a coding style error reported by checkpatch.pl | Problem Details:
Tool checkpatch.pl reported the following error: extern struct class *bcm_class;"
declaration not allowed in .c files. Therefore, I move this declaration into
the header "headers.h" file.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by... | ```diff
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 4bcc38b5bbb3..d3f3856e2dcc 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++ b/drivers/staging/bcm/Bcmchar.c
@@ -1974,8 +1974,6 @@ static const struct file_operations bcm_fops = {
.llseek = no_llseek,
};
-extern struct class *bcm... |
1dcab0875b113a148b6601d87b4e0e3444440339 | Analyze and fix the following issue in the Linux kernel code: Staging: zcache: signedness bug in tmem_get() | Problem Details:
"ret" needs to be signed for the error handling to work properly.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/zcache/tmem.c b/drivers/staging/zcache/tmem.c
index 975e34bcd722..1ca66ea9b281 100644
--- a/drivers/staging/zcache/tmem.c
+++ b/drivers/staging/zcache/tmem.c
@@ -604,7 +604,7 @@ int tmem_get(struct tmem_pool *pool, struct tmem_oid *oidp, uint32_t index,
struct tmem_obj *obj;
voi... |
c5f5c4db393837ebb2ae47bf061d70e498f48f8c | Analyze and fix the following issue in the Linux kernel code: staging: zcache: fix crash on high memory swap | Problem Details:
zcache_put_page() was modified to pass page_address(page) instead of the
actual page structure. In combination with the function signature changes
to tmem_put() and zcache_pampd_create(), zcache_pampd_create() tries to
(re)derive the page structure from the virtual address. However, if the
original pa... | ```diff
diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index 855a5bb56a47..a3f5162bfedc 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -1158,7 +1158,7 @@ static void *zcache_pampd_create(char *data, size_t size, bool raw, int eph... |
0428fec32c5fde013cb8223c248972941b18ca59 | Analyze and fix the following issue in the Linux kernel code: staging: zcache: fix typos | Problem Details:
The patch fixes two typos in zcache-main.c
Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index cdf0128fb55c..6c0f001c3586 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -651,7 +651,7 @@ static unsigned int zv_max_zsize = (PAGE_SIZE / 8) * 7;
/*
* byte count de... |
dbe82eb1170c0095e0ce89676235e0b27d7040d1 | Analyze and fix the following issue in the Linux kernel code: staging: zcache: fix possible sleep under lock | Problem Details:
zcache_new_pool() calls kmalloc() with GFP_KERNEL which has
__GFP_WAIT set. However, zcache_new_pool() gets called on
a stack that holds the swap_lock spinlock, leading to a
possible sleep-with-lock situation. The lock is obtained
in enable_swap_info().
The patch replaces GFP_KERNEL with GFP_ATOMIC.
... | ```diff
diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index 855a5bb56a47..cdf0128fb55c 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -1668,7 +1668,7 @@ static int zcache_new_pool(uint16_t cli_id, uint32_t flags)
if (cli == NU... |
97c451ca1094d9d1ed1f3bf7c7a8b65b783e37e0 | Analyze and fix the following issue in the Linux kernel code: Staging: usbip: Fix braces and spaces to match coding style. | Problem Details:
Fix brace positioning and spaces at the start of lines in order to
comply with the kernel coding style.
Signed-off-by: Akshay Joshi <me@akshayjoshi.com>
Acked-by: matt mooney <mfm@muteddisk.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index 1dacdc0c4e05..77d64693b873 100644
--- a/drivers/staging/usbip/stub_dev.c
+++ b/drivers/staging/usbip/stub_dev.c
@@ -548,4 +548,4 @@ struct usb_driver stub_driver = {
.id_table = stub_table,
.pre_reset = stub_pre_reset,
... |
581cd7ee21db5c2a1f991adae8d2d889e79f5cb7 | Analyze and fix the following issue in the Linux kernel code: Staging: keucr: Coding style fixes in scsiglue.c | Problem Details:
Fixed macros in scsiglue.c
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
index 135f7f21dfde..e1f3931d41e0 100644
--- a/drivers/staging/keucr/scsiglue.c
+++ b/drivers/staging/keucr/scsiglue.c
@@ -144,7 +144,7 @@ static int command_abort(struct scsi_cmnd *srb)
scsi_lock(us_to_host(us));
if (us->srb !=... |
f647b49b8587ec4793d47f007f4c24689004b640 | Analyze and fix the following issue in the Linux kernel code: Staging: keucr: Coding style fixes in smil.h | Problem Details:
Fixed brace style in smil.h
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/keucr/smil.h b/drivers/staging/keucr/smil.h
index b5a8fa7c7989..24a636a4aa1c 100644
--- a/drivers/staging/keucr/smil.h
+++ b/drivers/staging/keucr/smil.h
@@ -177,8 +177,7 @@ struct SSFDCTYPE {
WORD MaxLogBlocks;
};
-typedef struct SSFDCTYPE_T
-{
+typedef struct SSFDCTYPE_T {
... |
e1d94ecc1fbbabd3abb0f8c95ca7b2ea5ec2626d | Analyze and fix the following issue in the Linux kernel code: Staging: keucr: Coding style fixes in smscsi.c | Problem Details:
I fixed whitespace, brace style and commetnt in smscsi.c
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index a6fa77f9c48e..58b555571185 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -9,36 +9,46 @@
#include "usb.h"
#include "scsiglue.h"
#include "transport.h"
-//#include "smcommon.h"
#include "sm... |
746a54ac1d9878c60d2a3a852a9ccfd3127c3249 | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: Coding style fixes in trans.c | Problem Details:
I fixed whitespace in drivers/staging/pohmelfs/trans.c
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/pohmelfs/trans.c b/drivers/staging/pohmelfs/trans.c
index 36a253582565..06c1a7451b1b 100644
--- a/drivers/staging/pohmelfs/trans.c
+++ b/drivers/staging/pohmelfs/trans.c
@@ -50,7 +50,7 @@ static int netfs_trans_send_pages(struct netfs_trans *t, struct netfs_state *st)
int err = 0;... |
ba8f318471f66d5d5b79da68112525cf432b2b18 | Analyze and fix the following issue in the Linux kernel code: m68k: fix __page_to_pfn for a const struct page argument | Problem Details:
Fixes fallout due to the removal of the cast in commit aa462abe8aaf
("mm: fix __page_to_pfn for a const struct page argument")
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.li... | ```diff
diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
index 31d5570d6567..89f201434b5a 100644
--- a/arch/m68k/include/asm/page_mm.h
+++ b/arch/m68k/include/asm/page_mm.h
@@ -162,7 +162,7 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
pgdat->node_mem_map + (__pfn -... |
176f9f29cec95f88cfa01a8e40741d1fc532add2 | Analyze and fix the following issue in the Linux kernel code: STAGING:iio:light: fix ISL29018 init to handle brownout | Problem Details:
After a voltage brownout, sensor will now operate correctly.
Page 10 of ISL29018 data sheet and the Intersil Application Note 1534
describe the required initialization sequence:
1. Write 0x00 to register 0x08 (TEST)
2. Write 0x00 to register 0x00 (CMD1)
3. msleep(1)
4. program remaining registers as b... | ```diff
diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index 426b6af70807..da5bb33a66c1 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -53,6 +53,10 @@
#define ISL29018_REG_ADD_DATA_MSB 0x03
#define ISL29018_MAX_REGS ISL29018_R... |
f94aa354d676532448e8e222e737fdd0755fc786 | Analyze and fix the following issue in the Linux kernel code: iio: impedance-analyzer: New driver for AD5933/4 Impedance Converter, Network Analyzer | Problem Details:
The AD5933 is a high precision impedance converter system solution
that combines an on-board frequency generator with a 12-bit, 1 MSPS,
analog-to-digital converter (ADC). The frequency generator allows an
external complex impedance to be excited with a known frequency.
The response signal from the imp... | ```diff
diff --git a/drivers/staging/iio/Documentation/sysfs-bus-iio-impedance-analyzer-ad5933 b/drivers/staging/iio/Documentation/sysfs-bus-iio-impedance-analyzer-ad5933
new file mode 100644
index 000000000000..79c7e88c64cd
--- /dev/null
+++ b/drivers/staging/iio/Documentation/sysfs-bus-iio-impedance-analyzer-ad5933
@... |
7991029a55fa1d172b2162288345276f9e818785 | Analyze and fix the following issue in the Linux kernel code: staging:iio:accel:adis16220 iio_chan_spec conversion. | Problem Details:
I still have numerous issues with this driver and it
needs a substantial rewrite.
Whilst doing this patch at least one bug has been fixed (temp
reading didn't have an address) and a number of missing channel
info elements added.
Untested!
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: M... | ```diff
diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c
index bf9ba07c0383..075e40fabf47 100644
--- a/drivers/staging/iio/accel/adis16220_core.c
+++ b/drivers/staging/iio/accel/adis16220_core.c
@@ -6,9 +6,6 @@
* Licensed under the GPL-2 or later.
*/
-#include <... |
232b9cba130025d47531c5c539d6affc64950213 | Analyze and fix the following issue in the Linux kernel code: staging:iio:core flatten convenience function that only has one user. | Problem Details:
Fix trivial wrong index (no effect on any current drivers).
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
index e8ad648de3da..97f4d6329170 100644
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -1004,18 +1004,17 @@ error_ret:
return ret;
}
-static inline void __iio_remov... |
de1874b7876e5423e9b5f5e876c48eaa8d800f44 | Analyze and fix the following issue in the Linux kernel code: staging:iio:documentation trivial typo fix | Problem Details:
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/Documentation/sysfs-bus-iio b/drivers/staging/iio/Documentation/sysfs-bus-iio
index 467c49a47258..5f99f88d1b2d 100644
--- a/drivers/staging/iio/Documentation/sysfs-bus-iio
+++ b/drivers/staging/iio/Documentation/sysfs-bus-iio
@@ -2,7 +2,7 @@ What: /sys/bus/iio/devices/deviceX
... |
f7256877c777d08f3af445840d94e37b11038fe2 | Analyze and fix the following issue in the Linux kernel code: staging:iio: dummy sysfs group for autogenerated base directories. | Problem Details:
Needed to ensure the reference counting is correct.
Temporary fix whilst discussions are ongoing.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
index 7ee4186c4dfa..8bee56250a96 100644
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -725,19 +725,29 @@ static ssize_t iio_show_dev_name(struct device *dev,
static ... |
70a876c59007ddb166a36c1073f45633bef1513b | Analyze and fix the following issue in the Linux kernel code: staging:iio:accel:adis16201 overflow tx buffer. | Problem Details:
Smatch caught bug.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/accel/adis16201_ring.c b/drivers/staging/iio/accel/adis16201_ring.c
index 66e708ddf8b2..a745d5debc20 100644
--- a/drivers/staging/iio/accel/adis16201_ring.c
+++ b/drivers/staging/iio/accel/adis16201_ring.c
@@ -38,10 +38,12 @@ static int adis16201_read_ring_data(struct iio_dev *i... |
8df322385a7e253672dc5077c11dc1a6219d25cc | Analyze and fix the following issue in the Linux kernel code: staging:iio:addac:adt7316 make interrupt mask sane. | Problem Details:
Coccinelle found this one. I'm not certain what
the intent is, but this fix makes no functional changes.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 637316f79f78..c828b6f0a281 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -203,7 +203,7 @@ struct adt7316_chip_info {
#define ADT7316_TEMP_INT_MASK 0x1F
#define ADT7516_... |
cc2439fdecb85f27866cab0ae1cbf21a9b61c423 | Analyze and fix the following issue in the Linux kernel code: staging:iio:core simplify and fix a bug in iio_device_(un)register_event_set. | Problem Details:
The unwinding index was j, not i and it is much simpler to do these as a single
loop unwinding those elements necessary in before jumping to the error handler.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
index 19819e7578c6..7ee4186c4dfa 100644
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -1061,7 +1061,7 @@ static int iio_device_register_eventset(struct iio_dev *dev_inf... |
cd0380190f7c7ad8d5a8f15403a67fedd37fcddb | Analyze and fix the following issue in the Linux kernel code: staging:iio:adc: max1363 fix 2 raw sysfs issues. | Problem Details:
indio_dev->channels was accidentally removed thus preventing any sysfs
registrations occuring for direct reading. That hid the other issue.
Unfortunately the incorrect handling leads to misspresentation of data
in sysfs reads.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kro... | ```diff
diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c
index 72b0917412ee..d93b7a917b99 100644
--- a/drivers/staging/iio/adc/max1363_core.c
+++ b/drivers/staging/iio/adc/max1363_core.c
@@ -255,7 +255,7 @@ static int max1363_read_raw(struct iio_dev *indio_dev,
switch (m) {... |
cdf6e817904412931ba9a54fa0376cf6f4f678fe | Analyze and fix the following issue in the Linux kernel code: staging:iio:gyro:adis16130 fix adis16130_spi_read which was never selecting the channel | Problem Details:
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/gyro/adis16130_core.c b/drivers/staging/iio/gyro/adis16130_core.c
index c80e908d8acf..caf067ce98ce 100644
--- a/drivers/staging/iio/gyro/adis16130_core.c
+++ b/drivers/staging/iio/gyro/adis16130_core.c
@@ -75,15 +75,24 @@ static int adis16130_spi_read(struct device *dev, u8 reg_... |
88d94e301e416f672b2991af3404aebfb6277b2c | Analyze and fix the following issue in the Linux kernel code: Staging: nvec: fixes coding style issues in nvec_kbd.c | Problem Details:
This patches nvec_kbd.c to the file that fixes up errors found by
the checkpath.pl tool.
Signed-off-by: Colin Brophy <colin@brophys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/nvec/nvec_kbd.c b/drivers/staging/nvec/nvec_kbd.c
index 9a9850725b5b..04bd285cfe0a 100644
--- a/drivers/staging/nvec/nvec_kbd.c
+++ b/drivers/staging/nvec/nvec_kbd.c
@@ -4,7 +4,7 @@
#include "nvec-keytable.h"
#include "nvec.h"
-#define ACK_KBD_EVENT {'\x05','\xed','\x01'}
+#defi... |
c13d2ad0599a73d87871c5a2b4468e8cbd4bf369 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: bugfix for fifo problem on 64 bits platforms. | Problem Details:
Message 'receive fifo overflow' appeared in the log. Root cause was an
invalid physical address being programmed into the DMA engine. This was
caused by an invalid pointer cast in the dma code. Issue was observed on
a Sparc (Sun Fire V120) machine but could theoretically also pop up
on other architectu... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/dma.c b/drivers/staging/brcm80211/brcmsmac/dma.c
index 2ef416a9558e..05dad9fcc931 100644
--- a/drivers/staging/brcm80211/brcmsmac/dma.c
+++ b/drivers/staging/brcm80211/brcmsmac/dma.c
@@ -600,13 +600,18 @@ static bool _dma_alloc(struct dma_info *di, uint direction)... |
49d468f64d59016030c2835a423833e7b45ccce5 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: bugfix for exception on Sparc platforms | Problem Details:
Problem would pop up during driver load on a Sun Fire V120 and manifested
itself as an exception. This was caused by int* pointers provided to memcpy()
that were not aligned on an int boundary. The pointer type provided to
memcpy() is used by the compiler for optimization purposes. Fix was to cast
the ... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/main.c b/drivers/staging/brcm80211/brcmsmac/main.c
index c625c2556aed..7e729d295d73 100644
--- a/drivers/staging/brcm80211/brcmsmac/main.c
+++ b/drivers/staging/brcm80211/brcmsmac/main.c
@@ -6111,9 +6111,12 @@ _brcms_c_ioctl(struct brcms_c_info *wlc, int cmd, void... |
183eeb985a2cdbf37c7850c5e8e99cc1cc26901f | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix rtnl_lock issue when bringing down brcmfmac | Problem Details:
When bringing down the netdevice interface a deadlock occurred
sporadically due to the rtnl_lock being held by a task that was
waiting for another task trying to get the lock. This patch fixes
that issue.
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broa... | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
index 6c604cf627d5..80bb30a8a762 100644
--- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
@@ -3189,7 +3189,14 @@ static void brcmf_term_isc... |
60be7ec5099cee40f40b0fbb75ea4396016a5231 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix checkpatch warning in fullmac | Problem Details:
Fix the __aligned checkpatch warning in wl_cfg80211.h
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.h b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.h
index 049138b9e5de..0542bac2d79e 100644
--- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.h
+++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.h
@@ -317,7 +317,7 @@ struct brcmf_cfg80211_priv {
... |
adf27befdc79a9403bfba82ee84f02a47bcd546c | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: restrict MIPS dma bug workaround to BCM47XX | Problem Details:
The inline function dma_spin_for_len() was defined for MIPS platforms
but the problem only occurs with dma of the PCI core in bcm47xx chips.
This patch restricts the function further to BCM47XX platforms only.
Tested on BCM63281.
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by:... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/dma.h b/drivers/staging/brcm80211/brcmsmac/dma.h
index 134402cc008a..2ce5963818d4 100644
--- a/drivers/staging/brcm80211/brcmsmac/dma.h
+++ b/drivers/staging/brcm80211/brcmsmac/dma.h
@@ -100,21 +100,21 @@ void dma_walk_packets(struct dma_pub *dmah, void (*callback... |
d745a845045f31a8250cd856b79e84c8374a3adb | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: Fix handling of firmware and inits on big-endian platforms | Problem Details:
The firmware files are encoded as little-endian. Do the appropriate swapping
for big-endian platforms.
Tested on Mac G5 PPC and BCM63281.
Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Tested-b... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/mac80211_if.c b/drivers/staging/brcm80211/brcmsmac/mac80211_if.c
index e4657495ebd3..7179edda94af 100644
--- a/drivers/staging/brcm80211/brcmsmac/mac80211_if.c
+++ b/drivers/staging/brcm80211/brcmsmac/mac80211_if.c
@@ -1722,15 +1722,17 @@ int brcms_ucode_init_buf(... |
8ac98a56fac0cafb56d900154ac4569a959011c0 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix off-by-one error in swap functions | Problem Details:
The original implementation iterated over the data in buf+1 through buf+size,
whereas it should have been over the data in buf through buf+size-1.
Tested on Mac G5 PPC and BCM63281.
Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Ro... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/srom.c b/drivers/staging/brcm80211/brcmsmac/srom.c
index 060f06fc1440..7a17f598e499 100644
--- a/drivers/staging/brcm80211/brcmsmac/srom.c
+++ b/drivers/staging/brcm80211/brcmsmac/srom.c
@@ -880,13 +880,15 @@ int srom_var_init(struct si_pub *sih, void *curmap, cha... |
303a1e5c0be3745a5fccd59347e3765ac7628372 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: remove PHYSADDR macro from dma.c | Problem Details:
Four macros with PHYSADDR name prefix are not doing a lot and
complicate code readability. These have been expanded in the source
code and consequently removed the definitions.
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Ro... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/dma.c b/drivers/staging/brcm80211/brcmsmac/dma.c
index 9ac38679b5a7..64d311f95d96 100644
--- a/drivers/staging/brcm80211/brcmsmac/dma.c
+++ b/drivers/staging/brcm80211/brcmsmac/dma.c
@@ -196,14 +196,6 @@
#define DMA_NONE(args)
-#define PHYSADDRHI(_pa) (0)
-#d... |
20cc7995fe66ce6417678bb0db6b3d4955fb1ff6 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: SPARC build error fix | Problem Details:
Due to missing memset function declaration.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/otp.c b/drivers/staging/brcm80211/brcmsmac/otp.c
index 34253cf37812..4a70180eba5d 100644
--- a/drivers/staging/brcm80211/brcmsmac/otp.c
+++ b/drivers/staging/brcm80211/brcmsmac/otp.c
@@ -16,6 +16,7 @@
#include <linux/io.h>
#include <linux/errno.h>
+#include <l... |
9818a4775a3ab18b84a689537088b3d72a742130 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix compile error on non-x86 archs since 3.0 kernel | Problem Details:
Since the arrival of kernel version 3.0 in the staging tree it
turns out compile error occurs for sparc64, powerpc, and arm
platforms. This patch fixes that issue.
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Arend van Spr... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/types.h b/drivers/staging/brcm80211/brcmsmac/types.h
index bbf21897ae0e..823b5e4672e2 100644
--- a/drivers/staging/brcm80211/brcmsmac/types.h
+++ b/drivers/staging/brcm80211/brcmsmac/types.h
@@ -18,6 +18,7 @@
#define _BRCM_TYPES_H_
#include <linux/types.h>
+#i... |
124bf340114b74eb0a9f49dd51e855fa2300b565 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix 'uninitialized usage' compiler warning | Problem Details:
Building for the ARM resulted in a compiler warning about usage of
a possibly uninitialized variable. The warning is valid and the
code has been fixed accordingly.
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Arend van Spr... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/channel.c b/drivers/staging/brcm80211/brcmsmac/channel.c
index b9cb892377ed..1aad680c7f62 100644
--- a/drivers/staging/brcm80211/brcmsmac/channel.c
+++ b/drivers/staging/brcm80211/brcmsmac/channel.c
@@ -1279,8 +1279,8 @@ brcms_c_channel_reg_limits(struct brcms_cm_... |
d788766c12f89ebf486101a3f9a30317c324a14b | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: SPARC build error fix | Problem Details:
Due to missing memset function declaration.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/otp.c b/drivers/staging/brcm80211/brcmsmac/otp.c
index 975d80cb8841..b6ff76706ef3 100644
--- a/drivers/staging/brcm80211/brcmsmac/otp.c
+++ b/drivers/staging/brcm80211/brcmsmac/otp.c
@@ -16,6 +16,7 @@
#include <linux/io.h>
#include <linux/errno.h>
+#include <l... |
05b92610eef4646c252171d059a84c705b66ede5 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: replace simple_strtoul usage in brcmfmac | Problem Details:
The usage of simple_strtoul is not preferred. Instead kstrtoul
should be used. This patch fixes this for the brcmfmac driver.
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_common.c b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
index 12c772d17898..fdd362901df4 100644
--- a/drivers/staging/brcm80211/brcmfmac/dhd_common.c
+++ b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
@@ -827,10 +827,13 @@ static int brcmf_c_pattern_atoh... |
1a1038033ea08bf4f82e6abbdd9fbed5df2148c8 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: remove BRCMF_SD_* debug macros from brcmfmac | Problem Details:
Use unified debug macros BRCMF_* in fullmac.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
index 09531608c5c6..53dfecdf5aa9 100644
--- a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
@@ -34,28 +34,6 @@
#define SDIOH_API_ACCESS_RETRY_LIMIT 2
-#defi... |
23eec9e1776d2e4ff7872f4d547d6913922c8977 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: remove SDLX_MSG from brcmfmac | Problem Details:
Use unified debug macros in fullmac
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
index 7b6678791946..09531608c5c6 100644
--- a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
@@ -29,6 +29,7 @@
#include <soc.h>
#include "dhd.h"
#include "dhd_... |
e38a80cc29ce821cf0d359891c363616507b8db5 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: get rid of sd debug message macro in fullmac | Problem Details:
Use BRCMF_* instead of sd_* as debug message interface
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
index 916d41f6a102..310d4fd8c25a 100644
--- a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
@@ -98,8 +98,6 @@ static struct brcmf_sdioh_driver drvinfo = { NULL, ... |
3f7e0c5df5910157441b680622447c903436f04a | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: replace simple_strtoul usage in brcmsmac | Problem Details:
The usage of simple_strtoul is not preferred. Instead kstrtoul
should be used. This patch fixes this for the brcmsmac driver.
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by:... | ```diff
diff --git a/drivers/staging/brcm80211/brcmsmac/main.c b/drivers/staging/brcm80211/brcmsmac/main.c
index 5c97778c1db7..001a1f77e692 100644
--- a/drivers/staging/brcm80211/brcmsmac/main.c
+++ b/drivers/staging/brcm80211/brcmsmac/main.c
@@ -4287,16 +4287,17 @@ int brcms_b_attach(struct brcms_c_info *wlc, u16 vend... |
1fda276eb1707ec9cef3d00c293d7cb488af7ca6 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: removed global variable from sdio fullmac | Problem Details:
Code cleanup. bus->card is assigned in brcmf_sdbrcm_probe (before
brcmf_sdbrcm_probe_attach()). Since w_sdreg32() and r_sdreg32() are called
only after that assignment, they can safely use bus->card. Thus there
is no instance left where brcmf_sdcard_reg_read() or brcmf_sdcard_reg_write()
is called with... | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
index fb3ab638e40c..916d41f6a102 100644
--- a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
@@ -89,9 +89,6 @@ struct sdio_hc {
bool oob_irq_registered;
};
-... |
bf4c4f434d473e63e87b2b0b4f86d52079764df0 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: brcmfmac: Connect request made robust | Problem Details:
Connect request made robust by passing broadcast bssid to the
FW in SET_SSID request. This fix helps STA to connect
to any available AP in ESS instead of sticking to one
unresponsive AP.
Signed-off-by: Sukesh Srikakula <sukeshs@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-... | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
index a915b6e409e5..2e8fd6e7052e 100644
--- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
@@ -1420,11 +1420,6 @@ brcmf_cfg80211_connect(str... |
92faa4ea9f749a20c325863c5c40c48602eebe29 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: power save issue fixed in brcmfmac driver | Problem Details:
brcmfmac driver is getting request for enabling power save
before the interface is up. With the earlier implementation,
this request used to fail resulting out of sync power save
state between cfg80211 & brcmfmac driver. With this fix,
power save state is stored in configuration parameters and
will be ... | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_common.c b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
index 44128934dc0e..62b7591fdadf 100644
--- a/drivers/staging/brcm80211/brcmfmac/dhd_common.c
+++ b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
@@ -1099,7 +1099,6 @@ int brcmf_c_preinit_ioctls(stru... |
2740a329487c68b079785074c72d5a97946ad597 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix for checkpatch 'avoid externs in c file' warning | Problem Details:
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
index f4e72ed126b0..fb3ab638e40c 100644
--- a/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh.c
@@ -103,16 +103,8 @@ static struct brcmf_sdioh_driver drvinfo = { NUL... |
2c1599cfd6a736e09c29c772fbaf41250646ad42 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: bugfix for len==0 parameter in 3 fullmac functions | Problem Details:
Three functions use the same method to check incoming parameters. The
'len' parameter can be equal to 0 in case of a 'set' operation.
Currently these functions return an error code under that condition,
which is incorrect. The problem was introduced in recent patches in
which asserts were removed from ... | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c
index 38bd9ba3096f..e345af7918e2 100644
--- a/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c
+++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c
@@ -407,7 +407,7 @@ brcmf_sdioh_iovar_op(stru... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.