id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
3cbf5072ee0f38da278d67b7fafcfd6c86f83d36 | Analyze and fix the following issue in the Linux kernel code: [media] fix A-Link DTU(m) remote controller PIP button | Problem Details:
Button is PIP => KEY_NEW
http://www.linuxtv.org/wiki/index.php/Remote_Controllers
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/IR/keymaps/rc-alink-dtu-m.c b/drivers/media/IR/keymaps/rc-alink-dtu-m.c
index 6888ea2e4b91..ddfee7f8093d 100644
--- a/drivers/media/IR/keymaps/rc-alink-dtu-m.c
+++ b/drivers/media/IR/keymaps/rc-alink-dtu-m.c
@@ -27,7 +27,7 @@ static struct ir_scancode alink_dtu_m[] = {
{ 0x0802, KEY... |
dfd6f7fab5ae962c6d7f9a66bc7ca6a154f83306 | Analyze and fix the following issue in the Linux kernel code: [media] fix TerraTec remote controller PIP button | Problem Details:
Button is PIP => KEY_NEW
http://www.linuxtv.org/wiki/index.php/Remote_Controllers
Thanks to Cart.
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/IR/keymaps/rc-terratec-slim.c b/drivers/media/IR/keymaps/rc-terratec-slim.c
index 70b08fe64079..10dee4c1deff 100644
--- a/drivers/media/IR/keymaps/rc-terratec-slim.c
+++ b/drivers/media/IR/keymaps/rc-terratec-slim.c
@@ -34,7 +34,7 @@ static struct ir_scancode terratec_slim[] = {
{ 0... |
f8b3d9a00294cd81d6d123d03aa030c2b5454764 | Analyze and fix the following issue in the Linux kernel code: [media] fix MSI DIGIVOX mini III remote controller power buttons | Problem Details:
Fix power button mappings as defined in
http://www.linuxtv.org/wiki/index.php/Remote_Controllers
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/IR/keymaps/rc-msi-digivox-iii.c b/drivers/media/IR/keymaps/rc-msi-digivox-iii.c
index 8ea3960347c3..882056e52ef9 100644
--- a/drivers/media/IR/keymaps/rc-msi-digivox-iii.c
+++ b/drivers/media/IR/keymaps/rc-msi-digivox-iii.c
@@ -27,7 +27,7 @@
static struct ir_scancode msi_digivox_iii[... |
39a96b4cf592e79aefd1b4f2b136c20ec7bf10a7 | Analyze and fix the following issue in the Linux kernel code: [media] em28xx-audio: fix some locking issues | Problem Details:
Those locking issues affect tvtime, causing a kernel oops/panic, due to
a race condition.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c
index e182abf476c9..3c48a72eb7de 100644
--- a/drivers/media/video/em28xx/em28xx-audio.c
+++ b/drivers/media/video/em28xx/em28xx-audio.c
@@ -102,6 +102,9 @@ static void em28xx_audio_isocirq(struct urb *urb)
brea... |
643800d5c806cf46b0cd184b595a14cce83224e4 | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx: use core-assisted lock | Problem Details:
Instead of doing its own lock, use core-assisted one. As a bonus, it
will do the proper unlock during queue wait events. This fixes a
long-standing bug where softwares like tvtime would hang if you try to
use cx231xx-alsa.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-video.c b/drivers/media/video/cx231xx/cx231xx-video.c
index 38367ee07cc5..b13b69fb2af6 100644
--- a/drivers/media/video/cx231xx/cx231xx-video.c
+++ b/drivers/media/video/cx231xx/cx231xx-video.c
@@ -1019,8 +1019,6 @@ static int vidioc_g_fmt_vid_cap(struct file *fi... |
bae94dc39e9530842379208c4406512d34dc7ef3 | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx-417: Fix a gcc warning | Problem Details:
gcc didn't like to have i++ inside a complex operation:
drivers/media/video/cx231xx/cx231xx-417.c: In function ‘cx231xx_load_firmware’:
drivers/media/video/cx231xx/cx231xx-417.c:1059: warning: operation on ‘i’ may be undefined
drivers/media/video/cx231xx/cx231xx-417.c:1061: warning: operation on ‘i’ m... | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-417.c b/drivers/media/video/cx231xx/cx231xx-417.c
index a5b1b13d1fd6..b5b69989ff8d 100644
--- a/drivers/media/video/cx231xx/cx231xx-417.c
+++ b/drivers/media/video/cx231xx/cx231xx-417.c
@@ -1053,16 +1053,15 @@ static int cx231xx_load_firmware(struct cx231xx *dev)... |
61b04cb24a129f2483d5110e119fc2e365177741 | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx-audio: fix some locking issues | Problem Details:
Acked-by: Sri Deevi <Srinivasa.Deevi@conexant.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-audio.c b/drivers/media/video/cx231xx/cx231xx-audio.c
index 6ac418cc6895..30d13c15739a 100644
--- a/drivers/media/video/cx231xx/cx231xx-audio.c
+++ b/drivers/media/video/cx231xx/cx231xx-audio.c
@@ -124,6 +124,9 @@ static void cx231xx_audio_isocirq(struct urb *urb... |
e350d44fed8eb86a7192a579e3687fcd76a4645b | Analyze and fix the following issue in the Linux kernel code: [media] tda18271: allow restricting max out to 4 bytes | Problem Details:
By default, tda18271 tries to optimize I2C bus by updating all registers
at the same time. Unfortunately, some devices doesn't support it.
The current logic has a problem when small_i2c is equal to 8, since there
are some transfers using 11 + 1 bytes.
Fix the problem by enforcing the max size at the ... | ```diff
diff --git a/drivers/media/common/tuners/tda18271-common.c b/drivers/media/common/tuners/tda18271-common.c
index e1f678281a58..195b30e3872d 100644
--- a/drivers/media/common/tuners/tda18271-common.c
+++ b/drivers/media/common/tuners/tda18271-common.c
@@ -193,20 +193,46 @@ int tda18271_write_regs(struct dvb_fron... |
92fbb811a8c433f0f9a2b6ede0875c588b32d85c | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx: fix Kconfig dependencies | Problem Details:
ERROR: "cx2341x_mpeg_ctrls" [drivers/media/video/cx231xx/cx231xx.ko] undefined!
ERROR: "cx2341x_fill_defaults" [drivers/media/video/cx231xx/cx231xx.ko] undefined!
ERROR: "cx2341x_log_status" [drivers/media/video/cx231xx/cx231xx.ko] undefined!
ERROR: "cx2341x_ctrl_get_menu" [drivers/media/video/cx231xx/... | ```diff
diff --git a/drivers/media/video/cx231xx/Kconfig b/drivers/media/video/cx231xx/Kconfig
index 5ac7eceececa..bb04914983fd 100644
--- a/drivers/media/video/cx231xx/Kconfig
+++ b/drivers/media/video/cx231xx/Kconfig
@@ -6,6 +6,7 @@ config VIDEO_CX231XX
depends on VIDEO_IR
select VIDEOBUF_VMALLOC
select VIDEO_C... |
6af8cc0b2553b7bed060592c07244bd2d75737c9 | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx: Fix vblank/vactive line counts for PAL/SECAM | Problem Details:
Adjust the vblank and vactive counts so that they don't throw an error in
cx25840's set_std call (we did an equivalent change for NTSC when we got the
scaler working).
Signed-off-by: Devin Heitmueller <dheitmueller@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-avcore.c b/drivers/media/video/cx231xx/cx231xx-avcore.c
index ebbdd90cac06..b4eda903d27d 100644
--- a/drivers/media/video/cx231xx/cx231xx-avcore.c
+++ b/drivers/media/video/cx231xx/cx231xx-avcore.c
@@ -1012,21 +1012,21 @@ int cx231xx_do_mode_ctrl_overrides(struct... |
2ded0fe140738accc4213d08b5605f7805fd18d3 | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx: whitespace cleanup | Problem Details:
Fix some indentation problems and remove an "if (1)" from the Colibri setup
function.
Signed-off-by: Devin Heitmueller <dheitmueller@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-avcore.c b/drivers/media/video/cx231xx/cx231xx-avcore.c
index a9e6cbe26ce5..580fe535b644 100644
--- a/drivers/media/video/cx231xx/cx231xx-avcore.c
+++ b/drivers/media/video/cx231xx/cx231xx-avcore.c
@@ -1482,43 +1482,38 @@ void cx231xx_Setup_AFE_for_LowIF(struct c... |
d5a1754d523f5145a6e4ec8fa3a592cc57400467 | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx: reduce log severity for some debug events | Problem Details:
Change the log level from info to debug for some log events that occur
frequently and should never need to be seen in normal operation.
Signed-off-by: Devin Heitmueller <dheitmueller@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-core.c b/drivers/media/video/cx231xx/cx231xx-core.c
index 44f3c3e5e105..7beb201141c4 100644
--- a/drivers/media/video/cx231xx/cx231xx-core.c
+++ b/drivers/media/video/cx231xx/cx231xx-core.c
@@ -528,7 +528,7 @@ int cx231xx_set_video_alternate(struct cx231xx *dev)
... |
adc0356e9ba59b9b014a58c9e117b10c9ce522d9 | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx: Fix VBI parameters for sampling rate and offset | Problem Details:
The VBI sampling rate and offset were incorrectly specified, which resulted in
CC data not being rendered under zvbi or tvtime.
Set the fields correctly.
Signed-off-by: Devin Heitmueller <dheitmueller@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-video.c b/drivers/media/video/cx231xx/cx231xx-video.c
index 9a42ccbcb46f..585c0316a48c 100644
--- a/drivers/media/video/cx231xx/cx231xx-video.c
+++ b/drivers/media/video/cx231xx/cx231xx-video.c
@@ -2020,12 +2020,10 @@ static int vidioc_g_fmt_vbi_cap(struct file *... |
dd067a8de79fcc75b3fbd84aba398c9296b47cb2 | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx: fix format string warning | Problem Details:
Change a %x to a %p since the variable is a pointer
Signed-off-by: Devin Heitmueller <dheitmueller@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-417.c b/drivers/media/video/cx231xx/cx231xx-417.c
index d0e0d713a466..38acc55cb9b6 100644
--- a/drivers/media/video/cx231xx/cx231xx-417.c
+++ b/drivers/media/video/cx231xx/cx231xx-417.c
@@ -2010,7 +2010,7 @@ static int mpeg_release(struct file *file)
struct cx2... |
bda7f4ee67b8a7a6315b906224d01d44d5a433b4 | Analyze and fix the following issue in the Linux kernel code: [media] s5h1432: fix codingstyle issues | Problem Details:
Run Lindent and fix a few spacing issues.
This patch makes no functional change to the driver.
Signed-off-by: Devin Heitmueller <dheitmueller@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/s5h1432.c b/drivers/media/dvb/frontends/s5h1432.c
index cff164c812e0..5fc3bf5f1c0b 100644
--- a/drivers/media/dvb/frontends/s5h1432.c
+++ b/drivers/media/dvb/frontends/s5h1432.c
@@ -53,14 +53,13 @@ static int debug;
printk(arg); \
} while (0)
-
static int s5h1432... |
9dfde5578d1111da96142d16fdfa2039d8992744 | Analyze and fix the following issue in the Linux kernel code: [media] Use smaller i2c transaction size with 18271 tuner | Problem Details:
Configure the tda18271 to use a smaller transaction size by default, which
works around some sort of i2c bug in the Polaris driver (which needs to be
debugged).
This should be safe for other boards (being in tuner-core means it will be
enabled by default), although testing needs to be done.
Signed-of... | ```diff
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index e32146680b37..d14f66f0cb31 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -427,6 +427,7 @@ static void set_type(struct i2c_client *c, unsigned int type,
{
struct tda18271_config c... |
761f6cf6425e8024b983ddfa905a4c0002718fbe | Analyze and fix the following issue in the Linux kernel code: [media] cx231xx: fix race condition in DVB initialization | Problem Details:
Fix case where analog calls come in while the DVB side of the board is still
initializing. This patch is actually just an exact port of the same patch
made by Mauro to em28xx in hg rev 14762.
Signed-off-by: Devin Heitmueller <dheitmueller@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@r... | ```diff
diff --git a/drivers/media/video/cx231xx/cx231xx-core.c b/drivers/media/video/cx231xx/cx231xx-core.c
index b75e9e7dd502..44f3c3e5e105 100644
--- a/drivers/media/video/cx231xx/cx231xx-core.c
+++ b/drivers/media/video/cx231xx/cx231xx-core.c
@@ -97,20 +97,17 @@ void cx231xx_add_into_devlist(struct cx231xx *dev)
}... |
01bc79918637432bf6ee7f4ad7fa547c0a14fa6a | Analyze and fix the following issue in the Linux kernel code: [media] Staging: cx25821: remove spaces after parenthesis | Problem Details:
fix "ERROR: space prohibited after that open parenthesis '('"
This is a patch to the cx25821-audio-upstream.h file that fixed up a
space errors found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/staging/cx25821/cx25821-audio-upstream.h b/drivers/staging/cx25821/cx25821-audio-upstream.h
index ca987addf815..668a4f11e80b 100644
--- a/drivers/staging/cx25821/cx25821-audio-upstream.h
+++ b/drivers/staging/cx25821/cx25821-audio-upstream.h
@@ -46,11 +46,11 @@
#define USE_RISC_NOOP_AUDIO ... |
df2b9b0f9c02689ce3b3f0b5dbc6c9b272bbe1ab | Analyze and fix the following issue in the Linux kernel code: [media] cafe_ccic: Fix hang in command write processing | Problem Details:
This patch, which basically reverts 6d77444ac, fixes an occasional
on-boot or on-capture hang on the XO-1 laptop.
It seems like the cafe hardware is flakier than we thought and that in
some cases, the commands get executed but are never reported as completed
(even if we substantially increase the dela... | ```diff
diff --git a/drivers/media/video/cafe_ccic.c b/drivers/media/video/cafe_ccic.c
index 2ffb6df955b3..05d810ad454a 100644
--- a/drivers/media/video/cafe_ccic.c
+++ b/drivers/media/video/cafe_ccic.c
@@ -363,7 +363,6 @@ static int cafe_smbus_write_data(struct cafe_camera *cam,
{
unsigned int rval;
unsigned long... |
a716e9d75f04ff71fb5e391a7a189b6f1b032bbc | Analyze and fix the following issue in the Linux kernel code: [media] go7007: MJPEG buffer overflow | Problem Details:
The go7007 driver has a potential buffer overflow and pointer corruption
bug which causes a crash while capturing MJPEG. The motion detection
(MODET) active_map array can be overflowed by JPEG frame data that
emulates a MODET start code. The active_map overflow overwrites the
active_buf pointer, causin... | ```diff
diff --git a/drivers/staging/go7007/go7007-driver.c b/drivers/staging/go7007/go7007-driver.c
index 372a7c6791ca..b8ecbd889761 100644
--- a/drivers/staging/go7007/go7007-driver.c
+++ b/drivers/staging/go7007/go7007-driver.c
@@ -393,7 +393,8 @@ static void write_bitmap_word(struct go7007 *go)
for (i = 0; i < 16... |
94d4350c544066d590eee93582220128e8be8b1c | Analyze and fix the following issue in the Linux kernel code: [media] staging/tm6000: Fix a warning message | Problem Details:
I added a code to the driver to force it to produce a warning. This
were intended to remind me about a very bad hack. I never found a way
to workaround. So, instead of those warnings:
drivers/staging/tm6000/tm6000-core.c: In function ‘tm6000_init_analog_mode’:
drivers/staging/tm6000/tm6000-core.c:328:... | ```diff
diff --git a/drivers/staging/tm6000/tm6000-core.c b/drivers/staging/tm6000/tm6000-core.c
index 57cb69e1fce9..3d825107c09f 100644
--- a/drivers/staging/tm6000/tm6000-core.c
+++ b/drivers/staging/tm6000/tm6000-core.c
@@ -188,6 +188,8 @@ void tm6000_set_fourcc_format(struct tm6000_core *dev)
int tm6000_init_ana... |
2b361ab6d54ddd4322d730ecbee25ab4b98aa36f | Analyze and fix the following issue in the Linux kernel code: [media] lirc_igorplugusb: Fix a compilation waring | Problem Details:
drivers/staging/lirc/lirc_igorplugusb.c: In function ‘usb_remote_probe’:
drivers/staging/lirc/lirc_igorplugusb.c:393: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘unsigned int’
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/staging/lirc/lirc_igorplugusb.c b/drivers/staging/lirc/lirc_igorplugusb.c
index bce600ede263..e680d8897106 100644
--- a/drivers/staging/lirc/lirc_igorplugusb.c
+++ b/drivers/staging/lirc/lirc_igorplugusb.c
@@ -390,7 +390,7 @@ static int usb_remote_probe(struct usb_interface *intf,
devnum ... |
7242063018c06977dc6825026b3075076e6f227b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: Fix a merge conflict that affects unlock_ioctl | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/v4l2-dev.c b/drivers/media/video/v4l2-dev.c
index a7702e3d149c..0ca7978654b5 100644
--- a/drivers/media/video/v4l2-dev.c
+++ b/drivers/media/video/v4l2-dev.c
@@ -236,20 +236,20 @@ static unsigned int v4l2_poll(struct file *filp, struct poll_table_struct *poll)
static long v4l2_... |
be737a826949760b75c3b46fc86686274965fca1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: tm6000: Fix warnings due to a small array size | Problem Details:
drivers/staging/tm6000/tm6000-stds.c:101: warning: excess elements in array initializer
drivers/staging/tm6000/tm6000-stds.c:101: warning: (near initialization for ‘tv_stds[0].common’)
drivers/staging/tm6000/tm6000-stds.c:160: warning: excess elements in array initializer
drivers/staging/tm6000/tm6000-... | ```diff
diff --git a/drivers/staging/tm6000/tm6000-stds.c b/drivers/staging/tm6000/tm6000-stds.c
index f6aa75334d0d..fe22f427491a 100644
--- a/drivers/staging/tm6000/tm6000-stds.c
+++ b/drivers/staging/tm6000/tm6000-stds.c
@@ -32,7 +32,7 @@ struct tm6000_std_tv_settings {
v4l2_std_id id;
struct tm6000_reg_settings ... |
d026d8284378110c8629a259caaccae4628f1ce0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: videobuf-dma-sg: Fix a warning due to the usage of min(PAGE_SIZE, arg) | Problem Details:
drivers/media/video/videobuf-dma-sg.c: In function ‘videobuf_pages_to_sg’:
drivers/media/video/videobuf-dma-sg.c:119: warning: comparison of distinct pointer types lacks a cast
drivers/media/video/videobuf-dma-sg.c:120: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Mauro Ca... | ```diff
diff --git a/drivers/media/video/videobuf-dma-sg.c b/drivers/media/video/videobuf-dma-sg.c
index 359f2f3fdc77..7153e44efd52 100644
--- a/drivers/media/video/videobuf-dma-sg.c
+++ b/drivers/media/video/videobuf-dma-sg.c
@@ -116,8 +116,8 @@ static struct scatterlist *videobuf_pages_to_sg(struct page **pages,
... |
a95bd640e7e5642eca52b946f7a27481980154ac | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca - sonixj: Bad detection of the end of image | Problem Details:
The 'end of image' block may be splitted between two ISOC packets.
This case was not tested, so, some images could be lost and concatenated
to previous one(s), raising 'frame overflow' errors.
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com... | ```diff
diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c
index 3c699ac5233f..72f830a6572c 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -2820,38 +2820,52 @@ static void sd_pkt_scan(struct gspca_dev *gspca_dev,
struct sd *sd = (struct sd... |
73f4d265f660be3d69ee930bbf55c9ba069be079 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: tm6000+audio | Problem Details:
I rework my last patch for audio and now audio works well. This patch
can be submited to GIT tree Quality of audio now is good for SECAM-DK.
For other standard I set some value from datasheet need some tests.
1. Fix pcm buffer overflow
2. Rework pcm buffer fill method
3. Swap bytes in audio stream
4. ... | ```diff
diff --git a/drivers/staging/tm6000/tm6000-alsa.c b/drivers/staging/tm6000/tm6000-alsa.c
index 087137d9164d..a99101fef1a3 100644
--- a/drivers/staging/tm6000/tm6000-alsa.c
+++ b/drivers/staging/tm6000/tm6000-alsa.c
@@ -160,15 +160,15 @@ static struct snd_pcm_hardware snd_tm6000_digital_hw = {
SNDRV_PCM_INFO_... |
a2efdd7b189a1ed0413b058a77c3529fb0758e80 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca - cpia1: Fix compilation warning when gspca debug disabled | Problem Details:
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/cpia1.c b/drivers/media/video/gspca/cpia1.c
index 203bab9318e6..9b121681d135 100644
--- a/drivers/media/video/gspca/cpia1.c
+++ b/drivers/media/video/gspca/cpia1.c
@@ -1753,7 +1753,9 @@ static void sd_stopN(struct gspca_dev *gspca_dev)
/* this function is called at probe ... |
8dbf3e7c3a89bb398d69e373962a6b447d1ff3d7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca - benq: Display error messages when gspca debug disabled | Problem Details:
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/benq.c b/drivers/media/video/gspca/benq.c
index fce8d9492641..dc25788436c7 100644
--- a/drivers/media/video/gspca/benq.c
+++ b/drivers/media/video/gspca/benq.c
@@ -62,7 +62,7 @@ static void reg_w(struct gspca_dev *gspca_dev,
0,
500);
if (ret < 0) {
- PDEBUG(D_ER... |
88bfd0bd7f8343c3c2ff65fe4d3fc3aff6ecca7c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: mx2_camera: fix comment typo | Problem Details:
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
index 3fba60036eb2..2560e77b35df 100644
--- a/drivers/media/video/mx2_camera.c
+++ b/drivers/media/video/mx2_camera.c
@@ -461,7 +461,7 @@ static void free_buffer(struct videobuf_queue *vq, struct mx2_buffer *buf)
/*
* This w... |
401e5f8d38f539765cf550fa76b684d10975840c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: em28xx: fix a compilation warning | Problem Details:
drivers/media/video/em28xx/em28xx-video.c: In function ‘vidioc_s_register’:
drivers/media/video/em28xx/em28xx-video.c:1617: warning: unused variable ‘rc’
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 06cf19792504..908e3bc88303 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -1614,7 +1614,6 @@ static int vidioc_s_register(struct file *file, void *p... |
ee6869afc922a9849979e49bb3bbcad794872fcb | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: v4l2: add core serialization lock | Problem Details:
Drivers can optionally set a pointer to a mutex in struct video_device.
The core will use that to lock before calling open, read, write, unlocked_ioctl,
poll, mmap or release.
Updated the documentation as well and ensure that v4l2-event knows about the
lock: it will unlock it before doing a blocking w... | ```diff
diff --git a/Documentation/video4linux/v4l2-framework.txt b/Documentation/video4linux/v4l2-framework.txt
index 9b1d81c26b7d..a128e012a45c 100644
--- a/Documentation/video4linux/v4l2-framework.txt
+++ b/Documentation/video4linux/v4l2-framework.txt
@@ -453,6 +453,10 @@ You should also set these fields:
- ioctl_o... |
c37db91fd0d42d27141b6c49b768070df29e1c5e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: bttv: fix driver lock and remove explicit calls to BKL | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
index d74dfa6d1a55..056888cbc8e7 100644
--- a/drivers/media/video/bt8xx/bttv-driver.c
+++ b/drivers/media/video/bt8xx/bttv-driver.c
@@ -1859,21 +1859,25 @@ static int bttv_s_std(struct file *file, void *priv, v4l2_std... |
ca960bfe136844952041d2e7dc030a6d4d5c7469 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: bttv: Fix mutex unbalance at bttv_poll | Problem Details:
Don't do double mutex_unlock when reading a stream at bttv_poll.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
index fcafe2f1e5cf..d74dfa6d1a55 100644
--- a/drivers/media/video/bt8xx/bttv-driver.c
+++ b/drivers/media/video/bt8xx/bttv-driver.c
@@ -3162,15 +3162,14 @@ static unsigned int bttv_poll(struct file *file, poll_table *... |
e69e34e9d964b66013dc09a112e6b46def0af1ef | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: v4l: fsl-viu.c: add slab.h include to fix compile breakage | Problem Details:
mpc512x kernel configurations without SPI support do not build:
drivers/media/video/fsl-viu.c: In function 'viu_open':
drivers/media/video/fsl-viu.c:1248: error: implicit declaration of function 'kzalloc'
drivers/media/video/fsl-viu.c:1248: warning: assignment makes pointer from integer without a cast... | ```diff
diff --git a/drivers/media/video/fsl-viu.c b/drivers/media/video/fsl-viu.c
index 43d208f1f586..0b318bed4d52 100644
--- a/drivers/media/video/fsl-viu.c
+++ b/drivers/media/video/fsl-viu.c
@@ -22,6 +22,7 @@
#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/of_platform.h>
+#include <linux/slab.... |
d6c1ef6faa45b6a07a439719084756c3d136fa90 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: Fix Kconfig dependencies for VIDEO_IR | Problem Details:
warning: (VIDEO_GO7007 && STAGING && !STAGING_EXCLUDE_BUILD && VIDEO_DEV && PCI && I2C && INPUT && BKL && SND || VIDEO_CX25821 && STAGING && !STAGING_EXCLUDE_BUILD && DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && BKL) selects VIDEO_IR which has unmet direct dependencies (IR_CORE)
warning: (VIDEO_CX25... | ```diff
diff --git a/drivers/staging/cx25821/Kconfig b/drivers/staging/cx25821/Kconfig
index df7756a95fad..a766d0bed4fb 100644
--- a/drivers/staging/cx25821/Kconfig
+++ b/drivers/staging/cx25821/Kconfig
@@ -4,7 +4,7 @@ config VIDEO_CX25821
select I2C_ALGOBIT
select VIDEO_BTCX
select VIDEO_TVEEPROM
- select VIDEO_... |
693508df9824ecc2bf308a35b58159aa2fecf91f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: IR/imon: protect ictx's kc and last_keycode w/spinlock | Problem Details:
Lest we get our keycodes wrong... Thus far, in practice, I've not found
it to actually matter, but its one of the issues raised in
https://bugzilla.kernel.org/show_bug.cgi?id=16351 that wasn't addressed
by converting to using native IR keydown/up functions.
Signed-off-by: Jarod Wilson <jarod@redhat.co... | ```diff
diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c
index d36fe7239782..4b73b8eaf7dc 100644
--- a/drivers/media/IR/imon.c
+++ b/drivers/media/IR/imon.c
@@ -1,7 +1,7 @@
/*
* imon.c: input and display driver for SoundGraph iMON IR/VFD/LCD
*
- * Copyright(C) 2009 Jarod Wilson <jarod@wilsonet.c... |
8403472f19fea7e7cec7899e998f38b899e59604 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: usbvision: remove BKL from usbvision | Problem Details:
Removed the BKL from usbvision.
There was an initialization bug as well where the i2c bus was registered twice.
Although when the BKL was present no oops was generated, I did run into
other i2c problems. Now that I protect against duplicate i2c registration
that bug is now gone as well.
But trying t... | ```diff
diff --git a/drivers/media/video/usbvision/usbvision-i2c.c b/drivers/media/video/usbvision/usbvision-i2c.c
index 42ba28785750..a5fd2aa3646e 100644
--- a/drivers/media/video/usbvision/usbvision-i2c.c
+++ b/drivers/media/video/usbvision/usbvision-i2c.c
@@ -211,6 +211,9 @@ int usbvision_i2c_register(struct usb_usb... |
479567ce3af7b99d645a3c53b8ca2fc65e46efdc | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: pwc: fully convert driver to V4L2 | Problem Details:
Remove the V4L1 API from this driver, making it fully V4L2.
Also fix a bug where the /dev/videoX device was created too early, which led
to initialization problems of the camera, making it unable to capture video.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <... | ```diff
diff --git a/drivers/media/video/pwc/Kconfig b/drivers/media/video/pwc/Kconfig
index 11980db22d31..8da42e4f1ba0 100644
--- a/drivers/media/video/pwc/Kconfig
+++ b/drivers/media/video/pwc/Kconfig
@@ -1,6 +1,6 @@
config USB_PWC
tristate "USB Philips Cameras"
- depends on VIDEO_V4L1
+ depends on VIDEO_V4L2
--... |
5e765c6e445da16527a04aa3931f21e5deb476d8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: V4L Doc: fix DocBook syntax errors | Problem Details:
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/Documentation/DocBook/v4l/pixfmt.xml b/Documentation/DocBook/v4l/pixfmt.xml
index 5376aefeeffc..f4cc0a9e658e 100644
--- a/Documentation/DocBook/v4l/pixfmt.xml
+++ b/Documentation/DocBook/v4l/pixfmt.xml
@@ -787,14 +787,14 @@ http://www.thedirks.org/winnov/</ulink></para></entry>
<entry>'TM60'<... |
b1e4665b667bcec77d62742fa9238aeac3cb4232 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca - sn9c20x: Fix the number of bytes per line | Problem Details:
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/sn9c20x.c b/drivers/media/video/gspca/sn9c20x.c
index b1c4d74e1c22..4f8ad37ffa25 100644
--- a/drivers/media/video/gspca/sn9c20x.c
+++ b/drivers/media/video/gspca/sn9c20x.c
@@ -347,7 +347,7 @@ static const struct ctrl sd_ctrls[] = {
static const struct v4l2_pix_format vg... |
76391a71543ba0c45e634b31cc33cef1e1be8e79 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: af9015: fix bug introduced by commit 490ade7e3f4474f626a8f5d778ead4e599b94fbc | Problem Details:
Commit 490ade7e3f4474f626a8f5d778ead4e599b94fbc merge conflict fix
leads situation where last nine device definitions were overridden mistakenly.
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c
index 754b126ed176..b5fdcc2cb543 100644
--- a/drivers/media/dvb/dvb-usb/af9015.c
+++ b/drivers/media/dvb/dvb-usb/af9015.c
@@ -1370,7 +1370,7 @@ static struct dvb_usb_device_properties af9015_properties[] = {
.i2c_algo = &a... |
6b81bef8cde141d8d8172a35633af27e17cf487a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: drivers/media/video/em28xx: Remove potential NULL dereference | Problem Details:
If the NULL test is necessary, the initialization involving a dereference of
the tested value should be moved after the NULL test.
The sematic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld... | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 7b9ec6e493e4..95a4b60a1eda 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -277,12 +277,13 @@ static void em28xx_copy_vbi(struct em28xx *dev,
{
vo... |
d7ef485daa657456cad4994873148377b3561b8b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: af9015: add USB ID for Terratec Cinergy T Stick RC MKII | Problem Details:
Adding the USB ID for my TerraTec Electronic GmbH Cinergy T RC MKII
[0ccd:0097] and hooking it up into af9015, on top of your new NXP TDA18218
patches, makes it work for me.
Just the shipped IR remote control doesn't seem to create keycode events
yet (tested with different remote=%d parameters), are t... | ```diff
diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c
index 750a1b515139..55a12df9a2f9 100644
--- a/drivers/media/dvb/dvb-usb/af9015.c
+++ b/drivers/media/dvb/dvb-usb/af9015.c
@@ -1308,6 +1308,7 @@ static struct usb_device_id af9015_usb_table[] = {
/* 30 */{USB_DEVICE(USB_VID_KWO... |
f71d76812e6cd3af8e293eeb8eb465c208e771cc | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx25821: fix gcc warning when compiled with allyesconfig | Problem Details:
drivers/staging/cx25821/cx25821-alsa.c:632: warning: ‘cx25821_audio_pci_tbl’ defined but not used
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/staging/cx25821/cx25821-alsa.c b/drivers/staging/cx25821/cx25821-alsa.c
index bbe36437ac16..2a01dc057b2c 100644
--- a/drivers/staging/cx25821/cx25821-alsa.c
+++ b/drivers/staging/cx25821/cx25821-alsa.c
@@ -629,7 +629,7 @@ static int snd_cx25821_pcm(struct cx25821_audio_dev *chip, int device... |
b6b85ff87b6232ba89fba303b7b7b93c893d3523 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx88: Fix some gcc warnings | Problem Details:
drivers/media/video/cx88/cx88-dsp.c: In function ‘detect_a2_a2m_eiaj’:
drivers/media/video/cx88/cx88-dsp.c:158: warning: ‘carrier_freq’ may be used uninitialized in this function
drivers/media/video/cx88/cx88-dsp.c:158: warning: ‘stereo_freq’ may be used uninitialized in this function
drivers/media/vid... | ```diff
diff --git a/drivers/media/video/cx88/cx88-dsp.c b/drivers/media/video/cx88/cx88-dsp.c
index e1d6eef233dc..2e6a92fbb977 100644
--- a/drivers/media/video/cx88/cx88-dsp.c
+++ b/drivers/media/video/cx88/cx88-dsp.c
@@ -175,13 +175,7 @@ static s32 detect_a2_a2m_eiaj(struct cx88_core *core, s16 x[], u32 N)
stereo_... |
401ad27867781c327855025d4becd5bc30fe7e42 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: tm6000: bugfix param string | Problem Details:
Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/staging/tm6000/tm6000-input.c b/drivers/staging/tm6000/tm6000-input.c
index 54f7667cc706..daca3a5ab70d 100644
--- a/drivers/staging/tm6000/tm6000-input.c
+++ b/drivers/staging/tm6000/tm6000-input.c
@@ -36,7 +36,7 @@ MODULE_PARM_DESC(ir_debug, "enable debug message [IR]");
static unsigned... |
6c2d4dd139de417d18151b98c157aa35387038a3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: V4L2: avoid name conflicts in macros | Problem Details:
"sd" and "err" are too common names to be used in macros for local variables.
Prefix them with an underscore to avoid name clashing.
[mchehab@redhat.com: whitespace cleanups]
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Reviewed-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: M... | ```diff
diff --git a/drivers/media/video/cx18/cx18-driver.h b/drivers/media/video/cx18/cx18-driver.h
index 9bc51a99376b..77be58c1096b 100644
--- a/drivers/media/video/cx18/cx18-driver.h
+++ b/drivers/media/video/cx18/cx18-driver.h
@@ -674,18 +674,25 @@ static inline int cx18_raw_vbi(const struct cx18 *cx)
/* Call th... |
76e241d421e785dacdc8f7a4c39ecc42c8313a9e | Analyze and fix the following issue in the Linux kernel code: gspca/konica: Fix compilation merge conflict | Problem Details:
drivers/media/video/gspca/konica.c: In function ‘sd_start’:
drivers/media/video/gspca/konica.c:322: error: implicit declaration of function ‘usb_buffer_alloc’
drivers/media/video/gspca/konica.c:325: warning: assignment makes pointer from integer without a cast
make[3]: ** [drivers/media/video/gspca/kon... | ```diff
diff --git a/drivers/media/video/gspca/konica.c b/drivers/media/video/gspca/konica.c
index 8cdf1af4257e..3de67ee5c230 100644
--- a/drivers/media/video/gspca/konica.c
+++ b/drivers/media/video/gspca/konica.c
@@ -319,7 +319,7 @@ static int sd_start(struct gspca_dev *gspca_dev)
return -ENOMEM;
}
gspca_de... |
48a232d14c0853854497fb44207fc96d8b7e7dff | Analyze and fix the following issue in the Linux kernel code: m68knommu: Fix MCFUART_TXFIFOSIZE for m548x. | Problem Details:
Serial lines on the MCF548x have really big fifos : 512 bytes.
Signed-off-by: Philippe De Muyter <phdm@macqel.be>
Signed-off-by: Greg Ungerer <gerg@uclinux.org> | ```diff
diff --git a/arch/m68k/include/asm/mcfuart.h b/arch/m68k/include/asm/mcfuart.h
index af16f3be4e19..db72e2b889ca 100644
--- a/arch/m68k/include/asm/mcfuart.h
+++ b/arch/m68k/include/asm/mcfuart.h
@@ -217,7 +217,9 @@ struct mcf_platform_uart {
#define MCFUART_URF_RXS 0xc0 /* Receiver status */
#endif
-#if d... |
ea49f8ffae6262e8de9a0d3e9fcdd384156c7e05 | Analyze and fix the following issue in the Linux kernel code: m68knommu: add basic mmu-less m548x support | Problem Details:
Add a very basic mmu-less support for coldfire m548x family. This is perhaps
also valid for m547x family. The port comprises the serial, tick timer and
reboot support. The gpio part compiles but is empty. This gives a functional
albeit limited linux for the m548x coldfire family. This has been tes... | ```diff
diff --git a/arch/m68k/include/asm/cacheflush_no.h b/arch/m68k/include/asm/cacheflush_no.h
index 89f195656be7..7085bd51668b 100644
--- a/arch/m68k/include/asm/cacheflush_no.h
+++ b/arch/m68k/include/asm/cacheflush_no.h
@@ -29,7 +29,7 @@
static inline void __flush_cache_all(void)
{
-#ifdef CONFIG_M5407
+#if ... |
c8a2786b107873e34d540b8e3e54bd3cef03bc56 | Analyze and fix the following issue in the Linux kernel code: m68knommu: fix strace support for 68328/68360 | Problem Details:
strace enabled is marked using the `flags' field of the `thread_info' struct.
68360 version of entry.S did test a wrong bit in a wrong structure
(task_struct).
68328 version of entry.S did test the right bit in the right structure,
but wrongly, because the `flags' field is 32 bit wide, while the used
... | ```diff
diff --git a/arch/m68knommu/platform/68328/entry.S b/arch/m68knommu/platform/68328/entry.S
index 9d80d2c42866..31a091708317 100644
--- a/arch/m68knommu/platform/68328/entry.S
+++ b/arch/m68knommu/platform/68328/entry.S
@@ -80,7 +80,7 @@ ENTRY(system_call)
movel %sp,%d1 /* get thread_info pointer */
andl #... |
47422259b44e53e670b4ee375ff98f0603e6dd45 | Analyze and fix the following issue in the Linux kernel code: m68knommu: fix default starting date | Problem Details:
Currently m68knommu boards without RTC chip start with an unexpected
default date of 1999-11-30 (Actually the source asks for 2000-00-00)
Make that 1970-01-01 instead, as expected.
Signed-off-by: Philippe De Muyter <phdm@macqel.be>
Signed-off-by: Greg Ungerer <gerg@uclinux.org> | ```diff
diff --git a/arch/m68knommu/kernel/time.c b/arch/m68knommu/kernel/time.c
index a90acf5b0cde..810649341e3e 100644
--- a/arch/m68knommu/kernel/time.c
+++ b/arch/m68knommu/kernel/time.c
@@ -61,13 +61,16 @@ static unsigned long read_rtc_mmss(void)
{
unsigned int year, mon, day, hour, min, sec;
- if (mach_getto... |
f020e2905166e12f9a8f109fe968cb5a9db887e9 | Analyze and fix the following issue in the Linux kernel code: privcmd: MMAPBATCH: Fix error handling/reporting | Problem Details:
On error IOCTL_PRIVCMD_MMAPBATCH is expected to set the top nibble of
the effected MFN and return 0. Currently it leaves the MFN unmodified
and returns the number of failures. Therefore:
- reimplement remap_domain_mfn_range() using direct
HYPERVISOR_mmu_update() calls and small batches. The xen_set_... | ```diff
diff --git a/drivers/xen/xenfs/privcmd.c b/drivers/xen/xenfs/privcmd.c
index 80526afd3063..438223ae0fc3 100644
--- a/drivers/xen/xenfs/privcmd.c
+++ b/drivers/xen/xenfs/privcmd.c
@@ -32,14 +32,16 @@
#include <xen/features.h>
#include <xen/page.h>
+#define REMAP_BATCH_SIZE 16
+
#ifndef HAVE_ARCH_PRIVCMD_MMA... |
8e3e99918b9ccd6bc2369ddbcd74056f8796e1e0 | Analyze and fix the following issue in the Linux kernel code: xenbus: export xen_store_interface for xenfs | Problem Details:
xen_store_interface is needed by xenfs, and xenfs may be a module.
[ Impact: build fix for modular xenfs ]
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> | ```diff
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
index d409495876f1..132939f36020 100644
--- a/drivers/xen/xenbus/xenbus_probe.c
+++ b/drivers/xen/xenbus/xenbus_probe.c
@@ -64,9 +64,11 @@
int xen_store_evtchn;
-EXPORT_SYMBOL(xen_store_evtchn);
+EXPORT_SYMBOL_GPL(xen_store_... |
f31fdf510531333dea95f0a92e6eaa1c3a7541e2 | Analyze and fix the following issue in the Linux kernel code: xen/privcmd: make sure vma is ours before doing anything to it | Problem Details:
Test vma->vm_ops is our operations to make sure we created it.
We don't want to stomp on other random vmas.
[ Impact: bugfix; prevent ioctl from affecting other mappings ]
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> | ```diff
diff --git a/drivers/xen/xenfs/privcmd.c b/drivers/xen/xenfs/privcmd.c
index 6b602f505363..80526afd3063 100644
--- a/drivers/xen/xenfs/privcmd.c
+++ b/drivers/xen/xenfs/privcmd.c
@@ -310,6 +310,8 @@ static int mmap_return_errors(void *data, void *state)
return 0;
}
+static struct vm_operations_struct privc... |
441c7416b55d3d48b4aaafc5bdd804092387d877 | Analyze and fix the following issue in the Linux kernel code: xen/privcmd: print SIGBUS faults | Problem Details:
Print more detail about privcmd mapping faults for debugging.
[ Impact: debug ]
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> | ```diff
diff --git a/drivers/xen/xenfs/privcmd.c b/drivers/xen/xenfs/privcmd.c
index c7192f314f86..6b602f505363 100644
--- a/drivers/xen/xenfs/privcmd.c
+++ b/drivers/xen/xenfs/privcmd.c
@@ -403,6 +403,10 @@ static long privcmd_ioctl(struct file *file,
#ifndef HAVE_ARCH_PRIVCMD_MMAP
static int privcmd_fault(struct vm... |
24a89b5be4cf2b7f1b49b56b6cb4a7b71fccf241 | Analyze and fix the following issue in the Linux kernel code: xen/privcmd: create address space to allow writable mmaps | Problem Details:
These are necessary to allow writeable mmap of the privcmd node to
succeed without being marked read-only for writenotify purposes. Which
in turn is necessary to allow mappings of foreign guest pages
[ Impact: bugfix: allow writable mappings ]
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Sig... | ```diff
diff --git a/drivers/xen/xenfs/super.c b/drivers/xen/xenfs/super.c
index 8c7462866e90..23f1cca5a2e9 100644
--- a/drivers/xen/xenfs/super.c
+++ b/drivers/xen/xenfs/super.c
@@ -12,6 +12,8 @@
#include <linux/module.h>
#include <linux/fs.h>
#include <linux/magic.h>
+#include <linux/mm.h>
+#include <linux/backing... |
f0d3d9894e43fc68d47948e2c6f03e32da88b799 | Analyze and fix the following issue in the Linux kernel code: selinux: include vmalloc.h for vmalloc_user | Problem Details:
Include vmalloc.h for vmalloc_user (fixes ppc build warning).
Acked-by: Eric Paris <eparis@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org> | ```diff
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 3a1739b33b78..223c1ff6ef23 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -51,6 +51,7 @@
#include <linux/mutex.h>
#include <linux/selinux.h>
#include <linux/flex_array.h>
+#include <linux/v... |
ff660c80d00b52287f1f67ee6c115dc0057bcdde | Analyze and fix the following issue in the Linux kernel code: secmark: fix config problem when CONFIG_NF_CONNTRACK_SECMARK is not set | Problem Details:
When CONFIG_NF_CONNTRACK_SECMARK is not set we accidentally attempt to use
the secmark fielf of struct nf_conn. Problem is when that config isn't set
the field doesn't exist. whoops. Wrap the incorrect usage in the config.
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: James Morris <j... | ```diff
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index b3c628555cf3..146476c6441a 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -582,9 +582,11 @@ ctnetlink_conntrack_event(unsigned int events, struct nf_ct_event *item)
... |
15714f7b58011cf3948cab2988abea560240c74f | Analyze and fix the following issue in the Linux kernel code: secmark: do not return early if there was no error | Problem Details:
Commit 4a5a5c73 attempted to pass decent error messages back to userspace for
netfilter errors. In xt_SECMARK.c however the patch screwed up and returned
on 0 (aka no error) early and didn't finish setting up secmark. This results
in a kernel BUG if you use SECMARK.
Signed-off-by: Eric Paris <eparis... | ```diff
diff --git a/net/netfilter/xt_SECMARK.c b/net/netfilter/xt_SECMARK.c
index 23b2d6c486b5..364ad1600129 100644
--- a/net/netfilter/xt_SECMARK.c
+++ b/net/netfilter/xt_SECMARK.c
@@ -101,7 +101,7 @@ static int secmark_tg_check(const struct xt_tgchk_param *par)
switch (info->mode) {
case SECMARK_MODE_SEL:
err... |
3ed02ada2a5e695e2fbb5e4a0008cfcb0f50feaa | Analyze and fix the following issue in the Linux kernel code: AppArmor: Ensure the size of the copy is < the buffer allocated to hold it | Problem Details:
Actually I think in this case the appropriate thing to do is to BUG as there
is currently a case (remove) where the alloc_size needs to be larger than
the copy_size, and if copy_size is ever greater than alloc_size there is
a mistake in the caller code.
Signed-off-by: John Johansen <john.johansen@cano... | ```diff
diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
index 7320331b44ab..544ff5837cb6 100644
--- a/security/apparmor/apparmorfs.c
+++ b/security/apparmor/apparmorfs.c
@@ -29,7 +29,7 @@
* aa_simple_write_to_buffer - common routine for getting policy from user
* @op: operation doing th... |
9b3056cca09529d34af2d81305b2a9c6b622ca1b | Analyze and fix the following issue in the Linux kernel code: tpm: change 'tpm_suspend_pcr' to be module parameter | Problem Details:
Fix the following warning:
drivers/char/tpm/tpm.c:1085: warning: `tpm_suspend_setup' defined but not used
and make the workaround operable in case when TPM is compiled as a module.
As a side-effect the option will be called tpm.suspend_pcr.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Cc: Rajiv And... | ```diff
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 05ad4a17a28f..7c4133582dba 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -47,6 +47,16 @@ enum tpm_duration {
#define TPM_MAX_PROTECTED_ORDINAL 12
#define TPM_PROTECTED_ORDINAL_MASK 0xFF
+/*
+ * Bug workaround - some TPM... |
36f7f28416c97dbb725154930066d115b4447e17 | Analyze and fix the following issue in the Linux kernel code: selinux: fix up style problem on /selinux/status | Problem Details:
This patch fixes up coding-style problem at this commit:
4f27a7d49789b04404eca26ccde5f527231d01d5
selinux: fast status update interface (/selinux/status)
Signed-off-by: KaiGai Kohei <kaigai@ak.jp.nec.com>
Signed-off-by: James Morris <jmorris@namei.org> | ```diff
diff --git a/security/selinux/include/security.h b/security/selinux/include/security.h
index e390e31bb4bf..4b66f19bb1f3 100644
--- a/security/selinux/include/security.h
+++ b/security/selinux/include/security.h
@@ -197,8 +197,7 @@ const char *security_get_initial_sid_context(u32 sid);
extern struct page *selin... |
60272da0341e9eaa136e1dc072bfef72c995d851 | Analyze and fix the following issue in the Linux kernel code: selinux: really fix dependency causing parallel compile failure. | Problem Details:
While the previous change to the selinux Makefile reduced the window
significantly for this failure, it is still possible to see a compile
failure where cpp starts processing selinux files before the auto
generated flask.h file is completed. This is easily reproduced by
adding the following temporary ... | ```diff
diff --git a/security/selinux/Makefile b/security/selinux/Makefile
index c6fa30e2d673..a30f218c33ee 100644
--- a/security/selinux/Makefile
+++ b/security/selinux/Makefile
@@ -2,17 +2,12 @@
# Makefile for building the SELinux module as part of the kernel tree.
#
-obj-$(CONFIG_SECURITY_SELINUX) := selinux.o s... |
ceba72a68d17ee36ef24a71b80dde39ee934ece8 | Analyze and fix the following issue in the Linux kernel code: selinux: fix parallel compile error | Problem Details:
Selinux has an autogenerated file, "flask.h" which is included by
two other selinux files. The current makefile has a single dependency
on the first object file in the selinux-y list, assuming that will get
flask.h generated before anyone looks for it, but that assumption breaks
down in a "make -jN" s... | ```diff
diff --git a/security/selinux/Makefile b/security/selinux/Makefile
index 58d80f3bd6f6..c6fa30e2d673 100644
--- a/security/selinux/Makefile
+++ b/security/selinux/Makefile
@@ -20,7 +20,7 @@ selinux-$(CONFIG_NETLABEL) += netlabel.o
EXTRA_CFLAGS += -Isecurity/selinux -Isecurity/selinux/include
-$(obj)/avc.o: ... |
065d78a0603cc6f8d288e96dbf761b96984b634f | Analyze and fix the following issue in the Linux kernel code: LSM: Fix security_module_enable() error. | Problem Details:
We can set default LSM module to DAC (which means "enable no LSM module").
If default LSM module was set to DAC, security_module_enable() must return 0
unless overridden via boot time parameter.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Serge E. Hallyn <serge@hallyn.co... | ```diff
diff --git a/security/security.c b/security/security.c
index c53949f17d9e..43b6463ebbfb 100644
--- a/security/security.c
+++ b/security/security.c
@@ -89,20 +89,12 @@ __setup("security=", choose_lsm);
* Return true if:
* -The passed LSM is the one chosen by user at boot time,
* -or the passed LSM is confi... |
528ef1b5f3998cd3199926526b4c188d52e4ba7c | Analyze and fix the following issue in the Linux kernel code: ARM: S5PV210: Add si470x radio device to the GONI board | Problem Details:
Add required platform definitions for si470x radio device on Samsung
Goni board.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
[kgene.kim@samsung.com: minor title fixes]
Signed... | ```diff
diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 640b590dc365..634844693cdb 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -81,10 +81,12 @@ config MACH_GONI
select S3C_DEV_HSMMC
select S3C_DEV_HSMMC1
select S3C_DEV_HSMMC2
+ select S3C_DEV_... |
8415d5c41564a9b7c802f26d5a4795ddb823d6ed | Analyze and fix the following issue in the Linux kernel code: ARM: S5PV210: Add support for S6E63M0 LCD controller on GONI board | Problem Details:
Add required platform definitions for S6E63M0 LCD controller on Samsung
Goni board.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
[kgene.kim@samsung.com: minor title fixes]
[kgene.kim@samsung.com: fix build error]
Signed-off-by: Kuk... | ```diff
diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
index 30ad59f6970f..435b68f07086 100644
--- a/arch/arm/mach-s5pv210/mach-goni.c
+++ b/arch/arm/mach-s5pv210/mach-goni.c
@@ -17,6 +17,9 @@
#include <linux/i2c-gpio.h>
#include <linux/mfd/max8998.h>
#include <linux/regulator/fix... |
dc425471b6d4e2a3c1d74745433816fc313f30e7 | Analyze and fix the following issue in the Linux kernel code: ARM: S5PV210: Fix build error on pm debug | Problem Details:
This patch fixes build error by S3C2410 PM Suspend debug option
due to undefined address.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com> | ```diff
diff --git a/arch/arm/mach-s5pv210/include/mach/map.h b/arch/arm/mach-s5pv210/include/mach/map.h
index 12a409f964ca..0e24ba14cd26 100644
--- a/arch/arm/mach-s5pv210/include/mach/map.h
+++ b/arch/arm/mach-s5pv210/include/mach/map.h
@@ -57,6 +57,8 @@
#define S5P_SZ_UART SZ_256
+#define S3C_VA_UARTx(x) (S3C... |
5fdc97b5d95aa8175c085545a4c37bccd45dd950 | Analyze and fix the following issue in the Linux kernel code: ARM: S5PV210: Add support for GPIO Interrupt | Problem Details:
S5PV210/S5PC110 can use common S5P GPIO interrupt code.
This patch adds required defines and code to make use of it.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
[kgene.kim@samsung.com: minor title fixes]
Signed-off-by: Kukjin Kim ... | ```diff
diff --git a/arch/arm/mach-s5pv210/gpiolib.c b/arch/arm/mach-s5pv210/gpiolib.c
index 0d459112d039..29dfb894d4f4 100644
--- a/arch/arm/mach-s5pv210/gpiolib.c
+++ b/arch/arm/mach-s5pv210/gpiolib.c
@@ -150,6 +150,7 @@ static struct s3c_gpio_chip s5pv210_gpio_4bit[] = {
.label = "GPG3",
},
}, {
+ .config ... |
170a46177094b390299d1206748d7f15cd375dc9 | Analyze and fix the following issue in the Linux kernel code: ARM: S5P: Add common S5P GPIO Interrupt support | Problem Details:
This patch adds common code to enable support of GPIO interrupt on
S5P SoCs.
The total number of GPIO pins is quite large on S5P SoCs. Registering
irq support for all of them would be a resource waste. Because of that
the interrupt support for standard GPIO pins is registered dynamically
by the s5p_re... | ```diff
diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig
index 25960966af7c..65dbfa8e0a86 100644
--- a/arch/arm/plat-s5p/Kconfig
+++ b/arch/arm/plat-s5p/Kconfig
@@ -32,6 +32,11 @@ config S5P_EXT_INT
Use the external interrupts (other than GPIO interrupts.)
Note: Do not choose this for S5P6440 ... |
1114275674787ac2f5f27f2c10368890d27fae1c | Analyze and fix the following issue in the Linux kernel code: ARM: S5PV310: Fix physical address of System Controller Register | Problem Details:
The physical address of SYSCON(System Controller) is wrong.
This patch fixs this wrong physical address value from 0x10020000 to 0x10010000.
Signed-off-by: Boojin Kim <boojin.kim@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com> | ```diff
diff --git a/arch/arm/mach-s5pv310/include/mach/map.h b/arch/arm/mach-s5pv310/include/mach/map.h
index 75236536c4df..8014c3a6dd5d 100644
--- a/arch/arm/mach-s5pv310/include/mach/map.h
+++ b/arch/arm/mach-s5pv310/include/mach/map.h
@@ -34,7 +34,7 @@
#define S5PV310_PA_CHIPID (0x10000000)
#define S5P_PA_CHIPID... |
8f3b9cff23ed15c1ef2f4e60c677f3c7d5e535ce | Analyze and fix the following issue in the Linux kernel code: ARM: S5PV310: Fix clkset_moutcore_list | Problem Details:
This patch fixes source clocks of moutcore.
That should be clk_mout_apll instead of clk_sclk_apll.
Signed-off-by: Jaecheol Lee <jc.lee@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com> | ```diff
diff --git a/arch/arm/mach-s5pv310/clock.c b/arch/arm/mach-s5pv310/clock.c
index 262a46fef5b7..32146db1f451 100644
--- a/arch/arm/mach-s5pv310/clock.c
+++ b/arch/arm/mach-s5pv310/clock.c
@@ -155,7 +155,7 @@ static struct clksrc_clk clk_mout_mpll = {
};
static struct clk *clkset_moutcore_list[] = {
- [0] = &... |
240634e9b3a8ae2a9e2b7effeea3b9a5b30d68fb | Analyze and fix the following issue in the Linux kernel code: ceph: fix num_pages_free accounting in pagelist | Problem Details:
Decrement the free page counter when removing a page from the free_list.
Signed-off-by: Sage Weil <sage@newdream.net> | ```diff
diff --git a/net/ceph/pagelist.c b/net/ceph/pagelist.c
index b8cbc456d0bb..13cb409a7bba 100644
--- a/net/ceph/pagelist.c
+++ b/net/ceph/pagelist.c
@@ -37,6 +37,7 @@ static int ceph_pagelist_addpage(struct ceph_pagelist *pl)
} else {
page = list_first_entry(&pl->free_list, struct page, lru);
list_del(&pa... |
6f453ed6c07dbed83b368269c9c0fb170866ee71 | Analyze and fix the following issue in the Linux kernel code: ceph: fix debugfs warnings | Problem Details:
Include "super.h" outside of CONFIG_DEBUG_FS to eliminate a compiler warning:
fs/ceph/debugfs.c:266: warning: 'struct ceph_fs_client' declared inside parameter list
fs/ceph/debugfs.c:266: warning: its scope is only this definition or declaration, which is probably not what you want
fs/ceph/debugfs.c:2... | ```diff
diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
index 94fe1d284c3a..7ae1b3d55b58 100644
--- a/fs/ceph/debugfs.c
+++ b/fs/ceph/debugfs.c
@@ -12,9 +12,10 @@
#include <linux/ceph/auth.h>
#include <linux/ceph/debugfs.h>
+#include "super.h"
+
#ifdef CONFIG_DEBUG_FS
-#include "super.h"
#include "mds_client... |
932967202182743c01a2eee4bdfa2c42697bc586 | Analyze and fix the following issue in the Linux kernel code: x86: Spread tlb flush vector between nodes | Problem Details:
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has di... | ```diff
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index c03f14ab6667..49358481c733 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -5,6 +5,7 @@
#include <linux/smp.h>
#include <linux/interrupt.h>
#include <linux/module.h>
+#include <linux/cpu.h>
#include <asm/tlbflush.h>
#include <asm/mmu_cont... |
b5dc608c98d929abbf2fe932ed07b3c868d83342 | Analyze and fix the following issue in the Linux kernel code: drm/i915: Copy the updated reloc->presumed_offset back to the user | Problem Details:
If the userspace driver is using a constant relocation array with a
static buffer, they will pass the same relocation array back to the
kernel. So we *do* need to update the presumed offset value in those
relocations to reflect the current object so that they remain correct
with future batchbuffers and... | ```diff
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 6e85496f9164..5041ebe3fdf9 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3399,6 +3399,15 @@ i915_gem_execbuffer_relocate(struct drm_i915_gem_object *obj,
iowrite32(reloc.delta, reloc... |
f01f7c56a1425b9749a99af821e1de334fb64d7e | Analyze and fix the following issue in the Linux kernel code: x86, mm: Fix incorrect data type in vmalloc_sync_all() | Problem Details:
arch/x86/mm/fault.c: In function 'vmalloc_sync_all':
arch/x86/mm/fault.c:238: warning: assignment makes integer from pointer without a cast
introduced by 617d34d9e5d8326ec8f188c616aa06ac59d083fe.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
LKML-Reference: <20101020103642.GA3135@kryptos.o... | ```diff
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 6c27c39f8a37..0cdb8d493f61 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -230,7 +230,7 @@ void vmalloc_sync_all(void)
spin_lock_irqsave(&pgd_lock, flags);
list_for_each_entry(page, &pgd_list, lru) {
spinlock_t *pgt_lock;
- ... |
cb174681a9ececa6702f114b85bdf82144b6a5af | Analyze and fix the following issue in the Linux kernel code: HID: hidraw: fix window in hidraw_release | Problem Details:
There is a window between hidraw_table check and its dereference.
In that window, the device may be unplugged and removed form the
system and we will then dereference NULL.
Lock that place properly so that either we get NULL and jump out or we
can work with real pointer.
Signed-off-by: Jiri Slaby <js... | ```diff
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index 47d70c523d93..5a6f99b1db12 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -212,9 +212,13 @@ static int hidraw_release(struct inode * inode, struct file * file)
unsigned int minor = iminor(inode);
struct hidraw *dev;
struct hid... |
e0e451ea092915fa683e5fe7a9e52df33726a5ac | Analyze and fix the following issue in the Linux kernel code: ARM: S3C24XX: Fix gpiolib support for ports K..M | Problem Details:
S3C2443 and S3C2416 has 12 GPIO banks (from A to M), increase
ARCH_NR_GPIOS for this architectures.
Also typo from previous commit has been fixed: CONFIG_CPU_S3C24XX
instead CONFIG_CPU_244X.
Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
Tested-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off... | ```diff
diff --git a/arch/arm/mach-s3c2410/include/mach/gpio.h b/arch/arm/mach-s3c2410/include/mach/gpio.h
index b649bf2ccd5c..f7f6b07df30e 100644
--- a/arch/arm/mach-s3c2410/include/mach/gpio.h
+++ b/arch/arm/mach-s3c2410/include/mach/gpio.h
@@ -22,6 +22,8 @@
#ifdef CONFIG_CPU_S3C244X
#define ARCH_NR_GPIOS (32 * 9... |
f13d493d9cf772d510d78ae00bb9f4d680b3170b | Analyze and fix the following issue in the Linux kernel code: netpoll: Revert napi_poll fix for bonding driver | Problem Details:
In an erlier patch I modified napi_poll so that devices with IFF_MASTER polled
the per_cpu list instead of the device list for napi. I did this because the
bonding driver has no napi instances to poll, it instead expects to check the
slave devices napi instances, which napi_poll was unaware of. Looki... | ```diff
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index d79d221fd1f4..4e98ffac3af0 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -156,15 +156,8 @@ static void poll_napi(struct net_device *dev)
{
struct napi_struct *napi;
int budget = 16;
- struct softnet_data *sd = &__get_cpu_var(softnet_d... |
9ff76c951c5194d44a7cdce51d807d67fc3ae514 | Analyze and fix the following issue in the Linux kernel code: netpoll: Remove netpoll blocking from uninit path | Problem Details:
Some recent testing in netpoll with bonding showed this backtrace
------------[ cut here ]------------
kernel BUG at drivers/net/bonding/bonding.h:134!
invalid opcode: 0000 [#1] SMP
last sysfs file: /sys/devices/pci0000:00/0000:00:1d.2/usb7/devnum
CPU 0
Pid: 1876, comm: rmmod Not tainted 2.6.36-... | ```diff
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index ecbe206f90d1..6b9a7bd8ec14 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2082,7 +2082,6 @@ static int bond_release_all(struct net_device *bond_dev)
struct net_device *slave_dev;
stru... |
dd04bb12d047a4d4461772093472a40dbe171e5f | Analyze and fix the following issue in the Linux kernel code: ALSA: snd-aloop - fix locking issues (running flag updates) | Problem Details:
On SMP machines, the cable->running update must be atomic, otherwise
stream is not started correctly sometimes.
Signed-off-by: Jaroslav Kysela <perex@perex.cz> | ```diff
diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c
index 66786ea6f480..38e8351e935d 100644
--- a/sound/drivers/aloop.c
+++ b/sound/drivers/aloop.c
@@ -263,13 +263,17 @@ static int loopback_trigger(struct snd_pcm_substream *substream, int cmd)
return err;
dpcm->last_jiffies = jiffies;
dpcm->pcm... |
c293393faa8e11a5a80a9e358718432b8697f451 | Analyze and fix the following issue in the Linux kernel code: arm: use addruart macro to establish debug mappings | Problem Details:
Since we can get both physical and virtual addresses from the addruart
macro, we can use this to establish the debug mappings.
In the case of CONFIG_DEBUG_ICEDCC, we don't need any mappings, but
may still need to setup r7 correctly.
Incorporating ASM changes from Nicolas Pitre <npitre@fluxnic.net>.
... | ```diff
diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S
index 767390449e0a..dd6b369ac69c 100644
--- a/arch/arm/kernel/head.S
+++ b/arch/arm/kernel/head.S
@@ -22,6 +22,10 @@
#include <asm/thread_info.h>
#include <asm/system.h>
+#ifdef CONFIG_DEBUG_LL
+#include <mach/debug-macro.S>
+#endif
+
#if (PHYS_O... |
1ea64615601229f0dc16dee91dc5b50216411baa | Analyze and fix the following issue in the Linux kernel code: arm/debug: consolidate addruart macros for CONFIG_DEBUG_ICEDCC | Problem Details:
We have the same (empty) macro for all IDEDCC flavours, so consolidate
it to one.
Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com> | ```diff
diff --git a/arch/arm/kernel/debug.S b/arch/arm/kernel/debug.S
index a38b4879441d..f91395206a4b 100644
--- a/arch/arm/kernel/debug.S
+++ b/arch/arm/kernel/debug.S
@@ -22,11 +22,11 @@
#if defined(CONFIG_DEBUG_ICEDCC)
@@ debug using ARM EmbeddedICE DCC channel
-#if defined(CONFIG_CPU_V6)
-
.macro addruar... |
27afdf2008da0b8878a73e32e4eb12381b84e224 | Analyze and fix the following issue in the Linux kernel code: apic, x86: Use BIOS settings for IBS and MCE threshold interrupt LVT offsets | Problem Details:
We want the BIOS to setup the EILVT APIC registers. The offsets
were hardcoded and BIOS settings were overwritten by the OS.
Now, the subsystems for MCE threshold and IBS determine the LVT
offset from the registers the BIOS has setup. If the BIOS setup
is buggy on a family 10h system, a workaround enab... | ```diff
diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
index 1fa03e04ae44..286de34b0ed6 100644
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -252,9 +252,7 @@ static inline int apic_is_clustered_box(void)
}
#endif
-extern u8 setup_APIC_eilvt_mce(u8 vector, u8 msg_type... |
a68c439b1966c91f0ef474e2bf275d6792312726 | Analyze and fix the following issue in the Linux kernel code: apic, x86: Check if EILVT APIC registers are available (AMD only) | Problem Details:
This patch implements checks for the availability of LVT entries
(APIC500-530) and reserves it if used. The check becomes
necessary since we want to let the BIOS provide the LVT offsets.
The offsets should be determined by the subsystems using it
like those for MCE threshold or IBS. On K8 only offset... | ```diff
diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h
index 7fe3b3060f08..a859ca461fb0 100644
--- a/arch/x86/include/asm/apicdef.h
+++ b/arch/x86/include/asm/apicdef.h
@@ -131,6 +131,7 @@
#define APIC_EILVTn(n) (0x500 + 0x10 * n)
#define APIC_EILVT_NR_AMD_K8 1 /* # of extended interrup... |
ae1007d37e00144b72906a4bdc47d517ae91bcc1 | Analyze and fix the following issue in the Linux kernel code: NFSv4: Don't call nfs4_state_mark_reclaim_reboot() from error handlers | Problem Details:
In the case of a server reboot, the state recovery thread starts by calling
nfs4_state_end_reclaim_reboot() in order to avoid edge conditions when
the server reboots while the client is in the middle of recovery.
However, if the client has already marked the nfs4_state as requiring
reboot recovery, th... | ```diff
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 7f25246bf38c..88a9d93ec1bd 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -255,9 +255,6 @@ static int nfs4_handle_exception(const struct nfs_server *server, int errorcode,
nfs4_state_mark_reclaim_nograce(clp, state);
goto do_state_recov... |
b0ed9dbc24f1fd912b2dd08b995153cafc1d5b1c | Analyze and fix the following issue in the Linux kernel code: NFSv4: Fix open recovery | Problem Details:
NFSv4 open recovery is currently broken: since we do not clear the
state->flags states before attempting recovery, we end up with the
'can_open_cached()' function triggering. This again leads to no OPEN call
being put on the wire.
Reported-by: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Trond My... | ```diff
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index aee1bcc1fcc9..7f25246bf38c 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1118,6 +1118,7 @@ static int nfs4_open_recover(struct nfs4_opendata *opendata, struct nfs4_state *
clear_bit(NFS_DELEGATED_STATE, &state->flags);
smp_rmb();
if (st... |
3234282f33b29d349bcada40204fc7c8fda7fe72 | Analyze and fix the following issue in the Linux kernel code: x86, asm: Fix CFI macro invocations to deal with shortcomings in gas | Problem Details:
gas prior to (perhaps) 2.16.90 has problems with passing non-
parenthesized expressions containing spaces to macros. Spaces, however,
get inserted by cpp between any macro expanding to a number and a
subsequent + or -. For the +, current x86 gas then removes the space
again (future gas may not do so), ... | ```diff
diff --git a/Kbuild b/Kbuild
index e3737ad72b5a..399593942a9b 100644
--- a/Kbuild
+++ b/Kbuild
@@ -53,7 +53,7 @@ targets += arch/$(SRCARCH)/kernel/asm-offsets.s
# Default sed regexp - multiline due to syntax constraints
define sed-y
"/^->/{s:->#\(.*\):/* \1 */:; \
- s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#d... |
44235dcde416104b8e1db7606c283f4c0149c760 | Analyze and fix the following issue in the Linux kernel code: x86, mm: Fix bogus whitespace in sync_global_pgds() | Problem Details:
Whitespace cleanup only.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com> | ```diff
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 74f0f358b07b..1ad7c0ff5d2b 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -103,28 +103,28 @@ __setup("noexec32=", nonx32_setup);
*/
void sync_global_pgds(unsigned long start, unsigned long end)
{
- unsigned long addres... |
d38a5edf812c2f715242aa20b6beb785939a0096 | Analyze and fix the following issue in the Linux kernel code: ACPI dock: move some functions to .init.text | Problem Details:
find_dock and find_bay are only called by dock_init which lives in
.init.text dock_add is only called by find_dock and find_bay. So all
three functions can be moved to .init.text, too.
This fixes:
WARNING: vmlinux.o(.text+0x2134b7): Section mismatch in reference from the function dock_add() ... | ```diff
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 3fe29e992be8..2b1656322ee2 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -929,7 +929,7 @@ static struct attribute_group dock_attribute_group = {
* allocated and initialize a new dock station device. Find all devices
* that are on ... |
cd389a34a182639e8b6bf0e812fe8ec038bfddc5 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: brcmfmac: add debugfs, display wi-fi statistics | Problem Details:
Add debugfs to display wi-fi profile/statistics.
Initially some profile parameters such as dtim_period,
beacon_int will be seen at
/sys/kernel/debug/ieee80211/phy#/netdev:eth#.
This will provide users with current connection status.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kro... | ```diff
diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
index 5bda8569cfc6..621521b9e408 100644
--- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
@@ -333,6 +333,12 @@ static __used s32 wl_update_... |
bd384c2722428498669840db44c6a7aafab54c29 | Analyze and fix the following issue in the Linux kernel code: Staging: frontier: fix coding style issues in tranzport.c | Problem Details:
This is a patch to the tranzport.c file that fixes up the following issue
WARNING: please, no space for starting a line x 23
Signed-off-by: Gustavo Silva <silvagustavo@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/frontier/tranzport.c b/drivers/staging/frontier/tranzport.c
index d33e1760b3a6..cde02839258a 100644
--- a/drivers/staging/frontier/tranzport.c
+++ b/drivers/staging/frontier/tranzport.c
@@ -174,37 +174,37 @@ static void usb_tranzport_abort_transfers(struct usb_tranzport *dev)
us... |
e2cc502c3f71d8de812893527dc435e61b7fe604 | Analyze and fix the following issue in the Linux kernel code: MIPS: O32 compat/N32: Fix to use compat syscall wrappers for AIO syscalls. | Problem Details:
[Ralf: Michel's original patch only fixed N32; I replicated the same fix
for O32.]
Signed-off-by: Michel Thebeau <michel.thebeau@windriver.com>
Cc: paul.gortmaker@windriver.com
Cc: bruce.ashfield@windriver.com
Signed-off-by: Ralf Baechle <ralf@linux-mips.org> | ```diff
diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
index a3d66137731a..79c27d1f5f9e 100644
--- a/arch/mips/kernel/scall64-n32.S
+++ b/arch/mips/kernel/scall64-n32.S
@@ -320,10 +320,10 @@ EXPORT(sysn32_call_table)
PTR sys_cacheflush
PTR sys_cachectl
PTR sys_sysmips
- PTR sys_io_se... |
08be7b2bc7393d5cf4beb00aecb5eb9e5cde5f85 | Analyze and fix the following issue in the Linux kernel code: MIPS: jz4740: Fix Kbuild Platform file. | Problem Details:
The platform specific files should be included via the platform-y
variable.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Patchwork: https://patchwork.linux-mips.org/patch/1719/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org> | ```diff
diff --git a/arch/mips/jz4740/Platform b/arch/mips/jz4740/Platform
index 6a97230e3d05..ba91be9c21ef 100644
--- a/arch/mips/jz4740/Platform
+++ b/arch/mips/jz4740/Platform
@@ -1,3 +1,3 @@
-core-$(CONFIG_MACH_JZ4740) += arch/mips/jz4740/
+platform-$(CONFIG_MACH_JZ4740) += jz4740/
cflags-$(CONFIG_MACH_JZ4740) += ... |
c694ed85eab4e7966cd83fca509ce27494e3e296 | Analyze and fix the following issue in the Linux kernel code: Staging: cxt1e1: multiple definition of max_mtu fix | Problem Details:
eliminate multiple definition of max_mtu by renaming
with cxt1e1_ prefix, similarly rename max_mru
Signed-off-by: Bob Beers <bbeers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index eb0f4bdf6273..c7930287e3db 100644
--- a/drivers/staging/cxt1e1/linux.c
+++ b/drivers/staging/cxt1e1/linux.c
@@ -112,13 +112,13 @@ int log_level = LOG_ERROR;
int log_level_default = LOG_ERROR;
module_param(log_le... |
b3495cebaaa64c9e6df9ab663dfb75e86a08f9ce | Analyze and fix the following issue in the Linux kernel code: staging: speakup: fix memory leak | Problem Details:
speakup_init() didn't free first_console if speakup_kobj_init() fails.
Also propagate speakup_kobj_init()'s return code.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index a64704bd19bf..4b7a9c2b965f 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2259,8 +2259,11 @@ static int __init speakup_init(void)
first_console = kzalloc(sizeof(*first_console), GFP_KERNEL)... |
6a56486716d54d2c16c46cde6a5cf10062cd6719 | Analyze and fix the following issue in the Linux kernel code: staging: speakup: fix leaks of sysfs groups | Problem Details:
speakup_kobj_init() and speakup_kobj_exit() didn't remove
i18n_attr_group and main_attr_group sysfs groups.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index e12b0e7c0ad6..cc79f9edfe9e 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -989,24 +989,34 @@ int speakup_kobj_init(void)
speakup_kobj = kobject_create_and_add("speakup", ac... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.