id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
48a6a468198aadb54bc5d3fdd065364d43ff5197 | Analyze and fix the following issue in the Linux kernel code: ath9k: fix enabling ANI / tx monitor after bg scan | Problem Details:
ath9k's entire logic with SC_OP_SCANNING is incorrect due to the
way mac80211 currently implements the scan complete callback and
we handle it in ath9k. This patch removes the flag completely in
preference for the SC_OP_OFFCHANNEL which is really what we wanted.
The scanning flag was used to ensure we... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index c8ff417f6c10..98b57e6c614e 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -563,7 +563,6 @@ struct ath_ant_comb {
#define SC_OP_RXFLUSH BIT(7)
#... |
52b8ac92496e03d6b5619204d7f3bae6ce6eae45 | Analyze and fix the following issue in the Linux kernel code: ath9k: fix regression on beacon loss after bgscan | Problem Details:
When we return to the home channel we were never reseting our beacon
timers, this was casued by the fact that the scanning flag was still
on even after we returned to our home channel. There are also other
reasons why we would get a reset and if we are not off channel
we always need to resynch our beac... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 1dd8768c63dc..3295c638f7e3 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -258,9 +258,11 @@ int ath_set_channel(struct ath_softc *sc, struct ieee80211_hw *hw,
if ... |
8ab2cd09fecc8819bbaee2d0fd8f3a092d866ce3 | Analyze and fix the following issue in the Linux kernel code: ath9k: fix power save race conditions | Problem Details:
ath9k has a race on putting the chip into network sleep and
having registers read from hardware. The race occurs because
although ath9k_ps_restore() locks its own callers it makes use
of some variables which get altered in the driver at different
code paths. The variables are the ps_enabled and ps_flag... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index fa875d1c7e91..1dd8768c63dc 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1554,6 +1554,8 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
* IEEE... |
0f529e98498ff1a8bb264958b5fe7c0aa308d5dc | Analyze and fix the following issue in the Linux kernel code: ath9k_htc: Fix register read through bulk pipe | Problem Details:
To optimize register read/write operations, the HTC firmwares were patched
to change EP3 and EP4 pipe types from Interrupt to Bulk. So register writes
are submitted as bulk urbs, but register reads are not. Also changing the
register read endpoint pipe as bulk type when URBs are filled improves the
reg... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index 27f88a0a155b..728d904c74d7 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -541,7 +541,8 @@ static void ath9k_hif_usb_reg_in_cb(struct urb *urb)
}
... |
f799a301abf77b87133d624164d28dc2b521e99d | Analyze and fix the following issue in the Linux kernel code: ath9k_hw: remove warning in ath9k_hw_def_get_num_ant_config | Problem Details:
This patch fixes following warning
drivers/net/wireless/ath/ath9k/eeprom_def.c: In function 'ath9k_hw_def_get_num_ant_config'
drivers/net/wireless/ath/ath9k/eeprom_def.c:1425:47: warning: comparison
between 'enum ath9k_hal_freq_band' and 'enum ieee80211_band'
Signed-off-by: Rajkumar Manoharan <rma... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index b883b174385b..e2ae98feb0be 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -968,7 +968,7 @@ static int ath9k_hw_ar9300_get_eeprom... |
20c956dfbeec823082054954b2443e736455418b | Analyze and fix the following issue in the Linux kernel code: iwlwifi: fix sparse warning about wrong enum for band parameter | Problem Details:
drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: warning: mixing different enum types
drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: int enum nl80211_band versus
drivers/net/wireless/iwlwifi/iwl-scan.c:386:27: int enum ieee80211_band
drivers/net/wireless/iwlwifi/iwl-scan.c:435:57: warning: mix... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index 599573f2b01f..c54c20023e7c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -350,7 +350,7 @@ EXPORT_SYMBOL(iwl_init_scan_params);
static int __must_check iwl... |
a871869245d79ab8d8ee465139144c7cb89e1854 | Analyze and fix the following issue in the Linux kernel code: staging: keucr: fix keucr lost disconnect | Problem Details:
keucr lost the disconnect,
so keucr crash when plug-in and then plug-out SD-card quickly.
unmark the part of usb disconnect
Signed-off-by: Al Cho <acho@novell.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/keucr/usb.c b/drivers/staging/keucr/usb.c
index 260828ea8eaf..606053db069e 100644
--- a/drivers/staging/keucr/usb.c
+++ b/drivers/staging/keucr/usb.c
@@ -21,6 +21,8 @@ MODULE_AUTHOR("Domao");
MODULE_DESCRIPTION("ENE USB Mass Storage driver for Linux");
MODULE_LICENSE("GPL");
+st... |
2503a26554c7e73c544fc97f47c1d41faa88bd07 | Analyze and fix the following issue in the Linux kernel code: staging: comedi: fix signess bug | Problem Details:
ai_count and ao_counter are unsigned, check for < 0 doesn't make sense.
Cast them to int.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 9b1dd3cc2120..2583e16cd02a 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -3078,7 +3078,7 @@ static void handle_ai_interrupt(struct come... |
cae16a1742ad3cc19f15e78b821b94448e330ad9 | Analyze and fix the following issue in the Linux kernel code: staging: crystalhd: fix signed bug | Problem Details:
chd_dec_major is unsigned, so check chd_dec_major < 0 doesn't make sense.
Since it is used as signed, declare it as int.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.h b/drivers/staging/crystalhd/crystalhd_lnx.h
index c951e43cbb3d..a2b5a56be6dd 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.h
+++ b/drivers/staging/crystalhd/crystalhd_lnx.h
@@ -76,7 +76,7 @@ struct crystalhd_adp {
spinlock_t lock;
/* API Relat... |
3850a8ae43a1d93cda1f9a9132d41b98d825f6a3 | Analyze and fix the following issue in the Linux kernel code: staging: solo6010: fix signess bug | Problem Details:
video_nr is unsigned, so check video_nr >= 0 doesn't make sense.
The only "negative" value may be -1, so explicitly check for it.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/solo6x10/solo6010-v4l2-enc.c b/drivers/staging/solo6x10/solo6010-v4l2-enc.c
index f114b4b7d8ee..bbf3d9c4abb0 100644
--- a/drivers/staging/solo6x10/solo6010-v4l2-enc.c
+++ b/drivers/staging/solo6x10/solo6010-v4l2-enc.c
@@ -1497,7 +1497,7 @@ static struct solo_enc_dev *solo_enc_alloc(... |
2427924cb02c4886ec298094d18d15eb511ebc14 | Analyze and fix the following issue in the Linux kernel code: staging: ST_BT depends on RFKILL | Problem Details:
Fix kconfig unmet dependency warning:
warning: (ST_BT && STAGING && !STAGING_EXCLUDE_BUILD && BT) selects TI_ST which has unmet direct dependencies (RFKILL)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/ti-st/Kconfig b/drivers/staging/ti-st/Kconfig
index 68ad3d0b84a7..858062dbed76 100644
--- a/drivers/staging/ti-st/Kconfig
+++ b/drivers/staging/ti-st/Kconfig
@@ -16,7 +16,7 @@ config TI_ST
config ST_BT
tristate "BlueZ bluetooth driver for ST"
- depends on BT
+ depends on BT && ... |
5fe1f1edb916aa4f573563449ceccd1b468aedda | Analyze and fix the following issue in the Linux kernel code: staging/bcm: fix build for CONFIG_PM not enabled | Problem Details:
Handle build case of CONFIG_PM not being enabled.
drivers/staging/bcm/InterfaceInit.c:280: error: 'struct usb_device' has no member named 'autosuspend_delay'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c
index e06f168a52bd..d22a0e52a046 100644
--- a/drivers/staging/bcm/InterfaceInit.c
+++ b/drivers/staging/bcm/InterfaceInit.c
@@ -277,6 +277,7 @@ usbbcm_device_probe(struct usb_interface *intf, const struct usb_device_id *id)
... |
3e8acee461f3bdcec0a0a5cbf2886710a21a6662 | Analyze and fix the following issue in the Linux kernel code: staging/bcm: fix printk format warnings | Problem Details:
Fix lots of printk format warnings in bcm. Here is a sample of them:
drivers/staging/bcm/CmHost.c:1955: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
drivers/staging/bcm/CmHost.c:1955: warning: format '%x' expects type 'unsigned int', but argument 2 has... | ```diff
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 489487a6edb6..b23986291894 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++ b/drivers/staging/bcm/Bcmchar.c
@@ -1141,7 +1141,7 @@ static INT bcm_char_ioctl(struct inode *inode, struct file *filp,
}
if(IoBuffer.OutputLength < ... |
e23f773ee481aac96814aa9a4dbb0a7a4e0e9a7a | Analyze and fix the following issue in the Linux kernel code: staging/keucr: fix build when CONFIG_PM is not enabled | Problem Details:
keucr driver has a build error when CONFIG_PM is not enabled, so fix that.
drivers/staging/keucr/usb.c:42: error: 'struct us_data' has no member named 'suspend_resume_hook'
drivers/staging/keucr/usb.c:43: error: 'struct us_data' has no member named 'suspend_resume_hook'
drivers/staging/keucr/usb.c:64:... | ```diff
diff --git a/drivers/staging/keucr/usb.c b/drivers/staging/keucr/usb.c
index d7dab727cd6f..260828ea8eaf 100644
--- a/drivers/staging/keucr/usb.c
+++ b/drivers/staging/keucr/usb.c
@@ -30,6 +30,7 @@ static struct usb_device_id eucr_usb_ids [] = {
MODULE_DEVICE_TABLE (usb, eucr_usb_ids);
+#ifdef CONFIG_PM
... |
e0f8c2a9b879e1e65d588a40a3c88db69a7d6956 | Analyze and fix the following issue in the Linux kernel code: ath5k: Use common ath key management functions | Problem Details:
Use common ath key management functions in ath5k. This fixes problems with HW
encryption in AP mode, which was broken in the ath5k implementation.
Before (with the ath5k implementation) only one client could connect to the AP
using HW encryption and WPA. When a second client connected, the first clien... | ```diff
diff --git a/drivers/net/wireless/ath/ath5k/attach.c b/drivers/net/wireless/ath/ath5k/attach.c
index aabad4f13e2a..eb125d69fb78 100644
--- a/drivers/net/wireless/ath/ath5k/attach.c
+++ b/drivers/net/wireless/ath/ath5k/attach.c
@@ -314,6 +314,9 @@ int ath5k_hw_attach(struct ath5k_softc *sc)
}
/* Crypto set... |
01ea50638bc04ca5259f5711fcdedefcdde1cf43 | Analyze and fix the following issue in the Linux kernel code: block: Fix race during disk initialization | Problem Details:
When a new disk is being discovered, add_disk() first ties the bdev to gendisk
(via register_disk()->blkdev_get()) and only after that calls
bdi_register_bdev(). Because register_disk() also creates disk's kobject, it
can happen that userspace manages to open and modify the device's data (or
inode) bef... | ```diff
diff --git a/block/genhd.c b/block/genhd.c
index 5c9c503de423..7923e720ddf5 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -541,13 +541,15 @@ void add_disk(struct gendisk *disk)
disk->major = MAJOR(devt);
disk->first_minor = MINOR(devt);
+ /* Register BDI before referencing it from bdev */
+ bdi = &di... |
b23909695c33f53df5f1d16696b1aa5b874c1904 | Analyze and fix the following issue in the Linux kernel code: netfilter: nf_conntrack: fix the hash random initializing race | Problem Details:
nf_conntrack_alloc() isn't called with nf_conntrack_lock locked, so hash
random initializing code maybe executed more than once on different
CPUs.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net> | ```diff
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
index df3eedb142ff..4c0ad9b4dba0 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/netfilter/nf_conntrack_core.c
@@ -65,8 +65,7 @@ EXPORT_SYMBOL_GPL(nf_conntrack_max);
DEFINE_PER_CPU(struct nf_conn, nf_conntrack_untracked... |
30ea098fc000bb05081a1999269658f1a88af36a | Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Fix input-pin setup for Realtek codecs | Problem Details:
Through the transition of autocfg to individual inputs array, I forgot
to rewrite the argument passed to alc_set_input_pin(). This resulted in
wrongly setup input pins. Fixed now.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 945826da23b6..5df88798895b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5160,7 +5160,7 @@ static void alc880_auto_init_analog_input(struct hda_codec *codec)
for (i = 0; i < cfg->num_inputs; i... |
5855fb8076e784a657bc2441cd29f166c7c1ea8c | Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Fix initialization of secondary headphone and speaker | Problem Details:
The secondary or later headphones or speakers aren't initialized preoprly
for some codecs.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ab2947d87232..945826da23b6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10634,16 +10634,21 @@ static void alc882_auto_init_hp_out(struct hda_codec *codec)
{
struct alc_spec *spec = codec->sp... |
16d3ea26f82271fef9b1c4523b5e1ea31fa39eec | Analyze and fix the following issue in the Linux kernel code: [SCSI] Fix VPD inquiry page wrapper | Problem Details:
Fix two bugs in the VPD page wrapper:
- Don't return failure if the user asked for page 0
- The end of buffer check failed to account for the page header size
and consequently didn't work
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Stable Tree <stable@kernel.org>... | ```diff
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index ad0ed212db4a..348fba0a8976 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -1046,13 +1046,13 @@ int scsi_get_vpd_page(struct scsi_device *sdev, u8 page, unsigned char *buf,
/* If the user actually wanted this page, we can skip the re... |
a0572d93c13d28cc25b2c286ec9378eeb4ddd46c | Analyze and fix the following issue in the Linux kernel code: mac80211: disallow seeks in minstrel debug code | Problem Details:
No need for seek here, so let's just use nonseekable_open.
Signed-off-by: Arnd Bergmann <arnd@arndb.de> | ```diff
diff --git a/net/mac80211/rc80211_minstrel_ht_debugfs.c b/net/mac80211/rc80211_minstrel_ht_debugfs.c
index 4a5a4b3e7799..cefcb5d2dae6 100644
--- a/net/mac80211/rc80211_minstrel_ht_debugfs.c
+++ b/net/mac80211/rc80211_minstrel_ht_debugfs.c
@@ -90,7 +90,7 @@ minstrel_ht_stats_open(struct inode *inode, struct file... |
c0b0aca0e0e8c479c43c1e126cddc5fc82b2803a | Analyze and fix the following issue in the Linux kernel code: arm/omap: use generic_file_llseek in iommu_debug | Problem Details:
In future kernels, debugfs files need to specify
the llseek operation explicitly to allow seeking.
This sets the llseek operation in the omap iommu
debugfs files to generic_file_llseek, which is
appropriate for files using simple_read_from_buffer.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Tony ... | ```diff
diff --git a/arch/arm/plat-omap/iommu-debug.c b/arch/arm/plat-omap/iommu-debug.c
index e6c0d536899c..f07cf2f08e09 100644
--- a/arch/arm/plat-omap/iommu-debug.c
+++ b/arch/arm/plat-omap/iommu-debug.c
@@ -328,12 +328,14 @@ static int debug_open_generic(struct inode *inode, struct file *file)
.open = debug_open... |
0238a0d8c3846f5c1f9db0dabe504481751e58e8 | Analyze and fix the following issue in the Linux kernel code: usb: Fix up r8a66597-hcd section mismatches. | Problem Details:
The _remove() routine is flagged __init_or_module, despite only being
used in a __devexit context. As the rest of the driver is already
balanced out with __devinit, switch to __devexit and __devexit_p()
wrapping.
Signed-off-by: Paul Mundt <lethal@linux-sh.org> | ```diff
diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
index 77be3c24a427..3076b1cc05df 100644
--- a/drivers/usb/host/r8a66597-hcd.c
+++ b/drivers/usb/host/r8a66597-hcd.c
@@ -2397,7 +2397,7 @@ static const struct dev_pm_ops r8a66597_dev_pm_ops = {
#define R8A66597_DEV_PM_OPS NULL
#endi... |
25ab998e2eff46d2e6ede80c9fc02a349fa005a3 | Analyze and fix the following issue in the Linux kernel code: mfd: Fix up section mismatches in SH SDHI. | Problem Details:
The current probe/remove definitions are split between __init and
__devexit, make them consistent by switching to __devinit.
Signed-off-by: Paul Mundt <lethal@linux-sh.org> | ```diff
diff --git a/drivers/mfd/sh_mobile_sdhi.c b/drivers/mfd/sh_mobile_sdhi.c
index cd164595f08a..49b4d069cbf9 100644
--- a/drivers/mfd/sh_mobile_sdhi.c
+++ b/drivers/mfd/sh_mobile_sdhi.c
@@ -65,7 +65,7 @@ static void sh_mobile_sdhi_set_pwr(struct platform_device *tmio, int state)
p->set_pwr(pdev, state);
}
-s... |
7c996361ef0d02ef8c1435902c909d14195adcdc | Analyze and fix the following issue in the Linux kernel code: arm, memblock: Fix the sparsemem build | Problem Details:
Stephen Rothwell reported this build failure:
arch/arm/mm/init.c: In function 'arm_memory_present':
arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
Caused by commit 719c1514f2 ("memblock/arm: Use new accessors")
which forgot a closing brace on a new for_each_memblock(... | ```diff
diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index 8504906b147f..d6022d1f51d1 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -249,9 +249,8 @@ static void arm_memory_present(void)
static void arm_memory_present(void)
{
struct memblock_region *reg;
- int i;
- for_each_memblock(memory, r... |
2610a25406087ef797f4187e7f82dd04335056c7 | Analyze and fix the following issue in the Linux kernel code: sg: fix a warning in blk_rq_aligned() call | Problem Details:
2nd argument of blk_rq_aligned() has changed to 'unsigned long' by
the previous commit 'block: fix an address space warning in blk-map.c'.
That commit neglected to update a user of that function.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com> | ```diff
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 78d616315d8e..655ab920cff4 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1657,7 +1657,7 @@ static int sg_start_req(Sg_request *srp, unsigned char *cmd)
if (sg_allow_dio && hp->flags & SG_FLAG_DIRECT_IO &&
dxfer_dir != SG_DXFER_UNKNOWN... |
1a4e34e67c6de2385d9d493e69c0f6fce886b14d | Analyze and fix the following issue in the Linux kernel code: ALSA: usb-audio - Fix an unused-variable compile warning | Problem Details:
Used only when CONFIG_SND_DEBUG=y
sound/usb/mixer.c: In function 'get_min_max':
sound/usb/mixer.c:762: warning: unused variable 'chip'
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 3ed3901369ce..5f12e294b0f8 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -759,8 +759,6 @@ static void usb_mixer_elem_free(struct snd_kcontrol *kctl)
*/
static int get_min_max(struct usb_mixer_elem_info *cval, int default_min)
{
- struct sn... |
9e0064a5456fd75fd7c70f6f3692c7f732f91a65 | Analyze and fix the following issue in the Linux kernel code: phonet: Fix build warning. | Problem Details:
net/phonet/socket.c: In function ‘pn_res_seq_show’:
net/phonet/socket.c:726: warning: format ‘%02X’ expects type ‘unsigned int’, but argument 3 has type ‘long int’
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/phonet/socket.c b/net/phonet/socket.c
index 6bf6e3c97d5c..aca8fba099e9 100644
--- a/net/phonet/socket.c
+++ b/net/phonet/socket.c
@@ -723,7 +723,8 @@ static int pn_res_seq_show(struct seq_file *seq, void *v)
struct sock *sk = *psk;
seq_printf(seq, "%02X %5d %lu%n",
- psk - pnres.sk, s... |
801e147cde02f04b5c2f42764cd43a89fc7400a2 | Analyze and fix the following issue in the Linux kernel code: r8169: Handle rxfifo errors on 8168 chips | Problem Details:
The Thinkpad X100e seems to have some odd behaviour when the display is
powered off - the onboard r8169 starts generating rxfifo overflow errors.
The root cause of this has not yet been identified and may well be a
hardware design bug on the platform, but r8169 should be more resiliant to
this. This pa... | ```diff
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 078bbf4e6f19..a0da4a17b025 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2934,7 +2934,7 @@ static const struct rtl_cfg_info {
.hw_start = rtl_hw_start_8168,
.region = 2,
.align = 8,
- .intr_event = SYSErr | LinkChg | RxOve... |
75e3cfbed6f71a8f151dc6e413b6ce3c390030cb | Analyze and fix the following issue in the Linux kernel code: x86, intr-remap: Set redirection hint in the IRTE | Problem Details:
Currently the redirection hint in the interrupt-remapping table entry
is set to 0, which means the remapped interrupt is directed to the
processors listed in the destination. So in logical flat mode
in the presence of intr-remapping, this results in a single
interrupt multi-casted to multiple cpu's as ... | ```diff
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index f1efebaf5510..90f8a75f548f 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1392,6 +1392,7 @@ int setup_ioapic_entry(int apic_id, int irq,
irte.dlvry_mode = apic->irq_delivery_mode;
irte.... |
2d2b6901649a62977452be85df53eda2412def24 | Analyze and fix the following issue in the Linux kernel code: [IA64] Optimize ticket spinlocks in fsys_rt_sigprocmask | Problem Details:
Tony's fix (f574c843191728d9407b766a027f779dcd27b272) has a small bug,
it incorrectly uses "r3" as a scratch register in the first of the two
unlock paths ... it is also inefficient. Optimize the fast path again.
Signed-off-by: Petr Tesarik <ptesarik@suse.cz>
Signed-off-by: Tony Luck <tony.luck@intel... | ```diff
diff --git a/arch/ia64/kernel/fsys.S b/arch/ia64/kernel/fsys.S
index 471a1e783aca..331d42bda77a 100644
--- a/arch/ia64/kernel/fsys.S
+++ b/arch/ia64/kernel/fsys.S
@@ -420,34 +420,31 @@ EX(.fail_efault, ld8 r14=[r33]) // r14 <- *set
;;
RSM_PSR_I(p0, r18, r19) // mask interrupt delivery
- mov ar.ccv=0
... |
e0de7c93b950b9e784894efc4b529c6958cb747a | Analyze and fix the following issue in the Linux kernel code: ethtool: Remove unimplemented flow specification types | Problem Details:
struct ethtool_rawip4_spec and struct ethtool_ether_spec are neither
commented nor used by any driver, so remove them. Adjust padding in
the user-visible unions that included these structures.
Fix references to struct ethtool_rawip4_spec in
ethtool_get_rx_ntuple(), which should use struct ethtool_usr... | ```diff
diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 8e1859c801a4..e36a83845a1c 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -7462,10 +7462,12 @@ static int niu_add_ethtool_tcam_entry(struct niu *np,
if (fsp->flow_type == IP_USER_FLOW) {
int i;
int add_usr_cls = 0;
- int ipv6 = 0;
s... |
84176b7b56704580e008e6cb820dd4ccf622a1fd | Analyze and fix the following issue in the Linux kernel code: 3c59x: Remove atomic context inside vortex_{set|get}_wol | Problem Details:
There is no need to use spinlocks in vortex_{set|get}_wol.
This also fixes a bug:
[ 254.214993] 3c59x 0000:00:0d.0: PME# enabled
[ 254.215021] BUG: sleeping function called from invalid context at kernel/mutex.c:94
[ 254.215030] in_atomic(): 0, irqs_disabled(): 1, pid: 4875, name: ethtool
[ 254.215... | ```diff
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index 85671adae455..fa42103b2874 100644
--- a/drivers/net/3c59x.c
+++ b/drivers/net/3c59x.c
@@ -635,6 +635,9 @@ struct vortex_private {
must_free_region:1, /* Flag: if zero, Cardbus owns the I/O region */
large_frames:1, /* accept large frames */... |
2e9f7a7408d264f01d4477c564ef5c6b610cd10f | Analyze and fix the following issue in the Linux kernel code: tg3: Unlock 5717 B0+ support | Problem Details:
This patch adjusts the driver to use the tg3_start_xmit_dma_bug()
transmit routine for all revisions of 5717 asic rev devices and then
allows the driver to attach to B0 and later devices.
Reviewed-by: Benjamin Li <benli@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: Matt C... | ```diff
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index fc9706c8e3c6..4e92b81bccfa 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -13431,10 +13431,6 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
if (err)
return err;
- if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5717 &&
- ... |
41a8a7ee4a78216962f3afcea5968c04d0ab3b08 | Analyze and fix the following issue in the Linux kernel code: tg3: Fix read DMA FIFO overruns on recent devices | Problem Details:
Earlier versions of tg3 devices had a problem where the read DMA FIFO
could be overrun in certain edge conditions. The fix was to limit the
number of rx BDs the hardware would fetch at a time. For later devices
(5761, 5784 and later ASIC revs), there is a hardware fix that must be
enabled to fix the ... | ```diff
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 9f6ffffc8376..c3a430cfbe00 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -8015,6 +8015,16 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_57780)
rdmac_mode |= RDMAC_MODE_IPV6_LSO... |
3661ca66a42e306aaf53246fb75aec1ea01be0f0 | Analyze and fix the following issue in the Linux kernel code: memblock: Fix section mismatch warnings | Problem Details:
Stephen found a bunch of section mismatch warnings with the
new memblock changes.
Use __init_memblock to replace __init in memblock.c and remove
__init in memblock.h. We should not use __init in header files.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Tested-by: Stephen Rothwell <sfr@canb.a... | ```diff
diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 7d285271130d..5096458c7535 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -51,39 +51,39 @@ u64 memblock_find_in_range(u64 start, u64 end, u64 size, u64 align);
int memblock_free_reserved_regions(void);
int memblock... |
359f64f7b3997e94ee71039b5fcdc1278b9b77c4 | Analyze and fix the following issue in the Linux kernel code: omap: Fix compile dependency to LEDS_CLASS | Problem Details:
If we LEDS_CLASS is not selected, we will get undefined reference
to `led_classdev_register'.
Signed-off-by: Tony Lindgren <tony@atomide.com> | ```diff
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index e39a417a368d..a92cb499313f 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -33,7 +33,7 @@ config OMAP_DEBUG_DEVICES
config OMAP_DEBUG_LEDS
bool
depends on OMAP_DEBUG_DEVICES
- default y if LEDS
+ default ... |
eb838fe109b8f51ba590802761753a2631c3f7f0 | Analyze and fix the following issue in the Linux kernel code: pcmcia: per-device, not per-socket debug messages | Problem Details:
As the iomem / ioport setup differs per device, it is much better
to print out the device instead of the socket.
Tested-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> | ```diff
diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
index 54aa1c238cb3..a5c176598d95 100644
--- a/drivers/pcmcia/pcmcia_resource.c
+++ b/drivers/pcmcia/pcmcia_resource.c
@@ -163,7 +163,7 @@ static int pcmcia_access_config(struct pcmcia_device *p_dev,
c = p_dev->function_config;
... |
c494bc6c534c78fac2d308ad38073b9226448b0d | Analyze and fix the following issue in the Linux kernel code: pcmcia serial_cs.c: fix multifunction card handling | Problem Details:
We shouldn't overwrite pre-set values, and we should also
set the port address to the beginning, and not the end of
the 8-port range.
CC: linux-serial@vger.kernel.org
Reported-by: Komuro <komurojun-mbn@nifty.com>
Hardware-supplied-by: Jochen Frieling <j.frieling@pengutronix.de>
Tested-by: Wolfram Sang... | ```diff
diff --git a/drivers/serial/serial_cs.c b/drivers/serial/serial_cs.c
index 141c69554bd4..7d475b2a79e8 100644
--- a/drivers/serial/serial_cs.c
+++ b/drivers/serial/serial_cs.c
@@ -335,8 +335,6 @@ static int serial_probe(struct pcmcia_device *link)
info->p_dev = link;
link->priv = info;
- link->resource[0]-... |
373a3cf744c774478f44921c50011b896ab08f9d | Analyze and fix the following issue in the Linux kernel code: drm/i915: call drm_encoder_init first | Problem Details:
Later initialisation of the encoder often requires that
drm_encoder_init() has already been called, for instance, initialiasing
the DDC buses.
Yet another recent regression, as 819f3fb7 depended upon these fixes
which I missed when cherry-picking.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk... | ```diff
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index 0403ec9e164a..2353da625d25 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -548,6 +548,10 @@ void intel_crt_init(struct drm_device *dev)
if (!intel_encoder->ddc_bus) {
dev_printk(K... |
7040dea4d2a0609241c7a98a944b7c432c69db2e | Analyze and fix the following issue in the Linux kernel code: arch/tile: fix formatting bug in register dumps | Problem Details:
This cut-and-paste bug was caused by rewriting the register dump
code to use only a single printk per line of output.
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com> | ```diff
diff --git a/arch/tile/kernel/process.c b/arch/tile/kernel/process.c
index c37b6e3873c1..84c29111756c 100644
--- a/arch/tile/kernel/process.c
+++ b/arch/tile/kernel/process.c
@@ -667,7 +667,7 @@ void show_regs(struct pt_regs *regs)
regs->regs[51], regs->regs[52], regs->tp);
pr_err(" sp : "REGFMT" lr ... |
0fab59e5ddb4e0557825e9ab8e41b66b5f336941 | Analyze and fix the following issue in the Linux kernel code: arch/tile: fix memcpy_fromio()/memcpy_toio() signatures | Problem Details:
This tripped up a driver (not yet committed to git). Fix it now.
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com> | ```diff
diff --git a/arch/tile/include/asm/io.h b/arch/tile/include/asm/io.h
index 8c95bef3fa45..ee43328713ab 100644
--- a/arch/tile/include/asm/io.h
+++ b/arch/tile/include/asm/io.h
@@ -164,22 +164,22 @@ static inline void _tile_writeq(u64 val, unsigned long addr)
#define iowrite32 writel
#define iowrite64 writeq
... |
144177991ca624841ddbd1e7edff958fc0f6d1fe | Analyze and fix the following issue in the Linux kernel code: block: fix an address space warning in blk-map.c | Problem Details:
Change type of 2nd parameter of blk_rq_aligned() into unsigned long
and remove unnecessary casting. Now we can call it with 'uaddr'
instead of 'ubuf' in __blk_rq_map_user() so that it can remove
following warnings from sparse:
block/blk-map.c:57:31: warning: incorrect type in argument 2 (different ad... | ```diff
diff --git a/block/blk-map.c b/block/blk-map.c
index c65d7593f7f1..ac0f7d46db63 100644
--- a/block/blk-map.c
+++ b/block/blk-map.c
@@ -54,7 +54,7 @@ static int __blk_rq_map_user(struct request_queue *q, struct request *rq,
* direct dma. else, set up kernel bounce buffers
*/
uaddr = (unsigned long) ubuf;... |
d2c726309d88df3c5568486e4b5b9e4c3150903f | Analyze and fix the following issue in the Linux kernel code: dccp ccid-3: remove buggy RTT-sampling history lookup | Problem Details:
This removes the RTT-sampling function tfrc_tx_hist_rtt(), since
1. it suffered from complex passing of return values (the return value both
indicated successful lookup while the value doubled as RTT sample);
2. when for some odd reason the sample value equalled 0, this triggered a bug
warn... | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index e9ca0983ac58..b2ddd205d438 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -370,6 +370,7 @@ static void ccid3_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb)
{
struct ccid3_hc_tx_sock *hc = ccid3_hc_tx_sk(sk);
st... |
20cbd3e120a0c20bebe420e1fed0e816730bb988 | Analyze and fix the following issue in the Linux kernel code: dccp ccid-3: A lower bound for the inter-packet scheduling algorithm | Problem Details:
This fixes a subtle bug in the calculation of the inter-packet gap and shows
that t_delta, as it is currently used, is not needed.
The algorithm from RFC 5348, 8.3 below continually computes a send time t_nom,
which is initialised with the current time t_now; t_gran = 1E6 / HZ specifies
the scheduling... | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index 278e17069322..e9ca0983ac58 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -91,19 +91,16 @@ static inline u64 rfc3390_initial_rate(struct sock *sk)
return scaled_div(w_init << 6, hc->tx_rtt);
}
-/*
- * Recalculate t_ipi ... |
38a81da2205f94e8a2a834b51a6b99c91fc7c2e8 | Analyze and fix the following issue in the Linux kernel code: perf events: Clean up pid passing | Problem Details:
The kernel perf event creation path shouldn't use find_task_by_vpid()
because a vpid exists in a specific namespace. find_task_by_vpid() uses
current's pid namespace which isn't always the correct namespace to use
for the vpid in all the places perf_event_create_kernel_counter() (and
thus find_get_cont... | ```diff
diff --git a/arch/arm/oprofile/common.c b/arch/arm/oprofile/common.c
index 0691176899ff..aad63e611b36 100644
--- a/arch/arm/oprofile/common.c
+++ b/arch/arm/oprofile/common.c
@@ -96,7 +96,7 @@ static int op_create_counter(int cpu, int event)
return ret;
pevent = perf_event_create_kernel_counter(&counter_... |
d958077d007d98125766d11e82da2fd6497b91d6 | Analyze and fix the following issue in the Linux kernel code: hw breakpoints: Fix pid namespace bug | Problem Details:
Hardware breakpoints can't be registered within pid namespaces
because tsk->pid is passed rather than the pid in the current
namespace.
(See https://bugzilla.kernel.org/show_bug.cgi?id=17281 )
This is a quick fix demonstrating the problem but is not the
best method of solving the problem since passin... | ```diff
diff --git a/kernel/hw_breakpoint.c b/kernel/hw_breakpoint.c
index 3b2aaffb65f0..6122f02cfedf 100644
--- a/kernel/hw_breakpoint.c
+++ b/kernel/hw_breakpoint.c
@@ -433,7 +433,8 @@ register_user_hw_breakpoint(struct perf_event_attr *attr,
perf_overflow_handler_t triggered,
struct task_struct *tsk)... |
64a48d90149bb7007275fac13eaa4cb8d8ce12ea | Analyze and fix the following issue in the Linux kernel code: perf, sh: Fix patch merge foul-up | Problem Details:
3f6da390 ("perf: Rework and fix the arch CPU-hotplug hooks") introduced
this breakage. sh_pmu_setup() is missing an opening curly brace.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20100913191729.GA6440@console-pimps.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/sh/kernel/perf_event.c b/arch/sh/kernel/perf_event.c
index cf39c4873468..036f7a9296fa 100644
--- a/arch/sh/kernel/perf_event.c
+++ b/arch/sh/kernel/perf_event.c
@@ -338,7 +338,7 @@ static struct pmu pmu = {
};
static void sh_pmu_setup(int cpu)
-
+{
struct cpu_hw_events *cpuhw = &per_cpu(... |
65175c07653534294257f75baa03a36edad86870 | Analyze and fix the following issue in the Linux kernel code: alpha: Fix HW performance counters to be stopped properly | Problem Details:
Also fix a few compile errors due to undefined and duplicated
variables.
Signed-off-by: Michael Cree <mcree@orcon.net.nz>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1284269844-23251-1-git-send-email-mcree@orcon.net.nz>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/alpha/kernel/perf_event.c b/arch/alpha/kernel/perf_event.c
index a25fe9eb4739..1cc49683fb69 100644
--- a/arch/alpha/kernel/perf_event.c
+++ b/arch/alpha/kernel/perf_event.c
@@ -422,9 +422,10 @@ static void maybe_change_configuration(struct cpu_hw_events *cpuc)
static int alpha_pmu_add(struct ... |
d9ca07a05ce1c42ac9717e54eaea4546a3a80978 | Analyze and fix the following issue in the Linux kernel code: watchdog: Avoid kernel crash when disabling watchdog | Problem Details:
In case you boot with the watchdog disabled, i.e., nowatchdog, then,
if you try to disable it via /proc/sys/kernel/watchdog, you get
a kernel crash. The reason is that you are trying to cancel a hrtimer
which has never been initialized.
This patch fixes this by skipping execution of
watchdog_disable_a... | ```diff
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index fa71aebda4ff..89eadbb9cefe 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -473,6 +473,9 @@ static void watchdog_disable_all_cpus(void)
{
int cpu;
+ if (no_watchdog)
+ return;
+
for_each_online_cpu(cpu)
watchdog_disable(cpu);
``` |
e75e863dd5c7d96b91ebbd241da5328fc38a78cc | Analyze and fix the following issue in the Linux kernel code: sched: Fix user time incorrectly accounted as system time on 32-bit | Problem Details:
We have 32-bit variable overflow possibility when multiply in
task_times() and thread_group_times() functions. When the
overflow happens then the scaled utime value becomes erroneously
small and the scaled stime becomes i erroneously big.
Reported here:
https://bugzilla.redhat.com/show_bug.cgi?id=63... | ```diff
diff --git a/kernel/sched.c b/kernel/sched.c
index ed09d4f2a69c..dc85ceb90832 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3513,9 +3513,9 @@ void task_times(struct task_struct *p, cputime_t *ut, cputime_t *st)
rtime = nsecs_to_cputime(p->se.sum_exec_runtime);
if (total) {
- u64 temp;
+ u64 temp ... |
1446c5fba73044a1c72153e1203b23b1820431c5 | Analyze and fix the following issue in the Linux kernel code: ALSA: snd-aloop - fix the "PCM Playback Channels" kcontrol | Problem Details:
Obvious copy-and-paste error.
Signed-off-by: Jaroslav Kysela <perex@perex.cz> | ```diff
diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c
index 3123a15d23f6..f2b8f868d97a 100644
--- a/sound/drivers/aloop.c
+++ b/sound/drivers/aloop.c
@@ -809,7 +809,7 @@ static int loopback_channels_get(struct snd_kcontrol *kcontrol,
ucontrol->value.integer.value[0] =
loopback->setup[kcontrol->id.s... |
fe725d4f22f6bd1e7a5e7074bdf53a8fe0a954ee | Analyze and fix the following issue in the Linux kernel code: drm/radeon/kms: only warn on mipmap size checks in r600 cs checker (v2) | Problem Details:
The texture base address registers are in units of 256 bytes.
The original CS checker treated these offsets as bytes, so the
original check was wrong. I fixed the units in a patch during
the 2.6.36 cycle, but this ended up breaking some existing
userspace (probably due to a bug in either userspace tex... | ```diff
diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
index d8864949e387..250a3a918193 100644
--- a/drivers/gpu/drm/radeon/r600_cs.c
+++ b/drivers/gpu/drm/radeon/r600_cs.c
@@ -1170,9 +1170,8 @@ static inline int r600_check_texture_resource(struct radeon_cs_parser *p, u32 i
/* using... |
a4128b03ff1ff5bc6ea922518a3f36a09b914379 | Analyze and fix the following issue in the Linux kernel code: MN10300: Fix up the IRQ names for the on-chip serial ports | Problem Details:
Fix up the IRQ names for the MN10300 on-chip serial ports in the driver as
request_interrupt() no longer allows names containing slashes, giving a warning
like the following if one is encountered:
------------[ cut here ]------------
WARNING: at fs/proc/generic.c:323 __xlate_proc_name+0x62/0x7c()
n... | ```diff
diff --git a/arch/mn10300/kernel/mn10300-serial.c b/arch/mn10300/kernel/mn10300-serial.c
index 9d49073e827a..db509dd80565 100644
--- a/arch/mn10300/kernel/mn10300-serial.c
+++ b/arch/mn10300/kernel/mn10300-serial.c
@@ -156,17 +156,17 @@ struct mn10300_serial_port mn10300_serial_port_sif0 = {
._intr = &SC0ICR... |
75e1c70fc31490ef8a373ea2a4bea2524099b478 | Analyze and fix the following issue in the Linux kernel code: aio: check for multiplication overflow in do_io_submit | Problem Details:
Tavis Ormandy pointed out that do_io_submit does not do proper bounds
checking on the passed-in iocb array:
if (unlikely(nr < 0))
return -EINVAL;
if (unlikely(!access_ok(VERIFY_READ, iocbpp, (nr*sizeof(iocbpp)))))
return -EFAULT; ^^^^^^... | ```diff
diff --git a/fs/aio.c b/fs/aio.c
index 3006b5bc33d6..1320b2a05fb2 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1659,6 +1659,9 @@ long do_io_submit(aio_context_t ctx_id, long nr,
if (unlikely(nr < 0))
return -EINVAL;
+ if (unlikely(nr > LONG_MAX/sizeof(*iocbpp)))
+ nr = LONG_MAX/sizeof(*iocbpp);
+
if (unli... |
ef6c3c6e53ba4286140ea7d582d81f08d43dc7d2 | Analyze and fix the following issue in the Linux kernel code: staging: west bridge: pnand hal fixes | Problem Details:
This patch includes changing some defines, necessary for compilation
with the linux-next tree.
Signed-off-by: David Cross <david.cross@cypress.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/westbridge/astoria/arch/arm/mach-omap2/cyashalomap_kernel.c b/drivers/staging/westbridge/astoria/arch/arm/mach-omap2/cyashalomap_kernel.c
index a0759ee76249..ac3a4cf4216f 100644
--- a/drivers/staging/westbridge/astoria/arch/arm/mach-omap2/cyashalomap_kernel.c
+++ b/drivers/staging/w... |
72bbd9bce41276d06b6b816df21aced71b1896eb | Analyze and fix the following issue in the Linux kernel code: Staging: west bridge: block driver api fix | Problem Details:
This patch contains an update for cyasblkdev_queue.c which is needed for
the kernel update from 2.6.35 to 2.6.36.
Signed-off-by: David Cross <david.cross@cypress.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/westbridge/astoria/block/cyasblkdev_queue.c b/drivers/staging/westbridge/astoria/block/cyasblkdev_queue.c
index 8dc29bd2891d..5cc469ab89fe 100644
--- a/drivers/staging/westbridge/astoria/block/cyasblkdev_queue.c
+++ b/drivers/staging/westbridge/astoria/block/cyasblkdev_queue.c
@@ -9... |
4ecea3c51b42419d6cd314b3d36c6ceaa9c204e9 | Analyze and fix the following issue in the Linux kernel code: Staging: west bridge: Kconfig fix | Problem Details:
This patch fixes the currently broken Kconfig for west bridge by
introducing a dependency on a valid HAL Layer for the driver build.
Signed-off-by: David Cross <david.cross@cypress.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/westbridge/Kconfig b/drivers/staging/westbridge/Kconfig
index 57468125b391..2b1c2ae557b6 100644
--- a/drivers/staging/westbridge/Kconfig
+++ b/drivers/staging/westbridge/Kconfig
@@ -4,7 +4,7 @@
menuconfig WESTBRIDGE
tristate "West Bridge support"
- depends on HAS_IOMEM && BROKE... |
8be11ffcf59e9bcb5f0a2a2b2e7b43d56c797b98 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix macro coding style issue in adl_pci9111.c | Problem Details:
This is a patch that fixes up, macros with multiple statements should be enclosed in a do - while loop, coding style issue in the adl_pci9111.c file found by the checkpatch.pl tool
Signed-off-by: Maurice Dawson <mauricedawson2699@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c b/drivers/staging/comedi/drivers/adl_pci9111.c
index 96c4f300205e..18103b68769c 100644
--- a/drivers/staging/comedi/drivers/adl_pci9111.c
+++ b/drivers/staging/comedi/drivers/adl_pci9111.c
@@ -266,19 +266,28 @@ TODO:
outb(flags, PCI9111_IO_BASE+PCI9111... |
ff75f96bb0e9d4fc42efb66a6ccb7bf83ecc298f | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: check kmalloc() return value | Problem Details:
kmalloc() may fail, if so drop current packet.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
[sven.eckelmann@gmx.de: Removed new introduced deadlock]
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <greg... | ```diff
diff --git a/drivers/staging/batman-adv/routing.c b/drivers/staging/batman-adv/routing.c
index e12fd995417c..2cf8cf98a299 100644
--- a/drivers/staging/batman-adv/routing.c
+++ b/drivers/staging/batman-adv/routing.c
@@ -1232,8 +1232,12 @@ int recv_ucast_frag_packet(struct sk_buff *skb, struct batman_if *recv_if)... |
b68d58a84b42d6213e46948b8f4cb95b8ed0efec | Analyze and fix the following issue in the Linux kernel code: staging: iio: sca3000 fix sca3000_[show,store]_ring_bpse | Problem Details:
Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
index 6d19d15c6d77..09836c4f18b8 100644
--- a/drivers/staging/iio/accel/sca3000_ring.c
+++ b/drivers/staging/iio/accel/sca3000_ring.c
@@ -126,8 +126,8 @@ static ssize_t sca3000_show_ring_bpse(struct device *dev,
{
... |
3285aae1edd04ffdb6a732f7d90c44f90a7e5d8f | Analyze and fix the following issue in the Linux kernel code: staging: iio: ak8975: Add ak8975 magnetometer sensor | Problem Details:
This is for the Asahi Kasei AK8975 3-axis magnetometer. It resides within
the magnetometer section of the IIO subsystem, and implements the raw
magn_x,y,z_raw attributes, as well as magn_x,y,z_scale attributes for
converting to Gauss.
Changed to use the magn_x,y,z_scale attributes, and made those att... | ```diff
diff --git a/drivers/staging/iio/magnetometer/Kconfig b/drivers/staging/iio/magnetometer/Kconfig
index d01445060f51..81b579d371df 100644
--- a/drivers/staging/iio/magnetometer/Kconfig
+++ b/drivers/staging/iio/magnetometer/Kconfig
@@ -3,6 +3,16 @@
#
comment "Magnetometer sensors"
+config SENSORS_AK8975
+ tr... |
5fee254098c11a52ce04e1efdc8c090caf592bfd | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix remaining checkpatch errors. | Problem Details:
Remaining errors are due to the use of typedefs. They should dissappear
once the typedefs get cleaned up.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/bcmutils.h b/drivers/staging/brcm80211/include/bcmutils.h
index 67fe99cb5b9a..321071b53727 100644
--- a/drivers/staging/brcm80211/include/bcmutils.h
+++ b/drivers/staging/brcm80211/include/bcmutils.h
@@ -415,15 +415,15 @@ extern "C" {
}
#ifndef ABS
-#define ABS... |
92dfc7d18a123fcf22beaf23036ba02a13416e3e | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: trailing whitespace." | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/sys/wlc_channel.c b/drivers/staging/brcm80211/sys/wlc_channel.c
index 7824c8d89d6b..554a0cb84ad5 100644
--- a/drivers/staging/brcm80211/sys/wlc_channel.c
+++ b/drivers/staging/brcm80211/sys/wlc_channel.c
@@ -1473,7 +1473,7 @@ wlc_channel_reg_limits(wlc_cm_info_t *wlc_cm, c... |
fd64bcc48bd1542ca361e99b6487b54ad10dc4b8 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: spaces required around that ..." | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/bcmutils.h b/drivers/staging/brcm80211/include/bcmutils.h
index 51caf3c7eaea..67fe99cb5b9a 100644
--- a/drivers/staging/brcm80211/include/bcmutils.h
+++ b/drivers/staging/brcm80211/include/bcmutils.h
@@ -415,15 +415,15 @@ extern "C" {
}
#ifndef ABS
-#define ABS... |
2ae3b7ea9f8e7472d26ec317ce498466b0864871 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: spaces prohibited around that ':' ..." | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/phy/wlc_phy_n.c b/drivers/staging/brcm80211/phy/wlc_phy_n.c
index 07efa67458c5..6a0c1cdcc371 100644
--- a/drivers/staging/brcm80211/phy/wlc_phy_n.c
+++ b/drivers/staging/brcm80211/phy/wlc_phy_n.c
@@ -23487,7 +23487,7 @@ wlc_phy_est_tonepwr_nphy(phy_info_t *pi, int32 *qdBm_... |
a0e5ccd340ccb2cc9c87771609bafa1e2491770b | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: space required before that ..." | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/bcmutils.h b/drivers/staging/brcm80211/include/bcmutils.h
index 85fe70447406..51caf3c7eaea 100644
--- a/drivers/staging/brcm80211/include/bcmutils.h
+++ b/drivers/staging/brcm80211/include/bcmutils.h
@@ -415,7 +415,7 @@ extern "C" {
}
#ifndef ABS
-#define ABS(a... |
914d69d6bc5758b57f46a33699d794a364db88b9 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: space required after that ..." | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/sys/wl_dbg.h b/drivers/staging/brcm80211/sys/wl_dbg.h
index 7dd741a8a47d..d83244cae449 100644
--- a/drivers/staging/brcm80211/sys/wl_dbg.h
+++ b/drivers/staging/brcm80211/sys/wl_dbg.h
@@ -25,10 +25,10 @@ extern uint32 wl_msg_level;
#ifdef BCMDBG
-#define WL_ERROR(args... |
0eeca2f48d5a28cc2458891294a98e46f4547c4b | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: space required after that close brace" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/sys/wl_dbg.h b/drivers/staging/brcm80211/sys/wl_dbg.h
index a2dd359a4d94..7dd741a8a47d 100644
--- a/drivers/staging/brcm80211/sys/wl_dbg.h
+++ b/drivers/staging/brcm80211/sys/wl_dbg.h
@@ -44,14 +44,14 @@ extern uint32 wl_msg_level;
extern uint32 wl_ampdu_dbg;
-#define... |
5ebee113b66e9dfc07aa1ca45978c3a5c6bc970d | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: space prohibited before ...close square bracket" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/bcmsdpcm.h b/drivers/staging/brcm80211/include/bcmsdpcm.h
index 7937cda9b394..cd495545a691 100644
--- a/drivers/staging/brcm80211/include/bcmsdpcm.h
+++ b/drivers/staging/brcm80211/include/bcmsdpcm.h
@@ -103,7 +103,7 @@
#define SDPCM_DOFFSET_SHIFT 24
#define S... |
29c4275adbe15e95db54ce04a3137a6ff40c890c | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: space prohibited after that ..." | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/phy/wlc_phy_cmn.c b/drivers/staging/brcm80211/phy/wlc_phy_cmn.c
index 01876ac37069..f2e504eddcdd 100644
--- a/drivers/staging/brcm80211/phy/wlc_phy_cmn.c
+++ b/drivers/staging/brcm80211/phy/wlc_phy_cmn.c
@@ -2408,8 +2408,8 @@ wlc_phy_txpower_get_current(wlc_phy_t *ppi, tx_... |
198bd4d69dddb3fe78fdc251983bb49502b3b35e | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: need consistent spacing around '*'" | Problem Details:
This patch fixes the real errors. The rest are caused by typedefs
which will be fixed in a later patch.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/d11.h b/drivers/staging/brcm80211/include/d11.h
index 3dbd54c0cc74..f17ea8cba07b 100644
--- a/drivers/staging/brcm80211/include/d11.h
+++ b/drivers/staging/brcm80211/include/d11.h
@@ -1201,8 +1201,8 @@ BWL_PRE_PACKED_STRUCT struct tx_status {
#define M_20IN40_IQ ... |
39dcff3f45048df1c8bd3e3ba033e7b62328db3f | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix 'ERROR: "(foo*)" should be "(foo *)"' | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/linux_osl.h b/drivers/staging/brcm80211/include/linux_osl.h
index 28b61caf4350..0e61de1b5fc1 100644
--- a/drivers/staging/brcm80211/include/linux_osl.h
+++ b/drivers/staging/brcm80211/include/linux_osl.h
@@ -88,16 +88,16 @@ typedef struct {
#define PKTFREESETCB(... |
c5fe41c339180dea243443391d08f620fbf147c3 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: Macros w/ mult. statements ... do - while loop" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/d11.h b/drivers/staging/brcm80211/include/d11.h
index 378832cfffe4..3dbd54c0cc74 100644
--- a/drivers/staging/brcm80211/include/d11.h
+++ b/drivers/staging/brcm80211/include/d11.h
@@ -696,7 +696,10 @@ BWL_PRE_PACKED_STRUCT struct cck_phy_hdr {
#define WLC_GET_CCK_... |
0d706ef4f2f17541900978b0c1cf629321f56298 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: Macros w/ complex values ... parenthesis" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/bcmutils.h b/drivers/staging/brcm80211/include/bcmutils.h
index 6e8d96fc065d..85fe70447406 100644
--- a/drivers/staging/brcm80211/include/bcmutils.h
+++ b/drivers/staging/brcm80211/include/bcmutils.h
@@ -226,7 +226,7 @@ extern "C" {
#define bcm_perf_enable()
#def... |
7e85c72969b17eed698c3e23674f424bf345aceb | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: do not initialise statics to 0 or NULL" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/sys/wl_mac80211.c b/drivers/staging/brcm80211/sys/wl_mac80211.c
index b92942f1d671..b6b4c6ad9e50 100644
--- a/drivers/staging/brcm80211/sys/wl_mac80211.c
+++ b/drivers/staging/brcm80211/sys/wl_mac80211.c
@@ -128,7 +128,7 @@ static int wl_linux_watchdog(void *ctx);
FIF_OT... |
e4e4d21fa303f71a8289c3dd822a02cf91603502 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: do not initialise globals to 0 or NULL" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/util/bcmsrom.c b/drivers/staging/brcm80211/util/bcmsrom.c
index 03646508415a..361dc1126268 100644
--- a/drivers/staging/brcm80211/util/bcmsrom.c
+++ b/drivers/staging/brcm80211/util/bcmsrom.c
@@ -370,7 +370,7 @@ static const char BCMATTACHDATA(vstr_macaddr)[] = "macaddr=%s... |
9b6562b1c302704cdefd97f2c340b695bf481d44 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: while should follow close brace '}'" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/util/bcmutils.c b/drivers/staging/brcm80211/util/bcmutils.c
index 7f24fa71e732..056fcaf52bff 100644
--- a/drivers/staging/brcm80211/util/bcmutils.c
+++ b/drivers/staging/brcm80211/util/bcmutils.c
@@ -680,8 +680,7 @@ char *bcmstrtok(char **string, const char *delimiters, ch... |
e5c4536fa4643ba15c06373f87e7a7e3080b8045 | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: that open brace { ... prev line" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/phy/wlc_phy_lcn.c b/drivers/staging/brcm80211/phy/wlc_phy_lcn.c
index afe2b6fc9778..a891366a67bb 100644
--- a/drivers/staging/brcm80211/phy/wlc_phy_lcn.c
+++ b/drivers/staging/brcm80211/phy/wlc_phy_lcn.c
@@ -1857,17 +1857,17 @@ wlc_lcnphy_tx_iqlo_cal(phy_info_t *pi,
0x0... |
621458221781e3e943c56e1978614604cee3beaf | Analyze and fix the following issue in the Linux kernel code: staging: brcm80211: fix "ERROR: trailing statements should be on next line" | Problem Details:
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/brcm80211/include/linux_osl.h b/drivers/staging/brcm80211/include/linux_osl.h
index 5d2b1d06d8e3..2c1f61c45221 100644
--- a/drivers/staging/brcm80211/include/linux_osl.h
+++ b/drivers/staging/brcm80211/include/linux_osl.h
@@ -190,12 +190,16 @@ extern int osl_error(int bcmerror);
... |
460cf3411b858ad509d5255e0dfaf862a83c0299 | Analyze and fix the following issue in the Linux kernel code: cifs: fix potential double put of TCP session reference | Problem Details:
cifs_get_smb_ses must be called on a server pointer on which it holds an
active reference. It first does a search for an existing SMB session. If
it finds one, it'll put the server reference and then try to ensure that
the negprot is done, etc.
If it encounters an error at that point then it'll return... | ```diff
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 67dad54fbfa1..88c84a38bccb 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1706,9 +1706,6 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
if (ses) {
cFYI(1, "Existing smb sess found (status=%d)", ses->statu... |
eefdca043e8391dcd719711716492063030b55ac | Analyze and fix the following issue in the Linux kernel code: x86-64, compat: Retruncate rax after ia32 syscall entry tracing | Problem Details:
In commit d4d6715, we reopened an old hole for a 64-bit ptracer touching a
32-bit tracee in system call entry. A %rax value set via ptrace at the
entry tracing stop gets used whole as a 32-bit syscall number, while we
only check the low 32 bits for validity.
Fix it by truncating %rax back to 32 bits ... | ```diff
diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index 84e3a4ef9719..518bb99c3394 100644
--- a/arch/x86/ia32/ia32entry.S
+++ b/arch/x86/ia32/ia32entry.S
@@ -50,7 +50,12 @@
/*
* Reload arg registers from stack in case ptrace changed them.
* We don't reload %eax because syscall_trace_ent... |
36d001c70d8a0144ac1d038f6876c484849a74de | Analyze and fix the following issue in the Linux kernel code: x86-64, compat: Test %rax for the syscall number, not %eax | Problem Details:
On 64 bits, we always, by necessity, jump through the system call
table via %rax. For 32-bit system calls, in theory the system call
number is stored in %eax, and the code was testing %eax for a valid
system call number. At one point we loaded the stored value back from
the stack to enforce zero-exte... | ```diff
diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index b86feabed69b..84e3a4ef9719 100644
--- a/arch/x86/ia32/ia32entry.S
+++ b/arch/x86/ia32/ia32entry.S
@@ -153,7 +153,7 @@ ENTRY(ia32_sysenter_target)
testl $_TIF_WORK_SYSCALL_ENTRY,TI_flags(%r10)
CFI_REMEMBER_STATE
jnz sysenter_tracesy... |
fddd91016d16277a32727ad272cf2edd3d309c90 | Analyze and fix the following issue in the Linux kernel code: phylib: fix PAL state machine restart on resume | Problem Details:
On resume, before starting the PAL state machine, check if the
adjust_link() method is well supplied. If not, this would lead to a
NULL pointer dereference in the phy_state_machine() function.
This scenario can happen if the Ethernet driver call manually the PHY
functions instead of using the PAL stat... | ```diff
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 6a6b8199a0d6..6c58da2b882c 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -308,7 +308,7 @@ static int mdio_bus_suspend(struct device *dev)
* may call phy routines that try to grab the same lock, and that m... |
3894335876a6257ac46e14845bd37ae6fb0f7c87 | Analyze and fix the following issue in the Linux kernel code: ALSA: patch_nvhdmi.c: Fix supported sample rate list. | Problem Details:
22050 isn't a valid HDMI sample rate. 32000 is.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-By: Wei Ni <wni@nvidia.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/hda/patch_nvhdmi.c b/sound/pci/hda/patch_nvhdmi.c
index 69b950d527c3..baa108b9d6aa 100644
--- a/sound/pci/hda/patch_nvhdmi.c
+++ b/sound/pci/hda/patch_nvhdmi.c
@@ -84,7 +84,7 @@ static struct hda_verb nvhdmi_basic_init_7x[] = {
#else
/* support all rates and formats */
#define SUPPORTE... |
ab12811c89e88f2e66746790b1fe4469ccb7bdd9 | Analyze and fix the following issue in the Linux kernel code: bonding: correctly process non-linear skbs | Problem Details:
It was recently brought to my attention that 802.3ad mode bonds would no
longer form when using some network hardware after a driver update.
After snooping around I realized that the particular hardware was using
page-based skbs and found that skb->data did not contain a valid LACPDU
as it was not stor... | ```diff
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 822f586d72af..0ddf4c66afe2 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -2466,6 +2466,9 @@ int bond_3ad_lacpdu_recv(struct sk_buff *skb, struct net_device *dev, struct pac
if (!(dev->flags... |
a2c1e3dad516618cb0fbfb1a62c36d0b0744573a | Analyze and fix the following issue in the Linux kernel code: mac80211: match only assigned bss in sta_info_get_bss | Problem Details:
sta_info_get_bss() is used to match STA pointers
for VLAN/AP interfaces, but if the same station
is also added to multiple other interfaces it
will erroneously match because both pointers are
NULL, fix this by ignoring NULL pointers here.
Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by... | ```diff
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 687077e49dc6..e356ff80671a 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -125,7 +125,7 @@ struct sta_info *sta_info_get_bss(struct ieee80211_sub_if_data *sdata,
lockdep_is_held(&local->sta_mtx));
while (sta) ... |
31a01645c0c7b46d7f74777cd2a66ddb2a22bbd9 | Analyze and fix the following issue in the Linux kernel code: ath9k: fix BSSID mask calculation | Problem Details:
At the time the .add_interface driver op is called, the interface has not
been marked as running yet, so ieee80211_iterate_active_interfaces will
not pass it to the iterator function.
Because of this, the calculated BSSID mask is wrong, which breaks multi-BSS
operation.
Additionally, the current way o... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index 5fe570bb5c4c..c8ff417f6c10 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -719,7 +719,7 @@ static inline void ath_ahb_exit(void) {};
void ath9k_ps_wakeup(struc... |
4a0e8ecca4eeed38d4b3b7a317a3aaab4dd3cacd | Analyze and fix the following issue in the Linux kernel code: ath9k_htc: Fix CPU usage issue during scan period | Problem Details:
The CPU consumption during the scan period is high, since
the register write go over Interrupt endpoint. On downloading
the firmware to the target, the USB descriptors are
'patched' to change the type of the endpoints from Interrupt
to Bulk.
With this fix, the CPU usage during a scan run comes down to... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index 495f18950ac9..27f88a0a155b 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -92,10 +92,10 @@ static int hif_usb_send_regout(struct hif_device_usb *hif_dev... |
cc0de6536e8b70d61948128a9cbf86920066c53d | Analyze and fix the following issue in the Linux kernel code: ath9k_htc: Fix memory leak on WMI event handler | Problem Details:
ath9k_wmi_ctrl_rx is racy with ath9k_wmi_tasklet on event notification
due to which the wmi_skb may be overwritten which leads to memory leak.
Signed-off-by: Rajkumar Manoharan <rmanoharan@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/wmi.c b/drivers/net/wireless/ath/ath9k/wmi.c
index 45fe9cac7971..93a8bda09c25 100644
--- a/drivers/net/wireless/ath/ath9k/wmi.c
+++ b/drivers/net/wireless/ath/ath9k/wmi.c
@@ -124,55 +124,11 @@ void ath9k_wmi_tasklet(unsigned long data)
{
struct ath9k_htc_priv *priv... |
7cf24421292d92556d53630e6973b34324c94103 | Analyze and fix the following issue in the Linux kernel code: iwlwifi: use IWL_DEBUG_SCAN for debug scanning | Problem Details:
Replace IWL_DEBUG_{INFO,HC,RC} to IWL_DEBUG_SCAN in iwl-scan.c file. Add
some more IWL_DEBUG_SCAN messages. This will allow to fully debug
scanning using only IWL_DL_SCAN flag.
Also start one message sentence with capital letter, since that
convention in iwl-scan.c file.
Signed-off-by: Stanislaw Grus... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index 26dd8f3228c0..65b7cb4290cb 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -85,7 +85,7 @@ static int iwl_send_scan_abort(struct iwl_priv *priv)
* can occ... |
e7e16b90b477a07d17af37dceb2e8af1ddbd9712 | Analyze and fix the following issue in the Linux kernel code: iwlwifi: do not force complete scan too early | Problem Details:
Currently we force scan complete at the end of iwl_scan_cancel_timeout
function. This cause race condition when we can get a new scan request
from mac80211 and complete it by iwl_bg_complete from older scan. Change
code to force scan complete only when really needed: device goes down,
interface is remo... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index d2315debd1b8..646864a26eaf 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -4071,13 +4071,15 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv)
pr... |
f5354c17dc29681c241f2774f3ef9478fb586673 | Analyze and fix the following issue in the Linux kernel code: iwlwifi: force scan complete after timeout | Problem Details:
If we do not get notification from hardware about scan complete, after
timeout do mac80211 scan completion anyway. This assure we end scan
in case of firmware hung.
Patch fix one of the causes of wdev_cleanup_work warning reported at
https://bugzilla.redhat.com/show_bug.cgi?id=593566
Signed-off-by: S... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
index c9c523b2883f..b04a4f81ee97 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -2081,7 +2081,6 @@ void iwl_mac_remove_interface(struct ieee80211_hw *hw,
{
str... |
3f08e4ef807c3103ceebf7993c7463c7a90646f3 | Analyze and fix the following issue in the Linux kernel code: agp/intel: Fix resume regression from 2d2430cf | Problem Details:
On i915 [EeePCs] something scribles over the registers during suspend
and resume so we must save a copy of the PGETBL_CTL register programmed
by the BIOS and restore that upon resume.
Reported-by: Sitsofe Wheeler <sitsofe@yahoo.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> | ```diff
diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
index 791582c73ff7..ebdeab26ee3c 100644
--- a/drivers/char/agp/intel-gtt.c
+++ b/drivers/char/agp/intel-gtt.c
@@ -98,6 +98,7 @@ static struct _intel_private {
u8 __iomem *registers;
phys_addr_t gtt_bus_addr;
phys_addr_t gma_bus_addr;... |
cd44600fdd89832c0bc898189270a81be0db01cd | Analyze and fix the following issue in the Linux kernel code: iwlwifi: report scan completion when abort fail | Problem Details:
When we are not able to send abort command to firmware, notify mac80211
that we complete scan, as we will newer do it lately. Check for all
possible errors that low level sending command procedure does not check,
to assure we catch all failures cases.
Patch fix one of the causes of wdev_cleanup_work w... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index ea338498ee1c..dbb07e8dfcd7 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -54,34 +54,83 @@
#define IWL_PASSIVE_DWELL_BASE (100)
#define IWL_CHANNEL_T... |
d745d472afcbc6354ebfee008123894a7f37e97e | Analyze and fix the following issue in the Linux kernel code: iwlwifi: cancel scan when down the device | Problem Details:
Always cancel scan when stooping device and scan is currently pending,
we should newer have scan running after down device.
To assure we start scan cancel from restart work we have to schedule
abort_scan to different workqueue than priv->workqueue.
Patch fix not cancel scanning when restarting firmwa... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 36df9a7fcbcb..d2315debd1b8 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -2892,8 +2892,9 @@ static void __iwl_down(struct iwl_priv *priv)
IWL_DEBUG_INFO(pr... |
740c1aa3b01251c3c324743f395621749b099065 | Analyze and fix the following issue in the Linux kernel code: mac80211: Fix dangling pointer in ieee80211_xmit | Problem Details:
hdr pointer is left dangling after call to ieee80211_skb_resize. This
can cause guards around mesh path selection to fail.
Signed-off-by: Steve deRosier <steve@cozybit.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index ccf373788ce9..e1733dcb58a7 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1609,6 +1609,7 @@ static void ieee80211_xmit(struct ieee80211_sub_if_data *sdata,
return;
}
+ hdr = (struct ieee80211_hdr *) skb->data;
info->control.vif = &sda... |
65b7fc97473656eb35b6b58a22c7cef4a99d9e35 | Analyze and fix the following issue in the Linux kernel code: rt2x00: fix oops in rt2x00lib_txdone with rt61pci | Problem Details:
Fix a typo introduced in "rt2x00: Add helper function for reporting tx
status" that results in an oops in rt2x00lib_txdone.
Reported-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: Ivo van D... | ```diff
diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
index 286a5eb11339..8940070fe2a2 100644
--- a/drivers/net/wireless/rt2x00/rt61pci.c
+++ b/drivers/net/wireless/rt2x00/rt61pci.c
@@ -2117,7 +2117,7 @@ static void rt61pci_txdone(struct rt2x00_dev *rt2x00dev)
"TX statu... |
6646505de03b2ae85de09fd3b8d383ab816a19f9 | Analyze and fix the following issue in the Linux kernel code: rt2x00: Enable missing interrupts in rt61pci | Problem Details:
We're handling both, the CSR_BEACON_DONE and the CSR_TWAKEUP interrupts
in rt61pci. However, these interrupts are masked out by default. Fix
this.
Found via pure code inspection.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: ... | ```diff
diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
index 7a35f121e678..286a5eb11339 100644
--- a/drivers/net/wireless/rt2x00/rt61pci.c
+++ b/drivers/net/wireless/rt2x00/rt61pci.c
@@ -1654,6 +1654,7 @@ static void rt61pci_toggle_irq(struct rt2x00_dev *rt2x00dev,
rt2x00pc... |
0204464329c17ba6d293e1899f71223599a0e582 | Analyze and fix the following issue in the Linux kernel code: rt2x00: Check for specific changed flags when updating the erp config | Problem Details:
Previously rt2x00 was always updating all erp related config variables
even though mac80211 might only have changed one. Hence, pass the
changed flags to the config_erp driver callback so that the driver
can limit the changes to the correct values.
This fixes an issue in AP mode where the beacon inter... | ```diff
diff --git a/drivers/net/wireless/rt2x00/rt2400pci.c b/drivers/net/wireless/rt2x00/rt2400pci.c
index e3005ff5ae98..4b88909275a1 100644
--- a/drivers/net/wireless/rt2x00/rt2400pci.c
+++ b/drivers/net/wireless/rt2x00/rt2400pci.c
@@ -321,7 +321,8 @@ static void rt2400pci_config_intf(struct rt2x00_dev *rt2x00dev,
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.