id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
ebc89718a4b3fa0e440151fb4484541700828a5d | Analyze and fix the following issue in the Linux kernel code: MIPS: Fix build error for uncompressed non-plain vmlinux kernels | Problem Details:
Seen on rm200_defconfig for example:
CC arch/mips/boot/compressed/decompress.o
/home/ralf/src/linux/upstream-linus/arch/mips/boot/compressed/decompress.c: In function ‘decompress_kernel’:
/home/ralf/src/linux/upstream-linus/arch/mips/boot/compressed/decompress.c:116: error: implicit declaration... | ```diff
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 1893efd43fca..2dcb7a22582a 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -184,6 +184,15 @@ libs-$(CONFIG_CFE) += arch/mips/fw/cfe/
libs-$(CONFIG_SNIPROM) += arch/mips/fw/sni/
libs-y += arch/mips/fw/lib/
+#
+# Kernel compression
+#... |
21c2fd9970cc8e457058f84016450a2e9876125e | Analyze and fix the following issue in the Linux kernel code: x86: apic: Fix mismerge, add arch_probe_nr_irqs() again | Problem Details:
Merge commit aef55d4922 mis-merged io_apic.c so we lost the
arch_probe_nr_irqs() method.
This caused subtle boot breakages (udev confusion likely
due to missing drivers) with certain configs.
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <20100207210250.GB8256... | ```diff
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 979589881c80..72ac2a332993 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3876,6 +3876,28 @@ void __init probe_nr_irqs_gsi(void)
printk(KERN_DEBUG "nr_irqs_gsi: %d\n", nr_irqs_gsi);
}
+#... |
8d6184e4881b423522136aeb3ec1cbd9c35e8813 | Analyze and fix the following issue in the Linux kernel code: bonding: fix device leak on error in bond_create() | Problem Details:
When the register_netdevice() call fails, the newly allocated device is
not freed.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 1787e3c86573..430c02267d7e 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4946,6 +4946,8 @@ int bond_create(struct net *net, const char *name)
}
res = register_netdevice(bond_dev);
... |
3729d5021257b283f7fce33d957893162ccb2c9d | Analyze and fix the following issue in the Linux kernel code: rtnetlink: support specifying device flags on device creation | Problem Details:
commit e8469ed959c373c2ff9e6f488aa5a14971aebe1f
Author: Patrick McHardy <kaber@trash.net>
Date: Tue Feb 23 20:41:30 2010 +0100
Support specifying the initial device flags when creating a device though
rtnl_link. Devices allocated by rtnl_create_link() are marked as INITIALIZING
in order to surpress ... | ```diff
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 35609e64f6fd..b583d4968add 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -333,19 +333,17 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
struct veth_priv *priv;
char ifname[IFNAMSIZ];
struct nlattr *peer_tb[IF... |
71da81324c83ef65bb196c7f874ac1c6996d8287 | Analyze and fix the following issue in the Linux kernel code: rcu: Fix accelerated GPs for last non-dynticked CPU | Problem Details:
This patch disables irqs across the call to rcu_needs_cpu(). It
also enforces a hold-off period so that the idle loop doesn't
softirq itself to death when there are lots of RCU callbacks in
flight on the last non-dynticked CPU.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: laijs@cn... | ```diff
diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
index ed241fc478f0..464ad2cdee00 100644
--- a/kernel/rcutree_plugin.h
+++ b/kernel/rcutree_plugin.h
@@ -986,6 +986,7 @@ static void rcu_needs_cpu_flush(void)
#define RCU_NEEDS_CPU_FLUSHES 5
static DEFINE_PER_CPU(int, rcu_dyntick_drain);
+static ... |
a47cd880b50e14b0b6f5e9d426ae9a2676c9c474 | Analyze and fix the following issue in the Linux kernel code: rcu: Fix accelerated grace periods for last non-dynticked CPU | Problem Details:
It is invalid to invoke __rcu_process_callbacks() with irqs
disabled, so do it indirectly via raise_softirq(). This
requires a state-machine implementation to cycle through the
grace-period machinery the required number of times.
Located-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Paul E. McKenney... | ```diff
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index 335bfe4f0076..3ec8160fc75f 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -1341,6 +1341,9 @@ static void rcu_process_callbacks(struct softirq_action *unused)
* grace-period manipulations above.
*/
smp_mb(); /* See above block comment. */
+
... |
a9e7314b7940cee00b80995b360dbc06f995cc6e | Analyze and fix the following issue in the Linux kernel code: kernel-doc: track line numbers for each file separately | Problem Details:
The problem is that $. keeps track of the current record number (which
is line number by default). But if you pass it multiple files, it does
not wrap at the end of file, and therefore contains the *total* number
of processed lines.
I suppose we can fix line numbering by introducing a simple assignment... | ```diff
diff --git a/scripts/kernel-doc b/scripts/kernel-doc
index 241310e59cd6..8018f6a1dd04 100755
--- a/scripts/kernel-doc
+++ b/scripts/kernel-doc
@@ -2023,6 +2023,8 @@ sub process_file($) {
return;
}
+ $. = 1;
+
$section_counter = 0;
while (<IN>) {
if ($state == 0) {
``` |
4912002fffa377e66c5caefc2c311732a4ad5fb8 | Analyze and fix the following issue in the Linux kernel code: Remove EXPERIMENTAL from NFS_FSCACHE | Problem Details:
There's currently an open Ubuntu bug[0], with the intent to compile NFS_FSCACHE
(and possibly AFS_FSCACHE, 9P_FSCACHE) into the standard Ubuntu kernel.
However, since *_FSCACHE still depends on EXPERIMENTAL, this won't happen.
As Arjan van de Ven pointed out[1], the EXPERIMENTAL flag doesn't mean that... | ```diff
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index 59e5673b4597..a43d07e7b924 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -95,8 +95,7 @@ config ROOT_NFS
Most people say N here.
config NFS_FSCACHE
- bool "Provide NFS client caching support (EXPERIMENTAL)"
- depends on EXPERIMENTAL
+ bool "Provide ... |
29e1fa3565a7951cc415c634eb2b78dbdbee151d | Analyze and fix the following issue in the Linux kernel code: dvb-core: Fix DoS bug in ULE decapsulation code that can be triggered by an invalid Payload Pointer | Problem Details:
ULE (Unidirectional Lightweight Encapsulation RFC 4326) decapsulation
has a bug that causes endless loop when Payload Pointer of MPEG2-TS
frame is 182 or 183. Anyone who sends malicious MPEG2-TS frame will
cause the receiver of ULE SNDU to go into endless loop.
This patch was generated and tested aga... | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_net.c b/drivers/media/dvb/dvb-core/dvb_net.c
index 8b8558fcb042..b11533f76195 100644
--- a/drivers/media/dvb/dvb-core/dvb_net.c
+++ b/drivers/media/dvb/dvb-core/dvb_net.c
@@ -504,6 +504,7 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_le... |
f1c7f517a5dc23bce07efa5ed55e2c074ed9d4ba | Analyze and fix the following issue in the Linux kernel code: ftrace: Add function names to dangling } in function graph tracer | Problem Details:
The function graph tracer is currently the most invasive tracer
in the ftrace family. It can easily overflow the buffer even with
10megs per CPU. This means that events can often be lost.
On start up, or after events are lost, if the function return is
recorded but the function enter was lost, all we ... | ```diff
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index 112561df2a0a..e998a824e9db 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -18,6 +18,7 @@ struct fgraph_cpu_data {
pid_t last_pid;
int depth;
int ignore;
+ unsi... |
cbaee472f274ea9a98aabe47025f6e5551acadcb | Analyze and fix the following issue in the Linux kernel code: ocfs2: Only bug out in direct io write for reflinked extent. | Problem Details:
In ocfs2_direct_IO_get_blocks, we only need to bug out
in case of we are going to write a recounted extent rec.
What a silly bug introduced by me!
Signed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Cc: stable@kernel.org | ```diff
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 7e9df11260f4..4c2a6d282c4d 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -577,8 +577,9 @@ static int ocfs2_direct_IO_get_blocks(struct inode *inode, sector_t iblock,
goto bail;
}
- /* We should already CoW the refcounted extent. */
- BUG_ON(ext... |
66b116c9d8f70baadf5b2145dddb35af222df041 | Analyze and fix the following issue in the Linux kernel code: ocfs2: fix warning in ocfs2_file_aio_write() | Problem Details:
This patch fixes a compiling warning in ocfs2_file_aio_write().
Signed-off-by: Coly Li <coly.li@suse.de>
Signed-off-by: Joel Becker <joel.becker@oracle.com> | ```diff
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index da097bd07b72..c8a4a2939e55 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -2041,7 +2041,7 @@ out_dio:
* async dio is going to do it in the future or an end_io after an
* error has already done it.
*/
- if (ret == -EIOCBQUEUED || !ocfs2_iocb_is... |
6b240ff63c9dda93366c61c969b81ca22fe676ac | Analyze and fix the following issue in the Linux kernel code: ocfs2: Prefix the member fields of struct ocfs2_xattr_info. | Problem Details:
struct ocfs2_xattr_info is a useful structure describing an xattr
you'd like to set. Let's put prefixes on the member fields so it's
easier to read and use.
Signed-off-by: Joel Becker <joel.becker@oracle.com> | ```diff
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
index 22a60a7c35ca..c675a6cda0bb 100644
--- a/fs/ocfs2/xattr.c
+++ b/fs/ocfs2/xattr.c
@@ -116,10 +116,10 @@ static struct xattr_handler *ocfs2_xattr_handler_map[OCFS2_XATTR_MAX] = {
};
struct ocfs2_xattr_info {
- int name_index;
- const char *name;
- const vo... |
0e0a228398cc967c922759be36c69d32e4f62701 | Analyze and fix the following issue in the Linux kernel code: mac80211: fix direct probe loop on ieee80211_work_purge | Problem Details:
If authentication has already been performed when the WLAN interface is
stopped, (sometimes) the ieee80211_work_purge would corrupt some
ieee80211_work-structures. The outcome is this (cleaned up):
[ 2252.398681] WARNING: at net/mac80211/work.c:995 ieee80211_work_purge
[ 2252.466430] Backtrace:
[ 2252... | ```diff
diff --git a/net/mac80211/work.c b/net/mac80211/work.c
index 7e708d5c88b4..1e1ea3007b06 100644
--- a/net/mac80211/work.c
+++ b/net/mac80211/work.c
@@ -869,6 +869,7 @@ static void ieee80211_work_work(struct work_struct *work)
break;
case IEEE80211_WORK_ABORT:
rma = WORK_ACT_TIMEOUT;
+ break;
case... |
7bfbae10dc10a5c94a780d117a57e875d77e8e5a | Analyze and fix the following issue in the Linux kernel code: ath9k: disable RIFS search for AR91xx based chips | Problem Details:
While ath9k does not support RIFS yet, the ability to receive RIFS
frames is currently enabled for most chipsets in the initvals.
This is causing baseband related issues on AR9160 and AR9130 based
chipsets, which can lock up under certain conditions.
This patch fixes these issues by overriding the ini... | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index f00f5c744f48..2e767cf22f1e 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -1310,6 +1310,16 @@ static void ath9k_hw_override_ini(struct ath_hw *ah,
* Necessary to avoid i... |
0cbde8ee60c883b246fb50dfed8bcd968239702b | Analyze and fix the following issue in the Linux kernel code: [S390] zcore: Add prefix registers to dump header | Problem Details:
With this patch the prefix registers of all online CPUs are stored in the
the zcore dump header. This allows dump analysis tools to access the register
information that is stored in the prefix pages without using the System.map.
Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Signed-off-by... | ```diff
diff --git a/drivers/s390/char/zcore.c b/drivers/s390/char/zcore.c
index d688693f09b8..3438658b66b7 100644
--- a/drivers/s390/char/zcore.c
+++ b/drivers/s390/char/zcore.c
@@ -204,7 +204,7 @@ static int __init init_cpu_info(enum arch_id arch)
static DEFINE_MUTEX(zcore_mutex);
-#define DUMP_VERSION 0x3
+#def... |
73bfa5f2f71efcdcaad8d18cbed96b9d7ed86948 | Analyze and fix the following issue in the Linux kernel code: [S390] Define new s390 ELF note sections in elf.h | Problem Details:
S390 ELF core dump currently only contains the PSW, the general purpose
registers, the floating point registers and the access registers stored
in PRSTATUS/PRFPREG note sections.
For analyzing s390 kernel problems additional registers are important.
In order to be able to include these registers to a k... | ```diff
diff --git a/include/linux/elf.h b/include/linux/elf.h
index 0cc4d55151b7..39ad4b230a4a 100644
--- a/include/linux/elf.h
+++ b/include/linux/elf.h
@@ -362,6 +362,11 @@ typedef struct elf64_shdr {
#define NT_386_TLS 0x200 /* i386 TLS slots (struct user_desc) */
#define NT_386_IOPERM 0x201 /* x86 io permissio... |
589c74d5076dd1bde13a5a36d97ca79be8bd72b2 | Analyze and fix the following issue in the Linux kernel code: [S390] dasd: fix refcounting. | Problem Details:
The function dasd_device_from_cdev returns a reference to the dasd
device and increases the refcount by one. If an exception occurs,
the refcount was not decreased in all cases
e.g. in dasd_discipline_show.
Prevent the offline processing from hang by correcting two functions
to decrease the refcount ev... | ```diff
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 56df3c5ed385..302ca14a69e5 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -1003,12 +1003,20 @@ static void dasd_handle_killed_request(struct ccw_device *cdev,
return;
}
- device = (struct dasd_device *) cq... |
9eb251225ab4dbea3119cfcf4c5194eed223a740 | Analyze and fix the following issue in the Linux kernel code: [S390] dasd: fix online/offline race | Problem Details:
Setting a DASD online and offline in quick succession may cause
a kernel panic or let the chhccwdev command wait forever.
The Online process is split into two parts. After the first part
is finished the offline process may be called. This may result
in a situation where the second online processing par... | ```diff
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 5905936c7c60..56df3c5ed385 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -20,6 +20,7 @@
#include <linux/buffer_head.h>
#include <linux/hdreg.h>
#include <linux/async.h>
+#include <linux/mutex.h>
#include <... |
52499f40267e1178b3b2c887aee85c0c9fd01ec0 | Analyze and fix the following issue in the Linux kernel code: [S390] bug: use relative pointers in bug table entries | Problem Details:
Reduces the size of the bug table entries by 50% on 64bit kernels.
Saves around 30kb on a defconfig kernel.
s390 version of b93a531e "allow bug table entries to use relative
pointers (and use it on x86-64)".
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <s... | ```diff
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index c80235206c01..40334872f5ea 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -54,6 +54,9 @@ config GENERIC_BUG
depends on BUG
default y
+config GENERIC_BUG_RELATIVE_POINTERS
+ def_bool y
+
config NO_IOMEM
def_bool y
diff --git a/arch/s3... |
d96221ab1e7d86dc0d4666466979117cd1915386 | Analyze and fix the following issue in the Linux kernel code: [S390] free_initmem: reduce code duplication | Problem Details:
free_initmem() and free_initrd_mem() are nearly identical. So make them
call a common function.
Also fixes a bug: if the initrd wouldn't start on a page boundary also
memory after the initrd would be initialized with the poison value.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-of... | ```diff
diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
index 765647952221..d5865e4024ce 100644
--- a/arch/s390/mm/init.c
+++ b/arch/s390/mm/init.c
@@ -143,33 +143,34 @@ void kernel_map_pages(struct page *page, int numpages, int enable)
}
#endif
-void free_initmem(void)
+void free_init_pages(char *what, unsi... |
b8e660b83d505148c83ddc6d5ba69c29d0eab1e3 | Analyze and fix the following issue in the Linux kernel code: [S390] Replace ENOTSUPP usage with EOPNOTSUPP | Problem Details:
ENOTSUPP is not supposed to leak to userspace so lets just use
EOPNOTSUPP everywhere.
Doesn't fix a bug, but makes future reviews easier.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> | ```diff
diff --git a/arch/s390/hypfs/hypfs_diag.c b/arch/s390/hypfs/hypfs_diag.c
index 2b92d501425f..87cf523192e9 100644
--- a/arch/s390/hypfs/hypfs_diag.c
+++ b/arch/s390/hypfs/hypfs_diag.c
@@ -488,7 +488,7 @@ out:
static int diag224(void *ptr)
{
- int rc = -ENOTSUPP;
+ int rc = -EOPNOTSUPP;
asm volatile(
"... |
8387c736fcbaec17890b8d075ee4f4623518b54a | Analyze and fix the following issue in the Linux kernel code: [S390] sysinfo: fix SYSIB 3,2,2 structure | Problem Details:
The size of the field that contains the description block count is
only four bits instead of eight bits.
The first four bits are reserved but this might change and break.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> | ```diff
diff --git a/arch/s390/include/asm/sysinfo.h b/arch/s390/include/asm/sysinfo.h
index 9d70057d828c..22bdb2a0ee5f 100644
--- a/arch/s390/include/asm/sysinfo.h
+++ b/arch/s390/include/asm/sysinfo.h
@@ -87,7 +87,8 @@ struct sysinfo_2_2_2 {
struct sysinfo_3_2_2 {
char reserved_0[31];
- unsigned char count;
+ un... |
d1bf85902c28dd990c08f1703ea94109223549a7 | Analyze and fix the following issue in the Linux kernel code: [S390] cio: fix storage key handling | Problem Details:
Some parts of cio do not shift PAGE_DEFAULT_KEY correctly and end up
with an incorrect key in their data structures.
Since the default key is zero this doesn't really matter. However if
somebody would use key-controlled protection for debugging purposes
it would be quite helpful if all of this would wo... | ```diff
diff --git a/arch/s390/include/asm/page.h b/arch/s390/include/asm/page.h
index 5e9daf5d7f22..af650fb47206 100644
--- a/arch/s390/include/asm/page.h
+++ b/arch/s390/include/asm/page.h
@@ -107,9 +107,6 @@ typedef pte_t *pgtable_t;
#define __pgd(x) ((pgd_t) { (x) } )
#define __pgprot(x) ((pgprot_t) { ... |
d4080cb32ee3d2ed18aa69ffde6010524bd686cd | Analyze and fix the following issue in the Linux kernel code: mtd: r852 fix pci ID | Problem Details:
The PCI_DEVICE_ID_RICOH_R5C852 was missed in the edited commit, and on
second thought I just open code it.
This fixes compile error.
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> | ```diff
diff --git a/drivers/mtd/nand/r852.c b/drivers/mtd/nand/r852.c
index 7a616a926ee9..218a42dadff1 100644
--- a/drivers/mtd/nand/r852.c
+++ b/drivers/mtd/nand/r852.c
@@ -1083,7 +1083,7 @@ int r852_resume(struct device *device)
static const struct pci_device_id r852_pci_id_tbl[] = {
- { PCI_VDEVICE(RICOH, PCI_... |
6070a4a928f8c92b9fae7d6717ebbb05f425d6b2 | Analyze and fix the following issue in the Linux kernel code: drm/i915: Use a dmi quirk to skip a broken SDVO TV output. | Problem Details:
This IBM system has a multi-function SDVO card that reports both VGA
and TV, but the system has no TV connector. The TV connector always
reported as connected, which would lead to poor modesetting choices.
https://bugs.freedesktop.org/show_bug.cgi?id=25787
Signed-off-by: Zhao Yakui <yakui.zhao@intel... | ```diff
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index 82678d30ab06..48daee5c9c63 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -35,6 +35,7 @@
#include "i915_drm.h"
#include "i915_drv.h"
#include "intel_sdvo_regs.h"
+#include <linu... |
1f7a6e372e9cb4d749f34c0738d832e6cadb4071 | Analyze and fix the following issue in the Linux kernel code: drm/i915: Add dependency on the intel agp module | Problem Details:
See http://bugzilla.kernel.org/show_bug.cgi?id=15021
Make sure that the appropriate AGP module is loaded and probed before
trying to set up the DRM. The DRM already depends on the AGP core,
but in this case we know the specific AGP driver we need too, and can
help users avoid the trap of loading the ... | ```diff
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index 918e484f41b7..c1c07a2ccb11 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -10,6 +10,9 @@
#include <linux/agp_backend.h>
#include "agp.h"
+int intel_agp_enabled;
+EXPORT_SYMBOL(intel_agp_enabled);
... |
14bc490bbdf1b194ad1f5f3d2a0a27edfdf78986 | Analyze and fix the following issue in the Linux kernel code: drm/i915, agp/intel: Fix stolen memory size on Sandybridge | Problem Details:
New memory control config reg at 0x50 should be used for stolen
memory size detection on Sandybridge.
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Eric Anholt <eric@anholt.net> | ```diff
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index c3c870bf5678..9a551bc34c39 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -150,6 +150,25 @@ extern int agp_memory_reserved;
#define INTEL_I7505_AGPCTRL 0x70
#define INTEL_I7505_MCHCFG 0x50
+#defin... |
f6e450a6417460db6a74241de8aaab5116cac140 | Analyze and fix the following issue in the Linux kernel code: drm/i915: Fix sandybridge status page setup. | Problem Details:
The register's moved to the same location as the one for the BCS, it seems.
Signed-off-by: Eric Anholt <eric@anholt.net> | ```diff
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 742bd8f738ca..b57efca02901 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -136,6 +136,12 @@ const static struct intel_device_info intel_ironlake_m_info = {
.has_hotplug = 1,
};
+const... |
133fa8c7d70d16b07db3a3d87ea18291db8f8ebf | Analyze and fix the following issue in the Linux kernel code: mtd: Few follow up cleanups for Smartmedia/xD support | Problem Details:
* Test results of few functions that were declared with __must_check
* Fix bogus gcc warning about uinitialized variable 'ret'
* Remove unused variable from mtdblock_remove_dev
* Don't use deprecated DMA_32BIT_MASK
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: David Woodhouse ... | ```diff
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 9dd23d6acbb6..e32c49cb4005 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -380,9 +380,11 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
add_disk(gd);
- if (new->disk_attributes)
- sysfs_create_g... |
a9c9b4429df437982d2fbfab1f4b46b01329e9ed | Analyze and fix the following issue in the Linux kernel code: PM / Hibernate: Fix preallocating of memory | Problem Details:
The hibernate memory preallocation code allocates memory to push some
user space data out of physical RAM, so that the hibernation image is
not too large. It allocates more memory than necessary for creating
the image, so it has to release some pages to make room for
allocations made while suspending ... | ```diff
diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index 2eda40741aaa..830cadecbdfc 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -1181,7 +1181,7 @@ static void free_unnecessary_pages(void)
memory_bm_position_reset(©_bm);
- while (to_free_normal > 0 && to_free_highm... |
6d19c009cc780c63de25a046509ebc9473809fd6 | Analyze and fix the following issue in the Linux kernel code: USB: implement non-tree resume ordering constraints for PCI host controllers | Problem Details:
This patch (as1331) adds non-tree ordering constraints needed for
proper resume of PCI USB host controllers from hibernation. The main
issue is that non-high-speed devices must not be resumed before the
high-speed root hub, because it is the ehci_bus_resume() routine which
takes care of handing the de... | ```diff
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 60a45f1e3a67..f2f055eb6831 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -1022,6 +1022,14 @@ static int usb_resume_device(struct usb_device *udev, pm_message_t msg)
goto done;
}
+ /* Non-root devices on a... |
5a2eb8585f3b38e01e30aacaa8b985a1520a993d | Analyze and fix the following issue in the Linux kernel code: PM: Add facility for advanced testing of async suspend/resume | Problem Details:
Add configuration switch CONFIG_PM_ADVANCED_DEBUG for compiling in
extra PM debugging/testing code allowing one to access some
PM-related attributes of devices from the user space via sysfs.
If CONFIG_PM_ADVANCED_DEBUG is set, add sysfs attribute power/async
for every device allowing the user space to... | ```diff
diff --git a/Documentation/ABI/testing/sysfs-devices-power b/Documentation/ABI/testing/sysfs-devices-power
index 431bfd7e65c7..6123c523bfd7 100644
--- a/Documentation/ABI/testing/sysfs-devices-power
+++ b/Documentation/ABI/testing/sysfs-devices-power
@@ -51,3 +51,29 @@ Description:
drivers. Changing this at... |
8cc6b39ff36b4bbce2d7471da088df122b0e9033 | Analyze and fix the following issue in the Linux kernel code: PM: Add parent information to timing messages | Problem Details:
Add parent information to the messages printed by the suspend/resume
core when initcall_debug is set.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> | ```diff
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index a5142bddef41..6ca5cdf63849 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -271,8 +271,9 @@ static int pm_noirq_op(struct device *dev,
ktime_t calltime, delta, rettime;
if (initcall_debug) {
- pr_info("call... |
84f3751d6a6f766780dee509433bf7b3dfcdf465 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: v4l: soc_camera: fix bound checking of mbus_fmt[] index | Problem Details:
When code <= V4L2_MBUS_FMT_FIXED soc_mbus_get_fmtdesc returns a pointer to
mbus_fmt[x], where x < 0. Fix this.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
CC: stable@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/soc_mediabus.c b/drivers/media/video/soc_mediabus.c
index 0149290ee5a6..8b63b6545e76 100644
--- a/drivers/media/video/soc_mediabus.c
+++ b/drivers/media/video/soc_mediabus.c
@@ -149,7 +149,8 @@ EXPORT_SYMBOL(soc_mbus_bytes_per_line);
const struct soc_mbus_pixelfmt *soc_mbus_get... |
d2fa21876147005ba942cef1d9e5a5039b4326bd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: MAINTAINERS: Telegent tlg2300 section fix | Problem Details:
linux-next commit 2ff8223957d901999bf76aaf2c6183e33a6ad14e
exposes an infinite loop defect in scripts/get_maintainer.pl
Fix the incorrect format of the MAINTAINERS "M:" entries.
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Huang Shijie <shijie8@gmail.com>
Signed-off-by: Mauro Carvalho Cheha... | ```diff
diff --git a/MAINTAINERS b/MAINTAINERS
index f427294b85e0..f8bd5814bdda 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4677,13 +4677,12 @@ F: drivers/media/video/*7146*
F: include/media/*7146*
TLG2300 VIDEO4LINUX-2 DRIVER
-M Huang Shijie <shijie8@gmail.com>
-M Kang Yong <kangyong@telegent.com>
-M Zhang X... |
e7637521ac92ce99045b8f8a9c1419bb7814ff9a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca_main: Fix a compile error when CONFIG_INPUT is not set | Problem Details:
gspca_main: Fix a compile error when CONFIG_INPUT is not set.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
index a156dd42bc40..222af479150b 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -281,7 +281,7 @@ static void gspca_input_destroy_urb(struct gspca_dev *gspca_dev)
}
#else
#define gspca... |
10ee2402004d03b31555aad7badf7e499fa686d3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca_main: some input error handling fixes | Problem Details:
2 small changes to input device error handling:
1) Make it fatal when we fail to create an input device (it is either this
or add checks for gspca_dev->input_dev being NULL in a lot of places)
2) Since we allow gspca_input_create_urb() to fail everywhere we call it,
and thus never check its retur... | ```diff
diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
index d9a934b99a89..a156dd42bc40 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -184,8 +184,7 @@ static int gspca_input_connect(struct gspca_dev *dev)
} else {
dev->input_dev = in... |
587808d5f59e842f9258a15e88ad530fcf6e6763 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: ivtv: Fix ivtv_api_get_data() to avoid unneeded IO during IRQ handling | Problem Details:
ivtv_api_get_data() was performing more PCI MMIO than needed, resulting
often in it accounting for more than half the total time spent in
ivtv_irq_handler(). Now it only reads at most 7 of the 16 mailbox data words
over the PCI bus, and in some instances only 2 or 3 data words as needed.
Signed-off-b... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c
index c1b7ec475c27..a71e8ba306b0 100644
--- a/drivers/media/video/ivtv/ivtv-firmware.c
+++ b/drivers/media/video/ivtv/ivtv-firmware.c
@@ -258,7 +258,7 @@ void ivtv_init_mpeg_decoder(struct ivtv *itv)
IVTV_ERR("iv... |
995f5fefb0c6abba3688b3aadf40e422b64b814a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: media-spec: Fix documentation mistakes regarding I/O streaming | Problem Details:
The media spec contains several errors in the description of the
I/O streaming ioctls, in particular with respect to the userptr
I/O method.
The most important change is that you really need to set count
and index in v4l2_requestbuffer and v4l2_buffer when dealing with
user pointer streaming.
Signed-... | ```diff
diff --git a/Documentation/DocBook/v4l/io.xml b/Documentation/DocBook/v4l/io.xml
index f92f24323b2a..e870330cbf77 100644
--- a/Documentation/DocBook/v4l/io.xml
+++ b/Documentation/DocBook/v4l/io.xml
@@ -589,7 +589,8 @@ number of a video input as in &v4l2-input; field
<entry></entry>
<entry>A place h... |
340dde817a4f68af79453ed295ca0e8de7232669 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: saa7115: fix saa7111a support | Problem Details:
When the saa7111 driver was merged into saa7115 several bugs were introduced,
in particular with the saa7111a support as is used in the mxb.c driver.
This patch fixes the saa7111a support. This was tested with the mxb driver.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carval... | ```diff
diff --git a/drivers/media/video/mxb.c b/drivers/media/video/mxb.c
index 823f126b89cc..9f01f14e4aa2 100644
--- a/drivers/media/video/mxb.c
+++ b/drivers/media/video/mxb.c
@@ -298,7 +298,7 @@ static int mxb_init_done(struct saa7146_dev* dev)
/* select tuner-output on saa7111a */
i = 0;
saa7111a_call(mxb, v... |
cd7d9beb09d89d62bc3c6336e4cb9a2ee3da6163 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: saa7146_vv: fix regression where v4l2_device was registered too late | Problem Details:
v4l2_device_register needs to be called before the i2c subdevs are loaded.
However, it was called afterwards in the saa7146 driver. This caused an oops
when loading the mxb and hexium drivers. The vv_init function is now split
into two: one registers the v4l2_device, the other does the rest of the
init... | ```diff
diff --git a/drivers/media/common/saa7146_fops.c b/drivers/media/common/saa7146_fops.c
index 7364b9642d00..fd8e1f45be36 100644
--- a/drivers/media/common/saa7146_fops.c
+++ b/drivers/media/common/saa7146_fops.c
@@ -423,14 +423,15 @@ static void vv_callback(struct saa7146_dev *dev, unsigned long status)
}
}
... |
e54532e591cd5b9ce77dbc8d9786ae9f600f101a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: uvcvideo: Clamp control values to the minimum and maximum values | Problem Details:
When setting a control, the V4L2 specification requires drivers to
either clamp the control value to the [minimum, maximum] range or return
the -ERANGE error.
Fix the driver to clamp control values to the valid range in
uvc_ctrl_set() and make sure the value differs from the minimum by an
integer mult... | ```diff
diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video/uvc/uvc_ctrl.c
index 5ff501390842..f38bc6bbc3d2 100644
--- a/drivers/media/video/uvc/uvc_ctrl.c
+++ b/drivers/media/video/uvc/uvc_ctrl.c
@@ -1021,19 +1021,57 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
{
struct uvc_control *ctrl;
... |
8a4e76c14cbe0609fdb5c558f867fe7c556bb1c7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: uvcvideo: Return -ERANGE when setting a control to an out-of-range menu index | Problem Details:
The V4L2 specification states that out of bounds control values must
either be clamped to the valid range or result in a -ERANGE error code.
Fix the driver to return -ERANGE instead of -EINVAL when setting a menu
control to an invalid value.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonbo... | ```diff
diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video/uvc/uvc_ctrl.c
index 61576946329d..f4e5ba260968 100644
--- a/drivers/media/video/uvc/uvc_ctrl.c
+++ b/drivers/media/video/uvc/uvc_ctrl.c
@@ -1006,7 +1006,7 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
if (mapping->v4l2_type == V4L2_... |
56d15cd313d0d0d7a16c1a2e2cc519f18ab4725a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: uvcvideo: Increase the streaming control timeout to 5 seconds | Problem Details:
This fixes timeout issues with some Logitech webcams. The timeout value
seems to match the one used in the Logitech Windows driver, so no
further increase should be necessary.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/uvc/uvcvideo.h b/drivers/media/video/uvc/uvcvideo.h
index 6aa9b2c2b685..d0d3e25e1c09 100644
--- a/drivers/media/video/uvc/uvcvideo.h
+++ b/drivers/media/video/uvc/uvcvideo.h
@@ -152,7 +152,7 @@ struct uvc_xu_control {
#define UVC_MAX_STATUS_SIZE 16
#define UVC_CTRL_CONTROL_T... |
e070bf9ef85e293d9dc586fbfabc008795564c0e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca - main: Fix a compile error when CONFIG_INPUT is not set | Problem Details:
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
index 1e24acd4d940..96a77697eb1e 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -40,8 +40,10 @@
#include "gspca.h"
+#ifdef CONFIG_INPUT
#include <linux/input.h>
#include <linux/us... |
7d3502844609df0985932365197f905e4ea95d22 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: tuner-xc2028: Fix demod breakage for XC3028L | Problem Details:
A small mistake on the last patch broke demod s-code setup for
XC3028L (firmware 3.2 and upper). Fix it.
Thanks-to: Stefan Ringel <stefan.ringel@arcor.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers/media/common/tuners/tuner-xc2028.c
index 96f45a80fe56..be51c294b375 100644
--- a/drivers/media/common/tuners/tuner-xc2028.c
+++ b/drivers/media/common/tuners/tuner-xc2028.c
@@ -1135,11 +1135,13 @@ static int xc2028_set_params(struct dvb_frontend ... |
7f2199c03b4946f1b79514b3411e3dbf130a6bba | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: tuner-xc2028: fix tuning logic to solve a regression in Australia | Problem Details:
There's one reported regression in Australia (DTV7) and some
reported troubles with newer firmwares found on xc3028l chips.
Rework the logic to improve tuner on those cases.
Thanks-to: Robert Lowery <rglowery@exemail.com.au>
Thanks-to: Stefan Ringel <stefan.ringel@arcor.de>
Tested-by: Robert Lowery <r... | ```diff
diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers/media/common/tuners/tuner-xc2028.c
index f270e605da83..96f45a80fe56 100644
--- a/drivers/media/common/tuners/tuner-xc2028.c
+++ b/drivers/media/common/tuners/tuner-xc2028.c
@@ -917,30 +917,68 @@ static int generic_set_freq(struct dvb_frontend *fe... |
7ccf1eea972177064b4df9d5ba68958604781db6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: dvb: fix sparse warnings | Problem Details:
Fix sparse warnings in media/dvb/frontends:
drivers/media/dvb/frontends/dibx000_common.c:177:13: warning: non-ANSI function declaration of function 'systime'
drivers/media/dvb/frontends/tda665x.c:136:55: warning: right shift by bigger than source value
[mchehab@redhat.com: removed the change at dib00... | ```diff
diff --git a/drivers/media/dvb/frontends/dibx000_common.c b/drivers/media/dvb/frontends/dibx000_common.c
index e6f3d73db9d3..980e02f1575e 100644
--- a/drivers/media/dvb/frontends/dibx000_common.c
+++ b/drivers/media/dvb/frontends/dibx000_common.c
@@ -174,7 +174,7 @@ void dibx000_exit_i2c_master(struct dibx000_i... |
08cf8a57c51da7db9633c2827b3dbabfb7df51fd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: media/video/tlg2300: fix build when CONFIG_PM=n | Problem Details:
When CONFIG_PM is not enabled, tlg2300 has build errors,
so handle that case, mostly via stubs.
drivers/media/video/tlg2300/pd-alsa.c:237: error: 'struct poseidon' has no member named 'msg'
drivers/media/video/tlg2300/pd-main.c:412: error: implicit declaration of function 'find_old_poseidon'
drivers/m... | ```diff
diff --git a/drivers/media/video/tlg2300/pd-common.h b/drivers/media/video/tlg2300/pd-common.h
index ae9cb6c581ac..46066bdc73f9 100644
--- a/drivers/media/video/tlg2300/pd-common.h
+++ b/drivers/media/video/tlg2300/pd-common.h
@@ -254,7 +254,11 @@ void destroy_video_device(struct video_device **v_dev);
extern ... |
546e29b66a1aeec3b6a710aceeb2149871570416 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: timberdale: fix mfd build | Problem Details:
Fix mfd/timberdale build error -- add depends GPIOLIB.
include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
build-r7353.out:make[3]: *** [drivers/mfd/timberdale.o] Error 1
Repairs
commit ff7a26e08a16bb31158d830dbf60db2ff47019ab
Author: Richard R<C3><B6>jfors <richard.rojfors@p... | ```diff
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index eb22deeecb1a..413576a2f313 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -351,7 +351,7 @@ config AB4500_CORE
config MFD_TIMBERDALE
tristate "Support for the Timberdale FPGA"
select MFD_CORE
- depends on PCI
+ depends on PCI && GPI... |
dfbd5d4d324e630aedc40b7519351a9c0fe94dc9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: tvp7002: fix compilation breakage when advanced debug is enabled | Problem Details:
> On Mon, 22 Feb 2010 08:21:44 -0800 Randy Dunlap wrote:
> drivers/media/video/tvp7002.c:896: error: 'struct tvp7002' has no member named 'registers'
>
> so where are these registers??
Hmm, that code is a remnant from older revisions of this driver. Unfortunately,
when I compiled this driver before cr... | ```diff
diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c
index 0f0270b1ad7a..5a878bca02d4 100644
--- a/drivers/media/video/tvp7002.c
+++ b/drivers/media/video/tvp7002.c
@@ -859,13 +859,17 @@ static int tvp7002_g_register(struct v4l2_subdev *sd,
struct v4l2_dbg_register *reg)
{
struct... |
4105ed5df1e16afbbea4c96f8d513bda21248308 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: AZ6027: Fix build warnings | Problem Details:
drivers/media/dvb/dvb-usb/az6027.c:390: warning: excess elements in struct initializer
drivers/media/dvb/dvb-usb/az6027.c:390: warning: (near initialization for ‘az6027_rc_keys[0]’)
drivers/media/dvb/dvb-usb/az6027.c:391: warning: excess elements in struct initializer
drivers/media/dvb/dvb-usb/az6027.c... | ```diff
diff --git a/drivers/media/dvb/dvb-usb/az6027.c b/drivers/media/dvb/dvb-usb/az6027.c
index 30fd046d9d0d..d7290b2c0913 100644
--- a/drivers/media/dvb/dvb-usb/az6027.c
+++ b/drivers/media/dvb/dvb-usb/az6027.c
@@ -387,8 +387,8 @@ static int az6027_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff)
/* keys ... |
5f0e1cff5d19935bef1a6a2cdbd7f39b92031726 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: AZ6027: Fix checkpatch violations | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/az6027.c b/drivers/media/dvb/dvb-usb/az6027.c
index 555c8f440793..30fd046d9d0d 100644
--- a/drivers/media/dvb/dvb-usb/az6027.c
+++ b/drivers/media/dvb/dvb-usb/az6027.c
@@ -10,18 +10,17 @@
* see Documentation/dvb/README.dvb-usb for more information
*/
#include "az6027.... |
433763faec55e5f0e3aeb084da504c566134a934 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: Kworld 315U remote support | Problem Details:
Adds remote support for the Kworld 315U device
I have added the change for the IR_TYPE_NEC that Mauro suggested.
Note: I believe I got most of the mappings correct. Though the
source and shutdown button probably could be mapped to something
better.
[mchehab@redhat.com: Fix CodingStyle]
Signed-off-b... | ```diff
diff --git a/drivers/media/IR/ir-keymaps.c b/drivers/media/IR/ir-keymaps.c
index 71b3278f67e5..0efdefe75f32 100644
--- a/drivers/media/IR/ir-keymaps.c
+++ b/drivers/media/IR/ir-keymaps.c
@@ -3441,3 +3441,54 @@ struct ir_scancode_table ir_codes_winfast_usbii_deluxe_table = {
.size = ARRAY_SIZE(ir_codes_winfast... |
96dd6de3d058a454a5bc4ce2f561a053dd90bfae | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: drivers/media/radio/si470x/radio-si470x-usb.c fix use after free | Problem Details:
In si470x_usb_driver_disconnect() radio->disconnect_lock is accessed
after it is freed. This fixes the problem.
Coverity CID: 2530
Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/radio/si470x/radio-si470x-usb.c b/drivers/media/radio/si470x/radio-si470x-usb.c
index a0a79c70dd5b..6f60841828da 100644
--- a/drivers/media/radio/si470x/radio-si470x-usb.c
+++ b/drivers/media/radio/si470x/radio-si470x-usb.c
@@ -842,9 +842,11 @@ static void si470x_usb_driver_disconnect... |
fd9be0dc9b0b2baf203cfef8c8109859d05d0e01 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: DVB: ngene, fix memset parameters | Problem Details:
Switch second and third memset parameter to stamp the length buffer bytes
by 0xff's, not 255 bytes by low 8 bits of Length.
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@gmail.com, Matthias Benesch <twoof7@freenet.de>, Ralph Metzler <rjkm@metzlerbros.de>, Oliver Endriss <o... | ```diff
diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index cb5982ed8504..0150dfe7cfbb 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
{
u32 *ptr =... |
f0289efa1938eac27a98883bf33af946b13e1110 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: dst: fixes for DVB-C Twinhan VP2031 | Problem Details:
Remove check "state->dst_type == DST_DTYPE_IS_CABLE" in function
dst_get_tuna (around line 1352) to select the correct checksum
computation
Fill in the .caps field in struct dst_dvbc_ops (around line 1824) with
all the supported QAM modulation methods to match the capabilities of
the card as impleme... | ```diff
diff --git a/drivers/media/dvb/bt8xx/dst.c b/drivers/media/dvb/bt8xx/dst.c
index 91353a6faf1d..8b0cde38984d 100644
--- a/drivers/media/dvb/bt8xx/dst.c
+++ b/drivers/media/dvb/bt8xx/dst.c
@@ -1352,8 +1352,7 @@ static int dst_get_tuna(struct dst_state *state)
return retval;
}
if ((state->type_flags & DST_T... |
fad93fdb14f13e7b869a878c0fba3b6e0f91e0b6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: STV0900 Cut 3.0 AGC2 fix for NetUP Dual DVB-S2-CI card | Problem Details:
if the AGC2 > 1400 then no signal on this frequency for STV0900 Cut 3.0. For
Cut 2.0 this value is 700.
Signed-off-by: Abylay Ospan <aospan@netup.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv0900_sw.c b/drivers/media/dvb/frontends/stv0900_sw.c
index 96a5a5e29ede..ba0709b2d433 100644
--- a/drivers/media/dvb/frontends/stv0900_sw.c
+++ b/drivers/media/dvb/frontends/stv0900_sw.c
@@ -1230,6 +1230,9 @@ fe_stv0900_signal_type stv0900_get_signal_params(struct dvb... |
0a71102f105870a4a245edd1b291fa723a8f3a48 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: Fix logic for Leadtek winfast tv usbii deluxe | Problem Details:
As pointed by Magnus Alm <magnus.alm@gmail.com>, commit 99dbd128bb applied
a hunk at the wrong place. This patch moves the code to the right place.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c
index b1c5d9516e22..62ca31d44b56 100644
--- a/drivers/media/video/em28xx/em28xx-cards.c
+++ b/drivers/media/video/em28xx/em28xx-cards.c
@@ -2300,6 +2300,10 @@ void em28xx_register_i2c_ir(struct em28xx *dev)
dev... |
87147ff03a8aa27b9cc94872b195e6f8bb922feb | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: get_dvb_firmware: Fix typo, sort list of components | Problem Details:
Commiter: Oliver Endriss <o.endriss@gmx.de>
Fix typo. Sort list of components for better readability.
Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/Documentation/dvb/get_dvb_firmware b/Documentation/dvb/get_dvb_firmware
index f550fdaa9833..239cbdbf4d12 100644
--- a/Documentation/dvb/get_dvb_firmware
+++ b/Documentation/dvb/get_dvb_firmware
@@ -39,7 +39,7 @@ for ($i=0; $i < scalar(@components); $i++) {
die $@ if $@;
print STDERR <<EOF;
Fir... |
6525e67c01d303153272c26cb8118a3c314f4a1f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: ngene: Fix I2C initialisation | Problem Details:
Use I2C_CLASS_TV_DIGITAL, not I2C_ADAP_CLASS_TV_DIGITAL.
Remove initialisation of bus_lock mutex.
Thanks to Mauro for pointing out.
Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Thanks-to: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index 1b53482f6e7f..ea610e4b571d 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -847,11 +847,7 @@ static int ngene_i2c_init(struct ngene *dev, int dev_nr)
struct i2c_adapte... |
c58b5ecd46bf1b4a54b769d4a17afd97af23188d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: [nGene] Trivial I2C related fixes/cleanups | Problem Details:
Trivial I2C related fixes/cleanups
- Remove Unused I2C ID
- point the I2C device to the physical device
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Acked-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index 6f1b06618147..1c86edd908fd 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -828,9 +828,9 @@ static int ngene_i2c_init(struct ngene *dev, int dev_nr)
strcpy(adap->nam... |
dc35c9ae193564af2003117857848d69af24d534 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: ngene: Fix unloading of module | Problem Details:
Fixed unloading of module ngene.
Signed-off-by: Roland Praml <pram@gmx.de>
Signed-off-by: Matthias Benesch <twoof7@freenet.de>
Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index cf12bff57440..52798b7c8d96 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -2445,7 +2445,7 @@ static void release_channel(struct ngene_channel *chan)
#endif
if (chan... |
adc1d21eec74afbd38a9099f4aff4bcd5b9eaea2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: ngene: Remove firmware debugging | Problem Details:
Remove firmware debugging, because setting ngene_fw_debug and requesting
firmware from file causes a kernel error.
Signed-off-by: Matthias Benesch <twoof7@freenet.de>
Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index 0e0c01396ced..cf12bff57440 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -56,10 +56,6 @@ static int copy_eeprom;
module_param(copy_eeprom, int, 0444);
MODULE_PARM_DE... |
8bba2607f1927cf3166a64dfd4e4c38a2e3af990 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: ngene: Added Media-Pointer MP-S2/CineS2 DVB-S2 Twin Tuner | Problem Details:
Added support for nGene based Media-Pointer DVB-S2 twin tuner cards.
[mchehab@redhat.com: Fix compilation error: unknown field ‘ref_clk’]
Signed-off-by: Matthias Benesch <twoof7@freenet.de>
Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index eb47b86902f9..0e0c01396ced 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -44,6 +44,10 @@
#include "ngene.h"
+#include "stv6110x.h"
+#include "stv090x.h"
+#include... |
08c45cd58560f10e08e0ec4686845625b7030e8c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: drivers/media/dvb/frontends/stv090x.c: fix use-uninitlalised | Problem Details:
Mad guess.
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Manu Abraham <manu@linuxtv.org>
Acked-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index a11a2eb27f55..c52c3357dc54 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -2047,7 +2047,7 @@ static int stv090x_chk_tmg(struct stv090x_state *state)
u32 reg;
s3... |
690c79ae7a0d928459ee6a09be781a2503c27e3e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: drivers/media/dvb/frontends/stv090x.c: fix use-uninitialised | Problem Details:
drivers/media/dvb/frontends/stv090x.c: In function 'stv090x_blind_search':
drivers/media/dvb/frontends/stv090x.c:1967: warning: 'coarse_fail' may be used uninitialized in this function
Cc: Manu Abraham <manu@linuxtv.org>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Andrew Morton <akpm... | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index e1d4647b1a99..a11a2eb27f55 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -1964,7 +1964,8 @@ static int stv090x_blind_search(struct stv090x_state *state)
u32 agc2... |
c2312f60d741df833abf48fee4a30aa523e55a58 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: drivers/media/video/cx18/cx18-alsa-pcm.c: fix printk warning | Problem Details:
drivers/media/video/cx18/cx18-alsa-pcm.c: In function 'cx18_alsa_announce_pcm_data':
drivers/media/video/cx18/cx18-alsa-pcm.c:82: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'
Cc: Andy Walls <awalls@radix.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-... | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
index cfa512112ca0..2bd312daeb1e 100644
--- a/drivers/media/video/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
@@ -79,7 +79,7 @@ void cx18_alsa_announce_pcm_data(struct snd_cx18_card *cxsc, u8... |
ca39d84d438b609af127f2eb161cd9029afbc9a7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: em28xx: fix for "Leadtek winfast tv usbii deluxe" | Problem Details:
fix Video/Sound support "Leadtek winfast tv usbii deluxe".
Now, it is working Stereo, IR, Radio, TV, Svideo and Composite.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/IR/ir-keymaps.c b/drivers/media/IR/ir-keymaps.c
index 9bbe6b1e9871..71b3278f67e5 100644
--- a/drivers/media/IR/ir-keymaps.c
+++ b/drivers/media/IR/ir-keymaps.c
@@ -3393,3 +3393,51 @@ struct ir_scancode_table ir_codes_nec_terratec_cinergy_xs_table = {
};
EXPORT_SYMBOL_GPL(ir_codes_ne... |
3d36f5c652d9d1b4406b0f8f32d9452eaad8e33a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: m920x: Add support for Pinnacle PCTV310e card | Problem Details:
Adds support to Pinnacle PCTV310e hybrid tuner card, for DVB-T and
remote control, still no analog video.
[mchehab@redhat.com: fix CodingStyle issues]
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
index bc3581d58ced..90cdac7ccd87 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -209,6 +209,7 @@
#define USB_PID_PINNACLE_PCTV71E 0x022b
#define USB_PID_PINNA... |
0faf6f6b892aeb25934c9adc7fe328350d2d25cc | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cafe_ccic: Fix lock imbalances | Problem Details:
Fix lock imbalances in function device_authorization.
Signed-off-by: Alexander Strakh <strakh@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cafe_ccic.c b/drivers/media/video/cafe_ccic.c
index 7bb9c1ec7819..cbbf7e80d2cf 100644
--- a/drivers/media/video/cafe_ccic.c
+++ b/drivers/media/video/cafe_ccic.c
@@ -1907,7 +1907,6 @@ static int cafe_pci_probe(struct pci_dev *pdev,
goto out_free;
mutex_init(&cam->s_mutex)... |
b3b6dc620626eda13d7c1330cf3733862fe29420 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18: Increment driver version for the addition of cx18-alsa and fixes | Problem Details:
Signed-off-by: Andy Walls <awalls@radix.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx18/cx18-version.h b/drivers/media/video/cx18/cx18-version.h
index 9c0b5bb1b019..3e1aec4bcfde 100644
--- a/drivers/media/video/cx18/cx18-version.h
+++ b/drivers/media/video/cx18/cx18-version.h
@@ -24,7 +24,7 @@
#define CX18_DRIVER_NAME "cx18"
#define CX18_DRIVER_VERSION_MAJ... |
831f476cee704c37e7f96510135a90dfec6d00e9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18: Fix memory leak in cx18-alsa starting of PCM captures | Problem Details:
The cx18_open_id is normally dynamically allocated and stored in the
filp->private_data for v4l2 file operations. The cx18-alsa routines should
not dynamically allocate a cx18_open_id because they never store it anywhere
and never free it. This change fixes that and plugs a memory leak.
Signed-off-b... | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
index 06862a69c7b0..cfa512112ca0 100644
--- a/drivers/media/video/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
@@ -152,28 +152,20 @@ static int snd_cx18_pcm_capture_open(struct snd_pcm_substre... |
10e43d90da572f088f15cadfb5cc83cd762041c3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx25840: Fix composite detection | Problem Details:
If CX25840_VIN1_CH1 and the like is used, input is not detected as composite.
Their value is 0x800000XX and CX25840_COMPONENT_ON is 0x80000200. So
739 else if ((vid_input & CX25840_COMPONENT_ON) == 0)
this condition never be true.
Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
Reviewed... | ```diff
diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
index 796f12d59daa..f2461cd3de5a 100644
--- a/drivers/media/video/cx25840/cx25840-core.c
+++ b/drivers/media/video/cx25840/cx25840-core.c
@@ -734,10 +734,8 @@ static int set_input(struct i2c_client *client, enum... |
22c859faf5e10e7f7b04a2c643a98eeee69c1815 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: Fix VIDIOC_QBUF compat ioctl32 | Problem Details:
When using VIDIOC_QBUF with memory type set to V4L2_MEMORY_MMAP, the
v4l2_buffer buffer gets unmodified on drivers like uvc (well, only
bytesused field is modified). Then some apps like gstreamer are reusing
the same buffer later to call munmap (eg passing the buffer "length"
field as 2nd parameter of ... | ```diff
diff --git a/drivers/media/video/v4l2-compat-ioctl32.c b/drivers/media/video/v4l2-compat-ioctl32.c
index dc7b8c23eac0..f77f84bfe714 100644
--- a/drivers/media/video/v4l2-compat-ioctl32.c
+++ b/drivers/media/video/v4l2-compat-ioctl32.c
@@ -475,6 +475,9 @@ static int get_v4l2_buffer32(struct v4l2_buffer *kp, stru... |
3fb80ef3bc0f2b1008e14f695dcb32415cbacc90 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: firedtv: do not DMA-map stack addresses | Problem Details:
This is a portability fix and reduces stack usage.
The DMA mapping API cannot map on-stack addresses, as explained in
Documentation/DMA-mapping.txt. Convert the two cases of on-stack packet
payload buffers in firedtv (payload of write requests in avc_write and
of lock requests in cmp_lock) to slab-al... | ```diff
diff --git a/drivers/media/dvb/firewire/firedtv-1394.c b/drivers/media/dvb/firewire/firedtv-1394.c
index 81a56293540d..c3e0ec2dcfca 100644
--- a/drivers/media/dvb/firewire/firedtv-1394.c
+++ b/drivers/media/dvb/firewire/firedtv-1394.c
@@ -90,13 +90,14 @@ static inline struct node_entry *node_of(struct firedtv *... |
9420048c6e3ce43b428cb5965ba0d568bc145978 | Analyze and fix the following issue in the Linux kernel code: Fix the __init/__exit annotations | Problem Details:
WARNING: drivers/media/video/cx18/cx18-alsa.o(.text+0x4de): Section
mismatch in reference from the function cx18_alsa_load() to the function
.init.text:snd_cx18_init()
The function cx18_alsa_load() references
the function __init snd_cx18_init().
This is often because cx18_alsa_load lacks a __init
annot... | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-main.c b/drivers/media/video/cx18/cx18-alsa-main.c
index 9efabf5e260f..eb41d7ec65b9 100644
--- a/drivers/media/video/cx18/cx18-alsa-main.c
+++ b/drivers/media/video/cx18/cx18-alsa-main.c
@@ -94,7 +94,7 @@ static void snd_cx18_card_private_free(struct snd_card *sc)... |
583d338ddda291e3244c7f3a785973c51dcce84e | Analyze and fix the following issue in the Linux kernel code: cx18: Fix compilation when CONFIG_MODULE is disabled | Problem Details:
drivers/media/video/cx18/cx18-driver.c:252: warning: ‘request_modules’ used but never defined
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c
index cbd4f85da76b..c95a86ba33b0 100644
--- a/drivers/media/video/cx18/cx18-driver.c
+++ b/drivers/media/video/cx18/cx18-driver.c
@@ -248,8 +248,27 @@ MODULE_LICENSE("GPL");
MODULE_VERSION(CX18_VERSION);
-/* Forwar... |
914e8713f22fc01da14670c1647603edcb7c7b0a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca - sq905c: Fix a compilation warning | Problem Details:
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/sq905c.c b/drivers/media/video/gspca/sq905c.c
index bbfaf8361f65..6c7d271fc916 100644
--- a/drivers/media/video/gspca/sq905c.c
+++ b/drivers/media/video/gspca/sq905c.c
@@ -204,7 +204,7 @@ static int sd_config(struct gspca_dev *gspca_dev,
{
struct cam *cam = &gspca_dev->... |
11edebc264f14d3f9e05525f238b91da7f5fa81f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: gspca - ov534: Fix end of frame handling | Problem Details:
Fix a regression, introduced in the driver split, which made
the ov534 driver unusable.
Plus, the debug message should reflect that we discard also packets
beyond the expected frame size.
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Sign... | ```diff
diff --git a/drivers/media/video/gspca/ov534.c b/drivers/media/video/gspca/ov534.c
index c02784bbe95a..957e05e2d08f 100644
--- a/drivers/media/video/gspca/ov534.c
+++ b/drivers/media/video/gspca/ov534.c
@@ -992,9 +992,9 @@ static void sd_pkt_scan(struct gspca_dev *gspca_dev,
frame = gspca_get_i_frame(gspca_... |
b9fb9b791a05e52b6daba953637705fa30610ab3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: bt819: cleanup v4l2_subdev_notify() parameters | Problem Details:
The 3rd parameter v4l2_subdev_notify() is passed to the notify() callback
which is a pointer, see <media/v4l2-subdev.h> and <media/v4l2-device.h>.
This will remove the following sparse warning (see "make C=1"):
* Using plain integer as NULL pointer
Signed-off-by: Márton Németh <nm127@freemail.hu>
Si... | ```diff
diff --git a/drivers/media/video/bt819.c b/drivers/media/video/bt819.c
index 5bb0f9e71583..547e1a93c421 100644
--- a/drivers/media/video/bt819.c
+++ b/drivers/media/video/bt819.c
@@ -254,7 +254,7 @@ static int bt819_s_std(struct v4l2_subdev *sd, v4l2_std_id std)
v4l2_err(sd, "no notify found!\n");
if (st... |
cebedf15d2776e1629a86260b5aa7bcfff8401b2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: zoran: cleanup pointer condition | Problem Details:
Remove the following sparse warning (see "make C=1"):
* warning: Using plain integer as NULL pointer
Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c
index 2ddffed019ee..0d1e8710a322 100644
--- a/drivers/media/video/zoran/zoran_driver.c
+++ b/drivers/media/video/zoran/zoran_driver.c
@@ -324,7 +324,7 @@ static int jpg_fbuffer_alloc(struct zoran_fh *fh)
/* Alloc... |
986ce4510b37ba684aaebd3eb0e6ee0c03906ed8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: s2250: Fix write_reg i2c address | Problem Details:
The kernel i2c model uses right-aligned 7-bit i2c addresses, but the
2250 firmware uses an 8-bit address in the usb vendor request. A
previous patch by Jean Delvare shifted the i2c addresses 1 bit to the
right, and this patch fixes the write_reg function to shift it back
before sending the vendor requ... | ```diff
diff --git a/drivers/staging/go7007/s2250-board.c b/drivers/staging/go7007/s2250-board.c
index 8cf7f2750b3f..c324f6ea002b 100644
--- a/drivers/staging/go7007/s2250-board.c
+++ b/drivers/staging/go7007/s2250-board.c
@@ -159,7 +159,7 @@ static int write_reg(struct i2c_client *client, u8 reg, u8 value)
struct go... |
94b12d9ea555851632deee1c2b06c4f281a45e12 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18-alsa: Fix the rates definition and move some buffer freeing code. | Problem Details:
Clarify the rates available for the device, and move the freeing of the buffer
to the free routine instead of the close (per Takashi's suggestion).
Thanks to Takashi Iwai for reviewing and providing feedback.
This work was sponsored by ONELAN Limited.
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: ... | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
index e613826d5a47..6e56df94e34b 100644
--- a/drivers/media/video/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
@@ -55,7 +55,7 @@ static struct snd_pcm_hardware snd_cx18_hw_capture = {
.for... |
71036ef26b0026742c8ab79a54937aac1439350d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18-alsa: codingstyle cleanup | Problem Details:
Remove some dead code and make a PCM specific module debug parameter to avoid
an extern reference.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
index 371dfb8d8756..2d25c6f92d5d 100644
--- a/drivers/media/video/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
@@ -37,11 +37,13 @@
#include "cx18-fileops.h"
#include "cx18-alsa.h"
-extern ... |
f8bd9d26c59d0df0335bf43191feb732f2c8b6ad | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18: codingstyle fixes | Problem Details:
Codingstyle fixes, some introduced as a result of the ALSA work, some
pre-existing. This patch is a whitespace change only.
This work was sponsored by ONELAN Limited.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c
index 870c43e6e2f9..cbd4f85da76b 100644
--- a/drivers/media/video/cx18/cx18-driver.c
+++ b/drivers/media/video/cx18/cx18-driver.c
@@ -238,7 +238,8 @@ MODULE_PARM_DESC(enc_pcm_bufs,
"Number of encoder PCM buffers\n"
... |
780edb7ad60e5c657770f510747cc609c84b5b61 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18-alsa: codingstyle fixes | Problem Details:
Fix codingstyle issues, and make the minimum version for cx18-alsa required
to be 2.6.17, so that we don't need all the #ifdefs related to the changes
to ALSA structures.
This work was sponsored by ONELAN Limited.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Car... | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
index e14f8e42a2ab..371dfb8d8756 100644
--- a/drivers/media/video/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
@@ -85,9 +85,9 @@ static int snd_cx18_pcm_capture_open(struct snd_pcm_substream *... |
4dae2f0f84374d4e7cd6c8d41385a7c250f0726d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18-alsa: fix codingstyle issue | Problem Details:
Address coding style issue with cx18-alsa-main.c
This work was sponsored by ONELAN Limited.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-mixer.c b/drivers/media/video/cx18/cx18-alsa-mixer.c
index b80391a8a9fc..4251a72f11a8 100644
--- a/drivers/media/video/cx18/cx18-alsa-mixer.c
+++ b/drivers/media/video/cx18/cx18-alsa-mixer.c
@@ -92,7 +92,7 @@ static int snd_cx18_mixer_tv_vol_info(struct snd_kcontr... |
1a8e0e33881c9dd8cf3514bfd0b5a7ef148da929 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18-alsa: fix memory leak in error condition | Problem Details:
If the stream is already in use, make sure we free up the memory allocated
earlier.
Thanks to Andy Wall for reviewing and pointing this out.
This work was sponsored by ONELAN Limited.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.... | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
index 05cb8f1753b5..e14f8e42a2ab 100644
--- a/drivers/media/video/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
@@ -95,6 +95,7 @@ static int snd_cx18_pcm_capture_open(struct snd_pcm_substream *... |
1ec1c9bc6fc63b08467c12ce585862ae4e97859c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18: cleanup cx18-alsa debug logging | Problem Details:
Fix the debug macro so that it is dependent on the modprobe parameter.
This work was sponsored by ONELAN Limited.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-main.c b/drivers/media/video/cx18/cx18-alsa-main.c
index 6433ff0ad859..9b652a1649c8 100644
--- a/drivers/media/video/cx18/cx18-alsa-main.c
+++ b/drivers/media/video/cx18/cx18-alsa-main.c
@@ -41,7 +41,11 @@
int cx18_alsa_debug;
-#define CX18_DEBUG_ALSA_INFO(fm... |
4a8cfe6a5c158133f57c2e8476f259366d4bdc4d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18-alsa: remove unneeded debug line | Problem Details:
Remove an unneeded debug line, which was preventing the cx18-alsa module from
loading.
This work was sponsored by ONELAN Limited.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c
index a6502af0771e..366194068e92 100644
--- a/drivers/media/video/cx18/cx18-alsa-pcm.c
+++ b/drivers/media/video/cx18/cx18-alsa-pcm.c
@@ -87,7 +87,6 @@ static int snd_cx18_pcm_capture_open(struct snd_pcm_substream *... |
4cb565cc2700e6fcd57243cacc4c2826956bc088 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx18: make it so cx18-alsa-main.c compiles | Problem Details:
Fix some basic compilation issues with Andy's original code. In particular,
temporarily #ifdef out the mixer code, add some additional exception handling,
fix a couple of typos, and add a copyright line.
This work was sponsored by ONELAN Limited.
Signed-off-by: Devin Heitmueller <dheitmueller@kernel... | ```diff
diff --git a/drivers/media/video/cx18/cx18-alsa-main.c b/drivers/media/video/cx18/cx18-alsa-main.c
index dde2b0482f34..3c339774522a 100644
--- a/drivers/media/video/cx18/cx18-alsa-main.c
+++ b/drivers/media/video/cx18/cx18-alsa-main.c
@@ -2,6 +2,9 @@
* ALSA interface to cx18 PCM capture streams
*
* Copy... |
3ccc646b56a3f03029a259c6a8affd9cecc6020e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: cx25840, v4l2-subdev, ivtv, pvrusb2: Fix ivtv/cx25840 tinny audio | Problem Details:
This change attempts to fix the ivtv tinny audio problem by keeping digitizer
to encoder audio clocks running, while disabling the video clocks as needed to
avoid unpredictable PCI bus hangs.
To accomplish this, for the cx25840 module enabling of audio streaming had
to be separated from enabling video... | ```diff
diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
index 385ecd58f1c0..796f12d59daa 100644
--- a/drivers/media/video/cx25840/cx25840-core.c
+++ b/drivers/media/video/cx25840/cx25840-core.c
@@ -1347,30 +1347,59 @@ static int cx25840_s_register(struct v4l2_subdev ... |
b6e436b263b35476da4be06e0719cb1d5c8f8eed | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: ivtv: Fix race condition for queued udma transfers | Problem Details:
There are several DMA related interrupts which wake up the dma_waitq. The udma
routines use this queue while they wait for their transfer to complete. When
woken, the udma routine will check the IVTV_F_I_UDMA_PENDING & IVTV_F_I_UDMA
flags to see if the transfer is still queued or has finished. However,... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-irq.c b/drivers/media/video/ivtv/ivtv-irq.c
index cd9db0bf33bf..ee0cdded69f7 100644
--- a/drivers/media/video/ivtv/ivtv-irq.c
+++ b/drivers/media/video/ivtv/ivtv-irq.c
@@ -940,9 +940,10 @@ irqreturn_t ivtv_irq_handler(int irq, void *dev_id)
ivtv_dma_enc_start(s);
... |
0726681a7080cef6a9fd414894690fac16418772 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: 22-kHz set_tone fix for NetUP Dual DVB-S2-CI card. 22kHz logic controlled by demod | Problem Details:
22-kHz tone can be driven in two ways:
1. LNBH24 can produce 22kHz continuous tone when TEN=1 ( 22 KHz tone output is
always activated ).
2. LNBH24 can reproduce 22kHz tone timings from DSQIN or EXTM pin's when TEN=0.
From LNBH24 datasheet:
"In order to improve design flexibility an external tone input... | ```diff
diff --git a/drivers/media/dvb/frontends/lnbp21.c b/drivers/media/dvb/frontends/lnbp21.c
index 49d2b1c16119..13437259eeac 100644
--- a/drivers/media/dvb/frontends/lnbp21.c
+++ b/drivers/media/dvb/frontends/lnbp21.c
@@ -158,7 +158,7 @@ static struct dvb_frontend *lnbx2x_attach(struct dvb_frontend *fe,
/* overr... |
b10af3f70bfaf98b6405dcd0561283b7ec485630 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (14001): gscpa_sonixb: Differentiate between tas5110c and tas5110d and fix d hstart | Problem Details:
Our hstart value was wrong for tas5110d sensor using sonixb cams, this
patch fixes this. Many thanks to Paulus (laudaka) for donating me a camera
with such a sensor IC.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/sonixb.c b/drivers/media/video/gspca/sonixb.c
index 725a1230c8da..cfefdfefaf62 100644
--- a/drivers/media/video/gspca/sonixb.c
+++ b/drivers/media/video/gspca/sonixb.c
@@ -73,8 +73,9 @@ struct sd {
#define SENSOR_OV7630 2
#define SENSOR_PAS106 3
#define SENSOR_PAS202 4
... |
035d3a3d3fb0104bb94dfb78ef70c7ec6f3f4ae4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (13998): gscpa_ov519: Fix 320x240 on ov519 + ov7648 | Problem Details:
Differentiate between ov7640 and ov7648 and handle the ov7648 320x240
on the ov519 bridge specially to fix r and b being swapped.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/ov519.c b/drivers/media/video/gspca/ov519.c
index a607622b7348..abd200a947db 100644
--- a/drivers/media/video/gspca/ov519.c
+++ b/drivers/media/video/gspca/ov519.c
@@ -101,9 +101,10 @@ struct sd {
#define SEN_OV7620 7
#define SEN_OV7620AE 8
#define SEN_OV7640 9
-#define... |
859cc4700eebebe346572eb30898dd786a54e7a9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (13997): gspca_ov519: differentiate ov7620 and ov7620ae and fix 640x480 on the 7620 | Problem Details:
Michael Deegan <michael@ucc.gu.uwa.edu.au>, has reported issues with
using 640x480 mode on his ov518+ webcam. The fix for this breaks things
on my ov518+ cam (Trust 320 Sp@cecam), this patch thus adds differentiation
in the driver between the OV7620 sensor his cam has and the OV7620AE sensor
my cam has... | ```diff
diff --git a/drivers/media/video/gspca/ov519.c b/drivers/media/video/gspca/ov519.c
index 8c3909663a4c..a607622b7348 100644
--- a/drivers/media/video/gspca/ov519.c
+++ b/drivers/media/video/gspca/ov519.c
@@ -99,10 +99,11 @@ struct sd {
#define SEN_OV66308AF 5
#define SEN_OV7610 6
#define SEN_OV7620 7
-#define... |
388a6d54168923d0243d4c752586e87231a75291 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (13996): gspca_stv0680: Fix streaming on vga cameras | Problem Details:
Streaming of VGA stv0680 based cams (instead of CIF ones) failed, because
we were using the wrong control pipe for certain commands, this patch fixes
this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/stv0680.c b/drivers/media/video/gspca/stv0680.c
index 7312bf43113b..e50dd7693f74 100644
--- a/drivers/media/video/gspca/stv0680.c
+++ b/drivers/media/video/gspca/stv0680.c
@@ -53,24 +53,28 @@ static int stv_sndctrl(struct gspca_dev *gspca_dev, int set, u8 req, u16 val,
{
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.