id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
7765e89d2048fb96d91e8ad06908e87319e4aac4 | Analyze and fix the following issue in the Linux kernel code: Staging: rt28x0: fix BPP_R66 register handling | Problem Details:
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/common/cmm_data.c b/drivers/staging/rt2860/common/cmm_data.c
index 9b8337d76292..590a38dcb3ec 100644
--- a/drivers/staging/rt2860/common/cmm_data.c
+++ b/drivers/staging/rt2860/common/cmm_data.c
@@ -2077,7 +2077,6 @@ VOID RTMPResumeMsduTransmission(
{
DBGPRINT(RT_DEBUG_TRA... |
74eaa42b5c2808b37f15a2911cfeb7544790ee93 | Analyze and fix the following issue in the Linux kernel code: Staging: rt28x0: fix GTK length check in ParseKeyData() | Problem Details:
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/sta/wpa.c b/drivers/staging/rt2860/sta/wpa.c
index b8410a2692a6..8c34e39f3860 100644
--- a/drivers/staging/rt2860/sta/wpa.c
+++ b/drivers/staging/rt2860/sta/wpa.c
@@ -1764,12 +1764,7 @@ BOOLEAN ParseKeyData(
// Get GTK length - refer to IEEE 802.11i-2004 p.82
GTKLEN = pKD... |
9a5e59add33d0962544703ed4964d2835892e21a | Analyze and fix the following issue in the Linux kernel code: Staging: rt3070: AsicSetSlotTime() fix | Problem Details:
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/common/mlme.c b/drivers/staging/rt2860/common/mlme.c
index 16192117776b..53840f7e7799 100644
--- a/drivers/staging/rt2860/common/mlme.c
+++ b/drivers/staging/rt2860/common/mlme.c
@@ -7096,7 +7096,6 @@ VOID AsicSetSlotTime(
SlotTime = (bUseShortSlotTime)? 9 : 20;
{
-#if... |
3cf830a1dbd3ad5da682b9f6f338428f97500432 | Analyze and fix the following issue in the Linux kernel code: Staging: rt3070: WEP fixes | Problem Details:
Propagate WEP fixes from rt28[67]0 to rt3070.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/common/cmm_wpa.c b/drivers/staging/rt2860/common/cmm_wpa.c
index 43e68a2fa60a..2de29fde2c40 100644
--- a/drivers/staging/rt2860/common/cmm_wpa.c
+++ b/drivers/staging/rt2860/common/cmm_wpa.c
@@ -39,14 +39,10 @@
// WPA OUI
UCHAR OUI_WPA_NONE_AKM[4] = {0x00, 0x50, 0xF2, 0x0... |
a149b51d2d2a2913e30e8697e4cc65a20719c695 | Analyze and fix the following issue in the Linux kernel code: Staging: rt3070: fix PID checking in RTUSBEnqueueCmdFromNdis() | Problem Details:
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2870/common/rtusb_io.c b/drivers/staging/rt2870/common/rtusb_io.c
index ef545af2af93..30c032d614ec 100644
--- a/drivers/staging/rt2870/common/rtusb_io.c
+++ b/drivers/staging/rt2870/common/rtusb_io.c
@@ -982,12 +982,7 @@ NDIS_STATUS RTUSBEnqueueCmdFromNdis(
PCmdQElmt cmdqelmt = ... |
2ac6ff20265b2503cb1b172ac6e4e362676aaead | Analyze and fix the following issue in the Linux kernel code: Staging: rtxxxx: RTMPGetRalinkAuthModeStr() fixes | Problem Details:
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/common/cmm_info.c b/drivers/staging/rt2860/common/cmm_info.c
index 306c3a21f905..9f3263369edd 100644
--- a/drivers/staging/rt2860/common/cmm_info.c
+++ b/drivers/staging/rt2860/common/cmm_info.c
@@ -2725,9 +2725,6 @@ PCHAR RTMPGetRalinkAuthModeStr(
{
case Ndis802_11Aut... |
e96e946c6f3a3c58048b277b8bc50d30dc8ee6a2 | Analyze and fix the following issue in the Linux kernel code: Staging: rtxxx0: debug messages fixes | Problem Details:
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/common/ba_action.c b/drivers/staging/rt2860/common/ba_action.c
index 872349a9cc6a..79a51640f6bc 100644
--- a/drivers/staging/rt2860/common/ba_action.c
+++ b/drivers/staging/rt2860/common/ba_action.c
@@ -531,12 +531,10 @@ VOID BAOriSessionSetUp(
pBAEntry->TimeOutValue = Time... |
382280ae9d0f94a7ffed1f8963be16b96348684c | Analyze and fix the following issue in the Linux kernel code: Staging: rtxxx0: PID checking fixes | Problem Details:
* rt3070:
- add missing pid_nr() invocations
* rt{28,30}70:
- do not treat PID 0 as valid
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/rt_linux.h b/drivers/staging/rt2860/rt_linux.h
index dbe6fb75d6cb..37b63e24e734 100644
--- a/drivers/staging/rt2860/rt_linux.h
+++ b/drivers/staging/rt2860/rt_linux.h
@@ -163,7 +163,7 @@ typedef struct pid * THREAD_PID;
#define THREAD_PID_INIT_VALUE NULL
#define GET_PID(_v)... |
0b2e3aefc34d3d5824e687529c6992521765614d | Analyze and fix the following issue in the Linux kernel code: Staging: rt3070: fix build warnings | Problem Details:
In file included from drivers/staging/rt3070/common/../../rt2870/common/cmm_data.c:2,
from drivers/staging/rt3070/common/cmm_data.c:2:
drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/cmm_data.c: In function ‘RTMP_FillTxBlkInfo’:
drivers/staging/rt3070/common/../..... | ```diff
diff --git a/drivers/staging/rt2860/common/cmm_data.c b/drivers/staging/rt2860/common/cmm_data.c
index 66eca202eae4..2936ca38e44d 100644
--- a/drivers/staging/rt2860/common/cmm_data.c
+++ b/drivers/staging/rt2860/common/cmm_data.c
@@ -1013,11 +1013,6 @@ BOOLEAN RTMP_FillTxBlkInfo(
}
return TRUE;
-
-#ifdef... |
f0da335bdc9bb9410889b4196a9ce9d7173f8c9c | Analyze and fix the following issue in the Linux kernel code: Staging: rt2870: duplicated code is executed twice in AsicEvaluateRxAnt() | Problem Details:
Fix it.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/common/mlme.c b/drivers/staging/rt2860/common/mlme.c
index bb6fccbdca41..e93462a705a7 100644
--- a/drivers/staging/rt2860/common/mlme.c
+++ b/drivers/staging/rt2860/common/mlme.c
@@ -8433,26 +8433,6 @@ VOID AsicEvaluateRxAnt(
#ifdef RT2860
pAd->StaCfg.BBPR3 = BBPR3;
#... |
7c3ab53c467acf23fd4e8265f3b867461f0bebe4 | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: includecheck fix: rt_linux.h | Problem Details:
fix the following 'make includecheck' warning:
drivers/staging/rt2860/rt_linux.h: linux/wireless.h is included more than once.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/rt_linux.h b/drivers/staging/rt2860/rt_linux.h
index b434824d932c..ccf58b26b4b7 100644
--- a/drivers/staging/rt2860/rt_linux.h
+++ b/drivers/staging/rt2860/rt_linux.h
@@ -63,10 +63,6 @@
#include <linux/ctype.h>
#include <linux/vmalloc.h>
-
-#ifdef RT30xx
-#include <linux/... |
b3184e1ec36a94602d54339699df6e1036cd71f8 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8187se: Fix comment-out-typo | Problem Details:
This fixes a comment-out-typo that resulted in a dangling if-branch.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 89311efdf624..53e654d0d4fa 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -2246,7 +2246,7 @@ short rtl8180_tx(struct net_device *dev, u8* txbuf, int len, int pr... |
f357e6ecbc4696d11539df3fd604c8da59c1e6d1 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8192su: fixup size comparison warning | Problem Details:
sizeof(val) returns type unsigned long. count is already unsigned long, so
just use that. This fixes a compile warning.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8192su/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192su/ieee80211/ieee80211_module.c
index 510e71e6bfe0..68dc8fa094cc 100644
--- a/drivers/staging/rtl8192su/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192su/ieee80211/ieee80211_module.c
@@ -264,7 +264,7 @@ stati... |
859ebd9748fb086a272bebe6cce4d8e6461dd7fc | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8192su: fix up printk warnings | Problem Details:
This patch addresses printk warnings.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c
index 145a3120c6bb..107759024335 100644
--- a/drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c
+++ b/drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c
@@ -772,7 +772,7 @@ int ieee80211_wx_set_... |
b1af19f19d43567ddc956ed37b710cba0c8b1f95 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8192su: compile fixes | Problem Details:
This patch removes -fhard-float and the software float helpers. In-kernel
floating point is not allowed.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8192su/Makefile b/drivers/staging/rtl8192su/Makefile
index 52dc09baf4f8..c8b4332d108c 100644
--- a/drivers/staging/rtl8192su/Makefile
+++ b/drivers/staging/rtl8192su/Makefile
@@ -2,7 +2,6 @@ NIC_SELECT = RTL8192SU
EXTRA_CFLAGS += -std=gnu89
EXTRA_CFLAGS += -O2
-EXTRA_CFLAGS +... |
49bb9e6d75346980acdc43f5198032c2a0a22c2c | Analyze and fix the following issue in the Linux kernel code: Staging: echo: fix up remaining checkpatch.pl issues | Problem Details:
It's all just minor comment spacing issues. This patch fixes
up the remaining ones and now the code is checkpatch.pl clean.
Cc: Steve Underwood <steveu@coppice.org>
Cc: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/echo/TODO b/drivers/staging/echo/TODO
index f6d8580a0baa..18f7b4a78343 100644
--- a/drivers/staging/echo/TODO
+++ b/drivers/staging/echo/TODO
@@ -1,5 +1,4 @@
TODO:
- - checkpatch.pl cleanups
- handle bit_operations.h (merge in or make part of common code?)
- remove proc interfa... |
2e7dcc3bbffb0b87f64369b3dab3ac8993d446b3 | Analyze and fix the following issue in the Linux kernel code: Staging: sep: clean up command sending | Problem Details:
Split out the debug dumping functionality. Clean up the rest. For the moment
leave the hideous cache flush in there as the code needs fixing to use
the dma_map_sg interfaces not its own crazed table functions
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse... | ```diff
diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
index 23514f9d3230..1fdf742046ee 100644
--- a/drivers/staging/sep/sep_driver.c
+++ b/drivers/staging/sep/sep_driver.c
@@ -461,7 +461,8 @@ static unsigned int sep_poll(struct file *filp, poll_table * wait)
}
/*
- calculates tim... |
6f9e0f60c46d597ee924dd073628ca2424f4178c | Analyze and fix the following issue in the Linux kernel code: Staging: sep: flow ioctl cleanup | Problem Details:
Simple ioctl taking a single numeric argument so ditch the structs and
weirdness. While we are it lock it properly and fix the error returns.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
index 73f20c4bee94..23514f9d3230 100644
--- a/drivers/staging/sep/sep_driver.c
+++ b/drivers/staging/sep/sep_driver.c
@@ -2167,39 +2167,32 @@ static int sep_end_transaction_handler(struct sep_device *sep, unsigned long arg
}
-... |
6f13ea3df5de2af5c50e15218553c2434e455be9 | Analyze and fix the following issue in the Linux kernel code: Staging: sep: tidy firmware load | Problem Details:
Start by removing unused fields and then work this back to eliminate unused
chunks of the firmware loading ioctl (ie almost all of it)
Also fix the wrong handling of shared allocations and allocate the rar
region properly with dma_alloc_coherent not kmalloc, as it is device shared.
Signed-off-by: Ala... | ```diff
diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
index fd33945db6c8..f0dc715cbcb6 100644
--- a/drivers/staging/sep/sep_dev.h
+++ b/drivers/staging/sep/sep_dev.h
@@ -54,7 +54,7 @@ struct sep_device {
unsigned long resident_size;
void *resident_addr;
- unsigned long rar_region_addr... |
c7b7556245f3d0e825bf5c73dd9380b6b26737c5 | Analyze and fix the following issue in the Linux kernel code: Staging: sep: fix a conversion thinko | Problem Details:
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
index 531814bdbb09..0302c3c93c1a 100644
--- a/drivers/staging/sep/sep_driver.c
+++ b/drivers/staging/sep/sep_driver.c
@@ -277,7 +277,7 @@ static int sep_map_and_alloc_shared_area(struct sep_device *sep,
unsigned long size)
... |
3cacf72922067271ee2ad4debc398a53aeaf8a41 | Analyze and fix the following issue in the Linux kernel code: Staging: sep: fix flow API | Problem Details:
We can return NULL - much cleaner
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
index e8c36ea53eef..6a4681742ce2 100644
--- a/drivers/staging/sep/sep_driver.c
+++ b/drivers/staging/sep/sep_driver.c
@@ -1751,36 +1751,29 @@ static void sep_deallocated_flow_tables(struct sep_lli_entry_t *first_table_ptr)
return... |
6343cefdc8174f2d00abf8201ecd17d354e5ddf7 | Analyze and fix the following issue in the Linux kernel code: Staging: sep: Fix PCI irq usage | Problem Details:
Don't read the IRQ from the device, the device has no idea what is going on
in the full bus topology and remapping above PCI. Use the pdev->irq field.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
index 27248eb956a9..48286639e6c9 100644
--- a/drivers/staging/sep/sep_dev.h
+++ b/drivers/staging/sep/sep_dev.h
@@ -54,9 +54,6 @@ struct sep_device {
unsigned long resident_size;
void *resident_addr;
- /* device interrupt (as retri... |
577092ac155005ecb3a1385d628ef27fc9b52b72 | Analyze and fix the following issue in the Linux kernel code: Staging: sep: use O_NDELAY instead of magic APIs | Problem Details:
Open is still completely bogus in this driver but we'll tackle that later -
for now fix the bogus API
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
index b190373fa182..920e23a5142c 100644
--- a/drivers/staging/sep/sep_dev.h
+++ b/drivers/staging/sep/sep_dev.h
@@ -86,9 +86,6 @@ struct sep_device {
/* global data for every flow */
struct sep_flow_context_t flows_data_array[SEP_DRI... |
7913c21a25a9d54b093bed3522d35b188aadf6a4 | Analyze and fix the following issue in the Linux kernel code: Staging: sep: fix time handler | Problem Details:
Cleaning up the code reveals an obvious thinko
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
index fe46c1b46472..c2d9cab85d42 100644
--- a/drivers/staging/sep/sep_driver.c
+++ b/drivers/staging/sep/sep_driver.c
@@ -2143,7 +2143,9 @@ static int sep_get_time_handler(unsigned long arg)
struct sep_driver_get_time_t command_a... |
9dd3bd42162123553b62d44c02582f735fa25763 | Analyze and fix the following issue in the Linux kernel code: Staging: sep: Fix rar build | Problem Details:
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sep/Kconfig b/drivers/staging/sep/Kconfig
index 1a4514d3a7ac..6ef59f8d242e 100644
--- a/drivers/staging/sep/Kconfig
+++ b/drivers/staging/sep/Kconfig
@@ -1,6 +1,7 @@
config DX_SEP
tristate "Discretix SEP driver"
- depends on MRST
+# depends on MRST
+ depends on RAR_REGISTER
def... |
137cf5b22f5fd38751265eae881749c311d27c75 | Analyze and fix the following issue in the Linux kernel code: Staging: rar: fix some initial type problems | Problem Details:
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rar/rar_driver.c b/drivers/staging/rar/rar_driver.c
index 8c4463e2f620..0428bce5d213 100644
--- a/drivers/staging/rar/rar_driver.c
+++ b/drivers/staging/rar/rar_driver.c
@@ -74,7 +74,7 @@ static void __exit rar_exit_handler(void);
/*
function that is activated on the succesfull ... |
51a569f757f233bcffbffcdfeeff510916991a55 | Analyze and fix the following issue in the Linux kernel code: Staging: vme: fix {master,slave}_get check bug | Problem Details:
It's checking the wrong functions; fix it.
Signed-off-by: Emilio G. Cota <cota@braap.org>
Acked-by: Martyn Welch <martyn.welch@gefanuc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
index d6ad12e3cb54..7b442b99fa34 100644
--- a/drivers/staging/vme/vme.c
+++ b/drivers/staging/vme/vme.c
@@ -338,7 +338,7 @@ int vme_slave_get (struct vme_resource *resource, int *enabled,
image = list_entry(resource->entry, struct vme_slave_... |
03cd7136d68b4877a9e1793d31cab38fdcb67434 | Analyze and fix the following issue in the Linux kernel code: Staging: vt6655: fix possible Read buffer overflow | Problem Details:
If pDevice->sOpts.nRxDescs{0,1} or nTxDescs[{0,1}] is zero, the loop ends with
i == 0, and we write aRD{0,1}Ring[-1]. apTD{0,1}Rings[-1] respectively.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 449e47a839d9..53450b48eaa6 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1400,7 +1400,8 @@ static void device_init_rd0_ring(PSDevice pDevice) {
pDesc->next_d... |
d899d403862863cf2230432e18e7b294a517fd96 | Analyze and fix the following issue in the Linux kernel code: Staging: vt665x: 64bit compile fixes Part 2 | Problem Details:
Fix compile problems with 64bit. These issues could cause corrupted
address crashes. Cleanup definition use to use more portable kernel
typedefs etc.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c
index 58348cf10d06..3b8e38d7907f 100644
--- a/drivers/staging/vt6656/bssdb.c
+++ b/drivers/staging/vt6656/bssdb.c
@@ -1300,7 +1300,7 @@ if((pMgmt->eCurrState!=WMAC_STATE_ASSOC) &&
wpahdr->req_ie_len = 0;
skb... |
db6cb9036b2756c50efc43127c476786ea92eae2 | Analyze and fix the following issue in the Linux kernel code: Staging: vt665x: 64bit compile fixes Part 1 | Problem Details:
Fix compile problems with 64bit. These issues could cause corrupted
address crashes. In the process, replaced some definitions to use more
portable kernel types.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/vt6655/IEEE11h.c b/drivers/staging/vt6655/IEEE11h.c
index 5f25b8e88bd9..b0f4eb5af891 100644
--- a/drivers/staging/vt6655/IEEE11h.c
+++ b/drivers/staging/vt6655/IEEE11h.c
@@ -120,13 +120,13 @@ typedef struct _WLAN_FRAME_TPCREP {
/*--------------------- Static Functions -----------... |
6f92a8d0b863619227a5865e58ca38f9a759a9a1 | Analyze and fix the following issue in the Linux kernel code: Staging: otus: includecheck fix: drivers/staging/otus/usbdrv.h | Problem Details:
fix the following 'make includecheck' warning:
drivers/staging/otus/usbdrv.h: linux/usb.h is included more than once.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/otus/usbdrv.h b/drivers/staging/otus/usbdrv.h
index a11b3b36a906..78004062caba 100644
--- a/drivers/staging/otus/usbdrv.h
+++ b/drivers/staging/otus/usbdrv.h
@@ -61,10 +61,6 @@
#define USB_REG_IN_PIPE 3
#define USB_REG_OUT_PIPE 4
-#if (WLAN... |
2386b331802b1b2664c35f9f4c7aef778aac725f | Analyze and fix the following issue in the Linux kernel code: Staging: serqt_usb2: fix qt_open parameters | Problem Details:
The parameter list for qt_open() was from the old non usb-serial
driver.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
index 0fdf8c6dc648..52af44cfbe83 100644
--- a/drivers/staging/serqt_usb2/serqt_usb2.c
+++ b/drivers/staging/serqt_usb2/serqt_usb2.c
@@ -874,7 +874,7 @@ static void qt_release(struct usb_serial *serial)
}
static in... |
f66abce70504514b1173e4fc9973126b99f65d89 | Analyze and fix the following issue in the Linux kernel code: Staging: udlfb: fix printk format warning | Problem Details:
Fix printk format warning: use %td for ptrdiff:
drivers/staging/udlfb/udlfb.h:209: warning: format '%d' expects type 'int', but argument 3 has type 'long int'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartm... | ```diff
diff --git a/drivers/staging/udlfb/udlfb.h b/drivers/staging/udlfb/udlfb.h
index 08bd671204b2..40ad85ea8e67 100644
--- a/drivers/staging/udlfb/udlfb.h
+++ b/drivers/staging/udlfb/udlfb.h
@@ -205,7 +205,7 @@ static int dlfb_set_video_mode(struct dlfb_data *dev_info, int width, int height
/* send */
ret... |
658ce9d653056a537df70e3a796654446fc9ff64 | Analyze and fix the following issue in the Linux kernel code: Staging: fix typos "man[ae]g?ment" -> "management" | Problem Details:
This patch was generated by running
git grep -E -l 'man[ae]g?ment' drivers/staging | xargs -r perl -p -i -e 's/\bman[ae]g?ment\b/management/g'
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/et131x/et1310_mac.c b/drivers/staging/et131x/et1310_mac.c
index 02ae636e9b14..5200dbfae4b7 100644
--- a/drivers/staging/et131x/et1310_mac.c
+++ b/drivers/staging/et131x/et1310_mac.c
@@ -137,7 +137,7 @@ void ConfigMACRegs1(struct et131x_adapter *pAdapter)
/* Next lets configure the... |
a7cd5829d8b3837755105d71f76a75cddf49003f | Analyze and fix the following issue in the Linux kernel code: Staging: usb-ip: vhci_hdc:Fix the returned error value | Problem Details:
Compared with other drivers, the "ret" should be nagative and
returned. But in vhci_hdc, it always return 0;
I dont't use the driver, and I'm not familiar with the code.
Hope the patch is helpful.
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index 114db8b26028..6e91fc2bd850 100644
--- a/drivers/staging/usbip/vhci_hcd.c
+++ b/drivers/staging/usbip/vhci_hcd.c
@@ -594,7 +594,7 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
if (type != PIPE_CONTR... |
4d62691b609cc4e66e15c8e5b2261ddb6785b7ca | Analyze and fix the following issue in the Linux kernel code: Staging: dream, fix buf overflow | Problem Details:
In vfe_send_msg_no_payload there is a wrong struct vfe_message allocation.
It allocates only sizeof(pointer to vfe_message) for a whole structure.
Add a dereference to the sizeof to allocate sizeof(vfe_message).
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Sign... | ```diff
diff --git a/drivers/staging/dream/camera/msm_vfe8x_proc.c b/drivers/staging/dream/camera/msm_vfe8x_proc.c
index bb6501340211..5436f7120018 100644
--- a/drivers/staging/dream/camera/msm_vfe8x_proc.c
+++ b/drivers/staging/dream/camera/msm_vfe8x_proc.c
@@ -818,7 +818,7 @@ static void vfe_send_msg_no_payload(enum ... |
2e4d2af96aad73b7275de45cb34453d18423767d | Analyze and fix the following issue in the Linux kernel code: Staging: HTC Dream: touchscreen driver for staging | Problem Details:
This adds support for synaptic touchscreen, used in HTC dream
cellphone.
This is original version from Arve, fixed only to compile; I do have
cleaner version, but I broken something inside, and this will preserve
authorship better. I originally tried to push the driver directly to
input/touchscreen, b... | ```diff
diff --git a/drivers/staging/dream/synaptics_i2c_rmi.c b/drivers/staging/dream/synaptics_i2c_rmi.c
new file mode 100644
index 000000000000..e916cea6f3ca
--- /dev/null
+++ b/drivers/staging/dream/synaptics_i2c_rmi.c
@@ -0,0 +1,635 @@
+/* drivers/input/keyboard/synaptics_i2c_rmi.c
+ *
+ * Copyright (C) 2007 Googl... |
689bf406829c8a5e44ebf8fc8918b77b3806ee48 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: warn the world of a bug in the release function | Problem Details:
All device release functions need to do something, if not, it's a bug.
By merely providing an "empty" release function, it gets the kernel to
shut up, but that's not solving the problem at all. Stick a big fat
WARN_ON(1); in there to get people's attention.
Cc: Hank Janssen <hjanssen@microsoft.com>
... | ```diff
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
index 4462d5bb87e7..cc81ffd7e8a8 100644
--- a/drivers/staging/hv/vmbus_drv.c
+++ b/drivers/staging/hv/vmbus_drv.c
@@ -965,6 +965,11 @@ Desc: Final callback release of the vmbus root device
static void vmbus_bus_release(struct device *... |
0831ad041fd3611b31c10b46b9716b3c6289f1a1 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix coding style issues in Hv.c | Problem Details:
Lots of cleanups.
Note, the use of volatile still needs to be resolved, and
possibly the #ifdef could be done a bit "better".
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Hv.c b/drivers/staging/hv/Hv.c
index b61b35c39d90..c5b6613f2f2f 100644
--- a/drivers/staging/hv/Hv.c
+++ b/drivers/staging/hv/Hv.c
@@ -1,5 +1,4 @@
/*
- *
* Copyright (c) 2009, Microsoft Corporation.
*
* This program is free software; you can redistribute it and/or modify i... |
223c1aa632dbad672ad9b907e5d5e8f385417945 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix typedefs in nvspprotocol.h | Problem Details:
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/NetVsc.c b/drivers/staging/hv/NetVsc.c
index 36f98ebfaeac..9747ad73a12c 100644
--- a/drivers/staging/hv/NetVsc.c
+++ b/drivers/staging/hv/NetVsc.c
@@ -236,8 +236,8 @@ NetVscInitialize(
DPRINT_ENTER(NETVSC);
- DPRINT_DBG(NETVSC, "sizeof(struct hv_netvsc_packet)=%zd, sizeof(N... |
abb7aacb5070bad0e94eeaf5fad340ab4f97b33e | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix coding style issues in nvspprotocol.h | Problem Details:
No typedef changes yet though.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/include/nvspprotocol.h b/drivers/staging/hv/include/nvspprotocol.h
index 5e7e03cf851b..03fbb425d368 100644
--- a/drivers/staging/hv/include/nvspprotocol.h
+++ b/drivers/staging/hv/include/nvspprotocol.h
@@ -21,286 +21,242 @@
*
*/
-
-#pragma once
-
#include "VmbusChannelInt... |
9f0c7d2cc30a0691d478b069b499d6b1d01546a2 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix typedefs in StorVscApi.h | Problem Details:
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/BlkVsc.c b/drivers/staging/hv/BlkVsc.c
index d613e599ffac..d433d8c444f7 100644
--- a/drivers/staging/hv/BlkVsc.c
+++ b/drivers/staging/hv/BlkVsc.c
@@ -48,7 +48,7 @@ BlkVscInitialize(
struct hv_driver *Driver
)
{
- STORVSC_DRIVER_OBJECT* storDriver = (STORVSC_DRIVER_OBJECT*)D... |
9bcd786a311d7601f25a986e106d2bf774a22fdd | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix coding style issues in StorVscApi.h | Problem Details:
No typedef changes yet though.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/include/StorVscApi.h b/drivers/staging/hv/include/StorVscApi.h
index 2b3a73704af8..2deefbda73b1 100644
--- a/drivers/staging/hv/include/StorVscApi.h
+++ b/drivers/staging/hv/include/StorVscApi.h
@@ -27,12 +27,9 @@
#include "VmbusApi.h"
-
/* Defines */
-
-
-#define STORVSC_R... |
4bedd6be8b9e9a24f48792c1bef82f521a01db2a | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix coding style issues in VmbusPacketFormat.h | Problem Details:
Heh, volatiles, like that was a good idea... Turns out they were not
even used, wierd stuff.
All clean except for the typedefs.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/include/VmbusPacketFormat.h b/drivers/staging/hv/include/VmbusPacketFormat.h
index f6600a995519..d7f65de31bbc 100644
--- a/drivers/staging/hv/include/VmbusPacketFormat.h
+++ b/drivers/staging/hv/include/VmbusPacketFormat.h
@@ -21,300 +21,148 @@
*
*/
+#ifndef _VMBUSPACKETFOR... |
b3715ee49f33f336f196e9720e44c76885eacd19 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix typedefs in vstorage.h | Problem Details:
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/BlkVsc.c b/drivers/staging/hv/BlkVsc.c
index b2e6651b2013..d613e599ffac 100644
--- a/drivers/staging/hv/BlkVsc.c
+++ b/drivers/staging/hv/BlkVsc.c
@@ -61,9 +61,9 @@ BlkVscInitialize(
storDriver->RequestExtSize = sizeof(STORVSC_REQUEST_EXTENSION);
/* Divide the ring buffer... |
f3c7c96c8bb587263b408bf98f9208ac1c1d1c92 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix remaining style issue in ChannelInterface.h | Problem Details:
It snuck in with the other typedef cleanups, sorry about that.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/ChannelInterface.h b/drivers/staging/hv/ChannelInterface.h
index e24f7365ede7..684b4ca163a1 100644
--- a/drivers/staging/hv/ChannelInterface.h
+++ b/drivers/staging/hv/ChannelInterface.h
@@ -29,6 +29,7 @@
void GetChannelInterface(struct vmbus_channel_interface *ChannelInterfac... |
7e23a6e9626bf93242712f146a9657d38dda497b | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix up typedefs in NetVscApi.h | Problem Details:
It's now all clean from a coding style standpoint.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/NetVsc.c b/drivers/staging/hv/NetVsc.c
index 6d5ee1cd6b21..a7363a17536c 100644
--- a/drivers/staging/hv/NetVsc.c
+++ b/drivers/staging/hv/NetVsc.c
@@ -231,7 +231,7 @@ NetVscInitialize(
struct hv_driver *drv
)
{
- NETVSC_DRIVER_OBJECT* driver = (NETVSC_DRIVER_OBJECT*)drv;
+ s... |
8eef67392e25c04c52454e656c079bbec62487e1 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix up coding style issues in NetVscApi.h | Problem Details:
Everything but the typedefs.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/include/NetVscApi.h b/drivers/staging/hv/include/NetVscApi.h
index 60e6fbbca666..4445d69e2bae 100644
--- a/drivers/staging/hv/include/NetVscApi.h
+++ b/drivers/staging/hv/include/NetVscApi.h
@@ -29,29 +29,23 @@
#include "List.h"
/* Defines */
-
-#define NETVSC_DEVICE_RING_BUF... |
0b8ffe077776543bfcd7aa470ee9df0ab64651d0 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix up some coding style issues in logging.h | Problem Details:
It's now clean.
Well, from a coding style guide, not from a logic standpoint, the whole
file needs to be tossed overboard and cheered on as the sharks tear it
to individual bits.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/include/logging.h b/drivers/staging/hv/include/logging.h
index 74c18f1d7f4d..9e55617bd670 100644
--- a/drivers/staging/hv/include/logging.h
+++ b/drivers/staging/hv/include/logging.h
@@ -62,11 +62,11 @@
extern unsigned int vmbus_loglevel;
#define ASSERT(expr) \
- if (!... |
eacb1b4d24c2a8b7c1d73bb72e04920980ec8a4f | Analyze and fix the following issue in the Linux kernel code: Staging: hv: typdef fixes for HvSynicApi.h | Problem Details:
Still some volatile mis-usages left to fix.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Channel.c b/drivers/staging/hv/Channel.c
index a200128d0c1f..f8607320de48 100644
--- a/drivers/staging/hv/Channel.c
+++ b/drivers/staging/hv/Channel.c
@@ -42,7 +42,7 @@ static void VmbusChannelSetEvent(struct vmbus_channel *channel);
#if 0
static void
DumpMonitorPage(
- HV_MON... |
c786a84e9c7a3a342cda0aa19831417a64383444 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: coding style cleanups for HvSynicApi.h | Problem Details:
Don't fix the typedef issues, that will come next.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/include/HvSynicApi.h b/drivers/staging/hv/include/HvSynicApi.h
index 92944d612cb2..4215d9919cc4 100644
--- a/drivers/staging/hv/include/HvSynicApi.h
+++ b/drivers/staging/hv/include/HvSynicApi.h
@@ -21,433 +21,285 @@
*
*/
-#pragma once
-
+#ifndef __HVSYNICAPI_H
+#define __H... |
f80b3d51a6708b5f14a59c53b1343db59efdda1e | Analyze and fix the following issue in the Linux kernel code: Staging: hv: coding style cleanups for HvPtApi.h | Problem Details:
Fix up the typedefs in there as well.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Hv.c b/drivers/staging/hv/Hv.c
index e48033ee84be..83d0cae33cf7 100644
--- a/drivers/staging/hv/Hv.c
+++ b/drivers/staging/hv/Hv.c
@@ -230,7 +230,7 @@ int HvInit (void)
{
int ret=0;
int maxLeaf;
- HV_X64_MSR_HYPERCALL_CONTENTS hypercallMsr;
+ union hv_x64_msr_hypercall_co... |
089786553723cc134ab584ecd9e19986181e04ff | Analyze and fix the following issue in the Linux kernel code: Staging: hv: vmbus.h coding style cleanups | Problem Details:
Coding style fixes for vmbus.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/vmbus.h b/drivers/staging/hv/vmbus.h
index 44a784c02327..733edc9ab101 100644
--- a/drivers/staging/hv/vmbus.h
+++ b/drivers/staging/hv/vmbus.h
@@ -29,71 +29,53 @@
#include "include/VmbusApi.h"
-
-/* Data types */
-
-
typedef int (*PFN_DRIVERINITIALIZE)(struct hv_driver *drv... |
b4f3fda5d475931d596d5cf599a193f42b857594 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: coding style cleanup of include/HvVpApi.h | Problem Details:
Coding style fixes for include/HvVpApi.h
All of the include/Hv*.h files should be merged eventually...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/include/HvSynicApi.h b/drivers/staging/hv/include/HvSynicApi.h
index 03b4d290eb46..92944d612cb2 100644
--- a/drivers/staging/hv/include/HvSynicApi.h
+++ b/drivers/staging/hv/include/HvSynicApi.h
@@ -209,14 +209,14 @@ typedef struct _HV_PORT_INFO
struct
{
HV_SYNIC_SINT_I... |
cba4decdd3dcd224b17631572456951aace0a27e | Analyze and fix the following issue in the Linux kernel code: Staging: hv: coding style cleanup of include/HvHcApi.h | Problem Details:
Coding style fixes for include/HvHcApi.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Hv.c b/drivers/staging/hv/Hv.c
index 31459f76f16a..e48033ee84be 100644
--- a/drivers/staging/hv/Hv.c
+++ b/drivers/staging/hv/Hv.c
@@ -306,7 +306,7 @@ int HvInit (void)
goto Cleanup;
}
- gHvContext.SignalEventParam = (PHV_INPUT_SIGNAL_EVENT)(ALIGN_UP((unsigned long)gHvCont... |
93b5c9e17ab2285cc0f6527a8444e157069364a4 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: osd.c: coding style fixes | Problem Details:
Codingstyle fixes for osd.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/osd.c b/drivers/staging/hv/osd.c
index 3b142ce96616..8fe543bd9910 100644
--- a/drivers/staging/hv/osd.c
+++ b/drivers/staging/hv/osd.c
@@ -37,18 +37,10 @@
#include <linux/jiffies.h>
#include <linux/delay.h>
#include <linux/time.h>
-
-#include <asm/io.h>
-#include <asm/bitops.h... |
daaa8cc31fbd2b7356a0d67dd9ca6d336507f118 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: osd.h: fix GUID reference problem | Problem Details:
As GUID was a typedef, it hid the fact that we were passing it
a 2 variables in functions. This fixes this up by passing it
as a pointer, as it should be.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/ChannelMgmt.c b/drivers/staging/hv/ChannelMgmt.c
index f96cba7fa96f..ec078bdfd40c 100644
--- a/drivers/staging/hv/ChannelMgmt.c
+++ b/drivers/staging/hv/ChannelMgmt.c
@@ -284,8 +284,8 @@ VmbusChannelProcessOffer(
/* Start the process of binding this offer to the driver */
/* ... |
0ccafb365803b3256aa75fd07bf9e5c6814a260d | Analyze and fix the following issue in the Linux kernel code: Staging: hv: osd.h: codingstyle cleanups | Problem Details:
This fixes up the coding style issues in osd.h, with the exception of
the typedefs, they will be removed later.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/osd.h b/drivers/staging/hv/osd.h
index 949c273e576d..1723248db910 100644
--- a/drivers/staging/hv/osd.h
+++ b/drivers/staging/hv/osd.h
@@ -27,32 +27,28 @@
/* Defines */
+#define ALIGN_UP(value, align) (((value) & (align-1)) ? \
+ (((value) + (align-1)) & ~(align-1)) : \... |
bfc30aae73b6be57528059a9e03ce8674320e67b | Analyze and fix the following issue in the Linux kernel code: Staging: hv: osd: add osd_ prefix to global functions | Problem Details:
Put a "osd_" prefix on the osd.c functions in order for us to play nicer
in the kernel namespace.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Channel.c b/drivers/staging/hv/Channel.c
index 5b876438d41b..2346b859569b 100644
--- a/drivers/staging/hv/Channel.c
+++ b/drivers/staging/hv/Channel.c
@@ -230,7 +230,7 @@ VmbusChannelOpen(
NewChannel->ChannelCallbackContext = Context;
/* Allocate the ring buffer */
- out = ... |
949cadaa054588db0c4a3a0cfc3ac93f08fda913 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix sparse NULL pointer warnings | Problem Details:
This fixes up all of the sparse warnings where NULL should be used
instead of 0.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Hv.c b/drivers/staging/hv/Hv.c
index ef328d0d3821..36e0d860f14d 100644
--- a/drivers/staging/hv/Hv.c
+++ b/drivers/staging/hv/Hv.c
@@ -231,7 +231,7 @@ HvInit (
int ret=0;
int maxLeaf;
HV_X64_MSR_HYPERCALL_CONTENTS hypercallMsr;
- void* virtAddr=0;
+ void *virtAddr = NULL... |
127729066686c363c405c586731235443c03c252 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix sparse function warnings | Problem Details:
This fixes up all of the sparse warnings about functions not being
properly declared. Meaning, void functions need to say they are a void
function, otherwise the compiler assumes it is an integer here.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Connection.c b/drivers/staging/hv/Connection.c
index d017c2725d52..a2888cb46709 100644
--- a/drivers/staging/hv/Connection.c
+++ b/drivers/staging/hv/Connection.c
@@ -45,8 +45,7 @@ Description:
--*/
static int
-VmbusConnect(
- )
+VmbusConnect(void)
{
int ret=0;
VMBUS_CHA... |
bd1de709165a4f59878d4a272370fa228aa753f7 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix sparse static warnings | Problem Details:
This fixes up all of the sparse warnings about static functions.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/BlkVsc.c b/drivers/staging/hv/BlkVsc.c
index d2bde5dd92a3..526a0ab89975 100644
--- a/drivers/staging/hv/BlkVsc.c
+++ b/drivers/staging/hv/BlkVsc.c
@@ -75,7 +75,7 @@ BlkVscInitialize(
return ret;
}
-int
+static int
BlkVscOnDeviceAdd(
struct hv_device *Device,
void *Add... |
b7d7ae6f1de803667f86d2f2a839bf513b294427 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: properly fix the printk() warnings | Problem Details:
This fixes the printk() warnings on all platforms now (x86-64 and i386).
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Channel.c b/drivers/staging/hv/Channel.c
index 5ebc8dec1d16..68f3442395f0 100644
--- a/drivers/staging/hv/Channel.c
+++ b/drivers/staging/hv/Channel.c
@@ -555,7 +555,7 @@ VmbusChannelEstablishGpadl(
DPRINT_DBG(VMBUS, "buffer %p, size %d msg cnt %d", Kbuffer, Size, msgCount);
... |
bafd2c2a16d4257fd580ad387f18a15377f60dc6 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: remove more printk() warnings | Problem Details:
This should fix up the rest of the printk() warnings on an i386 build
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Channel.c b/drivers/staging/hv/Channel.c
index 674f141a648f..5ebc8dec1d16 100644
--- a/drivers/staging/hv/Channel.c
+++ b/drivers/staging/hv/Channel.c
@@ -555,7 +555,7 @@ VmbusChannelEstablishGpadl(
DPRINT_DBG(VMBUS, "buffer %p, size %d msg cnt %d", Kbuffer, Size, msgCount);
... |
b2aba7cc7105de5ce7769d7b5ddb0b0bc28909c5 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: vmbus_drv.c: fix print formatting | Problem Details:
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
index a86e4043d174..74419a7eb32d 100644
--- a/drivers/staging/hv/vmbus_drv.c
+++ b/drivers/staging/hv/vmbus_drv.c
@@ -647,7 +647,7 @@ static int vmbus_child_device_register(DEVICE_OBJECT* root_device_obj, DEVICE_OB
ret = child_device... |
7f6f27d65cfd94cab66b64cf4a1ef87f1bd8ea86 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: storvsc_drv.c: fix print formatting | Problem Details:
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index 648708ab44e6..3c677f015c47 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -943,7 +943,7 @@ static void storvsc_host_rescan_callback(struct work_struct *work)
return;
}
- DPRINT_... |
38d3af06737c6724e6f785fddf2679da02275dcb | Analyze and fix the following issue in the Linux kernel code: Staging: hv: RndisFilter.c: fix print formatting | Problem Details:
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/RndisFilter.c b/drivers/staging/hv/RndisFilter.c
index d971e866218c..919166761743 100644
--- a/drivers/staging/hv/RndisFilter.c
+++ b/drivers/staging/hv/RndisFilter.c
@@ -409,7 +409,7 @@ RndisFilterReceiveResponse(
}
else
{
- DPRINT_ERR(NETVSC, "rndis response buffer o... |
4d4a0e22418b517907340248460583bbd22d0609 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: NetVsc.c: fix print formatting | Problem Details:
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/NetVsc.c b/drivers/staging/hv/NetVsc.c
index 72d41cc4829c..111e149d88bb 100644
--- a/drivers/staging/hv/NetVsc.c
+++ b/drivers/staging/hv/NetVsc.c
@@ -239,7 +239,7 @@ NetVscInitialize(
DPRINT_ENTER(NETVSC);
- DPRINT_DBG(NETVSC, "sizeof(NETVSC_PACKET)=%d, sizeof(NVSP_MESSAGE... |
dfe8b2d9d809fef5df24280e1e275fcd30776bd5 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix blkvsc_ioctl() parameters | Problem Details:
blkvsc_ioctl() had the wrong parameter list for struct
block_device_operations
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
index 4bf77eeece7a..5322e570bd8c 100644
--- a/drivers/staging/hv/blkvsc_drv.c
+++ b/drivers/staging/hv/blkvsc_drv.c
@@ -129,8 +129,8 @@ static int blkvsc_release(struct gendisk *disk, fmode_t mode);
static int blkvsc_media_changed(s... |
77d2d9da7c74678b69170485909e63ff21e4af07 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix blkvsc_release() parameters | Problem Details:
blkvsc_release() had the wrong parameter list for struct
block_device_operations
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
index d8a3b2539045..4bf77eeece7a 100644
--- a/drivers/staging/hv/blkvsc_drv.c
+++ b/drivers/staging/hv/blkvsc_drv.c
@@ -125,7 +125,7 @@ static int blkvsc_remove(struct device *device);
static void blkvsc_shutdown(struct device *devi... |
39635f7d8de679d97e2773e6c5d2749a420bed87 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix blkvsc_open() parameters | Problem Details:
blkvsc_open() had the wrong parameter list for struct
block_device_operations
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
index 8f70b405aebe..d8a3b2539045 100644
--- a/drivers/staging/hv/blkvsc_drv.c
+++ b/drivers/staging/hv/blkvsc_drv.c
@@ -124,7 +124,7 @@ static int blkvsc_probe(struct device *dev);
static int blkvsc_remove(struct device *device);
s... |
627c156d75582c6e678efabc64d33d4b1c66b4ce | Analyze and fix the following issue in the Linux kernel code: Staging: hv: blkvsc_drv.c: fix print formatting | Problem Details:
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
index 9c4bfb6dea92..8f70b405aebe 100644
--- a/drivers/staging/hv/blkvsc_drv.c
+++ b/drivers/staging/hv/blkvsc_drv.c
@@ -411,7 +411,7 @@ static int blkvsc_probe(struct device *device)
/* go! */
add_disk(blkdev->gd);
- DPRINT_INF... |
78cd20035dc28f308e8c3d7a285ddfd23f129e65 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: StorVsc.c: fix print formatting | Problem Details:
There were a few places that used %lx when they should have used %x
and a few places that used %d when they should have used %ld
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/StorVsc.c b/drivers/staging/hv/StorVsc.c
index ee6d88e16d6c..50057e6320af 100644
--- a/drivers/staging/hv/StorVsc.c
+++ b/drivers/staging/hv/StorVsc.c
@@ -271,7 +271,7 @@ StorVscInitialize(
DPRINT_ENTER(STORVSC);
- DPRINT_DBG(STORVSC, "sizeof(STORVSC_REQUEST)=%d sizeof(STOR... |
2701f686d7083d516c2f937031515b032d71f563 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix up printk warnings | Problem Details:
After LogMsg was converted to printk, lots of build warnings showed up
as no one was checking the arguments to LogMsg. This patch fixes them
all.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Hv.c b/drivers/staging/hv/Hv.c
index 9ef3a0282588..3a833ad55d48 100644
--- a/drivers/staging/hv/Hv.c
+++ b/drivers/staging/hv/Hv.c
@@ -300,9 +300,9 @@ HvInit (
goto Cleanup;
}
- DPRINT_INFO(VMBUS, "Hypercall page VA=0x%08x, PA=0x%08x",
- (unsigned long)gHv... |
621d7fb7597e8cc2e24e6b0ca67118b452675d90 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: netvsc: fix up driver_data usage | Problem Details:
driver_data is gone now from struct device, so use the proper functions
to access it instead.
Thanks to Bill Pemberton for pointing out this build error.
Cc: Bill Pemberton <wfp5p@viridian.itc.Virginia.EDU>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-of... | ```diff
diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index 71931f553193..cd3f3b53f59b 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -209,14 +209,14 @@ static int netvsc_probe(struct device *device)
net_device_ctx = netdev_priv(net);
net_dev... |
b57a68dcd9030515763133f79c5a4a7c572e45d6 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: blkvsc: fix up driver_data usage | Problem Details:
driver_data is gone now from struct device, so use the proper functions
to access it instead.
Thanks to Bill Pemberton for pointing out this build error.
Cc: Bill Pemberton <wfp5p@viridian.itc.Virginia.EDU>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-of... | ```diff
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
index a4852f5a2a3a..04d980f1beee 100644
--- a/drivers/staging/hv/blkvsc_drv.c
+++ b/drivers/staging/hv/blkvsc_drv.c
@@ -341,7 +341,7 @@ static int blkvsc_probe(struct device *device)
blkdev->target = device_info.TargetId; // this i... |
0883c52bb245cb2be20546babcd54121e7ff17e2 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: storvsc: fix up driver_data usage | Problem Details:
driver_data is gone now from struct device, so use the proper functions
to access it instead.
Thanks to Bill Pemberton for pointing out this build error.
Cc: Bill Pemberton <wfp5p@viridian.itc.Virginia.EDU>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-of... | ```diff
diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index 0a1c14451b0a..1a05134cc40e 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -279,7 +279,7 @@ static int storvsc_probe(struct device *device)
return -ENOMEM;
}
- device->driver_dat... |
530cf2070be30831a371b6c7181d15e5976b6fc7 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: use the correct #ifdef for x86-64 | Problem Details:
x86-64 needs a different config check. Thanks to Hank for the debugging
to determine the fix for this.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Hv.c b/drivers/staging/hv/Hv.c
index 093210713469..4f080f0ddaed 100644
--- a/drivers/staging/hv/Hv.c
+++ b/drivers/staging/hv/Hv.c
@@ -165,7 +165,7 @@ HvDoHypercall (
void* Output
)
{
-#ifdef x86_64
+#ifdef CONFIG_X86_64
UINT64 hvStatus=0;
UINT64 inputAddre... |
bea385aceb2dbd14c09180274ba74edadd46ccf3 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8187se/ieee80211: ieee80211.h reorderings | Problem Details:
Reorder the code in ieee80211.h for easier comparisions with
rtl8192su's version of the file.
While at it:
* use IEEE80211_4ADDR_LEN for IEEE80211_LEN definition
* remove unused country_code_type_t typedef
* make some minor coding style fixes
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.c... | ```diff
diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211.h b/drivers/staging/rtl8187se/ieee80211/ieee80211.h
index c5278e9ecc59..5261cdd6a202 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211.h
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211.h
@@ -133,102 +133,14 @@ typedef struct ieee_param {
... |
b8bc58c5fbfb25acbafc021fc392a8d93b541585 | Analyze and fix the following issue in the Linux kernel code: Staging: rt*: don't confuse user of rt3070 driver with rt2870 strings | Problem Details:
Original author didn't bother to change strings for rt3070 driver. Fix it.
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/rt_linux.h b/drivers/staging/rt2860/rt_linux.h
index 25b53ac3f820..b434824d932c 100644
--- a/drivers/staging/rt2860/rt_linux.h
+++ b/drivers/staging/rt2860/rt_linux.h
@@ -90,22 +90,23 @@ typedef int (*HARD_START_XMIT_FUNC)(struct sk_buff *skb, struct net_device *net_
// ad... |
bc0db7314240c7aa2866546e80b8ba157c8009f7 | Analyze and fix the following issue in the Linux kernel code: Staging: rt*: fix wait_queue_head_t declaration on stack | Problem Details:
othwerwise lockdep complains:
"INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator."
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg K... | ```diff
diff --git a/drivers/staging/rt2860/rt_main_dev.c b/drivers/staging/rt2860/rt_main_dev.c
index 35c59d5aa99c..8fd1aafc4592 100644
--- a/drivers/staging/rt2860/rt_main_dev.c
+++ b/drivers/staging/rt2860/rt_main_dev.c
@@ -190,7 +190,7 @@ int rt28xx_close(IN PNET_DEV dev)
BOOLEAN Cancelled = FALSE;
UINT32 i... |
bbff696edead56dd87e1d10593ff0b438d29fbc5 | Analyze and fix the following issue in the Linux kernel code: Staging: at76_usb: fix !CONFIG_WIRELESS_EXT build | Problem Details:
Fix this build error when CONFIG_WIRELESS_EXT is not set
at76_usb.c:5322: error: 'struct net_device' has no member named 'wireless_data'
at76_usb.c:5325: error: 'struct net_device' has no member named 'wireless_handlers'
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kr... | ```diff
diff --git a/drivers/staging/at76_usb/at76_usb.c b/drivers/staging/at76_usb/at76_usb.c
index c165c50c0119..97aef78d42f0 100644
--- a/drivers/staging/at76_usb/at76_usb.c
+++ b/drivers/staging/at76_usb/at76_usb.c
@@ -5319,10 +5319,12 @@ static int at76_init_new_device(struct at76_priv *priv,
/* Add pointers t... |
eba1aaddc0fd427d62f51747c6ec5f965ef5dc56 | Analyze and fix the following issue in the Linux kernel code: Staging: quatech_usb2: Improve debug output and fix write_room | Problem Details:
This patch contains changes made in the course of successfully reading
data from the device. These consist of a number of corrections and
additions to debug messages, and a fix for incorrect calculation of the
number of characters in the device FIFO which affected the operation of
the write_room method... | ```diff
diff --git a/drivers/staging/quatech_usb2/quatech_usb2.c b/drivers/staging/quatech_usb2/quatech_usb2.c
index b06e90d3cefc..deb222c7186e 100644
--- a/drivers/staging/quatech_usb2/quatech_usb2.c
+++ b/drivers/staging/quatech_usb2/quatech_usb2.c
@@ -163,7 +163,7 @@ static struct usb_driver quausb2_usb_driver = {
... |
2feb633d6580d8e6a61890bef1c0ea9020e61225 | Analyze and fix the following issue in the Linux kernel code: Staging: quatech_usb2: chars_in_buffer() fix | Problem Details:
It seems I can't count.
Patch to fix chars_in_buffer() method (broken in vendor driver), and
subsequently simplify the close() method, making it somewhat less
broken. There is quite a bit more improvement to do on this method
though.
Signed-off-by: Richard Ash <richard@audacityteam.org>
Signed-off-by... | ```diff
diff --git a/drivers/staging/quatech_usb2/quatech_usb2.c b/drivers/staging/quatech_usb2/quatech_usb2.c
index a877e48b9e58..770585660075 100644
--- a/drivers/staging/quatech_usb2/quatech_usb2.c
+++ b/drivers/staging/quatech_usb2/quatech_usb2.c
@@ -619,7 +619,10 @@ int qt2_open(struct tty_struct *tty, struct usb_... |
72ba94ec61d1ceb9b80e317f72548b1e88e539f4 | Analyze and fix the following issue in the Linux kernel code: Staging: quatech_usb2: implement open functionality | Problem Details:
Part two of the driver implementation has finally got done. It
implements the rest of open and the callback for reads from the box. I
seem to have finally found a structure that can be made to work, with a
single set of URBs for bulk read and write for the whole device, which
are used by all the ports.... | ```diff
diff --git a/drivers/staging/quatech_usb2/quatech_usb2.c b/drivers/staging/quatech_usb2/quatech_usb2.c
index 3544e7005404..0eaea2e7ce8a 100644
--- a/drivers/staging/quatech_usb2/quatech_usb2.c
+++ b/drivers/staging/quatech_usb2/quatech_usb2.c
@@ -38,6 +38,7 @@ static int debug;
#define QU2BOXPWRON 0x8000 /* m... |
4ff863b1db411481971de481002aa644057b1fa6 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: s626: Possible read buffer overflow fix | Problem Details:
If `cmd->chanlist_len' is 0, then we write ppl[-1].
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 6549d116f2e6..80d2787d1063 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -1707,7 +1707,8 @@ static int s626_ai_load_polllist(uint8_t * ppl, struct comedi_cmd *cmd)... |
4a5629b92ee530e7c3077689d5efb90be613a9a5 | Analyze and fix the following issue in the Linux kernel code: Staging: otus: Fix warnings in staging/otus/ioctl.c | Problem Details:
This fixes a number of warnings in the otus driver.
Signed-off-by: D Pranith Kumar <bobby.prani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/otus/ioctl.c b/drivers/staging/otus/ioctl.c
index ce04218253dd..dd327056f120 100644
--- a/drivers/staging/otus/ioctl.c
+++ b/drivers/staging/otus/ioctl.c
@@ -2045,6 +2045,7 @@ int usbdrv_wpa_ioctl(struct net_device *dev, struct athr_wlan_param *zdparm)
struct zsKeyInfo keyInfo;
... |
761e95493982f3365e6ef34991a6c7ff84e33d25 | Analyze and fix the following issue in the Linux kernel code: Staging: vt6655: fix build when !CONFIG_WIRELESS_EXT | Problem Details:
Fix this build error when CONFIG_WIRELESS_EXT is not set:
drivers/staging/vt6655/device_main.c:1153: error: 'struct net_device'
has no member named 'wireless_handlers'
Cc: Forest Bond <forest@alittletooquiet.net>
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Har... | ```diff
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index f43ca416e4a8..0a11d7fd8aa2 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1146,14 +1146,9 @@ device_found1(struct pci_dev *pcid, const struct pci_device_id *ent)
... |
0984e56a65a29ad0700c5abf657327e73929ea1f | Analyze and fix the following issue in the Linux kernel code: Staging: android: lowmemorykiller: fix module param errors | Problem Details:
Move module_params to near the end of the source file so that
their references are already known/defined. Fixes build errors:
drivers/staging/android/lowmemorykiller.c: In function '__check_cost':
drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared (first use in this fun... | ```diff
diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index f13c6fc76c44..935d281a201a 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -57,13 +57,6 @@ static int lowmem_minfree_size = 4;
printk(x); \
}... |
e69b0f1b41c0e57bb1e29100b5810a5914efcb45 | Analyze and fix the following issue in the Linux kernel code: sched: Add a few SYNC hint knobs to play with | Problem Details:
Currently we use overlap to weaken the SYNC hint, but allow it to
set the hint as well.
echo NO_SYNC_WAKEUP > /debug/sched_features
echo SYNC_MORE > /debug/sched_features
preserves pipe-test behaviour without using the WF_SYNC hint.
Worth playing with on more workloads...
Signed-off-by: Peter Zij... | ```diff
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 6766959c7f44..280892e9d85e 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -1165,9 +1165,17 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p, int sync)
load = source_load(prev_cpu, idx);
this_load = target_l... |
63859d4fe4c97b737e7adbfe60acb1c2b2e668cb | Analyze and fix the following issue in the Linux kernel code: sched: Fix sync wakeups again | Problem Details:
The sync argument rename to introduce WF_* broke stuff by missing a
local alias for an argument in __wake_up_common, fix it by using
the more descriptive wake_flags name.
This restores WF_SYNC propagation, which fixes wake_affine()
behaviour, which fixes pipe-test.
Signed-off-by: Peter Zijlstra <a.p.... | ```diff
diff --git a/kernel/sched.c b/kernel/sched.c
index 0d4c4fea3317..af04ede6dd2f 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5564,10 +5564,10 @@ asmlinkage void __sched preempt_schedule_irq(void)
#endif /* CONFIG_PREEMPT */
-int default_wake_function(wait_queue_t *curr, unsigned mode, int flags,
+int... |
9ef96da6ec5e1b4cf7eb8e30852cd88ec7d5fdc0 | Analyze and fix the following issue in the Linux kernel code: xfs: includecheck fix for fs/xfs/xfs_iops.c | Problem Details:
fix the following 'make includecheck' warning:
fs/xfs/linux-2.6/xfs_iops.c: xfs_acl.h is included more than once.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
Signed-off-by: Alex Elder <aelder@sgi.com> | ```diff
diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
index 8070b34cc287..626b474b2cdd 100644
--- a/fs/xfs/linux-2.6/xfs_iops.c
+++ b/fs/xfs/linux-2.6/xfs_iops.c
@@ -43,7 +43,6 @@
#include "xfs_error.h"
#include "xfs_itable.h"
#include "xfs_rw.h"
-#include "xfs_acl.h"
#include "xfs_attr.h"
... |
889c27744c30eb7a43b68c11e33e679cfafc8cd5 | Analyze and fix the following issue in the Linux kernel code: pcmcia: document return value of pcmcia_loop_config | Problem Details:
Hopefully it will be harder to get it wrong now. Also fix an unneeded
initialization while we are here.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
index 8c2db2ac8f8a..d919e96c0afd 100644
--- a/drivers/pcmcia/pcmcia_resource.c
+++ b/drivers/pcmcia/pcmcia_resource.c
@@ -902,7 +902,7 @@ struct pcmcia_cfg_mem {
*
* pcmcia_loop_config() loops over all configuration options, an... |
cb6dbd79628a53e66352387b53b426fa88640bfe | Analyze and fix the following issue in the Linux kernel code: pcmcia: dtl1_cs: fix pcmcia_loop_config logic | Problem Details:
pcmcia_loop_config returns 0 on success.
[wsa: added '< 0' for better readability]
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/bluetooth/dtl1_cs.c b/drivers/bluetooth/dtl1_cs.c
index 2cc7b3266eaf..b881a9cd8741 100644
--- a/drivers/bluetooth/dtl1_cs.c
+++ b/drivers/bluetooth/dtl1_cs.c
@@ -618,7 +618,7 @@ static int dtl1_config(struct pcmcia_device *link)
/* Look for a generic full-sized window */
link->io.NumP... |
b4b3d7bbe1e1d924dc5f3b48b6c06977aee2d494 | Analyze and fix the following issue in the Linux kernel code: pcmcia: fix incorrect argument order to list_add_tail() | Problem Details:
Commit a56bc69a182f501582557af7fad5bc882b1c856c fixed a wrong usage of
list_add_tail() within store_new_id() for PCI. Port the fix to PCMCIA,
which adapted this function from PCI.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Greg Kroah-Hart... | ```diff
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index 304ff6d5cf3b..9f300d3cb125 100644
--- a/drivers/pcmcia/ds.c
+++ b/drivers/pcmcia/ds.c
@@ -236,7 +236,6 @@ pcmcia_store_new_id(struct device_driver *driver, const char *buf, size_t count)
if (!dynid)
return -ENOMEM;
- INIT_LIST_HEAD(&dynid->node... |
088a4eed282c9f75a2c165ba4909433c6dd6f959 | Analyze and fix the following issue in the Linux kernel code: debugfs: Change debuhgfs directory of trace-events-sample.h | Problem Details:
Default directory of debug filesystem for ftrace is /sys/kernel/debug/.
Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
index f24ae370e514..6af373236d73 100644
--- a/samples/trace_events/trace-events-sample.h
+++ b/samples/trace_events/trace-events-sample.h
@@ -1,6 +1,6 @@
/*
* If TRACE_SYSTEM is defined, that will be the dire... |
52ad51e7a93558a218cd00059bd69881a82eb2bb | Analyze and fix the following issue in the Linux kernel code: debugfs: Fix mount directory of debugfs by default in events.txt | Problem Details:
We need common default directory of denbugfs for consistency.
(debugfs's default directory is /sys/kernel/debug/ by debugfs.)
Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/Documentation/trace/events.txt b/Documentation/trace/events.txt
index 2bcc8d4dea29..90e8b3383ba2 100644
--- a/Documentation/trace/events.txt
+++ b/Documentation/trace/events.txt
@@ -22,12 +22,12 @@ tracing information should be printed.
---------------------------------
The events which are ava... |
162dd4212409fd2d36ff22547ea821bf3e86bcc9 | Analyze and fix the following issue in the Linux kernel code: mem_class: fix bug | Problem Details:
When I build and boot -next on fedora 10, I can not login anymore.
When I input the user name and password, the system does not output
any message and requires user to input the user name and password
again and again.
I find the patch which caused this problem with "GIT BISECT" command.
And the patch ... | ```diff
diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index bed3503184e4..0491cdf63f2a 100644
--- a/drivers/char/mem.c
+++ b/drivers/char/mem.c
@@ -878,8 +878,8 @@ static const struct memdev {
[ 4] = { "port", &port_fops, NULL },
#endif
[ 5] = { "zero", &zero_fops, &zero_bdi },
- [ 6] = { "full", &full_fops... |
2023c610dc54a4f4130b0494309a9bd668ca3df8 | Analyze and fix the following issue in the Linux kernel code: Driver core: add new device to bus's list before probing | Problem Details:
This patch (as1271) affects when new devices get linked into their
bus's list of devices. Currently this happens after probing, and it
doesn't happen at all if probing fails. Clearly this is wrong,
because at that point quite a few symbolic links have already been
created in sysfs. We are committed ... | ```diff
diff --git a/drivers/base/base.h b/drivers/base/base.h
index b528145a078f..1e52c125f437 100644
--- a/drivers/base/base.h
+++ b/drivers/base/base.h
@@ -104,7 +104,7 @@ extern int system_bus_init(void);
extern int cpu_dev_init(void);
extern int bus_add_device(struct device *dev);
-extern void bus_attach_devic... |
f509e34a57086874a736db66d37ac0456fe455fe | Analyze and fix the following issue in the Linux kernel code: [IA64] sgi-xp: fix printk format warnings | Problem Details:
Fix warnings in SGI XPC sn2 driver: lots of printk format warnings
and:
drivers/misc/sgi-xp/xpc_sn2.c: In function 'xpc_get_partition_rsvd_page_pa_sn2':
drivers/misc/sgi-xp/xpc_sn2.c:618: warning: passing argument 3 of 'sn_partition_reserved_page_pa' from incompatible pointer type
drivers/misc/sgi-xp... | ```diff
diff --git a/drivers/misc/sgi-xp/xpc_sn2.c b/drivers/misc/sgi-xp/xpc_sn2.c
index 915a3b495da5..8b70e03f939f 100644
--- a/drivers/misc/sgi-xp/xpc_sn2.c
+++ b/drivers/misc/sgi-xp/xpc_sn2.c
@@ -279,7 +279,7 @@ xpc_check_for_sent_chctl_flags_sn2(struct xpc_partition *part)
spin_unlock_irqrestore(&part->chctl_lock... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.