id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
27dc9c5a3d652b0d55ab9ab396dcce9f13bc77c3 | Analyze and fix the following issue in the Linux kernel code: qla2xxx: Fixed a bug in number of response queue creation logic. | Problem Details:
Cc: stable@kernel.org
Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index dcf011679c8b..f0396e79b6fa 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1663,7 +1663,7 @@ skip_pio:
/* queue 0 uses two msix vectors */
if (ql2xmultique_tag) {
cpus = num_online_cpus(... |
30c9afa6cc477f6f21f8a0b36f3b81080941a0c9 | Analyze and fix the following issue in the Linux kernel code: fix race that can give duplicate host number | Problem Details:
Just once, two fcoe instances got the same host number
from scsi_add_host().
Use atomic_t and atomic_inc_return() to get next host number.
Subtract 1, so that scsi_host still starts with 0.
[jejb: added comment about unusual subtraction]
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: ... | ```diff
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 89d41a424b33..5fd2da494d08 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -40,7 +40,7 @@
#include "scsi_logging.h"
-static int scsi_host_next_hn; /* host_no for next new host */
+static atomic_t scsi_host_next_hn; /* host_no f... |
bd2199d417313a056d4d2b2bac852231e1b50a4e | Analyze and fix the following issue in the Linux kernel code: libiscsi: add conn and scsi eh log debug flags | Problem Details:
Allow the user to control the debug logs in libiscsi. We will now
have a module param for connection, session & error handling.
[Mike Christie - Fixed up to compile on current code and added
missing ISCSI_DBG_EH conversions]
Signed-off-by: Erez Zilber <erezzi.list@gmail.com>
Signed-off-by: Mike Chris... | ```diff
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index b55b7991d5fa..716cc344c5df 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -38,15 +38,30 @@
#include <scsi/scsi_transport_iscsi.h>
#include <scsi/libiscsi.h>
-static int iscsi_dbg_lib;
-module_param_named(debug_libisc... |
ea09bcc9c298d3057270abd78a973fc678d55c4c | Analyze and fix the following issue in the Linux kernel code: sd: Physical block size and alignment support | Problem Details:
Extract physical block size and lowest aligned LBA from READ
CAPACITY(16) response and adjust queue parameters.
Report physical block size and alignment when applicable.
[jejb: fix up trailing whitespace]
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: James Bottomley <J... | ```diff
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 878b17a9af30..a86064b6458d 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1307,6 +1307,7 @@ static int read_capacity_16(struct scsi_disk *sdkp, struct scsi_device *sdp,
int sense_valid = 0;
int the_result;
int retries = 3;
+ unsigned int... |
b76a3f93d01fc93a87cb6eba4e854ffe378b4bac | Analyze and fix the following issue in the Linux kernel code: exofs: Fix bio leak in error handling path (sync read) | Problem Details:
When failing a read request in the sync path, called from
write_begin, I forgot to free the allocated bio, fix it.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> | ```diff
diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c
index 77d0a295eb1c..bb5d6ed0f7a8 100644
--- a/fs/exofs/inode.c
+++ b/fs/exofs/inode.c
@@ -295,6 +295,9 @@ static int read_exec(struct page_collect *pcol, bool is_sync)
err:
if (!is_sync)
_unlock_pcol_pages(pcol, ret, READ);
+ else /* Pages unlocked by calle... |
c1f47b454ce759d7b13604137a233cad4617e1e8 | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: Fix vmlinux fallback when running on a different kernel | Problem Details:
Lucas De Marchi reported that perf report and perf annotate
displays mismatching profile if a perf.data is analyzed on
an older kernel - even if the correct vmlinux is specified
via the -k option.
The reason is the fallback path in util/symbol.c:dso__load_kernel():
int dso__load_kernel(struct dso *se... | ```diff
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 86e14375e74e..01b62fa03996 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -629,7 +629,7 @@ int dso__load_kernel(struct dso *self, const char *vmlinux,
if (vmlinux)
err = dso__load_vmlinux(self, vmlinux, filter, ... |
d9f2a5ecb2846d0fd368fb4c45182e43f38e4471 | Analyze and fix the following issue in the Linux kernel code: perf_counter, x8: Fix L1-data-Cache-Store-Referencees for AMD | Problem Details:
Fix AMD's Data Cache Refills from System event.
After this patch :
./tools/perf/perf stat -e l1d -e l1d-misses -e l1d-write -e l1d-prefetch -e l1d-prefetch-miss -e l1i -e l1i-misses -e l1i-prefetch -e l2 -e l2-misses -e l2-write -e dtlb -e dtlb-misses -e itlb -e itlb-misses -e bpu -e bpu-misses ls /... | ```diff
diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
index 76dfef23f789..22eb3a1d4f9c 100644
--- a/arch/x86/kernel/cpu/perf_counter.c
+++ b/arch/x86/kernel/cpu/perf_counter.c
@@ -401,7 +401,7 @@ static const u64 amd_hw_cache_event_ids
[ C(RESULT_MISS) ] = 0x0041, /* Data Cac... |
d4ec36bac3de39b7e10ec8f42fbdd20d9a9ed753 | Analyze and fix the following issue in the Linux kernel code: sched: Documentation/sched-rt-group: Fix style issues & bump version | Problem Details:
- add missing closing bracket
- fix two 80-chars issues (as the rest of the document adheres to it)
- bump a reference to kernel version, so the document does not feel aged
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1245580359-4465-... | ```diff
diff --git a/Documentation/scheduler/sched-rt-group.txt b/Documentation/scheduler/sched-rt-group.txt
index 1df7f9cdab05..86eabe6c3419 100644
--- a/Documentation/scheduler/sched-rt-group.txt
+++ b/Documentation/scheduler/sched-rt-group.txt
@@ -73,7 +73,7 @@ The remaining CPU time will be used for user input and ... |
99bd0c0fc4b04da54cb311953ef9489931c19c63 | Analyze and fix the following issue in the Linux kernel code: x86: Set cpu_llc_id on AMD CPUs | Problem Details:
This counts when building sched domains in case NUMA information
is not available.
( See cpu_coregroup_mask() which uses llc_shared_map which in turn is
created based on cpu_llc_id. )
Currently Linux builds domains as follows:
(example from a dual socket quad-core system)
CPU0 attaching sched-dom... | ```diff
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index e5b27d8f1b47..28e5f5956042 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -258,13 +258,15 @@ static void __cpuinit amd_detect_cmp(struct cpuinfo_x86 *c)
{
#ifdef CONFIG_X86_HT
unsigned bits;
+ int cpu = smp_p... |
e487683990972bf9aa4e688434c46ead76748bca | Analyze and fix the following issue in the Linux kernel code: x86, mce: fix typo in comment in asm/mce.h | Problem Details:
Fix comment to match the actual declaration.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Cc: Andi Kleen <ak@linux.intel.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com> | ```diff
diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
index 5cdd8d100ec9..b50b9e9042c4 100644
--- a/arch/x86/include/asm/mce.h
+++ b/arch/x86/include/asm/mce.h
@@ -9,7 +9,7 @@
*/
#define MCG_BANKCNT_MASK 0xff /* Number of Banks */
-#define MCG_CTL_P (1ULL<<8) /* MCG_CAP register ... |
c277331d5fbaae5772ed19862feefa91f4e477d3 | Analyze and fix the following issue in the Linux kernel code: mm: page_alloc: clear PG_locked before checking flags on free | Problem Details:
da456f1 "page allocator: do not disable interrupts in free_page_mlock()" moved
the PG_mlocked clearing after the flag sanity checking which makes mlocked
pages always trigger 'bad page'. Fix this by clearing the bit up front.
Reported--and-debugged-by: Peter Chubb <peter.chubb@nicta.com.au>
Signed-of... | ```diff
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 6f0753fe694c..30d5093a099d 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -488,7 +488,6 @@ static inline void __free_one_page(struct page *page,
*/
static inline void free_page_mlock(struct page *page)
{
- __ClearPageMlocked(page);
__dec_zone_pag... |
9063c61fd5cbd6f42e95929aa0e02380c9e15656 | Analyze and fix the following issue in the Linux kernel code: x86, 64-bit: Clean up user address masking | Problem Details:
The discussion about using "access_ok()" in get_user_pages_fast() (see
commit 7f8189068726492950bf1a2dcfd9b51314560abf: "x86: don't use
'access_ok()' as a range check in get_user_pages_fast()" for details and
end result), made us notice that x86-64 was really being very sloppy
about virtual address che... | ```diff
diff --git a/arch/x86/include/asm/page_64_types.h b/arch/x86/include/asm/page_64_types.h
index 8d382d3abf38..7639dbf5d223 100644
--- a/arch/x86/include/asm/page_64_types.h
+++ b/arch/x86/include/asm/page_64_types.h
@@ -41,7 +41,7 @@
/* See Documentation/x86/x86_64/mm.txt for a description of the memory map. ... |
7f8189068726492950bf1a2dcfd9b51314560abf | Analyze and fix the following issue in the Linux kernel code: x86: don't use 'access_ok()' as a range check in get_user_pages_fast() | Problem Details:
It's really not right to use 'access_ok()', since that is meant for the
normal "get_user()" and "copy_from/to_user()" accesses, which are done
through the TLB, rather than through the page tables.
Why? access_ok() does both too few, and too many checks. Too many,
because it is meant for regular kerne... | ```diff
diff --git a/arch/x86/mm/gup.c b/arch/x86/mm/gup.c
index 6340cef6798a..f97480941269 100644
--- a/arch/x86/mm/gup.c
+++ b/arch/x86/mm/gup.c
@@ -247,10 +247,15 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write,
start &= PAGE_MASK;
addr = start;
len = (unsigned long) nr_pages << PAGE_SH... |
feaa0457ec8351cae855edc9a3052ac49322538e | Analyze and fix the following issue in the Linux kernel code: x86: ds.c fix invalid assignment | Problem Details:
Fixes the type mixups that cause the following sparse warnings:
CHECK arch/x86/kernel/ds.c
arch/x86/kernel/ds.c:549:19: warning: incorrect type in argument 2 (invalid types)
arch/x86/kernel/ds.c:549:19: expected bad type enum bts_field field
arch/x86/kernel/ds.c:549:19: got int
arch/x86/kern... | ```diff
diff --git a/arch/x86/kernel/ds.c b/arch/x86/kernel/ds.c
index 48bfe1386038..ef42a038f1a6 100644
--- a/arch/x86/kernel/ds.c
+++ b/arch/x86/kernel/ds.c
@@ -509,15 +509,15 @@ enum bts_field {
bts_escape = ((unsigned long)-1 & ~bts_qual_mask)
};
-static inline unsigned long bts_get(const char *base, enum bts... |
b53109db5e016425b767e8e33669a5f41257e6e5 | Analyze and fix the following issue in the Linux kernel code: ASoC: Fix shadowed variables in twl4030 | Problem Details:
No need to define second copies of mode and format, they're declared
with exactly the same type at the head of the function and there's no
conflict in their use.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> | ```diff
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 4dbb853eef5a..a5062ccd28ee 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -1609,8 +1609,6 @@ static int twl4030_hw_params(struct snd_pcm_substream *substream,
/* If the substream has 4 channel, do the ne... |
3e107603aecf886e1e5bda9dacbd9796eb2a2171 | Analyze and fix the following issue in the Linux kernel code: fat: Fix the removal of opts->fs_dmask | Problem Details:
(ce3b0f8d5c2203301fc87f3aaaed73e5819e2a48: New helper - current_umask())
is removing the opts->fs_dmask, probably it's a cut-and-paste
miss or something.
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> | ```diff
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 304b411cb8bc..8970d8c49bb0 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -966,7 +966,7 @@ static int parse_options(char *options, int is_vfat, int silent, int *debug,
opts->fs_uid = current_uid();
opts->fs_gid = current_gid();
- opts->fs_fmask = cur... |
20f54c490c6547049d880d3666ebb5b24e234e77 | Analyze and fix the following issue in the Linux kernel code: microblaze: remove init_mm | Problem Details:
Alexey removed the definition for init_mm from all architectures
but forgot microblaze, which was only recently added.
This fixes the microblaze build by dropping it there as well.
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Michal Simek <monst... | ```diff
diff --git a/arch/microblaze/kernel/init_task.c b/arch/microblaze/kernel/init_task.c
index 48eb9fb255fa..67da22579b62 100644
--- a/arch/microblaze/kernel/init_task.c
+++ b/arch/microblaze/kernel/init_task.c
@@ -18,8 +18,6 @@
static struct signal_struct init_signals = INIT_SIGNALS(init_signals);
static struc... |
e34e7dbb35474ffc75f639eca64a18a15f4f8688 | Analyze and fix the following issue in the Linux kernel code: kernel-doc: fix param matching for array params | Problem Details:
Fix function actual parameter vs. kernel-doc description matching
so that a warning is not printed when it should not be:
Warning(include/linux/etherdevice.h:199): Excess function parameter 'addr' description in 'is_etherdev_addr'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: S... | ```diff
diff --git a/scripts/kernel-doc b/scripts/kernel-doc
index fde6e3a22e70..ed591e9b7d1d 100755
--- a/scripts/kernel-doc
+++ b/scripts/kernel-doc
@@ -1653,6 +1653,15 @@ sub push_parameter($$$) {
}
}
+ # strip spaces from $param so that it is one continous string
+ # on @parameterlist;
+ # this fixes a proble... |
ac6ca5c86c63dd95acc6a34dff8d33c23b703a37 | Analyze and fix the following issue in the Linux kernel code: kallsyms: fix inverted valid symbol checking | Problem Details:
The previous commit (17b1f0de) introduced a slightly broken consolidation
of the memory text range checking.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> | ```diff
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 3cb57895c9ea..64343cc084b4 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -167,11 +167,11 @@ static int symbol_valid_tr(struct sym_entry *s)
for (i = 0; i < ARRAY_SIZE(text_ranges); ++i) {
tr = &text_ranges[i];
- if (s->addr >= tr->... |
b767b9059fa75a353c9ad6e320ae080fbe15a951 | Analyze and fix the following issue in the Linux kernel code: kbuild: fix build error during make htmldocs | Problem Details:
Fix the following build error when do 'make htmldocs':
DOCPROC Documentation/DocBook/debugobjects.xml
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: WANG Cong <amwang@redhat.co... | ```diff
diff --git a/scripts/basic/docproc.c b/scripts/basic/docproc.c
index 4c9523ef9c00..99ca7a698687 100644
--- a/scripts/basic/docproc.c
+++ b/scripts/basic/docproc.c
@@ -385,7 +385,7 @@ int main(int argc, char *argv[])
if (!srctree)
srctree = getcwd(NULL, 0);
kernsrctree = getenv("KBUILD_SRC");
- if (!kerns... |
39c58f37a10198054c656c28202fb1e6d22fd505 | Analyze and fix the following issue in the Linux kernel code: ide-cd: prevent null pointer deref via cdrom_newpc_intr | Problem Details:
With 2.6.30, the error handling code in cdrom_newpc_intr was changed
to deal with partial request failures by normally completing the 'good'
parts of a request and only 'error' the last (and presumably,
incompletely transferred) bio associated with a particular
request. In order to do this, ide_complet... | ```diff
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 0b7645b13df1..4a19686fcfe9 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -667,7 +667,7 @@ out_end:
rq->errors = -EIO;
}
- if (uptodate == 0)
+ if (uptodate == 0 && rq->bio)
ide_cd_error_cmd(drive, cmd);
/* make... |
6be832529a8129c9d90a1d3a78c5d503a710b6fc | Analyze and fix the following issue in the Linux kernel code: usbnet cdc_subset: fix issues talking to PXA gadgets | Problem Details:
The host-side CDC subset driver is binding more specifically
than it should ... only to PXA 210/25x/26x Linux-USB gadgets.
Loosen that restriction to match the gadget driver driver.
This will various PXA 27x and PXA 3xx devices happier when
talking to Linux hosts, potentially others.
Signed-off-by: D... | ```diff
diff --git a/drivers/net/usb/cdc_subset.c b/drivers/net/usb/cdc_subset.c
index c66b9c324f54..ca39ace0b0eb 100644
--- a/drivers/net/usb/cdc_subset.c
+++ b/drivers/net/usb/cdc_subset.c
@@ -307,9 +307,10 @@ static const struct usb_device_id products [] = {
USB_DEVICE (0x1286, 0x8001), // "blob" bootloader
.... |
73e42897e8e5619eacb787d2ce69be12f47cfc21 | Analyze and fix the following issue in the Linux kernel code: ipv4: fix NULL pointer + success return in route lookup path | Problem Details:
Don't drop route if we're not caching
I recently got a report of an oops on a route lookup. Maxime was
testing what would happen if route caching was turned off (doing so by setting
making rt_caching always return 0), and found that it triggered an oops. I
looked at it and found that the problem s... | ```diff
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index cd76b3cb7092..65b3a8b11a6c 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1085,8 +1085,16 @@ restart:
now = jiffies;
if (!rt_caching(dev_net(rt->u.dst.dev))) {
- rt_drop(rt);
- return 0;
+ /*
+ * If we're not caching, just tell the call... |
7b768f07dce463a054c9dd84862d15ccc3d2b712 | Analyze and fix the following issue in the Linux kernel code: ACPI: pdc init related memory leak with physical CPU hotplug | Problem Details:
arch_acpi_processor_cleanup_pdc() in x86 and ia64 results in memory allocated
for _PDC objects that is never freed and will cause memory leak in case of
physical CPU remove and add. Patch fixes the memory leak by freeing the
objects soon after _PDC is evaluated.
Reported-by: Bjorn Helgaas <bjorn.helga... | ```diff
diff --git a/arch/ia64/kernel/acpi-processor.c b/arch/ia64/kernel/acpi-processor.c
index cbe6cee5a550..dbda7bde6112 100644
--- a/arch/ia64/kernel/acpi-processor.c
+++ b/arch/ia64/kernel/acpi-processor.c
@@ -71,3 +71,15 @@ void arch_acpi_processor_init_pdc(struct acpi_processor *pr)
}
EXPORT_SYMBOL(arch_acpi... |
c85a17e22695969aa24a7ffa40cf26d6e6fcfd50 | Analyze and fix the following issue in the Linux kernel code: tracing/urgent: fix unbalanced ftrace_start_up | Problem Details:
Perfcounter reports the following stats for a wide system
profiling:
#
# (2364 samples)
#
# Overhead Symbol
# ........ ......
#
15.40% [k] mwait_idle_with_hints
8.29% [k] read_hpet
5.75% [k] ftrace_caller
3.60% [k] ftrace_call
[...]
This snapshot has been taken whi... | ```diff
diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
index c9a0b7df44ff..90f134764837 100644
--- a/kernel/trace/trace_functions.c
+++ b/kernel/trace/trace_functions.c
@@ -193,9 +193,11 @@ static void tracing_start_function_trace(void)
static void tracing_stop_function_trace(void)
{
f... |
fbe2b31b4b6dfa790cbc88e00631f3112c4fc54e | Analyze and fix the following issue in the Linux kernel code: ACPI: pci_root: check _CRS, then _BBN for downstream bus number | Problem Details:
To find a host bridge's downstream bus number, we currently look at _BBN
first. If _BBN returns a bus number we've already seen, we conclude that
_BBN was wrong and look for a bus number in _CRS.
However, the spec[1] (figure 5-5 and the example in sec 9.12.1) and an ACPI
FAQ[2] suggest that the OS sh... | ```diff
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index 196f97d00956..a8b250783937 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -365,12 +365,12 @@ static int __devinit acpi_pci_root_add(struct acpi_device *device)
{
int result = 0;
struct acpi_pci_root *root = NULL;
- ... |
a26c4463f695a2ef7818fd4dadf300f2c77c920e | Analyze and fix the following issue in the Linux kernel code: MAINTAINERS: ieee802154 fix pattern typo | Problem Details:
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Sergey Lapin <slapin@ossfans.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/MAINTAINERS b/MAINTAINERS
index 5f18e8540115..dada6fdd1c15 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2849,7 +2849,7 @@ W: http://apps.sourceforge.net/trac/linux-zigbee
T: git git://git.kernel.org/pub/scm/linux/kernel/git/lumag/lowpan.git
S: Maintained
F: net/ieee802154/
-F: drivers/ieee8012... |
fa451753b6b7eb082531d0b7fc7b2f585a5581e1 | Analyze and fix the following issue in the Linux kernel code: MAINTAINERS: fix Atheros pattern paths | Problem Details:
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Bob Copeland <me@bobcopeland.com>
Cc: "Luis R . Rodriguez" <lrodriguez@atheros.com>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <tor... | ```diff
diff --git a/MAINTAINERS b/MAINTAINERS
index 49eb8f2f705b..14193beed8a9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -946,7 +946,7 @@ M: me@bobcopeland.com
L: linux-wireless@vger.kernel.org
L: ath5k-devel@lists.ath5k.org
S: Maintained
-F: drivers/net/wireless/ath5k/
+F: drivers/net/wireless/ath/ath5k/
AT... |
4b1982896876872d30493cca9477975b62335f39 | Analyze and fix the following issue in the Linux kernel code: fbdev: do not allow VESA modes without compiled-in drivers | Problem Details:
Do not accept VESA modes by the "vga=" kernel parameter if there is no
frame buffer driver compiled-in to handle it.
Also, there is a comment added to the Kconfig description after Werner
Lemberg's suggestion
Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13249
Signed-off-by: Krzysztof Helt <k... | ```diff
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 932ffdbf86d9..d6d65ef85f54 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1122,12 +1122,14 @@ config FB_INTEL
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
- select FB_BOOT_VESA_SUPPORT
+ select FB... |
4390b9e0cfa30c2b1a4d821748d7948fd85356df | Analyze and fix the following issue in the Linux kernel code: dtlk: off by one in {read,write}_tts() | Problem Details:
With a postfix increment retries is incremented beyond DTLK_MAX_RETRIES so
the error message is not displayed correctly.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: James R. Van Zandt <jrv@vanzandt.mv.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds ... | ```diff
diff --git a/drivers/char/dtlk.c b/drivers/char/dtlk.c
index 6b900b297cc6..52e06589821d 100644
--- a/drivers/char/dtlk.c
+++ b/drivers/char/dtlk.c
@@ -571,7 +571,7 @@ static char dtlk_read_tts(void)
portval = inb_p(dtlk_port_tts);
} while ((portval & TTS_READABLE) == 0 &&
retries++ < DTLK_MAX_RETRIES);... |
befca96779b0259ac8fad0183e748a62935c39cb | Analyze and fix the following issue in the Linux kernel code: ptrace: wait_task_zombie: do not account traced sub-threads | Problem Details:
The bug is ancient.
If we trace the sub-thread of our natural child and this sub-thread exits,
we update parent->signal->cxxx fields. But we should not do this until
the whole thread-group exits, otherwise we account this thread (and all
other live threads) twice.
Add the task_detached() check. No ... | ```diff
diff --git a/kernel/exit.c b/kernel/exit.c
index 13ae64001fec..628d41f0dd54 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1197,8 +1197,11 @@ static int wait_task_zombie(struct wait_opts *wo, struct task_struct *p)
}
traced = ptrace_reparented(p);
-
- if (likely(!traced)) {
+ /*
+ * It can be ptraced... |
9effb959dee0919991362541048479d94bd1f6e0 | Analyze and fix the following issue in the Linux kernel code: spi_mpc83xx: fix checkpatch issues | Problem Details:
Checkpatch is spitting errors when seeing the rename patch, so fix the
errors prior to moving.
Following errors and warnings were fixed:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#1027: FILE: drivers/spi/spi_mpc8xxx.c:37:
+#include <asm/io.h>
ERROR: "foo * bar" should be "... | ```diff
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index 6e0232e65a38..273940d3938d 100644
--- a/drivers/spi/spi_mpc83xx.c
+++ b/drivers/spi/spi_mpc83xx.c
@@ -17,6 +17,7 @@
#include <linux/bug.h>
#include <linux/errno.h>
#include <linux/err.h>
+#include <linux/io.h>
#include <linux/completio... |
fd8a11e100b463811f41266ea3880c830f3359ea | Analyze and fix the following issue in the Linux kernel code: spi_mpc83xx: quieten down the "Requested speed is too low" message | Problem Details:
When a platform is running at high frequencies it's not always possible to
scale-down a frequency to a requested value, and using mmc_spi driver this
leads to the following printk flood during card polling:
...
mmc_spi spi32766.0: Requested speed is too low: 400000 Hz. Will use
520828 Hz instead... | ```diff
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index ce61be98e06d..4988230a7e0c 100644
--- a/drivers/spi/spi_mpc83xx.c
+++ b/drivers/spi/spi_mpc83xx.c
@@ -14,6 +14,7 @@
#include <linux/init.h>
#include <linux/types.h>
#include <linux/kernel.h>
+#include <linux/bug.h>
#include <linux/errn... |
f598282f5145036312d90875d0ed5c14b49fd8a7 | Analyze and fix the following issue in the Linux kernel code: PCI: Fix the NIU MSI-X problem in a better way | Problem Details:
The previous MSI-X fix (8d181018532dd709ec1f789e374cda92d7b01ce1) had
three bugs. First, it didn't move the write that disabled the vector.
This led to writing garbage to the MSI-X vector (spotted by Michael
Ellerman). It didn't fix the PCI resume case, and it had a race window
where the device could... | ```diff
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 79e56906c7f1..944e45e4a84f 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -313,22 +313,22 @@ static void __pci_restore_msix_state(struct pci_dev *dev)
if (!dev->msix_enabled)
return;
+ BUG_ON(list_empty(&dev->msi_list));
+ entry = list_e... |
c7a5d70796379e3d51d0c652fbe1634b81d3bbd5 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix build errors | Problem Details:
Some of the comedi drivers need timer.h to build properly, so put it
in the comedidev.h file to fix these errors.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index a54cc3137da5..89af44a788df 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -39,6 +39,7 @@
#include <linux/dma-mapping.h>
#include <linux/uaccess.h>
#include <linux/io.h>
+#in... |
4b6a4856c6b6e3bb7839b15296712627b7a37208 | Analyze and fix the following issue in the Linux kernel code: Staging: udlfb: fix some sparse warnings. | Problem Details:
There are others remaining due to the __iomem namespace of the
framebuffer data pointer.
Cc: Roberto De Ioris <roberto@unbit.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/udlfb/udlfb.c b/drivers/staging/udlfb/udlfb.c
index 45b8ae7882de..08165997f803 100644
--- a/drivers/staging/udlfb/udlfb.c
+++ b/drivers/staging/udlfb/udlfb.c
@@ -422,7 +422,7 @@ copyarea(struct dlfb_data *dev_info, int dx, int dy, int sx, int sy,
return 1;
}
-void dlfb_copyarea... |
6b23e3104d95dd752fcf8b32fbace15f483b6814 | Analyze and fix the following issue in the Linux kernel code: Staging: pata_rdc: fix build warnings | Problem Details:
struct ata_port_info shouldn't be const, so remove that which fixes up
the compiler warnings.
Cc: Kevin Huang <Kevin.Huang@rdc.com.tw>
Cc: Tomy Wang <Tomy.Wang@rdc.com.tw>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/pata_rdc/pata_rdc.c b/drivers/staging/pata_rdc/pata_rdc.c
index c1a18e6b67d7..257e622e2fce 100644
--- a/drivers/staging/pata_rdc/pata_rdc.c
+++ b/drivers/staging/pata_rdc/pata_rdc.c
@@ -942,7 +942,7 @@ static struct scsi_host_template rdc_pata_sht = {
ATA_BMDMA_SHT(DRIVER_NAME),
... |
b079fa27d946cf7382ebcd06148782d62103e51a | Analyze and fix the following issue in the Linux kernel code: Staging: pata_rdc: convert code to work in 2.6.29 | Problem Details:
This fixes build problems in the pata_rdc driver due to api changes in
the libata layer.
Cc: Kevin Huang <Kevin.Huang@rdc.com.tw>
Cc: Tomy Wang <Tomy.Wang@rdc.com.tw>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/pata_rdc/pata_rdc.c b/drivers/staging/pata_rdc/pata_rdc.c
index 657e9971f41c..5bc74ed05328 100644
--- a/drivers/staging/pata_rdc/pata_rdc.c
+++ b/drivers/staging/pata_rdc/pata_rdc.c
@@ -148,7 +148,7 @@ static int __devinit rdc_init_one(
{
//struct device *dev = &pdev->dev;
... |
0d99b6eb851fbea9e31ad23f70c8f9fbefd6e4e8 | Analyze and fix the following issue in the Linux kernel code: Staging: asus_oled: fix build warnings | Problem Details:
This fixes some build warnings in the asus_oled driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 04dde4b82817..9270f5df0204 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -516,7 +516,7 @@ static ssize_t odev_set_picture(struct asus_oled_dev *odev, const char *b... |
04b17c935bb4066bf036b338f46ed253bcf34b70 | Analyze and fix the following issue in the Linux kernel code: Staging: slicoss: fix build warnings | Problem Details:
This fixes some build warnings in the slicoss driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 099912685c98..ed47db5ce5ff 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -1872,7 +1872,6 @@ static int slic_card_download(struct adapter *adapter)
__iomem struct slic_regs *slic... |
b0f434a7e90395b588a38ae706c6c63a23d497e4 | Analyze and fix the following issue in the Linux kernel code: Staging: slicoss: Add missing __devexit_p() | Problem Details:
The remove function uses __devexit, so the .remove assignment needs
__devexit_p() to fix a build error with hotplug disabled.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 6f5d0bff4358..099912685c98 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -4049,7 +4049,7 @@ static struct pci_driver slic_driver = {
.name = DRV_NAME,
.id_table = slic_pci_tbl... |
602bd07313f6b337b7ec0297855a5d4d1743c6f2 | Analyze and fix the following issue in the Linux kernel code: Staging: altpciechdma: fix build warnings | Problem Details:
This fixes some build warnings in the altpciechdma driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/altpciechdma/altpciechdma.c b/drivers/staging/altpciechdma/altpciechdma.c
index ac9728e067d4..3724b8ad4879 100644
--- a/drivers/staging/altpciechdma/altpciechdma.c
+++ b/drivers/staging/altpciechdma/altpciechdma.c
@@ -399,6 +399,7 @@ static inline void ape_chdma_desc_set(struct ape_... |
24f5063d3f1125a75cadacab4609a358c15a96f3 | Analyze and fix the following issue in the Linux kernel code: Staging: altpciechdma: Add missing __devexit_p() | Problem Details:
The remove function uses __devexit, so the .remove assignment needs
__devexit_p() to fix a build error with hotplug disabled.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/altpciechdma/altpciechdma.c b/drivers/staging/altpciechdma/altpciechdma.c
index f5004d3cef63..ac9728e067d4 100644
--- a/drivers/staging/altpciechdma/altpciechdma.c
+++ b/drivers/staging/altpciechdma/altpciechdma.c
@@ -1143,7 +1143,7 @@ static struct pci_driver pci_driver = {
.name... |
afcf462a1fd78cc372aefd9fe352e2dc2f237937 | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix the problem that file_ext->state should be protected by device_lock | Problem Details:
While access file_ext->state, we should use device_lock to protect it. The
original codes miss this in some places.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/heci/heci_init.c b/drivers/staging/heci/heci_init.c
index 427f55d7b262..31fd891c099d 100644
--- a/drivers/staging/heci/heci_init.c
+++ b/drivers/staging/heci/heci_init.c
@@ -998,8 +998,12 @@ int heci_disconnect_host_client(struct iamt_heci_device *dev,
if ((!dev) || (!file_ext))
... |
ad914a3ec5f1b8c4f97a00f94e11bb20f99a901b | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix setting h_is bit in h_csr register | Problem Details:
Host software could issue interrupts to ME firmware, using H_IG bit. While
Setting H_IG bit, host software should preserve all the other bits in H_CSR
unchanged. In the original function which sets H_CSR register, they first read
the register, then set some bits, and write the whole 32bits back to the
... | ```diff
diff --git a/drivers/staging/heci/heci_init.c b/drivers/staging/heci/heci_init.c
index 06ea1967e0e3..427f55d7b262 100644
--- a/drivers/staging/heci/heci_init.c
+++ b/drivers/staging/heci/heci_init.c
@@ -249,7 +249,7 @@ int heci_hw_init(struct iamt_heci_device *dev)
if ((dev->host_hw_state & H_IS) == H_IS) {... |
52b855600c5c16c13b6f288f3536d01c2603e78d | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix typos and add wait after disconnect | Problem Details:
- Fix typo for enum HECI_WRITE.
- Fix timeout issue. If the time period is greater or equal 15s, it's timeout.
- Add 10ms wait time after disconnect, to ensure that hardware is ready.
Otherwise in the next time connection, hardware resource may be busy.
Signed-off-by: Dongxiao Xu <dongxiao.xu@int... | ```diff
diff --git a/drivers/staging/heci/heci_init.c b/drivers/staging/heci/heci_init.c
index a8a0da910cfb..06ea1967e0e3 100644
--- a/drivers/staging/heci/heci_init.c
+++ b/drivers/staging/heci/heci_init.c
@@ -1012,6 +1012,7 @@ int heci_disconnect_host_client(struct iamt_heci_device *dev,
if (dev->host_buffer_is_emp... |
58b25a63a18e88052c8f5f068e68feaac4c6831d | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix softirq safe to unsafe spinlock issue | Problem Details:
When spinlock is nested, and the outside one is spin_lock_bh, the inner
spinlock should also be spin_lock_bh, otherwise it will bring softirq-safe
to softirq-unsafe lock conversion.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/heci/heci_main.c b/drivers/staging/heci/heci_main.c
index fb97428b457c..4b02641aaa9b 100644
--- a/drivers/staging/heci/heci_main.c
+++ b/drivers/staging/heci/heci_main.c
@@ -955,10 +955,10 @@ static ssize_t heci_read(struct file *file, char __user *ubuf,
}
err = heci_start_rea... |
72abd2288318a35fbf225b93a31d4623e3b8c872 | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix spinlock order mess of device_lock and read_io_lock | Problem Details:
In orginal code, the device_lock and read_io_lock is mess order when nested,
which may bring dead lock. This patch unify the spinlock order of device_lock
and read_io_lock. First acquire device_lock, then read_io_lock.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Greg Kroah-Hartma... | ```diff
diff --git a/drivers/staging/heci/heci_main.c b/drivers/staging/heci/heci_main.c
index daf1107cb8e0..fb97428b457c 100644
--- a/drivers/staging/heci/heci_main.c
+++ b/drivers/staging/heci/heci_main.c
@@ -954,8 +954,8 @@ static ssize_t heci_read(struct file *file, char __user *ubuf,
goto out;
}
- spin_lock... |
171df6381962b463e5aa8ff936eb3f995a56ce9e | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix wrong order of device_lock and file_lock | Problem Details:
When the two locks are nested, the code should always first acquire file_lock,
and then acquire device_lock in order not to generate dead-lock race.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/heci/io_heci.c b/drivers/staging/heci/io_heci.c
index 619eeed87ea2..53dc770727d8 100644
--- a/drivers/staging/heci/io_heci.c
+++ b/drivers/staging/heci/io_heci.c
@@ -277,14 +277,16 @@ int heci_ioctl_connect_client(struct iamt_heci_device *dev, int if_num,
}
goto end;
}
+ spi... |
36e844671cbdace27f0462a46cedde0a4d6b1001 | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix userspace pointer mess | Problem Details:
Fix userspace pointer mess.
- In memcmp(), dest and src pointer should be both in kernel space.
- Add (void __user *) modification before userspace pointer.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/heci/heci_main.c b/drivers/staging/heci/heci_main.c
index 00e44c781428..daf1107cb8e0 100644
--- a/drivers/staging/heci/heci_main.c
+++ b/drivers/staging/heci/heci_main.c
@@ -1140,9 +1140,12 @@ static ssize_t heci_write(struct file *file, const char __user *ubuf,
spin_lock(&file_ex... |
7a80bfcd1f4bac61d586d3551f74215ff02e9cba | Analyze and fix the following issue in the Linux kernel code: Staging: rspiusb: copy_to/from_user related fixes | Problem Details:
The patch does copy_to/from_user related fixes
*) __copy_from/to_user is enough for user space data buffer checked by access_ok.
*) return -EFAULT if __copy_from/to_user fails.
*) Do not use memcpy to copy from user space.
Signed-off-by: Vibi Sreenivasan <vibi_sreenivasan@cms.com>
Signed-off-by: Greg... | ```diff
diff --git a/drivers/staging/rspiusb/rspiusb.c b/drivers/staging/rspiusb/rspiusb.c
index ebdbe41fbcc3..1cdfe69585ea 100644
--- a/drivers/staging/rspiusb/rspiusb.c
+++ b/drivers/staging/rspiusb/rspiusb.c
@@ -217,8 +217,10 @@ static int pixis_io(struct ioctl_struct *ctrl, struct device_extension *pdx,
dbg("numb... |
8d2db5169d103d03646e7b7e93798739b2290d22 | Analyze and fix the following issue in the Linux kernel code: Staging: rspiusb: Fix a bunch of warnings. | Problem Details:
The patch fixes the following warnings.
drivers/staging/rspiusb/rspiusb.c: In function ‘pixel_data’:
drivers/staging/rspiusb/rspiusb.c:267: warning: passing argument 1 of ‘SetPageDirty’ makes
pointer from integer without a cast
drivers/staging/rspiusb/rspiusb.c: In function ‘UnMapUserBuffer’:
drivers/... | ```diff
diff --git a/drivers/staging/rspiusb/rspiusb.c b/drivers/staging/rspiusb/rspiusb.c
index 090bf41ebcd2..ebdbe41fbcc3 100644
--- a/drivers/staging/rspiusb/rspiusb.c
+++ b/drivers/staging/rspiusb/rspiusb.c
@@ -264,7 +264,7 @@ static int pixel_data(struct ioctl_struct *ctrl, struct device_extension *pdx)
pdx->bul... |
f82ebea5c8ef9ed9378fc6402051a4860a805397 | Analyze and fix the following issue in the Linux kernel code: staging: p9auth: prevent some oopses and memory leaks | Problem Details:
Before all testcases, do:
mknod /dev/caphash c 253 0
mknod /dev/capuse c 253 1
This patch does the following:
1. caphash write of > CAP_NODE_SIZE bytes overruns node_ptr->data
(test: cat /etc/mime.types > /dev/caphash)
2. make sure we don't dereference a NULL cap_devices[0].head
(test: cat serge@... | ```diff
diff --git a/drivers/staging/p9auth/p9auth.c b/drivers/staging/p9auth/p9auth.c
index 3cac89b26faf..9111dcba37a1 100644
--- a/drivers/staging/p9auth/p9auth.c
+++ b/drivers/staging/p9auth/p9auth.c
@@ -180,8 +180,12 @@ static ssize_t cap_write(struct file *filp, const char __user *buf,
if (down_interruptible(&de... |
0f51010e87636ed93338f4d9a987a466ca0d6969 | Analyze and fix the following issue in the Linux kernel code: Staging: oslec bug fix | Problem Details:
I have just had a bug fix submitted for Oslec which I have applied to
Oslec SVN. The bug can potentially stops the echo canceller adapting
after a few seconds, although it hasn't caused many problems in
practice.
Signed-off-by: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@s... | ```diff
diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
index 6d7217e1bd06..79d15c65bfe4 100644
--- a/drivers/staging/echo/echo.c
+++ b/drivers/staging/echo/echo.c
@@ -395,7 +395,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx)
old = (int)ec->fir_state.history[ec->fir_... |
315d7fa9d60fb402b1331fe5e83d9295f4c6cf0f | Analyze and fix the following issue in the Linux kernel code: staging: wis-sony-tuner.c: fix &&/|| error | Problem Details:
Fix &&/|| typo
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/go7007/wis-sony-tuner.c b/drivers/staging/go7007/wis-sony-tuner.c
index c965c601ac90..086896cec49b 100644
--- a/drivers/staging/go7007/wis-sony-tuner.c
+++ b/drivers/staging/go7007/wis-sony-tuner.c
@@ -370,7 +370,7 @@ static int set_if(struct i2c_client *client)
i2c_transfer(clien... |
36dbd40139b5adcd60a62be10b6bf83289d79ea4 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8192su: fix build warnings | Problem Details:
This fixes some build warnings in the rtl8192su driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c
index 118dfe1c977f..50810c18aff7 100644
--- a/drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c
+++ b/drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c
@@ -731,7 +731,7 @@ int ieee80211_wx_set_... |
d01c3c8e13f7be29fae5b55bbd4a01d6f84d3d5e | Analyze and fix the following issue in the Linux kernel code: Staging: cpc-usb: fix build warnings | Problem Details:
This fixes some build warnings in the cpc-usb driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cpc-usb/cpc-usb_drv.c b/drivers/staging/cpc-usb/cpc-usb_drv.c
index f13db7264e35..9bf3f98c6825 100644
--- a/drivers/staging/cpc-usb/cpc-usb_drv.c
+++ b/drivers/staging/cpc-usb/cpc-usb_drv.c
@@ -1032,7 +1032,7 @@ static int cpcusb_probe(struct usb_interface *interface,
goto error;... |
5e23f3e9626b1bdc425f6351d10be28a57aae9c8 | Analyze and fix the following issue in the Linux kernel code: Staging: cpc-usb: fix printk format warnings | Problem Details:
Fix this warnings:
cpc-usb_drv.c:478: warning: format '%d' expects type 'int',
but argument 4 has type 'size_t'
cpc-usb_drv.c:1034: warning: format '%d' expects type 'int',
but argument 3 has type 'long unsigned int'
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroa... | ```diff
diff --git a/drivers/staging/cpc-usb/cpc-usb_drv.c b/drivers/staging/cpc-usb/cpc-usb_drv.c
index 52f0f0eebb51..f13db7264e35 100644
--- a/drivers/staging/cpc-usb/cpc-usb_drv.c
+++ b/drivers/staging/cpc-usb/cpc-usb_drv.c
@@ -475,7 +475,7 @@ static ssize_t cpcusb_write(struct file *file, const char *buffer,
unsi... |
c32a4e066c42b1b4bd7c472814bce09f16ff8202 | Analyze and fix the following issue in the Linux kernel code: Staging: cpc-usb: depends on PROC_FS | Problem Details:
Fix this build error when PROC_FS is not enabled:
cpc-usb_drv.c:61:2: error: #error "PROCFS needed"
cpc-usb_drv.c:1159: error: implicit declaration of function 'proc_mkdir'
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cpc-usb/Kconfig b/drivers/staging/cpc-usb/Kconfig
index 00924ce81956..2be0bc9c39d0 100644
--- a/drivers/staging/cpc-usb/Kconfig
+++ b/drivers/staging/cpc-usb/Kconfig
@@ -1,4 +1,4 @@
config USB_CPC
tristate "CPC CAN USB driver"
- depends on USB
+ depends on USB && PROC_FS
defaul... |
240f3ee0c864a19fa74fb9f049f53e63e77c3182 | Analyze and fix the following issue in the Linux kernel code: Staging: cpc-usb: fix checkpatch warnings in sja2m16c.h | Problem Details:
This fixes most of the coding style issues in sja2m16c.h
Cc: Sebastian Haas <haas@ems-wuensche.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cpc-usb/sja2m16c.h b/drivers/staging/cpc-usb/sja2m16c.h
index bd453e270559..654bd3fc91dc 100644
--- a/drivers/staging/cpc-usb/sja2m16c.h
+++ b/drivers/staging/cpc-usb/sja2m16c.h
@@ -1,41 +1,41 @@
-#ifndef SJA2M16C_H
-#define SJA2M16C_H
+#ifndef _SJA2M16C_H
+#define _SJA2M16C_H
#i... |
0f064b52ce0f837791924b252ae59476ef26de69 | Analyze and fix the following issue in the Linux kernel code: Staging: cpc-usb: fix up checkpatch errors in cpc-usb_drv.c | Problem Details:
This resolves the checkpatch errors in cpc-usb_drv.c
Cc: Sebastian Haas <haas@ems-wuensche.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cpc-usb/cpc-usb_drv.c b/drivers/staging/cpc-usb/cpc-usb_drv.c
index b8ef701a2bc5..14aca399fc4c 100644
--- a/drivers/staging/cpc-usb/cpc-usb_drv.c
+++ b/drivers/staging/cpc-usb/cpc-usb_drv.c
@@ -30,11 +30,6 @@
#include <linux/version.h>
-/* usb_kill_urb has been introduced in ke... |
84a209d01c58d74f291efc82e313b132ecec7be0 | Analyze and fix the following issue in the Linux kernel code: Staging: cpc-usb: fix some build problems in the driver | Problem Details:
It will now build properly on the latest kernel tree.
Cc: Sebastian Haas <haas@ems-wuensche.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cpc-usb/cpc-usb_drv.c b/drivers/staging/cpc-usb/cpc-usb_drv.c
index a08c6655b86b..b8ef701a2bc5 100644
--- a/drivers/staging/cpc-usb/cpc-usb_drv.c
+++ b/drivers/staging/cpc-usb/cpc-usb_drv.c
@@ -49,7 +49,7 @@
/* Version Information */
#define DRIVER_AUTHOR "Sebastian Haas <haas@em... |
d604fc995e7d222b043b33676f64e8b855fa596f | Analyze and fix the following issue in the Linux kernel code: Staging: android: fix Kconfig issues | Problem Details:
Wrap all ANDROID config items with a #if to keep from asking if you want
specific Android drivers even if you say N to CONFIG_ANDROID
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 178450876314..247194992374 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -6,6 +6,8 @@ config ANDROID
---help---
Enable support for various drivers needed on the Android platform
+... |
e93daf9f8d94b9dc31a66e3ae76d7fdf80b1cb7d | Analyze and fix the following issue in the Linux kernel code: Staging: android: ram_console: fix up remaining checkpatch warnings | Problem Details:
This cleans up the last of the checkpatch warnings in the android
ram_console driver.
Cc: San Mehat <san@android.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/android/ram_console.c b/drivers/staging/android/ram_console.c
index 3375c1cce2b3..8f18a59744cd 100644
--- a/drivers/staging/android/ram_console.c
+++ b/drivers/staging/android/ram_console.c
@@ -20,7 +20,7 @@
#include <linux/proc_fs.h>
#include <linux/string.h>
#include <linux/uac... |
66b20608c9e98a0a29806bd47b30565927fdbbd8 | Analyze and fix the following issue in the Linux kernel code: Staging: android: logger: fix up remaining checkpatch warnings | Problem Details:
This cleans up the last of the checkpatch warnings in the android logger
driver.
Cc: San Mehat <san@android.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index ab32003ecd0b..6c10b456c6cc 100644
--- a/drivers/staging/android/logger.c
+++ b/drivers/staging/android/logger.c
@@ -35,7 +35,7 @@
* mutex 'mutex'.
*/
struct logger_log {
- unsigned char * buffer; /* the ring buffer itse... |
1dbb5765acc7a6fe4bc1957c001037cc9d02ae03 | Analyze and fix the following issue in the Linux kernel code: Staging: android: lowmemorykiller: fix up remaining checkpatch warnings | Problem Details:
This cleans up the last of the checkpatch warnings in the android
lowmemorykiller driver.
Cc: San Mehat <san@android.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index cba3b91d728e..fe72240f5a9e 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -34,18 +34,24 @@ static int lowmem_adj[6] = {
};
static int lowmem_adj_s... |
5d14a573a4da521d4ed7acd0c7d8a975887b2dd2 | Analyze and fix the following issue in the Linux kernel code: Staging: android: lowmemorykiller: fix possible android low memory killer NULL pointer | Problem Details:
get_mm_rss() atomically dereferences the actual without checking for a
NULL pointer, which is possible since task_lock() is not held.
Cc: San Mehat <san@android.com>
Cc: Arve Hjønnevåg <arve@android.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse... | ```diff
diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index f61333b96025..cba3b91d728e 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -92,12 +92,18 @@ static int lowmem_shrink(int nr_to_scan, gfp_t gfp_mask)
... |
be2e10710b1c330d25e66724ef10b8aabdae4a83 | Analyze and fix the following issue in the Linux kernel code: Staging: rt2870: fix build warnings | Problem Details:
This fixes some build warnings in the rt2870 driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2870/common/2870_rtmp_init.c b/drivers/staging/rt2870/common/2870_rtmp_init.c
index 9ed818d442ff..0f4c8af97e47 100644
--- a/drivers/staging/rt2870/common/2870_rtmp_init.c
+++ b/drivers/staging/rt2870/common/2870_rtmp_init.c
@@ -763,7 +763,7 @@ NDIS_STATUS CreateThreads(
// Crea... |
f991a65c0cb8eaf855404a0e6c753053de08cdda | Analyze and fix the following issue in the Linux kernel code: staging: rtlxxxx: off by one in AsicSendCommandToMcu() and NDIS_STATUS NICLoadFirmware() | Problem Details:
With a postfix increment i/Index is incremented beyond 100/1000 so the
message will be displayed too soon.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/common/mlme.c b/drivers/staging/rt2860/common/mlme.c
index e9e69c539e6f..bb6fccbdca41 100644
--- a/drivers/staging/rt2860/common/mlme.c
+++ b/drivers/staging/rt2860/common/mlme.c
@@ -7866,7 +7866,7 @@ BOOLEAN AsicSendCommandToMcu(
RTMPusecDelay(2);
} while(i++ < 100);
... |
8d72f98abbabddd5785a668e0d24db3e739f78b4 | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix for driver RT2860 to be able to connect to WPA2 networks | Problem Details:
Hi
patch to change a line in the cmm_wpa.c file for the rt2860 driver so it
can connect to WPA2 networks with TKIP & AES encryption
Signed-off-by: Bryan Stephenson <acreda1234@tiscali.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/common/cmm_wpa.c b/drivers/staging/rt2860/common/cmm_wpa.c
index d467f5338c45..bda69e76867e 100644
--- a/drivers/staging/rt2860/common/cmm_wpa.c
+++ b/drivers/staging/rt2860/common/cmm_wpa.c
@@ -625,7 +625,7 @@ VOID RTMPMakeRSNIE(
UCHAR PrimaryRsnie;
BOOLEAN bMixCipher ... |
1611a52c395e6036725104af3a74a0cef8ea42b8 | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: p80211wext.c: problem with IW_ENCODE_ALG_WEP | Problem Details:
The expression !(ext->alg & IW_ENCODE_ALG_WEP) appears to be incorrect,
because there are several possible values for ext->alg that give 1 when
bit-anded with IW_ENCODE_ALG_WEP. Therefore Richard Kennedy suggested to
rewrite the code with !=
Added \n at the end of the debug string as well.
Signed-of... | ```diff
diff --git a/drivers/staging/wlan-ng/p80211wext.c b/drivers/staging/wlan-ng/p80211wext.c
index 3a96fce7c22e..e73123b26df7 100644
--- a/drivers/staging/wlan-ng/p80211wext.c
+++ b/drivers/staging/wlan-ng/p80211wext.c
@@ -1487,8 +1487,8 @@ static int p80211wext_set_encodeext(struct net_device *dev,
}
if (ext... |
f2b50b40d1241b443da43fa66ae53bae93df910a | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: Change KERN_DEBUG or pr_debug to match orig driver | Problem Details:
Change uses of KERN_DEBUG over to pr_debug to match original driver
where messages are only needed during driver development.
Signed-off-by: Karl Relton <karllinuxtest.relton@ntlworld.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6790bc5efe5b..be297b9cac3e 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1174,7 +1174,7 @@ int hfa384x_cmd_download(hfa384x_t *hw, u16 mode, u16 lowaddr,
int re... |
a39ee671746b6483c6a259fef755a4a3e475e3e4 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: more simplify hal_init_hardware() error handling | Problem Details:
Impact: fix, cleanup
If initialization in hal_init_hardware() fails, we call hal_halt() to
clean up and release resource. However, hal_halt() will attempt to
call del_timer_sync() on ->LEDTimer on "stage 3" although it's not
initialized at that point. Fix that up by simplifying error handling
logic in... | ```diff
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index 4ce2e5af9591..fc2566afbd21 100644
--- a/drivers/staging/winbond/wbusb.c
+++ b/drivers/staging/winbond/wbusb.c
@@ -488,15 +488,15 @@ static int hal_init_hardware(struct ieee80211_hw *hw)
pHwData->InitialResource = 1;
if (!... |
5355d8cac2a036471c1e739ee5aa1514973ed114 | Analyze and fix the following issue in the Linux kernel code: Staging: fix operator precedence errors | Problem Details:
`!' has a higher precedence than `&' and `|' has a higher precedence than `?'
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
index 353cdaf03ed3..19465c1b53c3 100644
--- a/drivers/staging/comedi/drivers/pcl816.c
+++ b/drivers/staging/comedi/drivers/pcl816.c
@@ -482,7 +482,7 @@ static int pcl816_ai_cmdtest(struct comedi_device *dev, struct co... |
a970ff45c9228472fd9c3ea62357ea7a9cbc8ce3 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Add missing __devexit_p() | Problem Details:
The remove function uses __devexit, so the .remove assignment needs
__devexit_p() to fix a build error with hotplug disabled.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index f7306da7d3b6..3a0dac962e4d 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -4516,7 +4516,7 @@ static struct pci_driver sxg_driver = {
.name = sxg_driver_name,
.id_table = sxg_pci_tbl,
.probe = sxg_entry_prob... |
01c2c2348f1c1bfaf564ed93226280970d4cb6df | Analyze and fix the following issue in the Linux kernel code: Staging: meilhaus: fix build warnings | Problem Details:
This fixes some build warnings in the meilhaus driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/meilhaus/memain.c b/drivers/staging/meilhaus/memain.c
index 0dc2878931bb..c4908549192f 100644
--- a/drivers/staging/meilhaus/memain.c
+++ b/drivers/staging/meilhaus/memain.c
@@ -520,7 +520,7 @@ static int __devinit me_probe_pci(struct pci_dev *dev,
if ((constructor =
(me_... |
f94338f64dff31c6aadd37204fa27c1c5918dde9 | Analyze and fix the following issue in the Linux kernel code: Staging: agnx: fix build warnings | Problem Details:
This fixes some build warnings in the agnx driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/agnx/pci.c b/drivers/staging/agnx/pci.c
index 0df7d43c4c32..1fe987065257 100644
--- a/drivers/staging/agnx/pci.c
+++ b/drivers/staging/agnx/pci.c
@@ -58,15 +58,17 @@ static inline void agnx_interrupt_ack(struct agnx_priv *priv, u32 *reason)
*reason |= AGNX_STAT_TXM;
}
}
-/*... |
5e436d09cec1eae3b3c17580c682cf1a42e595f8 | Analyze and fix the following issue in the Linux kernel code: staging: agnx, fix bssid compiler warnings | Problem Details:
conf->bssid is const. Propagate const to not get compiler warnings:
agnx/pci.c: In function ‘agnx_config_interface’:
agnx/pci.c:319: warning: passing argument 2 of ‘agnx_set_bssid’ discards qualifiers from pointer target type
agnx/pci.c:321: warning: passing argument 2 of ‘hash_write’ discards qualifie... | ```diff
diff --git a/drivers/staging/agnx/phy.c b/drivers/staging/agnx/phy.c
index 2be63312b727..ec1ca86fa0c4 100644
--- a/drivers/staging/agnx/phy.c
+++ b/drivers/staging/agnx/phy.c
@@ -118,7 +118,7 @@ static void mac_address_set(struct agnx_priv *priv)
iowrite32(reg, ctl + AGNX_RXM_MACLO);
}
-static void receive... |
8af6caf5d37aaa56911c15f9a7386fe93ff01f7e | Analyze and fix the following issue in the Linux kernel code: staging: agnx, fix fail paths in probe | Problem Details:
Return error on fail paths instead of 0.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/agnx/pci.c b/drivers/staging/agnx/pci.c
index 3aef9aab47e5..e5bf9a2a7680 100644
--- a/drivers/staging/agnx/pci.c
+++ b/drivers/staging/agnx/pci.c
@@ -473,6 +473,7 @@ static int __devinit agnx_pci_probe(struct pci_dev *pdev,
if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32)) ||
pci... |
3a5e32ddcb04d7a2bed86323ca22da51d3a810bd | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: cb_pcidas.c: Fix build warning (type mismatch) | Problem Details:
spin_lock_irqsave expects flags to be unsigned long, not unsigned int.
Signed-off-by: Gerard Lledo <gerard.lledo@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c
index 28212ad6461b..702de1571223 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas.c
@@ -1593,7 +1593,7 @@ static void handle_ao_interrupt(struct comedi_devic... |
efe8d60a923ddd00de394381cb30aab5114b71a4 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: usbdux: buffer overflow error handling | Problem Details:
These changes guarantee that the URBs are not resubmitted in case of a
comedi buffer overflow. Otherwise this runs in the background even when
the userspace program has terminated.
From: Bernd Porr <BerndPorr@f2s.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index eea7dbdde0be..171a6f2ff74f 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -509,14 +509,19 @@ static void usbduxsub_ai_IsocIrq(struct urb *urb)
for (i = 0;... |
f764df88f86c8db669bd7bfac230b9d2689ae322 | Analyze and fix the following issue in the Linux kernel code: staging: comedi: fix missing parentheses | Problem Details:
Add missing parentheses.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
index 607c71744bfc..039a77a66451 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -460,9 +460,9 @@ static int pcl818_ao_insn_write(struct comedi_device *dev, struct... |
c3e2354e3720d51afada9ac6923517c5444d7cbb | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: data.c should include delay.h | Problem Details:
Fix this build error:
.../data.c:86: error: implicit declaration of function 'udelay'
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/kcomedilib/data.c b/drivers/staging/comedi/kcomedilib/data.c
index 3e5fe2c87092..d808556460aa 100644
--- a/drivers/staging/comedi/kcomedilib/data.c
+++ b/drivers/staging/comedi/kcomedilib/data.c
@@ -26,6 +26,7 @@
#include "../comedidev.h"
#include <linux/string.h>
+#inclu... |
de4545cdfd9f3521b3402c0228b8d4ecdd97f7ec | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: comedi_test.c should include timer.h | Problem Details:
Fix this build error:
.../comedi_test.c:82: error: field timer has incomplete type
.../comedi_test.c: In function waveform_ai_interrupt:
.../comedi_test.c:188: error: implicit declaration of function mod_timer
.../comedi_test.c:188: error: jiffies undeclared (first use in this function)
Signed-off-by:... | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c
index 93ed1a0ae126..9b8cf62973be 100644
--- a/drivers/staging/comedi/drivers/comedi_test.c
+++ b/drivers/staging/comedi/drivers/comedi_test.c
@@ -55,6 +55,7 @@ zero volts).
#include <asm/div64.h>
#includ... |
dc7423c885dc1396710e18770b3c4ab3bdb71805 | Analyze and fix the following issue in the Linux kernel code: staging: comedi: fix pcmcia build breakage | Problem Details:
Add PCCARD dependancy to the PCMCIA drivers to fix build breakage.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 86991f657900..af723cb9d08f 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drivers/staging/comedi/Kconfig
@@ -22,10 +22,10 @@ config COMEDI_PCI_DRIVERS
config COMEDI_PCMCIA_DRIVERS
tristate "Comedi PCMCIA drivers"
- depend... |
b4918808debc62daaa189ecbdfca489c00b1061d | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: more fix the way structs are initialized. | Problem Details:
Change from the foo: bar format to the .foo = bar format.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
index 83af347934be..0e765641838b 100644
--- a/drivers/staging/comedi/drivers/rtd520.c
+++ b/drivers/staging/comedi/drivers/rtd520.c
@@ -278,22 +278,22 @@ struct rtdBoard {
static const struct rtdBoard rtd520Boards[... |
b153d83efb3d0ea15f5e6c7dced98fadc66531de | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: vmk80xx.c: get the driver to build properly | Problem Details:
There have been changes in the comedi core, this fixes the vmk80xx.c
driver to work properly with them, so it now will build properly.
Cc: Manuel Gebele <forensixs@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/vmk80xx.c b/drivers/staging/comedi/drivers/vmk80xx.c
index 64d90a16d830..533b625021ad 100644
--- a/drivers/staging/comedi/drivers/vmk80xx.c
+++ b/drivers/staging/comedi/drivers/vmk80xx.c
@@ -32,7 +32,6 @@ Status: works
*/
#include <linux/kernel.h>
-#include <linux... |
53106ae68acf6eda9593150a25fc44e30fd5ff68 | Analyze and fix the following issue in the Linux kernel code: Staging Comedi: fix spacing around parens | Problem Details:
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 6e13e450dc73..cabbf090f60b 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -198,7 +198,7 @@ int comedi_driver_unregister(struct comedi_driver *driver)
struct comedi_device_file_info ... |
4bde29ed2220c3089e93258e476e3a7f4fc388a1 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Undo stupid commit made 3 months ago | Problem Details:
Undo stupid commit made 3 months ago :
"Fix redefinition of macro comedi_rt_task_context_t".
It wasn't being redefined, it was being defined for RTLinux.
From: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.... | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_rt_timer.c b/drivers/staging/comedi/drivers/comedi_rt_timer.c
index 5d79c545ad75..c19ca8d3fb9e 100644
--- a/drivers/staging/comedi/drivers/comedi_rt_timer.c
+++ b/drivers/staging/comedi/drivers/comedi_rt_timer.c
@@ -104,6 +104,8 @@ static inline RTIME nano2coun... |
a71f18d2a1ca1b3a0e1e46f3c7259829d4d33f47 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: pcl818: Fix option handling for FIFO mode (hopefully!). | Problem Details:
Signed-off-by: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
index 4ab4154242ef..29cc5a5151a6 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -1025,26 +1025,32 @@ static int pcl818_ai_cmd_mode(int mode, struct comedi_device ... |
056d3ce5cfe3544b297e6bc90ffbbb317e7bbbff | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: set PCI and PCMCIA defines | Problem Details:
The comedi drivers are looking for CONFIG_COMEDI_PCI and
CONFIG_COMEDI_PCMCIA, not the current config items. This creates a
define so that things build properly when these options are selected.
Long term goal is to fix up the drivers to not need any defines.
Cc: Frank Mori Hess <fmhess@users.sourcefo... | ```diff
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 414a2cf557b0..753d3ab312c0 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -525,4 +525,17 @@ void comedi_usb_auto_unconfig(struct usb_device *usbdev);
#include "comedi_rt.h"
... |
72a822807272f8bb29a527e7e3c60efc7032a9ba | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix build errors in pcmcia comedi drivers | Problem Details:
This fixes a few minor build errors that were previously undetected in
the comedi pcmcia drivers.
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
index 4be9deffbcfd..7f9e502403c8 100644
--- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
+++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
@@ -37,7 +37,7 @@ This is just a wrapper around the 8255.o dr... |
de15d7fcd6452894e82657fb44b7b93c2afe97a4 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: 'pcmcia_parse_tuple()' now has two arguments, not three. | Problem Details:
This fixes the build error in the cv_das16_cs driver
From: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/cb_das16_cs.c b/drivers/staging/comedi/drivers/cb_das16_cs.c
index 0dd9630cfdfd..e7ba3e4288a1 100644
--- a/drivers/staging/comedi/drivers/cb_das16_cs.c
+++ b/drivers/staging/comedi/drivers/cb_das16_cs.c
@@ -773,7 +773,7 @@ static void das16cs_pcmcia_config(struct pcmc... |
2ce492f5cb8ccb404afff3d29dd6f85dad9bfb01 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Finish removing ni_private typedef | Problem Details:
This fixes compilation of ni_mio_cs.c that was broken.
Signed-off-by: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
index 76def4b9e8fb..dcd44874aaf3 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -278,9 +278,8 @@ static const int ni_irqpin[] =
struct ni_private {
s... |
528da3e9e237059a84a2625e942811cf824a6efd | Analyze and fix the following issue in the Linux kernel code: inotify: inotify_destroy_mark_entry could get called twice | Problem Details:
inotify_destroy_mark_entry could get called twice for the same mark since it
is called directly in inotify_rm_watch and when the mark is being destroyed for
another reason. As an example assume that the file being watched was just
deleted so inotify_destroy_mark_entry would get called from the path
fs... | ```diff
diff --git a/fs/notify/inotify/inotify.h b/fs/notify/inotify/inotify.h
index ea2605a58b8a..f234f3a4c8ca 100644
--- a/fs/notify/inotify/inotify.h
+++ b/fs/notify/inotify/inotify.h
@@ -15,7 +15,8 @@ struct inotify_inode_mark_entry {
int wd;
};
-extern void inotify_destroy_mark_entry(struct fsnotify_mark_entr... |
9cffa8d53335d891cc0ecb3824a67118b3ee4b2f | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: Define and use our own u64, s64 etc. definitions | Problem Details:
On 64-bit powerpc, __u64 is defined to be unsigned long rather than
unsigned long long. This causes compiler warnings every time we
print a __u64 value with %Lx.
Rather than changing __u64, we define our own u64 to be unsigned long
long on all architectures, and similarly s64 as signed long long.
For... | ```diff
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 672c5f069c6e..36d7eef49913 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -290,6 +290,7 @@ LIB_FILE=libperf.a
LIB_H += ../../include/linux/perf_counter.h
LIB_H += perf.h
+LIB_H += types.h
LIB_H += util/list.h
LIB_H += util/rbtree.... |
a97f4424fb4cddecf9b13c9b0e3f79924b624a7f | Analyze and fix the following issue in the Linux kernel code: cfg80211: validate station settings | Problem Details:
When I disallowed interfering with stations on non-AP interfaces,
I not only forget mesh but also managed interfaces which need
this for the authorized flag. Let's actually validate everything
properly.
This fixes an nl80211 regression introduced by the interfering,
under which wpa_supplicant -Dnl8021... | ```diff
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 304b3d568e07..241bddd0b4f1 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -1687,14 +1687,52 @@ static int nl80211_set_station(struct sk_buff *skb, struct genl_info *info)
if (err)
goto out_rtnl;
- if (dev->ieee80211_p... |
eab0cd493c08632ef10624d0169849c973951c66 | Analyze and fix the following issue in the Linux kernel code: ath5k: fix beacon_int handling | Problem Details:
73ca5203366235f8a43e490767284ba8cfd8c479
(ath5k: remove conf->beacon_int usage)
removed bintval setting from ath5k_config. We need to init the
interval earlier and don't touch it in add_interface anymore.
Otherwise it will be set only once by upper layer through
bss_info_changed but not on second and ... | ```diff
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index fc5ba0e3a681..ea045151f953 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -538,6 +538,7 @@ ath5k_pci_probe(struct pci_dev *pdev,
sc->iobase = mem; /* So we can un... |
488f7e0cdd99e7dc75dbe32d78474c070deadaea | Analyze and fix the following issue in the Linux kernel code: MAINTAINERS: Fix Atheros pattern paths | Problem Details:
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/MAINTAINERS b/MAINTAINERS
index 2cb7566904b1..d8209002fddc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -940,7 +940,7 @@ M: me@bobcopeland.com
L: linux-wireless@vger.kernel.org
L: ath5k-devel@lists.ath5k.org
S: Maintained
-F: drivers/net/wireless/ath5k/
+F: drivers/net/wireless/ath/ath5k/
AT... |
a878417cc576720d3c9ff5399522d06f226bad7d | Analyze and fix the following issue in the Linux kernel code: acer-wmi: fix rfkill conversion | Problem Details:
"rfkill: rewrite" incorrectly reversed
the meaning of 'state' in acer_rfkill_update() when it changed
rfkill_force_state() to rfkill_set_sw_state(). Fix it.
Signed-off-by: Troy Moure <twmoure@szypr.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 09a503e5da6a..be2fd6f91639 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -958,12 +958,12 @@ static void acer_rfkill_update(struct work_struct *ignored)
status = get_u32(&state, ACER_C... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.