id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
4887f7b4ef8926fd8eb79a928d5f3c4ea25263b8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11886): Siano: smscore - fix some new GPIO definitions names | Problem Details:
Fix some definitions' names, in order to emphasize the names
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smscoreapi.h b/drivers/media/dvb/siano/smscoreapi.h
index 03bdc94950fe..f1108c64e895 100644
--- a/drivers/media/dvb/siano/smscoreapi.h
+++ b/drivers/media/dvb/siano/smscoreapi.h
@@ -580,10 +580,10 @@ struct smscore_gpio_config {
#define SMS_GPIO_DIRECTION_OUTPUT 1
u8 Dire... |
bebfa762b171ffcfeeec08f3e677fa9076db6d4c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11824): Siano: smsusb - change exit func debug msg | Problem Details:
Change the debug message of the USB interface driver exit
function.
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smsusb.c b/drivers/media/dvb/siano/smsusb.c
index 81fc85c0891c..37a00e906768 100644
--- a/drivers/media/dvb/siano/smsusb.c
+++ b/drivers/media/dvb/siano/smsusb.c
@@ -554,9 +554,9 @@ int smsusb_module_init(void)
void smsusb_module_exit(void)
{
- sms_debug("");
/* Regula... |
05a073769dbc5f4440d40880a26b76bc8e568c78 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11823): Siano: smsusb - fix typo in module description | Problem Details:
Fix small typo in the module description
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smsusb.c b/drivers/media/dvb/siano/smsusb.c
index 4fa38bd83887..81fc85c0891c 100644
--- a/drivers/media/dvb/siano/smsusb.c
+++ b/drivers/media/dvb/siano/smsusb.c
@@ -562,6 +562,6 @@ void smsusb_module_exit(void)
module_init(smsusb_module_init);
module_exit(smsusb_module_ex... |
5d2387e3cae1e70febc1bd805f248d6e13cb254f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11822): Siano: smscore - bug fix at get_device_mode | Problem Details:
Fix bug that cause error log to echo also if success
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smscoreapi.c b/drivers/media/dvb/siano/smscoreapi.c
index d400a82daf7d..00a1053e5f98 100644
--- a/drivers/media/dvb/siano/smscoreapi.c
+++ b/drivers/media/dvb/siano/smscoreapi.c
@@ -905,7 +905,7 @@ int smscore_set_device_mode(struct smscore_device_t *coredev, int mode)
co... |
8cc8ef265015cee192fddad3801f09c9c750821b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11821): Siano: smscore - fix isdb-t firmware name | Problem Details:
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smscoreapi.c b/drivers/media/dvb/siano/smscoreapi.c
index e80641afa52a..d400a82daf7d 100644
--- a/drivers/media/dvb/siano/smscoreapi.c
+++ b/drivers/media/dvb/siano/smscoreapi.c
@@ -781,7 +781,7 @@ static char *smscore_fw_lkup[][SMS_NUM_OF_DEVICE_TYPES] = {
/*BDA*/
{"non... |
01abc0b07685137765ec36441adf66f7cfcaf654 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11820): Siano: smscore - fix byte ordering bug | Problem Details:
Fix byte ordering bug.
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smscoreapi.c b/drivers/media/dvb/siano/smscoreapi.c
index 9a5358caec46..e80641afa52a 100644
--- a/drivers/media/dvb/siano/smscoreapi.c
+++ b/drivers/media/dvb/siano/smscoreapi.c
@@ -31,6 +31,7 @@
#include <linux/firmware.h>
#include <linux/wait.h>
+#include <asm/byteorde... |
a9349315f65cd6a16e8fab1f6cf0fd40f379c4db | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11819): Siano: smscore - fix get_common_buffer bug | Problem Details:
get common buffers() should block operation until valid buffer
is avaliable.
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smscoreapi.c b/drivers/media/dvb/siano/smscoreapi.c
index 040a3ff12068..9a5358caec46 100644
--- a/drivers/media/dvb/siano/smscoreapi.c
+++ b/drivers/media/dvb/siano/smscoreapi.c
@@ -30,6 +30,7 @@
#include <linux/io.h>
#include <linux/firmware.h>
+#include <linux/wait.h>
... |
266b95a548c6707eac43ac8caac515348aa44efe | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11817): Siano: smscards - fix wrong firmware assignment | Problem Details:
Remove wrong firmware assignments for Nova, Stellar
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/sms-cards.c b/drivers/media/dvb/siano/sms-cards.c
index c35ff1f3f378..b5dc36dc8034 100644
--- a/drivers/media/dvb/siano/sms-cards.c
+++ b/drivers/media/dvb/siano/sms-cards.c
@@ -31,17 +31,14 @@ static struct sms_board sms_boards[] = {
[SMS1XXX_BOARD_SIANO_STELLAR] = {
.... |
843d0605efa58f6e087cae074b22a2fb77506f6a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11783): Siano: smsdvb - small typo fix ad module author | Problem Details:
Fix type at the module description
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smsdvb.c b/drivers/media/dvb/siano/smsdvb.c
index 881f5c5778f7..92a4dbb9de91 100644
--- a/drivers/media/dvb/siano/smsdvb.c
+++ b/drivers/media/dvb/siano/smsdvb.c
@@ -596,5 +596,5 @@ module_init(smsdvb_module_init);
module_exit(smsdvb_module_exit);
MODULE_DESCRIPTION("SMS... |
2c5582e58ce2982fd64da21907dfad4061fc1f71 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11780): Siano: fix compilation error due to the lack of EXTERNAL_SYMBOL | Problem Details:
Cc: Uri Shkolnik <urishk@yahoo.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smsendian.c b/drivers/media/dvb/siano/smsendian.c
index d79aa051269a..457b6d02ef85 100644
--- a/drivers/media/dvb/siano/smsendian.c
+++ b/drivers/media/dvb/siano/smsendian.c
@@ -49,6 +49,7 @@ void smsendian_handle_tx_message(void *buffer)
}
#endif /* __BIG_ENDIAN */
}
+E... |
8f12d0a4eb7c55837f0104c95c60933dc9c593db | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11778): Siano: smsusb - lost buffers bug fix | Problem Details:
This patch fixes a problem were protocol buffers
have been lost during USB disconnect events.
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smsusb.c b/drivers/media/dvb/siano/smsusb.c
index 1bcd0eff4b16..4fa38bd83887 100644
--- a/drivers/media/dvb/siano/smsusb.c
+++ b/drivers/media/dvb/siano/smsusb.c
@@ -65,14 +65,14 @@ static void smsusb_onresponse(struct urb *urb)
struct smsusb_urb_t *surb = (struct smsusb_u... |
e527579373ab3be045de16a627e43a193fcfacc0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11728): Siano: smsdvb - modify license | Problem Details:
Siano: smsdvb - Fix license to match all other Siano's files
Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/siano/smsdvb.c b/drivers/media/dvb/siano/smsdvb.c
index ba080b95befb..db3346dad8ec 100644
--- a/drivers/media/dvb/siano/smsdvb.c
+++ b/drivers/media/dvb/siano/smsdvb.c
@@ -1,23 +1,23 @@
-/*
- * Driver for the Siano SMS1xxx USB dongle
- *
- * Author: Uri Shkolni
- *
- * Copyrigh... |
7561300a7cea56b61fa28b36d40cdfab22af38bd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11441): cx88-dsp: fixing 64bit math | Problem Details:
cx88-dsp: fixing 64bit math on 32bit kernels
Some gcc versions report the missing of __divdi3
[mchehab.redhat.com: CodingStyle fixes]
Signed-off-by: Miroslav Sustek <sustmidown@centrum.cz>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx88/cx88-dsp.c b/drivers/media/video/cx88/cx88-dsp.c
index a78286e853c3..3e5eaf3fe2a6 100644
--- a/drivers/media/video/cx88/cx88-dsp.c
+++ b/drivers/media/video/cx88/cx88-dsp.c
@@ -22,6 +22,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/jiffies.h>
+... |
511da457340d3b30336f7a6731bad9bbe3ffaf08 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11877): lgdt3305: fix 64bit division in function lgdt3305_set_if | Problem Details:
Signed-off-by: Michael Krufky <kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/lgdt3305.c b/drivers/media/dvb/frontends/lgdt3305.c
index d92d0557a80b..fde8c59700fb 100644
--- a/drivers/media/dvb/frontends/lgdt3305.c
+++ b/drivers/media/dvb/frontends/lgdt3305.c
@@ -19,6 +19,7 @@
*
*/
+#include <asm/div64.h>
#include <linux/dvb/frontend.h>
#i... |
a5beb7b32364a236e833631c3ee5c910cbbfa5bb | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11875): dvb_frontend: fix case where fepriv->exit not reset | Problem Details:
The fact that we now explicitly set fepriv->exit = 1 when the thread is
shutting down exposed an edge case where it was not being reset back to zero
once the thread went away in some cases. This resulted in failures in cases
where the frontend was closed, and then opened O_RDONLY, since in that case
t... | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 1f38dd86f542..f50ca7292a7d 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -657,6 +657,7 @@ restart:
}
fepriv->thread = NULL;
+ fepriv->exit = ... |
57594a586f3353286d64c30f397494a834cac238 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11785): dvb_frontend: fix race condition resulting in dropped tuning commands | Problem Details:
A race condition was detected in the case that putting the tuner to sleep takes
an unusually long period of time, combined with applications that quickly
close/open the dvb frontend.
The kaffeine channel scanner closes and reopens the dvb frontend between each
tuning attempt. If it takes an unusually... | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index ebc78157b9b8..1f38dd86f542 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -543,6 +543,7 @@ restart:
if (kthread_should_stop() || dvb_frontend_i... |
06f837cadbcdedb45f0702cb57c99c404ae921e6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11784): cx88: Fix race condition between cx8800 startup and hald | Problem Details:
A power management fix to properly put the xc5000 into low power mode
revealed a race condition where hald could detect the creation of the device
file and connect to the device while the initial device configuration is
still in progress.
Lock the core structure so that video_release cannot be called ... | ```diff
diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c
index b993d42fe73c..d6d6d13a6a6b 100644
--- a/drivers/media/video/cx88/cx88-video.c
+++ b/drivers/media/video/cx88/cx88-video.c
@@ -926,8 +926,10 @@ static int video_release(struct file *file)
file->private_data = NULL;... |
b02064caebd9b1d73dd29ebb6e75f487c5f0dbc5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11738): patch: s2255drv: urb completion routine fixes | Problem Details:
Error count in read pipe completion corrected.
URB not resubmitted if shutting down.
URB not freed in completion routine if new urb_submit_fails.
(URB is freed on shutdown).
Signed-off-by: Dean Anderson <dean@sensoray.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c
index f08939c1f164..6be845ccc7d7 100644
--- a/drivers/media/video/s2255drv.c
+++ b/drivers/media/video/s2255drv.c
@@ -2281,8 +2281,10 @@ static void read_pipe_completion(struct urb *purb)
return;
}
status = purb->status;
- if (s... |
1fcbcc47d3ebd962f5486697cb85fd216e01cf89 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (12002): uvc: Fix for no return value check of uvc_ctrl_set() which calls mutex_lock_interruptible() | Problem Details:
Fix for no return value check of uvc_ctrl_set() which calls
mutex_lock_interruptible().
Signed-off-by: Robert Krakora <rob.krakora@messagenetsystems.com>
Acked-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/uvc/uvc_v4l2.c b/drivers/media/video/uvc/uvc_v4l2.c
index f8b94d608a10..5e77cad29690 100644
--- a/drivers/media/video/uvc/uvc_v4l2.c
+++ b/drivers/media/video/uvc/uvc_v4l2.c
@@ -530,7 +530,10 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
mem... |
1e7439388a5aa6decf76ac1d73d5312fe713e6af | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11999): af9015: fix stack corruption bug | Problem Details:
This patch fixes stack corruption bug present in af9015_eeprom_dump():
the buffer buf is one byte smaller than required - there is 4 chars
for address prefix, 16*3 chars for dump of 16 eeprom bytes per line
and 1 byte for zero ending the string required, i.e. 53 bytes, but
only 52 are provided.
The one... | ```diff
diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c
index 9155a79f169e..4cb31e7c13c2 100644
--- a/drivers/media/dvb/dvb-usb/af9015.c
+++ b/drivers/media/dvb/dvb-usb/af9015.c
@@ -538,7 +538,7 @@ exit:
/* dump eeprom */
static int af9015_eeprom_dump(struct dvb_usb_device *d)
{
... |
96ceea2734d922d07000e98606231f3d675e09f8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11991): buf-core.c: add pointer check | Problem Details:
add poiter check for videobuf_queue_core_init().
any guys who write a v4l driver, pass a NULL pointer or a non-inintial
pointer to the first parameter such as videobuf_queue_sg_init() , it
would be crashed.
Signed-off-by: Figo.zhang <figo1802@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@r... | ```diff
diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c
index 48c3ebdb415f..f1ccf98c0a6f 100644
--- a/drivers/media/video/videobuf-core.c
+++ b/drivers/media/video/videobuf-core.c
@@ -118,6 +118,7 @@ void videobuf_queue_core_init(struct videobuf_queue *q,
void *priv,
str... |
d5709a0e3dfe22e24d871ef1e0eec9ae04055997 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11990): saa7134-video.c: fix the block bug | Problem Details:
when re-open or re-start (video_streamon), the q->curr would not be NULL in saa7134_buffer_queue(),
and all the qbuf will add to q->queue list,no one to do activate to start DMA,and then no interrupt
would happened,so it will be block.
In VIDEOBUF_NEEDS_INIT state, initialize the curr pointer to be NU... | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c
index ceae3c88f93e..e305c1674cee 100644
--- a/drivers/media/video/saa7134/saa7134-video.c
+++ b/drivers/media/video/saa7134/saa7134-video.c
@@ -1057,6 +1057,7 @@ static int buffer_prepare(struct videobuf_queue... |
8a8dad71485cbfc21ddc0e93f4ae4338b68b82b1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11981): Remote control debugging for dw2102 driver based USB cards | Problem Details:
Remote control debugging for dw2102 driver based USB cards
It includes DVBWorld, TeVii, Terratec and others.
Type 'modprobe dvb-usb-dw2102 debug=4', then look at dmesg output.
Signed-off-by: Igor M. Liplianin <liplianin@me.by>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dw2102.c b/drivers/media/dvb/dvb-usb/dw2102.c
index c65f273ff313..dee9399f8597 100644
--- a/drivers/media/dvb/dvb-usb/dw2102.c
+++ b/drivers/media/dvb/dvb-usb/dw2102.c
@@ -51,7 +51,9 @@ struct dw210x_rc_keys {
/* debug */
static int dvb_usb_dw2102_debug;
module_param_na... |
163fe744c3283fd267268629afff4cfc846ed0e0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11966): ov511: Fix unit_video parameter behavior | Problem Details:
Fix a regression caused by changeset 9133:64aed7485a43 - v4l: disconnect
kernel number from minor
Before the above changeset, ov511_probe used to allow forcing to use a
certain specific set of video devices, like:
modprobe ov511 unit_video=4,1,3 num_uv=3
So, assuming that you have 5 ov511 devices, a... | ```diff
diff --git a/drivers/media/video/ov511.c b/drivers/media/video/ov511.c
index 9af5532db142..08cfd3e4ae8a 100644
--- a/drivers/media/video/ov511.c
+++ b/drivers/media/video/ov511.c
@@ -112,6 +112,8 @@ static int framedrop = -1;
static int fastset;
static int force_palette;
static int backlight;
+/* Bitmask ma... |
eccd15aad72f774b2059f708bc422dbb8493bb30 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11964): b2c2: Fix problems with frontend attachment | Problem Details:
The frontend attachment code didn't handle cases where the frontend
partially failed to attach. For instance, when the demod was attached
successfully but the tuner driver wasn't compiled or fails to init for some
reason. In these cases we try to clean up the partial attachment and fail
instead of pr... | ```diff
diff --git a/drivers/media/dvb/b2c2/flexcop-fe-tuner.c b/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
index 3f485bf13121..efb4a6c2b57a 100644
--- a/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
+++ b/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
@@ -175,23 +175,23 @@ static int skystar23_samsung_tbdu18132_tuner_set_params... |
f6a061bb0f143ff40070e6fd3d38fde5bd60027c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11962): dvb: Fix broken link in get_dvb_firmware for nxt2004 (A180) | Problem Details:
Due to a reorganisation of AVermedia's websites, get_dvb_firmware
no longer works for nxt2004. Fix it.
Signed-off-by: Jan Ceuleers <jan.ceuleers@computer.org>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/Documentation/dvb/get_dvb_firmware b/Documentation/dvb/get_dvb_firmware
index 815a57840a13..a52adfc9a57f 100644
--- a/Documentation/dvb/get_dvb_firmware
+++ b/Documentation/dvb/get_dvb_firmware
@@ -317,7 +317,7 @@ sub nxt2002 {
sub nxt2004 {
my $sourcefile = "AVerTVHD_MCE_A180_Drv_v1.2.2.16... |
6f4d72392d76b8f78f646805ba2be995b3f77992 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11959): se401: Fix unsafe use of sprintf with identical source/destination | Problem Details:
Closes-bug: http://bugzilla.kernel.org/show_bug.cgi?id=13435
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/se401.c b/drivers/media/video/se401.c
index 5990ab38a124..08129a830d6e 100644
--- a/drivers/media/video/se401.c
+++ b/drivers/media/video/se401.c
@@ -1244,17 +1244,18 @@ static int se401_init(struct usb_se401 *se401, int button)
int i=0, rc;
unsigned char cp[0x40];
char te... |
f1ca0adfcf2c2f1129a59b93caa80a1dbd6b6c81 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11957): dsbr100: change radio->muted to radio->status, update suspend/resume | Problem Details:
Patch renames radio->muted to radio->status, add defines for that
variable, and fixes suspend/resume procedure. Radio->status set to
STOPPED in usb_dsbr100_probe because of removing open call.
Also, patch increases driver version.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Signed-off-by: Do... | ```diff
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index 17e8f2ca7d90..ed9cd7ad0604 100644
--- a/drivers/media/radio/dsbr100.c
+++ b/drivers/media/radio/dsbr100.c
@@ -33,6 +33,10 @@
History:
+ Version 0.46:
+ Removed usb_dsbr100_open/close calls and radio->users counter. Also,
+ ra... |
23ff6043add670713bbf2f6ee5d520459cfdfae9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11945): uvcvideo: Don't accept to change the format when buffers are allocated. | Problem Details:
Setting a new frame format or size will likely change the buffer size required
to store a complete video frame. To avoid a buffer overflow, don't allow
VIDIOC_S_FMT calls when video buffers are already allocated.
Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalh... | ```diff
diff --git a/drivers/media/video/uvc/uvc_queue.c b/drivers/media/video/uvc/uvc_queue.c
index 0155752e4a5a..f854698c4061 100644
--- a/drivers/media/video/uvc/uvc_queue.c
+++ b/drivers/media/video/uvc/uvc_queue.c
@@ -172,6 +172,20 @@ int uvc_free_buffers(struct uvc_video_queue *queue)
return 0;
}
+/*
+ * Che... |
ef5b5168e58021f87af53283002795ce5a787c2b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11936): Fix v4l2-device usage of i2c_unregister_device() | Problem Details:
Fix v4l2-device usage of i2c_unregister_device() and handle the case of
CONFIG_I2C=m & CONFIG_MEDIA_VIDEO=y.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/v4l2-device.c b/drivers/media/video/v4l2-device.c
index 772833b69bbf..0d06e7cbd5b3 100644
--- a/drivers/media/video/v4l2-device.c
+++ b/drivers/media/video/v4l2-device.c
@@ -85,7 +85,7 @@ void v4l2_device_unregister(struct v4l2_device *v4l2_dev)
/* Unregister subdevs */
list... |
0f9fba3129541822b1d75330406e62e838bf4fc1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11926): tuner-core: fix warning introduced when cleaning up xc5000 init routine | Problem Details:
This patch removes some remaining dead code. Warning showed up in Hans
Verkuil's daily report after I committed hg changeset 7f2eea75118b.
Thanks to Michael Krufky for bringing the warning to my attention.
Cc: Michael Krufky <mkrufky@kernellabs.com>
Signed-off-by: Devin Heitmueller <dheitmueller@ker... | ```diff
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index 4018eacb3a4c..537594211a90 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -412,8 +412,6 @@ static void set_type(struct i2c_client *c, unsigned int type,
break;
case TUNER_XC5000:
... |
0a863975e288667fd65737f65f9d4cd5d9817ba9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11918): tuner-xc2028: Fix offset frequencies for DVB @ 6MHz | Problem Details:
Both ATSC and DVB @ 6MHz bandwidth require the same offset.
While we're fixing it, let's cleanup the bandwidth setup to better
reflect the fact that it is a function of the bandwidth.
Thanks to Terry Wu <terrywu2009@gmail.com> for pointing this issue and
to Andy Walls <awalls@radix.net> for an initia... | ```diff
diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers/media/common/tuners/tuner-xc2028.c
index 14649e456fdb..27e7cb6622b1 100644
--- a/drivers/media/common/tuners/tuner-xc2028.c
+++ b/drivers/media/common/tuners/tuner-xc2028.c
@@ -917,22 +917,29 @@ static int generic_set_freq(struct dvb_frontend *fe... |
a1014d70db862c8e9de9207c3a0397e644ad9d4a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11917): Fix firmware load for DVB-T @ 6MHz bandwidth for xc3028/xc3028L | Problem Details:
The only two countries that are known to use 6MHz bandwidth are Taiwan
and Uruguay. Both use QAM subcarriers at OFTM.
This patch fixes the firmware load for such countries, where the
required firmware is the QAM one.
This also confirms the previous tests where it was noticed that the 6MHz
QAM firmwar... | ```diff
diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers/media/common/tuners/tuner-xc2028.c
index ed2653d3b52d..14649e456fdb 100644
--- a/drivers/media/common/tuners/tuner-xc2028.c
+++ b/drivers/media/common/tuners/tuner-xc2028.c
@@ -1022,21 +1022,20 @@ static int xc2028_set_params(struct dvb_frontend ... |
cc8da5263fa743c33d6503f85113bcb70048e633 | Analyze and fix the following issue in the Linux kernel code: drm/radeon: switch to using late_initcall | Problem Details:
This fixes an issue where we get inited before fbcon when built-in.
Ideally this should work as a non late_initcall, but this fixes it for now.
We also don't suggest people build this in (at least distro maintainers).
Reported-by: Ryan Hope <rmh3093@gmail.com>
Signed-off-by: Dave Airlie <airlied@redh... | ```diff
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index f70c351bb43e..c815a2cbf7b3 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -345,7 +345,7 @@ static void __exit radeon_exit(void)
drm_exit(driver);
}
-module_init(radeon... |
d2abdf62882d982c58e7a6b09ecdcfcc28075e2e | Analyze and fix the following issue in the Linux kernel code: PCI PM: Fix handling of devices without PM support by pci_target_state() | Problem Details:
If a PCI device is not power-manageable either by the platform, or
with the help of the native PCI PM interface, pci_target_state() will
return either PCI_D3hot, or PCI_POWER_ERROR for it, depending on
whether or not the device is configured to wake up the system. Alas,
none of these return values is ... | ```diff
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index c56a4a0355a8..7b59fd7c9575 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1284,15 +1284,14 @@ pci_power_t pci_target_state(struct pci_dev *dev)
default:
target_state = state;
}
+ } else if (!dev->pm_cap) {
+ target_state = PCI_D0;
... |
8c1c699fec9e9021bf6ff0285dee086bb27aec90 | Analyze and fix the following issue in the Linux kernel code: PCI: cleanup Function Level Reset | Problem Details:
This patch enhances the FLR functions:
1) remove disable_irq() so the shared IRQ won't be disabled.
2) replace the 1s wait with 100, 200 and 400ms wait intervals
for the Pending Transaction.
3) replace mdelay() with msleep().
4) add might_sleep().
5) lock the device to prevent PM suspend... | ```diff
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index e87fe95da814..03c7706c0a09 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -110,7 +110,7 @@ static int virtfn_add(struct pci_dev *dev, int id, int reset)
}
if (reset)
- pci_execute_reset_function(virtfn);
+ __pci_reset_function(virtfn);
... |
498a8faf2c7eb974f70b7c5a60a31f0d48c35d44 | Analyze and fix the following issue in the Linux kernel code: PCI hotplug: fix return value of has_foo() functions | Problem Details:
Current has_foo() functions in pci_hotplug_core.c returns 0 if the
"foo" property is true. It would cause misunderstanding. In addition,
the error code of those functions is never checked, so this patch
changes those functions' error code to 'bool' and return true if the
property "foo" is true.
Signed... | ```diff
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
index 535fce0f07f9..ff32c6b4ae13 100644
--- a/drivers/pci/hotplug/pci_hotplug_core.c
+++ b/drivers/pci/hotplug/pci_hotplug_core.c
@@ -347,125 +347,126 @@ static struct pci_slot_attribute hotplug_slot_attr_test = {
.st... |
bd3d99c17039fd05a29587db3f4a180c48da115a | Analyze and fix the following issue in the Linux kernel code: PCI: Remove untested Electromechanical Interlock (EMI) support in pciehp. | Problem Details:
The EMI support in pciehp is obviously broken. It is implemented using
struct hotplug_slot_attribute, but sysfs_ops for pci_slot_ktype is NOT
for struct hotplug_slot_attribute, but for struct pci_slot_attribute.
This bug had been there for a long time, maybe it was introduced when
PCI slot framework wa... | ```diff
diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
index 0a368547e633..e6cf096498be 100644
--- a/drivers/pci/hotplug/pciehp.h
+++ b/drivers/pci/hotplug/pciehp.h
@@ -81,7 +81,6 @@ struct slot {
struct hpc_ops *hpc_ops;
struct hotplug_slot *hotplug_slot;
struct list_head slot_list;
- u... |
a72b46c3849cdb05993015991bde548ab8b6d7ac | Analyze and fix the following issue in the Linux kernel code: PCI: Add pci_bus_set_ops | Problem Details:
pci_bus_set_ops changes pci_ops associated with a pci_bus. This can be
used by debug tools such as PCIE AER error injection to fake some PCI
configuration registers.
Acked-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Huang Ying <ying.huang@intel.com>
Signed-off-by: Jesse Barnes ... | ```diff
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 0f3706512686..db23200c4874 100644
--- a/drivers/pci/access.c
+++ b/drivers/pci/access.c
@@ -66,6 +66,25 @@ EXPORT_SYMBOL(pci_bus_write_config_byte);
EXPORT_SYMBOL(pci_bus_write_config_word);
EXPORT_SYMBOL(pci_bus_write_config_dword);
+/**
+ * pc... |
26c56dc0c4fbdf3af12ebc48278f09ef65ddb4dd | Analyze and fix the following issue in the Linux kernel code: PCI quirk: unhide 'Overflow' device on i828{6,7}5P/PE chipsets | Problem Details:
Some BIOSes hide 'overflow' device (dev #6) for i82875P/PE chipsets.
The same happens for i82865P/PE. Add a quirk to enable this device.
This allows i82875 EDAC driver to bind to chipset's dev #6 and not
dev #0 as the latter is used by AGP driver.
On my laptop (i82865P based) ACPI code is disabling th... | ```diff
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index a778c84d04a9..15a8ab7ea911 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2017,6 +2017,28 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
PCI_DEVICE_ID_NX2_5709S,
quirk_brcm_570x_limit_vpd);
+/* Originally in EDAC sour... |
75c74d1c78ec3b713a986e0efc645ed558384cdf | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11896): em28xx: Fix for Slow Memory Leak | Problem Details:
Test Code: (Provided by Douglas)
v4l-dvb/v4l2-apps/test/stress-buffer.c
The audio DMA area was never being freed and would slowly leak over
time as the v4l device was opened and closed by an application.
Thanks again to Douglas for generating the test code to help locate
memory leaks!!!
Signed-off... | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c
index 0131322475bf..7bd8a70f0a0b 100644
--- a/drivers/media/video/em28xx/em28xx-audio.c
+++ b/drivers/media/video/em28xx/em28xx-audio.c
@@ -339,6 +339,11 @@ static int snd_em28xx_pcm_close(struct snd_pcm_substream... |
86bc85b38602411a9582b829fdd0ee02cf582985 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11865): cx18: Tweak color burst gate delay and initial color sub-carrier freq | Problem Details:
Fix the burst gate delays to use a crystal value of 28636360 as assumed by
the rest of the driver. Also have the initial color sub-carrier freq paramter
use the src decimation ratio per the documentation, instead of the actual
crystal/pixel clock ratio. The tracking circuit will find the correct colo... | ```diff
diff --git a/drivers/media/video/cx18/cx18-av-core.c b/drivers/media/video/cx18/cx18-av-core.c
index 33ec269a0f5e..0b3d840cc2e2 100644
--- a/drivers/media/video/cx18/cx18-av-core.c
+++ b/drivers/media/video/cx18/cx18-av-core.c
@@ -277,8 +277,15 @@ void cx18_av_std_setup(struct cx18 *cx)
struct cx18_av_state *... |
b9dcdb6fb870ce83578465b3ffd047185bead67f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11860): saa7134: fix quirk in saa7134_i2c_xfer for the saa7131 bridge | Problem Details:
The i2c quirk in the saa7134_i2c_xfer function does a bogus write
to i2c address 0xfd, to work around a bug in the silicon that
affects read transactions.
Unfortunately, this hack is not working properly, since the bogus
write is to 0xfd, an invalid i2c address. Fix this quirk by using
an actual vali... | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-i2c.c b/drivers/media/video/saa7134/saa7134-i2c.c
index a8a355e28799..8096dace5f6c 100644
--- a/drivers/media/video/saa7134/saa7134-i2c.c
+++ b/drivers/media/video/saa7134/saa7134-i2c.c
@@ -259,7 +259,7 @@ static int saa7134_i2c_xfer(struct i2c_adapter *i2c_adap,... |
c27586e4d647c5c07c81e766d34ceef6ba5a316d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11858): cx23885: fix tda10048 IF frequencies for the Hauppauge WinTV-HVR1210 | Problem Details:
Steve missed the HVR1210 config struct for the TDA10048 in his IF freq patch.
Signed-off-by: Michael Krufky <mkrufky@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c
index 577e83829adf..45784a384300 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -135,7 +135,9 @@ static struct tda10048_config hauppauge_hvr1210_config = ... |
4a567394dce57e8a2329f0a1123b951b0f070d39 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11852): saa7134-video.c: poll method lose race condition | Problem Details:
saa7134-video.c: poll method lose race condition
Signed-off-by: Figo Zhang <figo.zhang@kolorific.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c
index 493cad941460..ceae3c88f93e 100644
--- a/drivers/media/video/saa7134/saa7134-video.c
+++ b/drivers/media/video/saa7134/saa7134-video.c
@@ -1423,11 +1423,13 @@ video_poll(struct file *file, struct poll_tab... |
eda9f7523b6760bdfc3b9c5001214467b5ecd618 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11841): core: fix potential mutex_unlock without mutex_lock in dvb_dvr_read | Problem Details:
dvb_dvr_read may unlock the dmxdev mutex and return -ENODEV, except this
function is a file op and will never be called with the mutex held.
There's existing mutex_lock and mutex_unlock around the actual read but
it's commented out. These should probably be uncommented but the read
blocks and this co... | ```diff
diff --git a/drivers/media/dvb/dvb-core/dmxdev.c b/drivers/media/dvb/dvb-core/dmxdev.c
index c35fbb8d8f4a..6d6121eb5d59 100644
--- a/drivers/media/dvb/dvb-core/dmxdev.c
+++ b/drivers/media/dvb/dvb-core/dmxdev.c
@@ -244,19 +244,13 @@ static ssize_t dvb_dvr_read(struct file *file, char __user *buf, size_t count,
... |
04a37e0f32f9882430bc1899899d2ed91b8aaf5b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11837): uvcvideo: Start status polling on device open | Problem Details:
Most UVC camera include an interrupt endpoint to report control value changes,
video streaming errors and camera button events. The USB controller
continuously polls the interrupt endpoint to retrieve such events. This
prevents the device from being auto-suspended, and thus consumes power.
Reporting v... | ```diff
diff --git a/drivers/media/video/uvc/uvc_driver.c b/drivers/media/video/uvc/uvc_driver.c
index f4fced34cfd7..3287454bb368 100644
--- a/drivers/media/video/uvc/uvc_driver.c
+++ b/drivers/media/video/uvc/uvc_driver.c
@@ -1594,6 +1594,7 @@ static int uvc_probe(struct usb_interface *intf,
INIT_LIST_HEAD(&dev->ent... |
81dae6716f13e801cfe2035514e7aeb971b57492 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11832): dibusb_mc: fix i2c to not corrupt eeprom in case of strange read pattern | Problem Details:
dibusb_i2c_xfer seems to do things very dangerous :
it assumes that it get only write/read request or write request.
That means that read can be understood as write. For example a program
doing
file = open("/dev/i2c-x", O_RDWR);
ioctl(file, I2C_SLAVE, 0x50)
read(file, data, 10)
will corrupt th... | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dibusb-common.c b/drivers/media/dvb/dvb-usb/dibusb-common.c
index 8ee6cd4da9e7..8dbad1ec53c4 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-common.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-common.c
@@ -133,14 +133,17 @@ static int dibusb_i2c_xfer(struct i2c_adapter *adap,str... |
027aa2c771d9fb8dc6aae95c80b50e40e3c97dc5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11808): au0828: get rid of debug printk that was causing compile failures | Problem Details:
Remove a debug printk() line I added which is no longer needed, and happened
to be causing compile failures on some earlier kernels in Han's daily
compile report.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/au0828/au0828-video.c b/drivers/media/video/au0828/au0828-video.c
index f42f3deaa03b..51527d7b55a7 100644
--- a/drivers/media/video/au0828/au0828-video.c
+++ b/drivers/media/video/au0828/au0828-video.c
@@ -913,11 +913,6 @@ static int au0828_v4l2_mmap(struct file *filp, struct vm... |
4900877b7cdcb88e24c4130cb3c25080c03c335c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11800): tuner-xc2028: show the proper module description for no_poweroff option | Problem Details:
There was a typo in the module description for the "no_poweroff" option, where the
help was being associated with the "debug" option instead.
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers/media/common/tuners/tuner-xc2028.c
index fd83cc0c134c..ed2653d3b52d 100644
--- a/drivers/media/common/tuners/tuner-xc2028.c
+++ b/drivers/media/common/tuners/tuner-xc2028.c
@@ -30,7 +30,7 @@ MODULE_PARM_DESC(debug, "enable verbose debug messages"... |
bae7b7d73da0e42169aeb7c697e2c9549929300b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11795): xc5000: add build version to debug info | Problem Details:
Expose the firmware build number along with the other version info
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/common/tuners/xc5000.c b/drivers/media/common/tuners/xc5000.c
index c956c82524ec..8d3e31b6effc 100644
--- a/drivers/media/common/tuners/xc5000.c
+++ b/drivers/media/common/tuners/xc5000.c
@@ -100,6 +100,7 @@ struct xc5000_priv {
#define XREG_VERSION 0x07
#define XREG_PRODUCT_ID... |
8153c3b7d80a2058f91fb0b4ef49190f241ecc34 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11700): tda10048: Added option to block i2c gate control from other drivers. | Problem Details:
Currently, DVB-T is broken and this fixes it.
The PVRUSB2 has an odd I2C bus configuration where opening the i2c gate
on the digital and analog demod causes the tuner to fail. This needs
to be protected against for the PVRUSB2.
Signed-off-by: Steven Toth <stoth@linuxtv.org>
Signed-off-by: Michael Kru... | ```diff
diff --git a/drivers/media/dvb/frontends/tda10048.c b/drivers/media/dvb/frontends/tda10048.c
index dfa3e2ccc741..11be4697cb3d 100644
--- a/drivers/media/dvb/frontends/tda10048.c
+++ b/drivers/media/dvb/frontends/tda10048.c
@@ -689,6 +689,9 @@ static int tda10048_i2c_gate_ctrl(struct dvb_frontend *fe, int enable... |
38092a4402e0df6f1f283ff6e455197035266ce7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11677): radio-fm16: fix g_tuner. | Problem Details:
g_tuner handled capability, audmode and rxsubchans incorrectly.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/radio/radio-sf16fmi.c b/drivers/media/radio/radio-sf16fmi.c
index e598b5471d8a..49c4aab95dab 100644
--- a/drivers/media/radio/radio-sf16fmi.c
+++ b/drivers/media/radio/radio-sf16fmi.c
@@ -151,7 +151,7 @@ static int vidioc_g_tuner(struct file *file, void *priv,
v->rangelow = RSF16_MI... |
b475f4eeda1da16e995b2302f6eebdfb08ce18cd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11741): zoran: Fix &&/|| typo | Problem Details:
Fix &&/|| typo. `default_norm' can be 0 (PAL), 1 (NTSC) or 2 (SECAM),
the condition tested was impossible.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/zoran/zoran_card.c b/drivers/media/video/zoran/zoran_card.c
index ea6c577b0eb3..ea9de8b47db3 100644
--- a/drivers/media/video/zoran/zoran_card.c
+++ b/drivers/media/video/zoran/zoran_card.c
@@ -1022,7 +1022,7 @@ zr36057_init (struct zoran *zr)
zr->vbuf_bytesperline = 0;
/*... |
e9785250ef2eead8bd5e9166679c0be0595df387 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11723): Link firmware to physical device | Problem Details:
Use the physical device rather than the i2c adapter as the reference
device when loading firmwares. This will prevent the sysfs name
collision with i2c-dev that has been reported many times.
I may have missed other drivers which need the same fix.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Sign... | ```diff
diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers/media/common/tuners/tuner-xc2028.c
index 1adce9ff52ce..fd83cc0c134c 100644
--- a/drivers/media/common/tuners/tuner-xc2028.c
+++ b/drivers/media/common/tuners/tuner-xc2028.c
@@ -272,7 +272,7 @@ static int load_all_firmwares(struct dvb_frontend *fe... |
30d35e49509345a3bee778e0cee8545cd70853e2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11711): gspca - main: Fix a crash when no bandwidth available | Problem Details:
When the bandwidth is not wide enough, the transfer endpoint may be set to
the one of the alternate setting 0. This one may be null and this causes a
divide by 0 oops.
Reported-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Ch... | ```diff
diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
index 873e95580407..efa4dd349f60 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -449,7 +449,8 @@ static struct usb_host_endpoint *alt_xfer(struct usb_host_interface *alt,
for (i = 0; i... |
0b119b7bf4612d6de6638a0babe93c1d8509a838 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11709): gspca - zc3xx: Bad debug level in i2c_read | Problem Details:
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/zc3xx.c b/drivers/media/video/gspca/zc3xx.c
index c4684b9a412c..08422d315e68 100644
--- a/drivers/media/video/gspca/zc3xx.c
+++ b/drivers/media/video/gspca/zc3xx.c
@@ -6307,7 +6307,7 @@ static __u16 i2c_read(struct gspca_dev *gspca_dev,
retbyte = reg_r_i(gspca_dev, 0x009... |
1b844b536794163eb676b71e6e4c033f6d4b6b33 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11692): gspca - m5602: Checkpatch.pl fixes | Problem Details:
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/m5602/m5602_core.c b/drivers/media/video/gspca/m5602/m5602_core.c
index dd1024325fc7..8a5bba16ff32 100644
--- a/drivers/media/video/gspca/m5602/m5602_core.c
+++ b/drivers/media/video/gspca/m5602/m5602_core.c
@@ -113,7 +113,9 @@ int m5602_read_sensor(struct sd *sd, const u8... |
60d52cecedf7b55bed07d59ab6039ae066f01124 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11688): gspca - m5602-s5k4aa: Fixup SXGA resolution. | Problem Details:
The SXGA resolution doesn't work unless you first force the VGA resolution.
More investigation is needed in order to fix this the "right" way.
Signed-off-by: Grégory Lardière <spmf2004-m560x@yahoo.fr>
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redh... | ```diff
diff --git a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
index 73b826a8ab04..b5a9ddb2d218 100644
--- a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
+++ b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
@@ -74,6 +74,17 @@ static struct v4l2_pix_format s5k4aa_m... |
f1ff355a2c32dbe93cfe05160e05cbccc789ca33 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11663): Fix a warning introduced by git commit ec5f5bf80501abfe2da2897cfcde8452b545aacb | Problem Details:
/home/v4l/master/v4l/radio-si470x.c: In function 'si470x_fops_release':
/home/v4l/master/v4l/radio-si470x.c:1218: warning: label 'unlock' defined but not used
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/radio/radio-si470x.c b/drivers/media/radio/radio-si470x.c
index bd945d04dc90..640421ceb24a 100644
--- a/drivers/media/radio/radio-si470x.c
+++ b/drivers/media/radio/radio-si470x.c
@@ -1214,7 +1214,6 @@ static int si470x_fops_release(struct file *file)
usb_autopm_put_interface(radio... |
2e03669d9da8c52f24ba44fdbd17c5df7be10585 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11654): gspca - m5602: Storage class should be before const qualifier | Problem Details:
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the
beginning of the declaration specifiers in a declaration is an
obsolescent feature.
[mchehab@redhat.com: Fix a trivial merge conflict]
Cc: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: To... | ```diff
diff --git a/drivers/media/video/gspca/m5602/m5602_mt9m111.h b/drivers/media/video/gspca/m5602/m5602_mt9m111.h
index e71ddb786264..b3de77823091 100644
--- a/drivers/media/video/gspca/m5602/m5602_mt9m111.h
+++ b/drivers/media/video/gspca/m5602/m5602_mt9m111.h
@@ -113,7 +113,7 @@ int mt9m111_init(struct sd *sd);
... |
72b79747a88f1ffcb6689cedacc01235bb545cd6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11650): gspca - m5602: Sort out macro conflict by adding a prefix | Problem Details:
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/m5602/m5602_mt9m111.c b/drivers/media/video/gspca/m5602/m5602_mt9m111.c
index 5e8d8183bb50..0c9470e137e3 100644
--- a/drivers/media/video/gspca/m5602/m5602_mt9m111.c
+++ b/drivers/media/video/gspca/m5602/m5602_mt9m111.c
@@ -86,7 +86,7 @@ const static struct ctrl mt9m111_ct... |
934f78c3069943cf0654a6f809adf0375b078c38 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11647): gspca - m5602-po1030: Disable QVGA for now | Problem Details:
Getting QVGA to be supported on the po1030 seems harder than I first thought. I need access to the proper hardware in order to fix it up.
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/m5602/m5602_po1030.c b/drivers/media/video/gspca/m5602/m5602_po1030.c
index 840a3ca53200..270167bbcc36 100644
--- a/drivers/media/video/gspca/m5602/m5602_po1030.c
+++ b/drivers/media/video/gspca/m5602/m5602_po1030.c
@@ -43,15 +43,6 @@ static int po1030_get_auto_exposure(st... |
594bb46dbc63934bc65fa95743f83204bd26a641 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11607): soc-camera: add a free_bus method to struct soc_camera_link | Problem Details:
Currently pcm990 camera bus-width management functions request a GPIO and never
free it again. With this approach the GPIO extender driver cannot be unloaded
once camera drivers have been loaded, also unloading theb i2c-pxa bus driver
produces errors, because the GPIO extender driver cannot unregister ... | ```diff
diff --git a/arch/arm/mach-pxa/pcm990-baseboard.c b/arch/arm/mach-pxa/pcm990-baseboard.c
index 095521e9ee24..01791d74e08e 100644
--- a/arch/arm/mach-pxa/pcm990-baseboard.c
+++ b/arch/arm/mach-pxa/pcm990-baseboard.c
@@ -380,12 +380,12 @@ static struct pca953x_platform_data pca9536_data = {
.gpio_base = NR_BUIL... |
d46de9d2364cad55caddc04632707f5739b4cd87 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11567): saa7134: Added support for AVerMedia Cardbus Plus | Problem Details:
Here comes the full support for AVerMedia Cardbus Plus (E501R) - including
remote control. TV, Composite and FM radio tested, I don't have S-Video to
test. I've figured out that the radio works only with xtal frequency 13MHz.
[mchehab@redhat.com: CodingStyle fixes]
Signed-off-by: Oldřich Jedlička <old... | ```diff
diff --git a/Documentation/video4linux/CARDLIST.saa7134 b/Documentation/video4linux/CARDLIST.saa7134
index 8a15e2b837fc..fb3098d56d85 100644
--- a/Documentation/video4linux/CARDLIST.saa7134
+++ b/Documentation/video4linux/CARDLIST.saa7134
@@ -156,3 +156,4 @@
155 -> Hauppauge WinTV-HVR1120 ATSC/QAM-Hybrid [007... |
df0dbbe24053b7c669f63341d3d3f090560c3217 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11442): saa7134: BZ#7524: Add AVerTV Studio 507UA support | Problem Details:
[mchehab@redhat.com: Fix merge conflicts and CodingStyle issues]
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/Documentation/video4linux/CARDLIST.saa7134 b/Documentation/video4linux/CARDLIST.saa7134
index 6dacf2825259..8a15e2b837fc 100644
--- a/Documentation/video4linux/CARDLIST.saa7134
+++ b/Documentation/video4linux/CARDLIST.saa7134
@@ -155,3 +155,4 @@
154 -> Avermedia AVerTV GO 007 FM Plus [146... |
cbc320d2782cbb0c19e67522167843d9eb738722 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11598): stv090x: fix missing wakeup in init | Problem Details:
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index 6c0378ddebc5..9f69317f81c2 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -3880,6 +3880,11 @@ static int stv090x_init(struct dvb_frontend *fe)
const struct stv090... |
9629c5b69dd016e990603fd7fd9899f0af57610c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11597): stv090x: fixes read_status to return 0 in case of no error | Problem Details:
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index 004b774f561c..6c0378ddebc5 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -3163,7 +3163,6 @@ static int stv090x_read_status(struct dvb_frontend *fe, enum fe_status ... |
94871465b6a82de3882a61bf1e3c202725688294 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11596): stv090x: fixes some register definitions | Problem Details:
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x_reg.h b/drivers/media/dvb/frontends/stv090x_reg.h
index 0dff56d4e94b..55737074eafe 100644
--- a/drivers/media/dvb/frontends/stv090x_reg.h
+++ b/drivers/media/dvb/frontends/stv090x_reg.h
@@ -470,7 +470,7 @@
#define STV090x_FSKTCTRL 0xf175
#define STV090x_OFF... |
2f5914be7c2277cf19699e437cf2c6c15556a085 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11595): stv090x: fixes a few bugs | Problem Details:
This patch fixes:
* Cut revision was read too late
* Missing increment
* wrong return value
* mismatched entries
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index 3601132778e3..004b774f561c 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -1943,6 +1943,7 @@ static int stv090x_get_loop_params(struct stv090x_state *state, s32 *fr... |
64104dc9014d717335ed8ff987feaec1b17c1cd5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11594): stv090x: Fix incorrect TSMODE usage | Problem Details:
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index db3c09183a22..3601132778e3 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -3813,34 +3813,34 @@ static int stv090x_set_tspath(struct stv090x_state *state)
switch... |
4e58a6827a7d67f65d166d28635ac13bdf65dbb0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11593): stv090x: Fix Rolloff | Problem Details:
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index 3e0acd7cc822..db3c09183a22 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -807,9 +807,24 @@ err:
return -1;
}
-static u32 stv090x_car_width(u32 srate, u32 roll... |
f2b2fd401343b188f251b29ec2981ea8054ce1b7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11592): stv6110x: Fix read bug | Problem Details:
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv6110x.c b/drivers/media/dvb/frontends/stv6110x.c
index 738618133b16..3d8a2e01c9c4 100644
--- a/drivers/media/dvb/frontends/stv6110x.c
+++ b/drivers/media/dvb/frontends/stv6110x.c
@@ -53,6 +53,7 @@ static int stv6110x_read_reg(struct stv6110x_state *stv6110x, u8 reg, u... |
72982f761526278e1ca7dce0507ed9f33b952fee | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11585): stv090x: fix incorrectly used mode | Problem Details:
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index 0643bffea508..6aaeda1cf243 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -1922,7 +1922,7 @@ static int stv090x_get_loop_params(struct stv090x_state *state, s32 *fr... |
54d859ec563d2f0cbbc03e45e204325c5f2118bf | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11583): isl6423: Various fixes to use external modulation | Problem Details:
Use external modulation
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/isl6423.c b/drivers/media/dvb/frontends/isl6423.c
index c1943dcb8db6..dca5bebfeeb5 100644
--- a/drivers/media/dvb/frontends/isl6423.c
+++ b/drivers/media/dvb/frontends/isl6423.c
@@ -73,6 +73,7 @@ static int isl6423_write(struct isl6423_dev *isl6423, u8 reg)
struct i2... |
5657150759ab67292db0333808a069970328663b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11582): stv090x: fix Undocumented Registers | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index e80d163c767f..b450bf12db44 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -176,8 +176,10 @@ static const struct stv090x_tab stv090x_rf_tab[] = {
static struct stv0... |
017eb0381fedbfdcad1e8e536d014c4064e6687f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11581): stv090x and stv6110x: fix repeater level setup and ref clock | Problem Details:
* Reference clock was unused
* Fix missing repeater level setup
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c
index a65f1b7849a1..e80d163c767f 100644
--- a/drivers/media/dvb/frontends/stv090x.c
+++ b/drivers/media/dvb/frontends/stv090x.c
@@ -640,16 +640,19 @@ static int stv090x_write_reg(struct stv090x_state *state, unsigned int ... |
dd4c2b3f6a2d30602d22485ab725c84f2fb074b6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11580): budget-ci: Fix incorrect default CLOCK setup | Problem Details:
Signed-off-by: Andreas Regel <andreas.regel@gmx.de>
Signed-off-by: MAnu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
index 2ee03206dc8c..7222030345d5 100644
--- a/drivers/media/dvb/ttpci/budget-ci.c
+++ b/drivers/media/dvb/ttpci/budget-ci.c
@@ -1352,11 +1352,11 @@ static struct stb6100_config tt3200_stb6100_config = {
static struct stv090x... |
9086c7b994dcd6d06723bcb48a23af3e3f75e002 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11573): uvcvideo: Prevent invormation loss with removing implicit casting | Problem Details:
The uvcvideo driver supports only one input, which is input 0. For all
other input index the return value shall be EINVAL. This patch fixes the
problem when the value 0x80000000 was incorrectly casted and treated as
a zero value.
The patch was tested with v4l-test 0.10 [2] with CNF7129 webcam found on... | ```diff
diff --git a/drivers/media/video/uvc/uvc_v4l2.c b/drivers/media/video/uvc/uvc_v4l2.c
index 2a80caa54fb4..43b05a7ecdce 100644
--- a/drivers/media/video/uvc/uvc_v4l2.c
+++ b/drivers/media/video/uvc/uvc_v4l2.c
@@ -648,7 +648,7 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
cas... |
3763a8a41bd0c1ea6b055b60acaf5f9655e5c25e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11569): av7110_hw: fix compile warning | Problem Details:
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/av7110_hw.c b/drivers/media/dvb/ttpci/av7110_hw.c
index 5e3f88911a1d..e162691b515d 100644
--- a/drivers/media/dvb/ttpci/av7110_hw.c
+++ b/drivers/media/dvb/ttpci/av7110_hw.c
@@ -1089,7 +1089,7 @@ int av7110_osd_cmd(struct av7110 *av7110, osd_cmd_t *dc)
else {
int i, l... |
5a41c9f6b784a9ef7e27a8a27bdb6d541c28b076 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11546): gspca - m5602-mt9m111: Endianness fixes. | Problem Details:
Signed-off-by: Erik Andr?n <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/m5602/m5602_mt9m111.c b/drivers/media/video/gspca/m5602/m5602_mt9m111.c
index e7fec46ac459..241108c786c3 100644
--- a/drivers/media/video/gspca/m5602/m5602_mt9m111.c
+++ b/drivers/media/video/gspca/m5602/m5602_mt9m111.c
@@ -400,7 +400,7 @@ static int mt9m111_set_vflip(stru... |
42ef4632896b0c44f77fb5783b320cbedd38e3e3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11487): em28xx: fix typo em28xx_errdev message | Problem Details:
Fix typo usbtransfer->usb transfer on em28xx_errdev message.
Signed-off-by: Filipe Rosset <rosset.filipe@gmail.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c
index 192b76cdd5d7..7375353c04eb 100644
--- a/drivers/media/video/em28xx/em28xx-core.c
+++ b/drivers/media/video/em28xx/em28xx-core.c
@@ -938,7 +938,7 @@ int em28xx_init_isoc(struct em28xx *dev, int max_packets,
d... |
3e5cbad030f6c12983f697ecff9fbd8f5a6bee7b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11474): gspca - m5602-po1030: Fix sensor probing. | Problem Details:
The po1030 read sensor are currently returning the contents of the address+1 fix the probing of the sensor to cope with this. Obviously this needs to be tracked down and fixed.
Signed-off-by: Erik Andr?n <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/m5602/m5602_po1030.c b/drivers/media/video/gspca/m5602/m5602_po1030.c
index 3ecb53c701ab..a45d55c530b5 100644
--- a/drivers/media/video/gspca/m5602/m5602_po1030.c
+++ b/drivers/media/video/gspca/m5602/m5602_po1030.c
@@ -157,7 +157,7 @@ static void po1030_dump_registers(str... |
dd3ec39871ba83fb47364a26b1caaac4494deb7b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11464): gspca - m5602-mt9m111: Set the cached v4l2 ctrl values | Problem Details:
When we resume the machine we want the previously set values, not the default
values. Fix this for the mt9m111 sensor
Signed-off-by: Erik Andr?n <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/m5602/m5602_mt9m111.c b/drivers/media/video/gspca/m5602/m5602_mt9m111.c
index 519548d07af6..8700f37deca9 100644
--- a/drivers/media/video/gspca/m5602/m5602_mt9m111.c
+++ b/drivers/media/video/gspca/m5602/m5602_mt9m111.c
@@ -136,12 +136,16 @@ sensor_found:
sensor_setting... |
2f38d70fb4e97e7d00e12eaac45790cf6ebd7b22 | Analyze and fix the following issue in the Linux kernel code: shift current_cred() from __f_setown() to f_modown() | Problem Details:
Shift current_cred() from __f_setown() to f_modown(). This reduces
the number of arguments and saves 48 bytes from fs/fcntl.o.
[ Note: this doesn't clear euid/uid when pid is set to NULL. But if
f_owner.pid == NULL we never use f_owner.uid/euid. Otherwise we'd
have a bug anyway: we must not send... | ```diff
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 1ad703150dee..f9c03ca3b2f4 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -198,15 +198,19 @@ static int setfl(int fd, struct file * filp, unsigned long arg)
}
static void f_modown(struct file *filp, struct pid *pid, enum pid_type type,
- uid_t uid,... |
b01b4babbf204443b5a846a7494546501614cefc | Analyze and fix the following issue in the Linux kernel code: firewire: net: fix card driver reloading | Problem Details:
Fix some problems from "firewire: net: allow for unordered unit
discovery":
- fwnet_remove was missing a list_del, causing fwnet_probe to crash if
called after fwnet_remove, e.g. if firewire-ohci was unloaded and
reloaded.
- fwnet_probe should set its new_netdev flag only if it actually
... | ```diff
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 95e35a36b01f..47dcb45d720e 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -1390,7 +1390,8 @@ static int fwnet_add_peer(struct fwnet_device *dev,
if (!peer)
return -ENOMEM;
- unit->device.driver_data = peer;
+ dev_set_... |
d645f4dad056a98089df904294f66b96d04e91b6 | Analyze and fix the following issue in the Linux kernel code: firewire: core: fix iso context shutdown on card removal | Problem Details:
If isochronous contexts existed when firewire-ohci was unloaded, the
core iso shutdown functions crashed with NULL dereferences, and buffers
etc. weren't released.
How the fix works: We first copy the card driver's iso shutdown hooks
into the dummy driver, then fw_destroy_nodes notifies upper layers ... | ```diff
diff --git a/drivers/firewire/core-card.c b/drivers/firewire/core-card.c
index 667603ac14b1..543fccac81bb 100644
--- a/drivers/firewire/core-card.c
+++ b/drivers/firewire/core-card.c
@@ -461,11 +461,11 @@ EXPORT_SYMBOL(fw_card_add);
/*
- * The next few functions implements a dummy driver that use once a
- ... |
29ad14cddd6246d17ff22f496363dfd6b3de8964 | Analyze and fix the following issue in the Linux kernel code: firewire: core: fix DMA unmapping in iso buffer removal | Problem Details:
dmap_unmap_page() shall use the same direction as dma_map_page().
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> | ```diff
diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c
index 448ddd7d887b..166f19c6d38d 100644
--- a/drivers/firewire/core-iso.c
+++ b/drivers/firewire/core-iso.c
@@ -71,7 +71,7 @@ int fw_iso_buffer_init(struct fw_iso_buffer *buffer, struct fw_card *card,
for (j = 0; j < i; j++) {
address =... |
00e95830a4d6e49f764fdb19896a89199bc0aa3b | Analyze and fix the following issue in the Linux kernel code: tracing/filters: fix race between filter setting and module unload | Problem Details:
Module unload is protected by event_mutex, while setting filter is
protected by filter_mutex. This leads to the race:
echo 'bar == 0 || bar == 10' \ |
> sample/filter |
| insmod sample.ko
add_pred("bar == 0") |
-> n_preds == 1 |
... | ```diff
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index d9f01c1a042b..936c621bbf46 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -27,8 +27,6 @@
#include "trace.h"
#include "trace_output.h"
-static DEFINE_MUTEX(filter_mutex);
-
... |
57be88878e7aa38750384704d811485a607bbda4 | Analyze and fix the following issue in the Linux kernel code: tracing/filters: free filter_string in destroy_preds() | Problem Details:
filter->filter_string is not freed when unloading a module:
# insmod trace-events-sample.ko
# echo "bar < 100" > /mnt/tracing/events/sample/foo_bar/filter
# rmmod trace-events-sample.ko
[ Impact: fix memory leak when unloading module ]
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference:... | ```diff
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index b24ab0e6ea74..d9f01c1a042b 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -381,6 +381,7 @@ void destroy_preds(struct ftrace_event_call *call)
filter_free_pred(filter->preds... |
fa7439531dee58277748c819785a44d3203c4b51 | Analyze and fix the following issue in the Linux kernel code: ring-buffer: use commit counters for commit pointer accounting | Problem Details:
The ring buffer is made up of three sets of pointers.
The head page pointer, which points to the next page for the reader to
get.
The commit pointer and commit index, which points to the page and index
of the last committed write respectively.
The tail pointer and tail index, which points to the pag... | ```diff
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index e857e9443987..ed3559944fcf 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -415,6 +415,8 @@ struct ring_buffer_per_cpu {
unsigned long overrun;
unsigned long read;
local_t entries;
+ local_t co... |
263294f3e1e883b9dcbf0c09a54b644918f7729d | Analyze and fix the following issue in the Linux kernel code: ring-buffer: remove unused variable | Problem Details:
Fix the compiler error:
kernel/trace/ring_buffer.c: In function 'rb_move_tail':
kernel/trace/ring_buffer.c:1236: warning: unused variable 'event'
Signed-off-by: Steven Rostedt <rostedt@goodmis.org> | ```diff
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index dbc0f93396aa..e857e9443987 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -1233,7 +1233,6 @@ rb_move_tail(struct ring_buffer_per_cpu *cpu_buffer,
{
struct buffer_page *next_page, *head_page, *reader_page;
... |
e56e2dcd381d9ec35379328f332221581eda4787 | Analyze and fix the following issue in the Linux kernel code: [IA64] ia64 does not need umount2() syscall | Problem Details:
ia64 doesn't have old and new versions of the umount system call.
It just has the new version.
Fixes this build warning:
<stdin>:395:2: warning: #warning syscall umount2 not implemented
Signed-off-by: Tony Luck <tony.luck@intel.com> | ```diff
diff --git a/arch/ia64/include/asm/unistd.h b/arch/ia64/include/asm/unistd.h
index 61474f9156e7..5a5347f5c4e4 100644
--- a/arch/ia64/include/asm/unistd.h
+++ b/arch/ia64/include/asm/unistd.h
@@ -329,6 +329,7 @@
#define __IGNORE_utime /* utimes() */
#define __IGNORE_getpgrp /* getpgid() */
#define __IGNORE_v... |
1a2c4b3147ac0645605d6def2855478861d9361b | Analyze and fix the following issue in the Linux kernel code: imx: Check for NULL pointer deref before calling tty_encode_baud_rate | Problem Details:
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c
index 285b414f3054..5d7b58f1fe42 100644
--- a/drivers/serial/imx.c
+++ b/drivers/serial/imx.c
@@ -924,11 +924,13 @@ imx_set_termios(struct uart_port *port, struct ktermios *termios,
rational_best_approximation(16 * div * baud, sport->port.uartclk,
1 ... |
0ccad87012c6c2e7446e4dc0f0894cf182a5270a | Analyze and fix the following issue in the Linux kernel code: atmel_serial: fix hang in set_termios when crtscts is enabled | Problem Details:
After enabling hardware flow control, any subsequent termios call may hang
waiting for the transmitter to drain. This appears to be caused by a
busy-loop in set_termios() waiting for the transmitter to become empty,
which may take a very long time (or hang indefinitely) if the device at
the other end ... | ```diff
diff --git a/drivers/serial/atmel_serial.c b/drivers/serial/atmel_serial.c
index b3497d7e5354..338b15c0a548 100644
--- a/drivers/serial/atmel_serial.c
+++ b/drivers/serial/atmel_serial.c
@@ -1104,11 +1104,13 @@ static void atmel_set_termios(struct uart_port *port, struct ktermios *termios,
/* update the per-p... |
1aa4bed82a684308f54bf782cffaecd4b1dc3cf4 | Analyze and fix the following issue in the Linux kernel code: tty: fix sanity check | Problem Details:
The WARN_ON() that was added to tty_reopen can be triggered in the specific
case of a hangup occurring during a re-open of a tty which is not in the
middle of being otherwise closed.
In that case however the WARN() is bogus as we don't hold the neccessary
locks to make a correct decision.
The case we... | ```diff
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index 939e198d7670..a3afa0c387cd 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -1263,7 +1263,9 @@ static int tty_reopen(struct tty_struct *tty)
tty->count++;
tty->driver = driver; /* N.B. why do this every time?? */
+ mutex_loc... |
5dca607bcf10d3f08d07ffeac664c6769c336145 | Analyze and fix the following issue in the Linux kernel code: tty: fix unused warning when TCGETX is not defined | Problem Details:
If TCGETX is not defined, we end up with this warning:
drivers/char/tty_ioctl.c: In function ‘tty_mode_ioctl’:
drivers/char/tty_ioctl.c:950: warning: unused variable ‘ktermx’
Since the variable is only used in one case statement, push it down to
the local case scope.
Signed-off-by: Mike Frysinger <va... | ```diff
diff --git a/drivers/char/tty_ioctl.c b/drivers/char/tty_ioctl.c
index 8116bb1c8f80..b24f6c6a1ea3 100644
--- a/drivers/char/tty_ioctl.c
+++ b/drivers/char/tty_ioctl.c
@@ -947,7 +947,6 @@ int tty_mode_ioctl(struct tty_struct *tty, struct file *file,
void __user *p = (void __user *)arg;
int ret = 0;
struct ... |
677ca3060c474d7d89941948e32493d9c18c52d2 | Analyze and fix the following issue in the Linux kernel code: ldisc: debug aids | Problem Details:
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/drivers/char/tty_ldisc.c b/drivers/char/tty_ldisc.c
index 874c2486c034..a19e935847b0 100644
--- a/drivers/char/tty_ldisc.c
+++ b/drivers/char/tty_ldisc.c
@@ -207,6 +207,7 @@ static void tty_ldisc_put(struct tty_ldisc *ld)
ldo->refcount--;
module_put(ldo->owner);
spin_unlock_irqrestore(&tty_ld... |
8d2ead743dd54dff1fe3d0f4933e5da8bfe07472 | Analyze and fix the following issue in the Linux kernel code: tty: Fix leaks introduced by the shift to separate ldisc objects | Problem Details:
Gold star for the kmemleak detector.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/drivers/char/tty_ldisc.c b/drivers/char/tty_ldisc.c
index 39c8f86dedd4..94b3e06d73ec 100644
--- a/drivers/char/tty_ldisc.c
+++ b/drivers/char/tty_ldisc.c
@@ -148,8 +148,10 @@ static struct tty_ldisc *tty_ldisc_try_get(int disc)
}
}
spin_unlock_irqrestore(&tty_ldisc_lock, flags);
- if (err)
+... |
43a1a3ed6bf5a1b9ae197b4f5f20033baf19db61 | Analyze and fix the following issue in the Linux kernel code: fsldma: do not clear bandwidth control bits on the 83xx controller | Problem Details:
The 83xx controller does not support the external pause feature. The bit
in the mode register that controls external pause on the 85xx controller
happens to be part of the bandwidth control settings for the 83xx
controller.
This patch fixes the driver so that it only clears the external pause bit
if t... | ```diff
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 10bcf0cb0efc..6e60c77a145c 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -147,10 +147,11 @@ static void dma_start(struct fsl_dma_chan *fsl_chan)
if (fsl_chan->feature & FSL_DMA_CHAN_PAUSE_EXT) {
DMA_OUT(fsl_chan, &fsl_chan->re... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.