id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
1662070a593b5a862b5bf8c843ebfab0deb058a6
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11284): Fix i2c code of flexcop-driver for rare revisions
Problem Details: This patch adds a workaround in the i2c-code of the flexcop-driver to fix support for SkyStar2 rev 2.7. There are not many devices out there, that's why this bug was not revealed earlier. Signed-off-by: Patrick Boettcher <pb@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/b2c2/flexcop-i2c.c b/drivers/media/dvb/b2c2/flexcop-i2c.c index f13783f08f0f..a0cfde18e640 100644 --- a/drivers/media/dvb/b2c2/flexcop-i2c.c +++ b/drivers/media/dvb/b2c2/flexcop-i2c.c @@ -47,6 +47,18 @@ static int flexcop_i2c_read4(struct flexcop_i2c_adapter *i2c, int len = r100...
5fa7b9f3c0f249a4faed6c3e534917199249ead8
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11275): tvaudio: fix mute and s/g_tuner handling
Problem Details: The mute control depends on CHIP_HAS_INPUTSEL, so test for that first. The s/g_tuner code should check whether getmode/setmode is set at the beginning instead of filling in the struct and discovering at the end that this chip doesn't implement audiomodes after all (i.e. is a simple muxer chip). Signe...
```diff diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c index e8ab28532d94..faa9e3dd782f 100644 --- a/drivers/media/video/tvaudio.c +++ b/drivers/media/video/tvaudio.c @@ -1511,6 +1511,8 @@ static int tvaudio_g_ctrl(struct v4l2_subdev *sd, switch (ctrl->id) { case V4L2_CID_AUDIO_MUTE: +...
3fd8ab30c1fe9118a13f4b55172067ee04ef7a67
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11256): dabusb: fix compile warning.
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/dabusb.c b/drivers/media/video/dabusb.c index 384da45807a0..ba3709bec3f0 100644 --- a/drivers/media/video/dabusb.c +++ b/drivers/media/video/dabusb.c @@ -675,7 +675,6 @@ static int dabusb_release (struct inode *inode, struct file *file) static long dabusb_ioctl (struct file *...
ce18c48593746d6c6777bda2488f15c8ae401c9e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11255): dst_ca: fix compile warning.
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/bt8xx/dst_ca.c b/drivers/media/dvb/bt8xx/dst_ca.c index 607d7387fb6f..4601b059b2b2 100644 --- a/drivers/media/dvb/bt8xx/dst_ca.c +++ b/drivers/media/dvb/bt8xx/dst_ca.c @@ -554,16 +554,17 @@ free_mem_and_exit: static long dst_ca_ioctl(struct file *file, unsigned int cmd, unsigne...
195784b8efd53c1034c6b6d5c8d8d4d25b91d505
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11253): saa7134: fix RTD Embedded Technologies VFG7350 support.
Problem Details: This card has the saa6752hs on 7-bit address 0x21 instead of 0x20. Add support in the card definition struct to select which address to use and update the definitions accordingly. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c index 265a52ff8c33..3a038133b260 100644 --- a/drivers/media/video/saa7134/saa7134-cards.c +++ b/drivers/media/video/saa7134/saa7134-cards.c @@ -273,6 +273,7 @@ struct saa7134_board saa7134_boards[] = { .rad...
e7ddcd98a179c441d54fe84d221cea4e5852b235
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11251): tuner: prevent invalid initialization of t->config in set_type
Problem Details: Drivers that don't set "config" directly in the set_type function will end up with an invalid configuration value. Check that the value is sane, otherwise initialize to 0. Thanks to James Edward Geiger & Steven Toth for reporting this bug. Cc: Steven Toth <stoth@linuxtv.org> Cc: James Edward Geiger <...
```diff diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c index 2a957e2beabf..421475e0ea59 100644 --- a/drivers/media/video/tuner-core.c +++ b/drivers/media/video/tuner-core.c @@ -364,7 +364,8 @@ static void set_type(struct i2c_client *c, unsigned int type, } t->type = type; - t->co...
997fb78e73f3dce23c6fa773128583e1fa15d164
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11248): Remove debug output from stb6100_cfg.h
Problem Details: This patch removes the debug output from stb6100_cfg.h as it is flooding the syslog with tuning data during normal operation. Signed-off-by: Artem Makhutov <artem@makhutov.org> Acked-by: Manu Abraham <abraham.manu@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/frontends/stb6100_cfg.h b/drivers/media/dvb/frontends/stb6100_cfg.h index d3133405dc03..6314d18c797a 100644 --- a/drivers/media/dvb/frontends/stb6100_cfg.h +++ b/drivers/media/dvb/frontends/stb6100_cfg.h @@ -36,7 +36,6 @@ static int stb6100_get_frequency(struct dvb_frontend *fe, u...
9ef77adfb9ac170bcaf449530cf129c48547fd55
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11246): hdpvr: convert printing macros to v4l2_* with struct v4l2_device
Problem Details: it gives us a nice and unique prefix per device Signed-off-by: Janne Grunau <j@jannau.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/hdpvr/hdpvr-control.c b/drivers/media/video/hdpvr/hdpvr-control.c index 51de74aebfcb..06791749d1a0 100644 --- a/drivers/media/video/hdpvr/hdpvr-control.c +++ b/drivers/media/video/hdpvr/hdpvr-control.c @@ -40,9 +40,9 @@ int hdpvr_config_call(struct hdpvr_device *dev, uint value,...
fbc0ae205c5dfb1049a36f0a98cc9211a3a090bb
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11243): cx88: Missing failure checks
Problem Details: The ioremap one was reported in October 2007 (Bug 9146), the kmalloc one was blindingly obvious while looking at the ioremap one The bug suggests some other configuration for lots of I/O memory (32MB per device is ioremapped) but I'll leave that to the real maintainers Signed-off-by: Alan Cox <alan@l...
```diff diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c index b9def8cbcdab..348f6ef08b2a 100644 --- a/drivers/media/video/cx88/cx88-cards.c +++ b/drivers/media/video/cx88/cx88-cards.c @@ -3127,6 +3127,8 @@ struct cx88_core *cx88_core_create(struct pci_dev *pci, int nr) int i...
8737f66e6415e8dbe8c8b26d63692d87a4ad5b29
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11237): media/zoran: fix printk format
Problem Details: Fix printk format warning: drivers/media/video/zoran/zoran_driver.c:345: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'phys_addr_t' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c index 1e87fb9f7146..f16e57cf11e4 100644 --- a/drivers/media/video/zoran/zoran_driver.c +++ b/drivers/media/video/zoran/zoran_driver.c @@ -245,9 +245,9 @@ static int v4l_fbuffer_alloc(struct zoran_fh *fh) SetPage...
cf47d878e5c7825836abf8d37fde025f7676db2b
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11236): tda827x: fix locking issues with DVB-C
Problem Details: Separate tuning table for DVB-C solves tuning problem at 388MHz TechnoTrend C-1501 DVB-C card does not lock on 388MHz. I assume that existing frequency table is valid for DVB-T. This is suggested by the name of the table: tda827xa_dvbt. Added a table for DVB-C with the name tda827xa_dvbc. Added run...
```diff diff --git a/drivers/media/common/tuners/tda827x.c b/drivers/media/common/tuners/tda827x.c index 8cd55a83b381..36a7bc7585ab 100644 --- a/drivers/media/common/tuners/tda827x.c +++ b/drivers/media/common/tuners/tda827x.c @@ -351,7 +351,7 @@ struct tda827xa_data { u8 gc3; }; -static const struct tda827xa_dat...
48f98f7557d35d360470bf6d9fd7b00d04fba828
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11231): hdpvr: locking fixes
Problem Details: unlock io_mutex in hdpvr_stop_streaming hdpvr_disconnect to allow the streaming worker to stop before we flush the workqueue. do not return to user space with mutex held in vidioc_encoder_cmd with an unknown encoder command. Signed-off-by: Janne Grunau <j@jannau.net> Signed-off-by: Mauro Carvalho Cheh...
```diff diff --git a/drivers/media/video/hdpvr/hdpvr-core.c b/drivers/media/video/hdpvr/hdpvr-core.c index 2c49862b6d32..547833eb6cec 100644 --- a/drivers/media/video/hdpvr/hdpvr-core.c +++ b/drivers/media/video/hdpvr/hdpvr-core.c @@ -390,8 +390,10 @@ static void hdpvr_disconnect(struct usb_interface *interface) vide...
aeecea26234011c3fbf65ffa7d9c9525b486acab
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11225): v4lgrab: fix compilation warnings
Problem Details: Documentation/video4linux/v4lgrab.c: In function ‘main’: Documentation/video4linux/v4lgrab.c:193: warning: ‘src_depth’ is used uninitialized in this function Documentation/video4linux/v4lgrab.c:108: warning: ‘b’ may be used uninitialized in this function Documentation/video4linux/v4lgrab.c:108: warning...
```diff diff --git a/Documentation/video4linux/v4lgrab.c b/Documentation/video4linux/v4lgrab.c index d6e70bef8ad0..05769cff1009 100644 --- a/Documentation/video4linux/v4lgrab.c +++ b/Documentation/video4linux/v4lgrab.c @@ -105,8 +105,8 @@ int main(int argc, char ** argv) struct video_picture vpic; unsigned char...
3dee4dfed34b579ecc9533881cdabb961d92d5c7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11221): gspca - sonixj: Prefer sonixj instead of sn9c102 for 0471:0327.
Problem Details: Prefer the gspca sonixj driver for the Philips SPC600NC webcam instead of the sn9c102 driver. As we've got userreports that it works with the gspca driver, whereas it fails with the sn9c102 driver, see: https://bugzilla.redhat.com/show_bug.cgi?id=477111 Signed-off-by: Hans de Goede <hdegoede@redhat.co...
```diff diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c index 7d0d949b72ba..c72e19d3ac37 100644 --- a/drivers/media/video/gspca/sonixj.c +++ b/drivers/media/video/gspca/sonixj.c @@ -2189,9 +2189,7 @@ static const __devinitdata struct usb_device_id device_table[] = { #endif {USB_D...
fd28aeafd6aecf203d750871616902cbdb537e99
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11202): pvrusb2: Fix slightly mis-leading header in debug interface output
Problem Details: Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-debugifc.c b/drivers/media/video/pvrusb2/pvrusb2-debugifc.c index cc4ef891b5b6..2074ce05c76a 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-debugifc.c +++ b/drivers/media/video/pvrusb2/pvrusb2-debugifc.c @@ -147,7 +147,7 @@ int pvr2_debugifc_print_info(struct p...
7dfdf1ee14c245180f26d23231e690a80b2c6225
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11201): pvrusb2: Fix space-after-comma idiocy
Problem Details: Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c index 099b0d439560..0cfe0eec34ea 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c @@ -3032,7 +3032,7 @@ static void pvr2_subdev_update(struct pvr2_hdw *hdw) ...
851981a1ee0b7cf3726eb6aed267035b4f094336
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11197): pvrusb2: Fix incorrectly named sub-device ID
Problem Details: Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-devattr.h b/drivers/media/video/pvrusb2/pvrusb2-devattr.h index 1339a32a2a1b..30aa7a440990 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-devattr.h +++ b/drivers/media/video/pvrusb2/pvrusb2-devattr.h @@ -38,7 +38,7 @@ #define PVR2_CLIENT_ID_CX25840 2 #define ...
5f757ddd5f193f54a5a7498d32568b630583503e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11186): pvrusb2: Fix bugs involved in listing of sub-devices
Problem Details: Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c index 937c85c5c037..b10b90d97578 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c @@ -4855,7 +4855,7 @@ static unsigned int pvr2_hdw_report_unlocked(struct pvr...
3ab8d295156a43fc2751483d2f82a63c97489f89
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11185): pvrusb2: Fix uninitialized counter
Problem Details: Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c index 24b7413f5c99..937c85c5c037 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c @@ -1979,7 +1979,7 @@ static unsigned int pvr2_copy_i2c_addr_list( unsigned...
1e481cca49bf1c444562f5b86a0e5315d68640c7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11181): pvrusb2: Fix silly 80 column issue
Problem Details: Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-video-v4l.c b/drivers/media/video/pvrusb2/pvrusb2-video-v4l.c index 1c9ed5e85c80..c7a1621cf140 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-video-v4l.c +++ b/drivers/media/video/pvrusb2/pvrusb2-video-v4l.c @@ -263,7 +263,8 @@ void pvr2_saa7115_subdev_update(s...
858f910e869d1300c1ab0cadbe9908322f8bfb78
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11174): pvrusb2: Implement reporting of connected sub-devices
Problem Details: The pvrusb2 driver has a function that reports internal state. It can be accessed from either the debug interface or as the result of a v4l log status request. This change adds information listing sub-devices to the report. Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Ch...
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c index 2f9667e62bb1..bd4e374e37f8 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c @@ -4779,6 +4779,29 @@ static unsigned int pvr2_hdw_report_unlocked(struct pv...
20ae26c84e48b95177e334fa9022f68aa3b77df6
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11173): pvrusb2: Fix backwards function header comments
Problem Details: Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-debugifc.h b/drivers/media/video/pvrusb2/pvrusb2-debugifc.h index e24ff59f8605..2f8d46761cd0 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-debugifc.h +++ b/drivers/media/video/pvrusb2/pvrusb2-debugifc.h @@ -22,16 +22,16 @@ struct pvr2_hdw; -/* Non-intrusi...
d8f5b9ba82482cab344c2d54c2c487b607e34864
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11165): pvrusb2: Tie in debug register access to sub-devices
Problem Details: Implement tie-in for v4l2 debug register access such that the appropriate attached sub-device is handled. Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c index 9669d6a4fb9e..4e50e7bc5745 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c @@ -4925,7 +4925,10 @@ int pvr2_hdw_register_access(struct pvr2_hdw *hdw, r...
446dfdc6cc62890098a1b92a4a84019a34dce0cc
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11162): pvrusb2: Tie up loose ends with v4l2-subdev setup
Problem Details: Tie up loose ends with v4l2-subdev setup. Set attached module's group ID to match our internal ID, emit a few useful messages when sub-devices are dealt with, implement better error legs, and fix an error in the old i2c layer (caused by changes related to the v4l2-subdev work here). Signed-off-by: Mi...
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c index 0e0d086bb278..c764f360a774 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c @@ -2020,17 +2020,26 @@ static void pvr2_hdw_load_subdev(struct pvr2_hdw *hdw...
c457377a3a18117aa99653f3715d81960a1c6bda
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11152): hdpvr: Fix build with Config_I2C not set
Problem Details: Signed-off-by: Janne Grunau <j@jannau.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/hdpvr/Makefile b/drivers/media/video/hdpvr/Makefile index 79ad2e16cb8f..e0230fcb2e36 100644 --- a/drivers/media/video/hdpvr/Makefile +++ b/drivers/media/video/hdpvr/Makefile @@ -1,4 +1,6 @@ -hdpvr-objs := hdpvr-control.o hdpvr-core.o hdpvr-i2c.o hdpvr-video.o +hdpvr-objs := hdpv...
fadadb7d7ad1d6c09863fcf24f83e59f596201ed
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11142): au0828: fix oops on ARM platform when allocating transfer buffers
Problem Details: Add missing URB_NO_TRANSFER_DMA_MAP flag, since the use of consistent memory is not permitted for DMA on the ARM platform. Thanks to Paul Thomas <pthomas8589@gmail.com> for providing sample ARM hardware that was experiencing the oops (tested on the at91rm9200 based LinuxStamp). Thanks to David Browne...
```diff diff --git a/drivers/media/video/au0828/au0828-video.c b/drivers/media/video/au0828/au0828-video.c index d3a388af46e7..f7ad4958b94e 100644 --- a/drivers/media/video/au0828/au0828-video.c +++ b/drivers/media/video/au0828/au0828-video.c @@ -267,7 +267,7 @@ int au0828_init_isoc(struct au0828_dev *dev, int max_pack...
9a4f8201a5d241dd725c1e1c796d826e49dcd396
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11141): em28xx: fix oops on ARM platform when allocating transfer buffers
Problem Details: Add missing URB_NO_TRANSFER_DMA_MAP flag, since the use of consistent memory is not permitted for DMA on the ARM platform. Thanks to Paul Thomas <pthomas8589@gmail.com> for providing sample ARM hardware that was experiencing the oops (tested on the at91rm9200 based LinuxStamp). Thanks to David Browne...
```diff diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c index c896d24032f5..8f1999ca4803 100644 --- a/drivers/media/video/em28xx/em28xx-core.c +++ b/drivers/media/video/em28xx/em28xx-core.c @@ -982,7 +982,7 @@ int em28xx_init_isoc(struct em28xx *dev, int max_packets, ...
f876897015e15e879ad531f78260086a7fdee813
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11140): usbvision: fix oops on ARM platform when allocating transfer buffers
Problem Details: Add missing URB_NO_TRANSFER_DMA_MAP flag, since the use of consistent memory is not permitted for DMA on the ARM platform. Thanks to Paul Thomas <pthomas8589@gmail.com> for providing sample ARM hardware that was experiencing the oops (tested on the at91rm9200 based LinuxStamp). Thanks to David Browne...
```diff diff --git a/drivers/media/video/usbvision/usbvision-core.c b/drivers/media/video/usbvision/usbvision-core.c index 71cb4aabdf7d..a0feb1c97736 100644 --- a/drivers/media/video/usbvision/usbvision-core.c +++ b/drivers/media/video/usbvision/usbvision-core.c @@ -2503,7 +2503,7 @@ int usbvision_init_isoc(struct usb_...
e86da6f07ed6deebc199368bd0a47b3671829b80
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11125): fix mispelled Hauppauge in HD PVR and PVR USB2 driver comments
Problem Details: Signed-off-by: Janne Grunau <j@jannau.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/hdpvr/hdpvr-control.c b/drivers/media/video/hdpvr/hdpvr-control.c index ecf02c621f13..51de74aebfcb 100644 --- a/drivers/media/video/hdpvr/hdpvr-control.c +++ b/drivers/media/video/hdpvr/hdpvr-control.c @@ -1,5 +1,5 @@ /* - * Hauppage HD PVR USB driver - video 4 linux 2 interfac...
69d94f7ec5edea85da0057c48c4f2877e5bb509e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11118): cafe_ccic: replace debugfs with g/s_register ioctls.
Problem Details: Using VIDIOC_DBG_S/G_REGISTER is the standard way of reading/writing register for advanced debugging under v4l2. In addition, using this means that the cafe_ccic driver doesn't need to have knowledge about the used sensor: the debug ioctl can be passed on to the sensor if it isn't for the host. Signed...
```diff diff --git a/drivers/media/video/cafe_ccic.c b/drivers/media/video/cafe_ccic.c index 3363e501d6d7..2f4293771392 100644 --- a/drivers/media/video/cafe_ccic.c +++ b/drivers/media/video/cafe_ccic.c @@ -33,7 +33,6 @@ #include <linux/list.h> #include <linux/dma-mapping.h> #include <linux/delay.h> -#include <linux...
dcd241c384357e5c146299d45d2ee2f4ad439723
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11111): dvb_dummy_fe: Fix compilation breakage
Problem Details: As reported by Randy Dunlap <randy.dunlap@oracle.com>: ERROR: "dvb_dummy_fe_ofdm_attach" [drivers/media/video/cx231xx/cx231xx-dvb.ko] undefined! This happens since cx231xx DVB part still misses the frontend modules. So, the dummy frontend were used for development. The proper fix is to implement the D...
```diff diff --git a/drivers/media/dvb/frontends/dvb_dummy_fe.h b/drivers/media/dvb/frontends/dvb_dummy_fe.h index 8210f19d56ce..1fcb987d6386 100644 --- a/drivers/media/dvb/frontends/dvb_dummy_fe.h +++ b/drivers/media/dvb/frontends/dvb_dummy_fe.h @@ -25,8 +25,27 @@ #include <linux/dvb/frontend.h> #include "dvb_fronte...
6a39a38e338527effb2703e76aedd856cc7b3683
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11110): au8522/au0828: Fix Kconfig dependencies
Problem Details: au8522 is now dependent of V4L2, as reported by Randy Dunlap <randy.dunlap@oracle.com>: au8522_decoder.c:(.text+0x199898): undefined reference to `v4l2_ctrl_query_fill' au8522_decoder.c:(.text+0x1998b3): undefined reference to `v4l2_ctrl_query_fill' au8522_decoder.c:(.text+0x199944): undefined referen...
```diff diff --git a/drivers/media/dvb/frontends/Kconfig b/drivers/media/dvb/frontends/Kconfig index 5c78f6329d68..a206cee23f73 100644 --- a/drivers/media/dvb/frontends/Kconfig +++ b/drivers/media/dvb/frontends/Kconfig @@ -437,7 +437,7 @@ config DVB_S5H1409 config DVB_AU8522 tristate "Auvitek AU8522 based" - depen...
80c6e358c1b6da0b9aa97e10c82317b7104821bb
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11109): au0828: Fix compilation when VIDEO_ADV_DEBUG = n
Problem Details: As reported by Kyle McMartin and Randy Dunlap: drivers/media/video/au0828/au0828-video.c:1438: error: 'const struct v4l2_subdev_core_ops' has no member named 'g_register' drivers/media/video/au0828/au0828-video.c:1453: error: 'const struct v4l2_subdev_core_ops' has no member named 's_register' This p...
```diff diff --git a/drivers/media/video/au0828/au0828-video.c b/drivers/media/video/au0828/au0828-video.c index 5de968e128f6..d3a388af46e7 100644 --- a/drivers/media/video/au0828/au0828-video.c +++ b/drivers/media/video/au0828/au0828-video.c @@ -1427,6 +1427,7 @@ static int vidioc_streamoff(struct file *file, void *pr...
235f0e4348cc57d5a5fe36d07530ecf6541eeae5
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11100): au8522: fix compilation warning.
Problem Details: normal_i2c and I2C_CLIENT_INSMOD are only necessary for kernels < 2.6.22. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/frontends/au8522_decoder.c b/drivers/media/dvb/frontends/au8522_decoder.c index c9d0eecfbe3c..2617f680bd5f 100644 --- a/drivers/media/dvb/frontends/au8522_decoder.c +++ b/drivers/media/dvb/frontends/au8522_decoder.c @@ -47,15 +47,12 @@ MODULE_LICENSE("GPL"); static int au8522_a...
2eaf396020555973cad7aa5b517c2418eccbca50
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11079): au0828: fix panic on disconnect if analog initialization failed
Problem Details: If the analog initialization failed to create the video device, we never actually add the entry to the au0828_devlist. Therefore a panic occurs when unregistering the analog subsystem. Make it so we only remove the entry from the list if we added it to the list in the first place. Signed-off-by: Dev...
```diff diff --git a/drivers/media/video/au0828/au0828-video.c b/drivers/media/video/au0828/au0828-video.c index 4c77aebfe6ee..6abdd8bf4494 100644 --- a/drivers/media/video/au0828/au0828-video.c +++ b/drivers/media/video/au0828/au0828-video.c @@ -700,9 +700,10 @@ void au0828_analog_unregister(struct au0828_dev *dev) ...
fc4ce6cd9855dcd1151a9afc067ea354179089f9
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11077): au0828: properly handle missing analog USB endpoint
Problem Details: Move the setup of the analog isoc handler into au0828-video.c, so it does not occur if there is not an .input section defined for the board. Also fixes a case where if there is an input section but the board does not actually have analog support, the digital support will continue to work as expected. ...
```diff diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/video/au0828/au0828-core.c index f47fd9d78fa0..2b5ade626e57 100644 --- a/drivers/media/video/au0828/au0828-core.c +++ b/drivers/media/video/au0828/au0828-core.c @@ -165,11 +165,9 @@ static void au0828_usb_disconnect(struct usb_interface *inte...
d9109bef4b4f501eee94ae68bf876f765d5c6941
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11076): au0828: make g_chip_ident call work properly
Problem Details: Make the g_chip_ident call work for the au0828/au8522. Discovered when testing with the v4l2_compliance tool Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> [mchehab@redhat.com: fix merge conflict, due to a path change for analog demod] ...
```diff diff --git a/drivers/media/dvb/frontends/au8522_decoder.c b/drivers/media/dvb/frontends/au8522_decoder.c index e2927c145cd8..564636389bae 100644 --- a/drivers/media/dvb/frontends/au8522_decoder.c +++ b/drivers/media/dvb/frontends/au8522_decoder.c @@ -636,6 +636,7 @@ static int au8522_queryctrl(struct v4l2_subde...
b80f770a981db1d1f5a41626792c701f8c5bf973
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11075): au0828: make register debug lines easier to read
Problem Details: Make it a little easier to read the debug messages for register read/write operations Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/video/au0828/au0828-core.c index 0bc85b7d67d4..f47fd9d78fa0 100644 --- a/drivers/media/video/au0828/au0828-core.c +++ b/drivers/media/video/au0828/au0828-core.c @@ -51,13 +51,13 @@ static int recv_control_msg(struct au0828_dev *dev, u16 reque...
dc8685b565d6526aca6aaefb80059d115c124821
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11074): au0828: fix i2c enumeration bug
Problem Details: There was a bug where enumerating the i2c for devices would result in false positives. The root of the issue was the scanning was using SMBUS_QUICK messages, which are zero length write requests (which our i2c adapter implementation didn't handle). Because we never strobed any bytes onto the bus, the...
```diff diff --git a/drivers/media/video/au0828/au0828-i2c.c b/drivers/media/video/au0828/au0828-i2c.c index ee3e3040d54c..d57a38f5c738 100644 --- a/drivers/media/video/au0828/au0828-i2c.c +++ b/drivers/media/video/au0828/au0828-i2c.c @@ -156,6 +156,24 @@ static int i2c_sendbytes(struct i2c_adapter *i2c_adap, dprin...
32c000ad93fe8c447342632024ddef1ca516a0e9
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11067): au0828: workaround a bug in the au0828 i2c handling
Problem Details: There is an issue related to the i2c clock for addressing the xc5000. The au0828 chip does not support clock stretching, which the xc5000 makes use of. This results in cases where we silently get back garbage in i2c read operations. To work around this issue until we slow down the i2c clock when talk...
```diff diff --git a/drivers/media/video/au0828/au0828-i2c.c b/drivers/media/video/au0828/au0828-i2c.c index d618fbaade1b..ee3e3040d54c 100644 --- a/drivers/media/video/au0828/au0828-i2c.c +++ b/drivers/media/video/au0828/au0828-i2c.c @@ -140,7 +140,16 @@ static int i2c_sendbytes(struct i2c_adapter *i2c_adap, dprintk...
083a17317be27a0f33d999b4360320b322a8b55b
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11062): au8522: fix register read/write high bits
Problem Details: For the i2c messages to read and write registers, the two high order bits of the first byte dictates whether it is a read or a write operation. Thanks to Michael Krufky <mkrufky@linuxtv.org> and Steven Toth <stoth@linuxtv.org> for providing sample hardware, engineering level support, and testing. Sig...
```diff diff --git a/drivers/media/dvb/frontends/au8522_dig.c b/drivers/media/dvb/frontends/au8522_dig.c index 8082547c73e2..17bdbe2c67e6 100644 --- a/drivers/media/dvb/frontends/au8522_dig.c +++ b/drivers/media/dvb/frontends/au8522_dig.c @@ -40,7 +40,7 @@ static int debug; int au8522_writereg(struct au8522_state *sta...
ea2278633ab4728c41b4043f47df4d3e39131992
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11059): xc5000: fix bug for hybrid xc5000 devices with IF other than 5380
Problem Details: The xc5000 driver has a bug where the IF is always set to whatever the first caller to dvb_attach() provides. This fails when the device requires an IF other than 5380 and the analog driver is loaded first through tuner-core (which always supplies the hard-coded value of 5380). Thanks to Michael Kruf...
```diff diff --git a/drivers/media/common/tuners/xc5000.c b/drivers/media/common/tuners/xc5000.c index ef4bdf2315f1..b54598550dc4 100644 --- a/drivers/media/common/tuners/xc5000.c +++ b/drivers/media/common/tuners/xc5000.c @@ -973,8 +973,6 @@ struct dvb_frontend *xc5000_attach(struct dvb_frontend *fe, case 1: /* n...
e9d4a6d5ef58a700d3add96ffb984741c6e34fff
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11057): Fix CiMax stability in Netup Dual DVB-S2 CI
Problem Details: It appears TS discontinuity about one per 10 hrs if CAM used. Patch to fix it. Signed-off-by: Abylay Ospan <aospan@netup.ru> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/frontends/stv0900_core.c b/drivers/media/dvb/frontends/stv0900_core.c index da414b12247f..8499bcf7f251 100644 --- a/drivers/media/dvb/frontends/stv0900_core.c +++ b/drivers/media/dvb/frontends/stv0900_core.c @@ -250,7 +250,7 @@ enum fe_stv0900_error stv0900_initialize(struct stv09...
f1bee6994426c3a1435ee8d214b1c426a009784f
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11056): Bug fix in NetUP: restore high address lines in CI
Problem Details: CI high address lines disappears due to wrong data type used. Patch to fix it. Signed-off-by: Abylay Ospan <aospan@netup.ru> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/cx23885/cimax2.c b/drivers/media/video/cx23885/cimax2.c index 2105c2e4cf46..9a6536998d90 100644 --- a/drivers/media/video/cx23885/cimax2.c +++ b/drivers/media/video/cx23885/cimax2.c @@ -157,7 +157,7 @@ int netup_ci_get_mem(struct cx23885_dev *dev) } int netup_ci_op_cam(struc...
5765348cd41c17c797765174d479508ecfbd43de
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11055): Fix typo in stv0900
Problem Details: Signed-off-by: Igor M. Liplianin <liplianin@netup.ru> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/frontends/stv0900_core.c b/drivers/media/dvb/frontends/stv0900_core.c index 5c8835ed7338..da414b12247f 100644 --- a/drivers/media/dvb/frontends/stv0900_core.c +++ b/drivers/media/dvb/frontends/stv0900_core.c @@ -667,7 +667,7 @@ static s32 stv0900_carr_get_quality(struct dvb_fronte...
33470423aba5da982dc944658da232942824f2d5
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11048): zoran: fix incorrect return type of notify function.
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/zoran/zoran_card.c b/drivers/media/video/zoran/zoran_card.c index ec9b6ef56090..f91bba435ed5 100644 --- a/drivers/media/video/zoran/zoran_card.c +++ b/drivers/media/video/zoran/zoran_card.c @@ -1196,7 +1196,7 @@ zoran_setup_videocodec (struct zoran *zr, return m; } -static ...
c98afbfc20355dd04a7b817b232e06a4c3e73bac
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11035): mt9t031 bugfix
Problem Details: - The video device is not allocated when mt9t031_init() is called, don't use it in debug printk. - The clock polarity is inverted in mt9t031_set_bus_param(), use the correct one. Signed-off-by: Philippe Rétornaz <philippe.retornaz@epfl.ch> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> ...
```diff diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c index 677be18df9b3..23f9ce9d67ef 100644 --- a/drivers/media/video/mt9t031.c +++ b/drivers/media/video/mt9t031.c @@ -144,8 +144,6 @@ static int mt9t031_init(struct soc_camera_device *icd) int ret; /* Disable chip output, synchronous...
97215cbd1bc3cc32a2a1b3a94b003c3cbcf95683
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (11029): video: use videobuf_waiton() in sh_mobile_ceu free_buffer()
Problem Details: Make sure videobuf_waiton() is used before freeing a buffer. Without this fix we may return the buffer to the allocator before the bus mastering operation is finished. Reported-by: Matthieu CASTET <matthieu.castet@parrot.com> Tested-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> Signed-off-by: ...
```diff diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c index 55a5eae77bab..b5e37a530c62 100644 --- a/drivers/media/video/sh_mobile_ceu_camera.c +++ b/drivers/media/video/sh_mobile_ceu_camera.c @@ -174,6 +174,7 @@ static void free_buffer(struct videobuf_queue *vq, ...
afd96668d8491f762e35c16ce65781da820a67fa
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10987): cx23885: fix crash on non-netup cards
Problem Details: The new support for the CX23885_BOARD_NETUP_DUAL_DVBS2_CI board broke the existing boards. Interrupts for the netup part were enabled and handled without testing whether the current board actually had a netup -> instant and fatal crash. I've added tests to do this only for the CX23885_BOARD_NETUP_DUAL...
```diff diff --git a/drivers/media/video/cx23885/cx23885-core.c b/drivers/media/video/cx23885/cx23885-core.c index 1b401457d42e..d19d453cf62a 100644 --- a/drivers/media/video/cx23885/cx23885-core.c +++ b/drivers/media/video/cx23885/cx23885-core.c @@ -1699,7 +1699,8 @@ static irqreturn_t cx23885_irq(int irq, void *dev_i...
9832d765f82769799ba15ac9d2e8edf8f7de6898
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10986): mr97310a: don't discard frame headers on stream output
Problem Details: Fix a bug where all frame headers were being discarded, instead of being part of the stream output, on MR97310A cameras. The frame headers contain information which may be useful in processing the video output and therefore should be kept and not discarded. A corresponding patch to the decompression ...
```diff diff --git a/drivers/media/video/gspca/mr97310a.c b/drivers/media/video/gspca/mr97310a.c index 5ec5ce6e3ed9..2a901a4a6f00 100644 --- a/drivers/media/video/gspca/mr97310a.c +++ b/drivers/media/video/gspca/mr97310a.c @@ -29,9 +29,7 @@ MODULE_LICENSE("GPL"); /* specific webcam descriptor */ struct sd { struct ...
34aecd2851bba5c2b7dae2f0dbe8e629b1c5e4ac
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10962): fired-avc: fix printk formatting warning.
Problem Details: size_t should be printed with %zu. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/firewire/firedtv-avc.c b/drivers/media/dvb/firewire/firedtv-avc.c index 32526f103b59..12f7730184ad 100644 --- a/drivers/media/dvb/firewire/firedtv-avc.c +++ b/drivers/media/dvb/firewire/firedtv-avc.c @@ -151,7 +151,7 @@ static void debug_fcp(const u8 *data, int length) subunit_...
d8cd5e6c240bb3ff55e42afaa446c178ef8bb403
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10960): omap24xxcam: don't set vfl_type.
Problem Details: The vfl_type field is set by the core, so anything you fill in here will be overwritten. And it will be set to a VFL_TYPE_ value, not a VID_TYPE_ value which is an obsolete V4L1 type. Since these V4L1 types have been made unavailable for V4L2 drivers, this driver stopped compiling. In this case the f...
```diff diff --git a/drivers/media/video/omap24xxcam.c b/drivers/media/video/omap24xxcam.c index 805faaea6449..2cea7fee9b51 100644 --- a/drivers/media/video/omap24xxcam.c +++ b/drivers/media/video/omap24xxcam.c @@ -1665,7 +1665,6 @@ static int omap24xxcam_device_register(struct v4l2_int_device *s) vfd->parent = cam->...
1fab14ed1acf791e990138c4acdaf4520962f2d5
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10951): xc5000: Fix CodingStyle errors introduced by the last patch
Problem Details: Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/common/tuners/xc5000.c b/drivers/media/common/tuners/xc5000.c index 98654dbeafa4..ef4bdf2315f1 100644 --- a/drivers/media/common/tuners/xc5000.c +++ b/drivers/media/common/tuners/xc5000.c @@ -739,10 +739,10 @@ static int xc5000_set_analog_params(struct dvb_frontend *fe, dprintk(1, "...
7d7b4b635298fcf4c205a89486eb5f397c130f5b
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10946): radio-rtrack2: fix double mutex_unlock
Problem Details: Patch fixes double mutex unlocking. Signed-off-by: Alexey Klimov <klimov.linux@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/radio/radio-rtrack2.c b/drivers/media/radio/radio-rtrack2.c index 08bd8d9dc4f1..202085978116 100644 --- a/drivers/media/radio/radio-rtrack2.c +++ b/drivers/media/radio/radio-rtrack2.c @@ -60,7 +60,6 @@ static void rt_mute(struct rtrack2 *dev) mutex_lock(&dev->lock); outb(1, dev->i...
5c8e2403ba06d39f04f6ae62f3afe5542e0eb533
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10945): pwc : fix LED and power setup for first open
Problem Details: Call pwc_construct before trying to talk to device to obtain vc interface so that LED and power setup works the first time the video device is opened. Signed-off-by: Martin Fuzzey <mfuzzey@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c index a7c2e7284c20..7c542caf248e 100644 --- a/drivers/media/video/pwc/pwc-if.c +++ b/drivers/media/video/pwc/pwc-if.c @@ -1125,6 +1125,7 @@ static int pwc_video_open(struct file *file) } mutex_lock(&pdev->modlock); + pwc_cons...
e8944282a76f94bcf84ae3b7a91328bd03835ea1
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10923): saa7134: fix typo in product name
Problem Details: replace occurances of "HVR1150" with "HVR1120" - this was a typo. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/Documentation/video4linux/CARDLIST.saa7134 b/Documentation/video4linux/CARDLIST.saa7134 index 325c69fe91fd..626820e519e3 100644 --- a/Documentation/video4linux/CARDLIST.saa7134 +++ b/Documentation/video4linux/CARDLIST.saa7134 @@ -153,5 +153,5 @@ 152 -> Asus Tiger Rev:1.00 [104...
9f1a693f76700018d921cd7af86f7c994a300613
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10920): v4l2-ioctl: fix partial-copy code.
Problem Details: The code to optimize the usercopy only checked the ioctl NR field. However, this code is also called for non-V4L2 ioctls (either private or ioctls from linux/dvb/audio.h and linux/dvb/video.h for decoder drivers like ivtv). If such an ioctl has the same NR as a V4L2 ioctl, then disaster strikes. Modi...
```diff diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index df8d1ff1a577..54ba6b0b951f 100644 --- a/drivers/media/video/v4l2-ioctl.c +++ b/drivers/media/video/v4l2-ioctl.c @@ -1796,11 +1796,12 @@ static long __video_do_ioctl(struct file *file, static unsigned long cmd_input_size(unsi...
cc5cef8ea4fdc41b44007c5d2c116fe97cb87293
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10914): v4l2: fix compile warnings when printing u64 value.
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/adv7170.c b/drivers/media/video/adv7170.c index 43fd1d24cdeb..873c30a41bd7 100644 --- a/drivers/media/video/adv7170.c +++ b/drivers/media/video/adv7170.c @@ -195,7 +195,7 @@ static int adv7170_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std) { struct adv7170 *encoder = t...
9185cbfc336a080695304bcb781186559d987974
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10912): vivi: fix compile warning.
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index 980620f411f0..fbfefae7886f 100644 --- a/drivers/media/video/vivi.c +++ b/drivers/media/video/vivi.c @@ -1406,7 +1406,7 @@ free_dev: */ static int __init vivi_init(void) { - int ret, i; + int ret = 0, i; if (n_devs <= 0) n_devs...
0aab2e6044037c34ccb5fe94c616e532ba95f541
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10897): Fix Kbuild MEDIA_TUNER_CUSTOMIZE dependencies
Problem Details: Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/common/tuners/Kconfig b/drivers/media/common/tuners/Kconfig index 7969b695cb50..724e6870c412 100644 --- a/drivers/media/common/tuners/Kconfig +++ b/drivers/media/common/tuners/Kconfig @@ -66,14 +66,14 @@ config MEDIA_TUNER_TDA8290 config MEDIA_TUNER_TDA827X tristate "Philips TDA827...
78175bf2c5e4beb0874aee27dcfce58c4c7d4fb4
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10871): stv0900: delete debug messages not related to stv0900 tuning algorythm
Problem Details: Signed-off-by: Igor M. Liplianin <liplianin@netup.ru> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/frontends/stv0900_core.c b/drivers/media/dvb/frontends/stv0900_core.c index ca26518eafcd..3cc6626fe633 100644 --- a/drivers/media/dvb/frontends/stv0900_core.c +++ b/drivers/media/dvb/frontends/stv0900_core.c @@ -59,20 +59,10 @@ static struct stv0900_inode *find_inode(struct i2c_ad...
cb95a40e54b96938c2e81de6a95609e915922962
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10855): cx18: Fix VPS service register codes
Problem Details: Based on a documentation clarification from Conexant, fix the register code used for sliced VBI VPS service. Signed-off-by: Andy Walls <awalls@radix.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/cx18/cx18-av-vbi.c b/drivers/media/video/cx18/cx18-av-vbi.c index 43267d1afb92..27699839b80d 100644 --- a/drivers/media/video/cx18/cx18-av-vbi.c +++ b/drivers/media/video/cx18/cx18-av-vbi.c @@ -142,7 +142,7 @@ int cx18_av_vbi(struct cx18 *cx, unsigned int cmd, void *arg) 0, ...
583803d135b14d414e77b6d2b546a811cac9944e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10853): cx18: Fix s-parse warnings and a logic error about extracting the VBI PTS
Problem Details: My s-parse builds never griped about be32_to_cpu() casting to __be32, but Hans' builds did. This change explictly declares the pointer into the VBI buffer header as __be32, which is the correct thing to do as the data is always big endian when we go to fetch it. Hopefully this will quiet s-parse warn...
```diff diff --git a/drivers/media/video/cx18/cx18-vbi.c b/drivers/media/video/cx18/cx18-vbi.c index a81fe2e985f2..355737bff13e 100644 --- a/drivers/media/video/cx18/cx18-vbi.c +++ b/drivers/media/video/cx18/cx18-vbi.c @@ -169,7 +169,7 @@ void cx18_process_vbi_data(struct cx18 *cx, struct cx18_buffer *buf, int s...
72401b7a37c6f0132ea2d0c3236ec706a9e5759e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10851): cx18: Fix a video scaling check problem introduced by sliced VBI changes
Problem Details: Fix a scaling check that was failing, due to a magic number I missed fixing during previous slice VBI changes. Now $ v4l2-ctl -v width=480,height=480,pixelformat=MPEG yields proper visual results again. Signed-off-by: Andy Walls <awalls@radix.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@red...
```diff diff --git a/drivers/media/video/cx18/cx18-av-core.c b/drivers/media/video/cx18/cx18-av-core.c index cf256a999bd4..aeeb3cfa3390 100644 --- a/drivers/media/video/cx18/cx18-av-core.c +++ b/drivers/media/video/cx18/cx18-av-core.c @@ -867,8 +867,22 @@ static int cx18_av_s_fmt(struct v4l2_subdev *sd, struct v4l2_for...
5a771cb186dfa1f663ea15cdff3e32e04a8427e3
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10846): dvb/frontends: fix duplicate 'debug' symbol
Problem Details: Fix dvb frontend debug variable to be static, to avoid linker errors: drivers/built-in.o:(.data+0xf4b0): multiple definition of `debug' arch/x86/kernel/built-in.o:(.kprobes.text+0x90): first defined here ld: Warning: size of symbol `debug' changed from 85 in arch/x86/kernel/built-in.o to 4 in drivers/...
```diff diff --git a/drivers/media/dvb/frontends/stv0900_core.c b/drivers/media/dvb/frontends/stv0900_core.c index ee20fbfc45f4..ca26518eafcd 100644 --- a/drivers/media/dvb/frontends/stv0900_core.c +++ b/drivers/media/dvb/frontends/stv0900_core.c @@ -34,8 +34,8 @@ #include "stv0900_priv.h" #include "stv0900_init.h" ...
632fe9fe440249642845675d97436c667cbbd21e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10843): saa7146: Clean-up i2c error handling
Problem Details: saa7146: Clean-up i2c error handling Simplify i2c error handling and fix incorrect handling of address errors in poll mode. Signed-off-by: Oliver Endriss <o.endriss@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/common/saa7146_i2c.c b/drivers/media/common/saa7146_i2c.c index 76229f992275..7e8f56815998 100644 --- a/drivers/media/common/saa7146_i2c.c +++ b/drivers/media/common/saa7146_i2c.c @@ -293,7 +293,6 @@ static int saa7146_i2c_transfer(struct saa7146_dev *dev, const struct i2c_msg *m in...
2bd1d9eb1c27034a77c8e1887156da72d6160ae1
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10833): em28xx: enable Compro VideoMate ForYou sound
Problem Details: Compro VideoMate uses an external audio DSP chip, controlled via tvaudio module (tda9874a). This patch improves em28xx infrastructure to support an external audio processor and fixes the Compro VideoMate entry to work with it. Signed-off-by: Vitaly Wool <vital@embeddedalley.com> Signed-off-by: Mauro C...
```diff diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c index f7c817765752..650ccfda1428 100644 --- a/drivers/media/video/em28xx/em28xx-cards.c +++ b/drivers/media/video/em28xx/em28xx-cards.c @@ -122,6 +122,22 @@ static struct em28xx_reg_seq default_tuner_gpio[] = { ...
717167e8ae13a61649a1faf867279440fee70b56
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10814): saa7146: some small fixes
Problem Details: vidioc_enum_fmt_vid_overlay() did nothing but call vidioc_enum_fmt_vid_cap(), so just make saa7146_video_ioctl_ops.vidioc_enum_fmt_vid_overlay point to vidioc_enum_fmt_vid_cap() and get ride of vidioc_enum_fmt_vid_overlay(). Have gparm use v4l2_video_std_frame_period to fill in the frame period instea...
```diff diff --git a/drivers/media/common/saa7146_video.c b/drivers/media/common/saa7146_video.c index 8d8cb7ff3478..80352853bb5d 100644 --- a/drivers/media/common/saa7146_video.c +++ b/drivers/media/common/saa7146_video.c @@ -576,11 +576,6 @@ static int vidioc_enum_fmt_vid_cap(struct file *file, void *fh, struct v4l2_...
337f9d205972bfe1cb7982384fd0f4caa4af001d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10812): v4l2: Zero out read-only ioctls in one place
Problem Details: If an ioctl is read-only then the driver fills in all the fields. Lots of times drivers only care about some fields so it's best if video_ioctl2 takes care of zeroing out the entire structure before handing it to the driver. This saves code in each driver to do it and driver authors often forget. Th...
```diff diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 00c0f76b9b5d..64b4fda08dd5 100644 --- a/drivers/media/video/v4l2-ioctl.c +++ b/drivers/media/video/v4l2-ioctl.c @@ -655,8 +655,6 @@ static long __video_do_ioctl(struct file *file, if (cmd == VIDIOCGMBUF) { struct video_m...
55d5834d370416946fda7781a5a9ed394a465580
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10808): Fix typo in lnbp21.c
Problem Details: It was a typo in the function name, it should be lnbh24_attach, and not lnbp24_attach. Signed-off-by: Igor M. Liplianin <liplianin@netup.ru> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/dvb/frontends/lnbp21.c b/drivers/media/dvb/frontends/lnbp21.c index 772a0bbb0dd8..1dcc56f32bff 100644 --- a/drivers/media/dvb/frontends/lnbp21.c +++ b/drivers/media/dvb/frontends/lnbp21.c @@ -138,7 +138,7 @@ static struct dvb_frontend *lnbx2x_attach(struct dvb_frontend *fe, return f...
3d0081dd10d95cf1934b9ff2cf50c596a6d43417
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10783): mxl5007t: fix devname for hybrid_tuner_request_state
Problem Details: Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c index 59b458097d2f..b13de8c4662a 100644 --- a/drivers/media/common/tuners/mxl5007t.c +++ b/drivers/media/common/tuners/mxl5007t.c @@ -827,7 +827,7 @@ struct dvb_frontend *mxl5007t_attach(struct dvb_frontend *fe, mutex...
0d02efe486ef251e2f625fc846cb5f241eb57160
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10772): siano: prevent duplicate variable declaration
Problem Details: Fix the following build error: drivers/media/dvb/siano/smsusb.o: In function `get_order': include/asm-generic/page.h:10: multiple definition of `sms_dbg' drivers/media/dvb/siano/sms1xxx.o:include/asm-generic/page.h:10: first defined here drivers/media/dvb/siano/smsdvb.o: In function `get_order': inclu...
```diff diff --git a/drivers/media/dvb/siano/sms-cards.c b/drivers/media/dvb/siano/sms-cards.c index 66f591937ff5..63e4d0ec6583 100644 --- a/drivers/media/dvb/siano/sms-cards.c +++ b/drivers/media/dvb/siano/sms-cards.c @@ -19,6 +19,10 @@ #include "sms-cards.h" +static int sms_dbg; +module_param_named(cards_dbg, sm...
6246d4e1b30aa9404d2603dc09a823aba36d9c13
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10761): cx18: Change log lines for internal subdevs and fix tveeprom reads
Problem Details: Give messages originating from internal subdevs a header using the subdev's name. Fixed an uninitialized variable problem with reading the EEPROM, noticed from log output. Got rid of the unused cx18_av_exit() function. Signed-off-by: Andy Walls <awalls@radix.net> Signed-off-by: Mauro Carvalho Chehab...
```diff diff --git a/drivers/media/video/cx18/cx18-av-core.c b/drivers/media/video/cx18/cx18-av-core.c index 2128070154d3..cf256a999bd4 100644 --- a/drivers/media/video/cx18/cx18-av-core.c +++ b/drivers/media/video/cx18/cx18-av-core.c @@ -247,6 +247,7 @@ static int cx18_av_init(struct v4l2_subdev *sd, u32 val) void cx...
6da6bf5e43f409672f5525657ff59282e160c59f
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10760): cx18: Fix a memory leak of buffers used for sliced VBI insertion
Problem Details: We leaked buffers every time a device was removed, if the user had enabled sliced VBI insertion into the MPEG stream. MythTV uses that. Signed-off-by: Andy Walls <awalls@radix.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c index 79b3bf5bcec1..544abbfb843e 100644 --- a/drivers/media/video/cx18/cx18-driver.c +++ b/drivers/media/video/cx18/cx18-driver.c @@ -1066,6 +1066,7 @@ static void cx18_remove(struct pci_dev *pci_dev) { struct v4l2_d...
eefe1010a4657959588afc7fb3551cfa4e8bb4a7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10759): cx18: Convert GPIO connected functions to act as v4l2_subdevices
Problem Details: Convert GPIO line functions, such a audio routing and device resets, to v4l2_subdevices. This essentially completes the conversion of cx18 to the v4l2_device/v4l2_subdevice framework. No regression testing has taken place as of yet. Also an ivtv legacy bug with GPIO mux routing and going to/from rad...
```diff diff --git a/drivers/media/video/cx18/cx18-cards.c b/drivers/media/video/cx18/cx18-cards.c index 6644534db564..9bc221837847 100644 --- a/drivers/media/video/cx18/cx18-cards.c +++ b/drivers/media/video/cx18/cx18-cards.c @@ -56,7 +56,7 @@ static const struct cx18_card cx18_card_hvr1600_esmt = { .hw_audio_ctrl =...
5811cf99df2e3c102055be3ea77508e56c9f77c6
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10756): cx18: Slim down instance handling, build names from v4l2_device.name
Problem Details: Convert card instance handling to a lighter weight mechanism like ivtv. Also convert name strings and debug messages to use v4l2_device.name. Signed-off-by: Andy Walls <awalls@radix.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c index 2a45bbc757e8..f69e688ab6f4 100644 --- a/drivers/media/video/cx18/cx18-driver.c +++ b/drivers/media/video/cx18/cx18-driver.c @@ -39,10 +39,6 @@ #include <media/tveeprom.h> - -/* var to keep track of the number...
1a2670465ec94029e5df62e3decca9e2f7aea075
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10755): cx18: Convert the integrated A/V decoder core interface to a v4l2_subdev
Problem Details: This is the next step in converting the cx18 driver to use the v4l2_device/ v4l2_subdevice framework. This is a straightforward conversion of the cx18_av_*[ch] files. It compiles, but leaves the driver in an unlinkable state at the moment. Note, the cx18 integrated A/V digitizer will now make a host...
```diff diff --git a/drivers/media/video/cx18/cx18-av-core.c b/drivers/media/video/cx18/cx18-av-core.c index fc576cf1a8b5..9b30f77b5205 100644 --- a/drivers/media/video/cx18/cx18-av-core.c +++ b/drivers/media/video/cx18/cx18-av-core.c @@ -22,8 +22,10 @@ * 02110-1301, USA. */ +#include <media/v4l2-chip-ident.h> ...
b9391f4160a62f8c44bee6b93dab33cf329857c7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10751): sms1xxx: fix checkpatch.pl violations introduced by previous changeset
Problem Details: Fix checkpatch.pl violations introduced by previous changeset: ERROR: do not use C99 // comments 156: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1373: +//#ifdef DVB_CORE ERROR: do not use C99 // comments 157: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1374: +// smsdvb_unregister(); ERROR...
```diff diff --git a/drivers/media/dvb/siano/sms-cards.c b/drivers/media/dvb/siano/sms-cards.c index 39f83faa226e..4fa86f5b7fc5 100644 --- a/drivers/media/dvb/siano/sms-cards.c +++ b/drivers/media/dvb/siano/sms-cards.c @@ -86,6 +86,7 @@ struct sms_board *sms_get_board(int id) return &sms_boards[id]; } +EXPORT_SYMB...
e0f14c2574ded46b9ec8a1518922d07bc4001c18
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10750): import changes from Siano
Problem Details: Import the following changes from Uri Shkolnik * Two-ways merge with Siano internal repository * Continuing with DVB sub-system separation * kconfig and makefile updates * Code cleanup This is a work-in-progress sync with Siano's internal repository. Some changes had to be altered or dropped in orde...
```diff diff --git a/drivers/media/dvb/siano/Makefile b/drivers/media/dvb/siano/Makefile index ee0737af98c0..bcf93f4828b2 100644 --- a/drivers/media/dvb/siano/Makefile +++ b/drivers/media/dvb/siano/Makefile @@ -1,6 +1,8 @@ -sms1xxx-objs := smscoreapi.o smsusb.o smsdvb.o sms-cards.o +sms1xxx-objs := smscoreapi.o sms-car...
7f6adeaf2d8800b66c5dd6c2cf2622dfdd68bd31
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10730): v4l-dvb: cleanup obsolete references to v4l1 headers.
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> [mchehab@redhat.com: fix compilation of tea575x-tuner.c] Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/common/tuners/mt20xx.c b/drivers/media/common/tuners/mt20xx.c index 35b763a16d53..44608ad4e2d2 100644 --- a/drivers/media/common/tuners/mt20xx.c +++ b/drivers/media/common/tuners/mt20xx.c @@ -6,7 +6,7 @@ */ #include <linux/delay.h> #include <linux/i2c.h> -#include <linux/videodev....
e7946844e676b5d33876d36db92f386a9907a0f4
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10724): saa7110: convert to v4l2_subdev.
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> [mchehab@redhat.com: fix merge conflict with removal of v4l2_ctrl_query_fill_std()] Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/saa7110.c b/drivers/media/video/saa7110.c index 9ef6b2bb1b77..ea16e3cf1793 100644 --- a/drivers/media/video/saa7110.c +++ b/drivers/media/video/saa7110.c @@ -33,15 +33,19 @@ #include <linux/wait.h> #include <asm/uaccess.h> #include <linux/i2c.h> -#include <linux/videodev.h> -...
5ca75b00ffd0df5bae16e84830f2710537efed11
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10712): zoran: fix G_FMT
Problem Details: Returned height was really height / 2. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c index cdfd3cc05151..7129f9254e70 100644 --- a/drivers/media/video/zoran/zoran_driver.c +++ b/drivers/media/video/zoran/zoran_driver.c @@ -2083,7 +2083,7 @@ static int zoran_g_fmt_vid_out(struct file *file, void *__f...
0ba514d5d39d017e320ffba6d2a98563b829d37c
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10711): zoran: fix TRY_FMT support
Problem Details: Actually try to turn the format into something usable rather than just rejecting it if it isn't perfect. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/zoran/zoran_card.c b/drivers/media/video/zoran/zoran_card.c index 18834b18435b..774717bf43cc 100644 --- a/drivers/media/video/zoran/zoran_card.c +++ b/drivers/media/video/zoran/zoran_card.c @@ -835,7 +835,8 @@ zoran_unregister_i2c (struct zoran *zr) int zoran_check_jpg_setti...
3e66793b622feb383dec59d9c044a4c908d7c5c7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10706): zoran: fix field typo.
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c index c7806ac448b2..90ef3ae39c1c 100644 --- a/drivers/media/video/zoran/zoran_driver.c +++ b/drivers/media/video/zoran/zoran_driver.c @@ -2463,7 +2463,7 @@ static int zoran_g_fmt_vid_out(struct file *file, void *__f...
e2d750fcef6dd15afdf327c56156d85085eb4978
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10681): gspca - zc3xx: Bad probe of the ov7630c sensor.
Problem Details: This patch fixes an other bug of the kernel bug report 12737. Signed-off-by: Jean-Francois Moine <moinejf@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/gspca/zc3xx.c b/drivers/media/video/gspca/zc3xx.c index fb9b122ac61d..4f459a746037 100644 --- a/drivers/media/video/gspca/zc3xx.c +++ b/drivers/media/video/gspca/zc3xx.c @@ -7141,6 +7141,10 @@ static int sd_config(struct gspca_dev *gspca_dev, PDEBUG(D_PROBE, "Find Sensor OV7...
603538a085e42c02b9b3184b6104d73e22a7e5d1
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10680): gspca - zc3xx: Bad probe of the ov7xxx sensors.
Problem Details: This patch fixes one bug of the kernel bug report 12737. Signed-off-by: Jean-Francois Moine <moinejf@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/gspca/zc3xx.c b/drivers/media/video/gspca/zc3xx.c index e6a6cb946a21..fb9b122ac61d 100644 --- a/drivers/media/video/gspca/zc3xx.c +++ b/drivers/media/video/gspca/zc3xx.c @@ -6987,7 +6987,7 @@ static int vga_3wr_probe(struct gspca_dev *gspca_dev) static int zcxx_probeSensor(stru...
70e1d353e5d70551c5f69d464c4d194afae62f63
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10673): mt9t031: fix gain and hflip controls, register update, and scaling
Problem Details: Multiple fixes: 1. allow register update by setting the Output Control register to 2 and not 3 2. fix scaling factor calculations 3. recover lost HFLIP control 4. fix Global Gain calculation Signed-off-by: Guennadi Liakhovetski <lg@denx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c index 349d8e365530..acc1fa9db67d 100644 --- a/drivers/media/video/mt9t031.c +++ b/drivers/media/video/mt9t031.c @@ -150,7 +150,7 @@ static int mt9t031_init(struct soc_camera_device *icd) if (ret >= 0) ret = reg_write(icd, MT9T031_RE...
c8329accf7e75a8a8fbe4ad0a15a3eacf221f380
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10672): sh_mobile_ceu_camera: include NV* formats into the format list only once.
Problem Details: Currently, if an soc-camera device, connected to the sh_mobile_ceu_camera camera host driver, supports several formats from the UYVY, VYUY, YUYV, YVYU set, the driver would add four NV* formats for each of them. This patch fixes this misbehaviour. Reported-by: Kuninori Morimoto <morimoto.kuninori@rene...
```diff diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c index 8a1badba70f7..ed3bfc4cf9f9 100644 --- a/drivers/media/video/sh_mobile_ceu_camera.c +++ b/drivers/media/video/sh_mobile_ceu_camera.c @@ -586,11 +586,29 @@ static int sh_mobile_ceu_get_formats(struct soc_cam...
1af1b7a2def2f0936fc95edb5dcb3871934b7852
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10670): tw9910: bit mask operation fix on tw9910_mask_set.
Problem Details: Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c index 8dc3ec79a06f..0558b22fd3fb 100644 --- a/drivers/media/video/tw9910.c +++ b/drivers/media/video/tw9910.c @@ -460,9 +460,11 @@ static int tw9910_mask_set(struct i2c_client *client, u8 command, u8 mask, u8 set) { s32 val = i2c...
66b46e68a52114e7065f0bfd0016276ae5925e70
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10668): ov772x: bit mask operation fix on ov772x_mask_set.
Problem Details: Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/ov772x.c b/drivers/media/video/ov772x.c index 702e61a9c02b..6b18da7c3c0a 100644 --- a/drivers/media/video/ov772x.c +++ b/drivers/media/video/ov772x.c @@ -565,8 +565,11 @@ static int ov772x_mask_set(struct i2c_client *client, u8 set) { s32 val = i2c_smbus_read_byte_da...
5ab6c9af375e27c48bd2e86f4d9f6d68c9ab98fd
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10645): vivi: introduce v4l2_device and do several cleanups
Problem Details: - add v4l2_device - remove BKL - make the debug parameter settable on the fly - set bus_info in querycap Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index 0f25d686ca20..625e9662c7ad 100644 --- a/drivers/media/video/vivi.c +++ b/drivers/media/video/vivi.c @@ -33,12 +33,13 @@ #include <linux/videodev.h> #endif #include <linux/interrupt.h> -#include <media/videobuf-vmalloc.h> -#include <me...
748c01488923fa1b0c94046d731116125dc16a60
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10638): gspca - t613: Bad debug level when displaying the sensor type.
Problem Details: Signed-off-by: Jean-Francois Moine <moinejf@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/gspca/t613.c b/drivers/media/video/gspca/t613.c index 24174ccb62fa..353931023ac8 100644 --- a/drivers/media/video/gspca/t613.c +++ b/drivers/media/video/gspca/t613.c @@ -681,19 +681,19 @@ static int sd_init(struct gspca_dev *gspca_dev) | reg_r(gspca_dev, 0x07); switch (sen...
b7763f9bee2a1a59c0481b408ca42097944e1651
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10633): DAB: fix typo
Problem Details: Fix typo in "DAB adapters" section in Kconfig. Signed-off-by: Márton Németh <nm127@freemail.hu> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index 93ea201f426c..223c36ede5ae 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig @@ -117,7 +117,7 @@ source "drivers/media/dvb/Kconfig" config DAB boolean "DAB adapters" ---help--- - Allow selecting support for for Digital Audio Br...
cb3bf504f7c875070d56e84ce1e28aff8c3b6790
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10632): Added support for AVerMedia Cardbus Hybrid remote control
Problem Details: Added support for I2C device at address 0x40 and subaddress 0x0d/0x0b that provides remote control key reading support for AVerMedia Cardbus Hybrid card, possibly for other AVerMedia Cardbus cards. The I2C address 0x40 doesn't like the SAA7134's 0xfd quirk, so it was disabled. [mchehab@redhat.com: Co...
```diff diff --git a/drivers/media/common/ir-keymaps.c b/drivers/media/common/ir-keymaps.c index d7b205472e1c..97e78f71c60d 100644 --- a/drivers/media/common/ir-keymaps.c +++ b/drivers/media/common/ir-keymaps.c @@ -153,6 +153,65 @@ IR_KEYTAB_TYPE ir_codes_avermedia_m135a[IR_KEYTAB_SIZE] = { }; EXPORT_SYMBOL_GPL(ir_co...
995a65285bde47bbb2a0c3dadc0b8822d47d78f4
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10631): zoran: fix printk format
Problem Details: Fix printk format warning: drivers/media/video/zoran/zoran_driver.c:345: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'phys_addr_t' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c index 120ef235e63d..b81e20912fa7 100644 --- a/drivers/media/video/zoran/zoran_driver.c +++ b/drivers/media/video/zoran/zoran_driver.c @@ -344,9 +344,9 @@ v4l_fbuffer_alloc (struct file *file) SetPageReserved(MA...
92e8c91bd2a0db4b129baf332344f564bdfca941
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10618): gspca - some drivers: Fix compilation warnings.
Problem Details: Signed-off-by: Jean-Francois Moine <moinejf@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/gspca/mr97310a.c b/drivers/media/video/gspca/mr97310a.c index 3a5ddff8f7a6..5ec5ce6e3ed9 100644 --- a/drivers/media/video/gspca/mr97310a.c +++ b/drivers/media/video/gspca/mr97310a.c @@ -73,7 +73,7 @@ static int reg_w(struct gspca_dev *gspca_dev, int len) rc = usb_bulk_msg(gs...
314893605e07547c372ebc6187e28c784ce0b1ed
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10574): saa7134: fix Avermedia E506R composite input
Problem Details: Make correction to composite input plus svideo input to Avermedia E506R Signed-off-by: Tim Farrington <timf@iinet.net.au> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c index 3192ccb5fcfe..107f6d30d007 100644 --- a/drivers/media/video/saa7134/saa7134-cards.c +++ b/drivers/media/video/saa7134/saa7134-cards.c @@ -4323,13 +4323,13 @@ struct saa7134_board saa7134_boards[] = { ...
a7a1c0e60c706fc04c42c020cd9c45b8bfe14e8b
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10571): v4l2-framework.txt: Fixes the videobuf init functions
Problem Details: Documents the driver usage functions, instead of the generic one used by the videobuf specific handlers. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```diff diff --git a/Documentation/video4linux/v4l2-framework.txt b/Documentation/video4linux/v4l2-framework.txt index 8d2db7e09e89..48cdf86248cb 100644 --- a/Documentation/video4linux/v4l2-framework.txt +++ b/Documentation/video4linux/v4l2-framework.txt @@ -558,26 +558,38 @@ announcing that a new buffer were filled. ...
13afaefc0392d377d23ce5b7e1f4f3944a00e1f1
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10565): bttv: fix external mux for RemoteVision MX
Problem Details: Old versions of the bttv driver would use the high nibble of an input's muxsel value to program the GPIO lines enabled via gpiomask2. Apparently this was supposed to be for switching external audio muxes. Anyway, the code that did this was removed sometime in the pre-git 2.6 series. The RemoteVision...
```diff diff --git a/drivers/media/video/bt8xx/bttv-cards.c b/drivers/media/video/bt8xx/bttv-cards.c index 2832bafa3695..df4d7752eb77 100644 --- a/drivers/media/video/bt8xx/bttv-cards.c +++ b/drivers/media/video/bt8xx/bttv-cards.c @@ -1516,8 +1516,7 @@ struct tvcard bttv_tvcards[] = { .svhs = NO_SVHS, ....
15f8eeb2a86b969d82bfca5d54f1fb30c35cf243
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (10564): bttv: fix external mux for PHYTEC VD-009
Problem Details: Old versions of the bttv driver would use the high nibble of an input's muxsel value to program the GPIO lines enabled via gpiomask2. Apparently this was supposed to be for switching external audio muxes. Anyway, the code that did this was removed sometime in the pre-git 2.6 series. These phytec boa...
```diff diff --git a/drivers/media/video/bt8xx/bttv-cards.c b/drivers/media/video/bt8xx/bttv-cards.c index d055c2770469..2832bafa3695 100644 --- a/drivers/media/video/bt8xx/bttv-cards.c +++ b/drivers/media/video/bt8xx/bttv-cards.c @@ -73,6 +73,8 @@ static void sigmaSQ_muxsel(struct bttv *btv, unsigned int input); st...