id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
483a2b3a3182abcb7fcea986d7ea13e793bb00b1
Analyze and fix the following issue in the Linux kernel code: ARM etherh: Fix build failure.
Problem Details: Reported by Russell King: drivers/net/arm/etherh.c:649: error: unknown field 'ndo_set_mac_addr' specified in initializer Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/drivers/net/arm/etherh.c b/drivers/net/arm/etherh.c index 745ac188babe..d15d8b79d8e5 100644 --- a/drivers/net/arm/etherh.c +++ b/drivers/net/arm/etherh.c @@ -646,7 +646,7 @@ static const struct net_device_ops etherh_netdev_ops = { .ndo_get_stats = ei_get_stats, .ndo_set_multicast_list = ei_set...
1b0652eb588e57c3ab230e0291e7da99c7e665e0
Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Fix HP dv5 mic input
Problem Details: Fix HP dv5 (103c:3603) built-in mic input. Reference: kernel bug 12440 http://bugzilla.kernel.org/show_bug.cgi?id=12440 Signed-off-by: Takashi Iwai <tiwai@suse.de> Cc: stable@kernel.org
```diff diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 6d9a4a2aa4af..e6c13963f215 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -90,6 +90,7 @@ enum { STAC_DELL_M4_2, STAC_DELL_M4_3, STAC_HP_M4, + STAC_HP_DV5, STAC_92HD71BXX_MODELS }; @...
dbca1df48e89d8aa59254fdc10ef16c16e73d94e
Analyze and fix the following issue in the Linux kernel code: x86: headers cleanup - setup.h
Problem Details: Impact: cleanup 'make headers_check' warn us about leaking of kernel private (mostly compile time vars) data to userspace in headers. Fix it. Guard this one by __KERNEL__. Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
```diff diff --git a/arch/x86/include/asm/setup.h b/arch/x86/include/asm/setup.h index ebe858cdc8a3..29d31c0d13d6 100644 --- a/arch/x86/include/asm/setup.h +++ b/arch/x86/include/asm/setup.h @@ -1,6 +1,8 @@ #ifndef _ASM_X86_SETUP_H #define _ASM_X86_SETUP_H +#ifdef __KERNEL__ + #define COMMAND_LINE_SIZE 2048 #if...
444027031cd069ea7e48b016cb33bbf201c8a9f0
Analyze and fix the following issue in the Linux kernel code: x86: headers cleanup - prctl.h
Problem Details: Impact: cleanup (internal kernel function exported) 'make headers_check' warn us about leaking of kernel private (mostly compile time vars) data to userspace in headers. Fix it. sys_arch_prctl is completely removed from header since frankly I don't even understand why we describe it here. It is descr...
```diff diff --git a/arch/x86/include/asm/prctl.h b/arch/x86/include/asm/prctl.h index a8894647dd9a..3ac5032fae09 100644 --- a/arch/x86/include/asm/prctl.h +++ b/arch/x86/include/asm/prctl.h @@ -6,8 +6,4 @@ #define ARCH_GET_FS 0x1003 #define ARCH_GET_GS 0x1004 -#ifdef CONFIG_X86_64 -extern long sys_arch_prctl(int, ...
df291fa993c506da89a89264ff8166bccd172a14
Analyze and fix the following issue in the Linux kernel code: kbuild: fix kbuild.txt typos
Problem Details: Fix typos in the new kbuild.txt file. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
```diff diff --git a/Documentation/kbuild/kbuild.txt b/Documentation/kbuild/kbuild.txt index 923f9ddee8f6..f3355b6812df 100644 --- a/Documentation/kbuild/kbuild.txt +++ b/Documentation/kbuild/kbuild.txt @@ -3,7 +3,7 @@ Environment variables KCPPFLAGS -------------------------------------------------- Additional opti...
5cca0cf15a94417f49625ce52e23589eed0a1675
Analyze and fix the following issue in the Linux kernel code: x86, pat: fix reserve_memtype() for legacy 1MB range
Problem Details: Thierry Vignaud reported: > http://bugzilla.kernel.org/show_bug.cgi?id=12372 > > On P4 with an SiS motherboard (video card is a SiS 651) > X server fails to start with error: > xf86MapVidMem: Could not mmap framebuffer (0x00000000,0x2000) (Invalid > argument) Here X is trying to map first 8KB of memor...
```diff diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c index 85cbd3cd3723..070ee4a3b225 100644 --- a/arch/x86/mm/pat.c +++ b/arch/x86/mm/pat.c @@ -333,11 +333,20 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type, req_type & _PAGE_CACHE_MASK); } - is_range_ram = pagerange_is_ram(start...
e720b9e498b6bbb1b4f3b3d2f8e9a78578aafef7
Analyze and fix the following issue in the Linux kernel code: IDE: fix sparse signed-ness errors with host->host_busy
Problem Details: The host_busy field in struct ide_host defaults to a signed-long, where most arch's test_and_set_bit_* macros use an unsigned long. Change to using an unsigned long, which on ARM removes the following sparse errors: drivers/ide/ide-io.c:681:8: warning: incorrect type in argument 2 (different signedne...
```diff diff --git a/include/linux/ide.h b/include/linux/ide.h index 3644f6323384..194da5a4b0d6 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -871,7 +871,7 @@ struct ide_host { ide_hwif_t *cur_port; /* for hosts requiring serialization */ /* used for hosts requiring serialization */ - volatile lon...
2ea5521022ac8f4f528dcbae02668e02a3501a5a
Analyze and fix the following issue in the Linux kernel code: ide: fix suspend regression
Problem Details: On Monday 12 January 2009, Simon Holm Thøgersen wrote: > commit 295f000 ("ide: don't execute the next queued command from the > hard-IRQ context (v2)") breaks suspend to disk for me. On > 'echo disk > /sys/power/state' the systems hangs, letting me switch > virtual consoles, but not responding to Alt+S...
```diff diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c index 4b3bf6a06b70..60538d9c84ee 100644 --- a/drivers/ide/ide-pm.c +++ b/drivers/ide/ide-pm.c @@ -186,12 +186,10 @@ void ide_complete_pm_request(ide_drive_t *drive, struct request *rq) blk_pm_suspend_request(rq) ? "suspend" : "resume"); #endif ...
a294d97742568f429590cf2022d92e4b0c5f6ba0
Analyze and fix the following issue in the Linux kernel code: tx4938ide: Fix build error due to read_sff_dma_status moving
Problem Details: Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
```diff diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c index b4ef218072cd..d9095345f7ca 100644 --- a/drivers/ide/tx4938ide.c +++ b/drivers/ide/tx4938ide.c @@ -202,7 +202,6 @@ static const struct ide_tp_ops tx4938ide_tp_ops = { .exec_command = ide_exec_command, .read_status = ide_read_status, .re...
4180e8334cf8301cf37131bc5d69c0cd724682cb
Analyze and fix the following issue in the Linux kernel code: via82cxxx: fix cable warning message
Problem Details: Remove reference to the removed old-style kernel parameter. Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
```diff diff --git a/drivers/ide/via82cxxx.c b/drivers/ide/via82cxxx.c index fecc0e03c3fc..703c3eeb20a8 100644 --- a/drivers/ide/via82cxxx.c +++ b/drivers/ide/via82cxxx.c @@ -432,8 +432,6 @@ static int __devinit via_init_one(struct pci_dev *dev, const struct pci_device_i if (via_clock < 20000 || via_clock > 50000) { ...
9b896033aa2781d36b2d3f756fe70325fc8487e2
Analyze and fix the following issue in the Linux kernel code: ide: fix accidental LOCKDEP breakage caused by local_irq_set() removal
Problem Details: commit 54cc1428cfa619e16d75baae8cb041a2eff015f0 ("ide: remove local_irq_set() macro") accidentally replaced local_save_flags() by local_irq_set() in ide_probe_port() and __ide_wait_stat() which resulted in LOCKDEP breakage. Reported-by: Larry Finger <Larry.Finger@lwfinger.net> Tested-by: Larry Finger ...
```diff diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c index e728cfe7273f..753b92ebe0ae 100644 --- a/drivers/ide/ide-iops.c +++ b/drivers/ide/ide-iops.c @@ -493,7 +493,7 @@ static int __ide_wait_stat(ide_drive_t *drive, u8 good, u8 bad, unsigned long ti stat = tp_ops->read_status(hwif); if (stat & A...
9316fcacb89c59fe556c48587ac02cd7f5d38045
Analyze and fix the following issue in the Linux kernel code: kernel/up.c: omit it if SMP=y, USE_GENERIC_SMP_HELPERS=n
Problem Details: Fix the sparc build - we were including `up.o' on SMP builds, when CONFIG_USE_GENERIC_SMP_HELPERS=n. Tested-by: Robert Reif <reif@earthlink.net> Fixed-by: Robert Reif <reif@earthlink.net> Cc: David Miller <davem@davemloft.net> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@linux-fo...
```diff diff --git a/kernel/Makefile b/kernel/Makefile index 2aebc4cd7878..170a9213c1b6 100644 --- a/kernel/Makefile +++ b/kernel/Makefile @@ -40,9 +40,8 @@ obj-$(CONFIG_RT_MUTEXES) += rtmutex.o obj-$(CONFIG_DEBUG_RT_MUTEXES) += rtmutex-debug.o obj-$(CONFIG_RT_MUTEX_TESTER) += rtmutex-tester.o obj-$(CONFIG_GENERIC_I...
0d66bf6d3514b35eb6897629059443132992dbd7
Analyze and fix the following issue in the Linux kernel code: mutex: implement adaptive spinning
Problem Details: Change mutex contention behaviour such that it will sometimes busy wait on acquisition - moving its behaviour closer to that of spinlocks. This concept got ported to mainline from the -rt tree, where it was originally implemented for rtmutexes by Steven Rostedt, based on work by Gregory Haskins. Test...
```diff diff --git a/include/linux/mutex.h b/include/linux/mutex.h index 7a0e5c4f8072..3069ec7e0ab8 100644 --- a/include/linux/mutex.h +++ b/include/linux/mutex.h @@ -50,8 +50,10 @@ struct mutex { atomic_t count; spinlock_t wait_lock; struct list_head wait_list; -#ifdef CONFIG_DEBUG_MUTEXES +#if defined(CONFIG_...
41719b03091911028116155deddc5eedf8c45e37
Analyze and fix the following issue in the Linux kernel code: mutex: preemption fixes
Problem Details: The problem is that dropping the spinlock right before schedule is a voluntary preemption point and can cause a schedule, right after which we schedule again. Fix this inefficiency by keeping preemption disabled until we schedule, do this by explicity disabling preemption and providing a schedule() va...
```diff diff --git a/include/linux/sched.h b/include/linux/sched.h index 4cae9b81a1f8..9f0b372cfa6f 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -328,6 +328,7 @@ extern signed long schedule_timeout(signed long timeout); extern signed long schedule_timeout_interruptible(signed long timeout); exter...
18e6959c385f3edf3991fa6662a53dac4eb10d5b
Analyze and fix the following issue in the Linux kernel code: mm: fix assertion
Problem Details: This assertion is incorrect for lockless pagecache. By definition if we have an unpinned page that we are trying to take a speculative reference to, it may become the tail of a compound page at any time (if it is freed, then reallocated as a compound page). It was still a valid assertion for the vmsc...
```diff diff --git a/include/linux/mm.h b/include/linux/mm.h index b91a73fd1bcc..e8ddc98b8405 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -260,7 +260,6 @@ static inline int put_page_testzero(struct page *page) */ static inline int get_page_unless_zero(struct page *page) { - VM_BUG_ON(PageTail(page))...
2465fb6605b4f8f3964b132017bf4078d1265fe9
Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Fix missing initialization of NID 0x0e for STAC925x
Problem Details: The selector widget 0x0e isn't initialized properly in the whole probe process, thus it can be a wrong value depending on the BIOS setup. This patch adds the init verb to set it to the max & unmuted. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 25230f4c888e..6d9a4a2aa4af 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -884,6 +884,8 @@ static struct hda_verb stac92hd71bxx_analog_core_init[] = { static struct hda_verb stac925x_core_ini...
398a153b16b09a68739928d4502455db9725ac86
Analyze and fix the following issue in the Linux kernel code: sched: fix build error in kernel/sched_rt.c when RT_GROUP_SCHED && !SMP
Problem Details: Ingo found a build error in the scheduler when RT_GROUP_SCHED was enabled, but SMP was not. This patch rearranges the code such that it is a little more streamlined and compiles under all permutations of SMP, UP and RT_GROUP_SCHED. It was boot tested on my 4-way x86_64 and it still passes preempt-tes...
```diff diff --git a/kernel/sched.c b/kernel/sched.c index dd1a1466c1e6..2b703f1fac3a 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -466,7 +466,9 @@ struct rt_rq { #if defined CONFIG_SMP || defined CONFIG_RT_GROUP_SCHED struct { int curr; /* highest queued rt task prio */ +#ifdef CONFIG_SMP int next; /* ...
26689452f5ca201add63b1b1ff0dbcf82d6885e7
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] s390 specific system call wrappers
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/arch/s390/kernel/compat_wrapper.S b/arch/s390/kernel/compat_wrapper.S index fc2c97197a53..6035cd20c7a7 100644 --- a/arch/s390/kernel/compat_wrapper.S +++ b/arch/s390/kernel/compat_wrapper.S @@ -547,7 +547,7 @@ sys32_setdomainname_wrapper: .globl sys32_newuname_wrapper sys32_newuname_wrapper: l...
2b66421995d2e93c9d1a0111acf2581f8529c6e5
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 33
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/pipe.c b/fs/pipe.c index b89c878588a9..3a48ba5179d5 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -1059,7 +1059,7 @@ SYSCALL_DEFINE2(pipe2, int __user *, fildes, int, flags) return error; } -asmlinkage long sys_pipe(int __user *fildes) +SYSCALL_DEFINE1(pipe, int __user *, fildes) { return sy...
d4e82042c4cfa87a7d51710b71f568fe80132551
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 32
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/eventfd.c b/fs/eventfd.c index 08bf558d0408..5de2c2db3aa2 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -198,7 +198,7 @@ struct file *eventfd_fget(int fd) return file; } -asmlinkage long sys_eventfd2(unsigned int count, int flags) +SYSCALL_DEFINE2(eventfd2, unsigned int, count, int, flags...
836f92adf121f806e9beb5b6b88bd5c9c4ea3f24
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 31
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/signalfd.c b/fs/signalfd.c index 9c39bc7f8431..b07565c94386 100644 --- a/fs/signalfd.c +++ b/fs/signalfd.c @@ -205,8 +205,8 @@ static const struct file_operations signalfd_fops = { .read = signalfd_read, }; -asmlinkage long sys_signalfd4(int ufd, sigset_t __user *user_mask, - size_...
6559eed8ca7db0531a207cd80be5e28cd6f213c5
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 30
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/open.c b/fs/open.c index bc49e3c388d9..a3a78ceb2a2b 100644 --- a/fs/open.c +++ b/fs/open.c @@ -447,7 +447,7 @@ SYSCALL_ALIAS(sys_fallocate, SyS_fallocate); * We do this by temporarily clearing all FS-related capabilities and * switching the fsuid/fsgid around to the real ones. */ -asmlinka...
2e4d0924eb0c403ce4014fa139d1d61bf2c44fee
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 29
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/namei.c b/fs/namei.c index 90520f05f997..bbc15c237558 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1962,8 +1962,8 @@ static int may_mknod(mode_t mode) } } -asmlinkage long sys_mknodat(int dfd, const char __user *filename, int mode, - unsigned dev) +SYSCALL_DEFINE4(mknodat, int, dfd, cons...
938bb9f5e840eddbf54e4f62f6c5ba9b3ae12c9d
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 28
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/ioprio.c b/fs/ioprio.c index 1a39ac370942..c7c0b28d7d21 100644 --- a/fs/ioprio.c +++ b/fs/ioprio.c @@ -72,7 +72,7 @@ int set_task_ioprio(struct task_struct *task, int ioprio) } EXPORT_SYMBOL_GPL(set_task_ioprio); -asmlinkage long sys_ioprio_set(int which, int who, int ioprio) +SYSCALL_DEFINE...
1e7bfb2134dfec37ce04fb3a4ca89299e892d10c
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 27
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/exec.c b/fs/exec.c index 71a6efe5d8bd..0dd60a01f1b4 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -99,7 +99,7 @@ static inline void put_binfmt(struct linux_binfmt * fmt) * * Also note that we take the address to load from from the file itself. */ -asmlinkage long sys_uselib(const char __user *...
c4ea37c26a691ad0b7e86aa5884aab27830e95c9
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 26
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/drivers/pci/syscall.c b/drivers/pci/syscall.c index 645d7a60e412..ec22284eed30 100644 --- a/drivers/pci/syscall.c +++ b/drivers/pci/syscall.c @@ -14,10 +14,8 @@ #include <asm/uaccess.h> #include "pci.h" -asmlinkage long -sys_pciconfig_read(unsigned long bus, unsigned long dfn, - unsigned lo...
d5460c9974a321a194aded4a8c4daaac68ea8171
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 25
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/ipc/mqueue.c b/ipc/mqueue.c index 6df028b70543..faac04c85e74 100644 --- a/ipc/mqueue.c +++ b/ipc/mqueue.c @@ -650,8 +650,8 @@ static struct file *do_open(struct dentry *dentry, int oflag) return dentry_open(dentry, mqueue_mnt, oflag, cred); } -asmlinkage long sys_mq_open(const char __user *u_n...
e48fbb699f82ef1e80bd7126046394d2dc9ca7e6
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 24
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/ipc/msg.c b/ipc/msg.c index b4eee1c6101d..2ceab7f12fcb 100644 --- a/ipc/msg.c +++ b/ipc/msg.c @@ -309,7 +309,7 @@ static inline int msg_security(struct kern_ipc_perm *ipcp, int msgflg) return security_msg_queue_associate(msq, msgflg); } -asmlinkage long sys_msgget(key_t key, int msgflg) +SYSCA...
5a8a82b1d306a325d899b67715618413657efda4
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 23
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 96355d505347..ba2f9ec71192 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1110,7 +1110,7 @@ retry: /* * Open an eventpoll file descriptor. */ -asmlinkage long sys_epoll_create1(int flags) +SYSCALL_DEFINE1(epoll_create1, int, flags) { int error, fd...
3e0fa65f8ba4fd24b3dcfaf14d5b15eaab0fdc61
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 22
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/net/socket.c b/net/socket.c index fdd72c586a1a..35dd7371752a 100644 --- a/net/socket.c +++ b/net/socket.c @@ -1214,7 +1214,7 @@ int sock_create_kern(int family, int type, int protocol, struct socket **res) return __sock_create(&init_net, family, type, protocol, res, 1); } -asmlinkage long sys_...
20f37034fb966a1c35894f9fe529fda0b6440101
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 21
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/readdir.c b/fs/readdir.c index 8b4c2a0051a6..cf6a0e39819a 100644 --- a/fs/readdir.c +++ b/fs/readdir.c @@ -187,7 +187,8 @@ efault: return -EFAULT; } -asmlinkage long sys_getdents(unsigned int fd, struct linux_dirent __user * dirent, unsigned int count) +SYSCALL_DEFINE3(getdents, unsigned in...
3cdad42884bbd95d5aa01297e8236ea1bad70053
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 20
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/dcache.c b/fs/dcache.c index 4547f66884a0..937df0fb0da5 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -2092,7 +2092,7 @@ Elong: * return NULL; * } */ -asmlinkage long sys_getcwd(char __user *buf, unsigned long size) +SYSCALL_DEFINE2(getcwd, char __user *, buf, unsigned long, size) { in...
003d7ab479168132a2b2c6700fe682b08f08ab0c
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 19
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/read_write.c b/fs/read_write.c index 0671aa016b6f..fad10af59d95 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -147,7 +147,7 @@ loff_t vfs_llseek(struct file *file, loff_t offset, int origin) } EXPORT_SYMBOL(vfs_llseek); -asmlinkage long sys_lseek(unsigned int fd, off_t offset, unsign...
a6b42e83f249aad723589b2bdf6d1dfb2b0997c8
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 18
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/uid16.c b/kernel/uid16.c index 37f48c049a2a..221894e6e980 100644 --- a/kernel/uid16.c +++ b/kernel/uid16.c @@ -41,7 +41,7 @@ SYSCALL_DEFINE3(fchown16, unsigned int, fd, old_uid_t, user, old_gid_t, group) return ret; } -asmlinkage long sys_setregid16(old_gid_t rgid, old_gid_t egid) +SYSC...
ca013e945b1ba5828b151ee646946f1297b67a4c
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 17
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/open.c b/fs/open.c index 293408b1c165..4a6d80064746 100644 --- a/fs/open.c +++ b/fs/open.c @@ -517,7 +517,7 @@ out: return res; } -asmlinkage long sys_access(const char __user *filename, int mode) +SYSCALL_DEFINE2(access, const char __user *, filename, int, mode) { return sys_faccessat(A...
002c8976ee537724b20a5e179d9b349309438836
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 16
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/aio.c b/fs/aio.c index d6f89d3c15e8..8fa77e233944 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1270,7 +1270,7 @@ static void io_destroy(struct kioctx *ioctx) * pointer is passed for ctxp. Will fail with -ENOSYS if not * implemented. */ -asmlinkage long sys_io_setup(unsigned nr_events, aio_con...
a26eab2400f0477bfac0255600552394855016f7
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 15
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/fcntl.c b/fs/fcntl.c index cdc141946724..bd215cc791da 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -50,7 +50,7 @@ static int get_close_on_exec(unsigned int fd) return res; } -asmlinkage long sys_dup3(unsigned int oldfd, unsigned int newfd, int flags) +SYSCALL_DEFINE3(dup3, unsigned int, oldf...
3480b25743cb7404928d57efeaa3d085708b04c2
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 14
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/namei.c b/fs/namei.c index f05bed242422..43fa25259728 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2017,7 +2017,7 @@ out_unlock: return error; } -asmlinkage long sys_mknod(const char __user *filename, int mode, unsigned dev) +SYSCALL_DEFINE3(mknod, const char __user *, filename, int, mode, ...
6a6160a7b5c27b3c38651baef92a14fa7072b3c1
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 13
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/xattr.c b/fs/xattr.c index 0367a5dae2b8..197c4fcac032 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -499,8 +499,8 @@ SYSCALL_DEFINE2(removexattr, const char __user *, pathname, return error; } -asmlinkage long -sys_lremovexattr(const char __user *pathname, const char __user *name) +SYSCALL_DE...
64fd1de3d821659ac0a3004fd5ee1de59e64af30
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 12
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/xattr.c b/fs/xattr.c index d049ae27aae7..0367a5dae2b8 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -251,9 +251,9 @@ setxattr(struct dentry *d, const char __user *name, const void __user *value, return error; } -asmlinkage long -sys_setxattr(const char __user *pathname, const char __user *nam...
257ac264d69017270fbc3cf5536953525db4076c
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 11
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/open.c b/fs/open.c index f6c2f5673ed5..322bb60d168c 100644 --- a/fs/open.c +++ b/fs/open.c @@ -174,7 +174,7 @@ out: return error; } -asmlinkage long sys_fstatfs64(unsigned int fd, size_t sz, struct statfs64 __user *buf) +SYSCALL_DEFINE3(fstatfs64, unsigned int, fd, size_t, sz, struct statfs...
bdc480e3bef6eb0e7071770834cbdda7e30a5436
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 10
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/buffer.c b/fs/buffer.c index b6e8b8632e2f..b58208f1640a 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -3243,7 +3243,7 @@ void block_sync_page(struct page *page) * Use of bdflush() is deprecated and will be removed in a future kernel. * The `pdflush' kernel threads fully replace bdflush daemo...
a5f8fa9e9ba5ef3305e147f41ad6e1e84ac1f0bd
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 09
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/sync.c b/fs/sync.c index 23ebbd72ecc9..a16d53e5fe9d 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -36,7 +36,7 @@ static void do_sync(unsigned long wait) laptop_sync_completion(); } -asmlinkage long sys_sync(void) +SYSCALL_DEFINE0(sync) { do_sync(1); return 0; @@ -144,12 +144,12 @@ static ...
17da2bd90abf428523de0fb98f7075e00e3ed42e
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 08
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/exit.c b/kernel/exit.c index 08895df0eab3..f80dec3f1875 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1754,9 +1754,8 @@ end: return retval; } -asmlinkage long sys_waitid(int which, pid_t upid, - struct siginfo __user *infop, int options, - struct rusage __user *ru) +SYSCA...
754fe8d297bfae7b77f7ce866e2fb0c5fb186506
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 07
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/exit.c b/kernel/exit.c index fac9b040af2c..08895df0eab3 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1141,7 +1141,7 @@ NORET_TYPE void complete_and_exit(struct completion *comp, long code) EXPORT_SYMBOL(complete_and_exit); -asmlinkage long sys_exit(int error_code) +SYSCALL_DEFINE1...
5add95d4f7cf08f6f62510f19576992912387501
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 06
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/sched.c b/kernel/sched.c index 8be2c13b50d0..1a0fdfa5ddf9 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -5126,7 +5126,7 @@ int can_nice(const struct task_struct *p, const int nice) * sys_setpriority is a more generic, but much slower function that * does similar things. */ -asmli...
362e9c07c7220c0a78c88826fc0d2bf7e4a4bb68
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 05
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/itimer.c b/kernel/itimer.c index 7e0663ea94fc..6a5fe93dd8bd 100644 --- a/kernel/itimer.c +++ b/kernel/itimer.c @@ -260,9 +260,8 @@ unsigned int alarm_setitimer(unsigned int seconds) return it_old.it_value.tv_sec; } -asmlinkage long sys_setitimer(int which, - struct itimerval __u...
b290ebe2c46d01b742b948ce03f09e8a3efb9a92
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 04
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/acct.c b/kernel/acct.c index d57b7cbb98b6..7afa31564162 100644 --- a/kernel/acct.c +++ b/kernel/acct.c @@ -277,7 +277,7 @@ static int acct_on(char *name) * should be written. If the filename is NULL, accounting will be * shutdown. */ -asmlinkage long sys_acct(const char __user *name) +...
ae1251ab785f6da87219df8352ffdac68bba23e4
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 03
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/sys.c b/kernel/sys.c index 4c33555f8d95..ace9ced598b9 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -478,7 +478,7 @@ void ctrl_alt_del(void) * SMP: There are not races, the GIDs are checked only by filesystem * operations (as far as semantic preservation is concerned). */ -asmli...
dbf040d9d1cbf1ef6250bdb095c5c118950bcde8
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 02
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/sys.c b/kernel/sys.c index 37165e552331..4c33555f8d95 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -756,7 +756,7 @@ error: return retval; } -asmlinkage long sys_getresuid(uid_t __user *ruid, uid_t __user *euid, uid_t __user *suid) +SYSCALL_DEFINE3(getresuid, uid_t __user *, ruid, uid...
58fd3aa288939d3097fa04505b25c2f5e6e144d1
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrappers part 01
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index 1455b7651b6b..2dc30c59c5fd 100644 --- a/kernel/hrtimer.c +++ b/kernel/hrtimer.c @@ -1467,8 +1467,8 @@ out: return ret; } -asmlinkage long -sys_nanosleep(struct timespec __user *rqtp, struct timespec __user *rmtp) +SYSCALL_DEFINE2(nanosleep, struct time...
6673e0c3fbeaed2cd08e2fd4a4aa97382d6fedb0
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrapper special cases
Problem Details: System calls with an unsigned long long argument can't be converted with the standard wrappers since that would include a cast to long, which in turn means that we would lose the upper 32 bit on 32 bit architectures. Also semctl can't use the standard wrapper since it has a 'union' parameter. So we ha...
```diff diff --git a/fs/dcookies.c b/fs/dcookies.c index 180e9fec4ad8..a21cabdbd87b 100644 --- a/fs/dcookies.c +++ b/fs/dcookies.c @@ -145,7 +145,7 @@ out: /* And here is where the userspace process can look up the cookie value * to retrieve the path. */ -asmlinkage long sys_lookup_dcookie(u64 cookie64, char __use...
ed6bb6194350dc6ae97a65dbf2d621a3dbe6bbe9
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] s390: enable system call wrappers
Problem Details: Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index a94a3c3ae932..6b0a3538dc63 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -77,6 +77,7 @@ mainmenu "Linux Kernel Configuration" config S390 def_bool y select USE_GENERIC_SMP_HELPERS if SMP + select HAVE_SYSCALL_WRAPPERS select HAVE_FUNCTI...
ee6a093222549ac0c72cfd296c69fa5e7d6daa34
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] powerpc: Enable syscall wrappers for 64-bit
Problem Details: This enables the use of syscall wrappers to do proper sign extension for 64-bit programs. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 84b861316ce7..e39b73bc0ff8 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -123,6 +123,7 @@ config PPC select HAVE_DMA_ATTRS if PPC64 select USE_GENERIC_SMP_HELPERS if SMP select HAVE_OPROFILE + select HAVE_SYSCALL_WRAPPERS if ...
1a94bc34768e463a93cb3751819709ab0ea80a01
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] System call wrapper infrastructure
Problem Details: From: Martin Schwidefsky <schwidefsky@de.ibm.com> By selecting HAVE_SYSCALL_WRAPPERS architectures can activate system call wrappers in order to sign extend system call arguments. All architectures where the ABI defines that the caller of a function has to perform sign extension probably need this. ...
```diff diff --git a/arch/Kconfig b/arch/Kconfig index 2e13aa261929..550dab22daa1 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -62,6 +62,9 @@ config HAVE_EFFICIENT_UNALIGNED_ACCESS See Documentation/unaligned-memory-access.txt for more information on the topic of unaligned memory accesses. +config HAVE_SYS...
f627a741d24f12955fa2d9f8831c3b12860635bd
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] Make sys_syslog a conditional system call
Problem Details: Remove the -ENOSYS implementation for !CONFIG_PRINTK and use the cond_syscall infrastructure instead. Acked-by: Kyle McMartin <kyle@redhat.com> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/kernel/printk.c b/kernel/printk.c index 7015733793e8..e48cf33783fc 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -742,11 +742,6 @@ EXPORT_SYMBOL(vprintk); #else -asmlinkage long sys_syslog(int type, char __user *buf, int len) -{ - return -ENOSYS; -} - static void call_console_drivers(...
c9da9f2129d6a421c32e334a83770a9e67f7feac
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] Make sys_pselect7 static
Problem Details: Not a single architecture has wired up sys_pselect7 plus it is the only system call with seven parameters. Just make it static and rename it to do_pselect which will do the work for sys_pselect6. Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/compat.c b/fs/compat.c index 30f2faa22f5c..65a070e705ab 100644 --- a/fs/compat.c +++ b/fs/compat.c @@ -1709,7 +1709,7 @@ asmlinkage long compat_sys_select(int n, compat_ulong_t __user *inp, } #ifdef HAVE_SET_RESTORE_SIGMASK -asmlinkage long compat_sys_pselect7(int n, compat_ulong_t __user *i...
1134723e96f6e2abcf8bfd7a2d1c96fcc323ef35
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] Remove __attribute__((weak)) from sys_pipe/sys_pipe2
Problem Details: Remove __attribute__((weak)) from common code sys_pipe implemantation. IA64, ALPHA, SUPERH (32bit) and SPARC (32bit) have own implemantations with the same name. Just rename them. For sys_pipe2 there is no architecture specific implementation. Cc: Richard Henderson <rth@twiddle.net> Cc: David S. Mille...
```diff diff --git a/arch/alpha/kernel/entry.S b/arch/alpha/kernel/entry.S index f77345bc66a9..aa2e50cf9857 100644 --- a/arch/alpha/kernel/entry.S +++ b/arch/alpha/kernel/entry.S @@ -896,9 +896,9 @@ sys_getxpid: .end sys_getxpid .align 4 - .globl sys_pipe - .ent sys_pipe -sys_pipe: + .globl sys_alpha_pipe + .ent s...
e55380edf68796d75bf41391a781c68ee678587d
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] Rename old_readdir to sys_old_readdir
Problem Details: This way it matches the generic system call name convention. Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/arch/arm/kernel/calls.S b/arch/arm/kernel/calls.S index 09a061cb7838..9ca8d13f05f7 100644 --- a/arch/arm/kernel/calls.S +++ b/arch/arm/kernel/calls.S @@ -98,7 +98,7 @@ CALL(sys_uselib) CALL(sys_swapon) CALL(sys_reboot) - CALL(OBSOLETE(old_readdir)) /* used by libc4 */ + CALL(OBSOLETE(sys...
2ed7c03ec17779afb4fcfa3b8c61df61bd4879ba
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] Convert all system calls to return a long
Problem Details: Convert all system calls to return a long. This should be a NOP since all converted types should have the same size anyway. With the exception of sys_exit_group which returned void. But that doesn't matter since the system call doesn't return. Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/fs/read_write.c b/fs/read_write.c index 5cc6924eb158..940367f51f2a 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -147,7 +147,7 @@ loff_t vfs_llseek(struct file *file, loff_t offset, int origin) } EXPORT_SYMBOL(vfs_llseek); -asmlinkage off_t sys_lseek(unsigned int fd, off_t offset, unsig...
4c696ba7982501d43dea11dbbaabd2aa8a19cc42
Analyze and fix the following issue in the Linux kernel code: [CVE-2009-0029] Move compat system call declarations to compat header file
Problem Details: Move declarations to correct header file. Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
```diff diff --git a/include/linux/compat.h b/include/linux/compat.h index e88f3ecf38b4..3fd2194ff573 100644 --- a/include/linux/compat.h +++ b/include/linux/compat.h @@ -280,5 +280,18 @@ asmlinkage long compat_sys_timerfd_settime(int ufd, int flags, asmlinkage long compat_sys_timerfd_gettime(int ufd, struct c...
14819ea1e0bcbdc9b084cd60a6a24d5d786324ef
Analyze and fix the following issue in the Linux kernel code: irq: export __set_irq_handler() and handle_level_irq()
Problem Details: Impact: build fix ARM updates broke x86 allmodconfig builds: ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined! ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined! Signed-off-by: Ingo Molnar <mingo@elte.hu>
```diff diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index f63c706d25e1..7de11bd64dfe 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -383,6 +383,7 @@ handle_level_irq(unsigned int irq, struct irq_desc *desc) out_unlock: spin_unlock(&desc->lock); } +EXPORT_SYMBOL_GPL(handle_level_irq); /** * ha...
32632920a788fb13da35b131b77cc4324c38c1c5
Analyze and fix the following issue in the Linux kernel code: ftrace, trivial: fix typo "resgister" -> "register"
Problem Details: Signed-off-by: Uwe Kleine-Koenig <ukleinek@strlen.de> Signed-off-by: Steven Rostedt <srostedt@redhat.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
```diff diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 9f536108d3f3..8c1c9c0f4775 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -1894,7 +1894,7 @@ int register_ftrace_function(struct ftrace_ops *ops) } /** - * unregister_ftrace_function - unresgister a function for profiling. +...
baf48f6577e581a9adb8fe849dc80e24b21d171d
Analyze and fix the following issue in the Linux kernel code: softlock: fix false panic which can occur if softlockup_thresh is reduced
Problem Details: At run-time, if softlockup_thresh is changed to a much lower value, touch_timestamp is likely to be much older than the new softlock_thresh. This will cause a false softlockup to be detected. If softlockup_panic is enabled, the system will panic. The fix is to touch all watchdogs before changing soft...
```diff diff --git a/include/linux/sched.h b/include/linux/sched.h index 4cae9b81a1f8..54cbabf3b871 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -293,6 +293,9 @@ extern void sched_show_task(struct task_struct *p); extern void softlockup_tick(void); extern void touch_softlockup_watchdog(void); ex...
9248f2693921b143b54f380b60c945b28a7a5358
Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Fix stac92hd83xxx_amp_nids[]
Problem Details: Fix the bug introduced in commit c15c5060fc32d7de7cde76aa61e98bae1334d82e: sound/pci/hda/patch_sigmatel.c: In function ‘patch_stac92hd83xxx’: sound/pci/hda/patch_sigmatel.c:4765: warning: assignment from incompatible pointer type Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 103ac6d743ef..25230f4c888e 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -336,7 +336,7 @@ static unsigned int stac92hd83xxx_pwr_mapping[4] = { 0x03, 0x0c, 0x10, 0x40, }; -static unsigned...
b1a0aac05f044e78a589bfd7a9e2334aa640eb45
Analyze and fix the following issue in the Linux kernel code: ALSA: opti9xx - Fix build breakage by snd_card_create() conversion
Problem Details: Add a missing variable declaration. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c index 87a4feb50109..cd6e60a6a4ea 100644 --- a/sound/isa/opti9xx/opti92x-ad1848.c +++ b/sound/isa/opti9xx/opti92x-ad1848.c @@ -833,6 +833,7 @@ static int __devinit snd_opti9xx_probe(struct snd_card *card) static int snd_opti9xx...
a4a0acf8e17e3d08e28b721ceceb898fbc959ceb
Analyze and fix the following issue in the Linux kernel code: x86: fix broken flush_tlb_others_ipi()
Problem Details: This commit broke flush_tlb_others_ipi() causing boot hangs on a 16 logical cpu system: > commit 4595f9620cda8a1e973588e743cf5f8436dd20c6 > Author: Rusty Russell <rusty@rustcorp.com.au> > Date: Sat Jan 10 21:58:09 2009 -0800 > > x86: change flush_tlb_others to take a const struct cpumask This c...
```diff diff --git a/arch/x86/kernel/tlb_64.c b/arch/x86/kernel/tlb_64.c index 7a3f9891302d..54ee2ecb5e26 100644 --- a/arch/x86/kernel/tlb_64.c +++ b/arch/x86/kernel/tlb_64.c @@ -188,7 +188,7 @@ static void flush_tlb_others_ipi(const struct cpumask *cpumask, * We have to send the IPI only to * CPUs affected. *...
3e420e78ece6f9d2accc1568e80dfd0501e13df1
Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Add automatic model setting for Samsung Q45
Problem Details: Have the Samsung Q45 (144d:c510) select ALC262_HIPPO by default Reference: Ubuntu bug 200210 http://launchpad.net/bugs/200210 Signed-off-by: Luke Yelavich <themuso@ubuntu.com> Cc: stable@kernel.org Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index ea4c88fe05c4..82dd08431970 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10573,6 +10573,7 @@ static struct snd_pci_quirk alc262_cfg_tbl[] = { SND_PCI_QUIRK(0x10cf, 0x142d, "Fujitsu Lifebook E8...
2acc9dcb609427a20463e529ef552dd93b469847
Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Fix silent headphone output on Panasonic CF-74
Problem Details: CF-74 does the headphone/speaker switching on hardware, thus the driver shouldn't do any software-toggling of pins. Otherwise it results in a silent headphone output. This patch simply resets the hp_detect flag to fix the problem. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 0e6fc56fa378..89ff916a0ed1 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -4467,6 +4467,12 @@ static int patch_stac9200(struct hda_codec *codec) return err; } + /* CF-74 has no headphon...
7891cc818967e186be68caac32d84bfd0a3f0bd2
Analyze and fix the following issue in the Linux kernel code: ipv6: Fix fib6_dump_table walker leak
Problem Details: When a fib6 table dump is prematurely ended, we won't unlink its walker from the list. This causes all sorts of grief for other users of the list later. Reported-by: Chris Caputo <ccaputo@alt.net> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft....
```diff diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index 29c7c99e69f7..52ee1dced2ff 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -298,6 +298,10 @@ static void fib6_dump_end(struct netlink_callback *cb) struct fib6_walker_t *w = (void*)cb->args[2]; if (w) { + if (cb->args[4]) { + cb->ar...
7a6046ebe28d6a5d259097dcb44162e5a6eca88e
Analyze and fix the following issue in the Linux kernel code: sparc64: Fix UP build failure.
Problem Details: sparc_ksyms_64.c includes asm/spinlock.h directly, which is a no-no. Even better, none of these exports are even necessary. All of these functions are inlines. Reported by Meelis Roos and Alexander Beregalov. Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/arch/sparc/kernel/sparc_ksyms_64.c b/arch/sparc/kernel/sparc_ksyms_64.c index da8f804feb49..0f26066a08d9 100644 --- a/arch/sparc/kernel/sparc_ksyms_64.c +++ b/arch/sparc/kernel/sparc_ksyms_64.c @@ -9,7 +9,6 @@ #include <linux/pci.h> #include <linux/init.h> -#include <asm/spinlock.h> #include <...
33966dd0e2f68f26943cd9ee93ec6abbc6547a8e
Analyze and fix the following issue in the Linux kernel code: tcp: splice as many packets as possible at once
Problem Details: As spotted by Willy Tarreau, current splice() from tcp socket to pipe is not optimal. It processes at most one segment per call. This results in low performance and very high overhead due to syscall rate when splicing from interfaces which do not support LRO. Willy provided a patch inside tcp_splice_r...
```diff diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index ce572f9dff02..48ada1b2d2c4 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -522,8 +522,12 @@ static int tcp_splice_data_recv(read_descriptor_t *rd_desc, struct sk_buff *skb, unsigned int offset, size_t len) { struct tcp_splice_state *tss = rd_desc->...
62568510b8e2679cbc331d7de10ea9ba81ae8b3d
Analyze and fix the following issue in the Linux kernel code: Fix timeouts in sys_pselect7
Problem Details: Since we (Analog Devices) updated our Blackfin kernel to 2.6.28, we've seen occasional 5-second hangs from telnet. telnetd calls select with a NULL timeout, but with the new kernel, the system call occasionally returns 0, which causes telnet to call sleep (5). This did not happen with earlier kernels...
```diff diff --git a/fs/select.c b/fs/select.c index 08b91beed806..b0cf1f0896d9 100644 --- a/fs/select.c +++ b/fs/select.c @@ -610,7 +610,7 @@ asmlinkage long sys_pselect7(int n, fd_set __user *inp, fd_set __user *outp, sigprocmask(SIG_SETMASK, &ksigmask, &sigsaved); } - ret = core_sys_select(n, inp, outp, exp, ...
125c97d8a59888c5678734c2b70cbd08c847bd99
Analyze and fix the following issue in the Linux kernel code: fix early_serial_setup() regression
Problem Details: Commit b430428a188e8a434325e251d0704af4b88b4711 ("8250: Don't clobber spinlocks.") introduced a regression on the parisc architecture, which broke the handover to the serial port at boottime. early_serial_setup() was changed to only copy a subset of the uart_port fields, and sadly the "type" and "line...
```diff diff --git a/drivers/parisc/superio.c b/drivers/parisc/superio.c index 1e93c837514f..4fa3bb2ddfe4 100644 --- a/drivers/parisc/superio.c +++ b/drivers/parisc/superio.c @@ -405,7 +405,6 @@ static void __init superio_serial_init(void) serial_port.type = PORT_16550A; serial_port.uartclk = 115200*16; serial_po...
e6b50c8d58bde1cdc5c9c9520be7ed8921d26aab
Analyze and fix the following issue in the Linux kernel code: TWL4030: fix clk API usage
Problem Details: Always pass a struct device if one is available; and there's really no reason for the processor specific stuff in this file if only people would follow the API usage properly by using the struct device. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c index b59c385cbc12..4a488be91ed7 100644 --- a/drivers/mfd/twl4030-core.c +++ b/drivers/mfd/twl4030-core.c @@ -646,7 +646,7 @@ static inline int __init unprotect_pm_master(void) return e; } -static void __init clocks_init(void) +static voi...
58dab916dfb57328d50deb0aa9b3fc92efa248ff
Analyze and fix the following issue in the Linux kernel code: x86 PAT: remove CPA WARN_ON for zero pte
Problem Details: Impact: reduce scope of debug check - avoid warnings The logic to find whether identity map exists or not using high_memory or max_low_pfn_mapped/max_pfn_mapped are not complete as the memory withing the range may not be mapped if there is a unusable hole in e820. Specifically, on my test system I st...
```diff diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c index e89d24815f26..4cf30dee8161 100644 --- a/arch/x86/mm/pageattr.c +++ b/arch/x86/mm/pageattr.c @@ -555,10 +555,12 @@ repeat: if (!pte_val(old_pte)) { if (!primary) return 0; - WARN(1, KERN_WARNING "CPA: called for zero pte. " - "v...
cdecff6864a1cd352a41d44a65e7451b8ef5cee2
Analyze and fix the following issue in the Linux kernel code: x86 PAT: return compatible mapping to remap_pfn_range callers
Problem Details: Impact: avoid warning message, potentially solve 3D performance regression Change x86 PAT code to return compatible memtype if the exact memtype that was requested in remap_pfn_rage and friends is not available due to some conflict. This is done by returning the compatible type in pgprot parameter of...
```diff diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c index f88ac80530c0..8b08fb955274 100644 --- a/arch/x86/mm/pat.c +++ b/arch/x86/mm/pat.c @@ -601,12 +601,13 @@ void unmap_devmem(unsigned long pfn, unsigned long size, pgprot_t vma_prot) * Reserved non RAM regions only and after successful reserve_memtype, *...
a36706131182f5507d1e2cfbf391b0fa8d72203c
Analyze and fix the following issue in the Linux kernel code: x86 PAT: remove PFNMAP type on track_pfn_vma_new() error
Problem Details: Impact: fix (harmless) double-free of memtype entries and avoid warning On track_pfn_vma_new() failure, reset the vm_flags so that there will be no second cleanup happening when upper level routines call unmap_vmas(). This patch fixes part of the bug reported here: http://marc.info/?l=linux-kernel...
```diff diff --git a/mm/memory.c b/mm/memory.c index c2d4c477e5bb..d3ee2ea5615c 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1672,8 +1672,14 @@ int remap_pfn_range(struct vm_area_struct *vma, unsigned long addr, vma->vm_flags |= VM_IO | VM_RESERVED | VM_PFNMAP; err = track_pfn_vma_new(vma, prot, pfn, PAGE_ALIGN...
c8399943bdb70fef78798b97f975506ecc99e039
Analyze and fix the following issue in the Linux kernel code: x86, generic: mark complex bitops.h inlines as __always_inline
Problem Details: Impact: reduce kernel image size Hugh Dickins noticed that older gcc versions when the kernel is built for code size didn't inline some of the bitops. Mark all complex x86 bitops that have more than a single asm statement or two as always inline to avoid this problem. Probably should be done for oth...
```diff diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h index e02a359d2aa5..02b47a603fc8 100644 --- a/arch/x86/include/asm/bitops.h +++ b/arch/x86/include/asm/bitops.h @@ -3,6 +3,9 @@ /* * Copyright 1992, Linus Torvalds. + * + * Note: inlines with more than a single statement should be m...
2f4c782c2e06fbaef2ac2b6b7abd796b96abd98b
Analyze and fix the following issue in the Linux kernel code: [SCSI] mpt fusion: Add Firmware debug support
Problem Details: Signed-off-by: Kashyap Desai <kadesai@lsi.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
```diff diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 787a12648dbc..96ac88317b8e 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c @@ -107,6 +107,14 @@ module_param_call(mpt_debug_level, mpt_set_debug_level, param_get_int, MODULE_PARM_DESC(mpt...
29bdccbee69c199910b2b39377e66ee5c33f241c
Analyze and fix the following issue in the Linux kernel code: [SCSI] qla2xxx: Fix ISP restart bug in multiq code
Problem Details: After restarting ISP the additional queues are not being setup correctly. The following patch fixes the issue. Please apply. Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
```diff diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 2d4f32b4df5c..9ad4d0968e5c 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -1258,35 +1258,48 @@ qla2x00_init_rings(scsi_qla_host_t *vha) { int rval; unsigned long flags = 0; - int cnt;...
288e4877f94a3b144aadc206e7796921d02432c1
Analyze and fix the following issue in the Linux kernel code: Prevent oops at boot with VT-d
Problem Details: With some broken BIOSs when VT-d is enabled, the data structures are filled incorrectly. This can cause a NULL pointer dereference in very early boot. Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com> Acked-by: Yu Zhao <yu.zhao@intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> ...
```diff diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c index 235fb7a5a8a5..3dfecb20d5e7 100644 --- a/drivers/pci/intel-iommu.c +++ b/drivers/pci/intel-iommu.c @@ -438,7 +438,8 @@ static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn) continue; for (i = 0; i < drhd->devices_cnt; i++) -...
a0f79f7ad3e52b908786462cf5446ebe20fe14fa
Analyze and fix the following issue in the Linux kernel code: ata: fix wrong WARN_ON_ONCE
Problem Details: This patch fixes a wrong WARN_ON that was triggered by 32bit PIO support: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750() __atapi_pio_bytes simply doesnt know enough to decide if there is a bug. Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Jeff...
```diff diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 0eae9b453556..5a4aad123c42 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -1013,9 +1013,12 @@ next_sg: qc->cursg_ofs = 0; } - /* consumed can be larger than count only for the last transfer */ - WARN_ON_ONCE(q...
26d1597c9a4532eec74f9651c4c96483cb8892fe
Analyze and fix the following issue in the Linux kernel code: p54: fix "‘ret’ may be used uninitialized" warning
Problem Details: drivers/net/wireless/p54/p54common.c: In function ‘p54_config’: drivers/net/wireless/p54/p54common.c:1853: warning: ‘ret’ may be used uninitialized in this function Signed-off-by: John W. Linville <linville@tuxdriver.com>
```diff diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c index cba89ed0f572..c6a370fa9bcb 100644 --- a/drivers/net/wireless/p54/p54common.c +++ b/drivers/net/wireless/p54/p54common.c @@ -1850,7 +1850,7 @@ static void p54_remove_interface(struct ieee80211_hw *dev, static int p5...
25a4cceaa44a7f73c8f92e6177812347500a0b15
Analyze and fix the following issue in the Linux kernel code: iwl3945: fix "‘power_idx’ may be used uninitialized" warning
Problem Details: drivers/net/wireless/iwlwifi/iwl-3945.c: In function ‘iwl3945_txpower_set_from_eeprom’: drivers/net/wireless/iwlwifi/iwl-3945.c:2222: warning: ‘power_idx’ may be used uninitialized in this function Signed-off-by: John W. Linville <linville@tuxdriver.com>
```diff diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c index 8fdb34222c0a..45cfa1cf194a 100644 --- a/drivers/net/wireless/iwlwifi/iwl-3945.c +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c @@ -2219,7 +2219,7 @@ int iwl3945_txpower_set_from_eeprom(struct iwl3945_priv *priv) ...
08cb7e01678b0a8d95d76aa0a395f2d7390f7ee1
Analyze and fix the following issue in the Linux kernel code: b43legacy: fix "‘up_dev’ may be used uninitialized" warning
Problem Details: drivers/net/wireless/b43legacy/main.c: In function ‘b43legacy_op_dev_config’: drivers/net/wireless/b43legacy/main.c:2468: warning: ‘up_dev’ may be used uninitialized in this function Signed-off-by: John W. Linville <linville@tuxdriver.com>
```diff diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c index c1324e31d2f6..fb996c27a19b 100644 --- a/drivers/net/wireless/b43legacy/main.c +++ b/drivers/net/wireless/b43legacy/main.c @@ -2465,7 +2465,7 @@ static void b43legacy_put_phy_into_reset(struct b43legacy_wldev *dev) ...
922d8a0b6d82fb40ffb561576e3800c3784ff43d
Analyze and fix the following issue in the Linux kernel code: b43: fix "‘gmode’ may be used uninitialized" warning
Problem Details: drivers/net/wireless/b43/main.c: In function ‘b43_op_config’: drivers/net/wireless/b43/main.c:3264: warning: ‘gmode’ may be used uninitialized Signed-off-by: John W. Linville <linville@tuxdriver.com>
```diff diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c index 7b31a327b24a..c788bad10661 100644 --- a/drivers/net/wireless/b43/main.c +++ b/drivers/net/wireless/b43/main.c @@ -3261,7 +3261,7 @@ static int b43_switch_band(struct b43_wl *wl, struct ieee80211_channel *chan) struct b43_wlde...
85b9e4fe13de9b35af1dbd50acc5f4978b9119ee
Analyze and fix the following issue in the Linux kernel code: mac80211: fix "‘ret’ may be used uninitialized" warning
Problem Details: net/mac80211/ht.c: In function ‘ieee80211_start_tx_ba_session’: net/mac80211/ht.c:472: warning: ‘ret’ may be used uninitialized in this function Signed-off-by: John W. Linville <linville@tuxdriver.com>
```diff diff --git a/net/mac80211/ht.c b/net/mac80211/ht.c index 5f510a13b9f0..c5c0c5271096 100644 --- a/net/mac80211/ht.c +++ b/net/mac80211/ht.c @@ -469,7 +469,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_hw *hw, u8 *ra, u16 tid) struct ieee80211_sub_if_data *sdata; u16 start_seq_num; u8 *state; - in...
4a922a969cb0190ce4580d4b064e2ac35f3ac9bf
Analyze and fix the following issue in the Linux kernel code: x86, cpufreq: remove leftover copymask_copy()
Problem Details: Impact: fix potential boot crash on MAXSMP Remove code left over by: 50c668d: Revert "cpumask: use work_on_cpu in acpi-cpufreq.c for drv_read That cmd.cpumask is not allocated anymore. No impact on default !MAXSMP kernels. Signed-off-by: Ingo Molnar <mingo@elte.hu>
```diff diff --git a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c index 6f11e029e8c5..8f3c95c7e61f 100644 --- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c +++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c @@ -235,8 +235,6 @@ static u32 get_cur_val(const struct cpumask *mask) ...
dafb70ce1026d4d6ef1b16ad6996c9589bb11cce
Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Add quirk for another HP dv5
Problem Details: Add the model=hp-m4 quirk for another HP dv5 (103c:3603) Reference: kernel bug#12440 http://bugzilla.kernel.org/show_bug.cgi?id=12440 Signed-off-by: Takashi Iwai <tiwai@suse.de> Cc: stable@kernel.org
```diff diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index a4e2d8fcc8b7..9acf2f0a2df9 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -1736,6 +1736,8 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = { "HP dv7", STAC_HP_M4), SND_PCI_Q...
f9d088b2080b476c86f8ddbc274851b89668c6d7
Analyze and fix the following issue in the Linux kernel code: ALSA: hda - Fix a typo
Problem Details: Fix a typo in stac92hd83xxx_cfg_tbl[]. The actual number is identical thus there is no behavior change. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 35b83dc6e19e..a4e2d8fcc8b7 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -1682,7 +1682,7 @@ static const char *stac92hd83xxx_models[STAC_92HD83XXX_MODELS] = { static struct snd_pci_quirk sta...
554b91edec1c588b889a7357ff201c0a450e31ff
Analyze and fix the following issue in the Linux kernel code: ALSA: sscape: fix incorrect timeout after microcode upload
Problem Details: A comment states that one should wait up to 5 secs while a waiting loop waits only 5 system ticks. Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c index bc449166d18d..6a7f842b9627 100644 --- a/sound/isa/sscape.c +++ b/sound/isa/sscape.c @@ -393,20 +393,20 @@ static int sscape_wait_dma_unsafe(unsigned io_base, enum GA_REG reg, unsigned ti */ static int obp_startup_ack(struct soundscape *s, unsigned ti...
859975764fa61e927e7a69f46a55a4ba415785dd
Analyze and fix the following issue in the Linux kernel code: net: ppp_generic - fix regressions caused by IDR conversion
Problem Details: The commits: 7a95d267fb62cd6b80ef73be0592bbbe1dbd5df7 ("net: ppp_generic - use idr technique instead of cardmaps") ab5024ab23b78c86a0a1425defcdde48710fe449 ("net: ppp_generic - use DEFINE_IDR for static initialization") introduced usage of IDR functionality but broke userspace side. Before this...
```diff diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c index 06b448285eb5..7b2728b8f1b7 100644 --- a/drivers/net/ppp_generic.c +++ b/drivers/net/ppp_generic.c @@ -250,6 +250,7 @@ static int ppp_connect_channel(struct channel *pch, int unit); static int ppp_disconnect_channel(struct channel *pch); ...
a6d0b91ae5dd01263530c96f9b29001cb1ed58b0
Analyze and fix the following issue in the Linux kernel code: gianfar: Fix soft lockup with multi-interrupt TSECs
Problem Details: This patch fixes following bug: BUG: soft lockup - CPU#0 stuck for 61s! [S03mountvirtfs-:922] Modules linked in: NIP: c006505c LR: c00675f0 CTR: c0020438 REGS: c7a1db90 TRAP: 0901 Not tainted (2.6.28-rc8-01311-g8c7396a) MSR: 00009032 <EE,ME,IR,DR> CR: 28248442 XER: 20000000 TASK = c7a288a0[922] '...
```diff diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index efcbeb6c8673..ea530673236e 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1622,10 +1622,18 @@ static int gfar_clean_tx_ring(struct net_device *dev) static void gfar_schedule_cleanup(struct net_device *dev) { struct gfar_pri...
b74f62c1e736ea01c660355526dd54132d241ca9
Analyze and fix the following issue in the Linux kernel code: hso: driver fix for big endian machines.
Problem Details: Filip Aben says this fix is neccessary for big endian machines. Signed-off-by: Denis Joseph Barrow <D.Barow@option.com> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index c4918b86ed19..d17dc5214c9a 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -1792,8 +1792,8 @@ static int mux_device_request(struct hso_serial *serial, u8 type, u16 port, /* initialize */ ctrl_req->wValue = 0; - ctrl_req->wI...
71320afcdb33b3f0b754ba1fac6a8c77aa469041
Analyze and fix the following issue in the Linux kernel code: netfilter 06/09: nf_conntrack: fix ICMP/ICMPv6 timeout sysctls on big-endian
Problem Details: An old bug crept back into the ICMP/ICMPv6 conntrack protocols: the timeout values are defined as unsigned longs, the sysctl's maxsize is set to sizeof(unsigned int). Use unsigned int for the timeout values as in the other conntrack protocols. Reported-by: Jean-Mickael Guerin <jean-mickael.guerin@6win...
```diff diff --git a/net/ipv4/netfilter/nf_conntrack_proto_icmp.c b/net/ipv4/netfilter/nf_conntrack_proto_icmp.c index 1fd3ef7718b6..2a8bee26f43d 100644 --- a/net/ipv4/netfilter/nf_conntrack_proto_icmp.c +++ b/net/ipv4/netfilter/nf_conntrack_proto_icmp.c @@ -20,7 +20,7 @@ #include <net/netfilter/nf_conntrack_core.h> ...
d61ba9fd55b52a10b8e0ffd39bbc33587d3bfc8d
Analyze and fix the following issue in the Linux kernel code: netfilter 05/09: ebtables: fix inversion in match code
Problem Details: Commit 8cc784ee (netfilter: change return types of match functions for ebtables extensions) broke ebtables matches by inverting the sense of match/nomatch. Reported-by: Matt Cross <matthltc@us.ibm.com> Signed-off-by: Jan Engelhardt <jengelh@medozas.de> Signed-off-by: Patrick McHardy <kaber@trash.net> ...
```diff diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c index 8a8743d7d6e7..820252aee81f 100644 --- a/net/bridge/netfilter/ebtables.c +++ b/net/bridge/netfilter/ebtables.c @@ -79,7 +79,7 @@ static inline int ebt_do_match (struct ebt_entry_match *m, { par->match = m->u.match; par-...
656caff20e12ba6e07b4bf342641df5ab33b4e49
Analyze and fix the following issue in the Linux kernel code: netfilter 04/09: x_tables: fix match/target revision lookup
Problem Details: Commit 55b69e91 (netfilter: implement NFPROTO_UNSPEC as a wildcard for extensions) broke revision probing for matches and targets that are registered with NFPROTO_UNSPEC. Fix by continuing the search on the NFPROTO_UNSPEC list if nothing is found on the af-specific lists. Signed-off-by: Patrick McHar...
```diff diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index 89837a4eef76..bfbf521f6ea5 100644 --- a/net/netfilter/x_tables.c +++ b/net/netfilter/x_tables.c @@ -273,6 +273,10 @@ static int match_revfn(u8 af, const char *name, u8 revision, int *bestp) have_rev = 1; } } + + if (af != NFPROTO_U...
a2bd40ad3151d4d346fd167e01fb84b06f7247fc
Analyze and fix the following issue in the Linux kernel code: netfilter 02/09: bridge: Fix handling of non-IP packets in FORWARD/POST_ROUTING
Problem Details: Currently the bridge FORWARD/POST_ROUTING chains treats all non-IPv4 packets as IPv6. This packet fixes that by returning NF_ACCEPT on non-IP packets instead, just as is done in PRE_ROUTING. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Patrick McHardy <kaber@trash.net> Signe...
```diff diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c index a65e43a17fbb..9a1cd757ec4e 100644 --- a/net/bridge/br_netfilter.c +++ b/net/bridge/br_netfilter.c @@ -686,8 +686,11 @@ static unsigned int br_nf_forward_ip(unsigned int hook, struct sk_buff *skb, if (skb->protocol == htons(ETH_P_IP) || I...
985ebdb5ed54151eba734aa1b307460e8e4267ba
Analyze and fix the following issue in the Linux kernel code: net: Fix a comment in include/linux/netdevice.h.
Problem Details: Fix a comment in include/linux/netdevice.h. Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index f24556813375..4647604c7ca9 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -467,7 +467,7 @@ struct netdev_queue { * This function is called when network device transistions to the down * state. * - *...