id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
31a12666d8f0c22235297e1c1575f82061480029 | Analyze and fix the following issue in the Linux kernel code: mm: write_cache_pages cyclic fix | Problem Details:
In write_cache_pages, scanned == 1 is supposed to mean that cyclic
writeback has circled through zero, thus we should not circle again.
However it gets set to 1 after the first successful pagevec lookup. This
leads to cases where not enough data gets written.
Counterexample: file with first 10 pages ... | ```diff
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 2970e35fd03f..eb277bdd4c5d 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -868,9 +868,10 @@ int write_cache_pages(struct address_space *mapping,
int done = 0;
struct pagevec pvec;
int nr_pages;
+ pgoff_t uninitialized_var(writebac... |
c7d4caeb1d68d07f77cc09fc20b7759d6d7aa3b1 | Analyze and fix the following issue in the Linux kernel code: oom: fix zone_scan_mutex name | Problem Details:
zone_scan_mutex is actually a spinlock, so name it appropriately.
Signed-off-by: David Rientjes <rientjes@google.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index c592965dab2f..e5f50cfdca4d 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -31,7 +31,7 @@
int sysctl_panic_on_oom;
int sysctl_oom_kill_allocating_task;
int sysctl_oom_dump_tasks;
-static DEFINE_SPINLOCK(zone_scan_mutex);
+static DEFINE_SPINLOCK(zone_scan_loc... |
1c0fe6e3bda0464728c23c8d84aa47567e8b716c | Analyze and fix the following issue in the Linux kernel code: mm: invoke oom-killer from page fault | Problem Details:
Rather than have the pagefault handler kill a process directly if it gets
a VM_FAULT_OOM, have it call into the OOM killer.
With increasingly sophisticated oom behaviour (cpusets, memory cgroups,
oom killing throttling, oom priority adjustment or selective disabling,
panic on oom, etc), it's silly to ... | ```diff
diff --git a/arch/um/kernel/trap.c b/arch/um/kernel/trap.c
index 44e490419495..7384d8accfe7 100644
--- a/arch/um/kernel/trap.c
+++ b/arch/um/kernel/trap.c
@@ -64,11 +64,10 @@ good_area:
do {
int fault;
-survive:
+
fault = handle_mm_fault(mm, vma, address, is_write);
if (unlikely(fault & VM_FAULT_ER... |
3699c53c485bf0168e6500d0ed18bf931584dd7c | Analyze and fix the following issue in the Linux kernel code: CRED: Fix regression in cap_capable() as shown up by sys_faccessat() [ver #3] | Problem Details:
Fix a regression in cap_capable() due to:
commit 3b11a1decef07c19443d24ae926982bc8ec9f4c0
Author: David Howells <dhowells@redhat.com>
Date: Fri Nov 14 10:39:26 2008 +1100
CRED: Differentiate objective and effective subjective credentials on a task
The problem is that the above patch allows... | ```diff
diff --git a/include/linux/capability.h b/include/linux/capability.h
index e22f48c2a46f..02bdb768d43b 100644
--- a/include/linux/capability.h
+++ b/include/linux/capability.h
@@ -529,8 +529,21 @@ extern const kernel_cap_t __cap_init_eff_set;
*
* Note that this does not set PF_SUPERPRIV on the task.
*/
-#d... |
29881c4502ba05f46bc12ae8053d4e08d7e2615c | Analyze and fix the following issue in the Linux kernel code: Revert "CRED: Fix regression in cap_capable() as shown up by sys_faccessat() [ver #2]" | Problem Details:
This reverts commit 14eaddc967b16017d4a1a24d2be6c28ecbe06ed8.
David has a better version to come. | ```diff
diff --git a/include/linux/capability.h b/include/linux/capability.h
index 5b8a13214451..e22f48c2a46f 100644
--- a/include/linux/capability.h
+++ b/include/linux/capability.h
@@ -529,21 +529,8 @@ extern const kernel_cap_t __cap_init_eff_set;
*
* Note that this does not set PF_SUPERPRIV on the task.
*/
-#d... |
7a9c67a6ad2e6911e7ebdae34a75835c537d6e84 | Analyze and fix the following issue in the Linux kernel code: Staging: android: binder: fix build errors | Problem Details:
This fixes the build errors and warnings in the binder driver. It can't
be a module, due to a lack of some of the symbols being exported.
Also added a MODULE_LICENSE(), as it was missing.
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Brian Swetland <swetland@google.com>
Cc: Robert Love <rlove@google.com... | ```diff
diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 934f6f2019b3..6b996db0dd6a 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -7,8 +7,8 @@ config ANDROID
Enable support for various drivers needed on the Android platform
config ANDROI... |
9279bcc31698842961a30bb05b00aef7236dd728 | Analyze and fix the following issue in the Linux kernel code: staging: android: binder: Fix use of euid | Problem Details:
Task credentials were moved and must be accessed through task_struct.cred
Signed-off-by: J.R. Mauro <jrm8005@gmail.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Brian Swetland <swetland@google.com>
Cc: Robert Love <rlove@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 765048eaaf6d..7c3da5aa777a 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -1401,7 +1401,7 @@ binder_transaction(struct binder_proc *proc, struct binder_thread *thread,
t->from = thr... |
a2bf2153cb2a2de341b6a87cb644870a5bde2a9d | Analyze and fix the following issue in the Linux kernel code: Staging: android: binder: Fix gcc warnings about improper format specifiers for size_t in printk | Problem Details:
Use the proper format specifiers for printing size_t values.
Signed-off-by: J.R. Mauro <jrm8005@gmail.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Brian Swetland <swetland@google.com>
Cc: Robert Love <rlove@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 387625b40bb2..765048eaaf6d 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -493,7 +493,7 @@ static void binder_insert_free_buffer(
new_buffer_size = binder_buffer_size(proc, new_buffe... |
4cf7c4c692f05e137b65b9a2d7abe5bcb5408820 | Analyze and fix the following issue in the Linux kernel code: Staging: epl: fix netdev->priv b0rkage | Problem Details:
netdev->priv is now gone, use netdev_priv() instead.
This fixes the build error in the network driver within the epl stack.
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/epl/VirtualEthernetLinux.c b/drivers/staging/epl/VirtualEthernetLinux.c
index 522658ba8bf9..5d838dbf73a7 100644
--- a/drivers/staging/epl/VirtualEthernetLinux.c
+++ b/drivers/staging/epl/VirtualEthernetLinux.c
@@ -166,7 +166,7 @@ static int VEthOpen(struct net_device *pNetDevice_p)
... |
37bcd24b845abbfd85c838ee9ce07c2b254d3a05 | Analyze and fix the following issue in the Linux kernel code: Staging: frontier: fix compiler warnings | Problem Details:
Basically remove unused code and variables still hanging around.
Cc: David Taht <d@teklibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/frontier/alphatrack.c b/drivers/staging/frontier/alphatrack.c
index 028873e70fe9..61d7c5df87af 100644
--- a/drivers/staging/frontier/alphatrack.c
+++ b/drivers/staging/frontier/alphatrack.c
@@ -100,16 +100,10 @@ static int debug = 0;
/* Use our own dbg macro */
#define dbg_info(de... |
1242c70df56978e8abbf715a02fb1c55313f8471 | Analyze and fix the following issue in the Linux kernel code: Staging: rt2870: fix up netdev->priv usage | Problem Details:
Now that netdev->priv is removed, fix the driver to use netdev->ml_priv
like it always should have been doing.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2870/common/2870_rtmp_init.c b/drivers/staging/rt2870/common/2870_rtmp_init.c
index 359c1820e6d5..5d89a310d1ea 100644
--- a/drivers/staging/rt2870/common/2870_rtmp_init.c
+++ b/drivers/staging/rt2870/common/2870_rtmp_init.c
@@ -763,7 +763,7 @@ Note:
NDIS_STATUS CreateThreads(
... |
18223a99e60787ce41159ed321c8f0a21c328ac1 | Analyze and fix the following issue in the Linux kernel code: Staging: meilhaus: fix __symbol_get problems | Problem Details:
next-20081120 kernel randconfig on x86_64 box fails, while !CONFIG_MODULES
drivers/staging/meilhaus/memain.c: In function 'me_probe_pci':
drivers/staging/meilhaus/memain.c:425: error: implicit declaration of function '__symbol_get'
drivers/staging/meilhaus/memain.c:425: warning: cast to pointer from i... | ```diff
diff --git a/drivers/staging/meilhaus/memain.c b/drivers/staging/meilhaus/memain.c
index 6cdeb8582453..b09d1a6c766c 100644
--- a/drivers/staging/meilhaus/memain.c
+++ b/drivers/staging/meilhaus/memain.c
@@ -422,7 +422,7 @@ static int me_probe_pci(struct pci_dev *dev, const struct pci_device_id *id)
PDEBUG("mo... |
5ec5ec78060481e6a0cecc06ab0c6ec8b213ec80 | Analyze and fix the following issue in the Linux kernel code: Staging: asus_oled: fix build dependancy | Problem Details:
asus_oled depends on the CONFIG_USB_SUPPORT, I have only build tested
the patch.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/asus_oled/Kconfig b/drivers/staging/asus_oled/Kconfig
index 2c10e1eb7266..e56dbb25ac5d 100644
--- a/drivers/staging/asus_oled/Kconfig
+++ b/drivers/staging/asus_oled/Kconfig
@@ -1,5 +1,6 @@
config ASUS_OLED
tristate "Asus OLED driver"
+ depends on USB
default N
---help---
... |
a8275fcaa7ca1f720f0c1b1c4c373964ffc9f72d | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix build if CONFIG_PROC_FS is not set | Problem Details:
Don't include procfs functions if CONFIG_PROC_FS is not set
Signed-off by: J.R. Mauro <jrm8005@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/proc.c b/drivers/staging/comedi/proc.c
index 7db12ac0d280..5a2b72d87572 100644
--- a/drivers/staging/comedi/proc.c
+++ b/drivers/staging/comedi/proc.c
@@ -85,6 +85,7 @@ int comedi_read_procmem(char *buf, char **start, off_t offset, int len,
return l;
}
+#ifdef CONFIG_PRO... |
0bf8e27f7a7da413c1cf3dad4afdcf1b17418285 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix checkpatch.pl warning in interrupt.h | Problem Details:
No more need for a kernel version check now that we are in the main
kernel tree.
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/interrupt.h b/drivers/staging/comedi/interrupt.h
index 16532ec7a4b1..3038e461948a 100644
--- a/drivers/staging/comedi/interrupt.h
+++ b/drivers/staging/comedi/interrupt.h
@@ -53,15 +53,8 @@ typedef void irqreturn_t;
#endif
#endif
-/* if interrupt handler prototype has pt_... |
39eca2a087e30001b3679c04338976d3b02b9173 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: me_daq: fix sparse issues | Problem Details:
This fixes the sparse issues that the tool had with the me_daq
driver.
Cc: Michael Hillmann <hillmann@syscongroup.de>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drivers/me_daq.c
index 8821d5286082..6accec20a0f9 100644
--- a/drivers/staging/comedi/drivers/me_daq.c
+++ b/drivers/staging/comedi/drivers/me_daq.c
@@ -234,7 +234,7 @@ static const struct me_board me_boards[] = {
.ao_channel_nbr =... |
2ce411b57ec45a97bf0a0af4afe65b9ed5ad5159 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: me_daq: fix checkpatch.pl issues | Problem Details:
This fixes a number of checkpatch.pl issues in the me_daq
driver.
Cc: Michael Hillmann <hillmann@syscongroup.de>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drivers/me_daq.c
index e741ec54527d..c784ea999506 100644
--- a/drivers/staging/comedi/drivers/me_daq.c
+++ b/drivers/staging/comedi/drivers/me_daq.c
@@ -54,114 +54,111 @@ from http://www.comedi.org
#include "comedi_pci.h"
-//#inc... |
d72187b7cd4bac8eb9f87cabbb8d537145dc4bad | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix comedi_pci.h checkpatch.pl issues. | Problem Details:
This resolves all the resolvable checkpatch.pl issues in the
comedi_pci.h file.
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_pci.h b/drivers/staging/comedi/drivers/comedi_pci.h
index 140787839153..0f32be8ff969 100644
--- a/drivers/staging/comedi/drivers/comedi_pci.h
+++ b/drivers/staging/comedi/drivers/comedi_pci.h
@@ -26,13 +26,8 @@
#ifndef _COMEDI_PCI_H_
#define _COMEDI_PCI_H_
... |
6d62a12bb0fde6a70eb18e2ba25e48f6fd5eee07 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix comedi_fc.h checkpatch.pl issues. | Problem Details:
This resolves all the resolvable checkpatch.pl issues in the
comedi_fc.h file.
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_fc.h b/drivers/staging/comedi/drivers/comedi_fc.h
index b8edd673edfd..6952fe20f273 100644
--- a/drivers/staging/comedi/drivers/comedi_fc.h
+++ b/drivers/staging/comedi/drivers/comedi_fc.h
@@ -30,28 +30,30 @@
#include "../comedidev.h"
/* Writes an array of d... |
652dd4e7c78a2ad1fcf38c12e8be69651922c690 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix comedi_parport.c checkpatch.pl issues. | Problem Details:
This resolves all the resolvable checkpatch.pl issues in the
comedi_parport.c file.
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
index 9530c47806cb..ba838fffa29e 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -90,26 +90,26 @@ pin, which can be used to wake up... |
e0639d7644d8bd204415290221ffebb530fd5949 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix sparse issues in comedi_test.c | Problem Details:
This fixes all issues pointed out by sparse with the comedi_test.c
file.
Cc: Joachim Wuttke <Joachim.Wuttke@icn.siemens.de>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c
index b8911374dcdd..01d177e70070 100644
--- a/drivers/staging/comedi/drivers/comedi_test.c
+++ b/drivers/staging/comedi/drivers/comedi_test.c
@@ -241,9 +241,9 @@ static int waveform_attach(comedi_device *dev... |
1be0e3ed76188c9dd879f421953f5cbf5d9cee58 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix checkpatch.pl issues in comedi_test.c | Problem Details:
This fixes almost all checkpatch.pl issues with the comedi_test.c
file.
Hint, volatile doesn't do what you think it does, it has been removed
from the structure...
Cc: Joachim Wuttke <Joachim.Wuttke@icn.siemens.de>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
... | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c
index 356a9e9c3abd..b8911374dcdd 100644
--- a/drivers/staging/comedi/drivers/comedi_test.c
+++ b/drivers/staging/comedi/drivers/comedi_test.c
@@ -68,11 +68,11 @@ typedef struct waveform_board_struct {
sta... |
246c541822cd6251aa38862f8f13412e5147a1ad | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix sparse issues in comedi_bond.c | Problem Details:
This fixes the issues raised by the sparse tool on the
comedi_bond.c file.
Cc: Calin A. Culianu <calin@ajvar.org>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c
index 4ded9b15c760..9e5496f4f1ae 100644
--- a/drivers/staging/comedi/drivers/comedi_bond.c
+++ b/drivers/staging/comedi/drivers/comedi_bond.c
@@ -103,7 +103,7 @@ MODULE_LICENSE("GPL");
# define STR(x) STR1... |
ff534766e4b9e25e6e4a1f133946dfa8cfe6a747 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: remove typedefs from comedi_bond.c | Problem Details:
This fixes the remaining checkpatch.pl issues found in the
comedi_bond.c file.
Cc: Calin A. Culianu <calin@ajvar.org>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c
index fc803370a040..4ded9b15c760 100644
--- a/drivers/staging/comedi/drivers/comedi_bond.c
+++ b/drivers/staging/comedi/drivers/comedi_bond.c
@@ -129,9 +129,8 @@ MODULE_DESCRIPTION(MODULE_NAME "A driver for ... |
4e85a13b4ea73aa3bb9f735d77a949393cbbad2b | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix checkpatch.pl issues in comedi_fc.c | Problem Details:
This fixes all of the checkpatch.pl issues in the comedi_fc.c file.
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_fc.c b/drivers/staging/comedi/drivers/comedi_fc.c
index da8e9d2844f0..cd74dbe5417d 100644
--- a/drivers/staging/comedi/drivers/comedi_fc.c
+++ b/drivers/staging/comedi/drivers/comedi_fc.c
@@ -28,8 +28,8 @@
#include "comedi_fc.h"
-static void increment_scan... |
e7f2aa345581b5b500b44a4114bdda642938eb2e | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix checkpatch.pl issues in comedi_bond.c | Problem Details:
This fixes a number of the issues found by checkpatch.pl in the
comedi_bond.c file.
Cc: Calin A. Culianu <calin@ajvar.org>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c
index 3a65f0316fc9..fc803370a040 100644
--- a/drivers/staging/comedi/drivers/comedi_bond.c
+++ b/drivers/staging/comedi/drivers/comedi_bond.c
@@ -23,7 +23,8 @@
*/
/*
Driver: comedi_bond
-Description: A dr... |
4274ea02d728f3732433782919b32895555df3ca | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: usbdux: remove checkpatch.pl warnings | Problem Details:
Fix up and remove almost all of the remaining checkpatch.pl errors
and warnings in the usbdux driver.
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@su... | ```diff
diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index 7172f36ecc9c..ac9f34d45de1 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -53,9 +53,11 @@ sampling rate. If you sample two channels you get 4kHz and so on.
... |
b1853a4f28db5b532542426965198171ef8ab6a0 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: dt9812: fix sparse warnings | Problem Details:
remove all warnings that sparse complains about in the dt9812 driver
Cc: Anders Blomdell <anders.blomdell@control.lth.se>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c
index 369048e50ef3..70ea748caab3 100644
--- a/drivers/staging/comedi/drivers/dt9812.c
+++ b/drivers/staging/comedi/drivers/dt9812.c
@@ -769,8 +769,6 @@ static int dt9812_probe(struct usb_interface *interface,
* Se... |
02ebd471ea5b9950d3c30d75ec2f579f9ff0e918 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix build error in comedilib.h | Problem Details:
If anyone included this file, it would break the build.
This patch fixes the issue.
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
index d6a2e378f1ad..fc5fc015726b 100644
--- a/drivers/staging/comedi/comedilib.h
+++ b/drivers/staging/comedi/comedilib.h
@@ -24,7 +24,7 @@
#ifndef _LINUX_COMEDILIB_H
#define _LINUX_COMEDILIB_H
-#include <linux/comedi.h>
+#... |
a9acfa42bf636cab0add8ae1c5138ed9844d047c | Analyze and fix the following issue in the Linux kernel code: Staging: benet: fix problems reported by checkpatch | Problem Details:
Signed-off-by: Sathya Perla <sathyap@serverengines.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/benet/TODO b/drivers/staging/benet/TODO
index 6113737b2299..a51dfb59a62f 100644
--- a/drivers/staging/benet/TODO
+++ b/drivers/staging/benet/TODO
@@ -1,5 +1,4 @@
TODO:
- - fix minor checkpatch.pl issues
- remove wrappers around common iowrite functions
- full netdev audit of co... |
2a5a19caa0584619ea9aec0a67466095a8c92138 | Analyze and fix the following issue in the Linux kernel code: Staging: benet: fix build error. | Problem Details:
udelay() was not being defined properly, this patch fixes it.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Subbu Seetharaman <subbus@serverengines.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/benet/mpu.c b/drivers/staging/benet/mpu.c
index bec8dc9f1735..4ee0b630d06c 100644
--- a/drivers/staging/benet/mpu.c
+++ b/drivers/staging/benet/mpu.c
@@ -14,6 +14,7 @@
* 209 N. Fair Oaks Ave
* Sunnyvale, CA 94085
*/
+#include <linux/delay.h>
#include "hwlib.h"
#include "best... |
d6258716b53e1f25e0a219137640fc8a459591a3 | Analyze and fix the following issue in the Linux kernel code: Staging: benet: fix build errors when CONFIG_NETPOLL is off | Problem Details:
Signed-off-by: Sathya Perla <sathyap@serverengines.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/benet/Kconfig b/drivers/staging/benet/Kconfig
index ffb8ebdfd168..f6806074f998 100644
--- a/drivers/staging/benet/Kconfig
+++ b/drivers/staging/benet/Kconfig
@@ -1,6 +1,6 @@
config BENET
tristate "ServerEngines 10Gb NIC - BladeEngine"
- depends on PCI && INET && NETPOLL
+ depends... |
0252e5c691fd54064212c74435c2255abf3778d5 | Analyze and fix the following issue in the Linux kernel code: Staging: benet: fix up netdev->priv change | Problem Details:
netdev->priv is now gone, so fix up all of the build errors in the benet
driver due to this change.
Cc: Subbu Seetharaman <subbus@serverengines.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/benet/be_ethtool.c b/drivers/staging/benet/be_ethtool.c
index 8c3ac90d2fe8..027af85707aa 100644
--- a/drivers/staging/benet/be_ethtool.c
+++ b/drivers/staging/benet/be_ethtool.c
@@ -79,7 +79,7 @@ static const char benet_gstrings_stats[][ETH_GSTRING_LEN] = {
static void
be_get_drvi... |
85e468cd556b04dcf019deca145639e1f8cb1e63 | Analyze and fix the following issue in the Linux kernel code: Staging: benet: fix netif api breakage | Problem Details:
The netif_rx_complete() and netif_rx_schedule() functions have changed,
so fix up the build breakage in the benet driver.
Cc: Subbu Seetharaman <subbus@serverengines.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/benet/be_int.c b/drivers/staging/benet/be_int.c
index 82472b43fd8f..1e5e2948f174 100644
--- a/drivers/staging/benet/be_int.c
+++ b/drivers/staging/benet/be_int.c
@@ -728,7 +728,7 @@ int be_poll(struct napi_struct *napi, int budget)
/* All consumed */
if (work_done < budget) {
... |
127ce13ceed3e7f5e4fda774b1d64fe5dee50e2a | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: enable WPA_SUPPLICANT support | Problem Details:
This is needed in order to get NetworkManager to work properly
with this driver.
More details can be found at
https://bugzilla.novell.com/show_bug.cgi?id=437959
Cc: Helmut Schaa <hschaa@novell.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/Makefile b/drivers/staging/rt2860/Makefile
index 3496a6409d3c..6162212b588c 100644
--- a/drivers/staging/rt2860/Makefile
+++ b/drivers/staging/rt2860/Makefile
@@ -6,6 +6,8 @@ EXTRA_CFLAGS += -DRT2860
EXTRA_CFLAGS += -DCONFIG_STA_SUPPORT
EXTRA_CFLAGS += -DDBG
EXTRA_CFLAGS +... |
26f0bcd1cfeb657cddcc708a646279fea0eefa20 | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: Fix minor compiler warnings | Problem Details:
The build is "clean" now for this driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/2860_main_dev.c b/drivers/staging/rt2860/2860_main_dev.c
index d65bdbc62762..1e38f2d1f692 100644
--- a/drivers/staging/rt2860/2860_main_dev.c
+++ b/drivers/staging/rt2860/2860_main_dev.c
@@ -1022,7 +1022,7 @@ BOOLEAN RT28XXNetDevInit(
IN RTMP_ADAPTER *pAd)
{
struct pci... |
739b797941598529cc44e39d05227dbbe9254275 | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix up netdev->priv usage | Problem Details:
Now that netdev->priv is removed, fix the driver to use netdev->ml_priv
like it always should have been doing.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/2860_main_dev.c b/drivers/staging/rt2860/2860_main_dev.c
index c29453641851..d65bdbc62762 100644
--- a/drivers/staging/rt2860/2860_main_dev.c
+++ b/drivers/staging/rt2860/2860_main_dev.c
@@ -170,7 +170,7 @@ static int rt2860_suspend(
}
else
{
- pAd = (PRTMP_ADAPTER)net... |
707eefb8ee714ecaae436980cf19a7e7eb171cf1 | Analyze and fix the following issue in the Linux kernel code: Staging: otus: fix urb callback function type | Problem Details:
The #ifdef for version checking is wrong, and we no longer
pass the struct pt_regs to the urb callback functions. This
patch fixes this error.
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
index 5768675b5358..e00bf318cba1 100644
--- a/drivers/staging/otus/wwrap.c
+++ b/drivers/staging/otus/wwrap.c
@@ -259,11 +259,7 @@ u32_t zfLnxPutUsbRxBuffer(zdev_t *dev, zbuf_t *buf)
return 0;
}
-#if (LINUX_VERSION_CODE < KERNEL_VE... |
063e95c7360cd7153caebfa44315bad109fee1da | Analyze and fix the following issue in the Linux kernel code: Staging: otus: fix name clash | Problem Details:
Make p80211wext_handler_def in the otus driver static. It's not used outside
this file and causes name clashes if it's visible.
Signed-off by: J.R. Mauro <jrm8005@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/otus/usbdrv.c b/drivers/staging/otus/usbdrv.c
index 2bef4f98e26a..2f9d06e3dd24 100644
--- a/drivers/staging/otus/usbdrv.c
+++ b/drivers/staging/otus/usbdrv.c
@@ -287,7 +287,7 @@ static const iw_handler usbdrv_private_handler[] =
NULL, /* SIOCIWFIRSTPRIV */
};
-... |
e543c241412f5f68d6948968f1a6c2cbb5fad7ff | Analyze and fix the following issue in the Linux kernel code: Staging: agnx: fix build warnings | Problem Details:
Fix some minor build warnins in the agnx driver
Cc: Li YanBo <dreamfly281@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/agnx/pci.c b/drivers/staging/agnx/pci.c
index 80cccca974af..854630cb527e 100644
--- a/drivers/staging/agnx/pci.c
+++ b/drivers/staging/agnx/pci.c
@@ -207,7 +207,7 @@ static void rings_free(struct agnx_priv *priv)
spin_unlock_irqrestore(&priv->lock, flags);
}
-
+#if 0
static vo... |
aa0d6c34b6d44dcb14957cb768a13c8e4dd03729 | Analyze and fix the following issue in the Linux kernel code: Staging: agnx: fix build errors due to rate control API changes | Problem Details:
In commit e6a9854b05c1a6af1308fe2b8c68f35abf28a3ee, the rate control API
was rewritten, so make the needed changes to the agnx driver so that it
will build and work properly.
Cc: Li YanBo <dreamfly281@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/agnx/xmit.c b/drivers/staging/agnx/xmit.c
index 42ed7d51b6ed..7f01528b8a46 100644
--- a/drivers/staging/agnx/xmit.c
+++ b/drivers/staging/agnx/xmit.c
@@ -626,8 +626,8 @@ static inline void fill_agnx_hdr(struct agnx_priv *priv, struct agnx_info *tx_in
txhdr->reg0 = cpu_to_be32(reg)... |
40667f32d10c501798fba462ffbb71d3afb5b763 | Analyze and fix the following issue in the Linux kernel code: Staging: agnx: fix build errors due to ssid removal | Problem Details:
The wireless core has removed the ssid variables, so also remove
them from the agnx driver so that it builds properly.
Cc: Li YanBo <dreamfly281@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/agnx/agnx.h b/drivers/staging/agnx/agnx.h
index 6f89b9bf796f..a75b0db3726c 100644
--- a/drivers/staging/agnx/agnx.h
+++ b/drivers/staging/agnx/agnx.h
@@ -115,8 +115,6 @@ struct agnx_priv {
int mode;
int channel;
u8 bssid[ETH_ALEN];
- u8 ssid[32];
- size_t ssid_len;
u8 mac_... |
66615321f59c6ff98b7bf2e9a3caf04ff30c031b | Analyze and fix the following issue in the Linux kernel code: Staging: slicoss: use correct type for memory allcations | Problem Details:
Fix sizeof to use the right type
Signed-off-by: Lior Dotan <liodot@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index b8ac872e070c..d256aef9c431 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -323,7 +323,7 @@ static void slic_init_adapter(struct net_device *netdev,
index, pslic_handle, adapter->... |
1352b4b07fae399ae5741a9b6f155420e76a2b00 | Analyze and fix the following issue in the Linux kernel code: Staging: et131x: fix build failure | Problem Details:
Fix build failure in et131x driver - missing \ in multiline macro
Signed-off by: J.R. Mauro <jrm8005@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/et131x/et131x_debug.h b/drivers/staging/et131x/et131x_debug.h
index 4275638c0cc8..994108eca663 100644
--- a/drivers/staging/et131x/et131x_debug.h
+++ b/drivers/staging/et131x/et131x_debug.h
@@ -206,10 +206,10 @@
#define DBG_ASSERT(C) \
do { \
if (!(C)) { \
- D... |
bb9eacccf63bd3ab5474c47abe4212f6f3b9d24f | Analyze and fix the following issue in the Linux kernel code: Staging: et131x: Cleanup et131x_debug.h defines | Problem Details:
This patch cleans up the et131x_debug.h defines as well as fix the
checkpatch warnings
Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/et131x/et131x_debug.h b/drivers/staging/et131x/et131x_debug.h
index dab608031d0b..4275638c0cc8 100644
--- a/drivers/staging/et131x/et131x_debug.h
+++ b/drivers/staging/et131x/et131x_debug.h
@@ -82,11 +82,11 @@
#define DBG_LVL 3
#endif /* DBG_LVL */
-#define DBG_DEFAULTS (DBG_ER... |
9efb052563003c050cf2ad84632746968d414af9 | Analyze and fix the following issue in the Linux kernel code: Staging: go7007: small cleanup | Problem Details:
small cleanup of go7007:
- prepare for urb->status conversion
- micro optimization
- use kzalloc
- fix free of memory in use in go7007_usb_disconnect
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Cc: Cohen <rcohen@snurgle.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/go7007/go7007-usb.c b/drivers/staging/go7007/go7007-usb.c
index f18eaa4bffb4..83eec920c7d3 100644
--- a/drivers/staging/go7007/go7007-usb.c
+++ b/drivers/staging/go7007/go7007-usb.c
@@ -680,9 +680,10 @@ static void go7007_usb_readinterrupt_complete(struct urb *urb)
{
struct go700... |
8fca1cb3a4f7b1eba7e139a4eefc5d01f33d8961 | Analyze and fix the following issue in the Linux kernel code: Staging: go7007: fix minor build warnings | Problem Details:
Comment out some functions that we aren't using yet, in anticipation
of using them when the v4l core merges are changed upstream.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/go7007/go7007-v4l2.c b/drivers/staging/go7007/go7007-v4l2.c
index 7717feff8bea..2ca3877c7ae5 100644
--- a/drivers/staging/go7007/go7007-v4l2.c
+++ b/drivers/staging/go7007/go7007-v4l2.c
@@ -327,6 +327,7 @@ static int set_capture_size(struct go7007 *go, struct v4l2_format *fmt, int t... |
bf437012503cc99519e20b4a8bddf830cdaae794 | Analyze and fix the following issue in the Linux kernel code: Staging: poch: Fix user space protocol syncing | Problem Details:
Always set the user space offset from kernel space, to indicate group
transmitted/received.
Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/poch/poch.c b/drivers/staging/poch/poch.c
index 0a3eca14075e..3ecbd7c43c48 100644
--- a/drivers/staging/poch/poch.c
+++ b/drivers/staging/poch/poch.c
@@ -948,14 +948,7 @@ static int poch_channel_available(struct channel_info *channel)
spin_lock_irq(&channel->group_offsets_lock);
... |
3ca67c1b94f26cacf9c709d2cf39792cf14f1356 | Analyze and fix the following issue in the Linux kernel code: Staging: poch: Fix build warnings | Problem Details:
Removed out printing of DMA address, that causes warnings during
build.
Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/poch/poch.c b/drivers/staging/poch/poch.c
index afc9863f34dd..b54760f41a4b 100644
--- a/drivers/staging/poch/poch.c
+++ b/drivers/staging/poch/poch.c
@@ -390,8 +390,8 @@ static int poch_channel_alloc_groups(struct channel_info *channel)
group->user_offset =
(header_pages + (i... |
7dadbbcf7f88f44cc46c95e6dcfd9b1ac9e8ae62 | Analyze and fix the following issue in the Linux kernel code: Staging: poch: minor fixes | Problem Details:
Unmap PCI bars on remove().
Validate sysfs values before using them.
Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/poch/poch.c b/drivers/staging/poch/poch.c
index 52fc3d4b433b..afc9863f34dd 100644
--- a/drivers/staging/poch/poch.c
+++ b/drivers/staging/poch/poch.c
@@ -397,11 +397,38 @@ static int poch_channel_alloc_groups(struct channel_info *channel)
return 0;
}
-static void channel_latch_... |
95ead520a3d77b1a654ce95ada9639acd7e91619 | Analyze and fix the following issue in the Linux kernel code: Staging: poch: Block size bug fix | Problem Details:
Block size is to be expressed in no. of 64 bit transfers. But the code
specifies the block size in bytes. Fix this issue.
Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/poch/poch.c b/drivers/staging/poch/poch.c
index 0e113f9a1581..de3f8c6fcb0a 100644
--- a/drivers/staging/poch/poch.c
+++ b/drivers/staging/poch/poch.c
@@ -432,7 +432,10 @@ static void channel_dma_init(struct channel_info *channel)
}
printk(KERN_WARNING "block_size, group_size, ... |
66664462909d9c62bcff3dceb579b438563f15ee | Analyze and fix the following issue in the Linux kernel code: Staging: at76_usb: fix up all remaining checkpatch.pl warnings | Problem Details:
It's now a "clean" driver.
Cc: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/at76_usb/at76_usb.c b/drivers/staging/at76_usb/at76_usb.c
index aeee7dbc8022..375ba7cc3006 100644
--- a/drivers/staging/at76_usb/at76_usb.c
+++ b/drivers/staging/at76_usb/at76_usb.c
@@ -91,18 +91,18 @@
/* Use our own dbg macro */
#define at76_dbg(bits, format, arg...) \
- do { \... |
f7b31e015acf5cf081c0e84197b5b3582fe34473 | Analyze and fix the following issue in the Linux kernel code: Staging: at76_usb: fix build breakage | Problem Details:
The previous patch broke the at76_usb driver due to some other
wireless core api changes. This patch fixes the driver to build
properly again.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/at76_usb/at76_usb.c b/drivers/staging/at76_usb/at76_usb.c
index 4f7ea6f6ca9b..bf42a9861f36 100644
--- a/drivers/staging/at76_usb/at76_usb.c
+++ b/drivers/staging/at76_usb/at76_usb.c
@@ -2057,9 +2057,10 @@ exit:
return 0;
}
-static int at76_config(struct ieee80211_hw *hw, struct... |
a1da9da99152e065912d58950089405b15d0aebd | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: fix compiler warnings | Problem Details:
This fixes some compiler warnings in teh wlan-ng driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 89e521183e41..59e5ad10dbda 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -921,7 +921,6 @@ int wlan_unsetup(wlandevice_t *wlandev)
int register_wlandev(wlandev... |
7b7e7e84bdba1553c4a8a0d6b0fa4ebddfbac420 | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: hfa384x_usb.c use newest version of 384x_drvr_start | Problem Details:
include the needed fixes from Karl Relton
<karllinuxtest.relton@ntlworld.com>
see thread on linux-wlan-devel mailing list
"Possible cause of those pesky hfa384x_usbctlx_complete_sync errors"
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Karl Relton <karllinuxtest.relton@ntlworld.com>
S... | ```diff
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 0df9a67c85da..a26609bdc4a5 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -2960,19 +2960,38 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len... |
ee313528d96cbd9eda568fec11fb6fdae13d30a4 | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: p80211netdev.c fix netdev alloc to prevent oops on device start | Problem Details:
a version of this patch is in the wlan-ng_devel tree
initializes netdev correctly to prevent an oops on device start.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 41b62a3fe545..89e521183e41 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -814,13 +814,11 @@ int wlan_setup(wlandevice_t *wlandev)
(unsigned long)wlande... |
1e7201836c576883d5bd708810cc72ab1392756f | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: Delete a pile of unused mibs. And fix WEXT SET_TXPOWER. | Problem Details:
Signed-off-by: Solomon Peachy <pizza@shaftnet.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/drivers/staging/wlan-ng/p80211metadef.h
index 8d2d133a4df7..ff27d4ace391 100644
--- a/drivers/staging/wlan-ng/p80211metadef.h
+++ b/drivers/staging/wlan-ng/p80211metadef.h
@@ -798,25 +798,6 @@
(P80211DID_MKSECTION(1) | \
P80211DID_MKGROUP(4) | \
... |
f02466fc19f77fc47a0573d5c246b3333e076894 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: fix config build warnings | Problem Details:
the wireless config function has changed with commit
e8975581f63870be42ff4662b293d1b0c8c21350 so fix up the wbusb driver to
work properly with that change.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index cb4dee566f7f..b003f9a7e151 100644
--- a/drivers/staging/winbond/wbusb.c
+++ b/drivers/staging/winbond/wbusb.c
@@ -134,11 +134,12 @@ static int wbsoft_start(struct ieee80211_hw *dev)
return 0;
}
-static int wbsoft_config(st... |
310d465d8365dbb1258b972c8a7c35f8d9dc68a3 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: fix Kconfig | Problem Details:
4KSTACK dependency was needed when driver carried its own softmac
layer. That layer is gone, and functions have reasonably small stack
footprint -> dependency can be removed.
Add better description of hardware this driver is targetted at (now
with fixed whitespace)
Signed-off-by: Pavel Machek <pavel@... | ```diff
diff --git a/drivers/staging/winbond/Kconfig b/drivers/staging/winbond/Kconfig
index 425219ed7ab9..940460c39f36 100644
--- a/drivers/staging/winbond/Kconfig
+++ b/drivers/staging/winbond/Kconfig
@@ -1,7 +1,11 @@
config W35UND
- tristate "Winbond driver"
- depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTA... |
8421513d9ab4e510136d0b3042bd838d08129012 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: remove some dead code | Problem Details:
This patch removes the WBLinux_ReceivePacket(), WBLINUX_GetNextPacket(),
WBLINUX_GetNextPacketCompleted, and sme_get_rssi() functions, which execute
BUG() unconditionally, and related dead code.
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: ... | ```diff
diff --git a/drivers/staging/winbond/Makefile b/drivers/staging/winbond/Makefile
index 29c98bf1bc98..ed3180c25d44 100644
--- a/drivers/staging/winbond/Makefile
+++ b/drivers/staging/winbond/Makefile
@@ -7,7 +7,6 @@ w35und-objs := $(DRIVER_DIR)/wbusb.o $(DRIVER_DIR)/wb35reg.o $(DRIVER_DIR)/wb35r
phy_calibratio... |
16d3659fcda922a31873e9e827b12c825b36fd11 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: plug memory leak in wbsoft_tx() | Problem Details:
There's no reason to duplicate the skb in wbsoft_tx() and leak GFP_ATOMIC
memory as the contents are copied to ->TxBuffer in MdxTx() anyway before
MLMESendFrame() returns.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gre... | ```diff
diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c
index d9c3a16c4156..75213b53a49f 100644
--- a/drivers/staging/winbond/linux/wbusb.c
+++ b/drivers/staging/winbond/linux/wbusb.c
@@ -107,11 +107,8 @@ static void wbsoft_configure_filter(struct ieee80211_hw *dev,
static ... |
4af12e55a5f5e8d0d6d9390a592daa789a181e36 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: usb_put_dev() is missing from wb35_disconnect() | Problem Details:
The wb35_probe() function does usb_get_dev() so add a missing usb_put_dev() to
the wb35_disconnect() function. Also fix error handling paths in wb35_probe()
to call usb_put_dev() as well.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kr... | ```diff
diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c
index eb115034498a..d9c3a16c4156 100644
--- a/drivers/staging/winbond/linux/wbusb.c
+++ b/drivers/staging/winbond/linux/wbusb.c
@@ -275,6 +275,7 @@ error_free_hw:
error_free_adapter:
kfree(adapter);
error:
+ usb_put_d... |
1523ddc4826155b76614e75375e2bbb27b4603f7 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: wb35_probe() cleanup | Problem Details:
Fix error handling in wb35_probe() function and clean it up a bit.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c
index 5f09fd49f52b..c1c2642f69c6 100644
--- a/drivers/staging/winbond/linux/wbusb.c
+++ b/drivers/staging/winbond/linux/wbusb.c
@@ -191,26 +191,33 @@ static int wb35_probe(struct usb_interface *intf, const struct usb_devi... |
a55a89b175a1802e89b5654e2b9ae84ed032ea22 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: purb typedef removal | Problem Details:
This patch removes the struct urb pointer typedef from the driver code and
fixes up variable names that use the typedef while we're at it.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/linux/common.h b/drivers/staging/winbond/linux/common.h
index 712a86cfa68b..64bd1c7dff65 100644
--- a/drivers/staging/winbond/linux/common.h
+++ b/drivers/staging/winbond/linux/common.h
@@ -69,10 +69,6 @@
#define BIT(x) (1 << (x))
#endif
-typedef struct ... |
60572c0d8b8a5164445b3ebcaa0b15f7935f321a | Analyze and fix the following issue in the Linux kernel code: Staging: go7007: fixes due v4l2_file_operations api change | Problem Details:
v4l2_file_operations was introduced, so use it to fix up
the build errors in the go7007 driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/go7007/go7007-v4l2.c b/drivers/staging/go7007/go7007-v4l2.c
index b925761350c2..dfbc2e91c23b 100644
--- a/drivers/staging/go7007/go7007-v4l2.c
+++ b/drivers/staging/go7007/go7007-v4l2.c
@@ -81,7 +81,7 @@ static int go7007_streamoff(struct go7007 *go)
return 0;
}
-static int go7... |
4f7ddec22312926909c03b220c74b0efad4affe8 | Analyze and fix the following issue in the Linux kernel code: Staging: go7007: fixes due to video_usercopy api change | Problem Details:
video_usercopy() just changed its arguments, so fix up the go7007 driver
to properly build.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/go7007/go7007-v4l2.c b/drivers/staging/go7007/go7007-v4l2.c
index 94e1141a1fcd..b925761350c2 100644
--- a/drivers/staging/go7007/go7007-v4l2.c
+++ b/drivers/staging/go7007/go7007-v4l2.c
@@ -375,8 +375,7 @@ static int clip_to_modet_map(struct go7007 *go, int region,
return 0;
}
... |
3f4528d6e91cffde49894f5252e6657d420d3d74 | Analyze and fix the following issue in the Linux kernel code: sparc64: Fix unsigned long long warnings in drivers. | Problem Details:
Fix warnings caused by the unsigned long long usage in sparc
specific drivers.
The drivers were considered sparc specific more or less from the
filename alone.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem... | ```diff
diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
index 953c0b83d758..5861e33efe63 100644
--- a/drivers/block/sunvdc.c
+++ b/drivers/block/sunvdc.c
@@ -153,7 +153,7 @@ static int vdc_send_attr(struct vio_driver_state *vio)
pkt.vdisk_block_size = port->vdisk_block_size;
pkt.max_xfer_size = port->m... |
9018113649348c689da107166c05d436cd52e7bf | Analyze and fix the following issue in the Linux kernel code: sparc64: Use unsigned long long for u64. | Problem Details:
Andrew Morton wrote:
People keep on doing
printk("%llu", some_u64);
testing it only on x86_64 and this generates a warning storm on
powerpc, sparc64, etc. Because they use `long', not `long long'.
Quite a few 64-bit architectures are using `long' for their
s64/u64 t... | ```diff
diff --git a/arch/sparc/include/asm/timer_64.h b/arch/sparc/include/asm/timer_64.h
index 5b779fd1f788..ef3c3682debf 100644
--- a/arch/sparc/include/asm/timer_64.h
+++ b/arch/sparc/include/asm/timer_64.h
@@ -10,7 +10,7 @@
#include <linux/init.h>
struct sparc64_tick_ops {
- unsigned long (*get_tick)(void);
+ ... |
4b905671d2ea09fd48fed72c581df17e40823f39 | Analyze and fix the following issue in the Linux kernel code: jbd2: Fix oops in jbd2_journal_init_inode() on corrupted fs | Problem Details:
On 32-bit system with CONFIG_LBD getblk can fail because provided
block number is too big. Add error checks so we fail gracefully if
getblk() returns NULL (which can also happen on memory allocation
failures).
Thanks to David Maciejak from Fortinet's FortiGuard Global Security
Research Team for repor... | ```diff
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index fe20e40ee7c3..2932c8f55199 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -632,6 +632,8 @@ struct journal_head *jbd2_journal_get_descriptor_buffer(journal_t *journal)
return NULL;
bh = __getblk(journal->j_dev, blocknr, journal->j_blocksi... |
07716e4df25523bf85b4e304d2cf63dbf3cbabf9 | Analyze and fix the following issue in the Linux kernel code: ia64: fix section mismatch swiotlb_dma_init -> swiotlb_init | Problem Details:
Impact: Section fix
WARNING: vmlinux.o(.text+0x596d2): Section mismatch in
reference from the function swiotlb_dma_init() to the function
.init.text:swiotlb_init()
The function swiotlb_dma_init() references
the function __init swiotlb_init().
This is often because swiotlb_dma_init lacks a __init
annot... | ```diff
diff --git a/arch/ia64/kernel/pci-swiotlb.c b/arch/ia64/kernel/pci-swiotlb.c
index e6b2ec9b27da..d21dea44e76f 100644
--- a/arch/ia64/kernel/pci-swiotlb.c
+++ b/arch/ia64/kernel/pci-swiotlb.c
@@ -33,7 +33,7 @@ struct dma_map_ops swiotlb_dma_ops = {
.mapping_error = swiotlb_dma_mapping_error,
};
-void swiotl... |
035da16fb529c0383ac27c712a5bbade5c11cafe | Analyze and fix the following issue in the Linux kernel code: s390: remove s390_root_dev_*() | Problem Details:
Replace s390_root_dev_register() with root_device_register() etc.
[Includes fix from Cornelia Huck]
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/arch/s390/include/asm/s390_rdev.h b/arch/s390/include/asm/s390_rdev.h
deleted file mode 100644
index 6fa20442a48c..000000000000
--- a/arch/s390/include/asm/s390_rdev.h
+++ /dev/null
@@ -1,15 +0,0 @@
-/*
- * include/asm-s390/ccwdev.h
- *
- * Copyright (C) 2002,2005 IBM Deutschland Entwicklung Gm... |
7232800ba8aca1c070d43a81cc49991f230b5da1 | Analyze and fix the following issue in the Linux kernel code: driver core:fix duplicate removing driver link in __device_release_driver | Problem Details:
In __device_release_driver(),driver_sysfs_remove() has removed the
driver link under device dir in sysfs, but sysfs_remove_link() is
called again to do such thing. Remove the duplicate call to
sys_remove_link().
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@... | ```diff
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index bb5f1eb83c03..6fdaf76f033f 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -298,7 +298,6 @@ static void __device_release_driver(struct device *dev)
drv = dev->driver;
if (drv) {
driver_sysfs_remove(dev);
- sysfs_remove_link(&dev->kobj, "... |
d0d85ff989222f08dd1fa66321fef5567bbc4a7b | Analyze and fix the following issue in the Linux kernel code: Make DEBUG take precedence over DYNAMIC_PRINTK_DEBUG | Problem Details:
Statically defined DEBUG should take precedence over
dynamically enabled debugging; otherwise adding DEBUG
(like, for example, via CONFIG_DEBUG_KOBJECT) does not
have the expected result of printing pr_debug() and dev_dbg()
messages unconditionally.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.c... | ```diff
diff --git a/include/linux/device.h b/include/linux/device.h
index e21b5d69d67c..b97a0cf1eb05 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -553,13 +553,13 @@ extern const char *dev_driver_string(const struct device *dev);
#define dev_info(dev, format, arg...) \
dev_printk(KERN_INFO , ... |
355a72d75b3b4f4877db4c9070c798238028ecb5 | Analyze and fix the following issue in the Linux kernel code: PCI: Rework default handling of suspend and resume | Problem Details:
Rework the handling of suspend and resume of PCI devices which have
no drivers or the drivers of which do not provide any suspend-resume
callbacks in such a way that their standard PCI configuration
registers will be saved and restored with interrupts disabled. This
should prevent such devices, includ... | ```diff
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 4042d211c3e5..99d867bcf22a 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -300,6 +300,14 @@ static void pci_device_shutdown(struct device *dev)
#ifdef CONFIG_PM_SLEEP
+static bool pci_has_legacy_pm_support(struc... |
cd3772e6898c6386f21d2958346d6dd57d4204f5 | Analyze and fix the following issue in the Linux kernel code: kernel/ksysfs.c:fix dependence on CONFIG_NET | Problem Details:
Access to uevent_seqnum and uevent_helper does not need to
depend on CONFIG_NET, so remove it.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c
index 08dd8ed86c77..528dd78e7e7e 100644
--- a/kernel/ksysfs.c
+++ b/kernel/ksysfs.c
@@ -24,7 +24,7 @@ static struct kobj_attribute _name##_attr = __ATTR_RO(_name)
static struct kobj_attribute _name##_attr = \
__ATTR(_name, 0644, _name##_show, _name##_store)
-#... |
c65b9145f40da99cad000f81823265dc70e5fcf9 | Analyze and fix the following issue in the Linux kernel code: uevent: don't pass envp_ext[] as format string in kobject_uevent_env() | Problem Details:
kobject_uevent_env() uses envp_ext[] as verbatim format string which
can cause problems ranging from unexpectedly mangled string to oops if
a string in envp_ext[] contains substring which can be interpreted as
format. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Kay Sievers <kay.sievers@vrfy.... | ```diff
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 3f914725bda8..ca215bc2329a 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -165,7 +165,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobject_action action,
/* keys passed in from the caller */
if (envp_ext) {
for (i =... |
7f4f5d4516b441d712fa0ffe5380618fb7fc545e | Analyze and fix the following issue in the Linux kernel code: Fix misspellings in pm.h macros | Problem Details:
This patch (as1167) fixes some misspellings in various recently-added
macros in pm.h. Fortunately these macros are not yet used anywhere.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl> | ```diff
diff --git a/include/linux/pm.h b/include/linux/pm.h
index 5785666d0cc4..de2e0a8f6728 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -252,7 +252,7 @@ struct dev_pm_ops {
#define PM_EVENT_SLEEP (PM_EVENT_SUSPEND | PM_EVENT_HIBERNATE)
#define PM_EVENT_USER_SUSPEND (PM_EVENT_USER | PM_EVENT_SUSPEND... |
53a3294e26c49622daa14c1d8540500f568ded99 | Analyze and fix the following issue in the Linux kernel code: bonding: use net_device_ops | Problem Details:
Use the correct pointer in debug message.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 460c2cad2755..9fb388388fb7 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4148,7 +4148,7 @@ static int bond_change_mtu(struct net_device *bond_dev, int new_mtu)
bond_for_each_slave(bo... |
b9bdcbba010c2e49c8f837ea7a49fe006b636f41 | Analyze and fix the following issue in the Linux kernel code: ioat: fix self test for multi-channel case | Problem Details:
In the multiple device case we need to re-arm the completion and protect
against concurrent self-tests. The printk from the test callback is
removed as it can arbitrarily delay completion of the test.
Cc: <stable@kernel.org>
Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>
Signed-off-by: Dan William... | ```diff
diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
index e42e1aea0f18..b3759c4b6536 100644
--- a/drivers/dma/ioat_dma.c
+++ b/drivers/dma/ioat_dma.c
@@ -1340,12 +1340,11 @@ static void ioat_dma_start_null_desc(struct ioat_dma_chan *ioat_chan)
*/
#define IOAT_TEST_SIZE 2000
-DECLARE_COMPLETION(tes... |
0d603f611d6515049fbceb0267ded43c33b95451 | Analyze and fix the following issue in the Linux kernel code: iop-adma: kill debug BUG_ON | Problem Details:
This BUG_ON caught problems in early development but now it is in the
way as it invalidly triggers when trying to remove the module.
Signed-off-by: Dan Williams <dan.j.williams@intel.com> | ```diff
diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c
index 0c6bbf5407c4..e82e39e5da3b 100644
--- a/drivers/dma/iop-adma.c
+++ b/drivers/dma/iop-adma.c
@@ -269,8 +269,6 @@ static void __iop_adma_slot_cleanup(struct iop_adma_chan *iop_chan)
break;
}
- BUG_ON(!seen_current);
-
if (cookie > 0) {
... |
54224f04ae95d86b27c0673cd773ebb120d86876 | Analyze and fix the following issue in the Linux kernel code: NFSD: Fix a handful of coding style issues in write_filehandle() | Problem Details:
Clean up: follow kernel coding style.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 173c4dd3d7a8..498d763b9320 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -390,11 +390,13 @@ static ssize_t write_filehandle(struct file *file, char *buf, size_t size)
dname = mesg;
len = qword_get(&mesg, dname, size);
- if (len <= 0) return ... |
05f3a9af58180d24a9decedd71d4587935782d70 | Analyze and fix the following issue in the Linux kernel code: NSM: Remove !nsm check from nsm_release() | Problem Details:
The nsm_release() function should never be called with a NULL handle
point. If it is, that's a bug.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
index 0a066a13478e..0792900b6281 100644
--- a/fs/lockd/mon.c
+++ b/fs/lockd/mon.c
@@ -288,8 +288,6 @@ found:
*/
void nsm_release(struct nsm_handle *nsm)
{
- if (!nsm)
- return;
if (atomic_dec_and_lock(&nsm->sm_count, &nsm_lock)) {
list_del(&nsm->sm_link);
... |
bc1cc6c4e476b60df48227165990c87a22db6bb7 | Analyze and fix the following issue in the Linux kernel code: NSM: Remove NULL pointer check from nsm_find() | Problem Details:
The nsm_find() function should never be called with a NULL IP address
pointer. If it is, that's a bug.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
index 38255455563d..0a066a13478e 100644
--- a/fs/lockd/mon.c
+++ b/fs/lockd/mon.c
@@ -224,9 +224,6 @@ struct nsm_handle *nsm_find(const struct sockaddr *sap, const size_t salen,
struct nsm_handle *nsm = NULL;
struct nsm_handle *pos;
- if (!sap)
- return NULL;
... |
03eb1dcbb799304b58730f4dba65812f49fb305e | Analyze and fix the following issue in the Linux kernel code: NSM: move to xdr_stream-based XDR encoders and decoders | Problem Details:
Introduce xdr_stream-based XDR encoder and decoder functions, which are
more careful about preventing RPC buffer overflows.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
index 0fc9836db4e7..81e1cc14246f 100644
--- a/fs/lockd/mon.c
+++ b/fs/lockd/mon.c
@@ -193,21 +193,26 @@ nsm_create(void)
* Status Monitor wire protocol.
*/
-static __be32 *xdr_encode_nsm_string(__be32 *p, char *string)
+static int encode_nsm_string(struct xdr_s... |
29ed1407ed81086b778ebf12145b048ac3f7e10e | Analyze and fix the following issue in the Linux kernel code: NSM: Support IPv6 version of mon_name | Problem Details:
The "mon_name" argument of the NSMPROC_MON and NSMPROC_UNMON upcalls
is a string that contains the hostname or IP address of the remote peer
to be notified when this host has rebooted. The sm-notify command uses
this identifier to contact the peer when we reboot, so it must be
either a well-qualified ... | ```diff
diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
index 497dfea02e8a..a606fbbf804d 100644
--- a/fs/lockd/mon.c
+++ b/fs/lockd/mon.c
@@ -18,8 +18,6 @@
#define NLMDBG_FACILITY NLMDBG_MONITOR
-#define XDR_ADDRBUF_LEN (20)
-
static struct rpc_clnt * nsm_create(void);
static struct rpc_program nsm_program;
@@ ... |
f47534f7f0ac7727e05ec4274b764b181df2cf7f | Analyze and fix the following issue in the Linux kernel code: NSM: Use modern style for sm_name field in nsm_handle | Problem Details:
Clean up: I'm about to add another "char *" field to the nsm_handle
structure. The sm_name field uses an older style of declaring a
"char *" field. If I match that style for the new field, checkpatch.pl
will complain.
So, fix the sm_name field to use the new style.
Signed-off-by: Chuck Lever <chuck... | ```diff
diff --git a/include/linux/lockd/lockd.h b/include/linux/lockd/lockd.h
index 80a0a2cff2b8..54dbb458e73c 100644
--- a/include/linux/lockd/lockd.h
+++ b/include/linux/lockd/lockd.h
@@ -79,7 +79,7 @@ struct nlm_host {
struct nsm_handle {
struct list_head sm_link;
atomic_t sm_count;
- char * sm_name;
+ char... |
5acf43155d1bcc412d892c73f64044f9a826cde6 | Analyze and fix the following issue in the Linux kernel code: NSM: convert printk(KERN_DEBUG) to a dprintk() | Problem Details:
Clean up: make the printk(KERN_DEBUG) in nsm_mon_unmon() a dprintk,
and add another dprintk to note if creating an RPC client for the
upcall failed.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
index 6f6ff410341a..497dfea02e8a 100644
--- a/fs/lockd/mon.c
+++ b/fs/lockd/mon.c
@@ -52,6 +52,8 @@ nsm_mon_unmon(struct nsm_handle *nsm, u32 proc, struct nsm_res *res)
clnt = nsm_create();
if (IS_ERR(clnt)) {
status = PTR_ERR(clnt);
+ dprintk("lockd: failed ... |
7538ce1eb656a1477bedd5b1c202226e7abf5e7b | Analyze and fix the following issue in the Linux kernel code: NLM: Use modern style for pointer fields in nlm_host | Problem Details:
Clean up: I'm about to add another "char *" field to the nlm_host
structure. The h_name field, for example, uses an older style of
declaring a "char *" field. If I match that style for the new field,
checkpatch.pl will complain.
So, fix pointer fields to use the new style.
Signed-off-by: Chuck Leve... | ```diff
diff --git a/include/linux/lockd/lockd.h b/include/linux/lockd/lockd.h
index 23da3fa69efa..3dbdd353156c 100644
--- a/include/linux/lockd/lockd.h
+++ b/include/linux/lockd/lockd.h
@@ -43,8 +43,8 @@ struct nlm_host {
struct sockaddr_storage h_addr; /* peer address */
size_t h_addrlen;
struct sockaddr_sto... |
2bd9e7b62e6e1da3f881c40c73d93e9a212ce6de | Analyze and fix the following issue in the Linux kernel code: nfsd: Fix leaked memory in nfs4_make_rec_clidname | Problem Details:
cksum.data is not freed up in one error case. Compile tested.
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index 0f9d6efaa62b..74f7b67567fd 100644
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -116,9 +116,9 @@ nfs4_make_rec_clidname(char *dname, struct xdr_netobj *clname)
md5_to_hex(dname, cksum.data);
- kfree(cksum.data);
status = nfs_o... |
07d400a6df4767a90d49a153fdb7f4cfa1e3f23e | Analyze and fix the following issue in the Linux kernel code: Btrfs: tree logging checksum fixes | Problem Details:
This patch contains following things.
1) Limit the max size of btrfs_ordered_sum structure to PAGE_SIZE. This
struct is kmalloced so we want to keep it reasonable.
2) Replace copy_extent_csums by btrfs_lookup_csums_range. This was
duplicated code in tree-log.c
3) Remove replay_one_csum. csum items... | ```diff
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 171ca30a3755..293da650873f 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -5579,7 +5579,7 @@ int btrfs_reloc_clone_csums(struct inode *inode, u64 file_pos, u64 len)
BUG_ON(ordered->file_offset != file_pos || ordered->len !... |
e630fcbe9399e0cfec097f516b758680f2b2bdaa | Analyze and fix the following issue in the Linux kernel code: ide: fix ide_port_scan() to do ACPI setup after initializing request queues | Problem Details:
This makes ide_port_scan()'s behavior match ide_host_register()'s
one and fixes OOPS in elv_may_queue() during port re-scan.
Reported-and-tested-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | ```diff
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index f71f4eb4705a..ebb1b7f863f4 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -1694,8 +1694,8 @@ void ide_port_scan(ide_hwif_t *hwif)
hwif->present = 1;
ide_port_tune_devices(hwif);
- ide_acpi_port_init_devices(hwif);
... |
744a82b004b0a08d55f579daa55e32d963353edc | Analyze and fix the following issue in the Linux kernel code: ide: Fix drive's DWORD-IO handling | Problem Details:
According the documentation, id[ATA_ID_DWORD_IO] is non-zero if
the drive supports dword IO, while the code disables support by
setting IDE_DFLAG_NO_IO_32BIT. In addition, this word has been
reused by the ATA8 specification. This patch fixes both cases.
Signed-off-by: Mario Schwalbe <schwalbe@inf.tu-d... | ```diff
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index e688ca1c967c..f71f4eb4705a 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -849,8 +849,7 @@ static void ide_port_tune_devices(ide_hwif_t *hwif)
}
ide_port_for_each_dev(i, drive, hwif) {
- if ((hwif->host_flags & ID... |
42cf2611b28602cf4c9dc7c22bc8653a10dff60d | Analyze and fix the following issue in the Linux kernel code: ide: fix setting nIEN on idle devices | Problem Details:
Fix do_ide_request() to operate on previous device / port instead of
the current one. The original code was wrong since at least Feb 2002
(2.4.0 timeframe).
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | ```diff
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index c3cbe5a1e307..1d63159fc97d 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -724,7 +724,9 @@ void do_ide_request(struct request_queue *q)
spin_lock_irq(&hwgroup->lock);
if (!ide_lock_hwgroup(hwgroup)) {
+ ide_hwif_t *prev_port;... |
b46f205da647608a4064ce0a0acb07a8c74c6f23 | Analyze and fix the following issue in the Linux kernel code: ide: fix LOCKDEP warning | Problem Details:
commit 295f00042aaf6b553b5f37348f89bab463d4a469 ("ide: don't execute
the next queued command from the hard-IRQ context") overlooked that
ide_do_drive_cmd() (used for REQUEST SENSE command handling) may still
invoke do_ide_request() (->request_fn) in the hard-IRQ context through
blk_start_queueing(). T... | ```diff
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 1c36a8e83d36..c3cbe5a1e307 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -1197,7 +1197,6 @@ void ide_do_drive_cmd(ide_drive_t *drive, struct request *rq)
spin_lock_irqsave(q->queue_lock, flags);
__elv_add_request(q, rq, ELEVA... |
36c401a44abcc389a00f9cd14892c9cf9bf0780d | Analyze and fix the following issue in the Linux kernel code: [IA64] fix typo in cpumask_of_pcibus() | Problem Details:
Impact: build fix
Fujita Tomonori reported:
drivers/pci/probe.c: In function 'pci_bus_show_cpuaffinity':
drivers/pci/probe.c:56: error: implicit declaration of function 'cpumask_from_node'
drivers/pci/probe.c:56: warning: pointer/integer type mismatch in conditional expression
make[3]: *** [drive... | ```diff
diff --git a/arch/ia64/include/asm/topology.h b/arch/ia64/include/asm/topology.h
index 76a33a91ca69..32f3af1641c5 100644
--- a/arch/ia64/include/asm/topology.h
+++ b/arch/ia64/include/asm/topology.h
@@ -124,7 +124,7 @@ extern void arch_fix_phys_package_id(int num, u32 slot);
#define cpumask_of_pcibus(bus) (p... |
180591bcfed1a2cec048abb21d3dab840625caab | Analyze and fix the following issue in the Linux kernel code: Btrfs: Use btrfs_join_transaction to avoid deadlocks during snapshot creation | Problem Details:
Snapshot creation happens at a specific time during transaction commit. We
need to make sure the code called by snapshot creation doesn't wait
for the running transaction to commit.
This changes btrfs_delete_inode and finish_pending_snaps to use
btrfs_join_transaction instead of btrfs_start_transacti... | ```diff
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 1b35ea63b6ce..c0ca9c3723c0 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -2886,7 +2886,7 @@ void btrfs_delete_inode(struct inode *inode)
btrfs_wait_ordered_range(inode, 0, (u64)-1);
btrfs_i_size_write(inode, 0);
- trans = btrfs_start_transac... |
227b4dc6432d271eecd0ff0aefe6f0897ec47397 | Analyze and fix the following issue in the Linux kernel code: ASoC: Fix SND_SOC_ALL_CODECS handling of dual SPI and I2C control buses | Problem Details:
For codecs that have both SPI and I2C support we need to ensure that we
don't try to make the codec driver built in when I2C is modular since
that won't link. Do this by creating a helper variable which uses
conditional defaults to pick up the correct value for all combinations.
We don't need to do a... | ```diff
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c41289b5f586..d0e0d691ae51 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1,3 +1,13 @@
+# Helper to resolve issues with configs that have SPI enabled but I2C
+# modular, meaning we can't build the codec driver in wi... |
ffbbef5c0639dbf31a0511d8f65f574bb3e30758 | Analyze and fix the following issue in the Linux kernel code: intel-iommu: add map_page and unmap_page | Problem Details:
This is a preparation of struct dma_mapping_ops unification. We use
map_page and unmap_page instead of map_single and unmap_single.
This uses a temporary workaround, ifdef X86_64 to avoid IA64
build. The workaround will be removed after the unification. Well,
changing x86's struct dma_mapping_ops coul... | ```diff
diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
index 235fb7a5a8a5..60258ecbcb4c 100644
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -2273,6 +2273,15 @@ error:
return 0;
}
+static dma_addr_t intel_map_page(struct device *dev, struct page *page,
+ unsigned long o... |
4d9f94319c485f5af6717dfd7a333949636aed16 | Analyze and fix the following issue in the Linux kernel code: x86: fix x86_32 builds for summit and es7000 arch's | Problem Details:
Fix the following build errors reported by Yinghai Lu:
| In file included from arch/x86/mach-generic/summit.c:16:
| tip/linux-2.6/arch/x86/include/asm/summit/apic.h:
| In function 'cpu_mask_to_apicid_and':
| tip/linux-2.6/arch/x86/include/asm/summit/apic.h:179:
| error: 'GFP_ATOMIC' undeclared (first ... | ```diff
diff --git a/arch/x86/include/asm/es7000/apic.h b/arch/x86/include/asm/es7000/apic.h
index bc53d5ef1386..c58b9cc74465 100644
--- a/arch/x86/include/asm/es7000/apic.h
+++ b/arch/x86/include/asm/es7000/apic.h
@@ -1,6 +1,8 @@
#ifndef __ASM_ES7000_APIC_H
#define __ASM_ES7000_APIC_H
+#include <linux/gfp.h>
+
#d... |
5a9e67b1a19e08a82387709f325d26e07b891d27 | Analyze and fix the following issue in the Linux kernel code: trivial: chack -> check typo fix in main Makefile | Problem Details:
Trivial one letter spelling in main Makefile
Signed-off-by: Anisse Astier <anisse@astier.eu>
Signed-off-by: Jiri Kosina <jkosina@suse.cz> | ```diff
diff --git a/Makefile b/Makefile
index f9006663f01e..c9ac00837787 100644
--- a/Makefile
+++ b/Makefile
@@ -1008,7 +1008,7 @@ define check-symlink
endef
# We create the target directory of the symlink if it does
-# not exist so the test in chack-symlink works and we have a
+# not exist so the test in check-s... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.