id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
308bb52c192cc1bad3c90c82dbd90e7fff176caa | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9662): uvcvideo: Fix printk badness when printing ioctl names | Problem Details:
Add a trailing newline character after calling v4l_printk_ioctl() to avoid
messing the kernel log up and merge the uvc_v4l2_ioctl message with the ioctl
name.
Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/uvc/uvc_v4l2.c b/drivers/media/video/uvc/uvc_v4l2.c
index 01b48a87a9b9..7b1c1363583c 100644
--- a/drivers/media/video/uvc/uvc_v4l2.c
+++ b/drivers/media/video/uvc/uvc_v4l2.c
@@ -464,9 +464,6 @@ static int uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
struct... |
9bc6218dc1dc7bd421f3d141241c8e0e70c4e92b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9660): uvcvideo: Fix unaligned memory access. | Problem Details:
Use the unaligned memory access macros when accessing unaligned memory.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/uvc/uvc_driver.c b/drivers/media/video/uvc/uvc_driver.c
index 1e3b4fe5ae93..7fe3ae954c19 100644
--- a/drivers/media/video/uvc/uvc_driver.c
+++ b/drivers/media/video/uvc/uvc_driver.c
@@ -32,6 +32,7 @@
#include <linux/vmalloc.h>
#include <linux/wait.h>
#include <asm/atomic.h>
+... |
60245e858ddb2255d458868be16ba814f6f8d446 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9629): Add support for the ATI TV Wonder HD 600 USB Remote Control | Problem Details:
Add support for the ATI TV Wonder HD 600 USB Remote Control
(required a new keymap)
[mchehab@redhat.com: Fix CodingStyle]
Signed-off-by: Devin Heitmueller <devin.heitmueller@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/common/ir-keymaps.c b/drivers/media/common/ir-keymaps.c
index 4952aeb5dd80..3534cdc1f953 100644
--- a/drivers/media/common/ir-keymaps.c
+++ b/drivers/media/common/ir-keymaps.c
@@ -2511,3 +2511,35 @@ IR_KEYTAB_TYPE ir_codes_real_audio_220_32_keys[IR_KEYTAB_SIZE] = {
};
EXPORT_SYMBO... |
0a6b8a851efae71b0a6f2cbf5d40880553dfabaa | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9612): Fix key repetition with HVR-950 IR | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-input.c b/drivers/media/video/em28xx/em28xx-input.c
index f724cae8b040..159b5c307f25 100644
--- a/drivers/media/video/em28xx/em28xx-input.c
+++ b/drivers/media/video/em28xx/em28xx-input.c
@@ -67,6 +67,7 @@ struct em28xx_IR {
u32 mask_keycode;
u32 mask_keydown;
... |
1958578da6f3971227fca94a62429cdf0bd3c699 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9591): v4l core: fix debug printk for enumberating framerates | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 98a0bf22e43c..bef4286933a1 100644
--- a/drivers/media/video/v4l2-ioctl.c
+++ b/drivers/media/video/v4l2-ioctl.c
@@ -1816,9 +1816,13 @@ static int __video_do_ioctl(struct file *file,
p->discrete.denominator);
break;
... |
492404449532e40b5b6ed06b56aae2bf710239e6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9586): Fix possible null pointer dereference in info message | Problem Details:
Fix case where we could end up dereferencing a NULL pointer if dev->vdev or
dev->vbi_dev were not set properly.
Signed-off-by: Devin Heitmueller <devin.heitmueller@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 415dff830f88..e8edeecf367d 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -1600,8 +1600,6 @@ static void em28xx_release_resources(struct em28xx *dev... |
65c9fd4609ccbabe4aa354eeab7823507424d8b3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9581): Remove unused variable from em28xx-audio.c | Problem Details:
Remove unused variable from em28xx-audio.c
Fix warning for unused "ret" variable
Signed-off-by: Devin Heitmueller <devin.heitmueller@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c
index 215ee789f107..4a42b29481b6 100644
--- a/drivers/media/video/em28xx/em28xx-audio.c
+++ b/drivers/media/video/em28xx/em28xx-audio.c
@@ -424,7 +424,7 @@ static int em28xx_audio_init(struct em28xx *dev)
struct... |
60a5a927595763dbb711a13528e21c2b7a46dbad | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9576): cx88-dvb: MFE attachment clean-up for HVR-3000/4000 | Problem Details:
This cleans-up MFE attachment for these cards plus
two cases of potential memory leak on attachment
failure.
Signed-off-by: Darron Broad <darron@kewl.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index 462947319dda..e5bbc7b37c39 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -606,7 +606,7 @@ static int dvb_register(struct cx8802_dev *dev)
/* Get the first frontend */
... |
7e21fda17e7f6156e2ad66ca4f76abcbe1063eb2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9563): gspca: Let gspca handle the webcam 0471:0328 instead of sn9c102. | Problem Details:
According to http://bugzilla.kernel.org/show_bug.cgi?id=11997,
the driver sn9c102 does not work for this webcam.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c
index 193f0f77964f..a7954a72e4b9 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -1673,8 +1673,8 @@ static const __devinitdata struct usb_device_id device_table[] = {
{USB_DEVICE(0x... |
29fbdf3d94dc0fd97e245cceaf1b77012e77c22d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9560): gspca: Let gspca handle the webcam 0c45:602c instead of sn9c102. | Problem Details:
According to http://bugzilla.kernel.org/show_bug.cgi?id=11920,
the driver sn9c102 does not work for this webcam.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/sonixb.c b/drivers/media/video/gspca/sonixb.c
index f9e5a3da0cb4..ffa714fde85c 100644
--- a/drivers/media/video/gspca/sonixb.c
+++ b/drivers/media/video/gspca/sonixb.c
@@ -1235,8 +1235,8 @@ static __devinitdata struct usb_device_id device_table[] = {
{USB_DEVICE(0x0c45, ... |
95c730beb21235e031fb38145048ab4389e8c442 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9548): gspca: Fix Kconfig CodingStyle | Problem Details:
Signed-off-by: Frederic Cand <frederic.cand@anevia.com>
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/Kconfig b/drivers/media/video/gspca/Kconfig
index cfe0324b1004..6b557c057fac 100644
--- a/drivers/media/video/gspca/Kconfig
+++ b/drivers/media/video/gspca/Kconfig
@@ -3,16 +3,16 @@ menuconfig USB_GSPCA
depends on VIDEO_V4L2
default m
---help---
- Say Y here if you w... |
54b7b0deb4c602d0751627d14510dc50b5bba372 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9540): dsbr100: add disabled controls and fix version | Problem Details:
Patch adds disabled controls in
v4l2_queryctrl struct. Also version of driver corrected.
--
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index e6485cfe1218..eafa547ca96b 100644
--- a/drivers/media/radio/dsbr100.c
+++ b/drivers/media/radio/dsbr100.c
@@ -93,8 +93,8 @@
*/
#include <linux/version.h> /* for KERNEL_VERSION MACRO */
-#define DRIVER_VERSION "v0.41"
-#define ... |
53e745157b79c79f434a10361a77a8364c15db2f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9562): gspca: Set the default frame rate to 30 fps for sensor ov764x in ov519. | Problem Details:
This patch fixes the bad picture at low resolution (320x240).
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/ov519.c b/drivers/media/video/gspca/ov519.c
index 8f9df2db6f1d..27bf7480a2d4 100644
--- a/drivers/media/video/gspca/ov519.c
+++ b/drivers/media/video/gspca/ov519.c
@@ -1499,8 +1499,8 @@ static int ov519_mode_init_regs(struct sd *sd)
switch (sd->sensor) {
case SEN_OV764... |
2e0903b00131e751ac91720162d62415613e9bc5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9552): gspca: Simplify the ISOC packet scanning in tv8532. | Problem Details:
This patch
- makes unuseful the temporary buffers
- and also fixes the bad colors problem.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/gspca/tv8532.c b/drivers/media/video/gspca/tv8532.c
index f6a4733d0262..3eac1cb88520 100644
--- a/drivers/media/video/gspca/tv8532.c
+++ b/drivers/media/video/gspca/tv8532.c
@@ -30,10 +30,6 @@ MODULE_LICENSE("GPL");
struct sd {
struct gspca_dev gspca_dev; /* !! must be the fi... |
886134e4be4e9ef585b0ecde5eebcaf37ee78f80 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9520): stb0899 Remove double .read_status assignment | Problem Details:
Currently in stb0899 code it appears double .read_status assignment
Send patch to fix it.
Cc: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Igor M. Liplianin <liplianin@me.by>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 8a329d6e6e85..528820170228 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -272,9 +272,9 @@ int stb0899_read_reg(struct stb0899_state *state, unsigne... |
f4167342b572c6122c712e8c6e5391808c1e5503 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9514): cx18: Fix PLL freq computation for debug display | Problem Details:
cx18: Fix PLL freq computation for debug display.
The code to compute the PLL freq from register values was storing an
intermediate 56 bit result in a 32 bit type, causing a nonsense value to
be displayed.
Signed-off-by: Andy Walls <awalls@radix.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redha... | ```diff
diff --git a/drivers/media/video/cx18/cx18-av-core.c b/drivers/media/video/cx18/cx18-av-core.c
index 5c079e35e611..518bd701d393 100644
--- a/drivers/media/video/cx18/cx18-av-core.c
+++ b/drivers/media/video/cx18/cx18-av-core.c
@@ -273,10 +273,9 @@ void cx18_av_std_setup(struct cx18 *cx)
pll_int, pll_frac, p... |
ced07371d931884c9c89b66bfe951ea0148a8d08 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9512): cx18: Fix write retries for registers that always change - part 3. | Problem Details:
cx18: Fix write retries for registers that always change - part 3.
Fix the io for the rest of the registers that will often not read back the
value just written. Modified register readback checks to make sure the
intended effect was achieved without constantly rewriting the registers.
The one outstand... | ```diff
diff --git a/drivers/media/video/cx18/cx18-av-audio.c b/drivers/media/video/cx18/cx18-av-audio.c
index 0b55837880a7..486cad0c26e0 100644
--- a/drivers/media/video/cx18/cx18-av-audio.c
+++ b/drivers/media/video/cx18/cx18-av-audio.c
@@ -215,12 +215,15 @@ static int set_audclk_freq(struct cx18 *cx, u32 freq)
void... |
b7496780e800061522de2262b4b4d7bf7602ecfa | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9504): dvbdev: fix typo causing 2.6.28 compile error | Problem Details:
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvbdev.c b/drivers/media/dvb/dvb-core/dvbdev.c
index 92ec7f8826e0..6c571d9f011c 100644
--- a/drivers/media/dvb/dvb-core/dvbdev.c
+++ b/drivers/media/dvb/dvb-core/dvbdev.c
@@ -251,7 +251,7 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev,
... |
cbd82441065820190960aae1b1cfb09bff366ad6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9500): cx88-dvb: MFE attachment fix-up | Problem Details:
MFE attachment fix-up
Signed-off-by: Darron Broad <darron@kewl.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index 309ca5e68063..8378d46dc80d 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -1199,8 +1199,7 @@ static int cx8802_dvb_probe(struct cx8802_driver *drv)
{
struct cx88_core *c... |
7b51a70cbf0c9995caf59f7126d251e14a9e0686 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9472): dm1105: fix the misuse of pci_dma_mapping_error | Problem Details:
pci_dma_mapping_error can't be used for pci_alloc_consistent
(pci_dma_mapping_error is for dma_map_single and dma_map_page).
pci_alloc_consistent returns NULL if the allocation fails.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Igor M. Liplianin <liplianin@me.by>
Signed-of... | ```diff
diff --git a/drivers/media/dvb/dm1105/dm1105.c b/drivers/media/dvb/dm1105/dm1105.c
index 5c16437d989d..f48f73aff195 100644
--- a/drivers/media/dvb/dm1105/dm1105.c
+++ b/drivers/media/dvb/dm1105/dm1105.c
@@ -367,7 +367,7 @@ static int __devinit dm1105dvb_dma_map(struct dm1105dvb *dm1105dvb)
{
dm1105dvb->ts_bu... |
9bb17eee39d862611d2f34d5c611661b3dfd2e54 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9468): Miscellaneous fixes | Problem Details:
- Fix a bitfield
- Set gain appropriately
- Slept for the wrong duration
Signed-off-by: Reinhard Nissl <rnissl@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_reg.h b/drivers/media/dvb/frontends/stb0899_reg.h
index 4e5b2415847f..ba1ed56304a0 100644
--- a/drivers/media/dvb/frontends/stb0899_reg.h
+++ b/drivers/media/dvb/frontends/stb0899_reg.h
@@ -362,7 +362,7 @@
#define STB0899_OFF0_CRL_FREQ 0xf304
#define STB089... |
c615a27a533b6f6de6143d4d58cfa0abfdb6970d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9467): Fix runtime verbosity | Problem Details:
Signed-off-by: Reinhard Nissl <rnissl@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index bdbb60c9e4ed..cf787f5fc00c 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -31,7 +31,7 @@
#include "stb0899_priv.h"
#include "stb0899_reg.h"
-sta... |
aa912921d888c72470d32616dc9d65cdbe477906 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9466): Bug: Fix incorrect Register definitions | Problem Details:
Thanks to Robert Schlabbach <robert_s@gmx.net> for pointing this out
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_reg.h b/drivers/media/dvb/frontends/stb0899_reg.h
index fc2805fbd284..4e5b2415847f 100644
--- a/drivers/media/dvb/frontends/stb0899_reg.h
+++ b/drivers/media/dvb/frontends/stb0899_reg.h
@@ -1351,7 +1351,7 @@
#define STB0899_OFFST_CSM_GAMMA_ACQ 0
#define STB089... |
9acfee56df8ba3078b9c90e23249f3006b585c37 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9465): Fix incorrect IF_AGC Bitfield definition | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_reg.h b/drivers/media/dvb/frontends/stb0899_reg.h
index d2e9217c767a..fc2805fbd284 100644
--- a/drivers/media/dvb/frontends/stb0899_reg.h
+++ b/drivers/media/dvb/frontends/stb0899_reg.h
@@ -356,7 +356,7 @@
/* S2 DEMOD */
#define STB0899_OFF0_DMD_STATUS 0xf300... |
e94a4470b1c32f935f63c64027434932e3f0c90e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9459): We can now reduce the debug levels, just need to look at errors only. | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 333b983b04ab..60a5c9a2f69a 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -31,7 +31,7 @@
#include "stb0899_priv.h"
#include "stb0899_reg.h"
-sta... |
9a286097b027081c073addc2c55775340704c683 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9458): Bugfix: gate control needs to be handled | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 3cf9719204f2..750e88c2c8e6 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -146,7 +146,9 @@ static void stb0899_first_subrange(struct stb0899_sta... |
40e8ce3dba8e9437ed48c88c268615dc0a4bebb2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9457): Optimization, Fix a Bug | Problem Details:
* cut down some I/O operations by disabling "disable gate"
* budget_av was left with the gate open, thereby more susceptible
to RF interference due to I/O operations
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index b7752473f7a7..3cf9719204f2 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -583,6 +583,9 @@ enum stb0899_status stb0899_dvbs_algo(struct stb0899_... |
3d6a3bebda2093cf563266bbfa0f1f1b1ae8fd41 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9454): Fix a compile warning | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 6e7db9912749..196a837f11ce 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -444,7 +444,7 @@ err:
return status < 0 ? status : -EREMOTEIO;
}
-int... |
85eabac439ff6b60775e3d6458702dcb6c479e05 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9453): stb0899: fix compilation warnings | Problem Details:
Cleanup/Optimization:
* Fix compile warnings
* The compile warnings helped to identify 2 unnecessary I/O operations
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index f1432cb29262..65bc032964b1 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -199,9 +199,7 @@ static enum stb0899_status stb0899_check_tmg(struct s... |
d6812086508a38ccb48ed9d5bc9f50732dc818db | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9452): Fix invalid GCT mode | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb6100.c b/drivers/media/dvb/frontends/stb6100.c
index 5c6d06775dd5..c8fdc1e99df1 100644
--- a/drivers/media/dvb/frontends/stb6100.c
+++ b/drivers/media/dvb/frontends/stb6100.c
@@ -360,7 +360,10 @@ static int stb6100_set_frequency(struct dvb_frontend *fe, u32 frequency)... |
18527bee917fb94aaf1760826d918ac7f08d7e61 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9451): Bug! F/3 Clock domain was incorrectly used | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 420dea120ad6..2caa192a8e7e 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -1433,7 +1433,7 @@ void stb0899_set_delsys(struct stb0899_state *state)
... |
561374113e6dbd717ac4a578d99834219de9d3c1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9448): Bug: fix array size | Problem Details:
Bug: a string which contains 4 digits needs an array
of size 5. The fifth character will hold the terminating '\0'
Signed-off-by: Reinhard Nissl <rnissl@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 3468f59ecec9..420dea120ad6 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -1277,8 +1277,8 @@ int stb0899_get_dev_id(struct stb0899_state *state)
u... |
02ec9d8ff4fba95255c277585aa5d0f33ec3adef | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9446): Bug Fix an overflow in bandwidth calculation | Problem Details:
Signed-off-by: Reinhard Nissl <rnissl@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 4dc741de3690..3468f59ecec9 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -1593,7 +1593,7 @@ static enum dvbfe_search stb0899_search(struct dvb_fron... |
89693b7d7bd965c18e9ce1c68eef2b52f9c2b745 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9445): Bug: Bandwidth calculation at upper and lower boundaries | Problem Details:
Signed-off-by: Reinhard Nissl <rnissl@gmx.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb6100.c b/drivers/media/dvb/frontends/stb6100.c
index f4c2b8e114bf..0259a4689507 100644
--- a/drivers/media/dvb/frontends/stb6100.c
+++ b/drivers/media/dvb/frontends/stb6100.c
@@ -267,13 +267,13 @@ static int stb6100_set_bandwidth(struct dvb_frontend *fe, u32 bandwidth... |
763fbaf65a3f7fd571db427a376e727faeb5bfc5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9443): Bug: Bandwidth calculation | Problem Details:
Bug #1: The 5 tap equaliser is set to correct simple perturbations
like reflections on the IF cable for DVB-S. In the case of DVB-S2
a more powerful equalizer is used to correct the filter group delay
allowing the bandwidth to be reduced by a factor of 1/3
Bug #2: The ZIF tuner takes badwidth to be se... | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index d21396450259..45961193272b 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -1554,8 +1554,7 @@ static enum dvbfe_search stb0899_search(struct dvb_fron... |
d0a41e8f8fa3d0fe94ebd1cc115f73e3d7b97172 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9440): Bug in previous commit | Problem Details:
Signed-off-by: Arvo Jarve <arvo@softshark.ee>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 6913bebe7162..2d2b87cf6d00 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -110,7 +110,7 @@ static u32 stb0899_set_srate(struct stb0899_state *st... |
1b792e05e99f0f56eb4da91084ac9b8e8a132a15 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9439): Bug! SFRL nibble got swapped | Problem Details:
The Bug was found by Arvo Jarve <arvo@softshark.ee>
It was a wonder how it worked in the case with this bug,
STM verified this that this nibble was in fact insignificant
and can be ignored.
But still we need to fix all inconsistencies.
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Ma... | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 2256fc70c85a..6913bebe7162 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -110,7 +110,7 @@ static u32 stb0899_set_srate(struct stb0899_state *st... |
eadf29b941df1c0e0e585d7482e096ca608a7bb7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9438): Bug! RTF is signed | Problem Details:
Signed-off-by: Arvo Jarve <arvo@softshark.ee>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 1363ae396f9e..2256fc70c85a 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -194,8 +194,9 @@ static void stb0899_first_subrange(struct stb0899_sta... |
9efdd297bc7c50dea24532a9b52bd0245e7e5169 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9436): Fix a typo in the previous commit | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 0b1d94476638..0b2a908f1a5f 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -588,12 +588,12 @@ static int stb0899_postproc(struct stb0899_state *state... |
ac8fdc47cc86ff11457812893f31b0ff7c447788 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9431): Bug ID #19: Diseqc works properly at 90MHz only on Cut 1.1 and 2.0 | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c
index 55fe5bb9c013..6b5f8854042c 100644
--- a/drivers/media/dvb/ttpci/budget-av.c
+++ b/drivers/media/dvb/ttpci/budget-av.c
@@ -964,7 +964,7 @@ static const struct stb0899_s1_reg knc1_stb0899_s1_init_1[] = {
{ STB0899_GPIO3... |
b655b6cbc9238aa34e90aa6763088f6d4e830347 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9430): stb0899: avoid parameter overwriting | Problem Details:
BUG! Setting CRL parameter overwrote the CR Algorithm type,
eventually leading to wrong search algorithm to be employed in
the DVB-S carrier loop optimization.
Symptom: Once the CR optimization stage is passed either way, in
a successful or failed manner, the very next carrier search will
fail, due to... | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 17f0311ead67..37717a4397a3 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -675,7 +675,6 @@ enum stb0899_status stb0899_dvbs_algo(struct stb0899_... |
7d8f1e57646d7121089ba21e270c1b390de9a17a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9428): Fix: assignment of wrong values | Problem Details:
Signed-off-by: Marko Schluessler <marco@lordzodiac.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index ff3a3f83a6d3..17f0311ead67 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -515,7 +515,7 @@ enum stb0899_status stb0899_dvbs_algo(struct stb0899_... |
0867f571858043c761e3e44bd4f2bcc70f82bb27 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9422): Bug: Fix a typo | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
index 21f5e2c6b4c0..64f15280a73c 100644
--- a/drivers/media/dvb/ttpci/budget-ci.c
+++ b/drivers/media/dvb/ttpci/budget-ci.c
@@ -1780,11 +1780,11 @@ static void frontend_init(struct budget_ci *budget_ci)
* connected to the... |
cf6efeb6705e9828291401f890dcb327a0ea52e7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9419): Bug: unnecessary large current causes large phasor errors | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/tda8261.c b/drivers/media/dvb/frontends/tda8261.c
index 9cbd511d749e..1b9f4dc1b003 100644
--- a/drivers/media/dvb/frontends/tda8261.c
+++ b/drivers/media/dvb/frontends/tda8261.c
@@ -130,6 +130,10 @@ static int tda8261_set_state(struct dvb_frontend *fe,
* (to account ... |
baa40e48d9069c6ec3ac4739f47e2e7560a022d3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9413): Bug: Set Auxilliary Clock Register correctly | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 80791006d168..fe298654b34b 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -1145,7 +1145,7 @@ static int stb0899_set_tone(struct dvb_frontend *fe, fe... |
b11eb46344f9d64c9bd9ecbb1b265f9c67f105eb | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9412): Fix tuner name and comment | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c
index 2ce36765ebd3..ae28b0e7ab8d 100644
--- a/drivers/media/dvb/ttpci/budget-av.c
+++ b/drivers/media/dvb/ttpci/budget-av.c
@@ -1475,9 +1475,12 @@ static struct stb0899_config knc1_dvbs2_config = {
.tuner_set_rfsiggain = NU... |
3479474b368ec3da83240500eca03688fd53ca03 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9411): Bug! Timing recovery was calculated for 99MHz not 90 MHz | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 67f6edfa7e56..80791006d168 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -1502,7 +1502,7 @@ static enum dvbfe_search stb0899_search(struct dvb_fron... |
c14eaedd6c6b2b8ef8900f2dddab382567d556f8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9410): Bug: Missing reference clock definition | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
index e1bbab3dd6ba..169acfae54d2 100644
--- a/drivers/media/dvb/ttpci/budget-ci.c
+++ b/drivers/media/dvb/ttpci/budget-ci.c
@@ -1683,7 +1683,8 @@ static struct stb0899_config tt3200_config = {
};
struct stb6100_config tt3... |
aa4a9e1ae0f499dd87cddf59d32154cba9399cc9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9409): Bug! inverted logic | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
index fdcfbda5e4d8..e1bbab3dd6ba 100644
--- a/drivers/media/dvb/ttpci/budget-ci.c
+++ b/drivers/media/dvb/ttpci/budget-ci.c
@@ -1770,7 +1770,7 @@ static void frontend_init(struct budget_ci *budget_ci)
budget_ci->budget.dvb... |
421b2970d24f7571039b29e6726bce1608578ac4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9406): Really silly bug, setting bandwidth into frequency | Problem Details:
probably should stop fiddling with code late nights. :-(
Thanks to Marco for pointing it out and fixing it.
Signed-off-by: Marko Schluessler <marco@lordzodiac.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
index 3f086855c2fb..fdcfbda5e4d8 100644
--- a/drivers/media/dvb/ttpci/budget-ci.c
+++ b/drivers/media/dvb/ttpci/budget-ci.c
@@ -1633,7 +1633,7 @@ static int stb6100_set_bandwidth(struct dvb_frontend *fe, u32 bandwidth)
stru... |
6ea223c20dfb45311d0ffe0d6ef6b55c9ed4f398 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9403): Fix the CA module not working issue | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
index 3e1128cf6dd0..13ffa7af828c 100644
--- a/drivers/media/dvb/ttpci/budget-ci.c
+++ b/drivers/media/dvb/ttpci/budget-ci.c
@@ -1426,7 +1426,7 @@ static const struct stb0899_s1_reg tt3200_stb0899_s1_init_3[] = {
{ STB0899_T... |
c7d85a2debb07af67c4915c972a352b68cda9022 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9397): fix some bugs at tda8261 | Problem Details:
Fix bug obviously, some enhancements as well
* enable i2c_gate before doing any transaction
* read is one single message with 2 words
* reduce sleep from 100mS to 20mS
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/tda8261.c b/drivers/media/dvb/frontends/tda8261.c
index 1b3d491445af..a6cd2b362b6e 100644
--- a/drivers/media/dvb/frontends/tda8261.c
+++ b/drivers/media/dvb/frontends/tda8261.c
@@ -37,14 +37,15 @@ struct tda8261_state {
static int tda8261_read(struct tda8261_state *s... |
de29eb82595684c937cf0e2578479f4fcb9c9e40 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9396): Fix clocks at stb0899 | Problem Details:
Really silly! Disabled all clocks and expected it to run.
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index 598e3348d534..db620f02eda9 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -251,7 +251,6 @@ int _stb0899_read_reg(struct stb0899_state *state, unsign... |
57ad94a63548b413dc11039f462480994a06c809 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9387): FIX: Write to the correct register | Problem Details:
Thanks to Marko Schluessler <marco@lordzodiac.de> for pointing it out
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 914a82544c71..5b55b0dea7e4 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -277,7 +277,7 @@ static enum stb0899_status stb0899_check_carrier(stru... |
d189f3ef9e91b81573731f6fcb00c62b61450a50 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9386): FIX: Add in missing inversion (should be ideally in the config struct) | Problem Details:
Thanks to Marco Schluessler <marco@lordzodiac.de> for pointing it out
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_drv.c b/drivers/media/dvb/frontends/stb0899_drv.c
index b8beac76f0e4..598e3348d534 100644
--- a/drivers/media/dvb/frontends/stb0899_drv.c
+++ b/drivers/media/dvb/frontends/stb0899_drv.c
@@ -1891,6 +1891,7 @@ struct dvb_frontend *stb0899_attach(struct stb0899_conf... |
381d8047031d8b7c2aca4b0dd624108c807262ec | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9384): FIX: register value is not reset to 0 after write | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 876931527c71..914a82544c71 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -692,24 +692,28 @@ enum stb0899_status stb0899_dvbs_algo(struct stb089... |
b797c206168992e8a2c080e80e39a56410cdaac0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9380): FIX: a possible division by zero | Problem Details:
Thanks to Marko Schluessler <marco@lordzodiac.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/stb0899_algo.c b/drivers/media/dvb/frontends/stb0899_algo.c
index 0ae964975814..876931527c71 100644
--- a/drivers/media/dvb/frontends/stb0899_algo.c
+++ b/drivers/media/dvb/frontends/stb0899_algo.c
@@ -933,9 +933,9 @@ static void stb0899_dvbs2_set_btr_loopbw(struct stb08... |
b3332a983dc07d6bd35d5a97a6e3572b067e7f53 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9379): FIX: fix a bug in the charge pump setting | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/frontends/dvb-pll.c b/drivers/media/dvb/frontends/dvb-pll.c
index ea058153ebfa..9f6349964cda 100644
--- a/drivers/media/dvb/frontends/dvb-pll.c
+++ b/drivers/media/dvb/frontends/dvb-pll.c
@@ -311,7 +311,7 @@ static struct dvb_pll_desc dvb_pll_philips_sd1878_tda8261 = {
.count = ... |
2c5aacc6c7916e0a432991b68f3645540365ad53 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9363): tvp5150: add support to enable raw vbi | Problem Details:
Signed-off-by: Markus Rechberger <mrechberger@sundtek.de>
[mchehab@redhat.com: Fix bad whitespaces]
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c
index 28af5ce5560d..e8f701a412ab 100644
--- a/drivers/media/video/tvp5150.c
+++ b/drivers/media/video/tvp5150.c
@@ -912,6 +912,21 @@ static int tvp5150_command(struct i2c_client *c,
int i;
fmt = arg;
+ /* raw vbi */
+ if (fmt->... |
9962ac5331d79362cc538f2da257c0663fb609e1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9480): Fix frontend DVBFE_ALGO_CUSTOM Search | Problem Details:
Issue: Currently, the DVBFE_ALGO_CUSTOM is called only at the first tuning.
After the first call, the status is never set to force a new tuning.
Signed-off-by: Marco Schluessler <marco@lordzodiac.de>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.co... | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index bd610d7c4b19..00f063abab4d 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -1286,6 +1286,9 @@ int dtv_property_process_set(struct dvb_frontend *fe, s... |
f04c3ca8a2677816af1c0ae7170c2e56ac5d7042 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9478): Fix: parameters not supplied in the search process | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index d18c8f75510e..bd610d7c4b19 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -595,6 +595,7 @@ restart:
dprintk("%s: Frontend ALGO = DVBFE_ALGO_CUS... |
f7c9bf96ad3f65e80762c190be6aad6b2ce997f6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (9477): Fix: Commit 9344 breaks tning of cx24123 | Problem Details:
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index d30e00ff36f1..d18c8f75510e 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -573,6 +573,7 @@ restart:
if (fepriv->state & FESTATE_RETUNE) {
... |
7f92b11c1cc0e865fc64f3148eda87fff74920e1 | Analyze and fix the following issue in the Linux kernel code: ide: move legacy ISA/VLB ports handling to ide-legacy.c (v2) | Problem Details:
* Move legacy ISA/VLB ports handling from ide-probe.c to ide-legacy.c.
* Add CONFIG_IDE_LEGACY config option to be selected by host drivers
needing ide-legacy.c.
v2:
Fix CONFIG_IDE_LEGACY not being defined in Kconfig.
(from Takashi Iwai <tiwai@suse.de>)
There should be no functional changes caused... | ```diff
diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index e6857e01d1ba..7a0a84b042c9 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -62,6 +62,9 @@ config IDE_TIMINGS
config IDE_ATAPI
bool
+config IDE_LEGACY
+ bool
+
config BLK_DEV_IDE_SATA
bool "Support for SATA (deprecated; conflicts ... |
1d35364acbd5ab7d67bb39cfc5dd3ed0fbefb4b8 | Analyze and fix the following issue in the Linux kernel code: ide: use ATA_DMA_* defines in ide-dma-sff.c | Problem Details:
In few places open-coded values were still being used. Fix it.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | ```diff
diff --git a/drivers/ide/ide-dma-sff.c b/drivers/ide/ide-dma-sff.c
index 1f2a5f56f81c..f6d2d44d8a9a 100644
--- a/drivers/ide/ide-dma-sff.c
+++ b/drivers/ide/ide-dma-sff.c
@@ -176,15 +176,10 @@ int ide_dma_setup(ide_drive_t *drive)
{
ide_hwif_t *hwif = drive->hwif;
struct request *rq = hwif->hwgroup->rq;
- ... |
2f996acb6191b6b5f188eca1d1ad76cf1d8ecf76 | Analyze and fix the following issue in the Linux kernel code: ide: checkpatch.pl fixes for ide-lib.c | Problem Details:
Fix following errors/warnings detected by checkpatch.pl:
- WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
- WARNING: space prohibited between function name and open parenthesis '('
- ERROR: trailing whitespace
- ERROR: trailing statements should be on next line
- WARNING:... | ```diff
diff --git a/drivers/ide/ide-lib.c b/drivers/ide/ide-lib.c
index 1932119dfa00..7913ad5d4979 100644
--- a/drivers/ide/ide-lib.c
+++ b/drivers/ide/ide-lib.c
@@ -43,7 +43,6 @@ const char *ide_xfer_verbose(u8 mode)
return s;
}
-
EXPORT_SYMBOL(ide_xfer_verbose);
/**
@@ -87,7 +86,7 @@ static u8 ide_rate_filt... |
702c026be87ef8374ae58122969a4b0b081ce6f2 | Analyze and fix the following issue in the Linux kernel code: ide: rework handling of serialized ports (v2) | Problem Details:
* hpt366: set IDE_HFLAG_SERIALIZE in ->host_flags if needed
in init_hwif_hpt366(). Remove HPT_SERIALIZE_IO while at it.
* Set IDE_HFLAG_SERIALIZE in ->host_flags if needed in
ide_init_port().
* Convert init_irq() to use IDE_HFLAG_SERIALIZE together with
hwif->host to find out ports which need ... | ```diff
diff --git a/drivers/ide/hpt366.c b/drivers/ide/hpt366.c
index f5afd46ed51c..b18e10d99d2e 100644
--- a/drivers/ide/hpt366.c
+++ b/drivers/ide/hpt366.c
@@ -135,7 +135,6 @@
/* various tuning parameters */
#define HPT_RESET_STATE_ENGINE
#undef HPT_DELAY_INTERRUPT
-#define HPT_SERIALIZE_IO 0
static const char... |
46aa7af1d6bf46d0973dc9e8f13275f2c001d3dd | Analyze and fix the following issue in the Linux kernel code: ide: fix ->quirk_list checking in ide_do_request() | Problem Details:
Fix nIEN quirk check to also omit quirky devices using pdc202xx_{new,old}
host drivers for which ->quirk_list == 2.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | ```diff
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index e41488e1ed4e..ca51460af756 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -1008,7 +1008,7 @@ static void ide_do_request (ide_hwgroup_t *hwgroup, int masked_irq)
* set nIEN for previous hwif, drives in the
* quirk_list may ... |
0e63a588fc3d6a5e6bb66bacaeb11cd9093141f8 | Analyze and fix the following issue in the Linux kernel code: ide: fix IDE ACPI regression breaking suspend | Problem Details:
Commit 4dde4492d850a4c9bcaa92e5bd7f4eebe3e2f5ab ("ide: make drive->id
an union (take 2)") accidentally introduced an IDE ACPI regression which
at least on some machines confuses ACPI and breaks suspend. Fix it.
Fixes kernel.org bug #12279:
http://bugzilla.kernel.org/show_bug.cgi?id=12279
[ Sorry abou... | ```diff
diff --git a/drivers/ide/ide-acpi.c b/drivers/ide/ide-acpi.c
index 244a8a052ce8..fd4a36433050 100644
--- a/drivers/ide/ide-acpi.c
+++ b/drivers/ide/ide-acpi.c
@@ -615,10 +615,10 @@ void ide_acpi_push_timing(ide_hwif_t *hwif)
in_params[0].buffer.length = sizeof(struct GTM_buffer);
in_params[0].buffer.pointer... |
f26f6ceacaaf017a677138cbca7ab076b565ca87 | Analyze and fix the following issue in the Linux kernel code: tx493[89]ide: Fix length for __ide_flush_dcache_range | Problem Details:
This fixes data corruption on PIO mode.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: stable <stable@kernel.org>
Cc: sshtylyov@ru.mvista.com
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | ```diff
diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c
index 9120063e8f87..13b63e7fa353 100644
--- a/drivers/ide/tx4938ide.c
+++ b/drivers/ide/tx4938ide.c
@@ -181,7 +181,7 @@ static void tx4938ide_input_data_swap(ide_drive_t *drive, struct request *rq,
while (count--)
*ptr++ = cpu_to_le16(__raw_r... |
a0fce792b55b260589c3d77293a224e84395ec07 | Analyze and fix the following issue in the Linux kernel code: tx4939ide: Do not use zero count PRD entry | Problem Details:
This fixes data corruption on some heavy load.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: stable <stable@kernel.org>
Cc: sshtylyov@ru.mvista.com
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | ```diff
diff --git a/drivers/ide/tx4939ide.c b/drivers/ide/tx4939ide.c
index bafb7d1a22e2..30d0d256230f 100644
--- a/drivers/ide/tx4939ide.c
+++ b/drivers/ide/tx4939ide.c
@@ -259,6 +259,12 @@ static int tx4939ide_build_dmatable(ide_drive_t *drive, struct request *rq)
bcount = 0x10000 - (cur_addr & 0xffff);
if (... |
39eb7e9aca2a582330ddb6f1167272268e6b3965 | Analyze and fix the following issue in the Linux kernel code: [SCSI] zfcp: Add support for unchained FSF requests | Problem Details:
Add the support to send CT and ELS requests as unchained FSF requests. This is
required for older hardware and was somehow omitted during the cleanup of the
FSF layer. The req_count and resp_count attributes are unused, so remove them
instead of adding a special case for setting them. Also add debug da... | ```diff
diff --git a/drivers/s390/scsi/zfcp_dbf.c b/drivers/s390/scsi/zfcp_dbf.c
index bf691fbc4d29..150bd5390b1d 100644
--- a/drivers/s390/scsi/zfcp_dbf.c
+++ b/drivers/s390/scsi/zfcp_dbf.c
@@ -936,6 +936,7 @@ void zfcp_san_dbf_event_ct_response(struct zfcp_fsf_req *fsf_req)
rct->reason_code = hdr->reason_code;
rc... |
06499fac65a273f1de0154679ab04f29dead2bba | Analyze and fix the following issue in the Linux kernel code: [SCSI] zfcp: fix compile warning | Problem Details:
Get rid of this one:
drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_thread':
drivers/s390/scsi/zfcp_erp.c:1400: warning: ignoring return value of
'down_interruptible', declared with attribute warn_unused_result
zfcp_erp_thread is a kernel thread which can't receive any signals.
So introduce a du... | ```diff
diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c
index 4ed4950d994b..495a4a33e37d 100644
--- a/drivers/s390/scsi/zfcp_erp.c
+++ b/drivers/s390/scsi/zfcp_erp.c
@@ -1385,6 +1385,7 @@ static int zfcp_erp_thread(void *data)
struct list_head *next;
struct zfcp_erp_action *act;
unsigned ... |
dedbc2b3cb8404c618975bd2811c7605a4ccb51e | Analyze and fix the following issue in the Linux kernel code: [SCSI] zfcp: Simplify SBAL allocation to fix sparse warnings | Problem Details:
When waiting for a request claim the SBAL before waiting. This way,
locking before each check of the free counter is not required and
sparse does not emit warnings for the complicated locking scheme.
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Acked-by: Felix Beck <felix@linux.vnet.i... | ```diff
diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c
index 3376305609f9..878b8f86ddc7 100644
--- a/drivers/s390/scsi/zfcp_fsf.c
+++ b/drivers/s390/scsi/zfcp_fsf.c
@@ -644,38 +644,38 @@ static void zfcp_fsf_exchange_port_data_handler(struct zfcp_fsf_req *req)
}
}
-static int zfcp_fsf_sba... |
27c3f0a6e4521ba0ff6e76da54969f0bf430f53a | Analyze and fix the following issue in the Linux kernel code: [SCSI] zfcp: Fix message line break | Problem Details:
Move the closing parenthesis before the line break.
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Acked-by: Felix Beck <felix@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c
index 9c72e083559d..3376305609f9 100644
--- a/drivers/s390/scsi/zfcp_fsf.c
+++ b/drivers/s390/scsi/zfcp_fsf.c
@@ -1907,7 +1907,7 @@ static void zfcp_fsf_open_unit_handler(struct zfcp_fsf_req *req)
dev_err(&adapter->ccw_device->dev,
... |
20c09df7eb9c92a40e0ecf654b6e8f14c8583b9e | Analyze and fix the following issue in the Linux kernel code: [SCSI] eata: fix the data buffer accessors conversion regression | Problem Details:
This fixes the regression introduced by the commit
58e2a02eb18393e76a469580fedf7caec190eb5e (eata: convert to use the
data buffer accessors), reported:
http://marc.info/?t=122987621300006&r=1&w=2
- fix DMA_NONE handling in map_dma()
- this driver can't use scsi_dma_map since host->shost_gendev.paren... | ```diff
diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c
index a73a6bbb1b2b..976cdd5c94ef 100644
--- a/drivers/scsi/eata.c
+++ b/drivers/scsi/eata.c
@@ -1626,8 +1626,15 @@ static void map_dma(unsigned int i, struct hostdata *ha)
cpp->sense_len = SCSI_SENSE_BUFFERSIZE;
- count = scsi_dma_map(SCpnt);
- BUG_ON... |
302378534c8d4403f9a9b2a20f875b6866a27e42 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ipr: fix lockdep warning from ipr_ioa_reset_done | Problem Details:
To fix the following lockdep warning we turn the spin_unlock_irq() into
a spin_unlock() and similarly for the corresponding spin_lock_irq(). We
can do this because there is no need to enable interrupts in this path
(thanks to Bring King for the tip).
Badness at kernel/lockdep.c:2193
NIP: c000000000085... | ```diff
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index ec53c220cb37..0edfb1fa63ce 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -5389,9 +5389,9 @@ static int ipr_ioa_reset_done(struct ipr_cmnd *ipr_cmd)
list_add_tail(&ipr_cmd->queue, &ioa_cfg->free_q);
wake_up_all(&ioa_cfg->reset_wait_q);
... |
21465eda9eafa275ed11c27779d90aa95559b6f6 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvscsi: Don't fail EH due to insufficient resources | Problem Details:
The ibmvscsi driver currently has a bug in it which can result
in it using up all its event structs for commands. If something
results in all those commands timing out, we won't have any resources
left to send aborts or resets. This results in escalating to a host reset
in order to recover, which is a ... | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 6cad1758243a..868d35ea01bb 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -107,7 +107,7 @@ module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(max_c... |
4d3fef9e69ac002f7531c377970449d1154fe884 | Analyze and fix the following issue in the Linux kernel code: [SCSI] scsi_transport_spi: fix the misuse of scsi_execute return value | Problem Details:
[jejb: fix rejections]
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
index 96361aa70906..f49f55c6bfc8 100644
--- a/drivers/scsi/scsi_transport_spi.c
+++ b/drivers/scsi/scsi_transport_spi.c
@@ -113,7 +113,7 @@ static int spi_execute(struct scsi_device *sdev, const void *cmd,
REQ_FAILFAST... |
9f1e1b50ab43a281dbc75c25f11e1926a9ea367a | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.3.0 : Fix some memory handling issues | Problem Details:
- Fix mailbox buffer leak on dump mailbox completion
- Fix mbuf leak in lpfc_pci_probe_one() SLI-2 mode error path
- Don't allocate HBQs in interrupt context
- Use correct size for FCP response buffer so that all available sense
data is copied
- Fix jiffies calculation to prevent crash when colle... | ```diff
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index e07f12a0871b..7a216d478a94 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -255,8 +255,10 @@ lpfc_dump_wakeup_param_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmboxq)
/* character array used for d... |
eaf15d5b5605e1a403f631489de30a49fd66905d | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.3.0 : Fix several minor issues | Problem Details:
- Avoid polling HBA Error Attention when HBA's PCI channel is offline
due to PCI EEH
- Fix handling of RSCN with non-zero event qualifiers
- Remove unnecessary sleeps during HBA initialization which slow down
driver load
- Fix internal and external loopback on FCoE HBAs
- Fix incorrect decremen... | ```diff
diff --git a/drivers/scsi/lpfc/lpfc_crtn.h b/drivers/scsi/lpfc/lpfc_crtn.h
index a6594857712e..73481c8fd98f 100644
--- a/drivers/scsi/lpfc/lpfc_crtn.h
+++ b/drivers/scsi/lpfc/lpfc_crtn.h
@@ -290,7 +290,7 @@ void lpfc_fabric_abort_nport(struct lpfc_nodelist *);
void lpfc_fabric_abort_hba(struct lpfc_hba *);
vo... |
8f34f4cea3234ae347c4b0ffa302ffb85f140838 | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.3.0 : Fix issue with assumed Interrupt Enable Block support | Problem Details:
The phba hbq_get address was setup before the HBA reported support for
Interrupt Enable Block (INB). This caused loopback tests to fail
after all HBQs had been used once. Moved setting of hba_get until
after config port mailbox command completes.
Signed-off-by: James Smart <James.Smart@emulex.com>
S... | ```diff
diff --git a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers/scsi/lpfc/lpfc_mbox.c
index dcdb7c939520..5bb376baba62 100644
--- a/drivers/scsi/lpfc/lpfc_mbox.c
+++ b/drivers/scsi/lpfc/lpfc_mbox.c
@@ -1198,16 +1198,11 @@ lpfc_config_port(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
sizeof(*phba->host_gp));
}
- ... |
97207482fcdd120a60a44e9eb6bbad8da6f81c9d | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.3.0 : Added 3 small features and improve PCI EEH support | Problem Details:
- Added FC_REG_VPORTRSCN_EVENT to lpfc_nl.h
- Added code to provide option ROM version from HBA and via sysfs
- Added support for HPS bit in config port mailbox command to tell HBA
that host group pointers are in host memory.
- Bugfix for Extended Error Handling (EEH) support on IBM PowerPC P6
p... | ```diff
diff --git a/drivers/scsi/lpfc/lpfc_crtn.h b/drivers/scsi/lpfc/lpfc_crtn.h
index 044ef4057d28..a6594857712e 100644
--- a/drivers/scsi/lpfc/lpfc_crtn.h
+++ b/drivers/scsi/lpfc/lpfc_crtn.h
@@ -22,6 +22,7 @@ typedef int (*node_filter)(struct lpfc_nodelist *, void *);
struct fc_rport;
void lpfc_dump_mem(struct ... |
eada272dfc32ba3dcd33e7ca5875337defb13c54 | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.3.0 : Fix multiple NPIV issues | Problem Details:
- Fix lock up on rmmod with vports defined by having
lpfc_pci_remove_one() invoke fc_vport_terminate() to remove all the
vports before invoking fc_remove_host() for the physical port
- Fix echotest failure when NPIV is enabled
- Add the vport_disable function to the physical port's transport
te... | ```diff
diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h
index 60a9e6e9384b..030f9eb46f2a 100644
--- a/drivers/scsi/lpfc/lpfc.h
+++ b/drivers/scsi/lpfc/lpfc.h
@@ -354,8 +354,6 @@ struct lpfc_vport {
uint8_t load_flag;
#define FC_LOADING 0x1 /* HBA in process of loading drvr */
#define FC_UNLOADING ... |
109f6ed05aadb7dd1cc9671a63603658d3ba518e | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.3.0 : Fix system crash due to uninitialized node access | Problem Details:
In the IOCB completion handler, always check if the node is valid
before accessing the node object. Added lpfc_initialize_node() to
initialize nodes.
Signed-off-by: James Smart <James.Smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index 58ed6859c921..ba120530cf80 100644
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -1857,6 +1857,32 @@ lpfc_disable_node(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
lpfc_nlp_state_c... |
a528ab7a324f1dbb3598ae0ecd238ab7dd974294 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvfc: Fix errors due to inconsistent command data | Problem Details:
In order to ensure the VIOS sees a consistent command buffer, we
need to add a memory barrier after building the command buffer
but before sending the command.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 2aa3d695d548..a401e938a87a 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -1381,6 +1381,8 @@ static int ibmvfc_send_event(struct ibmvfc_event *evt,
add_timer(&evt->timer);
}
+ mb();
+
... |
1c41fa8288277e76785acb50f52bb2f39509f903 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvfc: Delay NPIV login retry and add retries | Problem Details:
Adds a delay prior to retrying a failed NPIV login. This fixes
a scenario if the backing fibre channel adapter is getting reset
due to an EEH event, NPIV login will fail. Currently, ibmvfc
retries three times very quickly, resets the CRQ and tries one
more time. If the adapter is getting reset due to E... | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 8715a7b140cc..2aa3d695d548 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -561,7 +561,7 @@ static void ibmvfc_init_host(struct ibmvfc_host *vhost, int relogin)
struct ibmvfc_target *tgt;
... |
30b4915015c112547e930cadf734d875aec8438d | Analyze and fix the following issue in the Linux kernel code: [SCSI] iscsi_tcp: add iscsi_tcp prefix to iscsi_tcp functions | Problem Details:
Add iscsi_tcp prefix to most functions. Some are not changed
becuase they are going to move in the next patch.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index e6ae4e648343..97f3f68aeb64 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -516,12 +516,11 @@ static void iscsi_tcp_cleanup_task(struct iscsi_task *task)
}
/**
- * iscsi_data_in - SCSI Data-In Response processing
... |
63c62f1cb980241513c82cacd5b9f878527c6647 | Analyze and fix the following issue in the Linux kernel code: [SCSI] iscsi_tcp: prepare helpers for LLDs that can offload some operations | Problem Details:
cxgb3i is unlike qla4xxx and bnx2i in that it does not offload entire
scsi commands or iscsi sequences. Instead it only offloads the transfer
of a ISCSI DATA_IN pdu's data, the digests and padding. This patch fixes up the
iscsi tcp recv path so that it exports its skb recv processing so
cxgb3i and othe... | ```diff
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index e11bce6ab63c..464de780d953 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -486,7 +486,8 @@ iscsi_tcp_data_recv_prep(struct iscsi_tcp_conn *tcp_conn)
struct iscsi_conn *conn = tcp_conn->iscsi_conn;
struct hash_des... |
a02488ed73488f316aa00eb973407f4229c6c2bf | Analyze and fix the following issue in the Linux kernel code: [SCSI] st: update to use block timeout | Problem Details:
Since we're trying to eliminate struct scsi_device timeout, the tape
driver has to be updated to use the block queue timeout instead. The
tape use of scsi_device timeout looks to be self consistent, so I don't
think this necessarily fixes any bug, but it has to be done to allow me
to remove the timeou... | ```diff
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index c959bdc55f4f..d60be83ba78b 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -613,7 +613,8 @@ static int cross_eof(struct scsi_tape * STp, int forward)
tape_name(STp), forward ? "forward" : "backward"));
SRpnt = st_do_scsi(NULL, STp, cmd... |
da244654c66e78e03668863974ec74c981934c38 | Analyze and fix the following issue in the Linux kernel code: [SCSI] mac_esp: fix for quadras with two esp chips | Problem Details:
On the Quadra 900 and 950 there are two ESP chips sharing one IRQ. Because
the shared IRQ is edge-triggered, we must make sure that an IRQ transition
from one chip doesn't go unnoticed when the shared IRQ is already active
due to the other. This patch prevents interrupts getting lost so that both
SCSI ... | ```diff
diff --git a/drivers/scsi/mac_esp.c b/drivers/scsi/mac_esp.c
index a99f9ce6be55..c24e86f07804 100644
--- a/drivers/scsi/mac_esp.c
+++ b/drivers/scsi/mac_esp.c
@@ -53,7 +53,8 @@ struct mac_esp_priv {
void __iomem *pdma_io;
int error;
};
-static struct platform_device *internal_esp, *external_esp;
+static st... |
09e13e91670b69736b5da0a869a076a55a326394 | Analyze and fix the following issue in the Linux kernel code: [SCSI] m68k: mac_esp asm fix | Problem Details:
Fix asm constraints and arguments so as not to transfer an odd byte when
there may be more words to transfer. The bug would probably also cause
exceptions sometimes by transferring one too many bytes.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Geert Uytterhoeven <geert@linux... | ```diff
diff --git a/drivers/scsi/mac_esp.c b/drivers/scsi/mac_esp.c
index 887682a24e36..a99f9ce6be55 100644
--- a/drivers/scsi/mac_esp.c
+++ b/drivers/scsi/mac_esp.c
@@ -170,7 +170,7 @@ static inline int mac_esp_wait_for_dreq(struct esp *esp)
#define MAC_ESP_PDMA_LOOP(operands) \
asm volatile ( \
- " t... |
b60af5b0adf0da24c673598c8d3fb4d4189a15ce | Analyze and fix the following issue in the Linux kernel code: [SCSI] simplify scsi_io_completion() | Problem Details:
This patch (as1142b) consolidates a lot of repetitious code in
scsi_io_completion(). It also fixes a few comments. Most
importantly, however, it clearly distinguishes among the three sorts
of retries that can be done when a command fails to complete:
Unprepare the request and resubmit it, so that a... | ```diff
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 148d3af92aef..ecfbbd30dce5 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -875,16 +875,24 @@ static void scsi_end_bidi_request(struct scsi_cmnd *cmd)
* (the normal case for most drivers), we don't need
*... |
5919ce29085f4ca080054fde5feef8f8b3405261 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvfc: Fix command timeouts due to cached CRQ access | Problem Details:
The CRQs used by the ibmvfc driver are read and written by both
the client and the server. Therefore, we need to mark them volatile
so that we do not cache their contents when handling an interrupt.
This fixes a problem which can surface as occasional command timeouts.
No commands were actually timing ... | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/drivers/scsi/ibmvscsi/ibmvfc.h
index f0c0212a7460..526bca743c81 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.h
+++ b/drivers/scsi/ibmvscsi/ibmvfc.h
@@ -523,10 +523,10 @@ enum ibmvfc_async_event {
};
struct ibmvfc_crq {
- u8 valid;
- u8 format;
+ volatile u8 valid;
... |
4081b77c3a86151d2eaeed9d568a34dd0982ed52 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvfc: Fix oops in interrupt handler | Problem Details:
Fixes an oops that can occur in the interrupt handler
if we get a lot of async events.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 9fead7f19e22..eb79f755dad0 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -2721,7 +2721,7 @@ static irqreturn_t ibmvfc_interrupt(int irq, void *dev_instance)
} else if ((async = ibmvfc_next... |
c51da4ecb03a4513996e64dd9500a9d5ca812523 | Analyze and fix the following issue in the Linux kernel code: [SCSI] qla2xxx: Fix for build warning | Problem Details:
drivers/scsi/qla2xxx/qla_os.c: In function 'qla2x00_probe_one':
drivers/scsi/qla2xxx/qla_os.c:1582: warning: 'mem_only' is used uninitialized in this function
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Signed-off-by: James B... | ```diff
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 05db1660855e..9830fcb6130a 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1563,7 +1563,7 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
char pci_info[30];
char fw_... |
4a8ab87baf8d424de99234fdfae35db6a414ffd2 | Analyze and fix the following issue in the Linux kernel code: [SCSI] scsi_error: fix indentation and braces disagreement - add braces | Problem Details:
...and the list of recent breakage goes on and on, this time
it's 242f9dcb8ba6f (block: unify request timeout handling)
which broke it.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnershi... | ```diff
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index edfaf241c5ba..f5767dc48d61 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -136,7 +136,7 @@ enum blk_eh_timer_return scsi_times_out(struct request *req)
else
eh_timed_out = NULL;
- if (eh_timed_out)
+ if (e... |
66aa5745f6fe328f0166f91b523df864b17fb8f1 | Analyze and fix the following issue in the Linux kernel code: [SCSI] tmscsim: fix indentation and braces disagreement - add braces | Problem Details:
Lucky winner is 557cc476c04 ([SCSI] tmscsim: Fixup
KERN_INFO in printk).
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index 69ac6e590f1d..9a4273445c0d 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2572,9 +2572,10 @@ static struct pci_driver dc390_driver = {
static int __init dc390_module_init(void)
{
- if (!disable_clustering)
+ if (!disabl... |
8d6dda7f0ce53c55ec14eb5eaa360d549641586b | Analyze and fix the following issue in the Linux kernel code: [SCSI] u14-34f: fix scsi_dma_map failure case | Problem Details:
When unsigned, scsi_dma_map may return -ENOMEM without triggering BUG_ON()
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 329eb8780e74..601e95141cbe 100644
--- a/drivers/scsi/u14-34f.c
+++ b/drivers/scsi/u14-34f.c
@@ -1111,7 +1111,8 @@ static int u14_34f_detect(struct scsi_host_template *tpnt) {
static void map_dma(unsigned int i, unsigned int j) {
unsigned ... |
10e794996ed00a0f09ff0745f87e3a3dd5de4606 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvfc: Fix target initialization failure retry handling | Problem Details:
If the ibmvfc driver is in discovery attempting to log into a target
and it encounters an error, the command may get retried one or more
times, depending on the error received. If the retries are
unsuccessful such that the discovery thread gives up on discovery to
that target, the target ends up in a s... | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index af69c0738edb..844684581e45 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -496,6 +496,7 @@ static void ibmvfc_set_host_action(struct ibmvfc_host *vhost,
case IBMVFC_HOST_ACTION_INIT:
case ... |
ad8dcffaf9bc1d7eb86dabf591e95f4ffb86cf1b | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvfc: Error handling fixes | Problem Details:
Due to an ambiguity in the VIOS VFC interface specification,
abort/cancel handling is not done correctly and can result in double
completion of commands. In order to cancel all outstanding commands to
a device, a cancel must be sent, followed by an abort task set. After
the responses are received for t... | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index ae65fa60eeb4..af69c0738edb 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -758,6 +758,9 @@ static void ibmvfc_scsi_eh_done(struct ibmvfc_event *evt)
cmnd->scsi_done(cmnd);
}
+ if (evt->... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.