Datasets:
switlydev
/
linux-kernel-bugfixes-diffs

Dataset card Data Studio Files
xet
 Community
1
id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
d69b2e41a5f6d934d01cc62f314697a60356b466
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7462): bttv: Fix some API non-compliances for some audio/input V4L2 calls
Problem Details: Thanks to Cyrill Gorcunov <gorcunov@gmail.com> for pointing this Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c index af2c0c994186..79da9d01d715 100644 --- a/drivers/media/video/bt8xx/bttv-driver.c +++ b/drivers/media/video/bt8xx/bttv-driver.c @@ -3117,12 +3117,18 @@ static int bttv_s_crop(struct file *file, void *f, struct v4l...
b12203d253732d282dd97909a1424016694183e9
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7449): cx88: fix oops on module removal caused by IR worker
Problem Details: If the IR worker is not stopped before the removal of the cx88xx module, an OOPS may occur, because the worker function cx88_ir_work gets called. So stop the ir worker. Signed-off-by: Marton Balint <cus@fazekas.hu> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c index 327c0a87c081..1eea044969a1 100644 --- a/drivers/media/video/cx88/cx88-video.c +++ b/drivers/media/video/cx88/cx88-video.c @@ -1920,6 +1920,9 @@ static void __devexit cx8800_finidev(struct pci_dev *pci_dev) core->...
a2401d9eed955d90e682b911c343d7fb4ad22436
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7447): pvrusb2: Fix compilation warning
Problem Details: Fix use of a non-int (size_t) being passed in a printf width field. This benign issue has apparently been around for a long time, but went undetected until now. Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-sysfs.c b/drivers/media/video/pvrusb2/pvrusb2-sysfs.c index 17616f79f34e..78ecfcbdd0b9 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-sysfs.c +++ b/drivers/media/video/pvrusb2/pvrusb2-sysfs.c @@ -288,7 +288,7 @@ static ssize_t store_val_norm(int id,struct devic...
2c4963d4fb6103c0589db411fccf5e4f8531f173
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7441): kconfig fixes for tuner-simple
Problem Details: Update Kconfig for the hybrid devices recently converted to use tuner-simple rather than dvb-pll. dvb-bt8xx no longer uses dvb-pll at all, so remove all references to dvb-pll within that driver. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradea...
```diff diff --git a/drivers/media/dvb/b2c2/Kconfig b/drivers/media/dvb/b2c2/Kconfig index 3197aeb61d1f..ffcbc7610856 100644 --- a/drivers/media/dvb/b2c2/Kconfig +++ b/drivers/media/dvb/b2c2/Kconfig @@ -9,6 +9,7 @@ config DVB_B2C2_FLEXCOP select DVB_STV0297 if !DVB_FE_CUSTOMISE select DVB_BCM3510 if !DVB_FE_CUSTOMI...
a03402d8ad1638a0a88c5091a189be146c1ee261
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7440): dvb-bt8xx: fix build error
Problem Details: Fix the following build error: In file included from dvb-bt8xx.c:35: dvb-bt8xx.h:42:26: error: tuner-simple.h: No such file or directory dvb-bt8xx.c: In function 'frontend_init': dvb-bt8xx.c:612: error: 'simple_tuner_attach' undeclared (first use in this function) dvb-bt8xx.c:612: error: (Each undecla...
```diff diff --git a/drivers/media/dvb/bt8xx/Makefile b/drivers/media/dvb/bt8xx/Makefile index 84cf70504d17..9d3e68b5d6eb 100644 --- a/drivers/media/dvb/bt8xx/Makefile +++ b/drivers/media/dvb/bt8xx/Makefile @@ -1,3 +1,6 @@ obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o dst.o dst_ca.o -EXTRA_CFLAGS += -Idrivers/media...
e7809a07663f868f596b5f08a63db9a32240502c
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7433): tda18271: fix comparison bug in tda18271_powerscan
Problem Details: Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/frontends/tda18271-fe.c b/drivers/media/dvb/frontends/tda18271-fe.c index 3c455795d1ac..4a025849a327 100644 --- a/drivers/media/dvb/frontends/tda18271-fe.c +++ b/drivers/media/dvb/frontends/tda18271-fe.c @@ -422,7 +422,7 @@ static int tda18271_powerscan(struct dvb_frontend *fe, ...
ae07d042f626caa13d5a8a15ac7297b2873f7622
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7430): tda18271: fix typo in tda18271_calibrate_rf
Problem Details: The internal calibration signal must be set on the cal pll. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/frontends/tda18271-fe.c b/drivers/media/dvb/frontends/tda18271-fe.c index eb44ab71ff74..2bbf277f5cfc 100644 --- a/drivers/media/dvb/frontends/tda18271-fe.c +++ b/drivers/media/dvb/frontends/tda18271-fe.c @@ -305,8 +305,8 @@ static int tda18271_calibrate_rf(struct dvb_frontend *fe,...
03dea86de2243d5b3932604b799be26efeff010d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7401): radio-si470x: unplugging fixed
Problem Details: This patch fixes several kernel oops, when unplugging device while it is in use: Basically the patch delays freeing of the internal variables in si470x_usb_driver_disconnect, until the the last user closed the device in si470x_fops_release. This was implemented a while ago with the help of Oliver Neuk...
```diff diff --git a/drivers/media/radio/radio-si470x.c b/drivers/media/radio/radio-si470x.c index 649f14d2c013..4ad88ee616fd 100644 --- a/drivers/media/radio/radio-si470x.c +++ b/drivers/media/radio/radio-si470x.c @@ -85,6 +85,7 @@ * Oliver Neukum <oliver@neukum.org> * Version 1.0.7 * - usb autosuspend suppor...
a4df8e1d6ae460546dfa3b4f23a85cb5a4255109
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7394): saa7134: add number of devices check
Problem Details: This patch fixes reported problems when trying to add a 9th device into a system. Signed-off-by: Alan McIvor <alan.mcivor@reveal.co.nz> Signed-off-by: Hartmut Hackmann <hartmut.hackmann@t-online.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c index 599273894f34..eec127864fe3 100644 --- a/drivers/media/video/saa7134/saa7134-core.c +++ b/drivers/media/video/saa7134/saa7134-core.c @@ -866,6 +866,9 @@ static int __devinit saa7134_initdev(struct pci_dev *...
c1e6393e24e0fcc8047db18dce05758c3fd54515
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7389): git-dvb: drivers/media/video/bt8xx/bttv-cards.c: fix warnings
Problem Details: drivers/media/video/bt8xx/bttv-cards.c:3030:38: warning: "/*" within comment drivers/media/video/bt8xx/bttv-cards.c:3032:20: warning: "/*" within comment Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/bt8xx/bttv-cards.c b/drivers/media/video/bt8xx/bttv-cards.c index 4a82cd2dd66a..f20a01cfc73e 100644 --- a/drivers/media/video/bt8xx/bttv-cards.c +++ b/drivers/media/video/bt8xx/bttv-cards.c @@ -3027,9 +3027,7 @@ struct tvcard bttv_tvcards[] = { .gpiomask = 0x008007, ...
6e741713913fd28f8291fddb3d32d9353f1f0472
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7388): saa7134: fix radio entry for xc2028/3028 boards
Problem Details: If left in blank, the driver will use value 0 (Temic PAL) Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c index 4b8bbb4a2f76..e30f34e019b0 100644 --- a/drivers/media/video/saa7134/saa7134-cards.c +++ b/drivers/media/video/saa7134/saa7134-cards.c @@ -4071,6 +4071,7 @@ struct saa7134_board saa7134_boards[] = { .n...
d9ae6dd76325d26a68068f7d8c78e0c7ec7e8f3e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7387): saa7134: Fix xc3028 entries
Problem Details: Tuner addresses were incorrect. Fix the entries. Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c index 55b056bc4e69..4b8bbb4a2f76 100644 --- a/drivers/media/video/saa7134/saa7134-cards.c +++ b/drivers/media/video/saa7134/saa7134-cards.c @@ -4068,9 +4068,11 @@ struct saa7134_board saa7134_boards[] = { }...
b2cb200f0d0d5e801b47635554519f6e1b64e847
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7377): radio-sf16fmr2.c: fix volume handling
Problem Details: As reported by Roel Kluin <12o3l@tiscali.nl>: in drivers/media/radio/radio-sf16fmr2.c:319: for (i = 0; i < ARRAY_SIZE(radio_qctrl); i++) { if ((fmr2->card_type != 11) && V4L2_CID_AUDIO_VOLUME) radio_qctrl[i].step = 65535; ... I don't understand this '&& V4L2_CID_AU...
```diff diff --git a/drivers/media/radio/radio-sf16fmr2.c b/drivers/media/radio/radio-sf16fmr2.c index ebc5fbbc38bb..7bf7d534c042 100644 --- a/drivers/media/radio/radio-sf16fmr2.c +++ b/drivers/media/radio/radio-sf16fmr2.c @@ -29,6 +29,8 @@ static struct mutex lock; #include <linux/version.h> /* for KERNEL_VERSIO...
50407f99a1fd7fcca74e53b1852dc70deb5114db
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7375): cx88/saa7134: fix magic number for xc3028 reusage detection
Problem Details: tuner-xc2028 needs to know when a DVB module is sharing the same analog tuner. This is done by comparing a magic number that needs to be the same on analog and on digital. To make easier, this magic number is a pointer to some data struct. With the previous code, two different pointers were using, cau...
```diff diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c index d72b817bf886..37ebfcc6be55 100644 --- a/drivers/media/video/cx88/cx88-dvb.c +++ b/drivers/media/video/cx88/cx88-dvb.c @@ -458,7 +458,7 @@ static int attach_xc3028(u8 addr, struct cx8802_dev *dev) struct xc2028_config ...
a920e42f61bdfe9974f3e2f3715d3a6d319eeaba
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7374): Fix left-overs from the videobuf-dma-sg.c conversion to generic DMA
Problem Details: The dev element of the struct videobuf_queue is now of type struct device implicitly. Fix left-over casts. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de> Reviewed-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx23885/cx23885-core.c b/drivers/media/video/cx23885/cx23885-core.c index 7f10b273598f..a77505daaed2 100644 --- a/drivers/media/video/cx23885/cx23885-core.c +++ b/drivers/media/video/cx23885/cx23885-core.c @@ -952,7 +952,7 @@ void cx23885_free_buffer(struct videobuf_queue *q, st...
ceb63a4fda646faea60e34fa4c3abf8455add013
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7371): cx88: Fix audio on Prolink Pixelview Mpeg 8000GT
Problem Details: This board works only with non-mts firmware Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c index 98d3475a4b32..603b3664381a 100644 --- a/drivers/media/video/cx88/cx88-cards.c +++ b/drivers/media/video/cx88/cx88-cards.c @@ -2495,6 +2495,11 @@ static void cx88_card_setup(struct cx88_core *core) case CX88_BOARD...
8b3b90aca293418171297ae14efac5817ba02bd3
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7363): fix coding style violations in v4l1-compat.c
Problem Details: fix most coding style violations found by checkpatch Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/v4l1-compat.c b/drivers/media/video/v4l1-compat.c index ffd3f106dd4f..6455b2f43bed 100644 --- a/drivers/media/video/v4l1-compat.c +++ b/drivers/media/video/v4l1-compat.c @@ -41,13 +41,16 @@ static unsigned int debug; module_param(debug, int, 0644); -MODULE_PARM_DESC(debug,"e...
a2a7f84b7908c6dba998b43a1ed343aff1d2fd98
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7360): tuner-simple: fix return value of simple_dvb_configure
Problem Details: simple_dvb_configure returns the actual tuned frequency to its caller, so it must be declared as a u32 rather than an int. As a result, we will return 0 to indicate a failure. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c index 5356c8a92413..b95ed1f489a0 100644 --- a/drivers/media/video/tuner-simple.c +++ b/drivers/media/video/tuner-simple.c @@ -788,9 +788,10 @@ static void simple_set_dvb(struct dvb_frontend *fe, u8 *buf, } } -static int si...
2fd3c14cf53c379602d1a8a1a0aed7737a48c5c6
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7343): msp3400: fix SECAM D/K handling
Problem Details: The 6.5 MHz carrier was interpreted as SECAM-L even if SECAM-D/K was selected. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/msp3400-kthreads.c b/drivers/media/video/msp3400-kthreads.c index 61ec794a737e..7f5568592793 100644 --- a/drivers/media/video/msp3400-kthreads.c +++ b/drivers/media/video/msp3400-kthreads.c @@ -833,11 +833,6 @@ static int msp34xxg_modus(struct i2c_client *client) v4l_dbg(1, m...
e0028027c6e4a8aa8b3b77001b982a97ac35bbd7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7342): saa7115: fix PAL-Nc handling
Problem Details: Fsc 3.58 refers to Combination PAL-N (aka PAL-Nc), not to plain PAL-N (that uses Fsc 4.43). Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c index aaec17f9d4eb..416d05d4a969 100644 --- a/drivers/media/video/saa7115.c +++ b/drivers/media/video/saa7115.c @@ -957,7 +957,7 @@ static void saa711x_set_v4lstd(struct i2c_client *client, v4l2_std_id std) if (std == V4L2_STD_PAL_M...
cd9fa026606848b2238a56e37b2c4aa4f371e152
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7340): ivtv: fix tunerhz bug: PAL-N(c) is 50 Hz, not 60
Problem Details: Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/ivtv/ivtv-driver.c b/drivers/media/video/ivtv/ivtv-driver.c index baa3aeed8a23..3e4f55a9edfa 100644 --- a/drivers/media/video/ivtv/ivtv-driver.c +++ b/drivers/media/video/ivtv/ivtv-driver.c @@ -509,7 +509,7 @@ static v4l2_std_id ivtv_parse_std(struct ivtv *itv) return V4L2_S...
0358d7c580370c5eaf081ac42a41c6e347709051
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7337): ivtv: fix polling bug
Problem Details: The q_io queue was never taken into account by the poll function. Thanks to Andy Walls for finding this bug. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/drivers/media/video/ivtv/ivtv-fileops.c index 6fb96f19a866..d949a81339d5 100644 --- a/drivers/media/video/ivtv/ivtv-fileops.c +++ b/drivers/media/video/ivtv/ivtv-fileops.c @@ -753,7 +753,7 @@ unsigned int ivtv_v4l2_enc_poll(struct file *filp, poll_table * w...
1c659689fe9959c017bfaaa8301243f7d99f1a46
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7335): usb-video: checkpatch fixes
Problem Details: Please run checkpatch prior to sending patches Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/usbvideo/usbvideo.c b/drivers/media/video/usbvideo/usbvideo.c index f1ccf59545d4..7f3cdc9a0624 100644 --- a/drivers/media/video/usbvideo/usbvideo.c +++ b/drivers/media/video/usbvideo/usbvideo.c @@ -1035,10 +1035,10 @@ int usbvideo_RegisterVideoDevice(struct uvd *uvd) __F...
2c4a07b2da61bcd33f18195ff7f355c5bb285904
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7331): Fix em2800 altsetting selection
Problem Details: Signed-off-by: Sascha Sommer <saschasommer@freenet.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c index dbea89c115b1..4ebef10b5722 100644 --- a/drivers/media/video/em28xx/em28xx-core.c +++ b/drivers/media/video/em28xx/em28xx-core.c @@ -813,19 +813,27 @@ int em28xx_set_alternate(struct em28xx *dev) { int errCo...
a9317abfba0850b006aed000e2acc4bee150410a
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7327): cx88: Fix memset for tuner-xc3028 control
Problem Details: Fix a cut-and-paste error Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c index 3e7ddee9aba6..4c1e876a9232 100644 --- a/drivers/media/video/cx88/cx88-cards.c +++ b/drivers/media/video/cx88/cx88-cards.c @@ -2416,7 +2416,7 @@ static void cx88_card_setup(struct cx88_core *core) struct v4l2_priv...
000e27a639f16e2df70a3b0bec7edfab79e5e717
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7326): Fix bad whitespaces
Problem Details: Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c index 7a2b0f26921a..3e7ddee9aba6 100644 --- a/drivers/media/video/cx88/cx88-cards.c +++ b/drivers/media/video/cx88/cx88-cards.c @@ -1437,140 +1437,140 @@ static const struct cx88_board cx88_boards[] = { .mpeg ...
ddd5441df4127d5af45f6b2c58c2020b60bd52de
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7325): cx88-dvb: fix an OOPS for xc3028 devices, when dvb_attach fails
Problem Details: If dvb_attach fails, dev->dvb.frontend is NULL. This will produce an OOPS, as reported. Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c index cf6b9b05f496..d72b817bf886 100644 --- a/drivers/media/video/cx88/cx88-dvb.c +++ b/drivers/media/video/cx88/cx88-dvb.c @@ -461,6 +461,13 @@ static int attach_xc3028(u8 addr, struct cx8802_dev *dev) .video_dev = dev->c...
ebff033039b654b7b5493499babe22c7c1b0d36e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7322): pvrusb2: Fix storage-class as per C99 spec
Problem Details: The C99 specification states in section 6.11.5: The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-b...
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c index 7e7c570cf830..8bdb807b19b8 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c @@ -1502,7 +1502,7 @@ struct pvr2_std_hack { default - which can always b...
794b16072e00d0a40a8c773dd4319fb1e460a632
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7321): pvrusb2: Rework context handling and initialization
Problem Details: This change significantly rearranges pvr2_context level initialization and operation: 1. A new kernel thread is set up for management of the context. 2. Destruction of the pvr2_context instance is moved into the kernel thread. No other context is able to remove the instance; doing this simplif...
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-context.c b/drivers/media/video/pvrusb2/pvrusb2-context.c index 953784c08abb..22bd8302c4aa 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-context.c +++ b/drivers/media/video/pvrusb2/pvrusb2-context.c @@ -23,6 +23,7 @@ #include "pvrusb2-ioread.h" #include "pvr...
c4a8828ddbf5fb445d2679ab006d5743540fc41a
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7319): pvrusb2: Close potential race condition during initialization
Problem Details: There is a callback that is issued to into pvr2_context from pvr2_hdw after initialization is done. There was a probability that this callback could get missed. Fixed. Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-context.c b/drivers/media/video/pvrusb2/pvrusb2-context.c index 2a6726e403f0..953784c08abb 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-context.c +++ b/drivers/media/video/pvrusb2/pvrusb2-context.c @@ -75,10 +75,9 @@ struct pvr2_context *pvr2_context_create( ...
99a6acf9a7a80da49e85be964b15ffed9ab7643e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7306): pvrusb2: Fix oops possible when claiming a NULL stream
Problem Details: Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-context.c b/drivers/media/video/pvrusb2/pvrusb2-context.c index 160437b21e6d..2a6726e403f0 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-context.c +++ b/drivers/media/video/pvrusb2/pvrusb2-context.c @@ -173,7 +173,7 @@ int pvr2_channel_claim_stream(struct pvr2...
beb0ecd7f02f1a2da174b450d096e00530b3e8e8
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7300): pvrusb2: v4l2 implementation fixes for input selection
Problem Details: Now that the pvrusb2 driver can dynamically choose which inputs to make available depending on the hardware, the enumeration of input choices is no longer a contiguous range of integers. Unfortunately this causes a problem in the v4l2 implementation since the input enumeration requires continuity in t...
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c index 5e2292726e94..e878c6445ae2 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c +++ b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c @@ -67,6 +67,10 @@ struct pvr2_v4l2 { struct v4l2_prio_state prio; ...
76464d412a5a51633881078d4109212e4463e8d4
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7288): cx88: fix GPIO for FusionHDTV 7 Gold input selection
Problem Details: Fix GPIO for FusionHDTV 7 Gold tv / s-video / composite input selection. Fix card textual name to match other FusionHDTV device names. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/Documentation/video4linux/CARDLIST.cx88 b/Documentation/video4linux/CARDLIST.cx88 index b5f2134f1664..da7f70dfad2a 100644 --- a/Documentation/video4linux/CARDLIST.cx88 +++ b/Documentation/video4linux/CARDLIST.cx88 @@ -63,4 +63,4 @@ 62 -> PowerColor Real Angel 330 [14f1:e...
e43d76b40d3fda146b9cd1192c5504a257603b70
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7281): v4l: Deadlock in videobuf-core for DQBUF waiting on QBUF
Problem Details: Avoid a deadlock where DQBUF is holding the vb_lock while waiting on a QBUF which also needs the vb_lock. Reported by Hans Verkuil <hverkuil@xs4all.nl>. Signed-off-by: Brandon Philips <bphilips@suse.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c index eab79ffdf56a..5ea635fac236 100644 --- a/drivers/media/video/videobuf-core.c +++ b/drivers/media/video/videobuf-core.c @@ -605,7 +605,9 @@ int videobuf_dqbuf(struct videobuf_queue *q, goto done; } buf = list_entry...
6f2896756c4f1d4df5bd30599e6444c9513cfe8d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7274): dabusb: fix shadowed variable warning in dabusb.c
Problem Details: drivers/media/video/dabusb.c:208:6: warning: symbol 'buffers' shadows an earlier one drivers/media/video/dabusb.c:63:12: originally declared here Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/dabusb.c b/drivers/media/video/dabusb.c index a5731f90be0f..8d1f8ee2a533 100644 --- a/drivers/media/video/dabusb.c +++ b/drivers/media/video/dabusb.c @@ -205,7 +205,7 @@ static void dabusb_iso_complete (struct urb *purb) /*-------------------------------------------------------...
b573ea0a936eb2a7c6c57cdacb0d02bd358495a7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7271): cx88-cards: Fix powerangel gpio1
Problem Details: With this gpio, audio works properly. Thanks to Daniel Fraga <fragabr@gmail.com> for helping on fixing the code for Powerangel Real board. Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c index dbfaabb3e2e2..bf58f350e269 100644 --- a/drivers/media/video/cx88/cx88-cards.c +++ b/drivers/media/video/cx88/cx88-cards.c @@ -1494,7 +1494,7 @@ static const struct cx88_board cx88_boards[] = { .type = CX...
8765561fc88131bbc9a6246010c15b63595ec35e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7259): FusionHDTV DVB-T Pro tuning problem fixes
Problem Details: It seems that on this board, the demodulator provides the pullup on the I2C bus, which means that calling i2c_gate_ctrl crashes the bus. Turn this off and the xc3028 can talk OK. Also fix some GPIO related settings that became more clear through working on this. Some changes made by Mauro Chehab to ...
```diff diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c index 1dc70f27f7f9..1fe6b9da9815 100644 --- a/drivers/media/video/cx88/cx88-cards.c +++ b/drivers/media/video/cx88/cx88-cards.c @@ -2038,11 +2038,9 @@ static int cx88_dvico_xc2028_callback(void *ptr, int command, int arg)...
8efd2e28265ca031072d8d94cdbdd53904ce9b2d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7254): cx88: fix FusionHDTV 5 PCI nano name and enable IR support
Problem Details: load ir-kbd-i2c for IR remote control support on DViCO FusionHDTV 5 PCI nano Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/Documentation/video4linux/CARDLIST.cx88 b/Documentation/video4linux/CARDLIST.cx88 index 79c166a7f230..7d48e3dbd074 100644 --- a/Documentation/video4linux/CARDLIST.cx88 +++ b/Documentation/video4linux/CARDLIST.cx88 @@ -57,4 +57,4 @@ 56 -> Hauppauge WinTV-HVR1300 DVB-T/Hybrid MPEG Encoder [0070:9...
bb55de3b0e3523469491a48c51dcf7c6738162b2
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7249): Fix advertised pixel formats in mt9m001 and mt9v022
Problem Details: Only advertise pixel formats, that we actually can support in the present configuration. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/mt9m001.c b/drivers/media/video/mt9m001.c index e3afc82050af..4ad834326fa8 100644 --- a/drivers/media/video/mt9m001.c +++ b/drivers/media/video/mt9m001.c @@ -44,15 +44,23 @@ #define MT9M001_CHIP_ENABLE 0xF1 static const struct soc_camera_data_format mt9m001_colour_formats[]...
0705135e59f8503e4dade4b3580fed77b1743b7c
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7237): Convert videobuf-dma-sg to generic DMA API
Problem Details: videobuf-dma-sg does not need to depend on PCI. Switch it to using generic DMA API, convert all affected drivers, relax Kconfig restriction, improve compile-time type checking, fix some Coding Style violations while at it. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de> Signed-off...
```diff diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index a86504587447..b9b38d9ff650 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig @@ -160,7 +160,7 @@ config VIDEOBUF_GEN tristate config VIDEOBUF_DMA_SG - depends on PCI || ARCH_PXA + depends on HAS_DMA select VIDEOBUF_GEN trista...
f13613acfb1a71895ac886dc831d6ae4e20e241a
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7235): tuner-simple: fix a buffer overflow
Problem Details: simple_set_tv() creates a buffer with 4 elements, and calls simple_std_setup(), passing &buffer[1]. This makes the 5th element of buffer to be initialized to 0, overriding some area outside the buffer. Also, simple_std_setup() receives a buffer as parameter, but the buffer is just overriden after the ...
```diff diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c index dc2467159ece..ee5ef860700a 100644 --- a/drivers/media/video/tuner-simple.c +++ b/drivers/media/video/tuner-simple.c @@ -251,7 +251,7 @@ static int simple_config_lookup(struct dvb_frontend *fe, static int simple_std_set...
05b207924d558935080ac08776236e42aca1708c
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7220): drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y
Problem Details: Fix Unlikely(x) == y Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Reviewed-by: Luca Risolia <luca.risolia@studio.unibo.it> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/sn9c102/sn9c102_core.c b/drivers/media/video/sn9c102/sn9c102_core.c index e5ef0190ebdc..94f393eebd51 100644 --- a/drivers/media/video/sn9c102/sn9c102_core.c +++ b/drivers/media/video/sn9c102/sn9c102_core.c @@ -528,7 +528,7 @@ sn9c102_find_sof_header(struct sn9c102_device* cam, v...
ef6ad5c35ed7233e7aafcc5645a1470199b10cc7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7218): Fix breakage in mt9m001 and mt9v022 driver if "CONFIG_GENERIC_GPIO is not set"
Problem Details: Both camera drivers can function without GPIO support, in which case they will only support the 10 bit data width mode. But the two respective switch have to depend on CONFIG_GENERIC_GPIO. Additionally remove redundant gpio_is_valid tests - they are repeated in bus_switch_request() functions. Signed-o...
```diff diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig index 21f250b8cbb0..de6a6208e344 100644 --- a/drivers/media/video/Kconfig +++ b/drivers/media/video/Kconfig @@ -847,7 +847,7 @@ config SOC_CAMERA config SOC_CAMERA_MT9M001 tristate "mt9m001 support" - depends on SOC_CAMERA && GENERIC_GP...
ab6c46e24a3c89c1e2d0d3959e119583e1bc92d9
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7184): make hybrid_tuner_request_state tolerant of devices without i2c adapters
Problem Details: Some dvb demodulators access the tuner directly without using i2c. In these cases, i2c_adap may be NULL. This patch fixes hybrid_tuner_request_state to allow for NULL i2c_adapters. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/tuner-i2c.h b/drivers/media/video/tuner-i2c.h index c53c327a487c..60ba794809fe 100644 --- a/drivers/media/video/tuner-i2c.h +++ b/drivers/media/video/tuner-i2c.h @@ -83,7 +83,8 @@ static inline int tuner_i2c_xfer_send_recv(struct tuner_i2c_props *props, #define tuner_printk(k...
26d507fcfef7f7d0cd2eec874a87169cc121c835
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7166): [v4l] Add new user class controls and deprecate others
Problem Details: These changes should appear in the next update of the v4l2spec. HCENTER and VCENTER are unused in the tree so I added a _DEPRECATED postfix so applications can remove their use. Signed-off-by: Brandon Philips <bphilips@suse.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 17a80177a674..777bcb0daa11 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -849,21 +849,34 @@ struct v4l2_querymenu #define V4L2_CID_AUDIO_TREBLE (V4L2_CID_BASE+8) #define V4L2_CID_AUDIO_MUTE (V4L2_CID_BASE+9)...
2756665c28a7d2e25d92745195b5171866e12da9
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7135): remove PREFIX from users of tuner_foo printk macros
Problem Details: Store a pointer to the device name in the name field of struct tuner_i2c_props, so that we can remove the printk macros defined in tuner-i2c.h Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/mt20xx.c b/drivers/media/video/mt20xx.c index 1fa89dbdff24..fbcb28233737 100644 --- a/drivers/media/video/mt20xx.c +++ b/drivers/media/video/mt20xx.c @@ -14,8 +14,6 @@ static int debug; module_param(debug, int, 0644); MODULE_PARM_DESC(debug, "enable verbose debug messages"); ...
3c2a0865d06df23f755a7d36a1076965500e1228
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7134): tuner: create a macro for sharing state between hybrid tuner instances
Problem Details: Create a macro implementing a standard method to share state amongst multiple instances of a hybrid tuner object. Also, prepare tuner_foo printk macros for the removal of PREFIX Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/tuner-i2c.h b/drivers/media/video/tuner-i2c.h index de52e8ffd347..8ec5b41d459f 100644 --- a/drivers/media/video/tuner-i2c.h +++ b/drivers/media/video/tuner-i2c.h @@ -26,6 +26,10 @@ struct tuner_i2c_props { u8 addr; struct i2c_adapter *adap; + + /* used for tuner instance ma...
7f8447d13d3abaeb46d0e6ae2890a843aa09561f
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (7124): tuner-simple: display frequency in MHz
Problem Details: fix debug in simple_config_lookup to display frequency in MHz Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c index 4854fc4a7d39..85556d44c8ab 100644 --- a/drivers/media/video/tuner-simple.c +++ b/drivers/media/video/tuner-simple.c @@ -241,8 +241,10 @@ static int simple_config_lookup(struct dvb_frontend *fe, *config = t_params->range...
a7f796a60bb5dcdc154c3ae04d484a395a60809f
Analyze and fix the following issue in the Linux kernel code: [CIFS] Fix typo in previous commit
Problem Details: Signed-off-by: Steve French <sfrench@us.ibm.com>
```diff diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h index 3b889bc3e8d1..9f49c2f3582c 100644 --- a/fs/cifs/cifspdu.h +++ b/fs/cifs/cifspdu.h @@ -2049,8 +2049,8 @@ typedef struct { #define CIFS_UNIX_LARGE_READ_CAP 0x00000040 /* support reads >128K (up to 0xFFFF00 */ #define CIFS_UNIX_LARGE_WR...
0a2784233785226fe5882c8af15118476f89e98e
Analyze and fix the following issue in the Linux kernel code: Blackfin Serial Driver: fix bug - use mod_timer to replace only add_timer.
Problem Details: http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=4045 If adding timer in both timer handler and rx interrupt, a timer may be added when it is till in the pending list. Signed-off-by: Sonic Zhang <sonic.zhang@analog.com> Signed-off-by: Bryan Wu <coolon...
```diff diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c index 47ca7b0267df..5f55534a290b 100644 --- a/drivers/serial/bfin_5xx.c +++ b/drivers/serial/bfin_5xx.c @@ -506,8 +506,7 @@ void bfin_serial_rx_dma_timeout(struct bfin_serial_port *uart) uart->rx_dma_buf.tail = uart->rx_dma_buf.head; } - ...
ee4987ab5cc9d00be38cfeec90174229565211be
Analyze and fix the following issue in the Linux kernel code: [CIFS] Fix define for new proxy cap to match documentation
Problem Details: The transport encryption capability and new SetFSInfo level were missing, and the new proxy capability (which Samba server is implementing) and proxy setfsinfo needed to be moved down to not collide with Samba's transport encryption capability. CC: Jeremy Allison <jra@samba.org> CC: Sam Liddicott <sam...
```diff diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h index b18c6d43bef3..3b889bc3e8d1 100644 --- a/fs/cifs/cifspdu.h +++ b/fs/cifs/cifspdu.h @@ -1787,7 +1787,8 @@ typedef struct smb_com_transaction2_fnext_rsp_parms { #define SMB_QUERY_CIFS_UNIX_INFO 0x200 #define SMB_QUERY_POSIX_FS_INFO 0x201 #define SM...
72cff12397cd6648b8b5abfaeb00502f45b76cb8
Analyze and fix the following issue in the Linux kernel code: alpha: fix legacy mode PCI IDE controllers
Problem Details: Legacy IDE resources were never properly allocated on most alpha platforms, so IDE expectedly stopped working after commit 10f000a2fd805e8ccfe988e8615545467bb7f7df (generic pci_enable_resources). Always allocate "fixed" PCI resources before doing anything else; remove Cypress IDE quirk, as it's a gene...
```diff diff --git a/arch/alpha/kernel/pci.c b/arch/alpha/kernel/pci.c index c107cc08daf4..78357798b6fd 100644 --- a/arch/alpha/kernel/pci.c +++ b/arch/alpha/kernel/pci.c @@ -71,25 +71,13 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82378, quirk_i static void __init quirk_cypress(struct pci_de...
8911c9e3343c647b59727b47b10feca7ee9ac9c3
Analyze and fix the following issue in the Linux kernel code: [SCSI] aic79xx: fix MMIO for PPC 44x platforms
Problem Details: The driver stores the PCI resource address into 'u_long' variable before calling ioremap_nocache() on it. This warrants kernel oops when the registers are accessed on PPC 44x platforms which (being 32-bit) have PCI memory space mapped beyond 4 GB. The arch/ppc/ kernel has a fixup in ioremap() that hel...
```diff diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.h b/drivers/scsi/aic7xxx/aic79xx_osm.h index b252803e05f6..08dd18229b45 100644 --- a/drivers/scsi/aic7xxx/aic79xx_osm.h +++ b/drivers/scsi/aic7xxx/aic79xx_osm.h @@ -360,7 +360,7 @@ struct ahd_platform_data { #define AHD_LINUX_NOIRQ ((uint32_t)~0) uint32_t irq; ...
448504130f18bc9d8d10ba045775c906abd01438
Analyze and fix the following issue in the Linux kernel code: [SCSI] aic7xxx: fix MMIO for PPC 44x platforms
Problem Details: The driver stores the PCI resource address into 'u_long' variable before calling ioremap_nocache() on it. This warrants kernel oops when the registers are accessed on PPC 44x platforms which (being 32-bit) have PCI memory space mapped beyond 4 GB. The arch/ppc/ kernel has a fixup in ioremap() that hel...
```diff diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.h b/drivers/scsi/aic7xxx/aic7xxx_osm.h index 9d6e0660ddbc..c2a9ad76d35d 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.h +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.h @@ -365,7 +365,7 @@ struct ahc_platform_data { #define AHC_LINUX_NOIRQ ((uint32_t)~0) uint32_t irq; ...
5826042d3c550522e49a8a55db64d9c47b43a8f9
Analyze and fix the following issue in the Linux kernel code: [ARM] 5011/1: htc-pasic3: fix bug in resource pipe-through to ds1wm
Problem Details: The newly created DS1WM platform device should get a copy of the PASIC3 platform devices' resources. Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/drivers/mfd/htc-pasic3.c b/drivers/mfd/htc-pasic3.c index af66f4f28300..cb4ab27a2ef5 100644 --- a/drivers/mfd/htc-pasic3.c +++ b/drivers/mfd/htc-pasic3.c @@ -135,8 +135,9 @@ static struct ds1wm_platform_data ds1wm_pdata = { .disable = ds1wm_disable, }; -static int ds1wm_device_add(struct dev...
0d626239ffe515a64a6b53c70896796f621c635c
Analyze and fix the following issue in the Linux kernel code: arm/mach-integrator/time.c, mwave: revert portions of recent irq cleanups
Problem Details: The recent irq cleanups for arch/arm/mach-integrator/time.c and drivers/char/mwave/tp3780i.c changed the request_irq() dev_id parameter, but neglected to change the matching free_irq() parameter, thus creating a bug upon irq de-registration. Given that the impetus for the changes is not yet accepted u...
```diff diff --git a/arch/arm/mach-integrator/time.c b/arch/arm/mach-integrator/time.c index 5235f64f235b..8508a0db3eaf 100644 --- a/arch/arm/mach-integrator/time.c +++ b/arch/arm/mach-integrator/time.c @@ -124,8 +124,11 @@ static int rtc_probe(struct amba_device *dev, void *id) xtime.tv_sec = __raw_readl(rtc_base ...
36f8a2c4c61e3559a95190e457b431c6900859b4
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Add CONFIG_PPC_PSERIES_DEBUG to enable debugging for platforms/pseries
Problem Details: Add a DEBUG config setting which turns on all (most) of the debugging under platforms/pseries. To have this take effect we need to remove all the #undef DEBUG's, in various files. We leave the #undef DEBUG in platforms/pseries/lpar.c, as this enables debugging printks from the low-level hash table rou...
```diff diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index 306a9d07491d..07fe5b69b9e2 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -34,3 +34,8 @@ config LPARCFG help Provide system capacity information via human r...
f7ebf352b2e04ee89efb426e33dd450d8f1cfcd5
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Convert from DBG() to pr_debug() in platforms/pseries/
Problem Details: In pseries/lpar.c, fix some printf specifier mismatches, and add a newline to one printk. In pseries/rtasd.c add "rtasd" to some messages to make it clear where they're coming from. In pseries/scanlog.c remove the hand-rolled runtime debugging support in there. This file has been largely unchanged fo...
```diff diff --git a/arch/powerpc/platforms/pseries/firmware.c b/arch/powerpc/platforms/pseries/firmware.c index b765b7c77b65..743d494c06dd 100644 --- a/arch/powerpc/platforms/pseries/firmware.c +++ b/arch/powerpc/platforms/pseries/firmware.c @@ -27,11 +27,6 @@ #include <asm/prom.h> #include <asm/udbg.h> -#ifdef DE...
cb1e2ab45a92b31114dfe6e34832a084f9b0b263
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Register udbg console early on pseries LPAR
Problem Details: On pseries LPAR we can call the udbg routines, and the udbg console very early. So mark the udbg console as safe to call early in boot, and register the udbg console as soon as the udbg routines are hooked up. This allows platforms/pseries code to use printk() and pr_debug() rather than needing to cal...
```diff diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c index 9235c469449e..c34789fe535e 100644 --- a/arch/powerpc/platforms/pseries/lpar.c +++ b/arch/powerpc/platforms/pseries/lpar.c @@ -196,6 +196,8 @@ void __init udbg_init_debug_lpar(void) udbg_putc = udbg_putcLP; udbg_...
c7afb4e22961b5ec88eb6f7b81260dafa9f287c7
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Set udbg_console index to 0
Problem Details: Because the udbg_console has CON_ENABLED set, it's possible that when we register it with the console code the index won't be set. This leads to slightly confusing boot messages like: [ 0.000000] console [udbg-1] enabled We could remove CON_ENABLED, but we don't want to do that, we always want the...
```diff diff --git a/arch/powerpc/kernel/udbg.c b/arch/powerpc/kernel/udbg.c index 7aad6203e411..9ac5f3aad5e8 100644 --- a/arch/powerpc/kernel/udbg.c +++ b/arch/powerpc/kernel/udbg.c @@ -155,7 +155,7 @@ static struct console udbg_console = { .name = "udbg", .write = udbg_console_write, .flags = CON_PRINTBUFFER | ...
885aa35c9669ce7919d203036a87a7e1a4ebd25f
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix new warnings arising from stacktrace patch
Problem Details: Remove the inclusion of asm-offsets.h from stacktrace.c. It isn't supposed to be included in C code and it causes problems with multiple definitions of things. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c index e3638eeaaae7..962944038430 100644 --- a/arch/powerpc/kernel/stacktrace.c +++ b/arch/powerpc/kernel/stacktrace.c @@ -13,7 +13,6 @@ #include <linux/sched.h> #include <linux/stacktrace.h> #include <asm/ptrace.h> -#include <as...
2c419bdeca1d958bb02228b5141695f312d8c633
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Port fixmap from x86 and use for kmap_atomic
Problem Details: The fixmap code from x86 allows us to have compile time virtual addresses that we change the physical addresses of at run time. This is useful for applications like kmap_atomic, PCI config that is done via direct memory map, kexec/kdump. We got ride of CONFIG_HIGHMEM_START as we can now determine a m...
```diff diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index fdc755a05f70..20f45a8b87e3 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -626,20 +626,6 @@ config ADVANCED_OPTIONS comment "Default settings for advanced configuration options are used" depends on !ADVANCED_OPTIONS -config HIG...
2fd53e02be9a73cc49d69e0ff8860daa7b5bf8ab
Analyze and fix the following issue in the Linux kernel code: [POWERPC] char/xilinx_hwicap/ section fix
Problem Details: This patch fixes the following build error: <-- snip --> ... CC [M] drivers/char/xilinx_hwicap/xilinx_hwicap.o ... /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/char/xilinx_hwicap/xilinx_hwicap.c:806: error: hwicap_of_match causes a section type conflict /home/bunk/linux/kernel-2.6/git/linux...
```diff diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c index 016f90567a52..dfe6907ae15b 100644 --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c @@ -803,7 +803,7 @@ static int __devexit hwicap_of_remove(struct of_devic...
138decf83f6a973951ce7faf39094d964de7853a
Analyze and fix the following issue in the Linux kernel code: [POWERPC] drivers/of/of_i2c.c: Add MODULE_LICENSE
Problem Details: After commit 585468e5d5962660867c269e26f0a4b89a599473 ([POWERPC] i2c: Fix build breakage introduced by OF helpers) drivers/of/of_i2c.c needs a MODULE_LICENSE. Signed-off-by: Adrian Bunk <bunk@kernel.org> Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c index 631689171159..715a44471617 100644 --- a/drivers/of/of_i2c.c +++ b/drivers/of/of_i2c.c @@ -13,6 +13,7 @@ #include <linux/i2c.h> #include <linux/of.h> +#include <linux/module.h> struct i2c_driver_device { char *of_device; @@ -113,3 +114,5 @@...
96f1bb8a412aec3fc16306ef07c5bdb426edb615
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Add strncmp to arch/ppc
Problem Details: Commit 0119536cd314ef95553604208c25bc35581f7f0a added an assembly version of strncmp to PowerPC. However, it changed a common header file between arch/ppc and arch/powerpc without adding strncmp to arch/ppc. This fixes that omission so that arch/ppc links again. Signed-off-by: Josh Boyer <jwboyer@li...
```diff diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c index 2ba659f401be..d9036ef0b658 100644 --- a/arch/ppc/kernel/ppc_ksyms.c +++ b/arch/ppc/kernel/ppc_ksyms.c @@ -88,6 +88,7 @@ EXPORT_SYMBOL(strncpy); EXPORT_SYMBOL(strcat); EXPORT_SYMBOL(strlen); EXPORT_SYMBOL(strcmp); +EXPORT_SYMBOL(strn...
e91d7119ba8031f57cee5814e31c893487844011
Analyze and fix the following issue in the Linux kernel code: [POWERPC] 4xx: Fix duplicate phys_addr_t definition
Problem Details: Commit d04ceb3fc294ea2c4f538a04343f3a473953a3b0 moved phys_addr_t definitions to include/asm-powerpc/types.h. However, arch/ppc 440 builds had a duplicate definition in include/asm-ppc/mmu.h that caused the build to fail. This removes the duplicate definition in arch/ppc. Signed-off-by: Josh Boyer <...
```diff diff --git a/include/asm-ppc/mmu.h b/include/asm-ppc/mmu.h index d46b57b589ae..d76ef098ed37 100644 --- a/include/asm-ppc/mmu.h +++ b/include/asm-ppc/mmu.h @@ -15,10 +15,8 @@ * physical need a larger than native word size type. -Matt */ #ifndef CONFIG_PHYS_64BIT -typedef unsigned long phys_addr_t; #define ...
df40a57ef16219e5dee75238559960b1dd459c65
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix mv64x60 early console code to use cell-index property
Problem Details: The MPSC driver and prpmc2800.dts have been modified to use property 'cell-index' as the serial port number, but the early serial console driver for the mv64x60 has not been modified to use this new property. This fixes it. Signed-off-by: Remi Machet (rmachet@slac.stanford.edu) Acked-by: Dale Farnswor...
```diff diff --git a/arch/powerpc/sysdev/mv64x60_udbg.c b/arch/powerpc/sysdev/mv64x60_udbg.c index ccdb3b0418fc..2792dc8b038c 100644 --- a/arch/powerpc/sysdev/mv64x60_udbg.c +++ b/arch/powerpc/sysdev/mv64x60_udbg.c @@ -94,7 +94,7 @@ static void mv64x60_udbg_init(void) if (!np) return; - block_index = of_get_prop...
f6a616800e68b61807d0f7bb0d5dc70665ef8046
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix kernel stack allocation alignment
Problem Details: The powerpc kernel stacks need to be naturally aligned, as they contain the thread info at the bottom, which is obtained by clearing the low bits of the stack pointer. However, when using 64K pages, the stack is smaller than a page, so we use kmalloc to allocate it, but that doesn't provide the alignm...
```diff diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 703100d5e458..6caad17ea72e 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -1033,3 +1033,34 @@ void ppc64_runlatch_off(void) } } #endif + +#if THREAD_SHIFT < PAGE_SHIFT + +static struct kmem_ca...
8c9843e57a7d9d7a090d6467a0f1f3afb8031527
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Add thread_info_cache_init() weak hook
Problem Details: Some architectures need to maintain a kmem cache for thread info structures. The next commit adds that to powerpc to fix an alignment problem. There is no good arch callback to use to initialize that cache that I can find, so this adds a new one in the form of a weak function whose default is empty. ...
```diff diff --git a/include/linux/sched.h b/include/linux/sched.h index 311380e5fe89..d0bd97044abd 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1926,6 +1926,8 @@ static inline unsigned long *end_of_stack(struct task_struct *p) #endif +extern void thread_info_cache_init(void); + /* set threa...
1d32e21889b96e594e8b63b193bf7d2a51ab93ec
Analyze and fix the following issue in the Linux kernel code: [POWERPC] PS3: Fix gelic net module dependency
Problem Details: The PS3 gelic network driver depends on the wake-on-lan support provided by the PS3 sys manager driver. Add that dependency to the GELIC_NET Kconfig option. Prevents these build errors: ps3_gelic_net.c:1277: undefined reference to `.ps3_sys_manager_get_wol' ps3_gelic_net.c:1337: undefined refere...
```diff diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 2399a3796f6e..d46d9498040c 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2278,6 +2278,7 @@ config TSI108_ETH config GELIC_NET tristate "PS3 Gigabit Ethernet driver" depends on PPC_PS3 + select PS3_SYS_MANAGER help This driv...
23386fe572028ca0f9249fb3c71ed31b54cf1665
Analyze and fix the following issue in the Linux kernel code: [POWERPC] macintosh/windfarm: Fix platform driver hotplug/coldplug
Problem Details: Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable "macintosh" platform drivers, to re-enable auto loading. [dbrownell@users.sourceforge.net: registration fixes] Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> S...
```diff diff --git a/drivers/macintosh/windfarm_pm112.c b/drivers/macintosh/windfarm_pm112.c index b3fbb45bc90a..73d695dc9e50 100644 --- a/drivers/macintosh/windfarm_pm112.c +++ b/drivers/macintosh/windfarm_pm112.c @@ -668,7 +668,7 @@ static struct platform_driver wf_pm112_driver = { .remove = __devexit_p(wf_pm112_re...
3a841d519f91463361bbbe7addc24a0c1b2e9f99
Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1724 - Fix IRQ lock-up with MPU access
Problem Details: The sound boards with VT1724 and compatible chips may lock up when MPU401 is accessed together with the PCM streaming. This patch fixes the problem. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c index 13ea94f317cb..4490422fb930 100644 --- a/sound/pci/ice1712/ice1724.c +++ b/sound/pci/ice1712/ice1724.c @@ -222,6 +222,32 @@ static unsigned int snd_vt1724_get_gpio_data(struct snd_ice1712 *ice) return data; } +/* + * MPU401 accesso...
efd89d9dcf75ab0a31b200db0ae4ae19cad25e48
Analyze and fix the following issue in the Linux kernel code: [ALSA] pcsp: fix wording in DEBUG_PAGEALLOC warning
Problem Details: Signed-off-by: Stas Sergeev <stsp@aknet.ru> (fixed invalid KERN_WARNING by tiwai) Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/drivers/pcsp/pcsp.c b/sound/drivers/pcsp/pcsp.c index d8f96219fd36..59203511e77d 100644 --- a/sound/drivers/pcsp/pcsp.c +++ b/sound/drivers/pcsp/pcsp.c @@ -147,12 +147,8 @@ static int __devinit alsa_card_pcsp_init(struct device *dev) #ifdef CONFIG_DEBUG_PAGEALLOC /* Well, CONFIG_DEBUG_PA...
73bdd2ad7aac70456494c4a1d93f99fe88184dba
Analyze and fix the following issue in the Linux kernel code: [ALSA] pcsp - Fix dependency in Kconfig
Problem Details: Added the proper dependency to Kconfig for snd-pcsp driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig index 78648c4e9e73..fe85af1c5693 100644 --- a/sound/drivers/Kconfig +++ b/sound/drivers/Kconfig @@ -7,6 +7,7 @@ menu "Generic devices" config SND_PCSP tristate "Internal PC speaker support" depends on X86_PC && HIGH_RES_TIMERS + depends on INPUT ...
b32432e3f2d386d9563669c8cfdeaa473bfd8572
Analyze and fix the following issue in the Linux kernel code: [ALSA] soc - pxa2xx-pcm - Fix checkpatch warnings
Problem Details: Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/soc/pxa/pxa2xx-pcm.c b/sound/soc/pxa/pxa2xx-pcm.c index daeaa4c8b876..01ad7bf716b7 100644 --- a/sound/soc/pxa/pxa2xx-pcm.c +++ b/sound/soc/pxa/pxa2xx-pcm.c @@ -64,8 +64,8 @@ static void pxa2xx_pcm_dma_irq(int dma_ch, void *dev_id) if (dcsr & DCSR_ENDINTR) { snd_pcm_period_elapsed(substre...
22cd630285b6a12a50f02dfb23c531f151be5499
Analyze and fix the following issue in the Linux kernel code: [ALSA] soc - spitz - Fix checkpatch warnings
Problem Details: Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/soc/pxa/spitz.c b/sound/soc/pxa/spitz.c index ecca39033fcc..d8b8372db00e 100644 --- a/sound/soc/pxa/spitz.c +++ b/sound/soc/pxa/spitz.c @@ -313,15 +313,13 @@ static int spitz_wm8750_init(struct snd_soc_codec *codec) } /* Add spitz specific widgets */ - for (i = 0; i < ARRAY_SIZE(wm8750_...
29e36e49bdb7f24ca7cc0fb980fab2c407a8a2c9
Analyze and fix the following issue in the Linux kernel code: [ALSA] soc - poodle - Fix checkpatch warnings
Problem Details: Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/soc/pxa/poodle.c b/sound/soc/pxa/poodle.c index 4fbf8bba9627..7e830b218943 100644 --- a/sound/soc/pxa/poodle.c +++ b/sound/soc/pxa/poodle.c @@ -257,21 +257,19 @@ static int poodle_wm8731_init(struct snd_soc_codec *codec) /* Add poodle specific controls */ for (i = 0; i < ARRAY_SIZE(wm8731...
1bfcd361461f25be7d6d180a8da30d02bc124046
Analyze and fix the following issue in the Linux kernel code: [ALSA] soc - corgi - Fix checkpatch warnings
Problem Details: Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/soc/pxa/corgi.c b/sound/soc/pxa/corgi.c index 1a70a6ac98ce..7f32a1167572 100644 --- a/sound/soc/pxa/corgi.c +++ b/sound/soc/pxa/corgi.c @@ -297,21 +297,19 @@ static int corgi_wm8731_init(struct snd_soc_codec *codec) /* Add corgi specific controls */ for (i = 0; i < ARRAY_SIZE(wm8731_corgi...
0015e7d1e2b09443ac76573a2fb886854aa1ca15
Analyze and fix the following issue in the Linux kernel code: [ALSA] soc - s3c24xx-i2s - Fix tab/space breakage
Problem Details: Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/soc/s3c24xx/s3c24xx-i2s.c b/sound/soc/s3c24xx/s3c24xx-i2s.c index 340f36e6979c..50e06f0777f1 100644 --- a/sound/soc/s3c24xx/s3c24xx-i2s.c +++ b/sound/soc/s3c24xx/s3c24xx-i2s.c @@ -159,10 +159,10 @@ static void s3c24xx_snd_rxctrl(int on) * DMA engine will simply freeze randomly. */ -...
05808ecc45802c1b533f42ed701a132d4c949034
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda - Fix Thinkpad X300 digital mic
Problem Details: TP X300 digital mic requires additional init verbs with magic COEFs. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index f486eb16a386..e0a605adde42 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c @@ -3740,6 +3740,9 @@ static struct hda_verb ad1984a_thinkpad_verbs[] = { {0x11, AC_VERB_SET_UNSOLICITED_ENABLE, AC_USRSP_EN | ...
a0b8f7d89b8de0cc79999b9fdd3a303912f3b2a3
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda - Fix model for Acer Aspire 5720z
Problem Details: Set the proper model=acer for Acer Aspire 5720z with ALC268 codec. ALSA bug#3550: https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3550 Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 732515dcc99d..cdda64b02f46 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10404,6 +10404,7 @@ static const char *alc268_models[ALC268_MODEL_LAST] = { }; static struct snd_pci_quirk alc268_cfg...
409203074e9f3c423cdc7c38f984ce24ae261556
Analyze and fix the following issue in the Linux kernel code: [ALSA] soc - s3c24xx - Improve diagnostic output
Problem Details: Add some debug messages for suspend/resume and to add a clear prefix to s3c24xx-i2s and s3c24xx-pcm. Signed-off-by: Tim Niemeyer <reddog@mastersword.de> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/soc/s3c24xx/s3c24xx-i2s.c b/sound/soc/s3c24xx/s3c24xx-i2s.c index 301002cd3fc8..cb68b9ced601 100644 --- a/sound/soc/s3c24xx/s3c24xx-i2s.c +++ b/sound/soc/s3c24xx/s3c24xx-i2s.c @@ -46,7 +46,7 @@ #define S3C24XX_I2S_DEBUG 0 #if S3C24XX_I2S_DEBUG -#define DBG(x...) printk(KERN_DEBUG x) +#def...
ebf029da38829ede6b53ac8a5ad45b149064ea16
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix possible races at free_irq in PCI drivers
Problem Details: The irq handler of PCI drivers must be released before releasing other resources since the handler for a shared irq can be still called and may access the freed resource again. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c index 3818249fcc81..ecbe79b67e43 100644 --- a/sound/pci/ca0106/ca0106_main.c +++ b/sound/pci/ca0106/ca0106_main.c @@ -1114,6 +1114,8 @@ static int snd_ca0106_free(struct snd_ca0106 *chip) * So we can fix: snd-malloc: Memory leak? ...
6b9a9b329640b7e8143df7b2782884ea758650f7
Analyze and fix the following issue in the Linux kernel code: [ALSA] soc - neo1973_wm8753 - Fix module unload
Problem Details: Signed-off-by: Tim Niemeyer <reddog@mastersword.de> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/soc/s3c24xx/neo1973_wm8753.c b/sound/soc/s3c24xx/neo1973_wm8753.c index 6ee115ceb011..962cc20b1af5 100644 --- a/sound/soc/s3c24xx/neo1973_wm8753.c +++ b/sound/soc/s3c24xx/neo1973_wm8753.c @@ -659,6 +659,7 @@ static int __init neo1973_init(void) static void __exit neo1973_exit(void) { + i2...
f000fd80937c0d94c67f9f3e7026f1fbc8ef8873
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix synchronize_irq() bugs, redundancies
Problem Details: free_irq() calls synchronize_irq() for you, so there is no need for drivers to manually do the same thing (again). Thus, calls where sync-irq immediately precedes free-irq can be simplified. However, during this audit several bugs were noticed, where free-irq is preceded by a "irq >= 0" check... but ...
```diff diff --git a/drivers/media/video/cx88/cx88-alsa.c b/drivers/media/video/cx88/cx88-alsa.c index 316b106c3511..03feb5b49e1b 100644 --- a/drivers/media/video/cx88/cx88-alsa.c +++ b/drivers/media/video/cx88/cx88-alsa.c @@ -690,10 +690,8 @@ MODULE_DEVICE_TABLE(pci, cx88_audio_pci_tbl); static int snd_cx88_free(snd_...
8a87c9cf999542db846c3ab93c1065d446427f37
Analyze and fix the following issue in the Linux kernel code: [ALSA] Audiophile 192: Fix ad converter initialization
Problem Details: Correct some arguments in calls to snd_ice1712_gpio_write_bits() from ap192_set_rate_val(). Signed-off-by: Karsten Wiese <fzu@wemgehoertderstaat.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c index dba93d8efbe0..4d2631434dc8 100644 --- a/sound/pci/ice1712/revo.c +++ b/sound/pci/ice1712/revo.c @@ -327,7 +327,7 @@ static void ap192_set_rate_val(struct snd_akm4xxx *ak, unsigned int rate) revo_set_rate_val(ak, rate); /* reset CKS */ ...
0d52cea487c0213d6d7bca9c951210081e7b653b
Analyze and fix the following issue in the Linux kernel code: OSS: dmabuf: fix negative DMAbuf_get_buffer_pointer() check
Problem Details: Since unsigned active_offs < 0 is even true when DMAbuf_get_buffer_pointer() returns negative Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/oss/dmabuf.c b/sound/oss/dmabuf.c index eaf69971bf92..1e90d769b62e 100644 --- a/sound/oss/dmabuf.c +++ b/sound/oss/dmabuf.c @@ -795,9 +795,9 @@ static int find_output_space(int dev, char **buf, int *size) #ifdef BE_CONSERVATIVE active_offs = dmap->byte_counter + dmap->qhead * dmap->fragmen...
e34ba212225a27cdf5f974be22cc539ae7ee7ca5
Analyze and fix the following issue in the Linux kernel code: [ALSA] SOC: fix tests in cs4270_hw_params()
Problem Details: cs4270_hw_params does several times: ret = snd_soc_write() if (ret < 0) ... This only works when ret is signed. Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index bf2ab72d49bf..e73fcfd9f5cd 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -372,7 +372,7 @@ static int cs4270_hw_params(struct snd_pcm_substream *substream, struct snd_soc_device *socdev = rtd->socdev; struct ...
9eb70e68f38bbc5996a2193e7b7dc0b5487a08cb
Analyze and fix the following issue in the Linux kernel code: [ALSA] usb-audio - Fix race in reconnection
Problem Details: Fix the race at reconnection of the device. The disconnected usb_chip[] must be cleared before the next probe call properly. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index 7b3bcf1916d2..410be4aff1ba 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -3424,7 +3424,6 @@ static void snd_usb_audio_create_proc(struct snd_usb_audio *chip) static int snd_usb_audio_free(struct snd_usb_audio *chip) { - usb_chi...
73d38b13ffb105ab633bd91969c8d218b2de38d4
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix the race of card instance unregistration
Problem Details: Move the call of device_unregister() for the card instance in snd_card_disconnect() to avoid the race of sysfs card entry, which can be typically found on usb-audio reconnection. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/core/init.c b/sound/core/init.c index f045f7db3ab4..07acac77ea45 100644 --- a/sound/core/init.c +++ b/sound/core/init.c @@ -360,6 +360,12 @@ int snd_card_disconnect(struct snd_card *card) snd_printk(KERN_ERR "not all devices for card %i can be disconnected\n", card->number); snd_info_c...
369b240d6391aef41d376c9e8769fd939c7c6c4d
Analyze and fix the following issue in the Linux kernel code: [ALSA] sound/drivers/dummy.c: fix negative snd_pcm_format_width() check
Problem Details: bps is unsigned, a negative snd_pcm_format_width() return value is not noticed Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 83ac4980c5fb..4e4c69e6cb4c 100644 --- a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c @@ -230,13 +230,14 @@ static int snd_card_dummy_pcm_prepare(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; ...
cb308f97aee2c816834240c8d5f7c98dd8aff157
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda - Fix ALC889A codec support
Problem Details: ALC889A is recognized ALC885/ALC882 but it's actually closer to ALC888/ALC883. Cc: Kasper Sandberg <lkml@metanurb.dk> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 181db2177a1d..fb09e4429b27 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -14042,6 +14042,8 @@ struct hda_codec_preset snd_hda_preset_realtek[] = { { .id = 0x10ec0880, .name = "ALC880", .patch =...
3adb8abc70aaf5c071f27576069c8b01783cca83
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda - Add support of AD1989A/AD1989B
Problem Details: Added the support of AD1989A and AD1989B codecs. These codecs can have multiple SPDIF devices, but currently we handle only one SPDIF. If any real devices with two SPDIF interfaces (likely one for SPDIF and one for HDMI), we'll fix this rightly. Otherwise, these codecs are pretty similar with AD1988....
```diff diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt index 3413644dff1e..fd4c32a031c9 100644 --- a/Documentation/sound/alsa/ALSA-Configuration.txt +++ b/Documentation/sound/alsa/ALSA-Configuration.txt @@ -956,7 +956,7 @@ Prior to version 0.9.0rc4 options...
ad5fada51d33b408ad3d2d0848ef6744b5daf06f
Analyze and fix the following issue in the Linux kernel code: [ALSA] sound/core.h: evil #ifdefs
Problem Details: snd_minor_info_oss_* is an function returning int _or_ comment, depending on config parameters. That is truly evil, fix it. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/include/sound/core.h b/include/sound/core.h index 356659de6b85..695ee53488a3 100644 --- a/include/sound/core.h +++ b/include/sound/core.h @@ -277,8 +277,8 @@ int snd_minor_info_done(void); int snd_minor_info_oss_init(void); int snd_minor_info_oss_done(void); #else -#define snd_minor_info_oss_ini...
a8bb1bad9b16ab91de6568ac9356b8f705f7272b
Analyze and fix the following issue in the Linux kernel code: [ALSA] virtuoso: fix DX front panel I/O
Problem Details: Fix the GPIO 1 mixer control to enable I/O through the front panel connector of the Xonar DX. Signed-off-by: Clemens Ladisch <clemens@ladisch.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/oxygen/virtuoso.c b/sound/pci/oxygen/virtuoso.c index c7080d6b71c2..6f5c2531abd0 100644 --- a/sound/pci/oxygen/virtuoso.c +++ b/sound/pci/oxygen/virtuoso.c @@ -47,7 +47,7 @@ * GPI 0 <- external power present * * GPIO 0 -> enable output to speakers - * GPIO 1 -> ? + * GPIO 1 -> enabl...
8d048841e822f745187246a036d03f2793739b7f
Analyze and fix the following issue in the Linux kernel code: [ALSA] snd_usb_caiaq: fix potential lockups locking
Problem Details: This patch fixes potential lockups in snd_usb_caiaq by refining the locking mechanims and by using usb_kill_urb() in favor to usb_unlink_urb(). Signed-off-by: Daniel Mack <daniel@caiaq.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/usb/caiaq/caiaq-audio.c b/sound/usb/caiaq/caiaq-audio.c index 9cc4cd8283f9..1aa927942cc6 100644 --- a/sound/usb/caiaq/caiaq-audio.c +++ b/sound/usb/caiaq/caiaq-audio.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006,2007 Daniel Mack, Karsten Wiese + * Copyright (c) 2006-2008 Daniel Mack, Karst...
8b45a209935c4b79905182608922736ba0e5579e
Analyze and fix the following issue in the Linux kernel code: [ALSA] sound: fix platform driver hotplug/coldplug
Problem Details: Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable sound platform drivers, to re-enable auto loading. [dbrownell@users.sourceforge.net: more drivers, registration fixes] Signed-off-by: Kay Sievers <kay.sievers@vr...
```diff diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c index 490729799e59..71fbf8d7ee82 100644 --- a/sound/arm/pxa2xx-ac97.c +++ b/sound/arm/pxa2xx-ac97.c @@ -424,6 +424,7 @@ static struct platform_driver pxa2xx_ac97_driver = { .resume = pxa2xx_ac97_resume, .driver = { .name = "pxa2xx-ac97", + ...
07f51a727462696ddea01c7a7750c27796a0e1f3
Analyze and fix the following issue in the Linux kernel code: [ALSA] sound/usb/usbaudio.c: coding style
Problem Details: Putting space between ! and variable is a strange coding style, fix that, also make it fit into 80 columns where that is easy. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index 26fb5769d951..7b3bcf1916d2 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -64,9 +64,10 @@ MODULE_SUPPORTED_DEVICE("{{Generic,USB Audio}}"); static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; /* Index 0-MAX */ static char *id[SND...
2a56f51bcc3650ecff806450f7fdab5edf57618f
Analyze and fix the following issue in the Linux kernel code: [ALSA] usb audio: make quirk handling more readable, and fix commented-out code
Problem Details: usb audio contains useful debugging code, protected by #if 0. Unfortunately, it will not compile because variable names changed; fix it. Dallas workaround is formatted in a way where it is not quite obvious what is normal code and what is quirk. Reformat it to make it obvious. Signed-off-by: Pavel M...
```diff diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index ff2e09a46133..26fb5769d951 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -1427,8 +1427,8 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt) subs->cur_audiofmt = fmt; #if 0 - printk("setting done:...
b9d43bcd061956c8144bcb453d07d13236b6ab28
Analyze and fix the following issue in the Linux kernel code: [ALSA] usb audio: Fix another Dallas quirk
Problem Details: Dallas USB speakers are buggy in more than one way. One of configs they offer does not work at all. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index 5c40c031dd57..ff2e09a46133 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -2676,12 +2676,23 @@ static int parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) int format; struct audioformat *fp; unsigned char *fmt, ...