id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
f08048e94564d009b19038cfbdd800aa83e79c7f | Analyze and fix the following issue in the Linux kernel code: libata: PCI device should be powered up before being accessed | Problem Details:
PCI device should be powered up or powered up before its PCI regsiters
are accessed. Although PCI configuration register access is allowed
in D3hot, PCI device is free to reset its status when transiting from
D3hot to D0 causing configuration data to change.
Many libata SFF drivers which use ata_pci_... | ```diff
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index 511a830b6256..3814aebefb2d 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -637,6 +637,11 @@ static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
const struct ata_port_info *ppi[] = { NULL, NULL };
... |
d96a51f6b8040ef2b25b88032f23ffdb1ddba681 | Analyze and fix the following issue in the Linux kernel code: cxgb3: Fix __must_check warning with dev_dbg. | Problem Details:
Fix the warning:
drivers/net/cxgb3/cxgb3_main.c: In function ‘offload_open’:
drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of
‘sysfs_create_group’, declared with attribute warn_unused_result
Now the return value is checked; if sysfs_create_group() returns failure,
a warning is pr... | ```diff
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index fd2e05bbb903..05e5f59e87fa 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -1014,8 +1014,8 @@ static int offload_open(struct net_device *dev)
adapter->port[0]->mtu : 0xffff);
init_smt... |
10e05f78c5566cb762ced12bf70307c60168d56e | Analyze and fix the following issue in the Linux kernel code: tc35815: Statistics cleanup | Problem Details:
On Sat, 12 Apr 2008 05:00:49 -0400, Jeff Garzik <jeff@garzik.org> wrote:
> applied 1-6
Thanks.
Could you apply this too, or hopufully fold into Andy Fleming's "phy:
Change mii_bus id field to a string" patch (commit c69fedae) ?
------------------------------------------------------
Subject: [PATCH] ... | ```diff
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index 744f11f5ffb8..10e4e85da3fc 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c
@@ -766,7 +766,8 @@ static int tc_mii_init(struct net_device *dev)
lp->mii_bus.name = "tc35815_mii_bus";
lp->mii_bus.read = tc_mdio_read;
lp->mii_bus.w... |
703bb99ca73aa38d3f200d4c7e9bb460dce35fda | Analyze and fix the following issue in the Linux kernel code: natsemi: fix MMIO for PPC 44x platforms | Problem Details:
The driver stores the PCI resource address into 'unsigned long' variable before
calling ioremap() on it. This warrants a kernel oops when the registers are
accessed on PPC 44x platforms which (being 32-bit) have PCI memory space mapped
beyond 4 GB.
The arch/ppc/ kernel has a fixup in ioremap() that c... | ```diff
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 900ab5d2ba70..46119bb3770a 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -786,7 +786,8 @@ static int __devinit natsemi_probe1 (struct pci_dev *pdev,
struct netdev_private *np;
int i, option, irq, chip_idx = ent->driver_data... |
56fb70932964927597ce30bbd820471633c72adc | Analyze and fix the following issue in the Linux kernel code: kgdb: fix SMP NMI kgdb_handle_exception exit race | Problem Details:
Fix the problem of protecting the kgdb handle_exception exit
which had an NMI race condition, while trying to restore
normal system operation.
There was a small window after the master processor sets cpu_in_debug
to zero but before it has set kgdb_active to zero where a
non-master processor in an SMP ... | ```diff
diff --git a/kernel/kgdb.c b/kernel/kgdb.c
index 85b7e5b934a7..4d1b3c232377 100644
--- a/kernel/kgdb.c
+++ b/kernel/kgdb.c
@@ -561,18 +561,6 @@ static void kgdb_wait(struct pt_regs *regs)
smp_wmb();
atomic_set(&cpu_in_kgdb[cpu], 1);
- /*
- * The primary CPU must be active to enter here, but this is
- * ... |
225a4424ade24e913c081d5a4c4bd71a0fe2e0ac | Analyze and fix the following issue in the Linux kernel code: kgdb: documentation fixes | Problem Details:
Minor cleanups to kgdb docs.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/Documentation/DocBook/kgdb.tmpl b/Documentation/DocBook/kgdb.tmpl
index 95e5f84cbf56..97618bed4d65 100644
--- a/Documentation/DocBook/kgdb.tmpl
+++ b/Documentation/DocBook/kgdb.tmpl
@@ -152,9 +152,10 @@
<para>
The kgdboc driver was originally an abbreviation meant to stand for
"kgdb over c... |
4a1b5502d426df09b9ba1cbcc74fd09702a74cd8 | Analyze and fix the following issue in the Linux kernel code: kgdb: Kconfig fix | Problem Details:
ERROR: "uart_parse_options" [drivers/serial/serial_core.ko] undefined!
Cc: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 4d7eecbead9b..c32c1ca75f63 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -1771,7 +1771,7 @@ static int uart_read_proc(char *page, char **start, off_t off,
}
#endif
-#ifdef CONFIG_SERIAL_CORE_CONS... |
737a460f21febe551ff1d2299b63bae9b154078f | Analyze and fix the following issue in the Linux kernel code: kgdb: fix several kgdb regressions | Problem Details:
kgdb core fixes:
- Check to see that mm->mmap_cache is not null before calling
flush_cache_range(), else on arch=ARM it will cause a fatal
fault.
- Breakpoints should only be restored if they are in the BP_ACTIVE
state.
- Fix a typo in comments to "kgdb_register_io_module"
x86 kgdb fixes:
- Fi... | ```diff
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index 7d651adcb222..8c7e555f6d39 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -370,6 +370,8 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
ptr = &remcomInBuffer[1];
if (kgdb_hex2long(&ptr, &addr))... |
b4b8ac524d9b6ed7229017145afa1d7afbea4a48 | Analyze and fix the following issue in the Linux kernel code: kgdb: fix optional arch functions and probe_kernel_* | Problem Details:
Fix two regressions dealing with the kgdb core.
1) kgdb_skipexception and kgdb_post_primary_code are optional
functions that are only required on archs that need special exception
fixups.
2) The kernel address space scope must be set on any probe_kernel_*
function or archs such as ARCH=arm will not a... | ```diff
diff --git a/kernel/kgdb.c b/kernel/kgdb.c
index 68aea78407e4..31425e0fbf20 100644
--- a/kernel/kgdb.c
+++ b/kernel/kgdb.c
@@ -200,6 +200,17 @@ int __weak kgdb_arch_init(void)
return 0;
}
+int __weak kgdb_skipexception(int exception, struct pt_regs *regs)
+{
+ return 0;
+}
+
+void __weak
+kgdb_post_primary... |
64e9ee3095b61d0300ea548216a57d2536611309 | Analyze and fix the following issue in the Linux kernel code: kgdb: add x86 HW breakpoints | Problem Details:
Add HW breakpoints into the arch specific portion of x86 kgdb. In the
current x86 kernel.org kernels HW breakpoints are changed out in lazy
fashion because there is no infrastructure around changing them when
changing to a kernel task or entering the kernel mode via a system
call. This lazy approach ... | ```diff
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index 5d7a21119bf8..7d651adcb222 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -182,6 +182,122 @@ void gdb_regs_to_pt_regs(unsigned long *gdb_regs, struct pt_regs *regs)
#endif
}
+static struct hw_breakpoint {
+ unsigned ena... |
d359752407f8916c29ad53a5c30ac73e338f2797 | Analyze and fix the following issue in the Linux kernel code: kgdb: fix NMI hangs | Problem Details:
This patch fixes the hang regression with kgdb when the NMI interrupt
comes in while the master core is returning from an exception.
Adjust the NMI logic such that KGDB will not stop NMI exceptions from
occurring by in general returning NOTIFY_DONE. It is not possible to
distinguish the debug NMI syn... | ```diff
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index 37194d6374d8..5d7a21119bf8 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -41,6 +41,7 @@
#include <linux/kgdb.h>
#include <linux/init.h>
#include <linux/smp.h>
+#include <linux/nmi.h>
#include <asm/apicdef.h>
#include... |
c191e5ad6b3fd8cc84b2b6d62c02fcd6837c8a8f | Analyze and fix the following issue in the Linux kernel code: kgdb: fix kgdboc dynamic module configuration | Problem Details:
Fix the run time configuration of kgdboc such that it does not default
to 9600 baud if you use the "echo" command to configure the sysfs
module paramater.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/drivers/serial/kgdboc.c b/drivers/serial/kgdboc.c
index 341830791608..9cf03327386a 100644
--- a/drivers/serial/kgdboc.c
+++ b/drivers/serial/kgdboc.c
@@ -106,7 +106,9 @@ static void kgdboc_put_char(u8 chr)
static int param_set_kgdboc_var(const char *kmessage, struct kernel_param *kp)
{
- if (st... |
f2d937f3bf00665ccf048b3b6616ef95859b0945 | Analyze and fix the following issue in the Linux kernel code: consoles: polling support, kgdboc | Problem Details:
polled console handling support, to access a console in an irq-less
way while in debug or irq context.
absolutely zero impact as long as CONFIG_CONSOLE_POLL is disabled.
(which is the default)
[ jan.kiszka@siemens.com: lots of cleanups ]
[ mingo@elte.hu: redesign, splitups, cleanups. ]
Signed-off-by... | ```diff
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index 613ec816ce60..4d3c7018f0c3 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -1155,6 +1155,48 @@ static struct tty_driver *get_tty_driver(dev_t device, int *index)
return NULL;
}
+#ifdef CONFIG_CONSOLE_POLL
+
+/**
+ * tty_find... |
17b7a8de3bf1eb2cba14d5c8d919e55d511d8a71 | Analyze and fix the following issue in the Linux kernel code: [SCSI] libsas: fix endianness bug in sas_ata | Problem Details:
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index b0e5ac372a32..06ad2fa3fa4c 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -698,7 +698,7 @@ static int sas_discover_sata_dev(struct domain_device *dev)
/* incomplete response */
SAS_DPRINTK("... |
ee95a16d3950367d32beb6ffed287666631dbda9 | Analyze and fix the following issue in the Linux kernel code: [SCSI] zfcp: fix compiler warning caused by poking inside new semaphore (linux-next) | Problem Details:
as seen in linux-next tree:
drivers/s390/scsi/zfcp_dbf.c: In function ‘zfcp_rec_dbf_event_thread’:
drivers/s390/scsi/zfcp_dbf.c:697: warning: passing argument 1 of ‘atomic_read’
from incompatible pointer type
Caused by recent git commit:
commit 348447e85749120ad600a5c8e23b6bb7058b931d
Author: Marti... | ```diff
diff --git a/drivers/s390/scsi/zfcp_dbf.c b/drivers/s390/scsi/zfcp_dbf.c
index 85ba4cc4190e..c34a874482a5 100644
--- a/drivers/s390/scsi/zfcp_dbf.c
+++ b/drivers/s390/scsi/zfcp_dbf.c
@@ -623,7 +623,6 @@ static int zfcp_rec_dbf_view_format(debug_info_t *id, struct debug_view *view,
zfcp_dbf_out(&p, "id", "%d",... |
1017be88d341c05adc8d790d8092781b7330dafd | Analyze and fix the following issue in the Linux kernel code: [ARM] 4985/1: S3C2412: Fix ARMDIVN name in CLKDIVN definition. | Problem Details:
Fix the name of the S3C2412_CLKDIVN_ARMDIVN define.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/mach-s3c2412/s3c2412.c b/arch/arm/mach-s3c2412/s3c2412.c
index abf1599c9f97..98a0de924c22 100644
--- a/arch/arm/mach-s3c2412/s3c2412.c
+++ b/arch/arm/mach-s3c2412/s3c2412.c
@@ -175,7 +175,7 @@ void __init s3c2412_init_clocks(int xtal)
/* work out clock scalings */
hclk = fclk / ((tmp... |
f49688d459c5eaa62db3597cbfd3cb13e361d415 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/acpi/sleep.c | Problem Details:
Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index 6bc815cd8cb3..dd78326ae47c 100644
--- a/arch/x86/kernel/acpi/sleep.c
+++ b/arch/x86/kernel/acpi/sleep.c
@@ -13,7 +13,7 @@
#include <asm/smp.h>
/* address in low memory of the wakeup routine. */
-unsigned long acpi_wakeup_address ... |
e223f162a1d37aeeaa6c1ee37d81cc084aa2b004 | Analyze and fix the following issue in the Linux kernel code: x86: setup_trampoline() - fix section mismatch warning | Problem Details:
this patch fixes section mismatch warnings (on x86_64 host) in setup_trampoline(),
which was referencing __initdata variables trampoline_data and trampoline_end.
Warning messages:
WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x2b6a): Section mismatch in reference from the function setup_trampolin... | ```diff
diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
index 4aedd0bcee4c..2a07e67d6697 100644
--- a/arch/x86/kernel/trampoline_64.S
+++ b/arch/x86/kernel/trampoline_64.S
@@ -32,7 +32,7 @@
/* We can free up trampoline after bootup if cpu hotplug is not supported. */
#ifndef CONFIG_HO... |
df96323dfaebdf7e17cdf0656096e6ab2158ec76 | Analyze and fix the following issue in the Linux kernel code: x86: section mismatch fixes, #1 | Problem Details:
This patch fixes mismatch warnings in smp_checks() (in arch/x86/kernel/smpboot.c):
WARNING: arch/x86/kernel/built-in.o(.text+0x11922): Section mismatch in reference from the function smp_checks()
to the variable .cpuinit.data:smp_b_stepping
The function smp_checks() references
the variable __cpuinitda... | ```diff
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 4517d1c01eb5..ca3929b16049 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -437,7 +437,7 @@ valid_k7:
#endif
}
-void smp_checks(void)
+void __cpuinit smp_checks(void)
{
if (smp_b_stepping)
printk(KERN_WA... |
63d38198a0f57dca87e6cb79931c7bedbb7ab069 | Analyze and fix the following issue in the Linux kernel code: x86: fix paranoia about using BIOS quickboot mechanism. | Problem Details:
> > Make sure that we clear the "shutdown status flag" in the CMOS
> > register after each CPU is brought up. This fixes a problem where the
> > "shutdown status flag" may remain set when a CPU is brought up after
> > booting.
>
> btw., what problem does this result in, exactly?
The shutdown status f... | ```diff
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 21ad3f396a05..4517d1c01eb5 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1001,6 +1001,11 @@ do_rest:
/* mark "stuck" area as not stuck */
*((volatile unsigned long *)trampoline_base) = 0;
+ /*
+ * Cleanu... |
ba1ce61ff226bddebd2101a29fe56b4664ef7cec | Analyze and fix the following issue in the Linux kernel code: x86: don't set io apic features if io-apic is not enabled, fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/mpparse_32.c b/arch/x86/kernel/mpparse_32.c
index 09cb77813680..44f52f623fd6 100644
--- a/arch/x86/kernel/mpparse_32.c
+++ b/arch/x86/kernel/mpparse_32.c
@@ -429,9 +429,9 @@ static int __init smp_read_mpc(struct mp_config_table *mpc)
struct mpc_config_ioapic *m=
(struct m... |
f408b43ceedce49f26c01cd4a68dbbdbe2743e51 | Analyze and fix the following issue in the Linux kernel code: x86: fix VisualWS and Voyager kexec build failures | Problem Details:
without this patch:
VOYAGER:
kernel/built-in.o: In function `crash_kexec':
(.text+0x28588): undefined reference to `machine_crash_shutdown'
VISWS:
kernel/built-in.o: In function `crash_kexec':
/next-20080401/kernel/kexec.c:1074: undefined reference to `machine_crash_shutdown'
make[1]: *** [.tmp_vmlin... | ```diff
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index a0d7406e8b37..0a7193ae45ed 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1121,6 +1121,7 @@ source kernel/Kconfig.hz
config KEXEC
bool "kexec system call"
+ depends on X86_64 || X86_BIOS_REBOOT
help
kexec is a system call that implement... |
431ef7a2a486201967304fcc9cfc33e945626fed | Analyze and fix the following issue in the Linux kernel code: x86: debug Store - call kfree if only we really need it | Problem Details:
We should call for kfree if only we really need it.
Though it's safe to call kfree with NULL pointer passed
in this code we've already tested the pointer and can
eliminate the call
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/ds.c b/arch/x86/kernel/ds.c
index dcd918c1580d..11c11b8ec48d 100644
--- a/arch/x86/kernel/ds.c
+++ b/arch/x86/kernel/ds.c
@@ -220,11 +220,11 @@ int ds_allocate(void **dsp, size_t bts_size_in_bytes)
int ds_free(void **dsp)
{
- if (*dsp)
+ if (*dsp) {
kfree((void *)get_bts_buff... |
f5149a49f994e5c469ac398af7cdeb8eb612d3a4 | Analyze and fix the following issue in the Linux kernel code: x86: support for new UV apic, fix | Problem Details:
Yinghai Lu pointed out a bug in the previous patches,
fix double-shift of apicid.
Signed-off-by: Jack Steiner <steiner@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/genapic_64.c b/arch/x86/kernel/genapic_64.c
index 910a4a777a4c..c9eabe36ee36 100644
--- a/arch/x86/kernel/genapic_64.c
+++ b/arch/x86/kernel/genapic_64.c
@@ -95,8 +95,6 @@ unsigned int read_apic_id(void)
id = apic_read(APIC_ID);
if (uv_system_type >= UV_X2APIC)
id |= __get_c... |
a24eae88ad3767d0a4a940a10e4a9cec849b7778 | Analyze and fix the following issue in the Linux kernel code: x86: uv fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/asm-x86/smp.h b/include/asm-x86/smp.h
index b35566264879..654724c58f5b 100644
--- a/include/asm-x86/smp.h
+++ b/include/asm-x86/smp.h
@@ -174,7 +174,7 @@ static inline int logical_smp_processor_id(void)
return GET_APIC_LOGICAL_ID(*(u32 *)(APIC_BASE + APIC_LDR));
}
-#ifdef CONFIG_X86_32... |
6093015db2bd9e70cf20cdd23be1a50733baafdd | Analyze and fix the following issue in the Linux kernel code: x86: cleanup replace most vm86 flags with flags from processor-flags.h, fix | Problem Details:
- fix build error
- fix CONFIG_HEADERS_CHECK error
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/traps_32.c b/arch/x86/kernel/traps_32.c
index 57a5704e3f6c..3284502a1bf8 100644
--- a/arch/x86/kernel/traps_32.c
+++ b/arch/x86/kernel/traps_32.c
@@ -959,7 +959,7 @@ debug_vm86:
clear_TF_reenable:
set_tsk_thread_flag(tsk, TIF_SINGLESTEP);
- regs->flags &= ~TF_MASK;
+ regs->flag... |
e937fcf2fa0c1d21f9c0008ab600d46c240a984c | Analyze and fix the following issue in the Linux kernel code: x86: mpparse: 64-bit fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/mpparse_64.c b/arch/x86/kernel/mpparse_64.c
index d62294003036..5e789bdb34fa 100644
--- a/arch/x86/kernel/mpparse_64.c
+++ b/arch/x86/kernel/mpparse_64.c
@@ -63,6 +63,20 @@ void *x86_bios_cpu_apicid_early_ptr;
DEFINE_PER_CPU(u16, x86_bios_cpu_apicid) = BAD_APICID;
EXPORT_PER_CPU_S... |
fe176de0ffdc2dd300fbcece84434a32b482b5b1 | Analyze and fix the following issue in the Linux kernel code: x86: microcode: show results on success too | Problem Details:
Report when microcode was successfully updated. It used to be there but
now with DEBUG unset it becomes very silent. Also some cosmetic fixes.
Signed-off-by: Ben Castricum <lk08@bencastricum.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
index f2702d01b8a8..25cf6dee4e56 100644
--- a/arch/x86/kernel/microcode.c
+++ b/arch/x86/kernel/microcode.c
@@ -290,7 +290,7 @@ static int get_maching_microcode(void *mc, int cpu)
}
return 0;
find:
- pr_debug("microcode: CPU %d found a ... |
86c9835b46605fb29a3c30c6cc344d9df49e54a3 | Analyze and fix the following issue in the Linux kernel code: x86: mpparse, move generic processor info to apic_32.c fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/asm-x86/mpspec.h b/include/asm-x86/mpspec.h
index 7ee54d396d60..31bac12a97d1 100644
--- a/include/asm-x86/mpspec.h
+++ b/include/asm-x86/mpspec.h
@@ -1,6 +1,8 @@
#ifndef _AM_X86_MPSPEC_H
#define _AM_X86_MPSPEC_H
+#include <linux/init.h>
+
#include <asm/mpspec_def.h>
#ifdef CONFIG_X8... |
fae9811b775655a02dcb51fa0b6423b546468bd1 | Analyze and fix the following issue in the Linux kernel code: x86: mpparse, move boot cpu physical apicid to apic_32.c, fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/mpparse_32.c b/arch/x86/kernel/mpparse_32.c
index 9143810bb637..9b61b50a96c9 100644
--- a/arch/x86/kernel/mpparse_32.c
+++ b/arch/x86/kernel/mpparse_32.c
@@ -65,8 +65,10 @@ int pic_mode;
#ifndef CONFIG_X86_SMP
unsigned int num_processors;
unsigned disabled_cpus __cpuinitdata;
+#i... |
059c9640b57cb8e70c60de141ec817b450431816 | Analyze and fix the following issue in the Linux kernel code: x86: mpparse, move disabled cpus to smpboot.c, fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/mpparse_32.c b/arch/x86/kernel/mpparse_32.c
index bf29dcc37de7..0f877a572cf0 100644
--- a/arch/x86/kernel/mpparse_32.c
+++ b/arch/x86/kernel/mpparse_32.c
@@ -196,7 +196,9 @@ static void __cpuinit MP_processor_info(struct mpc_config_processor *m)
int apicid;
if (!(m->mpc_cpufla... |
756a6c68556600aec9460346332884d891d5beb4 | Analyze and fix the following issue in the Linux kernel code: x86: ioremap of 64-bit resource on 32-bit kernel fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 7338c5d3dd37..c590fd200e29 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -47,7 +47,7 @@ static inline int phys_addr_valid(unsigned long addr)
int page_is_ram(unsigned long pagenr)
{
- unsigned long addr, end;
+ resource_siz... |
15a601eb9cdc2a9cc69d5fc745317805a85c064c | Analyze and fix the following issue in the Linux kernel code: x86: fix test_poke for vmalloced pages | Problem Details:
* Ingo Molnar (mingo@elte.hu) wrote:
>
> * Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
>
> > The shadow vmap for DEBUG_RODATA kernel text modification uses
> > virt_to_page to get the pages from the pointer address.
> >
> > However, I think vmalloc_to_page would be required in case the page... | ```diff
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 0c92ad4d257a..df4099dc1c68 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -515,7 +515,7 @@ void *__kprobes text_poke(void *addr, const void *opcode, size_t len)
BUG_ON(len > sizeof(long));
BUG... |
d93c870bad38e8daaaf9f7e900a13431f24becbb | Analyze and fix the following issue in the Linux kernel code: x86: only enable interrupts when kernel state has been set up | Problem Details:
The sysenter path tries to enable interrupts immediately. Unfortunately
this doesn't work in a paravirt environment, because not enough kernel
state has been set up at that point (namely, pointing %fs to the kernel
percpu data segment). To fix this, defer ENABLE_INTERRUPTS until after
the kernel stat... | ```diff
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 4b87c32b639f..a664d5726d8d 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -291,10 +291,10 @@ ENTRY(ia32_sysenter_target)
movl TSS_sysenter_sp0(%esp),%esp
sysenter_past_esp:
/*
- * No need to follow this... |
f461f1372cef1853534df2115f9ff5b7fbfc6958 | Analyze and fix the following issue in the Linux kernel code: include/asm-x86/kdebug.h: checkpatch cleanups - formatting only | Problem Details:
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/asm-x86/kdebug.h b/include/asm-x86/kdebug.h
index 99dcbafa1511..0c4175390dab 100644
--- a/include/asm-x86/kdebug.h
+++ b/include/asm-x86/kdebug.h
@@ -23,12 +23,12 @@ enum die_val {
};
extern void printk_address(unsigned long address, int reliable);
-extern void die(const char *,struct p... |
86d8a08616ecbc510323bfca591816a5709c6e54 | Analyze and fix the following issue in the Linux kernel code: include/asm-x86/bug.h: checkpatch cleanups - formatting only | Problem Details:
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/asm-x86/bug.h b/include/asm-x86/bug.h
index 8d477a201392..b69aa64b82a4 100644
--- a/include/asm-x86/bug.h
+++ b/include/asm-x86/bug.h
@@ -12,25 +12,25 @@
# define __BUG_C0 "2:\t.quad 1b, %c0\n"
#endif
-#define BUG() \
- do { \
- asm volatile("1:\tud2\n" \
- ".pu... |
d3463c5a66147bdd21b5865ea29fdca50ea28f7f | Analyze and fix the following issue in the Linux kernel code: undo "x86: fix breakage of vSMP irq operations" | Problem Details:
revert:
"x86: fix breakage of vSMP irq operations"
the irqflags.h unification will solve this in a cleaner way.
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/asm-x86/irqflags.h b/include/asm-x86/irqflags.h
index 0e2292483b35..92021c1ffa3a 100644
--- a/include/asm-x86/irqflags.h
+++ b/include/asm-x86/irqflags.h
@@ -70,26 +70,6 @@ static inline void raw_local_irq_restore(unsigned long flags)
native_restore_fl(flags);
}
-#ifdef CONFIG_X86_VSMP... |
dcfe946520719943fabd3e5ed13813956e48e37c | Analyze and fix the following issue in the Linux kernel code: x86: fix memtest print out | Problem Details:
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index ae225c3ae9a8..210243e94d84 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -473,7 +473,7 @@ static void __init memtest(unsigned long start_phys, unsigned long size,
last_bad += incr;
} else {
if (start_bad) {
- ... |
9b967106da0357ef8b08847dce35584a04134f20 | Analyze and fix the following issue in the Linux kernel code: x86: fix smpboot integration | Problem Details:
> yhlu@mpk:~/xx/xx/kernel/x86/linux-2.6> git-bisect bad
> d1c707188ad646c8094cac9afb1738e7d0196ff2 is first bad commit
> commit d1c707188ad646c8094cac9afb1738e7d0196ff2
> Author: Glauber de Oliveira Costa <gcosta@redhat.com>
> Date: Wed Mar 19 14:25:53 2008 -0300
>
> x86: include mach_apic.h... | ```diff
diff --git a/include/asm-x86/mach-default/mach_apicdef.h b/include/asm-x86/mach-default/mach_apicdef.h
index 7b78275e6d33..e4b29ba37de6 100644
--- a/include/asm-x86/mach-default/mach_apicdef.h
+++ b/include/asm-x86/mach-default/mach_apicdef.h
@@ -5,13 +5,12 @@
#ifdef CONFIG_X86_64
#define APIC_ID_MASK (0xF... |
709f744f18ebc3a810d29c8d5502bf20c3cecc70 | Analyze and fix the following issue in the Linux kernel code: x86: bitops asm constraint fixes | Problem Details:
This (simplified) piece of code didn't behave as expected due to
incorrect constraints in some of the bitops functions, when
X86_FEATURE_xxx is referring to other than the first long:
int test(struct cpuinfo_x86 *c) {
if (cpu_has(c, X86_FEATURE_xxx))
clear_cpu_cap(c, X86_FEATURE_xxx);
return cpu_h... | ```diff
diff --git a/include/asm-x86/bitops.h b/include/asm-x86/bitops.h
index 1a23ce1a5697..7a76555b676a 100644
--- a/include/asm-x86/bitops.h
+++ b/include/asm-x86/bitops.h
@@ -24,9 +24,12 @@
/* Technically wrong, but this avoids compilation errors on some gcc
versions. */
#define ADDR "=m" (*(volatile long *) ... |
6e908947b4995bc0e551a8257c586d5c3e428201 | Analyze and fix the following issue in the Linux kernel code: x86: fix ioapic bug again | Problem Details:
un-revert:
commit 4960c9df1407c2723459c60ff13e6efe0c209c62
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue Jan 22 10:23:01 2008 +0100
Revert "x86: fix NMI watchdog & 'stopped time' problem"
This reverts commit d4d25deca49ec2527a634557bf5a6cf449f85deb.
needs a proper fix th... | ```diff
diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c
index 742fab45e1c6..8ed6eb967652 100644
--- a/arch/x86/kernel/io_apic_32.c
+++ b/arch/x86/kernel/io_apic_32.c
@@ -2124,10 +2124,14 @@ static inline void __init check_timer(void)
{
int apic1, pin1, apic2, pin2;
int vector;
+ unsigned i... |
f2e576b8141ec1cf2669ff7bbc92f0a9c147f34f | Analyze and fix the following issue in the Linux kernel code: i386: arch/x86/math-emu/reg_ld_str.c: fix warning | Problem Details:
arch/x86/math-emu/reg_ld_str.c:380: warning: 'l[0]' may be used uninitialized in this function
arch/x86/math-emu/reg_ld_str.c:380: warning: 'l[1]' may be used uninitialized in this function
I can't actually spot the bug here. There's one obvious place, but fixing
that didn't shut the warning up.
Cc:... | ```diff
diff --git a/arch/x86/math-emu/reg_ld_str.c b/arch/x86/math-emu/reg_ld_str.c
index 799d4af5be66..02af772a24db 100644
--- a/arch/x86/math-emu/reg_ld_str.c
+++ b/arch/x86/math-emu/reg_ld_str.c
@@ -383,15 +383,15 @@ int FPU_store_double(FPU_REG *st0_ptr, u_char st0_tag, double __user *dfloat)
int exp;
FPU_REG ... |
cc7594e420283cf6070538655f1a4fbebb3fb853 | Analyze and fix the following issue in the Linux kernel code: i386: arch/x86/math-emu/fpu_entry.c warning fix | Problem Details:
arch/x86/math-emu/fpu_entry.c:555: warning: 'entry_sel_off.empty' is used uninitialized in this function
Presumably it's harmless, but I'll sleep better at night knowing that we
initialised it.
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Mo... | ```diff
diff --git a/arch/x86/math-emu/fpu_entry.c b/arch/x86/math-emu/fpu_entry.c
index 760baeea5f07..4bab3b145392 100644
--- a/arch/x86/math-emu/fpu_entry.c
+++ b/arch/x86/math-emu/fpu_entry.c
@@ -276,6 +276,7 @@ asmlinkage void math_emulate(long arg)
entry_sel_off.offset = FPU_ORIG_EIP;
entry_sel_off.selector = ... |
b450e5e816d10893e17f57b3eb9d29c52635862a | Analyze and fix the following issue in the Linux kernel code: x86: PAT bug fix for attribute type check after reserve_memtype, debug | Problem Details:
Make the PAT related printks in ioremap pr_debug.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 3f7f05e2c434..7338c5d3dd37 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -167,7 +167,7 @@ static void __iomem *__ioremap(resource_size_t phys_addr, unsigned long size,
retval = reserve_memtype(phys_addr, phys_addr + size,
... |
dee7cbb210fdd266ad81af4689bcbac3649f38ff | Analyze and fix the following issue in the Linux kernel code: x86: PAT bug fix for attribute type check after reserve_memtype | Problem Details:
Bug fixes for reserve_memtype() call in __ioremap and pci_mmap_page_range().
If reserve_memtype returns non-zero, then it is an error and subsequent free is
not required. Requested and returned prot value check should be done when
reserve_memtype returns success.
Signed-off-by: Venkatesh Pallipadi <ve... | ```diff
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 6cd3418afe71..3f7f05e2c434 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -124,6 +124,7 @@ static void __iomem *__ioremap(resource_size_t phys_addr, unsigned long size,
struct vm_struct *area;
unsigned long new_prot_val;
p... |
a7c7d0e91daebd7c5e51f9416d612b6a15e7e79a | Analyze and fix the following issue in the Linux kernel code: x86: tom2 warning fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
index 74ec2ea4ed3e..353efe4f5017 100644
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -251,8 +251,10 @@ void __init get_mtrr_state(void)
else
printk(KERN_INFO "MTRR %u disabled\n"... |
52783fa8d6b847857fdd86df418e09c026d816f5 | Analyze and fix the following issue in the Linux kernel code: x86: PAT fix | Problem Details:
build fix for !CONFIG_MTRR.
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/asm-x86/mtrr.h b/include/asm-x86/mtrr.h
index 968794af93f9..ee172296e056 100644
--- a/include/asm-x86/mtrr.h
+++ b/include/asm-x86/mtrr.h
@@ -84,10 +84,9 @@ struct mtrr_gentry
#ifdef __KERNEL__
-extern u8 mtrr_type_lookup(u64 addr, u64 end);
-
/* The following functions are for use b... |
042b78e4dbb8919a59e77ba5d502a5a14405dea1 | Analyze and fix the following issue in the Linux kernel code: x86: PAT infrastructure patch, documentation updates | Problem Details:
Fix double help section in PAT Kconfig. Thanks to Randy Dunlap for catching
this bug.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5b46756e4c7c..629923126653 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1015,12 +1015,12 @@ config X86_PAT
depends on MTRR && NONPROMISC_DEVMEM
help
Use PAT attributes to setup page level cache control.
- ---help---
+
PATs are the mo... |
6997ab4982a29925e79f72c3a59823cf944c3529 | Analyze and fix the following issue in the Linux kernel code: x86: add PAT related debug prints | Problem Details:
Adds debug prints at critical code. Adds enough info in dmesg to allow us to
do effective first round of analysis of any issues that may result due to PAT
patch series.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-of... | ```diff
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 51cd3956c564..6cd3418afe71 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -131,7 +131,7 @@ static void __iomem *__ioremap(resource_size_t phys_addr, unsigned long size,
return NULL;
if (!phys_addr_valid(phys_addr)) {
- p... |
48ee679a02406c65ced67c3951ad19744eb21083 | Analyze and fix the following issue in the Linux kernel code: x86: ia32 ptrace vs -ENOSYS sysenter/syscall | Problem Details:
The previous "x86_64 ia32 ptrace vs -ENOSYS" fix only covered
the int $0x80 system call entries. This does the same fix
for the sysenter and syscall instruction paths.
Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index 30f492934f23..ae7158bce4d6 100644
--- a/arch/x86/ia32/ia32entry.S
+++ b/arch/x86/ia32/ia32entry.S
@@ -162,12 +162,14 @@ sysenter_tracesys:
SAVE_REST
CLEAR_RREGS
movq %r9,R9(%rsp)
- movq $-ENOSYS,RAX(%rsp) /* really needed? */
+ movq ... |
8ab32bb89b5b9bf06147c31947eba65f0f21c3c0 | Analyze and fix the following issue in the Linux kernel code: x86: ia32 ptrace vs -ENOSYS | Problem Details:
When we're stopped at syscall entry tracing, ptrace can change the %eax
value from -ENOSYS to something else. If no system call is actually made
because the syscall number (now in orig_eax) is bad, then the %eax value
set by ptrace should be returned to the user. But, instead it gets reset
to -ENOSYS... | ```diff
diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index 8022d3c695c0..30f492934f23 100644
--- a/arch/x86/ia32/ia32entry.S
+++ b/arch/x86/ia32/ia32entry.S
@@ -325,7 +325,7 @@ ENTRY(ia32_syscall)
jnz ia32_tracesys
ia32_do_syscall:
cmpl $(IA32_NR_syscalls-1),%eax
- ja ia32_badsys
+ ja int_... |
6542fe80e6296cde50c1c3b8a9eede701ee51907 | Analyze and fix the following issue in the Linux kernel code: x86: vsmp fix x86 vsmp fix is vsmp box cleanup | Problem Details:
code got a bit smaller:
arch/x86/kernel/vsmp_64.o:
text data bss dec hex filename
205 4 0 209 d1 vsmp_64.o.before
181 4 0 185 b9 vsmp_64.o.after
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/vsmp_64.c b/arch/x86/kernel/vsmp_64.c
index 13bd82453e4b..1e9a791dbe39 100644
--- a/arch/x86/kernel/vsmp_64.c
+++ b/arch/x86/kernel/vsmp_64.c
@@ -120,10 +120,8 @@ int is_vsmp_box(void)
return vsmp;
/* Check if we are running on a ScaleMP vSMP box */
- if ((read_pci_config_16(... |
aa7d8e25eca5deb33eb08013bc78a80514349b40 | Analyze and fix the following issue in the Linux kernel code: x86: fix build breakage when PCI is define and PARAVIRT is not | Problem Details:
- Fix the the build breakage when PARAVIRT is defined
but PCI is not
This fixes problem reported at:
http://marc.info/?l=linux-kernel&m=120525966600698&w=2
- Make is_vsmp_box() available even when PARAVIRT is not defined.
This is needed to determine if tsc's are reliable as a time source
even ... | ```diff
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
index d5a05a0cef62..1fe841a86f7e 100644
--- a/arch/x86/kernel/Makefile
+++ b/arch/x86/kernel/Makefile
@@ -60,7 +60,7 @@ obj-$(CONFIG_KEXEC) += relocate_kernel_$(BITS).o crash.o
obj-$(CONFIG_CRASH_DUMP) += crash_dump_$(BITS).o
obj-$(CONFIG_X86_N... |
3250c91ada16a06de5afef55bce7b766c894d75c | Analyze and fix the following issue in the Linux kernel code: x86: vSMP: Fix is_vsmp_box() | Problem Details:
is_vsmp_box() currently does not work on vSMPowered systems, as pci cfg
space is not read correctly -- This patch fixes it.
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/vsmp_64.c b/arch/x86/kernel/vsmp_64.c
index a00961d42e75..eb25584c54c3 100644
--- a/arch/x86/kernel/vsmp_64.c
+++ b/arch/x86/kernel/vsmp_64.c
@@ -84,8 +84,10 @@ int is_vsmp_box(void)
return vsmp;
/* Check if we are running on a ScaleMP vSMP box */
- if (read_pci_config(0, 0x1... |
f6bc40290964b5fcb48c226ccafa4b7536d62663 | Analyze and fix the following issue in the Linux kernel code: x86: include mach_apic.h in smpboot_64.c and smpboot.c | Problem Details:
After the inclusion, a lot of files needs fixing for conflicts,
some of them in the headers themselves, to accomodate for both
i386 and x86_64 versions.
[ mingo@elte.hu: build fix ]
Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 2cdc9de9371d..956b60f3ebd5 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -40,6 +40,10 @@
#include <asm/io.h>
#include <asm/mpspec.h>
+#ifdef CONFIG_X86_LOCAL_APIC
+# include <mach_apic.h>
+#endif
+
... |
e481fcf8563d300e7f8875cae5fdc41941d29de0 | Analyze and fix the following issue in the Linux kernel code: x86: calibrate delay with irqs enabled | Problem Details:
We do it to make it close to x86_64. The later needs it,
otherwise the nmi watchdog can get into the scene and kill us
with a hammer.
Enabling irqs here used to trigger a bug in i386. This is because
time irq handling relies upon structures that are only initialized
after smp initcalls (More precisely... | ```diff
diff --git a/arch/x86/kernel/smpboot_32.c b/arch/x86/kernel/smpboot_32.c
index dbfaeb30a69a..bd2f8863efa2 100644
--- a/arch/x86/kernel/smpboot_32.c
+++ b/arch/x86/kernel/smpboot_32.c
@@ -167,7 +167,9 @@ static void __cpuinit smp_callin(void)
/*
* Get our bogomips.
*/
+ local_irq_enable();
calibrate_de... |
eb44d0a2a9c4d64ed89044fcf1f75e6a27c42ea7 | Analyze and fix the following issue in the Linux kernel code: x86: include smpboot_hooks.h in smpboot_64.c | Problem Details:
We do it and also fix conflicts, which makes x86_64 automatically
closer to i386
Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c
index c6c993f4c415..b9384b3af017 100644
--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -61,6 +61,7 @@
#include <asm/numa.h>
#include <mach_wakecpu.h>
+#include <smpboot_hooks.h>
/* Set when the idlers are a... |
8d77010f8c93b4d41ffd71c7ad9d07fc1668cd5a | Analyze and fix the following issue in the Linux kernel code: x86: include mach_wakecpu.h in smpboot_64 | Problem Details:
Do it and also fix conflicts, which automatically makes
x86_64 look closer to i386
Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c
index c3e770b0094b..c6c993f4c415 100644
--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -60,6 +60,8 @@
#include <asm/hw_irq.h>
#include <asm/numa.h>
+#include <mach_wakecpu.h>
+
/* Set when the idlers are all ... |
1161705bd66df0c80fa45e87190e456c02e6f145 | Analyze and fix the following issue in the Linux kernel code: x86: fill cpu to apicid and present map in mpparse, fix | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/mpparse_32.c b/arch/x86/kernel/mpparse_32.c
index a0cec74b80ef..000b51b78fbd 100644
--- a/arch/x86/kernel/mpparse_32.c
+++ b/arch/x86/kernel/mpparse_32.c
@@ -75,6 +75,10 @@ unsigned disabled_cpus __cpuinitdata;
/* Bitmask of physically existing CPUs */
physid_mask_t phys_cpu_prese... |
fbac7fcbadc54cc5d374873a2e60e924a056d198 | Analyze and fix the following issue in the Linux kernel code: x86: fix alloc_bootmem_pages_node macro | Problem Details:
missing a semicolon
Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/asm-x86/mmzone_32.h b/include/asm-x86/mmzone_32.h
index 274a59566c45..b9f5be2f603b 100644
--- a/include/asm-x86/mmzone_32.h
+++ b/include/asm-x86/mmzone_32.h
@@ -129,7 +129,7 @@ static inline int pfn_valid(int pfn)
struct pglist_data __maybe_unused \
*__alloc_bootmem_node__pgdat =... |
b552da8740222c35bcd83c9be7b27185bfb6d53c | Analyze and fix the following issue in the Linux kernel code: x86 iommu: add more documentation | Problem Details:
Fix coding style in pci-dma_64.c and add stubs for documentation. I
hope someone fills the rest, I understand maybe off and soft...
Signed-off-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index dafd001bf833..43c527d72f2f 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -812,6 +812,19 @@ and is between 256 and 4096 characters. It is defined in the file
inttest= [... |
c0a282c251181aa423d4831719613b8286b5b839 | Analyze and fix the following issue in the Linux kernel code: x86: make mp_bus_id_to_type optional | Problem Details:
[ mingo@elte.hu: fix boot regression. ]
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c
index 97ac6104d63a..0d70acd3b134 100644
--- a/arch/x86/kernel/io_apic_32.c
+++ b/arch/x86/kernel/io_apic_32.c
@@ -915,6 +915,7 @@ void __init setup_ioapic_dest(void)
}
#endif
+#if defined(CONFIG_EISA) || defined(CONFIG_MCA)
/*
* EIS... |
537d916066f66de18dbca79adf82933cd12d2a36 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/setup_32.c | Problem Details:
Fix:
ERROR: do not initialise externals to 0 or NULL
Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c
index fd639d9f79b6..d4ad6e8ae886 100644
--- a/arch/x86/kernel/setup_32.c
+++ b/arch/x86/kernel/setup_32.c
@@ -228,7 +228,7 @@ static inline void copy_edd(void)
}
#endif
-int __initdata user_defined_memmap = 0;
+int __initdata user_defined_... |
e587cadd8f47e202a30712e2906a65a0606d5865 | Analyze and fix the following issue in the Linux kernel code: x86: enhance DEBUG_RODATA support - alternatives | Problem Details:
Fix a memcpy that should be a text_poke (in apply_alternatives).
Use kernel_wp_save/kernel_wp_restore in text_poke to support DEBUG_RODATA
correctly and so the CPU HOTPLUG special case can be removed.
Add text_poke_early, for alternatives and paravirt boot-time and module load
time patching.
Changel... | ```diff
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index e2d30b8e08a2..0c92ad4d257a 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -11,6 +11,8 @@
#include <asm/mce.h>
#include <asm/nmi.h>
#include <asm/vsyscall.h>
+#include <asm/cacheflush.h>
+#inclu... |
a7062211865efb53cda253d6e33a106f0fe20ebe | Analyze and fix the following issue in the Linux kernel code: x86: fix amd_detect_cmp | Problem Details:
for system with apicid lifting, boot cpu apicid will be 4
got:
CPU: L1 I Cache: 64K (64 bytes/line), D cache 64K (64 bytes/line)
CPU: L2 Cache: 512K (64 bytes/line)
CPU 0/4 -> Node 0
CPU: Physical Processor ID: 1
CPU: Processor Core ID: 0
so try to offset apicid back before get phys_proc_i... | ```diff
diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c
index d65b73e63384..f303c70dd688 100644
--- a/arch/x86/kernel/setup_64.c
+++ b/arch/x86/kernel/setup_64.c
@@ -564,7 +564,7 @@ static void __cpuinit amd_detect_cmp(struct cpuinfo_x86 *c)
/* Low order bits define the core id (index of core in ... |
8b6451fe5cf78909f28d3762f77df060c8603cd0 | Analyze and fix the following issue in the Linux kernel code: x86: fix switch_to() clobbers | Problem Details:
Liu Pingfan noticed that switch_to() clobbers more registers than its
asm constraints specify.
We get away with this due to luck mostly - schedule()
by its nature only has 'local' state which gets reloaded
automatically. Fix it nevertheless, we could hit this anytime.
it turns out that with the extra... | ```diff
diff --git a/include/asm-x86/system.h b/include/asm-x86/system.h
index 299ae9605cb1..33b0017156a7 100644
--- a/include/asm-x86/system.h
+++ b/include/asm-x86/system.h
@@ -29,7 +29,14 @@ struct task_struct *__switch_to(struct task_struct *prev,
*/
#define switch_to(prev, next, last) \
do { \
- un... |
9fc34113f6880b215cbea4e7017fc818700384c2 | Analyze and fix the following issue in the Linux kernel code: x86: debug pmd_bad() | Problem Details:
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c
index 2f9e9afcb9f4..76e4f4d26272 100644
--- a/arch/x86/mm/pgtable_32.c
+++ b/arch/x86/mm/pgtable_32.c
@@ -381,3 +381,10 @@ void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd)
}
#endif
+
+int pmd_bad(pmd_t pmd)
+{
+ WARN_ON_ONCE(pmd_bad_v1(... |
823c248e7cc75b4f22da914b01f8e5433cff197e | Analyze and fix the following issue in the Linux kernel code: x86: fix recursive dependencies | Problem Details:
The proper dependency check uncovered a few dependency problems,
the subarchitecture used a mixture of selects and depends on SMP
and PCI dependency was messed up.
Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 810248f01729..dbdd3142215c 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -241,8 +241,7 @@ config X86_ELAN
config X86_VOYAGER
bool "Voyager (NCR)"
- depends on X86_32
- select SMP if !BROKEN
+ depends on X86_32 && (SMP || BROKEN)
help
Vo... |
c9cf39ae64a6c86872e580f921afec64ab9770f8 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to x86/kernel/early_printk.c | Problem Details:
Depends on:
[PATCH 2/3] x86: coding style fixes to arch/x86/kernel/early_printk.c
Remove two:
ERROR: do not initialise statics to 0 or NULL
paolo@paolo-desktop:/tmp/c$ size *
text data bss dec hex filename
1172 280 12 1464 5b8 early_printk.o.after
1172 280 ... | ```diff
diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
index a8f965dd58df..643fd861b724 100644
--- a/arch/x86/kernel/early_printk.c
+++ b/arch/x86/kernel/early_printk.c
@@ -13,7 +13,7 @@
#define VGABASE (__ISA_IO_base + 0xb8000)
static int max_ypos = 25, max_xpos = 80;
-static int cur... |
e941f27a7a0f4ecac9ba8237b8a329bab4bd622f | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/early_printk.c | Problem Details:
Before:
total: 17 errors, 3 warnings, 254 lines checked
After:
total: 2 errors, 3 warnings, 254 lines checked
paolo@paolo-desktop:/tmp/b$ md5sum *
da32f5cd8f248970e4809e1005393e95 early_printk.o.after
da32f5cd8f248970e4809e1005393e95 early_printk.o.before
paolo@paolo-desktop:/tmp/b$ size *
text... | ```diff
diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
index cff84cd9987f..a8f965dd58df 100644
--- a/arch/x86/kernel/early_printk.c
+++ b/arch/x86/kernel/early_printk.c
@@ -108,12 +108,12 @@ static __init void early_serial_init(char *s)
if (*s) {
unsigned port;
- if (!strncmp(s,"0x... |
3f50dbc1aec96c4d66ffa1c564014f9f43fb9e11 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/lib/usercopy_32.c | Problem Details:
Before:
total: 63 errors, 2 warnings, 878 lines checked
After:
total: 0 errors, 2 warnings, 878 lines checked
Compile tested, no change in the binary output:
text data bss dec hex filename
3231 0 0 3231 c9f usercopy_32.o.after
3231 0 0 3231 c9f u... | ```diff
diff --git a/arch/x86/lib/usercopy_32.c b/arch/x86/lib/usercopy_32.c
index e849b9998b0e..24e60944971a 100644
--- a/arch/x86/lib/usercopy_32.c
+++ b/arch/x86/lib/usercopy_32.c
@@ -1,4 +1,4 @@
-/*
+/*
* User address space access functions.
* The non inlined parts of asm-i386/uaccess.h are here.
*
@@ -22,14... |
e3100c82abd9aa643dc15828202aceeae3504e03 | Analyze and fix the following issue in the Linux kernel code: x86: check physical address range in ioremap | Problem Details:
Roland Dreier reported in http://lkml.org/lkml/2008/2/27/194
[ 8425.915139] BUG: unable to handle kernel paging request at ffffc20001a0a000
[ 8425.919087] IP: [<ffffffff8021dacc>] clflush_cache_range+0xc/0x25
[ 8425.919087] PGD 1bf80e067 PUD 1bf80f067 PMD 1bb497067 PTE 80000047000ee17b
This is on a I... | ```diff
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 868bbde74698..17f518839028 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -35,6 +35,18 @@ unsigned long __phys_addr(unsigned long x)
}
EXPORT_SYMBOL(__phys_addr);
+static inline int phys_addr_valid(unsigned long addr)
+{
+ r... |
f8fffa458368ed3d57385698f775880db629bd1a | Analyze and fix the following issue in the Linux kernel code: x86: apic_is_clustered_box for vsmp | Problem Details:
quad core 8 socket system will have apic id lifting.the apic id range could
be [4, 0x23]. and apic_is_clustered_box will think that need to three clusters
and that is larger than 2. So it is treated as a clustered_box.
and will get:
Marking TSC unstable due to TSCs unsynchronized
even if the CPUs... | ```diff
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
index ac2405ed504d..f6eb01d8923a 100644
--- a/arch/x86/kernel/apic_64.c
+++ b/arch/x86/kernel/apic_64.c
@@ -1182,9 +1182,9 @@ __cpuinit int apic_is_clustered_box(void)
* there is not this kind of box with AMD CPU yet.
* Some AMD box with q... |
34048c9e927d5ae29c6ba802c826370de2a046d2 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/common.c | Problem Details:
Before:
total: 55 errors, 6 warnings, 727 lines checked
After:
total: 0 errors, 3 warnings, 734 lines checked
No code changed:
arch/x86/kernel/cpu/common.o:
text data bss dec hex filename
3500 4611 44 8155 1fdb common.o.before
3500 4611 44 8155 ... | ```diff
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 0fd6be154d5d..ef9e31b89b35 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -62,9 +62,9 @@ __u32 cleared_cpu_caps[NCAPINTS] __cpuinitdata;
static int cachesize_override __cpuinitdata = -1;
static int ... |
db96598494f2a2ab9ab79999dd8fc365a906914b | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/power/cpu_32.c | Problem Details:
Before:
total: 15 errors, 3 warnings, 133 lines checked
After:
total: 0 errors, 0 warnings, 138 lines checked
No code changed:
arch/x86/power/cpu_32.o:
text data bss dec hex filename
739 0 84 823 337 cpu_32.o.before
739 0 84 823 3... | ```diff
diff --git a/arch/x86/power/cpu_32.c b/arch/x86/power/cpu_32.c
index 7f9c6da04a4c..7dc5d5cf50a2 100644
--- a/arch/x86/power/cpu_32.c
+++ b/arch/x86/power/cpu_32.c
@@ -27,17 +27,17 @@ static void __save_processor_state(struct saved_context *ctxt)
/*
* descriptor tables
*/
- store_gdt(&ctxt->gdt);
- sto... |
7ebed39ff7eec204850736a662828da0b942b8c0 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/xen/multicalls.c | Problem Details:
Before:
total: 2 errors, 2 warnings, 138 lines checked
After:
total: 0 errors, 2 warnings, 138 lines checked
No code changed:
arch/x86/xen/multicalls.o:
text data bss dec hex filename
887 2832 0 3719 e87 multicalls.o.before
887 2832 0 3719 ... | ```diff
diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
index 5e6f36f6d876..5791eb2e3750 100644
--- a/arch/x86/xen/multicalls.c
+++ b/arch/x86/xen/multicalls.c
@@ -76,7 +76,7 @@ void xen_mc_flush(void)
if (ret) {
printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
ret, smp_processor... |
94a9fa41421625caedc328a2b0a0d5c78919a20f | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/msr.c | Problem Details:
Before:
total: 2 errors, 0 warnings, 231 lines checked
After:
total: 0 errors, 0 warnings, 231 lines checked
No code changed:
arch/x86/kernel/msr.o:
text data bss dec hex filename
1199 12 4 1215 4bf msr.o.before
1199 12 4 1215 4bf msr... | ```diff
diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index af51ea8400b2..4dfb40530057 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -65,8 +65,8 @@ static loff_t msr_seek(struct file *file, loff_t offset, int orig)
return ret;
}
-static ssize_t msr_read(struct file *file, char __us... |
0fb90297dc69b87333c0afae537b1bff847e0397 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/oprofile/nmi_timer_int.c | Problem Details:
Before:
total: 3 errors, 0 warnings, 69 lines checked
After:
total: 0 errors, 0 warnings, 69 lines checked
No code changed:
arch/x86/oprofile/nmi_timer_int.o:
text data bss dec hex filename
180 12 0 192 c0 nmi_timer_int.o.before
180 12 0... | ```diff
diff --git a/arch/x86/oprofile/nmi_timer_int.c b/arch/x86/oprofile/nmi_timer_int.c
index 1418e36ae7ab..e3ecb71b5790 100644
--- a/arch/x86/oprofile/nmi_timer_int.c
+++ b/arch/x86/oprofile/nmi_timer_int.c
@@ -17,14 +17,14 @@
#include <asm/nmi.h>
#include <asm/apic.h>
#include <asm/ptrace.h>
-
+
static int pr... |
adf85265b455f096fa9caf4aea51f274cdaca3c6 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/cyrix.c | Problem Details:
Before:
total: 46 errors, 10 warnings, 450 lines checked
After:
total: 1 errors, 10 warnings, 449 lines checked
No code changed:
arch/x86/kernel/cpu/cyrix.o:
text data bss dec hex filename
2048 908 4 2960 b90 cyrix.o.before
2048 908 4 2960 ... | ```diff
diff --git a/arch/x86/kernel/cpu/cyrix.c b/arch/x86/kernel/cpu/cyrix.c
index 9c4ee98f2cb8..f7085bde4c28 100644
--- a/arch/x86/kernel/cpu/cyrix.c
+++ b/arch/x86/kernel/cpu/cyrix.c
@@ -19,7 +19,7 @@ static void __cpuinit do_cyrix_devid(unsigned char *dir0, unsigned char *dir1)
{
unsigned char ccr2, ccr3;
uns... |
7030760ae5d29d637d1e962c70d1d9c58be3306f | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/boot/cpucheck.c | Problem Details:
Before:
total: 30 errors, 0 warnings, 262 lines checked
After:
total: 0 errors, 0 warnings, 262 lines checked
No code changed:
arch/x86/boot/cpucheck.o:
text data bss dec hex filename
989 0 96 1085 43d cpucheck.o.before
989 0 96 1085 ... | ```diff
diff --git a/arch/x86/boot/cpucheck.c b/arch/x86/boot/cpucheck.c
index 769065bd23d7..2462c88689ed 100644
--- a/arch/x86/boot/cpucheck.c
+++ b/arch/x86/boot/cpucheck.c
@@ -56,27 +56,27 @@ static const u32 req_flags[NCAPINTS] =
REQUIRED_MASK7,
};
-#define A32(a,b,c,d) (((d) << 24)+((c) << 16)+((b) << 8)+(a))... |
d677759e99b51f50a75b2adfabb25e9d656ee33c | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/mcheck/mce_32.c | Problem Details:
Before:
total: 10 errors, 3 warnings, 90 lines checked
After:
total: 0 errors, 3 warnings, 90 lines checked
No code changed:
arch/x86/kernel/cpu/mcheck/mce_32.o:
text data bss dec hex filename
287 42 12 341 155 mce_32.o.before
287 42 12 ... | ```diff
diff --git a/arch/x86/kernel/cpu/mcheck/mce_32.c b/arch/x86/kernel/cpu/mcheck/mce_32.c
index a5182dcd94ae..774d87cfd8cd 100644
--- a/arch/x86/kernel/cpu/mcheck/mce_32.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_32.c
@@ -10,20 +10,20 @@
#include <linux/smp.h>
#include <linux/thread_info.h>
-#include <asm/processo... |
4de816297d96a96b60007f3065a07f3937fd7c6e | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/mcheck/winchip.c | Problem Details:
Before:
total: 4 errors, 0 warnings, 36 lines checked
After:
total: 0 errors, 0 warnings, 36 lines checked
No code changed:
arch/x86/kernel/cpu/mcheck/winchip.o:
text data bss dec hex filename
222 0 4 226 e2 winchip.o.before
222 0 4 ... | ```diff
diff --git a/arch/x86/kernel/cpu/mcheck/winchip.c b/arch/x86/kernel/cpu/mcheck/winchip.c
index 3d428d5afc52..f2be3e190c6b 100644
--- a/arch/x86/kernel/cpu/mcheck/winchip.c
+++ b/arch/x86/kernel/cpu/mcheck/winchip.c
@@ -8,14 +8,14 @@
#include <linux/kernel.h>
#include <linux/interrupt.h>
-#include <asm/proce... |
714a9ac2efe5e20fdccfcf91b27dbd384bd34685 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/mcheck/non-fatal.c | Problem Details:
Before:
total: 5 errors, 5 warnings, 91 lines checked
After:
total: 0 errors, 0 warnings, 94 lines checked
No code changed:
arch/x86/kernel/cpu/mcheck/non-fatal.o:
text data bss dec hex filename
441 80 4 525 20d non-fatal.o.before
441 80 ... | ```diff
diff --git a/arch/x86/kernel/cpu/mcheck/non-fatal.c b/arch/x86/kernel/cpu/mcheck/non-fatal.c
index bf39409b3838..00ccb6c14ec2 100644
--- a/arch/x86/kernel/cpu/mcheck/non-fatal.c
+++ b/arch/x86/kernel/cpu/mcheck/non-fatal.c
@@ -16,7 +16,7 @@
#include <linux/smp.h>
#include <linux/module.h>
-#include <asm/pro... |
83e714e82f3434a32c3f54f7223f78345d873218 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/vm86_32.c | Problem Details:
Before:
total: 64 errors, 18 warnings, 840 lines checked
After:
total: 12 errors, 15 warnings, 844 lines checked
No code changed:
arch/x86/kernel/vm86_32.o:
text data bss dec hex filename
4449 28 132 4609 1201 vm86_32.o.before
4449 28 132 4609... | ```diff
diff --git a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c
index 738c2104df30..6a91fcf92d67 100644
--- a/arch/x86/kernel/vm86_32.c
+++ b/arch/x86/kernel/vm86_32.c
@@ -64,7 +64,7 @@
#define KVM86 ((struct kernel_vm86_struct *)regs)
-#define VMPI KVM86->vm86plus
+#define VMPI KVM86->vm86plus
/*... |
fb87a298fb79357fa5b27e6916ae1c45bf94dac7 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/amd.c | Problem Details:
Before:
total: 42 errors, 26 warnings, 350 lines checked
After:
total: 0 errors, 26 warnings, 352 lines checked
No code changed:
arch/x86/kernel/cpu/amd.o:
text data bss dec hex filename
1936 328 0 2264 8d8 amd.o.before
1936 328 0 2264 ... | ```diff
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index cab4e562b5cb..1a3e1bb4d758 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -20,7 +20,7 @@
* the chip setting when fixing the bug but they also tweaked some
* performance at the same time..
*/
-
+
extern vo... |
f97518271941fdb2dab07d7bd58bf9fa39ba3f65 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/transmeta.c | Problem Details:
Before:
total: 13 errors, 3 warnings, 105 lines checked
After:
total: 0 errors, 3 warnings, 107 lines checked
No code changed:
arch/x86/kernel/cpu/transmeta.o:
text data bss dec hex filename
713 324 0 1037 40d transmeta.o.before
713 324 0 ... | ```diff
diff --git a/arch/x86/kernel/cpu/transmeta.c b/arch/x86/kernel/cpu/transmeta.c
index c2d168e992f4..daee21d208f4 100644
--- a/arch/x86/kernel/cpu/transmeta.c
+++ b/arch/x86/kernel/cpu/transmeta.c
@@ -18,8 +18,8 @@ static void __cpuinit init_transmeta(struct cpuinfo_x86 *c)
/* Print CMS and CPU revision */
ma... |
93d8bd3d4f070014e1e73c0ac618ac33924a7b96 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/lib/memcpy_32.c | Problem Details:
Before:
total: 2 errors, 0 warnings, 43 lines checked
After:
total: 0 errors, 0 warnings, 43 lines checked
No code changed:
arch/x86/lib/memcpy_32.o:
text data bss dec hex filename
164 0 0 164 a4 memcpy_32.o.before
164 0 0 164 ... | ```diff
diff --git a/arch/x86/lib/memcpy_32.c b/arch/x86/lib/memcpy_32.c
index 37756b6fb329..5415a9d06f53 100644
--- a/arch/x86/lib/memcpy_32.c
+++ b/arch/x86/lib/memcpy_32.c
@@ -25,7 +25,7 @@ void *memmove(void *dest, const void *src, size_t n)
int d0, d1, d2;
if (dest < src) {
- memcpy(dest,src,n);
+ memcpy(d... |
e0f025704437dfd6cb5adc077f05709c31189edc | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/mtrr/state.c | Problem Details:
Before:
total: 6 errors, 5 warnings, 80 lines checked
After:
total: 0 errors, 4 warnings, 82 lines checked
No code changed:
arch/x86/kernel/cpu/mtrr/state.o:
text data bss dec hex filename
313 0 4 317 13d state.o.before
313 0 4 317 ... | ```diff
diff --git a/arch/x86/kernel/cpu/mtrr/state.c b/arch/x86/kernel/cpu/mtrr/state.c
index 9f8ba923d1c9..7f7e2753685b 100644
--- a/arch/x86/kernel/cpu/mtrr/state.c
+++ b/arch/x86/kernel/cpu/mtrr/state.c
@@ -19,13 +19,15 @@ void set_mtrr_prepare_save(struct set_mtrr_context *ctxt)
if (use_intel() || is_cpu(CYRIX))... |
0067cc996ee7a0dd282d8da5b64fa60aa2066bb2 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/mca_32.c | Problem Details:
Before:
total: 42 errors, 3 warnings, 469 lines checked
After:
total: 0 errors, 3 warnings, 479 lines checked
No code changed:
arch/x86/kernel/mca_32.o:
text data bss dec hex filename
1832 288 5 2125 84d mca_32.o.before
1832 288 5 2125 ... | ```diff
diff --git a/arch/x86/kernel/mca_32.c b/arch/x86/kernel/mca_32.c
index 9482033ed0fe..2dc183758be3 100644
--- a/arch/x86/kernel/mca_32.c
+++ b/arch/x86/kernel/mca_32.c
@@ -53,9 +53,9 @@
#include <linux/init.h>
#include <asm/arch_hooks.h>
-static unsigned char which_scsi = 0;
+static unsigned char which_scsi;... |
f73920cd63d316008738427a0df2caab6cc88ad7 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/lib/strstr_3 | Problem Details:
Before:
total: 3 errors, 0 warnings, 31 lines checked
After:
total: 0 errors, 0 warnings, 31 lines checked
No code changed:
arch/x86/lib/strstr_32.o:
text data bss dec hex filename
49 0 0 49 31 strstr_32.o.before
49 0 0 49 ... | ```diff
diff --git a/arch/x86/lib/strstr_32.c b/arch/x86/lib/strstr_32.c
index a3dafbf59dae..42e8a50303f3 100644
--- a/arch/x86/lib/strstr_32.c
+++ b/arch/x86/lib/strstr_32.c
@@ -1,9 +1,9 @@
#include <linux/string.h>
-char * strstr(const char * cs,const char * ct)
+char *strstr(const char *cs, const char *ct)
{
in... |
d717ca84c02f4b60a85502c23bca5698801dfaae | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/oprofile/init.c | Problem Details:
Before:
total: 5 errors, 4 warnings, 48 lines checked
After:
total: 0 errors, 4 warnings, 49 lines checked
No code changed:
arch/x86/oprofile/init.o:
text data bss dec hex filename
42 0 0 42 2a init.o.before
42 0 0 42 2a i... | ```diff
diff --git a/arch/x86/oprofile/init.c b/arch/x86/oprofile/init.c
index 5341d481d92f..cdfe4c54deca 100644
--- a/arch/x86/oprofile/init.c
+++ b/arch/x86/oprofile/init.c
@@ -10,18 +10,19 @@
#include <linux/oprofile.h>
#include <linux/init.h>
#include <linux/errno.h>
-
-/* We support CPUs that have performance ... |
65eb6b4326daddd1cccd003bd4df3fd75b06f0e1 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/intel.c | Problem Details:
Before:
total: 37 errors, 16 warnings, 366 lines checked
After:
total: 0 errors, 15 warnings, 369 lines checked
No code changed:
arch/x86/kernel/cpu/intel.o:
text data bss dec hex filename
1534 452 0 1986 7c2 intel.o.before
1534 452 0 1986 ... | ```diff
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 34468b2e2507..c9ecf378cc41 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -45,7 +45,7 @@ static void __cpuinit early_init_intel(struct cpuinfo_x86 *c)
*
* This is called before we do cpu ident work
... |
60e11746d97c099b305e25e587731148387d02eb | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/summit_32.c | Problem Details:
Before:
total: 20 errors, 17 warnings, 180 lines checked
After:
total: 0 errors, 17 warnings, 183 lines checked
No code changed:
arch/x86/kernel/summit_32.o:
text data bss dec hex filename
932 192 0 1124 464 summit_32.o.before
932 192 0 1... | ```diff
diff --git a/arch/x86/kernel/summit_32.c b/arch/x86/kernel/summit_32.c
index 72f463401592..c7b579db843d 100644
--- a/arch/x86/kernel/summit_32.c
+++ b/arch/x86/kernel/summit_32.c
@@ -40,38 +40,40 @@ static int __init setup_pci_node_map_for_wpeg(int wpeg_num, int last_bus)
int twister = 0, node = 0;
int i, b... |
023196a3be708657d828bb139343bceb2c1c9649 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fix to arch/x86/boot/pm.c | Problem Details:
Before:
total: 1 errors, 0 warnings, 178 lines checked
After:
total: 0 errors, 0 warnings, 178 lines checked
No code changed:
arch/x86/boot/pm.o:
text data bss dec hex filename
351 0 6 357 165 pm.o.before
351 0 6 357 165 pm.o.af... | ```diff
diff --git a/arch/x86/boot/pm.c b/arch/x86/boot/pm.c
index 1a0f936c160b..a93cb8bded4d 100644
--- a/arch/x86/boot/pm.c
+++ b/arch/x86/boot/pm.c
@@ -100,7 +100,7 @@ static void reset_coprocessor(void)
/*
* Set up the GDT
*/
-#define GDT_ENTRY(flags,base,limit) \
+#define GDT_ENTRY(flags, base, limit) \
(... |
1e934dda0c77c8ad13fdda02074f2cfcea118a56 | Analyze and fix the following issue in the Linux kernel code: x86: insert_resorce for lapic addr after e820_reserve_resources | Problem Details:
when comparing the e820 direct from BIOS, and the one by kexec:
BIOS-provided physical RAM map:
- BIOS-e820: 0000000000000000 - 0000000000097400 (usable)
+ BIOS-e820: 0000000000000100 - 0000000000097400 (usable)
BIOS-e820: 0000000000097400 - 00000000000a0000 (reserved)
BIOS-e820: 00000000000e6000... | ```diff
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
index 7d8ffdaa0ab3..ac2405ed504d 100644
--- a/arch/x86/kernel/apic_64.c
+++ b/arch/x86/kernel/apic_64.c
@@ -881,11 +881,6 @@ void __init init_apic_mappings(void)
apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n",
APIC_BASE, apic_... |
fd77c7cabd71ab0c31758f5faf1b92b66e9fe461 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/boot/compressed/misc.c | Problem Details:
Fix lots of style errors and warnings.
Before:
total: 58 errors, 9 warnings, 469 lines checked
After:
total: 7 errors, 8 warnings, 471 lines checked
No code changed:
arch/x86/boot/compressed/misc.o:
text data bss dec hex filename
10716 8 2152 12876 324c misc.... | ```diff
diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
index 69aec2f4155d..50d054c29018 100644
--- a/arch/x86/boot/compressed/misc.c
+++ b/arch/x86/boot/compressed/misc.c
@@ -127,7 +127,8 @@ typedef unsigned char uch;
typedef unsigned short ush;
typedef unsigned long ulg;
-#define ... |
48e6b7a050971dd42122f6db7a43467794075c02 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/umc.c | Problem Details:
Before:
total: 3 errors, 1 warnings, 23 lines checked
After:
total: 0 errors, 0 warnings, 25 lines checked
No code changed:
arch/x86/kernel/cpu/umc.o:
text data bss dec hex filename
24 616 0 640 280 umc.o.before
24 616 0 640 280 u... | ```diff
diff --git a/arch/x86/kernel/cpu/umc.c b/arch/x86/kernel/cpu/umc.c
index b1acf08245fb..b1fc90989d75 100644
--- a/arch/x86/kernel/cpu/umc.c
+++ b/arch/x86/kernel/cpu/umc.c
@@ -3,17 +3,19 @@
#include <asm/processor.h>
#include "cpu.h"
-/* UMC chips appear to be only either 386 or 486, so no special init takes... |
2c5847837fe76497934734330151f240f3e04925 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/kernel/cpu/mcheck/p6.c | Problem Details:
Before:
total: 16 errors, 13 warnings, 122 lines checked
After:
total: 0 errors, 0 warnings, 122 lines checked
No code changed:
arch/x86/kernel/cpu/mcheck/p6.o:
text data bss dec hex filename
1082 0 8 1090 442 p6.o.before
1082 0 8 1090 ... | ```diff
diff --git a/arch/x86/kernel/cpu/mcheck/p6.c b/arch/x86/kernel/cpu/mcheck/p6.c
index 74342604d30e..62efc9c2b3af 100644
--- a/arch/x86/kernel/cpu/mcheck/p6.c
+++ b/arch/x86/kernel/cpu/mcheck/p6.c
@@ -9,23 +9,23 @@
#include <linux/interrupt.h>
#include <linux/smp.h>
-#include <asm/processor.h>
+#include <asm... |
4d46a89e7c867718020b2d5fd8f9e775293304be | Analyze and fix the following issue in the Linux kernel code: x86: clean up include/asm-x86/processor.h | Problem Details:
basic style cleanup to flush out years of neglect:
- consistent indentation
- whitespace fixes
- consistent comments
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/asm-x86/processor.h b/include/asm-x86/processor.h
index 45a2f0ab33d0..43d2cc829a94 100644
--- a/include/asm-x86/processor.h
+++ b/include/asm-x86/processor.h
@@ -24,6 +24,7 @@ struct mm_struct;
#include <asm/msr.h>
#include <asm/desc_defs.h>
#include <asm/nops.h>
+
#include <linux/perso... |
637cba02618c1373eb9d2b70a53c17832e27d090 | Analyze and fix the following issue in the Linux kernel code: x86: coding style fixes to arch/x86/mach-generic/bigsmp.c | Problem Details:
arch/x86/mach-generic/bigsmp.o:
text data bss dec hex filename
1271 144 4 1419 58b bigsmp.o.before
1271 144 4 1419 58b bigsmp.o.after
md5:
b83aad375294c002c79b03c3a2e4be35 bigsmp.o.before.asm
b83aad375294c002c79b03c3a2e4be35 bigsmp.o.after.a... | ```diff
diff --git a/arch/x86/mach-generic/bigsmp.c b/arch/x86/mach-generic/bigsmp.c
index 292a225edabe..95fc463056d0 100644
--- a/arch/x86/mach-generic/bigsmp.c
+++ b/arch/x86/mach-generic/bigsmp.c
@@ -1,4 +1,4 @@
-/*
+/*
* APIC driver for "bigsmp" XAPIC machines with more than 8 virtual CPUs.
* Drives the local ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.