id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
b3d98135aa6e462d7e3f42a86d12483a9003a4da | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6981): Fix bugzillas 9686 and 9691 | Problem Details:
IR were not working for Winfast XP 2000 TV.
Gabor Nyekhelyi <n0gabor@vipmail.hu> wrote a hack some time ago:
http://marc.info/?l=linux-video&m=116362609323281&w=2
This patch fixes CodingStyle and commits the hack. I suspect that the proper
solution would be to find the proper mask_keydown for this IR... | ```diff
diff --git a/drivers/media/video/bt8xx/bttv-input.c b/drivers/media/video/bt8xx/bttv-input.c
index e7c521b8444a..fc9ecb21eec6 100644
--- a/drivers/media/video/bt8xx/bttv-input.c
+++ b/drivers/media/video/bt8xx/bttv-input.c
@@ -69,6 +69,11 @@ static void ir_handle_key(struct bttv *btv)
(ir->mask_keyup &... |
98512f7b36ec412ea0461e9aab8f16c882df055d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6976): drivers/media/radio/radio-sf16fmr2.c: fix error handling | Problem Details:
video_register_device() returns -EFOO on errr, not -1.
Addresses http://bugzilla.kernel.org/show_bug.cgi?id=9699
Reported-By: <devzero@web.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/radio/radio-sf16fmr2.c b/drivers/media/radio/radio-sf16fmr2.c
index c432c44bd634..f7c8b000404f 100644
--- a/drivers/media/radio/radio-sf16fmr2.c
+++ b/drivers/media/radio/radio-sf16fmr2.c
@@ -476,8 +476,7 @@ static int __init fmr2_init(void)
return -EBUSY;
}
- if(video_register... |
616f8878bc5b5b2276f1941643d9ca7c88690305 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6974): Fix codingStyle | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
index 7f4212928e9f..0db955c2d9b9 100644
--- a/drivers/media/video/saa7134/saa7134-input.c
+++ b/drivers/media/video/saa7134/saa7134-input.c
@@ -173,7 +173,7 @@ static int get_key_beholdm6xx(struct IR_i2c *ir, ... |
d2c932a1f7aca16727ce6670c5eccb0a4e2b47a5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6965): tda18271: fix analog tuning regression caused by earlier changeset | Problem Details:
An earlier patch, "tda18271: fail table lookups if frequency is out of range"
broke analog support on certain hardware. This patch fixes that problem, by
allowing the RF_CAL byte to be set to the maximum value, in cases of the
frequency being out of range.
Signed-off-by: Michael Krufky <mkrufky@linux... | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271-common.c b/drivers/media/dvb/frontends/tda18271-common.c
index 4adc7390ba00..d7a335659474 100644
--- a/drivers/media/dvb/frontends/tda18271-common.c
+++ b/drivers/media/dvb/frontends/tda18271-common.c
@@ -601,13 +601,11 @@ int tda18271_calc_rf_cal(struct dvb_fro... |
0e1fab90a8a76e09b669d3159ec910eab7ee97d6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6964): tda18271: document debug level and configuration parameters | Problem Details:
Document debug level module options and
tda18271_config attach-time parameters.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271-fe.c b/drivers/media/dvb/frontends/tda18271-fe.c
index a02d6404f755..55c17fc22275 100644
--- a/drivers/media/dvb/frontends/tda18271-fe.c
+++ b/drivers/media/dvb/frontends/tda18271-fe.c
@@ -24,7 +24,8 @@
int tda18271_debug;
module_param_named(debug, tda18271_... |
e545d6e2760b51163da141caffd288572c2db08d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6953): Fix radio set frequency logic | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index 67b9ed1ac71a..35976e6cb1b8 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -247,7 +247,7 @@ static void set_radio_freq(struct i2c_client *c, unsigned int freq)
tuner_warn ("tuner typ... |
6d79468dd8537530f4150e76ed9b4b63f80571c6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6951): Integrates em28xx-audio.c into em28xx kernel module | Problem Details:
Also fixes the remaining CodingStyle issues that Lindent didn't fix.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/em28xx/Kconfig b/drivers/media/video/em28xx/Kconfig
index 813077b6ef7f..abbd38c1ebba 100644
--- a/drivers/media/video/em28xx/Kconfig
+++ b/drivers/media/video/em28xx/Kconfig
@@ -11,3 +11,18 @@ config VIDEO_EM28XX
To compile this driver as a module, choose M here: the
m... |
6596a4f6032f13f1bef47550fcf1d4134cd978a4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6944): Fix in-kernel ivtv compilation | Problem Details:
Due to tuner-xc2028.h, some extra directories should be added at .h search.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/Makefile b/drivers/media/video/ivtv/Makefile
index e8eefd96d897..a0389014fa88 100644
--- a/drivers/media/video/ivtv/Makefile
+++ b/drivers/media/video/ivtv/Makefile
@@ -6,3 +6,8 @@ ivtv-objs := ivtv-routing.o ivtv-cards.o ivtv-controls.o \
obj-$(CONFIG_VIDEO_IVTV) += ivt... |
7686b574a1507ecf5fd7c419b43f26222668aa4d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6924): tda18271: fix whitespace in tda18271_ir_measure | Problem Details:
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271-tables.c b/drivers/media/dvb/frontends/tda18271-tables.c
index cce0e0d82233..02b6d2cb9570 100644
--- a/drivers/media/dvb/frontends/tda18271-tables.c
+++ b/drivers/media/dvb/frontends/tda18271-tables.c
@@ -258,11 +258,11 @@ static struct tda18271_map tda18271_rf_... |
926bf3ca937461123b98ff2ba8c3409f5b4c05b5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6923): tda18271: remove extraneous debug | Problem Details:
We don't need to do a dbg_info during tda18271_attach anymore, since
the tda18271_get_id function will call dbg_info with the same information
and more.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271-fe.c b/drivers/media/dvb/frontends/tda18271-fe.c
index 19c9be92de51..da22b24190cf 100644
--- a/drivers/media/dvb/frontends/tda18271-fe.c
+++ b/drivers/media/dvb/frontends/tda18271-fe.c
@@ -783,7 +783,6 @@ struct dvb_frontend *tda18271_attach(struct dvb_frontend ... |
8574ac690eab730a3ff735177af1d52e45e36c8b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6921): include/media/v4l2-i2c-drv.h must #include <media/v4l2-common.h> | Problem Details:
Fix the following compiler error:
v4l2-i2c-drv.h:72: error: implicit declaration of function 'v4l2_i2c_attach'
Also, prevent multiple inclusions of v4l2-i2c-drv.h
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/include/media/v4l2-i2c-drv.h b/include/media/v4l2-i2c-drv.h
index d758b765e0ff..9e4bab276915 100644
--- a/include/media/v4l2-i2c-drv.h
+++ b/include/media/v4l2-i2c-drv.h
@@ -21,6 +21,11 @@
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#ifndef __V4L2_I2C_DRV_H__
+#define __V4... |
67d52e29032dd2f21d4080331f47a21205f337f6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6920): tuner: fix backwards logic in check for set_config | Problem Details:
tuner-core was checking if analog_ops->set_config is set. If set, it would
complain that it isn't. Fix this backwards logic to the proper behavior.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index f792871582ff..67b9ed1ac71a 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -855,12 +855,11 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
break;... |
9134be0376e7527afa4f2574253ff02ca80d5b47 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6914): Fix a few issues at the bttv conversion | Problem Details:
bttv driver is working as previously. An additional gain of about 1,5Kb were
obtained with the driver conversion to vidioc_ioctl2:
text data bss dec hex filename
89208 40244 57556 187008 2da80 old/bttv.ko
88960 38740 57556 185256 2d3a8 new/bttv.ko
(measured on a x8... | ```diff
diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
index c8f958151677..ddca21d9c948 100644
--- a/drivers/media/video/bt8xx/bttv-driver.c
+++ b/drivers/media/video/bt8xx/bttv-driver.c
@@ -785,15 +785,15 @@ static const struct v4l2_queryctrl bttv_ctls[] = {
};
-sta... |
4041f1a58774249f5f26163e68b844521ece1fb4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6909): cx23885: fix bad use count caused by tda18271 being probed by tda8290 | Problem Details:
Don't allow the tda8290 module to probe and attach the tuner module,
causing incorrect use counts when using dvb_attach.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c
index 0f7e9dfcd73f..81dd47f6f654 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -33,6 +33,7 @@
#include "s5h1409.h"
#include "mt2131.h"
#include "tda82... |
994fc28b6cd087cf6ef8d3ebd4eeef97c8194e4e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6903): mt312: CodingStyle fix | Problem Details:
Fixes all occurences of assignment in if
checkpatch marks them as ERROR.
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Reviewed-by: Andreas Oberritter <obi@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/mt312.c b/drivers/media/dvb/frontends/mt312.c
index 2d68fafc0ef8..1638301fbd6e 100644
--- a/drivers/media/dvb/frontends/mt312.c
+++ b/drivers/media/dvb/frontends/mt312.c
@@ -152,7 +152,8 @@ static int mt312_get_inversion(struct mt312_state *state,
int ret;
u8 vit_mod... |
3f51451b516eeb19d3c1ea311ee8845fc80b5135 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6894): xc5000: fix build warning | Problem Details:
Fix the following build warning:
xc5000.c:560: warning: format '%d' expects type 'int',
but argument 2 has type 'size_t'
On many architectrues size_t is unsigned long, and may not be printed with %d.
Use %Zu instead.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Ca... | ```diff
diff --git a/drivers/media/dvb/frontends/xc5000.c b/drivers/media/dvb/frontends/xc5000.c
index 9edd07115395..106004e12459 100644
--- a/drivers/media/dvb/frontends/xc5000.c
+++ b/drivers/media/dvb/frontends/xc5000.c
@@ -533,7 +533,8 @@ static int xc5000_fwupload(struct dvb_frontend* fe)
printk(KERN_ERR "xc500... |
7972f9880c8c812332a56da7cfa4523d01ea310b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6893): tuner-xc2028: fix xc2028_attach function | Problem Details:
xc2028_attach was returning an integer when disabled from the build, where it
should instead be returning NULL. Declare xc2028_attach as type dvb_frontend *
instead of void *.
The prototype declaration must be marked as extern in the header.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed... | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 5ed12e2272e9..ddd94f1d6a6f 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -1140,7 +1140,8 @@ static const struct dvb_tuner_ops xc2028_dvb_tuner_ops = {
};
-void *xc2028_at... |
fb6d8e2c7fe1667d8ce057e333b18deb91191be5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6892): xc5000: fix build when DVB_TUNER_XC5000 is disabled | Problem Details:
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/xc5000.h b/drivers/media/dvb/frontends/xc5000.h
index 9286a03822c1..941b31948133 100644
--- a/drivers/media/dvb/frontends/xc5000.h
+++ b/drivers/media/dvb/frontends/xc5000.h
@@ -42,7 +42,7 @@ extern struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe,
#else
stat... |
26501a703d9eca3b42d793d2e2553c33744097b9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6890): tda18271: fix typo in RF tracking filter calibration | Problem Details:
We want to set bits 1 & 2 on easy programming byte 4, not extended byte 4.
Thanks to David Wong for pointing this out.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Cc: David Wong <davidtlwong@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271-fe.c b/drivers/media/dvb/frontends/tda18271-fe.c
index 3c0f06e1f47d..8eaeb057282a 100644
--- a/drivers/media/dvb/frontends/tda18271-fe.c
+++ b/drivers/media/dvb/frontends/tda18271-fe.c
@@ -406,7 +406,7 @@ static int tda18271_tune(struct dvb_frontend *fe,
tda18... |
0b6a3342a645208feaab76332f1eee33e1688bd5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6874): removes duplicated KERN_DEBUG flags from dprintk calls in mt312.c | Problem Details:
do { \
if (debug) printk(KERN_DEBUG "mt312: " args); \
} while (0)
So no caller need to specify KERN_DEBUG.
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/mt312.c b/drivers/media/dvb/frontends/mt312.c
index 55d42440e979..2d68fafc0ef8 100644
--- a/drivers/media/dvb/frontends/mt312.c
+++ b/drivers/media/dvb/frontends/mt312.c
@@ -183,7 +183,7 @@ static int mt312_get_symbol_rate(struct mt312_state *state, u32 *sr)
monitor... |
89f6475857b89e956a8bcfef64944409ce4173b4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6873): Fixes issues listed by checkpatch | Problem Details:
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/mt312.c b/drivers/media/dvb/frontends/mt312.c
index 0606b9a5b616..55d42440e979 100644
--- a/drivers/media/dvb/frontends/mt312.c
+++ b/drivers/media/dvb/frontends/mt312.c
@@ -37,9 +37,9 @@
struct mt312_state {
- struct i2c_adapter* i2c;
+ struct i2c_adapter *i2c;
/... |
3ac510e6097368695ddff20918ab5822823b548e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6858): Fix offset for ATSC | Problem Details:
ATSC works with offset=0
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 0565edd224bc..d367f205c98a 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -873,7 +873,7 @@ static int generic_set_freq(struct dvb_frontend *fe, u32 freq /* in HZ */,
*/
if... |
d8f69971d8d6c137e42928492f8d469078113db9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6836): Fix CodingStyle troubles caused by the previous cx88 commits | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx88/cx88-blackbird.c b/drivers/media/video/cx88/cx88-blackbird.c
index d83facf00dc6..5f79442924fd 100644
--- a/drivers/media/video/cx88/cx88-blackbird.c
+++ b/drivers/media/video/cx88/cx88-blackbird.c
@@ -594,13 +594,11 @@ static int blackbird_start_codec(struct file *file, voi... |
7b27d45bb50498c86aa87e7ef174b2a0f5b6f361 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6831): Audio routes fix for blackbird boards with the wm8775 ADC | Problem Details:
Fix lack of audio on the MPEG-2 stream of wm8775 based blackbirds.
The wm8775 module initializes the audio input at "route 2", which doesn't
hold true for all boards. The HVR-1300, for example, uses route 1 for
tuner audio, and route 2 for baseband. So we must route the audio to the
proper input depen... | ```diff
diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
index f8a786ae4758..d484e5ce579c 100644
--- a/drivers/media/video/cx88/cx88-cards.c
+++ b/drivers/media/video/cx88/cx88-cards.c
@@ -302,22 +302,22 @@ static const struct cx88_board cx88_boards[] = {
.type = CX88_VMU... |
f9e54e0c84da869ad9bc372fb4eab26d558dbfc2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6828): cx88-blackbird: audio improvements | Problem Details:
This patch should fix the 'muted audio' and 'raspy audio' problem for
mpeg2 streams out of cx88-blackbird devices.
Especially mythtv users would find that the audio would often sound bad
(aliased, or 'raspy'), mainly related to channel changes, many (all?)
other users would find that there was no audi... | ```diff
diff --git a/drivers/media/video/cx88/cx88-blackbird.c b/drivers/media/video/cx88/cx88-blackbird.c
index f802b5653569..7ce37f46b753 100644
--- a/drivers/media/video/cx88/cx88-blackbird.c
+++ b/drivers/media/video/cx88/cx88-blackbird.c
@@ -536,6 +536,9 @@ static int blackbird_initialize_codec(struct cx8802_dev *... |
2b03238a79295aff30afc3d9a82afa617fd33971 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6821): s5h1409: fix IF frequency configuration | Problem Details:
On the s5h1409 demod, the IF frequency for VSB is limited to 44 / 5.38 MHz.
Hardcode VSB IF frequency within the driver to 44 / 5.38 MHz.
QAM IF frequency remains configurable via attach-time configuration.
Acked-by: Steven Toth <stoth@hauppauge.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org... | ```diff
diff --git a/drivers/media/dvb/frontends/s5h1409.c b/drivers/media/dvb/frontends/s5h1409.c
index 562d9208857a..b80a3ee91ba4 100644
--- a/drivers/media/dvb/frontends/s5h1409.c
+++ b/drivers/media/dvb/frontends/s5h1409.c
@@ -42,6 +42,7 @@ struct s5h1409_state {
fe_modulation_t current_modulation;
u32 curren... |
6c2f990105acd360e83b95b41c60ed8bf25e67fe | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6815): Fix vivi internal debug messages | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index 889e6611e039..0346d1af3e62 100644
--- a/drivers/media/video/vivi.c
+++ b/drivers/media/video/vivi.c
@@ -54,7 +54,6 @@
/* Declare static vars that will be used as parameters */
static unsigned int vid_limit = 16; /* Video memory limit... |
544e6175330c86ad87abeeb1b048f56bafd96c31 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6811): media-video-usbvision-add-mutex_unlock-to-error-paths-fix | Problem Details:
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Thierry MERLE <thierry.merle@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c
index d929ced58ec3..92e72910792b 100644
--- a/drivers/media/video/usbvision/usbvision-video.c
+++ b/drivers/media/video/usbvision/usbvision-video.c
@@ -1290,8 +1290,8 @@ static int usbvision_radio_open... |
0991112c1c4625323df8a582de1b2f8609922248 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6810): media: video: usbvision: add mutex_unlock() to error paths | Problem Details:
There are a few error paths which don't unlock the usbvision->lock.
So I've added mutex_unlock() calls to fix those paths.
Signed-off-by: Daniel Walker <dwalker@mvista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Thierry MERLE <thierry.merle@free.fr>
Signed-off-by: Mau... | ```diff
diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c
index e34f311124e3..d929ced58ec3 100644
--- a/drivers/media/video/usbvision/usbvision-video.c
+++ b/drivers/media/video/usbvision/usbvision-video.c
@@ -1290,6 +1290,7 @@ static int usbvision_radio_open... |
7cd355e7c0c02e499784c77e88720f7cc8f98473 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6809): git-dvb: drivers/media/video/et61x251/et61x251_core.c: fix warnings | Problem Details:
drivers/media/video/et61x251/et61x251_core.c:390: warning: 'et61x251_i2c_read' defined but not used
drivers/media/video/et61x251/et61x251_core.c:397: warning: 'et61x251_i2c_write' defined but not used
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mcheha... | ```diff
diff --git a/drivers/media/video/et61x251/et61x251_core.c b/drivers/media/video/et61x251/et61x251_core.c
index 38d2ad0aadef..06b6a3ae06c4 100644
--- a/drivers/media/video/et61x251/et61x251_core.c
+++ b/drivers/media/video/et61x251/et61x251_core.c
@@ -268,72 +268,6 @@ et61x251_i2c_wait(struct et61x251_device* ca... |
39b43b1a61f3c4b540b024843e592b14533aa961 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6808): git-dvb: fix build in drivers/media/dvb/frontends/tda18271.h | Problem Details:
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271.h b/drivers/media/dvb/frontends/tda18271.h
index d8400337263b..b98a9331c590 100644
--- a/drivers/media/dvb/frontends/tda18271.h
+++ b/drivers/media/dvb/frontends/tda18271.h
@@ -38,7 +38,7 @@ extern struct dvb_frontend *tda18271_attach(struct dvb_frontend *fe, u8... |
8996b3f3cfa9d21ba9ed31a116d5066e38827878 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6807): fix debug enable | Problem Details:
The changes at vivi_template make debug option to not work properly.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index 0b5c1426bb90..889e6611e039 100644
--- a/drivers/media/video/vivi.c
+++ b/drivers/media/video/vivi.c
@@ -1250,7 +1250,7 @@ MODULE_PARM_DESC(video_nr, "video iminor start number");
module_param(n_devs, int, 0);
MODULE_PARM_DESC(n_devs, "... |
a9622391acbcdb124b55eb674dc5196eb55dc105 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6792): Fix VBI support | Problem Details:
VBI were broken, since there weren't any function handlers for it. This patch
fixes it, by removing the vbi_template, using, instead video_template.
This also saves some space at the data segment.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c
index 92c48ee1591b..52baa4f7f7dd 100644
--- a/drivers/media/video/saa7134/saa7134-core.c
+++ b/drivers/media/video/saa7134/saa7134-core.c
@@ -1053,7 +1053,9 @@ static int __devinit saa7134_initdev(struct pci_dev... |
2dcf84b36c23a2c34207ab650071f9ee33d3c4a2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6788): tda8290: fix codingstyle, open brace following struct on the same line | Problem Details:
Fix codingstyle issue discovered after using new checkpatch.pl
ERROR: open brace '{' following struct go on the same line
396: FILE: linux/drivers/media/video/tda8290.h:24:
+struct tda829x_config
+{
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@in... | ```diff
diff --git a/drivers/media/video/tda8290.h b/drivers/media/video/tda8290.h
index 4c547577e7ca..7bce03183d08 100644
--- a/drivers/media/video/tda8290.h
+++ b/drivers/media/video/tda8290.h
@@ -20,8 +20,7 @@
#include <linux/i2c.h>
#include "dvb_frontend.h"
-struct tda829x_config
-{
+struct tda829x_config {
u... |
864a6b813ab6cb69f3552553899ae443329ecfa9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6787): tuner: bug-fix: default mode was set to bogus value | Problem Details:
Fix type inconsistency in t->mode value, causing the following:
tuner' 1-0043: freq set: unknown mode: 0x0004!
(only visible with tuner debug enabled)
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index 59e67c925758..355f9810facf 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -1138,11 +1138,11 @@ register_client:
/* Sets a default mode */
if (t->mode_mask & T_ANALOG_TV) {
- t->... |
fa746aee336fedfe25e6945e5967399966948420 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6784): tda8290: prevent possible memory leak | Problem Details:
Always call tda829x_release if tda829x_attach fails for a reason
other than failure to allocate memory for private structure.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tda8290.c b/drivers/media/video/tda8290.c
index 245b202560b5..a39cb1f9e875 100644
--- a/drivers/media/video/tda8290.c
+++ b/drivers/media/video/tda8290.c
@@ -704,7 +704,7 @@ int tda829x_attach(struct tuner *t)
}
if (tda829x_find_tuner(fe) < 0)
- return -EINVAL;
+ goto fa... |
14d5deba2737c59444e805c10764d58a3d73e9b2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6776): ivtv: Some general fixes | Problem Details:
Fix "warning: Using plain integer as NULL pointer".
Convert 'x < y ? x : y' to use min() instead.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-driver.c b/drivers/media/video/ivtv/ivtv-driver.c
index 4994dc59d40c..2765624b230f 100644
--- a/drivers/media/video/ivtv/ivtv-driver.c
+++ b/drivers/media/video/ivtv/ivtv-driver.c
@@ -983,7 +983,7 @@ static int __devinit ivtv_probe(struct pci_dev *dev,
}
itv = kz... |
e2c77314c9444c994087c96eb370b333d57657a7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6759): CodingStyle fixes | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c
index 26d1a5001738..9662d1e40a0c 100644
--- a/drivers/media/video/videobuf-core.c
+++ b/drivers/media/video/videobuf-core.c
@@ -22,29 +22,32 @@
#include <media/videobuf-core.h>
#define MAGIC_BUFFER 0x20070728
-#define MAG... |
f905c442e5b19f75fe4e8ce96f2acffa565f2392 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6753): Fix vivi to support non-zero minor node | Problem Details:
There were a trouble at vivi driver when using non-zero inodes. This where due
to not properly preserving the minor inode after calling video_register. Since
this driver is a reference for newer drivers, and it is possible to have more
than one video device inside the machine, this patch makes vivi to ... | ```diff
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index fe9784a0cc21..5ddaaa370cbc 100644
--- a/drivers/media/video/vivi.c
+++ b/drivers/media/video/vivi.c
@@ -170,7 +170,7 @@ struct vivi_dev {
int users;
/* various device info */
- struct video_device vfd;... |
d172b8bdab3812a6ad710e4cc78ceea3e8a40cd5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6749): v4l-nopage-fix | Problem Details:
dont just copy-and-paste stuff.
(compile-tested this time)
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/videobuf-dma-sg.c b/drivers/media/video/videobuf-dma-sg.c
index eea5b4ecfc3d..98efd7ab1f50 100644
--- a/drivers/media/video/videobuf-dma-sg.c
+++ b/drivers/media/video/videobuf-dma-sg.c
@@ -395,7 +395,8 @@ videobuf_vm_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
pag... |
4a56eb3f535f92b0585aa01dba05b3f17a547df0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6743): cx25840: fix endianness inconsistency | Problem Details:
cx25840_read4 reads a little-endian 32-bit value whereas cx25840_write4 writes
the 32-bit value as big-endian. Convert write4 to use little-endian as well
(that's the correct endianness).
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx25840/cx25840-audio.c b/drivers/media/video/cx25840/cx25840-audio.c
index 3d46a776df36..51fc0af01578 100644
--- a/drivers/media/video/cx25840/cx25840-audio.c
+++ b/drivers/media/video/cx25840/cx25840-audio.c
@@ -38,71 +38,71 @@ static int set_audclk_freq(struct i2c_client *cli... |
6b1e56763b50f169d8446c43df6adb70f69552db | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6742): ivtv: fix incorrect debug message | Problem Details:
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-irq.c b/drivers/media/video/ivtv/ivtv-irq.c
index ebc200320e6f..c5ea54e65272 100644
--- a/drivers/media/video/ivtv/ivtv-irq.c
+++ b/drivers/media/video/ivtv/ivtv-irq.c
@@ -436,7 +436,7 @@ static void ivtv_dma_enc_start(struct ivtv_stream *s)
s_vbi->sg_pending_size =... |
8c85454a5963747fca7d0699e2450f676314c176 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6736): Fix some errors at the video_ioctl2 conversion | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c
index cbddd35f1618..92c48ee1591b 100644
--- a/drivers/media/video/saa7134/saa7134-core.c
+++ b/drivers/media/video/saa7134/saa7134-core.c
@@ -834,6 +834,7 @@ static struct video_device *vdev_init(struct saa7134_... |
5d2bf930a2f4586a3e19318ed821a34193c4b7cd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6728): tda18271: fix register dump format | Problem Details:
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271-fe.c b/drivers/media/dvb/frontends/tda18271-fe.c
index 5d3c4b0975f6..e8f4ac2325da 100644
--- a/drivers/media/dvb/frontends/tda18271-fe.c
+++ b/drivers/media/dvb/frontends/tda18271-fe.c
@@ -72,22 +72,22 @@ static void tda18271_dump_regs(struct dvb_frontend *fe)
... |
293da0ec468addf891856e9ffee88af2fd00e25a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6725): tda18271: improve debug flexibility | Problem Details:
converted debug module option to an or-able setting.
1 = info
2 = table map values
4 = register dumps
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271-fe.c b/drivers/media/dvb/frontends/tda18271-fe.c
index 1944177da873..01de75e369ed 100644
--- a/drivers/media/dvb/frontends/tda18271-fe.c
+++ b/drivers/media/dvb/frontends/tda18271-fe.c
@@ -27,12 +27,20 @@
static int tda18271_debug;
module_param_named(debug, ... |
166983cdfbb2779bec98de89927669ed4c9ff8f2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6714): ivtv: yuv frame parameter fix | Problem Details:
Inadvertently missed a line when converting code to new hardware buffering
method. In some circumstances, this would lead to a frame being displayed
using parameters belonging to another frame.
Signed-off-by: Ian Armstrong <ian@iarmst.demon.co.uk>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signe... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-irq.c b/drivers/media/video/ivtv/ivtv-irq.c
index fc8eac09584c..8c00d8f6d4d9 100644
--- a/drivers/media/video/ivtv/ivtv-irq.c
+++ b/drivers/media/video/ivtv/ivtv-irq.c
@@ -797,7 +797,7 @@ static void ivtv_irq_vsync(struct ivtv *itv)
/* Check if we need to update the... |
26e33048aad0486c98155b1406037f02fe70cb1b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6706): pvrusb2: Remove use of volatile in command sequencer | Problem Details:
pvrusb2: Remove use of volatile for command sequencer; these variables
are set by interrupt-context code and we check their state in such a
manner that there should be no race conditions. This had originally
been done out of paranoia, and I have since been convinced that the
paranoia is not required.
... | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h b/drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h
index 894c630c95c0..c79d3a68dbd7 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h
+++ b/drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h
@@ -217,9 +217,9 @@ struct pvr2_hdw {
s... |
482cb9a75ba5df68f4bcbe806c838eaf28af34c0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6702): pvrusb2: fix typo in comments | Problem Details:
Firmware file name(s) for 24xxx devices
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-devattr.c b/drivers/media/video/pvrusb2/pvrusb2-devattr.c
index e0a5bb9a9587..e4a311a81000 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-devattr.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-devattr.c
@@ -71,7 +71,7 @@ static const char *pvr2_fw1_names_29xxx[] =... |
493977f016f2ff52fdca38d031c7211b4da658fd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6688): V4L: fix copy and paste error in dprintk for videobuf-vmalloc.c | Problem Details:
Signed-off-by: Brandon Philips <bphilips@suse.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/videobuf-vmalloc.c b/drivers/media/video/videobuf-vmalloc.c
index e01259438bb2..9b3898347ca5 100644
--- a/drivers/media/video/videobuf-vmalloc.c
+++ b/drivers/media/video/videobuf-vmalloc.c
@@ -41,7 +41,7 @@ MODULE_AUTHOR("Mauro Carvalho Chehab <mchehab@infradead.org>");
MODULE... |
5c15648a42016eebb9870dc3af44e94bca4f3604 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6683): Fix DVB compatibility | Problem Details:
DVB-S is not supported. Also, there are some QAM6 firmwares for xc3028, but it
is reported that this doesn't work fine.
Thanks to Manu Abraham, Michael Krufky and Patrick Boettcher for their
insights.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index e1796ebb7c71..7acc175d805a 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -957,12 +957,14 @@ static int xc2028_set_params(struct dvb_frontend *fe,
type |= D2620;
switch(... |
54465b082cc86921aa7d7b638d75803e6d919f25 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6681): tda18271: rename 'debug' to 'tda18271_debug' | Problem Details:
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271-fe.c b/drivers/media/dvb/frontends/tda18271-fe.c
index ba980cf5811b..726e102cbc5d 100644
--- a/drivers/media/dvb/frontends/tda18271-fe.c
+++ b/drivers/media/dvb/frontends/tda18271-fe.c
@@ -25,12 +25,12 @@
#include "tda18271.h"
#include "tda18271-priv.h"
-sta... |
63806eeb61dcdf30fdbf488babff98aea2ca3f08 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6677): Fix xc2028 driver for non OFDM | Problem Details:
A previous patch implemented support for non-OFDM digital TV. However, the
previous bandwidth ofdm parameter were left at the code by mistake.
Thanks to Michael Krufky and Patrick Boettcher for noticing this mistake.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index cf72f22986a4..e1796ebb7c71 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -972,8 +972,6 @@ static int xc2028_set_params(struct dvb_frontend *fe,
break;
}
- bw = p->u.ofd... |
3203cb86d22c63504f8368151029bf9dad014ddb | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6668): Fix theoretical races between IRQ handler and .suspend/resume | Problem Details:
*dev->insuspend = 1 should be set before synchronize_irq
*ACK interrupts after synchronize_irq, to make sure there aren't
pending interrupts.
*Add barrier before we restart interrupts so the handler will 100%
see the dev->insuspend
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off... | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c
index 40cdec26a7f4..85c165d17301 100644
--- a/drivers/media/video/saa7134/saa7134-core.c
+++ b/drivers/media/video/saa7134/saa7134-core.c
@@ -1181,8 +1181,13 @@ static int saa7134_suspend(struct pci_dev *pci_dev... |
0d65cd4f2bfe70872e4218d9d35d37a7000d6739 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6667): Fix access to configuration space while in D3 | Problem Details:
pci_save_state should be called before pci_set_power_state
and pci_restore_state after pci_set_power_state
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c
index 76410f5bdcdd..40cdec26a7f4 100644
--- a/drivers/media/video/saa7134/saa7134-core.c
+++ b/drivers/media/video/saa7134/saa7134-core.c
@@ -1194,10 +1194,10 @@ static int saa7134_suspend(struct pci_dev *pci_de... |
c23f5949c0eeec328c872f29c8f4c233e73c3c4d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6665): Fix CodingStyle | Problem Details:
thanks to checkpatch.pl
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c
index 29e935f41098..c4204c90fb01 100644
--- a/drivers/media/video/em28xx/em28xx-cards.c
+++ b/drivers/media/video/em28xx/em28xx-cards.c
@@ -1,5 +1,6 @@
/*
- em28xx-cards.c - driver for Empia EM2800/EM2820/2840 ... |
cca83798119c92a3086af9e8a0419360c63aeadd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6662): Fix standard selection for PAL | Problem Details:
Not all 8MHz firmware are marked with F8MHz.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index a43a3398b7c0..1f14892a883a 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -734,6 +734,9 @@ skip_base:
new_fw.id |= parse_audio_std_option();
rc = load_firmware(fe, new_f... |
c71d4bc512dda42069c70219bd00315a91550367 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6657): Fix standard selection for PAL/M, PAL/N, PAL/Nc and NTSC | Problem Details:
Those standards use 6 MHz firmware.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 429e81be697e..911831442b59 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -910,12 +910,18 @@ static int xc2028_set_tv_freq(struct dvb_frontend *fe,
struct analog_para... |
2ce4b3aa7c3c199466ae9f5ed32ea177912c8c3a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6639): xc2028: correct divisor length | Problem Details:
The frequency divisor should only be four bytes long. Also, display the
frequency and divisor correctly in the debug output.
Signed-off-by: Chris Pascoe <c.pascoe@itee.uq.edu.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 7c86971a8d64..e85992f970f7 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -740,7 +740,7 @@ static int generic_set_tv_freq(struct dvb_frontend *fe, u32 freq /* in Hz */ ,
{
s... |
3157ecef3bce47df74427d6656fa8592bfe8d2d7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6634): xc2028: error messages missing whitespace | Problem Details:
Fix some missing spaces in errors that may be emitted during attach failure.
Signed-off-by: Chris Pascoe <c.pascoe@itee.uq.edu.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index a49a4e886897..c208f1f5e72c 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -928,13 +928,13 @@ void *xc2028_attach(struct dvb_frontend *fe, struct xc2028_config *cfg)
void ... |
e155d908f72cc429b538c101ee8ffcd10a44b69b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6632): xc2028: fix inverted logic in audio standard check | Problem Details:
strcasecmp returns 0 on match, not true.
Signed-off-by: Chris Pascoe <c.pascoe@itee.uq.edu.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 6e23fad0e560..166fede7d0e3 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -200,17 +200,17 @@ void dump_firm_type(unsigned int type)
static v4l2_std_id parse_audio_std_optio... |
255c1887ccca6cde4a2eac231623b925bf621540 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6622): tda827x: prevent possible NULL pointer dereference in tda827xa_lna_gain | Problem Details:
If tda827x_config hasn't been defined, exit the function.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda827x.c b/drivers/media/dvb/frontends/tda827x.c
index 50adfb5395ec..229b11987a58 100644
--- a/drivers/media/dvb/frontends/tda827x.c
+++ b/drivers/media/dvb/frontends/tda827x.c
@@ -556,6 +556,11 @@ static void tda827xa_lna_gain(struct dvb_frontend *fe, int high,
struc... |
3b0c453aa78be253b4414cd337c9975f91e2c894 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6621): tda827x: fix NULL pointer dereference during tda827x_probe_version | Problem Details:
Fix the following oops:
[ 750.807586] CPU: 1
[ 750.807587] EIP: 0060:[<f9dde2a3>] Tainted: P VLI
[ 750.807589] EFLAGS: 00010296 (2.6.22-14-generic #1)
[ 750.807599] EIP is at tda827x_probe_version+0xc3/0x130 [tda827x]
[ 750.807603] eax: 00000000 ebx: f5a45a00 ecx: 00000000 ... | ```diff
diff --git a/drivers/media/dvb/frontends/tda827x.c b/drivers/media/dvb/frontends/tda827x.c
index 8329d33b517a..50adfb5395ec 100644
--- a/drivers/media/dvb/frontends/tda827x.c
+++ b/drivers/media/dvb/frontends/tda827x.c
@@ -796,11 +796,13 @@ static int tda827x_probe_version(struct dvb_frontend *fe)
dprintk("t... |
ef8c1888b32132ae48553a8ce00d5858ec3e9b51 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6614): Fix driver for i386 architectures | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028-types.h b/drivers/media/video/tuner-xc2028-types.h
index 388884491f47..a9e2e0562d99 100644
--- a/drivers/media/video/tuner-xc2028-types.h
+++ b/drivers/media/video/tuner-xc2028-types.h
@@ -82,13 +82,13 @@
/* Audio types */
-#define V4L2_STD_A2_A (1L<<32)
-#def... |
2d4c0ac60dbcdee83da5bdebc661c2c145938d8a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6613): Fix: add a missing continue statement | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 89e6e64786ea..748f9ad08b88 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -477,6 +477,7 @@ static int load_firmware(struct dvb_frontend *fe, unsigned int type,
return -EIN... |
2fc580ffeb551066f769934e3a4717d721d0a559 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6610): Fix a wrong typecast | Problem Details:
Signed-off-by: Michel Ludwig <michel.ludwig@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 371e822fb4cc..c64eae2c7ec2 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -311,7 +311,7 @@ static int load_all_firmwares(struct dvb_frontend *fe)
id = le64_to_cpu(*(v4l2_std... |
1414becf15da1701b0c45e9c82b1f120cb676a36 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6598): Fix standard name | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028-types.h b/drivers/media/video/tuner-xc2028-types.h
index f6695d413563..388884491f47 100644
--- a/drivers/media/video/tuner-xc2028-types.h
+++ b/drivers/media/video/tuner-xc2028-types.h
@@ -88,7 +88,7 @@
#define V4L2_STD_NICAM_B (1L<<35)
#define V4L2_STD_AM (1L<<3... |
83fb340b3184875a63564ea174350b1d1b081874 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6595): Corrects printk lines | Problem Details:
Make the driver less verbose by default. It adds a debug parameter to make the
driver more verbose.
Also, error messages were using KERN_ERR level, instead of KERN_INFO.
A few printk messages were reviewed to make them more clear.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index e046c21be0b9..492181d8de87 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -24,6 +24,10 @@
#define PREFIX "xc2028"
+static int debug;
+module_param(debug, int, 0644);
+MODU... |
f380e1d2c9a1ff82a89ec68850ce53094359000e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6593): Fix scode table loading | Problem Details:
Xceive 2028/3028 has a concept of scode/dcode.
Scode is a table of 16 values (each with 12 bytes i2c sequence).
Dcode is the entry of Scode table that should be used, given a certain
frequency.
The idea is that, depending on what frequency is selected, and according with a
country-based (or standard-b... | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index ac0c9c3cde98..e046c21be0b9 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -116,6 +116,8 @@ void dump_firm_type(unsigned int type)
{
if (type & BASE)
printk("BASE ");
+ ... |
9e31ced888d1ca49ec5be51ef295e3ce994366c4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6584): Fix read() method | Problem Details:
Backport read() fixes from Markus Rechberger.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index f0191779a8e2..8a4d221a4fe4 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -416,6 +416,9 @@ em28xx_v4l2_read(struct file *filp, char __user * buf, si... |
a225452ef80a7bd894fd2dfd01a4973d444152f4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6583): Fix em28xx read stream locking | Problem Details:
On some situations, closing an streaming application and re-opening were
returning -EBUSY.
Uses the same locking schema also present on cx88.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 5b17ca9cad11..f0191779a8e2 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -225,6 +225,44 @@ static void video_mux(struct em28xx *dev, int index)
}... |
a3a048cea301baba5d451991074a85dc20a8f228 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6582): Fix em28xx to allow multiple open | Problem Details:
Allows shared access support for em28xx. Just one userspace application is
allowed to get stream. The other(s) application(s) can change V4L2 controls,
set video standards, etc.
This patch were splited from Markus Rechberger's tree and backported to 2.6.17
by Pádraig Brady.
The original patch were po... | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index b43edc3fa23e..5b17ca9cad11 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -234,6 +234,7 @@ static int em28xx_v4l2_open(struct inode *inode, struct f... |
53133afbeeb177487a907fdc2edf18f857497641 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6578): dvb-usb: make some debug vars static | Problem Details:
This patch makes some needlessly global debug variables static.
opera1.h became so small that I removed it.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/cxusb.c b/drivers/media/dvb/dvb-usb/cxusb.c
index 04e31cf7d530..5b6431ea38c1 100644
--- a/drivers/media/dvb/dvb-usb/cxusb.c
+++ b/drivers/media/dvb/dvb-usb/cxusb.c
@@ -32,9 +32,12 @@
#include "zl10353.h"
/* debug */
-int dvb_usb_cxusb_debug;
+static int dvb_usb_cxusb_d... |
c80296d755df29167deafa53e612644a95b40c6e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6564): Move check before lock | Problem Details:
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
CC: Antti Palosaari <crope@iki.fi>
CC: Carl Lundqvist <comabug@gmail.com>
CC: Aapo Tahkola <aet@rasterburn.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/au6610.c b/drivers/media/dvb/dvb-usb/au6610.c
index 18e0b16fb2a9..f3ff81314696 100644
--- a/drivers/media/dvb/dvb-usb/au6610.c
+++ b/drivers/media/dvb/dvb-usb/au6610.c
@@ -79,12 +79,12 @@ static int au6610_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msg[],
struct d... |
80b522085a2c870ba0c0bdf2415cc925d7c86ca5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6561): Fix xc2028 get register functions and calls | Problem Details:
The status registers require a dword for setting register. Fix it on all
occurrences, and at xc3028_get_reg. Also, improves the hardware/firmware
detection printk.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index b4c88ed12a8a..ecfc39036f90 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -91,16 +91,17 @@ struct xc2028_data {
msleep(10); \
} while (0)
-static int xc2028_get_reg(... |
f8b6030ccca06bf0d45d9b0908caac9b624a9beb | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6560): Fix a bug when setting tuner type | Problem Details:
Tuner-type were correctly filled only by the hint function.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c
index e88bf6700e63..b1afc6c2d372 100644
--- a/drivers/media/video/em28xx/em28xx-cards.c
+++ b/drivers/media/video/em28xx/em28xx-cards.c
@@ -564,8 +564,26 @@ static int em28xx_hint_board(struct em28xx *dev)
retur... |
b873e1a3ccf9e04d2de85db0d510ec4b793fe569 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6559): Fix a buffer overflow at xc2028_get_reg | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 80d14020c78d..b4c88ed12a8a 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -94,13 +94,13 @@ struct xc2028_data {
static int xc2028_get_reg(struct xc2028_data *priv, u16 reg)
{... |
232fcefb55e67cf38176a1e5c188a04694445f11 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB(6548b) Fix compilation for em28xx | Problem Details:
From: Mauro Carvalho Chehab <mchehab@infradead.org>
In file included from drivers/media/video/em28xx/em28xx-i2c.c:31:
drivers/media/video/tuner-xc2028.h:10:26: error: dvb_frontend.h: No such file or directory
In file included from drivers/media/video/em28xx/em28xx-i2c.c:31:
drivers/media/video/tuner-... | ```diff
diff --git a/drivers/media/video/em28xx/Makefile b/drivers/media/video/em28xx/Makefile
index 826d0e340753..7e7a93d75c34 100644
--- a/drivers/media/video/em28xx/Makefile
+++ b/drivers/media/video/em28xx/Makefile
@@ -4,3 +4,6 @@ em28xx-objs := em28xx-video.o em28xx-i2c.o em28xx-cards.o em28xx-core.o \
obj-$(... |
e3e97fe61f25aa36b96afe2f16a915dd966c70b0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB(6548a) Fix compilation for TDA8290 | Problem Details:
From: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/tda8290.c:27:21: error: tda827x.h: No such file or directory
drivers/media/video/tda8290.c:28:22: error: tda18271.h: No such file or directory
drivers/media/video/tda8290.c:52: error: field 'cfg' has incomplete type
drivers/media/... | ```diff
diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
index d8910d87acaa..a837e1ea518f 100644
--- a/drivers/media/video/Makefile
+++ b/drivers/media/video/Makefile
@@ -132,3 +132,4 @@ obj-$(CONFIG_VIDEO_VIVI) += vivi.o
obj-$(CONFIG_VIDEO_CX23885) += cx23885/
EXTRA_CFLAGS += -Idrivers/medi... |
5a80415bcabf2b59e8c34db6e743c54582cfd3c2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6538): em28xx: fix locking to allow accesses from 2 different threads at the same time | Problem Details:
The attached patch modifies the em28xx driver so that there can be ioctls from
multiple different threads.
This is necessary for capture apps like MPlayer that use different threads for
capturing and channel tuning.
Now the locking is only done for the ioctls that change properties of the
device or a... | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 18b8568c634c..bc495a11dc2d 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -126,8 +126,6 @@ static struct v4l2_queryctrl em28xx_qctrl[] = {
static... |
3dbd85ba36ff74af87550e76f5765a768b108409 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6535): Fix: Adds the generic PCI IDs for em28xx | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/Documentation/video4linux/CARDLIST.em28xx b/Documentation/video4linux/CARDLIST.em28xx
index abdcc68d47f9..f947dca5ac48 100644
--- a/Documentation/video4linux/CARDLIST.em28xx
+++ b/Documentation/video4linux/CARDLIST.em28xx
@@ -1,9 +1,9 @@
0 -> Unknown EM2800 video grabber (em2800) ... |
7d070e26a868bd72f0d32189e0f3ceba47d2db82 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6519): Fix HVR900/HVR950 entry | Problem Details:
- Television is now default;
- Add HVR950 name at the entry.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/Documentation/video4linux/CARDLIST.em28xx b/Documentation/video4linux/CARDLIST.em28xx
index 37f0e3cedf43..abdcc68d47f9 100644
--- a/Documentation/video4linux/CARDLIST.em28xx
+++ b/Documentation/video4linux/CARDLIST.em28xx
@@ -8,7 +8,7 @@
7 -> Leadtek Winfast USB II (em2800)
... |
8ae1fe2a0935afa878b8a506633fea45a8b00293 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6508): ttpci: Rework Kconfig menus and Makefile | Problem Details:
The ttpci Kconfig file has bugs that cause it to fail in certain Kconfig
situations. The basic problem is that it selects certain drivers, but does
not depend on the dependencies of those drivers.
See http://article.gmane.org/gmane.comp.video.video4linux/35072
Using the Kconfig file also has some an... | ```diff
diff --git a/drivers/media/common/Kconfig b/drivers/media/common/Kconfig
index c5092ef1082f..06ca75911b7f 100644
--- a/drivers/media/common/Kconfig
+++ b/drivers/media/common/Kconfig
@@ -1,6 +1,6 @@
config VIDEO_SAA7146
tristate
- depends on I2C
+ depends on I2C && PCI
config VIDEO_SAA7146_VV
tristate
d... |
4942744f93884cb462400c66258c0013bea65dcf | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6491): tuner: prevent repeated "type set" message unless debug is enabled | Problem Details:
The tuner sub-module will usually log its type during its _attach() function,
then tuner-core reports which type was attached when control is returned.
In most cases, we expect to see the same message reported from both locations.
We only need to see this second message if debug is enabled.
Signed-of... | ```diff
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index cd5f0d8e693c..b92efe0460f3 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -366,7 +366,7 @@ static void set_type(struct i2c_client *c, unsigned int type,
t->fe.analog_demod_priv = t;... |
1808a698a87366f9d82945270355c2139df0a16d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6475): Fix some troubles at list handling | Problem Details:
- priv->count were wrong. Should be incremented since the first usage;
- forgot to use list_del() to remove the driver;
- Release memory if an error occurs during _attach
Thanks to Aidan Thornton <makosoft@googlemail.com> for pointing this.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 7d53d58aafa1..c5bdeff54288 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -639,6 +639,8 @@ static int xc2028_dvb_release(struct dvb_frontend *fe)
priv->count--;
if (!priv... |
6f998742f09a7116f1232cebc87a814e3aca639a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6446): tda18271: clean up debug macros | Problem Details:
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda18271.c b/drivers/media/dvb/frontends/tda18271.c
index 3395f2bda498..1b9c143888ea 100644
--- a/drivers/media/dvb/frontends/tda18271.c
+++ b/drivers/media/dvb/frontends/tda18271.c
@@ -28,13 +28,9 @@ static int debug;
module_param(debug, int, 0644);
MODULE_PARM_DESC(d... |
e2be32ac8017d1bcb293f8c11c046ff654991385 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6437): tuner: clear analog_demod_ops on release | Problem Details:
Clear analog_demod_ops on release.
Fix test for analog_demod_ops after tuner attach.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Reviewed-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index f31de98bbfa5..9de66769b623 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -101,6 +101,8 @@ static void fe_release(struct tuner *t)
if (fe_tuner_ops->release)
fe_tuner_ops->relea... |
ce1f8bdb0cbe9c5f57cf0256ef75fce06152547f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6434): tda827x: fix GPL export on attach function | Problem Details:
EXPORT_SYMBOL should have been EXPORT_SYMBOL_GPL
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Reviewed-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda827x.c b/drivers/media/dvb/frontends/tda827x.c
index 3c71f07a6d2c..6de1aea02d51 100644
--- a/drivers/media/dvb/frontends/tda827x.c
+++ b/drivers/media/dvb/frontends/tda827x.c
@@ -775,7 +775,7 @@ struct dvb_frontend *tda827x_attach(struct dvb_frontend *fe, int addr,
... |
2e4160ca8046e3c35277bed62b2c180427d57dd7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6426): Some fixes on tuner-xc2028 | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-xc2028.c b/drivers/media/video/tuner-xc2028.c
index 2bb695490ab2..838db8187a9c 100644
--- a/drivers/media/video/tuner-xc2028.c
+++ b/drivers/media/video/tuner-xc2028.c
@@ -24,15 +24,19 @@
#define V4L2_STD_DTV_8MHZ ((v4l2_std_id)0x10000000)
/* Firmwares used on tm... |
e92adc2c39aaaa0129b7b97584784a8ba9da9ec4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6404): cx23885: i2c 16bit reg/val read/write fix | Problem Details:
Fix i2c reads and writes of 16bit register address / values
Signed-off-by: Steven Toth <stoth@hauppauge.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx23885/cx23885-i2c.c b/drivers/media/video/cx23885/cx23885-i2c.c
index 71da528932df..f7e8a481696d 100644
--- a/drivers/media/video/cx23885/cx23885-i2c.c
+++ b/drivers/media/video/cx23885/cx23885-i2c.c
@@ -84,7 +84,8 @@ static int i2c_sendbytes(struct i2c_adapter *i2c_adap,
u3... |
01c785dcb4e9fd6c4c370fd9915fc10585ed64bd | Analyze and fix the following issue in the Linux kernel code: [WATCHDOG] wdt: fix locking | Problem Details:
The audit of _p usage shows various drivers assume inb_p is somehow atomic.
Of course it isn't and the delay can be split from the I/O cycle causing a
timing violation on chips that matter (eg this one)
With the proposed use of udelay() for some _p delays this will cease to be
a mostly theoretical bu... | ```diff
diff --git a/drivers/watchdog/wdt.c b/drivers/watchdog/wdt.c
index 53d0bb410df8..756fb15fdce7 100644
--- a/drivers/watchdog/wdt.c
+++ b/drivers/watchdog/wdt.c
@@ -70,6 +70,8 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" _
static int io=0x240;
static int irq=11;
+static DE... |
5973e5b954848c63855a357ad4ff39882e3904f7 | Analyze and fix the following issue in the Linux kernel code: sched: fix: don't take a mutex from interrupt context | Problem Details:
print_cfs_stats is callable from interrupt context (sysrq), hence it should
not take mutexes. Change it to use RCU since the task group data is RCU
freed anyway.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 1b3b40ad7c54..45ff4e9411e0 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -1434,9 +1434,9 @@ static void print_cfs_stats(struct seq_file *m, int cpu)
#ifdef CONFIG_FAIR_GROUP_SCHED
print_cfs_rq(m, cpu, &cpu_rq(cpu)->cfs);
#endif
- l... |
90739081ef8d5495d50abba9c5d333be9acd872a | Analyze and fix the following issue in the Linux kernel code: softlockup: fix signedness | Problem Details:
fix softlockup tunables signedness.
mark tunables read-mostly.
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/linux/sched.h b/include/linux/sched.h
index dfc76e172f3f..53534f90a96a 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -269,10 +269,10 @@ extern void softlockup_tick(void);
extern void spawn_softlockup_task(void);
extern void touch_softlockup_watchdog(void);
extern void... |
326587b840785c60f5dc18557235a23bafefd620 | Analyze and fix the following issue in the Linux kernel code: sched: fix goto retry in pick_next_task_rt() | Problem Details:
looking at it one more time:
(1) it looks to me that there is no need to call
sched_rt_ratio_exceeded() from pick_next_rt_entity()
- [ for CONFIG_FAIR_GROUP_SCHED ] queues with rt_rq->rt_throttled are
not within this 'tree-like hierarchy' (or whatever we should call it
:-)
- there is also no need to... | ```diff
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 2dac5ebb8bcb..274b40d7bef2 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -476,15 +476,12 @@ static struct sched_rt_entity *pick_next_rt_entity(struct rq *rq,
struct list_head *queue;
int idx;
- if (sched_rt_ratio_exceeded(rt_rq))
- goto... |
cc203d2422004498909c4886d1b94a2e388d973e | Analyze and fix the following issue in the Linux kernel code: sched: monitor clock underflows in /proc/sched_debug | Problem Details:
We monitor clock overflows, let's also monitor clock underflows.
Signed-off-by: Guillaume Chazarain <guichaz@yahoo.fr>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/kernel/sched.c b/kernel/sched.c
index 3995d1679858..4d3a5a700866 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -465,7 +465,7 @@ struct rq {
u64 clock, prev_clock_raw;
s64 clock_max_delta;
- unsigned int clock_warps, clock_overflows;
+ unsigned int clock_warps, clock_overflows, clock_und... |
782daeee3d596282bfee4cd9e976c86be0e194a8 | Analyze and fix the following issue in the Linux kernel code: sched: fix rq->clock warps on frequency changes | Problem Details:
sched: fix rq->clock warps on frequency changes
Fix 2bacec8c318ca0418c0ee9ac662ee44207765dd4
(sched: touch softlockup watchdog after idling) that reintroduced warps
on frequency changes. touch_softlockup_watchdog() calls __update_rq_clock
that checks rq->clock for warps, so call it after adjusting rq-... | ```diff
diff --git a/kernel/sched.c b/kernel/sched.c
index 629614ad0358..3995d1679858 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -858,7 +858,6 @@ void sched_clock_idle_wakeup_event(u64 delta_ns)
struct rq *rq = cpu_rq(smp_processor_id());
u64 now = sched_clock();
- touch_softlockup_watchdog();
rq->idle... |
4f05b98d54b140ed3c5851d5d5156e9918c6305d | Analyze and fix the following issue in the Linux kernel code: sched: fix, always create kernel threads with normal priority | Problem Details:
Ensure that the kernel threads are created with the usual nice level
and affinity even if kthreadd's properties were changed from the
default by root.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/kernel/kthread.c b/kernel/kthread.c
index dcfe724300eb..0ac887882f90 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -15,6 +15,8 @@
#include <linux/mutex.h>
#include <asm/semaphore.h>
+#define KTHREAD_NICE_LEVEL (-5)
+
static DEFINE_SPINLOCK(kthread_create_lock);
static LIST_HEAD(kthr... |
1ad82fd547c716f96e544b477e0bdbfa2d647529 | Analyze and fix the following issue in the Linux kernel code: debug: clean up kernel/profile.c | Problem Details:
Before:
total: 25 errors, 13 warnings, 602 lines checked
After:
total: 0 errors, 2 warnings, 601 lines checked
No code changed:
kernel/profile.o:
text data bss dec hex filename
3048 236 24 3308 cec profile.o.before
3048 236 24 3308 cec profi... | ```diff
diff --git a/kernel/profile.c b/kernel/profile.c
index 5e95330e5120..e64c2da11c0f 100644
--- a/kernel/profile.c
+++ b/kernel/profile.c
@@ -52,7 +52,7 @@ static DEFINE_PER_CPU(int, cpu_profile_flip);
static DEFINE_MUTEX(profile_flip_mutex);
#endif /* CONFIG_SMP */
-static int __init profile_setup(char * str)... |
e14af7eeb47ea96c52741c5e5fa010d33daf6973 | Analyze and fix the following issue in the Linux kernel code: debug: track and print last unloaded module in the oops trace | Problem Details:
Based on a suggestion from Andi:
In various cases, the unload of a module may leave some bad state around
that causes a kernel crash AFTER a module is unloaded; and it's then hard
to find which module caused that.
This patch tracks the last unloaded module, and prints this as part of the
module li... | ```diff
diff --git a/kernel/module.c b/kernel/module.c
index 5bbf225ca07a..1bb4c5e0d56e 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -496,6 +496,8 @@ static struct module_attribute modinfo_##field = { \
MODINFO_ATTR(version);
MODINFO_ATTR(srcversion);
+static char last_unloaded_module[MO... |
21aa9280b9f4e9e68d3fa8990df6c9d7fd71f994 | Analyze and fix the following issue in the Linux kernel code: debug: show being-loaded/being-unloaded indicator for modules | Problem Details:
It's rather common that an oops/WARN_ON/BUG happens during the load or
unload of a module. Unfortunatly, it's not always easy to see directly
which module is being loaded/unloaded from the oops itself. Worse,
it's not even always possible to ask the bug reporter, since there
are so many components (ude... | ```diff
diff --git a/kernel/module.c b/kernel/module.c
index dcb8a2cbf75e..5bbf225ca07a 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2357,21 +2357,30 @@ static void m_stop(struct seq_file *m, void *p)
mutex_unlock(&module_mutex);
}
-static char *taint_flags(unsigned int taints, char *buf)
+static char *m... |
5a52dd50091b6a6e710a1293db741028f8cc5aac | Analyze and fix the following issue in the Linux kernel code: sched: rt-watchdog: fix .rlim_max = RLIM_INFINITY | Problem Details:
Remove the curious logic to set it_sched_expires in the future. It useless
because rt.timeout wouldn't be incremented anyway.
Explicity check for RLIM_INFINITY as a test programm that had a 1s soft limit
and a inf hard limit would SIGKILL at 1s. This is because RLIM_INFINITY+d-1
is d-2.
Signed-off-by... | ```diff
diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c
index 2c076b36c4f6..0b7c82ac467e 100644
--- a/kernel/posix-cpu-timers.c
+++ b/kernel/posix-cpu-timers.c
@@ -1020,7 +1020,8 @@ static void check_thread_timers(struct task_struct *tsk,
unsigned long hard = sig->rlim[RLIMIT_RTTIME].rlim_max;
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.