id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
c361be55b3128474aa66d31092db330b07539103 | Analyze and fix the following issue in the Linux kernel code: Move free pages between lists on steal | Problem Details:
When a fallback occurs, there will be free pages for one allocation type
stored on the list for another. When a large steal occurs, this patch will
move all the free pages within one list to the other.
[y-goto@jp.fujitsu.com: fix BUG_ON check at move_freepages()]
[apw@shadowen.org: Move to using pfn_... | ```diff
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index aa7e5d2f28a5..d575a3ee8dd8 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -680,6 +680,72 @@ static int fallbacks[MIGRATE_TYPES][MIGRATE_TYPES-1] = {
[MIGRATE_MOVABLE] = { MIGRATE_UNMOVABLE },
};
+/*
+ * Move the free pages in a range to the free... |
835c134ec4dd755e5c4470af566db226d1e96742 | Analyze and fix the following issue in the Linux kernel code: Add a bitmap that is used to track flags affecting a block of pages | Problem Details:
Here is the latest revision of the anti-fragmentation patches. Of particular
note in this version is special treatment of high-order atomic allocations.
Care is taken to group them together and avoid grouping pages of other types
near them. Artifical tests imply that it works. I'm trying to get the
... | ```diff
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index f6167f2fd7fb..322e8048463e 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -13,6 +13,7 @@
#include <linux/init.h>
#include <linux/seqlock.h>
#include <linux/nodemask.h>
+#include <linux/pageblock-flags.h>
#include <asm/at... |
6cb062296f73e74768cca2f3eaf90deac54de02d | Analyze and fix the following issue in the Linux kernel code: Categorize GFP flags | Problem Details:
The function of GFP_LEVEL_MASK seems to be unclear. In order to clear up
the mystery we get rid of it and replace GFP_LEVEL_MASK with 3 sets of GFP
flags:
GFP_RECLAIM_MASK Flags used to control page allocator reclaim behavior.
GFP_CONSTRAINT_MASK Flags used to limit where allocations can occur.
GFP... | ```diff
diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index 12a90a191c11..da8aa872eb6e 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -53,13 +53,6 @@ struct vm_area_struct;
#define __GFP_BITS_SHIFT 20 /* Room for 20 __GFP_FOO bits */
#define __GFP_BITS_MASK ((__force gfp_t)((1 << __GFP_BITS_SH... |
58c0a4a7864b2dad6da4090813322fcd29a11c92 | Analyze and fix the following issue in the Linux kernel code: Fix panic of cpu online with memory less node | Problem Details:
When a cpu is onlined on memory-less-node box, kernel panics due to touch
NULL pointer of pgdat->kswapd. Current kswapd runs only nodes which have
memory. So, calling of set_cpus_allowed() is not necessary for memory-less
node.
This is fix for it.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com... | ```diff
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 8fd8ba1c67b4..cb8ad3c6e483 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1694,9 +1694,11 @@ static int __devinit cpu_callback(struct notifier_block *nfb,
{
pg_data_t *pgdat;
cpumask_t mask;
+ int nid;
if (action == CPU_ONLINE || action == CPU_ONLINE_FROZEN)... |
37b07e4163f7306aa735a6e250e8d22293e5b8de | Analyze and fix the following issue in the Linux kernel code: memoryless nodes: fixup uses of node_online_map in generic code | Problem Details:
Here's a cut at fixing up uses of the online node map in generic code.
mm/shmem.c:shmem_parse_mpol()
Ensure nodelist is subset of nodes with memory.
Use node_states[N_HIGH_MEMORY] as default for missing
nodelist for interleave policy.
mm/shmem.c:shmem_fill_super()
initialize policy_nodes to nod... | ```diff
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 0d70fb7d83be..2c521defb41e 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -126,7 +126,7 @@ static int mpol_check_policy(int mode, nodemask_t *nodes)
return -EINVAL;
break;
}
- return nodes_subset(*nodes, node_online_map) ? 0 : -EINVAL;
+ return n... |
523b945855a1427000ffc707c610abe5947ae607 | Analyze and fix the following issue in the Linux kernel code: Memoryless nodes: Fix GFP_THISNODE behavior | Problem Details:
GFP_THISNODE checks that the zone selected is within the pgdat (node) of the
first zone of a nodelist. That only works if the node has memory. A
memoryless node will have its first node on another pgdat (node).
GFP_THISNODE currently will return simply memory on the first pgdat. Thus it
is returnin... | ```diff
diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index bc68dd9a6d41..12a90a191c11 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -98,22 +98,29 @@ struct vm_area_struct;
static inline enum zone_type gfp_zone(gfp_t flags)
{
+ int base = 0;
+
+#ifdef CONFIG_NUMA
+ if (flags & __GFP_THISNOD... |
6eaf806a223e61dc5f2de4ab591f11beb97a8f3b | Analyze and fix the following issue in the Linux kernel code: Memoryless nodes: Fix interleave behavior for memoryless nodes | Problem Details:
MPOL_INTERLEAVE currently simply loops over all nodes. Allocations on
memoryless nodes will be redirected to nodes with memory. This results in an
imbalance because the neighboring nodes to memoryless nodes will get
significantly more interleave hits that the rest of the nodes on the system.
We can ... | ```diff
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index ccbdb22147bb..5daf63bd97e7 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -183,7 +183,9 @@ static struct mempolicy *mpol_new(int mode, nodemask_t *nodes)
switch (mode) {
case MPOL_INTERLEAVE:
policy->v.nodes = *nodes;
- if (nodes_weight(*nodes) == ... |
7ea1530ab3fdfa85441061909cc8040e84776fd4 | Analyze and fix the following issue in the Linux kernel code: Memoryless nodes: introduce mask of nodes with memory | Problem Details:
It is necessary to know if nodes have memory since we have recently begun to
add support for memoryless nodes. For that purpose we introduce a two new
node states: N_HIGH_MEMORY and N_NORMAL_MEMORY.
A node has its bit in N_HIGH_MEMORY set if it has any memory regardless of the
type of mmemory. If a ... | ```diff
diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
index 583e6b843d2a..ccee962f3559 100644
--- a/include/linux/nodemask.h
+++ b/include/linux/nodemask.h
@@ -341,8 +341,14 @@ static inline void __nodes_remap(nodemask_t *dstp, const nodemask_t *srcp,
* Bitmasks that are kept for all the nodes.
*... |
55144768e100b68447f44c5e5c9deb155ad661bd | Analyze and fix the following issue in the Linux kernel code: fs: remove some AOP_TRUNCATED_PAGE | Problem Details:
prepare/commit_write no longer returns AOP_TRUNCATED_PAGE since OCFS2 and
GFS2 were converted to the new aops, so we can make some simplifications
for that.
[michal.k.k.piotrowski@gmail.com: fix warning]
Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Michael Halcrow <mhalcrow@us.ibm.com>
Cc: Mark Fa... | ```diff
diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt
index 281c19ff7f45..6f8e16e3d6c0 100644
--- a/Documentation/filesystems/vfs.txt
+++ b/Documentation/filesystems/vfs.txt
@@ -621,11 +621,7 @@ struct address_space_operations {
any basic-blocks on storage, then those blocks sho... |
03158cd7eb3374843de68421142ca5900df845d9 | Analyze and fix the following issue in the Linux kernel code: fs: restore nobh | Problem Details:
Implement nobh in new aops. This is a bit tricky. FWIW, nobh_truncate is
now implemented in a way that does not create blocks in sparse regions,
which is a silly thing for it to have been doing (isn't it?)
ext2 survives fsx and fsstress. jfs is converted as well... ext3
should be easy to do (but not... | ```diff
diff --git a/fs/buffer.c b/fs/buffer.c
index a89d25bf1171..a406cfd89e3b 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2369,7 +2369,7 @@ out_unlock:
}
/*
- * nobh_prepare_write()'s prereads are special: the buffer_heads are freed
+ * nobh_write_begin()'s prereads are special: the buffer_heads are freed
* ... |
4899f9c852564ce7b6d0ca932ac6674bf471fd28 | Analyze and fix the following issue in the Linux kernel code: nfs: convert to new aops | Problem Details:
[akpm@linux-foundation.org: fix against git-nfs]
[peterz@infradead.org: fix against git-nfs]
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew... | ```diff
diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 08c7c7387fce..d29f90d00aa2 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -306,27 +306,50 @@ nfs_fsync(struct file *file, struct dentry *dentry, int datasync)
}
/*
- * This does the "real" work of the write. The generic routine has
- * allocated the page, ... |
f4fc66a894546bdc88a775d0e83ad20a65210bcb | Analyze and fix the following issue in the Linux kernel code: ext3: convert to new aops | Problem Details:
Various fixes and improvements
Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index de4e3161e479..2f2b6864db10 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1147,51 +1147,68 @@ static int do_journal_get_write_access(handle_t *handle,
return ext3_journal_get_write_access(handle, bh);
}
-static int ext3_prepare_write(struct file ... |
637aff46f94a754207c80c8c64bf1b74f24b967d | Analyze and fix the following issue in the Linux kernel code: fs: fix data-loss on error | Problem Details:
New buffers against uptodate pages are simply be marked uptodate, while the
buffer_new bit remains set. This causes error-case code to zero out parts of
those buffers because it thinks they contain stale data: wrong, they are
actually uptodate so this is a data loss situation.
Fix this by actually cl... | ```diff
diff --git a/fs/buffer.c b/fs/buffer.c
index 09bb80c479d8..9ece6c2086d0 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1813,7 +1813,9 @@ static int __block_prepare_write(struct inode *inode, struct page *page,
unmap_underlying_metadata(bh->b_bdev,
bh->b_blocknr);
if (PageUptodate(page)) {
+ ... |
08291429cfa6258c4cd95d8833beb40f828b194e | Analyze and fix the following issue in the Linux kernel code: mm: fix pagecache write deadlocks | Problem Details:
Modify the core write() code so that it won't take a pagefault while holding a
lock on the pagecache page. There are a number of different deadlocks possible
if we try to do such a thing:
1. generic_buffered_write
2. lock_page
3. prepare_write
4. unlock_page+vmtruncate
5. copy_from_user
... | ```diff
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 862fc07dc6c0..8f1e390fd71b 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -219,6 +219,9 @@ static inline int fault_in_pages_writeable(char __user *uaddr, int size)
{
int ret;
+ if (unlikely(size == 0))
+ return 0;
... |
64649a58919e66ec21792dbb6c48cb3da22cbd7f | Analyze and fix the following issue in the Linux kernel code: mm: trim more holes | Problem Details:
If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then
we may have failed the write operation despite prepare_write having
instantiated blocks past i_size. Fix this, and consolidate the trimming into
one place.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew... | ```diff
diff --git a/mm/filemap.c b/mm/filemap.c
index 0c54fc9b8e3d..73b98c6a3389 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1895,22 +1895,9 @@ generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
}
status = a_ops->prepare_write(file, page, offset, offset+bytes);
- if (unlikely(status... |
5fe172370687e03cc6ba8dca990b75db18ff9bb3 | Analyze and fix the following issue in the Linux kernel code: mm: debug write deadlocks | Problem Details:
Allow CONFIG_DEBUG_VM to switch off the prefaulting logic, to simulate the
Makes the race much easier to hit.
This is useful for demonstration and testing purposes, but is removed in a
subsequent patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.o... | ```diff
diff --git a/mm/filemap.c b/mm/filemap.c
index f74d05201862..0c54fc9b8e3d 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1878,6 +1878,7 @@ generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
if (maxlen > bytes)
maxlen = bytes;
+#ifndef CONFIG_DEBUG_VM
/*
* Bring in the use... |
ae37461c70bc8c8416cad1bab13a9898ed030aa1 | Analyze and fix the following issue in the Linux kernel code: mm: clean up buffered write code | Problem Details:
Rename some variables and fix some types.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/mm/filemap.c b/mm/filemap.c
index 4bf7d1ab6c2a..f74d05201862 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1838,16 +1838,15 @@ generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
size_t count, ssize_t written)
{
struct file *file = iocb->ki_filp;
- struct address_space... |
6814d7a91289ceb143285975e244a8f00fd3a830 | Analyze and fix the following issue in the Linux kernel code: Revert "[PATCH] generic_file_buffered_write(): deadlock on vectored write" | Problem Details:
This reverts commit 6527c2bdf1f833cc18e8f42bd97973d583e4aa83, which
fixed the following bug:
When prefaulting in the pages in generic_file_buffered_write(), we only
faulted in the pages for the firts segment of the iovec. If the second of
successive segment described a mmapping of the page into... | ```diff
diff --git a/mm/filemap.c b/mm/filemap.c
index caaaa7adfdf9..4bf7d1ab6c2a 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1865,21 +1865,14 @@ generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
do {
unsigned long index;
unsigned long offset;
+ unsigned long maxlen;
size_t copie... |
4b49643fbb3fa8bf4910f82be02d45e94e8972a4 | Analyze and fix the following issue in the Linux kernel code: Revert "[PATCH] generic_file_buffered_write(): handle zero-length iovec segments" | Problem Details:
This reverts commit 81b0c8713385ce1b1b9058e916edcf9561ad76d6, which was
a bugfix against 6527c2bdf1f833cc18e8f42bd97973d583e4aa83 ("[PATCH]
generic_file_buffered_write(): deadlock on vectored write"), which we
also revert.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Nick Piggin <npiggi... | ```diff
diff --git a/mm/filemap.c b/mm/filemap.c
index c504db18ac26..caaaa7adfdf9 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1895,12 +1895,6 @@ generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
break;
}
- if (unlikely(bytes == 0)) {
- status = 0;
- copied = 0;
- goto zero_le... |
902aaed0d983dfd459fcb2b678608d4584782200 | Analyze and fix the following issue in the Linux kernel code: mm: use pagevec to rotate reclaimable page | Problem Details:
While running some memory intensive load, system response deteriorated just
after swap-out started.
The cause of this problem is that when a PG_reclaim page is moved to the tail
of the inactive LRU list in rotate_reclaimable_page(), lru_lock spin lock is
acquired every page writeback . This deteriora... | ```diff
diff --git a/mm/swap.c b/mm/swap.c
index d93fa1e9ec7c..d034b2128d2b 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -32,6 +32,10 @@
/* How many pages do we try to swap or page in/out together? */
int page_cluster;
+static DEFINE_PER_CPU(struct pagevec, lru_add_pvecs) = { 0, };
+static DEFINE_PER_CPU(struct pageve... |
26fb1589cb0aaec3a0b4418c54f30c1a2b1781f6 | Analyze and fix the following issue in the Linux kernel code: fix the max path calculation in radix-tree.c | Problem Details:
A while back, Nick Piggin introduced a patch to reduce the node memory
usage for small files (commit cfd9b7df4abd3257c9e381b0e445817b26a51c0c):
-#define RADIX_TREE_MAP_SHIFT 6
+#define RADIX_TREE_MAP_SHIFT (CONFIG_BASE_SMALL ? 4 : 6)
Unfortunately, he didn't take into account the fact that the
calcul... | ```diff
diff --git a/lib/radix-tree.c b/lib/radix-tree.c
index 0eee4020a7be..519d3f00ef9e 100644
--- a/lib/radix-tree.c
+++ b/lib/radix-tree.c
@@ -60,9 +60,14 @@ struct radix_tree_path {
};
#define RADIX_TREE_INDEX_BITS (8 /* CHAR_BIT */ * sizeof(unsigned long))
-#define RADIX_TREE_MAX_PATH (RADIX_TREE_INDEX_BITS/... |
a4b0672db3a698d0684ee6e54f44e2e162a3da1b | Analyze and fix the following issue in the Linux kernel code: fs: fix nobh error handling | Problem Details:
nobh mode error handling is not just pretty slack, it's wrong.
One cannot zero out the whole page to ensure new blocks are zeroed, because
it just brings the whole page "uptodate" with zeroes even if that may not
be the correct uptodate data. Also, other parts of the page may already
contain dirty da... | ```diff
diff --git a/fs/buffer.c b/fs/buffer.c
index b144fc367b8b..09bb80c479d8 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2274,51 +2274,64 @@ int nobh_prepare_write(struct page *page, unsigned from, unsigned to,
struct inode *inode = page->mapping->host;
const unsigned blkbits = inode->i_blkbits;
const unsig... |
ef8b4520bd9f8294ffce9abd6158085bde5dc902 | Analyze and fix the following issue in the Linux kernel code: Slab allocators: fail if ksize is called with a NULL parameter | Problem Details:
A NULL pointer means that the object was not allocated. One cannot
determine the size of an object that has not been allocated. Currently we
return 0 but we really should BUG() on attempts to determine the size of
something nonexistent.
krealloc() interprets NULL to mean a zero sized object. Handle... | ```diff
diff --git a/mm/slab.c b/mm/slab.c
index 6f6abef83a1a..1b240a3029d6 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -4446,7 +4446,8 @@ const struct seq_operations slabstats_op = {
*/
size_t ksize(const void *objp)
{
- if (unlikely(ZERO_OR_NULL_PTR(objp)))
+ BUG_ON(!objp);
+ if (unlikely(objp == ZERO_SIZE_PTR))
... |
c92ff1bde06f69d59b40f3194016aee51cc5da55 | Analyze and fix the following issue in the Linux kernel code: move mm_struct and vm_area_struct | Problem Details:
Move the definitions of struct mm_struct and struct vma_area_struct to
include/mm_types.h. This allows to define more function in asm/pgtable.h
and friends with inline assemblies instead of macros. Compile tested on
i386, powerpc, powerpc64, s390-32, s390-64 and x86_64.
[aurelien@aurel32.net: build ... | ```diff
diff --git a/include/linux/mm.h b/include/linux/mm.h
index fbbc29a29dff..6a68d41444f8 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -50,69 +50,6 @@ extern int sysctl_legacy_va_layout;
* mmap() functions).
*/
-/*
- * This struct defines a memory VMM memory area. There is one of these
- * per ... |
b55ed816235cf41c29159d22a4cdeec7deb5821c | Analyze and fix the following issue in the Linux kernel code: mm: clarify __add_to_swap_cache locking | Problem Details:
__add_to_swap_cache unconditionally sets the page locked, which can be a bit
alarming to the unsuspecting reader: in the code paths where the page is
visible to other CPUs, the page should be (and is) already locked.
Instead, just add a check to ensure the page is locked here, and teach the one
path r... | ```diff
diff --git a/mm/swap_state.c b/mm/swap_state.c
index 67daecb6031a..b52635601dfe 100644
--- a/mm/swap_state.c
+++ b/mm/swap_state.c
@@ -74,6 +74,7 @@ static int __add_to_swap_cache(struct page *page, swp_entry_t entry,
{
int error;
+ BUG_ON(!PageLocked(page));
BUG_ON(PageSwapCache(page));
BUG_ON(PagePri... |
557ed1fa2620dc119adb86b34c614e152a629a80 | Analyze and fix the following issue in the Linux kernel code: remove ZERO_PAGE | Problem Details:
The commit b5810039a54e5babf428e9a1e89fc1940fabff11 contains the note
A last caveat: the ZERO_PAGE is now refcounted and managed with rmap
(and thus mapcounted and count towards shared rss). These writes to
the struct page could cause excessive cacheline bouncing on big
systems. There are a ... | ```diff
diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index bbee97ff355f..64551ab6be03 100644
--- a/drivers/char/mem.c
+++ b/drivers/char/mem.c
@@ -625,65 +625,10 @@ static ssize_t splice_write_null(struct pipe_inode_info *pipe,struct file *out,
return splice_from_pipe(pipe, out, ppos, len, flags, pipe_to_null... |
6df8ba4f8a4c4abca9ccad10441d0dddbdff301c | Analyze and fix the following issue in the Linux kernel code: radixtree: introduce radix_tree_next_hole() | Problem Details:
Introduce radix_tree_next_hole(root, index, max_scan) to scan radix tree for
the first hole. It will be used in interleaved readahead.
The implementation is dumb and obviously correct. It can help debug(and
document) the possible smart one in future.
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed... | ```diff
diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h
index f9e77d2ee320..430e4a8c1382 100644
--- a/include/linux/radix-tree.h
+++ b/include/linux/radix-tree.h
@@ -155,6 +155,8 @@ void *radix_tree_delete(struct radix_tree_root *, unsigned long);
unsigned int
radix_tree_gang_lookup(struct radix_... |
f4e6b498d6e06742d72706ef50593a9c4dd72214 | Analyze and fix the following issue in the Linux kernel code: readahead: combine file_ra_state.prev_index/prev_offset into prev_pos | Problem Details:
Combine the file_ra_state members
unsigned long prev_index
unsigned int prev_offset
into
loff_t prev_pos
It is more consistent and better supports huge files.
Thanks to Peter for the nice proposal!
[akpm@linux-foundation.org: fix shift overflow]
Cc: Peter Zijlstra <peterz@infradead.org>
... | ```diff
diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c
index c00723a99f44..c2c3491b18cf 100644
--- a/fs/ext3/dir.c
+++ b/fs/ext3/dir.c
@@ -143,7 +143,7 @@ static int ext3_readdir(struct file * filp,
sb->s_bdev->bd_inode->i_mapping,
&filp->f_ra, filp,
index, 1);
- filp->f_ra.prev_index = index;
+ filp-... |
d29eff7bca60c9ee401d691d4562a4abca8de543 | Analyze and fix the following issue in the Linux kernel code: ppc64: SPARSEMEM_VMEMMAP support | Problem Details:
Enable virtual memmap support for SPARSEMEM on PPC64 systems. Slice a 16th
off the end of the linear mapping space and use that to hold the vmemmap.
Uses the same size mapping as uses in the linear 1:1 kernel mapping.
[pbadari@gmail.com: fix warning]
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
A... | ```diff
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 037664d496d7..5e001ad588a7 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -295,6 +295,7 @@ config ARCH_FLATMEM_ENABLE
config ARCH_SPARSEMEM_ENABLE
def_bool y
depends on PPC64
+ select SPARSEMEM_VMEMMAP_ENABLE
config ARCH_SPA... |
8f6aac419bd590f535fb110875a51f7db2b62b5b | Analyze and fix the following issue in the Linux kernel code: Generic Virtual Memmap support for SPARSEMEM | Problem Details:
SPARSEMEM is a pretty nice framework that unifies quite a bit of code over all
the arches. It would be great if it could be the default so that we can get
rid of various forms of DISCONTIG and other variations on memory maps. So far
what has hindered this are the additional lookups that SPARSEMEM int... | ```diff
diff --git a/include/asm-generic/memory_model.h b/include/asm-generic/memory_model.h
index 30d8d33491dd..52226e14bd7d 100644
--- a/include/asm-generic/memory_model.h
+++ b/include/asm-generic/memory_model.h
@@ -46,6 +46,12 @@
__pgdat->node_start_pfn; \
})
+#elif defined(CONFIG_SPARSEMEM_VMEMMAP)
+
+/*... |
540557b9439ec19668553830c90222f9fb0c2e95 | Analyze and fix the following issue in the Linux kernel code: sparsemem: record when a section has a valid mem_map | Problem Details:
We have flags to indicate whether a section actually has a valid mem_map
associated with it. This is never set and we rely solely on the present bit
to indicate a section is valid. By definition a section is not valid if it
has no mem_map and there is a window during init where the present bit is set... | ```diff
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7a1390cd6aad..c41d0728efe2 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -238,7 +238,7 @@ store_mem_state(struct sys_device *dev, const char *buf, size_t count)
mem = container_of(dev, struct memory_block, sysdev);
phys_sec... |
cd881a6b22902b356cacf8fd2e4e895871068eec | Analyze and fix the following issue in the Linux kernel code: sparsemem: clean up spelling error in comments | Problem Details:
SPARSEMEM is a pretty nice framework that unifies quite a bit of code over all
the arches. It would be great if it could be the default so that we can get
rid of various forms of DISCONTIG and other variations on memory maps. So far
what has hindered this are the additional lookups that SPARSEMEM int... | ```diff
diff --git a/mm/sparse.c b/mm/sparse.c
index 239f5a720d38..e8f36e4796d0 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -106,7 +106,7 @@ static inline int sparse_index_init(unsigned long section_nr, int nid)
/*
* Although written for the SPARSEMEM_EXTREME case, this happens
- * to also work for the flat arra... |
74a0b5762713a26496db72eac34fbbed46f20fce | Analyze and fix the following issue in the Linux kernel code: x86: optimize page faults like all other achitectures and kill notifier cruft | Problem Details:
x86(-64) are the last architectures still using the page fault notifier
cruft for the kprobes page fault hook. This patch converts them to the
proper direct calls, and removes the now unused pagefault notifier bits
aswell as the cruft in kprobes.c that was related to this mess.
I know Andi didn't rea... | ```diff
diff --git a/arch/x86/kernel/kprobes_32.c b/arch/x86/kernel/kprobes_32.c
index e7d0d3c2ef64..06b86e5617f6 100644
--- a/arch/x86/kernel/kprobes_32.c
+++ b/arch/x86/kernel/kprobes_32.c
@@ -584,7 +584,7 @@ out:
return 1;
}
-static int __kprobes kprobe_fault_handler(struct pt_regs *regs, int trapnr)
+int __kpr... |
dc0cf6a263d5a094d8c17287407aad1032a613b3 | Analyze and fix the following issue in the Linux kernel code: pcmcia: cistpl: use get_unaligned() in CIS parsing | Problem Details:
Based on a patch by Haavard Skinnemoen posted to linux-pcmcia, but using
static inlines for readability reasons. this should fix PCMCIA an AVR32
Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Sign... | ```diff
diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c
index d154dee76e7f..06a85d7d5aa2 100644
--- a/drivers/pcmcia/cistpl.c
+++ b/drivers/pcmcia/cistpl.c
@@ -25,6 +25,7 @@
#include <linux/ioport.h>
#include <asm/io.h>
#include <asm/byteorder.h>
+#include <asm/unaligned.h>
#include <pcmcia/cs_type... |
b5446b514c00b3034017609ec4e5a09117b9c8fd | Analyze and fix the following issue in the Linux kernel code: move a few definitions to au1000_xxs1500.c | Problem Details:
Only a few definitions is in xxs1500.h .
They can be move to au1000_xxs1500.c .
[m.kozlowski@tuxland.pl: fix unbalanced parenthesis]
Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Marius... | ```diff
diff --git a/drivers/pcmcia/au1000_xxs1500.c b/drivers/pcmcia/au1000_xxs1500.c
index 01874b0bb03b..ce9d5c44a7b5 100644
--- a/drivers/pcmcia/au1000_xxs1500.c
+++ b/drivers/pcmcia/au1000_xxs1500.c
@@ -50,7 +50,10 @@
#include <asm/au1000.h>
#include <asm/au1000_pcmcia.h>
-#include <asm/xxs1500.h>
+
+#define PC... |
0322a2b84096270c238da45f444bd3c9eb6f5e9c | Analyze and fix the following issue in the Linux kernel code: Add assembler equivalents to __init{,date}_refok | Problem Details:
I need __INIT_REFOK to fix a MODPOST warning for a few MIPS configs which
have to call init code from .text very early in the game due to bootloader
issues. __INITDATA_REFOK is just for consistency.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.... | ```diff
diff --git a/include/linux/init.h b/include/linux/init.h
index f8d9d0b5cffc..9b7a2ba8237e 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -67,8 +67,10 @@
/* For assembly routines */
#define __INIT .section ".init.text","ax"
+#define __INIT_REFOK .section ".text.init.refok","ax"
#define __F... |
bfe8df3d314bddf30758bd738e0087e80964760c | Analyze and fix the following issue in the Linux kernel code: slow down printk during boot | Problem Details:
Optionally add a boot delay after each kernel printk() call, crudely
measured in milliseconds, with a maximum delay of 10 seconds per printk.
Enable CONFIG_BOOT_PRINTK_DELAY=y and then add (e.g.):
"lpj=loops_per_jiffy boot_delay=100"
to the kernel command line.
It has been useful in cases like "durin... | ```diff
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 085e4a095eaa..760ed5776174 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -349,6 +349,11 @@ and is between 256 and 4096 characters. It is defined in the file
blkmtd_bs=
... |
b875d650527e1980cc88b2731ac4c209d2e4a0ca | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix thinko in cs4231 mce down check | Problem Details:
The last patches to replace with schedule_timeout() don't work as expected.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/isa/cs423x/cs4231_lib.c b/sound/isa/cs423x/cs4231_lib.c
index 72cf77159083..a5eb9659b519 100644
--- a/sound/isa/cs423x/cs4231_lib.c
+++ b/sound/isa/cs423x/cs4231_lib.c
@@ -313,6 +313,7 @@ void snd_cs4231_mce_up(struct snd_cs4231 *chip)
void snd_cs4231_mce_down(struct snd_cs4231 *chip)
{
u... |
56f91585b48bb3ca8ec38b84c92d3df2a2f2bf66 | Analyze and fix the following issue in the Linux kernel code: [ALSA] sun-cs4231: improved waiting after MCE down | Problem Details:
This patch sync sparc driver with x86 isa cs4231 driver patches.
It fixes wrong waiting for the auto calibration bit and makes
further waiting use much finer granularity.
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <pere... | ```diff
diff --git a/sound/sparc/cs4231.c b/sound/sparc/cs4231.c
index 4f515a64e03f..ab39860e2404 100644
--- a/sound/sparc/cs4231.c
+++ b/sound/sparc/cs4231.c
@@ -422,44 +422,39 @@ static void snd_cs4231_mce_down(struct snd_cs4231 *chip)
spin_unlock_irqrestore(&chip->lock, flags);
return;
}
- snd_cs4231_busy_wa... |
c2cbdbb1583830b77f169a717407f035d6627793 | Analyze and fix the following issue in the Linux kernel code: [ALSA] fix bootup crash in snd_gus_interrupt() | Problem Details:
when simulating a storm of fake GUS interrupts (without actually owning
this venerable piece of ISA hardware) the driver falls over (crashes) in
two ways:
1) spinlocks being initialized too late:
INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the loc... | ```diff
diff --git a/sound/isa/gus/gus_irq.c b/sound/isa/gus/gus_irq.c
index a0430b338d67..cd9a6f1c99e6 100644
--- a/sound/isa/gus/gus_irq.c
+++ b/sound/isa/gus/gus_irq.c
@@ -45,11 +45,13 @@ __again:
// snd_printk("IRQ: status = 0x%x\n", status);
if (status & 0x02) {
STAT_ADD(gus->gf1.interrupt_stat_midi_in);
- ... |
c9b58006be7e471a5f55d171cbaa08f4aa8078ea | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix SKU ID function for realtek codecs | Problem Details:
Fixed SKU ID function for realtek codecs. It's used by the automatic
BIOS configuration mode. Now it supports the correct jack-detection
mechanism, too.
Signed-off-by: Kailang Yang <kailang@realtek.com.tw>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c8ca97b2c31d..53b0428abfc2 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -662,6 +662,44 @@ static struct hda_verb alc_gpio3_init_verbs[] = {
{ }
};
+static void alc_sku_automute(struct hda_c... |
2a3988f6d2c5be9d02463097775d1c66a8290527 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hdsp - Fix zero division | Problem Details:
Fix zero-division bug in the calculation dds offset.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz> | ```diff
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index 2411f0b396b4..ff26a3672d40 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -3059,6 +3059,9 @@ static int hdsp_dds_offset(struct hdsp *hdsp)
unsigned int dds_value = hdsp->dds_value;
int system_sample_rate = hdsp->... |
ea045ee4d381428ec9c056ff5848bc619d84986a | Analyze and fix the following issue in the Linux kernel code: [ALSA] usb-audio - Fix double comment | Problem Details:
Remove superfluous comment line (maybe a merge failure).
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz> | ```diff
diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h
index aeb9005125ce..743568f89907 100644
--- a/sound/usb/usbquirks.h
+++ b/sound/usb/usbquirks.h
@@ -101,7 +101,6 @@
.idProduct = 0x3f04,
.bInterfaceClass = USB_CLASS_AUDIO,
},
-/*
/*
* Yamaha devices
*/
``` |
9066f2443122c1501da64b6faa0038c13f0209f9 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix STAC922x volume knob control | Problem Details:
Reported by zhejiang <zhe.jiang@intel.com>
'I found that STAC_VOLKNOB hardwired the KNOB nid to 0x24.
It is okay for stac9205 and stac927x.
But the VolumeKnob nid of stac9220-9221 is 0x16.'
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz> | ```diff
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 8b3576007d4a..626a5edde06c 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -352,7 +352,7 @@ static int stac92xx_volknob_info(struct snd_kcontrol *kcontrol,
static int stac92xx_volknob_get(stru... |
39d3ed381877246719184897c853c0c58028fe54 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix for Fujitsu Lifebook C1410 | Problem Details:
Fixed ALC262 fujitsu model to support Fujitsu Lifebook C1410 properly.
It requires EAPD and has separate int/ext mic inputs (which was missing
in the current driver).
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ec14dd513fee..1d2cd4c4b160 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7807,9 +7807,10 @@ static struct hda_verb alc262_fujitsu_unsol_verbs[] = {
};
static struct hda_input_mux alc262_fuji... |
11be265f7fd4976a1139d6ec9b2ef1e8adaf835f | Analyze and fix the following issue in the Linux kernel code: [ALSA] via82xx - Add DXS quirk for Shuttle AK31v2 | Problem Details:
Shuttle AK31v2 works well with dxs_support=5 (ALSA bug#2926).
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/via82xx.c b/sound/pci/via82xx.c
index 45d89deb64e5..69487f681184 100644
--- a/sound/pci/via82xx.c
+++ b/sound/pci/via82xx.c
@@ -2363,6 +2363,7 @@ static struct snd_pci_quirk dxs_whitelist[] __devinitdata = {
SND_PCI_QUIRK(0x1071, 0, "Diverse Notebook", VIA_DXS_NO_VRA),
SND_PCI_QUIRK(0... |
a3a2f429e55997e3b7a0c23baf1208991970ecc1 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix input_mux numbers for vaio stac92xx | Problem Details:
My bad, I forgot to update the num_items field when added a new item
to vaio_mux items table, so the last item 'PCM' disappeared.
Now it has the right number 3.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 9fae4f1296bb..8b3576007d4a 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -2875,7 +2875,7 @@ static hda_nid_t vaio_adcs[] = { 0x8 /*,0x6*/ };
static hda_nid_t vaio_mux_nids[] = { 0x15 };
s... |
e6382cf8b0c34be26e667d45911fa827aea8df5c | Analyze and fix the following issue in the Linux kernel code: [ALSA] pcxhr - Fix dB level information | Problem Details:
Some dB level information is wrong in pcxhr driver according to the
datasheet. Fixed now.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/pcxhr/pcxhr_mixer.c b/sound/pci/pcxhr/pcxhr_mixer.c
index b913453063f8..5f8d42633b04 100644
--- a/sound/pci/pcxhr/pcxhr_mixer.c
+++ b/sound/pci/pcxhr/pcxhr_mixer.c
@@ -44,8 +44,8 @@
#define PCXHR_ANALOG_PLAYBACK_LEVEL_MAX 128 /* 0.0 dB */
#define PCXHR_ANALOG_PLAYBACK_ZERO_LEVEL 104... |
1194b5b70a0a000a4ace54d94d8df5cc3ec6e3e0 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix Gateway laptops with STAC9200 | Problem Details:
Fix the output of Gateway laptops with STAC9200 codec chip.
They require the EAPD control for some pins. These pins shouldn't be
powered down.
To enable EAPD control, a new model 'gateway' was added to STAC9200.
The known PCI SSIDs are included in the quirk list.
The fix was originally suggested by Br... | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index 9268925f8e42..a035eb64042f 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -972,6 +972,7 @@ Prior to version 0.9.0rc4 options... |
2469049e728ee0542d6617f81311a18a14e73826 | Analyze and fix the following issue in the Linux kernel code: [ALSA] sound: snd_register_device_for_dev fix | Problem Details:
snd_register_device_for_dev() can oops when device_create() returns
ERR_PTR(err).
Scenario:
preg->dev = device_create(...); /* fails */
if (preg->dev) /* contains ERR_PTR(err) */
dev_set_drvdata(preg->dev, private_data);
and dev_set_drvdata() looks like this:
static inline void
dev_set_drvdata (struct... | ```diff
diff --git a/sound/core/sound.c b/sound/core/sound.c
index 8dc7a3b32b98..f6ebce08b537 100644
--- a/sound/core/sound.c
+++ b/sound/core/sound.c
@@ -266,6 +266,14 @@ int snd_register_device_for_dev(int type, struct snd_card *card, int dev,
snd_minors[minor] = preg;
preg->dev = device_create(sound_class, devic... |
1e74190bc0f8a5ab7e83bdf6688fcaebbed25316 | Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-usb-audio: Add basic support for E-Mu USB devices. | Problem Details:
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h
index 5e69e884ad00..aeb9005125ce 100644
--- a/sound/usb/usbquirks.h
+++ b/sound/usb/usbquirks.h
@@ -88,7 +88,20 @@
.bInterfaceClass = USB_CLASS_AUDIO,
.bInterfaceSubClass = USB_SUBCLASS_AUDIO_CONTROL
},
-
+/* E-Mu devices */
+{
+ .match_flags = USB... |
6eda7cf184670764a6f6bfc883bd5005379d7251 | Analyze and fix the following issue in the Linux kernel code: [ALSA] git-alsa kconfig fix | Problem Details:
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
index c127e79ed29c..356bf21a1506 100644
--- a/sound/pci/Kconfig
+++ b/sound/pci/Kconfig
@@ -900,6 +900,7 @@ config SND_AC97_POWER_SAVE_DEFAULT
int "Default time-out for AC97 power-save mode"
depends on SND_AC97_POWER_SAVE
default 0
+ help
The default ... |
213e84ec71abf596be76abcf18b988afeb2c210e | Analyze and fix the following issue in the Linux kernel code: [ALSA] sound/hda: fix help text | Problem Details:
Fix hda help text typo.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
index 2c6486c23a52..c127e79ed29c 100644
--- a/sound/pci/Kconfig
+++ b/sound/pci/Kconfig
@@ -506,7 +506,7 @@ config SND_HDA_HWDEP
select SND_HWDEP
help
Say Y here to build a hwdep interface for HD-audio driver.
- This interface can be used for out-of-b... |
b60dd394f8af01d1b0a8b1d9d1aa6b75c645eb8e | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix ALC662 codec support | Problem Details:
* Fixed ALC662 init verbs (wrong NIDs)
* Fixed ALC662 auto model issue (wrong DAC index)
Signed-off-by: Kailang Yang <kailang@realtek.com.tw>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b642c8bf162f..096ef296db1a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11665,12 +11665,12 @@ static struct hda_verb alc662_init_verbs[] = {
{0x0b, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(3)},... |
b438f817b16eec5b497fe78cc2b889f3276e6508 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ad1848: Fix msleep while atomic | Problem Details:
Simplest fix.
Acked-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
index 330b5ced01aa..18355fd66cb5 100644
--- a/sound/isa/ad1848/ad1848_lib.c
+++ b/sound/isa/ad1848/ad1848_lib.c
@@ -236,7 +236,9 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
* calibration process to start. Needs upto 5 ... |
c929e5ef4f1b2ef52f707e7ffcedc492a199741e | Analyze and fix the following issue in the Linux kernel code: [ALSA] schedule_timeout() fix for core/seq/seq_instr.c | Problem Details:
Replace schedule_timeout() with schedule_timeout_uninterruptible()
to avoid signals in loop.
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/core/seq/seq_instr.c b/sound/core/seq/seq_instr.c
index 5efe6523a589..08bed008fb7e 100644
--- a/sound/core/seq/seq_instr.c
+++ b/sound/core/seq/seq_instr.c
@@ -109,7 +109,7 @@ void snd_seq_instr_list_free(struct snd_seq_kinstr_list **list_ptr)
spin_lock_irqsave(&list->lock, flags);
wh... |
d86d01935a4c4c818514d8c23579703abd768329 | Analyze and fix the following issue in the Linux kernel code: [ALSA] alsa-kernel: schedule_timeout() fixes | Problem Details:
Fix schedule_timeout() use in alsa-kernel. Mostly just
schedule_timeout(1) --> schedule_timeout_uninterruptible(1)
The wavefront_synth one fixes the surrounding loop as well. In ymfpci_main,
delete a superfluous set_current_state() and in soc/soc-dapm.c replace an
_interruptible with _uninterruptible ... | ```diff
diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
index 4902da40b6c0..1cb921d6137e 100644
--- a/sound/isa/sscape.c
+++ b/sound/isa/sscape.c
@@ -401,7 +401,7 @@ static int obp_startup_ack(struct soundscape *s, unsigned timeout)
unsigned long flags;
unsigned char x;
- schedule_timeout(1);
+ schedule_... |
1ea73412b27ddd88decbdafb83bb2bfc288fe56c | Analyze and fix the following issue in the Linux kernel code: [ALSA] opti9xx: adjust OPL3 FM resource value | Problem Details:
The OPTi ISA-PnP chips advertise their OPL4 base at 0x380 (to 0x3f0) through
pnp and put their on-chip OPL3 at +8. The driver assumes the provided
value is the ALBase (OPL3 address) though and checks for an OPL4 at -8,
which means that simply adding 8 to the pnp provides value works to fix
detection of... | ```diff
diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index 049d479ce2b3..fb1d0704f2f9 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -1732,11 +1732,11 @@ static int __devinit snd_card_opti9xx_pnp(struct snd_opti9xx *chip,
#ifdef OPT... |
1cf0bc7e730c4148605164ac542c1c191c1d2e09 | Analyze and fix the following issue in the Linux kernel code: [ALSA] sc6000: 2 minor fixes | Problem Details:
This patch zeroes buffer for the card name and
fixes incorrect jump in the probe function.
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c
index 3032fa9e9f03..94daf8399994 100644
--- a/sound/isa/sc6000.c
+++ b/sound/isa/sc6000.c
@@ -352,6 +352,7 @@ static int __devinit sc6000_init_board(char __iomem *vport, int irq, int dma,
return err;
}
+ memset(answer, 0, sizeof(answer));
err = sc600... |
7b758d2f74be4f255d8c80b5c302d4c3b8fc3863 | Analyze and fix the following issue in the Linux kernel code: [ALSA] sc6000: documentation fix | Problem Details:
This patch fixes MPU-401 irq values list in documentation.
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index 74a8293c6e75..dcaabeb2e4ca 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -1679,7 +1679,7 @@ Prior to version 0.9.0rc4 optio... |
f79415207ea60109d34bed89b2f3ed303a18d24b | Analyze and fix the following issue in the Linux kernel code: [ALSA] ad1848_lib: waiting loops done after cs4231_lib | Problem Details:
This patch fixes ad1848_lib waiting loops to be the same as in the cs4231_lib.
Acked-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
index eee941be3b74..330b5ced01aa 100644
--- a/sound/isa/ad1848/ad1848_lib.c
+++ b/sound/isa/ad1848/ad1848_lib.c
@@ -205,7 +205,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
{
unsigned long flags;
int timeout;
- signe... |
3a5bdee5fa98bfd7d04c61b37b746eb918472e82 | Analyze and fix the following issue in the Linux kernel code: [ALSA] sc6000 build fix | Problem Details:
sound/isa/sc6000.c: In function 'sc6000_dsp_reset':
sound/isa/sc6000.c:270: error: implicit declaration of function 'udelay' sound/isa/sc6000.c: In function 'sc6000_init_mss':
sound/isa/sc6000.c:327: error: implicit declaration of function 'msleep'
{standard input}: Assembler messages:
Signed-o... | ```diff
diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c
index d4a4ccfc2fd7..3032fa9e9f03 100644
--- a/sound/isa/sc6000.c
+++ b/sound/isa/sc6000.c
@@ -25,6 +25,7 @@
#include <sound/driver.h>
#include <linux/module.h>
+#include <linux/delay.h>
#include <linux/isa.h>
#include <linux/io.h>
#include <asm/dma.h>
... |
22d3a20030439420bf2795c60529ba0e89b4d82c | Analyze and fix the following issue in the Linux kernel code: [ALSA] echoaudio - Add barrier() to prevent compiler optimization | Problem Details:
This patch adds a barrier() to prevent the compiler from
moving the read outside of the loop. It also fixes a comment.
Signed-off-by: Giuliano Pochini <pochini@shiny.it>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/echoaudio/echoaudio_dsp.c b/sound/pci/echoaudio/echoaudio_dsp.c
index 42afa837d9b4..e6c100770392 100644
--- a/sound/pci/echoaudio/echoaudio_dsp.c
+++ b/sound/pci/echoaudio/echoaudio_dsp.c
@@ -43,11 +43,11 @@ static int wait_handshake(struct echoaudio *chip)
{
int i;
- /* Wait up to 1... |
c36fd8c3cd682fa9bbe5b2cb4b99e16625a37c94 | Analyze and fix the following issue in the Linux kernel code: [ALSA] cmipci: fix distortion on rear channels | Problem Details:
When playing multichannel data, the rear channels can get distorted if
the last sample of the last played stereo stream was not zero. To avoid
this, add a hack to play a few silence samples after the stream is
stopped.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jaroslav Kysela... | ```diff
diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c
index 085a36751ac0..6832649879ce 100644
--- a/sound/pci/cmipci.c
+++ b/sound/pci/cmipci.c
@@ -434,6 +434,7 @@ struct cmipci_pcm {
u8 running; /* dac/adc running? */
u8 fmt; /* format bits */
u8 is_dac;
+ u8 needs_silencing;
unsigned int dma_size; /... |
0f28eca32b3064db29d4718156e692f4db75c7aa | Analyze and fix the following issue in the Linux kernel code: [ALSA] cmipci: fix lookup of double rates | Problem Details:
When using one of the double sampling rates, use half the sample rate to
look up in the rates[] table, otherwise we stumble over the BUG().
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c
index b4f74ae9c0b6..7cf4fc193419 100644
--- a/sound/pci/cmipci.c
+++ b/sound/pci/cmipci.c
@@ -604,6 +604,9 @@ static unsigned int rates[] = { 5512, 11025, 22050, 44100, 8000, 16000, 32000, 4
static unsigned int snd_cmipci_rate_freq(unsigned int rate)
{
un... |
8ffbc01e2cb2e203df910468f236c7b4e7b36f25 | Analyze and fix the following issue in the Linux kernel code: [ALSA] cmipci: reorganize set_dac_channels() | Problem Details:
By reorganizing the code that sets the CHB3DxC bits we can not only
simplify this code but also fix the bug where the CHB3D8C bit was not
reset when playing a stereo stream after a 7.1 stream.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c
index c51ea0ef26f9..b4f74ae9c0b6 100644
--- a/sound/pci/cmipci.c
+++ b/sound/pci/cmipci.c
@@ -738,48 +738,37 @@ static struct snd_pcm_hw_constraint_list hw_constraints_channels_8 = {
static int set_dac_channels(struct cmipci *cm, struct cmipci_pcm *rec, int ... |
6935e68877a875137ea3fe7b690b0bec6504b7ff | Analyze and fix the following issue in the Linux kernel code: [ALSA] cmipci: fix version 37 detection | Problem Details:
Use the proper value for the bit that identifies chip version 37.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c
index 78a23984eac7..751ff00bfeca 100644
--- a/sound/pci/cmipci.c
+++ b/sound/pci/cmipci.c
@@ -2665,7 +2665,7 @@ static void __devinit query_chip(struct cmipci *cm)
else
cm->can_ac3_hw = 1;
break;
- case 1:
+ case CM_CHIP_037:
cm->chip_versi... |
c818e0a152bcb138411b07f4495b8e6fb9bacf52 | Analyze and fix the following issue in the Linux kernel code: [ALSA] bt87x: fix detection of generic boards | Problem Details:
Add an 'unknown' board type so that it is possible to differentiate
between unknown and generic boards.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/bt87x.c b/sound/pci/bt87x.c
index 42e57fd02d39..91f9e6a112ff 100644
--- a/sound/pci/bt87x.c
+++ b/sound/pci/bt87x.c
@@ -149,6 +149,7 @@ MODULE_PARM_DESC(load_all, "Allow to load the non-whitelisted cards");
/* Cards with configuration information */
enum snd_bt87x_boardid {
+ SND_BT87... |
f189e14cc41a1fb7db225cacdb2df7498f5ad67a | Analyze and fix the following issue in the Linux kernel code: [ALSA] echoaudio - Remove superfluous volatile prefix | Problem Details:
Remove superfluous volatile prefix in the communication struct definition.
This eventually fixes the compile warnings with the recent gcc, too.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/echoaudio/echoaudio_dsp.h b/sound/pci/echoaudio/echoaudio_dsp.h
index e55ee00991ac..e352f3ae292c 100644
--- a/sound/pci/echoaudio/echoaudio_dsp.h
+++ b/sound/pci/echoaudio/echoaudio_dsp.h
@@ -642,18 +642,18 @@ struct comm_page { /* Base Length*/
u32 flags; /* See Appendix A below ... |
e8a7f136f5edb6ae83b14faaa0da2a3c4558f431 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-intel - Improve HD-audio codec probing robustness | Problem Details:
When modem is disabled in the BIOS, detection of the number of codecs
always fails after booting if STATESTS is not cleared first.
This patch fixes this problem and also adds an error check in a place
where a read error would lead to a very large number of pointless loops.
Signed-off-by: Danny Tholen ... | ```diff
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index e594de0b153e..535bcb7601b5 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -155,6 +155,8 @@ int snd_hda_get_sub_nodes(struct hda_codec *codec, hda_nid_t nid,
unsigned int parm;
parm = snd_hda_param_read(code... |
768d8c7df886fc5cc9d6057cc987ef8e52d197b5 | Analyze and fix the following issue in the Linux kernel code: [ALSA] pcxhr - Fix trigger start with non-linked streams | Problem Details:
The non-linked streams couldn't be started properly due to missing
setting of stream->status.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c
index cd4613a97bd7..2d618bd7e62b 100644
--- a/sound/pci/pcxhr/pcxhr.c
+++ b/sound/pci/pcxhr/pcxhr.c
@@ -664,6 +664,7 @@ static int pcxhr_trigger(struct snd_pcm_substream *subs, int cmd)
if (pcxhr_update_r_buffer(stream))
return -EINVAL;
+... |
bfc4e8616679226b1f113a46df491e233c8dc338 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix CS4270 volume control and optimize I2C operations | Problem Details:
The volume control for the CS4270 ASoC driver was inverted - raising the
volume level with alsamixer would decrease the actual volume.
This patch also improves the performance of the I2C code (used to change
register settings) by only performing an I2C write if the new value is
different from the value... | ```diff
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
index 43d50a4d8089..5d601ad6da70 100644
--- a/sound/soc/codecs/cs4270.c
+++ b/sound/soc/codecs/cs4270.c
@@ -294,19 +294,24 @@ static unsigned int cs4270_read_reg_cache(struct snd_soc_codec *codec,
static int cs4270_i2c_write(struct snd_soc_code... |
503fc85a3b15b0e939ad9672e376ffc9c4840591 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Kill useless volatile in pcm.h | Problem Details:
The volatile prefix is just useless there. Let's kill them, and then
gcc will be happier, too.
sound/acore/pcm.c:867: warning: passing argument 1 of ‘__constant_c_and_count_memset’ discards qualifiers from pointer target type
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kyse... | ```diff
diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index 76b34b5841eb..805d7207f08b 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -301,8 +301,8 @@ struct snd_pcm_runtime {
union snd_pcm_sync_id sync; /* hardware synchronization ID */
/* -- mmap -- */
- volatile struct snd_pcm_mmap_stat... |
b9f09a485937d9c3fb524b2fa140fee1d94856d0 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix 'discards qualifiers' compile warnings in pcm.h | Problem Details:
Fixed cast messes in pcm.h.
include/sound/pcm.h: In function ‘hw_param_interval_c’:
include/sound/pcm.h:800: warning: passing argument 1 of ‘hw_param_interval’ discards qualifiers from pointer target type
Simply redefine the inline functions again for const pointers.
Signed-off-by: Takashi Iwa... | ```diff
diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index 27f8ef48b5ec..76b34b5841eb 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -791,13 +791,13 @@ static inline struct snd_interval *hw_param_interval(struct snd_pcm_hw_params *p
static inline const struct snd_mask *hw_param_mask_c(const st... |
d44df2d0f22a688f4f3af3e0d6cbcf9a4516e1b5 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ad1848/cs4231: replace commented out debug code with snd-printd{,d} | Problem Details:
While I'm at it another 'while I'm there' -- replace commented out debug
code with snd-printd{,d}.
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
index c10dfc10e67a..eee941be3b74 100644
--- a/sound/isa/ad1848/ad1848_lib.c
+++ b/sound/isa/ad1848/ad1848_lib.c
@@ -213,13 +213,14 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
/* end of cleanup sequence */
for (timeout... |
bc962efa6cd864d8bd29d2634da4ef14873d020c | Analyze and fix the following issue in the Linux kernel code: [ALSA] ad1848: replace HZ calculus with msecs_to_jiffies() | Problem Details:
If I'm not mistaken, any (new) use of HZ these days is considered a bug so
while I'm there...
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
index d454d11989f0..c10dfc10e67a 100644
--- a/sound/isa/ad1848/ad1848_lib.c
+++ b/sound/isa/ad1848/ad1848_lib.c
@@ -239,7 +239,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
#if 0
printk("(2) jiffies = %li\n", jiffies);... |
90cf9b853281a39555cce8a42fc0fabad75b42a8 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ad1838/cs4231 - fix MCE timeout upon initial load | Problem Details:
When the ad1848/cs2431 is first being initialized, auto-calibration may not
be set causing a timeout waiting for it in snd_ad1848/cs4231_mce_down().
This has no dire consequences other than an alarming printk, but since what
we need to wait for is for the calibration to _finish_, let's just check for
t... | ```diff
diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
index f01e564b1238..d454d11989f0 100644
--- a/sound/isa/ad1848/ad1848_lib.c
+++ b/sound/isa/ad1848/ad1848_lib.c
@@ -229,16 +229,15 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
spin_unlock_irqrestore(&chip->reg_lock, fla... |
51c80cb65ff9b7bdf172f9075138793c2bce6883 | Analyze and fix the following issue in the Linux kernel code: [ALSA] au88x0_synth.c bugfix | Problem Details:
This patch fixes the code in vortex_wt_SetFrequency() to what seems to
have been intended.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/au88x0/au88x0_synth.c b/sound/pci/au88x0/au88x0_synth.c
index d3e662a1285d..978b856f5621 100644
--- a/sound/pci/au88x0/au88x0_synth.c
+++ b/sound/pci/au88x0/au88x0_synth.c
@@ -370,8 +370,8 @@ static void vortex_wt_SetFrequency(vortex_t * vortex, int wt, unsigned int sr)
while ((edx & ... |
3304cd361025e4d3fdad1971c93ddc05995a5d3a | Analyze and fix the following issue in the Linux kernel code: [ALSA] ad1848: fix AD1848P macro | Problem Details:
Consistent variable naming is a good thing, but let's be a little less
sneaky about enforcing it... ;-/
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/include/sound/ad1848.h b/include/sound/ad1848.h
index b2c3f00a9b35..ca0b6c35e5a9 100644
--- a/include/sound/ad1848.h
+++ b/include/sound/ad1848.h
@@ -27,7 +27,7 @@
/* IO ports */
-#define AD1848P( codec, x ) ( (chip) -> port + c_d_c_AD1848##x )
+#define AD1848P( chip, x ) ( (chip) -> port + c_... |
b875bf3aaf743fb461ab97e07752fbd825c2d78f | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Add quirk entry for Casper CPR2000 | Problem Details:
Added the quirk entry for Casper CPR2000 (model=acer) with ALC268 codec
(ALSA bug#3343).
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f06494a97761..90ab518dfe53 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9100,6 +9100,7 @@ static struct snd_pci_quirk alc268_cfg_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x30cc, "TOSHIBA", ALC268_TOSH... |
914759b79e28ce74606e99d9f6aaabeec58394ab | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Add support for ASUS A7M | Problem Details:
Added the support for ASUS A7M with ALC882 codec.
It's slightly different from ASUS A7J.
The patch taken from ALSA bug#3000
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3000
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 412629d02dbb..8491b046a9f4 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -155,6 +155,7 @@ enum {
ALC882_W2JC,
ALC882_TARGA,
ALC882_ASUS_A7J,
+ ALC882_ASUS_A7M,
ALC885_MACPRO,
ALC885_MBP... |
af6c016ecfd908203217a2d78715adeaa51b003d | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix wrong pin config order in STAC92xx dell models | Problem Details:
The last patch to change/add Dell models have wrong pin config orders.
This patch fixes the pin positions.
Taken from ALSA bug#3319,
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3319
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 6dffa54e2da1..f843e2122a8b 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -563,8 +563,8 @@ static unsigned int ref9200_pin_configs[8] = {
102801E8
*/
static unsigned int dell9200_d21_pi... |
ba02946a903015840ef672ccc9dc8620a7e83de6 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix handling of stfiwx math emulation | Problem Details:
Its legal for the stfiwx instruction to have RA = 0 as part of its
effective address calculation. This is illegal for all other XE
form instructions.
Add code to compute the proper effective address for stfiwx if
RA = 0 rather than treating it as illegal.
Signed-off-by: Kumar Gala <galak@kernel.cras... | ```diff
diff --git a/arch/powerpc/math-emu/math.c b/arch/powerpc/math-emu/math.c
index 69058b2873de..381306bb1590 100644
--- a/arch/powerpc/math-emu/math.c
+++ b/arch/powerpc/math-emu/math.c
@@ -407,11 +407,16 @@ do_mathemu(struct pt_regs *regs)
case XE:
idx = (insn >> 16) & 0x1f;
- if (!idx)
- goto illegal;
... |
7b85b4f088de8856c5cc5fee18630708ab28dfe8 | Analyze and fix the following issue in the Linux kernel code: [ALSA] sun-cs4231: memory management fix | Problem Details:
The chip structure is now allocated by snd_card_new()
and it must not be released by separate kfree().
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/sparc/cs4231.c b/sound/sparc/cs4231.c
index ddc0f2e082d6..20daf261d03d 100644
--- a/sound/sparc/cs4231.c
+++ b/sound/sparc/cs4231.c
@@ -1865,8 +1865,6 @@ static int snd_cs4231_sbus_free(struct snd_cs4231 *chip)
if (chip->port)
sbus_iounmap(chip->port, chip->regs_size);
- kfree(chip);
-... |
506ea68cd9e8899ac2b97f466956e670d60026dc | Analyze and fix the following issue in the Linux kernel code: [ALSA] cs5535audio: fix ACC_BM[x]_CMD register handling | Problem Details:
According to 6.3.2.7 of the cs5535/cs5536 data sheets, the ACC_BM[x]_CMD
registers are only 8 bits wide. This driver treats them as 32 bits wide,
and also has bits in the wrong place. Simple fix to the definitions.
Signed-off-by: Andres Salomon <dilinger@debian.org>
Signed-off-by: Takashi Iwai <tiwa... | ```diff
diff --git a/sound/pci/cs5535audio/cs5535audio.h b/sound/pci/cs5535audio/cs5535audio.h
index c7a204467037..516219ad5e8f 100644
--- a/sound/pci/cs5535audio/cs5535audio.h
+++ b/sound/pci/cs5535audio/cs5535audio.h
@@ -62,11 +62,11 @@
#define EOP (1<<0)
#define BM_EOP_ERR (1<<1)
/* ACC_BMX_CTL */
-#define B... |
222fa0b0d2fdb2373a71d532c2cabd2ec920b3b3 | Analyze and fix the following issue in the Linux kernel code: [ALSA] cs5535audio: fix PRD register save/restore power management race | Problem Details:
In the suspend path, we currently save the PRD registers and then disable DMA.
This is racy; the sound hardware might update the PRD register as it finishes
processing some DMA pages between when we've saved the PRD registers and
when DMA actually gets disabled. Furthermore, we actively check whether ... | ```diff
diff --git a/sound/pci/cs5535audio/cs5535audio.h b/sound/pci/cs5535audio/cs5535audio.h
index 4fd1f31a6cf9..c7a204467037 100644
--- a/sound/pci/cs5535audio/cs5535audio.h
+++ b/sound/pci/cs5535audio/cs5535audio.h
@@ -106,7 +106,6 @@ struct cs5535audio_dma {
struct snd_pcm_substream *substream;
unsigned int bu... |
9e05b7a3d936ac5eb6c10291b69aee0af1ad03fb | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix support for sigmatel codecs that have 2 or more ADCs | Problem Details:
1) Create seperate mixer controls for each ADC
2) Make number of substreams of capture PCM device be equal to
number of ADCs
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index a2b1dd54e2ef..6dffa54e2da1 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -413,11 +413,11 @@ static struct hda_verb stac9205_core_init[] = {
{}
};
-#define STAC_INPUT_SOURCE \
+#define ST... |
d804ad9258c1460916a5e5854655a0dc543fd8a5 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-intel - Fix resume logic, when dynamic power managment is on | Problem Details:
Comment in hda_intel.c states that 'the explicit resume is needed only
when POWER_SAVE isn't set', but this is not true.
There is no code that will automaticly power up the codec on resume,
but only code that powers it up when user accesses it. So if user
leaves a sound playing, codec will not be power... | ```diff
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 08104e2a3e99..e594de0b153e 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -2787,7 +2787,6 @@ int snd_hda_suspend(struct hda_bus *bus, pm_message_t state)
return 0;
}
-#ifndef CONFIG_SND_HDA_POWER_SAVE
/**
... |
2e4924628ad957f702631a7a049c586a780f00f8 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-intel - fix a race in dynamic power managment | Problem Details:
codec->power_transition is supposed to be true while codec is going
to be shut off if in the mean time somebody calls snd_hda_power_up,
hda_power_work will not shut down the codec, but nether will clear
codec->power_transition, thus it stays on forever. Fix this.
Signed-off-by: Maxim Levitsky <maximle... | ```diff
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 46d4253642d7..08104e2a3e99 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -2195,8 +2195,10 @@ static void hda_power_work(struct work_struct *work)
struct hda_codec *codec =
container_of(work, struct hda_code... |
b7e054a76fdc42b442c003f8d19ee5dce6b55f02 | Analyze and fix the following issue in the Linux kernel code: [ALSA] cmipci: show real chip name in card name | Problem Details:
The '-MCx' suffix that is expected by alsa-lib is only needed in the
card driver string, so we can show the actual chip name in the
shortname.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c
index 9149d00d1ad5..a8d6b54143fa 100644
--- a/sound/pci/cmipci.c
+++ b/sound/pci/cmipci.c
@@ -2852,6 +2852,7 @@ static int __devinit snd_cmipci_create(struct snd_card *card, struct pci_dev *pc
unsigned int val;
long iomidi;
int integrated_midi = 0;
+ ch... |
c480f79bdca58923e605ff5e4698cfe1779bae70 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Avoid zero NID in line_out_pins[] of STAC codecs | Problem Details:
The STAC codes adds line_out_pins[] for shared mic/line-inputs accordingly.
But, the current code may give a hole with NID=0 in some setting, which
results in an error at probe. This patch fixes the problem.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 39187828503d..b4a1d73b5721 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1479,7 +1479,8 @@ static int stac92xx_add_dyn_out_pins(struct hda_codec *codec, struct auto_pin_cf
case 3:
/* ad... |
dc81bed127a93e20d2100624273a27369738ffc7 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix wrong pin-setup at resume of STAC codecs | Problem Details:
The resume procedure for STAC codecs overrides the cached values and
results in the wrong (reset) PIN state. The patch gets rid of the
overriding part and simplifies the resume.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 98144f93dff9..39187828503d 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -2061,9 +2061,9 @@ static void enable_pin_detect(struct hda_codec *codec, hda_nid_t nid,
unsigned int event)... |
accbe4988c5cf3dc86f0a042396163ed279536a6 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix capture on ALC262 HP machines | Problem Details:
Fix the index for Front Mic capture source on ALC262 HP machines.
Also, added the new capture source list for HP BPC DC7000 series
to work properly.
From: zhejiang <zhe.jiang@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b3062afc481c..3557865dde38 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7746,13 +7746,23 @@ static struct hda_input_mux alc262_HP_capture_source = {
.num_items = 5,
.items = {
{ "Mic", 0... |
6534599d14892c5b0838b7170f071c850f5ea8e9 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hdspm - Fix autosync bug | Problem Details:
* better report of speed mode change failures
* autosync_ref control bugfix (was reporting pref_sync_ref instead)
(changed HDSPM_AES32_AUTOSYNC_FROM_NONE value to comply with array
indexing in snd_hdspm_info_autosync_ref())
* added support for master modes up to 192kHz (clock source control
value... | ```diff
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index 30e0c4dc9484..f1bdda6cbcff 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -359,7 +359,7 @@ MODULE_SUPPORTED_DEVICE("{{RME HDSPM-MADI}}");
#define HDSPM_AES32_AUTOSYNC_FROM_AES6 6
#define HDSPM_AES32_AUTOSYNC_FR... |
d6c3cf81f05c8dd8e5e656d4bcb8d5f2569d0262 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ac97 - Suppress the reset of audio-codec from modem-codec at resume | Problem Details:
On codec chips with both audio and modem functions (e.g. Conexant one),
performing AC97_RESET resets the whole registers. When both audio and
modem drivers are resumed at the same time, the modem one often is
resumed after the audio, and it results in the reset of audio registers
(ALSA bug#3333).
This... | ```diff
diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
index df1333332a5e..3e5ff29fc499 100644
--- a/sound/pci/ac97/ac97_codec.c
+++ b/sound/pci/ac97/ac97_codec.c
@@ -2496,7 +2496,10 @@ void snd_ac97_resume(struct snd_ac97 *ac97)
snd_ac97_write(ac97, AC97_POWERDOWN, 0);
if (! (ac97->flags ... |
dfe495d0a51e20325b51760f34a2f53bfe1f3b52 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix Dell laptops support with STAC codecs | Problem Details:
Fixed Dell laptops support with STAC92xx codecs.
Many pin-config models are introduced. See ALSA-Configuration.txt
for details.
The patch taken from ALSA bug#3319, originally by Jorg Prante:
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3319
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signe... | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index 85b40057716d..38e775629c12 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -957,8 +957,19 @@ Prior to version 0.9.0rc4 option... |
889c43955115ea7412d71335e3ceff6bad118dce | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix ALC268 unsol event | Problem Details:
The unsol event of ALC268 is in the standard bit 26.
Also, fixed the Acer master controls, and added Extensa 5210
to the quirk list.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4cbd0e6e849d..b108ea3d99b3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8500,7 +8500,7 @@ static struct hda_verb alc268_toshiba_verbs[] = {
};
/* Acer specific */
-/* bind volumes of both N... |
0724ea2a85a804e151d960359b599ae8a7c1cad1 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix mater mixer switch of ALC262 sony-amd model | Problem Details:
Fixed the master mixer switch of ALC272 sony-amd model.
It used a simple bind-control, but it resulted in unexpected
unmute of speaker output. Now the control checks the HP jack
state apropriately, just like fujitsu model.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <pe... | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index db29ebea20b5..4cbd0e6e849d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7453,18 +7453,46 @@ static struct snd_kcontrol_new alc262_HP_BPC_WildWest_option_mixer[] = {
{ } /* end */
};
-stati... |
1fcaee6ee212fc214c1327d788afa10899c22e3a | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-intel - Fix compile with gcc-3.x | Problem Details:
gcc-3.x doesn't like forward inlining:
CC [M] sound/pci/hda/hda_codec.o
sound/pci/hda/hda_codec.c: In function 'snd_hda_codec_free':
sound/pci/hda/hda_codec.c:517: sorry, unimplemented: inlining failed in call to 'free_hda_cache': function body not available
sound/pci/hda/hda_codec.c:534: sorry, uni... | ```diff
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index b1eee9a044fe..46d4253642d7 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -514,7 +514,7 @@ static int read_widget_caps(struct hda_codec *codec, hda_nid_t fg_node)
static void init_hda_cache(struct hda_cache_re... |
45c41b4868c9dbec5d43a4023e77994afa94470f | Analyze and fix the following issue in the Linux kernel code: [ALSA] cmipci: fix handling of FM/MIDI port addresses | Problem Details:
Make sure that the MPU-401 MIDI and OPL-3 FM devices are used only on
those chips where they are supported, and that the correct port
addresses are used.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index 3df33ea8bae6..85b40057716d 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -365,13 +365,15 @@ Prior to version 0.9.0rc4 optio... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.