id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
30e80a279d864385306ed4bf905f00196d1c9656 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - add ASUS W7J (0x1043, 0x1205) to quirk list - 3stack | Problem Details:
See Novell-bug#228201 .
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fcd9ab8dea4f..db261bb92162 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7589,6 +7589,7 @@ static const char *alc861_models[ALC861_MODEL_LAST] = {
};
static struct snd_pci_quirk alc861_cfg_t... |
ffc26918ab5674b286a4bc07dac7e011cea83e97 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ASoC at91 - Fix NULL pointer dereference in at91_i2s_shutdown | Problem Details:
This patch fixes a NULL pointer exception which occurs when a
substream is opened and immediately closed.
Signed-off-by: Frank Mandarino <fmandarino@endrelia.com>
Signed-off-by: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <p... | ```diff
diff --git a/sound/soc/at91/at91-i2s.c b/sound/soc/at91/at91-i2s.c
index 203e6948cd99..876d391c7013 100644
--- a/sound/soc/at91/at91-i2s.c
+++ b/sound/soc/at91/at91-i2s.c
@@ -296,6 +296,13 @@ static int at91_i2s_startup(struct snd_pcm_substream *substream)
ssc_p->dir_mask |= dir_mask;
spin_unlock_irq(&ssc_p... |
751e61c47d3b4e929c93bac61c8dd6c247854993 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Solve typos/compilation problems for debug functions in soc-dapm and at91-i2s | Problem Details:
soc-dapm
·Removed list_for_each since the loop is list_for_each_entry() and
not list_for_each(). Thanks to Liam Girdwood and Seth Forshee.
at91-i2s
·Fixed typo in dai modes definition.
·Fixed struct member name in at91_ssc_info->ssc_state.
·Fixed compilation problem, ssc_state is bundled in at91_ssc_i... | ```diff
diff --git a/sound/soc/at91/at91-i2s.c b/sound/soc/at91/at91-i2s.c
index b452e8e6a724..203e6948cd99 100644
--- a/sound/soc/at91/at91-i2s.c
+++ b/sound/soc/at91/at91-i2s.c
@@ -101,7 +101,7 @@ static struct snd_soc_dai_mode at91_i2s[] = {
.pcmdir = AT91_I2S_DIR,
.flags = SND_SOC_DAI_BFS_DIV,
.fs = 250,
-... |
518f6a6173e6009f5d380c638ea97a8897ebea9c | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix typo and add entry to documentation | Problem Details:
This patch adds the macpro and fixes a typo in the ALC882 section of
ALSA-Configuration.txt.
Signed-off-by: Tobin Davis <tdavis@dsl-only.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index 89b612f835ad..14debd58c182 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -814,8 +814,9 @@ Prior to version 0.9.0rc4 options... |
67e9f4b68c9d1820132c559c0f9b296dafdf631e | Analyze and fix the following issue in the Linux kernel code: [ALSA] ac97 - fix various issues with AD1986/AD1986A support | Problem Details:
Previously, ac97_codec.c was coded to support AD1986 and AD1986A
CODECs using code written for the AD1985 CODEC. This allowed the
LINE_OUT and HEADPHONE jacks to function properly, however register
differences between the CODECs prevented line and microphone inputs
from functioning.
Specifically, this... | ```diff
diff --git a/include/sound/ac97_codec.h b/include/sound/ac97_codec.h
index 5d3f0d8c0e61..246ac23534bd 100644
--- a/include/sound/ac97_codec.h
+++ b/include/sound/ac97_codec.h
@@ -503,6 +503,7 @@ struct snd_ac97 {
unsigned short id[3]; // codec IDs (lower 16-bit word)
unsigned short pcmreg[3]; // PCM re... |
6428ea1b733e4795209ff272be32732ec152594a | Analyze and fix the following issue in the Linux kernel code: [ALSA] ac97 - fix malfunctioning mixer controls for AD1985 | Problem Details:
This patch replaces the 'V_REFOUT Enable' mixer switch control
with a listbox control for the AD1985 CODEC.
Previous patch 'AD1888 mixer controls for DC mode' added
controls that were propogated to multiple codecs. For the
AD1985 codec, the bits VREFH and VREFD function differently,
preventing the 'V_... | ```diff
diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
index 5f69b9c9f1b3..bd27531a0f0e 100644
--- a/sound/pci/ac97/ac97_patch.c
+++ b/sound/pci/ac97/ac97_patch.c
@@ -1632,13 +1632,16 @@ int patch_ad1886(struct snd_ac97 * ac97)
#define AC97_AD198X_MBC_10 0x0001 /* +10dB */
#define AC97_AD198X_... |
1321b160fa1cf63fa841d954fe31220366b6647a | Analyze and fix the following issue in the Linux kernel code: [ALSA] soc - Fix delayed_work related changes on 2.6.20 kernel | Problem Details:
Fix the changes realted to delayed_work in soc/codecs/wm8750.c.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/include/sound/soc.h b/include/sound/soc.h
index c985a111bc3f..ea836d819ce0 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -374,6 +374,7 @@ struct snd_soc_codec {
struct list_head dapm_paths;
unsigned int dapm_state;
unsigned int suspend_dapm_state;
+ struct delayed_work delayed... |
831466f4ad2b5fe23dff77edbe6a7c244435e973 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ac97 - fix microphone and line_in selection logic | Problem Details:
This patch fixes the Microphone and LINE_IN select logic for
Analog Devices surround codecs with shared jacks. The existing
code can never utilize the shared jacks for Microphone and LINE_IN
due to the reversed jack selection logic. The patched code
correctly selects the shared jack for input if the ... | ```diff
diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
index 818a77d2deff..5f69b9c9f1b3 100644
--- a/sound/pci/ac97/ac97_patch.c
+++ b/sound/pci/ac97/ac97_patch.c
@@ -190,14 +190,28 @@ static inline int is_clfe_on(struct snd_ac97 *ac97)
return ac97->channel_mode >= 2;
}
+/* system has share... |
ca40587087fc05c670f4f2650cc466d557377f6d | Analyze and fix the following issue in the Linux kernel code: [ALSA] sparc dbri comment fix | Problem Details:
This is a comment fix to avoid misleading about locking in the
dbri_cmdsend.
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
index 4ceb09d215d8..25a2a7333006 100644
--- a/sound/sparc/dbri.c
+++ b/sound/sparc/dbri.c
@@ -678,7 +678,7 @@ static s32 *dbri_cmdlock(struct snd_dbri * dbri, int len)
* The JUMP cmd points to the new cmd string.
* It also releases the cmdlock spinlock.
... |
b0148a98ec5151fec82064d95f11eb9efbc628ea | Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-aoa: fix onyx resume | Problem Details:
When the machine resumes the onyx codec might be in a weird state. Hence,
simply fully reset it once (and keep the code to take it out of suspend in
case the suspend of the codec chip survives a reset).
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de... | ```diff
diff --git a/sound/aoa/codecs/snd-aoa-codec-onyx.c b/sound/aoa/codecs/snd-aoa-codec-onyx.c
index 0b7650788f1f..b00fc4842c93 100644
--- a/sound/aoa/codecs/snd-aoa-codec-onyx.c
+++ b/sound/aoa/codecs/snd-aoa-codec-onyx.c
@@ -825,7 +825,16 @@ static int onyx_resume(struct codec_info_item *cii)
int err = -ENXIO;
... |
1a5965b72209db9db453bc0049393e0d54cf85cb | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix AC97_BUS in soc/pxa/Kconfig | Problem Details:
Fixed the renamed AC97_BUS in soc/pxa/Kconfig file.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index a07598cdab3c..579e1c8d2b28 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -15,7 +15,7 @@ config SND_PXA2XX_AC97
config SND_PXA2XX_SOC_AC97
tristate
- select SND_AC97_BUS
+ select AC97_BUS
select SND_SOC_AC97_BUS
config... |
4484bb2e93a9ab636d149edc6515c75ea224e2b0 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix the soc code after dhowells workqueue changes. | Problem Details:
From: Andrew Morton <akpm@osdl.org>
I converted the workqueues to per-device while I was there. It seems
strange to create a new kernel thread (on each CPU!) and to then only
have a single global work to ever be queued upon it.
Plus without this, I'd have to use the _NAR stuff, gawd help me.
Does that... | ```diff
diff --git a/include/sound/soc.h b/include/sound/soc.h
index 3dfe052e0788..c985a111bc3f 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -15,6 +15,7 @@
#include <linux/platform_device.h>
#include <linux/types.h>
+#include <linux/workqueue.h>
#include <sound/driver.h>
#include <sound/core.h>
... |
ca377fecdd822f9ef5b0a21586040e7d0e1d0c7a | Analyze and fix the following issue in the Linux kernel code: [ALSA] ucb1400_ts.c compilation fix (struct snd_ac97) | Problem Details:
From: Andrew Morton <akpm@osdl.org>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index 4358a0a78eaa..c7db4032ef02 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -83,7 +83,7 @@
struct ucb1400 {
- ac97_t *ac97;
+ struct snd_ac97 *ac97;
str... |
cbb7d8f9b7b0a9f51c9869d0da63ea75a2c95caf | Analyze and fix the following issue in the Linux kernel code: [ALSA] emu10k1: Update registers defines for the Audigy 2/emu10k2.5 | Problem Details:
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h
index 32ce4bd31b46..adca71b20daa 100644
--- a/include/sound/emu10k1.h
+++ b/include/sound/emu10k1.h
@@ -460,6 +460,7 @@
#define FXRT_CHANNELC 0x0f000000 /* Effects send bus number for channel's effects send C */
#define FXRT_CHANNELD 0xf0000000 ... |
7c157069bc953c3cfb5926e92d358e46423bf942 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ca0106: Fix sound capture on Audigy LS via AC97. | Problem Details:
Fixes ALSA bug#2286
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index f61f052f6d14..6f781b811876 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -1382,7 +1382,6 @@ static int __devinit snd_ca0106_create(int dev, struct snd_card *card,
snd_ca0106_ptr_write(chip,... |
a5f65029ad5c5262ee3aff5165698e431415cf7c | Analyze and fix the following issue in the Linux kernel code: [ALSA] arm header fix | Problem Details:
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/arm/aaci.h b/sound/arm/aaci.h
index 06295190606c..9175ff9ded01 100644
--- a/sound/arm/aaci.h
+++ b/sound/arm/aaci.h
@@ -228,7 +228,7 @@ struct aaci {
/* AC'97 */
struct mutex ac97_sem;
- ac97_bus_t *ac97_bus;
+ struct snd_ac97_bus *ac97_bus;
u32 maincr;
spinlock_t lock;
``` |
61e77107fa849b69f50ebe96217ba3468a216ba8 | Analyze and fix the following issue in the Linux kernel code: [ALSA] create device symlink in snd-aoa | Problem Details:
create sysfs device symlinks for snd-aoa in /sys/class/sound/controlC0 This
allows hald to recognize the device as sound device. Furthermore it allows
the desktop user to actually access the sound device nodes. hald and
related packages will modify the acl attributes.
Fixes https://bugzilla.novell.co... | ```diff
diff --git a/sound/aoa/aoa.h b/sound/aoa/aoa.h
index 378ef1e9879b..541b908f3cdf 100644
--- a/sound/aoa/aoa.h
+++ b/sound/aoa/aoa.h
@@ -99,7 +99,7 @@ struct aoa_fabric {
* that are not assigned yet are passed to the fabric
* again for reconsideration. */
extern int
-aoa_fabric_register(struct aoa_fabric *fa... |
e0e6ce0380e0c4de35371372bc5b6c2b02458597 | Analyze and fix the following issue in the Linux kernel code: [ALSA] add struct snd_pcm_substream forward declaration | Problem Details:
fixes: include/sound/pcm.h:62: warning: 'struct snd_pcm_substream' declared
inside parameter list
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index ec006ed8cd59..ee6bc2d06803 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -56,6 +56,8 @@ struct snd_pcm_hardware {
size_t fifo_size; /* fifo size in bytes */
};
+struct snd_pcm_substream;
+
struct snd_pcm_ops {
int (*open)(stru... |
eb41dab6e10332c1c9008f3cfc5b88ff1e392cb9 | Analyze and fix the following issue in the Linux kernel code: [ALSA] emu10k1: Rename the digital optical capture control for the Audigy 2 ZS | Problem Details:
Notebook.
Digital playback and capture now works, but it is not bit accurate because it
passes through a resampler.
Bit accurate playback and capture will be implemented later via the p17v.
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/emu10k1/emumixer.c b/sound/pci/emu10k1/emumixer.c
index b8221f385ff9..0469546fc333 100644
--- a/sound/pci/emu10k1/emumixer.c
+++ b/sound/pci/emu10k1/emumixer.c
@@ -1486,6 +1486,7 @@ int __devinit snd_emu10k1_mixer(struct snd_emu10k1 *emu,
"Wave Playback Volume", "OLD PCM Playback Volum... |
184c1e2c4c4221c2b8d1e16c33314595373fa73f | Analyze and fix the following issue in the Linux kernel code: [ALSA] emu10k1: Add Audio capture support for Audigy 2 ZS Notebook. | Problem Details:
Implement functionallity in order to fixe ALSA bug#2058.
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h
index 8b28304f2c42..32ce4bd31b46 100644
--- a/include/sound/emu10k1.h
+++ b/include/sound/emu10k1.h
@@ -1427,6 +1427,8 @@ struct snd_emu10k1 {
spinlock_t memblk_lock;
unsigned int spdif_bits[3]; /* s/pdif out setup */
+ unsigned int i2c_captu... |
86d72bdfcd34c9cd8acddf749ff130d5365fe279 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix compile warnings without CONFIG_SND_DEBUG | Problem Details:
Fix compile warnings (unused variables) in patch_conexant.c
without CONFIG_SND_DEBUG.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index dec8f9747fc6..73f4668238c6 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -397,6 +397,9 @@ static int conexant_eapd_put(struct snd_kcontrol *kcontrol,
return 1;
}
+/* controls for test mo... |
2e26e483694059d63bda7bb89d5a464c952d1d44 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ASoC - Bit clock matching error | Problem Details:
This patch by Philipp Zabel fixes a bug whereby the BCLK matching fails
when the Codec BCLK is constant and the CPU BCLK is based upon a
divider.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Signed-off-by: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Signed-off-by: Takashi Iwai <tiwai@suse... | ```diff
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 6da1616bf776..90e8841e7e33 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -424,7 +424,7 @@ static int soc_hw_match_params(struct snd_pcm_substream *substream,
/* normalise cpu bfs div & codec const mult */
codec_bfs = soc_... |
5b78efd2ef206265aa789485580df9799c54b650 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix documentation of ASoC | Problem Details:
Fixed obsolete *_t typedefs in ASoC documentation.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/Documentation/sound/alsa/soc/codec.txt b/Documentation/sound/alsa/soc/codec.txt
index 47b36cb16840..274657a03e1c 100644
--- a/Documentation/sound/alsa/soc/codec.txt
+++ b/Documentation/sound/alsa/soc/codec.txt
@@ -170,11 +170,11 @@ The codec driver also supports the following alsa operations:-
/... |
a9e996604f77be6f1f4deb0eb1cc2652000054f1 | Analyze and fix the following issue in the Linux kernel code: [ALSA] intel8x0 - Add spdif_aclink option | Problem Details:
Added spdif_aclink module option to specify whether the board
has SPDIF over AC-link or a direct connection from the controller
chip.
NForce and ICH4 (or newer) boards may be equipped with SPDIF
through AC97 codec. In such a case, SPDIF should be handled
as if the old ICH style (the same slot for anal... | ```diff
diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index f8aef131be7a..a289abfc7172 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -71,6 +71,7 @@ static char *ac97_quirk;
static int buggy_semaphore;
static int buggy_irq = -1; /* auto-check */
static int xbox;
+static int spdif_aclink =... |
d1d985f019c3b290e09881b7b23abdc87aee2895 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix obsolete *_t typedefs | Problem Details:
Fixed obsolete *_t typedefs. Now completely removed.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/als300.c b/sound/pci/als300.c
index 9f406fbe0d95..8afcb98ca7bb 100644
--- a/sound/pci/als300.c
+++ b/sound/pci/als300.c
@@ -444,7 +444,7 @@ static int snd_als300_capture_close(struct snd_pcm_substream *substream)
}
static int snd_als300_pcm_hw_params(struct snd_pcm_substream *substrea... |
56bb0cab1c1698544e61409e3727f2b6bc205501 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Add asus-laptop model for ALC861 (ALC660) | Problem Details:
Added a new model 'asus-laptop' for ASUS F2*/F3* laptops
with ALC861 (equivalent with ALC660) codec chip.
Also fixed the model for PCI SSID 1043:1338.
Corresponding to ALSA bug#2480.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index d853a303ffcb..15d102a94619 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -839,6 +839,7 @@ Prior to version 0.9.0rc4 options... |
9fb62c9f23d437241051e27a11de568361a4745d | Analyze and fix the following issue in the Linux kernel code: [ALSA] korg1212: fix printk format warning | Problem Details:
sound/pci/korg1212/korg1212.c:2359: warning: format '%d' expects type 'int', but
argument 4 has type 'size_t'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c
index b4e98f36229b..21d0899ac382 100644
--- a/sound/pci/korg1212/korg1212.c
+++ b/sound/pci/korg1212/korg1212.c
@@ -2356,7 +2356,7 @@ static int __devinit snd_korg1212_create(struct snd_card *card, struct pci_dev *
if (snd_dma_alloc_... |
14e1d357e4fed9577d349952b71ec7d81aad710c | Analyze and fix the following issue in the Linux kernel code: [ALSA] atiixp - Add a parameter ac97_quirk | Problem Details:
Add an option to specify the AC'97 codec instead of
probing. This is a fix for bugzilla #7467.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index c54fd7c258d9..d853a303ffcb 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -242,6 +242,12 @@ Prior to version 0.9.0rc4 option... |
9dece1d74bd41f593cb1d9e387dc894dd826abf7 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix ALC861 connection of front-output | Problem Details:
Fix the wrongly set SET_CONNECTION verb for NID 0x0f of ALC861.
The widget has only a single connection although the init verb
sets to 0x01.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7b4bac3567d5..02ee6565b6e9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6922,7 +6922,7 @@ static struct hda_verb alc861_base_init_verbs[] = {
/* port-E for HP out (front panel) */
{ 0x0f, A... |
e6327cf90b1e5e849ac87fbdaee7822a64b6ff56 | Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-ca0106: Updated Enum control names. | Problem Details:
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/ca0106/ca0106_mixer.c b/sound/pci/ca0106/ca0106_mixer.c
index 9855f528ea78..bd2a054c673b 100644
--- a/sound/pci/ca0106/ca0106_mixer.c
+++ b/sound/pci/ca0106/ca0106_mixer.c
@@ -539,14 +539,14 @@ static struct snd_kcontrol_new snd_ca0106_volume_ctls[] __devinitdata = {
},
{
.iface = ... |
4c07c81832a9303eeb36afb8f76ad0594e66cf5e | Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-emu10k1: Update Enum naming. | Problem Details:
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/emu10k1/emumixer.c b/sound/pci/emu10k1/emumixer.c
index 5ceb8dd5cb38..9b7fd564343e 100644
--- a/sound/pci/emu10k1/emumixer.c
+++ b/sound/pci/emu10k1/emumixer.c
@@ -316,30 +316,30 @@ static int snd_emu1010_input_source_put(struct snd_kcontrol *kcontrol,
}
static struct snd_kcontrol_new... |
54bf5dd9ccd8c37830d7dae0737466e8fda018aa | Analyze and fix the following issue in the Linux kernel code: [ALSA] hdspm - Fix printk warnings | Problem Details:
sound/pci/rme9652/hdspm.c: In function 'snd_hdspm_hw_params':
sound/pci/rme9652/hdspm.c:3681: warning: format '%08X' expects type 'unsigned int', but argument 4 has type 'unsigned char *'
sound/pci/rme9652/hdspm.c:3692: warning: format '%08X' expects type 'unsigned int', but argument 4 has type 'unsign... | ```diff
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index 3d3a4ce3a35e..e0215aca1193 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -3678,7 +3678,7 @@ static int snd_hdspm_hw_params(struct snd_pcm_substream *substream,
hdspm->playback_buffer =
(unsigned char... |
9174140cf383c56bdcabb4caf9c99c5ac8f3fdd7 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix model for ASUS M2N-MX | Problem Details:
Add a proper model (3stack) for ASUS M2N-MX with AD1986A codec.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c
index 5e63123f70b8..9260560303ee 100644
--- a/sound/pci/hda/patch_analog.c
+++ b/sound/pci/hda/patch_analog.c
@@ -800,6 +800,8 @@ static struct hda_board_config ad1986a_cfg_tbl[] = {
.config = AD1986A_3STACK }, /* ASUS P5RD2-VM / P5GPL... |
219e281f4627a395aaceff0e4a257cd18608e145 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix mask to stop AT91 SSC clock on shutdown | Problem Details:
This patch by Frank Mandarino and Hubert Kahlert fixes a bug in the AT91
SSC (i2s) shutdown code that would erroneously disable other AT91
peripheral clocks.
Signed-off-by: Hubert Kahlert <hkahlert@hk-datentechnik.de>
Signed-off-by: Frank Mandarino <fmandarino@endrelia.com>
Signed-off-by: Liam Girdwoo... | ```diff
diff --git a/sound/soc/at91/at91rm9200-i2s.c b/sound/soc/at91/at91rm9200-i2s.c
index 2eee427b1e5c..e3e6345fc8be 100644
--- a/sound/soc/at91/at91rm9200-i2s.c
+++ b/sound/soc/at91/at91rm9200-i2s.c
@@ -373,7 +373,7 @@ static void at91rm9200_i2s_shutdown(struct snd_pcm_substream *substream)
if (!ssc_p->dir_mask) ... |
06bf2f495aabfdbe9d5db7b910fa75dd7f72131a | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix model for Lenovo A60 desktop | Problem Details:
Add a proper model entry (3stack) for Lenovo A60 desktop with
AD1986a codec to fix noise problems.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c
index 076365bc10e9..5e63123f70b8 100644
--- a/sound/pci/hda/patch_analog.c
+++ b/sound/pci/hda/patch_analog.c
@@ -800,6 +800,8 @@ static struct hda_board_config ad1986a_cfg_tbl[] = {
.config = AD1986A_3STACK }, /* ASUS P5RD2-VM / P5GPL... |
543a0fbe18d0b44f3d037fe6b59458fa0c0d5e4b | Analyze and fix the following issue in the Linux kernel code: [ALSA] ASoC AT91 DAI modes update | Problem Details:
This patch by Frank Mandarino updates the AT91RM9200 I2S DAI audio modes
as follows:-
o fixes a typo in the 16k mode
o removes experimental 24k mode
o adds a 32k mode.
Signed-off-by: Frank Mandarino <fmandarino@endrelia.com>
Signed-off-by: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Signed-off-b... | ```diff
diff --git a/sound/soc/at91/at91rm9200-i2s.c b/sound/soc/at91/at91rm9200-i2s.c
index 8c4d3b999053..2eee427b1e5c 100644
--- a/sound/soc/at91/at91rm9200-i2s.c
+++ b/sound/soc/at91/at91rm9200-i2s.c
@@ -71,22 +71,22 @@ static struct snd_soc_dai_mode at91rm9200_i2s[] = {
.flags = SND_SOC_DAI_BFS_DIV,
.fs = 750... |
12e74f7d430655f541b85018ea62bcd669094bd7 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ASoC - Fix build warnings in soc-core.c | Problem Details:
This patch fixes some build warnings in soc-core.c
Changes:-
o Check the return value of soc_ac97_dev_register()
o Check return value of calls to device_create_file()
Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kys... | ```diff
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 8d6ff047d7a0..2ce0c8251dc3 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1438,12 +1438,18 @@ int snd_soc_register_card(struct snd_soc_device *socdev)
{
struct snd_soc_codec *codec = socdev->codec;
struct snd_soc_machine *mach... |
b5c5fd24b9d34e4670cb339e546bfae7ad316354 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ASoC debug output build breakage | Problem Details:
This patch fixes a build failure when ASoC debug is enabled.
Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index eba0a1012531..8d6ff047d7a0 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -575,10 +575,11 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
}
dbg("asoc: %s <-> %s info:\n", rtd->codec_dai->name, rtd->cpu_dai->nam... |
e40a0b2e9d73c69e6b9e5d55eb56696f81fbf802 | Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-emu10k1: emu1010: replace long udelay with msleep. | Problem Details:
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/emu10k1/emumixer.c b/sound/pci/emu10k1/emumixer.c
index a118fee11cdd..5ceb8dd5cb38 100644
--- a/sound/pci/emu10k1/emumixer.c
+++ b/sound/pci/emu10k1/emumixer.c
@@ -542,7 +542,7 @@ static int snd_emu1010_internal_clock_put(struct snd_kcontrol *kcontrol,
snd_emu1010_fpga_write(emu, EMU_... |
b0dbdaea55d55c05be972cd2a040acfa073b0509 | Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-emu10k1: Add emu1010 internal clock rate control for 44100 or 48000. | Problem Details:
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h
index 7cfa91e7bde8..8b28304f2c42 100644
--- a/include/sound/emu10k1.h
+++ b/include/sound/emu10k1.h
@@ -1392,6 +1392,7 @@ struct snd_emu1010 {
unsigned int input_source[64];
unsigned int adc_pads; /* bit mask */
unsigned int dac_pads; /* bit m... |
0f71e8b98506252db22a0c4fcfecb0aadcf393cc | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix irq handler in soc/at91/at91rm9200-i2s.c | Problem Details:
Fixed the irq handler in soc/at91-at91rm9200-i2s.c to follow the
new style without pt_regs.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/soc/at91/at91rm9200-i2s.c b/sound/soc/at91/at91rm9200-i2s.c
index a74c5d85589b..044a774b4301 100644
--- a/sound/soc/at91/at91rm9200-i2s.c
+++ b/sound/soc/at91/at91rm9200-i2s.c
@@ -270,8 +270,7 @@ static struct at91rm9200_ssc_info {
};
-static int at91rm9200_i2s_interrupt(int irq, void *d... |
9148cc502752b12051760e6c5ba5daaea3367360 | Analyze and fix the following issue in the Linux kernel code: [ALSA] snd_emu10k1: Added support for 14dB Attenuation PADS on DACs and ADCs. | Problem Details:
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h
index 396812eb668d..7cfa91e7bde8 100644
--- a/include/sound/emu10k1.h
+++ b/include/sound/emu10k1.h
@@ -974,7 +974,7 @@
#define EMU_HANA_OPTICAL_OUT_SPDIF 0x00
#define EMU_HANA_OPTICAL_OUT_ADAT 0x02
-#define EMU_HANA_MIDI 0x0c /* 000000x 1 bit... |
e117483e3e713c6411968afea825daa1133bc28d | Analyze and fix the following issue in the Linux kernel code: [ALSA] soc-core: fix multi-line string literal | Problem Details:
Properly quote a string that had an embedded newline.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index e841ad46c759..eba0a1012531 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -575,8 +575,8 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
}
dbg("asoc: %s <-> %s info:\n", rtd->codec_dai->name, rtd->cpu_dai->name)... |
b66b3cfe6c2f6560f351278883a325b6ebc478f5 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda_intel: increase maximum DMA buffer size to 1024MB | Problem Details:
See ALSA bug#2481 .
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 1a7e82104bb9..d15c9b845f23 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1285,7 +1285,7 @@ static int __devinit create_codec_pcm(struct azx *chip, struct hda_codec *codec,
snd_pcm_set_ops(pcm, SNDRV_PCM_STRE... |
bbb53551e31dce3cdbf61330e135179a55c82fd1 | Analyze and fix the following issue in the Linux kernel code: [ALSA] emu10k1 - Fix compile warning | Problem Details:
Fixed a compile warning regarding print format for size_t.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
index 891172f2b1d7..09c4db8495b2 100644
--- a/sound/pci/emu10k1/emu10k1_main.c
+++ b/sound/pci/emu10k1/emu10k1_main.c
@@ -615,7 +615,7 @@ static int snd_emu1010_load_firmware(struct snd_emu10k1 * emu, const char * file
snd_print... |
d595ee7e0162ae66faa8c4c7d8c2069b40d64fed | Analyze and fix the following issue in the Linux kernel code: [ALSA] aoa: fix up i2sbus_attach_codec | Problem Details:
This patch changes i2sbus_attach_codec to implement a proper error handling
strategy using labels to jump to the right part. Since it has an elaborate
set-up sequence it also needs that tear-down, which I had hard-coded
inbetween all the checks. This increases readability and should reduce .text
size a... | ```diff
diff --git a/sound/aoa/soundbus/i2sbus/i2sbus-pcm.c b/sound/aoa/soundbus/i2sbus/i2sbus-pcm.c
index 051bb9b200ee..7c81db7e52c1 100644
--- a/sound/aoa/soundbus/i2sbus/i2sbus-pcm.c
+++ b/sound/aoa/soundbus/i2sbus/i2sbus-pcm.c
@@ -812,7 +812,6 @@ static void i2sbus_private_free(struct snd_pcm *pcm)
module_put(THI... |
d94d3dff0d5da3bdfcbb424ba5c08534521fd690 | Analyze and fix the following issue in the Linux kernel code: ACPI: bay: fix build warning | Problem Details:
drivers/acpi/bay.c: In function 'bay_add':
drivers/acpi/bay.c:310: warning: statement with no effect
Fix it by rewriting those macros in C. Much nicer.
Cc: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Len Brown <len.bro... | ```diff
diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
index 4dc8a5043ef0..3d7ebe0e4fc2 100644
--- a/include/acpi/acpi_drivers.h
+++ b/include/acpi/acpi_drivers.h
@@ -122,10 +122,24 @@ extern int register_hotplug_dock_device(acpi_handle handle,
acpi_notify_handler handler, void *context);
ext... |
0ee8d33c64df9a719fd61ba693203e3b33b9e10a | Analyze and fix the following issue in the Linux kernel code: cxgb3: sysfs attributes in -mm tree | Problem Details:
This patch fixes the usage of sysfs attributes in cxgb3 for the -mm tree.
It is built against the driver commited in the -mm tree.
Signed-off-by: Divy Le Ray <divy@chelsio.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik... | ```diff
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index dfa035a1ad45..c67f7d3c2f92 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -74,8 +74,6 @@ enum {
#define EEPROM_MAGIC 0x38E2F10C
-#define to_net_dev(class) container_of(class, struct net_d... |
1539b98b561754252dd520b98fa03a688a4f81b5 | Analyze and fix the following issue in the Linux kernel code: [IPX]: Fix NULL pointer dereference on ipx unload | Problem Details:
Fixes a null pointer dereference when unloading the ipx module.
On initialization of the ipx module, registering certain packet
types can fail. When this happens, unloading the module later
dereferences NULL pointers. This patch fixes that. Please apply.
Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Si... | ```diff
diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c
index 76c661566dfd..89f283c51dff 100644
--- a/net/ipx/af_ipx.c
+++ b/net/ipx/af_ipx.c
@@ -2035,19 +2035,27 @@ static void __exit ipx_proto_finito(void)
ipxitf_cleanup();
- unregister_snap_client(pSNAP_datalink);
- pSNAP_datalink = NULL;
+ if (pSNAP_datalink... |
742433b00b1c53d447a10f215cf887e4cb3406b5 | Analyze and fix the following issue in the Linux kernel code: [PATCH] PA-RISC: Fix bogus warnings from modpost | Problem Details:
parisc and parisc64 seem to name sections a little differently from other
targets. parisc64 gives spurious warnings like:
WARNING: drivers/net/dummy.o - Section mismatch: reference to .init.text:dummy_setup from .data.rel.ro between '.LC1' (at offset 0x0) and '.LC6'
and parisc gives spurious warning... | ```diff
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index ac0a58222992..e26381e3fc00 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -910,7 +910,7 @@ static int init_section_ref_ok(const char *name)
".opd", /* see comment [OPD] at exit_section_ref_ok() */
".toc1", /* used by pp... |
29a1e1d2732c7bfa94465749285aea0f2ed12213 | Analyze and fix the following issue in the Linux kernel code: [PATCH] parisc: fix module_param iommu permission | Problem Details:
Fix/change module_param permissions parameter from an init value
to a permission value.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Matthew Wilcox <willy@debian.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org> | ```diff
diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
index 41abbed51ea7..26fece45e737 100644
--- a/drivers/parisc/sba_iommu.c
+++ b/drivers/parisc/sba_iommu.c
@@ -109,7 +109,7 @@ static unsigned long piranha_bad_128k = 0;
#ifdef SBA_AGP_SUPPORT
static int sba_reserve_agpgart = 1;
-module_par... |
4387ff75f29412a234d394b0276c2b239d3d3844 | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix net/socket.c warnings. | Problem Details:
GCC (correctly) says:
net/socket.c: In function ‘sys_sendto’:
net/socket.c:1510: warning: ‘err’ may be used uninitialized in this function
net/socket.c: In function ‘sys_recvfrom’:
net/socket.c:1571: warning: ‘err’ may be used uninitialized in this function
sock_from_file() either returns filp->priva... | ```diff
diff --git a/net/socket.c b/net/socket.c
index fc74930f1443..5f374e1ff526 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -1514,8 +1514,9 @@ asmlinkage long sys_sendto(int fd, void __user *buff, size_t len,
struct file *sock_file;
sock_file = fget_light(fd, &fput_needed);
+ err = -EBADF;
if (!sock_file)... |
e1fd0586b04d624c597834320d9e57d6f2f4b878 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: x_tables: fix return values for LOG/ULOG | Problem Details:
Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/netfilter/ipt_LOG.c b/net/ipv4/netfilter/ipt_LOG.c
index c96de16fefae..37778c72aeaa 100644
--- a/net/ipv4/netfilter/ipt_LOG.c
+++ b/net/ipv4/netfilter/ipt_LOG.c
@@ -471,8 +471,11 @@ static struct nf_logger ipt_log_logger ={
static int __init ipt_log_init(void)
{
- if (ipt_register_targ... |
bb5aa42734e72b3f02fc0b3cdd6105083f9880f1 | Analyze and fix the following issue in the Linux kernel code: [IRDA]: handle out of memory errors | Problem Details:
This patch checks return value of memory allocation functions
for irda subsystem and fixes memory leaks in error cases.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/irda/irias_object.c b/net/irda/irias_object.c
index b1ee99a59c0c..2a571b43ebec 100644
--- a/net/irda/irias_object.c
+++ b/net/irda/irias_object.c
@@ -91,6 +91,12 @@ struct ias_object *irias_new_object( char *name, int id)
obj->magic = IAS_OBJECT_MAGIC;
obj->name = strndup(name, IAS_MAX_CL... |
22f8cde5bc336fd19603bb8c4572b33d14f14f87 | Analyze and fix the following issue in the Linux kernel code: [NET]: unregister_netdevice as void | Problem Details:
There was no real useful information from the unregister_netdevice() return
code, the only error occurred in a situation that was a driver bug. So
change it to a void function.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 2e37f5012788..1a528548cd1d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -589,7 +589,7 @@ extern int dev_open(struct net_device *dev);
extern int dev_close(struct net_device *dev);
extern int dev_queue_xmit... |
f2f2102d1a1dbc83b5b37b6596cd8374120cbe16 | Analyze and fix the following issue in the Linux kernel code: [XFRM]: Fix missed error setting in xfrm4_policy.c | Problem Details:
When we can't find the afinfo we should return EAFNOSUPPORT.
GCC warned about the uninitialized 'err' for this path as well.
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/xfrm4_policy.c b/net/ipv4/xfrm4_policy.c
index 011136a95809..699f27ce62ad 100644
--- a/net/ipv4/xfrm4_policy.c
+++ b/net/ipv4/xfrm4_policy.c
@@ -175,6 +175,7 @@ __xfrm4_bundle_create(struct xfrm_policy *policy, struct xfrm_state **xfrm, int
afinfo = xfrm_state_get_afinfo(dst_prev->xfrm-... |
0f08461ebf89e10f7db9042fb028359b810c3c81 | Analyze and fix the following issue in the Linux kernel code: [DCCP]: Warning fixes. | Problem Details:
net/dccp/ccids/ccid3.c: In function `ccid3_hc_rx_packet_recv':
net/dccp/ccids/ccid3.c:1007: warning: long int format, different type arg (arg 3)
net/dccp/ccids/ccid3.c:1007: warning: long int format, different type arg (arg 4)
opaque types must be suitably cast for printing.
Signed-off-by: Andrew Mor... | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index 40402c59506a..5c452a3ec4d1 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -479,7 +479,8 @@ static void ccid3_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb)
ccid3_pr_debug("%s(%p), s=%u, w_init=%llu, "
... |
84ff602efba2664762070add0600aa5c870a2659 | Analyze and fix the following issue in the Linux kernel code: [ATM]: Fix for crash in adummy_init() | Problem Details:
This was reported by Ingo Molnar here,
http://lkml.org/lkml/2006/12/18/119
The problem is that adummy_init() depends on atm_init() , but adummy_init()
is called first.
So I put atm_init() into subsys_initcall which seems appropriate, and it
will still get module_init() if it becomes a module.
Inter... | ```diff
diff --git a/net/atm/common.c b/net/atm/common.c
index fbabff494468..a2878e92c3ab 100644
--- a/net/atm/common.c
+++ b/net/atm/common.c
@@ -816,7 +816,8 @@ static void __exit atm_exit(void)
proto_unregister(&vcc_proto);
}
-module_init(atm_init);
+subsys_initcall(atm_init);
+
module_exit(atm_exit);
MODUL... |
ffbc61117d32dc4e768f999325ecfb2528d6b303 | Analyze and fix the following issue in the Linux kernel code: [PACKET]: Fix skb->cb clobbering between aux and sockaddr | Problem Details:
Both aux data and sockaddr tries to use the same buffer which
obviously doesn't work. We just happen to have 4 bytes free in
the skb->cb if you take away the maximum length of sockaddr_ll.
That's just enough to store the one piece of info from aux data
that we can't generate at recvmsg(2) time.
This ... | ```diff
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 8973ea78831e..a6fa48788e8f 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -60,6 +60,7 @@
#include <linux/netdevice.h>
#include <linux/if_packet.h>
#include <linux/wireless.h>
+#include <linux/kernel.h>
#include <linux/km... |
26932566a42d46aee7e5d526cb34fba9380cad10 | Analyze and fix the following issue in the Linux kernel code: [NETLINK]: Don't BUG on undersized allocations | Problem Details:
Currently netlink users BUG when the allocated skb for an event
notification is undersized. While this is certainly a kernel bug,
its not critical and crashing the kernel is too drastic, especially
when considering that these errors have appeared multiple times in
the past and it BUGs even if no listen... | ```diff
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index a9139682c49b..7d68b24b5654 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -45,7 +45,7 @@ static int br_fill_ifinfo(struct sk_buff *skb, const struct net_bridge_port *por
nlh = nlmsg_put(skb, pid, seq, event, sizeof(*... |
91efa462054d44ae52b0c6c8325ed5e899f2cd17 | Analyze and fix the following issue in the Linux kernel code: ieee1394: fix host device registering when nodemgr disabled | Problem Details:
Since my commit 8252bbb1363b7fe963a3eb6f8a36da619a6f5a65 in 2.6.20-rc1,
host devices have a dummy driver attached. Alas the driver was not
registered before use if ieee1394 was loaded with disable_nodemgr=1.
This resulted in non-functional FireWire drivers or kernel lockup.
http://bugzilla.kernel.org... | ```diff
diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c
index 6558c91674fe..ba9faeff4793 100644
--- a/drivers/ieee1394/nodemgr.c
+++ b/drivers/ieee1394/nodemgr.c
@@ -258,7 +258,6 @@ static struct device_driver nodemgr_mid_layer_driver = {
struct device nodemgr_dev_template_host = {
.bus = &ieee... |
a5782010b4e75cba571357efaa27df22a89427c2 | Analyze and fix the following issue in the Linux kernel code: ieee1394: video1394: DMA fix | Problem Details:
This together with the phys_to_virt fix in lib/swiotlb.c::swiotlb_sync_sg
fixes video1394 DMA on machines with DMA bounce buffers, especially Intel
x86-64 machines with > 3GB RAM.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: David Moore <dcm@acm.org>
Tested-by: Nicolas Turr... | ```diff
diff --git a/drivers/ieee1394/video1394.c b/drivers/ieee1394/video1394.c
index 598b19fc5989..f4d1ec00af65 100644
--- a/drivers/ieee1394/video1394.c
+++ b/drivers/ieee1394/video1394.c
@@ -489,6 +489,9 @@ static void wakeup_dma_ir_ctx(unsigned long l)
reset_ir_status(d, i);
d->buffer_status[d->buffer_prg_... |
0fe4c6fcacb28bda75b31f63d3629f640a6b9bf9 | Analyze and fix the following issue in the Linux kernel code: ieee1394: raw1394: prevent unloading of low-level driver | Problem Details:
Unloading the low-level driver module of a FireWire host can lead to
all sorts of trouble if a raw1394 userspace client is using the host.
Just disallow it by incrementing the LLD's module reference count on
a RAW1394_REQ_SET_CARD write operation. Decrement it when the file
is closed.
This feature wo... | ```diff
diff --git a/drivers/ieee1394/raw1394.c b/drivers/ieee1394/raw1394.c
index ad2108f27a04..a77a832828c8 100644
--- a/drivers/ieee1394/raw1394.c
+++ b/drivers/ieee1394/raw1394.c
@@ -636,27 +636,32 @@ static int state_initialized(struct file_info *fi, struct pending_request *req)
case RAW1394_REQ_SET_CARD:
s... |
88e7bf2a4c35d1200c2f72f5cd3d9e72c7f6c890 | Analyze and fix the following issue in the Linux kernel code: ieee1394: dv1394: fix CardBus card ejection | Problem Details:
Fix NULL pointer dereference on hot ejection of a FireWire card while
dv1394 was loaded. http://bugzilla.kernel.org/show_bug.cgi?id=7121
I did not test card ejection with open /dev/dv1394 files yet.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> | ```diff
diff --git a/drivers/ieee1394/dv1394.c b/drivers/ieee1394/dv1394.c
index 1084da4d88a9..d636cfad7fcf 100644
--- a/drivers/ieee1394/dv1394.c
+++ b/drivers/ieee1394/dv1394.c
@@ -2267,11 +2267,7 @@ static void dv1394_remove_host (struct hpsb_host *host)
{
struct video_card *video;
unsigned long flags;
- int id... |
0749aaab4975d741e124c139d40f00853a451f7f | Analyze and fix the following issue in the Linux kernel code: ieee1394: modified csr1212_key_id_type_map to support lisight | Problem Details:
This patch applies a little change in csr1212.c to fix iSight (firewire
digital camera) related issues (but maybe other firewire devices could
also need such modification)
The actual implementation of the "csr1212_key_id_type_map" table doesn't
support some node types used by the iSight for the audio u... | ```diff
diff --git a/drivers/ieee1394/csr1212.c b/drivers/ieee1394/csr1212.c
index 586f71e7346a..889ea0dfe2db 100644
--- a/drivers/ieee1394/csr1212.c
+++ b/drivers/ieee1394/csr1212.c
@@ -47,14 +47,14 @@
#define __D (1 << CSR1212_KV_TYPE_DIRECTORY)
#define __L (1 << CSR1212_KV_TYPE_LEAF)
static const u_int8_t csr1212... |
b892afd1e60132a981b963929e352eabf3306ba2 | Analyze and fix the following issue in the Linux kernel code: kbuild: fix space for good (take 103) | Problem Details:
Michal Ostrowski points out what the real problem was: the spaces at the
start of the definition of the 'checker-shell' make function.
Cc: Michal Ostrowski <mostrows@watson.ibm.com>
Acked-by: David Miller <davem@davemloft.net>
Acked-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Acked-by: Ole... | ```diff
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 8d7eabf238c0..a1880e854dce 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -60,16 +60,15 @@ endef
# Usage: option = $(call checker-shell,$(CC)...-o $$OUT,option-ok,otherwise)
# Exit code chooses option. $$OUT is safe locati... |
3e1a80f11f89f318e892694b501735abb51ef626 | Analyze and fix the following issue in the Linux kernel code: [ARM] 4153/1: fix consistent_sync() off-by-one BUG check | Problem Details:
In consistent_sync(), start + size can end up pointing one byte
beyond the end of the direct RAM mapping. We shouldn't BUG() when
this happens.
Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/mm/consistent.c b/arch/arm/mm/consistent.c
index 166aee13c4b1..1f9f94f9af4b 100644
--- a/arch/arm/mm/consistent.c
+++ b/arch/arm/mm/consistent.c
@@ -485,7 +485,7 @@ void consistent_sync(const void *start, size_t size, int direction)
{
const void *end = start + size;
- BUG_ON(!virt_add... |
108d093fdd75643dfc8c327f38125f4da76771e7 | Analyze and fix the following issue in the Linux kernel code: [ARM] 4152/1: Add PXA SSP audio register defs and fixups | Problem Details:
This patchs adds some missing register bit defs for the PXA SSP ports audio registers and fixes up some other broken bit definitions as noticed by Russell.
Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/include/asm-arm/arch-pxa/pxa-regs.h b/include/asm-arm/arch-pxa/pxa-regs.h
index e24f6b6c79ae..20576d10b3ec 100644
--- a/include/asm-arm/arch-pxa/pxa-regs.h
+++ b/include/asm-arm/arch-pxa/pxa-regs.h
@@ -474,8 +474,8 @@
#define SADIV __REG(0x40400060) /* Audio Clock Divider Register. */
#define S... |
3392b309dbd1f1f37454c412c2045448300cf374 | Analyze and fix the following issue in the Linux kernel code: [ARM] 4149/1: AT91: Overrun in SAM9 gettimeoffset(). | Problem Details:
Fix an overrun in the AT91SAM9 gettimeoffset() function. This causes
the time value returned by gettimeofday() to jump "backwards".
Original patch from Michel Benoit.
Signed-off-by: Andrew Victor <andrew@sanpeople.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/mach-at91/at91sam926x_time.c b/arch/arm/mach-at91/at91sam926x_time.c
index 59cbbe1e8161..a4dded27fa16 100644
--- a/arch/arm/mach-at91/at91sam926x_time.c
+++ b/arch/arm/mach-at91/at91sam926x_time.c
@@ -30,7 +30,6 @@
* Returns number of microseconds since last timer interrupt. Note that i... |
d0760b3bc8ff9b34e3e2e166e2102548a24751b4 | Analyze and fix the following issue in the Linux kernel code: [ARM] 4143/1: AT91: Prepare for AT91SAM9263 support | Problem Details:
The Atmel AT91SAM9263 processor includes many more integrated
peripherals than Atmel's previous ARM9-based AT91 processors, so this
has necessitated a few changes to the core AT91 support.
These changes are:
* The system peripheral I/O region we remap has increased from
0xFFFA0000..0xFFF... | ```diff
diff --git a/arch/arm/mach-at91/at91rm9200_devices.c b/arch/arm/mach-at91/at91rm9200_devices.c
index a06498ccc826..077c81f9bc56 100644
--- a/arch/arm/mach-at91/at91rm9200_devices.c
+++ b/arch/arm/mach-at91/at91rm9200_devices.c
@@ -315,7 +315,7 @@ static struct platform_device at91rm9200_mmc_device = {
.num_re... |
a93d48cc6019f84394b31d10c0d830a3b71696be | Analyze and fix the following issue in the Linux kernel code: [ARM] 4119/1: AT91: Fix build of AT91SAM9260 | Problem Details:
Fix build failure of AT91SAM9260.
The AT91RM9200 ethernet driver (at91_ether.c) stores platform data in a
"struct at91_eth_data" structure, but the AT91SAM9260 (and AT91SAM9263)
ethernet driver (macb.c) [developed on the AVR32 architecture] expects a
"struct eth_platform_data".
Since the platform dat... | ```diff
diff --git a/arch/arm/mach-at91rm9200/at91sam9260_devices.c b/arch/arm/mach-at91rm9200/at91sam9260_devices.c
index f42d3a40ec3c..f338f78eb943 100644
--- a/arch/arm/mach-at91rm9200/at91sam9260_devices.c
+++ b/arch/arm/mach-at91rm9200/at91sam9260_devices.c
@@ -128,7 +128,7 @@ void __init at91_add_device_udc(struc... |
850b42933e70c19c7765dd7fad15cb7ad3955b65 | Analyze and fix the following issue in the Linux kernel code: [ARM] 4123/1: xsc3: general cleanup | Problem Details:
This patch cleans up proc-xsc3:
- Correct a number of typos.
- Fix up indentation in a number of places.
- Change references to the various caches to be more clear about
whether we're talking about the L1 D, the L1 I or the unified L2
cache.
- Rename "drain write buffer" to "data write barrier", th... | ```diff
diff --git a/arch/arm/mm/proc-xsc3.S b/arch/arm/mm/proc-xsc3.S
index 94a58455f346..d95921a2ab99 100644
--- a/arch/arm/mm/proc-xsc3.S
+++ b/arch/arm/mm/proc-xsc3.S
@@ -5,23 +5,23 @@
* Current Maintainer: Lennert Buytenhek <buytenh@wantstofly.org>
*
* Copyright 2004 (C) Intel Corp.
- * Copyright 2005 (c) Mo... |
a7b4e5506d1608112a208bc5391377d2c0b6dd80 | Analyze and fix the following issue in the Linux kernel code: [ARM] 4144/1: Fix for patch #4099/1 with CONFIG_I2C_PXA_SLAVE set | Problem Details:
Switch the i2c-pxa driver to actually using the platform device information and let it handle the power i2c bus on pxa27x too. Original version of this patch didn't compile with CONFIG_I2C_PXA_SLAVE set.
Signed-off-by: G. Liakhovetski <gl@dsa-ac.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.or... | ```diff
diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c
index 9de1278d234f..390524c4710f 100644
--- a/arch/arm/mach-pxa/generic.c
+++ b/arch/arm/mach-pxa/generic.c
@@ -338,6 +338,27 @@ static struct platform_device i2c_device = {
.num_resources = ARRAY_SIZE(i2c_resources),
};
+#ifdef CONFIG_... |
1ed2ddf380e19dafeec2150ca709ef7f4a67cd21 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] windfarm: don't die on suspend thread signal | Problem Details:
When the windfarm thread gets a suspend signal it will die instead of
freezing. This fixes it.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c
index e947af982f93..94c117ef20c1 100644
--- a/drivers/macintosh/windfarm_core.c
+++ b/drivers/macintosh/windfarm_core.c
@@ -94,8 +94,6 @@ static int wf_thread_func(void *data)
DBG("wf: thread started\n");
while(!kthread_sho... |
92d4dda3332577bc2228b8d436f3d2796c59a520 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix comment in kernel/irq.c | Problem Details:
kernel/irq.c contains a comment that speaks of -1 and -2 as interrupt
numbers, but this is actually dependent on configuration options now.
Replace by NO_IRQ and NO_IRQ_ENABLED.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by... | ```diff
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index 34dc37e0e369..919fbf568495 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -281,10 +281,10 @@ void do_IRQ(struct pt_regs *regs)
/*
* Every platform is required to implement ppc_md.get_irq.
- * This functio... |
f31909c00332b3e8299209eaba6cec80756f802c | Analyze and fix the following issue in the Linux kernel code: [POWERPC] ppc: Fix booke watchdog initialization | Problem Details:
Fix two problems in the book-e watchdog driver.
a) The 4xx default period was defined wrong
b) Clear status before enabling the watchdog exception
Signed-off-by: Stefan Roese <sr@denx.de>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/drivers/char/watchdog/booke_wdt.c b/drivers/char/watchdog/booke_wdt.c
index 488902231cc2..0e23f29f71ab 100644
--- a/drivers/char/watchdog/booke_wdt.c
+++ b/drivers/char/watchdog/booke_wdt.c
@@ -35,7 +35,7 @@
#ifdef CONFIG_FSL_BOOKE
#define WDT_PERIOD_DEFAULT 63 /* Ex. wdt_period=28 bus=333Mhz , r... |
0524aad7b89671bc788d483b2c048ac7b79eefb9 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix ppc64's writing to struct file_operations | Problem Details:
In preparation for marking file_operations as const.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paul Mackerras <pau... | ```diff
diff --git a/arch/powerpc/kernel/lparcfg.c b/arch/powerpc/kernel/lparcfg.c
index 41c05dcd68f4..0de5a08cf9b0 100644
--- a/arch/powerpc/kernel/lparcfg.c
+++ b/arch/powerpc/kernel/lparcfg.c
@@ -439,6 +439,10 @@ static ssize_t lparcfg_write(struct file *file, const char __user * buf,
ssize_t retval = -ENOMEM;
... |
1d58420bad15d08f93bf1e0342c1b1d1234d69b7 | Analyze and fix the following issue in the Linux kernel code: drm: update core memory manager from git drm tree | Problem Details:
Remove the memory manager parameter from the put_block function, as this
makes the client code a lot cleaner. Prepare buffer manager for lock and
unlock calls.
Fix buggy aligned allocations.
Remove the stupid root_node field from the core memory manager.
Support multi-page buffer offset alignments
Add ... | ```diff
diff --git a/drivers/char/drm/drmP.h b/drivers/char/drm/drmP.h
index 63042ca9fffe..85d99e21e188 100644
--- a/drivers/char/drm/drmP.h
+++ b/drivers/char/drm/drmP.h
@@ -532,11 +532,13 @@ typedef struct drm_mm_node {
int free;
unsigned long start;
unsigned long size;
+ struct drm_mm *mm;
void *private;
} ... |
14719f325e1cd4ff757587e9a221ebaf394563ee | Analyze and fix the following issue in the Linux kernel code: Revert "PCI: remove duplicate device id from ata_piix" | Problem Details:
This reverts commit b11056355ea149c37edf0ef54976a49f5258cd54.
It was incorrect, the proper fix is coming through the SATA tree, sorry
about that.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 267241a59080..47701b286f8b 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -191,8 +191,12 @@ static const struct pci_device_id piix_pci_tbl[] = {
/* Intel ICH4 (i845GV, i845E, i852, i855) UDMA 100 */
{ 0x8086, 0x24CA, PCI... |
b02a92586dca362b0b76ad527b91bd44ce58ece5 | Analyze and fix the following issue in the Linux kernel code: sky2: use dev_err for error reports | Problem Details:
Use the standard dev_xxx functions instead of printk directly for
error reports. Fix a bug where the initialization would return 0
if allocation of network device failed.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index f4c0bc19b005..5abcf853e98b 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -2266,8 +2266,8 @@ static void sky2_hw_intr(struct sky2_hw *hw)
pci_err = sky2_pci_read16(hw, PCI_STATUS);
if (net_ratelimit())
- printk(KERN_ERR PFX "%s: p... |
866a8c87c4e51046602387953bbef76992107bcb | Analyze and fix the following issue in the Linux kernel code: msi: Fix msi_remove_pci_irq_vectors. | Problem Details:
Since msi_remove_pci_irq_vectors is designed to be called during
hotplug remove it is actively wrong to query the hardware and expect
meaningful results back.
To that end remove the pci_find_capability calls. Testing
dev->msi_enabled and dev->msix_enabled gives us all of the information
we need.
Sig... | ```diff
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0df626cf47d8..529113dc3e22 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -854,13 +854,10 @@ void pci_disable_msix(struct pci_dev* dev)
**/
void msi_remove_pci_irq_vectors(struct pci_dev* dev)
{
- int pos;
-
if (!pci_msi_enable || !dev)
... |
88187dfa4d8bb565df762f272511d2c91e427e0d | Analyze and fix the following issue in the Linux kernel code: MSI: Replace pci_msi_quirk with calls to pci_no_msi() | Problem Details:
I don't see any reason why we need pci_msi_quirk, quirk code can just
call pci_no_msi() instead.
Remove the check of pci_msi_quirk in msi_init(). This is safe as all
calls to msi_init() are protected by calls to pci_msi_supported(),
which checks pci_msi_enable, which is disabled by pci_no_msi().
The ... | ```diff
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index ee7b75b976b5..0420697c4293 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -5954,8 +5954,7 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
* responding after a while.
*
* AMD believes this incompatibility is unique ... |
c54c18790700b8b2a503945d729aa425c25691fe | Analyze and fix the following issue in the Linux kernel code: PCI: cleanup MSI code | Problem Details:
Cleanup MSI code as follows:
- fix some types
- fix strange local variable definition
- delete unnecessary blank line
- add comment to #endif which is far from corresponding #ifdef
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index ed3f7e1a563c..e87e8efb9bb4 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -49,8 +49,8 @@ static void msi_set_mask_bit(unsigned int irq, int flag)
switch (entry->msi_attrib.type) {
case PCI_CAP_ID_MSI:
if (entry->msi_attrib.maskbit) {
- ... |
15a260d53f7ca026e45109d2c2bec8c4b087780b | Analyze and fix the following issue in the Linux kernel code: PCI Quirk: 1k I/O space IOBL_ADR fix on P64H2 | Problem Details:
There's an existing quirk for the kernel to use 1k IO space granularity
on the Intel P64H2. It turns out however that pci_setup_bridge() in
drivers/pci/setup-bus.c reads in the IO base and limit address register
masks it off to the nearest 4k, and writes it back. This causes the
kernel to be on 1k bo... | ```diff
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 1d04ca02dd0f..47214fdfa6c8 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1670,6 +1670,31 @@ static void __devinit quirk_p64h2_1k_io(struct pci_dev *dev)
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x1460, quirk_p64h2_1k_io)... |
262303fe329a51463925f3749aafc358a4201397 | Analyze and fix the following issue in the Linux kernel code: pciehp: fix wait command completion | Problem Details:
This patch fixes this problem that pciehp driver will sleep
unnecessarily long when waiting for command completion. With this
patch, modprobe pciehp driver becomes very faster as follows for
instance.
o Without this patch
# time /sbin/modprobe pciehp
real 0m4.976s
user 0m0.000s
... | ```diff
diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
index 17167d594472..927dba9911ed 100644
--- a/drivers/pci/hotplug/pciehp.h
+++ b/drivers/pci/hotplug/pciehp.h
@@ -100,6 +100,7 @@ struct controller {
u16 vendor_id;
u8 cap_base;
struct timer_list poll_timer;
+ volatile int cmd_busy;
... |
429538ad3eeffec4199d8adddd1e9e4c80b2c08b | Analyze and fix the following issue in the Linux kernel code: PCI: mark pci_find_device() as __deprecated | Problem Details:
On Fri, Nov 17, 2006 at 09:32:36AM -0500, Alan Cox wrote:
>
> Soon we should deprecate pci_find_device as well
So let's mark it as __deprecated now, which also has the side effect
that noone can later whine that removing it might break some shiny
external modules.
Oh, and if anything starts compla... | ```diff
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 23d2a37f3c9f..cf2c8a35a1df 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -468,7 +468,7 @@ extern void pci_sort_breadthfirst(void);
/* Generic PCI functions exported to card drivers */
-struct pci_dev *pci_find_device (unsigned int... |
dde6d43d060bf0e0f38c66f76908e460db3bf0d8 | Analyze and fix the following issue in the Linux kernel code: fix unaligned exception in /drivers/net/wireless/orinoco.c | Problem Details:
Prevent an unaligned exception to occur. (GCC 4.1) tmp is defined as char
pointer while it is later accessed as short.
Cc: Jean Tourrilhes <jt@hpl.hp.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-of... | ```diff
diff --git a/drivers/net/wireless/orinoco.c b/drivers/net/wireless/orinoco.c
index 936c888e03e1..2a65bb93de26 100644
--- a/drivers/net/wireless/orinoco.c
+++ b/drivers/net/wireless/orinoco.c
@@ -2059,7 +2059,7 @@ static int determine_firmware(struct net_device *dev)
int err;
struct comp_id nic_id, sta_id;
... |
45d3ac4ec31ccf9a39065e8576260c6ac2652c83 | Analyze and fix the following issue in the Linux kernel code: z85230: spinlock logic | Problem Details:
At some point someone added a spin_lock(&dev->lock) to the IRQ handler for
the Z85230 driver. This actually correctly fixes a bug but the necessary
changes to remove the chan->lock calls in the event handlers were not made
(c->lock is the same lock).
Simona Dascenzo reported the problem with the driv... | ```diff
diff --git a/drivers/net/wan/z85230.c b/drivers/net/wan/z85230.c
index 59ddd21c3958..8dbcf83bb5f3 100644
--- a/drivers/net/wan/z85230.c
+++ b/drivers/net/wan/z85230.c
@@ -331,8 +331,7 @@ static void z8530_rtsdtr(struct z8530_channel *c, int set)
static void z8530_rx(struct z8530_channel *c)
{
u8 ch,stat;
- ... |
9251644ab33579d80c038b077f78daa23a04fdcd | Analyze and fix the following issue in the Linux kernel code: usbcore: trivial whitespace fixes | Problem Details:
This patch (as844) makes some trivial whitespace fixes to a few files
in usbcore. Oliver did most of the work and Alan added some tidying up.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
index 55d8f575206d..4eaa0ee8e72f 100644
--- a/drivers/usb/core/sysfs.c
+++ b/drivers/usb/core/sysfs.c
@@ -16,16 +16,16 @@
/* Active configuration fields */
#define usb_actconfig_show(field, multiplier, format_string) \
-static ssize_t show_#... |
629e4427aa817d5c9f11885420abf54b8f5967dc | Analyze and fix the following issue in the Linux kernel code: EHCI: fix interrupt-driven remote wakeup | Problem Details:
Now that port status change notifications are interrupt-driven,
ehci-hcd needs to tell usbcore when a remote-wakeup resume operation
is finished -- we can no longer rely on the core to poll and find
out. This patch (as843) uses the root-hub status timer to force a
poll after the resume is complete.
T... | ```diff
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index 3cfba69e0767..0d83c6df1a3b 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -379,8 +379,8 @@ ehci_hub_status_data (struct usb_hcd *hcd, char *buf)
ehci->reset_done [i] = 0;
if ((temp & mask) != 0
... |
49631ca7f3e2fd05186028b453fa27f75b830de7 | Analyze and fix the following issue in the Linux kernel code: USB: gadgetfs AIO tweaks | Problem Details:
This patch (as837) fixes several mistakes in the AIO interface of the
gadgetfs driver:
The ki_retry method is not supposed to do a put on the kiocb.
The extra call to aio_put_req() causes memory corruption.
(Note: This call was removed before, by patch as691, and then
mysteriously re-introduced la... | ```diff
diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c
index 1c5e1ee7e36b..34296e79edcf 100644
--- a/drivers/usb/gadget/inode.c
+++ b/drivers/usb/gadget/inode.c
@@ -576,7 +576,6 @@ static ssize_t ep_aio_read_retry(struct kiocb *iocb)
}
kfree(priv->buf);
kfree(priv);
- aio_put_req(iocb);
re... |
ce46794f77f698eaf3b80922fafac5a9379085e0 | Analyze and fix the following issue in the Linux kernel code: USB: gadgetfs behaves better on userspace init bug | Problem Details:
Resolve an initizlization issue that could come up if the userspace
driver wrote invalid descriptors to a dual-speed device.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c
index e5ce4f0bb7cc..1c5e1ee7e36b 100644
--- a/drivers/usb/gadget/inode.c
+++ b/drivers/usb/gadget/inode.c
@@ -1392,17 +1392,17 @@ gadgetfs_setup (struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl)
spin_lock (&dev->lock);
dev->s... |
5b89db02a5a7c8bad3c6fb7888778082a441b385 | Analyze and fix the following issue in the Linux kernel code: USB: gadgetfs race fix | Problem Details:
This resolves a race in gadgetfs associated with changing device/ep0
when processing control requests. The fix is to change that state
earlier, when the control response is issued, so there's no window
in which userspace could see the wrong state; and enlarge the scope
of the spinlock during the ep0 r... | ```diff
diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c
index ea8e3160d05e..e5ce4f0bb7cc 100644
--- a/drivers/usb/gadget/inode.c
+++ b/drivers/usb/gadget/inode.c
@@ -933,28 +933,24 @@ static void clean_req (struct usb_ep *ep, struct usb_request *req)
static void ep0_complete (struct usb_ep *ep, st... |
0864c7a9286b02319d3db2103bada1c2269c1e1e | Analyze and fix the following issue in the Linux kernel code: USB: gadgetfs simplifications | Problem Details:
This simplifies event reading by eliminating arithmetic and being
more direct/obvious, and tweaks some debug messages slightly.
The math elimination will change timings, sometimes enough to
allow a race to appear.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroa... | ```diff
diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c
index cbdcb3c10c5e..ea8e3160d05e 100644
--- a/drivers/usb/gadget/inode.c
+++ b/drivers/usb/gadget/inode.c
@@ -1062,39 +1062,36 @@ scan:
/* return queued events right away */
if (dev->ev_next != 0) {
unsigned i, n;
- int tmp = dev->e... |
3ff4fd94c86259e44d58946af34231a1586b5d93 | Analyze and fix the following issue in the Linux kernel code: USB: race fixes for usb-serial, step 3 | Problem Details:
- fix an error code returned if a device has been disconnected
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 685fb69bcc32..6bf22a28adb8 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -281,7 +281,7 @@ static void serial_close(struct tty_struct *tty, struct file * filp)
static int serial_write (st... |
4b10f0f3a0d4caa8b615cd1f770a70912967a3cd | Analyze and fix the following issue in the Linux kernel code: USB: race fixes for usb-serial, step 2 | Problem Details:
- take BKL before looking up a driver to associate with a device to make
sure the module is not unloaded after looking up but before association
& bumping module count
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 3780362eb9f0..685fb69bcc32 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -685,14 +685,17 @@ int usb_serial_probe(struct usb_interface *interface,
int num_ports = 0;
int max_endpoints;... |
34ef50e5b1f96c2d8c0f3d28b7d407743806256c | Analyze and fix the following issue in the Linux kernel code: USB: race fixes for usb-serial step 1 | Problem Details:
- introduce a spinlock for serial_table to eliminate the window between
looking up a device and getting a reference
- delay inscription of a new device into serial_table until it is fully
initialised
- make sure disconnect() kills all URBs to avoid leckage across a soft unbind
Signed-off-by: Oliv... | ```diff
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 90beb5c50e59..3780362eb9f0 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -59,14 +59,19 @@ static struct usb_driver usb_serial_driver = {
static int debug;
static struct usb_serial *se... |
fdcba53e2d58272bcdb5f1fad694602ccf02ad46 | Analyze and fix the following issue in the Linux kernel code: fix for bugzilla #7544 (keyspan USB-to-serial converter) | Problem Details:
At least the Keyspan USA-19HS USB-to-serial converter supports
two different configurations, one where the input endpoints
have interrupt transfer type and one where they are bulk endpoints.
The default UHCI configuration uses the interrupt input endpoints.
The keyspan driver, OTOH, assumes that the de... | ```diff
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 9d2fdfd6865f..e6966f12ed5a 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -1275,11 +1275,31 @@ static int keyspan_fake_startup (struct usb_serial *serial)
}
/* Helper functions used by keyspan_set... |
66e56ce75e39210415fb12ceacd5f3580ad72d50 | Analyze and fix the following issue in the Linux kernel code: USB: at91_udc wakeup event updates | Problem Details:
This updates the AT91 UDC driver's handling of wakeup events:
- Fix a bug in the original scheme, which was never updated after
the {enable,disable}_irq_wake() semantics were updated to address
refcounting issues (i.e. behave for shared irqs).
- Couple handling of both type of wakeup events, ... | ```diff
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 5a72743606fd..f39050145f1f 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -1807,16 +1807,13 @@ static int at91udc_suspend(struct platform_device *pdev, pm_message_t mesg)
|| !wake
|| at91_... |
3ca2a3211ee5078d49b04fe7149ff2a76473be51 | Analyze and fix the following issue in the Linux kernel code: UHCI: fix bandwidth allocation | Problem Details:
This patch (as840) fixes the bandwidth allocation mechanism in
uhci-hcd. It has never worked correctly.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c
index 3fbb5ba80249..5d6c06bc4524 100644
--- a/drivers/usb/host/uhci-debug.c
+++ b/drivers/usb/host/uhci-debug.c
@@ -168,9 +168,13 @@ static int uhci_show_qh(struct uhci_qh *qh, char *buf, int len, int space)
space, "", qh, qtype,
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.